Re: installed header includes

[David Faure]

On Monday 09 September 2013 16:03:38 Jeremy Whiting wrote:
> Hello,
> 
> Apparently my commit to knewstuff broke the build. The problem is that
> knewstuff/src/knewstuffbutton.h includes  which
> hasn't been installed yet when building kdelibs.  I looked around and
> saw some other frameworks install headers install directly into
> include (kauth.h includes "kauthaction.h", both of which are in
> /usr/local/include here) I don't think knewstuff3/entry.h should go
> directly into includes though. I also saw solid which installs headers
> into includes/solid has it's headers in solid/src/solid that way
> #include  works in sources.
> 
> Which is the preferred way to fix this? I can move
> knewstuff/src/*.cpp|h into knewstuff/src/knewstuff3/ so it will work
> in source tree and in installed locations I guess, is that the "right"
> way to do this sort of thing?

No, generate local forwarding headers, see what I did in staging/kio/src/

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112571: enable clearButton in kpassworddialog

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112571/
---

(Updated Sept. 10, 2013, 8:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

enable clearButton in kpassworddialog


Diffs
-

  tier1/kwidgetsaddons/src/kpassworddialog.cpp dfab3e9 
  tier1/kwidgetsaddons/src/kpassworddialog.ui e007454 

Diff: http://git.reviewboard.kde.org/r/112571/diff/


Testing
---

manually tested kpassworddialog and clear icon appears


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112557: Remove all links to libkdeqt5staging

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112557/
---

(Updated Sept. 10, 2013, 8:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Remove all links to libkdeqt5staging. QCommandLineParser is in qt5 now.

NOTE: Fist qt5.git must be updated


Diffs
-

  CMakeLists.txt 5a6ad45 
  kded/CMakeLists.txt 6431710 
  kdewidgets/CMakeLists.txt 038da6b 
  kio/misc/ksendbugmail/CMakeLists.txt cbe4bd9 
  kio/tests/CMakeLists.txt 825ca3c 
  kioslave/http/CMakeLists.txt 9c35586 
  kioslave/http/kcookiejar/CMakeLists.txt fcb620e 
  kross/console/CMakeLists.txt 58257ca 
  kross/qts/CMakeLists.txt 69c951b 
  kross/test/CMakeLists.txt 7d0c5b0 
  staging/kdoctools/src/CMakeLists.txt 72bb06e 
  staging/kio/src/widgets/CMakeLists.txt 67adcf9 
  staging/knotifications/tests/CMakeLists.txt fa93a01 
  staging/kservice/src/desktoptojson/CMakeLists.txt 1c2fd40 
  tier1/kconfig/src/kconf_update/CMakeLists.txt 08a3771 

Diff: http://git.reviewboard.kde.org/r/112557/diff/


Testing
---

it builds and tests looks OK


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112571: enable clearButton in kpassworddialog

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112571/#review39694
---


This review has been submitted with commit 
3c1014192bfc7d327a65cbcd4f5511c6a65068a2 by Wojciech Kapuscinski to branch 
frameworks.

- Commit Hook


On Sept. 6, 2013, 7:01 p.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112571/
> ---
> 
> (Updated Sept. 6, 2013, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> enable clearButton in kpassworddialog
> 
> 
> Diffs
> -
> 
>   tier1/kwidgetsaddons/src/kpassworddialog.cpp dfab3e9 
>   tier1/kwidgetsaddons/src/kpassworddialog.ui e007454 
> 
> Diff: http://git.reviewboard.kde.org/r/112571/diff/
> 
> 
> Testing
> ---
> 
> manually tested kpassworddialog and clear icon appears
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112557: Remove all links to libkdeqt5staging

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112557/#review39693
---


This review has been submitted with commit 
a5bd21c7a7416508af9d8ca2c1800935be46084f by Wojciech Kapuscinski to branch 
frameworks.

- Commit Hook


On Sept. 6, 2013, 1:54 p.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112557/
> ---
> 
> (Updated Sept. 6, 2013, 1:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Remove all links to libkdeqt5staging. QCommandLineParser is in qt5 now.
> 
> NOTE: Fist qt5.git must be updated
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 5a6ad45 
>   kded/CMakeLists.txt 6431710 
>   kdewidgets/CMakeLists.txt 038da6b 
>   kio/misc/ksendbugmail/CMakeLists.txt cbe4bd9 
>   kio/tests/CMakeLists.txt 825ca3c 
>   kioslave/http/CMakeLists.txt 9c35586 
>   kioslave/http/kcookiejar/CMakeLists.txt fcb620e 
>   kross/console/CMakeLists.txt 58257ca 
>   kross/qts/CMakeLists.txt 69c951b 
>   kross/test/CMakeLists.txt 7d0c5b0 
>   staging/kdoctools/src/CMakeLists.txt 72bb06e 
>   staging/kio/src/widgets/CMakeLists.txt 67adcf9 
>   staging/knotifications/tests/CMakeLists.txt fa93a01 
>   staging/kservice/src/desktoptojson/CMakeLists.txt 1c2fd40 
>   tier1/kconfig/src/kconf_update/CMakeLists.txt 08a3771 
> 
> Diff: http://git.reviewboard.kde.org/r/112557/diff/
> 
> 
> Testing
> ---
> 
> it builds and tests looks OK
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #699

[KDE CI System]

See 

Changes:

[wojtask9.kde] remove all links to kdeqt5staging

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson2193205909546483058.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   7cabdaa..ea835cc  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@2d43b0fe:LinuxSlave - 3
Using strategy: Default
Last Built Revision: Revision 97ce3dc808ca616445d8f389b9a00d58e518494b 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision ea835ccdb135e8b518d8de1507a4e0326efd650d 
(refs/heads/jenkins)
Checking out Revision ea835ccdb135e8b518d8de1507a4e0326efd650d 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1541040034197943649.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 libstreamanalyzer - Branch master
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreams - Branch master
 attica - Branch master
 strigidaemon - Branch master
 extra-cmake-modules - Branch master
 kdelibs - Branch frameworks

== Cleaning Source Tree

HEAD is now at ea835cc remove all links to kdeqt5staging
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJ

Re: Plugin locator performance ballpark

[David Faure]

On Monday 09 September 2013 17:10:25 Martin Graesslin wrote:
> On Monday 09 September 2013 16:48:05 David Faure wrote:
> > On Monday 09 September 2013 14:23:10 Sebastian Kügler wrote:
> > > Martin Grässlin asked if we could offer an async API for this. Opinions?
> > 
> > This task is mostly I/O, and a bit of CPU.
> > Portable async I/O requires doing it in a thread.
> > To avoid setting up a thread every time, this could use QThreadPool (but a
> > dedicated one, to avoid blocking the main one which is supposed to be
> > about
> > pure-CPU operations only), and the runnable would call the sync trader
> > API.
> > 
> > So, it's feasible.
> > But is it worth it?
> 
> Just adding the reasoning why I suggested it. We tried (in KWin) to move all
> the querying to a thread. It utterly failed due to KGlobal not being thread
> safe. The code is still there, so I will probably switch with frameworks 5.
> 
> In KWin all the plugin loading is during start up, but none of them is
> essential. By making it async we can significantly improve the startup time
> - that is the time till the first frame is rendered and the splash screen
> unfreezes.

Ah, but you say "plugin loading", not just "locating plugins" (which was what 
my previous email was about).

Surely loading (which means creating the objects in the plugin) in a secondary 
thread requires a lot of extra care. The plugin authors won't expect that, 
they'll create QObjects, which will then live in the wrong thread -- or there 
will be races with the init in the main thread...

> Finding a large number of plugins at startup is - I assume - relevant to
> many applications, for example Plasma. If we have the API in a way that it
> makes async usage easy I think it would help a lot and sync usage is still
> possible: .waitForFinished().

If the app wants to actually load plugins in a thread, it needs to manage that 
thread. It's not just a one-time task with a result, like locating plugins and 
returning a QStringList or so. It's now a longer-living thread, with 
synchronization issues.
These large apps can do the plugin loading in a thread, but they'll have to 
handle the synchronization issues. I don't see a way to encapsulate all of it, 
it sounds rather dangerous (apps will not use proper synchronization then).
The difference with KDE4 is that there's no KGlobal anymore :) So now what you 
tried should be possible.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112633: Modify KTextWidgets CMakeLists.txt for splitting

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112633/
---

Review request for KDE Frameworks.


Description
---

Adds dependencies to installed cmake file and splits qt version to separate 
variable


Diffs
-

  staging/ktextwidgets/CMakeLists.txt 0819c2d 
  staging/ktextwidgets/KTextWidgetsConfig.cmake.in 9f46933 

Diff: http://git.reviewboard.kde.org/r/112633/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #700

[KDE CI System]

See 

Changes:

[notmart] documentation++

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson6452524032146522113.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   45879b3..27c9c85  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@35d60412:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision ea835ccdb135e8b518d8de1507a4e0326efd650d 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 27c9c859ef87a29b9366436574480fb3ad2050c7 
(refs/heads/jenkins)
Checking out Revision 27c9c859ef87a29b9366436574480fb3ad2050c7 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1758520296548625557.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at 27c9c85 documentation++
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSConfig.cmake
-- KF5[KWallet]: Loaded

Re: Review Request 112633: Modify KTextWidgets CMakeLists.txt for splitting

[Stephen Kelly]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112633/#review39708
---

Ship it!


Ship It!

- Stephen Kelly


On Sept. 10, 2013, 9:35 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112633/
> ---
> 
> (Updated Sept. 10, 2013, 9:35 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Adds dependencies to installed cmake file and splits qt version to separate 
> variable
> 
> 
> Diffs
> -
> 
>   staging/ktextwidgets/CMakeLists.txt 0819c2d 
>   staging/ktextwidgets/KTextWidgetsConfig.cmake.in 9f46933 
> 
> Diff: http://git.reviewboard.kde.org/r/112633/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

[David Faure]

> On Sept. 8, 2013, 9:24 a.m., David Faure wrote:
> > kinit/CMakeLists.txt, line 44
> > 
> >
> > This could also be moved out of the if, by using the proper arguments 
> > for ecm_mark_nongui_executable, so that it doesn't disable the mac bundle.
> 
> Aleix Pol Gonzalez wrote:
> The macro doesn't have such an argument...

Ah I see. Reading the definition of the macro, it seems you can just do

set_target_properties(target PROPERTIES WIN32_EXECUTABLE FALSE)

to make it a console app on windows, and leave the bundle on mac.
This would be simpler I think.


- David


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112570/#review39569
---


On Sept. 9, 2013, 4:49 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112570/
> ---
> 
> (Updated Sept. 9, 2013, 4:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> kde4_add_executable is deprecated. Port all kde4_add_executable uses to 
> add_executable.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html b3329d6 
>   experimental/kdeclarative/CMakeLists.txt a7bddfa 
>   interfaces/terminal/example/CMakeLists.txt e8c3f01 
>   kdesu/CMakeLists.txt 351ad85 
>   kdewidgets/CMakeLists.txt 038da6b 
>   khtml/CMakeLists.txt 124c3eb 
>   kinit/CMakeLists.txt ff7b7fd 
>   kio/misc/CMakeLists.txt e2c62d6 
>   kio/misc/kpac/CMakeLists.txt 04ffba1 
>   kio/misc/ksendbugmail/CMakeLists.txt cbe4bd9 
>   kio/tests/CMakeLists.txt 825ca3c 
>   kioslave/http/kcookiejar/CMakeLists.txt fcb620e 
>   kjsembed/examples/kjsconsole/CMakeLists.txt 2438323 
>   kjsembed/kjscmd/CMakeLists.txt f457933 
>   knotify/tests/CMakeLists.txt bc6f5e0 
>   kparts/tests/CMakeLists.txt bb8a120 
>   kpty/CMakeLists.txt 2cc2885 
>   kross/console/CMakeLists.txt 58257ca 
>   staging/kde4support/CMakeLists.txt 0445f0a 
>   staging/kde4support/src/CMakeLists.txt 6f4603d 
>   staging/kemoticons/tests/CMakeLists.txt 5e0d46e 
> 
> Diff: http://git.reviewboard.kde.org/r/112570/diff/
> 
> 
> Testing
> ---
> 
> Builds, although it doesn't change much in linux.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #701

[KDE CI System]

See 

Changes:

[notmart] remove unused method

[notmart] more documentation

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson5532449426283063845.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   ea835cc..075395e  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@2d43b0fe:LinuxSlave - 3
Using strategy: Default
Last Built Revision: Revision 27c9c859ef87a29b9366436574480fb3ad2050c7 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 075395e6d12e892d5f9204de865d7ab09df084ff 
(refs/heads/jenkins)
Checking out Revision 075395e6d12e892d5f9204de865d7ab09df084ff 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson33537969787081030.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 libstreamanalyzer - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at 075395e more documentation
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJS

Build failed in Jenkins: plasma-framework_master_qt5 #702

[KDE CI System]

See 

Changes:

[notmart] add kdeqt5staging dependency

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1882990569506878322.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   075395e..6c27cc0  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@2d43b0fe:LinuxSlave - 3
Using strategy: Default
Last Built Revision: Revision 075395e6d12e892d5f9204de865d7ab09df084ff 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 6c27cc0963f7ebfadd4a14ed09a63b055d74b753 
(refs/heads/jenkins)
Checking out Revision 6c27cc0963f7ebfadd4a14ed09a63b055d74b753 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7303902582808619598.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreams - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at 6c27cc0 add kdeqt5staging dependency
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSConfig.cma

Build failed in Jenkins: plasma-framework_master_qt5 #703

[KDE CI System]

See 

Changes:

[notmart] documentation in ContainmentInterface

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson8653206481208988506.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   27c9c85..e5b2907  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@35d60412:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision 6c27cc0963f7ebfadd4a14ed09a63b055d74b753 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision e5b2907b535c38abeb90eb994344fd91470bcb88 
(refs/heads/jenkins)
Checking out Revision e5b2907b535c38abeb90eb994344fd91470bcb88 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson2438693253240686972.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at e5b2907 documentation in ContainmentInterface
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake

Build failed in Jenkins: plasma-framework_master_qt5 #704

[KDE CI System]

See 

Changes:

[notmart] propagate drawWallpaperChanged

[notmart] propagate containmentTypeChanged

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson4592741868394674038.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   e5b2907..bfbeae9  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@35d60412:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision e5b2907b535c38abeb90eb994344fd91470bcb88 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision bfbeae9969956a6640dadd2f2653e4d0586b1d77 
(refs/heads/jenkins)
Checking out Revision bfbeae9969956a6640dadd2f2653e4d0586b1d77 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson6853232526312225181.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at bfbeae9 propagate containmentTypeChanged
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kd

Re: Review Request 112556: Move itemviews to tier2

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112556/
---

(Updated Sept. 10, 2013, 12:45 p.m.)


Review request for KDE Frameworks.


Changes
---

Regenerated diff using --find-copies-harder


Description
---

In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the
if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within
kdelibs.


Diffs (updated)
-

  staging/CMakeLists.txt f0b6bf0 
  staging/itemviews/CMakeLists.txt f5c3c8d 
  staging/itemviews/ItemViewsConfig.cmake.in  
  staging/itemviews/autotests/CMakeLists.txt  
  staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
  staging/itemviews/src/CMakeLists.txt  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
  staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
  staging/itemviews/src/kcategorizedview.h  
  staging/itemviews/src/kcategorizedview.cpp  
  staging/itemviews/src/kcategorizedview_p.h  
  staging/itemviews/src/kcategorydrawer.h  
  staging/itemviews/src/kcategorydrawer.cpp  
  staging/itemviews/src/kextendableitemdelegate.h  
  staging/itemviews/src/kextendableitemdelegate.cpp  
  staging/itemviews/src/kfilterproxysearchline.h  
  staging/itemviews/src/kfilterproxysearchline.cpp  
  staging/itemviews/src/klistwidgetsearchline.h  
  staging/itemviews/src/klistwidgetsearchline.cpp  
  staging/itemviews/src/ktreewidgetsearchline.h  
  staging/itemviews/src/ktreewidgetsearchline.cpp  
  staging/itemviews/src/kwidgetitemdelegate.h  
  staging/itemviews/src/kwidgetitemdelegate.cpp  
  staging/itemviews/src/kwidgetitemdelegate_p.h  
  staging/itemviews/src/kwidgetitemdelegatepool.cpp  
  staging/itemviews/src/kwidgetitemdelegatepool_p.h  
  staging/itemviews/tests/CMakeLists.txt  
  staging/itemviews/tests/kcategorizedviewtest.cpp  
  staging/itemviews/tests/ktreewidgetsearchlinetest.h  
  staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
  staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
  tier2/CMakeLists.txt 62faacb 

Diff: http://git.reviewboard.kde.org/r/112556/diff/


Testing
---

Builds and passes tests when build from kdelibs and standalone.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #705

[KDE CI System]

See 

Changes:

[notmart] Revert "add kdeqt5staging dependency"

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1365863148039440559.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   bfbeae9..6f8c32f  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@35d60412:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision bfbeae9969956a6640dadd2f2653e4d0586b1d77 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 6f8c32fad7af0441d16cb71e10ba268ce6a1c1cb 
(refs/heads/jenkins)
Checking out Revision 6f8c32fad7af0441d16cb71e10ba268ce6a1c1cb 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson6902726227683737754.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at 6f8c32f Revert "add kdeqt5staging dependency"
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112281/#review39719
---

Ship it!


Looks good to me. Thanks for taking care of adding the doc I did not write.

- Aurélien Gâteau


On Sept. 8, 2013, 10:54 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112281/
> ---
> 
> (Updated Sept. 8, 2013, 10:54 a.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Allow setting a custom highlighter on the spell check decorator
> 
> --
> 
> This is needed in order to use this code from inside KTextEdit which allows 
> setting a custom highlighter. 
> This will also be useful for anyone wanting to subclass Sonnet::Highlighter 
> on a QTextEdit.
> 
> 
> Diffs
> -
> 
>   tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d 
>   tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 
> 
> Diff: http://git.reviewboard.kde.org/r/112281/diff/
> 
> 
> Testing
> ---
> 
> None - my KF5 setup has no dictionaries installed.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #706

[KDE CI System]

See 

Changes:

[notmart] support for wallpaper actions

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1206122932344955033.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   6f8c32f..52c3a27  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@35d60412:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision 6f8c32fad7af0441d16cb71e10ba268ce6a1c1cb 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 52c3a27e183445bccf488c39117c6bdf8cd5f214 
(refs/heads/jenkins)
Checking out Revision 52c3a27e183445bccf488c39117c6bdf8cd5f214 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson2519989181395799382.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at 52c3a27 support for wallpaper actions
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSConfig.c

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

[Àlex Fiestas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/
---

(Updated Sept. 10, 2013, 1:56 p.m.)


Review request for KDE Frameworks and David Faure.


Description
---

Port the rest of kdelibs-frameworks to KIO/Jobs


Diffs (updated)
-

  khtml/ecma/xmlhttprequest.h 6edf708 
  khtml/ecma/xmlhttprequest.cpp 565b489 
  khtml/html/html_formimpl.cpp 1a16a77 
  khtml/khtml_part.cpp 1833e4c 
  kio/kfile/kpropertiesdialog.cpp 2d2f00e 
  kross/ui/plugin.cpp f9f23f9 

Diff: http://git.reviewboard.kde.org/r/112559/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/#review39721
---

Ship it!



khtml/html/html_formimpl.cpp


same here. oh well :)



khtml/khtml_part.cpp


I just realized that KIO::storedGet + job->exec() would remove the need for 
a temporary file altogether :-)

But OK leave it as that if you want to move on.


- David Faure


On Sept. 10, 2013, 1:56 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112559/
> ---
> 
> (Updated Sept. 10, 2013, 1:56 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> ---
> 
> Port the rest of kdelibs-frameworks to KIO/Jobs
> 
> 
> Diffs
> -
> 
>   khtml/ecma/xmlhttprequest.h 6edf708 
>   khtml/ecma/xmlhttprequest.cpp 565b489 
>   khtml/html/html_formimpl.cpp 1a16a77 
>   khtml/khtml_part.cpp 1833e4c 
>   kio/kfile/kpropertiesdialog.cpp 2d2f00e 
>   kross/ui/plugin.cpp f9f23f9 
> 
> Diff: http://git.reviewboard.kde.org/r/112559/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #707

[KDE CI System]

See 

Changes:

[notmart] use a dynamic property

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson164263508166469744.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   52c3a27..d101966  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@35d60412:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision 52c3a27e183445bccf488c39117c6bdf8cd5f214 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision d101966f91229037e4c973e32d05cafdec7edfd0 
(refs/heads/jenkins)
Checking out Revision d101966f91229037e4c973e32d05cafdec7edfd0 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson5407925636631105333.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at d101966 use a dynamic property
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSConfig.cmake
-- KF5[KWa

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

[Àlex Fiestas]

> On Sept. 10, 2013, 2:34 p.m., David Faure wrote:
> > khtml/khtml_part.cpp, line 1060
> > 
> >
> > I just realized that KIO::storedGet + job->exec() would remove the need 
> > for a temporary file altogether :-)
> > 
> > But OK leave it as that if you want to move on.

The thing is... as with the "let's keep the bug" I don't want to modify much 
khtml code, so I'm trying to keep it as close as the original one.


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/#review39721
---


On Sept. 10, 2013, 1:56 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112559/
> ---
> 
> (Updated Sept. 10, 2013, 1:56 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> ---
> 
> Port the rest of kdelibs-frameworks to KIO/Jobs
> 
> 
> Diffs
> -
> 
>   khtml/ecma/xmlhttprequest.h 6edf708 
>   khtml/ecma/xmlhttprequest.cpp 565b489 
>   khtml/html/html_formimpl.cpp 1a16a77 
>   khtml/khtml_part.cpp 1833e4c 
>   kio/kfile/kpropertiesdialog.cpp 2d2f00e 
>   kross/ui/plugin.cpp f9f23f9 
> 
> Diff: http://git.reviewboard.kde.org/r/112559/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting Minutes 2013-w37

[Àlex Fiestas]

Hi there

These are the minutes of the Week 37 KF5 meeting. As usual it has been held on 
#kde-devel at 4pm Barcelona (CEST / UTC+2) time.

Present on the meeting: agateau, apol_, dfaure, jpwhiting, markg85, mck182, 
mgraesslin, scarpino, sebas, Sho_, steveire, svuorela, teo-, vHanda, afiestas

Topics discussed:
* apol: Has continue working on QCollator 
(https://codereview.qt-project.org/#change,63991).
* apol:  Has been digging on Frameworks CMake 
(https://git.reviewboard.kde.org/r/112570/).

* dfaure: Introduced QJob (QAbstractJob) in Qt mailing list, it won't be ready 
for 5.2, so we won't be able to port our frameworks to it.
* dfaure: Reviewing code all over the place :p.

* jpwhiting:  Will work on knewstuff (making it compile, cleaning it and moving 
to tier3 or lower).

* markg85: Has been porting SMB kio to kf5, port is done.
* markg85: Will work on KUriFilter.

* mck182: Got patch into Qt that is in staging again after breaking tests.
* mck182: Added some new tasks about printing.

* mgraesslin: Done findXCB adjustments, developers should update ECM.
* mgraesslin: Will work on Window decorations.

* sebas: Organized Plasma2 work to be done.
* sebas: Did more Plasma2 porting.
* sebas: No progress on K_PLUGIN_VERIFICATION_DATA.
* sebas: KServiceTypeTrader replacement based on JSON metadata.
* sebas: Will work on more KPlugin* stuff.

* Sho_: Ported Task Manager to Plasma2, having to modify bits of 
libtaskmanager.
* Sho_: Tracking down a bug in "MEL" Plasma component.

* svuorela: Slowly iterating over qtpaths.

* teo-: More work on restoring session management in Qt:  
https://codereview.qt-project.org/#change,64767 waiting for some help Qt with 
build system .
* teo-: We have to take a decision of what to do with all the session 
management features lost with KApplication.

* agateau: Pending review to move itemviews to tier2.
* agateau: Investigated the task of "All uses of NOGUI should be ported to 
ecm_mark_nongui_executable()" but posponed after talking with dfaure and 
steveire.
* agateau: Started to look at kinterporcesswindowing (cleaning code, writing 
test).
* agateau: There seems to be duplication between kwidgetsaddons and 
kinterprocesswindowinh.
* agateau: Wondering if change KMessageBox return type.

* bshah: Ported some kio-slave (application, archive and bookmarks).

* afiestas: Ported remaining uses of KIO::NetAccess to KIO (Kjob+exec).
* afiestas: Will move kio/netaccess to kde4support
* afiestas: Will move kiconthemes to tier2/3

If you got questions, feel free to ask.

Cheers !
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

[Stephen Kelly]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112570/#review39734
---

Ship it!


Ship It!

- Stephen Kelly


On Sept. 10, 2013, 3:49 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112570/
> ---
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> kde4_add_executable is deprecated. Port all kde4_add_executable uses to 
> add_executable.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html b3329d6 
>   experimental/kdeclarative/CMakeLists.txt a7bddfa 
>   interfaces/terminal/example/CMakeLists.txt e8c3f01 
>   kdesu/CMakeLists.txt 351ad85 
>   kdewidgets/CMakeLists.txt 038da6b 
>   khtml/CMakeLists.txt 124c3eb 
>   kinit/CMakeLists.txt ff7b7fd 
>   kio/misc/CMakeLists.txt e2c62d6 
>   kio/misc/kpac/CMakeLists.txt 04ffba1 
>   kio/misc/ksendbugmail/CMakeLists.txt cbe4bd9 
>   kio/tests/CMakeLists.txt 825ca3c 
>   kioslave/http/kcookiejar/CMakeLists.txt fcb620e 
>   kjsembed/examples/kjsconsole/CMakeLists.txt 2438323 
>   kjsembed/kjscmd/CMakeLists.txt f457933 
>   knotify/tests/CMakeLists.txt bc6f5e0 
>   kparts/tests/CMakeLists.txt bb8a120 
>   kpty/CMakeLists.txt 2cc2885 
>   kross/console/CMakeLists.txt 58257ca 
>   staging/kde4support/CMakeLists.txt 0445f0a 
>   staging/kde4support/src/CMakeLists.txt 6f4603d 
>   staging/kemoticons/tests/CMakeLists.txt 5e0d46e 
> 
> Diff: http://git.reviewboard.kde.org/r/112570/diff/
> 
> 
> Testing
> ---
> 
> Builds, although it doesn't change much in linux.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #708

[KDE CI System]

See 

Changes:

[notmart] support for setting a wallpaper trough drag and drop

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 2 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1562073826162840851.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   d101966..33dae6b  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@35d60412:LinuxSlave - 2
Using strategy: Default
Last Built Revision: Revision d101966f91229037e4c973e32d05cafdec7edfd0 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 33dae6b18c5760ebf69a974604dce1c0ec779380 
(refs/heads/jenkins)
Checking out Revision 33dae6b18c5760ebf69a974604dce1c0ec779380 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson5917937948363249840.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 attica - Branch master
 extra-cmake-modules - Branch master
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at 33dae6b support for setting a wallpaper trough drag and drop
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/

Re: Review Request 112545: Unify both meinproc5 binaries

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/#review39743
---



staging/kdoctools/src/meinproc.cpp


err? don't print this on every call to meinproc, only if 
parser.isSet("cache") !


- David Faure


On Sept. 10, 2013, 4:52 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112545/
> ---
> 
> (Updated Sept. 10, 2013, 4:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Description
> ---
> 
> Now we only have the one, which can be compiled without KArchive by ifdef'ing 
> meinproc.cpp.
> 
> I'm unsure that KArchive it's that big of a dependency, to make it optional. 
> Opinions?
> 
> 
> Diffs
> -
> 
>   staging/kdoctools/src/CMakeLists.txt 72bb06e 
>   staging/kdoctools/src/meinproc.cpp 5d476f6 
>   staging/kdoctools/src/meinproc_simple.cpp 334f13f 
> 
> Diff: http://git.reviewboard.kde.org/r/112545/diff/
> 
> 
> Testing
> ---
> 
> Builds, both ways.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112545: Unify both meinproc5 binaries

[Aleix Pol Gonzalez]

> On Sept. 10, 2013, 6:46 a.m., David Faure wrote:
> > staging/kdoctools/src/meinproc.cpp, line 112
> > 
> >
> > isn't it better to not define the option, so that the user gets 
> > "unknown option --cache"?
> > 
> > Alternatively, further down, check for isSet("cache") and error out.

I don't know, maybe :)

Let's do this.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/#review39690
---


On Sept. 9, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112545/
> ---
> 
> (Updated Sept. 9, 2013, 2:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Description
> ---
> 
> Now we only have the one, which can be compiled without KArchive by ifdef'ing 
> meinproc.cpp.
> 
> I'm unsure that KArchive it's that big of a dependency, to make it optional. 
> Opinions?
> 
> 
> Diffs
> -
> 
>   staging/kdoctools/src/CMakeLists.txt 72bb06e 
>   staging/kdoctools/src/meinproc.cpp 5d476f6 
>   staging/kdoctools/src/meinproc_simple.cpp 334f13f 
> 
> Diff: http://git.reviewboard.kde.org/r/112545/diff/
> 
> 
> Testing
> ---
> 
> Builds, both ways.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112545: Unify both meinproc5 binaries

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/
---

(Updated Sept. 10, 2013, 4:52 p.m.)


Review request for KDE Frameworks and Albert Astals Cid.


Changes
---

implement david's suggestions.


Description
---

Now we only have the one, which can be compiled without KArchive by ifdef'ing 
meinproc.cpp.

I'm unsure that KArchive it's that big of a dependency, to make it optional. 
Opinions?


Diffs (updated)
-

  staging/kdoctools/src/CMakeLists.txt 72bb06e 
  staging/kdoctools/src/meinproc.cpp 5d476f6 
  staging/kdoctools/src/meinproc_simple.cpp 334f13f 

Diff: http://git.reviewboard.kde.org/r/112545/diff/


Testing
---

Builds, both ways.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112545: Unify both meinproc5 binaries

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/
---

(Updated Sept. 10, 2013, 5:39 p.m.)


Review request for KDE Frameworks and Albert Astals Cid.


Changes
---

err... of course... -.-


Description
---

Now we only have the one, which can be compiled without KArchive by ifdef'ing 
meinproc.cpp.

I'm unsure that KArchive it's that big of a dependency, to make it optional. 
Opinions?


Diffs (updated)
-

  staging/kdoctools/src/CMakeLists.txt 72bb06e 
  staging/kdoctools/src/meinproc.cpp 5d476f6 
  staging/kdoctools/src/meinproc_simple.cpp 334f13f 

Diff: http://git.reviewboard.kde.org/r/112545/diff/


Testing
---

Builds, both ways.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112643: Adapt KCompletion so that it can be moved to tier2

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112643/
---

Review request for KDE Frameworks and Stephen Kelly.


Description
---

Adds the dependencies in the Config.cmake.in file.
Properly sets the Qt version dependency.
Puts all the remove_definitions together.


Diffs
-

  staging/kcompletion/CMakeLists.txt b498ae9 
  staging/kcompletion/KCompletionConfig.cmake.in 53b6219 
  staging/kcompletion/src/CMakeLists.txt 5e8ae19 

Diff: http://git.reviewboard.kde.org/r/112643/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112560: Remove KNotification dependency in KCompletion

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112560/
---

(Updated Sept. 10, 2013, 5:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Drop KNotifications dependency from KCompletion.

Reasons:
- Its not used in KDE4
- It creates noise
- It bumps KCompletion from tier2 to tier3

I know I already sent an e-mail about it, but it seemed to me that a review 
request would be more welcome.


Diffs
-

  staging/kcompletion/src/CMakeLists.txt 1300ab5 
  staging/kcompletion/src/kcompletion.h 682a058 
  staging/kcompletion/src/kcompletion.cpp bcd220a 
  staging/kcompletion/src/khistorycombobox.cpp fe955a2 

Diff: http://git.reviewboard.kde.org/r/112560/diff/


Testing
---

builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112560: Remove KNotification dependency in KCompletion

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112560/#review39748
---


This review has been submitted with commit 
61f7afdc7ab7d14f135967dfdd0c4a2b86d7fe6b by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 9, 2013, 3:50 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112560/
> ---
> 
> (Updated Sept. 9, 2013, 3:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Drop KNotifications dependency from KCompletion.
> 
> Reasons:
> - Its not used in KDE4
> - It creates noise
> - It bumps KCompletion from tier2 to tier3
> 
> I know I already sent an e-mail about it, but it seemed to me that a review 
> request would be more welcome.
> 
> 
> Diffs
> -
> 
>   staging/kcompletion/src/CMakeLists.txt 1300ab5 
>   staging/kcompletion/src/kcompletion.h 682a058 
>   staging/kcompletion/src/kcompletion.cpp bcd220a 
>   staging/kcompletion/src/khistorycombobox.cpp fe955a2 
> 
> Diff: http://git.reviewboard.kde.org/r/112560/diff/
> 
> 
> Testing
> ---
> 
> builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112556: Move itemviews to tier2

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112556/#review39773
---

Ship it!


Ship It!

- David Faure


On Sept. 10, 2013, 10:45 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112556/
> ---
> 
> (Updated Sept. 10, 2013, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the
> if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within
> kdelibs.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt f0b6bf0 
>   staging/itemviews/CMakeLists.txt f5c3c8d 
>   staging/itemviews/ItemViewsConfig.cmake.in  
>   staging/itemviews/autotests/CMakeLists.txt  
>   staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   staging/itemviews/src/CMakeLists.txt  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   staging/itemviews/src/kcategorizedview.h  
>   staging/itemviews/src/kcategorizedview.cpp  
>   staging/itemviews/src/kcategorizedview_p.h  
>   staging/itemviews/src/kcategorydrawer.h  
>   staging/itemviews/src/kcategorydrawer.cpp  
>   staging/itemviews/src/kextendableitemdelegate.h  
>   staging/itemviews/src/kextendableitemdelegate.cpp  
>   staging/itemviews/src/kfilterproxysearchline.h  
>   staging/itemviews/src/kfilterproxysearchline.cpp  
>   staging/itemviews/src/klistwidgetsearchline.h  
>   staging/itemviews/src/klistwidgetsearchline.cpp  
>   staging/itemviews/src/ktreewidgetsearchline.h  
>   staging/itemviews/src/ktreewidgetsearchline.cpp  
>   staging/itemviews/src/kwidgetitemdelegate.h  
>   staging/itemviews/src/kwidgetitemdelegate.cpp  
>   staging/itemviews/src/kwidgetitemdelegate_p.h  
>   staging/itemviews/src/kwidgetitemdelegatepool.cpp  
>   staging/itemviews/src/kwidgetitemdelegatepool_p.h  
>   staging/itemviews/tests/CMakeLists.txt  
>   staging/itemviews/tests/kcategorizedviewtest.cpp  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.h  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   tier2/CMakeLists.txt 62faacb 
> 
> Diff: http://git.reviewboard.kde.org/r/112556/diff/
> 
> 
> Testing
> ---
> 
> Builds and passes tests when build from kdelibs and standalone.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112643: Adapt KCompletion so that it can be moved to tier2

[Stephen Kelly]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112643/#review39778
---

Ship it!


Though I would put the remove_definitions changes in a separate patch.

Thanks!

- Stephen Kelly


On Sept. 10, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112643/
> ---
> 
> (Updated Sept. 10, 2013, 6:08 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Description
> ---
> 
> Adds the dependencies in the Config.cmake.in file.
> Properly sets the Qt version dependency.
> Puts all the remove_definitions together.
> 
> 
> Diffs
> -
> 
>   staging/kcompletion/CMakeLists.txt b498ae9 
>   staging/kcompletion/KCompletionConfig.cmake.in 53b6219 
>   staging/kcompletion/src/CMakeLists.txt 5e8ae19 
> 
> Diff: http://git.reviewboard.kde.org/r/112643/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #709

[KDE CI System]

See 

--
[...truncated 537 lines...]
Generating applet.moc
:0:
 Note: No relevant classes found. No output generated.
Generating configgroup.moc
:0:
 Note: No relevant classes found. No output generated.
Generating containment.moc
:0:
 Note: No relevant classes found. No output generated.
Generating desktopscriptengine.moc
:0:
 Note: No relevant classes found. No output generated.
Generating layouttemplatepackagestructure.moc
:0:
 Note: No relevant classes found. No output generated.
In file included from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/KMimeType:1:0,
 from 
:29:
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kmimetype.h:54:42:
 warning: ‘KMimeType’ is deprecated (declared at 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kmimetype.h:50)
 [-Wdeprecated-declarations]
Generating panel.moc
:0:
 Note: No relevant classes found. No output generated.
Generating scriptengine.moc
:0:
 Note: No relevant classes found. No output generated.
[ 16%] Building CXX object src/plasma/CMakeFiles/plasma.dir/pluginloader.cpp.o
Generating widget.moc
:0:
 Note: No relevant classes found. No output generated.
[ 16%] Building CXX object 
src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin_automoc.cpp.o
Linking CXX shared library ../../../lib/libdirmodelplugin.so
Scanning dependencies of target fullmodelaccesstest
[ 16%] Building CXX object 
src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/columnproxymodeltest.cpp.o
[ 17%] Building CXX object 
src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDragArea.cpp.o
[ 17%] Built target dirmodelplugin
[ 17%] Building CXX object 
src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDragDropEvent.cpp.o
In file included from 
:27:0:
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:
 In function ‘T KGlobal::findDirectChild(const QObject*)’:
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:514:31:
 warning: ‘QObject* KGlobal::findDirectChild_helper(const QObject*, const 
QMetaObject&)’ is deprecated (declared at 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:504)
 [-Wdeprecated-declarations]
:
 In member function ‘Plasma::DataEngine* 
Plasma::PluginLoader::loadDataEngine(const QString&)’:
:257:63:
 warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kplugininfo.h:114)
 [-Wdeprecated-declarations]
In file included from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0,
 from 
:23:
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:60:52:
 warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63:
 warning: ‘KCmdLineOptions’ is deprecated (declared at 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63:
 warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations]
In file included from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0,
 from 

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1174

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112556: Move itemviews to tier2

[Christoph Feck]

> On Sept. 10, 2013, 9:06 p.m., David Faure wrote:
> > Ship It!

So what about renaming itemmodels/itemviews to kitemmodels/kitemviews, or is it 
too late for that? Do we plan to have a proper/final "let's look at what we 
did" API review after everything has settled?


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112556/#review39773
---


On Sept. 10, 2013, 10:45 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112556/
> ---
> 
> (Updated Sept. 10, 2013, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the
> if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within
> kdelibs.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt f0b6bf0 
>   staging/itemviews/CMakeLists.txt f5c3c8d 
>   staging/itemviews/ItemViewsConfig.cmake.in  
>   staging/itemviews/autotests/CMakeLists.txt  
>   staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   staging/itemviews/src/CMakeLists.txt  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   staging/itemviews/src/kcategorizedview.h  
>   staging/itemviews/src/kcategorizedview.cpp  
>   staging/itemviews/src/kcategorizedview_p.h  
>   staging/itemviews/src/kcategorydrawer.h  
>   staging/itemviews/src/kcategorydrawer.cpp  
>   staging/itemviews/src/kextendableitemdelegate.h  
>   staging/itemviews/src/kextendableitemdelegate.cpp  
>   staging/itemviews/src/kfilterproxysearchline.h  
>   staging/itemviews/src/kfilterproxysearchline.cpp  
>   staging/itemviews/src/klistwidgetsearchline.h  
>   staging/itemviews/src/klistwidgetsearchline.cpp  
>   staging/itemviews/src/ktreewidgetsearchline.h  
>   staging/itemviews/src/ktreewidgetsearchline.cpp  
>   staging/itemviews/src/kwidgetitemdelegate.h  
>   staging/itemviews/src/kwidgetitemdelegate.cpp  
>   staging/itemviews/src/kwidgetitemdelegate_p.h  
>   staging/itemviews/src/kwidgetitemdelegatepool.cpp  
>   staging/itemviews/src/kwidgetitemdelegatepool_p.h  
>   staging/itemviews/tests/CMakeLists.txt  
>   staging/itemviews/tests/kcategorizedviewtest.cpp  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.h  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   tier2/CMakeLists.txt 62faacb 
> 
> Diff: http://git.reviewboard.kde.org/r/112556/diff/
> 
> 
> Testing
> ---
> 
> Builds and passes tests when build from kdelibs and standalone.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112660: KPluginInfo rework for KPluginTrader

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/
---

Review request for KDE Frameworks and David Faure.


Description
---

This patch prepares KPluginInfo for usage with KPluginTrader (to be submitted 
in a separate patch). It basically makes KPluginInfo's API a little bit more 
like KService by adding a property(QString) accessor to the plugin info. This 
allows us on the one hand 

Part of this patch, and much of its churn, is the internal change from 
independent QStrings and QStringLists to a QVariantMap. This is how the 
metadata comes in from KPlugin*, and it allows us to make properties accessible 
by name.

There's also a fair bit of moving from QLatin1String to QStringLiteral in 
there, most of these lines needed changes anyway. Additionally, the keys of 
properties are now shared in the d-pointer.

This change is source compatible to the old version.


Diffs
-

  staging/kservice/src/services/kplugininfo.cpp 21e0882 

Diff: http://git.reviewboard.kde.org/r/112660/diff/


Testing
---

All tests still pass, no regressions encountered otherwise.


Thanks,

Sebastian Kügler

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

[David Edmundson]

> On Sept. 9, 2013, 2:39 p.m., Aurélien Gâteau wrote:
> > Instead of adding methods to get buttons and combo boxes from 
> > KSelectAction, which is an implementation detail to me, what about this:
> > 
> > - Add KSelectAction::insertAction(QAction* before, QAction*) (because what 
> > KRecentFilesAction::addAction() really does is insert(firstAction, action)) 
> > 
> > - Implement KRecentFilesAction::addAction(QAction* action, const QUrl& url, 
> > const QString& name) like this:
> > 
> >   KSelectAction::insertAction(actions().first(), action);
> >   d->m_shortNames.insert(action, name);
> >   d->m_urls.insert(action, url);
> > 
> > Could this work?

yes I think it will. That's really neat and clever. Thanks.


- David


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/#review39649
---


On Sept. 7, 2013, 7:45 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112583/
> ---
> 
> (Updated Sept. 7, 2013, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> KConfigWidgets relies on a private header in KWidgetAddons. This prevents 
> KConfigWidgets building on it's own
> 
> By exposing the two of these private members in protected methods, we can 
> solve this problem.
> 
> 
> Commit log below:
> --
> 
> change target link libraries to ${lib_LIBRARIES} format
> --
> 
> Remove inheritance on KSelectionActionPrivate in KRecentFileActions
> 
> This is in a different framework so cannot be used when building
> standalone.
> 
> --
> Expose associated comboboxes and toolbuttons in KSelectAction
> 
> 
> Diffs
> -
> 
>   staging/kconfigwidgets/src/CMakeLists.txt 
> dad6bcc140cb4fe56380bd44ea007fe1f06edace 
>   staging/kconfigwidgets/src/krecentfilesaction.h 
> edf77a24866018134d9c5a200c6e35213742c555 
>   staging/kconfigwidgets/src/krecentfilesaction.cpp 
> 9aa5f8bd83d064402dd6333c7cd89a388d373fe1 
>   staging/kconfigwidgets/src/krecentfilesaction_p.h 
> 8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c 
>   tier1/kwidgetsaddons/src/kselectaction.h 
> 07afaa960d2be4877aeef0ff074d0fd20c7b7f40 
>   tier1/kwidgetsaddons/src/kselectaction.cpp 
> b388df94baa042e8230f2795f35dd378117c6ab6 
> 
> Diff: http://git.reviewboard.kde.org/r/112583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #710

[KDE CI System]

See 

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson8562171019780716667.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   6c27cc0..33dae6b  master -> origin/master
 * [new branch]  plasmaview -> origin/plasmaview
 * [new branch]  terietor/plasmaview -> origin/terietor/plasmaview
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@2d43b0fe:LinuxSlave - 3
Using strategy: Default
Last Built Revision: Revision 33dae6b18c5760ebf69a974604dce1c0ec779380 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 33dae6b18c5760ebf69a974604dce1c0ec779380 
(refs/heads/jenkins)
Checking out Revision 33dae6b18c5760ebf69a974604dce1c0ec779380 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7650020467385908033.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 attica - Branch master
 strigiclient - Branch master
 qt5 - Branch dev
 strigiutils - Branch master
 libstreams - Branch master
 libstreamanalyzer - Branch master
 strigidaemon - Branch master
 extra-cmake-modules - Branch master
 kdelibs - Branch frameworks

== Cleaning Source Tree

HEAD is now at 33dae6b support for setting a wallpaper trough drag and drop
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

Write failed: Broken pipe
rsync: connection unexpectedly closed (212683 bytes received so far) [receiver]
rsync error: error in rsync protocol data stream (code 12) at io.c(605) 
[receiver=3.0.9]
rsync: connection unexpectedly closed (212 bytes received so far) [generator]
rsync error: unexplained error (code 255) at io.c(605) [generator=3.0.9]
Syncing dependencies from master server for project plasma-framework failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Recording test results
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/#review39793
---



staging/kservice/src/services/kplugininfo.cpp


I think that two variables (hidden and _hidden) so similar are confusing.



staging/kservice/src/services/kplugininfo.cpp


In kdelibs I don't usually see private members in the "_variable" form, but 
"m_variable".

Nevertheless, members of a private class don't usually have any underscore 
or "m_", because when accessing them as d->name makes it clear that they are 
private. Probably you have a reason, though :-) .


- David Gil Oliva


On Sept. 10, 2013, 11:32 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112660/
> ---
> 
> (Updated Sept. 10, 2013, 11:32 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> ---
> 
> This patch prepares KPluginInfo for usage with KPluginTrader (to be submitted 
> in a separate patch). It basically makes KPluginInfo's API a little bit more 
> like KService by adding a property(QString) accessor to the plugin info. This 
> allows us on the one hand 
> 
> Part of this patch, and much of its churn, is the internal change from 
> independent QStrings and QStringLists to a QVariantMap. This is how the 
> metadata comes in from KPlugin*, and it allows us to make properties 
> accessible by name.
> 
> There's also a fair bit of moving from QLatin1String to QStringLiteral in 
> there, most of these lines needed changes anyway. Additionally, the keys of 
> properties are now shared in the d-pointer.
> 
> This change is source compatible to the old version.
> 
> 
> Diffs
> -
> 
>   staging/kservice/src/services/kplugininfo.cpp 21e0882 
> 
> Diff: http://git.reviewboard.kde.org/r/112660/diff/
> 
> 
> Testing
> ---
> 
> All tests still pass, no regressions encountered otherwise.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel