Re: Review Request 115387: rename dbus interface file for kinit

[Stefano Avallone]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115387/#review48591
---


Builds and installs fine. I would let more experienced devs to give the ship it.

- Stefano Avallone


On Jan. 29, 2014, 4:27 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115387/
> ---
> 
> (Updated Jan. 29, 2014, 4:27 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefano Avallone.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> rename the dbus interface file for kinit on install to prevent clashes with 
> kdelibs4 equivalent.
> 
> 
> Diffs
> -
> 
>   src/klauncher/CMakeLists.txt c6cff7c 
> 
> Diff: https://git.reviewboard.kde.org/r/115387/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115269: Improve dependency specifications

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/#review48597
---


I would like to commit this soon if there are no comments.

- Michael Palimaka


On Jan. 23, 2014, 6:24 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115269/
> ---
> 
> (Updated Jan. 23, 2014, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdnssd-framework
> 
> 
> Description
> ---
> 
> KConfig is only required when DNSSD is found, and QtDBus is only required 
> when either Avahi or DNSSD is found, so don't require them unconditionally.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt defb7bbb70a6b7567e5d7d0e6b8097f57ad07a15 
>   src/CMakeLists.txt ef84ffa5ae5cfdfd2547c458e446cf4c9a2c7420 
> 
> Diff: https://git.reviewboard.kde.org/r/115269/diff/
> 
> 
> Testing
> ---
> 
> Still builds against Avahi, DNSSD, and neither backends.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115269: Improve dependency specifications

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/#review48598
---

Ship it!


Looks sensible.  Just one thing while you're editing this file, then go ahead 
and commit.


CMakeLists.txt


Make this unconditional (ie: replace all four lines by just the 
find_package line)


- Alex Merry


On Jan. 23, 2014, 6:24 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115269/
> ---
> 
> (Updated Jan. 23, 2014, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdnssd-framework
> 
> 
> Description
> ---
> 
> KConfig is only required when DNSSD is found, and QtDBus is only required 
> when either Avahi or DNSSD is found, so don't require them unconditionally.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt defb7bbb70a6b7567e5d7d0e6b8097f57ad07a15 
>   src/CMakeLists.txt ef84ffa5ae5cfdfd2547c458e446cf4c9a2c7420 
> 
> Diff: https://git.reviewboard.kde.org/r/115269/diff/
> 
> 
> Testing
> ---
> 
> Still builds against Avahi, DNSSD, and neither backends.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/#review48600
---



src/config-strlcpy.h.cmake


I'm not convinced this is the correct fix; I don't think strlcpy *should* 
be exported by kcrash.  Instead, I suspect the KCRASH_EXPORT should be removed 
from strlcpy-fake.c.


- Alex Merry


On Jan. 22, 2014, 3:13 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115203/
> ---
> 
> (Updated Jan. 22, 2014, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Allow compiling with MSVC
> 
> 
> Diffs
> -
> 
>   src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 
>   src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 
> 
> Diff: https://git.reviewboard.kde.org/r/115203/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115398: rename dbus interface to prevent clashes with khtml from kdelibs4

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115398/
---

Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: khtml


Description
---

rename dbus interface to prevent clashes with khtml from kdelibs4
alas I have no idea what applications provide this interface


Diffs
-

  src/khtml_iface.h 07fbf32 
  src/CMakeLists.txt 841edbd 

Diff: https://git.reviewboard.kde.org/r/115398/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115358: Remove the --logfile-dir option, and instead always create a logfile

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115358/#review48604
---

Ship it!


Looks good.

- Aurélien Gâteau


On Jan. 28, 2014, 4:50 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115358/
> ---
> 
> (Updated Jan. 28, 2014, 4:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Aurélien Gâteau and Allen Winter.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> The options were getting a bit out of hand, and the warnings get lost in 
> doxygen's output, so:
> 
> 
> Remove the --logfile-dir option, and instead always create a logfile
> 
> Doxygen warnings will go into a file called doxygen-warnings.log in the
> apidocs directory.
> 
> 
> Diffs
> -
> 
>   src/kapidox/__init__.py c89e06fdc2385f07b074b14574c1e62900723cab 
>   src/kgenframeworksapidox d41f35fdb3c6a490c95e18898689206022d8b966 
> 
> Diff: https://git.reviewboard.kde.org/r/115358/diff/
> 
> 
> Testing
> ---
> 
> kgenapidox tested with python2 and python3 (on karchive).  
> kgenframeworksapidox tested with python2 and python3, at least for the first 
> few modules.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/#review48605
---


Looks good. Minor nitpicks:

- I would use `#include ` instead of `#include 
"kcompletionbase.h"` for consistency
- I would group the includes with the other kcompletion includes, except for 
kcompletionbase.cpp where it makes sense to include kcompletionbase.h first, to 
ensure kcompletionbase.h is self-contained.

- Aurélien Gâteau


On Jan. 30, 2014, 12:16 a.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115394/
> ---
> 
> (Updated Jan. 30, 2014, 12:16 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> To make kcompletion.h smaller, split KCompletionBase class from it into its 
> own header file.
> 
> 
> Diffs
> -
> 
>   src/klineedit.h f1107e2 
>   src/kcompletionbase.cpp 252b613 
>   src/kcompletion.h fa0731e 
>   src/kcompletionbase.h PRE-CREATION 
>   src/CMakeLists.txt 05452ab 
>   src/kcombobox.h f34d259 
> 
> Diff: https://git.reviewboard.kde.org/r/115394/diff/
> 
> 
> Testing
> ---
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115358: Remove the --logfile-dir option, and instead always create a logfile

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115358/
---

(Updated Jan. 30, 2014, 1:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aurélien Gâteau and Allen Winter.


Repository: kapidox


Description
---

The options were getting a bit out of hand, and the warnings get lost in 
doxygen's output, so:


Remove the --logfile-dir option, and instead always create a logfile

Doxygen warnings will go into a file called doxygen-warnings.log in the
apidocs directory.


Diffs
-

  src/kapidox/__init__.py c89e06fdc2385f07b074b14574c1e62900723cab 
  src/kgenframeworksapidox d41f35fdb3c6a490c95e18898689206022d8b966 

Diff: https://git.reviewboard.kde.org/r/115358/diff/


Testing
---

kgenapidox tested with python2 and python3 (on karchive).  kgenframeworksapidox 
tested with python2 and python3, at least for the first few modules.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115358: Remove the --logfile-dir option, and instead always create a logfile

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115358/#review48606
---


This review has been submitted with commit 
c5f9884b07fd3cdf42fd48bfb4900ea14e808612 by Alex Merry to branch master.

- Commit Hook


On Jan. 28, 2014, 3:50 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115358/
> ---
> 
> (Updated Jan. 28, 2014, 3:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Aurélien Gâteau and Allen Winter.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> The options were getting a bit out of hand, and the warnings get lost in 
> doxygen's output, so:
> 
> 
> Remove the --logfile-dir option, and instead always create a logfile
> 
> Doxygen warnings will go into a file called doxygen-warnings.log in the
> apidocs directory.
> 
> 
> Diffs
> -
> 
>   src/kapidox/__init__.py c89e06fdc2385f07b074b14574c1e62900723cab 
>   src/kgenframeworksapidox d41f35fdb3c6a490c95e18898689206022d8b966 
> 
> Diff: https://git.reviewboard.kde.org/r/115358/diff/
> 
> 
> Testing
> ---
> 
> kgenapidox tested with python2 and python3 (on karchive).  
> kgenframeworksapidox tested with python2 and python3, at least for the first 
> few modules.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115388: Remove unused dependencies.

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115388/#review48607
---

Ship it!


Looks good to me.

- Aurélien Gâteau


On Jan. 29, 2014, 6:06 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115388/
> ---
> 
> (Updated Jan. 29, 2014, 6:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> QtScript is not used. QtGui is actually used rather than QtWidgets.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 536f7f33ca6ac25fc87966bf2bb4e2fc248c37fd 
>   src/kdeclarative.h 84f313302c70f9161ab2244c735166e08947f252 
> 
> Diff: https://git.reviewboard.kde.org/r/115388/diff/
> 
> 
> Testing
> ---
> 
> Builds. Didn't find any reference to QtScript or QtWidgets when inspecting 
> source.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Change the ML default reply-to address

[Aurélien Gâteau]

On Wed, Jan 29, 2014, at 8:38, Kevin Krammer wrote:
> On Wednesday, 2014-01-29, 14:29:42, Mark Gaiser wrote:
> 
> > Yeah, i've had that issue quite a few times.
> > Now since i use gmail i either have an easy reply-to-all option or
> > (and that's even better) a labs plugin that automatically does
> > reply-to-all instead of reply.
> 
> Which has a different problem since this sends mails to the other person 
> twice. Once directly and once through the list. IMHO it really sucks when
> that 
> happens, polluting *my* inbox when replying to my mails on a list.
> 
> Make sure you always remove the sender after you've hit reply-all for a
> list!

You can avoid this (on the receiving side) by editing your personal
mailing list settings. Quoting mailman settings page:

"""
Avoid duplicate copies of messages?

When you are listed explicitly in the To: or Cc: headers of a list
message, you can opt to not receive another copy from the mailing list.
Select Yes to avoid receiving copies from the mailing list; select No to
receive copies.

If the list has member personalized messages enabled, and you elect to
receive copies, every copy will have a X-Mailman-Copy: yes header added
to it. 
"""

Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Change the ML default reply-to address

[Alex Merry]

On 30/01/14 13:50, Aurélien Gâteau wrote:
> You can avoid this (on the receiving side) by editing your personal
> mailing list settings. Quoting mailman settings page:
> 
> """
> Avoid duplicate copies of messages?
> 
> When you are listed explicitly in the To: or Cc: headers of a list
> message, you can opt to not receive another copy from the mailing list.
> Select Yes to avoid receiving copies from the mailing list; select No to
> receive copies.
> 
> If the list has member personalized messages enabled, and you elect to
> receive copies, every copy will have a X-Mailman-Copy: yes header added
> to it. 
> """

Only this ends up doing the exact opposite of what I, at least, want: I
get the message in my inbox, but it doesn't have the headers that cause
it to be filtered to the correct mailing list folder.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #1103

[KDE CI System]

See 

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7579407244150265765.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

fatal: Unable to look up anongit.kde.org (port 9418) (System error)

== Cleaning Source Tree

HEAD is now at d3ae687 SVN_SILENT made messages (.desktop file)
Removing build/
Removing install/
Success build forhudson.tasks.Shell@59b72395
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/plasma-framework.git
FATAL: Failed to fetch from git://anongit.kde.org/plasma-framework.git
hudson.plugins.git.GitException: Failed to fetch from 
git://anongit.kde.org/plasma-framework.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:625)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:847)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:872)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1411)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:651)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:560)
at hudson.model.Run.execute(Run.java:1670)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:231)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress git://anongit.kde.org/plasma-framework.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: Unable to look up anongit.kde.org (port 9418) (System error)

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1086)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:968)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$200(CliGitAPIImpl.java:71)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:197)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:328)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115401: rename all_languages for coinstallability in kde4support

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115401/
---

Review request for KDE Frameworks.


Repository: kde4support


Description
---

rename all_languages at install time in kde4support for coinstallability with 
kdelibs4


Diffs
-

  src/kdecore/klocale_kde.cpp 415edbf 
  src/CMakeLists.txt 0d67011 

Diff: https://git.reviewboard.kde.org/r/115401/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115401: rename all_languages for coinstallability in kde4support

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115401/#review48613
---

Ship it!


Ship It!

- Alex Merry


On Jan. 30, 2014, 2:10 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115401/
> ---
> 
> (Updated Jan. 30, 2014, 2:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> rename all_languages at install time in kde4support for coinstallability with 
> kdelibs4
> 
> 
> Diffs
> -
> 
>   src/kdecore/klocale_kde.cpp 415edbf 
>   src/CMakeLists.txt 0d67011 
> 
> Diff: https://git.reviewboard.kde.org/r/115401/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115401: rename all_languages for coinstallability in kde4support

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115401/#review48614
---


This review has been submitted with commit 
07db93e983accb3887d1e67d416fcf393e463cc8 by Jonathan Riddell to branch master.

- Commit Hook


On Jan. 30, 2014, 2:10 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115401/
> ---
> 
> (Updated Jan. 30, 2014, 2:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> rename all_languages at install time in kde4support for coinstallability with 
> kdelibs4
> 
> 
> Diffs
> -
> 
>   src/kdecore/klocale_kde.cpp 415edbf 
>   src/CMakeLists.txt 0d67011 
> 
> Diff: https://git.reviewboard.kde.org/r/115401/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115401: rename all_languages for coinstallability in kde4support

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115401/
---

(Updated Jan. 30, 2014, 2:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kde4support


Description
---

rename all_languages at install time in kde4support for coinstallability with 
kdelibs4


Diffs
-

  src/kdecore/klocale_kde.cpp 415edbf 
  src/CMakeLists.txt 0d67011 

Diff: https://git.reviewboard.kde.org/r/115401/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 #1104

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115388: Remove unused dependencies.

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115388/
---

(Updated Jan. 30, 2014, 2:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Marco Martin.


Repository: kdeclarative


Description
---

QtScript is not used. QtGui is actually used rather than QtWidgets.


Diffs
-

  CMakeLists.txt 536f7f33ca6ac25fc87966bf2bb4e2fc248c37fd 
  src/kdeclarative.h 84f313302c70f9161ab2244c735166e08947f252 

Diff: https://git.reviewboard.kde.org/r/115388/diff/


Testing
---

Builds. Didn't find any reference to QtScript or QtWidgets when inspecting 
source.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115388: Remove unused dependencies.

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115388/#review48619
---


This review has been submitted with commit 
4c4ee1e843b06a769f3367d47037e33a45d8908b by Michael Palimaka to branch master.

- Commit Hook


On Jan. 29, 2014, 5:06 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115388/
> ---
> 
> (Updated Jan. 29, 2014, 5:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> QtScript is not used. QtGui is actually used rather than QtWidgets.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 536f7f33ca6ac25fc87966bf2bb4e2fc248c37fd 
>   src/kdeclarative.h 84f313302c70f9161ab2244c735166e08947f252 
> 
> Diff: https://git.reviewboard.kde.org/r/115388/diff/
> 
> 
> Testing
> ---
> 
> Builds. Didn't find any reference to QtScript or QtWidgets when inspecting 
> source.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115269: Improve dependency specifications

[Michael Palimaka]

> On Jan. 30, 2014, 11:47 a.m., Alex Merry wrote:
> > CMakeLists.txt, lines 52-55
> > 
> >
> > Make this unconditional (ie: replace all four lines by just the 
> > find_package line)

Will do, thanks.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/#review48598
---


On Jan. 23, 2014, 6:24 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115269/
> ---
> 
> (Updated Jan. 23, 2014, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdnssd-framework
> 
> 
> Description
> ---
> 
> KConfig is only required when DNSSD is found, and QtDBus is only required 
> when either Avahi or DNSSD is found, so don't require them unconditionally.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt defb7bbb70a6b7567e5d7d0e6b8097f57ad07a15 
>   src/CMakeLists.txt ef84ffa5ae5cfdfd2547c458e446cf4c9a2c7420 
> 
> Diff: https://git.reviewboard.kde.org/r/115269/diff/
> 
> 
> Testing
> ---
> 
> Still builds against Avahi, DNSSD, and neither backends.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115330: Deprecate KWindowSystem::transientFor and ::groupLeader

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115330/#review48620
---

Ship it!


Ship It!

- David Edmundson


On Jan. 27, 2014, 1:57 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115330/
> ---
> 
> (Updated Jan. 27, 2014, 1:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Deprecate KWindowSystem::transientFor and ::groupLeader
> 
> Same functionality is provided in the NETWinInfo class using XCB
> instead of XLib and is exported to the higher level API in
> KWindowInfo.
> 
> Thus implementation is changed to delegate to KWindowInfo and
> methods are deprecated to indicate that KWindowInfo should be
> used instead.
> 
> 
> Diffs
> -
> 
>   src/kwindowsystem_x11.cpp 395bb00e2c0933724e45aed60352cd9c707844d9 
>   src/kwindowsystem.h 3edcc810c82fe7f772e7c1be2266136c86f9f277 
> 
> Diff: https://git.reviewboard.kde.org/r/115330/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115255: Add x11 platform detection to kkeyserver_x11

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/#review48624
---

Ship it!


Ship It!

- David Edmundson


On Jan. 27, 2014, 8:37 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115255/
> ---
> 
> (Updated Jan. 27, 2014, 8:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add x11 platform detection to kkeyserver_x11
> 
> Just because it's only compiled for X11 doesn't mean it's running on
> X11. So before we go into code paths which call into X11 we should
> verify. That's better than:
> "QX11Info::display() returns 0.  I'm probably going to crash now."
> 
> Not adjusted are obvious X11 methods which take an XLib or xcb data
> type. If one calls those from non-x11 unconditionally it's an
> application bug and the application deserves to crash :-P
> 
> 
> Diffs
> -
> 
>   src/kkeyserver_x11.cpp fd0ca5b25f09808e211198ce0f7aa56aa21e05f4 
> 
> Diff: https://git.reviewboard.kde.org/r/115255/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48622
---



src/kstartupinfo.cpp


Does this need a runtime check?


- David Edmundson


On Jan. 27, 2014, 7:31 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115251/
> ---
> 
> (Updated Jan. 27, 2014, 7:31 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add better runtime detection for X11 usage in KStartupInfo
> 
> Compile time checks for X11 is no longer sufficient. This adds a
> runtime check to all the code paths which look dangerous if executed
> on a non-X11 platform.
> 
> 
> Diffs
> -
> 
>   src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 
> 
> Diff: https://git.reviewboard.kde.org/r/115251/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115269: Improve dependency specifications

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/
---

(Updated Jan. 30, 2014, 2:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdnssd-framework


Description
---

KConfig is only required when DNSSD is found, and QtDBus is only required when 
either Avahi or DNSSD is found, so don't require them unconditionally.


Diffs
-

  CMakeLists.txt defb7bbb70a6b7567e5d7d0e6b8097f57ad07a15 
  src/CMakeLists.txt ef84ffa5ae5cfdfd2547c458e446cf4c9a2c7420 

Diff: https://git.reviewboard.kde.org/r/115269/diff/


Testing
---

Still builds against Avahi, DNSSD, and neither backends.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115269: Improve dependency specifications

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115269/#review48625
---


This review has been submitted with commit 
a8e9c0599a2787337b8434e3a7800b31d2df0999 by Michael Palimaka to branch master.

- Commit Hook


On Jan. 23, 2014, 6:24 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115269/
> ---
> 
> (Updated Jan. 23, 2014, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdnssd-framework
> 
> 
> Description
> ---
> 
> KConfig is only required when DNSSD is found, and QtDBus is only required 
> when either Avahi or DNSSD is found, so don't require them unconditionally.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt defb7bbb70a6b7567e5d7d0e6b8097f57ad07a15 
>   src/CMakeLists.txt ef84ffa5ae5cfdfd2547c458e446cf4c9a2c7420 
> 
> Diff: https://git.reviewboard.kde.org/r/115269/diff/
> 
> 
> Testing
> ---
> 
> Still builds against Avahi, DNSSD, and neither backends.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kde4support entry.desktop

[Jonathan Riddell]

kde4support has some files which clash with the kdelibs4 equivalents.

/usr/share/locale/all_languages

which I proposed to change to kf5_all_lanuages

https://git.reviewboard.kde.org/r/115401/

But there's also /usr/share/locale/en_US/entry.desktop which clases
with the kdelibs4 equivalent.  Will langpacks continue to ship an
entry.desktop?  Should I rename them to kf5_entry.desktop and patch
klocale to use the updated one?

Jonathan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Transitive dependency checks

[Michael Palimaka]

On 01/30/2014 04:35 AM, Alex Merry wrote:
> On 29/01/14 17:29, Michael Palimaka wrote:
>> Hi,
>>
>> In a some (not all) tier 3 frameworks, we check for transitive dependencies:
>>
>> #NOTE: here the dependencies of dependencies are displayed as well, this
>> shouldn't be needed
>> #after cmake 3.0.0 is released
>> find_package(...)
>>
>> I think this is no longer needed since we ship CMake config files for
>> each framework which pull in the required dependencies, and a number of
>> frameworks already omit the transitive checks and work fine.
>>
>> I'd like to start sending review requests to clean this all up unless
>> anyone thinks this is not correct.
> 
> The issue, as I recall, was the *private* dependencies - ie: those not
> listed in the Config.cmake file.  I'm not sure exactly what issue it
> caused, though, as I never encountered any problems.  I wouldn't have
> thought that dynamic linking would produce any problems anyway; maybe
> static linking?  Or Windows?
> 
> Alex
> 

That makes a bit more sense, but I didn't run into that yet.

For example in kemoticons, it has normal dependencies on karchive and
kservice, with transitive dependencies on kcoreaddons, kdbusaddons, and
ki18n. Those transitive dependencies are then found anyway by
KF5ServiceConfig.cmake.

So I think it would be safe to drop the checks in this case at least.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: khtml_master_qt5 #27

[KDE CI System]

See 

Changes:

[martin.sandsmark] don't install unused dbus interface

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[khtml_master_qt5] $ /bin/sh -xe /tmp/hudson7189141827401450303.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/khtml
   1d3e4eb..24c50ce  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 1d3e4eb Add content from old Mainpage.dox to README.md
Removing build/
Removing install/
Success build forhudson.tasks.Shell@4b44354
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/khtml
Checking out Revision 24c50cea9c32be8661cbc4914d8f4c2767206937 
(refs/heads/jenkins)
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[khtml_master_qt5] $ /bin/sh -xe /tmp/hudson6290231230354438328.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: khtml - Branch master
== Build Dependencies:
 kjobwidgets - Branch master
 polkit-qt-1 - Branch qt5
 sonnet - Branch master
 kiconthemes - Branch master
 ki18n - Branch master
 solid - Branch master
 kcrash - Branch master
 kio - Branch master
 extra-cmake-modules - Branch master
 kguiaddons - Branch master
 ktextwidgets - Branch master
 kparts - Branch master
 knotifications - Branch master
 kcoreaddons - Branch master
 cmake - Branch master
 kxmlgui - Branch master
 kwindowsystem - Branch master
 kconfig - Branch master
 kconfigwidgets - Branch master
 kinit - Branch master
 kitemviews - Branch master
 kglobalaccel - Branch master
 kdbusaddons - Branch master
 kauth - Branch master
 kservice - Branch master
 kjs - Branch master
 kbookmarks - Branch master
 kdoctools - Branch master
 kcodecs - Branch master
 phonon - Branch master
 kwallet-framework - Branch master
 kwidgetsaddons - Branch master
 qt5 - Branch stable
 kcompletion - Branch master
 karchive - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found Perl: /usr/bin/perl (found version "5.16.2") 
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - 
found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib64/libX11.so
-- Found JPEG: /usr/lib64/libjpeg.so  
-- Performing Test GIF_GifFileType_UserData
-- Performing Test GIF_GifFileType_UserData - Success
-- Found GIF: /usr/lib64/libgif.so (found version "4") 
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.7") 
-- Found PNG: /usr/lib64/libpng.so (found version "1.5.13") 
-- Found OpenSSL: /usr/lib64/libssl.so;/usr/lib64/libcrypto.so (found version 
"1.0.1e") 
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- 
-- The following OPTIONAL packages have been found:

 * X11
 * ZLIB

-- The following RECOMMENDED packages have been found:

 * OpenSSL , Support for secure network communications (SSL and TLS) , 

   KDE uses OpenSSL for the bulk of secure communications, including secure web 
browsing via HTTPS

-- The following REQUIRED packages have been found:

 * Qt5Core (required version >= 5.2.0)
 * ECM (required version >= 0.0.9)
 * Qt5Gui (required version >= 5.2.2)
 * Qt5Widgets
 * Qt5Network
 * Qt5DBus
 * Qt5PrintSupport
 * Qt5Xml
 * Qt5Test
 * KF5Archive (requ

Re: Review Request 115398: rename dbus interface to prevent clashes with khtml from kdelibs4

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115398/#review48637
---


closing as commented out in 
http://quickgit.kde.org/?p=khtml.git&a=commit&h=24c50cea9c32be8661cbc4914d8f4c2767206937
15:35 < sandsmark> seems to be a not-too-closely-looked-at leftover from dcop 
days


- Jonathan Riddell


On Jan. 30, 2014, 12:38 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115398/
> ---
> 
> (Updated Jan. 30, 2014, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> ---
> 
> rename dbus interface to prevent clashes with khtml from kdelibs4
> alas I have no idea what applications provide this interface
> 
> 
> Diffs
> -
> 
>   src/khtml_iface.h 07fbf32 
>   src/CMakeLists.txt 841edbd 
> 
> Diff: https://git.reviewboard.kde.org/r/115398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115398: rename dbus interface to prevent clashes with khtml from kdelibs4

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115398/
---

(Updated Jan. 30, 2014, 3:36 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: khtml


Description
---

rename dbus interface to prevent clashes with khtml from kdelibs4
alas I have no idea what applications provide this interface


Diffs
-

  src/khtml_iface.h 07fbf32 
  src/CMakeLists.txt 841edbd 

Diff: https://git.reviewboard.kde.org/r/115398/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : khtml_master_qt5 #28

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Transitive dependency checks

[Aurélien Gâteau]

On Wed, Jan 29, 2014, at 9:35, Alex Merry wrote:
> On 29/01/14 17:29, Michael Palimaka wrote:
> > Hi,
> > 
> > In a some (not all) tier 3 frameworks, we check for transitive dependencies:
> > 
> > #NOTE: here the dependencies of dependencies are displayed as well, this
> > shouldn't be needed
> > #after cmake 3.0.0 is released
> > find_package(...)
> > 
> > I think this is no longer needed since we ship CMake config files for
> > each framework which pull in the required dependencies, and a number of
> > frameworks already omit the transitive checks and work fine.
> > 
> > I'd like to start sending review requests to clean this all up unless
> > anyone thinks this is not correct.
> 
> The issue, as I recall, was the *private* dependencies - ie: those not
> listed in the Config.cmake file.  I'm not sure exactly what issue it
> caused, though, as I never encountered any problems.  I wouldn't have
> thought that dynamic linking would produce any problems anyway; maybe
> static linking?  Or Windows?

The issue only occurred with CMake 2.8.12 when building kdelibs as a
whole. It is no longer a problem now that the repositories have been
split. Therefore, I think you can go on and remove those dependencies.

Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

[Fredrik Höglund]

> On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote:
> > given the ratio by this property is set (often) and read (rarely), i wonder 
> > whether we could establish a semi-async functionality, where the client 
> > sends a message to have the property updated, then syncs, reads and returns 
> > the updated property?
> > 
> > reg. screen ./. output terminology:
> > we've "active screen" everywhere and we can probably not expose the 
> > screen/output problem to end users.
> > Also Qt talks of screen in this regard.
> > I'd suggest to keep activeScreen and specify the meaning in the comment.
> >
> 
> Martin Gräßlin wrote:
> > i wonder whether we could establish a semi-async functionality, where 
> the client sends a message to have the property updated, then syncs, reads 
> and returns the updated property?
> 
> That would be different to how all the other methods in KWindowSystem 
> works. What could be considered is not having a signal to not wake up the 
> clients or only emit the signal if connect-notify is called.
> 
> > Also Qt talks of screen in this regard.
> 
> This was the reason why I went with screen in the first place. The class 
> is called QScreen and not QOutput. Calling it output didn't occur to me at 
> all. I don't mind how it is called and from a technical perspective 
> (especially considering XRandR) I agree with Fredrik. But from a user point 
> of view I think screen is the better name due to the QScreen anology. What 
> could be done is using output in the NET class to be closer to the X11 world, 
> but keep the name screen in the abstraction. I don't know whether output 
> makes sense on Windows or Mac (in case they ever implement it).
> 
> Thomas Lübking wrote:
> > That would be different to how all the other methods in KWindowSystem 
> works.
> My major concern would be the mouse driven active screen.
> Right now, when the active screen is required, kwin just checks the 
> current mouse position.
> When we need to keep the info updated (signal or not), that means that 
> kwin has to poll the mouse all the time (even if we would "smoothen" the 
> update by a timer so the active screen isn't updated a 1000 times when moving 
> the cursor around a screen edge).
> 
> And while knowing the "active" screen is certainly nice, our main concern 
> right now is the occasional raiseOrLower taskbar case.
> 
> A 2-pass query would nicely circumvent this as the data only needs to be 
> updated when really and likely rarely required.

kwin should be using XI2 instead of polling.

We already have properties that are updated every time the stacking order 
changes
and every time the active window changes.  Given that, I don't think the update
frequency for this property is going to be a problem.

So with regards to the terminology, this is what we're looking at:

X   | Qt
+-
Output  | Screen
Screen  | Virtual desktop
Virtual desktop | ?

Which is just really unfortunate.  It's bound to cause confusion no matter
which name we pick, and it doesn't help that the QScreen documentation
doesn't explain the terminology.

Windows and Wayland also use "output", while I think Mac OS uses "display".


- Fredrik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/#review47824
---


On Jan. 20, 2014, 1:14 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115137/
> ---
> 
> (Updated Jan. 20, 2014, 1:14 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and kwin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> The rational for these changes is based on the discussion in 
> http://article.gmane.org/gmane.comp.kde.devel.plasma/27579/
> 
> Plasma needs to know which is the active screen and so far only KWin knows 
> it, so we need to make everybody aware of it.
> 
> ---
> Add convenient wrapper for active screen to KWindowSystem
> 
> A method is added to get the identifier of the active screen as a
> QString and a signal whenever the active screen changes. This method
> is only provided for X11, on Windows and Mac a null QString is returned
> as the identifier.
> 
> Add an active screen property to NETRootInfo
> 
> The active screen is intended to be set by KWin to the active screen
> it's using. This can be used by a Client to manually position e.g.
> override redirect windows on the active screen. It's intended as a help
> for multi-screen setups where a Client can only do guesses on where to
> position e.g. a notification window.
> 
> It's a KDE specific extension as property _KDE_NET_ACTIVE_SCREEN and
> announced

Re: Transitive dependency checks

[Michael Palimaka]

On 01/31/2014 03:12 AM, Aurélien Gâteau wrote:
> On Wed, Jan 29, 2014, at 9:35, Alex Merry wrote:
>> On 29/01/14 17:29, Michael Palimaka wrote:
>>> Hi,
>>>
>>> In a some (not all) tier 3 frameworks, we check for transitive dependencies:
>>>
>>> #NOTE: here the dependencies of dependencies are displayed as well, this
>>> shouldn't be needed
>>> #after cmake 3.0.0 is released
>>> find_package(...)
>>>
>>> I think this is no longer needed since we ship CMake config files for
>>> each framework which pull in the required dependencies, and a number of
>>> frameworks already omit the transitive checks and work fine.
>>>
>>> I'd like to start sending review requests to clean this all up unless
>>> anyone thinks this is not correct.
>>
>> The issue, as I recall, was the *private* dependencies - ie: those not
>> listed in the Config.cmake file.  I'm not sure exactly what issue it
>> caused, though, as I never encountered any problems.  I wouldn't have
>> thought that dynamic linking would produce any problems anyway; maybe
>> static linking?  Or Windows?
> 
> The issue only occurred with CMake 2.8.12 when building kdelibs as a
> whole. It is no longer a problem now that the repositories have been
> split. Therefore, I think you can go on and remove those dependencies.
> 
> Aurélien
> 

Thanks, I will start checking individual frameworks and filing review
requests then.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115404: Improve dependencies

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/
---

Review request for KDE Frameworks.


Repository: kemoticons


Description
---

- Remove transitive dependencies as per mailing list
- Add missing KF5Config dependency
- QtGui is used rather than QtWidgets by the framework.
- QtWidgets is only used for tests


Diffs
-

  tests/CMakeLists.txt a3016c172f18559a98771c9d7da53cfdc758adad 
  src/core/CMakeLists.txt 9bc9a1c1a995f488185dfd19ef25bcc1f9e8a483 
  KF5EmoticonsConfig.cmake.in 9b0efbc99cfed73c13e49c940cd5607afba85f07 
  CMakeLists.txt a48d111c59aa42d5b0b85aa959e5cf10e7b974b0 

Diff: https://git.reviewboard.kde.org/r/115404/diff/


Testing
---

Builds. Inspected source to verify changes.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Transitive dependency checks

[Alex Merry]

On 30/01/14 16:12, Aurélien Gâteau wrote:
> The issue only occurred with CMake 2.8.12 when building kdelibs as a
> whole. It is no longer a problem now that the repositories have been
> split. Therefore, I think you can go on and remove those dependencies.

I don't understand that - all the dependency checks are in if() clauses
that mean they are only looked for when built in split mode.  So the
problem must have been during a split build.

If we can't track down what the exact error was, we at least need to
test the changes with cmake 2.8.12.0 (and not the lastest git version,
as I expect most of us are using via kdesrc-build).

I'm building the v2.8.12 tag, and I'll try to test some frameworks with
removed transitive dependency checks (probably tomorrow, realisticly).
In the meantime, please don't commit any removals of these checks
without testing using 2.8.12.0.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

[Thomas Lübking]

> On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote:
> > given the ratio by this property is set (often) and read (rarely), i wonder 
> > whether we could establish a semi-async functionality, where the client 
> > sends a message to have the property updated, then syncs, reads and returns 
> > the updated property?
> > 
> > reg. screen ./. output terminology:
> > we've "active screen" everywhere and we can probably not expose the 
> > screen/output problem to end users.
> > Also Qt talks of screen in this regard.
> > I'd suggest to keep activeScreen and specify the meaning in the comment.
> >
> 
> Martin Gräßlin wrote:
> > i wonder whether we could establish a semi-async functionality, where 
> the client sends a message to have the property updated, then syncs, reads 
> and returns the updated property?
> 
> That would be different to how all the other methods in KWindowSystem 
> works. What could be considered is not having a signal to not wake up the 
> clients or only emit the signal if connect-notify is called.
> 
> > Also Qt talks of screen in this regard.
> 
> This was the reason why I went with screen in the first place. The class 
> is called QScreen and not QOutput. Calling it output didn't occur to me at 
> all. I don't mind how it is called and from a technical perspective 
> (especially considering XRandR) I agree with Fredrik. But from a user point 
> of view I think screen is the better name due to the QScreen anology. What 
> could be done is using output in the NET class to be closer to the X11 world, 
> but keep the name screen in the abstraction. I don't know whether output 
> makes sense on Windows or Mac (in case they ever implement it).
> 
> Thomas Lübking wrote:
> > That would be different to how all the other methods in KWindowSystem 
> works.
> My major concern would be the mouse driven active screen.
> Right now, when the active screen is required, kwin just checks the 
> current mouse position.
> When we need to keep the info updated (signal or not), that means that 
> kwin has to poll the mouse all the time (even if we would "smoothen" the 
> update by a timer so the active screen isn't updated a 1000 times when moving 
> the cursor around a screen edge).
> 
> And while knowing the "active" screen is certainly nice, our main concern 
> right now is the occasional raiseOrLower taskbar case.
> 
> A 2-pass query would nicely circumvent this as the data only needs to be 
> updated when really and likely rarely required.
> 
> Fredrik Höglund wrote:
> kwin should be using XI2 instead of polling.
> 
> We already have properties that are updated every time the stacking order 
> changes
> and every time the active window changes.  Given that, I don't think the 
> update
> frequency for this property is going to be a problem.
> 
> So with regards to the terminology, this is what we're looking at:
> 
> X   | Qt
> +-
> Output  | Screen
> Screen  | Virtual desktop
> Virtual desktop | ?
> 
> Which is just really unfortunate.  It's bound to cause confusion no matter
> which name we pick, and it doesn't help that the QScreen documentation
> doesn't explain the terminology.
> 
> Windows and Wayland also use "output", while I think Mac OS uses 
> "display".
>

> kwin should be using XI2 instead of polling
yes, "should" - https://git.reviewboard.kde.org/r/111875/


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/#review47824
---


On Jan. 20, 2014, 1:14 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115137/
> ---
> 
> (Updated Jan. 20, 2014, 1:14 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and kwin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> The rational for these changes is based on the discussion in 
> http://article.gmane.org/gmane.comp.kde.devel.plasma/27579/
> 
> Plasma needs to know which is the active screen and so far only KWin knows 
> it, so we need to make everybody aware of it.
> 
> ---
> Add convenient wrapper for active screen to KWindowSystem
> 
> A method is added to get the identifier of the active screen as a
> QString and a signal whenever the active screen changes. This method
> is only provided for X11, on Windows and Mac a null QString is returned
> as the identifier.
> 
> Add an active screen property to NETRootInfo
> 
> The active screen is intended to be set by KWin to the active screen
> it's using. This can be used by a Client to manually position e.g.
> override redir

Re: Review Request 115404: Improve dependencies

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/#review48652
---


Builds with what version of CMake?  Please test with 2.8.12.0 (for the 
transitive deps, at least).

- Alex Merry


On Jan. 30, 2014, 5:32 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115404/
> ---
> 
> (Updated Jan. 30, 2014, 5:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> - Remove transitive dependencies as per mailing list
> - Add missing KF5Config dependency
> - QtGui is used rather than QtWidgets by the framework.
> - QtWidgets is only used for tests
> 
> 
> Diffs
> -
> 
>   tests/CMakeLists.txt a3016c172f18559a98771c9d7da53cfdc758adad 
>   src/core/CMakeLists.txt 9bc9a1c1a995f488185dfd19ef25bcc1f9e8a483 
>   KF5EmoticonsConfig.cmake.in 9b0efbc99cfed73c13e49c940cd5607afba85f07 
>   CMakeLists.txt a48d111c59aa42d5b0b85aa959e5cf10e7b974b0 
> 
> Diff: https://git.reviewboard.kde.org/r/115404/diff/
> 
> 
> Testing
> ---
> 
> Builds. Inspected source to verify changes.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Authors, maintainers and licenses in apidox

[Jonathan Riddell]

A bigger problem is there's no copyright holder or licence for this framework, 
anyone know how to find those?

Jonathan


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Change the ML default reply-to address

[Martin Klapetek]

As there were no real objections and lots of +1s, I'm going to request this
change.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: add test for QFileDialog::getExistingDirectory / bug?

[Dominik Haumann]

On Tuesday 28 January 2014 15:05:30 Kevin Funk wrote:
> Am Sonntag, 26. Januar 2014, 18:53:42 schrieb Gregor Mi:
> > With another addition to qfiledialogtest in
> > frameworks/frameworkintegration another potential bug can be exposed:
> > 
> > Calling
> > 
> > $ ./qfiledialogtest --nameFilter "c (*.cpp)" --nameFilter "h (*.h)"
> > --selectNameFilter "h (*.h)"
> 
> Works for me. Using Qt 5.2.0, if that matters.

Kevin, what exactly "works" here?

Both tests do not work here: The first one for getting an existing directory, 
I have to choose a file, otherwise I cannot click Open. Probably the entire 
dialog is wrong, since I don't want a *file* dialog here. Instead, I want a 
dialog that shows a tree view of the folders, or am I wrong here?

For the text above, --selectNameFilter is set to the "h" filter. But starting 
the dialog preselects the "c" filter here. So to me this looks like it doesn't 
work.

Can you elaborate? ;)

Greetings,
Dominik
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/
---

(Updated Jan. 30, 2014, 10:59 p.m.)


Review request for KDE Frameworks.


Changes
---

Fix issues noted by Aurélien Gâteau


Repository: kcompletion


Description
---

To make kcompletion.h smaller, split KCompletionBase class from it into its own 
header file.


Diffs (updated)
-

  src/klineedit.h f1107e2 
  src/kcompletionbase.h PRE-CREATION 
  src/kcompletionbase.cpp 252b613 
  src/kcompletion.h fa0731e 
  src/kcombobox.h f34d259 
  src/CMakeLists.txt 05452ab 

Diff: https://git.reviewboard.kde.org/r/115394/diff/


Testing
---

It builds. Tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Authors, maintainers and licenses in apidox

[Alex Merry]

On 30/01/14 18:34, Jonathan Riddell wrote:
> 
> A bigger problem is there's no copyright holder or licence for this 
> framework, anyone know how to find those?

Which framework?  Do you mean kapidox?

All the Python files should have copyright headers at the top, and the
LICENSE file says it is BSD-licensed (although, as per this thread, I
think this should become a section in the README.md).

Alex

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115330: Deprecate KWindowSystem::transientFor and ::groupLeader

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115330/
---

(Updated Jan. 31, 2014, 7:54 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

Deprecate KWindowSystem::transientFor and ::groupLeader

Same functionality is provided in the NETWinInfo class using XCB
instead of XLib and is exported to the higher level API in
KWindowInfo.

Thus implementation is changed to delegate to KWindowInfo and
methods are deprecated to indicate that KWindowInfo should be
used instead.


Diffs
-

  src/kwindowsystem_x11.cpp 395bb00e2c0933724e45aed60352cd9c707844d9 
  src/kwindowsystem.h 3edcc810c82fe7f772e7c1be2266136c86f9f277 

Diff: https://git.reviewboard.kde.org/r/115330/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115330: Deprecate KWindowSystem::transientFor and ::groupLeader

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115330/#review48667
---


This review has been submitted with commit 
56d4868a101a303bf75267d978c28064b36edfef by Martin Gräßlin to branch master.

- Commit Hook


On Jan. 27, 2014, 1:57 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115330/
> ---
> 
> (Updated Jan. 27, 2014, 1:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Deprecate KWindowSystem::transientFor and ::groupLeader
> 
> Same functionality is provided in the NETWinInfo class using XCB
> instead of XLib and is exported to the higher level API in
> KWindowInfo.
> 
> Thus implementation is changed to delegate to KWindowInfo and
> methods are deprecated to indicate that KWindowInfo should be
> used instead.
> 
> 
> Diffs
> -
> 
>   src/kwindowsystem_x11.cpp 395bb00e2c0933724e45aed60352cd9c707844d9 
>   src/kwindowsystem.h 3edcc810c82fe7f772e7c1be2266136c86f9f277 
> 
> Diff: https://git.reviewboard.kde.org/r/115330/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115255: Add x11 platform detection to kkeyserver_x11

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/#review48668
---


This review has been submitted with commit 
a8c58f3ff888729556108caf37ff6e67bacd8474 by Martin Gräßlin to branch master.

- Commit Hook


On Jan. 27, 2014, 8:37 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115255/
> ---
> 
> (Updated Jan. 27, 2014, 8:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add x11 platform detection to kkeyserver_x11
> 
> Just because it's only compiled for X11 doesn't mean it's running on
> X11. So before we go into code paths which call into X11 we should
> verify. That's better than:
> "QX11Info::display() returns 0.  I'm probably going to crash now."
> 
> Not adjusted are obvious X11 methods which take an XLib or xcb data
> type. If one calls those from non-x11 unconditionally it's an
> application bug and the application deserves to crash :-P
> 
> 
> Diffs
> -
> 
>   src/kkeyserver_x11.cpp fd0ca5b25f09808e211198ce0f7aa56aa21e05f4 
> 
> Diff: https://git.reviewboard.kde.org/r/115255/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115255: Add x11 platform detection to kkeyserver_x11

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/
---

(Updated Jan. 31, 2014, 7:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

Add x11 platform detection to kkeyserver_x11

Just because it's only compiled for X11 doesn't mean it's running on
X11. So before we go into code paths which call into X11 we should
verify. That's better than:
"QX11Info::display() returns 0.  I'm probably going to crash now."

Not adjusted are obvious X11 methods which take an XLib or xcb data
type. If one calls those from non-x11 unconditionally it's an
application bug and the application deserves to crash :-P


Diffs
-

  src/kkeyserver_x11.cpp fd0ca5b25f09808e211198ce0f7aa56aa21e05f4 

Diff: https://git.reviewboard.kde.org/r/115255/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel