Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

[Michael Hansen]

> On March 23, 2014, 4:39 p.m., Aleix Pol Gonzalez wrote:
> > src/colors/kcolorutils.cpp, line 38
> > 
> >
> > Wouldn't it make more sense to use qIsNan?
> > 
> > http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN
> 
> Alex Merry wrote:
> Huh.  Yes.  Doing work on KJS had me in the wrong mindset :-)

D'oh, I should have thought of that >.<


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866/#review53877
---


On March 22, 2014, 1:54 p.m., Michael Hansen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116866/
> ---
> 
> (Updated March 22, 2014, 1:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Use std::isnan from  instead of isnan from , as MinGW-32 on 
> Windows does not include the latter.  This keeps the _isnan hack for MSVC, 
> since that compiler doesn't include either standard version :(.
> 
> 
> Diffs
> -
> 
>   src/kguiaddons_config.h.cmake PRE-CREATION 
>   src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 
>   src/ConfigureChecks.cmake PRE-CREATION 
>   src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 
> 
> Diff: https://git.reviewboard.kde.org/r/116866/diff/
> 
> 
> Testing
> ---
> 
> Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 
> 4.8 (Arch x86_64).
> 
> 
> Thanks,
> 
> Michael Hansen
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117042/#review54053
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On March 24, 2014, 11:28 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117042/
> ---
> 
> (Updated March 24, 2014, 11:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> Make KLineEdit::completionBox virtual so that konq can reimplement it (as 
> suggested in a comment)
> 
> 
> Diffs
> -
> 
>   src/klineedit.h 723cb42 
> 
> Diff: https://git.reviewboard.kde.org/r/117042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117037: Refactor parameter names

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117037/#review54052
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On March 24, 2014, 11:17 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117037/
> ---
> 
> (Updated March 24, 2014, 11:17 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> Refactor parameter names
> 
> Also add #ifndef KCOMPLETION_NO_DEPRECATED around the implementation of 
> KLineEdit::setUrlDropsEnabled()
> 
> 
> Diffs
> -
> 
>   src/kcombobox.h 80d6573 
>   src/kcombobox.cpp cbb209e 
>   src/kcompletion.h 3b3b0a6 
>   src/kcompletion.cpp 847cff3 
>   src/kcompletionbox.h f396746 
>   src/kcompletionbox.cpp 7753643 
>   src/khistorycombobox.h d1f5eac 
>   src/khistorycombobox.cpp 80261ae 
>   src/klineedit.h 723cb42 
>   src/klineedit.cpp b426767 
>   src/klineedit_p.h 397abc2 
> 
> Diff: https://git.reviewboard.kde.org/r/117037/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116955: Remove KDE 4 refs from Doxyfile.global

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116955/
---

(Updated March 24, 2014, 11:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Aurélien Gâteau.


Repository: kapidox


Description
---

Remove KDE 4 refs from Doxyfile.global

The "port4" command is no longer relevant, and "@glossary" now just says
"Glossary" instead of "KDE 4 Glossary".


Diffs
-

  src/kapidox/data/Doxyfile.global 96cb1c13ffeb78d0e35460c7697342a878d97786 

Diff: https://git.reviewboard.kde.org/r/116955/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116955: Remove KDE 4 refs from Doxyfile.global

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116955/#review54050
---


This review has been submitted with commit 
bcbae14c0f7319a592b526b53d77358adc5e5991 by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 4:19 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116955/
> ---
> 
> (Updated March 21, 2014, 4:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Remove KDE 4 refs from Doxyfile.global
> 
> The "port4" command is no longer relevant, and "@glossary" now just says
> "Glossary" instead of "KDE 4 Glossary".
> 
> 
> Diffs
> -
> 
>   src/kapidox/data/Doxyfile.global 96cb1c13ffeb78d0e35460c7697342a878d97786 
> 
> Diff: https://git.reviewboard.kde.org/r/116955/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kemoticons_master_qt5 #29

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116876: Add default emoticons theme to kemoticons

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116876/#review54049
---


This review has been submitted with commit 
17f7505d56d13e89a7eb71ecd023074cc2fe16cd by Alex Merry to branch master.

- Commit Hook


On March 18, 2014, 3:58 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116876/
> ---
> 
> (Updated March 18, 2014, 3:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> Make the autotests work uninstalled
> 
> This also makes them data-driven, separating out the different testcases
> in the output, and fixes the "skipping" behaviour (so QSKIP only skips
> one testcase and not all of them).
> 
> 
> Add a default theme
> 
> This was originally the default theme from Kopete, and was called "kde4"
> up until this point.
> 
> To trace its history, start at:
> svn path=/trunk/KDE/kdebase/runtime/; revision=699615
> which is also commit a9552cba75e67fb886921d1abc2cb2a09e6efbad of
> kde-runtime.
> 
> 
> I didn't copy the history from kde-runtime, because there was no history to 
> copy - only the commit noted above actually made it out of svn.
> 
> 
> Diffs
> -
> 
>   themes/Glass/sleep.png PRE-CREATION 
>   themes/Glass/shade.png PRE-CREATION 
>   themes/Glass/rose.png PRE-CREATION 
>   themes/Glass/sad.png PRE-CREATION 
>   themes/Glass/present.png PRE-CREATION 
>   themes/Glass/phone.png PRE-CREATION 
>   themes/Glass/omg.png PRE-CREATION 
>   themes/Glass/note.png PRE-CREATION 
>   themes/Glass/oh.png PRE-CREATION 
>   themes/Glass/love.png PRE-CREATION 
>   CMakeLists.txt de080764f7d387871ebebf6bfa7541944b618036 
>   autotests/CMakeLists.txt 98b8e43b2f5cbe08dc6b454e2736e809538a0251 
>   autotests/kemoticontest.h ba31c0bd50b8bf6a75844fb9c41ffdedd6fc34d5 
>   autotests/kemoticontest.cpp b7dc6f75fb722d63936fb666a51b969d37b84e31 
>   src/core/kemoticons.cpp bc72e166586ef1271cac2291a9223c2472e1d8b8 
>   tests/main.cpp 13f584a153fbd3612e8702d05368960d6e8e4e59 
>   themes/CMakeLists.txt PRE-CREATION 
>   themes/Glass/angry.png PRE-CREATION 
>   themes/Glass/bat.png PRE-CREATION 
>   themes/Glass/beer.png PRE-CREATION 
>   themes/Glass/biggrin.png PRE-CREATION 
>   themes/Glass/cake.png PRE-CREATION 
>   themes/Glass/camera.png PRE-CREATION 
>   themes/Glass/cat.png PRE-CREATION 
>   themes/Glass/clock.png PRE-CREATION 
>   themes/Glass/cocktail.png PRE-CREATION 
>   themes/Glass/confused.png PRE-CREATION 
>   themes/Glass/cry.png PRE-CREATION 
>   themes/Glass/cup.png PRE-CREATION 
>   themes/Glass/dog.png PRE-CREATION 
>   themes/Glass/email.png PRE-CREATION 
>   themes/Glass/embarassed.png PRE-CREATION 
>   themes/Glass/emoticons.xml PRE-CREATION 
>   themes/Glass/film.png PRE-CREATION 
>   themes/Glass/foot_in_mouth.png PRE-CREATION 
>   themes/Glass/innocent.png PRE-CREATION 
>   themes/Glass/kiss.png PRE-CREATION 
>   themes/Glass/lightbulb.png PRE-CREATION 
>   themes/Glass/smile.png PRE-CREATION 
>   themes/Glass/star.png PRE-CREATION 
>   themes/Glass/teeth.png PRE-CREATION 
>   themes/Glass/thumbs_down.png PRE-CREATION 
>   themes/Glass/thumbs_up.png PRE-CREATION 
>   themes/Glass/tongue.png PRE-CREATION 
>   themes/Glass/undecided.png PRE-CREATION 
>   themes/Glass/unhappy.png PRE-CREATION 
>   themes/Glass/unlove.png PRE-CREATION 
>   themes/Glass/wilted_rose.png PRE-CREATION 
>   themes/Glass/wink.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116876/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, tests pass without skipping (both before and after 
> installation).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116876: Add default emoticons theme to kemoticons

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116876/
---

(Updated March 24, 2014, 11:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kemoticons


Description
---

Make the autotests work uninstalled

This also makes them data-driven, separating out the different testcases
in the output, and fixes the "skipping" behaviour (so QSKIP only skips
one testcase and not all of them).


Add a default theme

This was originally the default theme from Kopete, and was called "kde4"
up until this point.

To trace its history, start at:
svn path=/trunk/KDE/kdebase/runtime/; revision=699615
which is also commit a9552cba75e67fb886921d1abc2cb2a09e6efbad of
kde-runtime.


I didn't copy the history from kde-runtime, because there was no history to 
copy - only the commit noted above actually made it out of svn.


Diffs
-

  themes/Glass/sleep.png PRE-CREATION 
  themes/Glass/shade.png PRE-CREATION 
  themes/Glass/rose.png PRE-CREATION 
  themes/Glass/sad.png PRE-CREATION 
  themes/Glass/present.png PRE-CREATION 
  themes/Glass/phone.png PRE-CREATION 
  themes/Glass/omg.png PRE-CREATION 
  themes/Glass/note.png PRE-CREATION 
  themes/Glass/oh.png PRE-CREATION 
  themes/Glass/love.png PRE-CREATION 
  CMakeLists.txt de080764f7d387871ebebf6bfa7541944b618036 
  autotests/CMakeLists.txt 98b8e43b2f5cbe08dc6b454e2736e809538a0251 
  autotests/kemoticontest.h ba31c0bd50b8bf6a75844fb9c41ffdedd6fc34d5 
  autotests/kemoticontest.cpp b7dc6f75fb722d63936fb666a51b969d37b84e31 
  src/core/kemoticons.cpp bc72e166586ef1271cac2291a9223c2472e1d8b8 
  tests/main.cpp 13f584a153fbd3612e8702d05368960d6e8e4e59 
  themes/CMakeLists.txt PRE-CREATION 
  themes/Glass/angry.png PRE-CREATION 
  themes/Glass/bat.png PRE-CREATION 
  themes/Glass/beer.png PRE-CREATION 
  themes/Glass/biggrin.png PRE-CREATION 
  themes/Glass/cake.png PRE-CREATION 
  themes/Glass/camera.png PRE-CREATION 
  themes/Glass/cat.png PRE-CREATION 
  themes/Glass/clock.png PRE-CREATION 
  themes/Glass/cocktail.png PRE-CREATION 
  themes/Glass/confused.png PRE-CREATION 
  themes/Glass/cry.png PRE-CREATION 
  themes/Glass/cup.png PRE-CREATION 
  themes/Glass/dog.png PRE-CREATION 
  themes/Glass/email.png PRE-CREATION 
  themes/Glass/embarassed.png PRE-CREATION 
  themes/Glass/emoticons.xml PRE-CREATION 
  themes/Glass/film.png PRE-CREATION 
  themes/Glass/foot_in_mouth.png PRE-CREATION 
  themes/Glass/innocent.png PRE-CREATION 
  themes/Glass/kiss.png PRE-CREATION 
  themes/Glass/lightbulb.png PRE-CREATION 
  themes/Glass/smile.png PRE-CREATION 
  themes/Glass/star.png PRE-CREATION 
  themes/Glass/teeth.png PRE-CREATION 
  themes/Glass/thumbs_down.png PRE-CREATION 
  themes/Glass/thumbs_up.png PRE-CREATION 
  themes/Glass/tongue.png PRE-CREATION 
  themes/Glass/undecided.png PRE-CREATION 
  themes/Glass/unhappy.png PRE-CREATION 
  themes/Glass/unlove.png PRE-CREATION 
  themes/Glass/wilted_rose.png PRE-CREATION 
  themes/Glass/wink.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116876/diff/


Testing
---

Builds, installs, tests pass without skipping (both before and after 
installation).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116876: Add default emoticons theme to kemoticons

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116876/#review54048
---


This review has been submitted with commit 
9c2397e2666a2fd058b85516c37558e9f7278920 by Alex Merry to branch master.

- Commit Hook


On March 18, 2014, 3:58 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116876/
> ---
> 
> (Updated March 18, 2014, 3:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> Make the autotests work uninstalled
> 
> This also makes them data-driven, separating out the different testcases
> in the output, and fixes the "skipping" behaviour (so QSKIP only skips
> one testcase and not all of them).
> 
> 
> Add a default theme
> 
> This was originally the default theme from Kopete, and was called "kde4"
> up until this point.
> 
> To trace its history, start at:
> svn path=/trunk/KDE/kdebase/runtime/; revision=699615
> which is also commit a9552cba75e67fb886921d1abc2cb2a09e6efbad of
> kde-runtime.
> 
> 
> I didn't copy the history from kde-runtime, because there was no history to 
> copy - only the commit noted above actually made it out of svn.
> 
> 
> Diffs
> -
> 
>   themes/Glass/sleep.png PRE-CREATION 
>   themes/Glass/shade.png PRE-CREATION 
>   themes/Glass/rose.png PRE-CREATION 
>   themes/Glass/sad.png PRE-CREATION 
>   themes/Glass/present.png PRE-CREATION 
>   themes/Glass/phone.png PRE-CREATION 
>   themes/Glass/omg.png PRE-CREATION 
>   themes/Glass/note.png PRE-CREATION 
>   themes/Glass/oh.png PRE-CREATION 
>   themes/Glass/love.png PRE-CREATION 
>   CMakeLists.txt de080764f7d387871ebebf6bfa7541944b618036 
>   autotests/CMakeLists.txt 98b8e43b2f5cbe08dc6b454e2736e809538a0251 
>   autotests/kemoticontest.h ba31c0bd50b8bf6a75844fb9c41ffdedd6fc34d5 
>   autotests/kemoticontest.cpp b7dc6f75fb722d63936fb666a51b969d37b84e31 
>   src/core/kemoticons.cpp bc72e166586ef1271cac2291a9223c2472e1d8b8 
>   tests/main.cpp 13f584a153fbd3612e8702d05368960d6e8e4e59 
>   themes/CMakeLists.txt PRE-CREATION 
>   themes/Glass/angry.png PRE-CREATION 
>   themes/Glass/bat.png PRE-CREATION 
>   themes/Glass/beer.png PRE-CREATION 
>   themes/Glass/biggrin.png PRE-CREATION 
>   themes/Glass/cake.png PRE-CREATION 
>   themes/Glass/camera.png PRE-CREATION 
>   themes/Glass/cat.png PRE-CREATION 
>   themes/Glass/clock.png PRE-CREATION 
>   themes/Glass/cocktail.png PRE-CREATION 
>   themes/Glass/confused.png PRE-CREATION 
>   themes/Glass/cry.png PRE-CREATION 
>   themes/Glass/cup.png PRE-CREATION 
>   themes/Glass/dog.png PRE-CREATION 
>   themes/Glass/email.png PRE-CREATION 
>   themes/Glass/embarassed.png PRE-CREATION 
>   themes/Glass/emoticons.xml PRE-CREATION 
>   themes/Glass/film.png PRE-CREATION 
>   themes/Glass/foot_in_mouth.png PRE-CREATION 
>   themes/Glass/innocent.png PRE-CREATION 
>   themes/Glass/kiss.png PRE-CREATION 
>   themes/Glass/lightbulb.png PRE-CREATION 
>   themes/Glass/smile.png PRE-CREATION 
>   themes/Glass/star.png PRE-CREATION 
>   themes/Glass/teeth.png PRE-CREATION 
>   themes/Glass/thumbs_down.png PRE-CREATION 
>   themes/Glass/thumbs_up.png PRE-CREATION 
>   themes/Glass/tongue.png PRE-CREATION 
>   themes/Glass/undecided.png PRE-CREATION 
>   themes/Glass/unhappy.png PRE-CREATION 
>   themes/Glass/unlove.png PRE-CREATION 
>   themes/Glass/wilted_rose.png PRE-CREATION 
>   themes/Glass/wink.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116876/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, tests pass without skipping (both before and after 
> installation).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Alex Merry]

> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote:
> > What about QStandardPaths::findExecutable? Actually this one should look 
> > into libexec too (at least the equivalent KStandardDirs::findExe used to).
> 
> Alex Merry wrote:
> I'm pretty sure QStandardPaths won't look at libexec.  How should it know 
> where libexec stuff is?  The whole point of libexec is that it is 
> library-private (TBH it's slightly hacky to have a "kde5" libexec dir in 
> $LIB/kde5/libexec; really, each library should have its own dir).
> 
> Hrvoje Senjan wrote:
> additionally, i think this will actually open drkonqi(4) (if 
> kde-runtime(4) is also installed), no?
> 
> Dan Vrátil wrote:
> The idea is that it does not find anything and fallsback to 
> CMAKE_INSTALL_DIR/LIBEXEC_INSTALL_DIR, but allows us to override it by PATH 
> in case we use some prefix, like /opt/kde5. Obviously if people mess with 
> their PATH they might get weird results like starting drkonqi4, but that's 
> simply their problem.

If anything, I'd rather use a special variable rather than PATH.  Putting 
things onto PATH that weren't named with that in mind is asking for trouble, 
IMO.

Maybe "KCRASH_DRKONQI_EXECUTABLE"?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53939
---


On March 24, 2014, 12:01 p.m., Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> ---
> 
> (Updated March 24, 2014, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 
> 3rd party software (kde-runtime), it should not make assumptions regarding 
> location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then 
> falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch 
> it's possible for distributions to ship KDE Frameworks in normal prefix 
> (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> ---
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117043: Add emission of KLineEdit::textEdited()

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117043/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Add emission of KLineEdit::textEdited()

Comment says that the userTextChanged() signal has to be removed. It is already 
deprecated.

It also says that textEdited() does the same, so I add the emission of 
textEdited() below userTextChanged().


Diffs
-

  src/klineedit.cpp b426767 

Diff: https://git.reviewboard.kde.org/r/117043/diff/


Testing
---

It builds


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117042/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Make KLineEdit::completionBox virtual so that konq can reimplement it (as 
suggested in a comment)


Diffs
-

  src/klineedit.h 723cb42 

Diff: https://git.reviewboard.kde.org/r/117042/diff/


Testing
---


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117040: Remove FIXME in KCompletion

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117040/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Remove FIXME in KCompletion.

I have revised the API and I think it makes sense as it is.


Diffs
-

  src/kcompletion.h 3b3b0a6 

Diff: https://git.reviewboard.kde.org/r/117040/diff/


Testing
---


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117037: Refactor parameter names

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117037/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Refactor parameter names

Also add #ifndef KCOMPLETION_NO_DEPRECATED around the implementation of 
KLineEdit::setUrlDropsEnabled()


Diffs
-

  src/kcombobox.h 80d6573 
  src/kcombobox.cpp cbb209e 
  src/kcompletion.h 3b3b0a6 
  src/kcompletion.cpp 847cff3 
  src/kcompletionbox.h f396746 
  src/kcompletionbox.cpp 7753643 
  src/khistorycombobox.h d1f5eac 
  src/khistorycombobox.cpp 80261ae 
  src/klineedit.h 723cb42 
  src/klineedit.cpp b426767 
  src/klineedit_p.h 397abc2 

Diff: https://git.reviewboard.kde.org/r/117037/diff/


Testing
---

It builds and tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117036/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Refactor private variables and parameters in KCompletionBase and KLineEdit

Also get rid of KCompletionBase::setup()


Diffs
-

  src/klineedit.cpp b426767 
  src/kcompletionbase.h edce7d4 
  src/kcompletionbase.cpp f1cf347 
  src/klineedit.h 723cb42 

Diff: https://git.reviewboard.kde.org/r/117036/diff/


Testing
---

It builds and tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/
---

(Updated March 24, 2014, 9:45 p.m.)


Review request for KDE Frameworks.


Changes
---

Since the patch was way too short, I finished the TODO part.


Summary (updated)
-

Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()


Repository: kcompletion


Description (updated)
---

Deprecate reset() and substitute it for resetIndex().

Remove private reset() and move the implementation to the public reset()

Move method to public Q_SLOTS section


Diffs (updated)
-

  autotests/kcombobox_unittest.cpp 1479ae2 
  src/khistorycombobox.h d1f5eac 
  src/khistorycombobox.cpp 80261ae 

Diff: https://git.reviewboard.kde.org/r/116969/diff/


Testing
---

It builds. Tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : ktexteditor_master_qt5 #323

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: ktexteditor_master_qt5 #321

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : ktexteditor_master_qt5 #320

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Allocating kde-runtime/platforms/win

[Kevin Ottens]

On Monday 24 March 2014 19:01:14 Aleix Pol wrote:
> So if nobody disagrees, we'll split it out into a KWindowsAddons repository
> and hope somebody will find a use for it some day.

No objection to have it as separate repository. Just to clarify though: won't 
be part of a KF5.0, afaict it's not something with API.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117024: Use the KF5::kconf_update target to locate kconf_update

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117024/#review54022
---

Ship it!


Ship It!

- Kevin Ottens


On March 24, 2014, 4:19 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117024/
> ---
> 
> (Updated March 24, 2014, 4:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kded
> 
> 
> Description
> ---
> 
> Use the KF5::kconf_update target to locate kconf_update
> 
> kconf_update is an internal executable to KConfig, and so is not on
> $PATH.  It is also not a kdeinit executable, although we still use
> kdeinit to launch it just for consistency (of environment etc).
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a081a5bf9a4b57101d4f2db48941fc1e1e51fbb2 
>   src/kded.cpp fb1cfcbab4c1a7b74009493930ae48ecea52c013 
> 
> Diff: https://git.reviewboard.kde.org/r/117024/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs.  Ran kded5, and kdeinit5 printed
> kdeinit5: Got EXEC_NEW '/home/kf5-devel/kf5/lib64/kde5/libexec/kconf_update' 
> from launcher.
> kdeinit5: preparing to launch 
> '/home/kf5-devel/kf5/lib64/kde5/libexec/kconf_update'
> and no related errors.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117023: Use the full path for kconf_update when running it

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117023/#review54021
---

Ship it!


Ship It!

- Kevin Ottens


On March 24, 2014, 4:19 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117023/
> ---
> 
> (Updated March 24, 2014, 4:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Use the full path for kconf_update when running it
> 
> It is not on $PATH, so we cannot just expect QProcess to find it.
> 
> Export the location of kconf_update in CMake
> 
> This is for the benefit of kded, which needs to run this binary.
> 
> 
> Diffs
> -
> 
>   src/core/CMakeLists.txt 4e13ee5ac129353feaa4ad6053226574f805b73c 
>   src/core/kconfig.cpp 5a4a083d0c220cd28e60c84cdaff8a014fe5acf5 
>   src/kconf_update/CMakeLists.txt e4e37ba963aac186d5c8495f8e1ed8e961429669 
> 
> Diff: https://git.reviewboard.kde.org/r/117023/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs.  Checked the define passed to the compiler by eye.  Not 
> sure how to test the actual code.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117020/#review54020
---

Ship it!


Ship It!

- Kevin Ottens


On March 24, 2014, 2:07 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117020/
> ---
> 
> (Updated March 24, 2014, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> Fix up KLibLoader autotests
> 
> They now test the actual current state of KLibLoader (eg: only Qt5-style
> plugins using KPluginFactory are supported).
> 
> Improve KLibLoader documentation
> 
> Also, add some extra deprecation warnings.
> 
> Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning
> 
> There is no code left to load these plugins, which have been deprecated
> since kdelibs 4.0.
> 
> Use KPluginLoader in KLibLoader::factory()
> 
> This actually has some chance of succeeding (KLibrary::factory() always
> returns 0).
> 
> 
> Diffs
> -
> 
>   src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e 
>   src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 
>   autotests/klibloadertest_module.h  
>   autotests/klibloadertest_module.cpp 
> e434cc46a7c7843186cb0fc4747f876fd5a86bc4 
>   autotests/klibloadertest4_module.h  
>   autotests/klibloadertest4_module.cpp 
> 5179baf6c64228ad6ff50d1733e149740ddedc45 
>   autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 
>   autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 
>   autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe 
> 
> Diff: https://git.reviewboard.kde.org/r/117020/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox

[Kevin Ottens]

> On March 23, 2014, 9:38 p.m., David Faure wrote:
> > I don't really get the point of this change? (it's mostly a TODO...)

Indeed I don't get it either.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/#review53857
---


On March 21, 2014, 10:51 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116969/
> ---
> 
> (Updated March 21, 2014, 10:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> Remove private reset() and move the implementation to the public reset()
> 
> Move method to public Q_SLOTS section
> 
> 
> Diffs
> -
> 
>   src/khistorycombobox.h d1f5eac 
>   src/khistorycombobox.cpp 80261ae 
> 
> Diff: https://git.reviewboard.kde.org/r/116969/diff/
> 
> 
> Testing
> ---
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116930: Fix "device not open" warning messages at build time

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/#review54018
---

Ship it!


Ship It!

- Kevin Ottens


On March 23, 2014, 8:12 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116930/
> ---
> 
> (Updated March 23, 2014, 8:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Sebastian Kügler.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> The "device not open" message appears when one registers a factory without a 
> .json file.
> The K_PLUGIN_FACTORY_WITH_BASEFACTORY macro expands to:
> 
> class MyPlugin : public KPluginFactory
> {
> Q_OBJECT
> Q_PLUGIN_METADATA(IID KPluginFactory_iid FILE "")
> 
> When moc parses such code, it tries to read a json file named "" and 
> rightfully complains.
> 
> 
> Diffs
> -
> 
>   src/plugin/kpluginfactory.h 3880d29 
> 
> Diff: https://git.reviewboard.kde.org/r/116930/diff/
> 
> 
> Testing
> ---
> 
> Rebuilt kde-workspace from scratch. No more message.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117003: Remove kde3 compatibility code for "DocPath" in desktop files

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117003/#review54017
---

Ship it!


Ship It!

- Kevin Ottens


On March 23, 2014, 5:36 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117003/
> ---
> 
> (Updated March 23, 2014, 5:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Remove kde3 compatibility code for "DocPath" in desktop files
> 
> LXR suggests nothing still sets that (everything is X-DocPath now).
> 
> 
> Diffs
> -
> 
>   src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 
> 
> Diff: https://git.reviewboard.kde.org/r/117003/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116997: Cleanup KDE 4 references in various comments and dox

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116997/#review54015
---

Ship it!


Ship It!

- Kevin Ottens


On March 23, 2014, 3:48 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116997/
> ---
> 
> (Updated March 23, 2014, 3:48 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Cleanup KDE 4 references in various comments and dox
> 
> 
> Remove commented-out KSocks call
> 
> No-one noticed its absense through KDE 4...
> 
> Remove disabled archive support from ListJob
> 
> According to the comments, this has never worked.
> 
> Remove the kdestop integration code from fileundomanager
> 
> This hasn't worked since KDE 2.1(!)
> 
> 
> Diffs
> -
> 
>   src/core/listjob.cpp 9ed42eb51f7aa83016a8818f45e88e300eaa726e 
>   src/core/slavebase.h 092289349dee1c0136668e14088ef4e3d41077ba 
>   src/core/slavebase.cpp b5d5de0f243a9420bcff61102bfca5fadc68c0be 
>   src/core/transferjob.h 6bd4d32d0607153db66461b97cbef5b367f9e27f 
>   src/core/udsentry.h ff3304fefe1c986e7f5df843ee20473ba41e4b4d 
>   src/filewidgets/kdiroperator.h a66d733929ec472971814644dc9847433c955491 
>   src/filewidgets/kdiroperator.cpp 17f09d14b859cba26bb474875bab65d2be0bb7a9 
>   src/filewidgets/kfilepreviewgenerator.cpp 
> c47a309de1305145184ced8fecd042f22cf7dc66 
>   src/widgets/fileundomanager.cpp 7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88 
>   src/widgets/fileundomanager_p.h f135f499b2c7d8e96936863eac2a6cd81a84b0e4 
>   src/widgets/kfileitemactions.h 94c7a1db14633be2966eb220cc942d59ebe0ccdc 
>   src/widgets/krun.h dbdc481d797c364d1cc72a67bc58280fcaf393b1 
>   src/widgets/kurifilter.h b67cb1f5a1f8b77bd2b70085417c1ce42748bdde 
>   src/widgets/kurlcombobox.cpp 6f76b2c3ace2b7d556dc9351dc9832c93c61c128 
>   src/widgets/pixmaploader.h a1b9fdaf20d29905d24c668cdd94ab0a48c04053 
>   src/widgets/previewjob.h 0eec0076d8659ce3510d56d5084be0907165aa5c 
>   src/core/job_base.h 63c59c2c6ddaa9879777c788a7aef391dde2e8dd 
>   src/core/kfileitem.h b09c3c017aab3fac0eed21dc0dcc20b8625d75f4 
> 
> Diff: https://git.reviewboard.kde.org/r/116997/diff/
> 
> 
> Testing
> ---
> 
> Builds, compiles, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116999: kparts: Remove/resolve old porting comments and TODOs

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116999/#review54016
---

Ship it!


Ship It!

- Kevin Ottens


On March 23, 2014, 4:33 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116999/
> ---
> 
> (Updated March 23, 2014, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kparts
> 
> 
> Description
> ---
> 
> Remove old porting comments and TODOs
> 
> 
> Use QMetaObject::indexOfMethod instead of iterating through methods
> 
> 
> Diffs
> -
> 
>   src/browserrun.cpp be89f9f54617b5cf4fb70af9bbaf8295d542150a 
>   src/mainwindow.h 728e60b497a4883db754c1fed608638cf250cbd3 
>   src/partmanager.h dbbde7e7e71e9791466fd7bd5a511a059c9b5502 
>   src/browserextension.cpp c3fb5e866ab6a9417fc76d79034cc76f0d0e2653 
> 
> Diff: https://git.reviewboard.kde.org/r/116999/diff/
> 
> 
> Testing
> ---
> 
> builds, installs, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116980: Update the kded5 man page

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116980/#review54014
---



docs/kded5/man-kded5.8.docbook


spurious whitespace


- Kevin Ottens


On March 23, 2014, 1:55 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116980/
> ---
> 
> (Updated March 23, 2014, 1:55 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kded
> 
> 
> Description
> ---
> 
> Update the kded5 man page
> 
> 
> Diffs
> -
> 
>   docs/kded5/man-kded5.8.docbook 4fca21f00c43be7842f07470b3d52d6607a40c32 
> 
> Diff: https://git.reviewboard.kde.org/r/116980/diff/
> 
> 
> Testing
> ---
> 
> Built, installed, visually inspected man page.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116982: Remove KDE 4 refs in khtml

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116982/#review54013
---

Ship it!


Ship It!

- Kevin Ottens


On March 22, 2014, 6:46 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116982/
> ---
> 
> (Updated March 22, 2014, 6:46 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> ---
> 
> Add FIXME to testregression docs about updating them
> 
> 
> kcmshell4 -> kcmshell5
> 
> 
> Reword or resolve "### KDE4" TODOs
> 
> Those that are just simple binary compatibility issues are resolved,
> others are replaced with "TODO".
> 
> 
> Diffs
> -
> 
>   src/BUILDING-TESTREGRESSION 2d799b947263d388ce77d8b16b9529416de3b51f 
>   src/dom/html_form.h adbb744b64792b517bd7c370a6e3ac4862f5a34e 
>   src/ecma/debugger/breakpointsdock.cpp 
> 3570bd07d705e60274d1a44f6bd344b613ec64c1 
>   src/ecma/debugger/scriptsdock.cpp 30cb846abe39d817435b73252581c673f2d92848 
>   src/ecma/kjs_window.h 6221179601c4904c09be49f0130df08b8109b52e 
>   src/ecma/kjs_window.cpp f72f49411202e75c2f1b3a949920a0949e63a6d7 
>   src/khtml_part.h 4e272af9f987003a7389c6f924e563f6b02b80a4 
>   src/khtml_part.cpp 2973fa6ce2408aadb5f717a1dc81d9d496543224 
>   src/khtmlpart_p.h c34648476cb92d0c42be5730d54670ec2b46c218 
>   src/rendering/render_image.cpp c61a2d209f2a53f3acf3dfcdec896654c4aa8307 
>   src/rendering/render_list.cpp f74d04f58904866de30a0442d4b8576dd2bb6a7f 
>   src/xml/dom2_eventsimpl.h 9d54af11d6c4524659f777cf2f2440735312cfe7 
>   src/xml/dom2_eventsimpl.cpp b376fe9c210a16d23308f1443eb7e7c5a3063aaa 
>   src/xml/dom_docimpl.h 83691165437edae603ab4d23d2c844cb0b9391ad 
> 
> Diff: https://git.reviewboard.kde.org/r/116982/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, autotests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116981: Use new terminology in webkit docs.

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/#review54012
---



src/kgraphicswebview.h


When used as product name we write "KDE Frameworks" with a capital F.



src/kgraphicswebview.h


Probably need to be checked with the plasma people, but I think they say 
just "Plasma" nowadays because of the upcoming generic shell.


- Kevin Ottens


On March 22, 2014, 6:03 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116981/
> ---
> 
> (Updated March 22, 2014, 6:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdewebkit
> 
> 
> Description
> ---
> 
> Use new terminology in webkit docs.
> 
> "KDE frameworks" intead of KDE, etc.
> 
> 
> Diffs
> -
> 
>   src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 
>   src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 
>   src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e 
>   src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee 
>   src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 
> 
> Diff: https://git.reviewboard.kde.org/r/116981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116955: Remove KDE 4 refs from Doxyfile.global

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116955/#review54011
---

Ship it!


Ship It!

- Kevin Ottens


On March 21, 2014, 4:19 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116955/
> ---
> 
> (Updated March 21, 2014, 4:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Remove KDE 4 refs from Doxyfile.global
> 
> The "port4" command is no longer relevant, and "@glossary" now just says
> "Glossary" instead of "KDE 4 Glossary".
> 
> 
> Diffs
> -
> 
>   src/kapidox/data/Doxyfile.global 96cb1c13ffeb78d0e35460c7697342a878d97786 
> 
> Diff: https://git.reviewboard.kde.org/r/116955/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116941/#review54009
---

Ship it!


Ship It!

- Kevin Ottens


On March 21, 2014, 7:15 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116941/
> ---
> 
> (Updated March 21, 2014, 7:15 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Remove deprecation for NET::timestampCompare and NET::timestampDiff
> 
> The deprecated note recommended to use the methods in KXUtils namespace,
> but those are in a private header and that's not going to change.
> 
> As the methods are used by applications (e.g. KWin) it should not get
> deprecated if there is no replacement.
> 
> 
> Diffs
> -
> 
>   src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 
> 
> Diff: https://git.reviewboard.kde.org/r/116941/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

[Harald Fernengel]

> On March 4, 2014, 8:28 p.m., Kevin Ottens wrote:
> > src/karchive.h, line 32
> > 
> >
> > Hm, why the change to "" for the includes? We try to stick to <> in 
> > public headers.
> 
> Kevin Ottens wrote:
> Any news?
> 
> Kevin Ottens wrote:
> Should it be discarded by lack of activity?

Heh, patch is still valid, I just didn't have time to follow up & test. The <> 
vs. "" is due to the way OS X frameworks find their headers - e.g. either use 
 or "foo.h".


- Harald


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115977/#review51936
---


On Feb. 23, 2014, 7:15 p.m., Harald Fernengel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115977/
> ---
> 
> (Updated Feb. 23, 2014, 7:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Change CMakeLists.txt to create Mac OS X frameworks
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f5dc644fdba13e29c94940c77d628e92e0759787 
>   src/CMakeLists.txt 53e97284cab199f5eb75aa276adfadc18d677682 
>   src/karchive.h d4209cf334190dda735fcb4687fa102a4e7a73cd 
>   src/karchivedirectory.h 60225d0be9fc2e28ff2b998dcc8fb28512c6e3cd 
>   src/karchiveentry.h aad6840ee0dc22e5760ddda99ce975a1d9a9dc92 
>   src/karchivefile.h c7d2e0e0735f75a8e490082aa8598fd08206a998 
>   src/ktar.h 4bca89884e646ffae90aa1a9e15a985e998e843f 
> 
> Diff: https://git.reviewboard.kde.org/r/115977/diff/
> 
> 
> Testing
> ---
> 
> 'make install' on Mac OS X
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116926: Remove support for _NET_WM_TAKE_ACTIVITY

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116926/#review54008
---

Ship it!


Ship It!

- Kevin Ottens


On March 20, 2014, 1:40 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116926/
> ---
> 
> (Updated March 20, 2014, 1:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Remove support for _NET_WM_TAKE_ACTIVITY
> 
> This was a proposed protocol [1] which never got adopted and no toolkit
> is making use of it. It's not implemented in either Qt4 or Qt5 and
> also not in GTK [2].
> 
> Only KWin had support for it, but didn't announce it in NET::Supported.
> 
> This is a SIC-change, but according to lxr nothing except KWin used
> these methods and there they are already in the process of getting
> removed.
> 
> [1] https://mail.gnome.org/archives/wm-spec-list/2004-April/msg00013.html
> [2] https://bugzilla.gnome.org/show_bug.cgi?id=154260
> 
> 
> Diffs
> -
> 
>   autotests/netrootinfotestwm.cpp e5fb0fa2b60bf434c84f89ce5e81deb93e3d2467 
>   src/netwm.h 640686a3cf4723bfd6e5aaad0b301f86f0a463ed 
>   src/netwm.cpp d9956d2b8191405847ff84cb401126fa7a2f2fbf 
>   src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 
> 
> Diff: https://git.reviewboard.kde.org/r/116926/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116848/#review54007
---

Ship it!


Ship It!

- Kevin Ottens


On March 19, 2014, 6:19 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116848/
> ---
> 
> (Updated March 19, 2014, 6:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) 
> signal
> 
> This signal replaces the existing signal carrying either just the
> NET::Properties as an uint or both as an const unsigned long*.
> Accordingly the previous signal gets deprecated, but is still emitted.
> 
> Question: what's the correct way of deprecating signals, so that one gets a 
> compile warning?
> 
> 
> Diffs
> -
> 
>   src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 
>   src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 
> 
> Diff: https://git.reviewboard.kde.org/r/116848/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116887: Undeprecate setUrlDropsEnabled(bool) in KComboBox and KLineEdit

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116887/
---

(Updated March 24, 2014, 6:43 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Undeprecate setUrlDropsEnabled(bool) in KComboBox and KLineEdit

Apidox say it to be deprecated and use installEventFilter with a
LineEditUrlDropEventFilter instead. But that's precisely what
setUrlDropsEnabled does, so I don't see the point of making the user
do it when there's already a one-line method for that.


Diffs
-

  src/klineedit.h 76a1f01 
  src/kcombobox.h eea930d 
  src/kcombobox.cpp 30edc1b 

Diff: https://git.reviewboard.kde.org/r/116887/diff/


Testing
---

It builds. The compiler warnings about this deprecation disappear. 


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116876: Add default emoticons theme to kemoticons

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116876/#review54006
---

Ship it!


Ship It!

- Kevin Ottens


On March 18, 2014, 3:58 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116876/
> ---
> 
> (Updated March 18, 2014, 3:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> Make the autotests work uninstalled
> 
> This also makes them data-driven, separating out the different testcases
> in the output, and fixes the "skipping" behaviour (so QSKIP only skips
> one testcase and not all of them).
> 
> 
> Add a default theme
> 
> This was originally the default theme from Kopete, and was called "kde4"
> up until this point.
> 
> To trace its history, start at:
> svn path=/trunk/KDE/kdebase/runtime/; revision=699615
> which is also commit a9552cba75e67fb886921d1abc2cb2a09e6efbad of
> kde-runtime.
> 
> 
> I didn't copy the history from kde-runtime, because there was no history to 
> copy - only the commit noted above actually made it out of svn.
> 
> 
> Diffs
> -
> 
>   themes/Glass/sleep.png PRE-CREATION 
>   themes/Glass/shade.png PRE-CREATION 
>   themes/Glass/rose.png PRE-CREATION 
>   themes/Glass/sad.png PRE-CREATION 
>   themes/Glass/present.png PRE-CREATION 
>   themes/Glass/phone.png PRE-CREATION 
>   themes/Glass/omg.png PRE-CREATION 
>   themes/Glass/note.png PRE-CREATION 
>   themes/Glass/oh.png PRE-CREATION 
>   themes/Glass/love.png PRE-CREATION 
>   CMakeLists.txt de080764f7d387871ebebf6bfa7541944b618036 
>   autotests/CMakeLists.txt 98b8e43b2f5cbe08dc6b454e2736e809538a0251 
>   autotests/kemoticontest.h ba31c0bd50b8bf6a75844fb9c41ffdedd6fc34d5 
>   autotests/kemoticontest.cpp b7dc6f75fb722d63936fb666a51b969d37b84e31 
>   src/core/kemoticons.cpp bc72e166586ef1271cac2291a9223c2472e1d8b8 
>   tests/main.cpp 13f584a153fbd3612e8702d05368960d6e8e4e59 
>   themes/CMakeLists.txt PRE-CREATION 
>   themes/Glass/angry.png PRE-CREATION 
>   themes/Glass/bat.png PRE-CREATION 
>   themes/Glass/beer.png PRE-CREATION 
>   themes/Glass/biggrin.png PRE-CREATION 
>   themes/Glass/cake.png PRE-CREATION 
>   themes/Glass/camera.png PRE-CREATION 
>   themes/Glass/cat.png PRE-CREATION 
>   themes/Glass/clock.png PRE-CREATION 
>   themes/Glass/cocktail.png PRE-CREATION 
>   themes/Glass/confused.png PRE-CREATION 
>   themes/Glass/cry.png PRE-CREATION 
>   themes/Glass/cup.png PRE-CREATION 
>   themes/Glass/dog.png PRE-CREATION 
>   themes/Glass/email.png PRE-CREATION 
>   themes/Glass/embarassed.png PRE-CREATION 
>   themes/Glass/emoticons.xml PRE-CREATION 
>   themes/Glass/film.png PRE-CREATION 
>   themes/Glass/foot_in_mouth.png PRE-CREATION 
>   themes/Glass/innocent.png PRE-CREATION 
>   themes/Glass/kiss.png PRE-CREATION 
>   themes/Glass/lightbulb.png PRE-CREATION 
>   themes/Glass/smile.png PRE-CREATION 
>   themes/Glass/star.png PRE-CREATION 
>   themes/Glass/teeth.png PRE-CREATION 
>   themes/Glass/thumbs_down.png PRE-CREATION 
>   themes/Glass/thumbs_up.png PRE-CREATION 
>   themes/Glass/tongue.png PRE-CREATION 
>   themes/Glass/undecided.png PRE-CREATION 
>   themes/Glass/unhappy.png PRE-CREATION 
>   themes/Glass/unlove.png PRE-CREATION 
>   themes/Glass/wilted_rose.png PRE-CREATION 
>   themes/Glass/wink.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116876/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, tests pass without skipping (both before and after 
> installation).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116044: In kstyle: Use the iconSize from mainToolbar

[Kevin Ottens]

> On Feb. 25, 2014, 12:10 p.m., David Faure wrote:
> > The part of the description that says "if accepted will modify kstyle as 
> > well" doesn't really make sense anymore (to fix if it's in your commit log 
> > too).
> > 
> > The bit I'm not sure about is: using MainToolbar icon style everywhere ... 
> > how does that take care of other toolbars then?
> > The idea (long ago) was to be able to have (large) icons and text in the 
> > main toolbar, and (small) icons only in other toolbars. Is that idea 
> > dropped, or handled elsewhere?
> 
> Hugo Pereira Da Costa wrote:
> "The bit I'm not sure about is: using MainToolbar icon style everywhere 
> ... how does that take care of other toolbars then?"
> Thing is, old code was treating 'main ToolBar' as 'other toolbars'. New 
> one (iiur) treats 'other toolbars' as 'main toolbar'.
> The latter is as 'incomplete' as the former, but more consistent. 
> Not sure where exactly the distinction between 'main' and 'all' toolbars 
> is performed. Alex ? Is it kapplication ? (as opposed to Qt only, which has 
> no such distinction) ?
> 
> David Faure wrote:
> I know consistency is better than inconsistency, but still, while looking 
> at this we might as well make it correct, too :)
> 
> The logic used to be in KToolBar, based on objectName == "mainToolBar"  
> (yes, you could say that's ugly and fragile, but since that comes from the 
> kxmlgui ui_standards.rc file, it actually happens automatically in all apps).
> 
> I'm not sure what's the plan for making this work in the QToolBar+KF5 
> world. But if nothing else has been planned already, kstyle and/or 
> platformtheme [I'm not sure why they both handle toolbar icon sizes] can take 
> care of checking the objectName too, given a pointer to the toolbar.
> 
> Kevin Ottens wrote:
> The style is indeed able to have that pointer to the toolbar, so it could 
> be a simple if there.
> 
> Kevin Ottens wrote:
> Hugo, any news? Still something blocking you?

Should it be discarded by lack of activity?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116044/#review50807
---


On Feb. 25, 2014, 12:34 p.m., Hugo Pereira Da Costa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116044/
> ---
> 
> (Updated Feb. 25, 2014, 12:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This is a spinoff of https://git.reviewboard.kde.org/r/112335/ originally 
> from afiestas
> Copying his own words: 
> 
> In the qplatformplugin  we use information from MainToolbar (which makes 
> sense) but in the styles we use information from Toolbar.
> This unify both by using MainToolbar in styles 
> Code has been removed from oxygen now that it derives from KStyle again
> 
> 
> Diffs
> -
> 
>   src/kstyle/kstyle.cpp c0528b3 
> 
> Diff: https://git.reviewboard.kde.org/r/116044/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hugo Pereira Da Costa
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

[Kevin Ottens]

> On March 17, 2014, 4:44 p.m., Kevin Ottens wrote:
> > OK, let's go for it without a test app...

Anything still blocking?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review53187
---


On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

[Kevin Ottens]

> On March 4, 2014, 8:28 p.m., Kevin Ottens wrote:
> > src/karchive.h, line 32
> > 
> >
> > Hm, why the change to "" for the includes? We try to stick to <> in 
> > public headers.
> 
> Kevin Ottens wrote:
> Any news?

Should it be discarded by lack of activity?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115977/#review51936
---


On Feb. 23, 2014, 7:15 p.m., Harald Fernengel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115977/
> ---
> 
> (Updated Feb. 23, 2014, 7:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Change CMakeLists.txt to create Mac OS X frameworks
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f5dc644fdba13e29c94940c77d628e92e0759787 
>   src/CMakeLists.txt 53e97284cab199f5eb75aa276adfadc18d677682 
>   src/karchive.h d4209cf334190dda735fcb4687fa102a4e7a73cd 
>   src/karchivedirectory.h 60225d0be9fc2e28ff2b998dcc8fb28512c6e3cd 
>   src/karchiveentry.h aad6840ee0dc22e5760ddda99ce975a1d9a9dc92 
>   src/karchivefile.h c7d2e0e0735f75a8e490082aa8598fd08206a998 
>   src/ktar.h 4bca89884e646ffae90aa1a9e15a985e998e843f 
> 
> Diff: https://git.reviewboard.kde.org/r/115977/diff/
> 
> 
> Testing
> ---
> 
> 'make install' on Mac OS X
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Dan Vrátil]

> On March 24, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote:
> > What about QStandardPaths::findExecutable? Actually this one should look 
> > into libexec too (at least the equivalent KStandardDirs::findExe used to).
> 
> Alex Merry wrote:
> I'm pretty sure QStandardPaths won't look at libexec.  How should it know 
> where libexec stuff is?  The whole point of libexec is that it is 
> library-private (TBH it's slightly hacky to have a "kde5" libexec dir in 
> $LIB/kde5/libexec; really, each library should have its own dir).
> 
> Hrvoje Senjan wrote:
> additionally, i think this will actually open drkonqi(4) (if 
> kde-runtime(4) is also installed), no?

The idea is that it does not find anything and fallsback to 
CMAKE_INSTALL_DIR/LIBEXEC_INSTALL_DIR, but allows us to override it by PATH in 
case we use some prefix, like /opt/kde5. Obviously if people mess with their 
PATH they might get weird results like starting drkonqi4, but that's simply 
their problem.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53939
---


On March 24, 2014, 1:01 p.m., Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> ---
> 
> (Updated March 24, 2014, 1:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 
> 3rd party software (kde-runtime), it should not make assumptions regarding 
> location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then 
> falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch 
> it's possible for distributions to ship KDE Frameworks in normal prefix 
> (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> ---
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Dan Vrátil]

> On March 24, 2014, 4:41 p.m., Alex Merry wrote:
> > The correct solution is to get drkonqi merged into kcrash (see 
> > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization).
> 
> Aleix Pol Gonzalez wrote:
> Agreed. If somebody has the time, it would be interesting to figure out 
> what can be uncommented (see commit f8b59b6c in kde-runtime). There's many 
> things commented out and I'm unsure what to do with it.

I agree, however until it is done, this patch would make lifes of distribution 
packagers a bit easier :-)


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53985
---


On March 24, 2014, 1:01 p.m., Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> ---
> 
> (Updated March 24, 2014, 1:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 
> 3rd party software (kde-runtime), it should not make assumptions regarding 
> location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then 
> falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch 
> it's possible for distributions to ship KDE Frameworks in normal prefix 
> (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> ---
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Allocating kde-runtime/platforms/win

[Aleix Pol]

On Thu, Feb 20, 2014 at 6:46 PM, Aleix Pol  wrote:

> Hi!
> I am going through the list of things where we're moving kde-runtime
> components to [1] and I see that there's a platform/win directory.
>
> Do you agree that having it in a separate repository would be the best?
> Could anybody with a working KF5 + windows system (if that exists) work on
> it?
>
> Thanks
> Aleix
>
> [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization
>
>
So if nobody disagrees, we'll split it out into a KWindowsAddons repository
and hope somebody will find a use for it some day.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Aleix Pol Gonzalez]

> On March 24, 2014, 3:41 p.m., Alex Merry wrote:
> > The correct solution is to get drkonqi merged into kcrash (see 
> > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization).

Agreed. If somebody has the time, it would be interesting to figure out what 
can be uncommented (see commit f8b59b6c in kde-runtime). There's many things 
commented out and I'm unsure what to do with it.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53985
---


On March 24, 2014, 12:01 p.m., Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> ---
> 
> (Updated March 24, 2014, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 
> 3rd party software (kde-runtime), it should not make assumptions regarding 
> location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then 
> falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch 
> it's possible for distributions to ship KDE Frameworks in normal prefix 
> (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> ---
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Hrvoje Senjan]

> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote:
> > What about QStandardPaths::findExecutable? Actually this one should look 
> > into libexec too (at least the equivalent KStandardDirs::findExe used to).
> 
> Alex Merry wrote:
> I'm pretty sure QStandardPaths won't look at libexec.  How should it know 
> where libexec stuff is?  The whole point of libexec is that it is 
> library-private (TBH it's slightly hacky to have a "kde5" libexec dir in 
> $LIB/kde5/libexec; really, each library should have its own dir).

additionally, i think this will actually open drkonqi(4) (if kde-runtime(4) is 
also installed), no?


- Hrvoje


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53939
---


On March 24, 2014, 12:01 p.m., Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> ---
> 
> (Updated March 24, 2014, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 
> 3rd party software (kde-runtime), it should not make assumptions regarding 
> location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then 
> falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch 
> it's possible for distributions to ship KDE Frameworks in normal prefix 
> (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> ---
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116927: Fix kdeinit module lookup

[Alex Merry]

> On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote:
> > this seems to broke kded modules loading here:
> > Cannot load library /usr/lib64/libkdeinit5_kio_file: 
> > (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No 
> > such file or directory)
> 
> Hrvoje Senjan wrote:
> err, s/kded modules/kio plugins
> 
> Alex Merry wrote:
> Ah, I see.  The old code *only* worked for kioslaves, and now it works 
> for everything *but* kioslaves.  Although I'm not sure why I didn't run into 
> this in my testing.
> 
> I think the correct solution here is to do the lookup in klauncher, 
> though.
> 
> Alex Merry wrote:
> Ah, I'm getting the error now.  Possibly it was something to do with the 
> multiple patches I had lying around for kinit, kservice and kio.
> 
> Alex Merry wrote:
> https://git.reviewboard.kde.org/r/116935/ should fix it.
> 
> Hrvoje Senjan wrote:
> FTR: it fixes the issue, tnx. another side-effect left:
> Could not open kconf_update using a library: Cannot load library 
> /usr/lib64/libkdeinit5_kconf_update: (/usr/lib64/libkdeinit5_kconf_update.so: 
> cannot open shared object file: No such file or directory)

Huh.  I don't think that ever worked with KF5.  See 
https://git.reviewboard.kde.org/r/117024/


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116927/#review53702
---


On March 20, 2014, 10:18 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116927/
> ---
> 
> (Updated March 20, 2014, 10:18 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> Fix kdeinit module lookup
> 
> KLibrary's lookup magic is not so magic these days - is just uses
> QCoreApplication::libraryPaths, which is not what we want.  Instead, we
> let dlopen() do the searching for us, plus hack in a check in the
> library installation directory for kinit (since dlopen() called from Qt
> does not respect kdeinit5's RUNPATH).
> 
> This should cover most common cases (module installed to standard
> location, module installed to same location as the kinit framework,
> mdoule in LD_LIBRARY_PATH), and if it still fails we just fall back to
> the normal executable.
> 
> Rename kinit_library_path() to generate_socket_name()
> 
> This reflects what the function actually does.  Also got rid of the
> (mostly) ifdef'd-out code that gave the function its original name.
> 
> Add comment about fragility of lookup based on installation vars
> 
> 
> Diffs
> -
> 
>   src/kdeinit/CMakeLists.txt c4e3c49ea28d4e96be9ee1fa02f801052945d01e 
>   src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 
> 
> Diff: https://git.reviewboard.kde.org/r/116927/diff/
> 
> 
> Testing
> ---
> 
> Built and installed.  Ran kdeinit5, which reported that it was launching 
> "libkdeinit5_klauncher", rather than "/home/kf5-devel/kf5/bin/klauncher" as 
> it did previously.  klauncher process then has "[kdeinit]" in its process 
> title in `ps xu`.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Finding libexec files / relocation

[Alex Merry]

Currently, paths to libexec files are hardcoded (or not... see
https://git.reviewboard.kde.org/r/117023/).  This works find unless you
want to relocate anything.

I know that relocating is something that has come up with KDE on Windows
stuff.  Is it something we want to support?  If so, how would we do it?

I think most of the rest of our stuff (including CMake code) supports
relocation, even if you have to set some environment variables to
support it (like LD_LIBRARY_PATH on Linux).

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117024: Use the KF5::kconf_update target to locate kconf_update

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117024/
---

Review request for KDE Frameworks.


Repository: kded


Description
---

Use the KF5::kconf_update target to locate kconf_update

kconf_update is an internal executable to KConfig, and so is not on
$PATH.  It is also not a kdeinit executable, although we still use
kdeinit to launch it just for consistency (of environment etc).


Diffs
-

  src/CMakeLists.txt a081a5bf9a4b57101d4f2db48941fc1e1e51fbb2 
  src/kded.cpp fb1cfcbab4c1a7b74009493930ae48ecea52c013 

Diff: https://git.reviewboard.kde.org/r/117024/diff/


Testing
---

Builds, installs.  Ran kded5, and kdeinit5 printed
kdeinit5: Got EXEC_NEW '/home/kf5-devel/kf5/lib64/kde5/libexec/kconf_update' 
from launcher.
kdeinit5: preparing to launch 
'/home/kf5-devel/kf5/lib64/kde5/libexec/kconf_update'
and no related errors.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117023: Use the full path for kconf_update when running it

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117023/
---

Review request for KDE Frameworks.


Repository: kconfig


Description
---

Use the full path for kconf_update when running it

It is not on $PATH, so we cannot just expect QProcess to find it.

Export the location of kconf_update in CMake

This is for the benefit of kded, which needs to run this binary.


Diffs
-

  src/core/CMakeLists.txt 4e13ee5ac129353feaa4ad6053226574f805b73c 
  src/core/kconfig.cpp 5a4a083d0c220cd28e60c84cdaff8a014fe5acf5 
  src/kconf_update/CMakeLists.txt e4e37ba963aac186d5c8495f8e1ed8e961429669 

Diff: https://git.reviewboard.kde.org/r/117023/diff/


Testing
---

Builds, installs.  Checked the define passed to the compiler by eye.  Not sure 
how to test the actual code.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Alex Merry]

> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote:
> > What about QStandardPaths::findExecutable? Actually this one should look 
> > into libexec too (at least the equivalent KStandardDirs::findExe used to).

I'm pretty sure QStandardPaths won't look at libexec.  How should it know where 
libexec stuff is?  The whole point of libexec is that it is library-private 
(TBH it's slightly hacky to have a "kde5" libexec dir in $LIB/kde5/libexec; 
really, each library should have its own dir).


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53939
---


On March 24, 2014, 12:01 p.m., Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> ---
> 
> (Updated March 24, 2014, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 
> 3rd party software (kde-runtime), it should not make assumptions regarding 
> location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then 
> falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch 
> it's possible for distributions to ship KDE Frameworks in normal prefix 
> (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> ---
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53985
---


The correct solution is to get drkonqi merged into kcrash (see 
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization).

- Alex Merry


On March 24, 2014, 12:01 p.m., Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> ---
> 
> (Updated March 24, 2014, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 
> 3rd party software (kde-runtime), it should not make assumptions regarding 
> location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then 
> falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch 
> it's possible for distributions to ship KDE Frameworks in normal prefix 
> (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> ---
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: ktexteditor_master_qt5 #319

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117017: Remove forward headers for KTextEditor

[Kevin Funk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/
---

(Updated March 24, 2014, 2:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Dominik Haumann.


Repository: kde4support


Description
---

Remove forward headers for KTextEditor

Some of the headers have actually been removed already. Keeping broken
forward headers actually makes it *more* difficult to port.


Diffs
-

  src/includes/KTextEditor/CommandExtension 
4187c61882a83cab906fa87cd16bd18229b6efb5 
  src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 
  src/includes/KTextEditor/CodeCompletionModelControllerInterface 
a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 
  src/includes/KTextEditor/CodeCompletionModel 
3511d00b212e5c56613bf4f06fedc5a5d76cb3bc 
  src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 
  src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae 
  src/includes/KTextEditor/CodeCompletionInterface 
41341c38dd92e7c1533b0ba74eceb735408a1d3f 
  src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d 
  src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 
  src/includes/KTextEditor/ConfigPage b3904bee10ffc0245bca1a928389237813850ec3 
  src/includes/KTextEditor/ConfigInterface 
0617835fc7621c4c26a2d50ca95d12d8870fffc2 
  src/includes/KTextEditor/CommandInterface 
4187c61882a83cab906fa87cd16bd18229b6efb5 
  src/includes/KTextEditor/ModificationInterface 
50df2902648156dc5cd4630f587add36d320a43a 
  src/includes/KTextEditor/MessageInterface 
41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
  src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 
  src/includes/KTextEditor/HighlightInterface 
8c8c94ec679877be7e3965eba86498f06b67a883 
  src/includes/KTextEditor/MarkInterface 
87adf561b38045bdd65fc3f64f24311aa901d8ee 
  src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
  src/includes/KTextEditor/ParameterizedSessionConfigInterface 
8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
  src/includes/KTextEditor/MovingRange 89f68605ffa863862476831cfb836660a70e4931 
  src/includes/KTextEditor/MovingInterface 
bde16eaca7d68517ce7c2068186eb641daf6eab1 
  src/includes/KTextEditor/MovingCursor 
7c9eb3074e4feace09cca78962caf1ff27bd6394 
  src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 
  src/includes/KTextEditor/VariableInterface 
126a93691700fab3134400907d0ba93a4e275f0d 
  src/includes/KTextEditor/TextHintInterface 
6b05d9a4a45ac8807294599e04c7dc15db076cf0 
  src/includes/KTextEditor/TemplateInterface2 
de9d9451796710756287bfc2a627f7ae43a006b1 
  src/includes/KTextEditor/TemplateInterface 
0142d17815fabb9136836effa61114aaa1994635 
  src/includes/KTextEditor/SessionConfigInterface 
8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
  src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 
  src/includes/KTextEditor/SearchInterface 
f7dffc91739e82cceffea35de0632cb19e92ab0a 
  src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e 

Diff: https://git.reviewboard.kde.org/r/117017/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117017: Remove forward headers for KTextEditor

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/#review53981
---


This review has been submitted with commit 
a2f6dfd6814f75c18dd4e91a6a28932db6cef5bf by Kevin Funk to branch master.

- Commit Hook


On March 24, 2014, 10:48 a.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117017/
> ---
> 
> (Updated March 24, 2014, 10:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Dominik Haumann.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> Remove forward headers for KTextEditor
> 
> Some of the headers have actually been removed already. Keeping broken
> forward headers actually makes it *more* difficult to port.
> 
> 
> Diffs
> -
> 
>   src/includes/KTextEditor/CommandExtension 
> 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/CodeCompletionModelControllerInterface 
> a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 
>   src/includes/KTextEditor/CodeCompletionModel 
> 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc 
>   src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 
>   src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae 
>   src/includes/KTextEditor/CodeCompletionInterface 
> 41341c38dd92e7c1533b0ba74eceb735408a1d3f 
>   src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d 
>   src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 
>   src/includes/KTextEditor/ConfigPage 
> b3904bee10ffc0245bca1a928389237813850ec3 
>   src/includes/KTextEditor/ConfigInterface 
> 0617835fc7621c4c26a2d50ca95d12d8870fffc2 
>   src/includes/KTextEditor/CommandInterface 
> 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/ModificationInterface 
> 50df2902648156dc5cd4630f587add36d320a43a 
>   src/includes/KTextEditor/MessageInterface 
> 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
>   src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 
>   src/includes/KTextEditor/HighlightInterface 
> 8c8c94ec679877be7e3965eba86498f06b67a883 
>   src/includes/KTextEditor/MarkInterface 
> 87adf561b38045bdd65fc3f64f24311aa901d8ee 
>   src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
>   src/includes/KTextEditor/ParameterizedSessionConfigInterface 
> 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
>   src/includes/KTextEditor/MovingRange 
> 89f68605ffa863862476831cfb836660a70e4931 
>   src/includes/KTextEditor/MovingInterface 
> bde16eaca7d68517ce7c2068186eb641daf6eab1 
>   src/includes/KTextEditor/MovingCursor 
> 7c9eb3074e4feace09cca78962caf1ff27bd6394 
>   src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 
>   src/includes/KTextEditor/VariableInterface 
> 126a93691700fab3134400907d0ba93a4e275f0d 
>   src/includes/KTextEditor/TextHintInterface 
> 6b05d9a4a45ac8807294599e04c7dc15db076cf0 
>   src/includes/KTextEditor/TemplateInterface2 
> de9d9451796710756287bfc2a627f7ae43a006b1 
>   src/includes/KTextEditor/TemplateInterface 
> 0142d17815fabb9136836effa61114aaa1994635 
>   src/includes/KTextEditor/SessionConfigInterface 
> 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
>   src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 
>   src/includes/KTextEditor/SearchInterface 
> f7dffc91739e82cceffea35de0632cb19e92ab0a 
>   src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e 
> 
> Diff: https://git.reviewboard.kde.org/r/117017/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117020: Tidy up KLibLoader and fix up its autotests

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117020/
---

(Updated March 24, 2014, 2:07 p.m.)


Review request for KDE Frameworks.


Changes
---

Type in commit message.


Repository: kde4support


Description (updated)
---

Fix up KLibLoader autotests

They now test the actual current state of KLibLoader (eg: only Qt5-style
plugins using KPluginFactory are supported).

Improve KLibLoader documentation

Also, add some extra deprecation warnings.

Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning

There is no code left to load these plugins, which have been deprecated
since kdelibs 4.0.

Use KPluginLoader in KLibLoader::factory()

This actually has some chance of succeeding (KLibrary::factory() always
returns 0).


Diffs
-

  src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e 
  src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 
  autotests/klibloadertest_module.h  
  autotests/klibloadertest_module.cpp e434cc46a7c7843186cb0fc4747f876fd5a86bc4 
  autotests/klibloadertest4_module.h  
  autotests/klibloadertest4_module.cpp 5179baf6c64228ad6ff50d1733e149740ddedc45 
  autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 
  autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 
  autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe 

Diff: https://git.reviewboard.kde.org/r/117020/diff/


Testing
---

Builds, installs, tests pass.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117020: Tidy up KLibLoader and fix up its autotests

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117020/
---

Review request for KDE Frameworks.


Repository: kde4support


Description
---

Fix up KLibLoader autotests

They now test the actual current state of KLibLoader (eg: only Qt5-style
plugins using KPluginFactory are supported).

Improve KLibLoader documentation

Also, add some extra deprecation warnings.

Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning

There is no code left to load these plugins, which have been deprecated
since kdelibs 4.0.

Use KPluginLoader in KLibLoader::factory()

This actually has some change of succeeding (KLibrary::factory() always
returns 0).


Diffs
-

  src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e 
  src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 
  autotests/klibloadertest_module.h  
  autotests/klibloadertest_module.cpp e434cc46a7c7843186cb0fc4747f876fd5a86bc4 
  autotests/klibloadertest4_module.h  
  autotests/klibloadertest4_module.cpp 5179baf6c64228ad6ff50d1733e149740ddedc45 
  autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 
  autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 
  autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe 

Diff: https://git.reviewboard.kde.org/r/117020/diff/


Testing
---

Builds, installs, tests pass.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117019: Remove fake defaultMimetype entries from protocols files

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117019/
---

Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

While looking into the issue, I turned up 
https://git.reviewboard.kde.org/r/101231/. So, this removes defaultMimetype 
entries referencing fake types which are apparently not actually required (I 
assume this is still true).


Diffs
-

  src/ioslaves/protocols/rtspu.protocol 
9cc9299f6bbe9dedb3103ff0d08f1f495428754e 
  src/ioslaves/protocols/rtspt.protocol 
9e4fe96261e9e6477f2f61801928394678a38fb4 
  src/ioslaves/protocols/pnm.protocol 3ca3a7d23e961171caca0647ee2a23a2e3fba722 
  src/ioslaves/protocols/mmsu.protocol deda935fc51235be1fea0ff96ac6c5739759817c 
  src/ioslaves/protocols/mmst.protocol 1f0f7636b7647b0853a10e50d51ecf4b33be441e 
  src/ioslaves/protocols/mms.protocol 79599ead181c9e6ee90eca08f09a097caee98c21 

Diff: https://git.reviewboard.kde.org/r/117019/diff/


Testing
---


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117018: Use qIsNaN() instead of isnan()

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/
---

(Updated March 24, 2014, 1:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.


Repository: kguiaddons


Description
---

Use qIsNaN() instead of isnan()


Revert "Use std::isnan on compilers that support it"

This reverts commit b0b7e84f75f9b9edfbe9ef8b60f56f85c4a7800c.

As apol pointed out, qIsNaN would be a better choice.


Fun fact: the Qt docs claim qIsNaN() is defined in QtGlobal, but you actually 
have to include QtNumeric.


Diffs
-

  src/CMakeLists.txt f15264e01849b00907afedc262078225ed8756a5 
  src/ConfigureChecks.cmake c194dfc5ce54c8c7fb3b0475a704f3165ce5cca1 
  src/colors/kcolorutils.cpp 5f4d0fdeb77d40d42b824c99e08e208aed6f2b93 
  src/kguiaddons_config.h.cmake 8d5cb897a7e431be298c2d290369b14dbaaa4904 

Diff: https://git.reviewboard.kde.org/r/117018/diff/


Testing
---

Builds, installs, tests pass (Linux, GCC 4.8).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117018: Use qIsNaN() instead of isnan()

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/#review53972
---


This review has been submitted with commit 
95204ce1f84054fe85e77b0d217b03dc61987a41 by Alex Merry to branch master.

- Commit Hook


On March 24, 2014, 12:10 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117018/
> ---
> 
> (Updated March 24, 2014, 12:10 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Use qIsNaN() instead of isnan()
> 
> 
> Revert "Use std::isnan on compilers that support it"
> 
> This reverts commit b0b7e84f75f9b9edfbe9ef8b60f56f85c4a7800c.
> 
> As apol pointed out, qIsNaN would be a better choice.
> 
> 
> Fun fact: the Qt docs claim qIsNaN() is defined in QtGlobal, but you actually 
> have to include QtNumeric.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt f15264e01849b00907afedc262078225ed8756a5 
>   src/ConfigureChecks.cmake c194dfc5ce54c8c7fb3b0475a704f3165ce5cca1 
>   src/colors/kcolorutils.cpp 5f4d0fdeb77d40d42b824c99e08e208aed6f2b93 
>   src/kguiaddons_config.h.cmake 8d5cb897a7e431be298c2d290369b14dbaaa4904 
> 
> Diff: https://git.reviewboard.kde.org/r/117018/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, tests pass (Linux, GCC 4.8).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117018: Use qIsNaN() instead of isnan()

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/#review53973
---


This review has been submitted with commit 
43d1f16a04a61646f904e9ed53e559b69919eaed by Alex Merry to branch master.

- Commit Hook


On March 24, 2014, 12:10 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117018/
> ---
> 
> (Updated March 24, 2014, 12:10 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Use qIsNaN() instead of isnan()
> 
> 
> Revert "Use std::isnan on compilers that support it"
> 
> This reverts commit b0b7e84f75f9b9edfbe9ef8b60f56f85c4a7800c.
> 
> As apol pointed out, qIsNaN would be a better choice.
> 
> 
> Fun fact: the Qt docs claim qIsNaN() is defined in QtGlobal, but you actually 
> have to include QtNumeric.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt f15264e01849b00907afedc262078225ed8756a5 
>   src/ConfigureChecks.cmake c194dfc5ce54c8c7fb3b0475a704f3165ce5cca1 
>   src/colors/kcolorutils.cpp 5f4d0fdeb77d40d42b824c99e08e208aed6f2b93 
>   src/kguiaddons_config.h.cmake 8d5cb897a7e431be298c2d290369b14dbaaa4904 
> 
> Diff: https://git.reviewboard.kde.org/r/117018/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, tests pass (Linux, GCC 4.8).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117017: Remove forward headers for KTextEditor

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/#review53970
---

Ship it!


Ship It!

- Christoph Cullmann


On March 24, 2014, 10:48 a.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117017/
> ---
> 
> (Updated March 24, 2014, 10:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Dominik Haumann.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> Remove forward headers for KTextEditor
> 
> Some of the headers have actually been removed already. Keeping broken
> forward headers actually makes it *more* difficult to port.
> 
> 
> Diffs
> -
> 
>   src/includes/KTextEditor/CommandExtension 
> 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/CodeCompletionModelControllerInterface 
> a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 
>   src/includes/KTextEditor/CodeCompletionModel 
> 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc 
>   src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 
>   src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae 
>   src/includes/KTextEditor/CodeCompletionInterface 
> 41341c38dd92e7c1533b0ba74eceb735408a1d3f 
>   src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d 
>   src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 
>   src/includes/KTextEditor/ConfigPage 
> b3904bee10ffc0245bca1a928389237813850ec3 
>   src/includes/KTextEditor/ConfigInterface 
> 0617835fc7621c4c26a2d50ca95d12d8870fffc2 
>   src/includes/KTextEditor/CommandInterface 
> 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/ModificationInterface 
> 50df2902648156dc5cd4630f587add36d320a43a 
>   src/includes/KTextEditor/MessageInterface 
> 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
>   src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 
>   src/includes/KTextEditor/HighlightInterface 
> 8c8c94ec679877be7e3965eba86498f06b67a883 
>   src/includes/KTextEditor/MarkInterface 
> 87adf561b38045bdd65fc3f64f24311aa901d8ee 
>   src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
>   src/includes/KTextEditor/ParameterizedSessionConfigInterface 
> 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
>   src/includes/KTextEditor/MovingRange 
> 89f68605ffa863862476831cfb836660a70e4931 
>   src/includes/KTextEditor/MovingInterface 
> bde16eaca7d68517ce7c2068186eb641daf6eab1 
>   src/includes/KTextEditor/MovingCursor 
> 7c9eb3074e4feace09cca78962caf1ff27bd6394 
>   src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 
>   src/includes/KTextEditor/VariableInterface 
> 126a93691700fab3134400907d0ba93a4e275f0d 
>   src/includes/KTextEditor/TextHintInterface 
> 6b05d9a4a45ac8807294599e04c7dc15db076cf0 
>   src/includes/KTextEditor/TemplateInterface2 
> de9d9451796710756287bfc2a627f7ae43a006b1 
>   src/includes/KTextEditor/TemplateInterface 
> 0142d17815fabb9136836effa61114aaa1994635 
>   src/includes/KTextEditor/SessionConfigInterface 
> 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
>   src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 
>   src/includes/KTextEditor/SearchInterface 
> f7dffc91739e82cceffea35de0632cb19e92ab0a 
>   src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e 
> 
> Diff: https://git.reviewboard.kde.org/r/117017/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117018: Use qIsNaN() instead of isnan()

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/#review53968
---

Ship it!


Less code, less ifdef's, more happiness!

- Aleix Pol Gonzalez


On March 24, 2014, 12:10 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117018/
> ---
> 
> (Updated March 24, 2014, 12:10 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Use qIsNaN() instead of isnan()
> 
> 
> Revert "Use std::isnan on compilers that support it"
> 
> This reverts commit b0b7e84f75f9b9edfbe9ef8b60f56f85c4a7800c.
> 
> As apol pointed out, qIsNaN would be a better choice.
> 
> 
> Fun fact: the Qt docs claim qIsNaN() is defined in QtGlobal, but you actually 
> have to include QtNumeric.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt f15264e01849b00907afedc262078225ed8756a5 
>   src/ConfigureChecks.cmake c194dfc5ce54c8c7fb3b0475a704f3165ce5cca1 
>   src/colors/kcolorutils.cpp 5f4d0fdeb77d40d42b824c99e08e208aed6f2b93 
>   src/kguiaddons_config.h.cmake 8d5cb897a7e431be298c2d290369b14dbaaa4904 
> 
> Diff: https://git.reviewboard.kde.org/r/117018/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, tests pass (Linux, GCC 4.8).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117018: Use qIsNaN() instead of isnan()

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/
---

Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.


Repository: kguiaddons


Description
---

Use qIsNaN() instead of isnan()


Revert "Use std::isnan on compilers that support it"

This reverts commit b0b7e84f75f9b9edfbe9ef8b60f56f85c4a7800c.

As apol pointed out, qIsNaN would be a better choice.


Fun fact: the Qt docs claim qIsNaN() is defined in QtGlobal, but you actually 
have to include QtNumeric.


Diffs
-

  src/CMakeLists.txt f15264e01849b00907afedc262078225ed8756a5 
  src/ConfigureChecks.cmake c194dfc5ce54c8c7fb3b0475a704f3165ce5cca1 
  src/colors/kcolorutils.cpp 5f4d0fdeb77d40d42b824c99e08e208aed6f2b93 
  src/kguiaddons_config.h.cmake 8d5cb897a7e431be298c2d290369b14dbaaa4904 

Diff: https://git.reviewboard.kde.org/r/117018/diff/


Testing
---

Builds, installs, tests pass (Linux, GCC 4.8).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Dan Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/
---

(Updated March 24, 2014, 1:01 p.m.)


Review request for KDE Frameworks.


Changes
---

Using QStandardPaths now.


Repository: kcrash


Description
---

Since KCrash is a framework that relies on DrKonqi binary being provided by a 
3rd party software (kde-runtime), it should not make assumptions regarding 
location of the utility.

This patch makes KCrash to look for drkonqi binary first in $PATH, then falling 
back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch it's possible 
for distributions to ship KDE Frameworks in normal prefix (/usr), but have 
current snapshots of kde-runtime in /opt/kde5 for instance.


Diffs (updated)
-

  src/kcrash.cpp 87163cc 

Diff: https://git.reviewboard.kde.org/r/117016/diff/


Testing
---

- Installed KCrash into /usr prefix
- Installed drkonqi from kde-runtime master to /opt/kde5 prefix
- started broken application
- no "could not find drkonqi" warning anymore
- crashed application, got drkonqi window


Thanks,

Dan Vrátil

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

[Alex Merry]

> On March 23, 2014, 11:39 p.m., Aleix Pol Gonzalez wrote:
> > src/colors/kcolorutils.cpp, line 38
> > 
> >
> > Wouldn't it make more sense to use qIsNan?
> > 
> > http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN

Huh.  Yes.  Doing work on KJS had me in the wrong mindset :-)


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866/#review53877
---


On March 22, 2014, 8:54 p.m., Michael Hansen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116866/
> ---
> 
> (Updated March 22, 2014, 8:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Use std::isnan from  instead of isnan from , as MinGW-32 on 
> Windows does not include the latter.  This keeps the _isnan hack for MSVC, 
> since that compiler doesn't include either standard version :(.
> 
> 
> Diffs
> -
> 
>   src/kguiaddons_config.h.cmake PRE-CREATION 
>   src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 
>   src/ConfigureChecks.cmake PRE-CREATION 
>   src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 
> 
> Diff: https://git.reviewboard.kde.org/r/116866/diff/
> 
> 
> Testing
> ---
> 
> Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 
> 4.8 (Arch x86_64).
> 
> 
> Thanks,
> 
> Michael Hansen
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117004: Remove out-of-date design docs

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117004/
---

(Updated March 24, 2014, 11:52 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Repository: kiconthemes


Description
---

Remove out-of-date design docs


Diffs
-

  docs/DESIGN.iconloading ceb2ffbceb90f05f7909ad71e8292d3e5480c6fc 

Diff: https://git.reviewboard.kde.org/r/117004/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117004: Remove out-of-date design docs

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117004/#review53963
---


This review has been submitted with commit 
3889bee5d08463b5216cd937bc88df85f1217851 by Alex Merry to branch master.

- Commit Hook


On March 23, 2014, 5:47 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117004/
> ---
> 
> (Updated March 23, 2014, 5:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Remove out-of-date design docs
> 
> 
> Diffs
> -
> 
>   docs/DESIGN.iconloading ceb2ffbceb90f05f7909ad71e8292d3e5480c6fc 
> 
> Diff: https://git.reviewboard.kde.org/r/117004/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116995/#review53961
---


This review has been submitted with commit 
892e693f616297a91835d3d79353926b96bd1201 by Alex Merry to branch master.

- Commit Hook


On March 23, 2014, 2:52 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116995/
> ---
> 
> (Updated March 23, 2014, 2:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Rename the kconfig_compiler_kf5 target to kconfig_compiler
> 
> Just because the executable has the "_kf5" suffix, that does not mean
> the target should have it.  This is ugly API, and will be unnecessary
> porting effort for KF6.
> 
> 
> Only one place uses this currently - one CMake file in kde4support.  I'll 
> change that when committing this.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 417cd9cb7e0d80abd9100019786e8ea19007e3ef 
>   KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 
>   autotests/kconfig_compiler/CMakeLists.txt 
> 289e9583b64396c5eb080a1bc9cb2833b540ba71 
>   src/kconfig_compiler/CMakeLists.txt 
> 71f2609d870cd00eae3d98c0f3a07504d5973ff0 
> 
> Diff: https://git.reviewboard.kde.org/r/116995/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116995/
---

(Updated March 24, 2014, 11:50 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kconfig


Description
---

Rename the kconfig_compiler_kf5 target to kconfig_compiler

Just because the executable has the "_kf5" suffix, that does not mean
the target should have it.  This is ugly API, and will be unnecessary
porting effort for KF6.


Only one place uses this currently - one CMake file in kde4support.  I'll 
change that when committing this.


Diffs
-

  CMakeLists.txt 417cd9cb7e0d80abd9100019786e8ea19007e3ef 
  KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 
  autotests/kconfig_compiler/CMakeLists.txt 
289e9583b64396c5eb080a1bc9cb2833b540ba71 
  src/kconfig_compiler/CMakeLists.txt 71f2609d870cd00eae3d98c0f3a07504d5973ff0 

Diff: https://git.reviewboard.kde.org/r/116995/diff/


Testing
---

Builds, installs, tests pass.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116993/#review53958
---


This review has been submitted with commit 
3465b1008e41a29bb3308474ddb03845ec38232c by Alex Merry to branch master.

- Commit Hook


On March 23, 2014, 2:18 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116993/
> ---
> 
> (Updated March 23, 2014, 2:18 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Use KPluginLoader::findPlugin and QLibrary instead of KLibrary
> 
> 
> Diffs
> -
> 
>   src/kcmoduleloader.cpp 31ad1aa95dd664f5d65ab81edeb3274b3c5d73e1 
> 
> Diff: https://git.reviewboard.kde.org/r/116993/diff/
> 
> 
> Testing
> ---
> 
> `kcmshell5 kcm_phonon`
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116993/
---

(Updated March 24, 2014, 11:47 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcmutils


Description
---

Use KPluginLoader::findPlugin and QLibrary instead of KLibrary


Diffs
-

  src/kcmoduleloader.cpp 31ad1aa95dd664f5d65ab81edeb3274b3c5d73e1 

Diff: https://git.reviewboard.kde.org/r/116993/diff/


Testing
---

`kcmshell5 kcm_phonon`


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116959: Remove KDE 4 references from kcmutils

[Alex Merry]

> On March 23, 2014, 9:35 p.m., David Faure wrote:
> > src/kcmultidialog.cpp, line 424
> > 
> >
> > this if() isn't needed, already tested in the parent scope.

Oops, worse than that.  I'd replaced rootOnlyMessage() (QString) with 
useRootOnlyMessage() (bool).  Fixed now.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53855
---


On March 24, 2014, 11:44 a.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116959/
> ---
> 
> (Updated March 24, 2014, 11:44 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> KCModuleProxy: remove deprecated forwarding methods
> 
> These have been deprecated since at least kdelibs 4.0, and LXR says the
> only user is KCMultiDialog (since I fixed the call in systemsettings).
> 
> KCModuleContainer: tidy up overridden methods
> 
> Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.
> 
> KCModuleContainer: move modulelist variables to private object
> 
> According to LXR, these were not used by anything.
> 
> Remove TODO file
> 
> This is full of API changes for KDE 4.  Some were done, and others not
> (but would probably be considered too disruptive for KF5).
> 
> 
> Diffs
> -
> 
>   TODO 82f28e12903e51279ba12871c7b184a97c79a12a 
>   src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 
>   src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 
>   src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 
>   src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b 
>   src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee 
> 
> Diff: https://git.reviewboard.kde.org/r/116959/diff/
> 
> 
> Testing
> ---
> 
> Compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116959: Remove KDE 4 references from kcmutils

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53954
---


This review has been submitted with commit 
82b15ec1d65ff7e771567d19018d5102a43bdc2e by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 5:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116959/
> ---
> 
> (Updated March 21, 2014, 5:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> KCModuleProxy: remove deprecated forwarding methods
> 
> These have been deprecated since at least kdelibs 4.0, and LXR says the
> only user is KCMultiDialog (since I fixed the call in systemsettings).
> 
> KCModuleContainer: tidy up overridden methods
> 
> Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.
> 
> KCModuleContainer: move modulelist variables to private object
> 
> According to LXR, these were not used by anything.
> 
> Remove TODO file
> 
> This is full of API changes for KDE 4.  Some were done, and others not
> (but would probably be considered too disruptive for KF5).
> 
> 
> Diffs
> -
> 
>   TODO 82f28e12903e51279ba12871c7b184a97c79a12a 
>   src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 
>   src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 
>   src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 
>   src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b 
>   src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee 
> 
> Diff: https://git.reviewboard.kde.org/r/116959/diff/
> 
> 
> Testing
> ---
> 
> Compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116959: Remove KDE 4 references from kcmutils

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53956
---


This review has been submitted with commit 
2bfb285f562115e1b85c8a911322e40da83130ef by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 5:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116959/
> ---
> 
> (Updated March 21, 2014, 5:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> KCModuleProxy: remove deprecated forwarding methods
> 
> These have been deprecated since at least kdelibs 4.0, and LXR says the
> only user is KCMultiDialog (since I fixed the call in systemsettings).
> 
> KCModuleContainer: tidy up overridden methods
> 
> Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.
> 
> KCModuleContainer: move modulelist variables to private object
> 
> According to LXR, these were not used by anything.
> 
> Remove TODO file
> 
> This is full of API changes for KDE 4.  Some were done, and others not
> (but would probably be considered too disruptive for KF5).
> 
> 
> Diffs
> -
> 
>   TODO 82f28e12903e51279ba12871c7b184a97c79a12a 
>   src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 
>   src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 
>   src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 
>   src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b 
>   src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee 
> 
> Diff: https://git.reviewboard.kde.org/r/116959/diff/
> 
> 
> Testing
> ---
> 
> Compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116959: Remove KDE 4 references from kcmutils

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/
---

(Updated March 24, 2014, 11:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcmutils


Description
---

KCModuleProxy: remove deprecated forwarding methods

These have been deprecated since at least kdelibs 4.0, and LXR says the
only user is KCMultiDialog (since I fixed the call in systemsettings).

KCModuleContainer: tidy up overridden methods

Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.

KCModuleContainer: move modulelist variables to private object

According to LXR, these were not used by anything.

Remove TODO file

This is full of API changes for KDE 4.  Some were done, and others not
(but would probably be considered too disruptive for KF5).


Diffs
-

  TODO 82f28e12903e51279ba12871c7b184a97c79a12a 
  src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 
  src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 
  src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 
  src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b 
  src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee 

Diff: https://git.reviewboard.kde.org/r/116959/diff/


Testing
---

Compiles, installs.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116959: Remove KDE 4 references from kcmutils

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53953
---


This review has been submitted with commit 
817f47214f94e2d76631cd5e8e87815a8945ebec by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 5:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116959/
> ---
> 
> (Updated March 21, 2014, 5:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> KCModuleProxy: remove deprecated forwarding methods
> 
> These have been deprecated since at least kdelibs 4.0, and LXR says the
> only user is KCMultiDialog (since I fixed the call in systemsettings).
> 
> KCModuleContainer: tidy up overridden methods
> 
> Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.
> 
> KCModuleContainer: move modulelist variables to private object
> 
> According to LXR, these were not used by anything.
> 
> Remove TODO file
> 
> This is full of API changes for KDE 4.  Some were done, and others not
> (but would probably be considered too disruptive for KF5).
> 
> 
> Diffs
> -
> 
>   TODO 82f28e12903e51279ba12871c7b184a97c79a12a 
>   src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 
>   src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 
>   src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 
>   src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b 
>   src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee 
> 
> Diff: https://git.reviewboard.kde.org/r/116959/diff/
> 
> 
> Testing
> ---
> 
> Compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116959: Remove KDE 4 references from kcmutils

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53955
---


This review has been submitted with commit 
b0f041b78f559a6682365c8f7e046fdec2582522 by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 5:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116959/
> ---
> 
> (Updated March 21, 2014, 5:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> KCModuleProxy: remove deprecated forwarding methods
> 
> These have been deprecated since at least kdelibs 4.0, and LXR says the
> only user is KCMultiDialog (since I fixed the call in systemsettings).
> 
> KCModuleContainer: tidy up overridden methods
> 
> Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.
> 
> KCModuleContainer: move modulelist variables to private object
> 
> According to LXR, these were not used by anything.
> 
> Remove TODO file
> 
> This is full of API changes for KDE 4.  Some were done, and others not
> (but would probably be considered too disruptive for KF5).
> 
> 
> Diffs
> -
> 
>   TODO 82f28e12903e51279ba12871c7b184a97c79a12a 
>   src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 
>   src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 
>   src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 
>   src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b 
>   src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee 
> 
> Diff: https://git.reviewboard.kde.org/r/116959/diff/
> 
> 
> Testing
> ---
> 
> Compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116937: Use QLibrary instead of KLibrary in KOpenSSL

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116937/
---

(Updated March 24, 2014, 11:43 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kde4support


Description
---

Use QLibrary instead of KLibrary in KOpenSSL


Diffs
-

  src/kssl/kopenssl.cpp 43125ae90cb4e375cb93a011acbf584adc334f0a 

Diff: https://git.reviewboard.kde.org/r/116937/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116937: Use QLibrary instead of KLibrary in KOpenSSL

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116937/#review53952
---


This review has been submitted with commit 
16b11a28e154d7030c77e8d8ffedd8968202d5d3 by Alex Merry to branch master.

- Commit Hook


On March 20, 2014, 8:50 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116937/
> ---
> 
> (Updated March 20, 2014, 8:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> Use QLibrary instead of KLibrary in KOpenSSL
> 
> 
> Diffs
> -
> 
>   src/kssl/kopenssl.cpp 43125ae90cb4e375cb93a011acbf584adc334f0a 
> 
> Diff: https://git.reviewboard.kde.org/r/116937/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117000/
---

(Updated March 24, 2014, 11:34 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kservice


Description
---

Rename kmimetypefactory.h to kmimetypefactory_p.h

This makes it obvious it is not installed.


Diffs
-

  src/kbuildsycoca/kbuildmimetypefactory.h 
a1c9f064c95191d30f92f5911168547892150729 
  src/kbuildsycoca/kbuildservicefactory.cpp 
55b2eea17e164bd64e83860a7d42d0fa95c89b84 
  src/services/kmimetypefactory.h 239a4cdfa2c3add603c6915ecd967401254cd930 
  src/services/kmimetypefactory.cpp 8fedf59170e4a1af59eae726ca873288d06ea432 
  src/services/kmimetypetrader.cpp 839579790e6624ff1856d2b5a26307d4da4f3974 
  src/services/kservice.cpp 50c86ac1a5dfa1400f7471be48494c323005c47d 

Diff: https://git.reviewboard.kde.org/r/117000/diff/


Testing
---

Builds, installs.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117000/#review53951
---


This review has been submitted with commit 
b1808656b35b24eb3133dcf7e2639d111b7d1514 by Alex Merry to branch master.

- Commit Hook


On March 23, 2014, 4:45 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117000/
> ---
> 
> (Updated March 23, 2014, 4:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Rename kmimetypefactory.h to kmimetypefactory_p.h
> 
> This makes it obvious it is not installed.
> 
> 
> Diffs
> -
> 
>   src/kbuildsycoca/kbuildmimetypefactory.h 
> a1c9f064c95191d30f92f5911168547892150729 
>   src/kbuildsycoca/kbuildservicefactory.cpp 
> 55b2eea17e164bd64e83860a7d42d0fa95c89b84 
>   src/services/kmimetypefactory.h 239a4cdfa2c3add603c6915ecd967401254cd930 
>   src/services/kmimetypefactory.cpp 8fedf59170e4a1af59eae726ca873288d06ea432 
>   src/services/kmimetypetrader.cpp 839579790e6624ff1856d2b5a26307d4da4f3974 
>   src/services/kservice.cpp 50c86ac1a5dfa1400f7471be48494c323005c47d 
> 
> Diff: https://git.reviewboard.kde.org/r/117000/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116936: Use QLibrary instead of KLibrary

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116936/
---

(Updated March 24, 2014, 11:33 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: khtml


Description
---

Use QLibrary instead of KLibrary

This code wants to load normal libraries, rather than ones in plugin
directories, and so does not need or want KLibrary's odd lookup
routines.


Diffs
-

  src/html/kopenssl.cpp 43125ae90cb4e375cb93a011acbf584adc334f0a 
  src/rendering/break_lines.cpp bc4542c7ea1031d75531b6028f3044fe15672009 

Diff: https://git.reviewboard.kde.org/r/116936/diff/


Testing
---

./tests/testkhtml 'https://git.reviewboard.kde.org'


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116936: Use QLibrary instead of KLibrary

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116936/#review53950
---


This review has been submitted with commit 
88f0d93edc884375a4cf5d77540707ca51d16141 by Alex Merry to branch master.

- Commit Hook


On March 20, 2014, 8:48 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116936/
> ---
> 
> (Updated March 20, 2014, 8:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> ---
> 
> Use QLibrary instead of KLibrary
> 
> This code wants to load normal libraries, rather than ones in plugin
> directories, and so does not need or want KLibrary's odd lookup
> routines.
> 
> 
> Diffs
> -
> 
>   src/html/kopenssl.cpp 43125ae90cb4e375cb93a011acbf584adc334f0a 
>   src/rendering/break_lines.cpp bc4542c7ea1031d75531b6028f3044fe15672009 
> 
> Diff: https://git.reviewboard.kde.org/r/116936/diff/
> 
> 
> Testing
> ---
> 
> ./tests/testkhtml 'https://git.reviewboard.kde.org'
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Problems found by the CI system

[Vishesh Handa]

On Monday, March 24, 2014 06:59:24 PM Ben Cooksley wrote:
> 
> Baloo developers, please take a look at the failure in this log -
> http://build.kde.org/view/FAILED/job/baloo_stable/80/console. When
> referencing projects outside your own, it is imperative the correct
> include statements are used in the CMake logic.
> 

I've pushed a commit. That should hopefully fix it.

Could you perhaps add some hook to email me about these failures? We don't 
have a dedicated mailing list for Baloo and I'm not sure if notifying kde-
devel would be a good idea.

-- 
Vishesh Handa
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116962: Clean up KDE4 references in kconfig

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53945
---


This review has been submitted with commit 
2cb32b4dc0ed9aed3ae705d34269f99d82c3c6dc by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 6:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116962/
> ---
> 
> (Updated March 21, 2014, 6:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Update docs for KDesktopFile::isAuthorizedDesktopFile()
> 
> The fact that it changed in KDE 4.3 is not so relevant any more.
> 
> Remove unhelpful comments
> 
> These lines of code do not really require any justification.
> 
> Better comment for why KDesktopFile::readPath uses readEntry
> 
> 
> Remove old kdelibs4 code
> 
> All this ifdef'd-out code just makes it hard to see what's going on.
> 
> Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}
> 
> Not sure why it would be unset and then used, instead of just not used
> at all.  LXR says it's not used anywhere else, though.
> 
> 
> Diffs
> -
> 
>   KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047 
>   KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 
>   src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500 
>   src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34 
>   src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 
>   src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0 
>   src/kconfig_compiler/CMakeLists.txt 
> 71f2609d870cd00eae3d98c0f3a07504d5973ff0 
> 
> Diff: https://git.reviewboard.kde.org/r/116962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116962: Clean up KDE4 references in kconfig

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/
---

(Updated March 24, 2014, 11:27 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kconfig


Description
---

Update docs for KDesktopFile::isAuthorizedDesktopFile()

The fact that it changed in KDE 4.3 is not so relevant any more.

Remove unhelpful comments

These lines of code do not really require any justification.

Better comment for why KDesktopFile::readPath uses readEntry


Remove old kdelibs4 code

All this ifdef'd-out code just makes it hard to see what's going on.

Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}

Not sure why it would be unset and then used, instead of just not used
at all.  LXR says it's not used anywhere else, though.


Diffs
-

  KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047 
  KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 
  src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500 
  src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34 
  src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 
  src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0 
  src/kconfig_compiler/CMakeLists.txt 71f2609d870cd00eae3d98c0f3a07504d5973ff0 

Diff: https://git.reviewboard.kde.org/r/116962/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116962: Clean up KDE4 references in kconfig

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53942
---


This review has been submitted with commit 
c018f617f1f0eff18bc144ff05f64ff95f07f573 by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 6:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116962/
> ---
> 
> (Updated March 21, 2014, 6:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Update docs for KDesktopFile::isAuthorizedDesktopFile()
> 
> The fact that it changed in KDE 4.3 is not so relevant any more.
> 
> Remove unhelpful comments
> 
> These lines of code do not really require any justification.
> 
> Better comment for why KDesktopFile::readPath uses readEntry
> 
> 
> Remove old kdelibs4 code
> 
> All this ifdef'd-out code just makes it hard to see what's going on.
> 
> Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}
> 
> Not sure why it would be unset and then used, instead of just not used
> at all.  LXR says it's not used anywhere else, though.
> 
> 
> Diffs
> -
> 
>   KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047 
>   KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 
>   src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500 
>   src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34 
>   src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 
>   src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0 
>   src/kconfig_compiler/CMakeLists.txt 
> 71f2609d870cd00eae3d98c0f3a07504d5973ff0 
> 
> Diff: https://git.reviewboard.kde.org/r/116962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116962: Clean up KDE4 references in kconfig

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53944
---


This review has been submitted with commit 
16348884c6b3632b9a7c7fee76c74d708c142f38 by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 6:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116962/
> ---
> 
> (Updated March 21, 2014, 6:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Update docs for KDesktopFile::isAuthorizedDesktopFile()
> 
> The fact that it changed in KDE 4.3 is not so relevant any more.
> 
> Remove unhelpful comments
> 
> These lines of code do not really require any justification.
> 
> Better comment for why KDesktopFile::readPath uses readEntry
> 
> 
> Remove old kdelibs4 code
> 
> All this ifdef'd-out code just makes it hard to see what's going on.
> 
> Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}
> 
> Not sure why it would be unset and then used, instead of just not used
> at all.  LXR says it's not used anywhere else, though.
> 
> 
> Diffs
> -
> 
>   KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047 
>   KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 
>   src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500 
>   src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34 
>   src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 
>   src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0 
>   src/kconfig_compiler/CMakeLists.txt 
> 71f2609d870cd00eae3d98c0f3a07504d5973ff0 
> 
> Diff: https://git.reviewboard.kde.org/r/116962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116962: Clean up KDE4 references in kconfig

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53946
---


This review has been submitted with commit 
a9ac60da055e108d153e265190ebd870cecb9f6f by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 6:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116962/
> ---
> 
> (Updated March 21, 2014, 6:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Update docs for KDesktopFile::isAuthorizedDesktopFile()
> 
> The fact that it changed in KDE 4.3 is not so relevant any more.
> 
> Remove unhelpful comments
> 
> These lines of code do not really require any justification.
> 
> Better comment for why KDesktopFile::readPath uses readEntry
> 
> 
> Remove old kdelibs4 code
> 
> All this ifdef'd-out code just makes it hard to see what's going on.
> 
> Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}
> 
> Not sure why it would be unset and then used, instead of just not used
> at all.  LXR says it's not used anywhere else, though.
> 
> 
> Diffs
> -
> 
>   KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047 
>   KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 
>   src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500 
>   src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34 
>   src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 
>   src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0 
>   src/kconfig_compiler/CMakeLists.txt 
> 71f2609d870cd00eae3d98c0f3a07504d5973ff0 
> 
> Diff: https://git.reviewboard.kde.org/r/116962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116962: Clean up KDE4 references in kconfig

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53943
---


This review has been submitted with commit 
54e96153a57c43da26588acc2dd5d5f29763d124 by Alex Merry to branch master.

- Commit Hook


On March 21, 2014, 6:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116962/
> ---
> 
> (Updated March 21, 2014, 6:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Update docs for KDesktopFile::isAuthorizedDesktopFile()
> 
> The fact that it changed in KDE 4.3 is not so relevant any more.
> 
> Remove unhelpful comments
> 
> These lines of code do not really require any justification.
> 
> Better comment for why KDesktopFile::readPath uses readEntry
> 
> 
> Remove old kdelibs4 code
> 
> All this ifdef'd-out code just makes it hard to see what's going on.
> 
> Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}
> 
> Not sure why it would be unset and then used, instead of just not used
> at all.  LXR says it's not used anywhere else, though.
> 
> 
> Diffs
> -
> 
>   KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047 
>   KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 
>   src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500 
>   src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34 
>   src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 
>   src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0 
>   src/kconfig_compiler/CMakeLists.txt 
> 71f2609d870cd00eae3d98c0f3a07504d5973ff0 
> 
> Diff: https://git.reviewboard.kde.org/r/116962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117006: Remove kde3 compatibility code and comments

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117006/#review53941
---


This review has been submitted with commit 
45ec64067d032e19953ca017a632bfebb0cc9aa7 by Alex Merry to branch master.

- Commit Hook


On March 23, 2014, 6:25 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117006/
> ---
> 
> (Updated March 23, 2014, 6:25 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Remove kde3 compatibility code and comments
> 
> 
> Diffs
> -
> 
>   src/core/kfileitem.cpp a37950860c4c009605b37b8d6d5a09f0e8a604d0 
>   src/core/kmountpoint.cpp 86ed0b2b3ce80a9ceb1d754f321abfed7d04258e 
>   src/ioslaves/ftp/ftp.cpp 23b1d8f4832f3184d2bf8fee6f8d814dcfeca948 
>   src/widgets/kdirmodel.cpp bd62d8e66bda0e4b4bea4d88d71b991740e9d91b 
> 
> Diff: https://git.reviewboard.kde.org/r/117006/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117006: Remove kde3 compatibility code and comments

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117006/
---

(Updated March 24, 2014, 11:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

Remove kde3 compatibility code and comments


Diffs
-

  src/core/kfileitem.cpp a37950860c4c009605b37b8d6d5a09f0e8a604d0 
  src/core/kmountpoint.cpp 86ed0b2b3ce80a9ceb1d754f321abfed7d04258e 
  src/ioslaves/ftp/ftp.cpp 23b1d8f4832f3184d2bf8fee6f8d814dcfeca948 
  src/widgets/kdirmodel.cpp bd62d8e66bda0e4b4bea4d88d71b991740e9d91b 

Diff: https://git.reviewboard.kde.org/r/117006/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: LXR

[Alex Merry]

On 23/03/14 19:51, David Faure wrote:
> On Sunday 23 March 2014 17:33:46 Alex Merry wrote:
>> On 23/03/14 14:55, Alex Merry wrote:
>>> On 20/03/14 08:13, David Faure wrote:
 On Thursday 20 March 2014 00:28:44 Alex Merry wrote:
>  LXR says the only
>
> users are a couple of projects that haven't even made it onto
> projects.kde.org.

 Talking about LXR... I just finished setting up
 http://lxrnew.kde.org/ident
 Can you use it for your upcoming searches, to beta-test it?
 If nothing major came up, we'll switch lxr.kde.org to that new site.
>>>
>>> It seems to be working really well.  The branch-group switching
>>> functionality is really useful.
>>
>> Oh, except that in the general search mode, switching branches clears
>> the file name and perl regex fields.
> 
> In all search modes, actually.
> This is just HTML-1.0 link technology from 1990 :)
> The links load a new page, the fields get reloaded.

Nu-uh.  If I do an identifier search for KService in latest-qt4, the
kf5-qt5 link becomes
http://lxrnew.kde.org/ident?v=kf5-qt5&_i=KService&_remember=1 - encoding
the search field.  The same happens with the "containing" field in the
general search, but not the "files named" or "advanced" fields.

Alex


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117017: Remove forward headers for KTextEditor

[Kevin Funk]

> On March 24, 2014, 10:57 a.m., Aleix Pol Gonzalez wrote:
> > There's a slight difference, and the reason we haven't been doing this for 
> > most headers. From KDE4Support you can include headers prefixing KDE/ (such 
> > as KDE/KTextEditor/MovingRange). If you remove these that won't be possible 
> > anymore thus making porting slightly harder. Arguably people won't be doing 
> > KDE/KTextEditor, but then I don't know why people added the KDE/ at all...

Yep. I'm just fixing this up in KDevelop (where I hit that problem), replacing 
occurences of 'KDE/'.

The problem with the KTE forward headers are that some of them are already 
broken (TemplateInterface*, HighlightInterface, and others). This makes it 
harder than easier to port, because you get compile errors in the middle of the 
build process.

Arguably, I'd rather force people to get rid off the 'KDE/' prefix (which is 
easy to script) than to compile again and again to make your code work.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/#review53937
---


On March 24, 2014, 10:48 a.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117017/
> ---
> 
> (Updated March 24, 2014, 10:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Dominik Haumann.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> Remove forward headers for KTextEditor
> 
> Some of the headers have actually been removed already. Keeping broken
> forward headers actually makes it *more* difficult to port.
> 
> 
> Diffs
> -
> 
>   src/includes/KTextEditor/CommandExtension 
> 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/CodeCompletionModelControllerInterface 
> a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 
>   src/includes/KTextEditor/CodeCompletionModel 
> 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc 
>   src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 
>   src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae 
>   src/includes/KTextEditor/CodeCompletionInterface 
> 41341c38dd92e7c1533b0ba74eceb735408a1d3f 
>   src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d 
>   src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 
>   src/includes/KTextEditor/ConfigPage 
> b3904bee10ffc0245bca1a928389237813850ec3 
>   src/includes/KTextEditor/ConfigInterface 
> 0617835fc7621c4c26a2d50ca95d12d8870fffc2 
>   src/includes/KTextEditor/CommandInterface 
> 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/ModificationInterface 
> 50df2902648156dc5cd4630f587add36d320a43a 
>   src/includes/KTextEditor/MessageInterface 
> 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
>   src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 
>   src/includes/KTextEditor/HighlightInterface 
> 8c8c94ec679877be7e3965eba86498f06b67a883 
>   src/includes/KTextEditor/MarkInterface 
> 87adf561b38045bdd65fc3f64f24311aa901d8ee 
>   src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
>   src/includes/KTextEditor/ParameterizedSessionConfigInterface 
> 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
>   src/includes/KTextEditor/MovingRange 
> 89f68605ffa863862476831cfb836660a70e4931 
>   src/includes/KTextEditor/MovingInterface 
> bde16eaca7d68517ce7c2068186eb641daf6eab1 
>   src/includes/KTextEditor/MovingCursor 
> 7c9eb3074e4feace09cca78962caf1ff27bd6394 
>   src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 
>   src/includes/KTextEditor/VariableInterface 
> 126a93691700fab3134400907d0ba93a4e275f0d 
>   src/includes/KTextEditor/TextHintInterface 
> 6b05d9a4a45ac8807294599e04c7dc15db076cf0 
>   src/includes/KTextEditor/TemplateInterface2 
> de9d9451796710756287bfc2a627f7ae43a006b1 
>   src/includes/KTextEditor/TemplateInterface 
> 0142d17815fabb9136836effa61114aaa1994635 
>   src/includes/KTextEditor/SessionConfigInterface 
> 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
>   src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 
>   src/includes/KTextEditor/SearchInterface 
> f7dffc91739e82cceffea35de0632cb19e92ab0a 
>   src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e 
> 
> Diff: https://git.reviewboard.kde.org/r/117017/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53939
---


What about QStandardPaths::findExecutable? Actually this one should look into 
libexec too (at least the equivalent KStandardDirs::findExe used to).

- Aleix Pol Gonzalez


On March 24, 2014, 10:52 a.m., Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117016/
> ---
> 
> (Updated March 24, 2014, 10:52 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Since KCrash is a framework that relies on DrKonqi binary being provided by a 
> 3rd party software (kde-runtime), it should not make assumptions regarding 
> location of the utility.
> 
> This patch makes KCrash to look for drkonqi binary first in $PATH, then 
> falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch 
> it's possible for distributions to ship KDE Frameworks in normal prefix 
> (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 87163cc 
> 
> Diff: https://git.reviewboard.kde.org/r/117016/diff/
> 
> 
> Testing
> ---
> 
> - Installed KCrash into /usr prefix
> - Installed drkonqi from kde-runtime master to /opt/kde5 prefix
> - started broken application
> - no "could not find drkonqi" warning anymore
> - crashed application, got drkonqi window
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review53938
---


Then you should modify the target_include_directories INSTALL_INTERFACE data, 
no?

- Aleix Pol Gonzalez


On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117012/
> ---
> 
> (Updated March 24, 2014, 1:33 a.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> ---
> 
> Currently kjsembed CMake file tries to install both 
> ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
> ${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
> allowed in a case-insensitive filesystem, causing the install step to fail on 
> Windows.
> 
> 
> Diffs
> -
> 
>   src/kjsembed/CMakeLists.txt e0ab74c 
> 
> Diff: https://git.reviewboard.kde.org/r/117012/diff/
> 
> 
> Testing
> ---
> 
> Tested using MSVC 2013
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117017: Remove forward headers for KTextEditor

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/#review53937
---


There's a slight difference, and the reason we haven't been doing this for most 
headers. From KDE4Support you can include headers prefixing KDE/ (such as 
KDE/KTextEditor/MovingRange). If you remove these that won't be possible 
anymore thus making porting slightly harder. Arguably people won't be doing 
KDE/KTextEditor, but then I don't know why people added the KDE/ at all...

- Aleix Pol Gonzalez


On March 24, 2014, 10:48 a.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117017/
> ---
> 
> (Updated March 24, 2014, 10:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Dominik Haumann.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> Remove forward headers for KTextEditor
> 
> Some of the headers have actually been removed already. Keeping broken
> forward headers actually makes it *more* difficult to port.
> 
> 
> Diffs
> -
> 
>   src/includes/KTextEditor/CommandExtension 
> 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/CodeCompletionModelControllerInterface 
> a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 
>   src/includes/KTextEditor/CodeCompletionModel 
> 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc 
>   src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 
>   src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae 
>   src/includes/KTextEditor/CodeCompletionInterface 
> 41341c38dd92e7c1533b0ba74eceb735408a1d3f 
>   src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d 
>   src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 
>   src/includes/KTextEditor/ConfigPage 
> b3904bee10ffc0245bca1a928389237813850ec3 
>   src/includes/KTextEditor/ConfigInterface 
> 0617835fc7621c4c26a2d50ca95d12d8870fffc2 
>   src/includes/KTextEditor/CommandInterface 
> 4187c61882a83cab906fa87cd16bd18229b6efb5 
>   src/includes/KTextEditor/ModificationInterface 
> 50df2902648156dc5cd4630f587add36d320a43a 
>   src/includes/KTextEditor/MessageInterface 
> 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
>   src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 
>   src/includes/KTextEditor/HighlightInterface 
> 8c8c94ec679877be7e3965eba86498f06b67a883 
>   src/includes/KTextEditor/MarkInterface 
> 87adf561b38045bdd65fc3f64f24311aa901d8ee 
>   src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 
>   src/includes/KTextEditor/ParameterizedSessionConfigInterface 
> 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
>   src/includes/KTextEditor/MovingRange 
> 89f68605ffa863862476831cfb836660a70e4931 
>   src/includes/KTextEditor/MovingInterface 
> bde16eaca7d68517ce7c2068186eb641daf6eab1 
>   src/includes/KTextEditor/MovingCursor 
> 7c9eb3074e4feace09cca78962caf1ff27bd6394 
>   src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 
>   src/includes/KTextEditor/VariableInterface 
> 126a93691700fab3134400907d0ba93a4e275f0d 
>   src/includes/KTextEditor/TextHintInterface 
> 6b05d9a4a45ac8807294599e04c7dc15db076cf0 
>   src/includes/KTextEditor/TemplateInterface2 
> de9d9451796710756287bfc2a627f7ae43a006b1 
>   src/includes/KTextEditor/TemplateInterface 
> 0142d17815fabb9136836effa61114aaa1994635 
>   src/includes/KTextEditor/SessionConfigInterface 
> 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 
>   src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 
>   src/includes/KTextEditor/SearchInterface 
> f7dffc91739e82cceffea35de0632cb19e92ab0a 
>   src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e 
> 
> Diff: https://git.reviewboard.kde.org/r/117017/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117005: Remove KDE3 KParts compatibility code

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117005/#review53936
---


This review has been submitted with commit 
c5db9d34fca7435a5c50da356e3f7b44b61e74a3 by Alex Merry to branch master.

- Commit Hook


On March 23, 2014, 6:19 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117005/
> ---
> 
> (Updated March 23, 2014, 6:19 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Remove KDE3 KParts compatibility code
> 
> 
> Diffs
> -
> 
>   src/plugin/kpluginfactory.cpp 4efd07a1dc2f70073580b9223b4694abaeb5d225 
> 
> Diff: https://git.reviewboard.kde.org/r/117005/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117005: Remove KDE3 KParts compatibility code

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117005/
---

(Updated March 24, 2014, 10:54 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
---

Remove KDE3 KParts compatibility code


Diffs
-

  src/plugin/kpluginfactory.cpp 4efd07a1dc2f70073580b9223b4694abaeb5d225 

Diff: https://git.reviewboard.kde.org/r/117005/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel