Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 131 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/131/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 06 Nov 2015 19:36:31 +
Build duration: 2 min 59 sec

CHANGE SET
Revision f32677b8e08a867f3a5f0e9f20a71a9f363b9eaa by nowrep: (Take 
QApplication::wheelScrollLines into account from ScrollView)
  change: edit src/declarativeimports/plasmastyle/ScrollViewStyle.qml
Revision db7f198a19c1222e0105e5ac16e2d1b2c2246409 by shafff: (-use 
QStringLiteral and QLatin1String in the code that is executed)
  change: edit src/scriptengines/qml/plasmoid/appletinterface.cpp
  change: edit src/declarativeimports/platformcomponents/application.h
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3917/10053 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 544/565 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 356/2010 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1591/3640 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 945/1746 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 481/1785 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 122 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/122/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 06 Nov 2015 19:00:51 +
Build duration: 2 min 39 sec

CHANGE SET
Revision ae4ba8920e6c909ae2cb2112539783eca1e31620 by Martin Gräßlin: 
([declarative/core] Use BypassWindowManagerHint only on platform X11)
  change: add src/declarativeimports/core/config-x11.h.cmake
  change: edit src/declarativeimports/core/CMakeLists.txt
  change: edit src/declarativeimports/core/tooltipdialog.cpp
Revision f32677b8e08a867f3a5f0e9f20a71a9f363b9eaa by nowrep: (Take 
QApplication::wheelScrollLines into account from ScrollView)
  change: edit src/declarativeimports/plasmastyle/ScrollViewStyle.qml
Revision db7f198a19c1222e0105e5ac16e2d1b2c2246409 by shafff: (-use 
QStringLiteral and QLatin1String in the code that is executed)
  change: edit src/scriptengines/qml/plasmoid/appletinterface.cpp
  change: edit src/declarativeimports/platformcomponents/application.h
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3908/10015 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 543/564 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 355/2009 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1588/3635 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 942/1739 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/184 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 480/1771 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125969: kinit: fix Coverity issues + small optimization

[Nick Shaforostoff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125969/
---

(Updated Nov. 7, 2015, 12:04 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
---

Submitted with commit 04e64f8ec47476530157cefc434776f4aa93a27f by Nick 
Shaforostoff to branch master.


Repository: kinit


Description
---

this patch fixes two coverity issues ranked 'outstanding':
https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24554334&mergedDefectId=258481
https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24557588&mergedDefectId=258474

and also does small string-related optimization by eliminating redundant 
mallocs done by QByteArray ctor


Diffs
-

  src/kdeinit/kinit.cpp 9e775b6 

Diff: https://git.reviewboard.kde.org/r/125969/diff/


Testing
---

compiles fine


Thanks,

Nick Shaforostoff

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125641: Allow PAM unlocking of a running wallet

[Valentin Rusu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125641/#review88114
---

Ship it!


Ship It!

- Valentin Rusu


On Oct. 16, 2015, 4:52 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125641/
> ---
> 
> (Updated Oct. 16, 2015, 4:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> A use-case: kwallet gets locked with lockscreen, eg. on Plasma Mobile, 
> unlocking the screen would also unlock kwallet through PAM.
> 
> Another use-case: automatic login that shows lockscreen after booting, 
> unlocking that session would also unlock kwallet through PAM.
> 
> This requires a small change in kwallet-pam.
> 
> Now to the patch itself. When a user authenticates via lockscreen, PAM can 
> start the kwalletd process and pass the auth hash token to it. In case the 
> kwalletd process is already running, this patch would check if the wallet is 
> opened and if not, it would pass the PAM hash token over dbus to the running 
> kwallet instance which would unlock the running wallet. If it is unlocked, 
> nothing would happen.
> 
> I originally didn't want to pass it over dbus, but in the end it doesn't 
> matter because as soon as the session is unlocked (at this point the hash is 
> sent), the wallet would be unlocked and a possible attacker would have access 
> to its data anyway. But I'm open to suggestions on improvements.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp fbab58d 
> 
> Diff: https://git.reviewboard.kde.org/r/125641/diff/
> 
> 
> Testing
> ---
> 
> I've created a special PAM profile which has
> 
> auth   optionalpam_kwallet5.so lockscreen 
> kwalletd=/opt/kde5/bin/kwalletd5
> 
> ran kcheckpass -c myprofile and kwallet5 got started and unlocked. Then I 
> locked the wallet using kwalletmanager5, ran kcheckpass -c myprofile again 
> and the running kwallet5 instance got unlocked.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[CRITICAL] KIO Test "threadtest" can enter into infinite loop

[Ben Cooksley]

Hi all,

It appears the test running with the binary name of "threadtest" in
kio has a grave bug which can lead to it entering into an infinite
loop.

This was consuming virtually the entire resources of one builder with
old hung processes, and the whole core of another builder -
drastically limiting the capabilities of the CI system (even though
KIO was not being built at the time).

Can someone please investigate? Manual intervention (with kill -9) is
needed to remove these hung processes.

Thanks,
Ben
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125969: kinit: fix Coverity issues + small optimization

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125969/#review88106
---

Ship it!


Ship It!

- Alex Merry


On Nov. 6, 2015, 4 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125969/
> ---
> 
> (Updated Nov. 6, 2015, 4 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> this patch fixes two coverity issues ranked 'outstanding':
> https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24554334&mergedDefectId=258481
> https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24557588&mergedDefectId=258474
> 
> and also does small string-related optimization by eliminating redundant 
> mallocs done by QByteArray ctor
> 
> 
> Diffs
> -
> 
>   src/kdeinit/kinit.cpp 9e775b6 
> 
> Diff: https://git.reviewboard.kde.org/r/125969/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 130 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/130/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 06 Nov 2015 07:52:49 +
Build duration: 7 min 3 sec

CHANGE SET
Revision ae4ba8920e6c909ae2cb2112539783eca1e31620 by Martin Gräßlin: 
([declarative/core] Use BypassWindowManagerHint only on platform X11)
  change: add src/declarativeimports/core/config-x11.h.cmake
  change: edit src/declarativeimports/core/tooltipdialog.cpp
  change: edit src/declarativeimports/core/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3917/10053 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 544/565 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 356/2010 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1591/3640 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 945/1746 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 481/1785 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 121 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/121/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 06 Nov 2015 06:19:36 +
Build duration: 6 min 18 sec

CHANGE SET
Revision 0233a7d5718774781d2b2a814742df1f09c353f6 by Marco Martin: (delete old 
panel background)
  change: edit src/desktoptheme/breeze-dark/CMakeLists.txt
  change: delete 
src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svgz


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3908/10009 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 543/564 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 355/2003 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1588/3635 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 942/1739 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/184 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 480/1771 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
---

(Updated Nov. 6, 2015, 5:57 p.m.)


Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Repository: kpackage


Description
---

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs (updated)
-

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp 567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
---

covered by autotests


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

[Nick Shaforostoff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review88105
---



src/util/urlhandler.cpp (line 49)


there is no point in using QStringLiteral there as a deep copy is done 
anyways. using QLatin1String would take almost the same time, except that the 
.so binary would be smaller.

instead for QStandardPaths::findExecutable it does make sense to use 
QStringLiteral


- Nick Shaforostoff


On Nov. 6, 2015, 4:48 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 6, 2015, 4:48 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

[Nick Shaforostoff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/#review88104
---



src/kpackage/private/packagejobthread.cpp (line 320)


QLatin1String("/metadata.desktop")


- Nick Shaforostoff


On Nov. 6, 2015, 4:10 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125976/
> ---
> 
> (Updated Nov. 6, 2015, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> new job based update() function that compared to install()
> if a package with the same pluginId is already installed,
> removes the old one before installing the new one, if
> and only if the version of the new one is more recent
> 
> 
> Diffs
> -
> 
>   autotests/plasmoidpackagetest.h f730dce 
>   autotests/plasmoidpackagetest.cpp 567 
>   src/kpackage/CMakeLists.txt 3696f37 
>   src/kpackage/package.h 4ada8da 
>   src/kpackage/package.cpp 539b21a 
>   src/kpackage/packagestructure.h 9427b42 
>   src/kpackage/packagestructure.cpp 0070514 
>   src/kpackage/private/packagejob.cpp 0d2241b 
>   src/kpackage/private/packagejob_p.h 267429f 
>   src/kpackage/private/packagejobthread.cpp ca523b3 
>   src/kpackage/private/packagejobthread_p.h bf8a266 
>   src/kpackage/private/versionparser.cpp PRE-CREATION 
>   src/kpackagetool/CMakeLists.txt 78e0fb0 
> 
> Diff: https://git.reviewboard.kde.org/r/125976/diff/
> 
> 
> Testing
> ---
> 
> covered by autotests
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

[Nick Shaforostoff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125971/
---

(Updated Nov. 6, 2015, 5:32 p.m.)


Review request for KDE Frameworks and Laurent Montel.


Changes
---

I have removed qDeleteAll(m_entryList) as it was causing one test to fail.

I have added a ~K7ZipFileEntry() destructor to delete m_buffer -> this removes 
about 1mb leaked memory during 'make test' execution, as shown by valgrind


Repository: karchive


Description
---

i couldn't find the place where the pointers contained in the member arrays are 
deleted so i have added their releasing. for this i have used qDeleteAll (you 
can search for qDeleteAll in the diff)

also i have reordered members of FileInfo to reduce its 'sizeof'
also using qvector for storing pointers is as fast as using qlist (or even 
faster) and needs less memory
also i have switched qvector acces from operator[] to .at() because it is const 
(doesn't call detach() method internally)
also i have disabled the code that was filling 'method' string because it was 
not used anywhere after


Diffs (updated)
-

  src/k7zip.cpp 321620a 
  src/karchive.cpp 0ece37c 

Diff: https://git.reviewboard.kde.org/r/125971/diff/


Testing
---

compiles fine


Thanks,

Nick Shaforostoff

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/
---

(Updated Nov. 6, 2015, 4:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.


Changes
---

Submitted with commit c61b3a8acfd013e50219e62da68f300ab43acfaf by Aleix Pol to 
branch master.


Repository: kguiaddons


Description
---

Tries to reach out to docs.kde.org when khelpcenter is not available.


Diffs
-

  src/util/urlhandler.cpp 5b46be2 

Diff: https://git.reviewboard.kde.org/r/125815/diff/


Testing
---

I tried it with a couple of applications. For the main documentation just works.

Needs figuring out for more complex cases, I'm unsure if applications are 
opening the documentation in specific pages. In fact, I couldn't find the 
documentation for docs.kde.org url scheme, and I just made up the `path` part, 
although it seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

[Aleix Pol Gonzalez]

> On Nov. 4, 2015, 1:43 a.m., Aleix Pol Gonzalez wrote:
> > Bump? Anyone with docs.kde.org knowledge around?
> 
> Ben Cooksley wrote:
> As long as the application name is being submitted in lower case, it 
> should work fine.
> 
> Examples: 
> https://docs.kde.org/index.php?branch=stable5&application=gwenview
> https://docs.kde.org/index.php?branch=stable5&application=konversation
> https://docs.kde.org/index.php?branch=stable5&application=dolphin
> 
> Luigi Toscano wrote:
> There are few exceptions for kioslaves and kcm modules:
> application=kioslave5/ftp for kioslaves (or kioslave/ftp for the kdelibs4 
> based version)
> application=kcontrol/powerdevil
> Not sure if they need to be handled there or those values are already 
> specified as applicationName()
> 
> For the record, all the source code is here:
> https://quickgit.kde.org/?p=websites%2Fdocs-kde-org.git&a=tree
> 
> Ralf Habacker wrote:
> What about language selection ? khelpcenter also covers to select the 
> language currently used in the KDE environment.

I introduced it in the committed version. It will need some love in the 
server-side though, since it needs to understand that "fr_FR" is "fr".
We can do the cutting before the _ because there's some exceptions, for example 
zh_CN.

Help there is welcome.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review87979
---


On Nov. 4, 2015, 6:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 4, 2015, 6:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build and test failures with Qt 5.6 and Qt 5.3

[Jan Kundrát]

Hi folks,
please take a look at the CI status matrix at [1]. TL;DR: There are build 
failures with Qt 5.3, plenty of test failures, and some test failures 
specific to the still unreleased Qt 5.6.


Oh, and a cmake 3.4-git regression that I'm not going to bother you with. 
Reported, known, downgraded for now.


This testing is more or less a side effect of kio's and plasma-workspace 
presence in Gerrit. If you like this CI coverage, if you appreciate the 
range of covered compilers and Qt5 versions, or if you would like it to 
extend the coverage to all of KF5 and/or plasma or some other apps, please 
let me know.


A quick summary (please click the "console" link in the matrix overview to 
see full log):


- [5.3] kactivities: won't build due to QQuickWidget::setClearColor which 
is 5.4+ only.


- [5.3] kcoreaddons: QDebug::noquote

- [5.3] kwidgetsaddons: QTimer::singleShot and the new slot syntax

- [5.3] plasma-workspace: QString::splitRef

- [5.6] karchive: wrong number of items in the archive

- [5.6] kconfig: error which I don't understand

- [5.6] kcoreaddons: different number formatting

- kio, in all versions: test failures in KNewFileMenuTest::test(text file 
with jpeg extension)


- kservice, in all versions: test failure

- [5.6] kwindowsystem: KWindowInfoX11Test fails tests

- plasma-framework, all versions: wrong dialog dimensions/offsets

[1] http://ci-logs.kde.flaska.net/matrix.html

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
---

(Updated Nov. 6, 2015, 4:10 p.m.)


Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Repository: kpackage


Description
---

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs (updated)
-

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp 567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
---

covered by autotests


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125976: add an update() method

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
---

Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Repository: kpackage


Description
---

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs
-

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp 567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
---

covered by autotests


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125969: kinit: fix Coverity issues + small optimization

[Nick Shaforostoff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125969/
---

(Updated Nov. 6, 2015, 4 p.m.)


Review request for KDE Frameworks and Alex Merry.


Changes
---

now displayEnvVarName_c() returns const char* and displayEnvVarName() is 
wrapping it into a QByteArray


Repository: kinit


Description
---

this patch fixes two coverity issues ranked 'outstanding':
https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24554334&mergedDefectId=258481
https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24557588&mergedDefectId=258474

and also does small string-related optimization by eliminating redundant 
mallocs done by QByteArray ctor


Diffs (updated)
-

  src/kdeinit/kinit.cpp 9e775b6 

Diff: https://git.reviewboard.kde.org/r/125969/diff/


Testing
---

compiles fine


Thanks,

Nick Shaforostoff

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

[Milian Wolff]

> On Nov. 6, 2015, 12:25 p.m., Milian Wolff wrote:
> > I'd remove the code, instead of just commenting it out if it's really not 
> > needed.
> > 
> > Also, minor nitpick: QList is pretty much equivalent to QVector, 
> > you won't see any big difference, performance or memory wise. That said, 
> > I'm all for using QVector everywhere by default. It's certainly not worse 
> > than QList ;-)
> > 
> > Thanks!
> > 
> > Oh and maybe wait for a review of David before pushing this. I have no clue 
> > about the code itself. The patch looks fine from my POV though.

above should read:

...`QList` is pretty much equivalent to `QVector`...


- Milian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125971/#review88094
---


On Nov. 5, 2015, 11:55 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125971/
> ---
> 
> (Updated Nov. 5, 2015, 11:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Laurent Montel.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> i couldn't find the place where the pointers contained in the member arrays 
> are deleted so i have added their releasing. for this i have used qDeleteAll 
> (you can search for qDeleteAll in the diff)
> 
> also i have reordered members of FileInfo to reduce its 'sizeof'
> also using qvector for storing pointers is as fast as using qlist (or even 
> faster) and needs less memory
> also i have switched qvector acces from operator[] to .at() because it is 
> const (doesn't call detach() method internally)
> also i have disabled the code that was filling 'method' string because it was 
> not used anywhere after
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 321620a 
> 
> Diff: https://git.reviewboard.kde.org/r/125971/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125965: Add declarative plugin to KHolidays

[Nick Shaforostoff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125965/#review88099
---



src/declarative/holidayregionsmodel.cpp (line 81)


i suggest enclosing strings into QByteArrayLiteral.

see http://woboq.com/blog/qstringliteral.html for explanation and 
https://gitlab.com/pteam/pteam-qtbase/commit/05663e29d047851adb9a1ef440fb78b38ff3cc9b
 for the case when QBAL are not suitable


- Nick Shaforostoff


On Nov. 5, 2015, 7:57 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125965/
> ---
> 
> (Updated Nov. 5, 2015, 7:57 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kholidays
> 
> 
> Description
> ---
> 
> For now it contains just the model of holiday regions
> which will be used in the Plasma calendar events
> configuration.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e8b7970 
>   src/CMakeLists.txt c067b6c 
>   src/declarative/CMakeLists.txt PRE-CREATION 
>   src/declarative/holidayregionsmodel.h PRE-CREATION 
>   src/declarative/holidayregionsmodel.cpp PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION 
>   src/declarative/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125965/diff/
> 
> 
> Testing
> ---
> 
> Applet configuration contains proper list of available
> holiday regions.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125965: Add declarative plugin to KHolidays

[Aleix Pol Gonzalez]

> On Nov. 6, 2015, 12:49 a.m., Aleix Pol Gonzalez wrote:
> > I don't know enough about the module, so I don't know about the exact case, 
> > but usually it's good to develop such API outside then when it stabilizes 
> > merge to the framework, I'd say. Otherwise changes in the API will be very 
> > hard.
> 
> Martin Klapetek wrote:
> Well it's a simple non-exported model, I don't see any API changes coming 
> to that.

ok, +1.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125965/#review88070
---


On Nov. 5, 2015, 8:57 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125965/
> ---
> 
> (Updated Nov. 5, 2015, 8:57 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kholidays
> 
> 
> Description
> ---
> 
> For now it contains just the model of holiday regions
> which will be used in the Plasma calendar events
> configuration.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e8b7970 
>   src/CMakeLists.txt c067b6c 
>   src/declarative/CMakeLists.txt PRE-CREATION 
>   src/declarative/holidayregionsmodel.h PRE-CREATION 
>   src/declarative/holidayregionsmodel.cpp PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION 
>   src/declarative/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125965/diff/
> 
> 
> Testing
> ---
> 
> Applet configuration contains proper list of available
> holiday regions.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125965: Add declarative plugin to KHolidays

[Martin Klapetek]

> On Nov. 6, 2015, 12:49 a.m., Aleix Pol Gonzalez wrote:
> > I don't know enough about the module, so I don't know about the exact case, 
> > but usually it's good to develop such API outside then when it stabilizes 
> > merge to the framework, I'd say. Otherwise changes in the API will be very 
> > hard.

Well it's a simple non-exported model, I don't see any API changes coming to 
that.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125965/#review88070
---


On Nov. 5, 2015, 8:57 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125965/
> ---
> 
> (Updated Nov. 5, 2015, 8:57 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kholidays
> 
> 
> Description
> ---
> 
> For now it contains just the model of holiday regions
> which will be used in the Plasma calendar events
> configuration.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e8b7970 
>   src/CMakeLists.txt c067b6c 
>   src/declarative/CMakeLists.txt PRE-CREATION 
>   src/declarative/holidayregionsmodel.h PRE-CREATION 
>   src/declarative/holidayregionsmodel.cpp PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION 
>   src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION 
>   src/declarative/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125965/diff/
> 
> 
> Testing
> ---
> 
> Applet configuration contains proper list of available
> holiday regions.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

[Milian Wolff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125971/#review88094
---

Ship it!


I'd remove the code, instead of just commenting it out if it's really not 
needed.

Also, minor nitpick: QList is pretty much equivalent to QVector, you 
won't see any big difference, performance or memory wise. That said, I'm all 
for using QVector everywhere by default. It's certainly not worse than QList ;-)

Thanks!

Oh and maybe wait for a review of David before pushing this. I have no clue 
about the code itself. The patch looks fine from my POV though.


src/k7zip.cpp (line 2644)


this looks odd, either remove it or not, but don't just comment out the code


- Milian Wolff


On Nov. 5, 2015, 11:55 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125971/
> ---
> 
> (Updated Nov. 5, 2015, 11:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Laurent Montel.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> i couldn't find the place where the pointers contained in the member arrays 
> are deleted so i have added their releasing. for this i have used qDeleteAll 
> (you can search for qDeleteAll in the diff)
> 
> also i have reordered members of FileInfo to reduce its 'sizeof'
> also using qvector for storing pointers is as fast as using qlist (or even 
> faster) and needs less memory
> also i have switched qvector acces from operator[] to .at() because it is 
> const (doesn't call detach() method internally)
> also i have disabled the code that was filling 'method' string because it was 
> not used anywhere after
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 321620a 
> 
> Diff: https://git.reviewboard.kde.org/r/125971/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

[Romário Rios]

> On Nov. 6, 2015, 7:52 a.m., David Faure wrote:
> > src/karchive.cpp, line 652
> > 
> >
> > This is not equivalent to seek(d->pos).
> > seek(d->pos) goes to the absolute position d->pos, counting from the 
> > beginning of the device.
> > 
> > read(d->pos) goes to the absolute position (current position + d->pos).
> > 
> > If this is seeking forward, you could emulate it with a dummy read, but 
> > what if this is seeking backward? That's not possible on a sequential 
> > device, so my advice is, forget using a sequential device here, download to 
> > a temp file.

Actually, this is irrelevant to the issue. I reverted this code back to the 
original and the fix still works.

You're right about the situation in this case, but, inside KTar::openArchive, 
it works because it originally only seeks the device forward.


- Romário


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125974/#review88078
---


On Nov. 6, 2015, 2:52 a.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125974/
> ---
> 
> (Updated Nov. 6, 2015, 2:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Up until now, since at least 5.12, decompressing some data coming directly 
> from a QIODevice by using KCompressionDevice because this is a sequential 
> device, and KTar and KArchive used to use QIODevice::seek and pos and some 
> places, which made the decompression fail. This patch makes KTar 
> sequential-friendly by replacing the calls to seek and pos with read and a 
> simple counter, respectively.
> 
> 
> Diffs
> -
> 
>   src/karchive.cpp 0ece37c 
>   src/ktar.cpp 824395e 
> 
> Diff: https://git.reviewboard.kde.org/r/125974/diff/
> 
> 
> Testing
> ---
> 
> Makes the tests from review #125941 pass
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Failure while executing KTar::open while using KCompressionDevice as the device

[Luiz Romário Santana Rios]

2015-11-06 4:48 GMT-03:00 David Faure :
> On Monday 02 November 2015 14:53:40 Luiz Romário Santana Rios wrote:
>>
>> I'm trying to decompress a XZ archive downloaded using
>> QNetworkAccessManager, so, according to the documents, I have to pass
>> the QNetworkReply pointer to a KCompressionDevice
>
> I don't think this can work at all.
> (and yes I've seen your review request, but while it fixes the file:/// case, 
> are you sure
> it fixes the network case as well?)

Since I wait for the QNAM::finished() signal before doing anything
with the QNetworkReply, it probably does, but maybe not for, say, a
QTcpSocket. That case would need the waitFor*() calls, indeed.

>
> Here's the issue:
> while QIODevice is indeed one single API, there are two ways to use it:
> push and pull.  Or in other words, async and sync.
>
> The push / async use case is the one used with sockets (including 
> QNetworkReply).
> You wait for data to be available and only then read it. Waiting can be done 
> blocking
> or with the event loop (signal/slot connection).
>
> The pull / sync use case is code that assumes there's always data available,
> as is the case with QFile, QBuffer etc. This is what KCompressionDevice, 
> KTar, KZip
> etc. all assume.
>
> So the reason it breaks (apart from the issue of seeking) is that when KTar
> (or KCompressionDevice) wants to read more data, it might not be available,
> and the read fails. You could add waitFor* calls, but that would make the 
> whole
> thing blocking - very bad for the main thread of a GUI program.

It already blocks, even in the KTar archive("file.tar.gz") case.

>
> So instead I do recommend using KIO (or QNAM) to make an async download
> (keeping the GUI reactive, allowing for a progress bar if desired...), and 
> only
> once the stuff is in a tempfile, you can create a KArchive on top.
>
> KTar is somewhat linear so your patch + waitFor* might make it work but
> KZip requires a lot more going back and forth in the file, so this will never 
> work
> without a temp file.

Then we could use a temp file in the KZip implementation and this
approach for KTar?

>
> In the special case of tar+compression in readonly mode, KTar already creates
> a temp file, for the uncompressed tar, for faster seeking. This might also be
> why you make it work in this very case, but that doesn't help for the other 
> cases
> (not tar, or not compressed)
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>



-- 
Luiz Romário Santana Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Failure while executing KTar::open while using KCompressionDevice as the device

[Luiz Romário Santana Rios]

2015-11-02 14:53 GMT-03:00 Luiz Romário Santana Rios :
> Hello,
>
> I'm trying to decompress a XZ archive downloaded using
> QNetworkAccessManager, so, according to the documents, I have to pass
> the QNetworkReply pointer to a KCompressionDevice and, then, use it as
> Ktar's device like this:
>
> https://gist.github.com/anonymous/b8fb686367f518a7dbb5
>
> The problem is that KTar::open() fails and returns false. The file I'm
> trying to extract has the following structure more or less:
> /root
> /root/dir
> /root/dir/file1
> /root/dir/file2
> ...
>
> So, as far as I've seen, the code runs normally when entering /root
> and /root/dir, but, pretty high in the stack, at
> KXzFilter::uncompress(), the call to lzma_code returns
> LZMA_FORMAT_ERROR while trying to uncompress file1 (or file2, I'm not
> sure). Here's the call stack:
>
> https://gist.github.com/anonymous/9ea380cfe48daadb5971
>
> Is this a bug? If it's a bug, how can I proceed to fix it?
>
> Thanks for the attention.
>
> --
> Luiz Romário Santana Rios

Hello, all.

This issue has been fixed: https://git.reviewboard.kde.org/r/125974/

Thanks for all the help getting this done.

-- 
Luiz Romário Santana Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125975: X11 build system cleanup

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125975/#review88092
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 6, 2015, 10:42 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125975/
> ---
> 
> (Updated Nov. 6, 2015, 10:42 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Use newer cmake syntax for XCB dependencies
> 
> 
> [declarativeimports/core] Specify HAVE_XCB_COMPOSITE in config-x11.h
> 
> 
> [plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency
> 
> Not used
> 
> [plasmaquick] Don't link OpenGL explicitly
> 
> Not needed and anyway pulled in from Qt.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/CMakeLists.txt 
> 0265d5999dcec533b04f6b38ac2f345ea57f966d 
>   src/declarativeimports/core/config-x11.h.cmake 
> 89858d17de239cfc7eed1f40a8b828803de3299c 
>   src/declarativeimports/core/windowthumbnail.h 
> 576b053229a8cfc15b6fadd8d4e6ff07f937565d 
>   src/plasma/CMakeLists.txt 73f308cf5ac8371c1d259c335edcb069117c5c11 
>   src/plasmaquick/CMakeLists.txt 1ddc61123e2a061b42d14cbd1065a70458fdd2d7 
> 
> Diff: https://git.reviewboard.kde.org/r/125975/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Failure while executing KTar::open while using KCompressionDevice as the device

[Aleix Pol]

On Fri, Nov 6, 2015 at 8:48 AM, David Faure  wrote:
> On Monday 02 November 2015 14:53:40 Luiz Romário Santana Rios wrote:
>>
>> I'm trying to decompress a XZ archive downloaded using
>> QNetworkAccessManager, so, according to the documents, I have to pass
>> the QNetworkReply pointer to a KCompressionDevice
>
> I don't think this can work at all.
> (and yes I've seen your review request, but while it fixes the file:/// case, 
> are you sure
> it fixes the network case as well?)
>
> Here's the issue:
> while QIODevice is indeed one single API, there are two ways to use it:
> push and pull.  Or in other words, async and sync.
>
> The push / async use case is the one used with sockets (including 
> QNetworkReply).
> You wait for data to be available and only then read it. Waiting can be done 
> blocking
> or with the event loop (signal/slot connection).
>
> The pull / sync use case is code that assumes there's always data available,
> as is the case with QFile, QBuffer etc. This is what KCompressionDevice, 
> KTar, KZip
> etc. all assume.
>
> So the reason it breaks (apart from the issue of seeking) is that when KTar
> (or KCompressionDevice) wants to read more data, it might not be available,
> and the read fails. You could add waitFor* calls, but that would make the 
> whole
> thing blocking - very bad for the main thread of a GUI program.
>
> So instead I do recommend using KIO (or QNAM) to make an async download
> (keeping the GUI reactive, allowing for a progress bar if desired...), and 
> only
> once the stuff is in a tempfile, you can create a KArchive on top.
>
> KTar is somewhat linear so your patch + waitFor* might make it work but
> KZip requires a lot more going back and forth in the file, so this will never 
> work
> without a temp file.
>
> In the special case of tar+compression in readonly mode, KTar already creates
> a temp file, for the uncompressed tar, for faster seeking. This might also be
> why you make it work in this very case, but that doesn't help for the other 
> cases
> (not tar, or not compressed)

What he could do though, is to add a QBuffer in case ::isSequential()
is true. This way we don't have specific restrictions on the API.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

[David Rosca]

> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote:
> > autotests/kdeplatformtheme_unittest.cpp, line 237
> > 
> >
> > What does `qApp->wheelScrollLines()` return now?
> 
> David Rosca wrote:
> It returned the value I have set in mouse kcm, because the test 
> KdePlatformTheme is not installed to qApp (and WheelScrollLines is now set as 
> themeHint instead of directly calling qApp->setWheelScrollLines)
> 
> Aleix Pol Gonzalez wrote:
> So the behavior on all applications that used qApp->wheelScrollLines() 
> changed now?
> 
> David Rosca wrote:
> No, it just can't be set with QApplication::setWheelScrollLines (from 
> KdePlatformTheme constructor) because QApplication is querying QPlatformTheme 
> for the value. 
> 
> That is with Qt 5.5, older version didn't have the WheelScrollLines hint.
> 
> Marco Martin wrote:
> if QApplication is querying QPlatformTheme for wheelScrollLines(), why do 
> you have to use themeHint directly?
> 
> David Rosca wrote:
> Because that's what this autotest is doing (see how the other themeHints 
> are tested above). It just tests if the KdePlatformTheme correctly gets the 
> value from config.
> 
> David Faure wrote:
> So why not test both, i.e. turn #else into #endif?

Because the platform theme used by QTest QApplication is created before 
prepareEnvironment() is called, thus it uses the user's kdeglobals and not the 
one used by tests.

If we fix it, eg with:

```
int main(int argc, char *argv[])
{
prepareEnvironment();
qputenv("QT_QPA_PLATFORMTHEME", QByteArrayLiteral("kde"));
QApplication app(argc, argv);
KdePlatformTheme_UnitTest t;
return QTest::qExec(&t, argc, argv);
}
```

instead of using Q_COREAPP_STARTUP_FUNCTION, then we can test the QApplication 
directly (not only wheelScrollLines, but every other hints).

I can rewrite the test according to this, if it's fine.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125877/#review87695
---


On Oct. 29, 2015, 8:22 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125877/
> ---
> 
> (Updated Oct. 29, 2015, 8:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   autotests/kdeplatformtheme_unittest.cpp f660ffd 
> 
> Diff: https://git.reviewboard.kde.org/r/125877/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kf5 frameworks autotest alters KDE4 desktop workspace settings?!

[René J . V . Bertin]

Hi,

I've been building KF5 frameworks to install under /opt/local on a KUbuntu 
14.04 host running a KDE4 desktop, using the same packaging scripts I'm 
developing for Mac OS X (MacPorts; evidently with some modifications for using 
them on Linux). I'm not patching the source code except where that's 
unavoidable.

After running certain autotests (make test in the build directory) working 
remotely, I found my KDE4 desktop with the number of virtual desktops reset to 
1. I am suspecting the kwindowsystem autotests.
Is this possible or indeed to be expected?

Supposing this is because KF5 will by default use the same user 
configuration/preferences directory as KDE4 (~/.kde), where is this path 
defined, and what is the best/official way to change it to a dedicated path? 
For KDE4 one could set KDE_DEFAULT_HOME to the desired location when building 
kdelibs4; where has this been moved with KF5?

Thanks,
René
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: icon frameworks

[Harald Sitter]

Quick update with

On Thu, Nov 5, 2015 at 10:07 AM, Harald Sitter  wrote:
> - breeze-icons is a new repo going to be split from breeze and moving
> to frameworks (tier1)

This is now in frameworks and open to push to.

> - oxygen-icons is a new repo of an old tarball (previously part of
> apps) that ought to be released alongside breeze-icons since we want
> to support both. so that also ought to move to frameworks (tier1).
> currently this is still in plasma's scope and needs a ticket filed for
> moving the repo.

Ticket ZUG-6194 requests a move *and* rename (as requested by
Riddell). Final destination being frameworks and name oxygen-icons5.
The name change is to make sure the oxygen-icons in frameworks are
distinctly set apart from the version released in applications up to
15.04, since frameworks has a lower version number and to aid
distributions in dealing with this.

> Until we are confident everything is lovely these should be marked release: 
> false.

This is done for both repos. Both repositories should comply with
frameworks documentation/metadata requirements.
David, please have a look and if it seems alright feel free to toggle
the release value.

HS
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Fwd: KF5 plugins and PLUGIN_INSTALL_DIR vs QT_PLUGIN_INSTALL_DIR

[René J . V . Bertin]

Sorry for the cross-posting, I'm really hoping for a fast resolution of this 
question...

---
Hi,

I came across an old message and commit from David Faure 
(https://mail.kde.org/pipermail/kde-buildsystem/2012-September/008851.html) 
that seems related to an issue I'm facing.

I'm finally writing MacPorts Portfiles for the KF5 frameworks. The good news is 
that "our" QSP patch appears to work as intended, including my own activator 
bit (which I'm simply linking to every KF5 framework).

More annoyingly, I'm running into an issue with KF5 plugin loading, at least in 
kwindowsystem, which AFAICS is due to the fact that plugins are expected 
(hardcoded) under QCoreApplication::libraryPaths().
Assuming the MacPorts default prefix, Qt5's plugin path is either 
/opt/local/share/qt5/plugins or /opt/local/libexec/qt5-mac/plugins (depends on 
the Qt5 port). And that's what QCoreApplication::libraryPaths() returns (plus 
the app path, of course).
However, my KF5 plugins end up in /opt/local/lib/plugins/kf5 (or 
/opt/local/lib/x86_64-linux-gnu/plugins/kf5 when I use the same packaging on 
Linux).

Evidently they're not being found.

Reading David's old message, I see the commit at the time was intended to "have 
all plugins in the same dir", which is clearly not what I'm getting.

What is going wrong here, and why? Should I be setting 
-DPLUGIN_INSTALL_DIR=${QT_PLUGIN_INSTALL_DIR}?

I'm used to Qt4 not finding KDE4's plugins on OS X/MacPorts, but KF5 not 
finding its own plugins is a whole 'nuther piece of something...

Cheers,
René
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

breeze-icons open for business

[Harald Sitter]

breeze-icons have been split from breeze into its own repo and is now
open for business.

HS
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125975: X11 build system cleanup

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125975/
---

Review request for KDE Frameworks, Plasma and Marco Martin.


Repository: plasma-framework


Description
---

Use newer cmake syntax for XCB dependencies


[declarativeimports/core] Specify HAVE_XCB_COMPOSITE in config-x11.h


[plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency

Not used

[plasmaquick] Don't link OpenGL explicitly

Not needed and anyway pulled in from Qt.


Diffs
-

  src/declarativeimports/core/CMakeLists.txt 
0265d5999dcec533b04f6b38ac2f345ea57f966d 
  src/declarativeimports/core/config-x11.h.cmake 
89858d17de239cfc7eed1f40a8b828803de3299c 
  src/declarativeimports/core/windowthumbnail.h 
576b053229a8cfc15b6fadd8d4e6ff07f937565d 
  src/plasma/CMakeLists.txt 73f308cf5ac8371c1d259c335edcb069117c5c11 
  src/plasmaquick/CMakeLists.txt 1ddc61123e2a061b42d14cbd1065a70458fdd2d7 

Diff: https://git.reviewboard.kde.org/r/125975/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

[René J . V . Bertin]

David Faure wrote:

> But this would have:
> - made the porting effort to KF5 even greater, for all the existing code

I'm tempted to say that the effort of adding a path component in front of 
headers is rather small compared to all the other stuff that blew up in the 
transition, with potentially considerable benefits:
- shorter and thus easier to read compilation commands (less -I/-isystem 
arguments)
- much less potential clashes because you can only add to the header search path

Cf py2 vs py3: this would have been the sort of thing that an automatic parser 
could have corrected.

> - made it impossible to move classes between frameworks

Less practical, you mean?

> These are the reasons why Qt decided on  and we decided on
> .

Forgive me if I don't take "Qt" as a reference for doing nothing the easy way 
that favours dev laziness over clean coding...

> Get your kdelibs4 headers out of the way and everything will be fine :)

I've been working on that, but just the headers. It seems that all it takes is 
building kdelibs4 with -DINCLUDE_INSTALL_PATH=/opt/local/include/KDE4 (after 
checking there's no current use of /opt/local/include/kde4 which would lead to 
other issues). Afterwards one can simply rebuild offending KDE4 packages as 
they 
declare themselves, to move their headers out of the way too.
It's a bit surprising this isn't documented somewhere, not even nicely visible 
in the kdelibs4 toplevel CMake file

R.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [OS X] avoiding kdelibs4 headers? ("unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools)

[David Faure]

On Thursday 05 November 2015 13:15:56 René J. V. Bertin wrote:
> René J. V. Bertin wrote:
> 
> > Before I find myself patching who knows how many KF5 files: is there a
> > provision in KDELibs4 to install its headers in a place where they shouldn't
> > clash with KF5's headers?
> 
> (apologies for asking a bit too quickly):
> 
> It seems that configuring KDELibs4 with -DINCLUDE_INSTALL_DIR=foo should have 
> the desired effect, but will that also cause all other KDE4 headerfiles to be 
> installed under that same prefix?
> In other words, am I going to have to rebuild all dependencies of KDE4 
> applications I'll continue to use? Surely something has been foreseen to 
> allow 
> developers to bootstrap gradually from KDE4 to KF5?
> (This is not on Linux, so I'm not running a KDE desktop, just a number of KDE-
> based applications installed, to be exhaustive, through MacPorts.)

The easiest solution is to ompile kdelibs4 and all your kdelibs4-based 
applications
using -DCMAKE_INSTALL_PREFIX=/opt/kdelibs4 or whereever you want it.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

[David Faure]

On Wednesday 04 November 2015 23:10:26 René J. V. Bertin wrote:
> Alex Merry wrote:
> 
> 
> > Well, if we'd done it for kdelibs4 as well, you wouldn't have this issue
> > - if you had to add -I/opt/local/include/kdelibs in order to find any
> > kdelibs headers, none would be found by mistake.
> 
> Fair enough, but you didn't :)
> 
> FWIW (and because there are some on here who would like to let KF5 be as 
> native 
> as possible on OS X): with Apple's framework bundles that also contain the 
> headers, you're more or less supposed to use statements like #include 
>  (or #import  in ObjC).
> Standardising on #include  where KFoo is expected to live in a 
> standard include directory would make it more straightforward to build KF5 
> frameworks as OS X frameworks (i.e. bundles).

But this would have:
- made the porting effort to KF5 even greater, for all the existing code
- made it impossible to move classes between frameworks
  (we've had the issue with  in Qt4 being  in 
Qt5.
   The obvious way to not hit such issues is to make it  everywhere, 
which
   is now indeed the recommended way).

These are the reasons why Qt decided on  and we decided on 
.

Get your kdelibs4 headers out of the way and everything will be fine :)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125936: Update KProtocolManager after configuration change.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125936/#review88081
---



src/kcms/kio/cache.cpp (line 91)


Isn't this done by the call to updateRunningIOSlaves just below, which 
sends the DBus signal "reparseSlaveConfiguration" to all processes with a KIO 
scheduler, which, in SchedulerPrivate::slotReparseSlaveConfiguration, calls 
KProtocolManager::reparseConfiguration?

Please check why this doesn't happen in your testcase.
I can think of a few possibilities:
- there's no KIO scheduler in this process
- you need this reparsed before going back to the event loop (but from your 
description it doesn't seem so)
- there's a bug in the emitting or the handling of that dbus signal (which 
is why I'm asking, if there is, we might as well find it and fix it).


- David Faure


On Nov. 4, 2015, 6:28 a.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125936/
> ---
> 
> (Updated Nov. 4, 2015, 6:28 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fixes missing update of Settings->Cache KCM that happens if opening
> KCM, changing values (e.g., "No Cache"), closing Cache KCM, opening Cache
> KCM again.
> 
> Reason is that storing and loading of UI values is performed
> asymmetrically in two different KSharedConfig objects. Now force second
> KSharedData to sync once settings are saved.
> 
> 
> Diffs
> -
> 
>   src/kcms/kio/cache.cpp 8f2f4e8 
> 
> Diff: https://git.reviewboard.kde.org/r/125936/diff/
> 
> 
> Testing
> ---
> 
> manual testing
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel