Re: Review Request 128106: kcatalog: Fix building with musl libc.

[Kylie McClain]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128106/
---

(Updated July 21, 2016, 7:47 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Chusslove Illich.


Repository: ki18n


Description
---

musl libc's gettext implementation doesn't have an _nl_msg_cat_cntr
function, so it fails at linking with an undefined reference.
Since musl doesn't provide a macro for checking if it's a non-libintl
implentation of gettext, or even if the libc is musl, instead we just
check if _nl_msg_cat_cntr is defined.


Diffs
-

  src/kcatalog.cpp 6682d62341dee03f5fc4906c2a88c6cda82fbedb 

Diff: https://git.reviewboard.kde.org/r/128106/diff/


Testing
---


Thanks,

Kylie McClain

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 109 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/109/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:28:41 +
Build duration: 7 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 76/113 (67%)CLASSES 76/113 (67%)LINE 4484/11311 
(40%)CONDITIONAL 2357/8431 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 933/977 
(95%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 559/1868 
(30%)CONDITIONAL 219/1142 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1678/3641 
(46%)CONDITIONAL 950/2722 (35%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 914/1729 
(53%)CONDITIONAL 418/1034 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 321/1676 
(19%)CONDITIONAL 152/1281 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1126 (1%)CONDITIONAL 
2/962 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 109 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/109/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:28:41 +
Build duration: 7 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 76/113 (67%)CLASSES 76/113 (67%)LINE 4484/11311 
(40%)CONDITIONAL 2357/8431 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 933/977 
(95%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 559/1868 
(30%)CONDITIONAL 219/1142 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1678/3641 
(46%)CONDITIONAL 950/2722 (35%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 914/1729 
(53%)CONDITIONAL 418/1034 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 321/1676 
(19%)CONDITIONAL 152/1281 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1126 (1%)CONDITIONAL 
2/962 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 86 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:29:01 +
Build duration: 1 min 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5456/7982 
(68%)CONDITIONAL 2948/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 886/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1221/2054 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 87 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/87/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:29:09 +
Build duration: 3 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5466/7983 
(68%)CONDITIONAL 2966/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 894/1768 (51%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 759/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2799 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 58 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:30:05 +
Build duration: 1 min 23 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 
test(s)Failed: TestSuite.kemoticons-kemoticontestFailed: 
TestSuite.kemoticons-ktexttohtmlplugintest

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 87 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/87/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 09:09:15 +
Build duration: 4 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5458/7982 
(68%)CONDITIONAL 2956/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 886/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1763/3042 
(58%)CONDITIONAL 760/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1225/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 59 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/59/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 09:12:08 +
Build duration: 1 min 26 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 12/14 (86%)CLASSES 12/14 (86%)LINE 440/819 
(54%)CONDITIONAL 269/707 (38%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 145/152 (95%)CONDITIONAL 
86/154 (56%)
src.core
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 215/429 (50%)CONDITIONAL 
106/301 (35%)
src.integrationplugin
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 9/9 (100%)CONDITIONAL 
7/10 (70%)
src.providers.kde
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 36/109 (33%)CONDITIONAL 
29/114 (25%)
src.providers.xmpp
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 35/120 (29%)CONDITIONAL 
41/128 (32%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 59 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/59/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 09:12:08 +
Build duration: 1 min 26 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 12/14 (86%)CLASSES 12/14 (86%)LINE 440/819 
(54%)CONDITIONAL 269/707 (38%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 145/152 (95%)CONDITIONAL 
86/154 (56%)
src.core
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 215/429 (50%)CONDITIONAL 
106/301 (35%)
src.integrationplugin
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 9/9 (100%)CONDITIONAL 
7/10 (70%)
src.providers.kde
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 36/109 (33%)CONDITIONAL 
29/114 (25%)
src.providers.xmpp
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 35/120 (29%)CONDITIONAL 
41/128 (32%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 88 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/88/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 09:12:08 +
Build duration: 6 min 31 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5463/7982 
(68%)CONDITIONAL 2965/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 894/1768 (51%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 55 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 09:12:15 +
Build duration: 5 min 25 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.kdualactiontest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 63/135 (47%)CLASSES 63/135 (47%)LINE 3301/13448 
(25%)CONDITIONAL 1243/6991 (18%)

By packages
  
autotests
FILES 23/23 (100%)CLASSES 23/23 (100%)LINE 1102/1105 
(100%)CONDITIONAL 547/1068 (51%)
src
FILES 40/112 (36%)CLASSES 40/112 (36%)LINE 2199/12343 
(18%)CONDITIONAL 696/5923 (12%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 88 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/88/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:06:41 +
Build duration: 4 min 52 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5463/7982 
(68%)CONDITIONAL 2961/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 891/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1229/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 88 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/88/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:06:41 +
Build duration: 4 min 52 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5463/7982 
(68%)CONDITIONAL 2961/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 891/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1229/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 89 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:18:18 +
Build duration: 2 min 46 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 
(68%)CONDITIONAL 2960/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 891/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 755/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2799 
(73%)CONDITIONAL 1229/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 89 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:18:18 +
Build duration: 2 min 46 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 
(68%)CONDITIONAL 2960/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 891/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 755/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2799 
(73%)CONDITIONAL 1229/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/89/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:32:24 +
Build duration: 1 min 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7982 
(68%)CONDITIONAL 2950/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 884/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1223/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 79 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:37:59 +
Build duration: 4 min 58 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.kglobalsettingstest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21679/42749 
(51%)CONDITIONAL 14659/36439 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11530/11783 
(98%)CONDITIONAL 8483/16824 (50%)
src.kdecore
FILES 74/93 (80%)CLASSES 74/93 (80%)LINE 9199/16821 
(55%)CONDITIONAL 5715/11771 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 934/9816 
(10%)CONDITIONAL 458/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 90 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:44:43 +
Build duration: 4 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5462/7982 
(68%)CONDITIONAL 2955/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 886/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 755/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1229/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 80 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/80/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:58:22 +
Build duration: 5 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21688/42749 
(51%)CONDITIONAL 14661/36439 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11534/11783 
(98%)CONDITIONAL 8483/16824 (50%)
src.kdecore
FILES 74/93 (80%)CLASSES 74/93 (80%)LINE 9199/16821 
(55%)CONDITIONAL 5715/11771 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9816 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 80 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/80/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:58:22 +
Build duration: 5 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21688/42749 
(51%)CONDITIONAL 14661/36439 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11534/11783 
(98%)CONDITIONAL 8483/16824 (50%)
src.kdecore
FILES 74/93 (80%)CLASSES 74/93 (80%)LINE 9199/16821 
(55%)CONDITIONAL 5715/11771 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9816 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128488/#review97710
---




modules/ECMQueryQmake.cmake (line 14)


If query_qmake isn't public API, it's not what the cmakelists.txt is 
calling. So it looks like an internal error message surfacing up to the user.
What should the user do when hitting this warning? (put qt5 qmake in PATH, 
right?). => I'd remove the mention of query_qmake() in the warning and explain 
more precisely what to do instead.

And what should a developer do if they want to use ECM for qt4? (not use 
this file, I suppose, but if that file is used elsewhere in ECM, it's not 
really a choice, is it?)


- David Faure


On July 20, 2016, 8:42 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128488/
> ---
> 
> (Updated July 20, 2016, 8:42 a.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and David Faure.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Addresses its usage on systems where Qt5 isn't installed, it allows for 
> modules using it to decide what they should do.
> 
> 
> Diffs
> -
> 
>   modules/ECMQueryQmake.cmake 8f4cf17 
> 
> Diff: https://git.reviewboard.kde.org/r/128488/diff/
> 
> 
> Testing
> ---
> 
> Should fix this issue: 
> https://build.kde.org/job/extra-cmake-modules%20master%20latest-qt4/16/PLATFORM=Linux,compiler=gcc/console
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 202 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/202/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 12:13:41 +
Build duration: 26 min

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/
---

(Updated July 21, 2016, 1:37 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Updated to use the manual deletion rather than QSGTexture's deletion.

I didn't push this earlier because I uploaded this at a time where we had a 
completely unrelated crash in WindowsThumbnail and someone said this makes it 
worse. Which is possible, but also unrelated.

I'm bumping it now because I went through a bug report 
(https://bugs.kde.org/show_bug.cgi?id=365946) where it seems this is the cause 
and it reminded me of it.


Repository: plasma-framework


Description
---

The QSGTextures are created with

window()->createTextureFromId(m_texture, QSize(w,h),
QuickWindow::TextureOwnsGLTexture));

this means we don't want to be deleting textures ourselves too, it will
be deleted when we delete the QSGTexture, which is a scoped pointer
inside our QSGNode.

BUG: 355644
REVIEW:


Diffs (updated)
-

  src/declarativeimports/core/windowthumbnail.cpp 
6c46789b13411fe311c4d3fb60c690abd966cc38 

Diff: https://git.reviewboard.kde.org/r/126131/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128492: [kio] Minor typo in file ioslave

[Chinmoy Ranjan Pradhan]

> On July 21, 2016, 6:44 a.m., David Faure wrote:
> > Porting bug indeed, the kdelibs4 code said KDE::lstat(dest_orig, &buff_orig)
> > Good catch!
> > 
> > (This shows a missing unittest though)

commit it on my behalf :)


- Chinmoy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128492/#review97688
---


On July 21, 2016, 3:34 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128492/
> ---
> 
> (Updated July 21, 2016, 3:34 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This fixes a typo in file ioslave source.
> Before initiating a put job the existence of the original file is checked. 
> But the path of '.part' file is passed as argument instead of path of the 
> original file. As a result a put job is initiated even though the file exist.
> 
> The Error Message:
> When user tries to create a new file with an existing name, the following 
> error message shows up. Instead of saying that the file with the given name 
> exist, the error says can't rename partial file.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/file/file.cpp 9a8ca32 
> 
> Diff: https://git.reviewboard.kde.org/r/128492/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> the error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/70053ddf-d72d-4ffe-936a-c38068de5d0d__erroemessage.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

[Chinmoy Ranjan Pradhan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128471/
---

(Updated July 21, 2016, 4:30 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
---

The "Link to Device" menu currently searches the template path for devices. I 
reimplemented it in a way such that it now shows the available devices (using 
Solid) and clicking on any sub menu(devices) mounts the device(if not mounted) 
and then creates a link (.desktop file) to mount point. Is it a good idea...?
I have not updated the diff file (since the earlier changes have not been 
finalized) instead i have added a screenshot of how the menu looks with the 
said change.


Repository: kio


Description
---

This patch fixes couple of issues with KNewFileMenu.

Fix 1: When creating a new file, if a file with the default name already exist 
then a new name is suggested by *KIO::suggestName*. Now this works fine until 
the scheme of file's url is "file" but in case the scheme is "desktop" (*like 
when the url in dolphin is set to desktop:/ or "Folder View Settings > 
Location" is set to desktop:/*) then the check for file's existence fails 
because *QFile::exists* doesn't understand the "desktop" scheme. So 
*KIO::suggestName* is not called and no new filename is suggested in case a 
file with the same filename already exist. To fix this i used 
*KNewFileMenuPrivate::mostLocalUrl* in *KNewFileFileMenu::executeRealFileorDir* 
which will resolve "desktop:/" to the user's desktop path. 

Fix 2: If a user tries to create a new file and proceeds with the default 
filename then the file created will have no extension. This happens (*inside 
KNewFileFileMenu::executeRealFileorDir*) because the filename is read from the 
*Name* section of the desktop file. To fix this, read the URL(the url is in 
*templatePath*) from the desktop file, determine the file extension from there 
and append it in the filename.

Fix 3: Fix for the bug https://bugs.kde.org/show_bug.cgi?id=363673 . The bug 
occurs because KPropertiesDialog is initialized (*inside 
KNewFileMenuPrivate::executeOtherDesktopFile*) with path of a resource file. 
Now KPropertiesDialog only show properties if the file is a local file(i 
guess). Thats why  clicking on "Link to Application" and then clicking 'ok' 
shows an error message . To Fix this i used QTemporaryFile to copy the contents 
of the application template shipped with kio and then initialize 
KPropertiesDialog with the temporary files' path.
(I added KNewFileMenuPrivate::mostLocalUrl here to ensure new filename is 
suggested when inside "desktop:/".)
(The temporary file created here must be deleted so i also added QFile::remove 
to *_k_slotOtherDesktopFile and _k_slotAbortDialog* so that whether or not the 
user creates a Link to Application, the temporary is always deleted)


Diffs
-

  src/filewidgets/knewfilemenu.cpp 2e613b1 

Diff: https://git.reviewboard.kde.org/r/128471/diff/


Testing
---


File Attachments (updated)


linktoapplication.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/d01841f8-08e3-4609-bd82-b54ea446cdf5__linktoapplication.png
no extension and no new filename
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/fbd04e13-c2d3-4acc-a4dc-b4a9053e2cb6__newfile.png
after_patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/6cbb3f10-9513-478b-a865-9fc791c006d5__linktoapplication_afterpatch.png
after_patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/2e9f5fa5-eaaa-4abc-a0ac-f492fb01faa3__newfile_aftepatch.png
add new device menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/1e115e07-3546-4abe-b913-9e841c21f672__new_addition.png


Thanks,

Chinmoy Ranjan Pradhan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128492: [kio] Minor typo in file ioslave

[Chinmoy Ranjan Pradhan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128492/
---

(Updated July 21, 2016, 8:14 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 1f30604a4cd1a96d8b733cdae53c5adbe38fda59 by Albert Astals 
Cid on behalf of Chinmoy Ranjan Pradhan to branch master.


Repository: kio


Description
---

This fixes a typo in file ioslave source.
Before initiating a put job the existence of the original file is checked. But 
the path of '.part' file is passed as argument instead of path of the original 
file. As a result a put job is initiated even though the file exist.

The Error Message:
When user tries to create a new file with an existing name, the following error 
message shows up. Instead of saying that the file with the given name exist, 
the error says can't rename partial file.


Diffs
-

  src/ioslaves/file/file.cpp 9a8ca32 

Diff: https://git.reviewboard.kde.org/r/128492/diff/


Testing
---


File Attachments


the error message
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/70053ddf-d72d-4ffe-936a-c38068de5d0d__erroemessage.png


Thanks,

Chinmoy Ranjan Pradhan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 141 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/141/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 20:14:24 +
Build duration: 16 min

CHANGE SET
Revision 1f30604a4cd1a96d8b733cdae53c5adbe38fda59 by Albert Astals Cid: (Minor 
typo in file ioslave)
  change: edit src/ioslaves/file/file.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/340 (76%)CLASSES 260/340 (76%)LINE 26850/51005 
(53%)CONDITIONAL 15014/37695 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7558/7871 
(96%)CONDITIONAL 4201/8180 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7732/14115 
(55%)CONDITIONAL 4201/9039 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2268/7562 
(30%)CONDITIONAL 912/4405 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
321/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/26 (96%)CONDITIONAL 
17/22 (77%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 29/64 (45%)CLASSES 29/64 (45%)LINE 2676/10869 
(25%)CONDITIONAL 1337/6898 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128494/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

slotCancel() isn't called when pressing Esc or closing the window with
the window manager button.

Doing this the more standard way (reimplementing accept() and reject())
simplifies the code (since KPageDialog sets up the buttonbox this way already)
and will be useful for knewfilemenutest which calls accept() on all types of 
dialog.


Diffs
-

  src/widgets/kpropertiesdialog.h b451a6ffcb248beb324ef612a0336148c96bccc2 
  src/widgets/kpropertiesdialog.cpp 808765c706ded7f109719bb2d731692fca0163d8 
  tests/kpropertiesdialogtest.cpp 7b180608716fa7de0bb2e5221330d0be958ef945 

Diff: https://git.reviewboard.kde.org/r/128494/diff/


Testing
---

Looking at the output from kpropertiesdialogtest, to ensure the signals are 
emitted, and only once.
Tested OK, Cancel, Esc, Alt+F4.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 20:58:09 +
Build duration: 7 min 34 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 
54 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 33028/49324 
(67%)CONDITIONAL 16761/32848 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4077/4390 
(93%)CONDITIONAL 1927/3920 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1755/3101 
(57%)CONDITIONAL 1208/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/935 (0%)CONDITIONAL 0/274 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1808/3214 
(56%)CONDITIONAL 1498/3191 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/244 
(83%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/326 (53%)CONDITIONAL 
40/85 (47%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 914/1225 
(75%)CONDITIONAL 606/932 (65%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 294/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1012/1389 
(73%)CONDITIONAL 565/904 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2151 
(77%)CONDITIONAL 1059/1784 (59%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1332/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3300/6281 
(53%)CONDITIONAL 1489/3788 (39%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 901/913 
(99%)CONDITIONAL 614/678 (91%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 20:58:09 +
Build duration: 7 min 34 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 
54 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 33028/49324 
(67%)CONDITIONAL 16761/32848 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4077/4390 
(93%)CONDITIONAL 1927/3920 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1755/3101 
(57%)CONDITIONAL 1208/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/935 (0%)CONDITIONAL 0/274 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1808/3214 
(56%)CONDITIONAL 1498/3191 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/244 
(83%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/326 (53%)CONDITIONAL 
40/85 (47%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 914/1225 
(75%)CONDITIONAL 606/932 (65%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 294/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1012/1389 
(73%)CONDITIONAL 565/904 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2151 
(77%)CONDITIONAL 1059/1784 (59%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1332/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3300/6281 
(53%)CONDITIONAL 1489/3788 (39%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 901/913 
(99%)CONDITIONAL 614/678 (91%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128494/#review97728
---


Ship it!




Ship It!

- Jeremy Whiting


On July 21, 2016, 3:06 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128494/
> ---
> 
> (Updated July 21, 2016, 3:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> slotCancel() isn't called when pressing Esc or closing the window with
> the window manager button.
> 
> Doing this the more standard way (reimplementing accept() and reject())
> simplifies the code (since KPageDialog sets up the buttonbox this way already)
> and will be useful for knewfilemenutest which calls accept() on all types of 
> dialog.
> 
> 
> Diffs
> -
> 
>   src/widgets/kpropertiesdialog.h b451a6ffcb248beb324ef612a0336148c96bccc2 
>   src/widgets/kpropertiesdialog.cpp 808765c706ded7f109719bb2d731692fca0163d8 
>   tests/kpropertiesdialogtest.cpp 7b180608716fa7de0bb2e5221330d0be958ef945 
> 
> Diff: https://git.reviewboard.kde.org/r/128494/diff/
> 
> 
> Testing
> ---
> 
> Looking at the output from kpropertiesdialogtest, to ensure the signals are 
> emitted, and only once.
> Tested OK, Cancel, Esc, Alt+F4.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128490/#review97729
---



If there are no objections by tomorrow, I'm going to push this before the 
Saturday string freeze :)

- Elvis Angelaccio


On July 20, 2016, 1:01 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128490/
> ---
> 
> (Updated July 20, 2016, 1:01 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Follow up of RR [128283](https://git.reviewboard.kde.org/r/128283/) and in 
> particular [128466](https://git.reviewboard.kde.org/r/128466/). This patch 
> replaces the "Share" groupbox with a vertical separator.
> 
> Don't forget that there is also RR 
> [128413](https://git.reviewboard.kde.org/r/128413/) pending ;)
> 
> 
> Diffs
> -
> 
>   src/widgets/checksumswidget.ui 03c64db 
>   src/widgets/kpropertiesdialog.cpp 808765c 
> 
> Diff: https://git.reviewboard.kde.org/r/128490/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/e39d8b29-5837-4236-833b-26ecafe18bfb__checksums-tab.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/d1ec9cee-03e5-4b26-9852-876e48aa5143__Spectacle.T11454.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

[Elvis Angelaccio]

> On July 16, 2016, 10:30 a.m., Elvis Angelaccio wrote:
> > Ping?
> > 
> > (String freeze for frameworks is next Saturday, right?)
> 
> Olivier Churlaud wrote:
> I would say: replace the [copy] button by a select on click. and then 
> ship it

Not sure about this. A button is self-explicative, while a "select on click" 
may not be intuitive for some users.


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/#review97473
---


On July 9, 2016, 7:55 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128413/
> ---
> 
> (Updated July 9, 2016, 7:55 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> As discussed in RR 128283, we can improve the usability of the dialog if we 
> add buttons to interact with the clipboard.
> 
> The Paste button is always visible, while the three Copy buttons are hidden 
> until the correspoding checksum is computed.
> 
> 
> Diffs
> -
> 
>   src/widgets/checksumswidget.ui 03c64db 
>   src/widgets/kpropertiesdialog.cpp 808765c 
> 
> Diff: https://git.reviewboard.kde.org/r/128413/diff/
> 
> 
> Testing
> ---
> 
> Copy/Paste works as expected.
> 
> 
> File Attachments
> 
> 
> Paste button next to the input field.
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/906d90f6-7727-4163-9992-c688667073ec__Spectacle.J11500.png
> Example of Copy button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/10c18534-0e72-4c8c-98ae-144a909438c9__Spectacle.J11519.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128451: KNewFileMenu: fix creating symlinks with a relative target.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128451/#review97731
---


Ship it!




Ship It!

- Jeremy Whiting


On July 21, 2016, 3:30 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128451/
> ---
> 
> (Updated July 21, 2016, 3:30 p.m.)
> 
> 
> Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and Jeremy Whiting.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KNameAndUrlInputDialog::url() makes URLs absolute (which is useful in
> general, for e.g. passing to KIO), so I added urlText() to retrieve
> the text as is.
> 
> This removes all the code about showing an error on remote URLs; we just
> create symlinks to the requested target, whether it looks like "../foo" or
> "a:/b" which could be a relative path too (although an unusual one).
> 
> Bug misreported as a comment in bug 352927.
> 
> 
> Diffs
> -
> 
>   src/filewidgets/knameandurlinputdialog.h 
> c32745d02a1a7361ac35a836cf57d7b9952cc49f 
>   src/filewidgets/knameandurlinputdialog.cpp 
> b7a6645874673e998e05ee73a2daef746ce39dd6 
>   src/filewidgets/knewfilemenu.cpp 2e613b19a98587c9a62c9cccf0f8695730798e89 
> 
> Diff: https://git.reviewboard.kde.org/r/128451/diff/
> 
> 
> Testing
> ---
> 
> Created a symlink to "../anotherdir" in konqueror/dolphinpart using "Create 
> New" / "Basic link to file or directory...", the target now stays relative.
> 
> I looked up who wrote that symlink creation code in order to add him as a 
> reviewer  turns out the author of commit 8684162 in kde-baseapps is  
> me.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128494/
---

(Updated July 21, 2016, 9:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit b36d368f8004d949597fbe9dc83d6b70418c22f8 by David Faure 
to branch master.


Repository: kio


Description
---

slotCancel() isn't called when pressing Esc or closing the window with
the window manager button.

Doing this the more standard way (reimplementing accept() and reject())
simplifies the code (since KPageDialog sets up the buttonbox this way already)
and will be useful for knewfilemenutest which calls accept() on all types of 
dialog.


Diffs
-

  src/widgets/kpropertiesdialog.h b451a6ffcb248beb324ef612a0336148c96bccc2 
  src/widgets/kpropertiesdialog.cpp 808765c706ded7f109719bb2d731692fca0163d8 
  tests/kpropertiesdialogtest.cpp 7b180608716fa7de0bb2e5221330d0be958ef945 

Diff: https://git.reviewboard.kde.org/r/128494/diff/


Testing
---

Looking at the output from kpropertiesdialogtest, to ensure the signals are 
emitted, and only once.
Tested OK, Cancel, Esc, Alt+F4.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128458: KProtocolInfo: refill cache to find newly installed protocols

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128458/
---

(Updated July 21, 2016, 9:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Cullmann.


Changes
---

Submitted with commit c2f47d93a30daee50012f62703141703d0d91c23 by David Faure 
to branch master.


Repository: kio


Description
---

KProtocolInfo: refill cache to find newly installed protocols


Diffs
-

  src/core/kprotocolinfofactory.cpp 1329b6b98bb42be27f06aaacf29d51157290bbb4 

Diff: https://git.reviewboard.kde.org/r/128458/diff/


Testing
---

$ git clone g...@github.com:shortstheory/staging-kioslave
$ compile and install
$ kioclient5 list stash:/

Now works, using a klauncher with this fix.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128451: KNewFileMenu: fix creating symlinks with a relative target.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128451/
---

(Updated July 21, 2016, 9:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and Jeremy Whiting.


Changes
---

Submitted with commit 4f7b8c13709e53f58545ae238210b345e1923108 by David Faure 
to branch master.


Repository: kio


Description
---

KNameAndUrlInputDialog::url() makes URLs absolute (which is useful in
general, for e.g. passing to KIO), so I added urlText() to retrieve
the text as is.

This removes all the code about showing an error on remote URLs; we just
create symlinks to the requested target, whether it looks like "../foo" or
"a:/b" which could be a relative path too (although an unusual one).

Bug misreported as a comment in bug 352927.


Diffs
-

  src/filewidgets/knameandurlinputdialog.h 
c32745d02a1a7361ac35a836cf57d7b9952cc49f 
  src/filewidgets/knameandurlinputdialog.cpp 
b7a6645874673e998e05ee73a2daef746ce39dd6 
  src/filewidgets/knewfilemenu.cpp 2e613b19a98587c9a62c9cccf0f8695730798e89 

Diff: https://git.reviewboard.kde.org/r/128451/diff/


Testing
---

Created a symlink to "../anotherdir" in konqueror/dolphinpart using "Create 
New" / "Basic link to file or directory...", the target now stays relative.

I looked up who wrote that symlink creation code in order to add him as a 
reviewer  turns out the author of commit 8684162 in kde-baseapps is  me.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/142/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 21:35:24 +
Build duration: 4 min 32 sec

CHANGE SET
Revision 4f7b8c13709e53f58545ae238210b345e1923108 by David Faure: 
(KNewFileMenu: fix creating symlinks with a relative target.)
  change: edit src/filewidgets/knewfilemenu.cpp
  change: edit src/filewidgets/knameandurlinputdialog.h
  change: edit src/filewidgets/knameandurlinputdialog.cpp
Revision c2f47d93a30daee50012f62703141703d0d91c23 by David Faure: 
(KProtocolInfo: refill cache to find newly installed protocols)
  change: edit src/core/kprotocolinfofactory.cpp
Revision b36d368f8004d949597fbe9dc83d6b70418c22f8 by David Faure: 
(KPropertiesDialog: simplify button box usage, fix behavior on Esc)
  change: edit src/widgets/kpropertiesdialog.cpp
  change: edit tests/kpropertiesdialogtest.cpp
  change: edit src/widgets/kpropertiesdialog.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 261/341 (77%)CLASSES 261/341 (77%)LINE 26812/50998 
(53%)CONDITIONAL 14991/37697 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7555/7871 
(96%)CONDITIONAL 4197/8180 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7708/14123 
(55%)CONDITIONAL 4194/9043 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2269/7550 
(30%)CONDITIONAL 911/4403 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
321/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 29/65 (45%)CLASSES 29/65 (45%)LINE 2678/10866 
(25%)CONDITIONAL 1336/6898 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/142/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 21:35:24 +
Build duration: 4 min 32 sec

CHANGE SET
Revision 4f7b8c13709e53f58545ae238210b345e1923108 by David Faure: 
(KNewFileMenu: fix creating symlinks with a relative target.)
  change: edit src/filewidgets/knewfilemenu.cpp
  change: edit src/filewidgets/knameandurlinputdialog.h
  change: edit src/filewidgets/knameandurlinputdialog.cpp
Revision c2f47d93a30daee50012f62703141703d0d91c23 by David Faure: 
(KProtocolInfo: refill cache to find newly installed protocols)
  change: edit src/core/kprotocolinfofactory.cpp
Revision b36d368f8004d949597fbe9dc83d6b70418c22f8 by David Faure: 
(KPropertiesDialog: simplify button box usage, fix behavior on Esc)
  change: edit src/widgets/kpropertiesdialog.cpp
  change: edit tests/kpropertiesdialogtest.cpp
  change: edit src/widgets/kpropertiesdialog.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 261/341 (77%)CLASSES 261/341 (77%)LINE 26812/50998 
(53%)CONDITIONAL 14991/37697 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7555/7871 
(96%)CONDITIONAL 4197/8180 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7708/14123 
(55%)CONDITIONAL 4194/9043 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2269/7550 
(30%)CONDITIONAL 911/4403 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
321/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 29/65 (45%)CLASSES 29/65 (45%)LINE 2678/10866 
(25%)CONDITIONAL 1336/6898 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128471/#review97725
---



Did you check if knewfilemenutest still passes?

I see that it's not testing the properties dialog case, I'm working on that.

(Maybe it would have been easier to split this into 3 different commits & 
review requests, if the bugs are completely unrelated. Then we could also 
discuss how to unittest each fix.)


src/filewidgets/knewfilemenu.cpp 


I don't follow. Doesn't removing this connect, break the case of desktop 
files not from a resource (usingTemplate == false)? Nothing happens anymore 
when clicking OK, executeStrategy() -- which is where the copying happens -- 
isn't called anymore.


- David Faure


On July 21, 2016, 4:30 p.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128471/
> ---
> 
> (Updated July 21, 2016, 4:30 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch fixes couple of issues with KNewFileMenu.
> 
> Fix 1: When creating a new file, if a file with the default name already 
> exist then a new name is suggested by *KIO::suggestName*. Now this works fine 
> until the scheme of file's url is "file" but in case the scheme is "desktop" 
> (*like when the url in dolphin is set to desktop:/ or "Folder View Settings > 
> Location" is set to desktop:/*) then the check for file's existence fails 
> because *QFile::exists* doesn't understand the "desktop" scheme. So 
> *KIO::suggestName* is not called and no new filename is suggested in case a 
> file with the same filename already exist. To fix this i used 
> *KNewFileMenuPrivate::mostLocalUrl* in 
> *KNewFileFileMenu::executeRealFileorDir* which will resolve "desktop:/" to 
> the user's desktop path. 
> 
> Fix 2: If a user tries to create a new file and proceeds with the default 
> filename then the file created will have no extension. This happens (*inside 
> KNewFileFileMenu::executeRealFileorDir*) because the filename is read from 
> the *Name* section of the desktop file. To fix this, read the URL(the url is 
> in *templatePath*) from the desktop file, determine the file extension from 
> there and append it in the filename.
> 
> Fix 3: Fix for the bug https://bugs.kde.org/show_bug.cgi?id=363673 . The bug 
> occurs because KPropertiesDialog is initialized (*inside 
> KNewFileMenuPrivate::executeOtherDesktopFile*) with path of a resource file. 
> Now KPropertiesDialog only show properties if the file is a local file(i 
> guess). Thats why  clicking on "Link to Application" and then clicking 'ok' 
> shows an error message . To Fix this i used QTemporaryFile to copy the 
> contents of the application template shipped with kio and then initialize 
> KPropertiesDialog with the temporary files' path.
> (I added KNewFileMenuPrivate::mostLocalUrl here to ensure new filename is 
> suggested when inside "desktop:/".)
> (The temporary file created here must be deleted so i also added 
> QFile::remove to *_k_slotOtherDesktopFile and _k_slotAbortDialog* so that 
> whether or not the user creates a Link to Application, the temporary is 
> always deleted)
> 
> 
> Diffs
> -
> 
>   src/filewidgets/knewfilemenu.cpp 2e613b1 
> 
> Diff: https://git.reviewboard.kde.org/r/128471/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> linktoapplication.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/d01841f8-08e3-4609-bd82-b54ea446cdf5__linktoapplication.png
> no extension and no new filename
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/fbd04e13-c2d3-4acc-a4dc-b4a9053e2cb6__newfile.png
> after_patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/6cbb3f10-9513-478b-a865-9fc791c006d5__linktoapplication_afterpatch.png
> after_patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/2e9f5fa5-eaaa-4abc-a0ac-f492fb01faa3__newfile_aftepatch.png
> add new device menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/1e115e07-3546-4abe-b913-9e841c21f672__new_addition.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128490/#review97737
---



Just a tiny note - that separator is horizontal, not vertical ;)

- Martin Klapetek


On July 20, 2016, 3:01 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128490/
> ---
> 
> (Updated July 20, 2016, 3:01 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Follow up of RR [128283](https://git.reviewboard.kde.org/r/128283/) and in 
> particular [128466](https://git.reviewboard.kde.org/r/128466/). This patch 
> replaces the "Share" groupbox with a vertical separator.
> 
> Don't forget that there is also RR 
> [128413](https://git.reviewboard.kde.org/r/128413/) pending ;)
> 
> 
> Diffs
> -
> 
>   src/widgets/checksumswidget.ui 03c64db 
>   src/widgets/kpropertiesdialog.cpp 808765c 
> 
> Diff: https://git.reviewboard.kde.org/r/128490/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/e39d8b29-5837-4236-833b-26ecafe18bfb__checksums-tab.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/d1ec9cee-03e5-4b26-9852-876e48aa5143__Spectacle.T11454.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

[Chinmoy Ranjan Pradhan]

> On July 21, 2016, 9:52 p.m., David Faure wrote:
> > Did you check if knewfilemenutest still passes?
> > 
> > I see that it's not testing the properties dialog case, I'm working on that.
> > 
> > (Maybe it would have been easier to split this into 3 different commits & 
> > review requests, if the bugs are completely unrelated. Then we could also 
> > discuss how to unittest each fix.)

knewfilemenutest passes successfully.

>Maybe it would have been easier to split this into 3 different commits & 
>review requests, if the bugs are completely unrelated.

Yes the three bugs are pretty much unrelated so have created 3 review requests 
for them.


> On July 21, 2016, 9:52 p.m., David Faure wrote:
> > src/filewidgets/knewfilemenu.cpp, line 497
> > 
> >
> > I don't follow. Doesn't removing this connect, break the case of 
> > desktop files not from a resource (usingTemplate == false)? Nothing happens 
> > anymore when clicking OK, executeStrategy() -- which is where the copying 
> > happens -- isn't called anymore.

When clicking OK the signal QDialog::accepted  is also emitted. In 
KPropertiesDialog::init this signal is connected to KPropertiesDialog::slotOk 
which, first calls the method for writing the desktop file and then emits 
signal KPropertiesDialog::propertiesClosed and KPropertiesDialog::applied.
In other words files are written first(if any) and then signals are emitted. 
This means the desktop file will be created even without any connect statement.

Though KNewFileMenu::executeStrategy handles file operations but because of the 
statement (which is at the start):
*if (src.isEmpty()) {
  return;
}*
the function returns as m_src is not set.
Also the copying of application desktop file is handled by KPropertiesDialog. 
So the call to KNewFileMenu::executeStrategy is not needed.


- Chinmoy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128471/#review97725
---


On July 21, 2016, 4:30 p.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128471/
> ---
> 
> (Updated July 21, 2016, 4:30 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch fixes couple of issues with KNewFileMenu.
> 
> Fix 1: When creating a new file, if a file with the default name already 
> exist then a new name is suggested by *KIO::suggestName*. Now this works fine 
> until the scheme of file's url is "file" but in case the scheme is "desktop" 
> (*like when the url in dolphin is set to desktop:/ or "Folder View Settings > 
> Location" is set to desktop:/*) then the check for file's existence fails 
> because *QFile::exists* doesn't understand the "desktop" scheme. So 
> *KIO::suggestName* is not called and no new filename is suggested in case a 
> file with the same filename already exist. To fix this i used 
> *KNewFileMenuPrivate::mostLocalUrl* in 
> *KNewFileFileMenu::executeRealFileorDir* which will resolve "desktop:/" to 
> the user's desktop path. 
> 
> Fix 2: If a user tries to create a new file and proceeds with the default 
> filename then the file created will have no extension. This happens (*inside 
> KNewFileFileMenu::executeRealFileorDir*) because the filename is read from 
> the *Name* section of the desktop file. To fix this, read the URL(the url is 
> in *templatePath*) from the desktop file, determine the file extension from 
> there and append it in the filename.
> 
> Fix 3: Fix for the bug https://bugs.kde.org/show_bug.cgi?id=363673 . The bug 
> occurs because KPropertiesDialog is initialized (*inside 
> KNewFileMenuPrivate::executeOtherDesktopFile*) with path of a resource file. 
> Now KPropertiesDialog only show properties if the file is a local file(i 
> guess). Thats why  clicking on "Link to Application" and then clicking 'ok' 
> shows an error message . To Fix this i used QTemporaryFile to copy the 
> contents of the application template shipped with kio and then initialize 
> KPropertiesDialog with the temporary files' path.
> (I added KNewFileMenuPrivate::mostLocalUrl here to ensure new filename is 
> suggested when inside "desktop:/".)
> (The temporary file created here must be deleted so i also added 
> QFile::remove to *_k_slotOtherDesktopFile and _k_slotAbortDialog* so that 
> whether or not the user creates a Link to Application, the temporary is 
> always deleted)
> 
> 
> Diffs
> -
> 
>   src/filewidgets/knewfilemenu.cpp 2e613b1 
> 
> Diff: https://git.reviewboard.kde.org/r/128471/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> linktoapp

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

[Chinmoy Ranjan Pradhan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128499/
---

(Updated July 22, 2016, 6:35 a.m.)


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

When creating a new file, if a file with the default name already exist then a 
new name is suggested by KIO::suggestName. Now this works fine until the scheme 
of file's url is "file" but in case the scheme is "desktop" (like when the url 
in dolphin is set to desktop:/ or "Folder View Settings > Location" is set to 
desktop:/) then the check for file's existence fails because QFile::exists 
doesn't understand the "desktop" scheme. So KIO::suggestName is not called and 
no new filename is suggested in case a file with the same filename already 
exist. To fix this i used KNewFileMenuPrivate::mostLocalUrl in 
KNewFileFileMenu::executeRealFileorDir which will resolve "desktop:/" to the 
user's desktop path.


Diffs
-

  src/filewidgets/knewfilemenu.cpp 2e613b1 

Diff: https://git.reviewboard.kde.org/r/128499/diff/


Testing
---


Thanks,

Chinmoy Ranjan Pradhan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 110 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/110/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 22 Jul 2016 06:33:52 +
Build duration: 2 min 31 sec

CHANGE SET
Revision d91127ca5866802fc3e1b5181805e2ffa4f86ae4 by kde: ([Containment] Treat 
HiddenStatus as low status)
  change: edit src/plasma/private/containment_p.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
15 test(s)Failed: TestSuite.plasma-dialogstatetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 79/117 (68%)CLASSES 79/117 (68%)LINE 4863/11782 
(41%)CONDITIONAL 2607/8793 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 956/1024 
(93%)CONDITIONAL 597/1194 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 646/2096 
(31%)CONDITIONAL 296/1292 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1680/3641 
(46%)CONDITIONAL 955/2722 (35%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 958/1802 
(53%)CONDITIONAL 438/1088 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 544/1799 
(30%)CONDITIONAL 299/1407 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1126 (1%)CONDITIONAL 
2/962 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel