Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. > > Matthieu Gallien wrote: > I almost forgot to ask an automatic test for your fix. Please do not ship > without it. > > Matthieu Gallien wrote: > You can see that current tests do not cover the line you are modifying: > https://build.kde.org/view/Frameworks%20kf5-qt5/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/cobertura/src_extractors/plaintextextractor_cpp/ > . > > Igor Poboiko wrote: > Unfortunately, I've got not that much experience in writing autotests... > > I think the proper test that would have revealed that problem would be > actually a test for ExtractorCollection::fetchExtractors (just check some > more or less obvious mimetypes and see that correct plugins are returned). > If you think this is fine, I can see how other tests are done and then > add one. Thanks for taking care of that bug. Do not feel scared, there are already tests that may get you started. I am also very happy to help if I can. In the current automatic tests, you will see that there are example files in the samplefiles directory. There is even one called plain_text_file.txt. You can have a look at any of the tests called extractortest.{h|cpp}. They may provide you inspiration. Let me know if I can help you. - Matthieu --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 --- On mars 14, 2017, 10:16 après-midi, Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated mars 14, 2017, 10:16 après-midi) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
D5066: Provide device type for Low Energy devices
drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D5066 To: elvisangelaccio, drosca Cc: #frameworks
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On Март 15, 2017, 4:13 д.п., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? I didn't see much performance issues; and from what can I see, DB size didn't change much after reindexing, so there is no redundant extractors as far as I can see. Concerning performance - I don't believe there is much overhead too much I think we should instead use profilers to find bottlenecks. I don't think it is one of them. - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- On Март 14, 2017, 9:16 п.п., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated Март 14, 2017, 9:16 п.п.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On March 15, 2017, 6:13 a.m., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? > > Igor Poboiko wrote: > I didn't see much performance issues; and from what can I see, DB size > didn't change much after reindexing, so there is no redundant extractors as > far as I can see. > Concerning performance - I don't believe there is much overhead too much > I think we should instead use profilers to find bottlenecks. I don't think it > is one of them. One more test, if i'm not too cheeky, please consider to have files like epub or svg i.e. complex mime types. For this types we have surely more than one extractor who can reflect on db size and cpu time. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- On March 14, 2017, 11:16 p.m., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated March 14, 2017, 11:16 p.m.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
D5057: Add KAcceleratorManager
This revision was automatically updated to reflect the committed changes. Closed by commit R242:ff78b9e53113: Add KAcceleratorManager (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5057?vs=12491&id=12512 REVISION DETAIL https://phabricator.kde.org/D5057 AFFECTED FILES src/declarativeimports/plasmacomponents/CMakeLists.txt src/declarativeimports/plasmacomponents/qmenu.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp To: broulik, #plasma, mart Cc: mart, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 378 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/378/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 16 Mar 2017 10:48:40 + Build duration: 3 min 34 sec CHANGE SET Revision ff78b9e53113538ba4a3e3843ea444e55fc59ac9 by kde: (Add KAcceleratorManager) change: edit src/declarativeimports/plasmacomponents/CMakeLists.txt change: edit src/declarativeimports/plasmacomponents/qmenu.cpp change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.plasma-dialogstatetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5023/11933 (42%)CONDITIONAL 2726/9014 (30%) By packages autotests FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1062/1133 (94%)CONDITIONAL 669/1358 (49%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 683/2187 (31%)CONDITIONAL 325/1354 (24%) src.plasma FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1673/3556 (47%)CONDITIONAL 969/2667 (36%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 923/1644 (56%)CONDITIONAL 430/1064 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 553/1846 (30%)CONDITIONAL 305/1433 (21%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1209 (1%)CONDITIONAL 1/988 (0%)
D5067: Specify qml-root-path as the share directory in the prefix
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5067 To: apol, #build_system, #frameworks, mart
D5067: Specify qml-root-path as the share directory in the prefix
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c5d92deff245: Specify qml-root-path as the share directory in the prefix (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5067?vs=12508&id=12519#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5067?vs=12508&id=12519 REVISION DETAIL https://phabricator.kde.org/D5067 AFFECTED FILES toolchain/Android.cmake toolchain/deployment-file.json.in To: apol, #build_system, #frameworks, mart
python bindings
Hi, I see that 5.31.0 marked the introduction of python bindings. That's nice (once you figure out how to get them to build) but does that mean there will be no standalone py-kde project like there was for KDE4? IOW, building the bindings and for what python version is something that will have to be taken care of when the individual frameworks are built? Thanks, R.
Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 210 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/210/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Mar 2017 14:03:00 + Build duration: 24 sec CHANGE SET No changes
Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 211 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/211/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Mar 2017 14:38:53 + Build duration: 2 min 26 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5907/8207 (72%)CONDITIONAL 10683/25361 (42%) By packages autotests FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2545/2651 (96%)CONDITIONAL 6489/13413 (48%) src.desktoptojson FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 84/106 (79%)CONDITIONAL 148/392 (38%) src.lib FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 302/536 (56%)CONDITIONAL 192/905 (21%) src.lib.caching FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 197/1096 (18%) src.lib.io FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 740/1397 (53%)CONDITIONAL 840/3234 (26%) src.lib.jobs FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 159/304 (52%)CONDITIONAL 57/146 (39%) src.lib.plugin FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 646/748 (86%)CONDITIONAL 1081/2424 (45%) src.lib.randomness FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 40/66 (61%) src.lib.text FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 349/764 (46%)CONDITIONAL 825/2069 (40%) src.lib.util FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 665/816 (81%)CONDITIONAL 814/1616 (50%)
Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 211 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/211/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Mar 2017 14:38:53 + Build duration: 2 min 26 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5907/8207 (72%)CONDITIONAL 10683/25361 (42%) By packages autotests FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2545/2651 (96%)CONDITIONAL 6489/13413 (48%) src.desktoptojson FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 84/106 (79%)CONDITIONAL 148/392 (38%) src.lib FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 302/536 (56%)CONDITIONAL 192/905 (21%) src.lib.caching FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 197/1096 (18%) src.lib.io FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 740/1397 (53%)CONDITIONAL 840/3234 (26%) src.lib.jobs FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 159/304 (52%)CONDITIONAL 57/146 (39%) src.lib.plugin FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 646/748 (86%)CONDITIONAL 1081/2424 (45%) src.lib.randomness FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 40/66 (61%) src.lib.text FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 349/764 (46%)CONDITIONAL 825/2069 (40%) src.lib.util FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 665/816 (81%)CONDITIONAL 814/1616 (50%)
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 470 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/470/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Mar 2017 15:39:37 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 30006/52014 (58%)CONDITIONAL 16426/39049 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 (96%)CONDITIONAL 4448/8694 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8128/14181 (57%)CONDITIONAL 4448/9267 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3464/7561 (46%)CONDITIONAL 1293/4381 (30%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 (47%)CONDITIONAL 1266/3460 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.remote FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 14/200 (7%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 (63%)CONDITIONAL 420/851 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 461/970 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3669/11064 (33%)CONDITIONAL 1754/7112 (25%)
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 470 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/470/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Mar 2017 15:39:37 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 30006/52014 (58%)CONDITIONAL 16426/39049 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 (96%)CONDITIONAL 4448/8694 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8128/14181 (57%)CONDITIONAL 4448/9267 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3464/7561 (46%)CONDITIONAL 1293/4381 (30%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 (47%)CONDITIONAL 1266/3460 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.remote FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 14/200 (7%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 (63%)CONDITIONAL 420/851 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 461/970 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3669/11064 (33%)CONDITIONAL 1754/7112 (25%)
D5069: initial implementation of a platform plugin for OS X
rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY KWindowSystem has been and is still lacking a platform plugin for OS X. A ReviewBoard RR has been up with a "backport" of the modified KDE4 KWindowSystem implementation that has been used in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years. This is a continuation of that request, still open at https://git.reviewboard.kde.org/r/126291 There's 1 outstanding issue on that RR (https://git.reviewboard.kde.org/r/126291/#comment68028). I have also reintroduced a small change to `KWindowSystem::setMainWindow()` so that it doesn't cause crashing. Ideally this function would be part of the backend but that's too big of a change to graft on the current patch. TEST PLAN Thoroughly tested up to and include with Qt 5.8.0 and KF5 Frameworks 5.32.0 The Mac backend code also contains a number of experimental functions that have been deactivated with #ifdefs . At this point I cannot assess their true potential importance; I do not seem to miss them for now but it certainly wouldn't hurt for instance to be able to map windows to applications. I'd vote to leave in the code in question until it's clearer from feedback whether or not we need it. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D5069 AFFECTED FILES src/kwindowsystem.cpp src/kwindowsystem.h src/platforms/osx/CMakeLists.txt src/platforms/osx/cocoa.json src/platforms/osx/kkeyserver.cpp src/platforms/osx/kwindowinfo.cpp src/platforms/osx/kwindowinfo.mm src/platforms/osx/kwindowinfo_mac_p.h src/platforms/osx/kwindowinfo_p_cocoa.h src/platforms/osx/kwindowsystem.cpp src/platforms/osx/kwindowsystem_mac_p.h src/platforms/osx/kwindowsystem_macobjc.mm src/platforms/osx/kwindowsystem_p_cocoa.h src/platforms/osx/plugin.cpp src/platforms/osx/plugin.h To: rjvbb, #frameworks Cc: kde-mac, #frameworks
Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/#review102882 --- https://phabricator.kde.org/D5069 - René J.V. Bertin On March 3, 2017, 6:23 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126291/ > --- > > (Updated March 3, 2017, 6:23 p.m.) > > > Review request for KDE Software on Mac OS X and KDE Frameworks. > > > Repository: kwindowsystem > > > Description > --- > > KWindowSystem has been lacking a platform plugin for OS X. This RR presents a > "backport" of the modified KDE4 KWindowSystem implementation that has been > used in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years. > > I have made some initial steps to remove deprecated Carbon API calls, but > this is clearly a work in progress. > > Open questions include > - is there any justification to run an event handler (or Cocoa observer) to > keep track of running applications, possibly even listing all their open > windows? > - is there any use for the Qt event listener framework (cf. the > NETEventFilter in the X11 plugin)? I haven't yet had time to try to figure > out what this "could be good for", and am very open to suggestions in this > departments. > - one application for such an event filter would be a listener that catches > the opening and closing of all windows by the running process, and keeps > track of their `WId`s. A new method could then be added (to `KWindowInfo`?) > to distinguish `WId`s created by the running application from "foreign" ones > (useful also on Wayland and MS Windows). > > `KWindowSystem::setMainWindow` should become a front for payload provided by > the plugins. I'll leave that to the regular/official maintainer(s) of this > framework. > > This code could probably do with *lots* of comments; I'll try to add them as > questions about this or that bit of code arise. > > > Diffs > - > > src/kwindowsystem.h 27e9e09 > src/kwindowsystem.cpp fda1682 > src/platforms/osx/CMakeLists.txt 4fc3347 > src/platforms/osx/cocoa.json PRE-CREATION > src/platforms/osx/kkeyserver.cpp 3ddb921 > src/platforms/osx/kwindowinfo.cpp e8555bb > src/platforms/osx/kwindowinfo.mm PRE-CREATION > src/platforms/osx/kwindowinfo_mac_p.h c8f307e > src/platforms/osx/kwindowinfo_p_cocoa.h PRE-CREATION > src/platforms/osx/kwindowsystem.cpp 1758829 > src/platforms/osx/kwindowsystem_mac_p.h PRE-CREATION > src/platforms/osx/kwindowsystem_macobjc.mm PRE-CREATION > src/platforms/osx/kwindowsystem_p_cocoa.h PRE-CREATION > src/platforms/osx/plugin.h PRE-CREATION > src/platforms/osx/plugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126291/diff/ > > > Testing > --- > > On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.16.0 . > > > Thanks, > > René J.V. Bertin > >
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 466 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/466/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Mar 2017 16:06:42 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 30007/52014 (58%)CONDITIONAL 16426/39049 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 (96%)CONDITIONAL 4448/8694 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8131/14181 (57%)CONDITIONAL 4451/9267 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3470/7561 (46%)CONDITIONAL 1294/4381 (30%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 (47%)CONDITIONAL 1266/3460 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.remote FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 14/200 (7%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 (63%)CONDITIONAL 420/851 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 461/970 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3661/11064 (33%)CONDITIONAL 1752/7112 (25%)
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 466 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/466/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Mar 2017 16:06:42 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 30007/52014 (58%)CONDITIONAL 16426/39049 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 (96%)CONDITIONAL 4448/8694 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8131/14181 (57%)CONDITIONAL 4451/9267 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3470/7561 (46%)CONDITIONAL 1294/4381 (30%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 (47%)CONDITIONAL 1266/3460 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.remote FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 14/200 (7%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 (63%)CONDITIONAL 420/851 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 461/970 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3661/11064 (33%)CONDITIONAL 1752/7112 (25%)
Re: Review Request 126086: [OS X] backend ported from KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated March 16, 2017, 4:31 p.m.) Status -- This change has been marked as submitted. Review request for KDE Software on Mac OS X, KDE Frameworks and Valentin Rusu. Changes --- Submitted with commit 5858ee8b3ee4ab6174e4893f35ae8e17d2ad3523 by R.J.V. Bertin to branch master. Repository: kauth Description --- This revision adds a port of the OS X backend improvements I implemented for KDE4 2 years ago, plus a few additional changes (some just to spark some debate). kauth-policy-gen still should not be built as an app bundle on OS X. This can be achieved by using `ecm_mark_nongui-executable`; there appear to be no contra-indications on other platforms. Diffs - cmake/KF5AuthMacros.cmake 15f05c7 src/CMakeLists.txt 1b6930d src/backends/dbus/DBusHelperProxy.cpp decc267 src/backends/mac/AuthServicesBackend.h 8f51eba src/backends/mac/AuthServicesBackend.cpp e832bfe src/backends/mac/kauth-policy-gen-mac.cpp b51d217 src/kauthhelpersupport.cpp 318d3a0 Diff: https://git.reviewboard.kde.org/r/126086/diff/ Testing --- On OS X 10.9 with Qt 5.6.1 and Frameworks 5.24.0 There is an issue with one of the autotests: ``` build/autotests/KAuthHelperTest -vb -v1 * Start testing of HelperTest * Config: Using QtTest library 5.6.1, Qt 5.6.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 6.0 (clang-600.0.57) (Apple)) INFO : HelperTest::initTestCase() entering QDEBUG : HelperTest::initTestCase() Test backend loaded QDEBUG : HelperTest::initTestCase() Waiting for HelperHandler to be initialized QDEBUG : HelperTest::initTestCase() Initializing helper handler QDEBUG : HelperTest::initTestCase() Adding proxy for thread QThread(0x7fab38e11e50) PASS : HelperTest::initTestCase() INFO : HelperTest::testBasicActionExecution() entering QDEBUG : HelperTest::testBasicActionExecution() Capabilities changing QDEBUG : HelperTest::testBasicActionExecution() Checking if action "org.kde.kf5auth.autotest.standardaction" exists QDEBUG : HelperTest::testBasicActionExecution() Caller ID: "a random caller Id" QDEBUG : HelperTest::testBasicActionExecution() Standard action running PASS : HelperTest::testBasicActionExecution() INFO : HelperTest::testExecuteJobSignals() entering QDEBUG : HelperTest::testExecuteJobSignals() Checking if action "org.kde.kf5auth.autotest.longaction" exists QDEBUG : HelperTest::testExecuteJobSignals() Caller ID: "a random caller Id" QDEBUG : HelperTest::testExecuteJobSignals() Long action running. Don't be scared, this action takes 2 seconds to complete PASS : HelperTest::testExecuteJobSignals() INFO : HelperTest::testActionData() entering QDEBUG : HelperTest::testActionData() Checking if action "org.kde.kf5auth.autotest.echoaction" exists QDEBUG : HelperTest::testActionData() Caller ID: "a random caller Id" QDEBUG : HelperTest::testActionData() Echo action running QWARN : HelperTest::testActionData() QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread ^CQFATAL : HelperTest::testActionData() Received signal 2 Function time: 3563ms Total time: 5657ms FAIL! : HelperTest::testActionData() Received a fatal error. Loc: [Unknown file(0)] Totals: 3 passed, 1 failed, 0 skipped, 0 blacklisted * Finished testing of HelperTest * ``` I don't know if this is a structural error or if it's just the test that should be rewritten or skipped on OS X. Also, I've noticed that applications like ksysguard5 that rely on a helper will authorise correctly in the main app, and then post an error: ``` DBus Backend error: connection to helper failed: "Not connected to D-Bus server" ``` Does this mean those applications are not written to comply with platforms where authorisation takes place in the host, or in a helper process they activate in a different way via DBus? Thanks, René J.V. Bertin
Re: Review Request 126369: [OS X] adaptation(s) to platform limitations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated March 16, 2017, 4:42 p.m.) Status -- This change has been marked as submitted. Review request for KDE Software on Mac OS X and KDE Frameworks. Changes --- Submitted with commit a6672ec04eafb7580a6a122806e826f6d5102bdd by R.J.V. Bertin to branch master. Repository: knotifications Description --- OS X has a number of limitations in features used by KNotifications, notably concerning the status notifier item (aka system tray icon). This RR will likely evolve to address multiple limitations (at least also the NeedsAttention state); at the moment it only proposes an emulation of `QMenu::addSection`. `QMenu::addSection` works by adding a QAction with a "texted separator" at the insertion location. Texted separators do not exist in menu items in the OS X "global" menubar (they become regular separators), and Qt will not provide a platform-specific implementation. Loss of the section title text is maybe not always an issue, but I think it is in the system tray menu. I therefore propose to emulate `QMenu::addSection` by replacing the texted separator with an inactive (disabled) menu item that shows the text, followed by a standard separator. Menus in the notification area are much less subject to interface guidelines, so the presence of an item icon is acceptable and IMO useful for the `titleAction`. Testing the NeedsAttention state with the tests/kstatusnotifieritemtest application leads to disappearance of the menubar icon, i.e. the access to the notifier menu becomes invisible rather than blinking (which is what I get on Linux using the same packaging). Adding a few qDebug statements shows that the `attentionIcon` is empty. I'd appreciate a crash course how this feature is supposed to work, so I can see if an OS X implementation might be feasible. Diffs - CMakeLists.txt 06a4966 src/CMakeLists.txt 7eb3125 src/knotification.cpp 57a701c src/kstatusnotifieritem.cpp 1cd5e00 tests/kstatusnotifieritemtest.cpp 973fc85 Diff: https://git.reviewboard.kde.org/r/126369/diff/ Testing --- On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.17.0 . File Attachments the systray icon & menu created by kstatusnotifieritemtest . This application has no icon to show. https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/286037ae-07b3-454a-a226-1748854493a1__kstatusnotifieritemtest-systray.png The systray icon and menu created by the KDE4 kwalletmanager (code has an equivalent patch) https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/4fc9d4e4-1537-478c-9196-94cbc17b6b7c__kwalletmanager-systray.png An Apple systray icon+menu that shows icons (which cannot be hidden) https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fc48a963-2e18-4396-bd38-062d41688118__Apple-systray-menu-with-icons.png kstatusnotifieritemtest with added appIcon https://git.reviewboard.kde.org/media/uploaded/files/2015/12/17/e896e90d-f0a8-43f7-9199-847572832df7__kstatusnotifieritemtest-with-appIcon.png kstatusnotifieritemtest-with-appIcon+attention.png https://git.reviewboard.kde.org/media/uploaded/files/2015/12/17/f41081db-8e09-4ea2-95c1-f507c62109d4__kstatusnotifieritemtest-with-appIconattention.png Thanks, René J.V. Bertin
D5070: Allow to play the default system sound (beep) instead of a specific sound file (WIP)
rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY This is a "port" of https://git.reviewboard.kde.org/r/128043/ which is itself a follow-up to discussion on the plasma-devel ML. The main goal behind the patch is to ensure audio notifications will sound when they are not configured properly, for instance because the necessary files are missing when not running under a Plasma session. The current state of the RR can be summarised as "awaiting brilliant ideas". When not running under a Plasma session it would be preferable if generic alert sounds are (can be) delivered using the default system sound. The easiest way to do that is to call QApplication::beep() ; at least on OS X this will play the user's selected alert sound. I have implemented this for now by assuming the existence of a virtual (relative) beep sound file that always plays the default sound. In addition, this patch provides better warning feedback if a soundfile isn't found (making it easier to figure out which alert is misconfigured), and will play the sysbeep in that case (so that the alert doesn't go lost if it's sound-only). Finally, no Phonon::AudioOutput object is created until that is actually required. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5070 AFFECTED FILES src/notifybyaudio.cpp To: rjvbb, #frameworks Cc: kde-mac, #frameworks
Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128043/#review102883 --- https://phabricator.kde.org/D5070 - René J.V. Bertin On June 9, 2016, 7:52 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128043/ > --- > > (Updated June 9, 2016, 7:52 p.m.) > > > Review request for KDE Software on Mac OS X and KDE Frameworks. > > > Repository: knotifications > > > Description > --- > > This is a follow-up to discussion on the plasma-devel ML. When not running > under a Plasma session it would be preferable if generic alert sounds are > (can be) delivered using the default system sound. The easiest way to do that > is to call `QApplication::beep()` ; at least on OS X this will play the > user's selected alert sound. > > I have implemented this for now by assuming the existence of a virtual > (relative) `beep` sound file that always plays the default sound. > > In addition, this patch provides better warning feedback if a soundfile isn't > found (making it easier to figure out which alert is misconfigured), and will > play the sysbeep in that case (so that the alert doesn't go lost if it's > sound-only). > Finally, no Phonon::AudioOutput object is created until that is actually > required. > > > Diffs > - > > src/notifybyaudio.cpp 903e996 > > Diff: https://git.reviewboard.kde.org/r/128043/diff/ > > > Testing > --- > > Works as expected on OS X 10.9.5 > > > Thanks, > > René J.V. Bertin > >
Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.
> On March 13, 2017, 12:10 p.m., Elvis Angelaccio wrote: > > I'm not sure if we should show the warning dialog at the kio_file level. > > This would result in a double dialog when deleting files with Shift+Del > > from file managers. What about making jobuidelegate.cpp smarter? It could > > show a more "scary" message if the file that's being deleted is > > write-protected. > > Chinmoy Ranjan Pradhan wrote: > In my system when i use Shift+del there is no warning dialog (few months > back dolphin used to show the dialog but strangly it doesn't shows now) so > this case didn't occured to me. > > If I am not wrong jobuidelegate's warning is shown before the job > executes and kauth's authentication dialog is shown only after job executes. > But its just the opposite we want. So if there's a way for slave to notify > the job of starting of a priviledged action then there should be no problem > in making jobuidelegate smarter. > (But the thing is at this very moment i can't think of or find any > possible way) > > Elvis Angelaccio wrote: > You probably checked the "don't show again" checkbox ;) The > jobuidelegate's dialog is shown by default, so we must assume the user will > see it => we need a way to prevent showing the dialog twice. You are right > that jobuidelegate is run before kio_file is involved. I was thinking of > checking the permissions from jobuidelegate: can you check if QFileInfo would > do the trick? (e.g. QFileInfo::isWritable()?) > > Chinmoy Ranjan Pradhan wrote: > >You probably checked the "don't show again" checkbox ;) > > Completely forgot about that :P > > >we need a way to prevent showing the dialog twice > > I hope you mean the warning dialog because if the user is not authorised > then there will be two dialogs. > > >I was thinking of checking the permissions from jobuidelegate: can you > check if QFileInfo would do the trick? > > Checking permissions beforehand and then showing the dangerous warning is > definitely a good idea. Now QFileInfo::isWritable will work only when > deleteJob is started inside a write-protected location. Suppose if its a > regular folder inside some regular location but containing a write-protected > subfolder then the check's result will be useless. > One thing we can do is stat the contents and as soon we find a > write-protected location we can abort the stat'ing and show our special > warning. Sounds good. Please make sure to include this point in your proposal ;) - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review102826 --- On March 14, 2017, 2:48 p.m., Chinmoy Ranjan Pradhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129983/ > --- > > (Updated March 14, 2017, 2:48 p.m.) > > > Review request for KDE Frameworks, David Faure and Elvis Angelaccio. > > > Repository: kio > > > Description > --- > > This is regarding the GSOC idea > https://community.kde.org/GSoC/2017/Ideas#Project:_Polkit_support_in_KIO. > > This patch intends to demonstrate one possible approach to provide polkit > support in kio. Here its only for the delete operation. This is based on the > patch in task https://phabricator.kde.org/T5070. > > The approach is as follows; > 1. Whenever file ioslave gets access denied error it calls the method > *execWithRoot* with the action that requires priviledge, the path of items >upon which action needs to be performed and a warning ID as arguments. > 2. *execWithRoot* then executes the KAuth::Action *org.kde.kio.file.execute*. > 3. This Kauth::Action has its Persistence set too 'session'. This means that > after authentication the restrictions are dropped for a while, for >about 5 minutes. This is similar to the behaviour of sudo command. > 4. During this time we can perform any action as a privileged user without > any authentication. So to prevent any mishap i added a warning box which >would popup before performing any action(only during this period). > 5. After the said time interval the root privileges are droped and calling > *execWithRoot* should show the usual authentication dialog. > > > Diffs > - > > src/ioslaves/file/CMakeLists.txt b9132ce > src/ioslaves/file/file.h 109ea80 > src/ioslaves/file/file.cpp eaf6c88 > src/ioslaves/file/file_unix.cpp 82eb11a > src/ioslaves/file/kauth/CMakeLists.txt PRE-CREATION > src/ioslaves/file/kauth/file.actions PRE-CREATION > src/ioslaves/file/kauth/helper.h PRE-CREATION > src/ioslaves/file/kauth/helper.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129983/d
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- (Updated Март 16, 2017, 8:33 п.п.) Review request for KDE Frameworks and Anthony Fieroni. Changes --- Added new test for ExtractorCollection. As for now, it simply checks if collection finds an extractor for known (text/plain) mimetype, and doesn't find anything for a-priory incorrect mimetype. Also removed unused include (otherwise test should have been linked with KI18N, which is actually not needed). Repository: kfilemetadata Description --- After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer matches ANY of the text/ mimetypes. This broke completely Baloo indexing e.g. simple plain text files. Introduced check however allows to provide "text/plain" as supported mimetype for the extractor and hope that everything containing plain text will be inherited from it. Diffs (updated) - autotests/CMakeLists.txt 5ab742b autotests/extractorcollectiontest.cpp PRE-CREATION src/externalextractor.cpp 05f0645 src/extractors/plaintextextractor.cpp 26e1247 Diff: https://git.reviewboard.kde.org/r/130013/diff/ Testing --- KFileMetaData compiles. Baloo indexes plain text files. Everybody is happy. Thanks, Igor Poboiko
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On Март 15, 2017, 4:13 д.п., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? > > Igor Poboiko wrote: > I didn't see much performance issues; and from what can I see, DB size > didn't change much after reindexing, so there is no redundant extractors as > far as I can see. > Concerning performance - I don't believe there is much overhead too much > I think we should instead use profilers to find bottlenecks. I don't think it > is one of them. > > Anthony Fieroni wrote: > One more test, if i'm not too cheeky, please consider to have files like > epub or svg i.e. complex mime types. For this types we have surely more than > one extractor who can reflect on db size and cpu time. Funny thing: I didn't manage to find any type with more than one extractor. SVG is matched only by PlainTextExtractor (apparently, the only extractor working with images is Exiv2Extractor, which doesn't support svg), and EPUB is matched only by EPubExtractor (apparently, internally it is zip-archive and there is no extractors working with archives). Anyways, if two extractors got the same DocTerm some file, Baloo won't save it twice, it saves only unique terms. And if they extract different terms - well, it gives more chances to match users search, which is even better! I also tried indexing whole /usr/share/icons directory, with lots of svg icons - well, I didn't see a change (again, subjectively: I didn't use profilers). Apparently, extraction takes considerably much more time that iterating over bunch of mimetypes per file (~100?). - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- On Март 16, 2017, 8:33 п.п., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130013/ > --- > > (Updated Март 16, 2017, 8:33 п.п.) > > > Review request for KDE Frameworks and Anthony Fieroni. > > > Repository: kfilemetadata > > > Description > --- > > After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see > https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer > matches ANY of the text/ mimetypes. > This broke completely Baloo indexing e.g. simple plain text files. > Introduced check however allows to provide "text/plain" as supported mimetype > for the extractor and hope that everything containing plain text will be > inherited from it. > > > Diffs > - > > autotests/CMakeLists.txt 5ab742b > autotests/extractorcollectiontest.cpp PRE-CREATION > src/externalextractor.cpp 05f0645 > src/extractors/plaintextextractor.cpp 26e1247 > > Diff: https://git.reviewboard.kde.org/r/130013/diff/ > > > Testing > --- > > KFileMetaData compiles. > Baloo indexes plain text files. > Everybody is happy. > > > Thanks, > > Igor Poboiko > >
D5066: Provide device type for Low Energy devices
This revision was automatically updated to reflect the committed changes. Closed by commit R269:fcab8c31897e: Provide device type for Low Energy devices (authored by elvisangelaccio). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5066?vs=12507&id=12543 REVISION DETAIL https://phabricator.kde.org/D5066 AFFECTED FILES src/device.cpp src/device.h src/utils.cpp src/utils.h To: elvisangelaccio, drosca Cc: #frameworks
D5003: Update docs to Frameworks API
This revision was automatically updated to reflect the committed changes. Closed by commit R283:91b73de5bfbc: Update docs to Frameworks API (authored by jriddell). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5003?vs=12366&id=12544#toc REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5003?vs=12366&id=12544 REVISION DETAIL https://phabricator.kde.org/D5003 AFFECTED FILES src/kauthaction.h src/kauthactionreply.h src/kauthexecutejob.h src/kauthhelpersupport.h To: jriddell, leinir Cc: #frameworks