Re: Compilation failure on Windows: kpeople

2017-05-27 Thread Ben Cooksley 
On Wed, May 17, 2017 at 7:33 AM, Ralf Habacker  wrote:
> Hi
>> When someone gets the chance, could they please look into the build
>> log at 
>> https://build-sandbox.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsQt5.7/4/console
>> to see why this Framework isn't building on Windows?
>
> from my recent experience with building kmymoney on Windows this may be
> caused by compiling code using a class located in a different shared
> library and therefore declared as dllimport, but  later included in the
> same dll as static library.
>
> I dealed with this by undefining the related export macro as target
> definition [1]. Something like this
>
> +if( WIN32 )
> +  target_compile_definitions(reports PUBLIC KMM_MYMONEY_EXPORT=)
> +endif()

Sorry, i've only just now had time to take a look into this.

As it turns out Pino fixed the build of kpeople in
https://cgit.kde.org/kpeople.git/commit/?id=dde883a272208ad4e3d01c223cd4ea59a0ae856d

>
>
> [1]
> https://build.opensuse.org/package/view_file/home:rhabacker:branches:windows:mingw:win32:kmymoney/mingw32-kmymoney/fix-windows-compile-issue.patch?expand=1
>
> My 2 cent
>
> Ralf
>
>

Thanks,
Ben

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

2017-05-27 Thread Stefan Brüns 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review103250
---



Thanks for pushing this upstream!

- Stefan Brüns


On May 27, 2017, 2:32 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> ---
> 
> (Updated May 27, 2017, 2:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> These are not my own patches, I'm creating this review request after having 
> been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
> simply rebased on top of current master (author of course preserved) to be 
> able to test it. I think it would be a great improvement over the current 
> situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 
> 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp 
> f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> ---
> 
> Migration itself was not tested so far, but a legacy application like ksirk 
> was able to create a new wallet just fine and can access it as well. I do not 
> have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

D5134: Don't exit if $DISPLAY is not set

2017-05-27 Thread Albert Astals Cid 
aacid abandoned this revision.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D5134

To: aacid, graesslin
Cc: graesslin, rikmills, lukas, #frameworks

D5983: Check error status after every PolKitAuthority usage

2017-05-27 Thread Sergey Kalinichev 
skalinichev added inline comments.

INLINE COMMENTS

> aacid wrote in Polkit1Backend.cpp:220
> This seems a bit weird since we have done nothing with authority here, so how 
> would it have an error?

Well yes it shouldn't happen now with the two other checks above. This check 
here just in case (that's why I use qWarning here instead of qCDebug as in two 
other cases).

Also since PolkitAuthoruty is a singleton theoretically some other code using 
PolkitQt1::Authority methods could trigger such errors.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5983

To: skalinichev
Cc: aacid, #frameworks

D5805: include directory should contains all directory from pkg-config

2017-05-27 Thread Aleix Pol Gonzalez 
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Is there a way where we can include a test to make sure this works properly?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5805

To: xuetianweng, apol, aacid
Cc: #frameworks, #build_system

D4906: Fix kactivities-stats into tier3

2017-05-27 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R159:b5e20a709fbe: Fix kactivities-stats into tier3 (authored 
by apol).

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4906?vs=12101=14883

REVISION DETAIL
  https://phabricator.kde.org/D4906

AFFECTED FILES
  metainfo.yaml

To: apol, #frameworks, ivan
Cc: adridg

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

2017-05-27 Thread Andreas Sturmlechner 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/
---

(Updated May 27, 2017, 4:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Stefan Brüns.


Changes
---

Submitted with commit c2fe10e2e75304114de89aa83381cfa20e6e9734 by Andreas 
Sturmlechner on behalf of Stefan Brüns to branch master.


Repository: kwallet


Description
---

These are not my own patches, I'm creating this review request after having 
been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
simply rebased on top of current master (author of course preserved) to be able 
to test it. I think it would be a great improvement over the current situation 
that is rather confusing to the users.

The changes are organised in 5 commits:

- Check for unique applicaton instance as early as possible
Exit before KWalletD and the MigrationAgent has been initialized.
The return value is changed, but concurrent instatiation of kwalletd is
not a fault.

- Only start timer for migration agent if necessary
- Whitespace fixup
- Signal completion of migration agent
- Replace kwalletd4 after migration has finished
kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd


Diffs
-

  src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
  src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
  src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
  src/runtime/kwalletd/migrationagent.h 
0f6467c1753ef34b7f7f7e282503ec5607927db9 
  src/runtime/kwalletd/migrationagent.cpp 
f3da94743ecd83fe406e058f560d4238caec1be8 

Diff: https://git.reviewboard.kde.org/r/130058/diff/


Testing
---

Migration itself was not tested so far, but a legacy application like ksirk was 
able to create a new wallet just fine and can access it as well. I do not have 
kwalletd4 installed anymore.


Thanks,

Andreas Sturmlechner

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

2017-05-27 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review103249
---


Ship it!




OK.

- David Faure


On March 29, 2017, 12:52 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> ---
> 
> (Updated March 29, 2017, 12:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> These are not my own patches, I'm creating this review request after having 
> been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
> simply rebased on top of current master (author of course preserved) to be 
> able to test it. I think it would be a great improvement over the current 
> situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 
> 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp 
> f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> ---
> 
> Migration itself was not tested so far, but a legacy application like ksirk 
> was able to create a new wallet just fine and can access it as well. I do not 
> have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

D5979: Consistently emit MouseEventListener::pressed signal

2017-05-27 Thread Kai Uwe Broulik 
broulik added a comment.


  In `onPressed` I would expect `pressed` to be also true which this patch 
ensures.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D5979

To: apol, #frameworks
Cc: broulik, davidedmundson

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!

2017-05-27 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/6/
 Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 12:48:56 +
 Build duration:
2 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-kwindowsystemplatformwaylandtestFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(3/4)88%
(42/48)88%
(42/48)75%
(6796/9070)54%
(3810/7089)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)98%
(2932/3004)52%
(1616/3115)src88%
(14/16)88%
(14/16)54%
(776/1435)44%
(314/712)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/89)0%
(0/2)src.platforms.xcb88%
(14/16)88%
(14/16)68%
(3088/4542)58%
(1880/3260)

build.log
Description: Binary data

D5975: breeze-icons: don't look for bash on Windows

2017-05-27 Thread Allen Winter 
winterz edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D5975

To: winterz
Cc: aacid, #frameworks

Re: KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 10 - Still Unstable!

2017-05-27 Thread Ben Cooksley 
On Sat, May 27, 2017 at 9:21 PM, Christoph Feck  wrote:
> On 27.05.2017 08:36, no-re...@kde.org wrote:
>>
>> # *Failed: TestSuite.kiconloader_unittest
>
>
> If I interpret the unit test correctly, it fails because of missing
> 'shared-mime-info' package in the CI.
>

As it turns out the package was installed, but it did reveal another
issue which i've now fixed.
I've initiated a rebuild of everything which was unstable.

Cheers,
Ben

KDE CI: Frameworks kdeclarative kf5-qt5 XenialQt5.7 - Build # 7 - Still Unstable!

2017-05-27 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20XenialQt5.7/7/
 Project:
Frameworks kdeclarative kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 12:23:38 +
 Build duration:
9 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.quickviewsharedengine
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)76%
(19/25)76%
(19/25)47%
(596/1269)26%
(223/864)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)68%
(328/484)25%
(123/484)src.kdeclarative75%
(3/4)75%
(3/4)45%
(140/312)34%
(57/166)src.kdeclarative.private100%
(5/5)100%
(5/5)24%
(14/58)6%
(2/32)src.qmlcontrols.kquickcontrolsaddons100%
(2/2)100%
(2/2)55%
(79/144)46%
(36/78)src.quickaddons29%
(2/7)29%
(2/7)13%
(35/271)5%
(5/104)

build.log
Description: Binary data

KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!

2017-05-27 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/6/
 Project:
Frameworks ktexteditor kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 12:24:17 +
 Build duration:
7 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.katesyntaxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report81%
(22/27)88%
(290/330)88%
(290/330)68%
(33451/49515)51%
(16877/32993)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(47/47)100%
(47/47)93%
(4252/4561)49%
(1997/4066)autotests.src.vimode100%
(16/16)100%
(16/16)99%
(5525/5569)54%
(897/1658)src.buffer88%
(15/17)88%
(15/17)91%
(1696/1869)76%
(1294/1694)src.completion100%
(16/16)100%
(16/16)56%
(1748/3102)43%
(1192/2798)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(184/464)22%
(79/354)src.dialogs0%
(0/4)0%
(0/4)0%
(0/875)0%
(0/258)src.document100%
(4/4)100%
(4/4)58%
(1859/3225)47%
(1517/3238)src.export0%
(0/4)0%
(0/4)0%
(0/125)0%
(0/152)src.include.ktexteditor93%
(13/14)93%
(13/14)82%
(202/245)63%
(145/230)src.inputmode100%
(8/8)100%
(8/8)53%
(172/325)45%
(40/89)src.mode83%
(5/6)83%
(5/6)39%
(165/427)37%
(99/265)src.printing0%
(0/4)0%
(0/4)0%
(0/885)0%
(0/294)src.render100%
(9/9)100%
(9/9)75%
(912/1217)67%
(624/932)src.schema22%
(2/9)22%
(2/9)1%
(21/1538)1%
(7/697)src.script100%
(14/14)100%
(14/14)66%
(700/1055)53%
(295/556)src.search100%
(7/7)100%
(7/7)74%
(1043/1418)63%
(588/929)src.spellcheck71%
(5/7)71%
(5/7)28%
(375/1336)25%
(207/820)src.swapfile50%
(1/2)50%
(1/2)33%

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 11 - Still Unstable!

2017-05-27 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/11/
 Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 12:23:34 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(10/10)85%
(79/93)85%
(79/93)72%
(5917/8223)42%
(10618/25187)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(33/40)83%
(33/40)96%
(2551/2667)48%
(6508/13475)src.desktoptojson100%
(3/3)100%
(3/3)79%
(84/106)38%
(146/384)src.lib67%
(2/3)67%
(2/3)56%
(302/536)22%
(192/893)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/787)18%
(195/1086)src.lib.io90%
(9/10)90%
(9/10)53%
(744/1397)26%
(837/3214)src.lib.jobs71%
(5/7)71%
(5/7)52%
(159/304)39%
(57/146)src.lib.plugin100%
(8/8)100%
(8/8)86%
(646/748)44%
(1035/2326)src.lib.randomness100%
(2/2)100%
(2/2)66%
(65/98)61%
(40/66)src.lib.text63%
(5/8)63%
(5/8)46%
(349/764)40%
(794/1981)src.lib.util100%
(10/10)100%
(10/10)81%
(665/816)50%
(814/1616)

build.log
Description: Binary data

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 7 - Still Unstable!

2017-05-27 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/7/
 Project:
Frameworks baloo kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 12:23:15 +
 Build duration:
3 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(12/12)77%
(111/144)77%
(111/144)73%
(5039/6932)50%
(2613/5194)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(42/42)89%
(16/18)autotests.integration100%
(3/3)100%
(3/3)95%
(242/255)64%
(140/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(40/40)57%
(25/44)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(736/736)53%
(390/740)autotests.unit.file100%
(11/11)100%
(11/11)97%
(788/809)51%
(438/864)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(315/326)52%
(156/302)src.codecs100%
(5/5)100%
(5/5)87%
(120/138)76%
(32/42)src.engine97%
(38/39)97%
(38/39)79%
(1607/2038)58%
(796/1379)src.file39%
(17/44)39%
(17/44)45%
(678/1506)38%
(374/980)src.file.extractor100%
(2/2)100%
(2/2)69%
(20/29)58%
(7/12)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(22/22)61%
(11/18)src.lib55%
(6/11)55%
(6/11)43%
(429/991)40%
(228/575)

build.log
Description: Binary data

KDE CI: Frameworks kservice kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!

2017-05-27 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/6/
 Project:
Frameworks kservice kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 12:24:13 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kmimeassociationstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)89%
(76/85)89%
(76/85)68%
(5497/8028)48%
(2997/6264)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)94%
(1477/1571)50%
(908/1820)src.kbuildsycoca100%
(1/1)100%
(1/1)91%
(61/67)65%
(13/20)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/326)0%
(0/262)src.plugin67%
(2/3)67%
(2/3)47%
(47/100)38%
(36/96)src.services97%
(30/31)97%
(30/31)58%
(1769/3046)40%
(770/1904)src.sycoca84%
(26/31)84%
(26/31)73%
(2035/2798)59%
(1236/2112)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)68%
(34/50)

build.log
Description: Binary data

KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!

2017-05-27 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/6/
 Project:
Frameworks bluez-qt kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 12:23:11 +
 Build duration:
2 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.bluezqt-adaptertestFailed: TestSuite.bluezqt-agentmanagertestFailed: TestSuite.bluezqt-devicetestFailed: TestSuite.bluezqt-inputtestFailed: TestSuite.bluezqt-managertestFailed: TestSuite.bluezqt-mediaplayertestFailed: TestSuite.bluezqt-obexmanagertestFailed: TestSuite.bluezqt-qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)45%
(39/86)45%
(39/86)24%
(974/4140)7%
(293/4224)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)47%
(647/1377)8%
(219/2896)src35%
(19/54)35%
(19/54)14%
(315/2331)6%
(71/1270)src.imports14%
(2/14)14%
(2/14)3%
(12/432)5%
(3/58)

build.log
Description: Binary data

KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 11 - Fixed!

2017-05-27 Thread no-reply 
BUILD SUCCESS
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/11/
 Project:
Frameworks kiconthemes kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 12:21:00 +
 Build duration:
1 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)94%
(15/16)94%
(15/16)56%
(1440/2592)42%
(893/2103)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)100%
(500/502)50%
(288/578)src89%
(8/9)89%
(8/9)45%
(940/2090)40%
(605/1525)

build.log
Description: Binary data

D5979: Consistently emit MouseEventListener::pressed signal

2017-05-27 Thread David Edmundson 
davidedmundson added a comment.


  What things are not consistent?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D5979

To: apol, #frameworks
Cc: davidedmundson

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

2017-05-27 Thread Andreas Sturmlechner 


> On April 1, 2017, 7:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
> 
> Andreas Sturmlechner wrote:
> Thanks, anyone else who wants to +1?
> 
> I've tried to test migration today but it didn't work. May as well have 
> nothing to do with te patch and be caused by the permanently troubled 
> migration agent though... KMail happily gets its IMAP password from kwallet5 
> though after manually export/import via XML files.
> 
> Andreas Sturmlechner wrote:
> As suspected, on my test system migration is broken regardless of with 
> these patches or not.
> 
> David Faure wrote:
> Are you planning on looking into that? ;-)
> 
> These patches are related to migration, it feels a bit wrong to commit 
> changes around migration and still leave it broken.
> 
> Andreas Sturmlechner wrote:
> I don't feel like I'm up to that task. Also, the reason for why it works 
> for some, but not all the systems, has afaik never been established.

Could we push it to give it some testing by others until the upcoming release?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review102982
---


On March 29, 2017, 12:52 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> ---
> 
> (Updated March 29, 2017, 12:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> These are not my own patches, I'm creating this review request after having 
> been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I 
> simply rebased on top of current master (author of course preserved) to be 
> able to test it. I think it would be a great improvement over the current 
> situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 
> 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp 
> f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> ---
> 
> Migration itself was not tested so far, but a legacy application like ksirk 
> was able to create a new wallet just fine and can access it as well. I do not 
> have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

D5975: breeze-icons: don't look for bash on Windows

2017-05-27 Thread Albert Astals Cid 
aacid added a comment.


  In https://phabricator.kde.org/D5975#112013, @winterz wrote:
  
  > Because Hannah told me the script doesn't work on Windows.
  
  
  Then you need a better commit message :)
  
  Saying "we have bash, let's comment this bash using script" is not what 
you're doing. What you're doing is "we don't have the tool required by this 
bash script even if we do actually have bash"

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D5975

To: winterz
Cc: aacid, #frameworks

D5983: Check error status after every PolKitAuthority usage

2017-05-27 Thread Albert Astals Cid 
aacid added inline comments.

INLINE COMMENTS

> Polkit1Backend.cpp:220
> +auto authority = PolkitQt1::Authority::instance();
> +if (authority->hasError()) {
> +qWarning() << "Encountered error while enumerating actions, error 
> code:" << authority->lastError() << authority->errorDetails();

This seems a bit weird since we have done nothing with authority here, so how 
would it have an error?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5983

To: skalinichev
Cc: aacid, #frameworks

Re: KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 10 - Still Unstable!

2017-05-27 Thread Christoph Feck 

On 27.05.2017 08:36, no-re...@kde.org wrote:

# *Failed: TestSuite.kiconloader_unittest


If I interpret the unit test correctly, it fails because of missing 
'shared-mime-info' package in the CI.

D5981: Fix compilation of Python bindings

2017-05-27 Thread Albert Astals Cid 
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:adca5fa181a0: Fix compilation of Python bindings 
(authored by aacid).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5981?vs=14868=14877

REVISION DETAIL
  https://phabricator.kde.org/D5981

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: aacid, lbeltrame
Cc: lbeltrame, #frameworks

future of baloo, cross-platform desktop search (and finding dependents of a shared library)

2017-05-27 Thread René J . V . Bertin 
Hi,

I seem to recall having read that baloo's future is incertain, inhowfar is that 
correct and to what extent are there concrete plans to develop something else?

I think there'd be justification for developing a good cross-platfom desktop 
search engine that applications can use regardless of the platform on which 
they're running. I'm aware that the "other big 2" platforms have their own 
desktop search engines, but at least the one Apple provides is not without its 
flaws. They could of course be used as a backend (I think even the current 
Baloo framework could be extended to relay queries to them so it actually does 
something on Mac and MSWin) but that still means that document importer plugins 
need to be written for each platform.

Anyway, that's not the only reason I'm bringing this up; I ran into a question 
the other day "how do I find any/all binary files that link to (= depend on) 
this or that shared library?". 

That's a query to which an answer can be obtained by maintaining a database of 
the dependency lists of all binaries in the searchable areas, gotten through 
ldd (otool on Mac). And that's data that one should be able to integrate into a 
desktop search database.

Does this ring any bells, I'm guessing this should be useful enough to 
distribution maintainers and OS developers that someone must have implemented a 
utility?

Thanks,
René

D5981: Fix compilation of Python bindings

2017-05-27 Thread Luca Beltrame 
lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5981

To: aacid, lbeltrame
Cc: lbeltrame, #frameworks

D5983: Check error status after every PolKitAuthority usage

2017-05-27 Thread Sergey Kalinichev 
skalinichev created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Otherwise if some error occurred in e.g. checkAuthorizationSync call, 
enumerateActions call would also fail (as PolKitAuthority already set error 
flag internally)

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5983

AFFECTED FILES
  src/backends/polkit-1/Polkit1Backend.cpp

To: skalinichev
Cc: #frameworks

D5981: Fix compilation of Python bindings

2017-05-27 Thread Luca Beltrame 
lbeltrame added a comment.


  I'll try to test and report back.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5981

To: aacid
Cc: lbeltrame, #frameworks

D5981: Fix compilation of Python bindings

2017-05-27 Thread Luca Beltrame 
lbeltrame added a reviewer: lbeltrame.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5981

To: aacid, lbeltrame
Cc: lbeltrame, #frameworks

KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 10 - Still Unstable!

2017-05-27 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/10/
 Project:
Frameworks kiconthemes kf5-qt5 XenialQt5.7
 Date of build:
Sat, 27 May 2017 06:35:27 +
 Build duration:
1 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.kiconloader_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)94%
(15/16)94%
(15/16)38%
(980/2592)27%
(575/2103)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)42%
(212/502)17%
(96/578)src89%
(8/9)89%
(8/9)37%
(768/2090)31%
(479/1525)

build.log
Description: Binary data