D6856: Reset url in closeUrl()
dfaure added a comment. Code looks good to me. INLINE COMMENTS > readonlypart.cpp:244 > > +// TODO KF6: make it non-virtual so that we can just call > +// closeUrlImpl() + setUrl(QUrl()) and get rid of m_closeUrlFromOpenUrl. I'm not sure about that TODO, it would be a horrendous porting trap (closeUrl not called anymore, no way to detect it unless `override` was used) I was commenting on the problem with this design, but I don't think we should actually change it, the bool works. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6856 To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: cullmann, #frameworks
D6597: Add magic define to enable setgroups(2)
This revision was automatically updated to reflect the committed changes. Closed by commit R241:15451d505fdb: Fix build on musl libc by exposing setgroups(2). (authored by mpyne). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6597?vs=16422=17270 REVISION DETAIL https://phabricator.kde.org/D6597 AFFECTED FILES src/kpac/kpac_dhcp_helper.c To: mpyne, #frameworks
D6598: Declare _POSIX_SOURCE to ensure kill(2) is declared
This revision was automatically updated to reflect the committed changes. Closed by commit R303:c42f18a7fc1a: Use proper feature flag to include kill(2). (authored by mpyne). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6598?vs=16423=17269#toc REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6598?vs=16423=17269 REVISION DETAIL https://phabricator.kde.org/D6598 AFFECTED FILES src/start_kdeinit/start_kdeinit.c To: mpyne, #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 38 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/38/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 27 Jul 2017 02:53:33 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
D6800: Add template for a simple kpart-based application
This revision was automatically updated to reflect the committed changes.
Closed by commit R306:089284db0c0d: Add template for a simple kpart-based
application (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6800?vs=16946=17264#toc
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6800?vs=16946=17264
REVISION DETAIL
https://phabricator.kde.org/D6800
AFFECTED FILES
CMakeLists.txt
ExtraDesktop.sh
templates/CMakeLists.txt
templates/kpartsapp/CMakeLists.txt
templates/kpartsapp/README
templates/kpartsapp/icons/16-apps-%{APPNAMELC}.png
templates/kpartsapp/icons/32-apps-%{APPNAMELC}.png
templates/kpartsapp/icons/48-apps-%{APPNAMELC}.png
templates/kpartsapp/icons/CMakeLists.txt
templates/kpartsapp/kpartsapp.kdevtemplate
templates/kpartsapp/kpartsapp.png
templates/kpartsapp/src/CMakeLists.txt
templates/kpartsapp/src/part/%{APPNAMELC}part.cpp
templates/kpartsapp/src/part/%{APPNAMELC}part.desktop
templates/kpartsapp/src/part/%{APPNAMELC}part.h
templates/kpartsapp/src/part/%{APPNAMELC}partui.rc
templates/kpartsapp/src/part/CMakeLists.txt
templates/kpartsapp/src/part/Messages.sh
templates/kpartsapp/src/shell/%{APPNAMELC}.desktop
templates/kpartsapp/src/shell/%{APPNAMELC}shell.cpp
templates/kpartsapp/src/shell/%{APPNAMELC}shell.h
templates/kpartsapp/src/shell/%{APPNAMELC}ui.rc
templates/kpartsapp/src/shell/CMakeLists.txt
templates/kpartsapp/src/shell/Messages.sh
templates/kpartsapp/src/shell/main.cpp
To: kossebau, #frameworks, dfaure
Cc: lueck, ltoscano, aacid
D6941: fix plasmashell unsetting QSG_RENDER_LOOP
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D6941 To: mkoller, davidedmundson Cc: #frameworks
D6941: fix plasmashell unsetting QSG_RENDER_LOOP
mkoller created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY being hit by the problem of plasmashell using way too much CPU even when doing "nothing", I found the description of the QSG_RENDER_LOOP env variable to be settable to basic, which solves the problem. However, even though I set the var in ~/.config/plasma-workspace/env/KDE5.sh plasmashell (and only this process) always ends up having the var set to an EMPTY string (I check this via /proc/PIC/environ). I don't know from where RendererSettings is initialized, but I assume that the QString inside it is not null but empty, so isNull() == false but isEmpty() == true With this patch, QSG_RENDER_LOOP=basic is now correct in plasmashell's env after a login. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D6941 AFFECTED FILES src/quickaddons/qtquicksettings.cpp To: mkoller, davidedmundson Cc: #frameworks
D6936: ECMGeneratePriFile - mac os x framework builds of Qt
winterz abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6936 To: winterz, dfaure Cc: #frameworks, #build_system
D6889: TestPart: add more test cases
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. Moved relevant test case in https://phabricator.kde.org/D6856 REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6889 To: elvisangelaccio, #kate, #kdevelop, dfaure Cc: #frameworks
D6856: Reset url in closeUrl()
elvisangelaccio updated this revision to Diff 17247. elvisangelaccio added a comment. - Fix apidox REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6856?vs=17246=17247 BRANCH reset-url-in-closeUrl REVISION DETAIL https://phabricator.kde.org/D6856 AFFECTED FILES autotests/parttest.cpp autotests/parttest.h src/readonlypart.cpp src/readonlypart.h src/readonlypart_p.h To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: cullmann, #frameworks
D6856: Reset url in closeUrl()
elvisangelaccio updated this revision to Diff 17246. elvisangelaccio edited the summary of this revision. elvisangelaccio added a comment. - Don't emit urlChanged() twice when calling openUrl(). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6856?vs=17149=17246 BRANCH reset-url-in-closeUrl REVISION DETAIL https://phabricator.kde.org/D6856 AFFECTED FILES autotests/parttest.cpp autotests/parttest.h src/readonlypart.cpp src/readonlypart_p.h To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: cullmann, #frameworks
D6936: ECMGeneratePriFile - mac os x framework builds of Qt
dfaure added a comment. This would make a large number of other headers accessible on other Unixes. So this additional include should be added only on Mac OS. I'm also a bit confused by the description. You say "QT/include" but this is rather about the includes for the framework, no? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6936 To: winterz, dfaure Cc: #frameworks, #build_system
D6936: ECMGeneratePriFile - mac os x framework builds of Qt
winterz created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY on mac os x framework builds of Qt, QT/include is not added to the list of include path,. this patch looks up one level so those includes can be found TEST PLAN used the generated pri file on Mac REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6936 AFFECTED FILES modules/ECMGeneratePriFile.cmake To: winterz, dfaure Cc: #frameworks, #build_system
D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
elvisangelaccio added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6685 To: elvisangelaccio, #frameworks, dfaure
D6833: Add support for PrivilegeExecution in KIO jobs
chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:1674 > Should the flag always be set here? Or only if m_privilegeExecutionEnabled is > true? Ideally it should be set when m_privilegeExecutionEnabled is true. But it will add more lines. Even though its just 2-3 lines, it doesn't look good. Besides the flag is ineffective if the parent job doesn't have this flag set. Shall I remove it? REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6833: Add support for PrivilegeExecution in KIO jobs
chinmoyr updated this revision to Diff 17225. chinmoyr added a comment. - Remove extra if statements - if..else -> switch..case in CopyJob CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6833?vs=17022=17225 BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6833 AFFECTED FILES src/core/chmodjob.cpp src/core/copyjob.cpp src/core/deletejob.cpp src/core/filecopyjob.cpp src/core/job_p.h src/core/mkpathjob.cpp src/core/storedtransferjob.cpp To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6914: Switch from QtScript to QtQml
cullmann added a comment. For me only the ruby tests fail, too. REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6914: Switch from QtScript to QtQml
carewolf updated this revision to Diff 17224. carewolf edited the summary of this revision. carewolf added a comment. Forgot to add the new private headers. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6914?vs=17223=17224 REVISION DETAIL https://phabricator.kde.org/D6914 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt autotests/src/bug313759.cpp autotests/src/bug317111.cpp autotests/src/script_test_base.cpp autotests/src/scriptdocument_test.cpp autotests/src/templatehandler_test.cpp autotests/src/testutils.cpp autotests/src/testutils.h autotests/src/vimode/CMakeLists.txt src/CMakeLists.txt src/include/ktexteditor/cursor.h src/script/data/indentation/ada.js src/script/data/indentation/cstyle.js src/script/data/indentation/pascal.js src/script/data/indentation/ruby.js src/script/katecommandlinescript.cpp src/script/kateindentscript.cpp src/script/katescript.cpp src/script/katescript.h src/script/katescriptdocument.cpp src/script/katescriptdocument.h src/script/katescripthelpers.cpp src/script/katescripthelpers.h src/script/katescriptview.cpp src/script/katescriptview.h src/script/scriptcursor.h src/script/scriptrange.h src/utils/katetemplatehandler.cpp To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6914: Switch from QtScript to QtQml
carewolf updated this revision to Diff 17223. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6914?vs=17209=17223 REVISION DETAIL https://phabricator.kde.org/D6914 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt autotests/src/bug313759.cpp autotests/src/bug317111.cpp autotests/src/script_test_base.cpp autotests/src/scriptdocument_test.cpp autotests/src/templatehandler_test.cpp autotests/src/testutils.cpp autotests/src/testutils.h autotests/src/vimode/CMakeLists.txt src/CMakeLists.txt src/include/ktexteditor/cursor.h src/script/data/indentation/ada.js src/script/data/indentation/cstyle.js src/script/data/indentation/pascal.js src/script/data/indentation/ruby.js src/script/katecommandlinescript.cpp src/script/kateindentscript.cpp src/script/katescript.cpp src/script/katescript.h src/script/katescriptdocument.cpp src/script/katescriptdocument.h src/script/katescripthelpers.cpp src/script/katescripthelpers.h src/script/katescriptview.cpp src/script/katescriptview.h src/utils/katetemplatehandler.cpp To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6832: Integrate new file ioslave in KIO job
chinmoyr updated this revision to Diff 17222. chinmoyr added a comment. 1. Separated enums, vars and functions 2. Removed hardcoding 3. Use the new signal privilegeOperationRequested 4. Removed public methods added in previous revision. Instead of them d_func is used (which should have been the case right from the start but I overlooked it somehow) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6832?vs=17021=17222 BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6832 AFFECTED FILES src/core/job.cpp src/core/job_base.h src/core/job_p.h src/core/simplejob.cpp src/core/simplejob.h To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6914: Switch from QtScript to QtQml
carewolf added a comment. As I said it has some instrumentation and dead-code. I will clean it up a bit. I was just hoping for a bit of help on why the ruby indent tests are being weird. INLINE COMMENTS > dhaumann wrote in katescripthelpers.cpp:178 > Is this all not required anymore? It is not used at all in our code, not before this patch or after. I don't know if it could be used in other scripts. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6914: Switch from QtScript to QtQml
dhaumann added a comment.
First of all, I also think this is a good patch.
There are some parts with debug output, some parts with warnings (e.g.
Q_FUNC_INFO), I guess this is temporary? :-)
Besides that, there are several parts with commented out code - is that work
in progress, or is the commented out code not required at all anymore?
INLINE COMMENTS
> katescript.cpp:77
>
> -bt += m_engine->uncaughtExceptionBacktrace().join(QStringLiteral("\n"))
> + QLatin1Char('\n');
> +//bt += m_engine>uncaughtExceptionBacktrace().join(QStringLiteral("\n"))
> + QLatin1Char('\n');
>
If there is no equivalent to get the backtrace, just delete this line.
> katescript.cpp:96
> }
> -m_engine->clearExceptions();
> +//m_engine->clearExceptions();
> }
If such a call is not required, please delete.
> katescript.cpp:150
> +m_engine->globalObject().setProperty(QStringLiteral("require"),
> functions.property(QStringLiteral("require")));
> m_engine->globalObject().setProperty(QStringLiteral("require_guard"),
> m_engine->newObject());
>
If I remember correctly, Christoph once said it as quite a hassle to get this
include guard working correctly. Are you sure it works or are there possibly
issues due to some other behavior in QJSEngine?
> katescriptdocument.h:63-65
> Q_INVOKABLE QString text(const KTextEditor::Cursor , const
> KTextEditor::Cursor );
> Q_INVOKABLE QString text(const KTextEditor::Range );
> +Q_INVOKABLE QString text(const QJSValue );
If I understand correctly, you are adding an overload for all functions that
have KTextEditor::Cursor or Range in the parameter.
Does that imply we could remove the Q_INVOKABLE part of the overloads that use
the complex types such as Cursor and Range?
If so, I would be in favor of doing this, just to make this explicit.
> katescripthelpers.cpp:178
> /// helper function to do the substitution from QtScript > QVariant > real
> values
> -KLocalizedString substituteArguments(const KLocalizedString , const
> QVariantList , int max = 99)
> -{
> -KLocalizedString ls = kls;
> -int cnt = qMin(arguments.count(), max); // QString supports max 99
> -for (int i = 0; i < cnt; ++i) {
> -QVariant arg = arguments[i];
> -switch (arg.type()) {
> -case QVariant::Int: ls = ls.subs(arg.toInt()); break;
> -case QVariant::UInt: ls = ls.subs(arg.toUInt()); break;
> -case QVariant::LongLong: ls = ls.subs(arg.toLongLong()); break;
> -case QVariant::ULongLong: ls = ls.subs(arg.toULongLong()); break;
> -case QVariant::Double: ls = ls.subs(arg.toDouble()); break;
> -default: ls = ls.subs(arg.toString()); break;
> -}
> -}
> -return ls;
> -}
> +//KLocalizedString substituteArguments(const KLocalizedString , const
> QVariantList , int max = 99)
> +//{
Is this all not required anymore?
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: cullmann, #frameworks
D6914: Switch from QtScript to QtQml
carewolf added a comment. Note all of the helper functions are now single argument, but no script we have use more. It doesn't however remove templating in the i18n functions. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6914: Switch from QtScript to QtQml
cullmann added a comment. A private not-installed header is fine for that, sure. I just would minimize the public API changes. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6914: Switch from QtScript to QtQml
carewolf added a comment. Actually the Q_GADGET part is not needed. I have commented out the code that registers the qmetaobject, so at this point those changes are no longer needed. I needed to do manual conversion anyway. The conversion functions doesn't need to be in public headers. But they are needed in several places, so at least in a private header. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6913: Theme: Remove author and license fields
This revision was automatically updated to reflect the committed changes. Closed by commit R216:12d50fae7527: Theme: Remove license and author fields (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6913?vs=17208=17211 REVISION DETAIL https://phabricator.kde.org/D6913 AFFECTED FILES src/lib/themedata.cpp src/lib/themedata_p.h To: dhaumann, cullmann, vkrause Cc: #frameworks
D6912: Theme: Derive read-only flag from file on disk
This revision was automatically updated to reflect the committed changes. Closed by commit R216:34489c2a1cec: Theme: Derive read-only flag from file on disk (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6912?vs=17206=17210 REVISION DETAIL https://phabricator.kde.org/D6912 AFFECTED FILES autotests/theme_test.cpp data/themes/default.theme data/themes/printing.theme src/lib/theme.h src/lib/themedata.cpp src/lib/themedata_p.h To: dhaumann, vkrause Cc: #frameworks
D6914: Switch from QtScript to QtQml
cullmann added reviewers: cullmann, dhaumann, Frameworks. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: cullmann, #frameworks
D6914: Switch from QtScript to QtQml
cullmann added a comment. First: As already said in person: COOL ;=) I failed to port some years ago and just dumped my patch on the attic. For the changes: Do we need the helper functions in the public headers? I see that we need to make the things Q_GADGETs, thats fine, but do we need to have the Qml includes + helpers there? REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf Cc: cullmann, #frameworks
D6913: Theme: Remove author and license fields
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6913 To: dhaumann, cullmann, vkrause Cc: #frameworks
D6912: Theme: Derive read-only flag from file on disk
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6912 To: dhaumann, vkrause Cc: #frameworks
D6914: Switch from QtScript to QtQml
carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Replaces the QtScript depedency with QtQml. WIP: The ruby indentation test doesn't work, and appears unstable as most failing test succede stand-alone. WIP: There is still instrumentation and dead-code in this change. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt autotests/src/bug313759.cpp autotests/src/bug317111.cpp autotests/src/script_test_base.cpp autotests/src/scriptdocument_test.cpp autotests/src/templatehandler_test.cpp autotests/src/testutils.cpp autotests/src/testutils.h autotests/src/vimode/CMakeLists.txt src/CMakeLists.txt src/include/ktexteditor/cursor.h src/include/ktexteditor/range.h src/script/data/indentation/ada.js src/script/data/indentation/cppstyle.js src/script/data/indentation/cstyle.js src/script/data/indentation/pascal.js src/script/data/indentation/ruby.js src/script/katecommandlinescript.cpp src/script/kateindentscript.cpp src/script/katescript.cpp src/script/katescript.h src/script/katescriptdocument.cpp src/script/katescriptdocument.h src/script/katescripthelpers.cpp src/script/katescripthelpers.h src/script/katescriptview.cpp src/script/katescriptview.h src/utils/katetemplatehandler.cpp To: carewolf Cc: #frameworks
D6913: Theme: Remove author and license fields
dhaumann edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6913 To: dhaumann, cullmann, vkrause Cc: #frameworks
D6913: Theme: Remove author and license fields
dhaumann created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Remove author and license fields to avoid the mess we have in highlighting.xml files. Luckily, this was not yet public API. TEST PLAN make test REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6913 AFFECTED FILES src/lib/themedata.cpp src/lib/themedata_p.h To: dhaumann, cullmann, vkrause Cc: #frameworks
D6906: Create a "." entry even on empty dirs
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0ac78aa3fba4: Emit a "." UDSEntry when not present, even on empty directories. (authored by albertvaka). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6906?vs=17194=17207 REVISION DETAIL https://phabricator.kde.org/D6906 AFFECTED FILES src/core/slavebase.cpp To: albertvaka, #frameworks, elvisangelaccio
D6912: Theme: Derive read-only flag from file on disk
dhaumann created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Instead of having a "read-only" flag in the .theme files, using the file location typically is exactly what we want. And having read-only files in a writable location does not make much sense. TEST PLAN make test, adapted unit tests. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6912 AFFECTED FILES autotests/theme_test.cpp data/themes/default.theme data/themes/printing.theme src/lib/theme.h src/lib/themedata.cpp src/lib/themedata_p.h To: dhaumann, vkrause Cc: #frameworks
D6906: Create a "." entry even on empty dirs
elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Tested with mtp and it works, thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio
D6829: Add ability to use the new kauth helper in file ioslave
chinmoyr updated this revision to Diff 17203. chinmoyr added a comment. Updated doc Renamed signal to privilegeOperationRequested(). Merged request(signal) and reply into one method, isPrivilegeOperationAllowed(). Now there is no round trip. Eliminated QStringList. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6829?vs=17202=17203 BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6829 AFFECTED FILES src/core/slavebase.cpp src/core/slavebase.h src/core/slaveinterface.cpp src/core/slaveinterface.h src/ioslaves/file/file.h src/ioslaves/file/file_unix.cpp src/ioslaves/file/file_win.cpp To: chinmoyr, dfaure, #frameworks Cc: #frameworks
D6829: Add ability to use the new kauth helper in file ioslave
chinmoyr updated this revision to Diff 17202. chinmoyr marked 5 inline comments as done. chinmoyr added a comment. 1. Updated doc 2. Renamed signal to privilegeOperationRequested(). 3. Merged request(signal) and reply into one method, isPrivilegeOperationAllowed(). Now there is no round trip. 4. Eliminated QStringList. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6829?vs=17017=17202 BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6829 AFFECTED FILES src/core/slavebase.cpp src/core/slavebase.h src/core/slaveinterface.cpp src/core/slaveinterface.h src/ioslaves/file/CMakeLists.txt src/ioslaves/file/file.h src/ioslaves/file/file_unix.cpp src/ioslaves/file/file_win.cpp src/ioslaves/file/kauth/CMakeLists.txt src/ioslaves/file/kauth/file.actions src/ioslaves/file/kauth/filehelper.cpp src/ioslaves/file/kauth/filehelper.h src/ioslaves/file/sharefd.cpp src/ioslaves/file/sharefd.h To: chinmoyr, dfaure, #frameworks Cc: #frameworks
