KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 23 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/23/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 04 Feb 2018 04:15:55 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.vimode_completion

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/34/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 04 Feb 2018 04:16:09 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 111 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/111/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 04 Feb 2018 04:15:36 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-threadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31527/59418)38%
(18602/48694)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests99%
(72/73)99%
(72/73)95%
(8599/9059)50%
(5331/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8339/14343)50%
(4870/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/976)41%
(413/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
  

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/37/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Feb 2018 04:15:55 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.vimode_completion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(33874/49372)52%
(17761/34214)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4370/4669)49%
(2164/4386)autotests.src.vimode100%
(16/16)100%
(16/16)96%
(5310/5534)53%
(970/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3121)43%
(1242/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)58%
(176/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)73%
(887/1218)63%
(592/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%
  

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.7 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/15/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 04 Feb 2018 04:15:46 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(411/1441)21%
(182/856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)49%
(53/109)23%
(13/56)src90%
(9/10)90%
(9/10)31%
(358/1156)24%
(169/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/41)0%
(0/4)

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/7/
 Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 04 Feb 2018 04:15:46 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/61/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 04 Feb 2018 04:16:09 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13285)19%
(1975/10485)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(250/2217)7%
(97/1476)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/92/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 04 Feb 2018 04:15:36 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/38/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 04 Feb 2018 04:15:55 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.vimode_completion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(33887/49378)52%
(17761/34216)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4381/4672)49%
(2166/4386)autotests.src.vimode100%
(16/16)100%
(16/16)96%
(5310/5534)53%
(970/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1779/3121)43%
(1243/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)58%
(176/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)73%
(887/1218)63%
(592/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/58/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Feb 2018 04:16:09 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13289)19%
(1976/10485)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(251/2221)7%
(98/1480)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/15/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Feb 2018 04:15:46 +
 Build duration:
3 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(411/1441)21%
(182/856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)49%
(53/109)23%
(13/56)src90%
(9/10)90%
(9/10)31%
(358/1156)24%
(169/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/41)0%
(0/4)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/41/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Feb 2018 02:18:50 +
 Build duration:
5 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/36/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 04 Feb 2018 02:18:50 +
 Build duration:
4 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/25/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 04 Feb 2018 02:18:51 +
 Build duration:
3 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

D10286: Fix C# var regex

[Wes]

wesdawg edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10286

To: wesdawg, #framework_syntax_highlighting
Cc: #frameworks, #framework_syntax_highlighting, michaelh, genethomas, ngraham, 
cullmann, vkrause, dhaumann

D10286: Fix C# var regex

[Wes]

wesdawg created this revision.
wesdawg added a reviewer: Framework: Syntax Highlighting.
wesdawg created this object with visibility "All Users".
wesdawg added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
wesdawg requested review of this revision.

REVISION SUMMARY
  This patch fixes the C# ```var``` data type regex to match correctly on all 
var keywords (e.g. 
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/implicitly-typed-local-variables)

TEST PLAN
  Tested with C# code from 
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/implicitly-typed-local-variables

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10286

AFFECTED FILES
  data/syntax/cs.xml

To: wesdawg, #framework_syntax_highlighting
Cc: #frameworks, #framework_syntax_highlighting, michaelh, genethomas, ngraham, 
cullmann, vkrause, dhaumann

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 91 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/91/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 23:37:15 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest

D10282: Use the destination KFileItem object to figure out of it's writable instead of creating a KFileItemListProperties which basically does the same thing but more expensive.

[Mark Gaiser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:68a832c9e2aa: Use the destination KFileItem object to 
figure out of its writable instead of… (authored by markg).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10282?vs=26466=26467

REVISION DETAIL
  https://phabricator.kde.org/D10282

AFFECTED FILES
  src/widgets/paste.cpp

To: markg, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh

D10282: Use the destination KFileItem object to figure out of it's writable instead of creating a KFileItemListProperties which basically does the same thing but more expensive.

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  kfileitemproperties_optimization

REVISION DETAIL
  https://phabricator.kde.org/D10282

To: markg, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh

D10282: Use the destination KFileItem object to figure out of it's writable instead of creating a KFileItemListProperties which basically does the same thing but more expensive.

[Mark Gaiser]

markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.

REVISION SUMMARY
  Use KFileItem::isWritable instead of the detour with KFileItemListProperties.
  It's basically the same, only more expensive.
  KFileItem::isWritable is already quite expensive on it's own.
  This saves cycles but to be fair, the amount is neglectable.

TEST PLAN
  I verified that the paste action in Dolphin (under the Right mouse button) 
still works.
  Is active (when writable) and shows the correct text as before.

REPOSITORY
  R241 KIO

BRANCH
  kfileitemproperties_optimization

REVISION DETAIL
  https://phabricator.kde.org/D10282

AFFECTED FILES
  src/widgets/paste.cpp

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham

D10279: add 24px media-album-cover icon

[Nathaniel Graham]

ngraham added reviewers: VDG, andreaska.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10279

To: astippich, #breeze, #vdg, andreaska
Cc: ngraham, #frameworks, michaelh

D10279: add 24px media-album-cover icon

[Alexander Stippich]

astippich added a comment.


  It just adds a missing link to an already existing icon, is a screenshot 
needed?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10279

To: astippich, #breeze
Cc: ngraham, #frameworks, michaelh

D10205: fileindexerconfig: Introduce canBeSearched()

[Nathaniel Graham]

ngraham accepted this revision as: Baloo, ngraham.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  search (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10205

To: michaelh, #frameworks, #dolphin, #baloo, mgallien, ngraham
Cc: ashaposhnikov, michaelh, spoorun, ngraham, alexeymin

D10279: add 24px media-album-cover icon

[Nathaniel Graham]

ngraham added a comment.


  Before-and-after screenshots?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10279

To: astippich, #breeze
Cc: ngraham, #frameworks, michaelh

D10279: add 24px media-album-cover icon

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: Breeze.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
astippich requested review of this revision.

REVISION SUMMARY
  media-album-cover icon is missing for the 24px size, create symlink to the 
amarok one like other sizes

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10279

AFFECTED FILES
  icons/actions/24/media-album-cover

To: astippich, #breeze
Cc: #frameworks, michaelh, ngraham

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  signalavailable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D9672: Don't emit error signal before we tried all list commands.

[Wei-Cheng Pan]

wcpan updated this revision to Diff 26460.
wcpan added a comment.


  Don't emit error signal before we tried all list commands.
  
  Use a special error code to skip error reporting.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9672?vs=24747=26460

BRANCH
  fix-ftp-list

REVISION DETAIL
  https://phabricator.kde.org/D9672

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: wcpan, dfaure
Cc: ngraham, cfeck, #frameworks, michaelh

D10278: Do not emit error until all commands have been tried.

[Wei-Cheng Pan]

wcpan created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
wcpan requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  fix-ftp-list

REVISION DETAIL
  https://phabricator.kde.org/D10278

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: wcpan
Cc: #frameworks, michaelh, ngraham

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In https://phabricator.kde.org/D10273#200254, @thiago wrote:
  
  > That doesn't make sense. There's QFile::encodeName in the code
  
  
  I was talking talking about FdSender which is used only in kauth helper.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Thiago Macieira]

thiago added a comment.


  That doesn't make sense. There's QFile::encodeName in the code.
  
  Is there a section of the library that is used in elevated privilege code, 
but not all of it?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Elvis Angelaccio]

elvisangelaccio accepted this revision as: elvisangelaccio.
This revision is now accepted and ready to land.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  signalavailable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> thiago wrote in fdsender.cpp:24
> The problem here is the API. Why is it using std::string in the first place?

The idea was to use std c++ and avoid qt throughout the class because the code 
will be executed with elevated privileges.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Thiago Macieira]

thiago added a comment.


  Looks good.

INLINE COMMENTS

> fdsender.cpp:24
>  
>  FdSender::FdSender(const std::string )
>  : m_socketDes(-1)

The problem here is the API. Why is it using std::string in the first place?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> thiago wrote in fdreceiver.cpp:88
> __APPLE__ is there. My question is about OpenBSD, NetBSD and DragonflyBSD. 
> Are you breaking them? You may not know the answer, but you need to document 
> the issue if you intentionally cause a Failure To Build From Sources.

I have replaced #error with #warning
so there shouldn't be any breakage.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Thiago Macieira]

thiago added a comment.


  The patch that I can see accomplishes what the description says it should do. 
And I agree with the idea of the patch.

INLINE COMMENTS

> dfaure wrote in fdreceiver.cpp:88
> This is UNIX-only, but indeed OSX is missing. Does that support getpeereid?

__APPLE__ is there. My question is about OpenBSD, NetBSD and DragonflyBSD. Are 
you breaking them? You may not know the answer, but you need to document the 
issue if you intentionally cause a Failure To Build From Sources.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase on top of master, FWIW. Can't wait to have this!

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26451.
chinmoyr added a comment.


  Fixed buffer overflow.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10273?vs=26445=26451

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10273

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> sharefd_p.h:61
> +const size_t pathSize = finalPath.size();
> +if (pathSize > 5 && pathSize < sizeof(a.sun_path) - 1) {
>  #ifdef __linux__

you now have a buffer overflow on linux. you need to split the conditional.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26446.
chinmoyr added a comment.


  Moved changes related to SocketAddress to https://phabricator.kde.org/D10273.
  Changed #error to #warning. So even if an OS does not have getpeereid or 
getsockopt compilation will still succeed but copying files will result in an 
error.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9966?vs=26421=26446

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26445.
chinmoyr added a comment.


  Check for null byte at index 1 in case of returning address length on linux.
  Use size of finalPath as pathSize.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10273?vs=26443=26445

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10273

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26443.
chinmoyr added a comment.


  Fixed typos

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10273?vs=26441=26443

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10273

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26441.
chinmoyr added a comment.


  Used QByteArray in FdSender
  Undoed behavioral changes.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10273?vs=26438=26441

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10273

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/kauth/fdsender.h
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> fdsender.cpp:27
>  {
> +SocketAddress addr(path.c_str());
> +if (!addr.address()) {

this actually constructs a qbytearray. that should be probably explicit.

a better approach would be moving the class' interface to qbytearray (or 
actually qstring) as well, to unify the API. but that's again a separate 
refactoring.

> sharefd_p.h:55
> -sockaddr_un a{ AF_UNIX, {0}};
> -std::string finalPath = "/tmp/" + path;
> -#ifdef __linux__

you're removing the auto-prefixing with /tmp/. if that is intentional, you need 
to atomically adjust the callers, as otherwise you're changing behavior.

> sharefd_p.h:56
> -std::string finalPath = "/tmp/" + path;
> -#ifdef __linux__
> -::strcpy(_path[1], finalPath.c_str());

i now noticed that you removed that branch, thus removing the use of linux' 
abstract address space. that also calls for a justification.
did you research the git history to find out why it was introduced in the first 
place?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26438.
chinmoyr added a comment.


  Corrected number of bytes to be copied.
  Added unlink().

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10273?vs=26436=26438

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10273

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> chinmoyr wrote in sharefd_p.h:60
> I just feel like the job of SocketAddress should be to create the address 
> structure and not perform any file operation. Removal of the socket file 
> should be handled by file ioslave or FdReceiver.

that's a valid concern, but doing that belongs into a separate patch which does 
the complementary change (as far as necessary) atomically, and explains it 
properly in the commit message.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr marked 2 inline comments as not done.
chinmoyr added inline comments.

INLINE COMMENTS

> ossi wrote in sharefd_p.h:60
> you still need to address that *somehow* ;)

I just feel like the job of SocketAddress should be to create the address 
structure and not perform any file operation. Removal of the socket file should 
be handled by file ioslave or FdReceiver.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> sharefd_p.h:60
> -::strcpy(a.sun_path, finalPath.c_str());
> -::unlink(finalPath.c_str());
> -#endif

you still need to address that *somehow* ;)

> sharefd_p.h:61
> +if (pathSize > 0 && pathSize < sizeof(a.sun_path) - 1) {
> +memcpy(a.sun_path, path.constData(), sizeof(a.sun_path) - 1);
> +}

the correct length is pathSize + 1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26436.
chinmoyr marked 3 inline comments as done.
chinmoyr added a comment.


  Added space on correct side of & and on either sides of binary operators.
  Used memcpy.
  Restored original position of data member.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10273?vs=26435=26436

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10273

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> fdreceiver.h:45
> +QString m_path;
> +QSocketNotifier *m_readNotifier;
>  };

why are you moving the member?
it doesn't matter in this case, but generally it's better to have the bigger 
members first, concentrating in particular on equal size (and sizeof(QString) 
== sizeof(void*)).
all other things being equal, prefer no change to reduce the diff size.

> sharefd_p.h:54
>  private:
> -static sockaddr_un make_address(const std::string& path)
> +static sockaddr_un make_address(const QByteArray& path)
>  {

space on wrong side of amp

> sharefd_p.h:60
> +const size_t pathSize = path.size();
> +if (pathSize > 0 && pathSize < sizeof(a.sun_path)-1) {
> +::strncpy(a.sun_path, path.constData(), sizeof(a.sun_path)-1);

put spaces around binary operators

> sharefd_p.h:60
> -::strcpy(a.sun_path, finalPath.c_str());
> -::unlink(finalPath.c_str());
> -#endif

you're removing that without replacement. that makes me think that the patch is 
still non-atomic.

> sharefd_p.h:61
> +if (pathSize > 0 && pathSize < sizeof(a.sun_path)-1) {
> +::strncpy(a.sun_path, path.constData(), sizeof(a.sun_path)-1);
> +}

using strncpy() after an explicit length check is relatively pointless (unless 
the trailing zero padding is important).
but the operation can be optimized by using memcpy().

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This patch changes SocketAddress class to create an address structure for
  a pathname socket (on all platforms), provide correct length of the structure
  by including length of any additional implementation specific fields
  and return nullptr upon address query if the address structure was not
  properly  initialized.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10273

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D8056#200013, @simgunz wrote:
  
  > I cannot push so someone needs to do it for me.
  
  
  No problem, I can do it for you.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D10245: Add more default user locations to Places model/panel

[Henrik Fehlauer]

rkflx added a comment.


  @spoorun You make it sound like the sidebar is the only way to access those 
folders. That's not true: The file dialog opens in "Home" by default, where you 
can directly click on Pictures and the other folders anyway.
  
  Regarding not adapting the file dialog to mimetypes: That's not how it works 
in most apps if you look at the file picker part: It only shows those files 
which are supported by the app, e.g. in VLC no odt Documents are shown at all. 
If we'd follow your reasoning we should change VLC to show every filetype, so 
users have a hard time finding things and get an error if they made a mistake 
instead of preventing those in the first place.
  
  Finally, a screenshot:
  
  F5690096: KUrlNavigator.png 
  
  I don't see any header there, so the duplicated entries are plainly 
confusing. Also, the list is way too long now (maximum recommended number of 
items in lists is 4-5).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: alexeymin, markg, spoorun, rkflx, michaelh, ngraham

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 - Build # 23 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/23/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 13:06:20 +
 Build duration:
3 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4479/15039)23%
(1891/8338)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1622/1637)52%
(960/1850)src44%
(52/117)44%
(52/117)23%
(2857/12275)15%
(931/6311)tests0%
(0/37)0%
(0/37)0%
(0/1127)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 16 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/16/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 13:04:43 +
 Build duration:
3 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/22/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 12:59:07 +
 Build duration:
7 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.kdatecomboboxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)29%
(4422/15030)22%
(1866/8330)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)97%
(1589/1630)51%
(942/1842)src44%
(52/117)44%
(52/117)23%
(2833/12273)15%
(924/6311)tests0%
(0/37)0%
(0/37)0%
(0/1127)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/24/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 13:03:07 +
 Build duration:
2 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4471/15040)23%
(1889/8334)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1622/1637)52%
(960/1850)src44%
(52/117)44%
(52/117)23%
(2849/12276)15%
(929/6307)tests0%
(0/37)0%
(0/37)0%
(0/1127)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 12:59:07 +
 Build duration:
5 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.kdatecomboboxtest

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/23/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 12:59:07 +
 Build duration:
3 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.kdatecomboboxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)29%
(4414/15031)22%
(1864/8326)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)97%
(1589/1630)51%
(942/1842)src44%
(52/117)44%
(52/117)23%
(2825/12274)15%
(922/6307)tests0%
(0/37)0%
(0/37)0%
(0/1127)0%
(0/177)

D9966: [KIO] Fix issues with sharing of file descriptor

[David Faure]

dfaure added a comment.


  Right, the port to QByteArray could be splitted out of this socket security 
fix commit.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

[Mark Gaiser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:32b3bbcd16fd: Use the KFileItemListProperties copy 
constructor instead of the conversion from… (authored by markg).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10261?vs=26401=26428

REVISION DETAIL
  https://phabricator.kde.org/D10261

AFFECTED FILES
  src/widgets/dropjob.cpp

To: markg, dfaure, jtamate
Cc: #frameworks, michaelh, ngraham

D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

[Jaime Torres Amate]

jtamate accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  KFileItemListProperties_stage2

REVISION DETAIL
  https://phabricator.kde.org/D10261

To: markg, dfaure, jtamate
Cc: #frameworks, michaelh, ngraham

D10257: KUrlMimeData: fix handling of PreferLocalUrls

[Jaime Torres Amate]

jtamate accepted this revision.
jtamate added a comment.


  Looks good (and symmetric).
  
  Is it difficult to create a new test?

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10257

To: dfaure, mwolff, jtamate, markg
Cc: markg, ngraham, #frameworks, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Oswald Buddenhagen]

ossi added a comment.


  In https://phabricator.kde.org/D9966#199979, @dfaure wrote:
  
  > Thiago: now it's ready for your review ;)
  
  
  if he wants to look past the already pointed out non-atomicity. i for one 
just refuse to look at this mess any further.
  https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets 
(i find https://wiki.qt.io/Commit_Policy point 8 clearer (yeah, i wrote it down 
myself ^^))

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/21/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 11:22:14 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.kdatecomboboxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)29%
(4433/15032)22%
(1868/8330)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)97%
(1589/1630)51%
(942/1842)src44%
(52/117)44%
(52/117)23%
(2844/12275)15%
(926/6311)tests0%
(0/37)0%
(0/37)0%
(0/1127)0%
(0/177)

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/25/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 11:12:59 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  Good!
  
  I cannot push so someone needs to do it for me.
  
  Soon, I'll have more free time, and I'll try to polish the code (remove fetch 
more, use Qt 5.10 recursive filtering).

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/26/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 11:12:59 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks, looks ok to me now.
  
  Well, all that code about incremental fetching (canFetchMore/fetchMore) only 
to then fetch everything upfront, could be simplified to just create the full 
tree without going through the fetchMore API... but I'll stop nitpicking ;)
  
  Please wait until the end of this weekend (5.43 tagging) before pushing 
though (new i18n calls).

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 22 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/22/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 11:22:14 +
 Build duration:
3 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.kdatecomboboxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)29%
(4414/15031)22%
(1864/8326)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)97%
(1589/1630)51%
(942/1842)src44%
(52/117)44%
(52/117)23%
(2825/12274)15%
(922/6307)tests0%
(0/37)0%
(0/37)0%
(0/1127)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/14/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 11:22:14 +
 Build duration:
2 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.kdatecomboboxtest

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/20/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 11:12:59 +
 Build duration:
8 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

D9966: [KIO] Fix issues with sharing of file descriptor

[David Faure]

dfaure added a comment.


  Thanks, looks ok to me now.
  
  Thiago: now it's ready for your review ;)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26421.
chinmoyr added a comment.


  1. Used QByteArray in SocketAddress.
  2. Rearranged members of FdReceiver.
  3. Removed changes not directly related to these fixes.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9966?vs=26403=26421

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 89 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/89/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 10:37:13 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 57 test(s)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 107 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/107/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 10:18:43 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31570/59417)38%
(18605/48636)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5347/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8344/14343)50%
(4874/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3855/7802)33%
(1625/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(509/974)42%
(394/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

D10266: Improve error handling in file ioslave

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:27aa3764c0bf: Improve error handling in file ioslave 
(authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10266?vs=26417=26420

REVISION DETAIL
  https://phabricator.kde.org/D10266

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 108 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/108/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 10:18:43 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31572/59419)38%
(18604/48560)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8634/9060)50%
(5345/10693)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8350/14344)50%
(4876/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3856/7802)33%
(1626/4884)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(509/974)42%
(394/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

D10266: Improve error handling in file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  The unittests pass.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10266

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 88 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/88/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 10:18:43 +
 Build duration:
9 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfilecopytomenutest

D10266: Improve error handling in file ioslave

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Ah OK so it was dead code. Removing dead code is always good.
  
  The patch looks ok to me now -- assuming the unittests still pass, which you 
didn't mention in the testing section of this review request.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10266

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D9966: [KIO] Fix issues with sharing of file descriptor

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D9966#199916, @dfaure wrote:
  
  > The early push was so we don't release 5.43 (planned for today) without 
this security fix at all, in case of no answer...
  
  
  Timing is not that important. As long as the other issues mentioned in the 
mail are not fixed, this shouldn't get re-enabled.

INLINE COMMENTS

> thiago wrote in file.h:106
> This change should be in a separate commit. I can't tell what you're doing 
> specifically to fix the bug with so much noise in this commit.

The fixes in this commit uncovered a design issue in the code which this fixes.
It could probably be split though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/48/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 03 Feb 2018 10:13:48 +
 Build duration:
5 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(258/306)62%
(155/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(216/249)63%
(140/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/48/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Feb 2018 10:13:48 +
 Build duration:
2 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(258/306)62%
(155/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(216/249)63%
(140/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/46/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 03 Feb 2018 10:13:48 +
 Build duration:
2 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupe

D10266: Improve error handling in file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In https://phabricator.kde.org/D10266#199961, @dfaure wrote:
  
  > socketPath() being passed by argument: true for OPEN indeed, but what about 
OPENDIR?
  
  
  No method in FileProtocol calls execWithElevatedPrivilege with OPENDIR 
action. If one does in future then we can pass socetPath() as argument there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10266

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10266: Improve error handling in file ioslave

[David Faure]

dfaure added a comment.


  socketPath() being passed by argument: true for OPEN indeed, but what about 
OPENDIR?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10266

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10266: Improve error handling in file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26417.
chinmoyr added a comment.


  errno -> errcode
  KIO::ERR_ACCESS_DENIED -> err
  socketPath is passed as an argument in line 106

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10266?vs=26415=26417

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10266

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10245: Add more default user locations to Places model/panel

[Alexey Min]

alexeymin added a comment.


  +1 very positive! There should be as many default places as possible, 
scrollbars are not awful; at least `Desktop`, `Documents`, `Downloads`, 
`Pictures`, `Music` fit perfectly fine. User can easily remove unneeded entries 
(it's easier to remove than to add I think)
  And collapsible headers would be very cool.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10245

To: ngraham, #frameworks, #dolphin
Cc: alexeymin, markg, spoorun, rkflx, michaelh, ngraham

D10233: [KIO] Remove PrivilegeExecution job flag

[David Faure]

dfaure added a comment.


  In https://phabricator.kde.org/D10233#199851, @chinmoyr wrote:
  
  > Try copying org.kde.kio.file.conf and .service file to dbus-1 directory. It 
worked for me.
  
  
  Ah, systemd stuff, not dbus stuff (which finds files in my custom prefix). 
Thanks, that worked, I was able to copy a file to '/'.
  The context menu for that file crashes kded5 (kdesvnd), I'm debugging that 
now...
  
  > On a completely different note, do all jobs have a uidelgate or does 
passing HideProgressInfo flag prevent it from being created?
  
  Neither ;)
  Some jobs don't have a uidelegate, those where we call setUiDelegate(0) (as 
is often done in unittests, to prevent any interaction with the user, like 
"file exists, do you want to overwrite or skip").
  HideProgressInfo doesn't remove such interaction, so the delegate still 
exists when setting HideProgressInfo.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10233

To: chinmoyr, #frameworks, dfaure
Cc: ngraham, michaelh

D10266: Improve error handling in file ioslave

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> file_unix.cpp:122
>  if (execAction.status() == KAuth::Action::AuthorizedStatus) {
> -return execWithElevatedPrivilege(action, arg1, arg2, arg3);
> +return execWithElevatedPrivilege(action, args, errno);
>  }

Why errno here? What sets it? Shouldn't that be errcode?

> file_unix.cpp:815
> +out << arg;
>  }
>  

What happened to the code that was passing socketPath() for OPEN and OPENDIR? 
It wasn't needed?

> file_win.cpp:392
>  {
> -return PrivilegeOperationReturnValue::failure();
> +return PrivilegeOperationReturnValue::failure(KIO::ERR_ACCESS_DENIED);
>  }

Why not just return the errcode that was given as input?
Won't this change mess up all error handling on Windows, otherwise, by "eating" 
the proper error codes?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10266

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D9966: [KIO] Fix issues with sharing of file descriptor

[David Faure]

dfaure added a comment.


  Thiago: thanks for the review. You didn't say anything about the 
getsockopt/getpeereid usage so I assume this part looks ok? That's mostly what 
I wanted you to look at.
  
  The early push was so we don't release 5.43 (planned for today) without this 
security fix at all, in case of no answer...

INLINE COMMENTS

> thiago wrote in fdreceiver.cpp:34
> Don't use toStdString(). I know this is what it used to do, but you can take 
> the opportunity to fix the issue.

Right, this should be QFile::encodeName(m_path) and using QByteArray in 
SocketAddress rather than std::string.

> thiago wrote in fdreceiver.cpp:88
> Where's the support for other OSes?

This is UNIX-only, but indeed OSX is missing. Does that support getpeereid?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10266: Improve error handling in file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26415.
chinmoyr added a comment.


  Used KIO error codes for windows

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10266?vs=26412=26415

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10266

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10266: Improve error handling in file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  When executing an action with elevated privileges file ioslave directly 
checks errno
  and then decides whether to continue or not. Since errno can change frequently
  between function call it should not be relied upon.
  With this patch after a function fails errno value is saved and then that 
saved value
  is used wherever required.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10266

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10045: remote: don't create entries with empty names

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Minor: now readName() is called 3 times, I think this should go into a local 
variable.
  
  I don't understand why the name can be empty in one of the desktop files, 
that seems quite strange. But oh well.

INLINE COMMENTS

> mwolff wrote in remoteimpl.cpp:56
> is this OK? or are there other entries that should be shown under remote:/ ?

I'm not 100% sure, but given the code in statNetworkFolder and below, I think 
every interesting file always ends with .desktop.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10045

To: mwolff, dfaure
Cc: dhaumann, #frameworks, michaelh, ngraham