D12538: Always prompt for overwrite on double-click in save dialog

[Nathaniel Graham]

ngraham added a comment.


  We still need to fix Kate's save dialog before we can land this, because 
right now it handles the overwrite case itself rather than delegating to the 
dialog like most KDE apps do. And we should do a sweep of other KDE apps that 
also have this legacy behavior left over from before the save dialog handled 
overwrite itself.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Always prompt for overwrite on double-click in save dialog

[Nathaniel Graham]

ngraham retitled this revision from "Select item without clicking the Open/Save 
button" to "Always prompt for overwrite on double-click in save dialog".
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  Oops, I was the one who was confused, sorry.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12569: Pony: fix identifier and keyword

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
jpoelen added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - missing `elseiftype` keyword
  - fix DataType of 1 or 2 characters or starting with `_`
  - `'` suffix is valid for a variable

TEST PLAN
  Run the tests.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_pony

REVISION DETAIL
  https://phabricator.kde.org/D12569

AFFECTED FILES
  autotests/folding/highlight.pony.fold
  autotests/html/highlight.pony.html
  autotests/input/highlight.pony
  autotests/reference/highlight.pony.ref
  data/syntax/pony.xml

To: jpoelen, dhaumann
Cc: #frameworks, michaelh, genethomas, bruns, cullmann, vkrause, dhaumann

D12562: Use "Configure %1..." for text of applet configure action

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This will match KDE apps, +1.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  useConfigureActionText

REVISION DETAIL
  https://phabricator.kde.org/D12562

To: kossebau, #vdg, #plasma, ngraham
Cc: ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Henrik Fehlauer]

rkflx added a comment.


  > [remove] BUG: 267749
  
  Now I'm confused: Isn't what we do here exactly what the bug reporter wanted?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Nathaniel Graham]

ngraham added a comment.


  Any objections to landing this tomorrow if we don't hear any objections from 
#frameworks  people before then?

REPOSITORY
  R241 KIO

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx
Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

[Nathaniel Graham]

ngraham added a comment.


  Given that this is fixing a fairly straightforward bug, I feel pretty 
confident about this patch. #frameworks 
 people: any objections, or shall 
we land this tomorrow?

REPOSITORY
  R241 KIO

BRANCH
  select_filename_only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12544

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  select_filename_only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12544

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense conceptually and doesn't break Baloo for me.

REPOSITORY
  R293 Baloo

BRANCH
  db_robustness

REVISION DETAIL
  https://phabricator.kde.org/D12335

To: bruns, #baloo, michaelh, #frameworks, ngraham
Cc: ngraham, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

[Stefan Brüns]

bruns added a comment.


  Can someone please review this - would be nice to get rid of all the bug 
reports and //Baloo is shit, just disable it// "reviews"

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12335

To: bruns, #baloo, michaelh, #frameworks
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  In D12538#254871 , @rkflx wrote:
  
  > @ngraham Is this still the case with the changed scope of the patch?
  
  
  Yeah, it's fine now that we're going to handle the single-click overwrite use 
case in another patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Henrik Fehlauer]

rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.


  Thanks, works great now for single click users. Glad we could skip a huge 
discussion ;)
  
  However, for double click mode and Save, descending into directories is kinda 
broken. You might want to fix that before shipping…
  
  > Activate files in the filepicker without having to click on the Open/Save 
button first, but instead single/double clicking on the icon, depending on the 
mouse settings.
  
  Please update your summary too, and ideally reference those 3 commits I 
mentioned, as they contain useful information and you copied most of the patch 
from there.
  
  In D12538#254372 , @ngraham wrote:
  
  > (As mentioned before, this can't and won't land until other things have 
been fixed and implemented first)
  
  
  @ngraham Is this still the case with the changed scope of the patch?

INLINE COMMENTS

> kfilewidget.cpp:1179
> +// accept). This way the user can choose a file and add a "_2" for 
> instance to the filename.
> +// Double clicking however will trigger this, regardless of 
> single/double click mouse setting,
> +// see: _k_slotViewDoubleClicked

Do you mean "override" instead of "trigger" here?

> kfilewidget.cpp:2156-2162
> +void KFileWidgetPrivate::_k_slotViewDoubleClicked(const QModelIndex )
> +{
> +if (operationMode == KFileWidget::Saving && index.isValid()) {
> +q->slotOk();
> +}
> +}
> +

I'd move that right under `:_k_slotIconSizeSliderMoved`, to keep ordering at 
least somewhat consistent with the declaration.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.


  Thanks for the patch. Pondered over the code, but could not find anything 
wrong.
  
  In D12544#254554 , @anemeth wrote:
  
  > I removed these checks: `&& !locationEdit->isVisible()`
  >  I assume at one point the filename line edit was once set to hide/show on 
demand.
  
  
  Beineri originally implemented this in 0134fb3a5e50 
, 
apparently. However, I don't understand why the check has a `!`. How could this 
ever work? At least in the latest KDE3 it is already broken.

REPOSITORY
  R241 KIO

BRANCH
  select_filename_only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12544

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12371: fix always reproducible crash

[Jaime Torres Amate]

jtamate updated this revision to Diff 33211.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  The responsible for changing smb:// into smb:/// was: void 
KFileWidgetPrivate::_k_enterUrl(const QUrl )
  With this patch, the crashes are gone, as there is no redirection to smb:///
  But now there is no smb error message. F5824747: smb_error_spanish.png 
 (in spanish). unless smb:/// is 
introduced manually as the url.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12371?vs=33045=33211

REVISION DETAIL
  https://phabricator.kde.org/D12371

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: jtamate, dfaure, #frameworks, apol
Cc: anthonyfieroni, apol, michaelh, bruns

D12513: CVE-2018-10361: privilege escalation

[Matthias Gerstner]

mgerstner added a comment.


  Hi,
  
  I am the guy that came up with the initial security report. I contacted
  //cullman// about the issue and we've exchanged a couple of emails about how
  to improve the code.
  
  He asked me about what approach would be better: Setting up the temporary file
  in $TMPDIR and potentially lose the atomic rename() possibility or keeping the
  approach of creating the temporary file in the target directory.
  
  We agreed upon that I add my thoughts here in this Phabricator entry for
  public discussion.
  
  The issue I reported was caused by reopening the temporary file which was
  probably caused by a misunderstanding of the QTemporaryFile API. The new code
  discussed so far should fix this issue and thus the exploit I published.
  
  Apart from this I don't think it matters much if the temporary file is kept in
  $TMPDIR or in the target directory. If the target directory is owned by a
  non-root user then there is always room for shenanigans by the unprivileged
  user. Therefore I would stick to the approach of keeping the temporary file in
  the target directory and additionally to the following:
  
  - enter the target directory via chdir()
  - check if the owner and group of the directory:
  - if owned by root:root, good to go
- otherwise either reject the operation (simple) or do a temporary privdrop 
to the owner/group of the directory including drop of  supplementary groups 
(complex).
  - create the tmpfile in the target dir and do the renameat() using only 
AT_FDCWD
  - restore privileges, if necessary
  
  The tricky thing is doing the privdrop, which is probably not covered by the
  Qt core library. The good thing about it is that with doing this the kernel
  takes over worrying about permission handling, which it is good at.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12513

To: cullmann, dfaure
Cc: mgerstner, aacid, ngraham, fvogt, cullmann, #frameworks, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D12562: Use "Configure %1..." for text of applet configure action

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: VDG, Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Follows HIG in using verb-based name, also starting the text with the most
  important objective first.
  As result also consistent with default text for similar action in menu of a
  normal app (when using KStandardAction).

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  useConfigureActionText

REVISION DETAIL
  https://phabricator.kde.org/D12562

AFFECTED FILES
  src/plasma/private/applet_p.cpp

To: kossebau, #vdg, #plasma
Cc: #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Henrik Fehlauer]

rkflx edited the summary of this revision.
rkflx edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice. Looks like this does what it's supposed to for open and save, in both 
single and double-click mode. Tested with Kate, Spectacle, and Gwenview.

REPOSITORY
  R241 KIO

BRANCH
  select_filename_only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12544

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  In D12538#254764 , @rkflx wrote:
  
  > Given the concerns with selection markers in single-select mode and thus 
for Save in general, and them being potentially far off in the future, can we 
think about changing this patch to double-click to overwrite, so single-click 
would still allow to append `_2` to the filename, a likely more common 
operation? Users who set click behaviour to double click everywhere would not 
be affected by this change at all!
  >
  > (And please think twice before making this discussion about a general 
single vs. double click debate again; I'm trying to improve single click to 
make more sense for the common use cases here, as we agreed upon as a sensible 
direction. Thanks ;)
  
  
  Makes sense. I'll let you be the judge of what behavior makes the most sense 
for single-click, since I don't use it. However to maybe set the record 
straight: I don't hate single-click; in fact, I love it conceptually! I'm very 
interested in improving the UX, particularly regarding ease-of-use with 
selections. If reverting to double-click makes sense here for usability, then 
let's do it.
  
  In D12538#254782 , @anemeth wrote:
  
  > @rkflx thanks for digging through those old commits.
  >  I added that code again, but for saving only.
  >  Unfortunately I could not test it with single click because the setting 
has vanished (??)
  
  
  Yep, see https://bugs.kde.org/show_bug.cgi?id=393547
  
  Hopefully Roman will fix this soon. In the meantime, you'll have to toggle it 
by editing `kate ~/.config/kdeglobals`; add `SingleClick=(true|false)` to the 
`[KDE]` section.

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth updated this revision to Diff 33204.
anemeth added a comment.


  Add comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33203=33204

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth added a comment.


  @rkflx thanks for digging through those old commits.
  I added that code again, but for saving only.
  Unfortunately I could not test it with single click because the setting has 
vanished (??)
  
  F5824410: aaa.PNG 

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth updated this revision to Diff 33203.
anemeth added a comment.


  Only doubleclick triggers save overwrite

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33165=33203

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Henrik Fehlauer]

rkflx added a comment.


  > https://bugs.kde.org/show_bug.cgi?id=267749
  
  Wow, reading the bug again, my suggestions is fitting right in! Double click 
to trigger Save for single click users. Only after some confusion in Comment 1 
the only slightly related question of overwriting came up in Comment 4, but 
this is not what the bug was originally about…

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Henrik Fehlauer]

rkflx added a comment.


  After sleeping over this, I don't feel comfortable the way this is supposed 
to work for single click: Selection markers only really make sense when 
enabling multi-select mode. Abusing a single selection marker in single-select 
mode to mean "put the filename in the line edit so it is editable" feels really 
weird, and if you are doing this more often than overwriting (which might be 
very likely!) hitting the small icon is quite cumbersome.
  
  IOW, I don't think the workaround which was promised to @jtamate's concern is 
good enough, and suggesting to switch to double click only to sustain a "pure" 
single click does not make sense to me either.
  
  The question for single click is: What is the primary action which should be 
triggered immediately? Is it overwriting, or is it putting the filename in the 
field? For Dolphin and the Open dialog it is clear that actually opening is the 
primary action. For Save I'd argue that overwriting is only the secondary 
option, and thus should be triggered by the second click only.
  
  I did some digging, and indeed this seems to be how it was originally 
implemented: 4ccd77256a0c 
 
added what this patch is now trying to remove again. Then right after that, 
f729c291cdbb 
 
allowed double clicking to overwrite without moving the mouse to the Save 
button. Somehow the latter commit got broken later on, I guess in 7f08f13809bc 
 
("Hope I didn't miss anything." haha). Maybe that slot should have triggered 
only for `KFileWidget::Saving`?
  
  Given the concerns with selection markers in single-select mode and thus for 
Save in general, and them being potentially far off in the future, can we think 
about changing this patch to double-click to overwrite, so single-click would 
still allow to append `_2` to the filename, a likely more common operation? 
Users who set click behaviour to double click everywhere would not be affected 
by this change at all!
  
  ---
  
  Historical side note: In KDE3 with single click enabled, the first click 
would select in file dialogs, the second click would accept. In KDE4 accepting 
was refined to single click for Open, but the double click was kept for Save, 
which makes sense to me.
  
  (And please think twice before making this discussion about a general single 
vs. double click debate again; I'm trying to improve single click to make more 
sense for the common use cases here, as we agreed upon as a sensible direction. 
Thanks ;)

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12520: [PasteJob] Emit KDirNotify on paste

[Kai Uwe Broulik]

broulik added a comment.


  Given I've done this twice now, should we perhaps fix `storedPut` to do that?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12520

To: broulik, #frameworks
Cc: michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 236 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/236/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 27 Apr 2018 07:46:06 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31603/59760)38%
(18578/49001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8598/9151)48%
(5254/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)58%
(8368/14391)50%
(4886/9751)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3875/7877)33%
(1634/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(522/1008)42%
(418/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 214 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/214/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 27 Apr 2018 07:46:06 +
 Build duration:
8 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/85/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 27 Apr 2018 07:46:06 +
 Build duration:
4 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31626/59761)38%
(18579/48997)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8598/9151)48%
(5253/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)58%
(8416/14392)50%
(4907/9755)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3876/7877)33%
(1635/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1780/4338)34%
(1364/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D12557

To: cfeck, alexmerry, dfaure
Cc: #frameworks, michaelh, bruns

D12371: fix always reproducible crash

[David Faure]

dfaure added a comment.


  This is unrelated to concatPaths because concatPaths is about 
absolute+relative.
  smb:// + /  isn't about adding a relative path.
  
  But yes, please find out where smb:/// comes from, and then we can discuss 
solutions ;)
  
  (Check how `kioclient5 ls smb://` and `kioclient5 ls smb:///` show different 
things)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

To: jtamate, dfaure, #frameworks, apol
Cc: anthonyfieroni, apol, michaelh, bruns

D9408: extractors: Hide warnings from system headers

[Kevin Funk]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:b680861aa2ed: extractors: Hide warnings from system 
headers (authored by kfunk).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9408?vs=33189=33191

REVISION DETAIL
  https://phabricator.kde.org/D9408

AFFECTED FILES
  src/extractors/CMakeLists.txt

To: kfunk, mgallien
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns