KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 157 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/157/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 10 May 2018 03:26:10 +
 Build duration:
5 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13463)19%
(1978/10657)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/470)0%
(0/263)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 10 May 2018 03:26:10 +
 Build duration:
2 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D8007: popplerextractor: don't try to guess the title if there isn't one.

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1491c4a2d9fd: popplerextractor: dont try to guess 
the title if there isnt one. (authored by flameeyes, committed by 
ngraham).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8007?vs=19974=33921

REVISION DETAIL
  https://phabricator.kde.org/D8007

AFFECTED FILES
  src/extractors/popplerextractor.cpp

To: flameeyes, #frameworks, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, bruns, michaelh, anthonyfieroni, mgallien, 
vhanda, ngraham, #frameworks, ashaposhnikov, astippich, spoorun

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham updated this revision to Diff 33920.
ngraham added a comment.


  Also omit node_packages folders

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12787?vs=33919=33920

BRANCH
  more-excluded-source-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12787

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ngraham
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12787

To: ngraham
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12787

To: ngraham
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham updated this revision to Diff 33919.
ngraham added a comment.


  Add more to also fix 39093

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12787?vs=33915=33919

BRANCH
  more-excluded-source-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12787

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ngraham
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12114: Revive 'Description' property

[Stefan Brüns]

bruns added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  @michaelh - are you still working on this?
  
  I think using Property::Description for dc::description and the like is very 
sensible, so I would welcome if you pushed this forward.
  
  Regarding the submission scheme, can you split this up into two distinct 
reviews, the first one adding autotests, covering the status quo as is, and the 
second one doing the transition from Propery::Comment to Property::Description

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: michaelh, #baloo, #frameworks
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham updated this revision to Diff 33915.
ngraham added a comment.


  Revert unintentional change

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12787?vs=33912=33915

BRANCH
  more-excluded-source-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12787

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ngraham
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12538: Allow accepting by double-click in save dialog

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D8007: popplerextractor: don't try to guess the title if there isn't one.

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.


  I think this is sensible, to much code for questionable results.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D8007

To: flameeyes, #frameworks, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, bruns, michaelh, anthonyfieroni, mgallien, 
vhanda, ngraham, #frameworks, ashaposhnikov, astippich, spoorun

D12513: CVE-2018-10361: privilege escalation

[Albert Astals Cid]

aacid added a comment.


  I meant dropping privileges to the user that is running the ktexteditor 
program, not to the user that owns the target directory, but now that i think 
about it that's pretty stupid since otherwise we wouldn't be needing root :D
  
  I'll try to go over this with a fresh mind again

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12513

To: cullmann, dfaure
Cc: kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, fvogt, 
cullmann, michaelh, kevinapavew, bruns, demsking, sars, dhaumann

D12538: Allow accepting by double-click in save dialog

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> anemeth wrote in kfilewidget.cpp:1866
> I'm having a lot of trouble finding the correct syntax...
> And the compiler is giving me 100 lines of cryptic error message.
> Could you help me out on this one?

Hmm, you're right, I can't get it to work without a lot of refactoring either. 
Let's leave this alone for now and do the connect syntax porting later.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D12197: autotests: Test for multiple values

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  This depends on the pending discussion how "Subject" and "Keyword" should be 
handled, see D10694 

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12197

To: michaelh, #baloo, #frameworks, mgallien, bruns
Cc: kde-frameworks-devel, ngraham, bruns, ashaposhnikov, michaelh, astippich, 
spoorun

D10694: epubextractor: Handle multiple subjects better

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.
Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; 
removed: Frameworks.


  Discussion regarding subject vs keywords is still pending, i.e. no conclusion.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure, bruns
Cc: kde-frameworks-devel, #baloo, bruns, astippich, ashaposhnikov, michaelh, 
spoorun, navarromorales, isidorov, firef, ngraham, andrebarros, emmanuelp, 
#frameworks

Crash on windows when resetting the toolbar items to the default values

[Alexander Semke]

Hi,

https://bugs.kde.org/show_bug.cgi?id=387610

we've got this bug reported, happens on windows only. Can somebody check this 
with another KF5-application on windows? Any ideas what is causing this crash?

Thanks and Regards,
Alexander

D12538: Allow accepting by double-click in save dialog

[Alex Nemeth]

anemeth marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

[Alex Nemeth]

anemeth updated this revision to Diff 33914.
anemeth added a comment.


  - Remove QFileInfo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33900=33914

BRANCH
  arcpatch-D12538 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D11155: handle zip files embedded within zip files

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D11155

To: sandsmark, dfaure, #frameworks
Cc: ngraham, #frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

[Alex Nemeth]

anemeth added inline comments.

INLINE COMMENTS

> rkflx wrote in kfilewidget.cpp:1866
> Well, how should that line look like then?

I'm having a lot of trouble finding the correct syntax...
And the compiler is giving me 100 lines of cryptic error message.
Could you help me out on this one?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

[Henrik Fehlauer]

rkflx added inline comments.

INLINE COMMENTS

> ngraham wrote in kfilewidget.cpp:1866
> Not for everything, just this one.

Well, how should that line look like then?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> rkflx wrote in kfilewidget.cpp:1866
> Is this even possible without a lot of refactoring (which would be 
> out-of-scope for this patch)?

Not for everything, just this one.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12787

To: ngraham
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12538: Allow accepting by double-click in save dialog

[Henrik Fehlauer]

rkflx added inline comments.

INLINE COMMENTS

> ngraham wrote in kfilewidget.cpp:1866
> Let's use new-style signal/slot syntax for new code. See 
> https://wiki.qt.io/New_Signal_Slot_Syntax

Is this even possible without a lot of refactoring (which would be out-of-scope 
for this patch)?

> kfilewidget.cpp:2183
> +// double clicking to save should only work on files
> +QFileInfo inf(ops->selectedItems().urlList().first().path());
> +

I find `inf` as a variable name slightly too cryptic.

But actually I'd just write this inline and go without `QFileInfo` and the 
`QUrl` conversion altogether, because `KFileItem` should already provide what 
is needed:

  && ops->selectedItems().first().isFile()

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham updated this revision to Diff 33912.
ngraham added a comment.


  add missing comma

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12787?vs=33903=33912

BRANCH
  more-excluded-source-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12787

AFFECTED FILES
  CMakeLists.txt
  src/file/fileexcludefilters.cpp

To: ngraham
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12787: Ignore more types of source files

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> fileexcludefilters.cpp:142
> +"text/csx",
> +"text/vnd.trolltech.linguist"
>  "application/x-awk",

,

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12787

To: ngraham
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12696: Use the new uds implementation

[David Faure]

dfaure added a comment.


  Starting to look good ;-)

INLINE COMMENTS

> udsentry.h:143
>  /**
>   * insert field with string value
>   * @param field numeric field id

The old insert() should be documented that it asserts if the entry already 
exists, and that one should use replace() instead. This will minimize surprises 
in case anyone hits this.

> udsentry.h:319
>  QSharedDataPointer d;
> +friend KIOCORE_EXPORT QDataStream& (::operator<<) (QDataStream , const 
> KIO::UDSEntry );
> +friend KIOCORE_EXPORT QDataStream& (::operator>>) (QDataStream , 
> KIO::UDSEntry );

heh, nice syntax ;-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, bruns, michaelh, ngraham

D12538: Allow accepting by double-click in save dialog

[Nathaniel Graham]

ngraham added a comment.


  Nice! Behaviorally, this works well now and I didn't find any regressions. 
Just some code style comments below:

INLINE COMMENTS

> kfilewidget.cpp:1189
>  }
> +
>  }

Unnecessary unrelated whitespace change

> kfilewidget.cpp:1866
> +
> +connect(d->ops->view(), SIGNAL(doubleClicked(QModelIndex)), this, 
> SLOT(_k_slotViewDoubleClicked(QModelIndex)));
>  }

Let's use new-style signal/slot syntax for new code. See 
https://wiki.qt.io/New_Signal_Slot_Syntax

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

[Andres Betts]

abetts added a comment.


  In D10937#260277 , @ngraham wrote:
  
  > Someone will need to land the changes for you. I'd prefer a few more thumbs 
up first. @abetts, are you good with these?
  
  
  I am linking these a lot. I am "almost" there with the designs. I would just 
ask that the center image of the sample window be simplified. I think it has a 
lot of detail. Maybe we can tone it down by removing some elements and making 
the window look more simple.
  
  Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12787

To: ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Nathaniel Graham]

ngraham added a subscriber: VDG.
ngraham added a comment.


  Someone will need to land the changes for you. I'd prefer a few more thumbs 
up first. @abetts, are you good with these?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Hello again,
  
  I was just wondering if there's something left I have to do now? Like some 
button I have to press or something.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, michaelh, 
crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender, 
#frameworks

D12197: autotests: Test for multiple values

[Nathaniel Graham]

ngraham added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  @michaelh Ping! Can we land this?

REPOSITORY
  R286 KFileMetaData

BRANCH
  multi-value-test (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12197

To: michaelh, #baloo, #frameworks, mgallien, bruns
Cc: kde-frameworks-devel, ngraham, bruns, ashaposhnikov, michaelh, astippich, 
spoorun

D8007: popplerextractor: don't try to guess the title if there isn't one.

[Nathaniel Graham]

ngraham added a comment.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.


  So... are we landing this?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D8007

To: flameeyes, #frameworks, mgallien
Cc: kde-frameworks-devel, #baloo, bruns, michaelh, anthonyfieroni, mgallien, 
vhanda, ngraham, #frameworks, ashaposhnikov, astippich, spoorun

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Add more types of development-related files to the exclusion lists. Thhese 
files aren't useful to index, and having them there can bog down Baloo.
  BUG: 394002
  FIXED-IN 5.47

TEST PLAN
  Created a bunch of files of the newly excluded types. Baloo didn't index them.

REPOSITORY
  R293 Baloo

BRANCH
  more-excluded-source-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12787

AFFECTED FILES
  CMakeLists.txt
  src/file/fileexcludefilters.cpp

To: ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12538: Allow accepting by double-click in save dialog

[Alex Nemeth]

anemeth updated this revision to Diff 33900.
anemeth added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  - Merge branch 'master' of git://anongit.kde.org/kio into arcpatch-D12538
  - Double clicking to save only works on files

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=3=33900

BRANCH
  arcpatch-D12538 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, 
#frameworks, michaelh, bruns

D12696: Use the new uds implementation

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> bruns wrote in kfileitem.cpp:198
> Wouldn't it be better to call m_entry.clear() and m_entry.insert(...) here?
> 
> For the call from the constructor, m_entry is empty, so you save the 
> std::find_if() in the replace method calls.
> 
> For any other caller, is there any useful info in m_entry() which is still 
> valid when calling init() again?

Ignore this one ..

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, bruns, michaelh, ngraham

D12696: Use the new uds implementation

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kfileitem.cpp:198
>  const QByteArray pathBA = QFile::encodeName(path);
>  if (QT_LSTAT(pathBA.constData(), ) == 0) {
> +m_entry.replace(KIO::UDSEntry::UDS_DEVICE_ID,   
> buf.st_dev);

m_entry.reserve(9)

> kfileitem.cpp:198
>  const QByteArray pathBA = QFile::encodeName(path);
>  if (QT_LSTAT(pathBA.constData(), ) == 0) {
> +m_entry.replace(KIO::UDSEntry::UDS_DEVICE_ID,   
> buf.st_dev);

Wouldn't it be better to call m_entry.clear() and m_entry.insert(...) here?

For the call from the constructor, m_entry is empty, so you save the 
std::find_if() in the replace method calls.

For any other caller, is there any useful info in m_entry() which is still 
valid when calling init() again?

> udsentry.cpp:184
> +{
> +s << static_cast(storage.size());
>  

quint32, see ..::load(...) below.

> udsentry.cpp:341
>  {
>  reserve(9);
>  insert(UDS_NAME,name);

I can count 10 inserts below ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, bruns, michaelh, ngraham

D12696: Use the new uds implementation

[Jaime Torres Amate]

jtamate updated this revision to Diff 33889.
jtamate edited the summary of this revision.
jtamate added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  Direct friendship with the operators.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12696?vs=33815=33889

REVISION DETAIL
  https://phabricator.kde.org/D12696

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/listjob.cpp
  src/core/udsentry.cpp
  src/core/udsentry.h

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, bruns, michaelh, ngraham

D12768: Allow wrapping selection off top/bottom of autocomplete results

[Subramaniyam Raizada]

sraizada added a comment.


  I only use Kate/KWrite so didn't test it on the others previously - sorry.
  It actually only works in Kate and KWrite, and has no effect on 
Kile/KDevelop. KDevelop is obviously doing some special stuff, but visually the 
Kile autocompletion seems identical to the one in Kate/KWrite so I'm surprised 
that it doesn't work.
  Any idea what's causing this issue or where I should look in the KDevelop 
code?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12768

To: sraizada, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, 
kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D12768: Allow wrapping selection off top/bottom of autocomplete results

[Subramaniyam Raizada]

sraizada updated this revision to Diff 33884.
sraizada added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  Removed unnecessary modifications to code

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12768?vs=33856=33884

REVISION DETAIL
  https://phabricator.kde.org/D12768

AFFECTED FILES
  src/completion/katecompletiontree.cpp

To: sraizada, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, 
kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann, 
#frameworks

D12765: Use a more intuitive, user-friendly name for Samba share access

[Mark Gaiser]

markg added a comment.


  In D12765#260054 , @ngraham wrote:
  
  > Which ones, and where do they live?
  
  
  I would have expected it for NFS (same repository), but it apparently doesn't 
have a .desktop file at all.
  FTP (lives in the mina kio repo in the ioslaves folder) could have been a 
possibility but also doesn't have a .desktop file.
  
  So no others i suppose.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg, apol, markg
Cc: markg, ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:80429a0ed768: Use a more intuitive, user-friendly name 
for Samba share access (authored by ngraham).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12765?vs=33844=33882

REVISION DETAIL
  https://phabricator.kde.org/D12765

AFFECTED FILES
  smb/smb-network.desktop

To: ngraham, #frameworks, #dolphin, #vdg, apol, markg
Cc: markg, ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

ngraham added a comment.


  Which ones, and where do they live?

REPOSITORY
  R320 KIO Extras

BRANCH
  friendlier-samba-share-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg, apol, markg
Cc: markg, ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Mark Gaiser]

markg accepted this revision.
markg added a comment.


  Please do note that you have more protocols with shared folders that likely 
deserve a name change in the same fashion.

REPOSITORY
  R320 KIO Extras

BRANCH
  friendlier-samba-share-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg, apol, markg
Cc: markg, ltoscano, elvisangelaccio

D9794: Provide access to data returned by helper even on error replies

[Alexander Volkov]

volkov added a comment.


  The error text is nonlocalized because a helper doesn't know a locale of a 
user process.
  With this change the helper may return data that can be composed into a 
translated message in the user process.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D9794

To: volkov, #frameworks
Cc: kde-frameworks-devel, apol, #frameworks, michaelh, ngraham, bruns

D12513: CVE-2018-10361: privilege escalation

[Matthias Gerstner]

mgerstner added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  In D12513#258565 , @aacid wrote:
  
  >
  
  
  
  
  > Honestly i don't understand why i have to care about anything.
  > 
  > If we drop privileges, it's just some code running with regular user level
  >  privileges, why are symlinks a problem?
  
  Well for one, if the target directory is owned by root, then you will be
  dropping privileges to root i.e. you won't drop privileges at all.
  
  The owners of the directory and the target file may differ. Another case might
  be that target directory and file are owned by root, but one of the upper
  directories is owned by a non-root user. Maybe it is a root-owned directory
  that is only temporary in nature and a race condition is involved i.e. it gets
  deleted before the actual file operations begin.
  
  It would be uncommon but we never now what the situation might be. The feature
  seems targeted towards users that have no big technical insight. So strange
  situations can be expected. IMO prudence is the better part of valor here.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12513

To: cullmann, dfaure
Cc: kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, fvogt, 
cullmann, michaelh, kevinapavew, bruns, demsking, sars, dhaumann, #frameworks

D12765: Use a more intuitive, user-friendly name for Samba share access

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  friendlier-samba-share-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg, apol
Cc: ltoscano, elvisangelaccio

D9794: Provide access to data returned by helper even on error replies

[Aleix Pol Gonzalez]

apol added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  What are you trying to fix?
  Why isn't the error text enough?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D9794

To: volkov, #frameworks
Cc: kde-frameworks-devel, apol, #frameworks, michaelh, ngraham, bruns

D12371: fix always reproducible crash

[David Faure]

dfaure accepted this revision.
dfaure added a comment.


  Patch looks good, but please update the first line of the commit message so 
that it gives more context (think about the changelog, where the rest of the 
description won't be visible...)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

To: jtamate, dfaure, #frameworks, apol
Cc: kde-frameworks-devel, anthonyfieroni, apol, michaelh, ngraham, bruns

D12371: fix always reproducible crash

[Jaime Torres Amate]

jtamate updated this revision to Diff 33872.
jtamate marked an inline comment as done.
jtamate edited the summary of this revision.
jtamate added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  The crash after the redirection in fish://127.0.0.1 was due to a remaining of 
an unfinished patch in other files. 
  After removing it and  testing the patch in different machines and different 
compilers, this solves this crash and I haven't noticed regressions.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12371?vs=33242=33872

REVISION DETAIL
  https://phabricator.kde.org/D12371

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: jtamate, dfaure, #frameworks, apol
Cc: kde-frameworks-devel, anthonyfieroni, apol, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12744

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D12768: Allow wrapping selection off top/bottom of autocomplete results

[Sven Brauch]

brauch added a comment.


  What happens if the overload selection window is open in addition (like in 
KDevelop)?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12768

To: sraizada, #ktexteditor
Cc: brauch, #ktexteditor, #frameworks, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann