D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

[jonathan poelen]

jpoelen added a comment.


  Ok, i'm doing this in the week.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  scss

REVISION DETAIL
  https://phabricator.kde.org/D14603

To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann
Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, kevinapavew, ngraham, bruns, 
demsking, sars

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen added a comment.


  There have been changes in the xml files that will cause conflicts. I would 
look in the next few days.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11470

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, rkflx, michaelh, kevinapavew, 
ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 197 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/197/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 13 Aug 2018 22:19:55 +
 Build duration:
2 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13107)19%
(1821/9434)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(299/2212)7%
(96/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D14810: Improve Widgets' removal and configure text

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-this-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14810

To: ngraham, #plasma, #vdg, abetts
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14810

To: ngraham, #plasma, #vdg, abetts
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

[Andres Betts]

abetts accepted this revision.
abetts added a comment.
This revision is now accepted and ready to land.


  This patch is sensible, it saves some strings, space, and it is grammatically 
consistent.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-this-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14810

To: ngraham, #plasma, #vdg, abetts
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14810

To: ngraham, #plasma, #vdg
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14810

To: ngraham, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Dangit, git. Let's try again: D14810: Improve Widgets' removal and configure 
text 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14118

To: ngraham, #plasma, #vdg, gladhorn
Cc: gladhorn, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14810

To: ngraham, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch makes the text for removal and configuration actions consistent 
with one another.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-this-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14810

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/private/applet_p.cpp

To: ngraham, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11838: Turn on line numbers by default

[Nathaniel Graham]

ngraham added a comment.


  Thanks so much, guys! So much improvement in so little time. It's very 
impressive.
  
  Probably this particular patch is now obsolete. I guess now we need a way for 
individual KTextEditor-using apps to pre-populate entries in their local rc 
files or something.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: kwrite-devel, kde-frameworks-devel, cullmann, aacid, acrouthamel, brauch, 
mludwig, kfunk, dhaumann, michaelh, kevinapavew, ngraham, bruns, demsking, sars

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Kai Uwe Broulik]

broulik updated this revision to Diff 39645.
broulik added a comment.


  - Fix top, should have worn my glasses when reading that

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14308?vs=39519&id=39645

REVISION DETAIL
  https://phabricator.kde.org/D14308

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: anthonyfieroni, bruns

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: anthonyfieroni, bruns

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: anthonyfieroni, bruns

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Stefan Brüns]

bruns added a comment.


  Bits ber pixel?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: anthonyfieroni, bruns

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

[David Edmundson]

davidedmundson added a comment.


  We went from 7 failing unit tests on CI to..6!
  
  Progress, but not done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14743

To: davidedmundson, #plasma, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Stefan Brüns]

bruns added a comment.


  In D14308#308137 , @broulik wrote:
  
  > > Should be "Prefer higher BPP"
  >
  > That's just the internal changelog on Phabricator. Can we ship this 
already..
  
  
  See "Summary: " ...

INLINE COMMENTS

> icoutils_common.cpp:98
>  
> -// we loop in reverse order because QtIcoHandler converts all images to 
> 32-bit depth, and resources are ordered from lower depth to higher depth
> -for ( int i_index = icons.size() - 1; i_index >= 0 ; --i_index )
> -{
> -
> -const QImage &icon = icons.at(i_index);
> -int i_width = icon.width();
> -int i_height = icon.height();
> -int i_w = abs(i_width - needWidth);
> -int i_h = abs(i_height - needHeight);
> -
> -if ( i_w < min_w || ( i_w == min_w && i_h < min_h ) )
> -{
> +// QtIcoHandler converts all images to 32-bit depth
> +// but they store the actual depth of the icon extracted in custom 
> text:

either Qt handler for "Ico" files or qicohandler

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: anthonyfieroni, bruns

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> broulik wrote in icoutils_common.cpp:100
> No, that is the actual file name on qtbase git dev

https://github.com/qt/qtbase/blob/5.11/src/plugins/imageformats/ico/qicohandler.cpp

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: anthonyfieroni, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 196 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/196/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 13 Aug 2018 20:42:59 +
 Build duration:
7 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13107)19%
(1821/9434)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(299/2212)7%
(96/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0ae178016adb: Copy PlasmaCore binary qmldir file 
structure into bin for unit tests (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14743?vs=39614&id=39642

REVISION DETAIL
  https://phabricator.kde.org/D14743

AFFECTED FILES
  src/declarativeimports/core/CMakeLists.txt

To: davidedmundson, #plasma, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14743

To: davidedmundson, #plasma, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14808: Add QVector> Definition::characterEncodings() const

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:581e41dfd3ac: Add QVector> Definition::characterEncodings() const (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14808?vs=39639&id=39640

REVISION DETAIL
  https://phabricator.kde.org/D14808

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/definition_p.h

To: dhaumann, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14808: Add QVector> Definition::characterEncodings() const

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Last missing piece for KTextEditor.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  expose-encoding-mappings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14808

To: dhaumann, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14808: Add QVector> Definition::characterEncodings() const

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Returns a list of character/string mapping that can be used for spell
  checking. This is useful for instance when spell checking LaTeX, where
  the string \"{A} represents the character Ä.

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  expose-encoding-mappings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14808

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/definition_p.h

To: dhaumann, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Kai Uwe Broulik]

broulik added a comment.


  > Should be "Prefer higher BPP"
  
  That's just the internal changelog on Phabricator. Can we ship this already..?

INLINE COMMENTS

> bruns wrote in icoutils_common.cpp:100
> qico_handler.cpp (no "n")

No, that is the actual file name on qtbase git dev

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr
Cc: anthonyfieroni, bruns

D11838: Turn on line numbers by default

[Dominik Haumann]

dhaumann added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  We now have application-local settings. What now? Are we closer to solving 
this? ...I guess not: Either it's on for all applications or off for all 
applications. The user still needs to set this up. @cullmann and @ngraham Any 
comments? ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: kwrite-devel, kde-frameworks-devel, cullmann, aacid, acrouthamel, brauch, 
mludwig, kfunk, dhaumann, michaelh, kevinapavew, ngraham, bruns, demsking, 
sars, #frameworks

D14799: Add bool Definition::foldingEnabled() const

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:de651c8cb6b3: Add bool Definition::foldingEnabled() const 
(authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14799?vs=39622&id=39632#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14799?vs=39622&id=39632

REVISION DETAIL
  https://phabricator.kde.org/D14799

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/definition_p.h

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Stefan Brüns]

bruns added a comment.


  Should be "Prefer higher BPP" (bits per pixel), DPI is dots per inch, i.e. 
spatial resolution.

INLINE COMMENTS

> icoutils_common.cpp:100
> +// but they store the actual depth of the icon extracted in custom 
> text:
> +// qtbase/src/plugins/imageformats/ico/qiconhandler.cpp:455
> +int depth = icon.text(QStringLiteral("_q_icoOrigDepth")).toInt();

qico_handler.cpp (no "n")

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr
Cc: anthonyfieroni, bruns

D14799: Add bool Definition::foldingEnabled() const

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  IMHO makes sense and one of the last missing pieces for KTextEditor.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  expose-folding-enabled (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14799

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D7033: Port ki18n from QtScript to QtQml

[Allan Sandfeld Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:9040bff75a5d: Port ki18n from QtScript to QtQml (authored 
by carewolf).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7033?vs=39526&id=39629

REVISION DETAIL
  https://phabricator.kde.org/D7033

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/ktranscript.cpp

To: carewolf, ilic, dhaumann
Cc: dfaure, kde-frameworks-devel, huftis, ngraham, dhaumann, ltoscano, kfunk, 
michaelh, bruns

D7033: Port ki18n from QtScript to QtQml

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I guess it's better to accept this now than later to have a longer testing 
period at Akademy and until the frameworks release.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7033

To: carewolf, ilic, dhaumann
Cc: dfaure, kde-frameworks-devel, huftis, ngraham, dhaumann, ltoscano, kfunk, 
michaelh, bruns

D14800: kioslave/Mac : proxy the bundle-exec and make an agent

[René J . V . Bertin]

rjvbb set the repository for this revision to R241 KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14800

To: rjvbb
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14800: kioslave/Mac : proxy the bundle-exec and make an agent

[René J . V . Bertin]

rjvbb updated this revision to Diff 39623.
rjvbb added a comment.


  Use a current instead of an obsolete platform token.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14800?vs=39620&id=39623

REVISION DETAIL
  https://phabricator.kde.org/D14800

AFFECTED FILES
  src/kioslave/CMakeLists.txt
  src/kioslave/kioslave.cpp
  src/kioslave/kioslave_wrapper.in

To: rjvbb
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14799: Add bool Definition::foldingEnabled() const

[Dominik Haumann]

dhaumann updated this revision to Diff 39622.
dhaumann added a comment.


  - Add another test, now all code paths are tested

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14799?vs=39621&id=39622

BRANCH
  expose-folding-enabled (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14799

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/definition_p.h

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14800: kioslave/Mac : proxy the bundle-exec and make an agent

[René J . V . Bertin]

rjvbb created this revision.
rjvbb added a project: Frameworks.
rjvbb requested review of this revision.

REVISION SUMMARY
  (I thought I had committed this already...)
  
  On Mac, kioslave must be built as an app bundle to prevent keyboard input 
issues (for instance during the authentication step with kio-gdrive) but it 
must also be found in the expected location and, ideally, not put up a menu bar 
nor appear in the app switcher.
  
  This patch achieves all that:
  
  - installs a wrapper script that proxies the kioslave app bundle-exec
  - adds the CoreFoundation magic code that instructs the application to behave 
as an agent.

TEST PLAN
  Works as intended with all kioslaves I tested.
  
  Alternatively one could use a Mac-specific hard-codec path to launch the 
bundle-exec instead of installing the wrapper script. That would require 
patching klauncher - and I don't know if this the only place where kioslave is 
started.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14800

AFFECTED FILES
  src/kioslave/CMakeLists.txt
  src/kioslave/kioslave.cpp
  src/kioslave/kioslave_wrapper.in

To: rjvbb
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14799: Add bool Definition::foldingEnabled() const

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: cullmann, vkrause.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  foldingEnabled() returns true, if either indentationbased folding
  or folding via folding regions are defined. This is required for
  showing/hiding the code folding region in KTextEditor.

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  expose-folding-enabled (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14799

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/definition_p.h

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

[David Edmundson]

davidedmundson updated this revision to Diff 39614.
davidedmundson added a comment.


  Update

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14743?vs=39458&id=39614

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14743

AFFECTED FILES
  src/declarativeimports/core/CMakeLists.txt

To: davidedmundson, #plasma, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7909: Add syntax support for Crystal Programming Language

[Faustino Aguilar]

faguilar added a comment.


  In D7909#307484 , @cullmann wrote:
  
  > Hi, did you get some time to look at the remaining issues?
  >  If they are fixed, I am happy to merge that.
  
  
  Hi, I haven't fixed the issues yet. I'm working on that, I will reply you 
again when the changes are ready :)

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, 
cullmann
Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, 
faguilar, michaelh, genethomas, kevinapavew, bruns, demsking, vkrause, sars, 
dhaumann

D14118: Improve "Remove this [widget]" text

[Nathaniel Graham]

ngraham updated this revision to Diff 39608.
ngraham added a comment.


  Make the text consistent

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14118?vs=38365&id=39608

BRANCH
  remove-this-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14118

AFFECTED FILES
  CMakeLists.txt
  examples/applets/conditionalloader/metadata.desktop
  examples/applets/dataenginemodel/metadata.desktop
  examples/containments/testcontainment/metadata.desktop
  
examples/dataengines/customDataContainers/plasma-dataengine-example-customDataContainers.desktop
  src/plasma/containment.cpp
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasma/data/servicetypes/plasma-containment.desktop
  src/plasma/data/servicetypes/plasma-containmentactions.desktop
  src/plasma/packagestructure/containmentactions-packagestructure.json
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  
templates/plasma-wallpaper-with-qml-extension/plasma-wallpaper-with-qml-extension.kdevtemplate
  
templates/qml-plasmoid-with-qml-extension/qml-plasmoid-with-qml-extension.kdevtemplate
  templates/qml-plasmoid/qml-plasmoid.kdevtemplate

To: ngraham, #plasma, #vdg, gladhorn
Cc: gladhorn, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

[Shubham]

shubham added a comment.


  A question requestMessageBox( ) is a "pure virtual" function inside 
"jobUiDelegateExtension" class which is implemented in "jobUiDelegate" class 
which is the derived class of "jobUiDelegateExtension". When I resolve 
requestMessageBox() using : : like this (jobUiDelegate::), I get an error 
saying jobUiDelegate has  not been declared , to correct the problem when I 
#include  it shows unknown file/directory. what's actually the 
problem?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14757

To: shubham, pino, dfaure
Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

[Dominik Haumann]

dhaumann added a comment.


  Ok - then with minor changes, let's move this forward. Who is going to do the 
work? :-)

INLINE COMMENTS

> kmoretools.cpp:650
> +if (mstruct.mainItems.isEmpty()) {
> +createMoreMenu(mstruct, menu);
> +} else {

This line then changes to d->createMoreMenu(...);

> kmoretools.h:664
> + */
> +void createMoreMenu(const KmtMenuStructure &mstruct, QMenu *parent);
> +

Please move to .cpp file behind the d-pointer.

Reasoning: We usually do not expose private functions in public interafces. 
This has slipped for this class in the past it seems, so for KF6, this needs to 
be changed anyways. But let's start now: move createMoreMenu() into the cpp 
file.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13880

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

[Nathaniel Graham]

ngraham added a comment.


  I'm okay with this patch as a first step, FWIW.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13880

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running'

[Nathaniel Graham]

ngraham added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14787

To: habacker, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14674: handle non-ASCII encodings of file names in tar archives

[Rinat Ibragimov]

ibragimovrinat added a comment.


  Thanks!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, 
ngraham, bruns

D7033: Port ki18n from QtScript to QtQml

[David Faure]

dfaure added a comment.


  +1, looks good to me (but I'm no QJSEngine expert)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D7033

To: carewolf, ilic
Cc: dfaure, kde-frameworks-devel, huftis, ngraham, dhaumann, ltoscano, kfunk, 
michaelh, bruns

D14674: handle non-ASCII encodings of file names in tar archives

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Excellent, thanks for the contribution.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, 
ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.

INLINE COMMENTS

> CMakeLists.txt:153
>   KF5::DBusAddons# KDEInitInterface
> + KF5::WidgetsAddons
>  )

Please remove

> copyjob.cpp:49
>  
> +#include 
> +

Please remove

> copyjob.cpp:892
> +SimpleJobPrivate *sjp;
> +int msgRes;
> +msgRes = 
> sjp->requestMessageBox(JobUiDelegateExtension::WarningYesNo,

join with next line, this isn't 1980-style C code ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14757

To: shubham, pino, dfaure
Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D12662: Add InlineNoteInterface

[Michal Srb]

michalsrb added a comment.


  In D12662#307752 , @brauch wrote:
  
  > I'd like to play with this a bit wrt what can be done in KDevelop with it 
(I want the problem popups gone). Would you mind if I do some changes along the 
way? I would post an updated patch here, in case I actually come up with useful 
changes ...
  
  
  No problem, go ahead.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12662

To: michalsrb, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, cullmann, ngraham, brauch, 
michaelh, kevinapavew, bruns, demsking, sars

D12662: Add InlineNoteInterface

[Sven Brauch]

brauch added a comment.


  I'd like to play with this a bit wrt what can be done in KDevelop with it (I 
want the problem popups gone). Would you mind if I do some changes along the 
way? I would post an updated patch here, in case I actually come up with useful 
changes ...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12662

To: michalsrb, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, cullmann, ngraham, brauch, 
michaelh, kevinapavew, bruns, demsking, sars

D14785: Fix DialogNativeTest in multi screen configuration

[Nathaniel Graham]

ngraham added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14785

To: habacker, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running'

[Ralf Habacker]

habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  Skip the test in that case and show the reason.
  
  BUG: 397418
  FIXED-IN: 5.50.0

TEST PLAN
  compiled and test on opensuse os

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14787

AFFECTED FILES
  autotests/themetest.cpp

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14772: Deprecate KFilterProxySearchLine

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kfilterproxysearchline.h:48
>  
> -class KITEMVIEWS_EXPORT KFilterProxySearchLine
> +class KITEMVIEWS_EXPORT KITEMVIEWS_DEPRECATED KFilterProxySearchLine
>  : public QWidget

Why not KITEMVIEWS_DEPRECATED_EXPORT?

While being defined as `KITEMVIEWS_EXPORT KITEMVIEWS_DEPRECATED`, so 
effectively the same, I wonder about consistent usage of the macros, and if 
there is areason not to use this special one?

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D14772

To: svuorela, kossebau, dfaure
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D14785: Fix DialogNativeTest in multi screen configuration

[Ralf Habacker]

habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  On multi screen configuration the x coordinate of the primary screen may
  not be always zero.
  
  With this commit, the widgets are displayed in different colors to
  distinguish them better.
  
  BUG: 397417
  FIXED-IN: 5.50.0

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14785

AFFECTED FILES
  autotests/dialognativetest.cpp

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14772: Deprecate KFilterProxySearchLine

[Sune Vuorela]

This revision was automatically updated to reflect the committed changes.
Closed by commit R276:f5fef035e5a2: Deprecate KFilterProxySearchLine (authored 
by svuorela).

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14772?vs=39579&id=39580

REVISION DETAIL
  https://phabricator.kde.org/D14772

AFFECTED FILES
  src/kfilterproxysearchline.h

To: svuorela, kossebau, dfaure
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D14772: Deprecate KFilterProxySearchLine

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R276 KItemViews

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14772

To: svuorela, kossebau, dfaure
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D14772: Deprecate KFilterProxySearchLine

[Sune Vuorela]

svuorela updated this revision to Diff 39579.
svuorela added a comment.


  Improve deprecation documentation

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14772?vs=39528&id=39579

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14772

AFFECTED FILES
  src/kfilterproxysearchline.h

To: svuorela, kossebau, dfaure
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D14772: Deprecate KFilterProxySearchLine

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  This class was doing it with a timer, I wonder if that should be part of the 
recommendation ("use QLineEdit with a timer"), or if we don't recommend 
delaying the searching as a general solution.
  (e.g. another typical fix for the "I type one letter and the result is huge" 
issue is to require 3 letters).

REPOSITORY
  R276 KItemViews

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14772

To: svuorela, kossebau, dfaure
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

[Nicolas Fella]

nicolasfella added a comment.


  In D13880#307597 , @dhaumann wrote:
  
  > What is the current state of this?
  >  The new private functions should move to the pimpl class behind the 
d-pointer.
  >
  > In general: Looking at the public classes, /all/ the private functions 
should have been hidden behind the pimpl class...
  
  
  We agreed on how we want to structure the menu, but I haven't had time to 
implement it. IMHO it is out of scope for this patch, though. I think this 
patch is still an improvement for cases where aforementioned redesign won't be 
used and worth merging (after I address your comment)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13880

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14778: Disable loading of translations when using 'C' locale

[Ralf Habacker]

habacker added a comment.


  Just as info:
  
  kcoreaddons uses '(s)' suffix in its internal formating  methods 
(https://cgit.kde.org/kcoreaddons.git/commit/src/lib/util/kformatprivate.cpp?id=ffcd094c1f4716a0d91650608e42017886a0a7e3)
 which is always translated with or without 's'  'not always (s)' depending on 
the amount (see 
https://websvn.kde.org/trunk/l10n-kf5/en/messages/frameworks/kcoreaddons5_qt.po?revision=1522490&view=markup
 line 440ff)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14778

To: habacker, #frameworks, apol
Cc: aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14639: Add syntax-highlighting for RDoc (R documentation)

[Aaron Puchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0b8d8acf816a: Add syntax-highlighting for RDoc (R 
documentation) (authored by aaronpuchert).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14639?vs=39151&id=39576

REVISION DETAIL
  https://phabricator.kde.org/D14639

AFFECTED FILES
  autotests/folding/test.Rd.fold
  autotests/html/test.Rd.html
  autotests/input/test.Rd
  autotests/reference/test.Rd.ref
  data/syntax/rdoc.xml

To: aaronpuchert, dhaumann, cullmann
Cc: #framework_syntax_highlighting, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14778: Disable loading of translations when using 'C' locale

[Ralf Habacker]

habacker added a comment.


  No, both LC_ALL=C and LC_ALL=en  fetches the same english translation
  
~/src/kf5/kcoreaddons-build> LC_ALL=en strace -e trace=file bin/kformattest 
2>&1 | grep \.qm | grep R_OK
access("/usr/share/locale/en/LC_MESSAGES/kcoreaddons5_qt.qm", R_OK) = 0

~/src/kf5/kcoreaddons-build> LC_ALL=C strace -e trace=file bin/kformattest 
2>&1 | grep \.qm | grep R_OK
access("/usr/share/locale/en/LC_MESSAGES/kcoreaddons5_qt.qm", R_OK) = 0
  
  The result is shown at https://bugs.kde.org/show_bug.cgi?id=397404#c0 (see 
below !!and with 'C' locale!!)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14778

To: habacker, #frameworks, apol
Cc: aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14732: Actually allow to set the refresh rate for device statistics

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D14732

To: volkov, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9247: Extend Scripting API to allow executing commands

[Dominik Haumann]

dhaumann marked 2 inline comments as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9247

To: dhaumann, cullmann, mwolff, kfunk
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D9247: Extend Scripting API to allow executing commands

[Dominik Haumann]

dhaumann updated this revision to Diff 39575.
dhaumann added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  - Apply proposed fixes
  - Merge branch 'master' into CommandScript

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9247?vs=23628&id=39575

BRANCH
  CommandScript (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9247

AFFECTED FILES
  src/script/katescriptview.cpp
  src/script/katescriptview.h

To: dhaumann, cullmann, mwolff, kfunk
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann, #frameworks

D13880: [KMoreTools] Reduce menu hierarchy

[Dominik Haumann]

dhaumann added a comment.


  What is the current state of this? The new private functions should move to 
the pimpl class behind the d-pointer.
  
  In general: Looking at the public classes, /all/ the private functions should 
have been hidden behind the pimpl class...

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13880

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14772: Deprecate KFilterProxySearchLine

[Volker Krause]

vkrause added a comment.


  +1, and also too narrow regarding being specific to QLineEdit and QSFPM. If 
at all this should be just the logic, and be independent of the UI.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D14772

To: svuorela, kossebau, dfaure
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D4619: Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9b0d8dce4977: Printing: Respect footer font, fix footer 
vertical position, make header/footer… (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4619?vs=11367&id=39573

REVISION DETAIL
  https://phabricator.kde.org/D4619

AFFECTED FILES
  src/printing/printpainter.cpp

To: atomsymbol, mwolff, dhaumann, kfunk
Cc: kde-frameworks-devel, dhaumann, kwrite-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars

D4619: Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Restricted Application added a project: Kate.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Tested again, certainly an improvement. If we find more issues, we can still 
improve.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4619

To: atomsymbol, mwolff, dhaumann, kfunk
Cc: kde-frameworks-devel, dhaumann, kwrite-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, #frameworks

D14762: Proposal: Add "None" highlighting to repository per default

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6166da7503e6: Add "None" highlighting to 
repository per default (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14762?vs=39522&id=39572#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14762?vs=39522&id=39572

REVISION DETAIL
  https://phabricator.kde.org/D14762

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  autotests/testhighlighter.cpp
  examples/codeeditor.cpp
  src/lib/definition_p.h
  src/lib/repository.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14762: Proposal: Add "None" highlighting to repository per default

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14762

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14763: Definition: Expose command markers

[Christoph Cullmann]

cullmann added a comment.


  > Does KTE only support one comment marker of each type? Then this is ok IMHO.
  
  Yes, all others were silently discarded.
  Later one should check that there is only on in the static checker.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14763

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14763: Definition: Expose command markers

[Volker Krause]

vkrause added a comment.


  Does KTE only support one comment marker of each type? Then this is ok IMHO.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14763

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14762: Proposal: Add "None" highlighting to repository per default

[Christoph Cullmann]

cullmann added a comment.


  Hi, is that change acceptable?
  I would need it to continue on my other KTextEditor patches that will not 
work without this :=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14762

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14778: Disable loading of translations when using 'C' locale

[Albert Astals Cid]

aacid added a comment.


  Doesn't setting the locale to en solve the same problem without needing to 
change ECM?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14778

To: habacker, #frameworks, apol
Cc: aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14593: Update Logtalk language syntax support

[Dominik Haumann]

dhaumann added a comment.


  Thanks goes to do - and sorry for the delay on our side.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14593: Update Logtalk language syntax support

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2ce2523452eb: Update Logtalk language syntax support 
(authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14593?vs=39566&id=39568#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14593?vs=39566&id=39568

REVISION DETAIL
  https://phabricator.kde.org/D14593

AFFECTED FILES
  autotests/folding/highlight.lgt.fold
  autotests/html/highlight.lgt.html
  autotests/input/highlight.lgt
  autotests/reference/highlight.lgt.ref
  data/syntax/logtalk.xml

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14593: Update Logtalk language syntax support

[Paulo Moura]

pmoura added a comment.


  Thanks for your help!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Restricted Application added a project: Kate.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  Thanks, changes look, please commit (after running make test) :-)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  optimize_many_files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11543

To: nibags, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, #frameworks

Re: purpose unittests on Windows

[Ben Cooksley]

On Mon, Aug 13, 2018 at 1:16 AM David Faure  wrote:
>
> On samedi 11 août 2018 07:02:18 CEST Ben Cooksley wrote:
> > On Fri, Aug 10, 2018 at 7:28 PM David Faure  wrote:
> > > Any idea why purpose can't find the KIO http and file protocols -- on
> > > Windows?
> > >
> > > https://build.kde.org/view/Frameworks/job/Frameworks%20purpose%20kf5-qt5%2
> > > 0WindowsMSVCQt5.10/76/testReport/junit/(root)/TestSuite/alternativesmodelt
> > > est/
> > >
> > > That's very odd, because the dependency from purpose on kio is there in
> > > kde-build-metadata (it wouldn't build otherwise), and using kio_file from
> > > other frameworks surely works (e.g. in KParts).
> > >
> > > The lookup for protocols looks for "kf5/kio" under all Qt plugin
> > > directories, i.e. $QT_PLUGIN_PATH.
> > >
> > > The CI log says
> > > QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks purpose kf5-qt5
> > > WindowsMSVCQt5.10\install-prefix\lib\plugins;C:\Craft\CI\windows-msvc2017
> > > _64-cl-debug\lib\qca-qt5'
> > >
> > > => is there a kf5\kio subdir in C:\CI\workspace\Frameworks purpose kf5-qt5
> > > WindowsMSVCQt5.10\install-prefix\lib\plugins ?
> > I've checked and the following seem to be present in that directory,
> > which looks correct to me:
> >
> > ModeLastWriteTime Length Name
> > - -- 
> > -a8/10/2018   8:39 PM 274944 file.dll
> > -a8/10/2018   8:40 PM 352256 ftp.dll
> > -a8/10/2018   8:40 PM 185856 ghelp.dll
> > -a8/10/2018   8:39 PM 185856 help.dll
> > -a8/10/2018   8:45 PM 946688 http.dll
> > -a8/10/2018   8:40 PM 189440 remote.dll
> > -a8/10/2018   8:40 PM 122880 trash.dll
> >
> > Is there any debug output we can enable to see how it is searching for
> > the plugins?
>
> I have now added debug output to kcoreaddons and kio, and the result is:
>
> Checking for plugins in ("C:/CI/workspace/Frameworks purpose kf5-qt5 
> WindowsMSVCQt5.10/build/bin/kf5/kio", 
> "C:/Craft/CI/windows-msvc2017_64-cl-debug/plugins/kf5/kio")
>
> This list doesn't include the above directory, C:\CI\workspace\Frameworks 
> purpose kf5-qt5 WindowsMSVCQt5.10\install-prefix\lib\plugins.
>
> Yet, ECMAddTests.cmake adds to QT_PLUGIN_PATH, it doesn't overwrite it...
> I wonder if set(PATHSEP "\\;") is correct though (why double backslash?)
> QCoreApplication::libraryPaths reads that env var and splits it using 
> QDir::listSeparator() which is ';' on Windows.
> Kevin, any reason for the backslash?
> Do you see any other reason for this to fail, otherwise?

Hi all,

I've done some investigation work on this on the CI system this
morning and it seems that it isn't even necessary to set
QT_PLUGIN_PATH within ECMAddTests (at least on Windows anyway)

QDEBUG : AlternativesModelTest::bigBufferTest() org.kde.kcoreaddons:
Checking for plugins in ("C:/CI/workspace/Frameworks purpose kf5-qt5
WindowsMSVCQt5.10/install-prefix/lib/plugins/kf5/kio",
"C:/Craft/CI/windows-msvc2017_64-cl-debug/lib/qca-qt5/kf5/kio",
"C:/Craft/CI/windows-msvc2017_64-cl-debug/plugins/kf5/kio",
"C:/CI/workspace/Frameworks purpose kf5-qt5
WindowsMSVCQt5.10/build/bin/kf5/kio")
QDEBUG : AlternativesModelTest::bigBufferTest() kf5.kio.core:
"C:/CI/workspace/Frameworks purpose kf5-qt5
WindowsMSVCQt5.10/install-prefix/lib/plugins/kf5/kio/file.dll"
supports protocols ("file")
QDEBUG : AlternativesModelTest::bigBufferTest() kf5.kio.core:
"C:/CI/workspace/Frameworks purpose kf5-qt5
WindowsMSVCQt5.10/install-prefix/lib/plugins/kf5/kio/ftp.dll" supports
protocols ("ftp")
QDEBUG : AlternativesModelTest::bigBufferTest() kf5.kio.core:
"C:/CI/workspace/Frameworks purpose kf5-qt5
WindowsMSVCQt5.10/install-prefix/lib/plugins/kf5/kio/ghelp.dll"
supports protocols ("ghelp")
QDEBUG : AlternativesModelTest::bigBufferTest() kf5.kio.core:
"C:/CI/workspace/Frameworks purpose kf5-qt5
WindowsMSVCQt5.10/install-prefix/lib/plugins/kf5/kio/help.dll"
supports protocols ("help")
QDEBUG : AlternativesModelTest::bigBufferTest() kf5.kio.core:
"C:/CI/workspace/Frameworks purpose kf5-qt5
WindowsMSVCQt5.10/install-prefix/lib/plugins/kf5/kio/http.dll"
supports protocols ("http", "https", "webdav", "webdavs")
QDEBUG : AlternativesModelTest::bigBufferTest() kf5.kio.core:
"C:/CI/workspace/Frameworks purpose kf5-qt5
WindowsMSVCQt5.10/install-prefix/lib/plugins/kf5/kio/remote.dll"
supports protocols ("remote")
QDEBUG : AlternativesModelTest::bigBufferTest() kf5.kio.core:
Refilling KProtocolInfoFactory cache in the hope to find "data"

The above seems correct as far as I can tell?

Unfortunately doing this doesn't fix the test as it's unable to find
kioslave.exe, even though it exists in $workspace/install-prefix/bin/
so not sure what's happening there:

QWARN  : AlternativesModelTest::bigBufferTest() kf5.kio.core: couldn't
create slave: "Can not find 'kioslave' executable at
'C:/CI/workspace/Frameworks purpose kf5-qt5
Windows

D14593: Update Logtalk language syntax support

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14593: Update Logtalk language syntax support

[Paulo Moura]

pmoura added a comment.


  I'm on macOS and I only forked from GitHub the `syntax-highlighting` repo. I 
don't have the necessary infra-structure to compile `KSyntaxHighlighting` and 
generate the reference files. I would very much appreciate if you can take it 
from here. I did test the updated syntax highlight support for Logtalk by 
replacing the `data/syntax/logtalk.xml` in a borrowed Ubuntu box, opening the 
test file, and checking that everything was highlight perfectly.

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

Re: KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still unstable!

[Ben Cooksley]

Hi David,

Unfortunately it doesn't look like the fix we put in place on Saturday did
the trick.

I have a feeling that QStandardPaths on Windows at least will also consider
the Qt install prefix in addition to the local to the executable paths when
searching for mime information. That would explain why the other tests are
working and why making that change didn't fix it.

Any ideas why this still fails?

Cheers,
Ben


On Sun, Aug 12, 2018 at 3:32 AM CI System  wrote:

> *BUILD UNSTABLE*
> Build URL
> https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.10/41/
> Project: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10
> Date of build: Sat, 11 Aug 2018 15:19:21 +
> Build duration: 12 min and counting
> * JUnit Tests *
> Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s),
> Total: 10 test(s)
>
>
> * - Failed: TestSuite.kmimeassociationstest*
>

D14593: Update Logtalk language syntax support

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.


  Shall we integrate this, or can you commit yourself?

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14593: Update Logtalk language syntax support

[Paulo Moura]

pmoura updated this revision to Diff 39566.
pmoura added a comment.


  Added license to Logtalk highlighting test file.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14593?vs=39558&id=39566

REVISION DETAIL
  https://phabricator.kde.org/D14593

AFFECTED FILES
  autotests/input/highlight.lgt
  data/syntax/logtalk.xml

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14692: Use custom QScrollArea with size hint not limited by font size

[Nathaniel Graham]

ngraham added a comment.


  Thanks so much!

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14692

To: valeriymalov, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

[Valeriy Malov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:23ba2b37ef82: Use custom QScrollArea with size hint not 
limited by font size (authored by valeriymalov).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14692?vs=39313&id=39564

REVISION DETAIL
  https://phabricator.kde.org/D14692

AFFECTED FILES
  src/kcmultidialog.cpp
  src/kcmultidialog.h

To: valeriymalov, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14593: Update Logtalk language syntax support

[Dominik Haumann]

dhaumann added a comment.


  Ok, perfect, thanks! I think "Apache License 2.0" is fine as well. It's just 
important that we do know the license, because otherwise it's a mess over time.
  
  How to create the reference. When compiling KSyntaxHighlighting, you then 
write:
  
  - make
  - make test
  
  make test will run all unit tests, and create new files in the build 
directory:
  
  - highlight.lgt.fold
  - highlight.lgt.html
  - highlight.lgt.ref
  
  These can be copied into the source folder by running in the build folder: 
./autotests/update-reference-data.sh

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14778: Disable loading of translations when using 'C' locale

[Nathaniel Graham]

ngraham added reviewers: Frameworks, apol.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14778

To: habacker, #frameworks, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14778: Disable loading of translations when using 'C' locale

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14778

To: habacker
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14593: Update Logtalk language syntax support

[Christoph Cullmann]

cullmann added a comment.


  If there is no redundancy, I am ok with that file. The license should be 
stated in it explicitly, will make it later easier to understand why we can use 
that.
  For the reference generation: after a run, you will get told that stuff 
diffs, e.g. you do
  
  make test
  
  and the tests will fail
  
  You then can look at the output in the autotests folder and copy the matching 
output files to the references folder in the framework.

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Nathaniel Graham]

ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14593: Update Logtalk language syntax support

[Paulo Moura]

pmoura added a comment.


  The test file tests everything that should be highlighted properly. There is 
no redundancy in it. It is large due to testing all built-in language features, 
including all that would be called keywords in other languages. It is the same 
test file that is used to check Logtalk syntax highlighting for two dozens of 
text editors and syntax highlighters. The original file is part of the Logtalk 
distribution and  thus uses the Apache License 2.0. This version, 
`highlight.lgt` can be re-licensed using the license preferred for your 
project. Note that the contents of the file are just for testing highlighting 
and make no sense as an actual compilable source code.

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D14758: use view lines for wheel scrolling, not real lines

[Sven Brauch]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2815fea7854f: Fix: Scroll view lines instead of real lines 
for wheel and touchpad scrolling (authored by brauch).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14758?vs=39499&id=39561#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14758?vs=39499&id=39561

REVISION DETAIL
  https://phabricator.kde.org/D14758

AFFECTED FILES
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: brauch, dhaumann
Cc: rjvbb, cullmann, ngraham, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Ralf Habacker]

habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  See D14778  for the related 
extra-cmake-modules patch
  
  BUG:397404
  FIXED-IN:5.50.0

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14779

AFFECTED FILES
  autotests/kformattest.cpp

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14773: completion widget: fix minimum header section size

[Sven Brauch]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:5499a0df825c: completion widget: fix minimum header 
section size (authored by brauch).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14773?vs=39533&id=39562

REVISION DETAIL
  https://phabricator.kde.org/D14773

AFFECTED FILES
  src/completion/expandingtree/expandingtree.cpp

To: brauch, #kate, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D7909: Add syntax support for Crystal Programming Language

[Christoph Cullmann]

cullmann added a comment.
Restricted Application added a subscriber: kwrite-devel.


  Hi, did you get some time to look at the remaining issues?
  If they are fixed, I am happy to merge that.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, 
cullmann
Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, 
faguilar, michaelh, genethomas, kevinapavew, bruns, demsking, vkrause, sars, 
dhaumann

D14778: Disable loading of translations when using 'C' locale

[Ralf Habacker]

habacker created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  kcoreaddons test case 'kformattest' is designed not to use translations
  and fails if a translation of kcoreaddons is installed.
  To disable translations, QLocale::setDefault(QLocale::C) can now be called 
before
  instantiating Q[Core]Application.
  
  CCBUG:397404

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14778

AFFECTED FILES
  modules/ECMQmLoader.cpp.in

To: habacker
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14593: Update Logtalk language syntax support

[Dominik Haumann]

dhaumann added a comment.


  Just curious: The test file looks good to me, but it looks to me that it also 
contains some redundancy: Think of it as follows: We use this for unit testing. 
As such, the best case is that a test file tests all the corner cases, but 
ideally only once. If a test fails, then we get a diff with the changed 
highlighting information. And if the file is 400 lines of code, checking for 
regressions is much more work compared to if the file only contains e.g. 50 
lines. So: would it be possible to strip it down a bit? And also: Is this file 
freely usable, e.g. licensed under MIT? Would be nice to add a license comment 
in the first line.

REVISION DETAIL
  https://phabricator.kde.org/D14593

To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann