date:20190212

D18941: Fix build with cmake 3.5

2019-02-12 Thread Luca Beltrame

lbeltrame added a reviewer: bruns.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18941

To: wbauer, #build_system, cgiboudeaux, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18941: Fix build with cmake 3.5

2019-02-12 Thread Luca Beltrame

lbeltrame added reviewers: Build System, cgiboudeaux.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18941

To: wbauer, #build_system, cgiboudeaux
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

T3689: Add abi compliance checker to CI

2019-02-12 Thread Dag Andersen

danders added a comment.


  In T3689#175818 , @knauss wrote:
  
  > So far I understood abi-dumper is something different - I use 
abi-complience-checker to create those dumps.
  
  
  Afaiu abi-dumper is the new way of creating dumps. From home page:
  "This new way is based on the analysis of the debug-info from binary objects. 
It's more reliable, faster and simple way. "
  Any particular reason for not to use abi-dumper? (Just curious)
  
  Anyway, I compiled both stable and unstable versions myself, created dumps 
with abi-dumper and got a clean bill.
  So I'm pretty certain the problem reported on CI is not correct (but I have 
been wrong before).

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss, danders
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D18943: Add Fontconfig find modudle

2019-02-12 Thread Volker Krause

vkrause created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Originally coming from KWin, but now also needed by qtbase.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18943

AFFECTED FILES
  find-modules/FindFontconfig.cmake

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18943: Add Fontconfig find modudle

2019-02-12 Thread Christophe Giboudeaux

cgiboudeaux added a comment.


  I'm not sure to understand the commit message, does qtbase look for ECM ?

INLINE COMMENTS

> FindFontconfig.cmake:23
> +# ``Fontconfig::Fontconfig``
> +
> +#=

Missing 'Since'

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18941: Fix build with cmake 3.5

2019-02-12 Thread Christophe Giboudeaux

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18941

To: wbauer, #build_system, cgiboudeaux, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18943: Add Fontconfig find modudle

2019-02-12 Thread Volker Krause

vkrause updated this revision to Diff 51473.
vkrause added a comment.


  Add since tag.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18943?vs=51472&id=51473

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18943

AFFECTED FILES
  find-modules/FindFontconfig.cmake

To: vkrause
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18943: Add Fontconfig find modudle

2019-02-12 Thread Volker Krause

vkrause added a comment.


  In D18943#410391 , @cgiboudeaux 
wrote:
  
  > I'm not sure to understand the commit message, does qtbase look for ECM ?
  
  
  Not as such at this point, but the CMake port of Qt (see wip/cmake branch in 
qtbase) for Qt6 currently copies CMake files from multiple KDE repositories, or 
duplicates existing modules. I'm trying to unify that to just ECM as the 
canonical source, which should simplify collaboration with the Qt team.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18941: Fix build with cmake 3.5

2019-02-12 Thread Wolfgang Bauer

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1632a6972279: Fix build with cmake 3.5 (authored by 
wbauer).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18941?vs=51466&id=51475

REVISION DETAIL
  https://phabricator.kde.org/D18941

AFFECTED FILES
  src/extractors/CMakeLists.txt

To: wbauer, #build_system, cgiboudeaux, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

2019-02-12 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/20/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 12 Feb 2019 09:32:33 +
 Build duration:
1 min 32 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3248/3967)48%
(4785/10033)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(898/917)49%
(1977/4013)src76%
(19/25)76%
(19/25)80%
(1116/1401)45%
(479/1075)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 15 - Still Unstable!

2019-02-12 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/15/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 12 Feb 2019 09:32:33 +
 Build duration:
4 min 48 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3248/3967)48%
(4785/10033)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(898/917)49%
(1977/4013)src76%
(19/25)76%
(19/25)80%
(1116/1401)45%
(479/1075)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D18943: Add Fontconfig find modudle

2019-02-12 Thread Volker Krause

vkrause added a comment.


  I just realized there is a much older version of this in attic/modules 
already, should that be removed as part of adding this?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

2019-02-12 Thread René J . V . Bertin

rjvbb added a comment.


  >   What's the minimum viable change here?
  
  I think my the implementation of my solution is pretty minimal by now, no? :)
  
  @David Faure: any ideas/suggestions, seems right up your alley?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz, markg
Cc: markg, cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18943: Add Fontconfig find modudle

2019-02-12 Thread Aleix Pol Gonzalez

apol added inline comments.

INLINE COMMENTS

> FindFontconfig.cmake:57
> +find_package(PkgConfig)
> +pkg_check_modules(PC_FONTCONFIG QUIET fontconfig)
> +

If you use IMPORTED_TARGET you can skip most stuff below. i.e.
`pkg_check_modules(Flatpak IMPORTED_TARGET flatpak>=0.11.8)`

In fact, I'd argue it's just easier to have pkg_check_modules called upstream 
rather than having an intermediary in ECM or so. 
It's what I did in Discover at least:
https://phabricator.kde.org/source/discover/browse/master/CMakeLists.txt$36

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18943: Add Fontconfig find modudle

2019-02-12 Thread Volker Krause

vkrause added inline comments.

INLINE COMMENTS

> apol wrote in FindFontconfig.cmake:57
> If you use IMPORTED_TARGET you can skip most stuff below. i.e.
> `pkg_check_modules(Flatpak IMPORTED_TARGET flatpak>=0.11.8)`
> 
> In fact, I'd argue it's just easier to have pkg_check_modules called upstream 
> rather than having an intermediary in ECM or so. 
> It's what I did in Discover at least:
> https://phabricator.kde.org/source/discover/browse/master/CMakeLists.txt$36

Does that mean we can rely on pkgconfig? So far I got the impression we have to 
treat that as optional in ECM code?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18943: Add Fontconfig find modudle

2019-02-12 Thread Aleix Pol Gonzalez

apol added inline comments.

INLINE COMMENTS

> vkrause wrote in FindFontconfig.cmake:57
> Does that mean we can rely on pkgconfig? So far I got the impression we have 
> to treat that as optional in ECM code?

Maybe you are right, I don't know what problems pkgconfig my incur in that 
can't be fixed upstream.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18947: Bring FindUDev.cmake up to ECM standards

2019-02-12 Thread Volker Krause

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This prepares it to be upstreamed to ECM, as it's also needed by KWin
  and qtbase.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18947

AFFECTED FILES
  CMakeLists.txt
  KF5SolidConfig.cmake.in
  cmake/FindUDev.cmake
  src/solid/devices/CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18947: Bring FindUDev.cmake up to ECM standards

2019-02-12 Thread Volker Krause

vkrause added a reviewer: Build System.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D18947

To: vkrause, #build_system
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18947: Bring FindUDev.cmake up to ECM standards

2019-02-12 Thread Luca Beltrame

lbeltrame added a reviewer: cgiboudeaux.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D18947

To: vkrause, #build_system, cgiboudeaux
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

2019-02-12 Thread Igor Poboiko

poboiko added inline comments.

INLINE COMMENTS

> bruns wrote in kinotify.cpp:390
> `QFile::decodeName(path)` twice ...

I'm a bit lost, why is it a problem? Or do you mean it's a costly operation and 
suggest to do the following?

  const QString& fname = QFile::decodeName(path);
  Q_EMIT created(fname);
  [...]
  handleDirCreated(fname);

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18947: Bring FindUDev.cmake up to ECM standards

2019-02-12 Thread Aleix Pol Gonzalez

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good to me, comments in D18943  
still apply but let's not block.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18947

To: vkrause, #build_system, cgiboudeaux, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18948: CubeScript: fixes line continuation escape in strings

2019-02-12 Thread Nibaldo González

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Fix the line continuation escape in strings.
  
  CubeScript files use the extension `.cfg`, which is used by default by 
Nagios, making it impossible to add a test file. It might be a good idea to add 
the extension `*.cubescript` and use it for the test file.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-escape-cubescript

REVISION DETAIL
  https://phabricator.kde.org/D18948

AFFECTED FILES
  data/syntax/cubescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18949: R Markdown: improve folding of blocks

2019-02-12 Thread Nibaldo González

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  **Changes:**
  
  - Use a different identifier for the folding of each block.
  - Fixes the end of the folding in some blocks: for example, in the context 
"YAMLhead", the folding is not closed.
  - Replaces `context="Normal Text"` by `context="#pop"`.
  - Add `column="0"` in some rules.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-rmarkdown

REVISION DETAIL
  https://phabricator.kde.org/D18949

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/reference/example.rmd.ref
  data/syntax/rmarkdown.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18950: KCompressionDevice: reset error in open() to allow reuse of object

2019-02-12 Thread Matthias Gerstner

mgerstner created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mgerstner requested review of this revision.

REVISION SUMMARY
  Previously is was not possible to reuse a `KCompressionDevice` object
  after a call to `open()` failed and `propagateErrorCode()` was called. A
  subsequent `open()` would work but a later `close()` will fail, because
  the older errorCode is still set.
  
  By resetting the error code before doing an `open()` this situation is
  avoided and reuse of objects becomes possible.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D18950

AFFECTED FILES
  src/kcompressiondevice.cpp

To: mgerstner
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the

2019-02-12 Thread Nibaldo González

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In the `` tag, it will be possible to highlight JSX, TypeScript and 
Mustache (MustacheJS/HandlebarsJS/RactiveJS) code, according to the "type" 
attribute.