KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/79/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Mar 2019 07:42:22 +
 Build duration:
8 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D19621: ViewPrivate: Make deselection by arrow keys more handy

[loh tar]

loh.tar updated this revision to Diff 53574.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  >> me wrote:
  >> 
  >> 2. Please test with right to left text layout, and mixed text layout.
  > 
  > Can't say what is to be expect in such case, so test is difficult for me
  
  OK. It pointed out that these RTL implementation is slightly buggy in Kate/Qt 
and therefore I was lost. After recent "forced" request to implement it anyway 
and to ignore my inner aversions to do it, I found good old BUG 165397. These 
test data and comments helped me to judge now that this patch works as best as 
it is possible.
  
  - Remove pointless "m_viewInternal->m_view->"
  - Re-arrange if cases, looks now similar as rest of the code
  - Use QFETCH, but not for all needed data. Requests to fix that will ignored 
:p

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19621?vs=53540=53574

REVISION DETAIL
  https://phabricator.kde.org/D19621

AFFECTED FILES
  autotests/src/kateview_test.cpp
  autotests/src/kateview_test.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 78 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/78/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Mar 2019 06:32:20 +
 Build duration:
1 hr 9 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis updated this revision to Diff 53571.
ndavis added a comment.


  - Add window-unpin-symbolic

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19633?vs=53569=53571

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

AFFECTED FILES
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-pin.svg
  icons-dark/actions/16/window-restore.svg
  icons-dark/actions/16/window-unpin.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-pin.svg
  icons-dark/actions/22/window-restore.svg
  icons-dark/actions/22/window-unpin.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/actions/symbolic/window-close-symbolic.svg
  icons-dark/actions/symbolic/window-keep-above-symbolic.svg
  icons-dark/actions/symbolic/window-keep-below-symbolic.svg
  icons-dark/actions/symbolic/window-maximize-symbolic.svg
  icons-dark/actions/symbolic/window-pin-symbolic.svg
  icons-dark/actions/symbolic/window-restore-symbolic.svg
  icons-dark/actions/symbolic/window-unpin-symbolic.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-pin.svg
  icons/actions/16/window-restore.svg
  icons/actions/16/window-unpin.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-pin.svg
  icons/actions/22/window-restore.svg
  icons/actions/22/window-unpin.svg
  icons/actions/32/window-close.svg
  icons/actions/symbolic/window-close-symbolic.svg
  icons/actions/symbolic/window-keep-above-symbolic.svg
  icons/actions/symbolic/window-keep-below-symbolic.svg
  icons/actions/symbolic/window-maximize-symbolic.svg
  icons/actions/symbolic/window-pin-symbolic.svg
  icons/actions/symbolic/window-restore-symbolic.svg
  icons/actions/symbolic/window-unpin-symbolic.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis updated this revision to Diff 53569.
ndavis added a comment.


  - Add window-unpin

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19633?vs=53516=53569

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

AFFECTED FILES
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-pin.svg
  icons-dark/actions/16/window-restore.svg
  icons-dark/actions/16/window-unpin.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-pin.svg
  icons-dark/actions/22/window-restore.svg
  icons-dark/actions/22/window-unpin.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/actions/symbolic/window-close-symbolic.svg
  icons-dark/actions/symbolic/window-keep-above-symbolic.svg
  icons-dark/actions/symbolic/window-keep-below-symbolic.svg
  icons-dark/actions/symbolic/window-maximize-symbolic.svg
  icons-dark/actions/symbolic/window-pin-symbolic.svg
  icons-dark/actions/symbolic/window-restore-symbolic.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-pin.svg
  icons/actions/16/window-restore.svg
  icons/actions/16/window-unpin.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-pin.svg
  icons/actions/22/window-restore.svg
  icons/actions/22/window-unpin.svg
  icons/actions/32/window-close.svg
  icons/actions/symbolic/window-close-symbolic.svg
  icons/actions/symbolic/window-keep-above-symbolic.svg
  icons/actions/symbolic/window-keep-below-symbolic.svg
  icons/actions/symbolic/window-maximize-symbolic.svg
  icons/actions/symbolic/window-pin-symbolic.svg
  icons/actions/symbolic/window-restore-symbolic.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/48/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 06:40:05 +
 Build duration:
2 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/71/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 06:40:05 +
 Build duration:
2 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/70/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 06:37:33 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D19638: Make go-bottom/first/last/top look more like media-skip*

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:24067c74c2d6: Make go-bottom/first/last/top look more 
like media-skip* (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19638?vs=53563=53564

REVISION DETAIL
  https://phabricator.kde.org/D19638

AFFECTED FILES
  icons-dark/actions/16/go-bottom.svg
  icons-dark/actions/16/go-first.svg
  icons-dark/actions/16/go-last.svg
  icons-dark/actions/16/go-top.svg
  icons-dark/actions/22/go-bottom.svg
  icons-dark/actions/22/go-first.svg
  icons-dark/actions/22/go-last.svg
  icons-dark/actions/22/go-top.svg
  icons-dark/actions/24/go-bottom.svg
  icons-dark/actions/24/go-first.svg
  icons-dark/actions/24/go-last.svg
  icons-dark/actions/24/go-top.svg
  icons-dark/actions/32/go-bottom.svg
  icons-dark/actions/32/go-first.svg
  icons-dark/actions/32/go-last.svg
  icons-dark/actions/32/go-top.svg
  icons/actions/16/go-bottom.svg
  icons/actions/16/go-first.svg
  icons/actions/16/go-last.svg
  icons/actions/16/go-top.svg
  icons/actions/22/go-bottom.svg
  icons/actions/22/go-first.svg
  icons/actions/22/go-last.svg
  icons/actions/22/go-top.svg
  icons/actions/24/go-bottom.svg
  icons/actions/24/go-first.svg
  icons/actions/24/go-last.svg
  icons/actions/24/go-top.svg
  icons/actions/32/go-bottom.svg
  icons/actions/32/go-first.svg
  icons/actions/32/go-last.svg
  icons/actions/32/go-top.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

[Noah Davis]

ndavis updated this revision to Diff 53563.
ndavis added a comment.


  Rebase on master

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19638?vs=53530=53563

BRANCH
  go-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19638

AFFECTED FILES
  icons-dark/actions/16/go-bottom.svg
  icons-dark/actions/16/go-first.svg
  icons-dark/actions/16/go-last.svg
  icons-dark/actions/16/go-top.svg
  icons-dark/actions/22/go-bottom.svg
  icons-dark/actions/22/go-first.svg
  icons-dark/actions/22/go-last.svg
  icons-dark/actions/22/go-top.svg
  icons-dark/actions/24/go-bottom.svg
  icons-dark/actions/24/go-first.svg
  icons-dark/actions/24/go-last.svg
  icons-dark/actions/24/go-top.svg
  icons-dark/actions/32/go-bottom.svg
  icons-dark/actions/32/go-first.svg
  icons-dark/actions/32/go-last.svg
  icons-dark/actions/32/go-top.svg
  icons/actions/16/go-bottom.svg
  icons/actions/16/go-first.svg
  icons/actions/16/go-last.svg
  icons/actions/16/go-top.svg
  icons/actions/22/go-bottom.svg
  icons/actions/22/go-first.svg
  icons/actions/22/go-last.svg
  icons/actions/22/go-top.svg
  icons/actions/24/go-bottom.svg
  icons/actions/24/go-first.svg
  icons/actions/24/go-last.svg
  icons/actions/24/go-top.svg
  icons/actions/32/go-bottom.svg
  icons/actions/32/go-first.svg
  icons/actions/32/go-last.svg
  icons/actions/32/go-top.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/47/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 06:35:05 +
 Build duration:
2 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 69 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/69/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 06:32:20 +
 Build duration:
5 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D19639: Change go-up/down-search symlinks target to go-up/down

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:f2509047d437: Change go-up/down-search symlinks target to 
go-up/down (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19639?vs=53560=53562

REVISION DETAIL
  https://phabricator.kde.org/D19639

AFFECTED FILES
  icons-dark/actions/16/go-down-search.svg
  icons-dark/actions/16/go-up-search.svg
  icons-dark/actions/22/go-down-search.svg
  icons-dark/actions/22/go-up-search.svg
  icons-dark/actions/24/go-down-search.svg
  icons-dark/actions/24/go-up-search.svg
  icons/actions/16/go-down-search.svg
  icons/actions/16/go-up-search.svg
  icons/actions/22/go-down-search.svg
  icons/actions/22/go-up-search.svg
  icons/actions/24/go-down-search.svg
  icons/actions/24/go-up-search.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 46 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/46/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 06:32:20 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D19639: Change go-up/down-search symlinks target to go-up/down

[Noah Davis]

ndavis updated this revision to Diff 53560.
ndavis added a comment.


  Rebase on master

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19639?vs=53531=53560

BRANCH
  go-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19639

AFFECTED FILES
  icons-dark/actions/16/go-down-search.svg
  icons-dark/actions/16/go-up-search.svg
  icons-dark/actions/22/go-down-search.svg
  icons-dark/actions/22/go-up-search.svg
  icons-dark/actions/24/go-down-search.svg
  icons-dark/actions/24/go-up-search.svg
  icons/actions/16/go-down-search.svg
  icons/actions/16/go-up-search.svg
  icons/actions/22/go-down-search.svg
  icons/actions/22/go-up-search.svg
  icons/actions/24/go-down-search.svg
  icons/actions/24/go-up-search.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:612a0134603d: Improve pixel grid alignment of 
go-up/down/next/previous/jump (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19641?vs=53558=53559

REVISION DETAIL
  https://phabricator.kde.org/D19641

AFFECTED FILES
  icons-dark/actions/16/go-down.svg
  icons-dark/actions/16/go-jump.svg
  icons-dark/actions/16/go-next.svg
  icons-dark/actions/16/go-previous.svg
  icons-dark/actions/16/go-up.svg
  icons-dark/actions/22/go-up.svg
  icons-dark/actions/24/go-up.svg
  icons-dark/actions/32/go-down.svg
  icons-dark/actions/32/go-jump.svg
  icons-dark/actions/32/go-next.svg
  icons-dark/actions/32/go-previous.svg
  icons-dark/actions/32/go-up.svg
  icons/actions/16/go-down.svg
  icons/actions/16/go-jump.svg
  icons/actions/16/go-next.svg
  icons/actions/16/go-previous.svg
  icons/actions/16/go-up.svg
  icons/actions/22/go-up.svg
  icons/actions/24/go-up.svg
  icons/actions/32/go-down.svg
  icons/actions/32/go-jump.svg
  icons/actions/32/go-next.svg
  icons/actions/32/go-previous.svg
  icons/actions/32/go-up.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

[Noah Davis]

ndavis updated this revision to Diff 53558.
ndavis edited the test plan for this revision.
ndavis added a comment.


  Rebase on master

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19641?vs=53533=53558

BRANCH
  go-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19641

AFFECTED FILES
  icons-dark/actions/16/go-down.svg
  icons-dark/actions/16/go-jump.svg
  icons-dark/actions/16/go-next.svg
  icons-dark/actions/16/go-previous.svg
  icons-dark/actions/16/go-up.svg
  icons-dark/actions/22/go-up.svg
  icons-dark/actions/24/go-up.svg
  icons-dark/actions/32/go-down.svg
  icons-dark/actions/32/go-jump.svg
  icons-dark/actions/32/go-next.svg
  icons-dark/actions/32/go-previous.svg
  icons-dark/actions/32/go-up.svg
  icons/actions/16/go-down.svg
  icons/actions/16/go-jump.svg
  icons/actions/16/go-next.svg
  icons/actions/16/go-previous.svg
  icons/actions/16/go-up.svg
  icons/actions/22/go-up.svg
  icons/actions/24/go-up.svg
  icons/actions/32/go-down.svg
  icons/actions/32/go-jump.svg
  icons/actions/32/go-next.svg
  icons/actions/32/go-previous.svg
  icons/actions/32/go-up.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19511: ViewPrivate: Disable read-only mode action when doc is modified

[Nathaniel Graham]

ngraham added a comment.


  In general I don't think it makes sense to be able to mark an 
already-modified-but-not-yet-saved document as read-only. It's already been 
written to!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, sars, dhaumann

D19646: Redesign KDE Connect and bluetooth config pages

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Better! Could we get a frame and a white background behind this list?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This results in every item in the menu getting an ellipsis, which isn't 
appropriate because not all of them require more user action to proceed (the 
imgur plugin is one such example). It seems like we need a way to indicate in 
the desktop file that the plugin will require user interaction and need an 
ellipsis displayed in the UI, without hardcoding that information with an 
ellipsis in the plugin's own name.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19639: Change go-up/down-search symlinks target to go-up/down

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19639

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

[Nathaniel Graham]

ngraham added a comment.


  In D19633#427965 , @ndavis wrote:
  
  > In D19633#427913 , @ngraham 
wrote:
  >
  > > Neat! Very helpful, thanks.
  > >
  > > While you're at it, do you think you could add a `window-unpin` icon too? 
https://bugs.kde.org/show_bug.cgi?id=405195
  >
  >
  > Yes, but I'm not sure if it should copy the style of the unpin button from 
the tilebar or if it should have a line through it like you suggested. I feel 
like the line is more clear, but less consistent. Maybe it's the titlebar 
button unpin that should be changed?
  
  
  Yeah, I kinda think the titlebar icon should look more like a toggle action 
such that a pinned window just gets a background circle and the symbol inverts. 
Regardless, we'd need a different style anyway for the proposed `window-unpin` 
icon since it's going to be used for a menu action where the title literally is 
"Unpin from Task Manager."

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19641

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 20 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/20/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 04:36:14 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.57.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(450/2236)17%
(198/1134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)93%
(144/155)56%
(59/106)src100%
(8/8)100%
(8/8)68%
(222/327)50%
(105/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/8)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
  

D19638: Make go-bottom/first/last/top look more like media-skip*

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I think this makes sense!

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19638

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/44/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Mar 2019 04:36:08 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/40/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 04:36:08 +
 Build duration:
8 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/32/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 04:36:08 +
 Build duration:
7 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3607/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

D19646: Redesign KDE Connect and bluetooth config pages

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19646: Redesign KDE Connect and bluetooth config pages

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19646: Redesign KDE Connect and bluetooth config pages

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: VDG, apol, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  settings

REVISION DETAIL
  https://phabricator.kde.org/D19646

AFFECTED FILES
  src/plugins/bluetooth/bluetoothplugin_config.qml
  src/plugins/kdeconnect/kdeconnectplugin_config.qml
  src/widgets/JobDialog.qml

To: nicolasfella, #vdg, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 53551.
nicolasfella added a comment.


  - Use i18n

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=53550=53551

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 53550.
nicolasfella added a comment.


  Move ellipsis from plugin name to menu

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=34975=53550

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh added a comment.


  In D19644#428074 , @bruns wrote:
  
  > Do not create a new transaction per file, thats costly.
  
  
  Still less expensive than single transaction for 1k files

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh updated this revision to Diff 53549.
davispuh edited the summary of this revision.
davispuh edited the test plan for this revision.
davispuh added a comment.


  Don't create transaction for every file

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19644?vs=53537=53549

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19644

AFFECTED FILES
  src/engine/writetransaction.cpp
  src/tools/balooctl/main.cpp

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

loh.tar updated this revision to Diff 53548.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Add autoReloadThrottle
  - Add some var settings/signal which looks missed, pls compare to 
onModOnHdReload()
  - not sure if that static single shot make sense
  - pretty untested

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19517?vs=53296=53548

REVISION DETAIL
  https://phabricator.kde.org/D19517

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/document/katedocument.cpp
  src/document/katedocument.h

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17305: Add KDE Connect SMS plugin

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:617e09707f0f: Add KDE Connect SMS plugin (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17305?vs=47226=53547

REVISION DETAIL
  https://phabricator.kde.org/D17305

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/kdeconnect_sms/CMakeLists.txt
  src/plugins/kdeconnect_sms/Messages.sh
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.cpp
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53546.
ognarb added a comment.


  Apply optipng. Thanks @bruns I learned something new :D.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53545=53546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Stefan Brüns]

bruns added a comment.


  and now, apply optipng and you are down to 2kB

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53545.
ognarb added a comment.


  Use inkscape to generate png

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53544=53545

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Stefan Brüns]

bruns added a comment.


  In D19557#428096 , @ognarb wrote:
  
  > Lol 128x128 png image 6kb, 129x129 png image 2kb
  
  
  The new PNG is fuzzy, thats probably the reason it does not compress well.
  
  Try exporting it with inkscape, and check if the vertical/horizontal edges 
are pixel grid aligned.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  Lol 128x128 png image 6kb, 129x129 png image 2kb

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53544.
ognarb added a comment.


  Use a 128x128 png image

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53542=53544

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#428086 , @bruns wrote:
  
  > Is it intentional the PNG is 129x129 while the JPEG is 128x128?
  
  
  I have no idea why 129x129. I used `convert` to convert the svg to png, just 
like I did with the jpg. But I will investigate this issue
  
  > Also, the JPEG shold be removed.
  
  I'm not sure, but I think this will be a problem with some documentations 
where the html wasn't regenerated, because the html wasn't regenerated the 
image element will link to a deadlink.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19621: ViewPrivate: Make deselection by arrow keys more handy

[Dominik Haumann]

dhaumann added a comment.


  The unit test is good, but it does not yet test the right-to-left case (e.g. 
arabic text). Could you add one for this as well?
  
  Maybe you can even use KateViewTest::testDeselectByArrowKeys_data() along 
with QFETCH to reuse the same code in the test function (see other usage of 
QFETCH).

INLINE COMMENTS

> kateview.cpp:2793
>  if (m_viewInternal->m_view->currentTextLine().isRightToLeft()) {
> -m_viewInternal->cursorNextChar();
> +if (selection() && !config()->persistentSelection()) {
> +m_viewInternal->updateCursor(selectionRange().end());

Since we have this line twice, I suggest to move this after line 2791 as 
follows:

  const bool moveToEndOfSelection = selection() && 
!config()->persistentSelection();

Then, you can use a simple `if (moveToEndOfSelection) {...}` which is a bit 
more readable.

REVISION DETAIL
  https://phabricator.kde.org/D19621

To: loh.tar, #ktexteditor
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

D19621: ViewPrivate: Make deselection by arrow keys more handy

[Dominik Haumann]

dhaumann edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D19621

To: loh.tar, #ktexteditor
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

D19557: Update css

[Stefan Brüns]

bruns added a comment.


  Is it intentional the PNG is 129x129 while the JPEG is 128x128?
  Also, the JPEG shold be removed.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19644: Reduce balooctl index/clear memory usage

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Do not create a new transaction per file, thats costly.

INLINE COMMENTS

> main.cpp:222
>  out << "Skipping: " << url << " Reason: Already scheduled 
> for indexing\n";
>  continue;
>  }

You are discarding the write transaction here withouth calling commit() or 
abort()

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53542.
ognarb added a comment.


  Change png image

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53541=53542

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53541.
ognarb added a comment.


  Use png instead of jpg

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53521=53541

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19635: Fix for showing argument hint tree on non-primary screen.

[Thomas Friedrichsmeier]

tfry closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19635

To: tfry, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19621: ViewPrivate: Make deselection by arrow keys more handy

[loh tar]

loh.tar updated this revision to Diff 53540.
loh.tar added a comment.


  - Consider RTL text

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19621?vs=53508=53540

REVISION DETAIL
  https://phabricator.kde.org/D19621

AFFECTED FILES
  autotests/src/kateview_test.cpp
  autotests/src/kateview_test.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh added a comment.


  In D19644#428047 , @bruns wrote:
  
  > A transaction can not be split up, thats the reason it is a transaction ...
  
  
  It can and they must be split in a lot smaller transactions. Currently 
sometimes baloo uses way too big transactions which causes memory usage to 
spike.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh edited the summary of this revision.
davispuh edited the test plan for this revision.
davispuh added reviewers: dhaumann, bruns, ngraham.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh, dhaumann, bruns, ngraham
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Stefan Brüns]

bruns added a comment.


  A transaction can not be split up, thats the reason it is a transaction ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19644

To: davispuh
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D19644: Reduce balooctl index/clear memory usage

[Dāvis Mosāns]

davispuh created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
davispuh requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19644

AFFECTED FILES
  src/engine/writetransaction.cpp
  src/tools/balooctl/main.cpp

To: davispuh
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19638: Make go-bottom/first/last/top look more like media-skip*

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19638

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19639: Change go-up/down-search symlinks target to go-up/down

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19639

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19641

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  These icons had subtle alignment issues. They weren't even always visible, 
but it's a problem when I'm trying to use parts of these icons in other icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19641

AFFECTED FILES
  icons-dark/actions/16/go-down.svg
  icons-dark/actions/16/go-jump.svg
  icons-dark/actions/16/go-next.svg
  icons-dark/actions/16/go-previous.svg
  icons-dark/actions/16/go-up.svg
  icons-dark/actions/22/go-up.svg
  icons-dark/actions/24/go-up.svg
  icons-dark/actions/32/go-down.svg
  icons-dark/actions/32/go-jump.svg
  icons-dark/actions/32/go-next.svg
  icons-dark/actions/32/go-previous.svg
  icons-dark/actions/32/go-up.svg
  icons/actions/16/go-down.svg
  icons/actions/16/go-jump.svg
  icons/actions/16/go-next.svg
  icons/actions/16/go-previous.svg
  icons/actions/16/go-up.svg
  icons/actions/22/go-up.svg
  icons/actions/24/go-up.svg
  icons/actions/32/go-down.svg
  icons/actions/32/go-jump.svg
  icons/actions/32/go-next.svg
  icons/actions/32/go-previous.svg
  icons/actions/32/go-up.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19639: Change go-up/down-search symlinks target to go-up/down

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  go-up/down is more appropriate because go-top/bottom is supposed to be for 
skipping to the top or bottom.

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19639

AFFECTED FILES
  icons-dark/actions/16/go-down-search.svg
  icons-dark/actions/16/go-up-search.svg
  icons-dark/actions/22/go-down-search.svg
  icons-dark/actions/22/go-up-search.svg
  icons-dark/actions/24/go-down-search.svg
  icons-dark/actions/24/go-up-search.svg
  icons/actions/16/go-down-search.svg
  icons/actions/16/go-up-search.svg
  icons/actions/22/go-down-search.svg
  icons/actions/22/go-up-search.svg
  icons/actions/24/go-down-search.svg
  icons/actions/24/go-up-search.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis added a comment.


  In D19633#427913 , @ngraham wrote:
  
  > Neat! Very helpful, thanks.
  >
  > While you're at it, do you think you could add a `window-unpin` icon too? 
https://bugs.kde.org/show_bug.cgi?id=405195
  
  
  Yes, but I'm not sure if it should copy the style of the unpin button from 
the tilebar or if it should have a line through it like you suggested. I feel 
like the line is more clear, but less consistent. Maybe it's the titlebar 
button unpin that should be changed?
  
  In D19633#427915 , @ngraham wrote:
  
  > Also `window-shade`?
  
  
  That can be done once D19575  and D19638 
 are landed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19638

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Once D19575  lands, the style of `go-top` 
will conflict with the style of `collapse-all`. I'm changing the style of these 
related `go-` icons to look more like standard media control symbols for skip 
forward/backward.

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19638

AFFECTED FILES
  icons-dark/actions/16/go-bottom.svg
  icons-dark/actions/16/go-first.svg
  icons-dark/actions/16/go-last.svg
  icons-dark/actions/16/go-top.svg
  icons-dark/actions/22/go-bottom.svg
  icons-dark/actions/22/go-first.svg
  icons-dark/actions/22/go-last.svg
  icons-dark/actions/22/go-top.svg
  icons-dark/actions/24/go-bottom.svg
  icons-dark/actions/24/go-first.svg
  icons-dark/actions/24/go-last.svg
  icons-dark/actions/24/go-top.svg
  icons-dark/actions/32/go-bottom.svg
  icons-dark/actions/32/go-first.svg
  icons-dark/actions/32/go-last.svg
  icons-dark/actions/32/go-top.svg
  icons/actions/16/go-bottom.svg
  icons/actions/16/go-first.svg
  icons/actions/16/go-last.svg
  icons/actions/16/go-top.svg
  icons/actions/22/go-bottom.svg
  icons/actions/22/go-first.svg
  icons/actions/22/go-last.svg
  icons/actions/22/go-top.svg
  icons/actions/24/go-bottom.svg
  icons/actions/24/go-first.svg
  icons/actions/24/go-last.svg
  icons/actions/24/go-top.svg
  icons/actions/32/go-bottom.svg
  icons/actions/32/go-first.svg
  icons/actions/32/go-last.svg
  icons/actions/32/go-top.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19557: Update css

[Stefan Brüns]

bruns added a comment.


  In D19557#426051 , @aacid wrote:
  
  > Why changing from jpg to png for the image file ?
  
  
  The logo is just 2 colors, and the PNG is smaller than the JPEG, without 
introducing artifacts. I would definitely prefer a PNG here.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D11828: Simplify orPostingIterator and make it faster

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11828

To: bruns, #baloo, #frameworks, poboiko
Cc: fvogt, kde-frameworks-devel, #frameworks, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Could you align the top of the down arrow in expand-all to the pixel grid and 
move it down by 1px? Like so: F6677924: Screenshot_20190309_114706.png 

  
  This makes the down arrow look sharper: F6677926: 
Screenshot_20190309_114759.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added a comment.


  @valeriymalov - are you going to update this?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D19633: Improve consistency of window-* and add more

[Nathaniel Graham]

ngraham added a comment.


  Also `window-shade`?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Nathaniel Graham]

ngraham added a comment.


  Neat! Very helpful, thanks.
  
  While you're at it, do you think you could add a `window-unpin` icon too? 
https://bugs.kde.org/show_bug.cgi?id=405195

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D11828: Simplify orPostingIterator and make it faster

[Stefan Brüns]

bruns updated this revision to Diff 53527.
bruns added a comment.


  rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11828?vs=36944=53527

BRANCH
  speedup_orpostingoperator

REVISION DETAIL
  https://phabricator.kde.org/D11828

AFFECTED FILES
  src/engine/orpostingiterator.cpp
  src/engine/orpostingiterator.h

To: bruns, #baloo, #frameworks, poboiko
Cc: fvogt, kde-frameworks-devel, #frameworks, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19635: Fix for showing argument hint tree on non-primary screen.

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Given all other calls use m_parent->... for the screenGeometry call, this 
looks sane.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19635

To: tfry, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19635: Fix for showing argument hint tree on non-primary screen.

[Thomas Friedrichsmeier]

tfry created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
tfry requested review of this revision.

REVISION SUMMARY
  If the texteditor window is on a secondary screen of a multi-screen desktop,
  *and* the argument hint has not yet been shown, before, *and* it going to be
  shown at a y-position above the top of the primary screen, the argument hint
  will fail to show (because screenGeometry(this) will incorrectly refer to the
  primary screen, then).
  
  Thus, refer to the parent view, when determining screen geometry, as is
  already done at other places in the code.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19635

AFFECTED FILES
  src/completion/kateargumenthinttree.cpp

To: tfry
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 53522.
trickyricky26 added a comment.


  - Use design by @ndavis with tighter spacing

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19575?vs=53430=53522

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/16/expand-all.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/22/expand-all.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/expand-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons-dark/actions/32/expand-all.svg
  icons-dark/actions/symbolic/collapse-all-symbolic.svg
  icons-dark/actions/symbolic/expand-all-symbolic.svg
  icons/actions/16/collapse-all.svg
  icons/actions/16/expand-all.svg
  icons/actions/22/collapse-all.svg
  icons/actions/22/expand-all.svg
  icons/actions/24/collapse-all.svg
  icons/actions/24/expand-all.svg
  icons/actions/32/collapse-all.svg
  icons/actions/32/expand-all.svg
  icons/actions/symbolic/collapse-all-symbolic.svg
  icons/actions/symbolic/expand-all-symbolic.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  @aacid it is ready to land?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53521.
ognarb added a comment.


  Use correct breeze color for important and warning

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53469=53521

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg

To: ognarb, #vdg, #documentation
Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Perhaps in addition to the message, one should just add a menu entry in Tools 
like "Read Only Mode", then the user can turn it of again.
  And as said, I think one needs some timer to delay this to reload all x 
seconds, otherwise it might really stall.
  Beside that: already nice

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19621: ViewPrivate: Make deselection by arrow keys more handy

[Sven Brauch]

brauch added a comment.


  Sorry, yeah, I misunderstood!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19621

To: loh.tar, #ktexteditor
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19532: Don't crash when no contexts are present

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7289a7088065: fix highlighter crash for broken hl file 
(authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19532?vs=53234=53517#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19532?vs=53234=53517

REVISION DETAIL
  https://phabricator.kde.org/D19532

AFFECTED FILES
  autotests/input/syntax/brokenlang.xml
  autotests/syntaxrepository_test.cpp
  autotests/test-config.h.in
  src/lib/abstracthighlighter.cpp

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I will commit the minimal needed fix to get this solved.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  context

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  octave-weak-delimiter

REVISION DETAIL
  https://phabricator.kde.org/D19570

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis updated this revision to Diff 53516.
ndavis edited the test plan for this revision.
ndavis added a comment.


  Rename window-maximized to window-restore for better 3rd party compatibility

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19633?vs=53514=53516

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

AFFECTED FILES
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-pin.svg
  icons-dark/actions/16/window-restore.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-pin.svg
  icons-dark/actions/22/window-restore.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/actions/symbolic/window-close-symbolic.svg
  icons-dark/actions/symbolic/window-keep-above-symbolic.svg
  icons-dark/actions/symbolic/window-keep-below-symbolic.svg
  icons-dark/actions/symbolic/window-maximize-symbolic.svg
  icons-dark/actions/symbolic/window-pin-symbolic.svg
  icons-dark/actions/symbolic/window-restore-symbolic.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-pin.svg
  icons/actions/16/window-restore.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-pin.svg
  icons/actions/22/window-restore.svg
  icons/actions/32/window-close.svg
  icons/actions/symbolic/window-close-symbolic.svg
  icons/actions/symbolic/window-keep-above-symbolic.svg
  icons/actions/symbolic/window-keep-below-symbolic.svg
  icons/actions/symbolic/window-maximize-symbolic.svg
  icons/actions/symbolic/window-pin-symbolic.svg
  icons/actions/symbolic/window-restore-symbolic.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

[Nikita Sirgienko]

sirgienko updated this revision to Diff 53515.
sirgienko added a comment.


  Increase syntax file version

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19570?vs=53292=53515

BRANCH
  octave-weak-delimiter

REVISION DETAIL
  https://phabricator.kde.org/D19570

AFFECTED FILES
  autotests/html/test.octave.html
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I guess this is ok, please increment the version of the syntax file and this 
can go in.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19570

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19621: ViewPrivate: Make deselection by arrow keys more handy

[Christoph Cullmann]

cullmann added a comment.


  I think for the bidi stuff, one needs to honor the if 
(m_viewInternal->m_view->currentTextLine().isRightToLeft()) flag.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19621

To: loh.tar, #ktexteditor
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Add window-keep-above/below
  
  Add window-maximize/maximized/minimize
  
  Change window-pin to titlebar button style
  
  Make window-close more consistent

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

AFFECTED FILES
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-maximized.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-pin.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-maximized.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-pin.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/actions/symbolic/window-close-symbolic.svg
  icons-dark/actions/symbolic/window-keep-above-symbolic.svg
  icons-dark/actions/symbolic/window-keep-below-symbolic.svg
  icons-dark/actions/symbolic/window-maximize-symbolic.svg
  icons-dark/actions/symbolic/window-maximized-symbolic.svg
  icons-dark/actions/symbolic/window-pin-symbolic.svg
  icons-dark/actions/symbolic/window-restore-symbolic.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-maximized.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-pin.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-maximized.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-pin.svg
  icons/actions/32/window-close.svg
  icons/actions/symbolic/window-close-symbolic.svg
  icons/actions/symbolic/window-keep-above-symbolic.svg
  icons/actions/symbolic/window-keep-below-symbolic.svg
  icons/actions/symbolic/window-maximize-symbolic.svg
  icons/actions/symbolic/window-maximized-symbolic.svg
  icons/actions/symbolic/window-pin-symbolic.svg
  icons/actions/symbolic/window-restore-symbolic.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19629: Change media-skip* and media-seek* style

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:581ce275edbd: Change media-skip* and media-seek* style 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19629?vs=53494=53510

REVISION DETAIL
  https://phabricator.kde.org/D19629

AFFECTED FILES
  icons-dark/actions/16/media-seek-backward.svg
  icons-dark/actions/16/media-seek-forward.svg
  icons-dark/actions/16/media-skip-backward.svg
  icons-dark/actions/16/media-skip-forward.svg
  icons-dark/actions/22/media-seek-backward.svg
  icons-dark/actions/22/media-seek-forward.svg
  icons-dark/actions/22/media-skip-backward.svg
  icons-dark/actions/22/media-skip-forward.svg
  icons-dark/actions/24/media-seek-backward.svg
  icons-dark/actions/24/media-seek-forward.svg
  icons-dark/actions/24/media-skip-backward.svg
  icons-dark/actions/24/media-skip-forward.svg
  icons-dark/actions/32/media-seek-backward.svg
  icons-dark/actions/32/media-seek-forward.svg
  icons-dark/actions/32/media-skip-backward.svg
  icons-dark/actions/32/media-skip-forward.svg
  icons/actions/16/media-seek-backward.svg
  icons/actions/16/media-seek-forward.svg
  icons/actions/16/media-skip-backward.svg
  icons/actions/16/media-skip-forward.svg
  icons/actions/22/media-seek-backward.svg
  icons/actions/22/media-seek-forward.svg
  icons/actions/22/media-skip-backward.svg
  icons/actions/22/media-skip-forward.svg
  icons/actions/24/media-seek-backward.svg
  icons/actions/24/media-seek-forward.svg
  icons/actions/24/media-skip-backward.svg
  icons/actions/24/media-skip-forward.svg
  icons/actions/32/media-seek-backward.svg
  icons/actions/32/media-seek-forward.svg
  icons/actions/32/media-skip-backward.svg
  icons/actions/32/media-skip-forward.svg

To: ndavis, #vdg, rooty, ngraham
Cc: ngraham, rooty, kde-frameworks-devel, michaelh, bruns

D19621: ViewPrivate: Make deselection by arrow keys more handy

[loh tar]

loh.tar updated this revision to Diff 53508.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Add autotest

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19621?vs=53501=53508

REVISION DETAIL
  https://phabricator.kde.org/D19621

AFFECTED FILES
  autotests/src/kateview_test.cpp
  autotests/src/kateview_test.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, cullmann, sars

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/50/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Mar 2019 11:47:42 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32825/60375)38%
(17041/44354)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9243/9683)48%
(4344/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8388/14390)51%
(4711/9321)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4353/7987)40%
(1917/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(540/1055)36%
(320/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/36/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Mar 2019 11:45:56 +
 Build duration:
7 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32803/60382)38%
(17022/44357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9243/9683)48%
(4346/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8390/14398)51%
(4715/9324)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4349/7987)40%
(1913/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(540/1055)36%
(320/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/49/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 09 Mar 2019 11:16:12 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32841/60375)38%
(17038/44354)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9243/9683)48%
(4340/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8402/14390)51%
(4711/9321)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4354/7987)40%
(1918/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(541/1055)36%
(321/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Mar 2019 11:14:16 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32804/60382)38%
(17027/44357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9243/9683)48%
(4346/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8390/14398)51%
(4715/9324)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4350/7987)40%
(1914/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(540/1055)36%
(320/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/31/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 09 Mar 2019 09:45:49 +
 Build duration:
1 hr 51 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%