D24959: Add new preferences search icons

[TrickyRicky]

trickyricky26 requested changes to this revision.
trickyricky26 added a comment.
This revision now requires changes to proceed.


  On the technical side, we usually convert everything to paths, and even 
though I can't imagine Qt SVG Renderer would have a problem with `circle`, it 
might be better to convert the background to a path.
  
  As for the design, I think this can be improved. My suggestion would 
basically be to use the magnifying glass from the Kfind icon, which IMO fits 
better with Breeze because of the thinner lines and the longer handle, which 
make the symbol feel more balanced.
  Additionally, maybe you could try adding the Breeze-typical 45° shadow, which 
is usually used in these symbol-on-background icons, although it might not look 
right with the magnifying glass extending in the same direction.
  
  Overall I think this will be a nice addition.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham

D24957: Add new baloo icons

[TrickyRicky]

trickyricky26 added a comment.


  Some of my thoughts on the new preferences-desktop-search icons 
(D24959#554523 ) also apply here: I 
think that lines of the magnifying glass symbol feel a bit too thick for 
Breeze, and IMO the large glass-to-handle ratio doesn't feel quite right, 
although I realize you have to fit that paw symbol in there. Also, this kind of 
icon is a classic candidate for the 45° degree shadow.
  
  I would also try making the paw symbol a bit more simple, perhaps by removing 
the ellipses between the bottom and the claws themselves, in order to make the 
design less visually noisy. Then it might also be possible to make the paw 
smaller in the 32px version.
  
  Maybe we can also come up with a more interesting background than a blue 
circle, which is quite bland, considering this is an application icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[Ahmad Samir]

ahmadsamir added a comment.


  In D24951#554516 , @dfaure wrote:
  
  > A sort model allows to define any sorting criteria you want (see 
QSortFilterProxyModel::lessThan), so this is technically possible: the criteria 
would say "if A is a match and B isn't, then A  I'm not 100% sure that things jumping around while typing is a good idea 
though.
  
  
  
  
  In D24951#554516 , @dfaure wrote:
  
  > A sort model allows to define any sorting criteria you want (see 
QSortFilterProxyModel::lessThan), so this is technically possible: the criteria 
would say "if A is a match and B isn't, then Ahttps://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[David Faure]

dfaure added a comment.


  By "jumping around" I mean that even order can change, not just things being 
added/removed.
  A would be before B, and then you type something, and B jumps before A.
  Or do I misunderstand and this could never happen?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[Nathaniel Graham]

ngraham added a comment.


  In D24951#554516 , @dfaure wrote:
  
  > I'm not 100% sure that things jumping around while typing is a good idea 
though.
  
  
  That's exactly what already happens though, as the list of search narrows 
itself while you type. KRunner does this too. I don't think it's a problem.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[David Faure]

dfaure added a comment.


  A sort model allows to define any sorting criteria you want (see 
QSortFilterProxyModel::lessThan), so this is technically possible: the criteria 
would say "if A is a match and B isn't, then Ahttps://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[Ahmad Samir]

ahmadsamir added a comment.


  In D24951#554485 , @ngraham wrote:
  
  > In D24951#554468 , @ahmadsamir 
wrote:
  >
  > > The user typing 'arc' then pressing Enter, and getting the file opened 
with wireshark is broken behaviour form the user's POV, that's the crux of the 
bug report in question.
  >
  >
  > If the point is to fix just this corner case, maybe we can do so by putting 
exact matches at the top of the list.
  
  
  I don't think that's possible; the proxy sort model doesn't offer a way to 
change the order of the shown results, IIUC, it just filters out/hides non 
matching items and displays what's left.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir added a comment.


  In D24928#553952 , @vkrause wrote:
  
  > The cipher naming stuff looks very fishy though, that's not due to your 
changes though but coming from old KSslCipher code. I'm wondering where the 
ssl_cipher meta data is being consumed? If this is purely used for display, 
maybe let's just replace the entire string in there by QSslCipher::name()?
  
  
  Looking at how ktorrent uses KIO::MetaData: 
https://lxr.kde.org/source/extragear/network/libktorrent/src/tracker/httptracker.cpp#0480
  
  gave me an idea to search for "ssl_cipher" on lxr.k.o, I found no hits at 
all. So nothing uses it in KDE, I don't know about 3rd party users. So maybe we 
just remove the digest method (or the whole sslCipher string), especially since 
cipher.name() is pretty descriptive.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.13 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.13/19/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 26 Oct 2019 21:21:42 +
 Build duration:
4 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 13 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_picFailed: projectroot.autotests.kimageformats_read_hdrFailed: projectroot.autotests.kimageformats_read_kraFailed: projectroot.autotests.kimageformats_read_oraFailed: projectroot.autotests.kimageformats_read_pcxFailed: projectroot.autotests.kimageformats_read_psdFailed: projectroot.autotests.kimageformats_read_rasFailed: projectroot.autotests.kimageformats_read_rgbFailed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_read_xcfFailed: projectroot.autotests.kimageformats_write_pcxFailed: projectroot.autotests.kimageformats_write_rgbFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(1/3)5%
(1/20)5%
(1/20)1%
(37/3921)0%
(3/2238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests33%
(1/3)33%
(1/3)10%
(37/385)2%
(3/134)src.imageformats0%
(0/14)0%
(0/14)0%
(0/3401)0%
(0/2064)tests0%
(0/3)0%
(0/3)0%
(0/135)0%
(0/40)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/16/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 26 Oct 2019 21:21:42 +
 Build duration:
1 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 13 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_picFailed: projectroot.autotests.kimageformats_read_hdrFailed: projectroot.autotests.kimageformats_read_kraFailed: projectroot.autotests.kimageformats_read_oraFailed: projectroot.autotests.kimageformats_read_pcxFailed: projectroot.autotests.kimageformats_read_psdFailed: projectroot.autotests.kimageformats_read_rasFailed: projectroot.autotests.kimageformats_read_rgbFailed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_read_xcfFailed: projectroot.autotests.kimageformats_write_pcxFailed: projectroot.autotests.kimageformats_write_rgbFailed: projectroot.autotests.kimageformats_write_tga

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure added a comment.


  Funnily enough, the 5.39 is irrelevant, since we don't support building with 
older versions of KConfig. But it becomes relevant because we support enabling 
one and not the other, as you mention.
  We could cheat and just s/38/39/ here, it wouldn't harm anyone.
  
  If we limit *_BUILD_DEPRECATED_SINCE to latest, then my build (with that 
variable enabled for kwindowsystem) could break at any time when new things get 
deprecated. But yeah, I'm the 0.1% of people compiling the code, who sets 
EXCLUDE_DEPRECATED_BEFORE_AND_AT, so I can live with that.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Developing an GLFW app that links makes use of KWindowEffects?

[David Faure]

On mercredi 16 octobre 2019 09:30:13 CEST Christian Parpart wrote:
> Hi guys,
> 
> I hope I landed into the right channel (it's many many years ago I did
> stuff with KDE), so I've to apologize in advance, eventually. :-)
> 
> I am developing an OpenGL / GLFW application (for highest platform
> independence and easiest porting efforts). It's basically a terminal
> emulator, and I want the background to be optionally transparent (done) but
> also blurred (done for windows, not linux/mac). I found out, that for KDE's
> konsole, it's not doing it by itself but using
> KWindowEffects::enableBlurBehind(...) instead, which is more or less how
> you do it on Windows 10 too. However, making use of it and linking against
> KF5::WindowSystem tells me that it couldn't find any plugins.
> *org.kde.kwindowsystem: Could not find any platform plugin*

That is "just" a deployment problem.

Did you build KWindowSystem yourself or use a Linux package?
In the first case, does `make install` show a file like
.../plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemX11Plugin.so
?
And if this isn't in a standard location like /usr/lib, did you export 
QT_PLUGIN_PATH to point to that plugins library? (without the kf5/org.[...])

> Also, I highly doubt I can just pump in the X11 `Window` (XID) handle to
> `enableBlurBehind`'s first param, but I couldn't figure how to construct a
> `WId` without fully transforming my program into a full KDE/Qt app.

Well, if you do have a X11 Window ID, I actually believe you can just pass 
that, that's what Qt's WId means, on X11.

> Is there a way without fully converting into KDE app

This sentence, nowadays, doesn't mean what you think it does ;)
This app isn't developed by the KDE community, so it's not a KDE app, by 
definition. You mean "without using other KF5 frameworks", and the answer is 
yes, you can use KWindowSystem without using other KDE Frameworks.

Hope this helps,

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

[David Faure]

dfaure created this revision.
dfaure added reviewers: kossebau, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  kded needs to keep being able to load kded modules that install desktop
  files rather than providing json metadata. Not all kded modules have
  been ported away from that, see e.g. D13360 
 or print-manager.
  
  NO_CHANGELOG

TEST PLAN
  kservice builds

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24974

AFFECTED FILES
  CMakeLists.txt
  src/services/kplugininfo.h

To: dfaure, kossebau, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[Nathaniel Graham]

ngraham added a comment.


  In D24951#554468 , @ahmadsamir 
wrote:
  
  > The user typing 'arc' then pressing Enter, and getting the file opened with 
wireshark is broken behaviour form the user's POV, that's the crux of the bug 
report in question.
  
  
  If the point is to fix just this corner case, maybe we can do so by putting 
exact matches at the top of the list.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[Ahmad Samir]

ahmadsamir added a comment.


  The user typing 'arc' then pressing Enter, and getting the file opened with 
wireshark is broken behaviour form the user's POV, that's the crux of the bug 
report in question.
  
  That combobox uses KCompletion and not having the up/down arrow keys navigate 
through the possible completions in the popup menu, when the mode[1] is 
CompletionPopup or CompletionPopupAuto, would be broken behaviour too, and 
unexpected by the user; e.g. in Dolphin, typing a path, there's popup list with 
possible completions, the arrow keys navigate through that list.
  
  KRunner is a different beast, it can search files, execute commands, invoke 
kcm modules, manage open windows... etc.
  
  Besides, we are talking about a corner case, 9 out of 10 times you'll only 
get 1 match.
  
  [1] 
https://api.kde.org/frameworks/kcompletion/html/classKCompletion.html#a927c284d89e41d976412201b68ca67e9

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24959: Add new preferences search icons

[Alexander Stippich]

astippich added a comment.


  Yes, that is the plan

REPOSITORY
  R266 Breeze Icons

BRANCH
  newSearchIcon

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D24593: Modified breeze shadows

[Nathaniel Graham]

ngraham added a comment.


  Still not working, sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  In D24951#554226 , @ahmadsamir 
wrote:
  
  > In D24951#554138 , @ngraham 
wrote:
  >
  > > Why wouldn't you want the first result chosen when there's more than one 
result? If you enter a search term and get (say) 2 results and the one you want 
to select is the first one, this patch would regress that, no?
  >
  >
  > If there is more than one result, there is no way for the code to know 
which result the user actually wants; please see the test plan for an example 
of when this backfires.
  
  
  Sorry but fixing the issue in the way you're proposing is a UI regression; 
it's just privileging one use case over another (the case where the first item 
is *not* the one you want to launch, vs the case where it is), and does not fix 
the underlying problem.
  
  That underlying problem is that there is no way to use the keyboard to move 
the selection highlight between the results in the list the way, for example, 
KRunner does it: the left and right arrow keys move the insertion point in the 
search field, and the up and down keys navigate through the list of search 
results. That's the way it should be here IMO.
  
  Right now the up and down arrow keys navigate through historical entries in 
the combobox which doesn't really make sense for the use case that this dialog 
supports. KRunner also has a search history but it isn't accessed in this way. 
I think we should just match KRunner's behavior here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  It doesn't compile:
  
/home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:1389:72: error: 
‘QString::QString(const char*)’ is private within this context
 1389 | KRun::runCommand(QStringLiteral("filelight"), directory, 
nullptr, QStringLiteral("/"));
  | 
   ^
  
  Anyway, should use `KRun::runApplication()` for this since that's made for 
launching GUI apps and handling arguments passed to the binary.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Lovely.

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice. So after this, you'll change 
https://cgit.kde.org/systemsettings.git/tree/categories/settings-workspace-search.desktop#n7,
 right?

REPOSITORY
  R266 Breeze Icons

BRANCH
  newSearchIcon

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/51/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 26 Oct 2019 17:42:20 +
 Build duration:
2 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

[David Faure]

dfaure closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a task: T7878: Create or find Icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  deleteNepomuk

REVISION DETAIL
  https://phabricator.kde.org/D24958

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Good with me.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

[David Faure]

dfaure updated this revision to Diff 68798.
dfaure added a comment.


  Revert change to CMakeLists.txt; explain change as comment

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24971?vs=68796=68798

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24971

AFFECTED FILES
  src/lib/kaboutdata.h

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in kstandardaction_p.h:103
> Hm, KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE should not be needed 
> to be used here.
> Does the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT trigger this? If so, IMHO 
> ECMGenerateExportHeader needs to be fixed. Will have a look tomorrow latest.

Ah, KStandardShortcut is from KConfig. Though deprecated only at 5.39 as per 
API dox, so this would need another if/else... welcome to the deprecation 
jungle :)

I start to think that the *_BUILD_DEPRECATED_SINCE should just be limited to 
latest perhaps, given the size of KF modules and their interdependencies.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kossebau wrote in kstandardaction_p.h:103
> Hm, KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE should not be needed 
> to be used here.
> Does the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT trigger this? If so, IMHO 
> ECMGenerateExportHeader needs to be fixed. Will have a look tomorrow latest.

Yes this is triggered by KF_DISABLE*

This is exactly the same issue as the one we just talked about.
SaveOptions is not longer available when using KConfig without deprecated API.
I thought that was what the "DO_NOT_USE" alias was for: internal usage like the 
one here.
The alternative is to make SaveOptions available unconditionally again, as we 
just did with programIconName, but I thought this solution was actually better, 
since it will still prevent apps from using SaveOptions.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kstandardaction_p.h:103
>  #if KCONFIGWIDGETS_BUILD_DEPRECATED_SINCE(5, 38)
> -{ SaveOptions,   KStandardShortcut::SaveOptions, "options_save_options", 
> I18N_NOOP(" Settings"), nullptr, nullptr },
> +{ SaveOptions,   KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE, 
> "options_save_options", I18N_NOOP(" Settings"), nullptr, nullptr },
>  #endif

Hm, KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE should not be needed 
to be used here.
Does the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT trigger this? If so, IMHO 
ECMGenerateExportHeader needs to be fixed. Will have a look tomorrow latest.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:96
>  add_definitions(-DQT_DEPRECATED_WARNINGS_SINCE=0x06)
> +add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00)
>  add_definitions(-DQT_NO_FOREACH)

Given KCOreAddons does not link against other KF modules, this does not make 
sense here.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kaboutdata.h:944
>  
> -#if KCOREADDONS_ENABLE_DEPRECATED_SINCE(5, 2)
> +#if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 2)
>  /**

Possibly best to document why only BUILD, pointing out infrastructure code 
supporting legacy code needs to always see this, unless disabled from build 
explicitly.
To avoid the next person thinking this was a mistake and changing to ENABLE 
again.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure updated this revision to Diff 68797.
dfaure added a comment.


  Keep code for compat. Requires D24971 .

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24965?vs=68789=68797

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24965

AFFECTED FILES
  CMakeLists.txt
  src/kstandardaction.cpp
  src/kstandardaction_p.h

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

[David Faure]

dfaure created this revision.
dfaure added a reviewer: kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  NO_CHANGELOG

TEST PLAN
  Builds, and allows to build kconfigwidgets

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24971

AFFECTED FILES
  CMakeLists.txt
  src/lib/kaboutdata.h

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure added a comment.


  Sorry, you were very clear, I just forgot that the compiler warning comes 
from a different macro :-)

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure added a comment.


  You can do whatever you want in the GUI -- I'll happily step out of that part 
of the discussion --, as long as you don't abuse UDS_SIZE for what it was not 
meant for, thus creating an ambiguous meaning for it.
  
  My suggestion would be to add a UDS_RECURSIVE_SIZE instead.
  The problem with that, however, is that the kioslave can't know if the 
application actually wants the information. So in most cases we would be 
wasting a lot of time for nothing -- even here it's not fully for free.
  One solution would be to use the "details" metadata for this.
  
  - 0 (as set by DeleteJob) means bare minimum (filename and type).
  - 1 isn't used anymore, but it adds uid, gid, atime, mtime, btime
  - 2 is the default, which is the above plus ACL data
  - 3 requests in addition the device and inode number (from kio_file), so that 
DirectorySizeJob can check for hardlinks
  - we could add that 4 means "I want UDS_RECURSIVE_SIZE too".
  
  I don't know if this will be useful in any other kioslave, but at least here 
it would allow skipping this stuff when not needed.
  
  Sample code, like in kio_file and kio_ftp:
  
const QString sDetails = metaData(QLatin1String("details"));
const int details = sDetails.isEmpty() ? 2 : sDetails.toInt();

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  So seems I missed to make clear what I meant, next try :)
  
  The goal is: make clients (e.g. apps) which are still using this method to 
set the app icon aware by a compiler warning that they should port their code 
to use QApplication::setWindowIcon. For that we would keep 
KCOREADDONS_DEPRECATED_VERSION, as it is what sets the warning attribute, if 
asked by given settings.
  
  What we cannot do is to allow making the API invisible to the compiler in 
general, as infrastructure code support such legacy settings always needs to 
access it. So we remove the wrapping with #if/#endif and 
KCOREADDONS_ENABLE_DEPRECATED_SINCE, as that is the one which controls the 
visibility of the API.
  
  And for the very infrastructure code we also need to have a way to not get 
the deprecation warning, as for that using the API is fine still. So we need to 
tell the compiler somehow the deprecation warning in such usage needs to be 
ignored. One could do complicated logic to have the 
KCOREADDONS_DEPRECATED_VERSION care for another macro definition. But for now 
the most simply might be to just tell the compiler in the calling code to 
ignore for that line deprecation warnings.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[David Faure]

dfaure added a comment.


  +1 from me, the reasoning makes sense.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure added a comment.


  Why would I need to push/pop warning, if the method call doesn't trigger any 
warning anymore?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24965#554393 , @dfaure wrote:
  
  > So basically we just use //KF6 TODO REMOVE for programIconName, but still 
use the macro around setProgramIconName? Works for me.
  
  
  Yes, remove the KCOREADDONS_ENABLE_DEPRECATED_SINCE(5, 2), or turn to 
KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 2) for help those who already look into 
building without the feature (and would have to wrap API using code with the 
same condition).
  And wrap API using code like here, to support clients still usng that 
feature, with something along QT_WARNING_PUSH QT_WARNING_POP for the 
deprecations warning.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24960

To: vkrause, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure added a comment.


  So basically we just use //KF6 TODO REMOVE for programIconName, but still use 
the macro around setProgramIconName? Works for me.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24970: Port away from I18N_NOOP2 and KLocalizedString::insertQtDomain

[David Faure]

dfaure created this revision.
dfaure added reviewers: aacid, ilic.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  - Remove duplication of the untranslated (but marked for translation)
  
  string. "Home" is "Home" even after marking for translation, no need to pass
  it twice. Pass the context (so I18NC_NOOP can be used) and discard it.
  
  - Messages.sh covers all of kio, there's no Qt linguist file involved
  
  here.

TEST PLAN
  Builds, and the file places widget looks ok in Dolphin,
  both in English and in French (LC_ALL=fr_FR dolphin).

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24970

AFFECTED FILES
  CMakeLists.txt
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/urifilters/ikws/kuriikwsfilter.cpp
  src/urifilters/ikws/kurisearchfilter.cpp

To: dfaure, aacid, ilic
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21004: [UserMetaData] Shortcut attribute queries for the common case

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R824 Baloo Widgets

BRANCH
  bulk_query

REVISION DETAIL
  https://phabricator.kde.org/D21004

To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame
Cc: hurikhan77, lots0logs, fbampaloukas, domson, ashaposhnikov, astippich, 
spoorun, ngraham, abrahams

D24959: Add new preferences search icons

[Alexander Stippich]

astippich added a comment.


  Correct

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D24965: KConfigWidgets: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  This falls into a category I also saw elsewhere doing all the patches, where 
the same API is used from two sides: the client side, like application code, 
and the serving side, like infrastructure.
  
  While we want to tell the client side, stop using this and for that also 
allow them to disable it, the serving side still needs to access it to support 
the legacy system.
  
  I had some ideas how to support this, though this would complicated all this 
fragile macro logic even more, so not sure this will work out.
  
  The other option is to remove the diabling wrappers around the 
programIconName API, so one can still use KF_DISABLE_DEPRECATED_BEFORE_AND_AT 
for the rests of the API. Actually I had done that in the other places where I 
came across that category. I would be in favour to do the same for 
programIconName. What do you think?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24968: Port away from KF5 deprecated API: use setWindowIcon

[David Faure]

dfaure closed this revision.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D24968

To: dfaure, vkrause, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24968: Port away from KF5 deprecated API: use setWindowIcon

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24968

To: dfaure, vkrause, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure added a comment.


  The goal is to set KF_DISABLE_DEPRECATED_BEFORE_AND_AT, so this isn't just 
about a warning, it's about API that no longer exists.
  But I guess we can't do that then, if we want to preserve compatible behavior 
until KF6...

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure added a reviewer: vkrause.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24968: Port away from KF5 deprecated API: use setWindowIcon

[David Faure]

dfaure created this revision.
dfaure added reviewers: vkrause, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  Restarted kwalletd5, made it open a wallet (via kwalletmanager),
  the dialog that pops belongs to kwalletd5 and has a nice icon.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24968

AFFECTED FILES
  CMakeLists.txt
  src/runtime/kwalletd/main.cpp

To: dfaure, vkrause, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24966: KXmlGui: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  For backward-compatibility, we want to support this still, no? See 
D24965#554354 

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24966

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  While being deprecated, there might be code still using it, and you are 
killing support for that now, which is backwards-incompatibel.
  
  IMHO the support should be kept. And we want to rather have a generic way to 
disable the warning here (still TODO to have generic macros for this made 
available as well by the ECMGenerateExportHeader).

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  deleteNepomuk

REVISION DETAIL
  https://phabricator.kde.org/D24958

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

[Stefan Brüns]

bruns added a comment.


  LGTM

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24966: KXmlGui: port away from KF5 deprecated API

[David Faure]

dfaure created this revision.
dfaure added reviewers: kossebau, elvisangelaccio, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  KAboutData::setProgramIconName is deprecated and says
  "Use QApplication::windowIcon", so I removed the code
  that reads from programIconName() as fallback.

TEST PLAN
  Builds

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24966

AFFECTED FILES
  CMakeLists.txt
  src/kaboutapplicationdialog.cpp

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Stefan Brüns]

bruns added a comment.


  Thats the "top level" icon, with "Krunner" and "File Search" (aka Baloo) 
below, correct?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D24965: KConfigWidgets: port away from KF5 deprecated API

[David Faure]

dfaure created this revision.
dfaure added reviewers: kossebau, elvisangelaccio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  KAboutData::setProgramIconName is deprecated and says
  "Use QApplication::windowIcon", so I removed the code
  that reads from programIconName()

TEST PLAN
  Builds

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24965

AFFECTED FILES
  CMakeLists.txt
  src/kstandardaction.cpp
  src/kstandardaction_p.h

To: dfaure, kossebau, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[David Redondo]

davidre added a comment.


  For reference here is the relevant part in the kcm
  
https://cgit.kde.org/plasma-desktop.git/tree/kcms/keys/kglobalshortcutseditor.cpp#n176

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D24593#552915 , @ngraham wrote:
  
  > Needs a rebase on master. It doesn't apply for me.
  
  
  Does it apply now? If not, I messed up something and I will just reset to 
master and add the svgs again.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 68788.
niccolove added a comment.


  Rebase on master - test

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=68626=68788

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24956: Consider desktop files with NoDisplay attribute

[Méven Car]

meven added a comment.


  In D24956#554190 , @davidre wrote:
  
  > I think you have also to check the the kcm as i also saw some `nodisplay` 
there.
  >  Also it seems kglobalaccel uses nodisplay when a component is disabled. 
https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n144
  
  
  It should probably use a custom field in the desktop file like 
X-KDE-Shortcuts-disable=true or similiar.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven added a comment.


  In D24773#551497 , @ngraham wrote:
  
  > In D24773#551245 , @meven wrote:
  >
  > > I would argue that "Disk space usage" and "Size" might be confusing to 
users. A folder size is the size of his content idiomatically.
  > >  That is our current usage of Size field for folders that is weird : My 
Image folder Size is "42 elements".
  > >  That is a paper cut that all new Plasma users have to learn "Size for 
folders is a content description" : not very intuitive.
  > >  We may want to in fact rename this field for folders to "Content" and 
keep Size for actual disk usage size (except in details view Size column of 
course).
  >
  >
  > Personally I would prefer it if we could actually calculate the total of a 
folder's contents: https://bugs.kde.org/show_bug.cgi?id=158090
  >
  > I tried to do this once and found that it was possible, but would need a 
lot of work to ensure adequate performance, and probably a lot of caching. I 
come from the macOS world where this is implemented and has no appreciable 
performance penalty whatsoever so I know it's possible.
  >
  > However this is probably unrelated to the current patch.
  >
  > Regarding this patch, I think the "Size" field for the trash should always 
show the total on-disk size of what's in the trash, regardless of the above, 
because the question that the user is looking to answer is, "How much space am 
I going to get back if I empty the trash right now?" For that, we need to 
always show the on-disk size.
  
  
  @dfaure any feedback ?
  Others maybe ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68785.
meven added a comment.


  Formatting

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68784=68785

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24752: WIP: Use a separate worker thread to run the actual deletion of files

[Méven Car]

meven abandoned this revision.
meven added a comment.


  In favor of D24962 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24752

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven retitled this revision from "WIP Ues a separate worker thread to run 
actual IO operation" to "WIP [DeleteJob] Use a separate worker thread to run 
actual IO operation".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: WIP Ues a separate worker thread to run actual IO operation

[Méven Car]

meven created this revision.
meven added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Part of T11627 

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24931: Port KSSLD internals from KSslError to QSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24931

To: vkrause, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24961: Port to the QSslError variant of KSslInfoDialog

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24961

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24961: Port to the QSslError variant of KSslInfoDialog

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24961

AFFECTED FILES
  src/widgets/sslui.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

[Volker Krause]

vkrause added a comment.


  In D24892#554048 , @kossebau wrote:
  
  > In D24892#553597 , @vkrause 
wrote:
  >
  > > In D24892#552838 , @kossebau 
wrote:
  > >
  > > > Looks good. Perfect would be if you tested KIconThemes  with 
EXCLUDE_DEPRECATED_BEFORE_AND_AT set to hexnumber(5.64.0), to see if there is 
no internal usage still happening, like with autotests which might need to 
support such a build with KICONTHEMES_ENABLE_DEPRECATED_SINCE (ENABLE variant, 
as external to lib).
  > >
  > >
  > > Assuming I used this correctly (setting EXCLUDE_DEPRECATED_BEFORE_AND_AT 
to 054000)
  >
  >
  > Hm, guess the "default:0" confuses people, EXCLUDE_DEPRECATED_BEFORE_AND_AT 
would be set as string in majpr.minor.patch format ("0" & "CURRENT" are special 
cases). That is documented on 
https://api.kde.org/ecm/module/ECMGenerateExportHeader.html but seemingly that 
is too far away, so will add to the option description text.
  
  
  "default:0" is not what confused me, but `EXCLUDE_DEPRECATED_BEFORE_AND_AT 
set to hexnumber(5.64.0)` in your original statement ;-)
  
  >> this doesn't build independent of assignIconsToContextMenu, due to the 
Q_ENUM code generated for KIconLoader still referencing the deprecated 
FileSystem enum element?
  > 
  > Building with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.8.0, 5.0.0 & 
CURRENT, to cover before & after versions, the build does not fail here.
  
  Doing a clean build and setting EXCLUDE_DEPREACTED_BEFORE_AND_AT at the 
*first* cmake run makes it work here reliably too.
  
  So, to get back to the original question: yes, this patch fixes the build :)

INLINE COMMENTS

> kossebau wrote in kicontheme.h:292
> Some API deprecated staying because porting away is not easy to do should be 
> the exception though, no? 
> I would rather flag only such API elements with a comment once it is found 
> out in real world that porting is more hard than anticipated.
> But at the point of time of deprecation, the whole idea of the warnings being 
> inserted into the compiler is to have people stop using it, so it can be 
> removed at the next occasion, no? Otherwise the whole warning is harmful 
> noise making people ignore warnings.
> 
> And ideally the concept of deprecated-but-might-stay should be codified 
> ideally in the macros, so the compiler can be taught to do what is wanted.

Going forward certainly yes. What I have doubts about in this regard are the 
things that got deprecated in the past, before we had clear guidelines for this.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24892

To: vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

[Volker Krause]

vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24892

To: vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

[Volker Krause]

vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24960

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Qt does set icons itself nowadays, so assignIconToContextMenu got
  deprecated.

REPOSITORY
  R310 KTextWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24960

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/widgets/ktextedit.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Alexander Stippich]

astippich added a comment.


  F7673429: preferences-desktop-search.svg.png 

  Basically the icon from D24957  without 
the paw

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: VDG, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Add a new icon for usage with the system-settings "search" category,
  which currently uses the baloo icon

REPOSITORY
  R266 Breeze Icons

BRANCH
  newSearchIcon

REVISION DETAIL
  https://phabricator.kde.org/D24959

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-search.svg
  icons/preferences/32/preferences-desktop-search.svg

To: astippich, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

[Alexander Stippich]

astippich added a comment.


  Before:
  F7673421: test.png 
  which is basically a copy of the kfind icon

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[Ahmad Samir]

ahmadsamir added a comment.


  In D24951#554138 , @ngraham wrote:
  
  > Why wouldn't you want the first result chosen when there's more than one 
result? If you enter a search term and get (say) 2 results and the one you want 
to select is the first one, this patch would regress that, no?
  
  
  If there is more than one result, there is no way for the code to know which 
result the user actually wants; please see the test plan for an example of when 
this backfires.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24958: Delete nepomuk icon

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  It's long gone, and is just a symlink to the
  preference-desktop-baloo icon

REPOSITORY
  R266 Breeze Icons

BRANCH
  deleteNepomuk

REVISION DETAIL
  https://phabricator.kde.org/D24958

AFFECTED FILES
  icons-dark/preferences/32/nepomuk.svg
  icons/preferences/32/nepomuk.svg

To: astippich, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

[Alexander Stippich]

astippich added a comment.


  F7673101: baloo48.png 
  
  F7673103: baloo32.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: VDG, ngraham, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Add new baloo 48px icon and update the preference-desktop-baloo
  icon to the same style.
  Discussed in T7878 

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

AFFECTED FILES
  icons-dark/apps/48/baloo.svg
  icons-dark/preferences/32/preferences-desktop-baloo.svg
  icons/apps/48/baloo.svg
  icons/preferences/32/preferences-desktop-baloo.svg

To: astippich, #vdg, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[David Redondo]

davidre added a comment.


  I think you have also to check the the kcm as i also saw some `nodisplay` 
there.
  Also it seems kglobalaccel uses nodisplay when a component is disabled. 
https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n144

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

[Laurent Montel]

mlaurent added a comment.


  Ok thanks.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: mlaurent, dfaure, ilic
Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven added a comment.


  In D24773#551497 , @ngraham wrote:
  
  > In D24773#551245 , @meven wrote:
  >
  > > I would argue that "Disk space usage" and "Size" might be confusing to 
users. A folder size is the size of his content idiomatically.
  > >  That is our current usage of Size field for folders that is weird : My 
Image folder Size is "42 elements".
  > >  That is a paper cut that all new Plasma users have to learn "Size for 
folders is a content description" : not very intuitive.
  > >  We may want to in fact rename this field for folders to "Content" and 
keep Size for actual disk usage size (except in details view Size column of 
course).
  >
  >
  > Personally I would prefer it if we could actually calculate the total of a 
folder's contents: https://bugs.kde.org/show_bug.cgi?id=158090
  >
  > I tried to do this once and found that it was possible, but would need a 
lot of work to ensure adequate performance, and probably a lot of caching. I 
come from the macOS world where this is implemented and has no appreciable 
performance penalty whatsoever so I know it's possible.
  >
  > However this is probably unrelated to the current patch.
  
  
  Agreed
  
  > Regarding this patch, I think the "Size" field for the trash should always 
show the total on-disk size of what's in the trash, regardless of the above, 
because the question that the user is looking to answer is, "How much space am 
I going to get back if I empty the trash right now?" For that, we need to 
always show the on-disk size.
  
  Agreed
  
  Your thought @dfaure ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[Méven Car]

meven added a comment.


  This was added previously in D2103 

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D24956

To: meven, mart, #plasma, fvogt, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

[Méven Car]

meven created this revision.
meven added reviewers: mart, Plasma, fvogt, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  >   NoDisplay means "this application exists, but don't display it in the 
menus". This can be useful to e.g. associate this application with MIME types, 
so that it gets launched from a file manager (or other apps), without having a 
menu entry for it (there are tons of good reasons for this, including e.g. the 
netscape -remote, or kfmclient openURL kind of stuff). 
  
  
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
  
  NoDisplay specify to ignore desktop files with no Display in menus. It 
specifically states that mimetype are a case where an app might be associated 
with one, but not shown in the menus.
  Shortcuts should be treated the same as mimetype association.
  
  To allow cases such as Krunner, where the app won't be in the menu but still 
needs shortcuts.
  Related: D24857 

REPOSITORY
  R268 KGlobalAccel

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24956

AFFECTED FILES
  src/runtime/globalshortcutsregistry.cpp

To: meven, mart, #plasma, fvogt, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2a36922a8cc4: Add folder-recent, extend hand of clock in 
folder-temp (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24652?vs=67939=68773

REVISION DETAIL
  https://phabricator.kde.org/D24652

AFFECTED FILES
  icons-dark/places/32/folder-recent.svg
  icons-dark/places/32/folder-temp.svg
  icons-dark/places/64/folder-recent.svg
  icons/places/32/folder-recent.svg
  icons/places/32/folder-temp.svg
  icons/places/64/folder-recent.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

[Noah Davis]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:8732c6a99ad1: Fill middle mouse button area (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24625?vs=67877=68774

REVISION DETAIL
  https://phabricator.kde.org/D24625

AFFECTED FILES
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-middle.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns