D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R269:d08e77529bd1: endl is Qt:: namespaced in qt5.15. Port to 
\n and flush when QTextStream is not… (authored by mlaurent).

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26320?vs=72512=73177

REVISION DETAIL
  https://phabricator.kde.org/D26320

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/XmlGenerator.cpp

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26484: Popup menu again to reposition it

[Tranter Madi]

trmdi retitled this revision from "Add a new parameter for delaying showing 
menu" to "Popup menu again to reposition it".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi removed a dependent revision: D26514: Delay popup for containments.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi updated this revision to Diff 73175.
trmdi added a comment.


  - Simplify the approach

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26484?vs=73114=73175

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26484

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25490: Remove legacy plugin loading code

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

BRANCH
  service

REVISION DETAIL
  https://phabricator.kde.org/D25490

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

[Nicolas Fella]

nicolasfella marked an inline comment as not done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

[Nicolas Fella]

nicolasfella updated this revision to Diff 73172.
nicolasfella marked 6 inline comments as done.
nicolasfella added a comment.


  - More comments

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26448?vs=73170=73172

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

AFFECTED FILES
  src/CMakeLists.txt
  src/krecentfilesmenu.cpp
  src/krecentfilesmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

[Nicolas Fella]

nicolasfella updated this revision to Diff 73170.
nicolasfella marked 4 inline comments as done.
nicolasfella added a comment.


  - Address comments

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26448?vs=72928=73170

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

AFFECTED FILES
  src/CMakeLists.txt
  src/krecentfilesmenu.cpp
  src/krecentfilesmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

Re: Fwd: KDE CI: Administration » Dependency Build Frameworks kf5-qt5 SUSEQt5.12 - Build # 66 - Still Failing!

[Ben Cooksley]

On Fri, Jan 10, 2020 at 9:39 AM Friedrich W. H. Kossebau
 wrote:
>
> Am Donnerstag, 9. Januar 2020, 21:10:23 CET schrieb Ben Cooksley:
> > Hi all,
> >
> > Please see the below Dependency Build failure, which happens on both our Qt
> > 5.12 and Qt 5.13 images.
> > It appears that for reasons unknown, the QCH generation for KDeclarative
> > fails in our newly rebuilt images (it also seems that CMake doesn't pick
> > this up, as it fails at install rather than build time, but that is a
> > separate issue I suspect)
> >
> > Any ideas?
>
> It's due to a bug in doxygen: https://github.com/doxygen/doxygen/issues/7248

Sigh.

>
> Sadly the broken version of doxygen now arrived in opensuse TW, and thus on
> CI.
>
> Master branch of doxygen has a fix merged recently: https://github.com/
> doxygen/doxygen/pull/7250
>
> Going to poke openSUSE devs to include the fix next, like other distros might
> have done already (all those packaging QCH for KF themselves already, which
> sadly openSUSE devs so far have not got to... I need to poke harder :) ).
>
> Proposal would be to unset BUILD_QCH with kdeclarative for now temporarily,
> building own doxygen package might be more work.

I've now done this, and have initiated the Dependency Build jobs.

>
> Cheers
> Friedrich
>
>

Cheers,
Ben

[sysadmin/ci-tooling] build-specs/Frameworks: Don't build QCH files for KDeclarative due to breakage in Doxygen.

[Ben Cooksley]

Git commit a193f9562032cfdb4f338c996ab2c7519a516ecf by Ben Cooksley.
Committed on 10/01/2020 at 00:09.
Pushed by bcooksley into branch 'master'.

Don't build QCH files for KDeclarative due to breakage in Doxygen.

CCMAIL: kde-frameworks-devel@kde.org

A  +2-0build-specs/Frameworks/kdeclarative.yaml

https://invent.kde.org/sysadmin/ci-tooling/commit/a193f9562032cfdb4f338c996ab2c7519a516ecf

diff --git a/build-specs/Frameworks/kdeclarative.yaml 
b/build-specs/Frameworks/kdeclarative.yaml
new file mode 100644
index 000..6e6d08b
--- /dev/null
+++ b/build-specs/Frameworks/kdeclarative.yaml
@@ -0,0 +1,2 @@
+"kf5-qt5":
+  "cmake-options": ""

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D26555#591132 , @davidre wrote:
  
  > In D26555#591131 , 
@The-Feren-OS-Dev wrote:
  >
  > > In D26555#591126 , @davidre 
wrote:
  > >
  > > > I still think the proper fix was to investigate why the widget explorer 
didn't show an icon instead of randomly changing the icon it uses which can 
have potential impact on other themes
  > >
  > >
  > > This is a fix to it happening in real-time in Plasmashell me making this 
patch is not related to a potential issue with Widget Explorer. However, I 
could easily edit this patch to retain the nepomuk icons alongside the renamed 
ones if needed.
  >
  >
  > But if I understood it right this patch is a reaction to an issue caused by 
changing the icon which was caused by the widget explorer issue?
  
  
  I honestly haven't heard about the potential Widget Factory issue side of it, 
but this patch was definitely made because the Milou Plasmoid changed its icon 
from 'nepomuk' to 'search'.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[David Redondo]

davidre added a comment.


  In D26555#591131 , 
@The-Feren-OS-Dev wrote:
  
  > In D26555#591126 , @davidre 
wrote:
  >
  > > I still think the proper fix was to investigate why the widget explorer 
didn't show an icon instead of randomly changing the icon it uses which can 
have potential impact on other themes
  >
  >
  > This is a fix to it happening in real-time in Plasmashell me making this 
patch is not related to a potential issue with Widget Explorer. However, I 
could easily edit this patch to retain the nepomuk icons alongside the renamed 
ones if needed.
  
  
  But if I understood it right this patch is a reaction to an issue caused by 
changing the icon which was caused by the widget explorer issue?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D26555#591126 , @davidre wrote:
  
  > I still think the proper fix was to investigate why the widget explorer 
didn't show an icon instead of randomly changing the icon it uses which can 
have potential impact on other themes
  
  
  This is a fix to it happening in real-time in Plasmashell me making this 
patch is not related to a potential issue with Widget Explorer. However, I 
could easily edit this patch to retain the nepomuk icons alongside the renamed 
ones if needed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25653: [bookmarksmenu] Improve variable name

[Nicolas Fella]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:78cbabc2d675: [bookmarksmenu] Improve variable name 
(authored by nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25653?vs=70673=73162#toc

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25653?vs=70673=73162

REVISION DETAIL
  https://phabricator.kde.org/D25653

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[David Redondo]

davidre added a comment.


  I still think the proper fix was to investigate why the widget explorer 
didn't show an icon instead of randomly changing the icon it uses which can 
have potential impact on other themes

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25490: Remove legacy plugin loading code

[Nicolas Fella]

nicolasfella added a comment.


  Ping?

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25490

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev retitled this revision from "Rename nepomuk Plasma Theme icons 
to 'search'" to "Rename 'nepomuk' Plasma Theme icons to 'search'".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename nepomuk Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
The-Feren-OS-Dev requested review of this revision.

REVISION SUMMARY
  BUG: 416072
  
  Since the Milou/Search applet changed its icon from 'nepomuk' to 'search', 
the Breeze and Air/Oxygen Plasma Themes no longer theme that Plasmoid icon. 
This patch fixes that by renaming the themed icons to theme the Milou Plasmoid 
once more.

TEST PLAN
  1. Apply one of the Plasma Theme affected by this patch once patched
  
  2. Use a non-Breeze icon set that would make the 'search' icon pop-out 
style-wise
  
  3. Add the Milou/Search Plasmoid to a panel if not already added
  
  4. It should now use the Plasma Themed icon instead of the icon set's icon 
for 'search' on that Plasmoid

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

AFFECTED FILES
  src/desktoptheme/air/icons/nepomuk.svg
  src/desktoptheme/air/icons/search.svg
  src/desktoptheme/breeze/icons/nepomuk.svg
  src/desktoptheme/breeze/icons/search.svg

To: The-Feren-OS-Dev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25655: Remove outdated comments

[Nicolas Fella]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:b8c2e78e371c: Remove outdated comments (authored by 
nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25655?vs=70675=73159

REVISION DETAIL
  https://phabricator.kde.org/D25655

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag updated this revision to Diff 73158.
zzag added a comment.


  Build with older versions of glibc. See D26553 


REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24629?vs=72993=73158

BRANCH
  kclockskewnotifier

REVISION DETAIL
  https://phabricator.kde.org/D24629

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/clock/kclockskewnotifier.cpp
  src/lib/clock/kclockskewnotifier.h
  src/lib/clock/kclockskewnotifierengine.cpp
  src/lib/clock/kclockskewnotifierengine_linux.cpp
  src/lib/clock/kclockskewnotifierengine_linux_p.h
  src/lib/clock/kclockskewnotifierengine_p.h

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

Re: Fwd: KDE CI: Administration » Dependency Build Frameworks kf5-qt5 SUSEQt5.12 - Build # 66 - Still Failing!

[Friedrich W. H. Kossebau]

Am Donnerstag, 9. Januar 2020, 21:10:23 CET schrieb Ben Cooksley:
> Hi all,
> 
> Please see the below Dependency Build failure, which happens on both our Qt
> 5.12 and Qt 5.13 images.
> It appears that for reasons unknown, the QCH generation for KDeclarative
> fails in our newly rebuilt images (it also seems that CMake doesn't pick
> this up, as it fails at install rather than build time, but that is a
> separate issue I suspect)
> 
> Any ideas?

It's due to a bug in doxygen: https://github.com/doxygen/doxygen/issues/7248

Sadly the broken version of doxygen now arrived in opensuse TW, and thus on 
CI.

Master branch of doxygen has a fix merged recently: https://github.com/
doxygen/doxygen/pull/7250

Going to poke openSUSE devs to include the fix next, like other distros might 
have done already (all those packaging QCH for KF themselves already, which 
sadly openSUSE devs so far have not got to... I need to poke harder :) ).

Proposal would be to unset BUILD_QCH with kdeclarative for now temporarily, 
building own doxygen package might be more work.

Cheers
Friedrich

Fwd: KDE CI: Administration » Dependency Build Frameworks kf5-qt5 SUSEQt5.12 - Build # 66 - Still Failing!

[Ben Cooksley]

Hi all,

Please see the below Dependency Build failure, which happens on both our Qt
5.12 and Qt 5.13 images.
It appears that for reasons unknown, the QCH generation for KDeclarative
fails in our newly rebuilt images (it also seems that CMake doesn't pick
this up, as it fails at install rather than build time, but that is a
separate issue I suspect)

Any ideas?

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Fri, Jan 10, 2020 at 7:50 AM
Subject: KDE CI: Administration » Dependency Build Frameworks kf5-qt5
SUSEQt5.12 - Build # 66 - Still Failing!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Frameworks%20kf5-qt5%20SUSEQt5.12/66/
Project: Dependency Build Frameworks kf5-qt5 SUSEQt5.12
Date of build: Thu, 09 Jan 2020 17:28:00 +
Build duration: 1 hr 22 min and counting
* CONSOLE OUTPUT *
[...truncated 59836 lines...]
[2020-01-09T18:49:47.894Z] [ 84%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/eventgenerator.cpp.o
[2020-01-09T18:49:49.265Z] [ 85%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/mimedatabase.cpp.o
[2020-01-09T18:49:50.195Z] [ 86%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/kcmshell.cpp.o
[2020-01-09T18:49:51.563Z] [ 87%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/icondialog.cpp.o
[2020-01-09T18:49:52.493Z] [ 88%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/plotter.cpp.o
[2020-01-09T18:49:54.385Z] [ 89%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/mouseeventlistener.cpp.o
[2020-01-09T18:49:55.752Z] [ 90%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/fallbacktaphandler.cpp.o
[2020-01-09T18:49:56.678Z] [ 91%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/qiconitem.cpp.o
[2020-01-09T18:49:57.616Z] [ 92%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/kquickcontrolsaddonsplugin.cpp.o
[2020-01-09T18:49:57.616Z] [ 94%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/qpixmapitem.cpp.o
[2020-01-09T18:49:57.616Z] [ 94%] Building CXX object
src/qmlcontrols/kquickcontrolsaddons/CMakeFiles/kquickcontrolsaddonsplugin.dir/qimageitem.cpp.o
[2020-01-09T18:50:00.161Z] [ 95%] Linking CXX shared library
../../../bin/libkquickcontrolsaddonsplugin.so
[2020-01-09T18:50:01.093Z] [ 95%] Built target kquickcontrolsaddonsplugin
[2020-01-09T18:50:01.093Z] Scanning dependencies of target kcoreaddonsplugin
[2020-01-09T18:50:01.093Z] [ 96%] Building CXX object
src/qmlcontrols/kcoreaddons/CMakeFiles/kcoreaddonsplugin.dir/kcoreaddonsplugin.cpp.o
[2020-01-09T18:50:01.093Z] [ 97%] Building CXX object
src/qmlcontrols/kcoreaddons/CMakeFiles/kcoreaddonsplugin.dir/kcoreaddonsplugin_autogen/mocs_compilation.cpp.o
[2020-01-09T18:50:01.093Z] [ 97%] Building CXX object
src/qmlcontrols/kcoreaddons/CMakeFiles/kcoreaddonsplugin.dir/formats.cpp.o
[2020-01-09T18:50:03.625Z] [ 98%] Building CXX object
src/qmlcontrols/kcoreaddons/CMakeFiles/kcoreaddonsplugin.dir/kuserproxy.cpp.o
[2020-01-09T18:50:04.993Z] [100%] Linking CXX shared library
../../../bin/libkcoreaddonsplugin.so
[2020-01-09T18:50:05.927Z] [100%] Built target kcoreaddonsplugin
[2020-01-09T18:50:06.184Z] [ 0%] Built target KF5Package_QCH
[2020-01-09T18:50:06.184Z] [ 1%] Automatic MOC for target kwindowsystem
[2020-01-09T18:50:06.441Z] [ 1%] Built target kwindowsystem_autogen
[2020-01-09T18:50:06.441Z] [ 2%] Automatic MOC for target kconfigplugin
[2020-01-09T18:50:06.441Z] [ 2%] Built target kconfigplugin_autogen
[2020-01-09T18:50:06.441Z] [ 3%] Automatic MOC for target KF5CalendarEvents
[2020-01-09T18:50:06.441Z] [ 3%] Built target KF5CalendarEvents_autogen
[2020-01-09T18:50:06.441Z] [ 4%] Automatic MOC for target
fullmodelaccesstest
[2020-01-09T18:50:06.699Z] [ 4%] Built target fullmodelaccesstest_autogen
[2020-01-09T18:50:06.699Z] [ 5%] Automatic MOC for target qimageitemtest
[2020-01-09T18:50:06.699Z] [ 5%] Built target qimageitemtest_autogen
[2020-01-09T18:50:06.699Z] [ 9%] Built target kwindowsystem
[2020-01-09T18:50:06.699Z] [ 13%] Built target kconfigplugin
[2020-01-09T18:50:06.699Z] [ 16%] Built target KF5CalendarEvents
[2020-01-09T18:50:06.699Z] [ 20%] Built target fullmodelaccesstest
[2020-01-09T18:50:06.699Z] [ 23%] Built target qimageitemtest
[2020-01-09T18:50:06.699Z] [ 24%] Automatic MOC for target kio
[2020-01-09T18:50:06.956Z] [ 24%] Built target kio_autogen
[2020-01-09T18:50:06.956Z] [ 25%] Automatic MOC for target kcoreaddonsplugin
[2020-01-09T18:50:06.956Z] [ 25%] Built target kcoreaddonsplugin_autogen
[2020-01-09T18:50:06.956Z] [ 29%] Built target kio

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a subscriber: broulik.
ndavis added a comment.


  In D25814#591053 , @ngraham wrote:
  
  > I wonder if a path forward is to move this option into Breeze itself and 
keep it out of the color scheme. We would add an option for "dark separators 
when using a dark color scheme" in the super hidden Breeze settings window.
  
  
  Hugo did suggest that. Although @broulik was just mentioning in the VDG chat 
that QML can't reuse the color because it's defined in Breeze and not part of 
the colorscheme.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, cfeck, 
hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Nathaniel Graham]

ngraham added a comment.


  I wonder if a path forward is to move this option into Breeze itself and keep 
it out of the color scheme. We would add an option for "dark separators when 
using a dark color scheme" in the super hidden Breeze settings window.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: manueljlin, alexde, ngraham, davidedmundson, filipf, cfeck, 
hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26484: Add a new parameter for delaying showing menu

[Tranter Madi]

trmdi planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ksortfilterproxymodel.cpp:101
> I'm not sure your comments are still valid, we switched to using the 
> superclass QSortFilterProxyModel's methods, and don't shadow that part here.

Right, I was looking at an old revision of this diff. Sorry about the noise.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: ahmadsamir, broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in ksortfilterproxymodel.cpp:101
> In setFilterRegExp(), 
> QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression &) is 
> used, so IIUC here it should be :
> QSortFilterProxyModel::filterRegularExpression().pattern()

I'm not sure your comments are still valid, we switched to using the superclass 
QSortFilterProxyModel's methods, and don't shadow that part here.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: ahmadsamir, broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> ksortfilterproxymodel.cpp:101
> +{
> +return QSortFilterProxyModel::filterRegExp().pattern();
> +}

In setFilterRegExp(), 
QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression &) is 
used, so IIUC here it should be :
QSortFilterProxyModel::filterRegularExpression().pattern()

> ksortfilterproxymodel.h:103
> +
> +void setFilterRegExp(const QString );
> +QString filterRegExp() const;

Hello. Since you're using QRegularExpression, maybe rename to setFilterRegex() 
or setFitlerRegularExpression() (the latter matches QSortFilterProxyModel 
naming schema) to avoid QRegExp vs QRegularExpression confusion?

(Another pro for renaming setFilterRegExp() to setFilterRegularExpression()).

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: ahmadsamir, broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26540: Consistency: colored selected buttons

[Marco Martin]

mart added a comment.


  In D26540#590924 , @davidedmundson 
wrote:
  
  > Can you update tests/components/button.qml   tests/components/button3.qml
  >
  > just a button with "focus: true" and some label that says "this should be 
highlighted on load"
  
  
  done post landing

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26540

To: mart, #plasma, #vdg, #goal_consistency, ngraham
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26540: Consistency: colored selected buttons

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1d6870b15624: Consistency: colored selected buttons 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26540?vs=73122=73138

REVISION DETAIL
  https://phabricator.kde.org/D26540

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmastyle/ButtonStyle.qml
  src/desktoptheme/breeze/widgets/button.svg

To: mart, #plasma, #vdg, #goal_consistency, ngraham
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26540: Consistency: colored selected buttons

[David Edmundson]

davidedmundson added a comment.


  Can you update tests/components/button.qml   tests/components/button3.qml
  
  just a button with "focus: true" and some label that says "this should be 
highlighted on load"

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/bluebutton

REVISION DETAIL
  https://phabricator.kde.org/D26540

To: mart, #plasma, #vdg, #goal_consistency, ngraham
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26540: Consistency: colored selected buttons

[Marco Martin]

mart added a comment.


  In D26540#590892 , @ngraham wrote:
  
  > +1 for consistency, definitely. One thing to note maybe for a future patch 
is that the focus behaviors is still a bit inconsistent with the desktop style: 
Clicking on a button doesn't move keyboard focus there like it does for widgets 
and qqc2 desktop style.
  
  
  that's a qqc1 issue i think

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/bluebutton

REVISION DETAIL
  https://phabricator.kde.org/D26540

To: mart, #plasma, #vdg, #goal_consistency, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26540: Consistency: colored selected buttons

[Nathaniel Graham]

ngraham added a reviewer: Goal: Consistency.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 for consistency, definitely. One thing to note maybe for a future patch is 
that the focus behaviors is still a bit inconsistent with the desktop style: 
Clicking on a button doesn't move keyboard focus there like it does for widgets 
and qqc2 desktop style.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/bluebutton

REVISION DETAIL
  https://phabricator.kde.org/D26540

To: mart, #plasma, #vdg, #goal_consistency, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

[Marco Martin]

mart added a comment.


  that depends how heavy the load() implementation is...
  
  both ways are not optimal..
  this behavior comes from KCModule, where the module nevel loads itself and a 
load() must be called from outside.
  
  here may be worth doing that even if it's two loads as would avoid a binding 
reevaluation. othe the other hand.. a config read more, hmmm

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26524

To: apol, #plasma, #frameworks
Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

[David Edmundson]

davidedmundson added a comment.


  I kinda see what you're saying, I don't understand why we currently do 
anything on showEvent()
  
  But now we're going to call load() twice, which doesn't sound very optimal.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26524

To: apol, #plasma, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 269 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/269/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 09 Jan 2020 14:18:26 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34733/62007)40%
(17598/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9685/10144)47%
(4507/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8689/14613)51%
(4492/8855)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4686/8323)43%
(2071/4802)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)53%
(667/1260)37%
(363/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 261 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/261/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 09 Jan 2020 14:18:27 +
 Build duration:
8 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

[Kevin Funk]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:27271405f408: SlaveBase::dispatchLoop: Fix timeout 
calculation (authored by Julien Goodwin jgood...@studio442.com.au, 
committed by kfunk).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26364?vs=72610=73129

REVISION DETAIL
  https://phabricator.kde.org/D26364

AFFECTED FILES
  src/core/slavebase.cpp

To: kfunk, chinmoyr, davidedmundson, dfaure, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

leinir added a dependent revision: D26544: [WIP] Switch the Plasma Desktop KCMs 
to using KNewStuffQuick.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

leinir added reviewers: Frameworks, Plasma, ngraham, broulik, mart.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This patch changes the previous naive approach to a more elaborate,
  QQmlListProperty based one. It further introduces a QObject based
  wrapper EntryInternal, in preparation for refactoring for KF6.
  
  The rationale for this approach (rather than e.g. using a model)
  is that the approach makes for the simplest possible porting from
  the QWidget based methods.
  
  Add a QObject wrapper for EntryInternal
  
  We can't reasonably change EntryInternal to a QObject at the moment,
  as that would make the assumptions about how it's used throughout
  the codebase not quite correct, so until breakage is allowed, add
  a class which wraps up an object and which works more like one would
  expect a QObject to behave.
  
  Register the wrapper with QtQuick (and clean the plugin a tiny bit)
  
  Switch to a QQmlListProperty
  
  The issue with the previous approach is that KNSCore::EntryInternal
  is not a QObject, and so the list can't be used verbatim. This
  allows us to do things a little bit roundabout, but also reasonably
  simply.
  
  Using an alias turns out to be fragile when digging through layers
  
  Previously, the property would fail to resolve on the first try,
  and consequently would just stop attempting the resolution entirely.
  This binding, while suboptimal compared to aliasing, at least
  forwards the data correctly.

TEST PLAN
  Without this patch, changedEntries cannot be read by any user of the code
  With it, changedEntries can be passed through to any C++ consumer, and read 
out using the standard QQmlListReference method

REPOSITORY
  R304 KNewStuff

BRANCH
  unbreak-changedentries-in-qtquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26543

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/entrywrapper.cpp
  src/core/entrywrapper.h
  src/qtquick/qml/Button.qml
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

[Roman Gilg]

romangg added a task: T11222: Reimagine output cloning.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26308

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26540: Consistency: colored selected buttons

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26540

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26540: Consistency: colored selected buttons

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  color selected buttons to the highlight color when it has keyboard
  focus.
  This makes the behavior much more similar to the Breeze desktop style

TEST PLAN
  selected buttons look blue on Breeze, old themes still work as they did

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/bluebutton

REVISION DETAIL
  https://phabricator.kde.org/D26540

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmastyle/ButtonStyle.qml
  src/desktoptheme/breeze/widgets/button.svg

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

[Ben Cooksley]

On Mon, Dec 30, 2019 at 3:03 AM Stephen Kelly  wrote:
>
>
> On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote:
> > Why are you proposing to do a step back instead to the old state, which
> > everyone including you considered not that satisfying?
>
> Because it's a temporary situation. We still have a way forward in KF6
> (which will open in a few months).

I have now actioned the reversal.

As this has cost a reasonable amount of time (and the full fallout of
the reversal has yet to be felt, with the CI rebuild yet to come which
I anticipate is going to require additional time on my part to sort
out), i'm going to require that the Grantlee project on Github be
transferred to KDE as part of the KF6 move (and this transfer will
take place prior to any infrastructure being setup on our side)

>
>
> Generally, getting Grantlee into KF5 now also establishes the wrong
> precedent. Grantlee should be split into two repos each with a tier 1
> library (KF6::TextDocument and KF6::TextTemplate). The two are
> independent and have nothing to do with each other aside from
> authorship. That seems to be something you were objecting to, so I want
> to make sure that's something addressed on its own. The two KF6
> libraries will then follow the KF6 naming conventions etc.
>
>
> > I hope my personal objections raised about it becoming an official KF module
> > already now have not arrived with you as objection in general.
>
>
> Not at all. I agree that the two libraries should be consistent with the
> rest of the Frameworks.
>
>
> > On the
> > opposite, I agree with the ideas behind this move. I have just strict 
> > feeling
> > about KF as a product itself when it comes to consumer as well as 
> > cross-module
> > ontributor experience.
> > So please be aware that I would be sad if you decided to have Grantlee go 
> > back
> > to lonely cowboy mode :)
>
>
> Only temporarily :).
>
> Thanks,
>
> Stephen.
>
>

Regards,
Ben

[sysadmin/repo-metadata] projects/kdereview/grantlee: Strip Grantlee of it's KDE Git repository and therefore terminate it's status as a KDE project.

[Ben Cooksley]

Git commit 510628f46bf2ecc6cba15e6940ca1bf3e941224c by Ben Cooksley.
Committed on 09/01/2020 at 09:39.
Pushed by bcooksley into branch 'master'.

Strip Grantlee of it's KDE Git repository and therefore terminate it's status 
as a KDE project.

Ref T12387

CCMAIL: kde-core-de...@kde.org
CCMAIL: kde-frameworks-devel@kde.org

D  +0-1projects/kdereview/grantlee/i18n.json
D  +0-11   projects/kdereview/grantlee/metadata.yaml

https://commits.kde.org/sysadmin/repo-metadata/510628f46bf2ecc6cba15e6940ca1bf3e941224c

diff --git a/projects/kdereview/grantlee/i18n.json 
b/projects/kdereview/grantlee/i18n.json
deleted file mode 100644
index 31dfafe..000
--- a/projects/kdereview/grantlee/i18n.json
+++ /dev/null
@@ -1 +0,0 @@
-{"trunk": "none", "stable": "none", "stable_kf5": "none", "trunk_kf5": 
"master"}
diff --git a/projects/kdereview/grantlee/metadata.yaml 
b/projects/kdereview/grantlee/metadata.yaml
deleted file mode 100644
index 3fe62a1..000
--- a/projects/kdereview/grantlee/metadata.yaml
+++ /dev/null
@@ -1,11 +0,0 @@
-description: Text Templating Library for Qt
-hasrepo: true
-icon: null
-members:
-- displayname: Stephen Kelly
-  username: skelly
-name: Grantlee
-projectpath: kdereview/grantlee
-repoactive: true
-repopath: grantlee
-type: project