KDE CI: Frameworks » threadweaver » kf5-qt5 SUSEQt5.12 - Build # 59 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20SUSEQt5.12/59/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 06:39:57 +
 Build duration:
9 min 13 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ThreadWeaver-5.67.0.xmlcompat_reports/KF5ThreadWeaver_compat_report.htmllogs/KF5ThreadWeaver/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.autotests.ThreadWeaverJobTests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(2/7)56%
(44/78)56%
(44/78)43%
(1423/3277)17%
(1015/6100)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests62%
(8/13)62%
(8/13)33%
(389/1195)12%
(425/3454)benchmarks0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/60)examples.HelloInternet0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/264)examples.HelloWorld0%
(0/1)0%
(0/1)0%
(0/3)100%
(0/0)examples.HelloWorldRaw0%
(0/1)0%
(0/1)0%
(0/13)100%
(0/0)examples.ThumbNailer0%
(0/14)0%
(0/14)0%
(0/458)0%
(0/880)src84%
(36/43)84%
(36/43)76%
(1034/1365)41%
(590/1442)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/51/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 16 Jan 2020 05:50:02 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 56 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/56/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 16 Jan 2020 05:49:44 +
 Build duration:
4 min 10 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.67.0.xmllogs/KF5WindowSystem/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7264/9613)55%
(3526/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3075/3162)52%
(1288/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(820/1374)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3362/4719)60%
(1934/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 WindowsMSVCQt5.13 - Build # 44 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20WindowsMSVCQt5.13/44/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 16 Jan 2020 05:49:43 +
 Build duration:
2 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 84 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Jan 2020 05:49:45 +
 Build duration:
3 min 7 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.67.0.xmllogs/KF5WindowSystem/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7266/9613)55%
(3529/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3077/3162)53%
(1291/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(820/1374)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3362/4719)60%
(1934/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 50 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/50/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Thu, 16 Jan 2020 05:50:04 +
 Build duration:
1 min 9 sec and counting

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart
Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  l-qregularexpressoin-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26693

To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I'm not totally sure I agree. If the text becomes focusable by tabbing, 
then I think that just clutters up the focus chain with non-interactive UI 
elements that nobody is actually going to care about doing something with 99% 
of the time.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25798: Deprecated allowAsDefault

[Nicolas Fella]

nicolasfella updated this revision to Diff 73672.
nicolasfella added a comment.


  - Fix and update

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25798?vs=71036&id=73672

BRANCH
  allo

REVISION DETAIL
  https://phabricator.kde.org/D25798

AFFECTED FILES
  src/CMakeLists.txt
  src/services/kservice.cpp
  src/services/kservice.h
  src/services/kserviceoffer.cpp
  src/services/kserviceoffer.h

To: nicolasfella, #frameworks
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

[David Faure]

dfaure added a comment.


  s/Schema/Scheme/ everywhere (method name, commit log)
  
  I want to deprecate KMimeTypeTrader, this should rather go into the upcoming 
KApplicationTrader D25698 , if new API is 
needed.
  
  I'm pretty sure you can use KMimeTypeTrader::query(mimeHandler) instead of 
parsing mimeapps.list. And then I wonder if you really need new API :)

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

[David Faure]

dfaure updated this revision to Diff 73671.
dfaure added a comment.


  Fix docu (oops, I'm tired)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26701?vs=73668&id=73671

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

AFFECTED FILES
  src/filewidgets/kfilecustomdialog.cpp
  src/filewidgets/kfilecustomdialog.h

To: dfaure, broulik, pino
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  There could be a ton more unittests, but OK, good enough since the old code 
didn't have more.

REPOSITORY
  R244 KCoreAddons

BRANCH
  l-perlsplit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26657

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

[Alexey Min]

alexeymin added inline comments.

INLINE COMMENTS

> kfilecustomdialog.h:40
> +/**
> + * Constructors a custom file dialog
> + */

Constructs?

> kfilecustomdialog.h:45
> +/**
> + * Constructors a custom file dialog
> + * @param startDir see the KFileWidget constructor for documentation

Constructs?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

[David Faure]

dfaure updated this revision to Diff 73668.
dfaure added a comment.


  off-by-10

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26701?vs=73667&id=73668

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

AFFECTED FILES
  src/filewidgets/kfilecustomdialog.cpp
  src/filewidgets/kfilecustomdialog.h

To: dfaure, broulik, pino
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

[David Faure]

dfaure created this revision.
dfaure added reviewers: broulik, pino.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This is needed because KFileWidget does special handling of the startDir
  parameter (to detect if it's directory+filename), while setUrl() assumes
  it's a directory.

TEST PLAN
  tested with D26645  in kolourpaint

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

AFFECTED FILES
  src/filewidgets/kfilecustomdialog.cpp
  src/filewidgets/kfilecustomdialog.h

To: dfaure, broulik, pino
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Decouple KBookmarksMenu from KActionCollection

[Nicolas Fella]

nicolasfella updated this revision to Diff 73666.
nicolasfella marked 11 inline comments as done.
nicolasfella added a comment.


  - Decouple from KActionCollection
  - Set action name
  - Restore root check
  - Use constructor delegation
  - Update since
  - fix docs
  - Docs fixes
  - Use QString()
  - Make methods const
  - Rename parameter

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25660?vs=70694&id=73666

BRANCH
  addd

REVISION DETAIL
  https://phabricator.kde.org/D25660

AFFECTED FILES
  src/CMakeLists.txt
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, dfaure, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26405: Add mime type for backtraces saved from DrKonqi

[Michael Pyne]

mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.


  Thanks Harald. Patch looks good and I've checked that the file name pattern 
is what Dr. Konqi uses by default. One question though, @broulik you mentioned 
there's also text/x-apport, should that be changed here too or is this 
changeset just for *.kcrash.txt? If the apport mention is for something else 
then I'd say to go ahead and commit.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26405

To: broulik, #frameworks, sitter, mpyne
Cc: mpyne, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[David Faure]

dfaure added a comment.


  IMHO the proper fix is to make tabbing work, and to fix Qt not to show a 
caret when the label gets the focus via a mouse click.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> wsdiscoverer.cpp:97
> +while (!m_discovery) {
> +QCoreApplication::processEvents();
> +}

You could also connect the signal resolved() to a local QEventLoop here? Would 
be cleaner and less CPU-intensive.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter, dfaure, #frameworks, #dolphin
Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn, davidedmundson, 
kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D26205: KWallet: Port QRegExp to QRegularExpression

[Albert Astals Cid]

aacid added a comment.


  In D26205#595080 , @ahmadsamir 
wrote:
  
  > In D26205#595034 , @blaze wrote:
  >
  > > 
https://github.com/KDE/falkon/blob/master/src/plugins/KDEFrameworksIntegration/kwalletpasswordbackend.cpp#L187
  > >
  > >   QMap entries;
  > >   if (m_wallet->readEntryList("*", entries) != 0) {
  > >   qWarning() << "KWalletPasswordBackend::initialize Cannot read 
entries!";
  > >   return;
  > >   }
  > >   
  > >
  > > This is the problematic code. As you can see it uses "*" as a wildcard. 
So may be it is possible just to use a different wildcard and it could be 
solved IDK
  >
  >
  > OK, I'll see if I can make it work and also fix the double-anchored issue; 
in a new diff, otherwise, we could just revert this patch.
  >
  > @apol, @aacid WDYT?
  
  
  I was going to be silent here, but since you asked my opinion is this, if you 
are not going to test the code you are changing, you should stop changing code. 
And by reading the comments it seems you aren't testing it, so either start 
testing it or stop doing blind changes.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26205: KWallet: Port QRegExp to QRegularExpression

[Mikołaj Płomieński]

blaze added a comment.


  > otherwise, we could just revert this patch
  
  The rest of the code is OK. The part that works funny is just the wildcard 
method, and since it's relatively new, I hope there could be a good workaround 
until the situation stabilizes

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26697: Message-related methods: Use more member-function-pointer-based connect

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26697

AFFECTED FILES
  src/document/katedocument.cpp
  src/view/katemessagewidget.cpp

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Seen while forking the Message classes for KDevelop for some shell-level 
message area :) https://invent.kde.org/kde/kdevelop/merge_requests/87
  Was confused initially by the old code, and then found it also less 
µ-optimized ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D26696

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  avoidmultiplehashaccess

REVISION DETAIL
  https://phabricator.kde.org/D26696

AFFECTED FILES
  src/document/katedocument.cpp

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26205: KWallet: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  In D26205#595034 , @blaze wrote:
  
  > 
https://github.com/KDE/falkon/blob/master/src/plugins/KDEFrameworksIntegration/kwalletpasswordbackend.cpp#L187
  >
  >   QMap entries;
  >   if (m_wallet->readEntryList("*", entries) != 0) {
  >   qWarning() << "KWalletPasswordBackend::initialize Cannot read 
entries!";
  >   return;
  >   }
  >   
  >
  > This is the problematic code. As you can see it uses "*" as a wildcard. So 
may be it is possible just to use a different wildcard and it could be solved 
IDK
  
  
  OK, I'll see if I can make it work and also fix the double-anchored issue; in 
a new diff, otherwise, we could just revert this patch.
  
  @apol, @aacid WDYT?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26633: Deprecate KWindowEffects::markAsDashboard()

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:181d4f31f5c7: Deprecate KWindowEffects::markAsDashboard() 
(authored by zzag).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26633?vs=73440&id=73655

REVISION DETAIL
  https://phabricator.kde.org/D26633

AFFECTED FILES
  autotests/kwindoweffectstest.cpp
  src/CMakeLists.txt
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindoweffects_dummy.cpp
  src/kwindoweffects_dummy_p.h
  src/kwindoweffects_p.h
  src/platforms/xcb/kwindoweffects.cpp
  src/platforms/xcb/kwindoweffects_x11.h

To: zzag, #kwin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  It turns out that QRegularExpression::wildcardToRegularExpression() returns
  an anchored (with \A and \z) pattern, so using anchoredPattern() in such
  cases would actually anchor the pattern twice, which is obviously wrong.
  Thanks to Mikołaj Płomieński (blaze) for catching it in
  https://phabricator.kde.org/D26205#594891

TEST PLAN
  make && ctest

REPOSITORY
  R495 Purpose Library

BRANCH
  l-qregularexpressoin-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26693

AFFECTED FILES
  src/alternativesmodel.cpp

To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  It turns out that QRegularExpression::wildcardToRegularExpression() returns
  an anchored (with \A and \z) pattern, so using anchoredPattern() in such
  cases would actually anchor the pattern twice, which is obviously wrong.
  Thanks to Mikołaj Płomieński (blaze) for catching it in
  https://phabricator.kde.org/D26205#594891

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-qregularexpression-too-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26692

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/kpac/script.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/50/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 15 Jan 2020 19:02:18 +
 Build duration:
37 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on FreeBSD Builder 2 in /usr/home/jenkins/workspace/Frameworks/kwindowsystem/kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2020-01-15T19:02:22.646Z] No credentials specified[2020-01-15T19:02:22.651Z] Cloning the remote Git repository[2020-01-15T18:52:22.258Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-15T18:52:22.258Z]  > git init /usr/home/jenkins/workspace/Frameworks/kwindowsystem/kf5-qt5 FreeBSDQt5.13 # timeout=10[2020-01-15T18:52:22.279Z] Fetching upstream changes from git://anongit.kde.org/kwindowsystem[2020-01-15T18:52:22.280Z]  > git --version # timeout=10[2020-01-15T18:52:22.288Z]  > git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-15T19:02:54.169Z] ERROR: Error fetching remote repo 'origin'[2020-01-15T19:02:54.169Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:54.169Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-15T19:02:54.169Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-15T19:02:54.169Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:02:54.169Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:02:54.169Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:02:54.169Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:02:54.169Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:02:54.169Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:02:54.169Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:02:54.169Z] stdout: [2020-01-15T19:02:54.169Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:02:54.169Z] [2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:02:54.169Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:02:54.169Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:02:54.169Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:02:54.169Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:02:54.169Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:02:54.169Z] 	... 4 more[2020-01-15T19:02:54.169Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 2[2020-01-15T19:02:54.169Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:02:54.169Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:02:54.169Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:02:54.169Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:02:54.169Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:02:54.169Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAc

KDE CI: Frameworks » kwindowsystem » kf5-qt5 WindowsMSVCQt5.13 - Build # 43 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20WindowsMSVCQt5.13/43/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Wed, 15 Jan 2020 19:02:18 +
 Build duration:
38 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on Windows Builder 2 in C:\CI\workspace\Frameworks\kwindowsystem\kf5-qt5 WindowsMSVCQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] bat[2020-01-15T19:02:22.970Z] [2020-01-15T19:02:22.970Z] C:\CI\workspace\Frameworks\kwindowsystem\kf5-qt5 WindowsMSVCQt5.13>if exist "C:\CI\Software Installs\kwindowsystem" rmdir /s /q "C:\CI\Software Installs\kwindowsystem" [Pipeline] checkout[2020-01-15T19:02:23.288Z] No credentials specified[2020-01-15T19:02:23.301Z] Cloning the remote Git repository[2020-01-16T04:02:23.045Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-16T04:02:23.047Z]  > git init C:\CI\workspace\Frameworks\kwindowsystem\kf5-qt5 WindowsMSVCQt5.13 # timeout=10[2020-01-16T04:02:23.106Z] Fetching upstream changes from git://anongit.kde.org/kwindowsystem[2020-01-16T04:02:23.106Z]  > git --version # timeout=10[2020-01-16T04:02:23.138Z]  > git fetch --tags --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-15T19:02:54.981Z] ERROR: Error fetching remote repo 'origin'[2020-01-15T19:02:54.981Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:54.981Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-15T19:02:54.981Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-15T19:02:54.981Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:02:54.981Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:02:54.981Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:02:54.981Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:02:54.981Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:02:54.981Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:02:54.981Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:02:54.981Z] stdout: [2020-01-15T19:02:54.981Z] stderr: fatal: read error: Invalid argument[2020-01-15T19:02:54.981Z] [2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:02:54.981Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:02:54.981Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)[2020-01-15T19:02:54.981Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:02:54.981Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:02:54.981Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:02:54.981Z] 	at java.util.concurrent.FutureTask.run(Unknown Source)[2020-01-15T19:02:54.981Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)[2020-01-15T19:02:54.981Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)[2020-01-15T19:02:54.981Z] 	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)[2020-01-15T19:02:54.981Z] 	at java.lang.Thread.run(Unknown Source)[2020-01-15T19:02:54.981Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 83 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/83/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 15 Jan 2020 19:02:17 +
 Build duration:
51 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskAll nodes of label ‘SUSEQt5.12’ are offlineRunning on Docker Swarm-4314e845938e in /home/jenkins/workspace/Frameworks/kwindowsystem/kf5-qt5 SUSEQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2020-01-15T19:02:38.334Z] No credentials specified[2020-01-15T19:02:38.335Z] Cloning the remote Git repository[2020-01-15T19:02:38.346Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:38.368Z]  > git init /home/jenkins/workspace/Frameworks/kwindowsystem/kf5-qt5 SUSEQt5.12 # timeout=10[2020-01-15T19:02:38.384Z] Fetching upstream changes from git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:38.385Z]  > git --version # timeout=10[2020-01-15T19:02:38.387Z]  > git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-15T19:03:07.784Z] ERROR: Error fetching remote repo 'origin'[2020-01-15T19:03:07.784Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kwindowsystem[2020-01-15T19:03:07.784Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-15T19:03:07.784Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-15T19:03:07.784Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:03:07.784Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:03:07.784Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:03:07.784Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:03:07.784Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:03:07.784Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:03:07.784Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:03:07.784Z] stdout: [2020-01-15T19:03:07.784Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:03:07.784Z] [2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:03:07.784Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:03:07.784Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:03:07.784Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:03:07.784Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:03:07.784Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:03:07.784Z] 	... 4 more[2020-01-15T19:03:07.784Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-4314e845938e[2020-01-15T19:03:07.784Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:03:07.784Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:03:07.784Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:03:07.784Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:03:07.784Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:03:07.784Z] 		at sun.reflect.Deleg

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 49 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/49/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Wed, 15 Jan 2020 19:02:19 +
 Build duration:
49 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on Docker Swarm-dddb2713fbd3 in /home/user/workspace/Frameworks/kwindowsystem/kf5-qt5 AndroidQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2020-01-15T19:02:37.084Z] No credentials specified[2020-01-15T19:02:37.086Z] Cloning the remote Git repository[2020-01-15T19:02:37.102Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:37.127Z]  > git init /home/user/workspace/Frameworks/kwindowsystem/kf5-qt5 AndroidQt5.13 # timeout=10[2020-01-15T19:02:37.147Z] Fetching upstream changes from git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:37.147Z]  > git --version # timeout=10[2020-01-15T19:02:37.157Z]  > git fetch --tags --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-15T19:03:06.842Z] ERROR: Error fetching remote repo 'origin'[2020-01-15T19:03:06.842Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kwindowsystem[2020-01-15T19:03:06.842Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-15T19:03:06.842Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-15T19:03:06.842Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-15T19:03:06.842Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-15T19:03:06.842Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:03:06.842Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:03:06.842Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:03:06.842Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:03:06.842Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:03:06.842Z] stdout: [2020-01-15T19:03:06.842Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:03:06.842Z] [2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:03:06.842Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:03:06.842Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:03:06.842Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:03:06.842Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:03:06.842Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:03:06.842Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:264)[2020-01-15T19:03:06.842Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)[2020-01-15T19:03:06.842Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)[2020-01-15T19:03:06.842Z] 	at java.lang.Thread.run(Thread.java:834)[2020-01-15T19:03:06.842Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-dddb2713fbd3[2020-01-15T19:03:06.842Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:03:06.842Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:03:06.842Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:03:06.8

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 55 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/55/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 15 Jan 2020 19:02:18 +
 Build duration:
23 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule task‘Docker Swarm-8645291ac0ac’ is offlineRunning on Docker Swarm-8645291ac0ac in /home/jenkins/workspace/Frameworks/kwindowsystem/kf5-qt5 SUSEQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2020-01-15T19:02:40.721Z] No credentials specified[2020-01-15T19:02:40.723Z] Cloning the remote Git repository[2020-01-15T19:02:40.737Z] Cloning repository git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:40.762Z]  > git init /home/jenkins/workspace/Frameworks/kwindowsystem/kf5-qt5 SUSEQt5.13 # timeout=10[2020-01-15T19:02:40.935Z] Fetching upstream changes from git://anongit.kde.org/kwindowsystem[2020-01-15T19:02:40.935Z]  > git --version # timeout=10[2020-01-15T19:02:40.942Z]  > git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-15T19:02:41.003Z] ERROR: Error cloning remote repo 'origin'[2020-01-15T19:02:41.006Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kwindowsystem +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-15T19:02:41.006Z] stdout: [2020-01-15T19:02:41.006Z] stderr: fatal: read error: Connection reset by peer[2020-01-15T19:02:41.006Z] [2020-01-15T19:02:41.006Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-15T19:02:41.006Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-15T19:02:41.006Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-15T19:02:41.006Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-15T19:02:41.006Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:787)[2020-01-15T19:02:41.006Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-15T19:02:41.006Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-15T19:02:41.006Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-15T19:02:41.006Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-15T19:02:41.006Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-15T19:02:41.006Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-15T19:02:41.006Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-15T19:02:41.006Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-15T19:02:41.006Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-15T19:02:41.006Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-15T19:02:41.006Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-8645291ac0ac[2020-01-15T19:02:41.006Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)[2020-01-15T19:02:41.006Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-15T19:02:41.006Z] 		at hudson.remoting.Channel.call(Channel.java:951)[2020-01-15T19:02:41.006Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-15T19:02:41.006Z] 		at sun.reflect.GeneratedMethodAccessor336.invoke(Unknown Source)[2020-01-15T19:02:41.006Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2020-01-15T19:02:41.006Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2020-01-15T19:02:41.006Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2020-01-15T19:02:41.006Z] 		at com.sun.proxy.$Proxy81.execute(Unknown Source)[2020-01-15T19:02:41.006Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)[2020-01-15T19:02:41.006Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-15T19:02:41.006Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-15T19:02:41.006Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-15T19:02:41.006Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-15T19:02:41.006Z] 		at org.jenkinsci

D26205: KWallet: Port QRegExp to QRegularExpression

[Mikołaj Płomieński]

blaze added a comment.


  
https://github.com/KDE/falkon/blob/master/src/plugins/KDEFrameworksIntegration/kwalletpasswordbackend.cpp#L187
  
QMap entries;
if (m_wallet->readEntryList("*", entries) != 0) {
qWarning() << "KWalletPasswordBackend::initialize Cannot read entries!";
return;
}
  
  This is the problematic code. As you can see it uses "*" as a wildcard. So 
may be it is possible just to use a different wildcard and it could be solved 
IDK

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> quickengine.h:54
>  Q_PROPERTY(QString searchTerm READ searchTerm WRITE setSearchTerm RESET 
> resetSearchTerm NOTIFY searchTermChanged)
> -Q_PROPERTY(KNSCore::EntryInternal::List changedEntries READ 
> changedEntries RESET resetChangedEntries NOTIFY changedEntriesChanged)
> +Q_PROPERTY(QQmlListProperty changedEntries READ changedEntries 
> NOTIFY changedEntriesChanged)
>  Q_PROPERTY(int changedEntriesCount READ changedEntriesCount NOTIFY 
> changedEntriesChanged)

Why QObject here?

One of the main advantages of using QQmlListProperty over QList is 
that you can specify the derived type.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26671: Cleanup and add 22px media repeat icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  repeatIcons

REVISION DETAIL
  https://phabricator.kde.org/D26671

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  repeatIcons

REVISION DETAIL
  https://phabricator.kde.org/D26671

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart
Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26405: Add mime type for backtraces saved from DrKonqi

[Harald Sitter]

sitter added a subscriber: mpyne.
sitter added a comment.


  +1 form me. not sure if @mpyne wants to have a look as well.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26405

To: broulik, #frameworks, sitter
Cc: mpyne, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart
Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26205: KWallet: Port QRegExp to QRegularExpression

[Mikołaj Płomieński]

blaze added a comment.


  In D26205#594867 , @ahmadsamir 
wrote:
  
  > A test case of what is broken would be appreciated, to try and fix/debug 
the issue.

INLINE COMMENTS

> ahmadsamir wrote in kwallet.cpp:180
> Any suggestions? QRegularExpression::wildcardToRegularExpression() is what 
> the upstream docs offer:
> 
> > Wildcard matching
> > 
> > There is no direct way to do wildcard matching in QRegularExpression. 
> > However, the wildcardToRegularExpression method is provided to translate 
> > glob patterns into a Perl-compatible regular expression that can be used 
> > for that purpose.

> The transformation is targeting file path globbing, which means in particular 
> that path separators receive special treatment.

I'm pretty sure the file path case is different from what we have here.

Also

> In order to match one of the special characters, place it in square brackets 
> (for example, "[?]")

Doesn't it mean you can't just use a bare raw wildcard?

So my suggestion is just to rollback to the previous solution, at least 
temporarily, until we don't have something better.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi retitled this revision from "[WIP] Optimize code when dropping files into 
the desktop" to "Optimize code when dropping files into the desktop".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart
Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart
Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi added reviewers: Plasma, mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart
Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi edited the summary of this revision.
trmdi added a subscriber: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi
Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

[Méven Car]

meven added a comment.


  I mean here to build consensus then implement about the need for this, then 
on how to implement it.
  
  I think KService should handle building this when parsing mimeapps.list files.
  And then expose this as `KService::findDefaultSchemeHandler(scheme)`

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

[Méven Car]

meven retitled this revision from "Add KMimeTypeTrader::defaultSchemaHandler to 
return default service associated with scheme" to "[WIP] Add 
KMimeTypeTrader::defaultSchemaHandler to return default service associated with 
scheme".
meven edited the summary of this revision.
meven added reviewers: dfaure, dvratil, ervin.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trmdi requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h

To: trmdi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

[Méven Car]

meven created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26690

AFFECTED FILES
  src/kdeinit/ktoolinvocation_x11.cpp
  src/services/kmimetypetrader.cpp
  src/services/kmimetypetrader.h

To: meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26205: KWallet: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> blaze wrote in kwallet.cpp:179
> QRegularExpression::wildcardToRegularExpression() already returns an anchored 
> output. What do you mean?

I didn't get what you meant before.

I've just tested and you're right; I didn't know that 
wildcardToRegularExpression() returned an anchored pattern, the docs didn't say 
anything about that (if they did, I must have missed it).

I'll be filing a diff to fix that (and I'll have review all my other QRegExp 
port diffs, the same issue will be in more places than just here in kwallet...).

Thanks for catching this issue.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:02e57319f791: Same behavior for scrollbar as the desktop 
style (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73631&id=73632

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart marked 3 inline comments as done.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart updated this revision to Diff 73631.
mart added a comment.


  - round things

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73621&id=73631

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26205: KWallet: Port QRegExp to QRegularExpression

[Mikołaj Płomieński]

blaze added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kwallet.cpp:179
> The pattern has to be anchored if we want to replicate what 
> QRegExp::exactMatch() did, with \A and \z or ^ and $.
> 
> If you have a test case where it anchoredPattern() anchors twice, file a bug 
> report upstream (to be honest, I don't know whether this is the intended 
> behaviour or not).

QRegularExpression::wildcardToRegularExpression() already returns an anchored 
output. What do you mean?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ScrollBar.qml:90
> +visible: !controlRoot.interactive
> +x: controlRoot.orientation == Qt.Vertical
> +? (parent.width - width) - (parent.width/2 - width/2) * 
> handleState

Math.round?

> ScrollBar.qml:94
> +
> +y: controlRoot.orientation == Qt.Horizontal
> +? (parent.height - height) - (parent.height/2 - height/2) * 
> handleState

Math.round

> scrollbar.svg:149
>   id="rect3856"
> - width="1"
> + width="4.01"
>   height="10"

We seem to have lost a lot of pixel alignment.

Probably won't make any difference unless you render at 2x the size, but 
might be worth asking Noah/someone how they do it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26664: Same behavior for scrollbar as the desktop style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah that's fine for now. We can adjust plasmoid layouts to better 
accommodate the line in Plasma 5.19.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26205: KWallet: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  A test case of what is broken would be appreciated, to try and fix/debug the 
issue.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26205: KWallet: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> blaze wrote in kwallet.cpp:179
> anchoredPattern() is excessive here, it creates a horror like that 
> "\\A(?:\\A(?:[^/]*)\\z)\\z" with the stuff being anchored twice.
> It has to be removed with no doubt at all.

The pattern has to be anchored if we want to replicate what 
QRegExp::exactMatch() did, with \A and \z or ^ and $.

If you have a test case where it anchoredPattern() anchors twice, file a bug 
report upstream (to be honest, I don't know whether this is the intended 
behaviour or not).

> blaze wrote in kwallet.cpp:180
> The output of wildcardToRegularExpression() method is different from what was 
> before and it breaks the app. It has to be replaced with something else.

Any suggestions? QRegularExpression::wildcardToRegularExpression() is what the 
upstream docs offer:

> Wildcard matching
> 
> There is no direct way to do wildcard matching in QRegularExpression. 
> However, the wildcardToRegularExpression method is provided to translate glob 
> patterns into a Perl-compatible regular expression that can be used for that 
> purpose.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart updated this revision to Diff 73621.
mart added a comment.


  - only show when *not* a plasmoid

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73545&id=73621

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26205: KWallet: Port QRegExp to QRegularExpression

[Mikołaj Płomieński]

blaze added a comment.


  This changeset breaks the app, making it impossible to get the list of 
entries from outside. Tested against Falkon browser with KDE integration 
plugin. See my inline comments here

INLINE COMMENTS

> kwallet.cpp:179
>  if (searchItemsJob->exec()) {
> -QRegExp re(key, Qt::CaseSensitive, QRegExp::Wildcard);
> +const QRegularExpression re(QRegularExpression::anchoredPattern(
> +  
> QRegularExpression::wildcardToRegularExpression(key)));

anchoredPattern() is excessive here, it creates a horror like that 
"\\A(?:\\A(?:[^/]*)\\z)\\z" with the stuff being anchored twice.
It has to be removed with no doubt at all.

> kwallet.cpp:180
> +const QRegularExpression re(QRegularExpression::anchoredPattern(
> +  
> QRegularExpression::wildcardToRegularExpression(key)));
>  const auto list = searchItemsJob->items();

The output of wildcardToRegularExpression() method is different from what was 
before and it breaks the app. It has to be replaced with something else.

> kwalletbackend.cc:533
>  
> -QRegExp re(key, Qt::CaseSensitive, QRegExp::Wildcard);
> +QRegularExpression re(QRegularExpression::anchoredPattern(
> +   
> QRegularExpression::wildcardToRegularExpression(key)));

Same here as well.

> kwalletbackend.cc:534
> +QRegularExpression re(QRegularExpression::anchoredPattern(
> +   
> QRegularExpression::wildcardToRegularExpression(key)));
>  

and here

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart added a comment.


  I would put for now an exception for plasmoids to not have such line, thenin 
a second moment we think about a proper and more complicated solution to update 
plasmoids design to have something along the lines of the latter mockup

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kpropertiesdialog.cpp:1114
> OK, it can be a problem since we can have many objects of KFilePropsPlugin 
> thus lambda will extend service ptr life to the process end, which can result 
> in memory leak (it's not leak) But since it's a plugin we don't expect a tons 
> of objects, but i'm fine to make service a class scope var to not outlive the 
> plugin.

I'm pretty sure that isn't true.

KFilePropsPlugin are the tabs inside the properties dialog. They get 
instantiated for each dialog and destroyed when the dialog is destroyed. They 
are not persistent throughout the life time of the process. 
The lamda in this case is scoped to the internal QFunctorSlotObject or whatever 
it's called and that is held by the QObject. When the dialog gets destroyed, it 
destroys the KFilePropsPlugin instance and that disconnects the signal 
triggering the QFunctorSlotObject to get deleted, which in turn causes the 
lambda to lose scope and clean up, destroying its pointer copies.
TLDR: the lambda and all its copies do not outlive the property dialog it 
belongs to.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart added a comment.


  actually, doesn't look that good.
  F7884183: Screenshot_20200115_16.png 

  
  this is because the scrollview has some margins and no frame, so now the 
scrollbar appears not centered.
  those plasmoids would need to not have any margin with their content, or 
preferably, having the scrollviews enlarging to touch exactly the applet borders

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart added a comment.


  In D26664#594322 , @ngraham wrote:
  
  > I don't see the separator lines in plasma applets. Is that intentional?
  
  
  most of them are still qqc1, i can look into adding them there as well

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Yunhe Guo]

guoyunhe added a comment.


  I am not 100% sure. It seems installed under `/etc/xdg/menus/*.menu`. You can 
install as many *.menu files as you want but keep different names.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Luigi Toscano]

ltoscano added a comment.


  In D24423#594728 , @guoyunhe wrote:
  
  > if we copy `applications.menu` to plasma-workspace and patch it there, it 
will only be shipped with future plasma releases.
  
  
  Isn't it going to conflict with the kservice-provided one? I simply don't 
know, but it should be answered before deciding.
  If it does not conflict, do you mean postpone the kservice patch until 
Frameworks 6?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Yunhe Guo]

guoyunhe added a comment.


  if we copy `applications.menu` to plasma-workspace and patch it there, it 
will only be shipped with future plasma releases.
  
  Existing released plasma can still get the old menu from kservice even with 
newer frameworks and it is not updated.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Luigi Toscano]

ltoscano added a comment.


  In D24423#594718 , @guoyunhe wrote:
  
  > Then how about I copy this file `applications.menu` to plasma-workspace? 
After one or two years, we can delete this file from frameworks. But for 
compatibility, it will exist in both repositories for some time.
  
  
  It is still does not answer the question on what happens with *already 
released* Plasma.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> dfaure wrote in kconfigcompiler_test.cpp:129
> OK, this needs a hint for the person debugging regressions then. Something 
> like
> 
>   QVERIFY2(content == contentRef, "Failure, see foo.diff");

This is done now within the appendFileDiff function.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73608.
tcanabrava added a comment.


  - Rebase

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=73557&id=73608

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  autotests/kconfigtest.h
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Yunhe Guo]

guoyunhe added a comment.


  Then how about I copy this file `applications.menu` to plasma-workspace? 
After one or two years, we can delete this file from frameworks. But for 
compatibility, it will exist in both repositories for some time.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Luigi Toscano]

ltoscano added a comment.


  The question is the same. What happens with older Plasma with newer 
Frameworks?
  It may be that nothing really breaks, of course.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

[Yunhe Guo]

guoyunhe added a comment.


  The dependency D24424  has been landed 
three month ago. Do you think it is safe to ship this patch now?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 73605.
ahmadsamir added a comment.


  Add TODO KF6 to doNameFilter()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26659?vs=73530&id=73605

BRANCH
  l-qregexp-deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26659

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h
  src/core/kcoredirlister_p.h

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> meven wrote in kpropertiesdialog.cpp:1114
> service is a QExplicitlySharedDataPointer in fact, I guess it 
> covers lambda use cases.

OK, it can be a problem since we can have many objects of KFilePropsPlugin thus 
lambda will extend service ptr life to the process end, which can result in 
memory leak (it's not leak) But since it's a plugin we don't expect a tons of 
objects, but i'm fine to make service a class scope var to not outlive the 
plugin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26650: Use KService to look for Filelight

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in kpropertiesdialog.cpp:1114
> Not sure copying that pointer into the lambda is a good idea?

service is a QExplicitlySharedDataPointer in fact, I guess it covers 
lambda use cases.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26652: Unbreak module imports for Python2

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R264 KApiDox

BRANCH
  fixpython2support

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr, davidedmundson
Cc: bcooksley, awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26650: Use KService to look for Filelight

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1114
> +
> d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon()));
> +connect(d->m_sizeDetailsButton, &QPushButton::clicked, this, 
> [this, service]() {
> +KRun::runApplication(*service, { properties->url() }, 
> properties->window());});

Not sure copying that pointer into the lambda is a good idea?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns