D5503: No "KDE Daemon" in password dialogs

[Lukáš Tinkl]

lukas added a comment.


  In action:
  F3729023: dialog-kded1.png  before
  F3729025: dialog-kded2.png  after

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D5503

To: lukas, #frameworks

D5503: No "KDE Daemon" in password dialogs

[Lukáš Tinkl]

lukas created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Do not append non-translatable text "KDE Daemon" to the password dialog 
window title.
  
  This is done automatically by the xcb QPA plugin here: 
https://code.woboq.org/qt5/qtbase/src/gui/kernel/qplatformwindow.cpp.html#_ZN15QPlatformWindow17formatWindowTitleERK7QStringS2_

TEST PLAN
  1. killall -9 kded
  2. Disconnect from the current AP
  3. Delete the network connection
  4. Try to reconnect, get the password dialog
  5. Observe the window title no longer getting the "KDE Daemon" string appended

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D5503

AFFECTED FILES
  src/kded.cpp

To: lukas, #frameworks

Re: Review Request 121446: Ignore child mtp devices

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121446/#review82360
---

Ship it!


Ship It!

- Lukáš Tinkl


On Pro. 11, 2014, 2:05 odp., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121446/
> ---
> 
> (Updated Pro. 11, 2014, 2:05 odp.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> When an mtp device has child usb devices (for example when you plug an 
> android phone with debugging), these childs usbs are mark as MTP but we can't 
> really access them.
> 
> According to the udev rules installed by libmtp, an alias devlink is added to 
> the actual device, so this patch adds a filter for that.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udev/udevmanager.cpp 39137ce 
> 
> Diff: https://git.reviewboard.kde.org/r/121446/diff/
> 
> 
> Testing
> ---
> 
> Tested with 3 different devices, 2 of them android with and withtout debug 
> and it worked fine (plasma shows only 1 working mtp device instead of 3)
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123335/#review78835
---


This is weird, I've explicitely tested both cases here on Qt 5.4 and they 
worked fine

- Lukáš Tinkl


On Dub. 11, 2015, 8:34 odp., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123335/
> ---
> 
> (Updated Dub. 11, 2015, 8:34 odp.)
> 
> 
> Review request for KDE Frameworks, David Faure and Lukáš Tinkl.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> 9814e4b773b2b34afafa0c5d242594bbb4f9a6ae fixed QML file dialogs but broke 
> QtWidgets dialogs.
> 
> QFileDialog static functions - dialog would open, but any user interaction is 
> blocked (cannot select files or click on anything).
> QFileDialog *d = new QFileDialog(parent); d->open(); - dialog would not open 
> at all
> 
> The first issue occurs because exec() is called on already shown dialog. This 
> is fixed by explicit hide() before calling exec() - kind of hacky :/
> The second issue is fixed by always calling show().
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 92ab107 
> 
> Diff: https://git.reviewboard.kde.org/r/123335/diff/
> 
> 
> Testing
> ---
> 
> QML dialogs: 
> example from bug 334963 works fine
> file dialog from plasma desktop settings -> wallpapers works fine
> 
> QtWidgets dialogs:
> static dialogs from qtbase/examples/widgets/dialogs/standarddialogs works fine
> QFileDialog *d = new QFileDialog(parent); d->open(); works fine
> test app: https://paste.kde.org/psddcng5n
> 
> I'm running Qt 5.4.1.
> 
> Are there any other types of dialogs that I forgot (and possibly broke)?
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123131: Port kio_man away from kdelibs4support

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123131/#review78048
---



man/kio_man.cpp (line 242)
<https://git.reviewboard.kde.org/r/123131/#comment53475>

Not correct, this returns only user configured list of languages, whereas 
it previously returned the full list.


- Lukáš Tinkl


On Bře. 25, 2015, 10:17 odp., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123131/
> ---
> 
> (Updated Bře. 25, 2015, 10:17 odp.)
> 
> 
> Review request for KDE Frameworks, Plasma and Martin Koller.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Port kio_man away from kdelibs4support
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d 
>   man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 
>   man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e 
>   man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881 
>   man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4 
> 
> Diff: https://git.reviewboard.kde.org/r/123131/diff/
> 
> 
> Testing
> ---
> 
> man view in kdevelop5 works
> 
> Not sure about the `KLocale::global()->languageList();` -> 
> `QLocale().uiLanguages();` change though so I would like some feedback.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122978: Add unit test for crash of bug 343976

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122978/#review77578
---


+1 from me

- Lukáš Tinkl


On Bře. 16, 2015, 1:04 odp., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122978/
> ---
> 
> (Updated Bře. 16, 2015, 1:04 odp.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 343976
> https://bugs.kde.org/show_bug.cgi?id=343976
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use a QPointer for QMenu of SystemTrayMenu
> 
> We need better memory management as the QMenu the SystemTrayMenu creates
> might be deleted externally causing a double delete if the so-far
> QScopedPoiter cleans up.
> 
> Switch to QPointer and call deleteLater if the pointer is still valid
> during destroying the SystemTrayMenu.
> 
> BUG: 343976
> CHANGELOG: Fix possible crash when destroying a QSystemTrayIcon (triggered by 
> Trojita)
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt e8ed6a99bb45969231ba21b8c5588e093bbbe3ee 
>   autotests/ksni_unittest.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.h 
> 8f13a36ae7cebed7499ce8a160f3533665b909ac 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 
> ce3d3de9f9cf479a5fe3af65ef7fb8ec2b9e0d29 
> 
> Diff: https://git.reviewboard.kde.org/r/122978/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122590: Guard kglobalaccel against QApplication

[Lukáš Tinkl]

> On Bře. 5, 2015, 4:44 odp., Lukáš Tinkl wrote:
> > For posterity, does this still work with khotkeys?
> 
> Martin Gräßlin wrote:
> why should it not work with khotkeys? Or better said: what should be so 
> special about khotkeys?

Nothing in particular, I was just wondering


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/#review77063
---


On Úno. 26, 2015, 10:39 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122590/
> ---
> 
> (Updated Úno. 26, 2015, 10:39 odp.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up 
> in case there is no QApplication (kscreenlocker_greet). This guards against 
> it.
> 
> 
> Diffs
> -
> 
>   src/kglobalaccel.h 4a5595f 
>   src/kglobalaccel.cpp d123af4 
>   src/kglobalaccel_p.h b1528dc 
> 
> Diff: https://git.reviewboard.kde.org/r/122590/diff/
> 
> 
> Testing
> ---
> 
> screenlocker no longer blows up when adding the mpris dataengine which does 
> kglobalaccel stuff but I have no idea whether this is the right approach and 
> what the widget is actually for.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122590: Guard kglobalaccel against QApplication

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/#review77063
---


For posterity, does this still work with khotkeys?

- Lukáš Tinkl


On Úno. 26, 2015, 10:39 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122590/
> ---
> 
> (Updated Úno. 26, 2015, 10:39 odp.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up 
> in case there is no QApplication (kscreenlocker_greet). This guards against 
> it.
> 
> 
> Diffs
> -
> 
>   src/kglobalaccel.h 4a5595f 
>   src/kglobalaccel.cpp d123af4 
>   src/kglobalaccel_p.h b1528dc 
> 
> Diff: https://git.reviewboard.kde.org/r/122590/diff/
> 
> 
> Testing
> ---
> 
> screenlocker no longer blows up when adding the mpris dataengine which does 
> kglobalaccel stuff but I have no idea whether this is the right approach and 
> what the widget is actually for.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122554/#review76186
---

Ship it!



src/knotifyconfigelement.h
<https://git.reviewboard.kde.org/r/122554/#comment52538>

whether


- Lukáš Tinkl


On Úno. 13, 2015, 8:42 odp., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122554/
> ---
> 
> (Updated Úno. 13, 2015, 8:42 odp.)
> 
> 
> Review request for KDE Frameworks and Frederik Gladhorn.
> 
> 
> Repository: knotifyconfig
> 
> 
> Description
> ---
> 
> Change config from KTTS to Speech.
> If QtSpeech is available when building return true from have_speech static 
> method.
> Otherwise return false.
> Could also add a check to see if there are any backend errors later on.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 
>   src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 
>   src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 
>   src/knotifyconfigactionswidgetbase.ui 
> cbe647b70eb41ba540b7bf6d87f519b3246973a1 
>   src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 
>   src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b 
>   src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 
> 
> Diff: https://git.reviewboard.kde.org/r/122554/diff/
> 
> 
> Testing
> ---
> 
> It builds, the config widget shows, the icon for speech is properly showing 
> when that configuration is enabled. Speech from konversation's new message 
> notifications are spoken.
> 
> Something strange here:
> After enabling this notification, no messages are spoken until restarting the 
> application with the notifications (konversation in my test case).
> Similarly, after disabling this notification, messages are still spoken until 
> restarting the application.
> I checked and the konversation.notifyrc file is getting updated, but for some 
> reason the changes aren't taking effect imediately yet.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122293: Use activate on single click setting from QPlatformTheme rather than duplicating it

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122293/#review74933
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 28, 2015, 6:26 odp., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122293/
> ---
> 
> (Updated Led. 28, 2015, 6:26 odp.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Our QPlatformTheme already provide a hint as to whether items should
> activate on single click and it updates when the setting changes
> 
> QCommonStyle by default uses the QPlatformTheme
> 
> This removes duplicating the lookup and also means we now update the
> setting if it changes at runtime
> 
> 
> Diffs
> -
> 
>   src/kstyle/kstyle.cpp b5f7363 
> 
> Diff: https://git.reviewboard.kde.org/r/122293/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122082: Rename jpegcreatorsettings to jpegcreatorsettings5

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122082/#review74114
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 16, 2015, 1:49 dop., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122082/
> ---
> 
> (Updated Led. 16, 2015, 1:49 dop.)
> 
> 
> Review request for KDE Frameworks and Lukáš Tinkl.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> same file is also provided by kde4 runtime, which will lead to file conflict.
> 
> rename jpegcreatorsettings -> jpegcreatorsettings5 to make packager life a 
> little bit easier.
> 
> 
> Diffs
> -
> 
>   thumbnail/jpegcreatorsettings.kcfgc 3f6cdab 
>   thumbnail/jpegcreatorsettings5.kcfg PRE-CREATION 
>   thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION 
>   thumbnail/CMakeLists.txt e9ab79b 
>   thumbnail/jpegcreator.cpp de4902b 
>   thumbnail/jpegcreatorsettings.kcfg 8f68f46 
> 
> Diff: https://git.reviewboard.kde.org/r/122082/diff/
> 
> 
> Testing
> ---
> 
> compiles.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121885: Properly check for systray being available

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121885/#review74017
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 14, 2015, 4:13 odp., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121885/
> ---
> 
> (Updated Led. 14, 2015, 4:13 odp.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 339707
> https://bugs.kde.org/show_bug.cgi?id=339707
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The "org.kde.StatusNotifierWatcher" is just a watcher/helper, not the actual 
> systray object, that's "org.kde.StatusNotifierHost-$PID". Because Plasma 
> appends the PID, we cannot check directly for it being present on the bus, so 
> we check the org.kde.StatusNotifierWatcher.IsStatusNotifierHostRegistered 
> property that's meant to be used for this.
> 
> Plus QSystemTrayIcon::isSystemTrayAvailable() is actually returning always 
> true, because the Watcher is in kded and is /always/ present.
> 
> This also fixes many apps with KSNI crashing on plasma exit, bug 339707 
> (though I believe this is not the direct cause for that bug)
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp b5e207c 
> 
> Diff: https://git.reviewboard.kde.org/r/121885/diff/
> 
> 
> Testing
> ---
> 
> Things do not crash anymore and the ::isSystemTrayAvailable() now returns 
> correct value.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121007: Fix warning when using newer upower backend.

[Lukáš Tinkl]

> On Lis. 7, 2014, 1:19 odp., David Faure wrote:
> > Thank you very much for looking into this. I talked to Lukas Tinkl about it 
> > when we met, though, and IIRC he said that it couldn't be fixed that simply 
> > (because of the dbus signal magic)? I'm not sure though. Did you check that 
> > indexOfSignal("DeviceAdded(QDBusObjectPath)") works?
> > (simpler than downgrading UPower).
> 
> Milian Wolff wrote:
> Yes, I did check that. You can also iterate over the QMetaObject's 
> QMetaProperties and print their names. I did see 
> `DeviceAdded(QDBusObjectPath)` and friends in there. I assume with an older 
> UPower, I'd see `DeviceAdded(QString)` etc.
> 
> Can someone with an older UPower test this and make sure?
> 
> Milian Wolff wrote:
> Put differently: @Lukáš Tinkl: What did you try before, and why did you 
> think it would fail this way?

I didn't say it would fail, I just didn't see this as an option. :) Anyway, I 
can confirm that I'm seeing DeviceAdded(QString) on my system with an older 
upower.


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121007/#review69983
---


On Lis. 7, 2014, 2:33 odp., Milian Wolff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121007/
> ---
> 
> (Updated Lis. 7, 2014, 2:33 odp.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas, David Faure, and Lukáš Tinkl.
> 
> 
> Bugs: 339014
> https://bugs.kde.org/show_bug.cgi?id=339014
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> "No such signal org::freedesktop::UPower::DeviceAdded(...)"
> 
> The signature change can be detected at runtime using Qt's QMetaObject
> introspection mechanism. That prevents us from emitting the two
> pesky warnings at runtime, polluting our konsoles.
> 
> Google is full of that warning, and there is also: 
> https://bugzilla.redhat.com/show_bug.cgi?id=1056769
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/upower/upowermanager.cpp 
> 53c858093a1c439f0faca0c956a51199f4e882e4 
> 
> Diff: https://git.reviewboard.kde.org/r/121007/diff/
> 
> 
> Testing
> ---
> 
> warning gone!
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121007: Fix warning when using newer upower backend.

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121007/#review69984
---

Ship it!


Ship It!

- Lukáš Tinkl


On Lis. 7, 2014, 1:20 odp., Milian Wolff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121007/
> ---
> 
> (Updated Lis. 7, 2014, 1:20 odp.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas, David Faure, and Lukáš Tinkl.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> "No such signal org::freedesktop::UPower::DeviceAdded(...)"
> 
> The signature change can be detected at runtime using Qt's QMetaObject
> introspection mechanism. That prevents us from emitting the two
> pesky warnings at runtime, polluting our konsoles.
> 
> Google is full of that warning, and there is also: 
> https://bugzilla.redhat.com/show_bug.cgi?id=1056769
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/upower/upowermanager.cpp 
> 53c858093a1c439f0faca0c956a51199f4e882e4 
> 
> Diff: https://git.reviewboard.kde.org/r/121007/diff/
> 
> 
> Testing
> ---
> 
> warning gone!
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120917: Fix memory leak for NETWinInfoPrivate::client_machine

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120917/#review69582
---


Please add reference to https://bugs.kde.org/show_bug.cgi?id=339902

Gonna test later, thanks for taking care of this!

- Lukáš Tinkl


On Říj. 31, 2014, 2:29 odp., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120917/
> ---
> 
> (Updated Říj. 31, 2014, 2:29 odp.)
> 
> 
> Review request for KDE Frameworks, kwin, Bhushan Shah, and Lukáš Tinkl.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Got a valgrind report for a possible leak in KWindowSystem and could
> confirm it with valgrind on the auto tests. The auto tests are
> extended to create "dangerous" situations to expose similar leaks.
> 
> 
> Diffs
> -
> 
>   src/netwm.cpp 7b398d46e9da2c85a96ab67b6c0f97b22ceae4a3 
>   autotests/netwininfotestclient.cpp c6905a6cc892096466c3e8b1411e7d3049c72dfa 
>   autotests/netwininfotestwm.cpp 7704b243b3055090ed1037cdd5f34305dd0ae401 
> 
> Diff: https://git.reviewboard.kde.org/r/120917/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120728: Install public header for KNotifyPlugin

[Lukáš Tinkl]

> On Říj. 23, 2014, 1:12 dop., Aleix Pol Gonzalez wrote:
> > You can rename it AFAIU.
> > Given that no external project has seen the header file, nobody is linking 
> > against it (if they don't copy the header over, which is not supported, of 
> > course).
> 
> Martin Klapetek wrote:
> My thinking is that rename = remove an exported class and add a new 
> exported class; and the first one breaks BC. Is this not the case?
> 
> However, my knowledge in this matter is quite basic.

You can rename it, it hasn't been possible to directly include it until now, so 
it should be safe


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120728/#review68952
---


On Říj. 22, 2014, 7:33 odp., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120728/
> ---
> 
> (Updated Říj. 22, 2014, 7:33 odp.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> ...to allow custom KNotification plugins. This class is being exported since 
> ever, but the public header was missing.
> 
> Also, I'd like to rename this class to KNotificationPlugin rather than 
> KNotifyPlugin as there is no KNotify anymore, but renaming already exported 
> class is not allowed in frameworks as that would break BC, right?
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5b109c8 
> 
> Diff: https://git.reviewboard.kde.org/r/120728/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120606: Properly parse URL in KUrlNavigator

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120606/#review68552
---


Tested, works fine

- Lukáš Tinkl


On Říj. 16, 2014, 3:56 odp., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120606/
> ---
> 
> (Updated Říj. 16, 2014, 3:56 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> When using an URL with a scheme, like sftp://f...@bar.com/home/foo/, then 
> KUrlNavigator doesn't properly parse it. At the beginning it tries to count 
> the number of slashes from sftp://f...@bar.com, which is 2, then it tries to 
> contruct buttons using names from particular sections separated by slashes, 
> but when we use only QUrl::path() for URL above, we will always get only 
> "/home/foo/" path and therefore we will have bigger index then the number of 
> sections, which leads to have same URLs for all buttons. We need to parse 
> sections from full URL including first two slashes.
> 
> 
> Diffs
> -
> 
>   src/filewidgets/kurlnavigator.cpp e96d914 
> 
> Diff: https://git.reviewboard.kde.org/r/120606/diff/
> 
> 
> Testing
> ---
> 
> Tested in dolphin and works fine now.
> 
> 
> File Attachments
> 
> 
> Screenshot of the problem
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/10/16/eda6fb7e-a75e-4c28-ac87-5d16a39a366d__kurlnavigator.png
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120599: Properly construct QUrl for a temporary file which will be copied as a new file or edited

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120599/#review68451
---

Ship it!


Ship It!

- Lukáš Tinkl


On Říj. 15, 2014, 3:02 odp., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120599/
> ---
> 
> (Updated Říj. 15, 2014, 3:02 odp.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> In KNewFileMenu when trying to copy a temporary file as a new file or editing 
> a desktop file it doesn't contruct the URL properly and it fails to create it 
> and returns a KIO error.
> 
> 
> Diffs
> -
> 
>   src/filewidgets/knewfilemenu.cpp a24ac9c 
> 
> Diff: https://git.reviewboard.kde.org/r/120599/diff/
> 
> 
> Testing
> ---
> 
> Tested in dolphin and now I'm able to create a new text file or link to an 
> application.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120519/#review68091
---

Ship it!


Seems sensible to me

- Lukáš Tinkl


On Říj. 7, 2014, 2:22 odp., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120519/
> ---
> 
> (Updated Říj. 7, 2014, 2:22 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Noticed that during startup something creates ~/.qttest directory, after a 
> bit of investigation, found that are those 2 misplaced lines...
> 
> 
> Diffs
> -
> 
>   src/sycoca/ksycoca.cpp a2c8c2f 
> 
> Diff: https://git.reviewboard.kde.org/r/120519/diff/
> 
> 
> Testing
> ---
> 
> on empty user/config, ~/.qttest no longer created/used
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120078: workaround QTBUG-40584

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120078/#review65919
---

Ship it!


\o/

- Lukáš Tinkl


On Zář. 6, 2014, 3:43 odp., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120078/
> ---
> 
> (Updated Zář. 6, 2014, 3:43 odp.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Bugs: 337353
> https://bugs.kde.org/show_bug.cgi?id=337353
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> This
> a) ensures there's windowaHandle() to restore the size for
> b) works around a pending Qt bug by explicitly coyping the restored QWindow 
> size to the QWidget size
> 
> also see https://git.reviewboard.kde.org/r/119594/
> 
> 
> Diffs
> -
> 
>   src/kmainwindow.cpp e273a76 
> 
> Diff: https://git.reviewboard.kde.org/r/120078/diff/
> 
> 
> Testing
> ---
> 
> Hrvoje, see bug - not tested myself.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120040: Install kdesu under bin

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120040/#review65734
---



kdesu/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120040/#comment45938>

The comment should probably also say "kdesu5"


I'm a bit worried by the multitude of user and distro specific scripts that 
rely on kdesu being present :/

- Lukáš Tinkl


On Zář. 2, 2014, 8:27 odp., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120040/
> ---
> 
> (Updated Zář. 2, 2014, 8:27 odp.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> this is a part of adressing the bug
> https://bugs.kde.org/show_bug.cgi?id=338755
> https://bugs.kde.org/show_bug.cgi?id=338756
> 
> in kde4 kdesu was installed under bin, and should still, being something that 
> should be invokable 
> but renames it to kdesu5, for coinstallability reasons
> 
> therefore, kio/src/core/desktopexecparser.cpp should be modified to search 
> for kdesu5 instead of kdesu
> 
> 
> Diffs
> -
> 
>   kdesu/CMakeLists.txt 2a70831 
> 
> Diff: https://git.reviewboard.kde.org/r/120040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119711/#review64290
---

Ship it!


Ship It!

- Lukáš Tinkl


On Srp. 11, 2014, 7:51 odp., Nicolas Lécureuil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119711/
> ---
> 
> (Updated Srp. 11, 2014, 7:51 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> Resolves the problem of passing relative vs. absolute 
> KF5_LIBEXEC_INSTALL_DIR/LIBEXEC_INSTALL_DIR. 
> 
> 
> Diffs
> -
> 
>   src/start_kdeinit/start_kdeinit.c 02d4d54 
>   src/start_kdeinit/start_kdeinit_wrapper.c f35c4a9 
>   src/config-kdeinit.h.cmake 76cd867 
>   src/kdeinit/CMakeLists.txt 8a84774 
>   src/kdeinit/kinit.cpp 296ebfd 
>   src/klauncher/CMakeLists.txt 8a251ff 
>   src/klauncher/klauncher.cpp 124011e 
>   src/start_kdeinit/CMakeLists.txt 56a91e3 
> 
> Diff: https://git.reviewboard.kde.org/r/119711/diff/
> 
> 
> Testing
> ---
> 
> Before it searches for /usr//usr/libexec and after all is fine.
> 
> 
> Thanks,
> 
> Nicolas Lécureuil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119711/#review64266
---


+1 from me, I'd wait for dfaure for the final "ship it" tho :)

- Lukáš Tinkl


On Srp. 11, 2014, 4:22 odp., Nicolas Lécureuil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119711/
> ---
> 
> (Updated Srp. 11, 2014, 4:22 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> Resolves the problem of passing relative vs. absolute 
> KF5_LIBEXEC_INSTALL_DIR/LIBEXEC_INSTALL_DIR. 
> 
> 
> Diffs
> -
> 
>   src/config-kdeinit.h.cmake 76cd867 
>   src/kdeinit/CMakeLists.txt 8a84774 
>   src/kdeinit/kinit.cpp 296ebfd 
>   src/klauncher/CMakeLists.txt 8a251ff 
>   src/klauncher/klauncher.cpp 124011e 
>   src/start_kdeinit/CMakeLists.txt 56a91e3 
>   src/start_kdeinit/start_kdeinit.c 02d4d54 
>   src/start_kdeinit/start_kdeinit_wrapper.c f35c4a9 
> 
> Diff: https://git.reviewboard.kde.org/r/119711/diff/
> 
> 
> Testing
> ---
> 
> Before it searches for /usr//usr/libexec and after all is fine.
> 
> 
> Thanks,
> 
> Nicolas Lécureuil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119711/#review64260
---


I'm getting this error:

chown: cannot access „/usr//usr/lib64/libexec/kf5/start_kdeinit“: Directory or 
file doesn't exist

- Lukáš Tinkl


On Srp. 11, 2014, 2:30 odp., Nicolas Lécureuil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119711/
> ---
> 
> (Updated Srp. 11, 2014, 2:30 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> Resolves the problem of passing relative vs. absolute 
> KF5_LIBEXEC_INSTALL_DIR/LIBEXEC_INSTALL_DIR. 
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.cpp 124011e 
>   src/start_kdeinit/CMakeLists.txt 56a91e3 
>   src/start_kdeinit/start_kdeinit.c 02d4d54 
>   src/start_kdeinit/start_kdeinit_wrapper.c f35c4a9 
>   src/config-kdeinit.h.cmake 76cd867 
>   src/kdeinit/CMakeLists.txt 8a84774 
>   src/kdeinit/kinit.cpp 296ebfd 
>   src/klauncher/CMakeLists.txt 8a251ff 
> 
> Diff: https://git.reviewboard.kde.org/r/119711/diff/
> 
> 
> Testing
> ---
> 
> Before it searches for /usr//usr/libexec and after all is fine.
> 
> 
> Thanks,
> 
> Nicolas Lécureuil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

[Lukáš Tinkl]

> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote:
> > No change here, ie. it doesn't restore the window geometry.
> 
> Martin Klapetek wrote:
> Same here, Qt 5.3.1. Thomas, which Qt are you using?
> 
> Nevertheless, as your knowledge about windows stuff is much better and if 
> you think this patch is needed anyway, go for it.

BTW this is my (earlier) attempt to fix this:  
http://developer.kde.org/~lukas/patches/kxmlgui-mainwindow-size.patch


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119593/#review63728
---


On Srp. 3, 2014, 9:13 odp., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119593/
> ---
> 
> (Updated Srp. 3, 2014, 9:13 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, 
> and Martin Klapetek.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> summarized
> 
> 
> Diffs
> -
> 
>   src/gui/kwindowconfig.cpp c3cefb7 
> 
> Diff: https://git.reviewboard.kde.org/r/119593/diff/
> 
> 
> Testing
> ---
> 
> See
> https://git.reviewboard.kde.org/r/119512/
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119594: fix FileDialog size restorage

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/#review63770
---

Ship it!


Great, this works for me :) Now what about 
https://git.reviewboard.kde.org/r/119593/

- Lukáš Tinkl


On Srp. 4, 2014, 1:57 odp., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119594/
> ---
> 
> (Updated Srp. 4, 2014, 1:57 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, 
> and Martin Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> - saving in the deconstrutor is insufficient,
>   the dialog might survive the runtime
>   -> needs to be saved when the dialog is finished or just closed
>   (the closeEvent is not invoked if at least a sync dialog is finished)
> 
> - ensure a windowHandle and then restore the window size before calling 
> ::exec()
> 
> - workaround an apparent QWidget QPA bug where even for a created platform 
> window
>   the QWindow geometry is not applied on the QWidget
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialogbase.cpp b823bc7 
>   src/platformtheme/kdeplatformfiledialogbase_p.h 8ef5b1e 
>   src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119594/diff/
> 
> 
> Testing
> ---
> 
> See
> https://git.reviewboard.kde.org/r/119512/
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

[Lukáš Tinkl]

> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote:
> > No change here, ie. it doesn't restore the file dialog geometry.
> 
> Thomas Lübking wrote:
> what is your precise testcase?
> a bit remote because of your other patches: did you check that the 
> correct platformtheme lib is used? (ran into this in a custom installation. 
> self compiled plugin ended up in a different path than the distro qt5 plugin 
> path)
> is the size data updated in kdeglobals?
> 
> Lukáš Tinkl wrote:
> Testcase: opening a filedialog in any Qt/KDE app, restarting the app -> 
> default file/window size
> 
> I guess I'm using the correct platformtheme, otherwise I wouldn't be 
> seeing KDE fialogs right? Also, toplevel windows are not restored either
> 
> Yup, the size is always correctly saved to the config files
> 
> Martin Klapetek wrote:
> I can also confirm that file dialogs do not have their size restored with 
> this patch (using tests/qfiledialogtest and also real dialogs around the 
> workspace), however testing the dir selection does give me properly restored 
> size dialog (./qfiledialogtest --staticFunction getExistingDirectory --modal 
> on). Qt 5.3.1 here.

Because KDirSelectDialog doesn't use KWindowConfig:


void KDirSelectDialog::Private::readConfig(const KSharedConfig::Ptr &config, 
const QString &group)   
{   
 
m_urlCombo->clear();
 

 
KConfigGroup conf(config, group);   
 
m_urlCombo->setHistoryItems(conf.readPathEntry("History Items", 
QStringList())); 

 
const QSize size = conf.readEntry("DirSelectDialog Size", QSize()); 
 
if (size.isValid()) {   
 
m_parent->resize(size); 
 
}   
 
}


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/#review63726
---


On Srp. 3, 2014, 9:16 odp., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119594/
> -------
> 
> (Updated Srp. 3, 2014, 9:16 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, 
> and Martin Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> summarized
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119594/diff/
> 
> 
> Testing
> ---
> 
> See
> https://git.reviewboard.kde.org/r/119512/
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

[Lukáš Tinkl]

> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote:
> > No change here, ie. it doesn't restore the file dialog geometry.
> 
> Thomas Lübking wrote:
> what is your precise testcase?
> a bit remote because of your other patches: did you check that the 
> correct platformtheme lib is used? (ran into this in a custom installation. 
> self compiled plugin ended up in a different path than the distro qt5 plugin 
> path)
> is the size data updated in kdeglobals?

Testcase: opening a filedialog in any Qt/KDE app, restarting the app -> default 
file/window size

I guess I'm using the correct platformtheme, otherwise I wouldn't be seeing KDE 
fialogs right? Also, toplevel windows are not restored either

Yup, the size is always correctly saved to the config files


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/#review63726
---


On Srp. 3, 2014, 9:16 odp., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119594/
> ---
> 
> (Updated Srp. 3, 2014, 9:16 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, 
> and Martin Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> summarized
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119594/diff/
> 
> 
> Testing
> ---
> 
> See
> https://git.reviewboard.kde.org/r/119512/
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/#review63726
---


No change here, ie. it doesn't restore the file dialog geometry.

- Lukáš Tinkl


On Srp. 3, 2014, 9:16 odp., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119594/
> ---
> 
> (Updated Srp. 3, 2014, 9:16 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, 
> and Martin Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> summarized
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119594/diff/
> 
> 
> Testing
> ---
> 
> See
> https://git.reviewboard.kde.org/r/119512/
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119593/#review63728
---


No change here, ie. it doesn't restore the window geometry.

- Lukáš Tinkl


On Srp. 3, 2014, 9:13 odp., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119593/
> ---
> 
> (Updated Srp. 3, 2014, 9:13 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, 
> and Martin Klapetek.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> summarized
> 
> 
> Diffs
> -
> 
>   src/gui/kwindowconfig.cpp c3cefb7 
> 
> Diff: https://git.reviewboard.kde.org/r/119593/diff/
> 
> 
> Testing
> ---
> 
> See
> https://git.reviewboard.kde.org/r/119512/
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/
---

(Updated Srp. 4, 2014, 12:49 dop.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin 
Klapetek.


Repository: frameworkintegration


Description
---

This patch tries to fix saving/restoring file dialog sizes. Using 
KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() 
methods. Instead, the patch uses the same method as KDirSelectDialog. 


Diffs
-

  src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
  src/platformtheme/kdirselectdialog.cpp 9a4082a 
  src/platformtheme/kdirselectdialog_p.h 5a8e758 

Diff: https://git.reviewboard.kde.org/r/119512/diff/


Testing
---

Current Plasma 5, working fine :)


Thanks,

Lukáš Tinkl

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119577: Allow translations to have context again.

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119577/#review63677
---

Ship it!


Translations might be broken due to 
https://bugreports.qt-project.org/browse/QTBUG-40444 , otherwise thanks for the 
fix!

- Lukáš Tinkl


On Srp. 2, 2014, 7:07 odp., Matthew Dawson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119577/
> ---
> 
> (Updated Srp. 2, 2014, 7:07 odp.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Bugs: 337979
> https://bugs.kde.org/show_bug.cgi?id=337979
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Allow translations to have context again.
> 
> Switch to using QT_TRANSLATE_NOOP3 so that context information can be
> given for actions, allowing the translators to do better translations.
> 
> BUG: 337979
> FIXED-IN: 5.1.0
> 
> I don't know if it is worthwhile to get this in for 5.1.0, or wait for 5.2.  
> Would it help the translators to get it in now?  If not, I'll get it in for 
> 5.2 (and update the FIXED-IN tag).
> 
> Also, is there an easy way to test translations?  It compiles, and the test 
> suite does run, but I don't have any translations so I don't know if it 
> actually works.  Any pointers to documentation would be great.
> 
> 
> Diffs
> -
> 
>   src/gui/kstandardshortcut.cpp eb50888a263e9662bdac6c3e046d653577c003e4 
> 
> Diff: https://git.reviewboard.kde.org/r/119577/diff/
> 
> 
> Testing
> ---
> 
> Compiles, test suite passes.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by 
> > calling ::winId(), then restore the size and ultimately ::exec()
> > 
> > Otherwise you could open an own nested eventloop instead of relying on the 
> > dialogs exec, but that'd be less elegant.
> > 
> > In either case I don't see why bringing your own config re/storage.
> 
> Lukáš Tinkl wrote:
> The trick with winId() unfortunately doesn't work, the dialog gets 
> restored to the default size, not the saved one... :/ Any other ideas?
> 
> Thomas Lübking wrote:
> I'm not gonna say "impossible", but the reason could then not be the 
> absence of a windowHandle()
> Eventually sth. alters the window size post the restore.
> 
> Have you checked for presence of a m_dialog->windowHandle() after calling 
> m_dialog->winId() and m_dialog->size() after calling 
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), 
> conf->group("FileDialogSize")); and before calling m_dialog->exec() ?
> 
> Martin Klapetek wrote:
> KWindowConfig::restoreWindowSize is broken for some reason.
> 
> I did some investigation and basically what happens is this:
>  - KWindowConfig::restoreWindowSize resutls in QXcbWindow::setGeometry 
> call
>  - geometry is set to the QWindow, but no to its QWidgets (no idea why)
>  - when event loop hits next loop, widgets are checked if their size >= 
> their min size
>  - because they didn't receive the updated geometry, this^ is not true
>  - the widgets get resized to their min size
>  - the window has a wrong geometry
> 
> I don't know why the widgets don't receive the event however, my 
> knowledge in this is lacking.
> 
> Lukáš Tinkl wrote:
> So how do we proceed with this one? Having tiny filedialogs is annoying 
> as hell...
> 
> Thomas Lübking wrote:
> Fix KWindowConfig::restoreWindowSize, I'd say.
> I assume calling
> 
> + window->create();
>     
> before "window->resize(width, height);" in 
> frameworks/kconfig/src/gui/kwindowconfig.cpp:81 should be be sufficient?
> (This should ensure d->platformWindow->setGeometry(QRect(position(), 
> newSize)); is called in QWindow::resize())
> 
> Lukáš Tinkl wrote:
> Nope, it didn't work unfortunately :/
> 
> Thomas Lübking wrote:
> You must still ensure that there's a QWindow before the Dialog::exec() 
> call, ie. calling ::winId() is still required in addition on this particular 
> case.
> 
> Lukáš Tinkl wrote:
> Done that, didn't help
> 
> Thomas Lübking wrote:
> What's your testcase on this?
> 
> QFileDialog *dlg = new QFileDialog;
> dlg->setFileMode(QFileDialog::Directory);
> dlg->setOption(QFileDialog::ShowDirsOnly);
> dlg->exec();
> 
> gets me a ::windowHandle() before, but *does* get me one after.
> 
> If I then call
> KSharedConfig::Ptr conf = KSharedConfig::openConfig();
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), 
> conf->group("FileDialogSize"));
> 
> and from there 
> window->create();
> right after the
> 
> if (!window) {
>return;
> }
> 
> check, I'm "sorry" to say, but the dialog size now _is_ restored for me.
> 
> 
> --
> What rather seems a problem is that the size does not get stored when eg. 
> closing the dialog via the titlebar "close" button.
> I've to say cancel or ok.
> 
> Lukáš Tinkl wrote:
> Yup, it works with a plain Q(File)Dialog, what doesn't work here is the 
> wrapper due to the abstraction layer in QPA imo
> 
> Thomas Lübking wrote:
> Humm? QFileDialog of course invokes the platformtheme if 
> XDG_CURRENT_DESKTOP is set to KDE.
> 
> 1. I could trace the invocation (strace/qDebug())
> 2. I get a "better" filedialog as compared to an unset (or different, the 
> Gtk+ thing sucks ;-) environment
> 
> With mentioned changes it /does/ work here using 
> /usr/lib/qt/plugins/platformthemes/KDEPlatformTheme.so, ie. this wrapper.
> 
> I'll add two RRs for it.

Great, thanks


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
---


On Čec. 28, 2014, 12:21 odp., Lukáš Tinkl wrot

Re: Review Request 119510: Fix untranslated menu entries

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119510/
---

(Updated Aug. 2, 2014, 8:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
---

This patch fixes QLocale usage in kbuildsycoca by not setting the default C 
locale when creating the sycoca database (leftover from a KLocale port?). 
Otherwise this results in menu entries being in English only (in effect 
KDesktopFile, KService and other classes returning the original strings instead 
of the uset-visible translated messages)


Diffs
-

  src/kbuildsycoca/kbuildsycoca.cpp 2f8405c 
  src/services/kservice.cpp c2b5ccf 

Diff: https://git.reviewboard.kde.org/r/119510/diff/


Testing
---

Current Plasma 5 workspace/desktop


File Attachments


translated systemsettings
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png


Thanks,

Lukáš Tinkl

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by 
> > calling ::winId(), then restore the size and ultimately ::exec()
> > 
> > Otherwise you could open an own nested eventloop instead of relying on the 
> > dialogs exec, but that'd be less elegant.
> > 
> > In either case I don't see why bringing your own config re/storage.
> 
> Lukáš Tinkl wrote:
> The trick with winId() unfortunately doesn't work, the dialog gets 
> restored to the default size, not the saved one... :/ Any other ideas?
> 
> Thomas Lübking wrote:
> I'm not gonna say "impossible", but the reason could then not be the 
> absence of a windowHandle()
> Eventually sth. alters the window size post the restore.
> 
> Have you checked for presence of a m_dialog->windowHandle() after calling 
> m_dialog->winId() and m_dialog->size() after calling 
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), 
> conf->group("FileDialogSize")); and before calling m_dialog->exec() ?
> 
> Martin Klapetek wrote:
> KWindowConfig::restoreWindowSize is broken for some reason.
> 
> I did some investigation and basically what happens is this:
>  - KWindowConfig::restoreWindowSize resutls in QXcbWindow::setGeometry 
> call
>  - geometry is set to the QWindow, but no to its QWidgets (no idea why)
>  - when event loop hits next loop, widgets are checked if their size >= 
> their min size
>  - because they didn't receive the updated geometry, this^ is not true
>  - the widgets get resized to their min size
>  - the window has a wrong geometry
> 
> I don't know why the widgets don't receive the event however, my 
> knowledge in this is lacking.
> 
> Lukáš Tinkl wrote:
> So how do we proceed with this one? Having tiny filedialogs is annoying 
> as hell...
> 
> Thomas Lübking wrote:
> Fix KWindowConfig::restoreWindowSize, I'd say.
> I assume calling
> 
> + window->create();
>     
> before "window->resize(width, height);" in 
> frameworks/kconfig/src/gui/kwindowconfig.cpp:81 should be be sufficient?
> (This should ensure d->platformWindow->setGeometry(QRect(position(), 
> newSize)); is called in QWindow::resize())
> 
> Lukáš Tinkl wrote:
> Nope, it didn't work unfortunately :/
> 
> Thomas Lübking wrote:
> You must still ensure that there's a QWindow before the Dialog::exec() 
> call, ie. calling ::winId() is still required in addition on this particular 
> case.
> 
> Lukáš Tinkl wrote:
> Done that, didn't help
> 
> Thomas Lübking wrote:
> What's your testcase on this?
> 
> QFileDialog *dlg = new QFileDialog;
> dlg->setFileMode(QFileDialog::Directory);
> dlg->setOption(QFileDialog::ShowDirsOnly);
> dlg->exec();
> 
> gets me a ::windowHandle() before, but *does* get me one after.
> 
> If I then call
> KSharedConfig::Ptr conf = KSharedConfig::openConfig();
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), 
> conf->group("FileDialogSize"));
> 
> and from there 
> window->create();
> right after the
> 
> if (!window) {
>return;
> }
> 
> check, I'm "sorry" to say, but the dialog size now _is_ restored for me.
> 
> 
> --
> What rather seems a problem is that the size does not get stored when eg. 
> closing the dialog via the titlebar "close" button.
> I've to say cancel or ok.

Yup, it works with a plain Q(File)Dialog, what doesn't work here is the wrapper 
due to the abstraction layer in QPA imo


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
---


On Čec. 28, 2014, 12:21 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> ---
> 
> (Updated Čec. 28, 2014, 12:21 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin 
> Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch tries to fix saving/restoring file dialog sizes. Using 

Re: Review Request 119562: Load polkit backends from installed location.

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119562/#review63631
---

Ship it!


Ship It!

- Lukáš Tinkl


On Srp. 1, 2014, 3:59 odp., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119562/
> ---
> 
> (Updated Srp. 1, 2014, 3:59 odp.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> Load polkit backends from installed location.
> 
> QCoreApplication::libraryPath() can be affected by the calling application, 
> which means KAuth can no longer find its own plugins.
> Added Debug showed it changing when I ran from systemsettings; sometimes 
> searching in libexec for some unknown reason.
> 
> Given we know the location that we install the plugins to, we can load
> them from that folder directly.
> 
> 
> Diffs
> -
> 
>   src/BackendsConfig.h.cmake 72ae77d 
>   src/BackendsManager.cpp 0dd4661 
> 
> Diff: https://git.reviewboard.kde.org/r/119562/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119540: don't construct bogus KAuthAction objects

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119540/#review63630
---

Ship it!


Ship It!

- Lukáš Tinkl


On Čec. 30, 2014, 2:32 dop., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119540/
> ---
> 
> (Updated Čec. 30, 2014, 2:32 dop.)
> 
> 
> Review request for KDE Frameworks, Hrvoje Senjan and Martin Bříza.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> KAuthAction(0) actually calls the QString constructor which will dispatch
> bogus polkit auth checks, polkitqt and polkitd are not terribly happy about
> those and subsequently don't want to talk to the KCM anymore, even if it
> manages to create a proper Action
> 
> creating a null Action rather than accidentally triggering the QString
> ctor ensures that we only do polkit interaction with reasonable actionids
> making sure that authentication works as expected
> 
> 
> Diffs
> -
> 
>   src/kcmodule.cpp 92e5427c121491e4ebf289addda040cc117cdd68 
> 
> Diff: https://git.reviewboard.kde.org/r/119540/diff/
> 
> 
> Testing
> ---
> 
> tested with clock kcm, succesfully can talk with the helper app if the bogus 
> actionid "" wasn't used intermediately
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by 
> > calling ::winId(), then restore the size and ultimately ::exec()
> > 
> > Otherwise you could open an own nested eventloop instead of relying on the 
> > dialogs exec, but that'd be less elegant.
> > 
> > In either case I don't see why bringing your own config re/storage.
> 
> Lukáš Tinkl wrote:
> The trick with winId() unfortunately doesn't work, the dialog gets 
> restored to the default size, not the saved one... :/ Any other ideas?
> 
> Thomas Lübking wrote:
> I'm not gonna say "impossible", but the reason could then not be the 
> absence of a windowHandle()
> Eventually sth. alters the window size post the restore.
> 
> Have you checked for presence of a m_dialog->windowHandle() after calling 
> m_dialog->winId() and m_dialog->size() after calling 
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), 
> conf->group("FileDialogSize")); and before calling m_dialog->exec() ?
> 
> Martin Klapetek wrote:
> KWindowConfig::restoreWindowSize is broken for some reason.
> 
> I did some investigation and basically what happens is this:
>  - KWindowConfig::restoreWindowSize resutls in QXcbWindow::setGeometry 
> call
>  - geometry is set to the QWindow, but no to its QWidgets (no idea why)
>  - when event loop hits next loop, widgets are checked if their size >= 
> their min size
>  - because they didn't receive the updated geometry, this^ is not true
>  - the widgets get resized to their min size
>  - the window has a wrong geometry
> 
> I don't know why the widgets don't receive the event however, my 
> knowledge in this is lacking.
> 
> Lukáš Tinkl wrote:
> So how do we proceed with this one? Having tiny filedialogs is annoying 
> as hell...
> 
> Thomas Lübking wrote:
> Fix KWindowConfig::restoreWindowSize, I'd say.
> I assume calling
> 
> + window->create();
>     
> before "window->resize(width, height);" in 
> frameworks/kconfig/src/gui/kwindowconfig.cpp:81 should be be sufficient?
> (This should ensure d->platformWindow->setGeometry(QRect(position(), 
> newSize)); is called in QWindow::resize())
> 
> Lukáš Tinkl wrote:
> Nope, it didn't work unfortunately :/
> 
> Thomas Lübking wrote:
> You must still ensure that there's a QWindow before the Dialog::exec() 
> call, ie. calling ::winId() is still required in addition on this particular 
> case.

Done that, didn't help


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
---


On Čec. 28, 2014, 12:21 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> ---
> 
> (Updated Čec. 28, 2014, 12:21 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin 
> Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch tries to fix saving/restoring file dialog sizes. Using 
> KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() 
> methods. Instead, the patch uses the same method as KDirSelectDialog. 
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
>   src/platformtheme/kdirselectdialog.cpp 9a4082a 
>   src/platformtheme/kdirselectdialog_p.h 5a8e758 
> 
> Diff: https://git.reviewboard.kde.org/r/119512/diff/
> 
> 
> Testing
> ---
> 
> Current Plasma 5, working fine :)
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by 
> > calling ::winId(), then restore the size and ultimately ::exec()
> > 
> > Otherwise you could open an own nested eventloop instead of relying on the 
> > dialogs exec, but that'd be less elegant.
> > 
> > In either case I don't see why bringing your own config re/storage.
> 
> Lukáš Tinkl wrote:
> The trick with winId() unfortunately doesn't work, the dialog gets 
> restored to the default size, not the saved one... :/ Any other ideas?
> 
> Thomas Lübking wrote:
> I'm not gonna say "impossible", but the reason could then not be the 
> absence of a windowHandle()
> Eventually sth. alters the window size post the restore.
> 
> Have you checked for presence of a m_dialog->windowHandle() after calling 
> m_dialog->winId() and m_dialog->size() after calling 
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), 
> conf->group("FileDialogSize")); and before calling m_dialog->exec() ?
> 
> Martin Klapetek wrote:
> KWindowConfig::restoreWindowSize is broken for some reason.
> 
> I did some investigation and basically what happens is this:
>  - KWindowConfig::restoreWindowSize resutls in QXcbWindow::setGeometry 
> call
>  - geometry is set to the QWindow, but no to its QWidgets (no idea why)
>  - when event loop hits next loop, widgets are checked if their size >= 
> their min size
>  - because they didn't receive the updated geometry, this^ is not true
>  - the widgets get resized to their min size
>  - the window has a wrong geometry
> 
> I don't know why the widgets don't receive the event however, my 
> knowledge in this is lacking.
> 
> Lukáš Tinkl wrote:
> So how do we proceed with this one? Having tiny filedialogs is annoying 
> as hell...
> 
> Thomas Lübking wrote:
> Fix KWindowConfig::restoreWindowSize, I'd say.
> I assume calling
> 
> + window->create();
> 
> before "window->resize(width, height);" in 
> frameworks/kconfig/src/gui/kwindowconfig.cpp:81 should be be sufficient?
> (This should ensure d->platformWindow->setGeometry(QRect(position(), 
> newSize)); is called in QWindow::resize())

Nope, it didn't work unfortunately :/


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
---


On Čec. 28, 2014, 12:21 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> ---
> 
> (Updated Čec. 28, 2014, 12:21 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin 
> Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch tries to fix saving/restoring file dialog sizes. Using 
> KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() 
> methods. Instead, the patch uses the same method as KDirSelectDialog. 
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
>   src/platformtheme/kdirselectdialog.cpp 9a4082a 
>   src/platformtheme/kdirselectdialog_p.h 5a8e758 
> 
> Diff: https://git.reviewboard.kde.org/r/119512/diff/
> 
> 
> Testing
> ---
> 
> Current Plasma 5, working fine :)
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119510: Fix untranslated menu entries

[Lukáš Tinkl]

> On Čec. 28, 2014, 8:12 odp., David Faure wrote:
> > I don't know about the bcp47 thing, but setting the locale to C is 
> > definitely definitely wrong.
> > 
> > This line of code in kdelibs4 was saying
> > 
> >// force generating of KLocale object. if not, the database will get
> >// be translated
> >KGlobal::locale();
> > 
> > +2 to removing that completely.
> 
> Lukáš Tinkl wrote:
> Here it returns just the language ("cs"), although the docu says: 
> "Returns the dash-separated language, script and country (and possibly other 
> BCP47 fields) of this locale as a string."
> 
> Anyway I don't think it matters much as long as the same entry gets 
> written into the database (lines 488 and 700)

Ship it?


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119510/#review63359
---


On Čec. 28, 2014, 4:28 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119510/
> ---
> 
> (Updated Čec. 28, 2014, 4:28 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This patch fixes QLocale usage in kbuildsycoca by not setting the default C 
> locale when creating the sycoca database (leftover from a KLocale port?). 
> Otherwise this results in menu entries being in English only (in effect 
> KDesktopFile, KService and other classes returning the original strings 
> instead of the uset-visible translated messages)
> 
> 
> Diffs
> -
> 
>   src/kbuildsycoca/kbuildsycoca.cpp 2f8405c 
>   src/services/kservice.cpp c2b5ccf 
> 
> Diff: https://git.reviewboard.kde.org/r/119510/diff/
> 
> 
> Testing
> ---
> 
> Current Plasma 5 workspace/desktop
> 
> 
> File Attachments
> 
> 
> translated systemsettings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by 
> > calling ::winId(), then restore the size and ultimately ::exec()
> > 
> > Otherwise you could open an own nested eventloop instead of relying on the 
> > dialogs exec, but that'd be less elegant.
> > 
> > In either case I don't see why bringing your own config re/storage.
> 
> Lukáš Tinkl wrote:
> The trick with winId() unfortunately doesn't work, the dialog gets 
> restored to the default size, not the saved one... :/ Any other ideas?
> 
> Thomas Lübking wrote:
> I'm not gonna say "impossible", but the reason could then not be the 
> absence of a windowHandle()
> Eventually sth. alters the window size post the restore.
> 
> Have you checked for presence of a m_dialog->windowHandle() after calling 
> m_dialog->winId() and m_dialog->size() after calling 
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), 
> conf->group("FileDialogSize")); and before calling m_dialog->exec() ?
> 
> Martin Klapetek wrote:
> KWindowConfig::restoreWindowSize is broken for some reason.
> 
> I did some investigation and basically what happens is this:
>  - KWindowConfig::restoreWindowSize resutls in QXcbWindow::setGeometry 
> call
>  - geometry is set to the QWindow, but no to its QWidgets (no idea why)
>  - when event loop hits next loop, widgets are checked if their size >= 
> their min size
>  - because they didn't receive the updated geometry, this^ is not true
>  - the widgets get resized to their min size
>  - the window has a wrong geometry
> 
> I don't know why the widgets don't receive the event however, my 
> knowledge in this is lacking.

So how do we proceed with this one? Having tiny filedialogs is annoying as 
hell...


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
---


On Čec. 28, 2014, 12:21 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> ---
> 
> (Updated Čec. 28, 2014, 12:21 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin 
> Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch tries to fix saving/restoring file dialog sizes. Using 
> KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() 
> methods. Instead, the patch uses the same method as KDirSelectDialog. 
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
>   src/platformtheme/kdirselectdialog.cpp 9a4082a 
>   src/platformtheme/kdirselectdialog_p.h 5a8e758 
> 
> Diff: https://git.reviewboard.kde.org/r/119512/diff/
> 
> 
> Testing
> ---
> 
> Current Plasma 5, working fine :)
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119510: Fix untranslated menu entries

[Lukáš Tinkl]

> On Čec. 28, 2014, 8:12 odp., David Faure wrote:
> > I don't know about the bcp47 thing, but setting the locale to C is 
> > definitely definitely wrong.
> > 
> > This line of code in kdelibs4 was saying
> > 
> >// force generating of KLocale object. if not, the database will get
> >// be translated
> >KGlobal::locale();
> > 
> > +2 to removing that completely.

Here it returns just the language ("cs"), although the docu says: "Returns the 
dash-separated language, script and country (and possibly other BCP47 fields) 
of this locale as a string."

Anyway I don't think it matters much as long as the same entry gets written 
into the database (lines 488 and 700)


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119510/#review63359
-------


On Čec. 28, 2014, 4:28 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119510/
> ---
> 
> (Updated Čec. 28, 2014, 4:28 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This patch fixes QLocale usage in kbuildsycoca by not setting the default C 
> locale when creating the sycoca database (leftover from a KLocale port?). 
> Otherwise this results in menu entries being in English only (in effect 
> KDesktopFile, KService and other classes returning the original strings 
> instead of the uset-visible translated messages)
> 
> 
> Diffs
> -
> 
>   src/kbuildsycoca/kbuildsycoca.cpp 2f8405c 
>   src/services/kservice.cpp c2b5ccf 
> 
> Diff: https://git.reviewboard.kde.org/r/119510/diff/
> 
> 
> Testing
> ---
> 
> Current Plasma 5 workspace/desktop
> 
> 
> File Attachments
> 
> 
> translated systemsettings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119510: Fix untranslated menu entries

[Lukáš Tinkl]

> On Čec. 28, 2014, 7:56 odp., Aleix Pol Gonzalez wrote:
> > src/services/kservice.cpp, line 57
> > <https://git.reviewboard.kde.org/r/119510/diff/1/?file=293809#file293809line57>
> >
> > Unrelated change, commit separately.

Ok, I'll make sure to split the commit into 2


On Čec. 28, 2014, 7:56 odp., Lukáš Tinkl wrote:
> > +1, makes sense to me. I'd like a  from one of our l10n gurus too. ;)

Fine, here's a +1 from me ;p


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119510/#review63356
-------


On Čec. 28, 2014, 4:28 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119510/
> ---
> 
> (Updated Čec. 28, 2014, 4:28 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This patch fixes QLocale usage in kbuildsycoca by not setting the default C 
> locale when creating the sycoca database (leftover from a KLocale port?). 
> Otherwise this results in menu entries being in English only (in effect 
> KDesktopFile, KService and other classes returning the original strings 
> instead of the uset-visible translated messages)
> 
> 
> Diffs
> -
> 
>   src/kbuildsycoca/kbuildsycoca.cpp 2f8405c 
>   src/services/kservice.cpp c2b5ccf 
> 
> Diff: https://git.reviewboard.kde.org/r/119510/diff/
> 
> 
> Testing
> ---
> 
> Current Plasma 5 workspace/desktop
> 
> 
> File Attachments
> 
> 
> translated systemsettings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119510: Fix untranslated menu entries

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119510/
---

(Updated Čec. 28, 2014, 4:28 odp.)


Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
---

This patch fixes QLocale usage in kbuildsycoca by not setting the default C 
locale when creating the sycoca database (leftover from a KLocale port?). 
Otherwise this results in menu entries being in English only (in effect 
KDesktopFile, KService and other classes returning the original strings instead 
of the uset-visible translated messages)


Diffs
-

  src/kbuildsycoca/kbuildsycoca.cpp 2f8405c 
  src/services/kservice.cpp c2b5ccf 

Diff: https://git.reviewboard.kde.org/r/119510/diff/


Testing
---

Current Plasma 5 workspace/desktop


File Attachments


translated systemsettings
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png


Thanks,

Lukáš Tinkl

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.h, line 53
> > <https://git.reviewboard.kde.org/r/119512/diff/1/?file=293814#file293814line53>
> >
> > this will also hit when the window is shaded, minimized or moved to 
> > another virtual desktop (unless the compositor keeps it open for other 
> > reasons)
> 
> Lukáš Tinkl wrote:
> The KDirSelectDialog does the same, hence why I reused it.

QPlatformDialogHelper has an abstract method hide(), I just moved the 
implementation up one level to the native QDialog


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
-------


On Čec. 28, 2014, 12:21 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> ---
> 
> (Updated Čec. 28, 2014, 12:21 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin 
> Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch tries to fix saving/restoring file dialog sizes. Using 
> KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() 
> methods. Instead, the patch uses the same method as KDirSelectDialog. 
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
>   src/platformtheme/kdirselectdialog.cpp 9a4082a 
>   src/platformtheme/kdirselectdialog_p.h 5a8e758 
> 
> Diff: https://git.reviewboard.kde.org/r/119512/diff/
> 
> 
> Testing
> ---
> 
> Current Plasma 5, working fine :)
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.h, line 53
> > <https://git.reviewboard.kde.org/r/119512/diff/1/?file=293814#file293814line53>
> >
> > this will also hit when the window is shaded, minimized or moved to 
> > another virtual desktop (unless the compositor keeps it open for other 
> > reasons)

The KDirSelectDialog does the same, hence why I reused it.


On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by 
> > calling ::winId(), then restore the size and ultimately ::exec()
> > 
> > Otherwise you could open an own nested eventloop instead of relying on the 
> > dialogs exec, but that'd be less elegant.
> > 
> > In either case I don't see why bringing your own config re/storage.

The trick with winId() unfortunately doesn't work, the dialog gets restored to 
the default size, not the saved one... :/ Any other ideas?


- Lukáš


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
---


On Čec. 28, 2014, 12:21 odp., Lukáš Tinkl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> ---
> 
> (Updated Čec. 28, 2014, 12:21 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin 
> Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch tries to fix saving/restoring file dialog sizes. Using 
> KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() 
> methods. Instead, the patch uses the same method as KDirSelectDialog. 
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
>   src/platformtheme/kdirselectdialog.cpp 9a4082a 
>   src/platformtheme/kdirselectdialog_p.h 5a8e758 
> 
> Diff: https://git.reviewboard.kde.org/r/119512/diff/
> 
> 
> Testing
> ---
> 
> Current Plasma 5, working fine :)
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/
---

(Updated July 28, 2014, 10:21 a.m.)


Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin 
Klapetek.


Repository: frameworkintegration


Description
---

This patch tries to fix saving/restoring file dialog sizes. Using 
KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() 
methods. Instead, the patch uses the same method as KDirSelectDialog. 


Diffs
-

  src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
  src/platformtheme/kdirselectdialog.cpp 9a4082a 
  src/platformtheme/kdirselectdialog_p.h 5a8e758 

Diff: https://git.reviewboard.kde.org/r/119512/diff/


Testing
---

Current Plasma 5, working fine :)


Thanks,

Lukáš Tinkl

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119349: typo in signal names ( upowermanager )

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119349/#review62638
---


Hmm, my upower (and also the newer one) has DeviceAdded/Removed signals... how 
did you come to this conclusion? Have you done any testing?

- Lukáš Tinkl


On Čec. 18, 2014, 7:31 dop., Ömer Fadıl Usta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119349/
> ---
> 
> (Updated Čec. 18, 2014, 7:31 dop.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> There were some typos for signals in upowermanager such as ;
> DeviceAdded   -- >  deviceAdded
> DeviceRemoved  -- > deviceRemoved
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/upower/upowermanager.cpp 53c8580 
> 
> Diff: https://git.reviewboard.kde.org/r/119349/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116116: Fix build with Qt 5.3

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116116/#review51335
---

Ship it!


Ship It!

- Lukáš Tinkl


On Feb. 27, 2014, 1:25 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116116/
> ---
> 
> (Updated Feb. 27, 2014, 1:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> Rename QByteArrayList to ByteArrayList and, while I was at it, QVariantMapMap 
> to VariantMapMap.
> 
> 
> Diffs
> -
> 
>   src/solid/backends/udisks2/dbus/manager.h 50481fa 
>   src/solid/backends/udisks2/udisks2.h ba8974a 
>   src/solid/backends/udisks2/udisksdevice.cpp 5208ece 
>   src/solid/backends/udisks2/udisksdevicebackend.h 691b5c6 
>   src/solid/backends/udisks2/udisksdevicebackend.cpp 3bbe787 
>   src/solid/backends/udisks2/udisksmanager.h 7382a1f 
>   src/solid/backends/udisks2/udisksmanager.cpp b6f3322 
>   src/solid/backends/udisks2/udisksstorageaccess.cpp edd7de8 
> 
> Diff: https://git.reviewboard.kde.org/r/116116/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108845/#review32960
---



tier1/solid/src/solid/processor.h
<http://git.reviewboard.kde.org/r/108845/#comment24419>

Is it intentional that IntelSse4 and IntelSse41 have the same value?


- Lukáš Tinkl


On Feb. 8, 2013, 2:09 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108845/
> ---
> 
> (Updated Feb. 8, 2013, 2:09 a.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Patrick von Reth.
> 
> 
> Description
> ---
> 
> This change implements cpu feature checks for MSVC. While at it, I added 
> support SSSE3 and SSE4.2 to the InstructionSets. I took the new values from 
> http://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits .
> 
> 
> Diffs
> -
> 
>   tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 
>   tier1/solid/src/solid/processor.h ce4f0e1 
> 
> Diff: http://git.reviewboard.kde.org/r/108845/diff/
> 
> 
> Testing
> ---
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel