Re: KHolidays as Framework (redux)
On Tuesday, 23 January 2018 18:36:10 CET Dominik Haumann wrote: > Another question: there are holiday files in the git repo. Are these files > compiled in as resource or loaded via filesystem? > > If these files are not added as resource, this probably breaks on Windows > and OSX. Good point, addressed in https://phabricator.kde.org/D10135 . Thanks, Volker > Am 20.01.2018 17:37 schrieb "Dominik Haumann" : > > Am 20.01.2018 17:22 schrieb "Volker Krause" : > > Thanks, should be fixed now. > > > Certainly better, although code examples and the like still would make a > significant difference ;) > > Cheers > Dominik > > On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: > > Hi, > > > > CC: only kdepim, kde-frameworks-devel > > > > I have some general comments about the API documentation. Looking at > > https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html > > the list mostly (only?) contains classes that are internal. Looking at > > https://github.com/KDE/kholidays/blob/master/src/holiday.h > > we can see documentation exists also for important classes, but the docs > > are not listed because the class documentation is missing. > > > > This is not a showstopper, but without accessible API, the visibility of > > this framework is much reduced. It would be nice, if the API documentation > > is complete, so here is still some room for improvement ;) > > > > Best regards > > Dominik > > > > > > > > Am 20.01.2018 11:39 schrieb "Volker Krause" : > > > > On Sunday, 14 January 2018 12:55:30 CET David Faure wrote: > > > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > > > Hi, > > > > > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at > > > > KHolidays > > > > > > > > > again > > > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > > > outstanding > > > > > > > porting issues with KHolidays and it is ready for review to be > > > > > > > included > > > > > > > as > > > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > > > step? > > > > > > > > > > > > Please make sure it passes all of the items in this checklist > > > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > > > actually being marked as a framework, which I guess is pending > > > > framework > > > > > > > approval. > > > > > > > > This got lost somehow, any objection to executing the move to > > frameworks > > > > > for 5.43, say end of this week? > > > > > > Go ahead. > > > > The necessary metainfo and CMake changes are pushed, the sysadmin ticket > > for > > > the repo metadata change is T7791. > > > > Summary: KHolidays will not be part of the 18.x KDE Application releases > > anymore, but instead become part of the KDE Frameworks releases with > > version > > > 5.43. There are no ABI or name changes, just the .so version increases > > from > > > 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully > > be > > > hardly noticeable. > > Side benefit: plasma-workspace no longer depends on a library from KDE > > Application releases. > > > > Regards, > > Volker signature.asc Description: This is a digitally signed message part.
Re: KHolidays as Framework (redux)
Another question: there are holiday files in the git repo. Are these files compiled in as resource or loaded via filesystem? If these files are not added as resource, this probably breaks on Windows and OSX. Best regards Dominik Am 20.01.2018 17:37 schrieb "Dominik Haumann" : Am 20.01.2018 17:22 schrieb "Volker Krause" : Thanks, should be fixed now. Certainly better, although code examples and the like still would make a significant difference ;) Cheers Dominik On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: > Hi, > > CC: only kdepim, kde-frameworks-devel > > I have some general comments about the API documentation. Looking at > https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html > the list mostly (only?) contains classes that are internal. Looking at > https://github.com/KDE/kholidays/blob/master/src/holiday.h > we can see documentation exists also for important classes, but the docs > are not listed because the class documentation is missing. > > This is not a showstopper, but without accessible API, the visibility of > this framework is much reduced. It would be nice, if the API documentation > is complete, so here is still some room for improvement ;) > > Best regards > Dominik > > > > Am 20.01.2018 11:39 schrieb "Volker Krause" : > > On Sunday, 14 January 2018 12:55:30 CET David Faure wrote: > > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > > Hi, > > > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at > > KHolidays > > > > > > > again > > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > > outstanding > > > > > > porting issues with KHolidays and it is ready for review to be > > > > > > included > > > > > > as > > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > > step? > > > > > > > > > > Please make sure it passes all of the items in this checklist > > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > > actually being marked as a framework, which I guess is pending > > framework > > > > > approval. > > > > > > This got lost somehow, any objection to executing the move to frameworks > > > for 5.43, say end of this week? > > > > Go ahead. > > The necessary metainfo and CMake changes are pushed, the sysadmin ticket for > the repo metadata change is T7791. > > Summary: KHolidays will not be part of the 18.x KDE Application releases > anymore, but instead become part of the KDE Frameworks releases with version > 5.43. There are no ABI or name changes, just the .so version increases from > 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be > hardly noticeable. > Side benefit: plasma-workspace no longer depends on a library from KDE > Application releases. > > Regards, > Volker
Re: KHolidays as Framework (redux)
Am 20.01.2018 17:22 schrieb "Volker Krause" : Thanks, should be fixed now. Certainly better, although code examples and the like still would make a significant difference ;) Cheers Dominik On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: > Hi, > > CC: only kdepim, kde-frameworks-devel > > I have some general comments about the API documentation. Looking at > https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html > the list mostly (only?) contains classes that are internal. Looking at > https://github.com/KDE/kholidays/blob/master/src/holiday.h > we can see documentation exists also for important classes, but the docs > are not listed because the class documentation is missing. > > This is not a showstopper, but without accessible API, the visibility of > this framework is much reduced. It would be nice, if the API documentation > is complete, so here is still some room for improvement ;) > > Best regards > Dominik > > > > Am 20.01.2018 11:39 schrieb "Volker Krause" : > > On Sunday, 14 January 2018 12:55:30 CET David Faure wrote: > > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > > Hi, > > > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at > > KHolidays > > > > > > > again > > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > > outstanding > > > > > > porting issues with KHolidays and it is ready for review to be > > > > > > included > > > > > > as > > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > > step? > > > > > > > > > > Please make sure it passes all of the items in this checklist > > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > > actually being marked as a framework, which I guess is pending > > framework > > > > > approval. > > > > > > This got lost somehow, any objection to executing the move to frameworks > > > for 5.43, say end of this week? > > > > Go ahead. > > The necessary metainfo and CMake changes are pushed, the sysadmin ticket for > the repo metadata change is T7791. > > Summary: KHolidays will not be part of the 18.x KDE Application releases > anymore, but instead become part of the KDE Frameworks releases with version > 5.43. There are no ABI or name changes, just the .so version increases from > 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be > hardly noticeable. > Side benefit: plasma-workspace no longer depends on a library from KDE > Application releases. > > Regards, > Volker
Re: KHolidays as Framework (redux)
Thanks, should be fixed now. On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: > Hi, > > CC: only kdepim, kde-frameworks-devel > > I have some general comments about the API documentation. Looking at > https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html > the list mostly (only?) contains classes that are internal. Looking at > https://github.com/KDE/kholidays/blob/master/src/holiday.h > we can see documentation exists also for important classes, but the docs > are not listed because the class documentation is missing. > > This is not a showstopper, but without accessible API, the visibility of > this framework is much reduced. It would be nice, if the API documentation > is complete, so here is still some room for improvement ;) > > Best regards > Dominik > > > > Am 20.01.2018 11:39 schrieb "Volker Krause" : > > On Sunday, 14 January 2018 12:55:30 CET David Faure wrote: > > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > > Hi, > > > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at > > KHolidays > > > > > > > again > > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > > outstanding > > > > > > porting issues with KHolidays and it is ready for review to be > > > > > > included > > > > > > as > > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > > step? > > > > > > > > > > Please make sure it passes all of the items in this checklist > > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > > actually being marked as a framework, which I guess is pending > > framework > > > > > approval. > > > > > > This got lost somehow, any objection to executing the move to frameworks > > > for 5.43, say end of this week? > > > > Go ahead. > > The necessary metainfo and CMake changes are pushed, the sysadmin ticket for > the repo metadata change is T7791. > > Summary: KHolidays will not be part of the 18.x KDE Application releases > anymore, but instead become part of the KDE Frameworks releases with version > 5.43. There are no ABI or name changes, just the .so version increases from > 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be > hardly noticeable. > Side benefit: plasma-workspace no longer depends on a library from KDE > Application releases. > > Regards, > Volker signature.asc Description: This is a digitally signed message part.
Re: KHolidays as Framework (redux)
Hi, CC: only kdepim, kde-frameworks-devel I have some general comments about the API documentation. Looking at https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html the list mostly (only?) contains classes that are internal. Looking at https://github.com/KDE/kholidays/blob/master/src/holiday.h we can see documentation exists also for important classes, but the docs are not listed because the class documentation is missing. This is not a showstopper, but without accessible API, the visibility of this framework is much reduced. It would be nice, if the API documentation is complete, so here is still some room for improvement ;) Best regards Dominik Am 20.01.2018 11:39 schrieb "Volker Krause" : On Sunday, 14 January 2018 12:55:30 CET David Faure wrote: > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > Hi, > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > > > again > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > outstanding > > > > > porting issues with KHolidays and it is ready for review to be > > > > > included > > > > > as > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > step? > > > > > > > > Please make sure it passes all of the items in this checklist > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > actually being marked as a framework, which I guess is pending framework > > > approval. > > > > This got lost somehow, any objection to executing the move to frameworks > > for 5.43, say end of this week? > > Go ahead. The necessary metainfo and CMake changes are pushed, the sysadmin ticket for the repo metadata change is T7791. Summary: KHolidays will not be part of the 18.x KDE Application releases anymore, but instead become part of the KDE Frameworks releases with version 5.43. There are no ABI or name changes, just the .so version increases from 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be hardly noticeable. Side benefit: plasma-workspace no longer depends on a library from KDE Application releases. Regards, Volker
Re: KHolidays as Framework (redux)
On Sunday, 14 January 2018 12:55:30 CET David Faure wrote: > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > Hi, > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > > > again > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > outstanding > > > > > porting issues with KHolidays and it is ready for review to be > > > > > included > > > > > as > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > step? > > > > > > > > Please make sure it passes all of the items in this checklist > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > actually being marked as a framework, which I guess is pending framework > > > approval. > > > > This got lost somehow, any objection to executing the move to frameworks > > for 5.43, say end of this week? > > Go ahead. The necessary metainfo and CMake changes are pushed, the sysadmin ticket for the repo metadata change is T7791. Summary: KHolidays will not be part of the 18.x KDE Application releases anymore, but instead become part of the KDE Frameworks releases with version 5.43. There are no ABI or name changes, just the .so version increases from 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be hardly noticeable. Side benefit: plasma-workspace no longer depends on a library from KDE Application releases. Regards, Volker signature.asc Description: This is a digitally signed message part.
Re: KHolidays as Framework (redux)
I'm wrong. the changes are BC since I'm just moving static functions around. Moving KHolidays anytime you want is fine with me. On Sunday, January 14, 2018 2:02:48 PM EST Volker Krause wrote: > On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote: > > @Volker: Is there a need to rush releasing KHolidays it under frameworks? > > this request is pending since more than 24 month, not exactly my definition > of > rushing things ;-) > > We should do the move reasonably early before the next application release > IMHO, so we don't collide with the pre-releases there. Apart from that I > don't > see any particular timing constraints. > > > As far I see it, the include mechanism do not change find_package do not > > need to change and also the target_libraries do not need to changed also > > the API is fixed so far -> no changes in kdepim needed. > > Exactly, it's all ready to go since two years. > > > The only thing that > > changes is the big bump of the version number and there will be some BIC > > cleanup, so there will be BIC breakage with that move. Distributions need > > to rebuild everything against the new framework. With only BIC changes > > there should be no big issue for distributions to ship a uptodate kdepim > > (17.12.X) with a uptodate KDE frameworks. > > Which BIC changes do you have in mind? The ABI has been stable since August > 2015 from what I can see. > > Regards, > Volker > > > PS: please also inform distributi...@kde.org, if the switch has a fixed > > date. > > On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote: > > > I don't object to making KHolidays a framework. > > > I kinda object to the short timeline. > > > > > > I wanted to finish up some BIC cleaning. No API changes planned at this > > > time. I'll try to hurry. > > > > > > On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > > > Hi, > > > > > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at > > > > > > > KHolidays > > > > > > > again > > > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > > > outstanding > > > > > > > porting issues with KHolidays and it is ready for review to be > > > > > > > included > > > > > > > as > > > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > > > step? > > > > > > > > > > > > Please make sure it passes all of the items in this checklist > > > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > > > actually being marked as a framework, which I guess is pending > > > > > framework > > > > > approval. > > > > > > > > This got lost somehow, any objection to executing the move to frameworks > > > > for 5.43, say end of this week? > > > > > > > > Regards, > > > > Volker -- Allen Winter | allen.win...@kdab.com | Senior Software Engineer KDAB (USA) LLC, a KDAB Group company Tel. USA +1-866-777-KDAB(5322) ext3 KDAB - The Qt, C++ and OpenGL Experts smime.p7s Description: S/MIME cryptographic signature
Re: KHolidays as Framework (redux)
On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote: > @Volker: Is there a need to rush releasing KHolidays it under frameworks? this request is pending since more than 24 month, not exactly my definition of rushing things ;-) We should do the move reasonably early before the next application release IMHO, so we don't collide with the pre-releases there. Apart from that I don't see any particular timing constraints. > As far I see it, the include mechanism do not change find_package do not > need to change and also the target_libraries do not need to changed also > the API is fixed so far -> no changes in kdepim needed. Exactly, it's all ready to go since two years. > The only thing that > changes is the big bump of the version number and there will be some BIC > cleanup, so there will be BIC breakage with that move. Distributions need > to rebuild everything against the new framework. With only BIC changes > there should be no big issue for distributions to ship a uptodate kdepim > (17.12.X) with a uptodate KDE frameworks. Which BIC changes do you have in mind? The ABI has been stable since August 2015 from what I can see. Regards, Volker > PS: please also inform distributi...@kde.org, if the switch has a fixed > date. > On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote: > > I don't object to making KHolidays a framework. > > I kinda object to the short timeline. > > > > I wanted to finish up some BIC cleaning. No API changes planned at this > > time. I'll try to hurry. > > > > On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > > Hi, > > > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at > > > > > > KHolidays > > > > > > again > > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > > outstanding > > > > > > porting issues with KHolidays and it is ready for review to be > > > > > > included > > > > > > as > > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > > step? > > > > > > > > > > Please make sure it passes all of the items in this checklist > > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > > actually being marked as a framework, which I guess is pending > > > > framework > > > > approval. > > > > > > This got lost somehow, any objection to executing the move to frameworks > > > for 5.43, say end of this week? > > > > > > Regards, > > > Volker signature.asc Description: This is a digitally signed message part.
Re: KHolidays as Framework (redux)
Hey, @Volker: Is there a need to rush releasing KHolidays it under frameworks? As far I see it, the include mechanism do not change find_package do not need to change and also the target_libraries do not need to changed also the API is fixed so far -> no changes in kdepim needed. The only thing that changes is the big bump of the version number and there will be some BIC cleanup, so there will be BIC breakage with that move. Distributions need to rebuild everything against the new framework. With only BIC changes there should be no big issue for distributions to ship a uptodate kdepim (17.12.X) with a uptodate KDE frameworks. sandro PS: please also inform distributi...@kde.org, if the switch has a fixed date. On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote: > I don't object to making KHolidays a framework. > I kinda object to the short timeline. > > I wanted to finish up some BIC cleaning. No API changes planned at this > time. I'll try to hurry. > > On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > Hi, > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > > > again > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > outstanding > > > > > porting issues with KHolidays and it is ready for review to be > > > > > included > > > > > as > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > step? > > > > > > > > Please make sure it passes all of the items in this checklist > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > actually being marked as a framework, which I guess is pending framework > > > approval. > > > > This got lost somehow, any objection to executing the move to frameworks > > for 5.43, say end of this week? > > > > Regards, > > Volker signature.asc Description: This is a digitally signed message part.
Re: KHolidays as Framework (redux)
I don't object to making KHolidays a framework. I kinda object to the short timeline. I wanted to finish up some BIC cleaning. No API changes planned at this time. I'll try to hurry. On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > Hi, > > > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > > again > > > > for inclusion as a Framework. As far as I am aware there are no > > > > outstanding > > > > porting issues with KHolidays and it is ready for review to be included > > > > as > > > > a Tier 1 Framework in the next possible release. What's the next step? > > > > > > Please make sure it passes all of the items in this checklist > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > AFAICS this is followed, apart from using the KF5 version number and > > actually being marked as a framework, which I guess is pending framework > > approval. > > This got lost somehow, any objection to executing the move to frameworks for > 5.43, say end of this week? > > Regards, > Volker
Re: KHolidays as Framework (redux)
On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > Hi, > > > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > > again > > > > for inclusion as a Framework. As far as I am aware there are no > > > > outstanding > > > > porting issues with KHolidays and it is ready for review to be > > > > included > > > > as > > > > a Tier 1 Framework in the next possible release. What's the next step? > > > > > > Please make sure it passes all of the items in this checklist > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > AFAICS this is followed, apart from using the KF5 version number and > > actually being marked as a framework, which I guess is pending framework > > approval. > > This got lost somehow, any objection to executing the move to frameworks for > 5.43, say end of this week? Go ahead. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: KHolidays as Framework (redux)
On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > On Friday 01 January 2016 18:24:17 David Faure wrote: > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > Hi, > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > again > > > for inclusion as a Framework. As far as I am aware there are no > > > outstanding > > > porting issues with KHolidays and it is ready for review to be included > > > as > > > a Tier 1 Framework in the next possible release. What's the next step? > > > > Please make sure it passes all of the items in this checklist > > https://community.kde.org/Frameworks/CreationGuidelines > > AFAICS this is followed, apart from using the KF5 version number and > actually being marked as a framework, which I guess is pending framework > approval. This got lost somehow, any objection to executing the move to frameworks for 5.43, say end of this week? Regards, Volker signature.asc Description: This is a digitally signed message part.
Re: KHolidays as Framework (redux)
On Friday 01 January 2016 18:24:17 David Faure wrote: > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > Hi, > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > > for inclusion as a Framework. As far as I am aware there are no > > outstanding > > porting issues with KHolidays and it is ready for review to be included as > > a Tier 1 Framework in the next possible release. What's the next step? > > Please make sure it passes all of the items in this checklist > https://community.kde.org/Frameworks/CreationGuidelines AFAICS this is followed, apart from using the KF5 version number and actually being marked as a framework, which I guess is pending framework approval. signature.asc Description: This is a digitally signed message part.
Re: KHolidays as Framework (redux)
On Thursday 24 December 2015 12:28:13 John Layt wrote: > Hi, > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > for inclusion as a Framework. As far as I am aware there are no outstanding > porting issues with KHolidays and it is ready for review to be included as > a Tier 1 Framework in the next possible release. What's the next step? Please make sure it passes all of the items in this checklist https://community.kde.org/Frameworks/CreationGuidelines -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KHolidays as Framework (redux)
On Thu, Dec 24, 2015 at 1:28 PM, John Layt wrote: > Hi, > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > for inclusion as a Framework. As far as I am aware there are no outstanding > porting issues with KHolidays and it is ready for review to be included as a > Tier 1 Framework in the next possible release. What's the next step? Move to > kdereview? > > There is the one issue with increasing the .so number to 6 that has been > raised for all the former kdepimlibs, what was the general consensus about > that? What should be happening now is that the library should be renamed to libKF5Holidays.so and we would get the number we want. kdereview isn't required as it's already part of the KDE released software. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KHolidays as Framework (redux)
Hi, It's xmas holidays, so it must be time to poke a stick at KHolidays again for inclusion as a Framework. As far as I am aware there are no outstanding porting issues with KHolidays and it is ready for review to be included as a Tier 1 Framework in the next possible release. What's the next step? Move to kdereview? There is the one issue with increasing the .so number to 6 that has been raised for all the former kdepimlibs, what was the general consensus about that? John. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
