Re: Dependency specifications

[Aleix Pol]

On Tue, Sep 10, 2013 at 7:42 PM, Michael Palimaka wrote:

> Hi,
>
> Currently, the specification for Qt dependencies is not always consistent
> between tier1 frameworks.
>
> In particular, I notice dependencies being specified twice (eg. QtTest in
> both project root and in autotests), and test dependencies split (eg.
> QtTest in project root only, and QtXml in autotests only).
>
> What is the intended behaviour? All dependencies specified in the project
> root? Common dependencies specified in the project root, and specific
> dependencies in directories that require them? Something else?
>
> Best regards,
> Michael
>
> __**_
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/**listinfo/kde-frameworks-devel
>

I'd say that all Qt dependencies in the module should be defined only once
in the root CMakeLists.txt. Actually this should be the only file with
"find_package" calls.

We could try an be stricter, but in practice what is useful for
distribution is the find_dependency call in the Config.cmake.in file...

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[David Faure]

On Thursday 12 September 2013 02:32:20 Aleix Pol wrote:
> I'd say that all Qt dependencies in the module should be defined only once
> in the root CMakeLists.txt. Actually this should be the only file with
> "find_package" calls.

And I disagree. If you build the framework with unittests disabled (like 
distros will probably do) then there's no point in searching for QtTest.
Modularity wins again, better do that inside the autotests subdir.

Apart from QtTest, I agree, though.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[Aleix Pol]

On Fri, Sep 13, 2013 at 9:43 AM, David Faure  wrote:

> On Thursday 12 September 2013 02:32:20 Aleix Pol wrote:
> > I'd say that all Qt dependencies in the module should be defined only
> once
> > in the root CMakeLists.txt. Actually this should be the only file with
> > "find_package" calls.
>
> And I disagree. If you build the framework with unittests disabled (like
> distros will probably do) then there's no point in searching for QtTest.
> Modularity wins again, better do that inside the autotests subdir.
>
> Apart from QtTest, I agree, though.
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>
Well, then let's make this a especial case for autotests/ and tests/. We
shouldn't have any find_package() within src/, and that's the case in many
places.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[David Faure]

On Friday 13 September 2013 13:03:29 Aleix Pol wrote:
> On Fri, Sep 13, 2013 at 9:43 AM, David Faure  wrote:
> > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote:
> > > I'd say that all Qt dependencies in the module should be defined only
> > 
> > once
> > 
> > > in the root CMakeLists.txt. Actually this should be the only file with
> > > "find_package" calls.
> > 
> > And I disagree. If you build the framework with unittests disabled (like
> > distros will probably do) then there's no point in searching for QtTest.
> > Modularity wins again, better do that inside the autotests subdir.
> > 
> > Apart from QtTest, I agree, though.
> > 
> > --
> > David Faure, fa...@kde.org, http://www.davidfaure.fr
> > Working on KDE, in particular KDE Frameworks 5
> 
> Well, then let's make this a especial case for autotests/ and tests/. We
> shouldn't have any find_package() within src/, and that's the case in many
> places.

Not tests/. That's for manual tests, no qtestlib there.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[Aleix Pol]

On Fri, Sep 13, 2013 at 1:17 PM, David Faure  wrote:

> On Friday 13 September 2013 13:03:29 Aleix Pol wrote:
> > On Fri, Sep 13, 2013 at 9:43 AM, David Faure  wrote:
> > > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote:
> > > > I'd say that all Qt dependencies in the module should be defined only
> > >
> > > once
> > >
> > > > in the root CMakeLists.txt. Actually this should be the only file
> with
> > > > "find_package" calls.
> > >
> > > And I disagree. If you build the framework with unittests disabled
> (like
> > > distros will probably do) then there's no point in searching for
> QtTest.
> > > Modularity wins again, better do that inside the autotests subdir.
> > >
> > > Apart from QtTest, I agree, though.
> > >
> > > --
> > > David Faure, fa...@kde.org, http://www.davidfaure.fr
> > > Working on KDE, in particular KDE Frameworks 5
> >
> > Well, then let's make this a especial case for autotests/ and tests/. We
> > shouldn't have any find_package() within src/, and that's the case in
> many
> > places.
>
> Not tests/. That's for manual tests, no qtestlib there.
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>
Well, but in that case you'll maybe want to find QtGui, QtWidgets or
KF5::AwesomeTests.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[David Faure]

On Friday 13 September 2013 13:17:47 Aleix Pol wrote:
> Well, but in that case you'll maybe want to find QtGui, QtWidgets or
> KF5::AwesomeTests.

Ah yes, true, manual tests can have more deps sometimes.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[Michael Palimaka]

On 12/09/2013 10:32, Aleix Pol wrote:

I'd say that all Qt dependencies in the module should be defined only
once in the root CMakeLists.txt. Actually this should be the only file
with "find_package" calls.
At a high level, that sounds reasonable, but I don't think this is 
necessarily the best solution for all cases. It it useful to hard-depend 
on, for example, QtTest and QtWidgets in the root, when they are only 
required by autotests (and one may choose not to build them)?



We could try an be stricter, but in practice what is useful for
distribution is the find_dependency call in the Config.cmake.in
 file...
While I am in favour of only depending on what's actually required for 
the build (which in my opinion is in the spirit of the individual 
frameworks thing), I am not too bothered either way.


My main motivation is to establish how things should be, and send a 
consistency patch. That will make it a little bit easier for packaging too.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[Stephen Kelly]

Aleix Pol wrote:

> I'd say that all Qt dependencies in the module should be defined only once
> in the root CMakeLists.txt. Actually this should be the only file with
> "find_package" calls.
> 

Why? What is the problem with having a find_package in src?

Thanks,

Steve.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[Aleix Pol]

On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly  wrote:

> Aleix Pol wrote:
>
> > I'd say that all Qt dependencies in the module should be defined only
> once
> > in the root CMakeLists.txt. Actually this should be the only file with
> > "find_package" calls.
> >
>
> Why? What is the problem with having a find_package in src?
>
> Thanks,
>
> Steve.
>
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

Well, it's good to have all the finders in the same place, to have a place
where to look when we need to see what a module works on.

That's of course debatable, but I'd like to push for this kind of
uniformity. Make things as the user/developer would expect them to be.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Dependency specifications

[Alexander Neundorf]

On Sunday 15 September 2013, Aleix Pol wrote:
> On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly  wrote:
> > Aleix Pol wrote:
> > > I'd say that all Qt dependencies in the module should be defined only
> > 
> > once
> > 
> > > in the root CMakeLists.txt. Actually this should be the only file with
> > > "find_package" calls.
> > 
> > Why? What is the problem with having a find_package in src?
> > 
> > Thanks,
> > 
> > Steve.
> > 
> > 
> > ___
> > Kde-frameworks-devel mailing list
> > Kde-frameworks-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 
> Well, it's good to have all the finders in the same place, to have a place
> where to look when we need to see what a module works on.
> 
> That's of course debatable, but I'd like to push for this kind of
> uniformity. Make things as the user/developer would expect them to be.

I agree with that.
For plugins it may be not as clear.
Still, if a plugin needs some additional package, the top level CMakeLists.txt 
can search for it and enable the plugin depending on whether it was found or 
not.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel