Re: Review Request 127031: Add function to get runtime frameworks version information

[Jarosław Staniek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review93814
---



Just wanted to say: thanks for this addition! It is useful for collecting 
feedback/support information (Kexi does it per user demand as a part of its QA 
-- https://blogs.kde.org/2013/12/09/usage-stats).

- Jarosław Staniek


On Feb. 25, 2016, 2:02 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 25, 2016, 2:02 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/
---

(Updated Feb. 25, 2016, 1:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 8e7c156b8c812cbeac499829c9874dfcf7e09a85 by David 
Edmundson to branch master.


Repository: kcoreaddons


Description
---

Adds a method similar to qVersion() that returns a string of the
frameworks version being run. This differs from the header file which
can only provide the version this app is compiled against.

The intended usage is in drkonqi system information.


Diffs
-

  src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
  src/lib/kcoreaddons.h PRE-CREATION 
  src/lib/kcoreaddons.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127031/diff/


Testing
---

See https://git.reviewboard.kde.org/r/127032/


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92697
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 23, 2016, 2:50 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 23, 2016, 2:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/
---

(Updated Feb. 23, 2016, 1:50 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Adds a method similar to qVersion() that returns a string of the
frameworks version being run. This differs from the header file which
can only provide the version this app is compiled against.

The intended usage is in drkonqi system information.


Diffs (updated)
-

  src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
  src/lib/kcoreaddons.h PRE-CREATION 
  src/lib/kcoreaddons.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127031/diff/


Testing
---

See https://git.reviewboard.kde.org/r/127032/


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[Kevin Funk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92564
---




src/lib/kcoreaddons.h (line 38)


Maybe also add a hint / some code which shows how to use that uint? I.e. 
point to Qt's QT_VERSION_CHECK documentation or copy/paste it.


- Kevin Funk


On Feb. 19, 2016, 12:46 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 19, 2016, 12:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92559
---



+1

- Aleix Pol Gonzalez


On Feb. 19, 2016, 1:46 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/
---

(Updated Feb. 19, 2016, 12:46 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Adds a method similar to qVersion() that returns a string of the
frameworks version being run. This differs from the header file which
can only provide the version this app is compiled against.

The intended usage is in drkonqi system information.


Diffs (updated)
-

  src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
  src/lib/kcoreaddons.h PRE-CREATION 
  src/lib/kcoreaddons.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127031/diff/


Testing
---

See https://git.reviewboard.kde.org/r/127032/


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92298
---




src/lib/kcoreaddons.h (line 33)


The docu is missing a @since 5.20

Also, while at it, I wonder if we should have ints for  major, minor, and 
patch, to be able to test this in code, not just print it out (I guess mostly 
for workarounds / adjusting for behaviour changes).


- David Faure


On Feb. 11, 2016, 12:53 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 11, 2016, 12:53 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92237
---



+1

- Martin Klapetek


On Feb. 10, 2016, 6:10 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 10, 2016, 6:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92245
---




src/lib/kcoreaddons.h (line 29)


Documntation is missing

Also "technically" one could mix and max versions even if we don't do it 
nor support it, but maybe we could call it just version() so it would be 
KCoreAddons::version() which give us a clear indication that in a world of mix 
& match this may b different frm KXMLGUI::version() (if it existed)

Or am i overthinking this?


- Albert Astals Cid


On Feb. 10, 2016, 5:10 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 10, 2016, 5:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[David Edmundson]

> On Feb. 10, 2016, 10:14 p.m., Albert Astals Cid wrote:
> > src/lib/kcoreaddons.h, line 29
> > 
> >
> > Documntation is missing
> > 
> > Also "technically" one could mix and max versions even if we don't do 
> > it nor support it, but maybe we could call it just version() so it would be 
> > KCoreAddons::version() which give us a clear indication that in a world of 
> > mix & match this may b different frm KXMLGUI::version() (if it existed)
> > 
> > Or am i overthinking this?

I did consider putting it in ECM so it was in every module, but it seemed over 
complex especially as some frameworks have multiple libs.
Also I can't imagine a situation where you'd really want to show more than one 
text label.

I'll do the rename though, that's a good compromise.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92245
---


On Feb. 10, 2016, 5:10 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 10, 2016, 5:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/
---

(Updated Feb. 11, 2016, 12:53 a.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Adds a method similar to qVersion() that returns a string of the
frameworks version being run. This differs from the header file which
can only provide the version this app is compiled against.

The intended usage is in drkonqi system information.


Diffs (updated)
-

  src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
  src/lib/kcoreaddons.h PRE-CREATION 
  src/lib/kcoreaddons.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127031/diff/


Testing
---

See https://git.reviewboard.kde.org/r/127032/


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

[Aleix Pol Gonzalez]

> On Feb. 10, 2016, 11:14 p.m., Albert Astals Cid wrote:
> > src/lib/kcoreaddons.h, line 29
> > 
> >
> > Documntation is missing
> > 
> > Also "technically" one could mix and max versions even if we don't do 
> > it nor support it, but maybe we could call it just version() so it would be 
> > KCoreAddons::version() which give us a clear indication that in a world of 
> > mix & match this may b different frm KXMLGUI::version() (if it existed)
> > 
> > Or am i overthinking this?
> 
> David Edmundson wrote:
> I did consider putting it in ECM so it was in every module, but it seemed 
> over complex especially as some frameworks have multiple libs.
> Also I can't imagine a situation where you'd really want to show more 
> than one text label.
> 
> I'll do the rename though, that's a good compromise.

Nope, we can't have a different version of KCoreAddons and KXMLGUI. (although I 
also prefer `::version()`).

+1 for docs.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92245
---


On Feb. 11, 2016, 1:53 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 11, 2016, 1:53 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel