Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-12-12 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/
---

(Updated Dec. 12, 2016, 9:32 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 19ecb443b39833ac0c6ecc64eb3c03fdab94ec15 by Jan Grulich 
to branch master.


Repository: kservice


Description
---

$SUMMARY says it all I guess, this patch allows to read X-KDE-RunOnDiscreteGpu 
property which can be now set from KPropertiesDialog, see review 129395. Also 
when running an application using KToolInvocation (e.g. when running an app 
from panel or desktop) take this property into account and set required 
variable accordingly.


Diffs
-

  src/services/kservice.h 66525b4 
  src/services/kservice.cpp 6574367 

Diff: https://git.reviewboard.kde.org/r/129396/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-12-04 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review101265
---


Fix it, then Ship it!





src/services/kservice.h (line 130)


5.30 at this point


- David Faure


On Nov. 29, 2016, 9:47 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Nov. 29, 2016, 9:47 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-29 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/
---

(Updated Lis. 29, 2016, 9:47 dop.)


Review request for KDE Frameworks and David Faure.


Changes
---

Move overriding DRI_PRIME variable into klauncher


Repository: kservice


Description
---

$SUMMARY says it all I guess, this patch allows to read X-KDE-RunOnDiscreteGpu 
property which can be now set from KPropertiesDialog, see review 129395. Also 
when running an application using KToolInvocation (e.g. when running an app 
from panel or desktop) take this property into account and set required 
variable accordingly.


Diffs (updated)
-

  src/services/kservice.h 66525b4 
  src/services/kservice.cpp 6574367 

Diff: https://git.reviewboard.kde.org/r/129396/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-26 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review101130
---




src/kdeinit/ktoolinvocation.cpp (line 103)


I would say this doesn't belong here.
This class is basically just a C++ API for the klauncher dbus api, which 
already has to lookup the KService anyway so it can read the new key while at 
it.


- David Faure


On Nov. 22, 2016, 12:11 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Nov. 22, 2016, 12:11 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/kdeinit/ktoolinvocation.cpp c9eb922 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-22 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/
---

(Updated Lis. 22, 2016, 12:11 odp.)


Review request for KDE Frameworks and David Faure.


Changes
---

Change DBus name -> use powerdevil instead


Repository: kservice


Description
---

$SUMMARY says it all I guess, this patch allows to read X-KDE-RunOnDiscreteGpu 
property which can be now set from KPropertiesDialog, see review 129395. Also 
when running an application using KToolInvocation (e.g. when running an app 
from panel or desktop) take this property into account and set required 
variable accordingly.


Diffs (updated)
-

  src/kdeinit/ktoolinvocation.cpp c9eb922 
  src/services/kservice.h 66525b4 
  src/services/kservice.cpp 6574367 

Diff: https://git.reviewboard.kde.org/r/129396/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-15 Thread Jan Grulich 


> On Lis. 14, 2016, 10:32 odp., David Faure wrote:
> > src/kdeinit/ktoolinvocation.cpp, line 107
> > 
> >
> > Err that's a weird D-Bus name, isn't it? Should this become a 
> > freedesktop standard?
> > Did you talk to hadess about it, before we make it a de-facto standard 
> > with a weird name?
> > 
> > 
> > And then why not standardize the name of the key in the .desktop file 
> > while at it?
> > 
> > x...@freedesktop.org is where to discuss both.
> 
> Jan Grulich wrote:
> I sent him an email and he responded that he is not interested in making 
> this a standard and doesn't consider this as a weird name. If the name 
> changes in future I hope they will at least keep the old service name for 
> backward compatibility, meanwhile I guess we have to keep this name.

After a discussion on #plasma we decided to implement this in powerdevil 
instead so we don't rely on 3rd party tool. Same applies for review 129399.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review100845
---


On Lis. 15, 2016, 7:58 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Lis. 15, 2016, 7:58 dop.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/kdeinit/ktoolinvocation.cpp c9eb922 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-15 Thread Jan Grulich 


> On Lis. 14, 2016, 10:32 odp., David Faure wrote:
> > src/kdeinit/ktoolinvocation.cpp, line 107
> > 
> >
> > Err that's a weird D-Bus name, isn't it? Should this become a 
> > freedesktop standard?
> > Did you talk to hadess about it, before we make it a de-facto standard 
> > with a weird name?
> > 
> > 
> > And then why not standardize the name of the key in the .desktop file 
> > while at it?
> > 
> > x...@freedesktop.org is where to discuss both.

I sent him an email and he responded that he is not interested in making this a 
standard and doesn't consider this as a weird name. If the name changes in 
future I hope they will at least keep the old service name for backward 
compatibility, meanwhile I guess we have to keep this name.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review100845
---


On Lis. 15, 2016, 7:58 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Lis. 15, 2016, 7:58 dop.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/kdeinit/ktoolinvocation.cpp c9eb922 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-14 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/
---

(Updated Lis. 15, 2016, 7:58 dop.)


Review request for KDE Frameworks and David Faure.


Changes
---

Fix description for the new method + add @since tag

Regarding the weird D-Bus name I'll try to talk to hadess about it.


Repository: kservice


Description
---

$SUMMARY says it all I guess, this patch allows to read X-KDE-RunOnDiscreteGpu 
property which can be now set from KPropertiesDialog, see review 129395. Also 
when running an application using KToolInvocation (e.g. when running an app 
from panel or desktop) take this property into account and set required 
variable accordingly.


Diffs (updated)
-

  src/kdeinit/ktoolinvocation.cpp c9eb922 
  src/services/kservice.h 66525b4 
  src/services/kservice.cpp 6574367 

Diff: https://git.reviewboard.kde.org/r/129396/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-14 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review100845
---




src/kdeinit/ktoolinvocation.cpp (line 107)


Err that's a weird D-Bus name, isn't it? Should this become a freedesktop 
standard?
Did you talk to hadess about it, before we make it a de-facto standard with 
a weird name?

And then why not standardize the name of the key in the .desktop file while 
at it?

x...@freedesktop.org is where to discuss both.



src/services/kservice.h (line 128)


cardsese?



src/services/kservice.h (line 129)


missing @since


- David Faure


On Nov. 14, 2016, 10:01 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Nov. 14, 2016, 10:01 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/kdeinit/ktoolinvocation.cpp c9eb922 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-14 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/
---

(Updated Lis. 14, 2016, 10:01 dop.)


Review request for KDE Frameworks and David Faure.


Changes
---

Use QString::left() when stripping down the .desktop suffix.


Repository: kservice


Description
---

$SUMMARY says it all I guess, this patch allows to read X-KDE-RunOnDiscreteGpu 
property which can be now set from KPropertiesDialog, see review 129395. Also 
when running an application using KToolInvocation (e.g. when running an app 
from panel or desktop) take this property into account and set required 
variable accordingly.


Diffs (updated)
-

  src/kdeinit/ktoolinvocation.cpp c9eb922 
  src/services/kservice.h 66525b4 
  src/services/kservice.cpp 6574367 

Diff: https://git.reviewboard.kde.org/r/129396/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-14 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review100831
---




src/kdeinit/ktoolinvocation.cpp (line 98)


Use left(...) - the file might have ".desktop" inside its filename, 
unlikely but possible.


- Kai Uwe Broulik


On Nov. 14, 2016, 8:29 vorm., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Nov. 14, 2016, 8:29 vorm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/kdeinit/ktoolinvocation.cpp c9eb922 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-14 Thread Jan Grulich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/
---

Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
---

$SUMMARY says it all I guess, this patch allows to read X-KDE-RunOnDiscreteGpu 
property which can be now set from KPropertiesDialog, see review 129395. Also 
when running an application using KToolInvocation (e.g. when running an app 
from panel or desktop) take this property into account and set required 
variable accordingly.


Diffs
-

  src/kdeinit/ktoolinvocation.cpp c9eb922 
  src/services/kservice.h 66525b4 
  src/services/kservice.cpp 6574367 

Diff: https://git.reviewboard.kde.org/r/129396/diff/


Testing
---


Thanks,

Jan Grulich