Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review79375
---



daemon/backends/upower/powerdevilupowerbackend.cpp (line 156)


Is it fine to use exec() here?


- Aleix Pol Gonzalez


On April 23, 2015, 1:05 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123475/
> ---
> 
> (Updated April 23, 2015, 1:05 p.m.)
> 
> 
> Review request for Plasma, Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> KJob::exec is dangerous and caused freezes on my system. Thus this change
> to remodel the interaction in an async way.
> 
> 
> Diffs
> -
> 
>   daemon/backends/upower/powerdevilupowerbackend.h 
> 1c4dd592f0a3cb07b9821c7f82c89517d599635a 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 
> 87b9cc7b7db1b6a6f5b31263cd3832715c497328 
> 
> Diff: https://git.reviewboard.kde.org/r/123475/diff/
> 
> 
> Testing
> ---
> 
> kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
> there a way to easily verify whether the module loaded completely?
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Martin Gräßlin 


> On April 23, 2015, 1:32 p.m., Aleix Pol Gonzalez wrote:
> > daemon/backends/upower/powerdevilupowerbackend.cpp, line 161
> > 
> >
> > Is it fine to use exec() here?

no, I missed that one :-(


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review79375
---


On April 23, 2015, 1:05 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123475/
> ---
> 
> (Updated April 23, 2015, 1:05 p.m.)
> 
> 
> Review request for Plasma, Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> KJob::exec is dangerous and caused freezes on my system. Thus this change
> to remodel the interaction in an async way.
> 
> 
> Diffs
> -
> 
>   daemon/backends/upower/powerdevilupowerbackend.h 
> 1c4dd592f0a3cb07b9821c7f82c89517d599635a 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 
> 87b9cc7b7db1b6a6f5b31263cd3832715c497328 
> 
> Diff: https://git.reviewboard.kde.org/r/123475/diff/
> 
> 
> Testing
> ---
> 
> kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
> there a way to easily verify whether the module loaded completely?
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/
---

(Updated April 24, 2015, 8:29 a.m.)


Review request for Solid and Kai Uwe Broulik.


Changes
---

Made the brightnessMaxJob async.


Repository: powerdevil


Description
---

KJob::exec is dangerous and caused freezes on my system. Thus this change
to remodel the interaction in an async way.


Diffs (updated)
-

  daemon/backends/upower/powerdevilupowerbackend.h 
1c4dd592f0a3cb07b9821c7f82c89517d599635a 
  daemon/backends/upower/powerdevilupowerbackend.cpp 
87b9cc7b7db1b6a6f5b31263cd3832715c497328 

Diff: https://git.reviewboard.kde.org/r/123475/diff/


Testing
---

kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
there a way to easily verify whether the module loaded completely?


Thanks,

Martin Gräßlin

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-05-10 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review80178
---



daemon/backends/upower/powerdevilupowerbackend.cpp (line 170)


Somehow that code path is never executed making init stuck when XRandR is 
not supported, however, I don't know why that is. The brightnessmaxjob works 
fine but the syspath thing doesn't.


- Kai Uwe Broulik


On April 24, 2015, 6:29 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123475/
> ---
> 
> (Updated April 24, 2015, 6:29 vorm.)
> 
> 
> Review request for Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> KJob::exec is dangerous and caused freezes on my system. Thus this change
> to remodel the interaction in an async way.
> 
> 
> Diffs
> -
> 
>   daemon/backends/upower/powerdevilupowerbackend.h 
> 1c4dd592f0a3cb07b9821c7f82c89517d599635a 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 
> 87b9cc7b7db1b6a6f5b31263cd3832715c497328 
> 
> Diff: https://git.reviewboard.kde.org/r/123475/diff/
> 
> 
> Testing
> ---
> 
> kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
> there a way to easily verify whether the module loaded completely?
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-05-11 Thread Martin Gräßlin 


> On May 10, 2015, 7:08 p.m., Kai Uwe Broulik wrote:
> > daemon/backends/upower/powerdevilupowerbackend.cpp, line 175
> > 
> >
> > Somehow that code path is never executed making init stuck when XRandR 
> > is not supported, however, I don't know why that is. The brightnessmaxjob 
> > works fine but the syspath thing doesn't.

any ideas how we can test it? Was it working before at all?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review80178
---


On April 24, 2015, 8:29 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123475/
> ---
> 
> (Updated April 24, 2015, 8:29 a.m.)
> 
> 
> Review request for Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> KJob::exec is dangerous and caused freezes on my system. Thus this change
> to remodel the interaction in an async way.
> 
> 
> Diffs
> -
> 
>   daemon/backends/upower/powerdevilupowerbackend.h 
> 1c4dd592f0a3cb07b9821c7f82c89517d599635a 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 
> 87b9cc7b7db1b6a6f5b31263cd3832715c497328 
> 
> Diff: https://git.reviewboard.kde.org/r/123475/diff/
> 
> 
> Testing
> ---
> 
> kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
> there a way to easily verify whether the module loaded completely?
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-05-11 Thread Kai Uwe Broulik 


> On Mai 10, 2015, 5:08 nachm., Kai Uwe Broulik wrote:
> > daemon/backends/upower/powerdevilupowerbackend.cpp, line 175
> > 
> >
> > Somehow that code path is never executed making init stuck when XRandR 
> > is not supported, however, I don't know why that is. The brightnessmaxjob 
> > works fine but the syspath thing doesn't.
> 
> Martin Gräßlin wrote:
> any ideas how we can test it? Was it working before at all?

Just return false in XRandrBrightness::isSupported() to force it into the 
brightness helper code path.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review80178
---


On April 24, 2015, 6:29 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123475/
> ---
> 
> (Updated April 24, 2015, 6:29 vorm.)
> 
> 
> Review request for Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> KJob::exec is dangerous and caused freezes on my system. Thus this change
> to remodel the interaction in an async way.
> 
> 
> Diffs
> -
> 
>   daemon/backends/upower/powerdevilupowerbackend.h 
> 1c4dd592f0a3cb07b9821c7f82c89517d599635a 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 
> 87b9cc7b7db1b6a6f5b31263cd3832715c497328 
> 
> Diff: https://git.reviewboard.kde.org/r/123475/diff/
> 
> 
> Testing
> ---
> 
> kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
> there a way to easily verify whether the module loaded completely?
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-07-10 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/
---

(Updated July 10, 2015, 3:23 p.m.)


Review request for Solid and Kai Uwe Broulik.


Changes
---

moved the syspath job into the lambda for the max job. On a Plasma/Wayland 
session I get debug output for the execution of the job. So seems to work ;-)


Repository: powerdevil


Description
---

KJob::exec is dangerous and caused freezes on my system. Thus this change
to remodel the interaction in an async way.


Diffs (updated)
-

  daemon/backends/upower/powerdevilupowerbackend.h 
1c4dd592f0a3cb07b9821c7f82c89517d599635a 
  daemon/backends/upower/powerdevilupowerbackend.cpp 
87b9cc7b7db1b6a6f5b31263cd3832715c497328 

Diff: https://git.reviewboard.kde.org/r/123475/diff/


Testing
---

kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
there a way to easily verify whether the module loaded completely?


Thanks,

Martin Gräßlin

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-07-10 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review82337
---

Ship it!


Thanks! Both XRandrBrightness and the helper still work for me.

- Kai Uwe Broulik


On Juli 10, 2015, 1:23 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123475/
> ---
> 
> (Updated Juli 10, 2015, 1:23 nachm.)
> 
> 
> Review request for Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> KJob::exec is dangerous and caused freezes on my system. Thus this change
> to remodel the interaction in an async way.
> 
> 
> Diffs
> -
> 
>   daemon/backends/upower/powerdevilupowerbackend.h 
> 1c4dd592f0a3cb07b9821c7f82c89517d599635a 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 
> 87b9cc7b7db1b6a6f5b31263cd3832715c497328 
> 
> Diff: https://git.reviewboard.kde.org/r/123475/diff/
> 
> 
> Testing
> ---
> 
> kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
> there a way to easily verify whether the module loaded completely?
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-07-11 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/
---

(Updated July 11, 2015, 8:01 a.m.)


Status
--

This change has been marked as submitted.


Review request for Solid and Kai Uwe Broulik.


Changes
---

Submitted with commit 3b56856d66f392bf18343f3b45f35da40813509f by Martin 
Gräßlin to branch master.


Repository: powerdevil


Description
---

KJob::exec is dangerous and caused freezes on my system. Thus this change
to remodel the interaction in an async way.


Diffs
-

  daemon/backends/upower/powerdevilupowerbackend.h 
1c4dd592f0a3cb07b9821c7f82c89517d599635a 
  daemon/backends/upower/powerdevilupowerbackend.cpp 
87b9cc7b7db1b6a6f5b31263cd3832715c497328 

Diff: https://git.reviewboard.kde.org/r/123475/diff/


Testing
---

kded5 no longer freezes. But I'm not sure whether the init gets finished: is 
there a way to easily verify whether the module loaded completely?


Thanks,

Martin Gräßlin

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel