date:20191028

[Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23668] Manual on patron import: Information on syntax for patron attributes

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23668

Danielle Elder  changed:

   What|Removed |Added

 CC||danielle@bywatersolutions.c
   ||om

--- Comment #2 from Danielle Elder  ---
I found that importing two patron attributes using command line patron import
tool at once does not work if there is a comman in the attribute value. 

Two attributes, as the patron import tools recommends.Not OK.

"ATTR1:BLUE","ATTR2:RED" 

Loads
ATTR1:BLUE
ATTR2: 
_
Two no space, no comma OK

"ATTR1:BLUE,ATTR2:Red" 

Loads
ATTR1:BLUE
ATTR2: Red

Two with spaces OK:
"ATTR1:BLUE DOG, ATTR2:Red FISH" 

Loads
ATTR1:BLUE DOG
ATTR2: Red FISH
__

Two with a comma - not OK
"ATTR1:BLUE DOG,ATTR2:Red, FISH" 

Loads
ATTR1:BLUE DOG
ATTR2: Red
__

Two with a comma - not OK
"ATTR1:BLUE, DOG","ATTR2:Red FISH" 

Loads
ATTR1:BLUE
ATTR2: 
_

"ATTR1:BLUE, Fish,ATTR2:Red Dog"
Loads
ATTR1:BLUE
ATTR2: Red Dog


_

One with comma does not work:

"ATTR1: Value, 1"

Loads
ATTR1: Value

The commas seem to be the problem in attributes unless separating attributes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23890] Plugins that utilise possibly security breaching hooks should warn

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23890

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23805] Add a dedicated credit_types table

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

--- Comment #45 from Julian Maurice  ---
It looks like it doesn't work. I get the same error message, and I added a warn
below `# MariaDB specific drop` and it is not displayed.
DBI is not dying (RaiseError is set to 0 at the beginning of updatedatabase.pl)

Maybe the problem could be avoided by changing the other queries. Currently the
order is:
1. Drop check constraint
2. accounttype = NEW_CODE(accounttype)
3. credit_type_code = accounttype
4. Drop accounttype

Instead we can do:
1. credit_type_code = NEW_CODE(accounttype)
2. Drop accounttype

This way, no need to drop the check constraint first (because accounttype is
not changed), and it is dropped automatically when the column is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23541] Duplicate Hold Notifications

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

--- Comment #2 from AspenCat Team  ---
One of our libraries reported this happening again.  We've seen this a number
of times now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

--- Comment #29 from Bouzid Fergani  ---
I rebased the bug 11299 and test this.
Thanks.
Bouzid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #79400|0   |1
is obsolete||

--- Comment #28 from Bouzid Fergani  ---
Created attachment 94819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94819=edit
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #79545|0   |1
is obsolete||

--- Comment #100 from Bouzid Fergani  ---
Created attachment 94818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94818=edit
Bug 11299 - Add a button to the biblio edition page to automatically add
authority links in the current biblio record via AJAX. Also adds a button to
easily create missing authority records.

add authority type in the form to create the missing  authority.
 when authority was found, the 600$9 field have the authid.

Testing scenario (Creating an authority record for a failed automatic link) :

 * In you system preferences, deactivate the "AutoCreateAuthorities"
preference.
 * Go to the biblio record creation form to create a new biblio record.
(koha/cataloguing/addbiblio.pl)
 * Click the "Link authorities automatically" button. A message should appear,
telling the user "No authority link was changed."
 * Add random informations in field 600$a of the biblio record.
 * Click the "Link authorities automatically" button.
   * if matching authority was found,  The message box should now show "600 - A
matching authority was found in the local database".
   * if no matching authority was found, the message box should now show  "600
- No matching authority found.".  For this scenario, we want the authority
match to have failed.
 * The 600$9 field should now be red and icons should have appeared next to
it. Click on the "create authority" icon.
 * A popup will appear, containing a form to create the missing  authority.
The form should be pre-filled, a the informations in the 600$a field of the
biblio shouldbe in the 100$a field of this new authority record.
 * Fill in the form and click the "Save" button
 * The 600$9 field in the biblio record should now be back to normal and have
the authid of the authority record that was just created.
 * Click the "Link authorities automatically" button again. The message box
should now show "No authority link was changed.".

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Bouzid Fergani  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22832] Require plugins to specify the methods they implement

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23890

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23890] Plugins that utilise possibly security breaching hooks should warn

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23890

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22832

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23890] Plugins that utilise possibly security breaching hooks should warn

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23890

--- Comment #2 from Martin Renvoize  ---
I've changed my mind on this one... whilst going through existing hooks and
trying to pick which methods potentially exposed us to nefarious code I pretty
much decided that they all could.

+'opac_online_payment' => '1',
+'opac_online_payment_end' => '1',
+'opac_online_payment_begin'   => '1',
+'to_marc' => '1',
+'edifact_transport'   => '1',
+'edifact_process_invoice' => '1',
+'edifact_order'   => '1',
+'edifact' => '1',
+'opac_head'   => '1',
+'opac_js' => '1',
+'intranet_head'   => '1',
+'intranet_js' => '1',
+'intranet_catalog_biblio_enhancements_toolbar_button' => '1',

As such, I think warning on some but not others could actually lead us to worse
situation where inexperienced system administrators are lulled into a false
sense of security.

In reality, I feel we need a cleaner delivery method for plugins as a community
and perhaps a signing procedure to state a certain level of trust/quality. 
This is something I've wanted to work on for some time but not had a moment to
implement to date.

As such, I don't believe this should hold up bug 22706.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

--- Comment #1 from Owen Leonard  ---
Created attachment 94817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94817=edit
Bug 23915: Replace OPAC list sort menu with Bootstrap menu button

This patch adds JavaScript to the list contents page which converts the
resort form's  menu into a Bootstrap dropdown menu. This allows
for a more compact and consistent display.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View a list in the OPAC. The toolbar of list controls ("New list,"
"Download list," etc.) should have a similary-styled "Sort" button. Each
sorting option should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23915


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915
[Bug 23915] Replace OPAC list sort menu with Bootstrap menu button
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23915] New: Replace OPAC list sort menu with Bootstrap menu button

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Bug ID: 23915
   Summary: Replace OPAC list sort menu with Bootstrap menu button
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 23913

Created attachment 94816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94816=edit
Screenshot showing the new menu button (in its active state)

After consolidating the menus in Bug 23913, the structure of the resort form
lends itself to being replaced, via JavaScript with a Bootstrap menu button.
This allows for a more compact toolbar.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913
[Bug 23913] Use a single menu to sort lists in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825

--- Comment #18 from Tomás Cohen Arazi  ---
I'm having trouble reproducing this issue. Can you elaborate on the
MySQL/MariaDB versions you are testing in?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23914] New: SQL Server Version

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914

Bug ID: 23914
   Summary: SQL Server Version
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hea
  Assignee: ch...@bigballofwax.co.nz
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: jonathan.dru...@bugs.koha-community.org

It would be really interesting to collect the sql server versions people are
using in HEA.  I'm interested to see what the adoption of MariaDB is and
whether we can start adopting more recently introduced features from either
MySQL or MariaDB (like CHECK constraints).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23805] Add a dedicated credit_types table

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

--- Comment #44 from Martin Renvoize  ---
I tried a few solutions but this one seemed to be the most reliable.. any
chance you could test this for me Julian?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23805] Add a dedicated credit_types table

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

--- Comment #43 from Martin Renvoize  ---
Created attachment 94815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94815=edit
Bug 23805: (RM follow-up) updatedatabase.pl mariadb support

MySQL and MariaDB have different syntax when it comes to dropping a
CHECK constraint.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913

--- Comment #1 from Owen Leonard  ---
Created attachment 94814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94814=edit
Bug 23913: Use a single menu to sort lists in the OPAC

This patch modifies the sorting form on the OPAC list contents view so
that the two menus (sort field and direction) are combined into one.
This makes it consistent with the sort menu on the search results page.

To test, apply the patch and view a list with multiple titles on it.

Test the "Sort by" menu, trying all the various options. Confirm that
the pre-selected item in the sorting menu is correct after each re-sort.

Edit the list to change the default sorting and verify that the "Sort
by" menu reflects your selection.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23908] Require patrons to confirm their email address

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913

Owen Leonard  changed:

   What|Removed |Added

 Depends on||23903


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903
[Bug 23903] Replace OPAC icons with Font Awesome
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23913


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913
[Bug 23913] Use a single menu to sort lists in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23913] New: Use a single menu to sort lists in the OPAC

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913

Bug ID: 23913
   Summary: Use a single menu to sort lists in the OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Right now in the OPAC the controls for re-sorting a list uses two menus: One
for the sort field and one for the direction. I think these should be combined
like they are on the search results page.

Instead of having:

Sort by: [Author] [Ascending]

We should have:

Sort by:

[ Author
  --
  Author (A-Z)
  Author (Z-A) ]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23912] Get correct authorised values for location and collections facets

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

Lari Taskula  changed:

   What|Removed |Added

  Component|Architecture, internals,|Searching - Zebra
   |and plumbing|
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23912] Get correct authorised values for location and collections facets

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

--- Comment #4 from Lari Taskula  ---
Created attachment 94813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94813=edit
Bug 23912: Use C4::Context->interface instead of passing $opac

Since most of Koha's codebase using getRecords() is not passing $opac into the
subroutine (the only exception being opac-search.pl and search.pl), remove
parameter $opac from list of subroutine parameters and replace the
functionality
with C4::Context->interface.

To test:
1. See test plan of the previous patch

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23912] Get correct authorised values for location and collections facets

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

Lari Taskula  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23912] Get correct authorised values for location and collections facets

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

--- Comment #3 from Lari Taskula  ---
Created attachment 94812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94812=edit
Bug 23912: Get correct authorised value description for location and ccode
facets in intranet

Bug 17248 made C4::Search::getRecords() parameter $opac unused and causes
location and collection facets to prefer OPAC description over intranet
one in all interfaces, including intranet itself.

This patch restores the functionality provided by $opac parameter.

To reproduce:
1. Go to /cgi-bin/koha/admin/authorised_values.pl?searchfield=LOC and change
   both Description and Description (OPAC) of one row to be different
2. Do the same for /cgi-bin/koha/admin/authorised_values.pl?searchfield=CCODE
3. In intranet, search a record and make sure you are able to see facets after
   performing the search (your search must return multiple records)
4. Add/edit an item of one of these biblios on your results screen
5. Give this item the location and collection code that you changed in steps
1&2
6. In intranet, perform the same search from step 3 again
7. Observe your location and collections facets show Description (OPAC) value
   from step 1 and 2 instead of Description.

To test:
1. Apply patch
2. Try to reproduce the bug again in intranet
3. Observe you will now see Description value instead of Description (OPAC)
4. prove t/db_dependent/Search.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

Lari Taskula  changed:

   What|Removed |Added

 Blocks||23912


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912
[Bug 23912] Get correct authorised values for location and collections facets
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23912] Get correct authorised values for location and collections facets

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

Lari Taskula  changed:

   What|Removed |Added

 Depends on||17248


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248
[Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #6 from Nick Clemens  ---
(In reply to Joonas Kylmälä from comment #5)
> 
> Would you be able to check with these libraries if they could just disable
> the holds completely because there doesn't seem to be any use of placing a
> hold in that case?

Often different workflows seem confusing, but I think there can be
justifications here: i.e. a library allows a proxy to pick up holds

I think you would need to send this to the mailing list to get opinions before
making a change.

The prefs seem pretty explicit about overriding 'waiting' so maybe a second
setting in the pref

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23912] Get correct authorised values for location and collections facets

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

Lari Taskula  changed:

   What|Removed |Added

Summary|Remove unused variable from |Get correct authorised
   |C4::Search::getRecords  |values for location and
   ||collections facets

--- Comment #2 from Lari Taskula  ---
(In reply to Lari Taskula from comment #1)

Renamed bug title to match issue described in comment #1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23910] Koha version 3.8 - missing item information on normal view

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23910

--- Comment #2 from Maria Nunes  ---
(In reply to Owen Leonard from comment #1)
> This does look like a support question rather than a bug. In addition, 3.8
> is very old and unsupported at this time. Still, you might get some help
> through the support options available to you:
> 
> You could ask on the Koha mailing list
> (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
> channel (http://koha-community.org/get-involved/irc/).
> 
> Hopefully you've already seen the Koha documentation:
> http://koha-community.org/documentation/
> 
> You can also find options for paid support here:
> https://koha-community.org/support/

thanks!
I'will try the support!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23912] Remove unused variable from C4::Search::getRecords

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi
   |ity.org |
 Status|NEW |ASSIGNED

--- Comment #1 from Lari Taskula  ---
It appears Bug 17248 made C4::Search::getRecords() parameter $opac unused and
causes location and collection facets to prefer OPAC description over intranet
one in all interfaces, including intranet itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23904] Chrome update does not allow use of window.open() during unload

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23904

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Lucas Gass  ---
Owen,

You are correct, I filed this bug to hastily. Marking it resolved now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767

--- Comment #6 from Séverine Queune  ---
Created attachment 94811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94811=edit
Total available sum incorrect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #5 from Séverine Queune  ---
Hi Nick,

I think the issue also concerns the "Total available" amount.
I attach a screenshot with the patch applied, you can see the child amounts are
not ignores in the last sum.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23904] Chrome update does not allow use of window.open() during unload

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23904

Owen Leonard  changed:

   What|Removed |Added

Summary|Chrome update does not  |Chrome update does not
   |allow use of window.open()  |allow use of window.open()
   ||during unload

--- Comment #1 from Owen Leonard  ---
I think the important detail relevant to us is that this new restriction is for
window.open() *during unload.* I would take that to mean that we can't trigger
a pop-up window with the unload event
(https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event).

The only instance of "onunload" I see in the code is in SCO and it isn't used
to open a window.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909

--- Comment #5 from Joonas Kylmälä  ---
(In reply to Andrew Fuerste-Henry from comment #4)
> I believe the thinking is that whenever possible the book should go to the
> patron who has it in-hand. I'm sure the patron who previously got a notice
> that their hold is available *is* angry when their item isn't there for
> them, but nonetheless I have known real libraries that do this. I'm not
> arguing that it's a good idea, just that it's something I've known libraries
> to do.

Would you be able to check with these libraries if they could just disable the
holds completely because there doesn't seem to be any use of placing a hold in
that case?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17359] Patron import results use wrong encoding

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359

Séverine Queune  changed:

   What|Removed |Added

  Attachment #94261|0   |1
is obsolete||

--- Comment #24 from Séverine Queune  ---
Created attachment 94809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94809=edit
Bug 17359: Add tests

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17359] Patron import results use wrong encoding

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359

Séverine Queune  changed:

   What|Removed |Added

  Attachment #94262|0   |1
is obsolete||

--- Comment #25 from Séverine Queune  ---
Created attachment 94810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94810=edit
Bug 17359: Correct encoding when displaying patron import summary

There is an encoding issue when the patron import summry, the string
must be UTF8 decoded before being sent to the template.

Test plan:
- Create a patron import CSV file with import issues. Use UTF8 characters.
See file attached to the bug report 'patron_import.csv'
=> The screen should display the line correctly
- Correct the import issue (add a surname for Chloé)
=> The imported patrons should contain the correct values.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17359] Patron import results use wrong encoding

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909

--- Comment #4 from Andrew Fuerste-Henry  ---
I believe the thinking is that whenever possible the book should go to the
patron who has it in-hand. I'm sure the patron who previously got a notice that
their hold is available *is* angry when their item isn't there for them, but
nonetheless I have known real libraries that do this. I'm not arguing that it's
a good idea, just that it's something I've known libraries to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903

--- Comment #2 from Owen Leonard  ---
The remote branch has been updated with more fixes and a complete test plan.
I've also posted patches for download (they're too large to attach here):

https://zivotdesign.com/download/bug-23903-1.patch
https://zivotdesign.com/download/bug-23903-2.patch

Test plan:

Bug 23903: Replace OPAC icons with Font Awesome

This patch replaces CSS-based background image icons with Font Awesome
icons. This will eliminate the use of sprite.png altogether.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Because JavaScript events are often triggered by class, the changes made
in this patch require testing of JavaScript-driven behavior as well as
visual confirmation of the changes.

Enable OPAC features to expose them for testing: Login, Holds, Article
requests, Tags, Cart, Search term highlighting.

 - Perform a search in the OPAC
   - In the header at the top of the search results, check the
 'Unhighlight/Highlight' link.
   - Select some search results and verify that the multi-item controls
 are enabled: Add to cart/Lists; Place hold; Tag. Check that these
 controls work correctly.
   - Verify that the following links look correct and work correctly:
 'Place hold,' 'Request article,' 'Log in to add tags,' 'Add to
 cart.'
   - Log in to the OPAC and return to the search results page. Check the
 'Add tag' and 'Save to lists' links.

 - View the lists page
   - Test the 'Edit' and 'Delete' controls.
   - View the contents of a list. Test the following:
  - Controls at the top of the table of results ('New list,'
'Download list,' 'Send list,' 'Print list,' 'Edit list,' and
'Delete list').
  - Multi-selection operations: 'Place hold,' 'Tag,' and 'Remove
from list.'
  - Controls for each item on the list: 'Place hold,' 'Add tag,'
'Save to another list,' 'Remove from this list,' and 'Add to
cart.'

   - View the bibliographic detail page for any search result
 - In the right-hand sidebar menu, verify that these controls look
   correct and work correctly: 'Place hold,' 'Print,' 'Request
   article,' 'Save to your lists,' 'Add to your cart,'
  'Unhighlight,' 'Send to device,' 'Save record,' and 'More
  searches.'
 - Test the shelf browser by clicking 'Browse shelf' under the call
   number for any of the holdings.
   - Test the 'Next' and 'Previous' controls.
 - Check the tabs for switching between 'Normal,' 'MARC,' and 'ISBD'
   views and verify that they look correct on each of those pages.

 - Add some items to the Cart and open the Cart
   - Test the cart controls at the top: 'More details/Brief display,'
 'Send,' 'Download,' 'Empty and close,' 'Hide window,' 'Print.'
   - Test the multiple-selection controls: 'Remove,' 'Add to list,'
 'Place hold,' and 'Tag.'

 - Log in to the OPAC as a user who has items checked out which can be
   renewed. On the 'Your summary' page, on the 'Checked out' tab, test
   the 'Renew selected' and 'Renew all' links.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909

--- Comment #3 from Joonas Kylmälä  ---
And to clarify this a bit more: waiting items cannot be checked out currently
with SIP so this would make both of these checkout methods work the same way.
Maybe you are thinking of the Reserved state, i.e. patron has placed a hold but
it has not been confirmed by the library yet to be available for pickup?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #17 from Kyle M Hall  ---
Created attachment 94808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94808=edit
Bug 23068: [DO NOT PUSH] Debugging code for test plan

Signed-off-by: Ed Veal 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #92463|0   |1
is obsolete||
  Attachment #92464|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 94807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94807=edit
Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
REMOTE_ADDR features work behind a proxy

Koha has a number of features that rely on knowing the IP address of the
connecting client. If that server is behind a proxy these features do not work.
This patch adds a module to automatically convert the X-Forwarded-For header
into the REMOTE_ADDR environment variable for both CGI and Plack processes.

TEST PLAN:
1) Apply this patch set
2) Install Plack::Middleware::RealIP via cpanm or your favorite utility
3) Update your plack.psgi with the changes you find in this patch set ( this
process differs based on your testing environment )
4) Restart plack
5) Tail the plack error log for your instance
6) Use curl to access the OPAC, adding an X-Forwarded-For header: curl --header
"X-Forwarded-For: 32.32.32.32" http://127.0.0.1:8080
7) Note the logs output this address if you are unproxied
8) If you are proxied, restart plack using a command like below, where the ip
you see in the logs ("REAL IP) is what you put in the koha conf:
172.22.0.1 1.1.1.1
9) Restart all the things!
10) Repeat step 6
11) You should now see "REAL IP: 32.32.32.32" in the plack logs as the remote
address in your plack-error.log logs!
12) Disable plack so you are running in cgi mode, repeat step 6 again
13) You should see "REAL IP: 32.32.32.32" as the remove address in your
opac-error.log logs!

Signed-off-by: Ed Veal 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909

--- Comment #2 from Joonas Kylmälä  ---
(In reply to Andrew Fuerste-Henry from comment #1)
> Some libraries would prefer that Koha allow the patron to check out the book
> even though it is meant to be on hold. I think this needs to be an option.

Why? And is there a real library doing this? Are the patrons not angry when
they have come to fetch a book for which they got an email about that it has
arrived?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23912] New: Remove unused variable from C4::Search::getRecords

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912

Bug ID: 23912
   Summary: Remove unused variable from C4::Search::getRecords
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lari.task...@hypernova.fi
QA Contact: testo...@bugs.koha-community.org

Remove unused variable $opac from C4/Search.pm getRecords subroutine.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23805] Add a dedicated credit_types table

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

--- Comment #42 from Martin Renvoize  ---
Good spot Julian, thanks.. I'll look into it now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #1 from Andrew Fuerste-Henry  ---
Some libraries would prefer that Koha allow the patron to check out the book
even though it is meant to be on hold. I think this needs to be an option.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22826] Allow indexing of individual authority records in Elasticsearch

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826

--- Comment #7 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22826] Allow indexing of individual authority records in Elasticsearch

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

--- Comment #17 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525

--- Comment #5 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23310] Noisy Koha::Biblio

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23310] Noisy Koha::Biblio

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

--- Comment #11 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874

--- Comment #6 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114

--- Comment #5 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23908] Require patrons to confirm their email address

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@hypernova.fi

--- Comment #2 from Lari Taskula  ---
(In reply to Katrin Fischer from comment #1)
> Should we prevent sending email to unverfiied emails? (optionally)

If verification is on and required, I think this is expected behavior in order
to avoid emails ending up in wrong person's inbox. Why not just force it when
verification is turned on?

> How should the patron import behave here? Checkbox for sending out
> verification emails vs. importing them as "verified"?

Having a choice for import is a good idea. We should also discuss what happens
when this feature is applied. Send verification to everyone or consider
existing patron emails verified?

Also, we should keep using their old email for messaging until patron has
verified the new one. So this requires some thought for the design. Perhaps the
whole messaging system should be redesigned so that patron can add n number of
email addresses (that can actually be used for messaging according to patron's
choice) instead of the so-confusing email, emailpro, B_email and so on. But
maybe this is outside the scope of this Bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23911] Possibility to do more complex analysis of systempreference usage

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23911

--- Comment #1 from Joonas Kylmälä  ---
One actual use case I have in mind for this is to do a sanity check when we are
deprecating or merging some sysprefs in Koha so that they are not used in an
unexpected way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23911] New: Possibility to do more complex analysis of systempreference usage

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23911

Bug ID: 23911
   Summary: Possibility to do more complex analysis of
systempreference usage
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Hea
  Assignee: ch...@bigballofwax.co.nz
  Reporter: joonas.kylm...@helsinki.fi
QA Contact: jonathan.dru...@bugs.koha-community.org

It would be nice to be able to query how many libraries use a combination of
different sysprefs like "AllowItemsOnHoldCheckout = 1 AND
AllowItemsOnHoldCheckoutSCO = 1". This could be available either through an API
or the UI.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23910] Koha version 3.8 - missing item information on normal view

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23910

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---
This does look like a support question rather than a bug. In addition, 3.8 is
very old and unsupported at this time. Still, you might get some help through
the support options available to you:

You could ask on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
  Attachment #93359|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23910] New: Koha version 3.8 - missing item information on normal view

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23910

Bug ID: 23910
   Summary: Koha version 3.8 - missing item information on normal
view
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mj...@reitoria.ulisboa.pt
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 94806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94806=edit
image of normal view (backoffice)

Hi!
we have been unable to make loans for 4 days because a total disappearance of
item information in normal view, however information appears in ISBD view
(backoffice) and MARC view (OPAC).

I apologize right now if this is not a bug, but I didn't know where to go to
present this problem.
I have been working on a Koha 3.8 since 2012 and this has never happened.
If this is not a bug, please indicate where I can try to find some help for
this issue.
Thank you!
Maria Nunes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23909

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21572

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23909] New: SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909

Bug ID: 23909
   Summary: SCO allows to check out items with Waiting state if
AllowItemsOnHoldCheckoutSCO
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: joonas.kylm...@helsinki.fi
QA Contact: testo...@bugs.koha-community.org

Currently SCO module allows to check out items with Waiting state if
AllowItemsOnHoldCheckoutSCO is enabeld.

Waiting items should not be able to be checked out unless librarian overrides
because the notifications of an item available for pickup might have already
been sent.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts [part 1]

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #20 from Marcel de Rooy  ---
(In reply to Joonas Kylmälä from comment #19)
> I suggest that instead of adding two new sysprefs we could use the already
> existing syspref TrackLastPatronActivity? Or at least just add one syspref
> instead of two since I don't think such granularity is needed to log either
> failed or successful logins.

Hi Jonaas,
Thx for asking. I agree that they are related. But I do think that granularity
of logging success and/or failure is useful. Although Vitor is interested in
both, I can imagine that others only would be interested in the failures. There
might be a difference in numbers there too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #11 from Séverine Queune  ---
(In reply to Magnus Enger from comment #10)
> A more or less related problem: If you set password as mandatory in
> PatronSelfRegistrationBorrowerMandatoryField it does not show up in the edit
> form (there is a separate screen for changing the password), and the edit
> form can never be submitted successfully. 
> 
> With a new syspref PatronSelfModificationBorrowerMandatoryField it would be
> possible to set it as not mandatory in the edit screen.

This peculiar problem with password field is very annoying (at BULAC, we
experience it since we update in 18.05, was working on 16.11), shouldn't we
open a new ticket to solve this specific point, if no one can work the new
syspref ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23891] opac-memberentry.pl showing fields that should be supressed by PatronSelfModificationBorrowerUnwantedField

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23891

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

--- Comment #26 from Joonas Kylmälä  ---
(In reply to Joonas Kylmälä from comment #25)
> (In reply to Kyle M Hall from comment #24)
> > Thanks! I tend to agree with Katrin. For instance, it may be that Koha SCO
> > is being used on site and librarians want to prevent patrons from grabbing
> > books from the hold shelf and SIP is being used off site and if the "patron
> > has possession" of the item they need to be able to check it out. This
> > scenario is completely contrived but I think it's illustrative ;)
> 
> If this is the only scenario that could cause problem theoretically to
> someone then I suggest we still would unify the sysprefs and fix this by
> making an option in the branch level to allow checkouts of reserved items.
> In my opinion SIP and SCO should be both treated the same or libraries will
> start abusing these features like by using the SCO module in one branch
> because it can do the job even though SIP would be better because you don't
> have to maintain a different kinds of self checkout machine.

To clarify, with reserved item I mean reserved and in waiting state (as the
original patch is about removing the possibility of checking out waiting
reserved items in SCO module)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts [part 1]

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

--- Comment #19 from Joonas Kylmälä  ---
I suggest that instead of adding two new sysprefs we could use the already
existing syspref TrackLastPatronActivity? Or at least just add one syspref
instead of two since I don't think such granularity is needed to log either
failed or successful logins.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts [part 1]

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #18 from Marcel de Rooy  ---
Please get this further now by testing and signing off !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts [part 1]

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts [part 1]

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #17 from Marcel de Rooy  ---
Created attachment 94805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94805=edit
Bug 21190: Add tests for authentication success and failure

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

--- Comment #25 from Joonas Kylmälä  ---
(In reply to Kyle M Hall from comment #24)
> Thanks! I tend to agree with Katrin. For instance, it may be that Koha SCO
> is being used on site and librarians want to prevent patrons from grabbing
> books from the hold shelf and SIP is being used off site and if the "patron
> has possession" of the item they need to be able to check it out. This
> scenario is completely contrived but I think it's illustrative ;)

If this is the only scenario that could cause problem theoretically to someone
then I suggest we still would unify the sysprefs and fix this by making an
option in the branch level to allow checkouts of reserved items. In my opinion
SIP and SCO should be both treated the same or libraries will start abusing
these features like by using the SCO module in one branch because it can do the
job even though SIP would be better because you don't have to maintain a
different kinds of self checkout machine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581

--- Comment #4 from Martin Renvoize  ---
Tomas said you might get to this any moment Agustin, so I'm marking it as 19.11
possible.. be great to see it in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595

--- Comment #11 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595

Martin Renvoize  changed:

   What|Removed |Added

   Severity|new feature |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23875] Elasticsearch - ES - When sorting by score we should provide a tiebreaker

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20307] Language overlay for authorized values

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #73 from Martin Renvoize  ---
I've added a new keyword for things we should target early next cycle..
rel_20_05_target and christened it by adding it to this bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item

2019-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377
Bug 22377 depends on bug 22563, which changed state.

Bug 22563 Summary: Convert lost handling to use 'status' instead of multiple 
accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 138 matches

Mail list logo