[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
--- Comment #116 from Lari Taskula ---
Comment on attachment 101934
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934
Bug 15522: Add API for circulation rules
Review of attachment 101934:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15522=101934)
-
::: api/v1/swagger/paths/circulation-rules.json
@@ +28,5 @@
> + "schema": {
> +"$ref": "../definitions.json#/error"
> + }
> +}
> + }
No permissions required for GET?
@@ +40,5 @@
> + ],
> + "parameters": [{
> +"name": "body",
> +"in": "body",
> +"description": "A JSON object containing rules to set; null for a
> rule_value means to delete the rule",
I think this wrong functionality for POST method that is supposed to create
resources.
Also, by definition POST is not idempotent, but here it seems to be. (If I
understand the API correctly, here making the same request twice is the same as
making it only once, right?)
It should then be PUT. But PUT requires the whole object as a parameter.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101946|0 |1 is obsolete|| --- Comment #115 from Lari Taskula --- Created attachment 101947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101947=edit Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101927|0 |1 is obsolete|| --- Comment #111 from Lari Taskula --- Created attachment 101943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101943=edit Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #112 from Lari Taskula --- Created attachment 101944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101944=edit Bug 15522: (follow-up) Fix circulation rules interface title inconsistency Follow-up to "Bug 15522: Remove old circulation rules interface" Instead of: "Circulation, fines and holds rules", use "Circulation, fines, and holds rules" for consistency Latter form already used in commit Bug 15522: New interface for updated circulation rules as follows koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:37: Circulation, fines, and holds rules koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:88: Circulation, fines, and holds rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #113 from Lari Taskula --- Created attachment 101945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101945=edit Bug 15522: (follow-up) Add missing http return codes to api spec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #114 from Lari Taskula --- Created attachment 101946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101946=edit Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101926|0 |1 is obsolete|| --- Comment #110 from Lari Taskula --- Created attachment 101942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101942=edit Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101925|0 |1 is obsolete|| --- Comment #109 from Lari Taskula --- Created attachment 101941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101941=edit Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101923|0 |1 is obsolete|| --- Comment #107 from Lari Taskula --- Created attachment 101939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101939=edit Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101922|0 |1 is obsolete|| --- Comment #106 from Lari Taskula --- Created attachment 101938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101938=edit Bug 15522: Add yarn.lock (autogenerated) Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101921|0 |1 is obsolete|| --- Comment #105 from Lari Taskula --- Created attachment 101937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101937=edit Bug 15522: Remove old circulation rules interface Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101924|0 |1 is obsolete|| --- Comment #108 from Lari Taskula --- Created attachment 101940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101940=edit Bud 15522: Restore categories filtering Mimicking what is done for Branches Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101918|0 |1 is obsolete|| --- Comment #102 from Lari Taskula --- Created attachment 101934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101919|0 |1 is obsolete|| --- Comment #103 from Lari Taskula --- Created attachment 101935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101935=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
Lari Taskula changed:
What|Removed |Added
Attachment #101920|0 |1
is obsolete||
--- Comment #104 from Lari Taskula ---
Created attachment 101936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101936=edit
Bug 15522: New interface for updated circulation rules
Test plan:
1) Make sure all dependencies are applied, and that their DB upgrades
have been applied.
2) Build JS (see previous patches for HOWTO).
3) Load .../cgi-bin/koha/admin/policy.pl .
4) Try changing an existing rule (one with a textbox or dropdown). Hit
"Save rules", ensure that your changes are saved.
5) Until changes are saved, all cells that are changed or affected by
your changes should be highlighted in yellow.
6) Same as above, but deleting a rule by hitting the "x" next to it.
7) Add rows and columns using the "Choose rule..." and "Choose
category/item type..." dropdowns.
8) Add rules by clicking the pencil in a currently unset rule cell.
Ensure changes are saved.
9) Hit "Cleanup rules"; all redundant rules should be removed. As this
only removes rules that are the same as the defaults, this should
not change any effective rules.
10) Use the filters at the top right ("Circulation", "Holds" and
"Fines") to filter the kinds of rules that are shown.
11) Ensure that any desired library can be shown, including (if
selected) all at the same time.
JD edits: Removed the changes to filtered categories, will be done in a
follow-up
Signed-off-by: Lisette Scheer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
--- Comment #101 from Lari Taskula ---
(In reply to Lari Taskula from comment #99)
> Comment on attachment 101920 [details] [review]
> Bug 15522: New interface for updated circulation rules
>
> Review of attachment 101920 [details] [review]:
> -
>
> ::: koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/app.js
> @@ +75,5 @@
> > +;
> > +}
> > +
> > +componentDidMount() {
> > +$( this.toolbarElem ).fixFloat();
>
> Test plan step 3 fails, my browser (both FF and Chromium) console says:
> TypeError: $(...).fixFloat is not a functionapp.js:79:30
Fixed by "Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky",
would be useful to squash this patch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #100 from Lari Taskula --- (In reply to Lari Taskula from comment #98) > (In reply to Lisette Scheer from comment #62) > > (In reply to Jonathan Druart from comment #51) > > > Created attachment 99148 [details] [review] [review] [review] > > > Bug 15522: Add API for circulation rules > > > > > > Test plan: > > > 1) Run t/db_dependent/api/v1/circ_rules.t . > > > > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove > > t/db_dependent/api/v1/circ_rules.t > > t/db_dependent/api/v1/circ_rules.t .. 1/5 > > # Failed test '403 Forbidden' > > # at t/db_dependent/api/v1/circ_rules.t line 128. > > # got: '400' > > # expected: '403' > > # Looks like you failed 1 test of 2. > > t/db_dependent/api/v1/circ_rules.t .. 3/5 > > # Failed test 'set_rules | unauthorized' > > # at t/db_dependent/api/v1/circ_rules.t line 132. > > > > # Failed test '200 OK' > > # at t/db_dependent/api/v1/circ_rules.t line 212. > > # got: '403' > > # expected: '200' > > # Looks like you failed 1 test of 6. > > > > # Failed test 'set_rules | restricted' > > # at t/db_dependent/api/v1/circ_rules.t line 223. > > # Looks like you failed 2 tests of 5. > > t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512, > > 0x200) > > Failed 2/5 subtests > > > > Test Summary Report > > --- > > t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2) > > Failed tests: 3, 5 > > Non-zero exit status: 2 > > Files=1, Tests=5, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.86 cusr 0.23 > > csys = 3.11 CPU) > > Result: FAIL > > > > I got this message when I tried to do this step in my devbox. Everything > > else worked great for me. > > I confirm this error. Will provide a patch to fix it. Already fixed by "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries", maybe squash this patch to the first one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
--- Comment #99 from Lari Taskula ---
Comment on attachment 101920
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101920
Bug 15522: New interface for updated circulation rules
Review of attachment 101920:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15522=101920)
-
::: koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/app.js
@@ +75,5 @@
> +;
> +}
> +
> +componentDidMount() {
> +$( this.toolbarElem ).fixFloat();
Test plan step 3 fails, my browser (both FF and Chromium) console says:
TypeError: $(...).fixFloat is not a functionapp.js:79:30
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||alei...@catalyst.net.nz --- Comment #16 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #12) > There is a QA script fail: > > FAIL tools/modborrowers.pl >FAIL critic > # Variables::RequireLexicalLoopIterators: Got 1 violation(s). > > Can you please check? All qa tests pass for me. Rebased and ready for testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #98 from Lari Taskula --- (In reply to Lisette Scheer from comment #62) > (In reply to Jonathan Druart from comment #51) > > Created attachment 99148 [details] [review] [review] > > Bug 15522: Add API for circulation rules > > > > Test plan: > > 1) Run t/db_dependent/api/v1/circ_rules.t . > > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove > t/db_dependent/api/v1/circ_rules.t > t/db_dependent/api/v1/circ_rules.t .. 1/5 > # Failed test '403 Forbidden' > # at t/db_dependent/api/v1/circ_rules.t line 128. > # got: '400' > # expected: '403' > # Looks like you failed 1 test of 2. > t/db_dependent/api/v1/circ_rules.t .. 3/5 > # Failed test 'set_rules | unauthorized' > # at t/db_dependent/api/v1/circ_rules.t line 132. > > # Failed test '200 OK' > # at t/db_dependent/api/v1/circ_rules.t line 212. > # got: '403' > # expected: '200' > # Looks like you failed 1 test of 6. > > # Failed test 'set_rules | restricted' > # at t/db_dependent/api/v1/circ_rules.t line 223. > # Looks like you failed 2 tests of 5. > t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512, > 0x200) > Failed 2/5 subtests > > Test Summary Report > --- > t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2) > Failed tests: 3, 5 > Non-zero exit status: 2 > Files=1, Tests=5, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.86 cusr 0.23 > csys = 3.11 CPU) > Result: FAIL > > I got this message when I tried to do this step in my devbox. Everything > else worked great for me. I confirm this error. Will provide a patch to fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Aleisha Amohia changed: What|Removed |Added Attachment #93859|0 |1 is obsolete|| --- Comment #15 from Aleisha Amohia --- Created attachment 101933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101933=edit Bug 23291: (follow-up) Fix capitalization on SMS There was one sms hidden between all the SMS, fixed it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #97 from Lari Taskula --- (In reply to Lari Taskula from comment #87) > Created attachment 101919 [details] [review] > Bug 15522: Add JS build pipeline > > This is not directly testable, but can be either used through the > Makefile: > > $ make js-build > > (This will automatically install all dependencies.) > > Or by manually installing yarn: > > $ sudo apt install nodejs npm > $ sudo npm install -g yarn > $ yarn install > $ yarn build > > (There is also `make js-watch` and `yarn watch`, which automatically > recompile when files are changed.) > > JD note: the make rule does not work > > Signed-off-by: Lisette Scheer I had issues with this on Ubuntu 18.04, especially the step "yarn build". koha@koha:~/Koha$ yarn build yarn run v1.22.4 $ node_modules/.bin/gulp build You are missing required Node modules; run `npm install`. I did some digging and found a more detailed message: ReferenceError: primordials is not defined It worked when I explicitly chose to install node version 10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Aleisha Amohia changed: What|Removed |Added Attachment #92667|0 |1 is obsolete|| --- Comment #14 from Aleisha Amohia --- Created attachment 101932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101932=edit Bug 23291: Retrieve all patrons with given SMS number, and change inputs This patch now handles situations where more than one patron has a given SMS number. The inputs are now more concise as radio buttons are now present for users to indicate whether the file they are uploading or the list of numbers they are entering are cardnumbers or SMS numbers. Test plan same as first patch, although take into account slight changes to inputs. Also test an SMS number that more than one patron has and check that all patrons with that number are displayed. Sponsored-by: Brimbank Library, Australia Authored-by: Alex Buckley and Hayley Mapley (Catalyst IT) Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Aleisha Amohia changed: What|Removed |Added Attachment #92666|0 |1 is obsolete|| --- Comment #13 from Aleisha Amohia --- Created attachment 101931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101931=edit Bug 23291: Find patrons by smsalertnumber in the batch patron modification Add ability to paste in sms numbers (one per line) or upload a file of sms numbers and find patrons with matching smsalertnumber values. If an sms number is not found then this is displayed in a yellow box to the librarian i.e. the batch patron modification tool will behave as it does currently when a cardnumber is not found. Test plan: 1. Go to Tools > Batch patron modification 2. Notice there is a file upload (for cardnumbers) and a text input area (for cardnumbers) 3. Apply patch and restart memached and plack 4. Refresh the page and notice a file upload (for sms numbers) and file text input area (for sms numbers) have been added 5. Create a file with valid sms numbers matching smsalertnumber values of patrons (one per line) 6. Select/upload the file into the sms number file upload and submit the form 7. Notice the patrons are found and you can batch modify them. Select a date in the 'Restriction expiration' datepicker and submit and notice this is added to the selected borrowers in the borrowers.debarred, borrowers.debarredcomment fields and borrower_debarment table. 8. Create a file with some valid and some invalid sms numbers (i.e. some smsnumbers belonging to patrons in their smsalertnumber field and some not matching) 9. Upload your file from 8 in the SMS number file upload and notice that error handling means the invalid/non-matching sms numbers are shown below the yellow box at the top of the page whilst matching sms numbers have returned patrons which you can edit 10. Confirm card number file upload still works by making a file of valid cardnumbers and uploading it in the Batch patron modification tool and noticing the patrons are successfully returned 11. In the batch patron modification tool paste valid sms numbers into the sms number text area input (0ne per line) and submit the batch patron modification. Notice that the patrons are successfully returned and displayed. 12. Repeat step 11 but this time paste in valid and invalid sms numbers and notice error handling means sms numbers which did not match borrowers, smsalertnumber are shown under the yellow box at the top of the page and patrons who matched sms numbers are shown below in the table 13. Repeat step 11 this time input only invalid sms numbers and submit. Notice that a page showing the yellow notice box and a list of all smsnumbers which could not be found are returned. 14. Repeat step 11 submitting valid smsnumbers in the cardnumber text area field and you will notice that a page showing the yellow notice box and a list of all non matching cardnumbers. 15. In your Koha home directory run: sudo koha-shell Then run: prove xt 16. Confirm all test pass 17. Sign off Sponsored-By: Brimbank Library, Australia Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 Aleisha Amohia changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 Aleisha Amohia changed: What|Removed |Added Attachment #92148|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 101930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101930=edit Bug 23450: Display subscription and issue cost in subscription interface of the catalouge/detail.pl Displays the serial issue price (from 952$g), and subscription cost (calculated from the Acquisition order the subscription is linked to). Test plan: 1. Create a subscription (making sure to select 'Create an item record when receiving this serial') and then go to Acquisitions module and create the following if they don't already exist: * Currency * Budget * Fund * Vendor * Basket 2. Add to the basket: Add to basket > From a subscription 3. Search for and select the subscription made in step #1 4. Set quantity, vendor price, and replacement price and 'Save' 5. Search for the serial biblio and view its catalogue/detail.pl page Click on the 'Subscriptions' tab and notice there is no 'Total cost of the subscription' text And no 'Issue price' and 'Subscription cost' columns in the issue table in the subscription tab which is currently empty 6. Select the 'Subscription details' link and select 'Receive' changing the status from 'Expected' to 'Arrived' 7. Repeat step 5 and notice the issues table in the Subscriptions tab still does not have 'Issue price' or 'Subscription cost' columns 8. Apply patches on bug 23352 and 23450 9. Update your database and restart memcached and plack 10. Refresh the catalogue/detail.pl page you were on in step 7 and notice the following has been added: Total cost of the subscription is: Issue price and Subscription cost columns in the issue table in the subscription tab. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #35 from David Cook --- While I agree about moving the HTML system preferences out of the system preferences, wouldn't it make sense to re-brand the "News" to "Customize user interface" or "HTML Content Editor" or something like that? I imagine putting things under the "News" banner might just confuse library staff more than they're already confused. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 David Cook changed: What|Removed |Added Attachment #101917|0 |1 is obsolete|| --- Comment #9 from David Cook --- Created attachment 101929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101929=edit Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature TEST PLAN: 1. Make a new news item and use the TinyMCE editor, click on the <> icon to go to the Source code editor 2. Add some HTML like TEST and save it. 3. Go back in and notice that TinyMCE has changed it to: TEST 4. It should not auto clean up and also it should not autowrap with tag. 5. Apply patch patch, and repeat step 2. Save again. 6. It should not have automatiicly changed any HTML or added any wrapper. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 --- Comment #37 from David Cook --- Created attachment 101928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101928=edit [Follow-up] Bug 20415: Fix typo causing SQL error in updatedatabase.pl This patch just removes a typo that is causing a database update to fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 --- Comment #36 from David Cook --- Oh wait. Maybe not broke. I forget we don't throw fatal errors for SQL errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415
--- Comment #35 from David Cook ---
(In reply to Martin Renvoize from comment #34)
> Nice work everyone!
>
> Pushed to master for 20.05
Ooops, I think you may have accidentally broken updatedatabase.pl:
diff --git a/installer/data/mysql/updatedatabase.pl
b/installer/data/mysql/updatedatabase.pl
index 65ecbb7169..3c62761737 100755
--- a/installer/data/mysql/updatedatabase.pl
+++ b/installer/data/mysql/updatedatabase.pl
@@ -21296,6 +21296,7 @@ if( CheckVersion( $DBversion ) ) {
$dbh->do(q|
ALTER TABLE suggestions ADD CONSTRAINT
`suggestions_ibfk_lastmodificationby` FOREIGN KEY (`lastmodificationby`)
REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE
+A
|);
}
@@ -21335,6 +21336,15 @@ if( CheckVersion( $DBversion ) ) {
NewVersion( $DBversion, 23590, "Add lastmodificationby and
lastmodificationdate to the suggestions table");
}
+$DBversion = '19.12.00.056';
+if( CheckVersion( $DBversion ) ) {
+
+$dbh->do( "DELETE FROM systempreferences WHERE variable='UseKohaPlugins'"
);
+
+NewVersion( $DBversion, 20415, "Remove UseKohaPlugins preference");
+}
+
+
# SEE bug 13068
# if there is anything in the atomicupdate, read and execute it.
my $update_dir = C4::Context->config('intranetdir') .
'/installer/data/mysql/atomicupdate/';
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #8 from David Cook --- Awesome! I'm going to put this on my todo list. In the middle of something else at the moment, but hoping to sign this off today. Been bitten by this issue more often than I'd like. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Personally, I'd prefer to use CodeMirror. However, my librarians would rather use a WYSIWYG editor I think, so I think being able to do an either/or would be great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi --- Comment #96 from Lari Taskula --- Fixed patch order, obsoleted duplicates, rebased on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99215|0 |1 is obsolete|| --- Comment #95 from Lari Taskula --- Created attachment 101927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101927=edit Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99201|0 |1 is obsolete|| --- Comment #94 from Lari Taskula --- Created attachment 101926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101926=edit Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99203|0 |1 is obsolete|| --- Comment #92 from Lari Taskula --- Created attachment 101924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101924=edit Bud 15522: Restore categories filtering Mimicking what is done for Branches Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99202|0 |1 is obsolete|| --- Comment #93 from Lari Taskula --- Created attachment 101925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101925=edit Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99204|0 |1 is obsolete|| --- Comment #91 from Lari Taskula --- Created attachment 101923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101923=edit Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99205|0 |1 is obsolete|| --- Comment #90 from Lari Taskula --- Created attachment 101922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101922=edit Bug 15522: Add yarn.lock (autogenerated) Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99206|0 |1 is obsolete|| --- Comment #89 from Lari Taskula --- Created attachment 101921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101921=edit Bug 15522: Remove old circulation rules interface Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
Lari Taskula changed:
What|Removed |Added
Attachment #99214|0 |1
is obsolete||
--- Comment #88 from Lari Taskula ---
Created attachment 101920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101920=edit
Bug 15522: New interface for updated circulation rules
Test plan:
1) Make sure all dependencies are applied, and that their DB upgrades
have been applied.
2) Build JS (see previous patches for HOWTO).
3) Load .../cgi-bin/koha/admin/policy.pl .
4) Try changing an existing rule (one with a textbox or dropdown). Hit
"Save rules", ensure that your changes are saved.
5) Until changes are saved, all cells that are changed or affected by
your changes should be highlighted in yellow.
6) Same as above, but deleting a rule by hitting the "x" next to it.
7) Add rows and columns using the "Choose rule..." and "Choose
category/item type..." dropdowns.
8) Add rules by clicking the pencil in a currently unset rule cell.
Ensure changes are saved.
9) Hit "Cleanup rules"; all redundant rules should be removed. As this
only removes rules that are the same as the defaults, this should
not change any effective rules.
10) Use the filters at the top right ("Circulation", "Holds" and
"Fines") to filter the kinds of rules that are shown.
11) Ensure that any desired library can be shown, including (if
selected) all at the same time.
JD edits: Removed the changes to filtered categories, will be done in a
follow-up
Signed-off-by: Lisette Scheer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99213|0 |1 is obsolete|| --- Comment #87 from Lari Taskula --- Created attachment 101919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101919=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99148|0 |1 is obsolete|| Attachment #99211|0 |1 is obsolete|| --- Comment #86 from Lari Taskula --- Created attachment 101918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101918=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #79 from Laura Horgan --- In our last system it was called parts and was used for books dvds kits, etc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- With more system preferences like OPACHeader(bz22880) and OPACMainUserBlock (bz23794) moving into the News feature there needs to be a robust way of editing HTML, I think CodeMirror is appropriate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #85 from Lari Taskula --- Not applying. Patches have gone in wrong order. I'll attempt to fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24764 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22660 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Katrin Fischer changed: What|Removed |Added Summary|Improve usability when |Allow use of CodeMirror for |editing HTML with the news |editing HTML in the news |editor |editor --- Comment #1 from Katrin Fischer --- Lucas proposed a good idea on bug 24764: Use CodeMirror! Changing the bug title to advertise the idea a bit more. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 --- Comment #7 from Katrin Fischer --- (In reply to Lucas Gass from comment #6) > This patch fixes the automatic code clean up problem with tinyMCE. A > discussion of wether CodeMirror might be a better option (or ability to use > either) is for a different bug, I think. Agreed, I filed bug 22660 :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit number of purchase suggestions per patron in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit number of purchase suggestions per patron in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer changed: What|Removed |Added Summary|Limit purchase suggestion |Limit number of purchase |in a specified time period |suggestions per patron in a ||specified time period --- Comment #20 from Katrin Fischer --- 1) QA test tools Looks good, only got what looks like a false positive: Processing additional checks * Email's author 'kohadevi...@devinim.com.tr' seems invalid 2) Capitalization (Bug 22774 - Limit Purchase Suggestion in a specified Time period) Please stick with our capitalization rules everywhere! :) Still testing here, but won't finish tonight. Will fix 2) myself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 --- Comment #6 from Lucas Gass --- This patch fixes the automatic code clean up problem with tinyMCE. A discussion of wether CodeMirror might be a better option (or ability to use either) is for a different bug, I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 --- Comment #5 from Lucas Gass --- Created attachment 101917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101917=edit Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature TEST PLAN: 1. Make a new news item and use the TinyMCE editor, click on the <> icon to go to the Source code editor 2. Add some HTML like TEST and save it. 3. Go back in and notice that TinyMCE has changed it to: TEST 4. It should not auto clean up and also it should not autowrap with tag. 5. Apply patch patch, and repeat step 2. Save again. 6. It should not have automatiicly changed any HTML or added any wrapper. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #75 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #73) > I'm sad to say, those RDA macros work in master without these patches. Just > tested this one on master and it made all three new fields: > new 336=‡atext ǂb txt ǂ2 rdacontent > new 337=‡aunmediated ǂb n ǂ2 rdamedia > new 338=‡avolume ǂb nc ǂ2 rdacarrier > > If it's only making one of the three with these patches then that ain't good. Do the subfield codes show up the right 'color' for you? I have the text added by the macro, but only the first is a real 'subfield' delimeter somehow. When I save and look at the record, they show in the record as ǂb and ǂ2 in normal view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #20 from Aleisha Amohia --- Created attachment 101916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101916=edit Bug 23352: (follow-up) Fix 952$g and location auto-population Previously the cost (952$g) used unit price from the acquisition order, but this is not automatically calculated and is sometimes zero. We should use the individual item's budgeted cost instead. This patch ensures the permanent location (952$a) and current location (952$b) are set to the current logged in branch, not the subscription branch Also fixing a typo and amending syspref description to be more user-friendly. Sponsored-by: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846 --- Comment #28 from Hayley Mapley --- > (In reply to Hayley Mapley from comment #26) > > Backported to 18.11.x for 18.11.16 > > Thank you Hayley for looking into it! Thanks for flagging it Katrin! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846 --- Comment #27 from Katrin Fischer --- (In reply to Hayley Mapley from comment #26) > Backported to 18.11.x for 18.11.16 Thank you Hayley for looking into it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846 Hayley Mapley changed: What|Removed |Added Version(s)|20.05.00, 19.11.04, |20.05.00, 19.11.04, released in|19.05.09|19.05.09, 18.11.16 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #26 from Hayley Mapley --- Backported to 18.11.x for 18.11.16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 --- Comment #4 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > In my opinion we should replace TinyMCE with CodeMirror here. Making it an option like the WYSIQY editor for prefs is might be nice. So you can switch if you want to do more elaborate things and keep the editor for people not fond of code? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 --- Comment #3 from Lucas Gass --- In my opinion we should replace TinyMCE with CodeMirror here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24996] New: Unwanted CSS change unhides OPAC results sorting button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 Bug ID: 24996 Summary: Unwanted CSS change unhides OPAC results sorting button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 23915 With JavaScript enabled the "Go" button associated with the OPAC search results re-sort form should be hidden. Looks like I accidentally removed a line of CSS with Bug 23915 which needs to get put back. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Owen Leonard changed: What|Removed |Added Blocks||24996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 [Bug 24996] Unwanted CSS change unhides OPAC results sorting button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||martin.renvoize@ptfs-europe ||.com --- Comment #74 from Tomás Cohen Arazi --- The fact it relies on the API should be a good thing for everyone, no one wants to add new CGI controller scripts that can only be tested with selenium :-D About translatability, the JS libraries usually just detect faulty codes (4XX, 5XX, and so on). And the error message is not what gets presented to the end user. That should be handled as usual in JS with translatability in mind. For example, if we do GET /a/resource/12 and get a 404, it doesn't matter the JSON that is returned (even though we try to be consistent on the format and texts there). The code on the UI should handle the fact that the requested resource doesn't exist, based on the 404 code. That said, maybe Nick relied on those messages for the UI, and that should be fixed. I haven't checked that myself. Regarding the need for a vote, I'd say we should, yes. This patchset requires something different than others: the resources (macros) can belong to a patron, but can also be shared. And we can only specify AND conditions for resource access. So we cannot say (on the spec) things like: 'you can edit this if you are superlibrarian or the owner'. It could be worked out in a different way, but I don't think we can avoid (at least) a minimum check in the controller, and is just fine IMHO. I will recheck this patchset in deep and provide more feedback ASAP. Specially if some design change can make this cleaner to implement. I haven't found a better option, thus adding Martin and Agustin to the conversation to gather more ideas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #78 from David Cook --- (In reply to Andrew Fuerste-Henry from comment #74) > A volume is a grouping of items within a bib. See bug 24860 for one > implementation (patrons can place hold on a volume, get first available item > within that volume). Imagine, say, a bib containing multiple copies of a > multi-volume series. Patron wants whichever copy of Book 1 comes in first. That's interesting. I wonder if we should use more generic terminology like "item_group" instead of "volume". Perhaps each group could have a translatable label assigned so you could choose "Volume", "Kit", etc. This might be useful for libraries that provide kits, toy bags, computers (with peripherals). Individual pieces could be barcoded and be items in their own right, but be grouped together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #11 from Joy Nelson --- Koha developments most often (if not always) keep one eye towards current users as well as future users. At times it's hard to balance the needs of a library (or libraries) and workflows that seem so important with the needs and workflows of the many. The things that seem obvious to me are not always obvious to others. I rely on the input of others in the community to give perspective on how other libraries operate. I believe someone once said "show me a library with a mad scheme and I'll show you another with a madder one"! Speaking from someone with experience migrating thousands of libraries to Koha, I can confidently say that libraries have indeed used this field with the expectation that it was NOT visible in the OPAC. There is the distinct possibility that patron information (or staff information/direction) is available in this field. A number of libraries come to my mind who have been using Koha for years in a way that is built upon the original design (not visible in opac). If this is to be implemented and visible in the OPAC, it must be made so it is optional/configurable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #73 from Andrew Fuerste-Henry --- I'm sad to say, those RDA macros work in master without these patches. Just tested this one on master and it made all three new fields: new 336=‡atext ǂb txt ǂ2 rdacontent new 337=‡aunmediated ǂb n ǂ2 rdamedia new 338=‡avolume ǂb nc ǂ2 rdacarrier If it's only making one of the three with these patches then that ain't good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #50 from Agustín Moyano --- Created attachment 101915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101915=edit Bug 20936: (follow-up) use modified by bug 24980, fix display of page info and fix search without enter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #22 from Katrin Fischer --- Setting FQA because Sally's testing confirms there is still some glitch with the deletes. I hope the problem can be fixed - this would make a nice addition! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #72 from Katrin Fischer ---
Having a look here too. Database update and permissions look good. Seems to
work well, although I have some concerns about macros working correctly in our
current version (see 5)
Found only some small stuff that needs fixing:
1) QA test tool fail
FAIL Koha/AdvancedEditorMacros.pm
FAIL pod coverage
POD is missing for 'object_class'
OK spelling
2) Translatability
Jonathan, I think you are right, if these show in the GUI (which it looks like)
they won't be translatable.
openapi => { error => "To create shared macros you must use
advancededitor/shared" } );
openapi => { error => "To create private macros you must use advancededitor" }
);
There are also some other glitches in the Javascript code:
+$convert = $( ' Convert old
macros' );
3) Should these API additions be voted on?
4) Capitalization
I've noticed lots of glitches there in patches recently - makes my inner
librarian unhappy:
+ "description": "Advanced Editor Macro internal identifier",
5) Testing went well, but I am wondering if there is an issue with our MACRO
language. A lot of the examples I tried from the wiki would not work:
https://wiki.koha-community.org/wiki/Advanced_editor_macros
Especially the RDA macros that add multiple subfields - only the first subfield
code will be recognized. I assume they used to work (trusting Heather), so what
happened there?
As this is so heavy on API it would be nice to get Tomas to have a look too.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Aleisha Amohia changed: What|Removed |Added Attachment #92166|0 |1 is obsolete|| --- Comment #19 from Aleisha Amohia --- Created attachment 101914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101914=edit Bug 23352: Changes to unit tests Changes to t/db_dependent/Serials.t unit tests to capture and test the changes to NewSubscription() and ModSubscription() in C4/Serials.pm Test plan: 1. Follow test plan in first commit 2. From Koha home directory enter Koha shell and run: prove t/db_dependent/Serials.t Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Aleisha Amohia changed: What|Removed |Added Attachment #92165|0 |1 is obsolete|| --- Comment #18 from Aleisha Amohia --- Created attachment 101913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101913=edit Bug 23352: Default setting of item price, replacement price, ccode, dateaccesioned in serials-edit.pl This patch contains: * Database and DBIx changes * Setting 952g (items.price) and 952v (items.replacementprice) from Acquisitions module order unitprice and replacment cost respectively * Default setting of the 952d (items.dateaccessioned) on page load * New input in serials/subscription-add.pl for librarian to select default collection code for serial issues. * 2 new sysprefs: - DefaultToCreatingSerialIssuesOnReceival - Disabled by default. When enabled it sets the 'Create an item record when receiving this serial' to be ticked. - PopulateNewItemDateAccessionedOnPageLoad - Disabled by default. When enabled it populates the 952$d Date Acquired field in the item addition page without the cataloguer having to click in the field. Test plan: 1. Enter mysql terminal: sudo koha-mysql 2. Run the query: describe subscription; 3. Notice there is no 'ccode' column after the 'mana_id' column 4. In the staff client go to Serials > New subscription 5. Notice the 'Do not create an item record when receiving this serial' radiobutton is ticked by default. Click the 'Create an item record when receiving this serial' radiobutton 6. Fill out all the required serial fields, set the library branch to a branch different to the library branch you are currently logged in as and click 'Save subscription' 7. Now go to the Acquisitions module. Add a new basket to a vendor Add to the basket and select 'From a subscription' Search for the subscription you created in steps 5-6 Set a quantity, vendor price of 2 and replacement cost of 3 Save the order 8. Go back to Serials and recieve an item for the subscription and notice that the item creation form that is loaded when you change the status from 'Expected' to 'Arrived' does not set defaults for: 952$8 - Collection code 952$d - Date accessioned - You must click in the input box to load a default value for this 952$g - Cost 952$v - Replacement price Also note the 952$a and 952$b are set the library you set in the subscription and not the branch you are currently logged in as 9. Exit mysql terminal and apply patch 10. Navigate to the installer/data/mysql directory 11. Enter koha-shell: sudo koha-shell 12. Run: ./updatedatabase.pl 13. Notice 2 atomicupdates run without errors 14. Exit koha-shell and re-enter mysql terminal and confirm the 'ccode' column is in the subscription table now after mana_id column Exit the MySQL terminal. 15. In the Koha staff client > Administration > Global System Preferences and notice there is a new syspref in the 'Serials' system preferences named 'DefaultToCreatingSerialIssuesOnReceival' and there is a new syspref in the 'Cataloging' system preferences named - PopulateNewItemDateAccessionedOnPageLoad Notice both are disabled by default. 16. Repeat steps 4-8. Notice there is now a new input in the subscription-add.pl page 2: 'Serial issue Collection' which populates with the contents of the ccode authorised value Notice upon receiving the item the following fields do have a default value now: 952$8 - Collection code 952$g - Cost 952$v - Replacement price 17. Go back to Administration > Global System Preferences and set the 'DefaultToCreatingSerialIssuesOnReceival' and 'PopulateNewItemDateAccessionedOnPageLoad' syspref to 'Enabled' 18. Go back to Serials > New subscription and observe the 'Create an item record when receiving this serial' radiobutton is now checked by default 19. After creating the subscription repeat step 7 and now receive the serial and notice that the 952d Date Acquired is set automatically to todays date in the format: -MM-DD (i.e. you don't have to click in the field). 20. Try clicking in the 952d and notice no second date is appended 21. Sign off :) Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 Lucas Gass changed: What|Removed |Added Attachment #101911|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 101912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101912=edit Bug 24995: Add issuedate to table_account_fines and finest TO TEST: 1. Have a patron with some fines on an item. Try accruing fines. 2. Go to the accounting tab and look at both the Tranaction tab and Make a payment Tab 3. No Issue Date 4. Apply patch 5. Check those tabs again and see the issue date displays. 6. Go to column configuration and try to hide the issuedate, make sure it hides properly. Try this for both tables. Also make sure other columns hide properly. 7. Sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 --- Comment #1 from Lucas Gass --- Created attachment 101911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101911=edit Bug 24995: Add issuedate to table_account_fines and finest TO TEST: 1. Have a patron with some fines on an item. Try accruing fines. 2. Go to the accounting tab and look at both the Tranaction tab and Make a payment Tab 3. No Issue Date 4. Apply patch 5. Check those tabs again and see the issue date displays. 6. Go to column configuration and try to hide the issuedate, make sure it hides properly. Try this for both tables. Also make sure other columns hide properly. 7. Sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24995] Add issuedate to table_account_fines and finest in Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24995 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #42 from Katrin Fischer --- Hi Jonathan, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #77 from Andrew Fuerste-Henry --- Laura - It's hard to say when this will be in Koha, as it has not yet gone through QA. This patch doesn't include a mechanism to automatically assign items to volumes, but existing items can be added to volumes manually. Katrin - Yes, absolutely! I can see ways in which defining volumes of periodicals would be useful. Though the only functionality beyond the creation of a volume that's currently being worked on is that in bug 24860. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED --- Comment #16 from Aleisha Amohia --- I believe this patch is no longer required - in master, guarantors and guarantees are stored in borrower_relationships in the database. the relationship information is deleted when changing from child patron to adult patron using memberentry.pl and child-update.pl. Closing bug report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #76 from Katrin Fischer --- Could this also be used in context of bound serials (all issues of a year bound into one volume)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23224] Inconsistent behaviour between memberentry.pl and the update-child.pl when updating child patron to Adult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |FIXED CC||alei...@catalyst.net.nz --- Comment #11 from Aleisha Amohia --- I believe this patch is no longer required - in master, guarantors and guarantees are stored in borrower_relationships in the database. the relationship information is deleted when changing from child patron to adult patron using memberentry.pl and child-update.pl. Closing bug report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Bug 12949 depends on bug 23224, which changed state. Bug 23224 Summary: Inconsistent behaviour between memberentry.pl and the update-child.pl when updating child patron to Adult https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #49 from Martin Renvoize --- Just spotted.. we need to add the `Sponsored-by: ` Line into at least one of the patches for the release notes ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #48 from Martin Renvoize --- With the new dependency added I believe we are unblocked again here.. resetting to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #7 from Agustín Moyano ---
(In reply to Agustín Moyano from comment #4)
> 4. In your browser go to koha main page, open a console and type
> $date('2020-03-25', {tz:
>'UTC'})
Don't know why it added an enter.. in console you should type like this
$date(''2020-03-25', {tz:'UTC'})
without that enter after "tz:"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 Martin Renvoize changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com, ||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize --- Excellent, thanks Agustin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 --- Comment #5 from Agustín Moyano --- (In reply to Martin Renvoize from comment #2) > How does that look to you? Great, it was just what I was looking for.. it just lacked the actual execution of creationData function.. too much Perl I guess, hehe Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #4 from Agustín Moyano ---
Created attachment 101910
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101910=edit
Bug 24980: (RM follow-up) Only add timezone if passed a date-time
This patch prevents a timezone from being assigned to the js moment if
the input string is only at the full-date and not date-time resolution
To test:
1. Do not apply this patch
2. Set your system time zone to CET
3. Apply previous patch (It's just for test)
4. In your browser go to koha main page, open a console and type
$date('2020-03-25', {tz:
'UTC'})
CHECK => you sould get '03/24/2020' (notice day is 24 instead of 25)
5. Apply this patch and reload the browser
6. repeat step 4
SUCCESS => now you get '03/25/2020' (day is correct)
7. Sing off
Signed-off-by: Martin Renvoize
Signed-off-by: Agustin Moyano
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 Agustín Moyano changed: What|Removed |Added Attachment #101794|0 |1 is obsolete|| --- Comment #3 from Agustín Moyano --- Created attachment 101909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101909=edit [DO NOT PUSH] Bug 24980: This patch is only for test purposes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 Martin Renvoize changed: What|Removed |Added Attachment #100220|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 101908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101908=edit Bug 24815: Add additional tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Martin Renvoize --- Rebased, thanks for yesting Jon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
