[Koha-bugs] [Bug 26229] Move translatable strings out of categories.tt and into categories.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26229 David Nind changed: What|Removed |Added Attachment #108401|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 110816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110816&action=edit Bug 26229: Move translatable strings out of categories.tt and into categories.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Patron categories - Click "New category" - Enter some special characters in the "Category code" field, e.g. "%^&*" - Try to submit the form without filling in any other details. - The category code field should have a validation message, "Category code can only contain the following characters: letters, numbers, - and _." - The enrollment period fields should have a validation message, "Please choose an enrollment period in months OR by date." - Enter valid data and confirm that the form can be submitted. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/categories.js for translation, e.g.: msgid "Please choose an enrollment period in months OR by date." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26229] Move translatable strings out of categories.tt and into categories.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26229 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26225] Move translatable strings out of audio_alerts.tt and into audio_alerts.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26225] Move translatable strings out of audio_alerts.tt and into audio_alerts.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 David Nind changed: What|Removed |Added Attachment #108394|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 110817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110817&action=edit Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Audio alerts. - Click the "Delete selected alerts" button without checking any checkboxes. You should see an error: "Check the box next to the alert you want to delete." - Check the checkbox for an existing sound and click "Delete selected alerts." You should get a confirmation message, "Are you sure you want to delete the selected audio alerts?" - Click "New alert." - Without filling any details, click the "Play sound" button. You should see an error message, "Please select or enter a sound." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js for translation, e.g.: msgid "Are you sure you want to delete the selected audio alerts?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24581] Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.branchprinter' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24581 Katrin Fischer changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26441] Move translatable strings out of catalog-strings.inc into catalog.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26441 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26441] Move translatable strings out of catalog-strings.inc into catalog.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26441 David Nind changed: What|Removed |Added Attachment #110410|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 110818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110818&action=edit Bug 26441: Move translatable strings out of catalog-strings.inc into catalog.js This patch moves translatable strings out of catalog-strings.inc into catalog.js, wrapped in the double-underscore function for translation. To test that each affected string correctly appears in the interface: - View the details for a bibliographic record which has items attached. - From the Edit menu, choose "Delete record." You should get an alert, "X item(s) are attached to this record. You must delete all items before deleting this record." - From the Edit menu, choose "Delete all items." You should get an alert, "Are you sure you want to delete the X attached items?" - When logged in as a user with acquisitions and cataloging privileges, view the details for a bibliographic record which is used in an order in Acquisitions. Delete any items attached. - Choose "Delete record" from the Edit menu. You should get an alert, "Warning: This record is used in X order(s). Deleting it could cause serious issues on acquisition module. Are you sure you want to delete this record?" - In Acquisitions, view a basket containing orders. Cancel the order for a title in the basket. Open the detail page for the title in the cancelled order. Try to delete it. You should get an confirmation, "X deleted order(s) are using this record. Are you sure you want to delete this record?" - Perform the same test as a user with cataloging but not acquisitions privileges. The alert should say "X deleted order(s) are using this record. You need order managing permissions to delete this record." - When logged in as a user with cataloging but not acquisitions privileges, view the details for a bibliographic record which is used in an order in Acquisitions. Delete any items attached. - Choose "Delete record" from the Edit menu. You should get an alert, "X order(s) are using this record. You need order managing permissions to delete this record." - View the details for a bibliographic record which has a hold. - Choose "Delete all items" from the Edit menu. You should get an alert, "X hold(s) on this record. You must delete all holds before deleting all items." - View the details for a bibliographic record which has no items. - Choose "Delete record" from the Edit menu. You should get an alert, "Are you sure you want to delete this record?" - Choose "Edit items in a batch" from the Edit menu. You should get an alert, "This record has no items." I could not find any instance of the PopupZ3950Confirmed function in catalog.js being triggered so I don't think the associated string can be tested. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/catalog.js for translation, e.g.: msgid "This record has no items." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26244] Move translatable strings out of memberentrygen.tt and into JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Hi Owen. I'm not sure what I'm doing wrong for this one. I've tried several times. But whatever I try I can't get it to recognise changes for the age/month/year phrases or the message when changing patron category. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer --- Hi Andrew, starting with some QA work here. Tbh I've never heard of this specific functionality in an ILS before and am a bit stumped on the use case. Can you explain a bit on how this is used in libraries? 1) QA script fails FAIL C4/Circulation.pm OK critic FAIL forbidden patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 2933) FAIL t/db_dependent/Circulation/issue.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Can't locate Koha/IssuingRules.pm in @INC (you may need to install the Koha::IssuingRules module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/kohadev/plugins) 2) Database updates There is lots of them :) a) The one thing that gives me a bit of a headache is the change to the notices for existing installations. I think we should leave that one out as we cannot safely assume what people have 'done' to this notice - they will have translated it, might have decided to not inform patrons of the reasons at all, changed the structure etc. I feel we should not interfere here. b) You have a mismatch between kohastructure.sql and the updates for issues/old_issues: AFTER renewals vs. after auto_renew 3) Strings in Javascript This is an old patch, I am aware, but not sure if you have seen yet: We are moving the strings back into the js as they can be finally translated within the file now. See bug 21156 for examples. I am not going to block this, but it would be nice if the patches could be changed to use the new mechanism right away. 4) Terminology We just did a major clean-up on the system preferences, that's why I am a bit nit-picky there. Every change later requires translators to do the work again too - so it might be forgiven: +- renewals to be recorded as "unseen" by the library, and count against the borrowers unseen renewals limit Can you please make the borrowers patrons and add a .? 5) Web based self check Renewals are also possible with the web based self check - so I feel some changes will be needed there as well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26120] Remove the use of jquery.checkboxes plugin from tags review template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26120] Remove the use of jquery.checkboxes plugin from tags review template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120 David Nind changed: What|Removed |Added Attachment #107721|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 110819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110819&action=edit Bug 26120: Remove the use of jquery.checkboxes plugin from tags review template This patch removes the use of the jquery.checkboxes plugin and improves the handling of tag status markup so that the "Select all pending" selection link works correctly. To test, apply the patch and go to Tools -> Tags. To test properly you should have multiple tags awaiting moderation. - The initial view of tags moderation shows only tags awaiting moderation. Test that the "select all," "clear all," and "Select all pending" links work correctly. - Click the "Approve" button for a tag, and the "Reject" button for another tag. - Test the "Select all pending" link again. Only the tags awaiting moderation should be selected. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26441] Move translatable strings out of catalog-strings.inc into catalog.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26441 Katrin Fischer changed: What|Removed |Added Attachment #110818|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 110820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110820&action=edit Bug 26441: Move translatable strings out of catalog-strings.inc into catalog.js This patch moves translatable strings out of catalog-strings.inc into catalog.js, wrapped in the double-underscore function for translation. To test that each affected string correctly appears in the interface: - View the details for a bibliographic record which has items attached. - From the Edit menu, choose "Delete record." You should get an alert, "X item(s) are attached to this record. You must delete all items before deleting this record." - From the Edit menu, choose "Delete all items." You should get an alert, "Are you sure you want to delete the X attached items?" - When logged in as a user with acquisitions and cataloging privileges, view the details for a bibliographic record which is used in an order in Acquisitions. Delete any items attached. - Choose "Delete record" from the Edit menu. You should get an alert, "Warning: This record is used in X order(s). Deleting it could cause serious issues on acquisition module. Are you sure you want to delete this record?" - In Acquisitions, view a basket containing orders. Cancel the order for a title in the basket. Open the detail page for the title in the cancelled order. Try to delete it. You should get an confirmation, "X deleted order(s) are using this record. Are you sure you want to delete this record?" - Perform the same test as a user with cataloging but not acquisitions privileges. The alert should say "X deleted order(s) are using this record. You need order managing permissions to delete this record." - When logged in as a user with cataloging but not acquisitions privileges, view the details for a bibliographic record which is used in an order in Acquisitions. Delete any items attached. - Choose "Delete record" from the Edit menu. You should get an alert, "X order(s) are using this record. You need order managing permissions to delete this record." - View the details for a bibliographic record which has a hold. - Choose "Delete all items" from the Edit menu. You should get an alert, "X hold(s) on this record. You must delete all holds before deleting all items." - View the details for a bibliographic record which has no items. - Choose "Delete record" from the Edit menu. You should get an alert, "Are you sure you want to delete this record?" - Choose "Edit items in a batch" from the Edit menu. You should get an alert, "This record has no items." I could not find any instance of the PopupZ3950Confirmed function in catalog.js being triggered so I don't think the associated string can be tested. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/catalog.js for translation, e.g.: msgid "This record has no items." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26441] Move translatable strings out of catalog-strings.inc into catalog.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26441 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26120] Remove the use of jquery.checkboxes plugin from tags review template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26120] Remove the use of jquery.checkboxes plugin from tags review template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120 Katrin Fischer changed: What|Removed |Added Attachment #110819|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 110821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110821&action=edit Bug 26120: Remove the use of jquery.checkboxes plugin from tags review template This patch removes the use of the jquery.checkboxes plugin and improves the handling of tag status markup so that the "Select all pending" selection link works correctly. To test, apply the patch and go to Tools -> Tags. To test properly you should have multiple tags awaiting moderation. - The initial view of tags moderation shows only tags awaiting moderation. Test that the "select all," "clear all," and "Select all pending" links work correctly. - Click the "Approve" button for a tag, and the "Reject" button for another tag. - Test the "Select all pending" link again. Only the tags awaiting moderation should be selected. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26225] Move translatable strings out of audio_alerts.tt and into audio_alerts.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 Katrin Fischer changed: What|Removed |Added Attachment #110817|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110822&action=edit Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Audio alerts. - Click the "Delete selected alerts" button without checking any checkboxes. You should see an error: "Check the box next to the alert you want to delete." - Check the checkbox for an existing sound and click "Delete selected alerts." You should get a confirmation message, "Are you sure you want to delete the selected audio alerts?" - Click "New alert." - Without filling any details, click the "Play sound" button. You should see an error message, "Please select or enter a sound." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js for translation, e.g.: msgid "Are you sure you want to delete the selected audio alerts?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26225] Move translatable strings out of audio_alerts.tt and into audio_alerts.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26229] Move translatable strings out of categories.tt and into categories.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26229 Katrin Fischer changed: What|Removed |Added Attachment #110816|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110823&action=edit Bug 26229: Move translatable strings out of categories.tt and into categories.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Patron categories - Click "New category" - Enter some special characters in the "Category code" field, e.g. "%^&*" - Try to submit the form without filling in any other details. - The category code field should have a validation message, "Category code can only contain the following characters: letters, numbers, - and _." - The enrollment period fields should have a validation message, "Please choose an enrollment period in months OR by date." - Enter valid data and confirm that the form can be submitted. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/categories.js for translation, e.g.: msgid "Please choose an enrollment period in months OR by date." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26229] Move translatable strings out of categories.tt and into categories.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26229 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26229] Move translatable strings out of categories.tt and into categories.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26229 --- Comment #4 from Katrin Fischer --- Hi Owen, just a note: When the error message for 'month or date' appears it pushes the calendar icon after the error message. This is before and after the patch, so unrelated. But do we consider this a bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26395] Move translatable strings out of letter.tt into letter.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26395 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26395] Move translatable strings out of letter.tt into letter.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26395 Katrin Fischer changed: What|Removed |Added Attachment #110815|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 110824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110824&action=edit Bug 26395: Move translatable strings out of letter.tt into letter.js This patch moves strings defined for translation in letter.tt into letter.js for translation using the new double-underscore i81n function. Note, the "MSG_NO_NOTICE_FOUND" usage has been removed because it didn't work. To test, apply the patch and go to Tools -> Notices & Slips. - Use the "Copy" dropdown to copy an existing notice to a specific library. - Save the copied notice. - Return to the "All libraries" view on the Notices & Slips page. - Repeat the same process above: Copy the same notice to the same library. - When you click save on the "Add notice" page you should get an error message, "A letter with the code 'ACCTDETAILS' already exists for " - From the "All libraries" view on the Notices & Slips page, copy the text in the "Code" column of an existing notice. - Click "New notice" and choose the module of the notice you copied from. - On the "Add notice" page, paste the code into the "Code" field and enter a name in the "Name" field. - Click "Save" without making any other changes. You should get an error message, "Please fill at least one template." - Enter some data into one of the message body fields but not message subject, and click "Save" again. - You should get an error, "Please specify title and content for " - Enter data in the message subject field and click "Save" again. - You should get an error, "A default letter with the code already exists." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/letter.js for translation, e.g.: msgid "Please fill at least one template." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26217] Move translatable strings out of templates into acq.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26217 Katrin Fischer changed: What|Removed |Added Attachment #110814|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110825&action=edit Bug 26217: Move translatable strings out of templates into acq.js This patch removes the definition of translatable strings out of templates and into the JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to acquisitions, and view a vendor. - Click "Uncertain prices" in the sidebar menu. - In the table of orders, enter something in the "price" form field which isn't a valid price. You should get an error message. - Test the validation of fund amounts: Go to Administration -> Budgets and create an active budget if necessary. - Add a fund to that budget. Try to save the fund with a fund amount which exceed the amount in the budget. - You should get an error message: "Fund amount exceeds period allocation" - Add a fund with valid data and then go to Administration -> Funds and locate the fun you just created. - Use the "Actions" menu to add a sub fund to that fund. - Try to save this new fund with an amount which exceeds the amount in the parent fund. - You should get an error message, "Fund amount exceeds parent allocation." Note: I was unable to properly test the error message "New budget-parent is beneath budget." I couldn't figure out how to trigger it. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/acq.js for translation, e.g.: msgid "Fund amount exceeds period allocation" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26217] Move translatable strings out of templates into acq.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26217 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26217] Move translatable strings out of templates into acq.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26217 --- Comment #4 from Katrin Fischer --- It would be nice if the look and feel of the message could be a bit modernized - it still follows the very old style including - for formatting :) "Fund amount exceeds parent allocation" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26334] Move translatable strings out of members-menu.inc into members-menu.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26334] Move translatable strings out of members-menu.inc into members-menu.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334 Katrin Fischer changed: What|Removed |Added Attachment #110813|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 110826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110826&action=edit Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js This patch moves translatable strings out of members-menu.inc into members-menu.js where they can be translated using the double-underscore i18n function. To test, apply the patch and go to Patrons. - Expand the search options in the search header by clicking the [+] link. - Select "Date of birth" from the "Search fields" dropdown. - A tooltip should appear above the search form, "Dates of birth should be entered in the format..." with your current date format. - Remove all "Adult" type patron categories but one. - Check out to a child patron. - From the "More" menu choose "Update child to adult patron." - You should see a confirmation. - From the checkout screen, from the "More" menu, choose "Renew patron" - You should get a confirmation. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/members-menu.js for translation, e.g.: msgid "Are you sure you want to renew this patron's registration?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26339] Move translatable strings out of addorderiso2709.tt into addorderiso2709.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26339 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26339] Move translatable strings out of addorderiso2709.tt into addorderiso2709.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26339 Katrin Fischer changed: What|Removed |Added Attachment #110812|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110827&action=edit Bug 26339: Move translatable strings out of addorderiso2709.tt into addorderiso2709.js This patch moves strings defined for translation in addorderiso2709.tt into addorderiso2709.js for translation using the new double-underscore i81n function. To test, apply the patch and go to Acquisitions -> Vendor -> Basket -> Add orders from MARC file. - Click "Add orders" next to a staged file. - Without making any selections, click "Save." You should get an error, "There is no record selected." - Select a record and click "Save." You should get an error, "Some budgets are not defined in item records." - Enter a non-numeric value in the "Quantity" field and click "Save." You should get an error, "1 quantity values are not filled in or are not numbers." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js for translation, e.g.: msgid "Some budgets are not defined in item records" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26291] Move translatable strings out of z3950_search.inc into z3950_search.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26291] Move translatable strings out of z3950_search.inc into z3950_search.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 Katrin Fischer changed: What|Removed |Added Attachment #110811|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110828&action=edit Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js This patch moves translatable strings out of z3950_search.inc into z3950_search.js, wrapped in the double-underscore function for translation. To test, apply the patch and go to Cataloging. - Click "New from Z39.50/SRU" - In the search form, uncheck all search targets and submit the form. You should get an error: "Please choose at least one external target" - Peform a search which will return multiple pages of results. - Test that you can enter a number in the "Go to page" form to navigate to a specific page. - Enter a non-number in the field and submit. You should get an error, "The page entered is not a number." - Enter a number in the field which is greater than the number of pages of results. Submitting the form should trigger an error, "The page should be a number between 1 and 10." - Perform the same tests from the other Z39.50 search results interfaces: - Acquisitions -> Add to basket -> From an external source. - Authorities -> New authority -> New from Z39.50/SRU. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/z3950_search.js for translation, e.g.: msgid "The page entered is not a number." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25317] Move translatable strings out of additem.js.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317
--- Comment #3 from Katrin Fischer ---
Just a note: In some cases it could be nice to move the variables into the
translation as it would allow the translators to change the sequence of
words/structure of the sentence:
fieldname + " '" + sorted_arr[i] + "' "
+ __("is duplicated")
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25317] Move translatable strings out of additem.js.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25317] Move translatable strings out of additem.js.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 Katrin Fischer changed: What|Removed |Added Attachment #110810|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 110829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110829&action=edit Bug 25317: Move translatable strings out of additem.js.inc This patch moves the definition of translatable strings out of additem.js.inc and into additem.js using the new JS i81n function. additem.js.inc is removed, being obsolete. To test: When creating an order: - Go to Administration -> System preferences and set "AcqCreateItem" to "when placing an order." - Apply the patch and go to Acquisitions -> Vendor -> Add to basket -> From a new (empty) record. - In the "Item" section, confirm that the buttons at the bottom of the form are correct: "Add item," "Clear," and "Add multiple items." - Click "Add multiple items." The placeholder in the revealed form field should read "Number of items to add." The corresponding button should be labeled "Add." - You should see a note, "NOTE: Fields listed in the 'UniqueItemsFields' system preference will not be copied." - Fill out the item entry form and add a number to the "multiple items" field. Click "Add." - A table of items should be displayed with "Edit" and "Delete" buttons for each new item. - Click one of the "Edit" buttons. The item form should be populated with the item's data, with an "Update item" button at the bottom. When receiving an order: - Go to Administration -> System preferences and set "AcqCreateItem" to "when receiving an order." - Go to Acquisitions -> Vendor -> Receive shipments. - Select or create an invoice. - Click "Receive" on an order which has a quantity greater than 1. - Add two items, duplicating in each at least one value which is marked as unique by the "UniqueItemFields" system preference (e.g. fill in the same barcode number for each item). - Click "Save." You should get an alert about duplicated values, and there should be an alert message on the page, "barcode 'XXX' is duplicated." - Edit one of the two items and change the barcode to one which already exists in your database. - Click "Save." An alert message should be shown on the page, "barcode 'XXX' already exists in the database." - Note: I was unable to find out how to trigger this error, "You can't receive any more items." It may be obsolete. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/additem.js for translation, e.g.: msgid "Add multiple items" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26261] Split calendar.inc into include file and JavaScript file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26261] Split calendar.inc into include file and JavaScript file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 Katrin Fischer changed: What|Removed |Added Attachment #110809|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 110830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110830&action=edit Bug 26261: Split calendar.inc into include file and JavaScript file This patch moves most of the JavaScript out of calendar.inc and into a new file, calendar.js. English strings in calendar.js are now wrapped in the double-underscore function to allow for translation. The patch shouldn't affect datepicker functionality in any way. To test, apply the patch and test the datepicker in various contexts: - Reports -> Statistics wizards -> Patrons - Date of birth "from" and "to" should be linked so that the former must come before the latter. - Patrons -> Add or edit patron - The date of birth field datepicker shouldn't allow you to pick a future year from the dropdown. - Tools -> Calendar. - Test that the calendar tool works correctly. - Test with various settings of the dateformat system preference. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/en/js/calendar.js for translation, e.g.: msgid "August" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and test the datepicker again. Translated strings like days of the week and months should be correct. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #37 from Katrin Fischer --- The dependent bug 26057 still requires sign-off - moving to BLOCKED for the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 David Nind changed: What|Removed |Added Attachment #109969|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 110831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110831&action=edit Bug 26439: Move cart-related strings out of js_includes.inc and into basket.js This patch moves strings defined for translation in js_includes.inc into basket.js for translation using the new double-underscore i81n function. To test, apply the patch and perform a catalog search in the staff client. - Click the Cart link in the header menu. A pop-up should appear saying "Your cart is currently empty." - On the search results page, click the "Add to cart" link next to any search result. The text should change to "In your cart." - Click the "Remove" link. The text should change to "Add to cart." - Check the box next to a title in the search results and click the "Add to cart" button in the search results toolbar. A message should appear, "1 item(s) added to your cart." - Click the "Add to cart" button again. You should see the message "No item was added to your cart (already in your cart)!" - Uncheck all check boxes on the search results page and click "Add to cart." You should see "No item was selected." - Add more items to your cart so that it contains more than one item. - Click the "Cart" link to open it. - Click the "Empty and close" button. You should be asked to confirm, "Are you sure you want to empty your cart?" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/basket.js for translation, e.g.: msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26154] Remove the use of jquery.checkboxes plugin from batch item deletion and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #2 from David Nind --- The patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #13 from Alex Buckley --- Hi David, Ohh, thanks for noting that! I'll look into why that's happening and hopefully update the patches on here today. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5697] Automatic linking in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #9 from David Cook --- I wonder if we could use SQL::Translator to translate the SQL into a JSON data structure that could be rendered by TT. I don't know enough about the module but *maybe* it has support for getting column names before they're aliased? Probably not but you never know? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26154] Remove the use of jquery.checkboxes plugin from batch item deletion and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26154] Remove the use of jquery.checkboxes plugin from batch item deletion and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 Owen Leonard changed: What|Removed |Added Attachment #107858|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 110832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110832&action=edit Bug 26154: Remove the use of jquery.checkboxes plugin from batch item deletion and modification This patch removes the use of the jquery.checkboxes plugin from the batch item modification and batch item deletion pages. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes. - On the results page, test the "Select all" and "Clear all" controls at the top of the page. These should work correctly on the checkboxes in the table of results. - Test that the "Clear on loan" control still works to uncheck checkboxes corresponding to items which are checked out. - Test the "Show all columns" and "Hide all columns" checkboxes in the "Show/hide columns" section. These should work correctly on the checkboxes for showing and hiding columns in the table. - Go to Tools -> Batch item deletion. - Submit a batch of barcodes. - Repeat the same testing steps above (except the "Clear on loan" step). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26154] Remove the use of jquery.checkboxes plugin from batch item deletion and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26154] Remove the use of jquery.checkboxes plugin from batch item deletion and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 David Nind changed: What|Removed |Added Attachment #110832|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 110833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110833&action=edit Bug 26154: Remove the use of jquery.checkboxes plugin from batch item deletion and modification This patch removes the use of the jquery.checkboxes plugin from the batch item modification and batch item deletion pages. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes. - On the results page, test the "Select all" and "Clear all" controls at the top of the page. These should work correctly on the checkboxes in the table of results. - Test that the "Clear on loan" control still works to uncheck checkboxes corresponding to items which are checked out. - Test the "Show all columns" and "Hide all columns" checkboxes in the "Show/hide columns" section. These should work correctly on the checkboxes for showing and hiding columns in the table. - Go to Tools -> Batch item deletion. - Submit a batch of barcodes. - Repeat the same testing steps above (except the "Clear on loan" step). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #53 from Arthur Suzuki --- yup, still, thanks martin for the helpful technical advises. And thanks to both of you (nick, martin) for reviewing. I'll do the follow-up. Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
