[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 Henry Bolshaw changed: What|Removed |Added Attachment #125185|0 |1 is obsolete|| --- Comment #8 from Henry Bolshaw --- Created attachment 126028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126028=edit Bug 28101: Update breadcrumb markup in the OPAC for consistency and accessibility Modified breadcrumbs to be accessible, in particular for a screen-reader. Also ensured the breadcrumbs were all consistent. Made the block of breadcrumbs to be a with an ordered list inside. The last breadcrumb also has aria-current="page" to specify that it is the current page. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Confirm that OPAC templates are updated consistently to use breadcrumbs markup beginning with '' - Pages in the OPAC should look consistent, with the last breadcrumb styled as text and with the "aria-current" attribute "page." Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be more accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101 Henry Bolshaw changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 --- Comment #4 from David Cook --- Wow, this one isn't already fixed? I thought that someone had already done a patch but they must not have... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #87 from Alex Buckley --- (In reply to Caroline Cyr La Rose from comment #86) > Hi Alex, > > Patches apply well! I'm having problems with the test plan, however. > > I'm stuck at step 6 from Comment #81. > > When I log in with a user who did not create the list (whatever their > permissions, whatever the 'changes allowed from' value (owner only or staff > only)), I can't see public lists. > > Here's what I tried : > > 1. With superlibrarian, I created a public list set to 'owner only' >--> Public lists appear OK > 2. With staff account who has 'catalog' permission, I went to Lists > Public > lists >--> Public lists appear OK > 3. I applied 3 first patches, updated db (I don't have plack/memcached > installed) > 4. With superlibrarian, I went to Lists > Public lists >--> Public lists appear OK > 5. With staff account who has 'catalog' permission, I went to Lists > Public > lists >--> 'Processing' appears and lists never load > 6. With staff account who has 'catalog' permission, I created a public list > set to 'owner only' >--> Public lists still don't appear > 7. With superlibrarian, I went to Lists > Public lists >--> Public lists don't appear anymore for this user > > I also tried by applying all patches and with a staff account who has > 'lists' permission and with public lists with different 'changed allowed > from' values. When patches are applied, public lists appear only to the > owner, only if they are all created by that same owner. If there are public > lists by multiple owners, nobody can see public lists. > > Is this because I don't have plack/memcached? I have a git install on my > computer that I constantly update (I don't use devbox or ktd). > > Caroline Hi Caroline, Thank you for testing. I'll look into what might be happening here and get back to you. Thanks! Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #729 from David Nind --- Hi Aleisha. Patches no longer apply 8-(... Note: I will make it a priority for me to review and sign-off once it applies again. It would be nice to get all your hard work into master (finally!). Applying: Bug 19532: Database and installer stuff Using index info to reconstruct a base tree... M C4/Auth.pm M Koha/CirculationRules.pm M Makefile.PL M admin/smart-rules.pl M installer/data/mysql/en/mandatory/sample_notices.yml A installer/data/mysql/fr-CA/obligatoire/sample_notices.sql M installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql M installer/data/mysql/kohastructure.sql M installer/data/mysql/mandatory/sysprefs.sql M installer/data/mysql/mandatory/userpermissions.sql A installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc CONFLICT (modify/delete): installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql deleted in HEAD and modified in Bug 19532: Database and installer stuff. Version Bug 19532: Database and installer stuff of installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql left in tree. Auto-merging installer/data/mysql/mandatory/userpermissions.sql Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql CONFLICT (content): Merge conflict in installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql CONFLICT (modify/delete): installer/data/mysql/fr-CA/obligatoire/sample_notices.sql deleted in HEAD and modified in Bug 19532: Database and installer stuff. Version Bug 19532: Database and installer stuff of installer/data/mysql/fr-CA/obligatoire/sample_notices.sql left in tree. Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml Auto-merging admin/smart-rules.pl Auto-merging Makefile.PL Auto-merging Koha/CirculationRules.pm Auto-merging C4/Auth.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19532: Database and installer stuff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 David Nind changed: What|Removed |Added Attachment #125983|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 126027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126027=edit Bug 28694: Check alert in cataloguing should be a static message This patch modifies the basic cataloging interface so that form validation errors are collected in a static "dialog" at the top of the page instead of showing in a transient JavaScript alert. The text of the message is roughly the same as it was in the alert, and links have been added so that the user can click to jump directly to the field referenced. If the user scrolls down away from the static error message, a button appears in the floating toolbar to jump back to the message. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Cataloging and create a new record using the basic cataloging editor and a framework which has multiple mandatory fields defined (e.g. an unmodified default framework) - Without entering anything in mandatory fields, click the "Save" button. - You should see a message box appear at the top of the page. - It should list each missing mandatory subfield and tag, each with a "Go to field" link next to it. - Clicking the "Go to field" link should switch you to the correct tab and scroll the mandatory field into view. - When you have scrolled down far enough for the error messages to be offscreen, an "Errors" button should appear in the floating toolbar. Clicking it should scroll the box back into view. - The JS function for scrolling to a particular element on the screen has been modified, so test that the links in the toolbar for individual tags still work correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 George Veranis changed: What|Removed |Added Version|21.05 |master CC||gvera...@dataly.gr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28337] Add System-control-number index for authorities to MARC21 indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28337 Katrin Fischer changed: What|Removed |Added Attachment #126024|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 126026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126026=edit Bug 28337: Use existing definition in ccl.properties and bib1.att As the field is already dfined, we don't need to add anything here. Bib1.att can use the existing number as well To test, enable zebra debugging in koha-conf, adding 'request' to the list: none,fatal,warn,request Restart all the things Repeat matching (redo matching with no rule, then with OCN rule) Tail the zebra-output.log and note 1=Ohter-control-number is searched and match is found Perform a search in the staff client for: other-control-number:expialodocious Note in logs that 1=1211 is searched Previous test plan did not mention copying ccl.properties and bib1.att to the package install, so highlighted that things work without these changes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28337] Add System-control-number index for authorities to MARC21 indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28337 Katrin Fischer changed: What|Removed |Added Attachment #123184|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 126025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126025=edit Bug 28337: Add System-control-number index to Zebra MARC21 files To test: 1 - Apply patch 2 - Copy zebra files to destination: cp /kohadevbox/koha/etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml /etc/koha/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml cp /kohadevbox/koha/etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl 3 - Reindex authorities 4 - Edit an authority and add 035$aExpialodocious 5 - Export the authority 6 - Create a new record matchign rule: Matching rule code: OCN Description: Other control number Match threshhold: 1000 Record type: Authority record Search-index: Other-control-number Score: 1000 Tag: 035 Subfields: a 7 - Stage the record and use the new matchign rule 8 - Match found! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28337] Add System-control-number index for authorities to MARC21 indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28337 Katrin Fischer changed: What|Removed |Added Attachment #124240|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 126024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126024=edit Bug 28337: Use existing definition in ccl.properties and bib1.att As the field is already dfined, we don't need to add anything here. Bib1.att can use the existing number as well To test, enable zebra debugging in koha-conf, adding 'request' to the list: none,fatal,warn,request Restart all the things Repeat matching (redo matching with no rule, then with OCN rule) Tail the zebra-output.log and note 1=Ohter-control-number is searched and match is found Perform a search in the staff client for: other-control-number:expialodocious Note in logs that 1=1211 is searched Previous test plan did not mention copying ccl.properties and bib1.att to the package install, so highlighted that things work without these changes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28337] Add System-control-number index for authorities to MARC21 indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28337 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||oleon...@myacpl.org --- Comment #11 from Katrin Fischer --- I can see that this is something that has come up more than once. I am totally ok with us adding this feature, but I feel that it doesn't look quite right yet. 1) Styling If you look at the visible search, it's not "seamless" with the background color. The "Hide/Show" link is stuck to the very left end of the screen without any margin/padding and looks a little out of place. 2) I wonder if it would be more in line with how this page works, to stick the option into the "Settings" section and also make it stick with a cookie as the other options do? At the moment it resets to "hidden" with every page load. Bonus points for thinking about a way to make sure the "Hide/Show" link is translatable :) Could you please have a look and let me know what you think and if we might be able to fix 1) at least? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- As Marcel already stated, this is really interesting! I am starting with some simple testing and code review - I have not dug into 11175 yes, but I believe it covers a certain type of link, while what has been started here could be useful for a lot of the other link types. 1) Only add cni search part, if CNI is present As the patch stands right now it will always add the AND cni: bit, even if the $w doesn't contain a CNI part. I think it would be a little nicer, if we made the template create the whole query string and account for the missing CNI part. This template could then be easily reused for all 7xx and 8xx linking fields present in the code. 2) Staff and OPAC should be changed We already got a lot of inconistencies here - so we should at least try not to make it worse. Same change should be applied to the OPAC files. Glad to have some discussion! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Katrin Fischer changed: What|Removed |Added Attachment #123479|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 126023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126023=edit Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #7 from Katrin Fischer --- Hi Owen, a little confused about the fix: When we are at the stage of "onboarding" the system preferences and possible also custom.sql changes for changing it (de-DE does) have already been run. So I think it should not be undefined at this point. Also, I believe it's not the hint that is off, but the input is displaying the database format, that is not our default ... so maybe a problem for a different bug actually? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28470] Typo: Are you sure you with to chart this report?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470
Katrin Fischer changed:
What|Removed |Added
Attachment #125952|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer ---
Created attachment 126022
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126022=edit
Bug 28470: Typo: Are you sure you with to chart this report?
This patch corrects the text of a warning on the report results page,
from this:
_("Fetching full chart data for reports with many rows can cause
performance issues. Are you sure you with to chart this report?")
...to this:
_("Fetching full chart data for reports with many rows can cause
performance issues. Are you sure you want to chart this report?")
To test, apply the patch and go to Reports -> Use saved.
- Run a report which, unlimited, will return more than 1000 rows.
- Click the "Fetch all data for chart" button.
- You should be asked for confirmation. Check that the text is correct.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28470] Typo: Are you sure you with to chart this report?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23479] Hold cancellation confirmation too generic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #6 from Katrin Fischer ---
I am sorry, but besides the small change David pointed out, there are a couple
of smaller issues here:
$("#cancellation-text").html(`Are you sure you want to cancel hold of
${biblio_title} for ${borrower_name}?`);
At the moment, this message is not translatable. Please have a look at how to
use _() to make sure that the strings are picked up for translation by our
tools.
the mark-up is also not recommended as this will break the strings into
pieces and leaves you with a single "for" to translate. That is really hard to
get right without further context (at least in German it is :) ). Better to not
highlight single parts of sentences like this.
I believe we did have a rule about quotes... but I cannot find it :( The rule I
remember was to use double quotes around JS, as languages like French need to
be able to use single quotes in their translations and single quotes often
broke things for them as for the translators it's not obvious when they are
translating JS and need to escape.
Please let me know if we can help you making these adjustments!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29177] Remove TODO in acqui/finishreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29177 --- Comment #4 from Katrin Fischer --- Leaving for Martin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29193] DataTables only showing 20 results on checkout search and patrons search on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Katrin Fischer changed: What|Removed |Added Attachment #125984|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 126021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126021=edit Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29193] DataTables only showing 20 results on checkout search and patrons search on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29193] DataTables only showing 20 results on checkout search and patrons search on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 --- Comment #7 from Katrin Fischer --- (In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #4) > > > > Shouldn't this patron search use the same methods as other patron searches? > > Bug 15812 could make this one obsolete. I've just tested bug 15812 and it resolves the issue for checkout search, but not for the holds page, so I think this one is still a good little fix that would also be easily backportable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29162] Change template structure on OPAC library page so that a single library can easily be hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162 Katrin Fischer changed: What|Removed |Added Text to go in the||This patch adds markup to release notes||the OPAC library page so ||that CSS or JS can more ||easily target elements of ||the page: ||- Each library ||section is wrapped in a div ||with a unique id ||- Classes ||are added to the paragraphs ||containing phone, fax, URL, ||and library description. ||- ||An ID has been added to the ||menu of libraries in the ||sidebar so that they can be ||targetted individually. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 --- Comment #6 from Katrin Fischer --- Thanks for the rebase, but also for the patch - it really makes the page much easier to read! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Katrin Fischer changed: What|Removed |Added Attachment #125711|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 126020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126020=edit Bug 28816: Improve the display of multiple holds during hold process This patch updates the appearance of the "confirm holds" page, shown during the process of placing a hold for someone in the staff interface. Most of the changes affect the appearance of the page when placing multiple holds on titles which have one or more holds on them already. The changes are intended to make the page clearer and easier to scan, especially when placing multiple holds at once. Also changed: The page heading when placing multiple holds now changes based on whether you've selected a patron or not. It says "Search patrons or clubs" when it's waiting for a patron/club selection. It says "Place holds" after the patron/club has been selected. This is instead of "Confirm holds" on both pages. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and set HoldsSplitQueue to "nothing." - Perform a search in the staff client catalog and place multiple holds titles from that result set on hold for a patron. - Perform the same search and select one or more of the titles you selected before in addition to one or more titles with no holds. - After clicking the "Place hold" button you should see a page with the heading "Search patrons or clubs" showing information about existing holds. This section of the page should be clear and readable, with clear distinction between each section of information about each hold. - Test this page again under each different option for the "HoldsSplitQueue" system preference by changing the preference and reloading the page. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28963] Use Flatpickr on calendar page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 Katrin Fischer changed: What|Removed |Added Attachment #125797|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 126019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126019=edit Bug 28963: Use Flatpickr on calendar page This patch replaces the use of jQueryUI's datepicker widget on the Calendar page. In order to ease customization of the static calendar which shows the current calendar, I've converted the calendar.css file to SCSS. This allows us to define new SCSS variables to pass to the Flatpickr SCSS. Also changed: Removed some unecessary comments in the template. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Tools -> Calendar. - Confirm that entering holidays works correctly for all types: Single, weekly, yearly, ranges, repeated ranges. - Confirm that holidays are deleted as expected. - Confirm that the colors of each type of holiday is correct. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28963] Use Flatpickr on calendar page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28988] Reindent calendar template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #10 from Katrin Fischer --- I believe that the heading issue on the accessilibity patch set would not be a difficult one to fix if we pushed this first, so I'd say let's move forward with this and flatpickr for now. Both accessibility and the date widget switch are things we want to push forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Katrin Fischer changed: What|Removed |Added Summary|Enable BakerTaylorEnabled |Enable BakerTaylorEnabled |content in the staff|content in the staff |interface |interface with separate ||system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307
Katrin Fischer changed:
What|Removed |Added
Summary|Make BakerTaylorEnabled |Enable BakerTaylorEnabled
|preference separate for |content in the staff
|staff and OPAC |interface
Keywords||release-notes-needed
Status|Signed Off |Failed QA
--- Comment #7 from Katrin Fischer ---
Having a look here - I can' test BakerTaylor content, so having a real close
look at the code.
As Owen pointed out this was not present before, so I think the small thing
here is that the pref description was wrong before, but the big thing is that
we add the content to staff! So I took the liberty to adjust the pref
description a bit (change back if you hate it)
As we rename the pref for the OPAC, I expected a lot more name changes there.
Checking with git grep I believe some were missed:
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF (
BakerTaylorEnabled ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc:
[% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || (
SyndeticsEnabled && SyndeticsCoverImages ) || GoogleJackets ||
BakerTaylorEnabled || ( Koha.Preference('OpacCoce') &&
Koha.Preference('CoceProviders') ) || (
Koha.Preference('OPACCustomCoverImages') AND
Koha.Preference('CustomCoverImagesURL') ) ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc:
[% IF ( BakerTaylorEnabled ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt:[% IF (
BakerTaylorEnabled ) %][% IF bt_id %]https://[%
BakerTaylorBookstoreURL |url %][% bt_id | uri %]">[% END %][%
END %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt:
[% IF BakerTaylorEnabled %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:
[% IF ( BakerTaylorEnabled &&
!BakerTaylorBookstoreURL ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:
[% IF ( BakerTaylorEnabled &&
BakerTaylorBookstoreURL ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:
[% IF (
Koha.Preference('BakerTaylorEnabled') &&
!Koha.Preference('BakerTaylorBookstoreURL') ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:
[% IF (
Koha.Preference('BakerTaylorEnabled') &&
Koha.Preference('BakerTaylorBookstoreURL') ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt:[% IF (
BakerTaylorEnabled && bt_id ) %]https://[% BakerTaylorBookstoreURL |
uri %][% bt_id | uri %]">[% END %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt:
[% IF ( BakerTaylorEnabled ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:
[% IF ( BakerTaylorEnabled ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:
[% IF ( BakerTaylorEnabled ) %]
Only seeing this one was changed:
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt:
[% IF ( OPACBakerTaylorEnabled && bt_id ) %]
I think the issue is in the test plan, it should be: Disable staff interface
and only enable OPAC. Verify it all still shows correctly.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29186] Move reports result limit menu into toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hi Owen, I am seeing something a little odd here, can you please check? Tested on the standard sample database with a bit below 1000 items: 1) Create a new SQL report: select * from items; 2) Run the report 3) By default, 20 results show on first page. 4) Switch to 1000 5) All results show, but the pull down disappears and you can't switch the setting again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29201] New: biblio_framework missing form list of runtime parameters when editing SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29201 Bug ID: 29201 Summary: biblio_framework missing form list of runtime parameters when editing SQL reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org There is a runtime parameter biblio_framework documented in the manual that is not showing up as an option in the new'ish pull down for adding runtime parameters to reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28441] Terminology: Reserve notes should be Hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28441 Katrin Fischer changed: What|Removed |Added Attachment #125954|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 126018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126018=edit Bug 28441: Terminology: Reserve notes should be Hold notes This bug corrects the text "Reserve notes" to be "Hold notes" on the holds to pull page. To test, apply the patch and go to Circulation -> Holds to pull. You should see in the table header a column labeled "Hold notes." Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28441] Terminology: Reserve notes should be Hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28441 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28956] Acquisitions: select correct default tax rate when receiving orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 --- Comment #5 from Katrin Fischer --- Hi Julien, I hope it's ok, I added your sign-off line as: Signed-off-by: Julien Sicot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28956] Acquisitions: select correct default tax rate when receiving orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Katrin Fischer changed: What|Removed |Added Attachment #124567|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 126017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126017=edit Bug 28956: correct default tax rate on orderreceive When there is more than one tax rate defined in system preferences, and a vendor has a tax rate that is not 0%, then when you are receiving an order in a basket for that vendor, the default tax rate should be the correct non 0 rate. This should be seen in acqui/orderreceive. To test: 1) Go to staff client 2) Go to Koha administration 3) Search for "tax rate" in system preferences 4) Add 0|0.15 into the preference 5) Create a vendor 6) Set vendor tax rate to 15% 7) Add a new basket to vendor 8) Add to basket 9) Add any sample order to basket - add actual cost 10) Close basket 11) Receive shipment 12) Make invoice 13) Click on Receive in the table 14) Should be on orderreceive.pl page 15) Observe tax rate default is 0% 16) Apply patch 17) Refresh page 18) Observe tax rate default is 15% Sponsored-by: Catalyst IT Signed-off-by: Julien Sicot Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28956] Acquisitions: select correct default tax rate when receiving orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Joonas Kylmälä changed: What|Removed |Added CC||nug...@gmail.com, ||stalkern...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #57 from Katrin Fischer --- Same behaviour when using the "next" button for navigating between the results, initial page load is always without the Google cover. Requires an explicit refresh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #56 from Katrin Fischer --- I am very sorry, but I think I found another inconsistency: CustomCoverImages LocalCoverImages AllowMultipleCovers GoogleJackets 1) On the results page: CustomCover (a random image url), local cover and Google cover. 2) Switch to detail page: Only custom and local cover show. 3) Reload page with F5: Google cover appears. Same test plan applies to results without a local cover. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 --- Comment #3 from Joonas Kylmälä --- Created attachment 126016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126016=edit Bug 26871: Flush SIP2 cache on every SIP request SIP connections tend to be long lived, weeks if not months, in the libraries I see. Basically the connection per SIP machine is initiated once when the SIP machine boots and then never closed until maintanance needs to be done. Therefore we need to reset the Koha's L1 caches on every SIP request to get the latest sysprefs and configs from the memcached cache that is shared between all the Koha programs (intranet, opac, sip, cronjobs) and is guaranteed to be up to date. To test: 0. Have kohadevbox 1. Enable IssueLog 2. In one terminal run the command "perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml" 3. Checkin and return a book using telnet: $ telnet localhost 6001 9300CNterm1|COterm1|CPCPL| 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| 4. Keep the telnet connection open and go to http://localhost:8081/cgi-bin/koha/tools/viewlog.pl and check that the *checkout* entry is in the circulation rules 5. 6. Disable IssueLog 7. Move back to the telnet prompt and check out and return a book again 11YN2021101010565320211010 105653AOCPL|AA1|AB30001|ACterm1|BON|BIN| 09N2021101010564420211010 105644APCPL|AOCPL|AB30001|ACterm1|BIN| 8. Go check out the circulation logs and notice a new entry was added when it shouldn't have according to the IssueLog syspref! 9. Apply patch and repeat steps to notice that the syspref is now followed correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Joonas Kylmälä changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29199] Classes in item availability on OPAC results no longer set correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29199 Katrin Fischer changed: What|Removed |Added Summary|MARC21slim2OPACResults.xsl |Classes in item |has HTML class name typo|availability on OPAC ||results no longer set ||correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29199] MARC21slim2OPACResults.xsl has HTML class name typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29199 --- Comment #4 from Katrin Fischer --- I checked against an older version, and this class names should probably contain things like ItemBranch, CallNumberAndLabel. So I've ruled out a typo here, definitely needs more investigation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29199] MARC21slim2OPACResults.xsl has HTML class name typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29199 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|NEW |ASSIGNED Severity|normal |major Assignee|koha-b...@lists.koha-commun |joonas.kylm...@iki.fi |ity.org | --- Comment #2 from Joonas Kylmälä --- Moving this to major as the original report (bug 23640) was as well, and the problem reported there should still exists for many of the users with the same severity. Starting to work on a patch now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29199] MARC21slim2OPACResults.xsl has HTML class name typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29199 --- Comment #3 from Katrin Fischer --- I am not sure this patch is correct. The idea here seems to have been that the XSLT variables should have been replaced by different values depending on context. This patch just makes them static. We should have a deeper look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29200] Adlibris cover service broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29200 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29200] New: Adlibris cover service broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29200 Bug ID: 29200 Summary: Adlibris cover service broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 8630 When turning on the Adlibris cover service now, there is a thumbnail link showing on the results list and a "Cover image" link (slightly prettier) on the details page, but no covers are showing. Maybe there is some new limitation on the service now? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 [Bug 8630] Add covers from AdLibris to the OPAC and Intranet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added Blocks||29200 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29200 [Bug 29200] Adlibris cover service broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #55 from Katrin Fischer --- Finally back to this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29112] Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | CC||joonas.kylm...@iki.fi --- Comment #6 from Joonas Kylmälä --- Fixes the problem, passing QA but noting down that those global variables could be moved in the future to _vars.scss now that we have such a file. Not blocking this because of that because there was pre-existing global variables already in the _mixins.scss file. Also, please describe in the commit what the change does and not what problem it solves, at least not in the title. Makes easier to verify intended changes, otherwise I have to guess based on the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 --- Comment #4 from Katrin Fischer --- Created attachment 126015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126015=edit Bug 29172: (follow-up) Amend preference text for control fields Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172
Katrin Fischer changed:
What|Removed |Added
Attachment #125754|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer ---
Created attachment 126014
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126014=edit
Bug 29172: Make CustomCoverImagesURL compatible with control fields
Bug 22445 added CustomCoverImagesURL that deals with MARC fields, but
control fields were not supported.
Test plan:
Turn CustomCoverImages on
Fill CustomCoverImagesURL with
https://covers.openlibrary.org/b/isbn/{006}-M.jpg
Add an isbn in 006 (0596001738 will work)
Go to the detail page of the bibliographic record and confirm that you
see a cover image.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29112] Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Joonas Kylmälä changed: What|Removed |Added Attachment #125751|0 |1 is obsolete|| --- Comment #5 from Joonas Kylmälä --- Created attachment 126013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126013=edit Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29112] Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29199] MARC21slim2OPACResults.xsl has HTML class name typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29199 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29199] MARC21slim2OPACResults.xsl has HTML class name typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29199 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28579] Typo: No record have been imported because they all match an existing record in your catalog.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28579 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | CC||joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28579] Typo: No record have been imported because they all match an existing record in your catalog.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28579 Joonas Kylmälä changed: What|Removed |Added Attachment #125953|0 |1 is obsolete|| --- Comment #3 from Joonas Kylmälä --- Created attachment 126012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126012=edit Bug 28579: Typo: No record have been imported because they all match an existing record in your catalog. This patch corrects a grammatical error in text which might be shown when adding records from a staged file to a basket. It corrects this: "No record have been imported because they all match an existing record in your catalog." ..to this: "No records have been imported because they all match existing records in your catalog." To see the error in Koha, apply the patch and export some records from Koha (Tools -> Export) and then re-import them using Tools -> Stage MARC for import. - Go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click the "Add to order" button corresponding to the file you just uploaded. - Select all records and define default accounting details. - When you click "Save" you should see the error message. Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28579] Typo: No record have been imported because they all match an existing record in your catalog.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28579 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29157] Cannot set date/date-time attributes to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29157 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Failed QA CC||joonas.kylm...@iki.fi --- Comment #9 from Joonas Kylmälä --- The unit test is in the wrong place, it should test the attributes_from_api function directly, please add it to t/db_dependent/Koha/Object.t. Otherwise the fix looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29197] commit_file.pl missing import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29197 Joonas Kylmälä changed: What|Removed |Added Attachment #125986|0 |1 is obsolete|| --- Comment #3 from Joonas Kylmälä --- Created attachment 126011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126011=edit Bug 29197: Add missing import in commit_file.pl This patch adds a new method import to the commit_file.pl script. To test: 1. Have MARC data staged 2. Run: $ kshell k$ perl misc/commit_file.pl --list-batches => FAIL: You get Undefined subroutine ::GetAllImportBatches called at misc/commit_file.pl line 68. 3. Apply this patch 4. Repeat 2 => SUCCESS: You get the list of batches 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29197] commit_file.pl missing import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29197 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29197] commit_file.pl missing import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29197 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #44 from Joonas Kylmälä --- (In reply to George Veranis from comment #30) > Hi Joonas, I did what you asked for , please check-it and tell me if you > need something more . Thanks for your QA ! Looks good now. Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698
--- Comment #43 from Joonas Kylmälä ---
Created attachment 126010
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126010=edit
Bug 24698: (follow-up) remove HTML select option for Series
The IFLA authorities format specification defines only the letters a-l
as possible values for authority leader 000 character position 9 ("Type
of entity"). Therefore, the first option from the HTML select dropdown
menu (" - Series") must be removed.
Mentored-by: Andreas Roussos
Signed-off-by: Joonas Kylmälä
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #42 from Joonas Kylmälä --- Created attachment 126009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126009=edit Bug 24698: (QA follow-up) Don't specify script type explictly It's makes the QA script complain because the option doesn't have any effect nowadays: https://www.w3.org/TR/2017/REC-html52-20171214/obsolete.html#warnings-for-obsolete-but-conforming-features Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #41 from Joonas Kylmälä --- Created attachment 126008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126008=edit Bug 24698: (QA follow-up) Don't specify select element's size if it is 1 This is to make the QA script happy, in order to not to break Bootstrap CSS rules, see Bug 28066 for more info Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #40 from Joonas Kylmälä --- Created attachment 126007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126007=edit Bug 24698: (QA follow-up) Filter untrusted input to prevent XSS Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #39 from Joonas Kylmälä --- Created attachment 126006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126006=edit Bug 24698: (QA follow-up) Use spaces instead of tabs This makes the QA script happy. Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #38 from Joonas Kylmälä --- Created attachment 126005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126005=edit Bug 24698: (QA follow-up) Make plugin script executable Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #37 from Joonas Kylmälä --- Created attachment 126004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126004=edit Bug 24698: (QA follow-up) Remove passing of authnotrequired parameter It should only be used when we want to override the default of auth being required. Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #36 from Joonas Kylmälä --- Created attachment 126003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126003=edit Bug 24698: (QA follow-up) Fix formatting and typos Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #35 from Joonas Kylmälä --- Created attachment 126002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126002=edit Bug 24698: (QA follow-up) Remove dead code These were left off from the copy taken from unimarc_field_100_authorities.pl Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #34 from Joonas Kylmälä --- Created attachment 126001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126001=edit Bug 24698: (QA follow-up) Align variables with whitespace Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #33 from Joonas Kylmälä --- Created attachment 126000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126000=edit Bug 24698: (QA follow-up) Remove debug info being outputted to the template This is only needed during development. Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #32 from Joonas Kylmälä --- Created attachment 125999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125999=edit Bug 24698: (QA follow-up) Fix errors caused by more strict exports being introduced The original patch "Bug 24698: Add plugin and template files for unimarc authority leader" doesn't work without explictly importing the methods from C4::Auth and C4::Output due to the default exports being changed in those modules after the patch was made. Signed-off-by: George Veranis Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä changed: What|Removed |Added Attachment #125669|0 |1 is obsolete|| Attachment #125929|0 |1 is obsolete|| Attachment #125930|0 |1 is obsolete|| Attachment #125931|0 |1 is obsolete|| Attachment #125932|0 |1 is obsolete|| Attachment #125933|0 |1 is obsolete|| Attachment #125934|0 |1 is obsolete|| Attachment #125935|0 |1 is obsolete|| Attachment #125936|0 |1 is obsolete|| Attachment #125937|0 |1 is obsolete|| Attachment #125938|0 |1 is obsolete|| Attachment #125939|0 |1 is obsolete|| Attachment #125940|0 |1 is obsolete|| --- Comment #31 from Joonas Kylmälä --- Created attachment 125998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125998=edit Bug 24698: Add plugin and template files for unimarc authority leader In Unimarc installations when adding/editing an authority record there is no Tag Editor for the leader field ( 000 ). This patch fixes that. Test plan: 1) Try to catalogue a new authoritry and check if on field 000 you can find the Tag Editor. 2) Apply the patch. 3) In the authorities framework view the subfields of field 000 and select for plugin option the value unimarc_leader_authorities.pl. 4) Restart memcached / plack if needed. 5) Repeat step 1 and notice if the Tag Editor is visible and click it to open new window in order to manage the field contents and press OK. 6) Check the value of the generated leader. Signed-off-by: Esther Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3153] 'maxoutstanding' syspref does not disallow placing holds on staff side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3153 Joonas Kylmälä changed: What|Removed |Added Assignee|joonas.kylm...@iki.fi |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29116] request.pl re-invents Koha::Patron::is_expired accessor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29116
Joonas Kylmälä changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment #6 from Joonas Kylmälä ---
(In reply to Jonathan Druart from comment #5)
> Same file:
>
> 266 my $expiry_date = $enrollment->patron->dateexpiry;
> 267 $member->{expiry} = 0; # flag set if patron account has expired
> 268 if ($expiry_date and
> 269 Date_to_Days(split /-/,$date) > Date_to_Days(split
> /-/,$expiry_date)) {
> 270 $member->{expiry} = 1;
> 271 }
>
> Can we fix that one as well please?
There's actually more to it, I had opened earlier early a separate bug report
for that with a patch: bug 29115. I'm putting this back to PQA.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29111] Remove dead code from intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #16 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #13) > Does not apply on top of bug 27526. At first glance I'd say that the changes > to additem are no longer valid (I cleaned them already). Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29111] Remove dead code from intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #15 from Joonas Kylmälä --- Created attachment 125997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125997=edit Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk Signed-off-by: Katrin Fischer Rebased-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29111] Remove dead code from intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä changed: What|Removed |Added Attachment #125652|0 |1 is obsolete|| Attachment #125653|0 |1 is obsolete|| --- Comment #14 from Joonas Kylmälä --- Created attachment 125996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125996=edit Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29111] Remove dead code from intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
