Re: [kvm-devel] [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID)
On Friday 25 January 2008 15:03:28 Avi Kivity wrote: Yang, Sheng wrote: I think it's OK for there is a judgment in __invvpid() to see if machine has the ability(also if it is allowed to using VPID). :) Oh right, I missed that. We can remove it now since it will only be called if vpid != 0, and that happens only on vpid enabled machines, no? Yes. I think we can replace vpid_sync_all() with vpid_sync_vcpu_all(), then there was no reference to vpid_sync_all() now... BTW: vpid_sync_all() can be used after VMX_ON, but just in case... So we may remove it for now. -- Thanks Yang, Sheng - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID)
Yang, Sheng a écrit : From 39551508c869f678f028655c062b3cb5fe4715bc Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 17 Jan 2008 15:14:33 +0800 Subject: [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID) To allow TLB entries to be retained across VM entry and VM exit, the VMM can now identify distinct address spaces through a new virtual-processor ID (VPID) field of the VMCS. Is it something supported by new processors only? If yes, could you please tell us which CPU support that? Thanks, Aurelien -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' [EMAIL PROTECTED] | [EMAIL PROTECTED] `-people.debian.org/~aurel32 | www.aurel32.net - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID)
Yang, Sheng wrote: Here is the updated patch: Applied, thanks. @@ -1714,6 +1788,8 @@ static int vmx_vcpu_reset(struct kvm_vcpu *vcpu) vmx_fpu_activate(vmx-vcpu); update_exception_bitmap(vmx-vcpu); + vpid_sync_all(); + return 0; This causes the new instruction to be executed unconditionally, which would #UD on older processors, no? I replaced it with vpid_sync_vcpu_all() which seems sufficient, or do I miss something? -- Any sufficiently difficult bug is indistinguishable from a feature. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID)
On Friday 25 January 2008 14:52:47 Avi Kivity wrote: Yang, Sheng wrote: Here is the updated patch: Applied, thanks. @@ -1714,6 +1788,8 @@ static int vmx_vcpu_reset(struct kvm_vcpu *vcpu) vmx_fpu_activate(vmx-vcpu); update_exception_bitmap(vmx-vcpu); + vpid_sync_all(); + return 0; This causes the new instruction to be executed unconditionally, which would #UD on older processors, no? I replaced it with vpid_sync_vcpu_all() which seems sufficient, or do I miss something? I think it's OK for there is a judgment in __invvpid() to see if machine has the ability(also if it is allowed to using VPID). :) Thanks! -- Thanks Yang, Sheng - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID)
Yang, Sheng wrote: I think it's OK for there is a judgment in __invvpid() to see if machine has the ability(also if it is allowed to using VPID). :) Oh right, I missed that. We can remove it now since it will only be called if vpid != 0, and that happens only on vpid enabled machines, no? -- Any sufficiently difficult bug is indistinguishable from a feature. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
