Re: Changes to contrib bootscripts
On Wed, 18 May 2011 12:16:22 -0500, DJ Lucas d...@linuxfromscratch.org wrote: Alright, with last commit to lsb-bootscripts, I think we are ready to go. Bruce, Matt, you guys get a chance to review the patch? Hi DJ, apologies for the delay, but I've now managed to review your patch. Firstly, thanks for taking the time to do this, it looks pretty good to me. Secondly, what follows are probably bike-shed topics, but I'll throw my 2p in along with everyone elses anyway :) : make-aux-files.sh: Why renaming things to lsb-bootscripts? If we're migrating (which I think we should), shouldn't we just move the lsb scripts out of contrib and then continue to refer to the package as the lfs-bootscripts? chapter07/console.xml: 1) Where did the consolelog script/configuration go? chapter07/network.xml: I quite like Red Hat's layout, but probably just because I've become accustomed to it through my day job. On that distro, network device config lives in /etc/sysconfig/network-scripts, and those files namely ifcfg-ifname and route-ifname. I certainly don't see the need for subdirectories under whichever directory is chosen to house the network configuration files, but maybe I'm being blinkered by my only needing static wired interfaces to be configured. Why are network scripts put under /lib/network-services? Again, possibly blinkered by my exposure to Red Hat, but keeping the service scripts in the same directory as the interface config files makes sense to me. Other than those minor points, I too think we're ready to go! Thanks again, Matt. -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
Re: Changes to contrib bootscripts
Matthew Burgess wrote: Firstly, thanks for taking the time to do this, it looks pretty good to me. I haven't had time to review yet. Secondly, what follows are probably bike-shed topics, but I'll throw my 2p in along with everyone elses anyway :) : make-aux-files.sh: Why renaming things to lsb-bootscripts? If we're migrating (which I think we should), shouldn't we just move the lsb scripts out of contrib and then continue to refer to the package as the lfs-bootscripts? I was thinking the same thing. Also, would this change, along with the /run, etc changes, be enough to roll the LFS version to 7.0? -- Bruce -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
Re: Changes to contrib bootscripts
Bruce Dubbs bruce.du...@gmail.com wrote: Matthew Burgess wrote: Firstly, thanks for taking the time to do this, it looks pretty good to me. I haven't had time to review yet. Secondly, what follows are probably bike-shed topics, but I'll throw my 2p in along with everyone elses anyway :) : make-aux-files.sh: Why renaming things to lsb-bootscripts? If we're migrating (which I think we should), shouldn't we just move the lsb scripts out of contrib and then continue to refer to the package as the lfs-bootscripts? Package name is still lfs-bootscripts, only directory name changed in svn. Reason is to avoid losing svn history (for both sets). At go time, we can 'svn mv' in whatever way is appropriate without losing history. I was thinking the same thing. Also, would this change, along with the /run, etc changes, be enough to roll the LFS version to 7.0? Maybe, up to you all. I've still got the DESTDIR changes POC coming along as well. Surprizingly, a lot changed to account for the /lib64 - /lib hack so it doesn't present nearly as well as it used to. -- DJ -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. -- This message has been scanned for viruses and dangerous content, and is believed to be clean. -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
Re: Changes to contrib bootscripts
Matthew Burgess matt...@linuxfromscratch.org wrote: On Wed, 18 May 2011 12:16:22 -0500, DJ Lucas d...@linuxfromscratch.org wrote: Alright, with last commit to lsb-bootscripts, I think we are ready to go. Bruce, Matt, you guys get a chance to review the patch? Hi DJ, apologies for the delay, but I've now managed to review your patch. Firstly, thanks for taking the time to do this, it looks pretty good to me. Secondly, what follows are probably bike-shed topics, but I'll throw my 2p in along with everyone elses anyway :) : make-aux-files.sh: Why renaming things to lsb-bootscripts? If we're migrating (which I think we should), shouldn't we just move the lsb scripts out of contrib and then continue to refer to the package as the lfs-bootscripts? No change, just file layout in SVN. chapter07/console.xml: 1) Where did the consolelog script/configuration go? echo kernel.printk=4 /etc/sysctl.conf chapter07/network.xml: I quite like Red Hat's layout, but probably just because I've become accustomed to it through my day job. On that distro, network device config lives in /etc/sysconfig/network-scripts, and those files namely ifcfg-ifname and route-ifname. I certainly don't see the need for subdirectories under whichever directory is chosen to house the network configuration files, but maybe I'm being blinkered by my only needing static wired interfaces to be configured. Might have to configure multiple services on one interface, for instance ip and ipx, or maybe one interface does not provide default gw, but a static route is still needed for a dual homed machine. Why are network scripts put under /lib/network-services? Again, possibly blinkered by my exposure to Red Hat, but keeping the service scripts in the same directory as the interface config files makes sense to me. Executables don't belong in /etc, this one was covered in Jeremy's thread. --DJ -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. -- This message has been scanned for viruses and dangerous content, and is believed to be clean. -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
Re: Changes to contrib bootscripts
On 05/18/2011 08:57 PM, Jeremy Huntwork wrote: On 5/18/11 9:26 PM, DJ Lucas wrote: Results of a bad sed? I hadn't noticed that, only fixing the misspelling in the dependencies. Prior to that commit it was kernel when it was mountkernfs. Fixing. Thanks. Ha ha, the ones in the parentheses got me, it looked intentional. I actually googled for 'linux virtel' thinking maybe there was some new terminology I missed somewhere. :) JH I hit dictionary.com before I realized what happened. -- DJ Lucas -- This message has been scanned for viruses and dangerous content, and is believed to be clean. -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
Re: Changes to contrib bootscripts
DJ Lucas wrote: Might have to configure multiple services on one interface, for instance ip and ipx, or maybe one interface does not provide default gw, but a static route is still needed for a dual homed machine. ipx? Does anyone still use that? -- Bruce -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
Re: Changes to contrib bootscripts
Bruce Dubbs wrote: DJ Lucas wrote: Might have to configure multiple services on one interface, for instance ip and ipx, or maybe one interface does not provide default gw, but a static route is still needed for a dual homed machine. ipx? Does anyone still use that? I use multiple files per interface for setting up wake-on-lan. signature.asc Description: OpenPGP digital signature -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
