[Libreoffice-commits] .: 2 commits - cairo/cairo cairo/cairo-1.10.2.patch cairo/pixman cairo/pixman-0.24.0.patch

2011-12-19 Thread Fridrich Strba
 cairo/cairo-1.10.2.patch  |   12 
 cairo/cairo/makefile.mk   |2 +-
 cairo/pixman-0.24.0.patch |   20 
 cairo/pixman/makefile.mk  |2 +-
 4 files changed, 26 insertions(+), 10 deletions(-)

New commits:
commit 8cf76f19c5bcaebd2e35a62d41e1d0ecd46fd94f
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Mon Dec 19 09:43:18 2011 +0100

Build ps and pdf cairo surfaces with MSVC

diff --git a/cairo/cairo-1.10.2.patch b/cairo/cairo-1.10.2.patch
index 195af16..74c139d 100644
--- a/cairo/cairo-1.10.2.patch
+++ b/cairo/cairo-1.10.2.patch
@@ -9,14 +9,10 @@
  CAIRO_HAS_GL_SURFACE=0
  CAIRO_HAS_DIRECTFB_SURFACE=0
  CAIRO_HAS_VG_SURFACE=0
-@@ -28,9 +28,9 @@
- CAIRO_HAS_SCRIPT_SURFACE=0
- CAIRO_HAS_FT_FONT=0
+@@ -30,7 +30,7 @@
  CAIRO_HAS_FC_FONT=0
--CAIRO_HAS_PS_SURFACE=1
--CAIRO_HAS_PDF_SURFACE=1
-+CAIRO_HAS_PS_SURFACE=0
-+CAIRO_HAS_PDF_SURFACE=0
+ CAIRO_HAS_PS_SURFACE=1
+ CAIRO_HAS_PDF_SURFACE=1
 -CAIRO_HAS_SVG_SURFACE=1
 +CAIRO_HAS_SVG_SURFACE=0
  CAIRO_HAS_TEST_SURFACES=0
@@ -47,7 +43,7 @@
  else
  ZLIB_CFLAGS += -I$(top_srcdir)/../zlib/
 -CAIRO_LIBS += $(top_builddir)/../zlib/zdll.lib
-+CAIRO_LIBS += $(top_builddir)/../zlib/zlib.lib
++CAIRO_LIBS += $(ZLIB3RDLIB)
  endif
  
  DEFAULT_CFLAGS = -nologo $(MS_MDFLAGS) $(OPT)
diff --git a/cairo/cairo/makefile.mk b/cairo/cairo/makefile.mk
index 0eaef24..7f84e3d 100644
--- a/cairo/cairo/makefile.mk
+++ b/cairo/cairo/makefile.mk
@@ -100,7 +100,7 @@ BUILD_DIR=$(CONFIGURE_DIR)$/src
 .ENDIF
 
 .ELSE   # WNT, not GCC
-BUILD_ACTION=$(GNUMAKE) -f Makefile.win32 CFG=release
+BUILD_ACTION=$(GNUMAKE) -f Makefile.win32 CFG=release ZLIB3RDLIB=$(ZLIB3RDLIB)
 BUILD_DIR=
 .ENDIF
 
commit b4c74957cbec8ce1fab512983f5133223376545e
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Mon Dec 19 09:42:32 2011 +0100

Fix MMX build of pixman with MSVC

diff --git a/cairo/pixman-0.24.0.patch b/cairo/pixman-0.24.0.patch
index 61ef416..a6141ac 100644
--- a/cairo/pixman-0.24.0.patch
+++ b/cairo/pixman-0.24.0.patch
@@ -122,4 +122,24 @@
  
  #include pixman-private.h
  
+--- misc/pixman-0.24.0/pixman/pixman-mmx.c 2011-11-06 13:47:42.0 
-0700
 misc/build/pixman-0.24.0/pixman/pixman-mmx.c   2011-12-19 
00:41:42.280402800 -0700
+@@ -309,7 +309,7 @@
+ 
+ /* Elemental unaligned loads */
+ 
+-static __inline__ __m64 ldq_u(uint64_t *p)
++static inline __m64 ldq_u(uint64_t *p)
+ {
+ #ifdef USE_X86_MMX
+ /* x86's alignment restrictions are very relaxed. */
+@@ -328,7 +328,7 @@
+ #endif
+ }
+ 
+-static __inline__ uint32_t ldl_u(uint32_t *p)
++static inline uint32_t ldl_u(uint32_t *p)
+ {
+ #ifdef USE_X86_MMX
+ /* x86's alignment restrictions are very relaxed. */
 
diff --git a/cairo/pixman/makefile.mk b/cairo/pixman/makefile.mk
index dcd489d..44ea09b 100644
--- a/cairo/pixman/makefile.mk
+++ b/cairo/pixman/makefile.mk
@@ -74,7 +74,7 @@ BUILD_DIR=$(CONFIGURE_DIR)
 
 .ELSE   # WNT, not GCC
 BUILD_DIR=pixman
-BUILD_ACTION=$(GNUMAKE) -f Makefile.win32 MMX=off SSE2=on CFG=release
+BUILD_ACTION=$(GNUMAKE) -f Makefile.win32 MMX=on SSE2=on CFG=release
 .ENDIF
 
 .ELIF $(GUIBASE)==aqua
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - cairo/cairo cairo/cairo-1.10.2.patch cairo/pixman cairo/pixman-0.24.0.patch

2011-12-19 Thread Fridrich Strba
 cairo/cairo-1.10.2.patch  |   12 
 cairo/cairo/makefile.mk   |2 +-
 cairo/pixman-0.24.0.patch |   31 +++
 cairo/pixman/makefile.mk  |2 +-
 4 files changed, 37 insertions(+), 10 deletions(-)

New commits:
commit 2889909e1e7ab5d69391bb6c0a0b37b48adac9ef
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Mon Dec 19 09:43:18 2011 +0100

Build ps and pdf cairo surfaces with MSVC

Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch

diff --git a/cairo/cairo-1.10.2.patch b/cairo/cairo-1.10.2.patch
index 533efdf..cd6b350 100644
--- a/cairo/cairo-1.10.2.patch
+++ b/cairo/cairo-1.10.2.patch
@@ -9,14 +9,10 @@
  CAIRO_HAS_GL_SURFACE=0
  CAIRO_HAS_DIRECTFB_SURFACE=0
  CAIRO_HAS_VG_SURFACE=0
-@@ -28,9 +28,9 @@
- CAIRO_HAS_SCRIPT_SURFACE=0
- CAIRO_HAS_FT_FONT=0
+@@ -30,7 +30,7 @@
  CAIRO_HAS_FC_FONT=0
--CAIRO_HAS_PS_SURFACE=1
--CAIRO_HAS_PDF_SURFACE=1
-+CAIRO_HAS_PS_SURFACE=0
-+CAIRO_HAS_PDF_SURFACE=0
+ CAIRO_HAS_PS_SURFACE=1
+ CAIRO_HAS_PDF_SURFACE=1
 -CAIRO_HAS_SVG_SURFACE=1
 +CAIRO_HAS_SVG_SURFACE=0
  CAIRO_HAS_TEST_SURFACES=0
@@ -47,7 +43,7 @@
  else
  ZLIB_CFLAGS += -I$(top_srcdir)/../zlib/
 -CAIRO_LIBS += $(top_builddir)/../zlib/zdll.lib
-+CAIRO_LIBS += $(top_builddir)/../zlib/zlib.lib
++CAIRO_LIBS += $(ZLIB3RDLIB)
  endif
  
  DEFAULT_CFLAGS = -nologo $(MS_MDFLAGS) $(OPT)
diff --git a/cairo/cairo/makefile.mk b/cairo/cairo/makefile.mk
index ccad5b4..fc0111c 100644
--- a/cairo/cairo/makefile.mk
+++ b/cairo/cairo/makefile.mk
@@ -96,7 +96,7 @@ BUILD_DIR=$(CONFIGURE_DIR)$/src
 .ENDIF
 
 .ELSE   # WNT, not GCC
-BUILD_ACTION=$(GNUMAKE) -f Makefile.win32 CFG=release
+BUILD_ACTION=$(GNUMAKE) -f Makefile.win32 CFG=release ZLIB3RDLIB=$(ZLIB3RDLIB)
 BUILD_DIR=
 .ENDIF
 
commit 546bb6c9b79bf9571a5089a2e2a5dc8b2642164e
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Mon Dec 19 09:42:32 2011 +0100

Fix MMX build of pixman with MSVC

diff --git a/cairo/pixman-0.24.0.patch b/cairo/pixman-0.24.0.patch
index 0611962..c848666 100644
--- a/cairo/pixman-0.24.0.patch
+++ b/cairo/pixman-0.24.0.patch
@@ -103,3 +103,34 @@
   { $as_echo $as_me:$LINENO: checking whether byte ordering is bigendian 5
  $as_echo_n checking whether byte ordering is bigendian...  6; }
  if test ${ac_cv_c_bigendian+set} = set; then
+--- misc/pixman-0.24.0/pixman/pixman-utils.c
 misc/build/pixman-0.24.0/pixman/pixman-utils.c
+@@ -27,6 +27,7 @@
+ #endif
+ #include stdio.h
+ #include stdlib.h
++#include limits.h
+ 
+ #include pixman-private.h
+ 
+--- misc/pixman-0.24.0/pixman/pixman-mmx.c 2011-11-06 13:47:42.0 
-0700
 misc/build/pixman-0.24.0/pixman/pixman-mmx.c   2011-12-19 
00:41:42.280402800 -0700
+@@ -309,7 +309,7 @@
+ 
+ /* Elemental unaligned loads */
+ 
+-static __inline__ __m64 ldq_u(uint64_t *p)
++static inline __m64 ldq_u(uint64_t *p)
+ {
+ #ifdef USE_X86_MMX
+ /* x86's alignment restrictions are very relaxed. */
+@@ -328,7 +328,7 @@
+ #endif
+ }
+ 
+-static __inline__ uint32_t ldl_u(uint32_t *p)
++static inline uint32_t ldl_u(uint32_t *p)
+ {
+ #ifdef USE_X86_MMX
+ /* x86's alignment restrictions are very relaxed. */
+
diff --git a/cairo/pixman/makefile.mk b/cairo/pixman/makefile.mk
index df9c795..225ae86 100644
--- a/cairo/pixman/makefile.mk
+++ b/cairo/pixman/makefile.mk
@@ -70,7 +70,7 @@ BUILD_DIR=$(CONFIGURE_DIR)
 
 .ELSE   # WNT, not GCC
 BUILD_DIR=pixman
-BUILD_ACTION=$(GNUMAKE) -f Makefile.win32 MMX=off SSE2=on CFG=release
+BUILD_ACTION=$(GNUMAKE) -f Makefile.win32 MMX=on SSE2=on CFG=release
 .ENDIF
 
 .ELIF $(GUIBASE)==aqua
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 2 commits - bridges/source sdext/source

2011-12-19 Thread Bjoern Michaelsen
 bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx |4 ++--
 sdext/source/pdfimport/makefile.mk|5 -
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit f233f3973631c664e0953f04f88a58234390c088
Author: Matthias Klose matthias.kl...@canonical.com
Date:   Mon Dec 19 10:51:43 2011 +0100

fix armhf build in bridges

Signed-off-by: Bjoern Michaelsen bjoern.michael...@canonical.com
Signed-off-by: Caolán McNamara caol...@redhat.com

diff --git a/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx 
b/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx
index 5b02678..9502b87 100644
--- a/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx
@@ -173,14 +173,14 @@ void MapReturn(sal_uInt32 r0, sal_uInt32 r1, 
typelib_TypeDescriptionReference *
 pRegisterReturn[0] = r0;
 break;
 case typelib_TypeClass_FLOAT:
-#if defined(__ARM_EABI__) || defined(__SOFTFP__)
+#if !defined(__ARM_PCS_VFP)  (defined(__ARM_EABI__) || defined(__SOFTFP__))
 pRegisterReturn[0] = r0;
 #else
 *(float*)pRegisterReturn = fret;
 #endif
 break;
 case typelib_TypeClass_DOUBLE:
-#if defined(__ARM_EABI__) || defined(__SOFTFP__)
+#if !defined(__ARM_PCS_VFP)  (defined(__ARM_EABI__) || defined(__SOFTFP__))
 pRegisterReturn[1] = r1;
 pRegisterReturn[0] = r0;
 #else
commit f2a1882be486986a76682ed51f481595e1cf0d5c
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date:   Fri Dec 16 19:55:37 2011 +0100

fix racecondition in sdext/source/pdfimport/makefile.mk

diff --git a/sdext/source/pdfimport/makefile.mk 
b/sdext/source/pdfimport/makefile.mk
index 641e90f..d33680f 100644
--- a/sdext/source/pdfimport/makefile.mk
+++ b/sdext/source/pdfimport/makefile.mk
@@ -156,11 +156,14 @@ $(COMPONENT_DIALOGS) : dialogs$/$$(@:f)
 @@-$(MKDIRHIER) $(@:d)
 $(COPY) $ $@
 
-$(COMPONENT_DESCRIPTION) : $(DESCRIPTION)
+$(COMPONENT_DESCRIPTION) : $(MISC)/descriptions
+
+$(MISC)/descriptions : $(DESCRIPTION)
 $(COPY) description-en-US.txt $(EXTENSIONDIR)
 .IF $(WITH_LANG) != 
 $(COPY) $(MISC)/$(EXTENSIONNAME)_in/description-*.txt $(EXTENSIONDIR)
 .ENDIF
+$(TOUCH) $@
 
 $(COMPONENT_IMAGES) :  $(SOLARSRC)$/$(RSCDEFIMG)$/desktop$/res$/$$(@:f)
 @@-$(MKDIRHIER) $(@:d)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - bridges/source

2011-12-19 Thread Bjoern Michaelsen
 bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 468fe685e3c58c84bce6d9a48b931dcc21682679
Author: Matthias Klose matthias.kl...@canonical.com
Date:   Mon Dec 19 10:51:43 2011 +0100

fix armhf build in bridges

Signed-off-by: Bjoern Michaelsen bjoern.michael...@canonical.com
Signed-off-by: Caolán McNamara caol...@redhat.com

diff --git a/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx 
b/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx
index 5b02678..9502b87 100644
--- a/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx
@@ -173,14 +173,14 @@ void MapReturn(sal_uInt32 r0, sal_uInt32 r1, 
typelib_TypeDescriptionReference *
 pRegisterReturn[0] = r0;
 break;
 case typelib_TypeClass_FLOAT:
-#if defined(__ARM_EABI__) || defined(__SOFTFP__)
+#if !defined(__ARM_PCS_VFP)  (defined(__ARM_EABI__) || defined(__SOFTFP__))
 pRegisterReturn[0] = r0;
 #else
 *(float*)pRegisterReturn = fret;
 #endif
 break;
 case typelib_TypeClass_DOUBLE:
-#if defined(__ARM_EABI__) || defined(__SOFTFP__)
+#if !defined(__ARM_PCS_VFP)  (defined(__ARM_EABI__) || defined(__SOFTFP__))
 pRegisterReturn[1] = r1;
 pRegisterReturn[0] = r0;
 #else
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sal/osl

2011-12-19 Thread Stephan Bergmann
 sal/osl/unx/thread.c |   39 +--
 1 file changed, 13 insertions(+), 26 deletions(-)

New commits:
commit 5c43f54af84675103ebb7757252fe064411dc021
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Dec 19 11:46:44 2011 +0100

At least GCC 4.5.1 does not allow #pragma GCC diagnostic inside functions.

diff --git a/sal/osl/unx/thread.c b/sal/osl/unx/thread.c
index 766cf06..b5d80f1 100644
--- a/sal/osl/unx/thread.c
+++ b/sal/osl/unx/thread.c
@@ -237,6 +237,14 @@ static void osl_thread_cleanup_Impl (void* pData)
 /*/
 /* osl_thread_start_Impl */
 /*/
+#if defined __GNUC__
+#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 2)
+#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 6)
+#pragma GCC diagnostic push
+#endif
+#pragma GCC diagnostic ignored -Wshadow
+#endif
+#endif
 static void* osl_thread_start_Impl (void* pData)
 {
 int terminate;
@@ -247,20 +255,7 @@ static void* osl_thread_start_Impl (void* pData)
 pthread_mutex_lock ((pImpl-m_Lock));
 
 /* install cleanup handler */
-#if defined __GNUC__
-#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 2)
-#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 6)
-#pragma GCC diagnostic push
-#endif
-#pragma GCC diagnostic ignored -Wshadow
-#endif
-#endif
 pthread_cleanup_push (osl_thread_cleanup_Impl, pData);
-#if defined __GNUC__
-#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 6)
-#pragma GCC diagnostic pop
-#endif
-#endif
 
 /* request oslThreadIdentifier @@@ see TODO @@@ */
 pImpl-m_Ident = insertThreadId (pImpl-m_hThread);
@@ -274,20 +269,7 @@ static void* osl_thread_start_Impl (void* pData)
 while (pImpl-m_Flags  THREADIMPL_FLAGS_SUSPENDED)
 {
 /* wait until SUSPENDED flag is cleared */
-#if defined __GNUC__
-#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 2)
-#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 6)
-#pragma GCC diagnostic push
-#endif
-#pragma GCC diagnostic ignored -Wshadow
-#endif
-#endif
 pthread_cleanup_push (osl_thread_wait_cleanup_Impl, (pImpl-m_Lock));
-#if defined __GNUC__
-#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 6)
-#pragma GCC diagnostic pop
-#endif
-#endif
 pthread_cond_wait ((pImpl-m_Cond), (pImpl-m_Lock));
 pthread_cleanup_pop (0);
 }
@@ -307,6 +289,11 @@ static void* osl_thread_start_Impl (void* pData)
 pthread_cleanup_pop (1);
 return (0);
 }
+#if defined __GNUC__
+#if __GNUC__  4 || (__GNUC__ == 4  __GNUC_MINOR__ = 6)
+#pragma GCC diagnostic pop
+#endif
+#endif
 
 /*/
 /* osl_thread_create_Impl */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-4' - package/source

2011-12-19 Thread Thorsten Behrens
 package/source/zipapi/ZipFile.cxx |8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

New commits:
commit e9fe4cbed27c750a40858ce532742b65ef441cb3
Author: Thorsten Behrens tbehr...@suse.com
Date:   Mon Dec 19 11:45:26 2011 +0100

Revert Fix n#653688

This reverts commit 4481a2fd1a40b27c1f8e784517b79fcc3c3ca196.

Broke password-protected odf document reading.

Signed-off-by: Stephan Bergmann sberg...@redhat.com

diff --git a/package/source/zipapi/ZipFile.cxx 
b/package/source/zipapi/ZipFile.cxx
index 03a0108..fb56c28 100644
--- a/package/source/zipapi/ZipFile.cxx
+++ b/package/source/zipapi/ZipFile.cxx
@@ -802,7 +802,7 @@ sal_Bool ZipFile::readLOC( ZipEntry rEntry )
 
 // the method can be reset for internal use so it is not checked
 bBroken = rEntry.nVersion != nVersion
-|| rEntry.nMethod != nHow
+|| rEntry.nFlag != nFlag
 || rEntry.nTime != nTime
 || rEntry.nPathLen != nPathLen
 || !rEntry.sPath.equals( sLOCPath );
@@ -812,12 +812,6 @@ sal_Bool ZipFile::readLOC( ZipEntry rEntry )
 bBroken = sal_True;
 }
 
-// ignore bits 1  2 for normal deflate algo - they're purely informative
-if( nHow != 8  nHow != 9 )
-bBroken = bBroken || rEntry.nFlag != nFlag;
-else if( (rEntry.nFlag  ~6L) != (nFlag  ~6L) )
-bBroken = true;
-
 if ( bBroken  !bRecoveryMode )
 throw ZipIOException( OUString( RTL_CONSTASCII_USTRINGPARAM( The 
stream seems to be broken! ) ),
 Reference XInterface () );
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 2 commits - accessibility/bridge svx/Library_svxcore.mk

2011-12-19 Thread Caolán McNamara
 accessibility/bridge/source/java/makefile.mk |2 +-
 svx/Library_svxcore.mk   |3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 9bf638c8f0a744965aa3e9568bf6fe8caaf57f25
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 10:20:51 2011 +

msvc 2008 express won't link without explicit salhelper

post salhelper visibility markup and gbuildification express
2008 doesn't link without salhelper mentioned on link line

diff --git a/svx/Library_svxcore.mk b/svx/Library_svxcore.mk
index 5ae06ab..f7b3be7 100644
--- a/svx/Library_svxcore.mk
+++ b/svx/Library_svxcore.mk
@@ -73,7 +73,8 @@ $(eval $(call gb_Library_add_linked_libs,svxcore,\
 i18nisolang1 \
 lng \
 sal \
-   sax \
+salhelper \
+sax \
 sfx \
 sot \
 svl \
commit c61f986374a875acdbc29b3576271342742f8946
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 10:14:56 2011 +

msvc 2008 express won't link without explicit salhelper

post salhelper visibility markup and gbuildification express
2008 doesn't link without salhelper mentioned on link line

diff --git a/accessibility/bridge/source/java/makefile.mk 
b/accessibility/bridge/source/java/makefile.mk
index 5aeb21c..f010b95 100644
--- a/accessibility/bridge/source/java/makefile.mk
+++ b/accessibility/bridge/source/java/makefile.mk
@@ -45,7 +45,7 @@ SLOFILES= $(SLO)$/WindowsAccessBridgeAdapter.obj
 
 SHL1TARGET=java_uno_accessbridge
 SHL1IMPLIB=i$(SHL1TARGET)
-SHL1STDLIBS=$(VCLLIB) $(TOOLSLIB) $(JVMACCESSLIB) $(CPPULIB) $(SALLIB)
+SHL1STDLIBS=$(VCLLIB) $(TOOLSLIB) $(JVMACCESSLIB) $(CPPULIB) $(SALHELPERLIB) 
$(SALLIB)
 SHL1OBJS=$(SLOFILES) 
 SHL1VERSIONOBJ=
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: binfilter/bf_sd

2011-12-19 Thread Caolán McNamara
 binfilter/bf_sd/util/makefile.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit ac67fcce783971e922fbf8fc0e924d5ba1cd9731
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 10:26:29 2011 +

msvc 2008 express won't link without explicit salhelper

post salhelper visibility markup and gbuildification express
2008 doesn't link without salhelper mentioned on link line

diff --git a/binfilter/bf_sd/util/makefile.mk b/binfilter/bf_sd/util/makefile.mk
index a01570c..864f769 100644
--- a/binfilter/bf_sd/util/makefile.mk
+++ b/binfilter/bf_sd/util/makefile.mk
@@ -78,6 +78,7 @@ SHL1STDLIBS+= \
 $(COMPHELPERLIB) \
 $(CPPUHELPERLIB) \
 $(CPPULIB) \
+$(SALHELPERLIB) \
 $(SALLIB)
 
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sal/rtl

2011-12-19 Thread Matus Kukan
 sal/rtl/source/alloc_impl.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ec64e5e36db7d9bf7c9f6fe2705c11dc54548fb7
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Mon Dec 19 12:09:48 2011 +0100

WaE: GCC 4.5.1 does not allow #pragma GCC diagnostic warning

diff --git a/sal/rtl/source/alloc_impl.hxx b/sal/rtl/source/alloc_impl.hxx
index 2e51abe..4452f19 100644
--- a/sal/rtl/source/alloc_impl.hxx
+++ b/sal/rtl/source/alloc_impl.hxx
@@ -260,7 +260,7 @@ typedef CRITICAL_SECTION rtl_memory_lock_type;
 #define GCC_VERSION (__GNUC__ * 1 \
  + __GNUC_MINOR__ * 100 \
  + __GNUC_PATCHLEVEL__)
-#if GCC_VERSION = 40201  !defined __clang__
+#if GCC_VERSION = 40600  !defined __clang__
 #pragma GCC diagnostic warning -Wunused-but-set-variable
 #endif
 #define RTL_VALGRIND_IGNORE_VAL (void)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Repository.mk

2011-12-19 Thread Stephan Bergmann
 Repository.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4b7af200ed9d85f690be425b3a44f9696abe619e
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Dec 19 12:15:21 2011 +0100

typesconfig missing from Repository.mk

diff --git a/Repository.mk b/Repository.mk
index 8447c5b..0927b30 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -41,6 +41,7 @@ $(eval $(call gb_Helper_register_executables,NONE, \
 saxparser \
 so_checksum \
 svidl \
+typesconfig \
 xml2cmp \
 ))
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - solenv/gbuild

2011-12-19 Thread Michael Stahl
 solenv/gbuild/ComponentTarget.mk |3 ++-
 solenv/gbuild/CppunitTest.mk |4 ++--
 solenv/gbuild/Library.mk |   16 
 solenv/gbuild/TargetLocations.mk |2 ++
 4 files changed, 18 insertions(+), 7 deletions(-)

New commits:
commit 176e98241a09d5ccf3da59e61931cee9baa333bb
Author: Michael Stahl mst...@redhat.com
Date:   Fri Dec 16 19:58:33 2011 +0100

gbuild: refactor gb_Library_set_componentfile:

Reverse the dependency: now the component target depends (order-only) on the
library, which should ensure that gb_CppunitTest_add_component can set up
dependencies such that the unit test does not run concurrently with
a library loaded via UNO being overwritten.

Unfortunately this requires introducing another phony dummy library
target, on which the module can depend (because we don't want to register
the component target as a module target).
(cherry picked from commit 0ef8beedb1d2ce70e4d5ec7b24afd1711db29f38)

Conflicts:

solenv/gbuild/Library.mk

diff --git a/solenv/gbuild/ComponentTarget.mk b/solenv/gbuild/ComponentTarget.mk
index 031d118..efe4819 100644
--- a/solenv/gbuild/ComponentTarget.mk
+++ b/solenv/gbuild/ComponentTarget.mk
@@ -58,7 +58,8 @@ $(call gb_ComponentTarget_get_outdir_target,%) :
 define gb_ComponentTarget_ComponentTarget
 $(call gb_ComponentTarget_get_target,$(1)) : COMPONENTPREFIX := $(2)
 $(call gb_ComponentTarget_get_target,$(1)) : LIBFILENAME := $(3)
-$(call gb_ComponentTarget_get_outdir_target,$(1)) : $(call 
gb_ComponentTarget_get_target,$(1))
+$(call gb_ComponentTarget_get_outdir_target,$(1)) : \
+   $(call gb_ComponentTarget_get_target,$(1))
 $(call gb_Deliver_add_deliverable,$(call 
gb_ComponentTarget_get_outdir_target,$(1)),$(call 
gb_ComponentTarget_get_target,$(1)),$(1))
 
 endef
diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk
index aa87be6..0d8959e 100644
--- a/solenv/gbuild/CppunitTest.mk
+++ b/solenv/gbuild/CppunitTest.mk
@@ -153,9 +153,9 @@ endef
 
 define gb_CppunitTest_add_component
 $(call gb_CppunitTest_get_target,$(1)) : \
-$(call gb_ComponentTarget_get_target,$(2))
+$(call gb_ComponentTarget_get_outdir_target,$(2))
 $(call gb_CppunitTest_get_target,$(1)) : \
-UNO_SERVICES += $(call gb_ComponentTarget_get_target,$(2))
+UNO_SERVICES += $(call gb_ComponentTarget_get_outdir_target,$(2))
 
 endef
 
diff --git a/solenv/gbuild/Library.mk b/solenv/gbuild/Library.mk
index 82daae1..631a553 100644
--- a/solenv/gbuild/Library.mk
+++ b/solenv/gbuild/Library.mk
@@ -39,6 +39,8 @@
 #  gb_Library_Library_platform
 #  gb_Library_TARGETS
 
+# doesn't do anything, just used for hooking up component target
+.PHONY: $(call gb_Library__get_final_target,%)
 
 # EVIL: gb_StaticLibrary and gb_Library need the same deliver rule because 
they are indistinguishable on windows
 .PHONY : $(WORKDIR)/Clean/OutDir/lib/%$(gb_Library_PLAINEXT)
@@ -69,21 +71,27 @@ $(call gb_LinkTarget_set_targettype,$(2),Library)
 $(call gb_LinkTarget_add_defs,$(2),\
$(gb_Library_DEFS) \
 )
+$(call gb_Library__get_final_target,$(1)) : $(call gb_Library_get_target,$(1))
 $(call gb_Library_get_target,$(1)) : $(call gb_LinkTarget_get_target,$(2))
 $(call gb_Library_get_clean_target,$(1)) : $(call 
gb_LinkTarget_get_clean_target,$(2))
 $(call gb_Library_Library_platform,$(1),$(2),$(gb_Library_DLLDIR)/$(call 
gb_Library_get_dllname,$(1)))
-$$(eval $$(call gb_Module_register_target,$(call 
gb_Library_get_target,$(1)),$(call gb_Library_get_clean_target,$(1
+$$(eval $$(call gb_Module_register_target,$(call 
gb_Library__get_final_target,$(1)),$(call gb_Library_get_clean_target,$(1
 $(call gb_Deliver_add_deliverable,$(call gb_Library_get_target,$(1)),$(call 
gb_LinkTarget_get_target,$(2)),$(1))
 
 endef
 
+# The dependency from workdir component target to outdir library should ensure
+# that gb_CppunitTest_add_component can transitively depend on the library.
+# But the component target also must be delivered, so a new phony target
+# gb_Library__get_final_target has been invented for that purpose...
 define gb_Library_set_componentfile
 $(call gb_ComponentTarget_ComponentTarget,$(2),$(call 
gb_Library__get_componentprefix,$(1)),\
$(call gb_Library_get_runtime_filename,$(if $(MERGELIBS),$(if $(filter 
$(gb_MERGED_LIBS),$(1)),merged,$(1)),$(1
-$(call gb_LinkTarget_get_target,$(call gb_Library_get_linktargetname,$(1))) : \
+$(call gb_Library__get_final_target,$(1)) : \
$(call gb_ComponentTarget_get_outdir_target,$(2))
-$(call gb_Library_get_clean_target,$(1)) : $(call 
gb_ComponentTarget_get_clean_target,$(or $(strip $(3)),$(strip $(2
-
+$(call gb_ComponentTarget_get_target,$(2)) :| $(call 
gb_Library_get_target,$(1))
+$(call gb_Library_get_clean_target,$(1)) : \
+   $(call gb_ComponentTarget_get_clean_target,$(2))
 endef
 
 gb_Library__get_componentprefix = \
diff --git a/solenv/gbuild/TargetLocations.mk b/solenv/gbuild/TargetLocations.mk
index 

[Libreoffice-commits] .: Branch 'feature/gbuild' - 0 commits -

2011-12-19 Thread Matus Kukan
Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Repository.mk

2011-12-19 Thread Stephan Bergmann
 Repository.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 9a4dfa9f95cd142fe12e4d2e02226152a80baf17
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Dec 19 12:51:27 2011 +0100

cppunittester missing from Repository.mk

diff --git a/Repository.mk b/Repository.mk
index 0927b30..c297edd 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -30,6 +30,7 @@ $(eval $(call gb_Helper_register_executables,NONE, \
 bestreversemap \
 bmp \
 bmpsum \
+cppunit/cppunittester \
 g2g \
 gencoll_rule \
 genconv_dict \
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sal/osl solenv/gbuild

2011-12-19 Thread Stephan Bergmann
 sal/osl/unx/system.c |2 +-
 sal/osl/unx/system.h |2 +-
 solenv/gbuild/platform/macosx.mk |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit f039057048f850f9b43c297258342fb3bc869a6f
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Dec 19 13:06:09 2011 +0100

Warning clean-up (Mac OS X).

diff --git a/sal/osl/unx/system.c b/sal/osl/unx/system.c
index bf8607d..b74aff5 100644
--- a/sal/osl/unx/system.c
+++ b/sal/osl/unx/system.c
@@ -38,7 +38,7 @@ static pthread_mutex_t getrtl_mutex = 
PTHREAD_MUTEX_INITIALIZER;
 extern int h_errno;
 
 struct hostent *gethostbyname_r(const char *name, struct hostent *result,
-char *buffer, int buflen, int *h_errnop)
+char *buffer, size_t buflen, int *h_errnop)
 {
 /* buffer layout:   name\0
  *  array_of_pointer_to_aliases
diff --git a/sal/osl/unx/system.h b/sal/osl/unx/system.h
index 71b9b31..3c54785 100644
--- a/sal/osl/unx/system.h
+++ b/sal/osl/unx/system.h
@@ -490,7 +490,7 @@ struct tm *gmtime_r(const time_t *timep, struct tm *buffer);
 #endif /* !defined FREEBSD || (__FreeBSD_version  500112) */
 #if !defined(FREEBSD) || (__FreeBSD_version  601103)
 struct hostent *gethostbyname_r(const char *name, struct hostent *result,
-char *buffer, int buflen, int *h_errnop);
+char *buffer, size_t buflen, int *h_errnop);
 #endif /* !defined(FREEBSD) || (__FreeBSD_version  601103) */
 #endif
 
diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk
index cef2015..fb02a58 100644
--- a/solenv/gbuild/platform/macosx.mk
+++ b/solenv/gbuild/platform/macosx.mk
@@ -55,9 +55,9 @@ gb_COMPILERDEFS += \
 gb_CFLAGS := \
-isysroot $(gb_SDKDIR) \
$(gb_CFLAGS_COMMON) \
-   -Wshadow \
-fPIC \
-fno-strict-aliasing \
+#-Wshadow \ break in compiler headers already
 
 gb_CXXFLAGS := \
-isysroot $(gb_SDKDIR) \
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] Changes to 'feature/gbuild_a11y'

2011-12-19 Thread David Tardon
New branch 'feature/gbuild_a11y' available with the following commits:
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sc/CppunitTest_sc_cellrangesbase.mk sc/CppunitTest_sc_datapilotfieldobj.mk sc/CppunitTest_sc_filters_test.mk sc/CppunitTest_sc_macros_test.mk sc/CppunitTest_sc_namedrangeobj.m

2011-12-19 Thread Stephan Bergmann
 sc/CppunitTest_sc_cellrangesbase.mk  |5 -
 sc/CppunitTest_sc_datapilotfieldobj.mk   |5 -
 sc/CppunitTest_sc_filters_test.mk|5 -
 sc/CppunitTest_sc_macros_test.mk |5 -
 sc/CppunitTest_sc_namedrangeobj.mk   |5 -
 sc/CppunitTest_sc_subsequent_filters_test.mk |5 -
 sc/CppunitTest_sc_tableautoformatfield.mk|5 -
 sc/CppunitTest_sc_ucalc.mk   |   10 ++
 sw/CppunitTest_sw_filters_test.mk|4 +++-
 sw/CppunitTest_sw_macros_test.mk |5 +++--
 sw/CppunitTest_sw_swdoc_test.mk  |8 
 11 files changed, 44 insertions(+), 18 deletions(-)

New commits:
commit 9351f4c1d6a3567c3b013894a0cc08471b4b0156
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Dec 19 13:59:10 2011 +0100

Tests apparently depend on localedata_en library.

More tests might be affected.  Also unclear to me whether it is always 
(only)
localedata_en, or whether it could also be _es/_euro/_others.

diff --git a/sc/CppunitTest_sc_cellrangesbase.mk 
b/sc/CppunitTest_sc_cellrangesbase.mk
index 07822e5..051ee27 100644
--- a/sc/CppunitTest_sc_cellrangesbase.mk
+++ b/sc/CppunitTest_sc_cellrangesbase.mk
@@ -137,6 +137,9 @@ $(eval $(call gb_CppunitTest_set_args,sc_cellrangesbase,\
 # a) explicitly depend on library msword because it is not implied by a link
 #relation
 # b) explicitly depend on the sc resource files needed at unit-test runtime
-$(call gb_CppunitTest_get_target,sc_cellrangesbase) : $(call 
gb_Library_get_target,scfilt) $(WORKDIR)/AllLangRes/sc
+$(call gb_CppunitTest_get_target,sc_cellrangesbase) : \
+$(WORKDIR)/AllLangRes/sc \
+$(call gb_Library_get_target,localedata_en) \
+$(call gb_Library_get_target,scfilt) \
 
 # vim: set noet sw=4 ts=4:
diff --git a/sc/CppunitTest_sc_datapilotfieldobj.mk 
b/sc/CppunitTest_sc_datapilotfieldobj.mk
index 74cfeb3..236ffb9 100644
--- a/sc/CppunitTest_sc_datapilotfieldobj.mk
+++ b/sc/CppunitTest_sc_datapilotfieldobj.mk
@@ -137,6 +137,9 @@ $(eval $(call gb_CppunitTest_set_args,sc_datapilotfieldobj,\
 # a) explicitly depend on library msword because it is not implied by a link
 #relation
 # b) explicitly depend on the sc resource files needed at unit-test runtime
-$(call gb_CppunitTest_get_target,sc_datapilotfieldobj) : $(call 
gb_Library_get_target,scfilt) $(WORKDIR)/AllLangRes/sc
+$(call gb_CppunitTest_get_target,sc_datapilotfieldobj) : \
+$(WORKDIR)/AllLangRes/sc \
+$(call gb_Library_get_target,localedata_en) \
+$(call gb_Library_get_target,scfilt) \
 
 # vim: set noet sw=4 ts=4:
diff --git a/sc/CppunitTest_sc_filters_test.mk 
b/sc/CppunitTest_sc_filters_test.mk
index 034debd..c6b69f1 100644
--- a/sc/CppunitTest_sc_filters_test.mk
+++ b/sc/CppunitTest_sc_filters_test.mk
@@ -133,6 +133,9 @@ $(eval $(call gb_CppunitTest_set_args,sc_filters_test,\
 # a) explicitly depend on library msword because it is not implied by a link
 #relation
 # b) explicitly depend on the sc resource files needed at unit-test runtime
-$(call gb_CppunitTest_get_target,sc_filters_test) : $(call 
gb_Library_get_target,scfilt) $(WORKDIR)/AllLangRes/sc
+$(call gb_CppunitTest_get_target,sc_filters_test) : \
+$(WORKDIR)/AllLangRes/sc \
+$(call gb_Library_get_target,localedata_en) \
+$(call gb_Library_get_target,scfilt) \
 
 # vim: set noet sw=4 ts=4:
diff --git a/sc/CppunitTest_sc_macros_test.mk b/sc/CppunitTest_sc_macros_test.mk
index 3252d15..e760cb2 100644
--- a/sc/CppunitTest_sc_macros_test.mk
+++ b/sc/CppunitTest_sc_macros_test.mk
@@ -135,6 +135,9 @@ $(eval $(call gb_CppunitTest_set_args,sc_macros_test,\
 # a) explicitly depend on library msword because it is not implied by a link
 #relation
 # b) explicitly depend on the sc resource files needed at unit-test runtime
-$(call gb_CppunitTest_get_target,sc_macros_test) : $(call 
gb_Library_get_target,scfilt) $(WORKDIR)/AllLangRes/sc
+$(call gb_CppunitTest_get_target,sc_macros_test) : \
+$(WORKDIR)/AllLangRes/sc \
+$(call gb_Library_get_target,localedata_en) \
+$(call gb_Library_get_target,scfilt) \
 
 # vim: set noet sw=4 ts=4:
diff --git a/sc/CppunitTest_sc_namedrangeobj.mk 
b/sc/CppunitTest_sc_namedrangeobj.mk
index cb01294..c41c29e 100644
--- a/sc/CppunitTest_sc_namedrangeobj.mk
+++ b/sc/CppunitTest_sc_namedrangeobj.mk
@@ -137,6 +137,9 @@ $(eval $(call gb_CppunitTest_set_args,sc_namedrangeobj,\
 # a) explicitly depend on library msword because it is not implied by a link
 #relation
 # b) explicitly depend on the sc resource files needed at unit-test runtime
-$(call gb_CppunitTest_get_target,sc_namedrangeobj) : $(call 
gb_Library_get_target,scfilt) $(WORKDIR)/AllLangRes/sc
+$(call gb_CppunitTest_get_target,sc_namedrangeobj) : \
+$(WORKDIR)/AllLangRes/sc \
+$(call gb_Library_get_target,localedata_en) \
+$(call gb_Library_get_target,scfilt) \
 
 # vim: set noet sw=4 ts=4:
diff --git 

[Libreoffice-commits] Changes to 'feature/gbuild_java'

2011-12-19 Thread David Tardon
New branch 'feature/gbuild_java' available with the following commits:
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sw/source

2011-12-19 Thread Cédric Bosdonnat
 sw/source/core/access/acccontext.cxx |   15 +++
 1 file changed, 15 insertions(+)

New commits:
commit d6dc60ab350824bd0dffbf699cac13a3efd1e289
Author: Vincent Povirk madewokh...@gmail.com
Date:   Mon Dec 19 14:51:18 2011 +0100

sw: Fix cursor accessibility API (fdo#43390)

diff --git a/sw/source/core/access/acccontext.cxx 
b/sw/source/core/access/acccontext.cxx
index 8c38ba1..2949c1e 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -40,6 +40,7 @@
 #include viewsh.hxx
 #include crsrsh.hxx
 #include fesh.hxx
+#include wrtsh.hxx
 #include txtfrm.hxx
 #include ndtxt.hxx
 #include pagefrm.hxx
@@ -1359,6 +1360,10 @@ sal_Bool SwAccessibleContext::Select( SwPaM *pPaM, 
SdrObject *pObj,
 if( pFEShell )
 pFEShell-FinishOLEObj();
 
+SwWrtShell* pWrtShell = pCrsrShell-ISA( SwWrtShell )
+? static_castSwWrtShell*( pCrsrShell )
+: 0;
+
 sal_Bool bRet = sal_False;
 if( pObj )
 {
@@ -1383,7 +1388,17 @@ sal_Bool SwAccessibleContext::Select( SwPaM *pPaM, 
SdrObject *pObj,
 bCallShowCrsr = sal_True;
 }
 pCrsrShell-KillPams();
+if( pWrtShell  pPaM-HasMark() )
+// We have to do this or SwWrtShell can't figure out that it needs
+// to kill the selection later, when the user moves the cursor.
+pWrtShell-SttSelect();
 pCrsrShell-SetSelection( *pPaM );
+if( pPaM-HasMark()  *pPaM-GetPoint() == *pPaM-GetMark())
+// Setting a Selection that starts and ends at the same spot
+// should remove the selection rather than create an empty one, so
+// that we get defined behavior if accessibility sets the cursor
+// later.
+pCrsrShell-ClearMark();
 if( bCallShowCrsr )
 pCrsrShell-ShowCrsr();
 bRet = sal_True;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sw/source

2011-12-19 Thread Cédric Bosdonnat
 sw/source/core/access/acccontext.cxx |   15 +++
 1 file changed, 15 insertions(+)

New commits:
commit 33e1bb84abcb1ba60595a26884f8772249f7416b
Author: Vincent Povirk madewokh...@gmail.com
Date:   Mon Dec 19 14:51:18 2011 +0100

sw: Fix cursor accessibility API (fdo#43390)

diff --git a/sw/source/core/access/acccontext.cxx 
b/sw/source/core/access/acccontext.cxx
index 8c38ba1..2949c1e 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -40,6 +40,7 @@
 #include viewsh.hxx
 #include crsrsh.hxx
 #include fesh.hxx
+#include wrtsh.hxx
 #include txtfrm.hxx
 #include ndtxt.hxx
 #include pagefrm.hxx
@@ -1359,6 +1360,10 @@ sal_Bool SwAccessibleContext::Select( SwPaM *pPaM, 
SdrObject *pObj,
 if( pFEShell )
 pFEShell-FinishOLEObj();
 
+SwWrtShell* pWrtShell = pCrsrShell-ISA( SwWrtShell )
+? static_castSwWrtShell*( pCrsrShell )
+: 0;
+
 sal_Bool bRet = sal_False;
 if( pObj )
 {
@@ -1383,7 +1388,17 @@ sal_Bool SwAccessibleContext::Select( SwPaM *pPaM, 
SdrObject *pObj,
 bCallShowCrsr = sal_True;
 }
 pCrsrShell-KillPams();
+if( pWrtShell  pPaM-HasMark() )
+// We have to do this or SwWrtShell can't figure out that it needs
+// to kill the selection later, when the user moves the cursor.
+pWrtShell-SttSelect();
 pCrsrShell-SetSelection( *pPaM );
+if( pPaM-HasMark()  *pPaM-GetPoint() == *pPaM-GetMark())
+// Setting a Selection that starts and ends at the same spot
+// should remove the selection rather than create an empty one, so
+// that we get defined behavior if accessibility sets the cursor
+// later.
+pCrsrShell-ClearMark();
 if( bCallShowCrsr )
 pCrsrShell-ShowCrsr();
 bRet = sal_True;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] Changes to 'feature/gbuild_cppuhelper'

2011-12-19 Thread Matus Kukan
New branch 'feature/gbuild_cppuhelper' available with the following commits:
commit 47019a6e70d41df5da057266a326eb1853d35385
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Tue Aug 23 15:03:09 2011 +0200

cppuhelper: convert to gbuild

missing subsequent test qa/propertysetmixin/makefile.mk

commit e7c593b0959bd5d650d1ebe971e426c521c4f4ae
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Tue Aug 23 14:47:42 2011 +0200

cppuhelper: add visibility symbols as first step for porting to gbuild

___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'feature/gbuild_extensions' - extensions/AllLangResTarget_abp.mk extensions/AllLangResTarget_bib.mk extensions/AllLangResTarget_dbp.mk extensions/CppunitTest_extensions

2011-12-19 Thread Michael Stahl
 extensions/AllLangResTarget_abp.mk   |2 +-
 extensions/AllLangResTarget_bib.mk   |6 +-
 extensions/AllLangResTarget_dbp.mk   |2 +-
 extensions/CppunitTest_extensions_test_update.mk |2 +-
 extensions/Library_abp.mk|4 ++--
 extensions/Library_bib.mk|2 +-
 extensions/Library_dbp.mk|4 ++--
 extensions/Library_so_activex_x64.mk |2 +-
 8 files changed, 10 insertions(+), 14 deletions(-)

New commits:
commit e1d34f15cc82b4e9b10eca0e8efb50793080f1b6
Author: Michael Stahl mst...@redhat.com
Date:   Mon Dec 19 15:26:33 2011 +0100

extensions: what is all this realpath stuff doing?

diff --git a/extensions/AllLangResTarget_abp.mk 
b/extensions/AllLangResTarget_abp.mk
index 30371f9..cda588e 100644
--- a/extensions/AllLangResTarget_abp.mk
+++ b/extensions/AllLangResTarget_abp.mk
@@ -38,7 +38,7 @@ $(eval $(call gb_SrsTarget_SrsTarget,abp/res))
 
 $(eval $(call gb_SrsTarget_set_include,abp/res,\
$$(INCLUDE) \
-   -I$(realpath $(SRCDIR)/extensions/inc) \
+   -I$(SRCDIR)/extensions/inc \
 ))
 
 $(eval $(call gb_SrsTarget_add_files,abp/res,\
diff --git a/extensions/AllLangResTarget_bib.mk 
b/extensions/AllLangResTarget_bib.mk
index 36b22c3..bcc5d1e 100644
--- a/extensions/AllLangResTarget_bib.mk
+++ b/extensions/AllLangResTarget_bib.mk
@@ -36,7 +36,7 @@ $(eval $(call gb_SrsTarget_SrsTarget,bib/res))
 
 $(eval $(call gb_SrsTarget_set_include,bib/res,\
$$(INCLUDE) \
-   -I$(realpath $(SRCDIR)/extensions/inc) \
+   -I$(SRCDIR)/extensions/inc \
 ))
 
 $(eval $(call gb_SrsTarget_add_files,bib/res,\
@@ -46,8 +46,4 @@ $(eval $(call gb_SrsTarget_add_files,bib/res,\
extensions/source/bibliography/toolbar.src \
 ))
 
-$(eval $(call gb_SrsTarget_add_templates,bib/res,\
-   extensions/source/bibliography/bib.hrc \
-))
-
 # vim:set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/extensions/AllLangResTarget_dbp.mk 
b/extensions/AllLangResTarget_dbp.mk
index 657694a..88cc389 100644
--- a/extensions/AllLangResTarget_dbp.mk
+++ b/extensions/AllLangResTarget_dbp.mk
@@ -36,7 +36,7 @@ $(eval $(call gb_SrsTarget_SrsTarget,dbp/res))
 
 $(eval $(call gb_SrsTarget_set_include,dbp/res,\
$$(INCLUDE) \
-   -I$(realpath $(SRCDIR)/extensions/inc) \
+   -I$(SRCDIR)/extensions/inc \
 ))
 
 $(eval $(call gb_SrsTarget_add_files,dbp/res,\
diff --git a/extensions/CppunitTest_extensions_test_update.mk 
b/extensions/CppunitTest_extensions_test_update.mk
index f0b9a05..7ada5af 100644
--- a/extensions/CppunitTest_extensions_test_update.mk
+++ b/extensions/CppunitTest_extensions_test_update.mk
@@ -52,7 +52,7 @@ $(eval $(call 
gb_CppunitTest_use_external,extensions_test_update,curl))
 
 $(eval $(call gb_CppunitTest_set_include,extensions_test_update,\
$$(INCLUDE) \
-   -I$(realpath $(SRCDIR)/extensions/inc) \
+   -I$(SRCDIR)/extensions/inc \
-I$(OUTDIR)/inc \
 ))
 
diff --git a/extensions/Library_abp.mk b/extensions/Library_abp.mk
index 411c2d8..8460cf8 100644
--- a/extensions/Library_abp.mk
+++ b/extensions/Library_abp.mk
@@ -34,8 +34,8 @@ $(eval $(call 
gb_Library_set_componentfile,abp,extensions/source/abpilot/abp))
 
 $(eval $(call gb_Library_set_include,abp,\
$$(INCLUDE) \
-   -I$(realpath $(SRCDIR)/extensions/inc) \
-   -I$(realpath $(SRCDIR)/extensions/source/inc) \
+   -I$(SRCDIR)/extensions/inc \
+   -I$(SRCDIR)/extensions/source/inc \
 ))
 
 ifneq ($(WITH_MOZILLA),NO)
diff --git a/extensions/Library_bib.mk b/extensions/Library_bib.mk
index 3a9c010..27d311f 100644
--- a/extensions/Library_bib.mk
+++ b/extensions/Library_bib.mk
@@ -34,7 +34,7 @@ $(eval $(call 
gb_Library_set_componentfile,bib,extensions/source/bibliography/bi
 
 $(eval $(call gb_Library_set_include,bib,\
$$(INCLUDE) \
-   -I$(realpath $(SRCDIR)/extensions/inc) \
+   -I$(SRCDIR)/extensions/inc \
 ))
 
 $(eval $(call gb_Library_add_api,bib,\
diff --git a/extensions/Library_dbp.mk b/extensions/Library_dbp.mk
index c7fd685..dc7f55b 100644
--- a/extensions/Library_dbp.mk
+++ b/extensions/Library_dbp.mk
@@ -34,8 +34,8 @@ $(eval $(call 
gb_Library_set_componentfile,dbp,extensions/source/dbpilots/dbp))
 
 $(eval $(call gb_Library_set_include,dbp,\
$$(INCLUDE) \
-   -I$(realpath $(SRCDIR)/extensions/inc) \
-   -I$(realpath $(SRCDIR)/extensions/source/inc) \
+   -I$(SRCDIR)/extensions/inc \
+   -I$(SRCDIR)/extensions/source/inc \
 ))
 
 $(eval $(call gb_Library_add_defs,dbp,\
diff --git a/extensions/Library_so_activex_x64.mk 
b/extensions/Library_so_activex_x64.mk
index f7cfa0b..4317672 100644
--- a/extensions/Library_so_activex_x64.mk
+++ b/extensions/Library_so_activex_x64.mk
@@ -36,7 +36,7 @@ $(SRCDIR)/extensions/source/activex/so_activex.cxx: 
$(WORKDIR)/CustomTarget/so_a
 
 $(eval $(call gb_Library_set_include,so_activex_x64,\
$$(INCLUDE) \
-   -I$(realpath 

[Libreoffice-commits] .: Branch 'feature/gbuild_extensions' - extensions/WinResTarget_npsoplugin.mk

2011-12-19 Thread Michael Stahl
 0 files changed

New commits:
commit b882f15d4af447cafac43ae5357be596fd12f84e
Author: Michael Stahl mst...@redhat.com
Date:   Mon Dec 19 15:30:17 2011 +0100

extensions: chmod a-x *.mk

diff --git a/extensions/WinResTarget_npsoplugin.mk 
b/extensions/WinResTarget_npsoplugin.mk
old mode 100755
new mode 100644
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'feature/pf_extensions' - 0 commits -

2011-12-19 Thread Matus Kukan
Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: svtools/source

2011-12-19 Thread Caolán McNamara
 svtools/source/filter/filter.cxx |   36 ++--
 1 file changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 71b63586c5fe33fdf836ecb417d11f9c2d4e4b72
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 14:48:43 2011 +

Resolves: fdo#43082 can't claim its not a DXF just because didn't see 
SECTION

typedetection doesn't know about 999 COMMENT, it should really.

diff --git a/svtools/source/filter/filter.cxx b/svtools/source/filter/filter.cxx
index ef07514..f61990b 100644
--- a/svtools/source/filter/filter.cxx
+++ b/svtools/source/filter/filter.cxx
@@ -497,36 +497,36 @@ static sal_Bool ImpPeekGraphicFormat( SvStream rStream, 
String rFormatExtensio
 //--- DXF 
 if( !bTest || ( rFormatExtension.CompareToAscii( DXF, 3 ) == 
COMPARE_EQUAL ) )
 {
-bSomethingTested=sal_True;
+//Binary DXF File Format
+if( strncmp( (const char*) sFirstBytes, AutoCAD Binary DXF, 18 ) == 
0 )
+{
+rFormatExtension = UniString::CreateFromAscii( DXF, 3 );
+return sal_True;
+}
 
+//ASCII DXF File Format
 i=0;
 while (i256  sFirstBytes[i]=32)
-i++;
+++i;
 
-if (i256)
+if (i256  sFirstBytes[i]=='0')
 {
-if( sFirstBytes[i]=='0' )
-i++;
-else
-i=256;
-}
-while( i256  sFirstBytes[i]=32 )
-i++;
+++i;
 
-if (i+7256)
-{
-if (strncmp((char*)(sFirstBytes+i),SECTION,7)==0)
+//only now do we have sufficient data to make a judgement
+//based on a '0' + 'SECTION' == DXF argument
+bSomethingTested=sal_True;
+
+while( i256  sFirstBytes[i]=32 )
+++i;
+
+if (i+7256  (strncmp((const 
char*)(sFirstBytes+i),SECTION,7)==0))
 {
 rFormatExtension = UniString::CreateFromAscii( DXF, 3 );
 return sal_True;
 }
 }
 
-if( strncmp( (char*) sFirstBytes, AutoCAD Binary DXF, 18 ) == 0 )
-{
-rFormatExtension = UniString::CreateFromAscii( DXF, 3 );
-return sal_True;
-}
 }
 
 //--- PCT 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - svtools/source

2011-12-19 Thread Caolán McNamara
 svtools/source/filter/filter.cxx |   36 ++--
 1 file changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 05d602e41958a5c60773884ade725f3a8e051064
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 14:48:43 2011 +

Resolves: fdo#43082 can't claim its not a DXF just because didn't see 
SECTION

typedetection doesn't know about 999 COMMENT, it should really.
(cherry picked from commit 71b63586c5fe33fdf836ecb417d11f9c2d4e4b72)

Signed-off-by: Caolán McNamara caol...@redhat.com

diff --git a/svtools/source/filter/filter.cxx b/svtools/source/filter/filter.cxx
index ef07514..f61990b 100644
--- a/svtools/source/filter/filter.cxx
+++ b/svtools/source/filter/filter.cxx
@@ -497,36 +497,36 @@ static sal_Bool ImpPeekGraphicFormat( SvStream rStream, 
String rFormatExtensio
 //--- DXF 
 if( !bTest || ( rFormatExtension.CompareToAscii( DXF, 3 ) == 
COMPARE_EQUAL ) )
 {
-bSomethingTested=sal_True;
+//Binary DXF File Format
+if( strncmp( (const char*) sFirstBytes, AutoCAD Binary DXF, 18 ) == 
0 )
+{
+rFormatExtension = UniString::CreateFromAscii( DXF, 3 );
+return sal_True;
+}
 
+//ASCII DXF File Format
 i=0;
 while (i256  sFirstBytes[i]=32)
-i++;
+++i;
 
-if (i256)
+if (i256  sFirstBytes[i]=='0')
 {
-if( sFirstBytes[i]=='0' )
-i++;
-else
-i=256;
-}
-while( i256  sFirstBytes[i]=32 )
-i++;
+++i;
 
-if (i+7256)
-{
-if (strncmp((char*)(sFirstBytes+i),SECTION,7)==0)
+//only now do we have sufficient data to make a judgement
+//based on a '0' + 'SECTION' == DXF argument
+bSomethingTested=sal_True;
+
+while( i256  sFirstBytes[i]=32 )
+++i;
+
+if (i+7256  (strncmp((const 
char*)(sFirstBytes+i),SECTION,7)==0))
 {
 rFormatExtension = UniString::CreateFromAscii( DXF, 3 );
 return sal_True;
 }
 }
 
-if( strncmp( (char*) sFirstBytes, AutoCAD Binary DXF, 18 ) == 0 )
-{
-rFormatExtension = UniString::CreateFromAscii( DXF, 3 );
-return sal_True;
-}
 }
 
 //--- PCT 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: cppu/source

2011-12-19 Thread Stephan Bergmann
 cppu/source/threadpool/thread.cxx |   25 +
 cppu/source/threadpool/thread.hxx |2 ++
 2 files changed, 27 insertions(+)

New commits:
commit b68640c44ecdb1df59d704cc6c2bae8bb412d7d0
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Dec 19 15:15:28 2011 +0100

Prevent creation of new ORequestThreads during shutdown.

diff --git a/cppu/source/threadpool/thread.cxx 
b/cppu/source/threadpool/thread.cxx
index 58aec56..cc22a45 100644
--- a/cppu/source/threadpool/thread.cxx
+++ b/cppu/source/threadpool/thread.cxx
@@ -30,12 +30,22 @@
 #include osl/diagnose.h
 #include uno/threadpool.h
 
+#include com/sun/star/lang/DisposedException.hpp
+#include com/sun/star/uno/Reference.hxx
+#include com/sun/star/uno/XInterface.hpp
 #include rtl/instance.hxx
+#include rtl/ustring.h
+#include rtl/ustring.hxx
 
 #include thread.hxx
 #include jobqueue.hxx
 #include threadpool.hxx
 
+namespace {
+
+namespace css = com::sun::star;
+
+}
 
 using namespace osl;
 extern C {
@@ -53,6 +63,8 @@ void SAL_CALL cppu_requestThreadWorker( void *pVoid )
 namespace cppu_threadpool {
 
 // 
--
+ThreadAdmin::ThreadAdmin(): m_disposed(false) {}
+
 ThreadAdmin::~ThreadAdmin()
 {
 #if OSL_DEBUG_LEVEL  1
@@ -66,6 +78,15 @@ namespace cppu_threadpool {
 void ThreadAdmin::add( ORequestThread *p )
 {
 MutexGuard aGuard( m_mutex );
+if( m_disposed )
+{
+throw css::lang::DisposedException(
+rtl::OUString(
+RTL_CONSTASCII_USTRINGPARAM(
+cppu_threadpool::ORequestThread created after
+ cppu_threadpool::ThreadAdmin has been disposed)),
+css::uno::Reference css::uno::XInterface ());
+}
 m_lst.push_back( p );
 }
 
@@ -79,6 +100,10 @@ namespace cppu_threadpool {
 
 void ThreadAdmin::join()
 {
+{
+MutexGuard aGuard( m_mutex );
+m_disposed = true;
+}
 ORequestThread *pCurrent;
 do
 {
diff --git a/cppu/source/threadpool/thread.hxx 
b/cppu/source/threadpool/thread.hxx
index bbef51e..a3ea45a 100644
--- a/cppu/source/threadpool/thread.hxx
+++ b/cppu/source/threadpool/thread.hxx
@@ -74,6 +74,7 @@ namespace cppu_threadpool {
 class ThreadAdmin
 {
 public:
+ThreadAdmin();
 ~ThreadAdmin ();
 static ThreadAdminHolder getInstance();
 void add( ORequestThread * );
@@ -83,6 +84,7 @@ namespace cppu_threadpool {
 private:
 ::osl::Mutex m_mutex;
 ::std::list ORequestThread *  m_lst;
+bool m_disposed;
 };
 
 } // end cppu_threadpool
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: cppu/source

2011-12-19 Thread Caolán McNamara
 cppu/source/uno/sequence.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit bc4c7b52a8cdeeb5db38cdf27950aff53bb8d07a
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 15:10:41 2011 +

get this to build under msvc 2008

diff --git a/cppu/source/uno/sequence.cxx b/cppu/source/uno/sequence.cxx
index 0c63598..5affbef 100644
--- a/cppu/source/uno/sequence.cxx
+++ b/cppu/source/uno/sequence.cxx
@@ -766,7 +766,7 @@ extern C
 {
 
 
//##
-CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_type_sequence_construct(
+sal_Bool SAL_CALL uno_type_sequence_construct(
 uno_Sequence ** ppSequence, typelib_TypeDescriptionReference * pType,
 void * pElements, sal_Int32 len,
 uno_AcquireFunc acquire )
@@ -810,7 +810,7 @@ CPPU_DLLPUBLIC sal_Bool SAL_CALL 
uno_type_sequence_construct(
 }
 
 
//##
-CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_sequence_construct(
+sal_Bool SAL_CALL uno_sequence_construct(
 uno_Sequence ** ppSequence, typelib_TypeDescription * pTypeDescr,
 void * pElements, sal_Int32 len,
 uno_AcquireFunc acquire )
@@ -849,7 +849,7 @@ CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_sequence_construct(
 }
 
 
//##
-CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_type_sequence_realloc(
+sal_Bool SAL_CALL uno_type_sequence_realloc(
 uno_Sequence ** ppSequence, typelib_TypeDescriptionReference * pType,
 sal_Int32 nSize, uno_AcquireFunc acquire, uno_ReleaseFunc release )
 SAL_THROW_EXTERN_C()
@@ -871,7 +871,7 @@ CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_type_sequence_realloc(
 }
 
 
//##
-CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_sequence_realloc(
+sal_Bool SAL_CALL uno_sequence_realloc(
 uno_Sequence ** ppSequence, typelib_TypeDescription * pTypeDescr,
 sal_Int32 nSize, uno_AcquireFunc acquire, uno_ReleaseFunc release )
 SAL_THROW_EXTERN_C()
@@ -890,7 +890,7 @@ CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_sequence_realloc(
 }
 
 
//##
-CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_type_sequence_reference2One(
+sal_Bool SAL_CALL uno_type_sequence_reference2One(
 uno_Sequence ** ppSequence,
 typelib_TypeDescriptionReference * pType,
 uno_AcquireFunc acquire, uno_ReleaseFunc release )
@@ -937,7 +937,7 @@ CPPU_DLLPUBLIC sal_Bool SAL_CALL 
uno_type_sequence_reference2One(
 }
 
 
//##
-CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_sequence_reference2One(
+sal_Bool SAL_CALL uno_sequence_reference2One(
 uno_Sequence ** ppSequence,
 typelib_TypeDescription * pTypeDescr,
 uno_AcquireFunc acquire, uno_ReleaseFunc release )
@@ -981,7 +981,7 @@ CPPU_DLLPUBLIC sal_Bool SAL_CALL uno_sequence_reference2One(
 }
 
 
//##
-CPPU_DLLPUBLIC void SAL_CALL uno_sequence_assign(
+void SAL_CALL uno_sequence_assign(
 uno_Sequence ** ppDest,
 uno_Sequence * pSource,
 typelib_TypeDescription * pTypeDescr,
@@ -997,7 +997,7 @@ CPPU_DLLPUBLIC void SAL_CALL uno_sequence_assign(
 }
 
 
//##
-CPPU_DLLPUBLIC void SAL_CALL uno_type_sequence_assign(
+void SAL_CALL uno_type_sequence_assign(
 uno_Sequence ** ppDest,
 uno_Sequence * pSource,
 typelib_TypeDescriptionReference * pType,
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sw/source

2011-12-19 Thread Cédric Bosdonnat
 sw/source/core/unocore/unotext.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit ab218a565ee9cc033d97d71ab52e9d87b02b1874
Author: Noel Power noel.po...@novell.com
Date:   Mon Dec 19 16:11:04 2011 +0100

sw: avoid creating cursor with non-text node text range (fdo#40195)

diff --git a/sw/source/core/unocore/unotext.cxx 
b/sw/source/core/unocore/unotext.cxx
index 28ff73f..820239f 100644
--- a/sw/source/core/unocore/unotext.cxx
+++ b/sw/source/core/unocore/unotext.cxx
@@ -2480,6 +2480,9 @@ throw (uno::RuntimeException)
 SwUnoInternalPaM aPam(*GetDoc());
 if (::sw::XTextRangeToSwPaM(aPam, xTextPosition))
 {
+if ( !aPam.GetNode()-GetTxtNode() )
+throw uno::RuntimeException( rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM(Invalid text range) ), uno::Reference 
uno::XInterface () );
+
 SwNode rNode = GetDoc()-GetNodes().GetEndOfContent();
 
 SwStartNode* p1 = aPam.GetNode()-StartOfSectionNode();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 2 commits - sal/osl

2011-12-19 Thread Stephan Bergmann
 sal/osl/unx/file_stat.cxx |   65 +++---
 1 file changed, 11 insertions(+), 54 deletions(-)

New commits:
commit fb2078addcbd96662283b2481206eee7ce3d50b6
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Dec 19 16:47:13 2011 +0100

Clean up previous commit.

diff --git a/sal/osl/unx/file_stat.cxx b/sal/osl/unx/file_stat.cxx
index 6b2407a..949121f 100644
--- a/sal/osl/unx/file_stat.cxx
+++ b/sal/osl/unx/file_stat.cxx
@@ -101,73 +101,14 @@ namespace /* private */
 pStat-uValidFields |= osl_FileStatus_Mask_Attributes;
 }
 
-inline void set_file_access_rights(const struct stat file_stat, int S_IR, 
int S_IW, int S_IX, oslFileStatus* pStat)
-{
-/* we cannot really map osl_File_Attribute_ReadOnly to
-   the Unix access rights, it's a Windows only flag
-   that's why the following hack. We set osl_FileStatus_Mask_Attributes
-   but if there is no read access for a file we clear the flag
-   again to signal to the caller that there are no file attributes
-   to read because that's better than to give them incorrect one.
-*/
-pStat-uValidFields |= osl_FileStatus_Mask_Attributes;
-
-if ((0 == (S_IW  file_stat.st_mode))  (S_IR  file_stat.st_mode))
-pStat-uAttributes |= osl_File_Attribute_ReadOnly;
-
-if (S_IX  file_stat.st_mode)
-pStat-uAttributes |= osl_File_Attribute_Executable;
-}
-
-/* a process may belong to up to NGROUPS_MAX groups, so when
-   checking group access rights, we have to check all belonging
-   groups */
-inline bool is_in_process_grouplist(const gid_t file_group)
-{
-// check primary process group
-
-if (getgid() == file_group)
-return true;
-
-// check supplementary process groups
-
-gid_t grplist[NGROUPS_MAX];
-int   grp_number = getgroups(NGROUPS_MAX, grplist);
-
-for (int i = 0; i  grp_number; i++)
-{
-if (grplist[i] == file_group)
-return true;
-}
-return false;
-}
-
-/* Currently we are determining the file access right based
-   on the real user ID not the effective user ID!
-   We don't use access(...) because access follows links which
-   may cause performance problems see #97133.
+/* This code used not to use access(...) because access follows links which
+   may cause performance problems see #97133.  (That apparently references 
a
+   no-longer accessible Hamburg-internal bug-tracking system.)
+   However, contrary to what is stated above the use of access calls is
+   required on network file systems not using unix semantics (AFS, see
+   fdo#43095).
 */
-inline void set_file_access_rights(const struct stat file_stat, 
oslFileStatus* pStat)
-{
-if (getuid() == file_stat.st_uid)
-{
-set_file_access_rights(file_stat, S_IRUSR, S_IWUSR, S_IXUSR, 
pStat);
-}
-else if (is_in_process_grouplist(file_stat.st_gid))
-{
-set_file_access_rights(file_stat, S_IRGRP, S_IWGRP, S_IXGRP, 
pStat);
-}
-else
-{
-set_file_access_rights(file_stat, S_IROTH, S_IWOTH, S_IXOTH, 
pStat);
-}
-}
-
-/* contrary to what is stated above the use of access calls
-   is required on network file systems not using unix semantics
-  (AFS)
-*/
-inline void set_file_access_real_rights(const rtl::OUString file_path, 
oslFileStatus* pStat)
+inline void set_file_access_rights(const rtl::OUString file_path, 
oslFileStatus* pStat)
 {
 pStat-uValidFields |= osl_FileStatus_Mask_Attributes;
 
@@ -193,15 +134,10 @@ namespace /* private */
 set_file_hidden_status(file_path, pStat);
 set_file_access_mask(file_stat, pStat);
 
-#ifdef FAKE_ACCESS_RIGHTS
 // we set the file access rights only on demand
 // because it's potentially expensive
 if (uFieldMask  osl_FileStatus_Mask_Attributes)
-   set_file_access_rights(file_stat, pStat);
-#else
-if (uFieldMask  osl_FileStatus_Mask_Attributes)
-set_file_access_real_rights(file_path, pStat);
-#endif
+set_file_access_rights(file_path, pStat);
 }
 
 inline void set_file_access_time(const struct stat file_stat, 
oslFileStatus* pStat)
commit 32a6a0891fb5f2d893cca656cd44afd0bcbe3272
Author: Moritz Bechler mbech...@eenterphace.org
Date:   Mon Dec 19 16:36:31 2011 +0100

fdo#43095: allow the use of real access() calls

diff --git a/sal/osl/unx/file_stat.cxx b/sal/osl/unx/file_stat.cxx
index 674e603..6b2407a 100644
--- a/sal/osl/unx/file_stat.cxx
+++ b/sal/osl/unx/file_stat.cxx
@@ -163,6 +163,22 @@ namespace /* private */
 }
 }
 
+/* contrary to what is stated above the use of access calls
+   is required on network file systems not using unix semantics
+  (AFS)
+*/
+

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sw/source

2011-12-19 Thread Cédric Bosdonnat
 sw/source/core/unocore/unotext.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit a327cd771e18b8677567f576e3bd88b69d2ee200
Author: Noel Power noel.po...@novell.com
Date:   Mon Dec 19 16:11:04 2011 +0100

sw: avoid creating cursor with non-text node text range (fdo#40195)

diff --git a/sw/source/core/unocore/unotext.cxx 
b/sw/source/core/unocore/unotext.cxx
index 28ff73f..820239f 100644
--- a/sw/source/core/unocore/unotext.cxx
+++ b/sw/source/core/unocore/unotext.cxx
@@ -2480,6 +2480,9 @@ throw (uno::RuntimeException)
 SwUnoInternalPaM aPam(*GetDoc());
 if (::sw::XTextRangeToSwPaM(aPam, xTextPosition))
 {
+if ( !aPam.GetNode()-GetTxtNode() )
+throw uno::RuntimeException( rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM(Invalid text range) ), uno::Reference 
uno::XInterface () );
+
 SwNode rNode = GetDoc()-GetNodes().GetEndOfContent();
 
 SwStartNode* p1 = aPam.GetNode()-StartOfSectionNode();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - bin/lo-pack-sources

2011-12-19 Thread Petr Mladek
 bin/lo-pack-sources |  173 ++--
 1 file changed, 34 insertions(+), 139 deletions(-)

New commits:
commit 4a0a1d83da07eed79cdd956eb1a7a2905f2ae017
Author: Petr Mladek pmla...@suse.cz
Date:   Mon Dec 19 17:18:41 2011 +0100

lo-pack-sources: do not duplicate the generated files in the archive dir

the storing in archive directory was non-standard solution = gets removed
also the code was simplified and clean up a bit

diff --git a/bin/lo-pack-sources b/bin/lo-pack-sources
index bfbde5b..b57ae1b 100755
--- a/bin/lo-pack-sources
+++ b/bin/lo-pack-sources
@@ -134,20 +134,19 @@ sub generate_tarball($$$)
 my ($dir, $tarball, $tar_compress_option) = @_;
 
 print Creating $tarball...;
-system (cd $dir   .
-tar -c $tar_compress_option -f $tarball --checkpoint * 21 | awk 
'{ ORS=\\ ; if (++nlines\%50 == 0) printf \.\; fflush() }'   .
-cd - /dev/null 21)  die Error: releasing failed: $!\n;
+# generate the tarball in the current directory; avoid ./ prefix in the 
stored paths; show progress
+system (tar -c $tar_compress_option -f $tarball -C $dir --checkpoint=500 
--checkpoint-action=exec=\echo -n .\ --transform=\s|^\./||\ .)  
+die Error: releasing failed: $!\n;
 print \n;
 }
 
-sub generate_md5($$)
+sub generate_md5($)
 {
-my ($dir, $filename) = @_;
+my ($filename) = @_;
 
 print Generating MD5...\n;
-system (cd $dir   .
-md5sum $filename $filename.md5   .
-cd - /dev/null 21)  die Error: releasing failed: $!\n;
+system (md5sum $filename $filename.md5) 
+die Error: releasing failed: $!\n;
 }
 
 sub default_releases_state_file($)
@@ -167,23 +166,6 @@ sub default_releases_state_file($)
 return $releases_state_file;
 }
 
-sub default_releases_archive($)
-{
-my ($lo_core_dir) = @_;
-
-my $rootdir = $lo_core_dir;
-$rootdir =~ s/^(.*?)\/?[^\/]+\/?$/$1/;
-
-my $releases_archive_dir;
-if ($rootdir) {
-$releases_archive_dir = $rootdir/archive;
-} else {
-$releases_archive_dir = archive;
-}
-
-return $releases_archive_dir;
-}
-
 sub load_releases_state($)
 {
 my ($releases_state_file) = @_;
@@ -229,25 +211,6 @@ sub remove_tempdir($)
 system (rm -rf $tempdir)  die Error: rm failed: $!\n;
 }
 
-sub save_file($$$)
-{
-my ($source_dir, $target_dir, $file) = @_;
-
-unless ( -d $target_dir ) {
-mkdir ($target_dir) ||
-die Can't create directory \$target_dir\: $!\n;
-}
-
-if ( -f $target_dir/$file ) {
-print Warning: $target_dir/$file already exists and will be 
replaced\n;
-unlink ($target_dir/$file);
-}
-
-print Copying into archive: $target_dir/$file ...\n;
-copy ($source_dir/$file, $target_dir/$file) ||
-die Error: Can't copy $source_dir/$file to $target_dir/$file: $!\n;
-}
-
 sub check_if_file_exists($$)
 {
 my ($file, $force) = @_;
@@ -262,24 +225,17 @@ sub check_if_file_exists($$)
 }
 }
 
-sub check_if_tarball_already_released($$$)
+sub check_if_already_released($$$)
 {
-my ($tarball, $releases_archive_dir, $force) = @_;
+my ($lo_core_tarball_name, $p_piece_tarball_name, $force, $bzip2, $xz, 
$pack_lo_core, $pack_lo_pieces) = @_;
 
-check_if_file_exists($tarball, $force);
-check_if_file_exists($releases_archive_dir/$tarball, $force) if (defined 
$releases_archive_dir);
-}
-
-sub check_if_already_released()
-{
-my ($lo_core_tarball_name, $p_piece_tarball_name, $releases_archive_dir, 
$force, $bzip2, $xz, $pack_lo_core, $pack_lo_pieces) = @_;
-
-check_if_tarball_already_released($lo_core_tarball_name.tar.gz, 
$releases_archive_dir, $force) if ($pack_lo_core);
+check_if_file_exists($lo_core_tarball_name.tar.bz2, $force)  if 
($pack_lo_core  defined $bzip2);
+check_if_file_exists($lo_core_tarball_name.tar.xz, $force) if 
($pack_lo_core  defined $xz);
 
 if ($pack_lo_pieces) {
 foreach my $tarball_name ( values %{$p_piece_tarball_name} ) {
-check_if_tarball_already_released($tarball_name.tar.bz2, 
$releases_archive_dir, $force) if (defined $bzip2);
-check_if_tarball_already_released($tarball_name.tar.xz, 
$releases_archive_dir, $force) if (defined $xz);
+check_if_file_exists($tarball_name.tar.bz2, $force) if (defined 
$bzip2);
+check_if_file_exists($tarball_name.tar.xz, $force) if (defined 
$xz);
 }
 }
 }
@@ -297,40 +253,31 @@ sub prepare_piece_sources()
 return $temp_dir;
 }
 
-sub pack_piece_sources($)
+sub pack_piece_sources()
 {
-my ($temp_dir, $md5, $tarball, $tar_compress_option, 
$releases_archive_dir) = @_;
+my ($temp_dir, $md5, $tarball, $tar_compress_option) = @_;
 
 generate_tarball($temp_dir, $tarball, $tar_compress_option);
-generate_md5($temp_dir, $tarball) if (defined $md5);
-
-save_file($temp_dir, ., $tarball);
-save_file($temp_dir, ., $tarball.md5) if 

[Libreoffice-commits] .: 2 commits - bin/lo-pack-sources

2011-12-19 Thread Petr Mladek
 bin/lo-pack-sources |  173 ++--
 1 file changed, 34 insertions(+), 139 deletions(-)

New commits:
commit 041207302ab15053523d47c8644d3148aa6f1a5e
Author: Petr Mladek pmla...@suse.cz
Date:   Mon Dec 19 17:18:41 2011 +0100

lo-pack-sources: do not duplicate the generated files in the archive dir

the storing in archive directory was non-standard solution = gets removed
also the code was simplified and clean up a bit

diff --git a/bin/lo-pack-sources b/bin/lo-pack-sources
index bfbde5b..b57ae1b 100755
--- a/bin/lo-pack-sources
+++ b/bin/lo-pack-sources
@@ -134,20 +134,19 @@ sub generate_tarball($$$)
 my ($dir, $tarball, $tar_compress_option) = @_;
 
 print Creating $tarball...;
-system (cd $dir   .
-tar -c $tar_compress_option -f $tarball --checkpoint * 21 | awk 
'{ ORS=\\ ; if (++nlines\%50 == 0) printf \.\; fflush() }'   .
-cd - /dev/null 21)  die Error: releasing failed: $!\n;
+# generate the tarball in the current directory; avoid ./ prefix in the 
stored paths; show progress
+system (tar -c $tar_compress_option -f $tarball -C $dir --checkpoint=500 
--checkpoint-action=exec=\echo -n .\ --transform=\s|^\./||\ .)  
+die Error: releasing failed: $!\n;
 print \n;
 }
 
-sub generate_md5($$)
+sub generate_md5($)
 {
-my ($dir, $filename) = @_;
+my ($filename) = @_;
 
 print Generating MD5...\n;
-system (cd $dir   .
-md5sum $filename $filename.md5   .
-cd - /dev/null 21)  die Error: releasing failed: $!\n;
+system (md5sum $filename $filename.md5) 
+die Error: releasing failed: $!\n;
 }
 
 sub default_releases_state_file($)
@@ -167,23 +166,6 @@ sub default_releases_state_file($)
 return $releases_state_file;
 }
 
-sub default_releases_archive($)
-{
-my ($lo_core_dir) = @_;
-
-my $rootdir = $lo_core_dir;
-$rootdir =~ s/^(.*?)\/?[^\/]+\/?$/$1/;
-
-my $releases_archive_dir;
-if ($rootdir) {
-$releases_archive_dir = $rootdir/archive;
-} else {
-$releases_archive_dir = archive;
-}
-
-return $releases_archive_dir;
-}
-
 sub load_releases_state($)
 {
 my ($releases_state_file) = @_;
@@ -229,25 +211,6 @@ sub remove_tempdir($)
 system (rm -rf $tempdir)  die Error: rm failed: $!\n;
 }
 
-sub save_file($$$)
-{
-my ($source_dir, $target_dir, $file) = @_;
-
-unless ( -d $target_dir ) {
-mkdir ($target_dir) ||
-die Can't create directory \$target_dir\: $!\n;
-}
-
-if ( -f $target_dir/$file ) {
-print Warning: $target_dir/$file already exists and will be 
replaced\n;
-unlink ($target_dir/$file);
-}
-
-print Copying into archive: $target_dir/$file ...\n;
-copy ($source_dir/$file, $target_dir/$file) ||
-die Error: Can't copy $source_dir/$file to $target_dir/$file: $!\n;
-}
-
 sub check_if_file_exists($$)
 {
 my ($file, $force) = @_;
@@ -262,24 +225,17 @@ sub check_if_file_exists($$)
 }
 }
 
-sub check_if_tarball_already_released($$$)
+sub check_if_already_released($$$)
 {
-my ($tarball, $releases_archive_dir, $force) = @_;
+my ($lo_core_tarball_name, $p_piece_tarball_name, $force, $bzip2, $xz, 
$pack_lo_core, $pack_lo_pieces) = @_;
 
-check_if_file_exists($tarball, $force);
-check_if_file_exists($releases_archive_dir/$tarball, $force) if (defined 
$releases_archive_dir);
-}
-
-sub check_if_already_released()
-{
-my ($lo_core_tarball_name, $p_piece_tarball_name, $releases_archive_dir, 
$force, $bzip2, $xz, $pack_lo_core, $pack_lo_pieces) = @_;
-
-check_if_tarball_already_released($lo_core_tarball_name.tar.gz, 
$releases_archive_dir, $force) if ($pack_lo_core);
+check_if_file_exists($lo_core_tarball_name.tar.bz2, $force)  if 
($pack_lo_core  defined $bzip2);
+check_if_file_exists($lo_core_tarball_name.tar.xz, $force) if 
($pack_lo_core  defined $xz);
 
 if ($pack_lo_pieces) {
 foreach my $tarball_name ( values %{$p_piece_tarball_name} ) {
-check_if_tarball_already_released($tarball_name.tar.bz2, 
$releases_archive_dir, $force) if (defined $bzip2);
-check_if_tarball_already_released($tarball_name.tar.xz, 
$releases_archive_dir, $force) if (defined $xz);
+check_if_file_exists($tarball_name.tar.bz2, $force) if (defined 
$bzip2);
+check_if_file_exists($tarball_name.tar.xz, $force) if (defined 
$xz);
 }
 }
 }
@@ -297,40 +253,31 @@ sub prepare_piece_sources()
 return $temp_dir;
 }
 
-sub pack_piece_sources($)
+sub pack_piece_sources()
 {
-my ($temp_dir, $md5, $tarball, $tar_compress_option, 
$releases_archive_dir) = @_;
+my ($temp_dir, $md5, $tarball, $tar_compress_option) = @_;
 
 generate_tarball($temp_dir, $tarball, $tar_compress_option);
-generate_md5($temp_dir, $tarball) if (defined $md5);
-
-save_file($temp_dir, ., $tarball);
-save_file($temp_dir, ., $tarball.md5) if 

[Libreoffice-commits] .: 2 commits - .gitignore solenv/gbuild

2011-12-19 Thread Michael Stahl
 .gitignore   |5 -
 solenv/gbuild/platform/macosx.mk |   13 +++--
 2 files changed, 11 insertions(+), 7 deletions(-)

New commits:
commit e0c780d3c227abfe031dae879e08b9ad920e8a3c
Author: Michael Stahl mst...@redhat.com
Date:   Mon Dec 19 18:22:26 2011 +0100

.gitignore: better VIM swp pattern

diff --git a/.gitignore b/.gitignore
index af084f9..b783183 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,9 +1,12 @@
 # backup and temporary files
 *~
-.*.sw[op]
+.*sw?
 \#*
 .DS_Store
 
+# StGit
+.stgit-edit.txt
+
 # python generated file
 *.pyc
 
commit a0a21ffa5b4198735823802e4ab516120393609c
Author: Michael Stahl mst...@redhat.com
Date:   Mon Dec 19 18:10:39 2011 +0100

gbuild: macosx.mk: install names with SOVERSION:

gb_LinkTarget__get_installname should append the SOVERSION, because the
installation set only contains the versioned libraries, not the
unversioned symlinks.

diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk
index fb02a58..f7f3440 100644
--- a/solenv/gbuild/platform/macosx.mk
+++ b/solenv/gbuild/platform/macosx.mk
@@ -149,11 +149,10 @@ gb_LinkTarget__RPATHS := \
SDKBIN: \
NONE:@__VIA_LIBRARY_PATH__@ \
 
-# The below contains a bad hack to set the correct install name for
-# libuno_salhepergcc3.dylib.3, with a trailing .3:
+# $(call gb_LinkTarget__get_installname,libfilename,soversion,layerprefix)
 define gb_LinkTarget__get_installname
-$(if $(2),-install_name '$(2)$(1)$(if $(filter 
$(1),libuno_salhelpergcc3.dylib),.3)',$(error
-cannot determine -install_name for $(2)))
+$(if $(3),-install_name '$(3)$(1)$(if $(2),.$(2))',
+   $(call gb_Output_error,cannot determine -install_name for $(3)))
 endef
 
 gb_LinkTarget_CFLAGS := $(gb_CFLAGS) $(gb_CFLAGS_WERROR)
@@ -293,11 +292,13 @@ gb_Library_LAYER := \
$(foreach lib,$(gb_Library_UNOVERLIBS),$(lib):URELIB) \
 
 define gb_Library_get_rpath
-$(call gb_LinkTarget__get_installname,$(call 
gb_Library_get_filename,$(1)),$(call gb_LinkTarget__get_rpath_for_layer,$(call 
gb_Library_get_layer,$(1
+$(call gb_LinkTarget__get_installname,$(call 
gb_Library_get_filename,$(1)),$(2),$(call 
gb_LinkTarget__get_rpath_for_layer,$(call gb_Library_get_layer,$(1
 endef
 
+# RPATH def is delayed until the link command to get current value of SOVERSION
 define gb_Library_Library_platform
-$(call gb_LinkTarget_get_target,$(2)) : RPATH := $(call 
gb_Library_get_rpath,$(1))
+$(call gb_LinkTarget_get_target,$(2)) : \
+   RPATH = $$(call gb_Library_get_rpath,$(1),$$(SOVERSION))
 $(call gb_LinkTarget_get_target,$(2)) : LAYER := $(call 
gb_Library_get_layer,$(1))
 
 endef
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: cairo/cairo-1.10.2.patch

2011-12-19 Thread Fridrich Strba
 cairo/cairo-1.10.2.patch |   45 ++---
 1 file changed, 6 insertions(+), 39 deletions(-)

New commits:
commit 04417370fcd44554fce4b7c5a146b0d1613bdbae
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Mon Dec 19 19:03:04 2011 +0100

Build all default cairo features on Windows

diff --git a/cairo/cairo-1.10.2.patch b/cairo/cairo-1.10.2.patch
index 74c139d..6bc44c9 100644
--- a/cairo/cairo-1.10.2.patch
+++ b/cairo/cairo-1.10.2.patch
@@ -1,33 +1,6 @@
 misc/cairo-1.10.2/build/Makefile.win32.features2010-08-18 
09:47:30.0 +0200
-+++ misc/build/cairo-1.10.2/build/Makefile.win32.features  2010-08-18 
09:47:30.0 +0200
-@@ -18,7 +18,7 @@
- CAIRO_HAS_DRM_XR_FUNCTIONS=0
- CAIRO_HAS_GALLIUM_SURFACE=0
- CAIRO_HAS_XCB_DRM_FUNCTIONS=0
--CAIRO_HAS_PNG_FUNCTIONS=1
-+CAIRO_HAS_PNG_FUNCTIONS=0
- CAIRO_HAS_GL_SURFACE=0
- CAIRO_HAS_DIRECTFB_SURFACE=0
- CAIRO_HAS_VG_SURFACE=0
-@@ -30,7 +30,7 @@
- CAIRO_HAS_FC_FONT=0
- CAIRO_HAS_PS_SURFACE=1
- CAIRO_HAS_PDF_SURFACE=1
--CAIRO_HAS_SVG_SURFACE=1
-+CAIRO_HAS_SVG_SURFACE=0
- CAIRO_HAS_TEST_SURFACES=0
- CAIRO_HAS_TEE_SURFACE=0
- CAIRO_HAS_XML_SURFACE=0
-@@ -37,5 +37,5 @@
- CAIRO_HAS_PTHREAD=0
- CAIRO_HAS_GOBJECT_FUNCTIONS=0
- CAIRO_HAS_TRACE=0
--CAIRO_HAS_INTERPRETER=1
-+CAIRO_HAS_INTERPRETER=0
- CAIRO_HAS_SYMBOL_LOOKUP=0
 --- misc/cairo-1.10.2/build/Makefile.win32.common  2009-06-14 
23:53:24.0 +0200
 +++ misc/build/cairo-1.10.2/build/Makefile.win32.common2009-06-14 
23:53:24.0 +0200
-@@ -22,8 +22,8 @@
+@@ -22,24 +22,26 @@
  OPT := -MD -O2
  endif
  
@@ -38,7 +11,10 @@
  
  CAIRO_LIBS =  gdi32.lib msimg32.lib user32.lib
  ifeq ($(CAIRO_HAS_PNG_FUNCTIONS),1)
-@@ -33,13 +33,15 @@
+ LIBPNG_CFLAGS += -I$(top_srcdir)/../libpng/
+-CAIRO_LIBS +=  $(top_builddir)/../libpng/libpng.lib
++CAIRO_LIBS += libpng.lib
+ endif
  ifeq ($(CAIRO_HAS_PS_SURFACE)$(CAIRO_HAS_PDF_SURFACE),00)
  else
  ZLIB_CFLAGS += -I$(top_srcdir)/../zlib/
@@ -66,21 +42,12 @@
@mkdir -p $(CFG)
 --- misc/cairo-1.10.2/build/config.sub 2009-08-14 23:33:32.0 +0200
 +++ misc/build/cairo-1.10.2/build/config.sub   2009-08-14 23:33:32.0 
+0200
-@@ -120,7 +120,7 @@
- # Here we must recognize all the valid KERNEL-OS combinations.
- maybe_os=`echo $1 | sed 's/^\(.*\)-\([^-]*-[^-]*\)$/\2/'`
- case $maybe_os in
--  nto-qnx* | linux-gnu* | linux-dietlibc | linux-newlib* | linux-uclibc* | \
-+  nto-qnx* | linux-gnu* | linux-android* | linux-dietlibc | linux-newlib* | 
linux-uclibc* | \
-   uclinux-uclibc* | uclinux-gnu* | kfreebsd*-gnu* | knetbsd*-gnu* | 
netbsd*-gnu* | \
-   kopensolaris*-gnu* | \
-   storm-chaos* | os2-emx* | rtmk-nova*)
 @@ -1272,7 +1272,7 @@
  | -ekkobsd* | -kfreebsd* | -freebsd* | -riscix* | -lynxos* \
  | -bosx* | -nextstep* | -cxux* | -aout* | -elf* | -oabi* \
  | -ptx* | -coff* | -ecoff* | -winnt* | -domain* | -vsta* \
 -| -udi* | -eabi* | -lites* | -ieee* | -go32* | -aux* \
-+| -udi* | -linux-androideabi* | -eabi* | -lites* | -ieee* | 
-go32* | -aux* \
++| -udi* | -androideabi* | -eabi* | -lites* | -ieee* | -go32* | 
-aux* \
  | -chorusos* | -chorusrdb* | -cegcc* \
  | -cygwin* | -pe* | -psos* | -moss* | -proelf* | -rtems* \
  | -mingw32* | -linux-gnu* | -linux-newlib* | -linux-uclibc* \
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - cairo/cairo-1.10.2.patch

2011-12-19 Thread Fridrich Strba
 cairo/cairo-1.10.2.patch |   34 +-
 1 file changed, 5 insertions(+), 29 deletions(-)

New commits:
commit a651ccbc873436238a5c7a134d426e003133c737
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Mon Dec 19 19:03:04 2011 +0100

Build all default cairo features on Windows

Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch

diff --git a/cairo/cairo-1.10.2.patch b/cairo/cairo-1.10.2.patch
index cd6b350..6bc44c9 100644
--- a/cairo/cairo-1.10.2.patch
+++ b/cairo/cairo-1.10.2.patch
@@ -1,33 +1,6 @@
 misc/cairo-1.10.2/build/Makefile.win32.features2010-08-18 
09:47:30.0 +0200
-+++ misc/build/cairo-1.10.2/build/Makefile.win32.features  2010-08-18 
09:47:30.0 +0200
-@@ -18,7 +18,7 @@
- CAIRO_HAS_DRM_XR_FUNCTIONS=0
- CAIRO_HAS_GALLIUM_SURFACE=0
- CAIRO_HAS_XCB_DRM_FUNCTIONS=0
--CAIRO_HAS_PNG_FUNCTIONS=1
-+CAIRO_HAS_PNG_FUNCTIONS=0
- CAIRO_HAS_GL_SURFACE=0
- CAIRO_HAS_DIRECTFB_SURFACE=0
- CAIRO_HAS_VG_SURFACE=0
-@@ -30,7 +30,7 @@
- CAIRO_HAS_FC_FONT=0
- CAIRO_HAS_PS_SURFACE=1
- CAIRO_HAS_PDF_SURFACE=1
--CAIRO_HAS_SVG_SURFACE=1
-+CAIRO_HAS_SVG_SURFACE=0
- CAIRO_HAS_TEST_SURFACES=0
- CAIRO_HAS_TEE_SURFACE=0
- CAIRO_HAS_XML_SURFACE=0
-@@ -37,5 +37,5 @@
- CAIRO_HAS_PTHREAD=0
- CAIRO_HAS_GOBJECT_FUNCTIONS=0
- CAIRO_HAS_TRACE=0
--CAIRO_HAS_INTERPRETER=1
-+CAIRO_HAS_INTERPRETER=0
- CAIRO_HAS_SYMBOL_LOOKUP=0
 --- misc/cairo-1.10.2/build/Makefile.win32.common  2009-06-14 
23:53:24.0 +0200
 +++ misc/build/cairo-1.10.2/build/Makefile.win32.common2009-06-14 
23:53:24.0 +0200
-@@ -22,8 +22,8 @@
+@@ -22,24 +22,26 @@
  OPT := -MD -O2
  endif
  
@@ -38,7 +11,10 @@
  
  CAIRO_LIBS =  gdi32.lib msimg32.lib user32.lib
  ifeq ($(CAIRO_HAS_PNG_FUNCTIONS),1)
-@@ -33,13 +33,15 @@
+ LIBPNG_CFLAGS += -I$(top_srcdir)/../libpng/
+-CAIRO_LIBS +=  $(top_builddir)/../libpng/libpng.lib
++CAIRO_LIBS += libpng.lib
+ endif
  ifeq ($(CAIRO_HAS_PS_SURFACE)$(CAIRO_HAS_PDF_SURFACE),00)
  else
  ZLIB_CFLAGS += -I$(top_srcdir)/../zlib/
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'feature/gbuild_extensions' - 2 commits - extensions/Executable_nsplugin.mk solenv/gbuild

2011-12-19 Thread Matus Kukan
 extensions/Executable_nsplugin.mk   |   24 +---
 solenv/gbuild/platform/WNT_INTEL_MSC.mk |1 +
 2 files changed, 10 insertions(+), 15 deletions(-)

New commits:
commit 4ee82ce8aeb36673301b631e94f80f725eecc362
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Mon Dec 19 20:58:22 2011 +0100

extensions: nsplugin: tweak linked libraries

diff --git a/extensions/Executable_nsplugin.mk 
b/extensions/Executable_nsplugin.mk
index 6b97d46..49b8761 100644
--- a/extensions/Executable_nsplugin.mk
+++ b/extensions/Executable_nsplugin.mk
@@ -1,4 +1,4 @@
-# -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
+# -*- Mode: makefile; tab-width: 4; indent-tabs-mode: t -*-
 #
 # Version: MPL 1.1 / GPLv3+ / LGPLv3+
 #
@@ -46,21 +46,15 @@ $(eval $(call gb_Executable_add_linked_libs,nsplugin,\
cppu \
cppuhelper \
sal \
+   $(if $(filter $(GUI),UNX), \
+   dl \
+   ) \
+   $(if $(filter $(OS),SOLARIS), \
+   nsl \
+   socket \
+   ) \
 ))
 
-ifeq ($(OS),LINUX)
-$(eval $(call gb_Executable_add_linked_libs,nsplugin,\
-   dl \
-))
-endif
-
-ifeq ($(OS),SOLARIS)
-$(eval $(call gb_Executable_add_libs,nsplugin,\
-   -lsocket \
-   -lnsl \
-))
-endif
-
 ifeq ($(GUI),WNT)
 $(eval $(call gb_Executable_add_ldflags,nsplugin,\
$(OUTDIR)/lib/pathutils-obj.obj \
@@ -85,4 +79,4 @@ $(eval $(call gb_Executable_add_linked_libs,nsplugin,\
 ))
 endif # WNT
 
-# vim:set shiftwidth=4 softtabstop=4 expandtab:
+# vim: set noet sw=4 ts=4:
commit a705718a7d95c8e1abc22fcc57ddb84e5b18aa0a
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Mon Dec 19 20:52:02 2011 +0100

gbuild: register ws2_32 also for MSVC

diff --git a/solenv/gbuild/platform/WNT_INTEL_MSC.mk 
b/solenv/gbuild/platform/WNT_INTEL_MSC.mk
index 1e068ff..de562a7 100644
--- a/solenv/gbuild/platform/WNT_INTEL_MSC.mk
+++ b/solenv/gbuild/platform/WNT_INTEL_MSC.mk
@@ -426,6 +426,7 @@ gb_Library_PLAINLIBS_NONE += \
version \
winmm \
winspool \
+   ws2_32 \
 
 gb_Library_LAYER := \
$(foreach lib,$(gb_Library_OOOLIBS),$(lib):OOO) \
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: basegfx/inc basegfx/Library_basegfx.mk basegfx/Package_inc.mk basegfx/source basegfx/StaticLibrary_basegfx_s.mk basegfx/test

2011-12-19 Thread August Sodora
 basegfx/Library_basegfx.mk |1 
 basegfx/Package_inc.mk |1 
 basegfx/StaticLibrary_basegfx_s.mk |1 
 basegfx/inc/basegfx/tools/debugplotter.hxx |  111 ---
 basegfx/source/tools/debugplotter.cxx  |  416 -
 basegfx/test/basegfx2d.cxx |  321 --
 6 files changed, 851 deletions(-)

New commits:
commit cdb2736f5bbc15c0b485cde667d889ed17c699c6
Author: August Sodora aug...@gmail.com
Date:   Mon Dec 19 15:33:43 2011 -0500

Remove DebugPlotter

diff --git a/basegfx/Library_basegfx.mk b/basegfx/Library_basegfx.mk
index 5e4885a..af62918 100644
--- a/basegfx/Library_basegfx.mk
+++ b/basegfx/Library_basegfx.mk
@@ -66,7 +66,6 @@ $(eval $(call gb_Library_add_linked_libs,basegfx,\
 $(eval $(call gb_Library_add_exception_objects,basegfx,\
basegfx/source/tools/b2dclipstate \
basegfx/source/tools/canvastools \
-   basegfx/source/tools/debugplotter \
basegfx/source/tools/gradienttools \
basegfx/source/tools/keystoplerp \
basegfx/source/tools/liangbarsky \
diff --git a/basegfx/Package_inc.mk b/basegfx/Package_inc.mk
index 158948e..6d1a4e7 100644
--- a/basegfx/Package_inc.mk
+++ b/basegfx/Package_inc.mk
@@ -30,7 +30,6 @@ $(eval $(call 
gb_Package_Package,basegfx_inc,$(SRCDIR)/basegfx/inc))
 
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/lerp.hxx,basegfx/tools/lerp.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/keystoplerp.hxx,basegfx/tools/keystoplerp.hxx))
-$(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/debugplotter.hxx,basegfx/tools/debugplotter.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/canvastools.hxx,basegfx/tools/canvastools.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/rectcliptools.hxx,basegfx/tools/rectcliptools.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/b2dclipstate.hxx,basegfx/tools/b2dclipstate.hxx))
diff --git a/basegfx/StaticLibrary_basegfx_s.mk 
b/basegfx/StaticLibrary_basegfx_s.mk
index 9b113bd..891e232 100644
--- a/basegfx/StaticLibrary_basegfx_s.mk
+++ b/basegfx/StaticLibrary_basegfx_s.mk
@@ -71,7 +71,6 @@ $(WORKDIR)/CustomTarget/basegfx/source/%.cxx : 
$(SRCDIR)/basegfx/source/%.cxx
 # copied sources are generated cxx sources
 $(eval $(call gb_StaticLibrary_add_generated_exception_objects,basegfx_s,\
CustomTarget/basegfx/source/tools/liangbarsky \
-   CustomTarget/basegfx/source/tools/debugplotter \
CustomTarget/basegfx/source/tools/canvastools \
CustomTarget/basegfx/source/tools/gradienttools \
CustomTarget/basegfx/source/tools/keystoplerp \
diff --git a/basegfx/inc/basegfx/tools/debugplotter.hxx 
b/basegfx/inc/basegfx/tools/debugplotter.hxx
deleted file mode 100644
index a588d0f..000
--- a/basegfx/inc/basegfx/tools/debugplotter.hxx
+++ /dev/null
@@ -1,111 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- *
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
- * Copyright 2000, 2010 Oracle and/or its affiliates.
- *
- * OpenOffice.org - a multi-platform office productivity suite
- *
- * This file is part of OpenOffice.org.
- *
- * OpenOffice.org is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License version 3
- * only, as published by the Free Software Foundation.
- *
- * OpenOffice.org is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License version 3 for more details
- * (a copy is included in the LICENSE file that accompanied this code).
- *
- * You should have received a copy of the GNU Lesser General Public License
- * version 3 along with OpenOffice.org.  If not, see
- * http://www.openoffice.org/license.html
- * for a copy of the LGPLv3 License.
- *
- /
-
-#ifndef _BGFX_TOOLS_DEBUGPLOTTER_HXX
-#define _BGFX_TOOLS_DEBUGPLOTTER_HXX
-
-#include basegfx/point/b2dpoint.hxx
-#include basegfx/vector/b2dvector.hxx
-#include basegfx/range/b2drange.hxx
-#include basegfx/polygon/b2dpolygon.hxx
-#include basegfx/polygon/b2dpolypolygon.hxx
-#include rtl/string.hxx
-#include boost/utility.hpp // for noncopyable
-#include vector
-#include utility
-#include iosfwd
-#include basegfx/basegfxdllapi.h
-
-
-namespace basegfx
-{
-class B2DCubicBezier;
-
-/** Generates debug output for various basegfx data types.
-
-Use this class to produce debug (trace) output for various
-basegfx geometry data types. By default, this class outputs
-via OSL_TRACE (i.e. to stderr), and uses the gnuplot output
-

[Libreoffice-commits] .: basic/source

2011-12-19 Thread Caolán McNamara
 basic/source/classes/image.cxx |4 
 basic/source/inc/filefmt.hxx   |4 
 2 files changed, 8 deletions(-)

New commits:
commit f6d704146ecf714e37fbed2b6b78de520634f208
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 20:27:09 2011 +

EXTENDED_BINARY_MODULES is always defined

diff --git a/basic/source/classes/image.cxx b/basic/source/classes/image.cxx
index 2e24903..1208184 100644
--- a/basic/source/classes/image.cxx
+++ b/basic/source/classes/image.cxx
@@ -159,7 +159,6 @@ sal_Bool SbiImage::Load( SvStream r, sal_uInt32 nVersion )
 aOUSource = aTmp;
 break;
 }
-#ifdef EXTENDED_BINARY_MODULES
 case B_EXTSOURCE:
 {
 for( sal_uInt16 j = 0 ; j  nCount ; j++ )
@@ -170,7 +169,6 @@ sal_Bool SbiImage::Load( SvStream r, sal_uInt32 nVersion )
 }
 break;
 }
-#endif
 case B_PCODE:
 if( bBadVer ) break;
 pCode = new char[ nLen ];
@@ -300,7 +298,6 @@ sal_Bool SbiImage::Save( SvStream r, sal_uInt32 nVer )
 r.WriteByteString( aTmp, eCharSet );
 SbiCloseRecord( r, nPos );
 
-#ifdef EXTENDED_BINARY_MODULES
 if( nLen  STRING_MAXLEN )
 {
 sal_Int32 nRemainingLen = nLen - nMaxUnitSize;
@@ -316,7 +313,6 @@ sal_Bool SbiImage::Save( SvStream r, sal_uInt32 nVer )
 }
 SbiCloseRecord( r, nPos );
 }
-#endif
 }
 // Binary data?
 if( pCode  SbiGood( r ) )
diff --git a/basic/source/inc/filefmt.hxx b/basic/source/inc/filefmt.hxx
index 2206106..672fcef 100644
--- a/basic/source/inc/filefmt.hxx
+++ b/basic/source/inc/filefmt.hxx
@@ -78,11 +78,7 @@ class SvStream;
 #define B_LINERANGES0x524C  // LR line ranges for publics
 #define B_MODEND0x454D  // ME module end
 #define B_SBXOBJECTS0x5853  // SX SBX objects
-
-#define EXTENDED_BINARY_MODULES
-#ifdef  EXTENDED_BINARY_MODULES
 #define B_EXTSOURCE 0x5345  // ES extended source
-#endif
 
 // A library record contains only module records
 //  sal_uInt16 identifier BL
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: basic/source

2011-12-19 Thread Caolán McNamara
 basic/source/classes/image.cxx |4 
 basic/source/inc/filefmt.hxx   |4 
 2 files changed, 8 deletions(-)

New commits:
commit 815b7b39f2b29db2d9e081b1ea098aaa6209c0e6
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 20:27:09 2011 +

EXTENDED_BINARY_MODULES is always defined

diff --git a/basic/source/classes/image.cxx b/basic/source/classes/image.cxx
index 2e24903..1208184 100644
--- a/basic/source/classes/image.cxx
+++ b/basic/source/classes/image.cxx
@@ -159,7 +159,6 @@ sal_Bool SbiImage::Load( SvStream r, sal_uInt32 nVersion )
 aOUSource = aTmp;
 break;
 }
-#ifdef EXTENDED_BINARY_MODULES
 case B_EXTSOURCE:
 {
 for( sal_uInt16 j = 0 ; j  nCount ; j++ )
@@ -170,7 +169,6 @@ sal_Bool SbiImage::Load( SvStream r, sal_uInt32 nVersion )
 }
 break;
 }
-#endif
 case B_PCODE:
 if( bBadVer ) break;
 pCode = new char[ nLen ];
@@ -300,7 +298,6 @@ sal_Bool SbiImage::Save( SvStream r, sal_uInt32 nVer )
 r.WriteByteString( aTmp, eCharSet );
 SbiCloseRecord( r, nPos );
 
-#ifdef EXTENDED_BINARY_MODULES
 if( nLen  STRING_MAXLEN )
 {
 sal_Int32 nRemainingLen = nLen - nMaxUnitSize;
@@ -316,7 +313,6 @@ sal_Bool SbiImage::Save( SvStream r, sal_uInt32 nVer )
 }
 SbiCloseRecord( r, nPos );
 }
-#endif
 }
 // Binary data?
 if( pCode  SbiGood( r ) )
diff --git a/basic/source/inc/filefmt.hxx b/basic/source/inc/filefmt.hxx
index 2206106..672fcef 100644
--- a/basic/source/inc/filefmt.hxx
+++ b/basic/source/inc/filefmt.hxx
@@ -78,11 +78,7 @@ class SvStream;
 #define B_LINERANGES0x524C  // LR line ranges for publics
 #define B_MODEND0x454D  // ME module end
 #define B_SBXOBJECTS0x5853  // SX SBX objects
-
-#define EXTENDED_BINARY_MODULES
-#ifdef  EXTENDED_BINARY_MODULES
 #define B_EXTSOURCE 0x5345  // ES extended source
-#endif
 
 // A library record contains only module records
 //  sal_uInt16 identifier BL
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: binfilter/bf_basic

2011-12-19 Thread Caolán McNamara
 binfilter/bf_basic/source/classes/image.cxx |2 --
 binfilter/bf_basic/source/inc/filefmt.hxx   |4 
 2 files changed, 6 deletions(-)

New commits:
commit 46bb912ebfc8d399622f0d793a6fe85c7627b39a
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 20:27:01 2011 +

EXTENDED_BINARY_MODULES is always defined

diff --git a/binfilter/bf_basic/source/classes/image.cxx 
b/binfilter/bf_basic/source/classes/image.cxx
index c41c51a..c713451 100644
--- a/binfilter/bf_basic/source/classes/image.cxx
+++ b/binfilter/bf_basic/source/classes/image.cxx
@@ -140,7 +140,6 @@ BOOL SbiImage::Load( SvStream r, UINT32 nVersion )
 aOUSource = aTmp;
 break;
 }
-#ifdef EXTENDED_BINARY_MODULES
 case B_EXTSOURCE:
 {
 for( UINT16 j = 0 ; j  nCount ; j++ )
@@ -151,7 +150,6 @@ BOOL SbiImage::Load( SvStream r, UINT32 nVersion )
 }
 break;
 }
-#endif
 case B_PCODE:
 if( bBadVer ) break;
 pCode = new char[ nLen ];
diff --git a/binfilter/bf_basic/source/inc/filefmt.hxx 
b/binfilter/bf_basic/source/inc/filefmt.hxx
index 73626a3..b99ba7c 100644
--- a/binfilter/bf_basic/source/inc/filefmt.hxx
+++ b/binfilter/bf_basic/source/inc/filefmt.hxx
@@ -80,11 +80,7 @@ namespace binfilter {
 #define B_LINERANGES0x524C  // LR line ranges for publics
 #define B_MODEND0x454D  // ME module end
 #define B_SBXOBJECTS0x5853  // SX SBX objects
-
-#define EXTENDED_BINARY_MODULES
-#ifdef  EXTENDED_BINARY_MODULES
 #define B_EXTSOURCE 0x5345  // ES extended source
-#endif
 
 // Ein Library Record enthaelt nur Module Records
 //  UINT16 Kennung BL
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: svtools/source tools/inc tools/source

2011-12-19 Thread Thorsten Behrens
 svtools/source/filter/filter.cxx |1 
 tools/inc/tools/stream.hxx   |1 
 tools/source/generic/color.cxx   |  146 +-
 tools/source/generic/gen.cxx |  396 ---
 tools/source/generic/poly.cxx|   98 -
 5 files changed, 15 insertions(+), 627 deletions(-)

New commits:
commit 864bc59e66e92eabeef26222301607a7a5745bea
Author: Matteo Casalin matteo.casa...@poste.it
Date:   Sat Dec 17 11:18:58 2011 +0100

Removed COMPRESSMODE_FULL support from SvStream

diff --git a/svtools/source/filter/filter.cxx b/svtools/source/filter/filter.cxx
index f61990b..8047b7b 100644
--- a/svtools/source/filter/filter.cxx
+++ b/svtools/source/filter/filter.cxx
@@ -2034,7 +2034,6 @@ sal_uInt16 GraphicFilter::ExportGraphic( const Graphic 
rGraphic, const String
 
 SvMemoryStream aMemStm( 65535, 65535 );
 
-aMemStm.SetCompressMode( COMPRESSMODE_FULL 
);
 ( (GDIMetaFile) aGraphic.GetGDIMetaFile() 
).Write( aMemStm );
 
 xActiveDataSource-setOutputStream( 
::com::sun::star::uno::Reference ::com::sun::star::io::XOutputStream (
diff --git a/tools/inc/tools/stream.hxx b/tools/inc/tools/stream.hxx
index 1554776..66312b7 100644
--- a/tools/inc/tools/stream.hxx
+++ b/tools/inc/tools/stream.hxx
@@ -90,7 +90,6 @@ typedef sal_uInt16 StreamMode;
 #define NUMBERFORMAT_INT_BIGENDIAN  (sal_uInt16)0x
 #define NUMBERFORMAT_INT_LITTLEENDIAN   (sal_uInt16)0x
 
-#define COMPRESSMODE_FULL   (sal_uInt16)0x
 #define COMPRESSMODE_NONE   (sal_uInt16)0x
 #define COMPRESSMODE_ZBITMAP(sal_uInt16)0x0001
 #define COMPRESSMODE_NATIVE (sal_uInt16)0x0010
diff --git a/tools/source/generic/color.cxx b/tools/source/generic/color.cxx
index 6ee5b0d..f06d3d1 100644
--- a/tools/source/generic/color.cxx
+++ b/tools/source/generic/color.cxx
@@ -296,88 +296,18 @@ SvStream operator( SvStream rIStream, Color rColor )
 DBG_ASSERTWARNING( rIStream.GetVersion(), Color:: - Solar-Version not 
set on rIStream );
 
 sal_uInt16  nColorName;
-sal_uInt16  nRed;
-sal_uInt16  nGreen;
-sal_uInt16  nBlue;
 
 rIStream  nColorName;
 
 if ( nColorName  COL_NAME_USER )
 {
-if ( rIStream.GetCompressMode() == COMPRESSMODE_FULL )
-{
-unsigned char   cAry[6];
-sal_uInt16  i = 0;
-
-nRed= 0;
-nGreen  = 0;
-nBlue   = 0;
-
-if ( nColorName  COL_RED_2B )
-i += 2;
-else if ( nColorName  COL_RED_1B )
-i++;
-if ( nColorName  COL_GREEN_2B )
-i += 2;
-else if ( nColorName  COL_GREEN_1B )
-i++;
-if ( nColorName  COL_BLUE_2B )
-i += 2;
-else if ( nColorName  COL_BLUE_1B )
-i++;
-
-rIStream.Read( cAry, i );
-i = 0;
-
-if ( nColorName  COL_RED_2B )
-{
-nRed = cAry[i];
-nRed = 8;
-i++;
-nRed |= cAry[i];
-i++;
-}
-else if ( nColorName  COL_RED_1B )
-{
-nRed = cAry[i];
-nRed = 8;
-i++;
-}
-if ( nColorName  COL_GREEN_2B )
-{
-nGreen = cAry[i];
-nGreen = 8;
-i++;
-nGreen |= cAry[i];
-i++;
-}
-else if ( nColorName  COL_GREEN_1B )
-{
-nGreen = cAry[i];
-nGreen = 8;
-i++;
-}
-if ( nColorName  COL_BLUE_2B )
-{
-nBlue = cAry[i];
-nBlue = 8;
-i++;
-nBlue |= cAry[i];
-i++;
-}
-else if ( nColorName  COL_BLUE_1B )
-{
-nBlue = cAry[i];
-nBlue = 8;
-i++;
-}
-}
-else
-{
-rIStream  nRed;
-rIStream  nGreen;
-rIStream  nBlue;
-}
+sal_uInt16 nRed;
+sal_uInt16 nGreen;
+sal_uInt16 nBlue;
+
+rIStream  nRed;
+rIStream  nGreen;
+rIStream  nBlue;
 
 rColor.mnColor = RGB_COLORDATA( nRed8, nGreen8, nBlue8 );
 }
@@ -441,64 +371,10 @@ SvStream operator( SvStream rOStream, const Color 
rColor )
 nGreen  = (nGreen8) + nGreen;
 nBlue   = (nBlue8) + nBlue;
 
-if ( rOStream.GetCompressMode() == COMPRESSMODE_FULL )
-{
-unsigned char   cAry[6];
-sal_uInt16  i = 0;
-
-if ( nRed  0x00FF )
-{
-nColorName |= COL_RED_2B;
-cAry[i] = (unsigned char)(nRed  0xFF);
-

[Libreoffice-commits] .: idl/Executable_svidl.mk idl/inc idl/source

2011-12-19 Thread Caolán McNamara
 idl/Executable_svidl.mk|4 
 idl/inc/basobj.hxx |8 
 idl/inc/bastype.hxx|   14 --
 idl/inc/database.hxx   |   11 ---
 idl/inc/globals.hxx|2 --
 idl/inc/module.hxx |4 
 idl/inc/object.hxx |4 
 idl/inc/slot.hxx   |4 
 idl/inc/types.hxx  |   14 --
 idl/source/objects/basobj.cxx  |   11 ---
 idl/source/objects/bastype.cxx |5 -
 idl/source/objects/module.cxx  |   13 -
 idl/source/objects/object.cxx  |3 ---
 idl/source/objects/slot.cxx|4 
 idl/source/objects/types.cxx   |   11 ---
 idl/source/prj/database.cxx|3 ---
 16 files changed, 115 deletions(-)

New commits:
commit 6ade792d3e8f3244dcbb445a540939158820e50a
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Dec 19 21:10:10 2011 +

IDL_COMPILER is always defined

diff --git a/idl/Executable_svidl.mk b/idl/Executable_svidl.mk
index 407ee37..0fe2ee2 100644
--- a/idl/Executable_svidl.mk
+++ b/idl/Executable_svidl.mk
@@ -39,10 +39,6 @@ $(eval $(call gb_Executable_add_api,svidl,\
 udkapi \
 ))
 
-$(eval $(call gb_Executable_add_defs,svidl,\
-   -DIDL_COMPILER \
-))
-
 $(eval $(call gb_Executable_add_linked_libs,svidl,\
tl \
sal \
diff --git a/idl/inc/basobj.hxx b/idl/inc/basobj.hxx
index ff1d7b4..d40aab3 100644
--- a/idl/inc/basobj.hxx
+++ b/idl/inc/basobj.hxx
@@ -79,7 +79,6 @@ public:
 SV_DECL_META_FACTORY1( SvMetaObject, SvPersistBase, 14 )
 SvMetaObject();
 
-#ifdef IDL_COMPILER
 static void WriteTab( SvStream  rOutStm, sal_uInt16 nTab );
 static sal_Bool TestAndSeekSpaceOnly( SvStream , sal_uLong 
nBegPos );
 static void Back2Delemitter( SvStream  );
@@ -93,7 +92,6 @@ public:
 
 virtual voidWriteCxx( SvIdlDataBase  rBase, SvStream  rOutStm, 
sal_uInt16 nTab );
 virtual voidWriteHxx( SvIdlDataBase  rBase, SvStream  rOutStm, 
sal_uInt16 nTab );
-#endif
 };
 SV_DECL_IMPL_REF(SvMetaObject)
 SV_DECL_PERSIST_LIST(SvMetaObject,SvMetaObject *)
@@ -135,7 +133,6 @@ class SvMetaName : public SvMetaObject
 SvString  aDescription;
 
 protected:
-#ifdef IDL_COMPILER
 virtual sal_Bool ReadNameSvIdl( SvIdlDataBase , SvTokenStream  rInStm );
 void DoReadContextSvIdl( SvIdlDataBase , SvTokenStream  rInStm,
  char c = '\0' );
@@ -150,7 +147,6 @@ protected:
 WriteType, WriteAttribute = 0);
 virtual void WriteContext( SvIdlDataBase  rBase, SvStream  rOutStm, 
sal_uInt16 nTab,
 WriteType, WriteAttribute = 0);
-#endif
 public:
 SV_DECL_META_FACTORY1( SvMetaName, SvMetaObject, 15 )
 SvMetaName();
@@ -164,14 +160,12 @@ public:
 virtual const SvString GetConfigName() const{ return aConfigName; }
 virtual const SvString GetDescription() const{ return aDescription; }
 
-#ifdef IDL_COMPILER
 virtual sal_BoolTest( SvIdlDataBase , SvTokenStream  rInStm );
 virtual sal_BoolReadSvIdl( SvIdlDataBase , SvTokenStream  rInStm 
);
 virtual voidWriteSvIdl( SvIdlDataBase  rBase, SvStream  rOutStm, 
sal_uInt16 nTab );
 virtual voidWrite( SvIdlDataBase  rBase, SvStream  rOutStm, 
sal_uInt16 nTab,
WriteType, WriteAttribute = 0);
 voidWriteDescription( SvStream rOutStm );
-#endif
 };
 SV_DECL_IMPL_REF(SvMetaName)
 SV_DECL_IMPL_PERSIST_LIST(SvMetaName,SvMetaName *)
@@ -242,7 +236,6 @@ public:
 
 const SvGlobalName GetUUId() const;
 const SvVersionGetVersion() const { return aVersion; }
-#ifdef IDL_COMPILER
 voidSetModule( SvIdlDataBase  rBase );
 virtual sal_BoolReadSvIdl( SvIdlDataBase , SvTokenStream  rInStm 
);
 virtual voidWriteSvIdl( SvIdlDataBase  rBase, SvStream  rOutStm, 
sal_uInt16 nTab );
@@ -255,7 +248,6 @@ protected:
   SvStream  rOutStm, sal_uInt16 
nTab );
 virtual voidWriteAttributes( SvIdlDataBase  rBase, SvStream  
rOutStm, sal_uInt16 nTab,
   WriteType, WriteAttribute = 0);
-#endif
 };
 SV_DECL_IMPL_REF(SvMetaExtern)
 SV_DECL_IMPL_PERSIST_LIST(SvMetaExtern,SvMetaExtern *)
diff --git a/idl/inc/bastype.hxx b/idl/inc/bastype.hxx
index 3d20e62..7fdeafd 100644
--- a/idl/inc/bastype.hxx
+++ b/idl/inc/bastype.hxx
@@ -150,11 +150,9 @@ public:
 friend SvStream operator  (SvStream , const SvBOOL );
 friend SvStream operator  (SvStream , SvBOOL );
 
-#ifdef IDL_COMPILER
 sal_BoolReadSvIdl( SvStringHashEntry * pName, SvTokenStream  
rInStm );
 sal_BoolWriteSvIdl( SvStringHashEntry * pName, SvStream  rOutStm 
);
 ByteString  GetSvIdlString( SvStringHashEntry * pName );

[Libreoffice-commits] .: sw/source

2011-12-19 Thread Matus Kukan
 sw/source/ui/inc/optpage.hxx |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit be45ae39c4712da0079b26fe856a71c608909db5
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Mon Dec 19 22:39:50 2011 +0100

fix build: we now use SwTestTabPage also with disabled dbgutil

diff --git a/sw/source/ui/inc/optpage.hxx b/sw/source/ui/inc/optpage.hxx
index 3824419..a2ebae6 100644
--- a/sw/source/ui/inc/optpage.hxx
+++ b/sw/source/ui/inc/optpage.hxx
@@ -361,8 +361,6 @@ public:
  TabPage test settings for SW
 - */
 
-#ifdef DBG_UTIL
-
 class SwTestTabPage : public SfxTabPage
 {
 public:
@@ -394,7 +392,6 @@ private:
 DECL_LINK( AutoClickHdl, CheckBox * );
 
 };
-#endif // DBG_UTIL
 
 #endif
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sal/util

2011-12-19 Thread Tor Lillqvist
 sal/util/Makefile |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3584cb1906ee96c11fbd5040bf57538cf0543254
Author: Tor Lillqvist t...@iki.fi
Date:   Mon Dec 19 23:55:08 2011 +0200

Need gb_CXXFLAGS, too

diff --git a/sal/util/Makefile b/sal/util/Makefile
index 78986f7..ad39b24 100644
--- a/sal/util/Makefile
+++ b/sal/util/Makefile
@@ -33,9 +33,9 @@ all: rtlbootstrap.mk $(if $(filter-out 
$(COM),MSC),sal/typesizes.h) sal/udkversi
 sal:
mkdir sal
 
-rtlbootstrap.mk:
+rtlbootstrap.mk: sal/typesizes.h
(echo '#include macro.hxx'; echo RTL_OS:=THIS_OS; echo 
RTL_ARCH:=THIS_ARCH)  bootstrap.cxx
-   $(CXX) -E $(gb_OSDEFS) -D$(CPUNAME) -I. -I$(SRCDIR)/sal/rtl/source 
-I$(SRCDIR)/sal/inc bootstrap.cxx | grep '^RTL_' | sed -e 's///g'  $@
+   $(CXX) -E $(gb_OSDEFS) $(gb_CXXFLAGS) -D$(CPUNAME) -I. 
-I$(SRCDIR)/sal/rtl/source -I$(SRCDIR)/sal/inc bootstrap.cxx | grep '^RTL_' | 
sed -e 's///g'  $@
 
 sal/typesizes.h: sal
 ifneq ($(CROSS_COMPILING),YES)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 4 commits - sc/inc sc/source

2011-12-19 Thread Markus Mohrhard
 sc/inc/externalrefmgr.hxx|   29 -
 sc/source/core/data/cell.cxx |2 +
 sc/source/core/data/documen2.cxx |   24 +-
 sc/source/core/data/document.cxx |   28 ++--
 sc/source/core/tool/token.cxx|2 +
 sc/source/ui/docshell/docsh.cxx  |   16 +
 sc/source/ui/docshell/externalrefmgr.cxx |   52 ++-
 sc/source/ui/inc/namemgrtable.hxx|2 -
 sc/source/ui/namedlg/namemgrtable.cxx|7 ++--
 sc/source/ui/view/viewfun2.cxx   |5 ++
 10 files changed, 137 insertions(+), 30 deletions(-)

New commits:
commit 8a9aea09d274419f924b17084137eaf6c0b92fc1
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Mon Dec 19 23:22:55 2011 +0100

Copy absolute sheet refs between different docs: Part IV

Handle Move Sheet correctly

diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index cfa027e..e2c950c 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx
@@ -89,6 +89,7 @@
 #include docuno.hxx
 #include charthelper.hxx
 #include tabbgcolor.hxx
+#include clipparam.hxx
 
 #include basic/sbstar.hxx
 #include com/sun/star/container/XNameContainer.hpp
@@ -2562,6 +2563,7 @@ void ScViewFunc::MoveTable(
 if(nDestTab==SC_TAB_APPEND)
 nDestTab=pDestDoc-GetTableCount();
 SCTAB nDestTab1=nDestTab;
+ScClipParam aParam;
 for( sal_uInt16 j=0; jTheTabs.size(); ++j, ++nDestTab1 )
 {   // insert sheets first and update all references
 rtl::OUString aName;
@@ -2576,7 +2578,10 @@ void ScViewFunc::MoveTable(
 nErrVal = 0;// total error
 break;  // for
 }
+ScRange aRange( 0, 0, TheTabs[j], MAXCOL, MAXROW, TheTabs[j] );
+aParam.maRanges.Append(aRange);
 }
+pDoc-SetClipParam(aParam);
 if ( nErrVal  0 )
 {
 nDestTab1 = nDestTab;
commit a0a1a34622e3c36c4e28561aba3a19ea8b6d51f6
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Mon Dec 19 22:23:44 2011 +0100

Copy absolute refs between different docs: Part III

support copying from an unsaved document and some improvements

still problems with MoveTab and missing dialog box if we have external
refs to unsaved docs while we save

diff --git a/sc/inc/externalrefmgr.hxx b/sc/inc/externalrefmgr.hxx
index e39ac2e..b3a640e 100644
--- a/sc/inc/externalrefmgr.hxx
+++ b/sc/inc/externalrefmgr.hxx
@@ -33,9 +33,11 @@
 #include address.hxx
 #include sfx2/objsh.hxx
 #include sfx2/lnkbase.hxx
+#include sfx2/event.hxx
 #include tools/time.hxx
 #include vcl/timer.hxx
 #include svl/zforlist.hxx
+#include svl/lstner.hxx
 #include scmatrix.hxx
 #include rangelst.hxx
 #include formula/token.hxx
@@ -46,6 +48,7 @@
 #include vector
 #include list
 #include set
+#include iostream
 #include formula/ExternalReferenceHelper.hxx
 
 class ScDocument;
@@ -353,7 +356,7 @@ private:
 mutable DocDataType maDocs;
 };
 
-class SC_DLLPUBLIC ScExternalRefManager : public 
formula::ExternalReferenceHelper
+class SC_DLLPUBLIC ScExternalRefManager : public 
formula::ExternalReferenceHelper, SfxListener
 {
 public:
 
@@ -426,6 +429,7 @@ public:
 ::rtl::OUString maRelativeName;
 ::rtl::OUString maFilterName;
 ::rtl::OUString maFilterOptions;
+bool bUnsaved;
 
 void maybeCreateRealFileName(const String rOwnDocName);
 };
@@ -673,6 +677,16 @@ public:
  */
 bool isFileLoadable(const ::rtl::OUString rFile) const;
 
+/**
+ * If in maUnsavedDocShells move it to maDocShells and create a correct
+ * external reference entry
+ *
+ * @param Pointer to the newly saved DocumentShell
+ */
+void transformUnsavedRefToSavedRef( SfxObjectShell* pShell );
+
+virtual void Notify( SfxBroadcaster rBC, const SfxHint rHint );
+
 private:
 ScExternalRefManager();
 ScExternalRefManager(const ScExternalRefManager);
@@ -749,6 +763,13 @@ private:
 
 sal_uInt32 getMappedNumberFormat(sal_uInt16 nFileId, sal_uInt32 nNumFmt, 
const ScDocument* pSrcDoc);
 
+/**
+ * If we still contain unsaved files we should warn the user before saving
+ *
+ * @return true if the document still contains references to an unsaved 
file
+ */
+bool containsUnsavedReferences() { return !maUnsavedDocShells.empty(); }
+
 private:
 /** cache of referenced ranges and names from source documents. */
 ScExternalRefCache maRefCache;
@@ -761,6 +782,12 @@ private:
  */
 DocShellMap maDocShells;
 
+/**
+ * DocShells to unsaved but referenced documents. If not empty ask before 
saving!
+ * Move to maDocShells if document referenced here is saved
+ */
+DocShellMap maUnsavedDocShells;
+
 /** list of source documents that are managed by the link manager. */
 LinkedDocMap maLinkedDocs;
 
diff --git 

[Libreoffice-commits] .: 2 commits - .gitignore binfilter/bf_svx

2011-12-19 Thread Michael Stahl
 .gitignore |   19 +++
 binfilter/bf_svx/source/xoutdev/svx__xpoly.cxx |   10 --
 2 files changed, 19 insertions(+), 10 deletions(-)

New commits:
commit da969397b19ade24b63bcc6693fcac039e4064c4
Author: Michael Stahl mst...@redhat.com
Date:   Tue Dec 20 00:27:12 2011 +0100

binfilter: .gitignore: be more ignorant

diff --git a/.gitignore b/.gitignore
index 0c1d61d..0613205 100644
--- a/.gitignore
+++ b/.gitignore
@@ -28,6 +28,12 @@
 
 # Backup files:
 *~
+.*sw?
+\#*
+.DS_Store
+
+# StGit
+.stgit-edit.txt
 
 # Build directories:
 /binfilter/unxlng??
@@ -52,4 +58,17 @@
 /binfilter/unxios?.pro
 /binfilter/unxand?
 /binfilter/unxand?.pro
+
+# libxslt debug memdump
 .memdump
+
+# LibreOffice lock files
+.~lock.*#
+
+# Everyone loves patching
+*.orig
+*.rej
+
+# Somepeople love debugging
+gdbtrace.log
+valgrind.log
commit c2ec78bb9d382ff1b1b24000d45b16f50ebfabeb
Author: Michael Stahl mst...@redhat.com
Date:   Tue Dec 20 00:23:43 2011 +0100

binfilter: -Werror=unused-variable

diff --git a/binfilter/bf_svx/source/xoutdev/svx__xpoly.cxx 
b/binfilter/bf_svx/source/xoutdev/svx__xpoly.cxx
index 081ea9f..7b005a2 100644
--- a/binfilter/bf_svx/source/xoutdev/svx__xpoly.cxx
+++ b/binfilter/bf_svx/source/xoutdev/svx__xpoly.cxx
@@ -938,15 +938,8 @@ namespace binfilter {
 /*N*/   DBG_CHKOBJ( rXPoly, XPolygon, NULL );
 /*N*/
 /*N*/   USHORT  i;
-/*N*/   USHORT  nStart;
-/*N*/   USHORT  nCurPoints;
 /*N*/   USHORT  nReadPoints; // Anzahl der Punkte im Stream
 /*N*/   USHORT  nMerkPoints; // Anzahl der Punkte die ich speichern 
kann
-/*N*/   unsigned char   bShort;
-/*N*/   short   nShortX;
-/*N*/   short   nShortY;
-/*N*/   longnLongX;
-/*N*/   longnLongY;
 /*N*/
 /*N*/   rXPoly.pImpXPolygon-CheckPointDelete();
 /*N*/
@@ -1021,9 +1014,6 @@ namespace binfilter {
 /*N*/ {
 /*N*/   DBG_CHKOBJ( rXPoly, XPolygon, NULL );
 /*N*/
-/*N*/   unsigned char   bShort;
-/*N*/   unsigned char   bCurShort;
-/*N*/   USHORT  nStart;
 /*N*/   USHORT  i;
 /*N*/   USHORT  nPoints = rXPoly.GetPointCount();
 /*N*/
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sw/source

2011-12-19 Thread Matus Kukan
 sw/source/ui/config/optpage.cxx |4 
 1 file changed, 4 deletions(-)

New commits:
commit 7f56bfc31ce5ca2e7fa1678de2c924b8107967c5
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Tue Dec 20 00:57:42 2011 +0100

remove one more ifdef for SwTestTabPage

But shouldn't this stay as it was before
d330111ec383542ad8955d78a64f4ed4b095b683
in sw/source/ui/dialog/swdlgfact.cxx:1648 ?

diff --git a/sw/source/ui/config/optpage.cxx b/sw/source/ui/config/optpage.cxx
index c8be2e2..ecf345a 100644
--- a/sw/source/ui/config/optpage.cxx
+++ b/sw/source/ui/config/optpage.cxx
@@ -1729,8 +1729,6 @@ void 
SwRedlineOptionsTabPage::InitFontStyle(SvxFontPrevWindow rExampleWin)
 }
 
 
-#ifdef DBG_UTIL
-
 void lcl_SetPosSize(Window rWin, Point aPos, Size aSize)
 {
 aPos = rWin.LogicToPixel(aPos, MAP_APPFONT);
@@ -1863,8 +1861,6 @@ IMPL_LINK_INLINE_START( SwTestTabPage, AutoClickHdl, 
CheckBox *, EMPTYARG )
 return 0;
 }
 IMPL_LINK_INLINE_END( SwTestTabPage, AutoClickHdl, CheckBox *, EMPTYARG )
-#endif
-
 
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: cui/source

2011-12-19 Thread August Sodora
 cui/source/options/treeopt.cxx |   15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

New commits:
commit add0b7de36f4b0d133906fdd9647d742c33dd63b
Author: August Sodora aug...@gmail.com
Date:   Mon Dec 19 15:59:35 2011 -0500

String-OUString

diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 2277188..b790ffa 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -1181,12 +1181,15 @@ IMPL_LINK( OfaTreeOptionsDialog, SelectHdl_Impl, 
Timer*, EMPTYARG )
 pPageInfo-m_pExtPage-ActivatePage();
 }
 
-String sTmpTitle = sTitle;
-sTmpTitle += String::CreateFromAscii( - );
-sTmpTitle += aTreeLB.GetEntryText(pParent);
-sTmpTitle += String::CreateFromAscii( - );
-sTmpTitle += aTreeLB.GetEntryText(pEntry);
-SetText(sTmpTitle);
+{
+::rtl::OUStringBuffer sTitleBuf(sTitle);
+sTitleBuf.appendAscii(RTL_CONSTASCII_STRINGPARAM( - ));
+sTitleBuf.append(aTreeLB.GetEntryText(pParent));
+sTitleBuf.appendAscii(RTL_CONSTASCII_STRINGPARAM( - ));
+sTitleBuf.append(aTreeLB.GetEntryText(pEntry));
+SetText(sTitleBuf.makeStringAndClear());
+}
+
 pCurrentPageEntry = pEntry;
 if ( !bForgetSelection )
 {
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 2 commits - vcl/inc vcl/source writerfilter/inc writerfilter/source

2011-12-19 Thread August Sodora
 vcl/inc/vcl/field.hxx   |9 --
 vcl/source/control/field2.cxx   |   92 
 writerfilter/inc/resourcemodel/TagLogger.hxx|5 -
 writerfilter/source/resourcemodel/TagLogger.cxx |   53 -
 4 files changed, 159 deletions(-)

New commits:
commit b0e993d42e1df8c68c4c2684ab9dda27a1329594
Author: August Sodora aug...@gmail.com
Date:   Mon Dec 19 21:56:10 2011 -0500

callcatcher: Remove unused code

diff --git a/writerfilter/inc/resourcemodel/TagLogger.hxx 
b/writerfilter/inc/resourcemodel/TagLogger.hxx
index d45637c..2a13487 100644
--- a/writerfilter/inc/resourcemodel/TagLogger.hxx
+++ b/writerfilter/inc/resourcemodel/TagLogger.hxx
@@ -73,14 +73,9 @@ namespace writerfilter
 void element(const std::string  name);
 void unoPropertySet(uno::Referencebeans::XPropertySet rPropSet);
 #endif
-void startElement(const std::string  name);
 void attribute(const std::string  name, const std::string  value);
 void attribute(const std::string  name, const ::rtl::OUString  
value);
-void attribute(const std::string  name, sal_uInt32 value);
-void attribute(const std::string  name, const uno::Any aAny);
 void chars(const std::string  chars);
-void chars(const ::rtl::OUString  chars);
-void endElement();
 
 #ifdef DEBUG_CONTEXT_HANDLER
 void propertySet(writerfilter::ReferenceProperties::Pointer_t props,
diff --git a/writerfilter/source/resourcemodel/TagLogger.cxx 
b/writerfilter/source/resourcemodel/TagLogger.cxx
index 7b63ce0..6a0795c 100644
--- a/writerfilter/source/resourcemodel/TagLogger.cxx
+++ b/writerfilter/source/resourcemodel/TagLogger.cxx
@@ -156,13 +156,6 @@ namespace writerfilter
 
 #endif
 
-void TagLogger::startElement(const string  name)
-{
-xmlChar* xmlName = xmlCharStrdup( name.c_str() );
-xmlTextWriterStartElement( pWriter, xmlName );
-xmlFree( xmlName );
-}
-
 void TagLogger::attribute(const string  name, const string  value)
 {
 xmlChar* xmlName = xmlCharStrdup( name.c_str() );
@@ -178,42 +171,6 @@ namespace writerfilter
 attribute( name, OUStringToOString( value, RTL_TEXTENCODING_ASCII_US 
).getStr() );
 }
 
-void TagLogger::attribute(const string  name, sal_uInt32 value)
-{
-xmlChar* xmlName = xmlCharStrdup( name.c_str() );
-xmlTextWriterWriteFormatAttribute( pWriter, xmlName,
-   % SAL_PRIuUINT32, value );
-xmlFree( xmlName );
-}
-
-void TagLogger::attribute(const string  name, const uno::Any aAny)
-{
-string aTmpStrInt;
-string aTmpStrFloat;
-string aTmpStrString;
-
-sal_Int32 nInt = 0;
-float nFloat = 0.0;
-::rtl::OUString aStr;
-
-xmlChar* xmlName = xmlCharStrdup( name.c_str() );
-if ( aAny = nInt )
-{
-xmlTextWriterWriteFormatAttribute( pWriter, xmlName,
-   % SAL_PRIdINT32, nInt );
-}
-else if ( aAny = nFloat )
-{
-xmlTextWriterWriteFormatAttribute( pWriter, xmlName,
-   %f, nFloat );
-}
-else if ( aAny = aStr )
-{
-attribute( name, aStr );
-}
-xmlFree( xmlName );
-}
-
 void TagLogger::chars(const string  rChars)
 {
 xmlChar* xmlChars = xmlCharStrdup( rChars.c_str() );
@@ -221,16 +178,6 @@ namespace writerfilter
 xmlFree( xmlChars );
 }
 
-void TagLogger::chars(const ::rtl::OUString  rChars)
-{
-chars(OUStringToOString(rChars, RTL_TEXTENCODING_ASCII_US).getStr());
-}
-
-void TagLogger::endElement()
-{
-xmlTextWriterEndElement( pWriter );
-}
-
 #ifdef DEBUG_CONTEXT_HANDLER
 class PropertySetDumpHandler : public Properties
 {
commit f94db3d01631e75750431a87215338bf182f7c61
Author: August Sodora aug...@gmail.com
Date:   Mon Dec 19 21:45:29 2011 -0500

callcatcher: Remove unused code

diff --git a/vcl/inc/vcl/field.hxx b/vcl/inc/vcl/field.hxx
index 391a6e6..76a710d 100644
--- a/vcl/inc/vcl/field.hxx
+++ b/vcl/inc/vcl/field.hxx
@@ -386,8 +386,6 @@ public:
 voidSetDate( const Date rNewDate );
 voidSetUserDate( const Date rNewDate );
 DateGetDate() const;
-DateGetRealDate() const;
-sal_BoolIsDateModified() const;
 voidSetEmptyDate();
 sal_BoolIsEmptyDate() const;
 DateGetCorrectedDate() const { return maCorrectedDate; 
}
@@ -835,7 +833,6 @@ class VCL_DLLPUBLIC DateBox : public ComboBox, public 
DateFormatter
 {
 public:
 DateBox( Window* pParent, WinBits nWinStyle );
-DateBox( Window* pParent, const ResId rResId );
 ~DateBox();
 
 virtual long

[Libreoffice-commits] .: cppcanvas/inc cppcanvas/source

2011-12-19 Thread August Sodora
 cppcanvas/inc/cppcanvas/vclfactory.hxx  |   35 
 cppcanvas/source/wrapper/vclfactory.cxx |  237 
 2 files changed, 272 deletions(-)

New commits:
commit d498a3c2a12e03810a81937c1252dc0b16747936
Author: August Sodora aug...@gmail.com
Date:   Mon Dec 19 23:19:45 2011 -0500

callcatcher: Remove unused code

diff --git a/cppcanvas/inc/cppcanvas/vclfactory.hxx 
b/cppcanvas/inc/cppcanvas/vclfactory.hxx
index 14d9e6c..ab84534 100644
--- a/cppcanvas/inc/cppcanvas/vclfactory.hxx
+++ b/cppcanvas/inc/cppcanvas/vclfactory.hxx
@@ -77,44 +77,17 @@ namespace cppcanvas
 public:
 static VCLFactory getInstance();
 
-BitmapCanvasSharedPtr   createCanvas( const ::Window rVCLWindow );
 BitmapCanvasSharedPtr   createCanvas( const 
::com::sun::star::uno::Reference
   
::com::sun::star::rendering::XBitmapCanvas  xCanvas );
 
 SpriteCanvasSharedPtr   createSpriteCanvas( const ::Window rVCLWindow 
) const;
 SpriteCanvasSharedPtr   createSpriteCanvas( const 
::com::sun::star::uno::Reference

::com::sun::star::rendering::XSpriteCanvas  xCanvas ) const;
-SpriteCanvasSharedPtr   createFullscreenSpriteCanvas( const ::Window 
rVCLWindow, const Size rFullscreenSize ) const;
-
-/** Create a polygon from a tools::Polygon
-
-The created polygon initially has the same size in user
-coordinate space as the source polygon
- */
-PolyPolygonSharedPtrcreatePolyPolygon( const CanvasSharedPtr, 
const ::Polygon rPoly ) const;
-PolyPolygonSharedPtrcreatePolyPolygon( const CanvasSharedPtr, 
const ::PolyPolygon rPoly ) const;
-
-/** Create an uninitialized bitmap with the given size
- */
-BitmapSharedPtr createBitmap( const CanvasSharedPtr, const 
::Size rSize ) const;
-
-/** Create an uninitialized alpha bitmap with the given size
- */
-BitmapSharedPtr createAlphaBitmap( const CanvasSharedPtr, 
const ::Size rSize ) const;
 
 /** Create a bitmap from a VCL Bitmap
  */
-BitmapSharedPtr createBitmap( const CanvasSharedPtr, const 
::Bitmap rBitmap ) const;
 BitmapSharedPtr createBitmap( const CanvasSharedPtr, const 
::BitmapEx rBmpEx ) const;
 
-/** Create a renderer object from a Graphic
-
-The created renderer initially draws the graphic
-one-by-one units large, in user coordinate space
- */
-RendererSharedPtr   createRenderer( const CanvasSharedPtr 
 rCanvas,
-const ::Graphic   
 rGraphic,
-const Renderer::Parameters
 rParms ) const;
 /** Create a renderer object from a Metafile
 
 The created renderer initially draws the metafile
@@ -124,14 +97,6 @@ namespace cppcanvas
 const ::GDIMetaFile   
 rMtf,
 const Renderer::Parameters
 rParms ) const;
 
-/** Create an animated sprite from a VCL animation
- */
-SpriteSharedPtr createAnimatedSprite( const 
SpriteCanvasSharedPtr, const ::Animation rAnim ) const;
-
-/** Create a text portion with the given content string
- */
-TextSharedPtr   createText( const CanvasSharedPtr, const 
::rtl::OUString ) const;
-
 private:
 friend struct InitInstance;
 
diff --git a/cppcanvas/source/wrapper/vclfactory.cxx 
b/cppcanvas/source/wrapper/vclfactory.cxx
index a66ab33..0513969 100644
--- a/cppcanvas/source/wrapper/vclfactory.cxx
+++ b/cppcanvas/source/wrapper/vclfactory.cxx
@@ -45,7 +45,6 @@
 #include impltext.hxx
 #include implsprite.hxx
 
-
 using namespace ::com::sun::star;
 
 namespace cppcanvas
@@ -74,15 +73,6 @@ namespace cppcanvas
 {
 }
 
-BitmapCanvasSharedPtr VCLFactory::createCanvas( const ::Window rVCLWindow 
)
-{
-return BitmapCanvasSharedPtr(
-new internal::ImplBitmapCanvas(
-uno::Reference rendering::XBitmapCanvas (
-rVCLWindow.GetCanvas(),
-uno::UNO_QUERY) ) );
-}
-
 BitmapCanvasSharedPtr VCLFactory::createCanvas( const uno::Reference 
rendering::XBitmapCanvas  xCanvas )
 {
 return BitmapCanvasSharedPtr(
@@ -104,118 +94,6 @@ namespace cppcanvas
 new internal::ImplSpriteCanvas( xCanvas ) );
 }
 
-SpriteCanvasSharedPtr VCLFactory::createFullscreenSpriteCanvas( const 
::Window rVCLWindow,
-const 
Size rFullscreenSize ) const
-{
-return SpriteCanvasSharedPtr(
-new internal::ImplSpriteCanvas(
-uno::Reference 

[Libreoffice-commits] .: scp2/source

2011-12-19 Thread René Engelhard
 scp2/source/gnome/module_gnome.scp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bacf1f9d7be4030b292e4f586654907601b9e4ed
Author: Rene Engelhard r...@debian.org
Date:   Tue Dec 20 05:39:09 2011 +0100

evoab is gid_File_Lib_Evoab since long(er), not gid_File_Lib_Evoab_2

diff --git a/scp2/source/gnome/module_gnome.scp 
b/scp2/source/gnome/module_gnome.scp
index 8b84916..88a2926 100644
--- a/scp2/source/gnome/module_gnome.scp
+++ b/scp2/source/gnome/module_gnome.scp
@@ -41,7 +41,7 @@ Module gid_Module_Optional_Gnome
 XpdCheckSolaris = SUNWgnome-vfs;
 #endif
 Files = (
-  gid_File_Lib_Evoab_2,
+  gid_File_Lib_Evoab,
   gid_File_Lib_Fps_Gnome,
   gid_File_Lib_Vclplug_Gtk,
 #ifdef ENABLE_GTK3
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - scp2/source

2011-12-19 Thread René Engelhard
 scp2/source/gnome/module_gnome.scp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d12c87415711b8d73604a5fd16fac1590b1a92bc
Author: Rene Engelhard r...@debian.org
Date:   Tue Dec 20 05:39:09 2011 +0100

evoab is gid_File_Lib_Evoab since long(er), not gid_File_Lib_Evoab_2

diff --git a/scp2/source/gnome/module_gnome.scp 
b/scp2/source/gnome/module_gnome.scp
index 8b84916..88a2926 100644
--- a/scp2/source/gnome/module_gnome.scp
+++ b/scp2/source/gnome/module_gnome.scp
@@ -41,7 +41,7 @@ Module gid_Module_Optional_Gnome
 XpdCheckSolaris = SUNWgnome-vfs;
 #endif
 Files = (
-  gid_File_Lib_Evoab_2,
+  gid_File_Lib_Evoab,
   gid_File_Lib_Fps_Gnome,
   gid_File_Lib_Vclplug_Gtk,
 #ifdef ENABLE_GTK3
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 2 commits - sc/inc sc/source

2011-12-19 Thread Markus Mohrhard
 sc/inc/document.hxx  |4 -
 sc/inc/externalrefmgr.hxx|   13 ++--
 sc/inc/globstr.hrc   |3 
 sc/inc/tokenarray.hxx|   11 ++-
 sc/source/core/data/cell.cxx |2 
 sc/source/core/data/document.cxx |  121 ---
 sc/source/core/tool/token.cxx|   54 +
 sc/source/ui/docshell/docsh.cxx  |   15 
 sc/source/ui/src/globstr.src |4 +
 9 files changed, 79 insertions(+), 148 deletions(-)

New commits:
commit b5363b8cedf09ce7e8c75022041f4dafda4b699f
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Tue Dec 20 06:53:52 2011 +0100

improve the handling of range names while copy between different docs

we now behave nearly the same way as excel does

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 526ad41..83ad4a1 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1864,10 +1864,6 @@ private: // CLOOK-Impl-methods
 
 voidCopyRangeNamesToClip(ScDocument* pClipDoc, const ScRange 
rClipRange, const ScMarkData* pMarks, bool bAllTabs);
 voidCopyRangeNamesToClip(ScDocument* pClipDoc, const ScRange 
rClipRange, SCTAB nTab);
-voidCopyRangeNamesFromClip(ScDocument* pClipDoc, ScClipRangeNameData 
rRangeNames);
-voidUpdateRangeNamesInFormulas(
-ScClipRangeNameData rRangeNames, const ScRangeList rDestRanges, 
const ScMarkData rMark,
-SCCOL nXw, SCROW nYw);
 
 boolHasPartOfMerged( const ScRange rRange );
 
diff --git a/sc/inc/tokenarray.hxx b/sc/inc/tokenarray.hxx
index f766a46..1819de2 100644
--- a/sc/inc/tokenarray.hxx
+++ b/sc/inc/tokenarray.hxx
@@ -96,8 +96,15 @@ public:
 const ScAddress rOldPos,
 const ScAddress rNewPos );
 
-// Make all absolute references external references pointing to the old 
document
-void ReadjusteAbsolute3DReferences( const ScDocument* pOldDoc, const 
ScDocument* pNewDoc, const ScAddress rPos );
+/**
+ * Make all absolute references external references pointing to the old 
document
+ *
+ * @param pOldDoc old document
+ * @param pNewDoc new document
+ * @param rPos position of the cell to determine if the reference is in 
the copied area
+ * @param bRangeName set for range names, range names have special 
handling for absolute sheet ref + relative col/row ref
+ */
+void ReadjusteAbsolute3DReferences( const ScDocument* pOldDoc, const 
ScDocument* pNewDoc, const ScAddress rPos, bool bRangeName = false );
 };
 
 #endif // SC_TOKENARRAY_HXX
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index e85d984..a5d6df4 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -180,7 +180,7 @@ void adjustRangeName(ScToken* pToken, ScDocument rNewDoc, 
const ScDocument* pOl
 bNewGlobal = bOldGlobal;
 pRangeData = new ScRangeData(*pOldRangeData, rNewDoc);
 ScTokenArray* pRangeNameToken = pRangeData-GetCode();
-pRangeNameToken-ReadjusteAbsolute3DReferences(pOldDoc, rNewDoc, 
pRangeData-GetPos());
+pRangeNameToken-ReadjusteAbsolute3DReferences(pOldDoc, rNewDoc, 
pRangeData-GetPos(), true);
 bool bInserted;
 if (bNewGlobal)
 bInserted = rNewDoc.GetRangeName()-insert(pRangeData);
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 9796ceb..eb03a74 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -2184,116 +2184,6 @@ void ScDocument::MergeNumberFormatter(ScDocument* 
pSrcDoc)
 }
 }
 
-void ScDocument::CopyRangeNamesFromClip(ScDocument* pClipDoc, 
ScClipRangeNameData rRangeNames)
-{
-if (!pClipDoc-pRangeName)
-return;
-
-ScClipRangeNameData aClipRangeNames;
-
-ScRangeName::const_iterator itr = pClipDoc-pRangeName-begin();
-ScRangeName::const_iterator itrEnd = pClipDoc-pRangeName-end();
-for (; itr != itrEnd; ++itr)//! DB-Bereiche Pivot-Bereiche auch
-{
-/*  Copy only if the name doesn't exist in this document.
-If it exists we use the already existing name instead,
-another possibility could be to create new names if
-documents differ.
-A proper solution would ask the user how to proceed.
-The adjustment of the indices in the formulas is done later.
-*/
-const ScRangeData* pExistingData = 
GetRangeName()-findByUpperName(itr-first);
-if (pExistingData)
-{
-sal_uInt16 nOldIndex = itr-second-GetIndex();
-sal_uInt16 nNewIndex = pExistingData-GetIndex();
-aClipRangeNames.insert(nOldIndex, nNewIndex);
-if ( !aClipRangeNames.mbReplace )
-aClipRangeNames.mbReplace = ( nOldIndex != nNewIndex );
-}
-else
-{
-ScRangeData* pData = new ScRangeData( *itr-second );
-

[Libreoffice-commits] .: sc/qa

2011-12-19 Thread Markus Mohrhard
 sc/qa/extras/xnamecontainer.cxx |   85 
 1 file changed, 85 insertions(+)

New commits:
commit b77902d38d06df87694564ded859733bdb1d4fb2
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Tue Dec 20 07:44:19 2011 +0100

add test case for ScTableSheetsObj::XNameContainer::removeByName

diff --git a/sc/qa/extras/xnamecontainer.cxx b/sc/qa/extras/xnamecontainer.cxx
new file mode 100644
index 000..0a42335
--- /dev/null
+++ b/sc/qa/extras/xnamecontainer.cxx
@@ -0,0 +1,85 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * Version: MPL 1.1 / GPLv3+ / LGPLv3+
+ *
+ * The contents of this file are subject to the Mozilla Public License Version
+ * 1.1 (the License); you may not use this file except in compliance with
+ * the License or as specified alternatively below. You may obtain a copy of
+ * the License at http://www.mozilla.org/MPL/
+ *
+ * Software distributed under the License is distributed on an AS IS basis,
+ * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+ * for the specific language governing rights and limitations under the
+ * License.
+ *
+ * Major Contributor(s):
+ * Copyright (C) 2011 Markus Mohrhard markus.mohrh...@googlemail.com 
(initial developer)
+ *
+ * All Rights Reserved.
+ *
+ * For minor contributions see the git repository.
+ *
+ * Alternatively, the contents of this file may be used under the terms of
+ * either the GNU General Public License Version 3 or later (the GPLv3+), or
+ * the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
+ * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
+ * instead of those above.
+ */
+
+#include test/unoapi_test.hxx
+#include com/sun/star/container/XNameContainer.hpp
+#include com/sun/star/sheet/XSpreadsheetDocument.hpp
+
+
+namespace ScTableSheetsObj
+{
+
+class ScXNameContainer : public UnoApiTest
+{
+uno::Reference container::XNameContainer  init();
+
+void testRemoveByName();
+
+CPPUNIT_TEST_SUITE(ScXNameContainer);
+CPPUNIT_TEST(testRemoveByName);
+CPPUNIT_TEST_SUITE_END();
+};
+
+void ScXNameContainer::testRemoveByName()
+{
+rtl::OUString aSheet2(RTL_CONSTASCII_USTRINGPARAM(Sheet2));
+uno::Reference container::XNameContainer  xNameContainer = init();
+CPPUNIT_ASSERT(xNameContainer-hasByName(aSheet2));
+xNameContainer-removeByName(aSheet2);
+CPPUNIT_ASSERT(!xNameContainer-hasByName(aSheet2));
+
+bool bExceptionThrown = false;
+try
+{
+xNameContainer-removeByName(aSheet2);
+}
+catch( const container::NoSuchElementException )
+{
+std::cout  Exception Caught  std::endl;
+bExceptionThrown = true;
+}
+
+CPPUNIT_ASSERT_MESSAGE(no exception thrown, bExceptionThrown);
+}
+
+uno::Reference container::XNameContainer  ScXNameContainer::init()
+{
+uno::Reference lang::XComponent  xComponent;
+xComponent = 
loadFromDesktop(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(private:factory/scalc)));
+CPPUNIT_ASSERT(xComponent.is());
+uno::Reference sheet::XSpreadsheetDocument xDoc (xComponent, 
UNO_QUERY_THROW);
+uno::Reference container::XNameContainer  xNameContainer ( 
xDoc-getSheets(), UNO_QUERY_THROW);
+CPPUNIT_ASSERT(xNameContainer.is());
+return xNameContainer;
+}
+
+CPPUNIT_TEST_SUITE_REGISTRATION(ScXNameContainer);
+
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sc/qa

2011-12-19 Thread Markus Mohrhard
 sc/qa/unit/ucalc.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b71919511f7748af7c69a2d2da4e93af7eb7
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Tue Dec 20 08:58:01 2011 +0100

disable failing test

after my last rework of the copy paste code my old assumptions for the
copy paste code are no longer valid

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index a4158c3..c3d47ef 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -184,7 +184,7 @@ public:
 CPPUNIT_TEST(testFunctionLists);
 CPPUNIT_TEST(testToggleRefFlag);
 CPPUNIT_TEST(testAutofilter);
-CPPUNIT_TEST(testCopyPaste);
+//CPPUNIT_TEST(testCopyPaste);
 CPPUNIT_TEST(testMergedCells);
 CPPUNIT_TEST(testUpdateReference);
 CPPUNIT_TEST_SUITE_END();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice] [REVIEW] bug#36874 to be patched in 3.4.5 as well?

2011-12-19 Thread Winfried Donkers
 Is it an option to push it to 3.4.5 as well?
In case you haven't known this yet: if you want to do this, you have
to send a mail to this dev list with a subject like
  [REVIEW] $subject
and pointing to your commit. Then wait for someone to review.

This probably is still not the correct way to propose this patch for 3.4.5, but 
hopefully good enough to be reviewed and processed.
I'm not fast in learning, but eventually I may get there ;)

Winfried


fdo36874.diff
Description: fdo36874.diff
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Fwd: InterFace 1.2.0 - New Open Source Social Network as Chat Messenger Addon

2011-12-19 Thread Tor Lillqvist
 What about to add this Messenger to Libre Office?

Feel free to submit patches. I don't personally see any reason for
this, though, but hey, I just work here.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gbuild'ified salhelper

2011-12-19 Thread Matúš Kukan
On 15 December 2011 23:04, Michael Stahl mst...@redhat.com wrote:

 done, see newly added gb_Library_set_soversion_script

Thanks for this

So I have also pushed sal and cppu:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9e130ab82f3216334e432e9d6ee19a600b6c287
http://cgit.freedesktop.org/libreoffice/core/commit/?id=051fdda153d45789c6eb1a0ec32dbd32dfd8a978

Stephan, could you please check if .map files for sal, cppu and
purpenvhelper are correct ?

And I did not convert onlinecheck.dll library because it's just one
function [1] and probably can be called directly ?
I think Kendy is working on online update libs ?
Is it ok or should I convert also onlinecheck library for Windows ?

Thanks,
Matus

[1] 
http://opengrok.libreoffice.org/xref/core/sal/systools/win32/onlineupdate/onlinecheck.cxx#46
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] l10n Racecondition in sdext/source/pdfimport

2011-12-19 Thread Bjoern Michaelsen
Hi all,

I just fixed a tricky race condition for l10n builds with:

 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f2a1882be486986a76682ed51f481595e1cf0d5c

on master. Before it, parallel l10n builds could break, because all
description-*.txt were copied by every locale (as the rule was fired for every
locale) causing midair collisions. This caused my l10n build to break every
time, but does not have to be reproducable elsewhere.

@atimar: Could you a) review and cherry-pick to -3-5 b) maybe make a rough
check this is lurking elsewhere still? 

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED-3-4] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency

2011-12-19 Thread Thorsten Behrens
 Michael Meeks wrote:
  can't we just revert the original fix there ?
 

Reverted with Stephan's review in -3-4.

Cheers,

-- Thorsten


pgpUDhanxrWzO.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] REMINDER: Release 3.5.0-beta2 from libreoffice-3-5 branch

2011-12-19 Thread Petr Mladek
Hi,

please note that the commit deadline for 3.5.0-beta2 is today (Monday),
December 19, 2011.

Note that the commit deadline for the next and last beta is on
January 9, 2011.


See also
http://wiki.documentfoundation.org/ReleasePlan#3.5_release
http://wiki.documentfoundation.org/Release_Criteria
http://wiki.documentfoundation.org/Development/Branches


Best Regards,
Petr


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [Patch] Remove OOoImprovement

2011-12-19 Thread Michael Meeks

On Sun, 2011-12-18 at 20:40 +0100, Stefan Knorr (Astron) wrote:
 Here's an idea: building the server side for this should be a
 medium-size task that is also separate from most of LibO and requires
 lots of new code, so wouldn't this be ideal as a GSoC task?

Sounds like a good idea to me; I'd be happy to mentor it with someone
else.

 By the way: is the gbuild conversion project removing some of the
 basis for this feature or did I misunderstand that?

That's rather orthogonal - it's 'just' substantially improving how we
build the code :-)

ATB,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [patch] translate some german comments in /svx

2011-12-19 Thread Noel Grandin
Hi

More translations, work by Mike Whiteley and Noel Grandin, patch is under 
MPL/LGPL+

Regards, Noel

Disclaimer: http://www.peralex.com/disclaimer.html


diff --git a/svx/inc/svx/obj3d.hxx b/svx/inc/svx/obj3d.hxx
index 5cf5d03..e2d7e2d 100644
--- a/svx/inc/svx/obj3d.hxx
+++ b/svx/inc/svx/obj3d.hxx
@@ -118,7 +118,7 @@ private:
  protected:
 virtual sdr::properties::BaseProperties* CreateObjectSpecificProperties();
 
-E3dObjList  maSubList;  // child objekts
+E3dObjList  maSubList;  // child objects
 
 basegfx::B3DRange   maLocalBoundVol;// surrounding volume of 
the object (from the geometry generation)
 basegfx::B3DHomMatrix   maTransformation;   // local transformation
diff --git a/svx/inc/svx/sdrpagewindow.hxx b/svx/inc/svx/sdrpagewindow.hxx
index 7498c32..d1a2633 100644
--- a/svx/inc/svx/sdrpagewindow.hxx
+++ b/svx/inc/svx/sdrpagewindow.hxx
@@ -35,7 +35,7 @@
 #include com/sun/star/awt/XControlContainer.hpp
 #include com/sun/star/util/XModeChangeListener.hpp
 #include cppuhelper/implbase4.hxx
-#include svx/svdtypes.hxx // fuer SdrLayerID
+#include svx/svdtypes.hxx // for SdrLayerID
 #include svl/svarray.hxx
 #include tools/contnr.hxx
 #include svx/sdrpagewindow.hxx
diff --git a/svx/inc/svx/sdtakitm.hxx b/svx/inc/svx/sdtakitm.hxx
index a869003..2ac0dbb 100644
--- a/svx/inc/svx/sdtakitm.hxx
+++ b/svx/inc/svx/sdtakitm.hxx
@@ -43,48 +43,47 @@ enum SdrTextAniKind {SDRTEXTANI_NONE,
  SDRTEXTANI_SLIDE};
 
 // - SDRTEXTANI_BLINK:
-//   Einfach nur Blinken. Direction und Amount ohne Wirkung.
-//   Frequenz siehe Delay, 0=0.5Hz (Delay=250).
-//   Count=Anzahl der blinker. 0=Endlos.
-//   StartInside: sal_False=beginnend mit Pause, sal_True=Beginnend mit Puls
-//   StopInside:  sal_False=Nach Count blinkern nicht sichtbar, 
sal_True=sichtbar
-//(nur wenn Count!=0)
+//   Just blink.  Direction and Amount don't effect things.
+//   Frequency delay: 0 = 0.5Hz (Delay = 250).
+//   Count = number of blinks. (0 = forever)
+//   start inside: sal_False = begin with the blinker off, sal_True  = begin 
with the blinker on
+//   stop inside: sal_False = end with the blinker off, sal_True = end with 
the blinker on
+//(Only if count! = 0)
 // - SDRTEXTANI_SCROLL:
-//   Schrift laeuft rein, laeuft vollstaendig durch. Wenn ganz verschwunden
-//   geht's wieder von vorne los.
-//   Delay in ms, Sonderfall Delay=0 wird auf 50ms defaulted (20Hz)
-//   Count=Durchlaufanzahl (0=Endlos)
-//   Direction: ist eben die Richtung in die gescrollt wird.
-//   StartInside: sal_False=Schrift wird auch beim ersten Durchlauf 
reingescrollt
-//sal_True=Der linke Teil der Schrift steht beim ersten 
Durchlauf
-// bereits da (im sichtbaren Scrollbereich)
-//   StopInside:  sal_False=Schrift wird auch beim letzten Durchlauf 
vollstaendig
-//  rausgescrollt
-//sal_True=Schrift wird beim letzten Durchlauf nicht 
rausgescrollt
-//(nur wenn Count!=0)
-//   Amount: Schrittweite in logischen Einheiten. Negative Werte bedeuten
-//   Pixel statt log. Einheiten. Wenn Amount=0, dann wird auf
+//   Text just scrolls all the way through, and starts over when it is done.
+//
+//   Delay in ms: (except delay = 0 means 50ms (20Hz) default)
+//   Count = number of passes (0 = go forever)
+//   Direction: the direction to scroll
+//   StartInside: sal_False = on the first pass, scroll the text in (not 
initially visible)
+//sal_True = on the first pass, the left part of the text is 
already visible
+//   in the scroll area before starting.
+//   StopInside: sal_False = on the last pass, scroll the text all the way out.
+//sal_True = on the last pass, keep the right part of the text 
visible.
+//(Only if count! = 0)
+//   Amount: Step size in logical units. Negative values = use Pixels instead
+//   of logical units. If Amount = 0, then default to 1 Pixel.
 //   1 Pixel defaulted.
 // - SDRTEXTANI_ALTERNATE:
-//   Wie SDRTEXTANI_SCROLL, nur wird nicht gescrollt bis Schrift ganz
-//   verschwunden, sondern bis der letzte Teil vollstaendig sichtbar ist. Dann
-//   wird die Richtung umgekehrt und zuruekgescrollt.
-//   Count=Anzahl der Durchlaeufe=Anzahl der Richtungswechsel-1
-//   Bei Count=1 ist SDRTEXTANI_ALTERNATE also identisch mit SDRTEXTANI_SCROLL
-//   Direction ist die Startrichtung
-//   Alle andern Parameter wie SDRTEXTANI_SCROLL
+//   Like SDRTEXTANI_SCROLL, except don't scroll until all of the text is out,
+//but just until the last part is visible.  Then, change direction and
+//scroll the text the other way.
+//   Count = number of passes (number of direction changes minus 1)
+//If count = 1, this is the same as SDRTEXTANI_ALTERNATE 
SDRTEXTANI_SCROLL
+//   Direction = the starting direction.
+//   All Other 

[Libreoffice] Fwd: [Bug 41291] [EasyHack] Create a Libreoffice build session with playterm to help new developers

2011-12-19 Thread Bjoern Michaelsen
Hi List,

Let me repost this request for help/support to give it some broader visibility
(and shamelessly plug my pet Easy Hack) as I really dont know too much about
ttyrec.

Best,

Bjoern
- Forwarded message from bugzilla-dae...@freedesktop.org -

Date: Sat, 17 Dec 2011 06:04:39 +
From: bugzilla-dae...@freedesktop.org
To: bjoern.michael...@canonical.com
Subject: [Bug 41291] [EasyHack] Create a Libreoffice build session with 
playterm to help new developers

https://bugs.freedesktop.org/show_bug.cgi?id=41291

--- Comment #1 from James arthuripswichd...@hotmail.com 2011-12-17 07:04:39 
CET ---
I've thought about this EasyHack.

I am untidy in the terminal, and pause a lot.

To take this on, I would have to be able to edit the ttyrec output that is the
immediate product of doing the build.

This appears to be possible; there are edits in this example:
http://playterm.org/r/grep-with-finds-exec-option-1317222810
but I don't know how it's done.

Advice from an experienced ttyrec user, for the benefit of the next person who
considers this bug, is welcome, but I will have finished my introductory builds
and moved on.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You reported the bug.

- End forwarded message -
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Git pull problems

2011-12-19 Thread Michael Meeks

On Sun, 2011-12-18 at 15:30 +0100, Alexander Thurgood wrote:
 Thanks for your suggestion, but I tried with and without the trailing
 circumflex to no avail. I just re-cloned in the end, which sorted things
 out.

Gosh - I'm sorry about that. I'd have been curious to see the results
of 'git log' on that borked repo - and to compare them with one that
worked, and also 'git branch' - perhaps you got stuck on an anonymous
branch, or stuck in the middle of a rebase or somesuch (?).

Anyhow - glad you're back on track.

All the best,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] c++ sample for calc add-on

2011-12-19 Thread Michael Stahl
On 17/12/11 21:33, Lars Callenbach wrote:
 Hello,
 
 I have a template for the quantlib addin which works for OO3.2.
 Unfortunately it does not work for LibreOffice-3.4.

i'm not familiar with Calc addins, but in general UNO based extensions
are supposed to work with newer versions as well (unless using
unpublished APIs that actually are changed, which is AFAIK quite rare).

 Does anybody have
 a template with necessary interface functions in c++ for LO-3.4? I
 have looked at the c++ examples in the SDK without success. Using the
 ideas of the java examples did not work. At the moment the plugin
 crashes LO if I try to insert a function.

that sounds like an LO bug; extensions are not supposed to crash LO;
please file in bugzilla and attach a backtrace if you can.

 By the way: I have to
 replace the onboard libstdc++ in ure-link/lib by the system libstdc++
 to use other libraries. Why is there on old libstdc++?

i think by now it is mostly for historic reasons.
until 5 years ago or so g++ and libstdc++ regularly changed ABI, so OOo
could not rely on the needed version being available on Linux systems.
but now libstdc++ seems to be stable, so i guess we could get rid of it
in LO4 (it also causes problems with gdb python-fu).

i don't know where the bundled libstdc++ comes from and why it's outdated.

 Help (and working code samples) would be appreciated.
 
 Lars
 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] c++ sample for calc add-on

2011-12-19 Thread Michael Meeks
Hi Lars,

On Sat, 2011-12-17 at 21:33 +0100, Lars Callenbach wrote:
 I have a template for the quantlib addin which works for OO3.2.
 Unfortunately it does not work for LibreOffice-3.4. Does anybody have
 a template with necessary interface functions in c++ for LO-3.4? I
 have looked at the c++ examples in the SDK without success. Using the
 ideas of the java examples did not work. At the moment the plugin
 crashes LO if I try to insert a function.

Sounds nasty; when you say 'insert a function' - you're wanting to add
a function to calc ? if so the code in 'scaddins' is prolly best
practise, but of course if it worked with OO.o 3.2 it should work with
LibO 3.3+ etc. Having said that we got stricter on XML validation for
various config files  so on.

 By the way: I have to replace the onboard libstdc++ in ure-link/lib by
 the system libstdc++ to use other libraries. Why is there on old
 libstdc++?

This may be related to your problems I guess. The old libstdc++ is
there to support old extensions that compiled against that, presumably
that became part of our C++ ABI at some stage.

Do you have some code to play with / test ? and/or a stack trace and/or
more details ? Also - we really prefer to put useful functionality into
the core of LibreOffice so more users can get at it - would that make
sense for your feature ?

Thanks,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Brittle unit test dependencies

2011-12-19 Thread Stephan Bergmann
http://cgit.freedesktop.org/libreoffice/core/commit/?id=9351f4c1d6a3567c3b013894a0cc08471b4b0156 
Tests apparently depend on localedata_en library. is yet another 
non-obvious dependency the large unit tests in sc, sw etc. have on 
their environment.  I fear that the approach of having such large unit 
tests with fat dependencies, who's dependencies in turn have additional 
hidden runtime dependencies is not really maintainable.  How should 
those manually tracked dependencies be kept accurate?  Compare this with 
the original idea of subsequent tests, making those tests depend on a 
complete installation and running them within the environment of that 
installation.


My opinion is that we have to accept the fact that those large unit 
tests are in fact subsequent tests (to be run in the environment of a 
complete installation), and that true unit tests (executed during the 
build, not at the end when the installation set is available) need to 
have much smaller and cleaner dependencies to be useful and maintainable.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gbuild'ified salhelper

2011-12-19 Thread Jan Holesovsky
Hi Matus,

On 2011-12-19 at 10:25 +0100, Matúš Kukan wrote:

 And I did not convert onlinecheck.dll library because it's just one
 function [1] and probably can be called directly ?
 I think Kendy is working on online update libs ?
 Is it ok or should I convert also onlinecheck library for Windows ?

Yes, calling directly indeed looks right.  I suppose the original intent
was not to link against Windows code for the
InternetGetConnectedStateEx() function in extensions/ ; but I think it
is fine, the code in extensions/ is #ifdef WNT there anyway, so...

Will you do that, please?  I can test the patch for you.

Thank you,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] manipulating cursors/selections in writer with accessibility api's (bug 43390)

2011-12-19 Thread Cedric Bosdonnat
Hello Vincent,

On Fri, 2011-12-16 at 18:24 -0600, Vincent Povirk wrote:
 I'm working for CodeWeavers on a project that uses accessibility API's
 (specifically at-spi 2) to manipulate text fields. I cannot publicly
 disclose the exact nature of this project before its release, though
 it may be possible to provide access to this project for selected
 developers.

Welcome to the LibreOffice project! It's good to see people hacking
around accessibility.

 I would like to get my patch (or some other fix if mine turns out to
 be wrong) into libreoffice and, if possible, cherry-picked into
 libreoffice 3.5 so that the project I'm working on can function
 properly with Writer in Ubuntu 12.04 without requiring a special
 build.

Your patch looks OK to me and isn't likely to break something else than
accessibility. I pushed it to both master and libreoffice-3-5 branches.

 I believe the fix to be low risk (as accessibility methods
 manipulating the selection/cursor seem to be rarely used, to my
 knowledge they have never worked correctly, and my patch only has an
 effect when those methods are called) and low importance (to most
 people) for the same reasons. However, getting it into 3.5 is very
 important to us.

Then it's done. Feel free to submit more patches around accessibility
like this one.

 I do not currently have a test case. Unfortunately, accerciser is not
 able to call selection methods, apparently because of bugs in the
 python library it uses to interact with at-spi (?!). I hope to have a
 small C program written that can reproduce this soon.

In general, if you have some hints or tools to help us check for
accessibility API correctness, it would be useful.

Thanks again for your help and keep such good patches :D

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] What do we want from extensions module?

2011-12-19 Thread Michael Meeks

On Sun, 2011-12-18 at 02:39 +0100, Michael Stahl wrote:
 that is really great work!

Indeed ! particularly since it is (IIRC) the last blocker to getting
tons more modules into tail_build, and hence getting real LTO going that
should help us glup much of the suite into a single library and improve
our startup performance a lot [ faster linking, lots less linking, much
better in-lining etc. ].

Thanks so much,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] development summary: year 2011, week 50

2011-12-19 Thread Petr Mladek
Hi,

this time a brief summary of what happened during the 49th week in 2011
on LibreOffice repositories and the living branches:

+ master:LO-3.5 development
+ libreoffice-3-5:   fixes for LO-3.5.0 release
+ libreoffice-3-4:   fixes for potential LO-3.4.6 bug fix release
+ libreoffice-3-4-5: final stabilization of the LO-3.4.5 release

There are two logs for each branch:

+ bugfixes-branch-week-year-week.txt lists all commits that 
reference a proper
  bug id from a variety of trackers, i.e. #i... referring to the 
OpenOffice
  issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla

+ commit-log-branch-week-year-week.txt lists all relevant commits 
on the actual
  source repositories

Many thanks to all contributors - you make all the difference!


Best Regards,
Petr
+ calc
+ fixed Libreoffice calc crashes when re-opening a xlxs file (rhbz#754051) [Eike Rathke]
+ components
+ fix (bnc#653688) [Thorsten Behrens]
+ calc
+ fixed Libreoffice calc crashes when re-opening a xlxs file (rhbz#754051) [Eike Rathke]
+ components
+ fix (bnc#653688) [Thorsten Behrens]
+ revert Fix  (bnc#653688) [Thorsten Behrens]
+ core
+ 'Back' is misleading, use 'Revert' instead (fdo#39452) [Lior Kaplan]
+ always load res of LibO UI locale, not system deflocale (fdo#43475) [Andras Timar]
+ always sort category axis when it's a date type. (fdo#43681) [Kohei Yoshida]
+ avoid SIGBUS writing to overcommitted mmaped diskspace (rhbz#767708) [Stephan Bergmann]
+ better fix for over-zealous Zip package consistency. (bnc#653688) [Thorsten Behrens]
+ component_getFactory is missing (fdo#43422) [Caolán McNamara]
+ correct default horizontal alignment for complex script. (fdo#32530) [Kohei Yoshida]
+ crash inserting table control (fdo#42694) [Caolán McNamara]
+ don't evaluate error cells as values during filtering. (fdo#35539) [Kohei Yoshida]
+ don't try to use Inf for axes calculation (fdo#43703) [Markus Mohrhard]
+ fail fast if cups is non-operational. (bnc#722902) [Thorsten Behrens]
+ fix (bnc#653688) [Thorsten Behrens]
+ fix RTF import crasher with \keep in table properties (bnc#228839) [Cédric Bosdonnat]
+ fix docx hyperlink writing (fdo#35826, bnc#706138) [Luboš Luňák]
+ fix inconsistent compression method for encrypted ZIP packages. (bnc#653688) [Thorsten Behrens]
+ fix selection of background pictures vs text (bnc#676858) [Cédric Bosdonnat]
+ fixed an RTF import crash when handling formdata in non-FORM fields (bnc#703032) [Cédric Bosdonnat]
+ fixed chart listener registration during ODS import. (fdo#39118) [Kohei Yoshida]
+ handle empty members correctly during field popup. (fdo#35981) [Kohei Yoshida]
+ header/Footer: RTL display fixes (fdo#43793) [Cédric Bosdonnat]
+ iFSD_Equal is asymmetrical (rhbz#761009) [Caolán McNamara]
+ move SID_INSERT_CURRENT_DATE/TIME to GID_INSERT (fdo#30714) [Miklos Vajna]
+ pass the correct ScTabViewShell instance to the input box. (fdo#43614) [Kohei Yoshida]
+ preserving dbf import/export charset. (fdo#33602) [Muthu Subramanian]
+ rTF export: handle url fields without a field result (fdo#37498) [Miklos Vajna]
+ core
+ 'Back' is misleading, use 'Revert' instead (fdo#39452) [Lior Kaplan]
+ always load res of LibO UI locale, not system deflocale (fdo#43475) [Andras Timar]
+ always sort category axis when it's a date type. (fdo#43681) [Kohei Yoshida]
+ at least process sub-elements of w:customXml (fdo#35983) [Luboš Luňák]
+ avoid SIGBUS writing to overcommitted mmaped diskspace (rhbz#767708) [Stephan Bergmann]
+ better fix for over-zealous Zip package consistency. (bnc#653688) [Thorsten Behrens]
+ correct default horizontal alignment for complex script. (fdo#32530) [Kohei Yoshida]
+ crash inserting table control (fdo#42694) [Caolán McNamara]
+ don't evaluate error cells as values during filtering. (fdo#35539) [Kohei Yoshida]
+ don't try to use Inf for axes calculation (fdo#43703) [Markus Mohrhard]
+ fail fast if cups is non-operational. (bnc#722902) [Thorsten Behrens]
+ fix (bnc#653688) [Thorsten Behrens]
+ fix RTF import crasher with \keep in table properties (bnc#228839) [Cédric Bosdonnat]
+ fix abort from stl debug iterators' invalid access. (fdo#43725) [Thorsten Behrens]
+ fix docx hyperlink writing (fdo#35826, bnc#706138) [Luboš Luňák]
+ fix inconsistent compression method for encrypted ZIP packages. (bnc#653688) [Thorsten Behrens]
+ fix selection of background pictures vs text (bnc#676858) [Cédric Bosdonnat]
+ fixed an RTF import crash when handling formdata in non-FORM fields (bnc#703032) [Cédric Bosdonnat]
+ fixed chart listener registration during ODS import. (fdo#39118) [Kohei Yoshida]
+ handle empty members correctly during field popup. (fdo#35981) [Kohei Yoshida]
+ header/Footer: RTL display fixes (fdo#43793) 

Re: [Libreoffice] libicudata ICU data info

2011-12-19 Thread Michael Meeks

On Thu, 2011-12-15 at 23:44 +0100, Eike Rathke wrote:
 There's an easier way by using the ICU data library customizer available
 at http://apps.icu-project.org/datacustom/

I put Mike off this ;-) but it seems to be the right way to go (sorry
Mike) :-) [ Eike is really the domain expert here ].

If you have a new ICU tar-ball to up-load, to add to ooo.lst.in, the
best person to help there is Thorsten.

Thanks,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Brittle unit test dependencies

2011-12-19 Thread Michael Meeks
Hi Stephan,

On Mon, 2011-12-19 at 14:10 +0100, Stephan Bergmann wrote:
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=9351f4c1d6a3567c3b013894a0cc08471b4b0156
  
 Tests apparently depend on localedata_en library. is yet another 
 non-obvious dependency the large unit tests in sc, sw etc. have on 
 their environment.

Riight ... nasty. I imagine we're going to need a gb_ComplexText set of
macros to ensure that this stuff can be elegantly shared across the
sc,sw,sd,base bits in future. Cut/paste is truly horrible.

   I fear that the approach of having such large unit 
 tests with fat dependencies, who's dependencies in turn have additional 
 hidden runtime dependencies is not really maintainable.  How should 
 those manually tracked dependencies be kept accurate ?

Well; hopefully the tinderboxen catch them for us over time - how did
you find this one ?

  Compare this with the original idea of subsequent tests, making those
 tests depend on a complete installation and running them within the
 environment of that installation.

My hope of course, is that as we finish gbuild, and move our solver to
look ever more like an install set, it'll get easier and less hacky to
run these unit tests; eg. with your nice 'services' work, we could even
install the .component files into services/ directly into the build tree
it seems to me.

That doesn't help the dependencies problem - but as long as we're
conservative, and have the big-cut-and-paste-list-of-common-deps
centralised, I hope we'll not have too much maintenance trouble here (?)

Thoughts ?

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Brittle unit test dependencies

2011-12-19 Thread Stephan Bergmann

On 12/19/2011 03:21 PM, Michael Meeks wrote:

Well; hopefully the tinderboxen catch them for us over time - how did
you find this one ?


But even if we find more and more missing dependencies over time, this 
does not solve the maintainability problem.  No longer necessary 
dependencies will typically not be removed.  So in the limit, we end up 
with the tests depending on everything else, so will only be run at the 
end anyway.  So, I say, lets be honest and move them there directly.


(I found this one by chance in a non-clean build after pulling from 
master, where apparently i18npool had been changed so to build new 
localedata libs, and some tests SEGVing within dl_sym.)


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] removing mpNotes field from ScBaseCell

2011-12-19 Thread Lubos Lunak
On Saturday 17 of December 2011, Noel Grandin wrote:
 Hi

 So I've been working on this patch to move mpNotes from ScBaseCell to
 ScTable, and I got it mostly working.
 But I was struggling with leaks and getting the lifecycle of the notes
 to exactly match the lifecycle of the ScBaseCell object.

 So then I had a weird idea - how about if I tied the lifecycles
 together implicitly?
 So I came up with this patch.

 Note that your patch breaks the formatting of the code it alters - you 
probably need to set your editor to fill tabs with spaces, set the tab size 
correctly or whatever it is your editor needs.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Brittle unit test dependencies

2011-12-19 Thread Bjoern Michaelsen
On Mon, Dec 19, 2011 at 02:21:45PM +, Michael Meeks wrote:
   My hope of course, is that as we finish gbuild, and move our solver to
 look ever more like an install set, it'll get easier and less hacky to
 run these unit tests; eg. with your nice 'services' work, we could even
 install the .component files into services/ directly into the build tree
 it seems to me.

My hope would be that once we are completely on gbuild, we could make gbuild
(including tests) relying only on WORKDIR, not on OUTDIR/solver. The only
reason to keep OUTDIR around would be that scp2 doesnt understand anything
else. Then we could either:
- make scp2 pack from WORKDIR and forget about solver
- or replace scp2 with something sane
something sane could be something in gbuild that populates a installset while
building (i.e. a new OUTDIR, that incedentally looks like an install)

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] l10n Racecondition in sdext/source/pdfimport

2011-12-19 Thread Andras Timar
Hi Bjoern,

2011/12/19 Bjoern Michaelsen bjoern.michael...@canonical.com:
 I just fixed a tricky race condition for l10n builds with:

  http://cgit.freedesktop.org/libreoffice/core/commit/?id=f2a1882be486986a76682ed51f481595e1cf0d5c

 on master. Before it, parallel l10n builds could break, because all
 description-*.txt were copied by every locale (as the rule was fired for every
 locale) causing midair collisions. This caused my l10n build to break every
 time, but does not have to be reproducable elsewhere.

 @atimar: Could you a) review and cherry-pick to -3-5 b) maybe make a rough
 check this is lurking elsewhere still?

There was another occurence in sdext/source/minimizer/makefile.mk. Now
fixed in master and -3-5.

Thanks,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] What do we want from extensions module?

2011-12-19 Thread Matúš Kukan
On 18 December 2011 02:39, Michael Stahl mst...@redhat.com wrote:
 - i have not moved hidother.src, i have no idea what it does; it is
  referenced from toolkit/src2xml/src.lst and i have no idea what isthat

These hidother.src files are in more modules, I am removing them when
porting to gbuild.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Brittle unit test dependencies

2011-12-19 Thread Stephan Bergmann

On 12/19/2011 03:42 PM, Bjoern Michaelsen wrote:

On Mon, Dec 19, 2011 at 02:21:45PM +, Michael Meeks wrote:

My hope of course, is that as we finish gbuild, and move our solver to
look ever more like an install set, it'll get easier and less hacky to
run these unit tests; eg. with your nice 'services' work, we could even
install the .component files into services/ directly into the build tree
it seems to me.


My hope would be that once we are completely on gbuild, we could make gbuild
(including tests) relying only on WORKDIR, not on OUTDIR/solver. The only
reason to keep OUTDIR around would be that scp2 doesnt understand anything
else. Then we could either:
- make scp2 pack from WORKDIR and forget about solver
- or replace scp2 with something sane
something sane could be something in gbuild that populates a installset while
building (i.e. a new OUTDIR, that incedentally looks like an install)


Just to be clear:  This is unrelated to and does not solve the problem 
of those non-obvious runtime dependencies.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gbuild'ified salhelper

2011-12-19 Thread Stephan Bergmann

On 12/19/2011 10:25 AM, Matúš Kukan wrote:

Stephan, could you please check if .map files for sal, cppu and
purpenvhelper are correct ?


The symbols from solenv/bin/addsym.awk were missing.  Fixed now.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gbuild'ified salhelper

2011-12-19 Thread Matúš Kukan
On 19 December 2011 14:59, Jan Holesovsky ke...@suse.cz wrote:
 Yes, calling directly indeed looks right.  I suppose the original intent
 was not to link against Windows code for the
 InternetGetConnectedStateEx() function in extensions/ ; but I think it
 is fine, the code in extensions/ is #ifdef WNT there anyway, so...

 Will you do that, please?  I can test the patch for you.

I was afraid I will be the one to do it :)

Well, something like attached patch could be ok?
I did not test even on Linux.
I guess soon extensions will be gbuild'ified so the makefile will be
removed anyway.

Matus
From fc9c19b950647f1a1ba2683adfe8299a29c97199 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mat=C3=BA=C5=A1=20Kukan?= matus.ku...@gmail.com
Date: Mon, 19 Dec 2011 16:37:06 +0100
Subject: [PATCH] move onlinecheck.cxx from sal to extensions

---
 extensions/source/update/check/makefile.mk  |   22 +--
 extensions/source/update/check/onlinecheck.cxx  |   69 
 sal/systools/win32/onlineupdate/makefile.mk |   78 ---
 sal/systools/win32/onlineupdate/onlinecheck.cxx |   69 
 sal/systools/win32/onlineupdate/onlinecheck.dxp |   28 
 5 files changed, 85 insertions(+), 181 deletions(-)
 create mode 100644 extensions/source/update/check/onlinecheck.cxx
 delete mode 100755 sal/systools/win32/onlineupdate/makefile.mk
 delete mode 100644 sal/systools/win32/onlineupdate/onlinecheck.cxx
 delete mode 100644 sal/systools/win32/onlineupdate/onlinecheck.dxp

diff --git a/extensions/source/update/check/makefile.mk b/extensions/source/update/check/makefile.mk
index 47da869..e460d39 100644
--- a/extensions/source/update/check/makefile.mk
+++ b/extensions/source/update/check/makefile.mk
@@ -67,13 +67,7 @@ SLOFILES=\
 $(SLO)$/updatecheckconfig.obj \
 $(SLO)$/updateprotocol.obj \
 $(SLO)$/updatehdl.obj
-
-SHL1NOCHECK=TRUE
-SHL1TARGET=$(TARGET).uno   
-SHL1OBJS=$(SLOFILES)
-SHL1DEF=$(MISC)$/$(SHL1TARGET).def
 
-SHL1IMPLIB=i$(SHL1TARGET)
 SHL1STDLIBS=\
 $(CPPUHELPERLIB) \
 $(CPPULIB) \
@@ -81,6 +75,22 @@ SHL1STDLIBS=\
 $(SALLIB) \
 $(SHELL32LIB) \
 $(OLE32LIB)
+
+.IF $(GUI)==WNT
+SLOFILES+=\
+$(SLO)$/onlinecheck.obj
+SHL1STDLIBS+=\
+	$(KERNEL32LIB) \
+	$(LIBCMT) \
+	$(WININETLIB)
+.ENDIF
+
+SHL1NOCHECK=TRUE
+SHL1TARGET=$(TARGET).uno   
+SHL1OBJS=$(SLOFILES)
+SHL1DEF=$(MISC)$/$(SHL1TARGET).def
+
+SHL1IMPLIB=i$(SHL1TARGET)
 
 SHL1VERSIONMAP=$(SOLARENV)/src/component.map
 SHL1DEF=$(MISC)$/$(SHL1TARGET).def
diff --git a/extensions/source/update/check/onlinecheck.cxx b/extensions/source/update/check/onlinecheck.cxx
new file mode 100644
index 000..d3bbdc3
--- /dev/null
+++ b/extensions/source/update/check/onlinecheck.cxx
@@ -0,0 +1,69 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ *
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * Copyright 2000, 2010 Oracle and/or its affiliates.
+ *
+ * OpenOffice.org - a multi-platform office productivity suite
+ *
+ * This file is part of OpenOffice.org.
+ *
+ * OpenOffice.org is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License version 3
+ * only, as published by the Free Software Foundation.
+ *
+ * OpenOffice.org is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License version 3 for more details
+ * (a copy is included in the LICENSE file that accompanied this code).
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * version 3 along with OpenOffice.org.  If not, see
+ * http://www.openoffice.org/license.html
+ * for a copy of the LGPLv3 License.
+ *
+ /
+
+#ifdef _MSC_VER
+#pragma warning( disable: 4668 )
+#endif
+
+#include sal/types.h
+#include sal/macros.h
+
+#define WIN32_LEAN_AND_MEAN
+#include windows.h
+#include wininet.h
+
+#ifdef UNICODE
+#define _UNICODE
+#endif
+#include tchar.h
+
+// #i71984
+extern C sal_Bool SAL_CALL hasInternetConnection()
+{
+DWORD   dwFlags;
+TCHAR   szConnectionName[1024];
+
+#ifndef __MINGW32__
+__try {
+#endif
+BOOL fIsConnected = InternetGetConnectedStateEx(
+dwFlags,
+szConnectionName,
+SAL_N_ELEMENTS(szConnectionName),
+0 );
+
+return fIsConnected ? sal_True : sal_False;
+
+#ifndef __MINGW32__
+} __except( EXCEPTION_EXECUTE_HANDLER ) {
+return sal_False;
+}
+#endif
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sal/systools/win32/onlineupdate/makefile.mk b/sal/systools/win32/onlineupdate/makefile.mk
deleted file mode 100755
index 027ddef..000

Re: [Libreoffice] Brittle unit test dependencies

2011-12-19 Thread Bjoern Michaelsen
On Mon, Dec 19, 2011 at 04:13:10PM +0100, Stephan Bergmann wrote:
 Just to be clear:  This is unrelated to and does not solve the
 problem of those non-obvious runtime dependencies.

Well, if the installation is in gbuild completely, you could depend on
everything in the installation dir from a test (which would again be
subsequenttests, but in the build this time) if the real deps would be too
complex. More importantly: You could try to enumerate the real deps and if that
fails just fallback to the gimme-a-full-install option.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Notifications between different SfxObjectShells

2011-12-19 Thread Eike Rathke
Hi Markus,

On Monday, 2011-12-19 03:53:57 +0100, Markus Mohrhard wrote:

 I'm trying to improve calc's copy behavior but I'm a bit stuck with
 the last step. I need to get a notification if another document is
 being saved because I may need to adjust the reference to this
 document. I found already SfxEventHint which broadcasts all relevant
 information but only to the same SfxObjectShell while I need it in
 another shell.

As discussed on IRC ... from that broadcast a hint to another listener
that registered with the shell.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpTBpOJPe5d4.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] dyld install_name: Re: What do we want from extensions module?

2011-12-19 Thread Michael Stahl
On 18/12/11 12:05, Christian Lohmaier wrote:
 Hi Michel, *,
 
 On Sun, Dec 18, 2011 at 2:39 AM, Michael Stahl mst...@redhat.com wrote:
 On 14/12/11 23:28, Peter Foley wrote:
 On Wed, 14 Dec 2011, Michael Stahl wrote:
 [...]
 - the spotlight plugin:
  no idea if that will actually work;
  i really hope we use the system zlib always on MacOS X, because
  the old makefile had this horrible thing in it:

 # we have to change the zlib install name, otherwise the plugin will not
 work
.IF $(SYSTEM_ZLIB)==NO
install_name_tool -change @executable_path/libz.1.dylib
 @executable_path/../../../../MacOS/libz.1.dylib
 $(MACOS)$/OOoSpotlightImporter
.ENDIF
 
 Is changing the installname what you call horrible thing? Then you
 might be surprised that this is not a scary thing at all. *all* LO
 libs go through this.
 http://opengrok.libreoffice.org/xref/core/solenv/inc/unxmacx.mk#175
 http://opengrok.libreoffice.org/xref/core/solenv/gbuild/platform/macosx.mk#145
 http://opengrok.libreoffice.org/xref/core/solenv/bin/macosx-change-install-names.pl

argh, don't remind me :)

i was thinking that it could be a problem because (as i found out by
downloading and mounting the instset dmg on linux) the spotlight
importer is located in a separate directory
Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/Contents/MacOS/,
and currently this install name hackery doesn't handle that case, and
i'd rather not touch that.

 There is no concept of a library search path on Mac, all libs
 explicitly reference the libs they depend on.By absolute paths or
 relative to the specials executable_path and loader_path
 
 I also suggest to read the tinderbox mails.

i usually don't read my work mail account on weekends, so i didn't
notice that the failure in instsetoo_native was actually caused by
salhelper; would it be possible for tinderboxes to detect that a build
failed in instsetoo_native and then upload the hidden second log file
that has the actual reason somewhere?

 As just removing what
 seems like a hack to you without providing the proper solutin
 (whatever that might have been in your idea) did broke the build. (the
 salhelper filename dylib.3 vs just dylib - Norbert did revert that
 commit today)

yeah, sorry i failed to remember why exactly i wrote
gb_LinkTarget__get_installname way back in
dbd21fcb53f6e38e83dbb5aca521a97482ee0e85  :)

i'll have another try, perhaps this untested change works better:
a0a21ffa5b4198735823802e4ab516120393609c

 ciao
 Christian

PS: please let your mac tinderbox have a go at
feature/gbuild_extensions, i'm pretty sure it will break but am curious
how  :)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PATCH] 4/4 tools/rtti.hxx cleaning

2011-12-19 Thread Rafael Dominguez

From c5625c7f1ad2a2ba7158c79ee5055a261d057225 Mon Sep 17 00:00:00 2001
From: Rafael Dominguez venccsra...@gmail.com
Date: Sun, 18 Dec 2011 19:29:26 -0430
Subject: [PATCH 32/36] Replace deprecated PTR_CAST macro for dynamic_cast.

---
 sd/source/ui/slideshow/slideshowimpl.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sd/source/ui/slideshow/slideshowimpl.cxx b/sd/source/ui/slideshow/slideshowimpl.cxx
index f2a7c92..fa92d2e 100644
--- a/sd/source/ui/slideshow/slideshowimpl.cxx
+++ b/sd/source/ui/slideshow/slideshowimpl.cxx
@@ -1673,7 +1673,7 @@ void SlideshowImpl::click( const Reference XShape  xShape, const ::com::sun::
 {
 // todo, better do it async?
 SdrObject* pObj = GetSdrObjectFromXShape( xShape );
-SdrOle2Obj* pOleObject = PTR_CAST(SdrOle2Obj, pObj);
+SdrOle2Obj* pOleObject = dynamic_castSdrOle2Obj*(pObj);
 if (pOleObject  mpViewShell )
 mpViewShell-ActivateObject(pOleObject, pEvent-mnVerb);
 }
-- 
1.7.3.4

From da3ba6a8c2694a94d414c458cabb5d02509b3ff9 Mon Sep 17 00:00:00 2001
From: Rafael Dominguez venccsra...@gmail.com
Date: Sun, 18 Dec 2011 19:33:51 -0430
Subject: [PATCH 33/36] Replace deprecated PTR_CAST macro for dynamic_cast.

---
 sd/source/ui/view/Outliner.cxx  |8 
 sd/source/ui/view/ViewShellBase.cxx |2 +-
 sd/source/ui/view/drviews7.cxx  |2 +-
 sd/source/ui/view/drviewsc.cxx  |4 ++--
 sd/source/ui/view/drviewse.cxx  |2 +-
 sd/source/ui/view/frmview.cxx   |2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/sd/source/ui/view/Outliner.cxx b/sd/source/ui/view/Outliner.cxx
index d76b008..3b3b99c 100644
--- a/sd/source/ui/view/Outliner.cxx
+++ b/sd/source/ui/view/Outliner.cxx
@@ -276,7 +276,7 @@ void Outliner::PrepareSpelling (void)
 {
 mbPrepareSpellingPending = false;
 
-ViewShellBase* pBase = PTR_CAST(ViewShellBase,SfxViewShell::Current());
+ViewShellBase* pBase = dynamic_castViewShellBase*(SfxViewShell::Current());
 if (pBase != NULL)
 SetViewShell (pBase-GetMainViewShell());
 SetRefDevice( SD_MOD()-GetRefDevice( *mpDrawDocument-GetDocSh() ) );
@@ -329,7 +329,7 @@ void Outliner::EndSpelling (void)
 ::boost::shared_ptrViewShell pViewShell (mpWeakViewShell.lock());
 ::boost::shared_ptrViewShell pOldViewShell (pViewShell);
 
-ViewShellBase* pBase = PTR_CAST(ViewShellBase,SfxViewShell::Current());
+ViewShellBase* pBase = dynamic_castViewShellBase*(SfxViewShell::Current());
 if (pBase != NULL)
 pViewShell = pBase-GetMainViewShell();
 else
@@ -487,7 +487,7 @@ bool Outliner::StartSearchAndReplace (const SvxSearchItem* pSearchItem)
 mpDrawDocument-GetDocSh()-SetWaitCursor( sal_True );
 if (mbPrepareSpellingPending)
 PrepareSpelling();
-ViewShellBase* pBase = PTR_CAST(ViewShellBase,SfxViewShell::Current());
+ViewShellBase* pBase = dynamic_castViewShellBase*(SfxViewShell::Current());
 // Determine whether we have to abort the search.  This is necessary
 // when the main view shell does not support searching.
 bool bAbort = false;
@@ -1621,7 +1621,7 @@ void Outliner::BeginConversion (void)
 {
 SetRefDevice( SD_MOD()-GetRefDevice( *mpDrawDocument-GetDocSh() ) );
 
-ViewShellBase* pBase = PTR_CAST(ViewShellBase, SfxViewShell::Current());
+ViewShellBase* pBase = dynamic_castViewShellBase*(SfxViewShell::Current());
 if (pBase != NULL)
 SetViewShell (pBase-GetMainViewShell());
 
diff --git a/sd/source/ui/view/ViewShellBase.cxx b/sd/source/ui/view/ViewShellBase.cxx
index 500e607..a0ba964 100644
--- a/sd/source/ui/view/ViewShellBase.cxx
+++ b/sd/source/ui/view/ViewShellBase.cxx
@@ -813,7 +813,7 @@ void ViewShellBase::ReadUserDataSequence (
 case ViewShell::ST_HANDOUT:
 {
 ::rtl::OUString sViewURL;
-switch (PTR_CAST(DrawViewShell, pShell)-GetPageKind())
+switch (dynamic_castDrawViewShell*(pShell)-GetPageKind())
 {
 default:
 case PK_STANDARD:
diff --git a/sd/source/ui/view/drviews7.cxx b/sd/source/ui/view/drviews7.cxx
index 97b2e6f..71825b3 100644
--- a/sd/source/ui/view/drviews7.cxx
+++ b/sd/source/ui/view/drviews7.cxx
@@ -1492,7 +1492,7 @@ void DrawViewShell::GetMenuState( SfxItemSet rSet )
 }
 else
 {
-SdrUnoObj* pUnoCtrl = PTR_CAST(SdrUnoObj, mpDrawView-GetMarkedObjectList().GetMark(0)-GetMarkedSdrObj());
+SdrUnoObj* pUnoCtrl = dynamic_castSdrUnoObj*(mpDrawView-GetMarkedObjectList().GetMark(0)-GetMarkedSdrObj());
 
 if ( pUnoCtrl  FmFormInventor == pUnoCtrl-GetObjInventor() )
 {
diff --git a/sd/source/ui/view/drviewsc.cxx b/sd/source/ui/view/drviewsc.cxx
index 5218c50..6646bb3 100644
--- a/sd/source/ui/view/drviewsc.cxx
+++ b/sd/source/ui/view/drviewsc.cxx
@@ -357,8 +357,8 @@ void DrawViewShell::FuTemp03(SfxRequest rReq)
   

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2011-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #58 from Astron heinzless...@gmail.com 2011-12-19 09:45:29 PST ---
Propose to add this:
https://bugs.freedesktop.org/show_bug.cgi?id=43738

Two of our bundled extensions don't work on Windows.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] License statement

2011-12-19 Thread Jeremy White
For the record, all CodeWeavers contributions are licensed under the
MPL/LGPLv3+ dual license.

Cheers,

Jeremy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-19 Thread Michael Stahl
hi Tomas,

you are much more likely to get a reply for this kind of bug on the dev
list.

On 19/12/11 16:32, Tomas Hlavaty wrote:
 Hi all,
 
 something has changed recently and it is not possible to remove sheets
 via uno calls anymore.  It used to work with v3.4.4 but fails with
 v3.5b0 and v3.5b1.
 
 Steps to reproduce:
 
 1) Create a new spreadsheet via uno
 
 2) While trying to remove the second sheet
com.sun.star.container.XNameContainer.removeByName(Sheet2) via uno
fails (on an instance of com.sun.star.sheet.XSpreadsheets)
 
 v3.5b0 at least indicates an exception:
 
type: com.sun.star.uno:runtime-exception
 message: C++ code threw St12out_of_range: vector::_M_range_check
 context: NULL
 
 v3.5b1 simply disconnects leaving me with a broken pipe.

sounds like a bug to me. guess you should file it in bugzilla and set
the regression keyword.

 I don't have an easy to run test case at the moment:-( Any pointers to a
 simple existing code that does something similar and is easy to set up
 so that I can modify it to document this bug with a running code?

in sc you should find some new C++ unit tests and old Java unit tests
(in qa/complex).

 What are the git tags for v3.4.4, v3.5b0 and v3.5b1?

i guess 3.4.4 is this: libreoffice-3.4.4.2

3.5 tags:

beta0:  libreoffice-3.5.0.0
beta1:  libreoffice-3.4.99.1

yes, really :)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-19 Thread Bjoern Michaelsen
On Mon, Dec 19, 2011 at 07:26:21PM +0100, Michael Stahl wrote:
 sounds like a bug to me. guess you should file it in bugzilla and set
 the regression keyword.

Any you could try bibisect: http://sweetshark.livejournal.com/7683.html
to close in on the bug even more (and thus make it get fixed faster).

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-19 Thread Markus Mohrhard
Hey,

let me check that. If it is a bug I'll create a test and fix it for beta3.

Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] DISTRIBUIDOR MSI

2011-12-19 Thread marco

Seu cliente de e-mail não pode ler este e-mail.
Para visualizá-lo on-line, por favor, clique aqui:
http://enviandonoticias.com/display.php?M=87167C=7864f54b2517959f8a2bff2f40abf895S=32L=24N=36


Para parar de receber nossos
Emails:http://enviandonoticias.com/unsubscribe.php?M=87167C=7864f54b2517959f8a2bff2f40abf895L=24N=32
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] 1/4 tools/rtti.hxx cleaning

2011-12-19 Thread Michael Meeks
Hi Rafael,

On Mon, 2011-12-19 at 13:03 -0430, Rafael Dominguez wrote:
 Just some cleanup of tools/rtti.hxx macros for c++ RTTI.

Gosh :-) you are brave. I suppose there is some residual performance
concern about this sort of thing; then again I think that many of our
SfxItemSet items are rather shallowly inherited - just a couple of jumps
to SfxFooItem etc. - so perhaps it won't be so bad. The SfxItemSet
grab-bag is used in some pretty inner of inner loops JFYI so ... lets
see.

  Theres a bunch of patchs but they are very straightfoward.
 In the future can i push the patch myself or should i continue sending
 them to the ml for review??

If we're resolved to do this thing; which - I suspect we should, then -
if you are 100% confident, then I'm not sure these would need review. I
wonder if there is an easy way (by leaving the existing macros in-place
but changing their impl. to use dynamic_cast) whether we could do some
profiling of: medium sized word document (with diverse styles 
formatting) load, same for medium sized spreadsheet, and large PPT -
before and after. [ the best way to do that is to run before  after in
callgrind the way to do that is:

export OOO_EXIT_POST_STARTUP=1
export OOO_DISABLE_RECOVERY=1
valgrind --tool=callgrind --simulate-cache=yes --dump-instr=yes ./soffice.bin 
-writer --splash-pipe=0 test-file.ods

You can then leave it un-attended  get a nice number out.

Beyond the malingering performance concern, I'm all for this :-)

As a minor nit:

// Check type since it is destroyed when the type is deleted
if(GetStyleSheet()  HAS_BASE(SfxStyleSheet, mpStyleSheet))

If indeed we don't need to check the type, we should prolly drop the
comment as well [ did you look at the commit that added those comments
in the history ? with git annotate - perhaps there is something
interesting there ].

Anyhow - great to have you cleaning this up.

ATB,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] [PATCH] [RFC] COMPRESSMODE_FULL

2011-12-19 Thread Thorsten Behrens
Matteo Casalin wrote:
 Here are the patches for *completely* removing COMPRESSMODE_FULL
 support.

Applied as-is, good work - and the identical commit msg are a
feature, not a bug. Good riddance hand-rolled compression code.
:)

What are you up for next?

Cheers,

-- Thorsten


pgpMyZnsIMmFD.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] 1/4 tools/rtti.hxx cleaning

2011-12-19 Thread Rafael Dominguez
On Mon, Dec 19, 2011 at 3:57 PM, Michael Meeks michael.me...@suse.comwrote:

 Hi Rafael,

 On Mon, 2011-12-19 at 13:03 -0430, Rafael Dominguez wrote:
  Just some cleanup of tools/rtti.hxx macros for c++ RTTI.

 Gosh :-) you are brave. I suppose there is some residual
 performance
 concern about this sort of thing; then again I think that many of our
 SfxItemSet items are rather shallowly inherited - just a couple of jumps
 to SfxFooItem etc. - so perhaps it won't be so bad. The SfxItemSet
 grab-bag is used in some pretty inner of inner loops JFYI so ... lets
 see.


Well yeah theres a penalty for using dynamic_cast but dunno how much will
affect performance since theres alot of calls, but im pretty sure some code
can be refactored to avoid casting.


   Theres a bunch of patchs but they are very straightfoward.
  In the future can i push the patch myself or should i continue sending
  them to the ml for review??

 If we're resolved to do this thing; which - I suspect we should,
 then -
 if you are 100% confident, then I'm not sure these would need review. I
 wonder if there is an easy way (by leaving the existing macros in-place
 but changing their impl. to use dynamic_cast) whether we could do some
 profiling of: medium sized word document (with diverse styles 
 formatting) load, same for medium sized spreadsheet, and large PPT -
 before and after. [ the best way to do that is to run before  after in
 callgrind the way to do that is:


Well probably we can change the implementation of the PTR_CAST, HAS_BASE
and IS_TYPE macros, but for the other ones
we cant. i will see if i can get some benchmarks.


 export OOO_EXIT_POST_STARTUP=1
 export OOO_DISABLE_RECOVERY=1
 valgrind --tool=callgrind --simulate-cache=yes --dump-instr=yes
 ./soffice.bin -writer --splash-pipe=0 test-file.ods

You can then leave it un-attended  get a nice number out.

Beyond the malingering performance concern, I'm all for this :-)

As a minor nit:

// Check type since it is destroyed when the type is deleted
if(GetStyleSheet()  HAS_BASE(SfxStyleSheet, mpStyleSheet))

If indeed we don't need to check the type, we should prolly drop the
 comment as well [ did you look at the commit that added those comments
 in the history ? with git annotate - perhaps there is something
 interesting there ].


No i didnt look at the code history, i saw alot of stuff that could
possibly can get improved but didnt want to change lots of code, you know
how fragile is the codebase. The most usage of the RTTI is for ui, views
and shell classes.


Anyhow - great to have you cleaning this up.

ATB,

Michael.

 --
 michael.me...@suse.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Build problems (and some solutions) in Mac OSX

2011-12-19 Thread James C
Hello All,

I have burned about 1.5 GB of metered network bandwidth, so far,
following these instructions:

http://wiki.documentfoundation.org/Development/How_to_build#Getting_the_sources

I have found and, I think fixed, problems which occur on both
origin/master and origin/libreoffice-3-5, where the test for a
parallel build bug presumes that mktmp and the thing to do sha1 hash
sums look like they do on linux.  A patch is attached, which I *think*
will not break the linux builds.  I release this change under GPLv3
and MPL, as requested.  I hope that nobody has a software patent on
the idea of correctness in code :-)

There is also a human-sized problem, with some instructions on the
web-site being wrong:
https://bugs.freedesktop.org/show_bug.cgi?id=43920

I am now stuck, and have not yet built libre-office.  There are two
ways forward; one technical and one human.

The technical one is:
  - my builds of origin/master and origin/libreoffice-3-5 fail in
pango, because it depends on where cairo gets its fonts from, and on
Apple Aqua, cairo gets its fonts from quartz, for which the
corresponding parts of pango seem not to have been written

  - this bug records my journey:
https://bugs.freedesktop.org/show_bug.cgi?id=43917

  - I expect that I will not complete it without help

  - how, if at all, is this software buildable under MacOS?

The human one is:
  - prebuilt LibreOffice 3.4.4 OOO340m1 (Build:402) from here:
http://www.libreoffice.org/download/
runs on my Mac, so it must be buildable

  - I cannot find the OOO340m1 tag in the git repository that I have
already invested resources in downloading

  - I do not understand which pieces of the source I would need, in
order to play with Writer, and how big they would be

  - please can there be a link on the download page, to an explanation
of how the various torrents relate to the various repositories?

  - better yet, please can the source for this version be put into the
repository, and I be told how to change to it?

Regards,
James,
Wellington, New Zealand.
diff --git a/configure.in b/configure.in
index 433c523..800c23c 100644
--- a/configure.in
+++ b/configure.in
@@ -2713,7 +2713,19 @@ if test $_make_longver -ge 038200 ; then
 elif test $_make_longver -ge 038100 ; then
 AC_MSG_RESULT([$GNUMAKE $_make_version])
 AC_MSG_CHECKING([for GNU make bug 20033])
-TESTGMAKEBUG20033=`mktemp -d`
+dnl
+dnl FIXME: mktemp takes different arguments on different platforms:
+dnl http://stackoverflow.com/questions/2792675/how-portable-is-mktemp1
+dnl
+dnl -t means either 'use $TMPDIR' (OK) or 'the following is a template'.
+dnl and without 'the following is a template', a following template
+dnl is allowed, so this *may* work on *most* platforms
+dnl
+TESTGMAKEBUG20033=`mktemp -d -t MakefileXX`
+SHA1SUM=sha1sum
+if test $_os = Darwin; then
+SHA1SUM=shasum
+fi
 cat  $TESTGMAKEBUG20033/Makefile  EOF
 A := \$(wildcard *.a)
 
@@ -2736,7 +2748,7 @@ define d2
 endef
 
 %.b : %.a
-   \$(eval CHECKSUM := \$(word 1,\$(shell cat \$^ | sha1sum))) \$(if 
\$(wildcard \$(CACHEDIR)/\$(CHECKSUM)),\
+   \$(eval CHECKSUM := \$(word 1,\$(shell cat \$^ | $SHA1SUM))) \$(if 
\$(wildcard \$(CACHEDIR)/\$(CHECKSUM)),\
\$(call d1,\$(CHECKSUM)),\
\$(call d2,\$(CHECKSUM)))
 EOF
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] hello

2011-12-19 Thread users
Mail transaction failed. Partial message is available.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-19 Thread Markus Mohrhard
Hello Tomas,

Ok, I wrote a simple c++ based test for that and can't reproduce your problem.

The test ( 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b77902d38d06df87694564ded859733bdb1d4fb2
) creates an empty document, checks that it has a second sheet( bad
assumption there from me) and removes the sheet. Eventually I even
check that removing with the same name will throw an
NoSuchElementException. I also had some quick looks at the
implementation and I don't see any place that would throw an out of
bounds exception.

All of these parts pass without any problem, not even a suspicious
line in a dbgutil build.

Can you open a bug report for this with some more details and assign it to me?

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 43901] RTL Toolbar icons order becomes opposite when in OLE object edit mode

2011-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43901

--- Comment #5 from Lior Kaplan kaplanl...@gmail.com 2011-12-19 00:34:32 PST 
---
Bug 42577 reports about the same problem in a different situation, but I
wouldn't mark them as duplicate without know the problem comes from the same
code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 42577] RTL UI toolbar view mirrored (docking and expand at the wrong side) when Insert Object Formula

2011-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42577

Lior Kaplan kaplanl...@gmail.com changed:

   What|Removed |Added

  Status Whiteboard|BSA, CONFIRMED  |BSA, CONFIRMED, RTL
 CC||kaplanl...@gmail.com
 Blocks||43808
   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=43901

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   >