[Bug 31609] Support different smart quote settings by language.
https://bugs.freedesktop.org/show_bug.cgi?id=31609 Cédric Bosdonnat cedric.bosdonnat@free.fr changed: What|Removed |Added CC|cedric.bosdonnat.ooo@free.f | |r | --- Comment #11 from Cédric Bosdonnat cedric.bosdonnat@free.fr --- Removing myself from CC: not hacking writer anymore -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 5 commits - svtools/Library_svt.mk svtools/source svtools/util
svtools/Library_svt.mk|1
svtools/source/control/filectrl.cxx | 54 +++
svtools/source/control/filectrl2.cxx | 75 --
svtools/source/graphic/descriptor.hxx |4 -
svtools/source/graphic/graphic.cxx|4 -
svtools/source/graphic/graphic.hxx|6 -
svtools/source/graphic/provider.cxx | 53 +--
svtools/source/graphic/renderer.cxx | 50 --
svtools/source/hatchwindow/hatchwindowfactory.cxx | 58 ++---
svtools/source/inc/hatchwindowfactory.hxx | 39 ---
svtools/source/inc/provider.hxx |9 --
svtools/source/inc/renderer.hxx |9 --
svtools/source/uno/fpicker.cxx| 68 +--
svtools/source/uno/fpicker.hxx| 47 -
svtools/source/uno/miscservices.cxx | 42
svtools/util/svt.component| 15 ++--
16 files changed, 159 insertions(+), 375 deletions(-)
New commits:
commit 732c0f929fc0229b6da37d4ec4b6de8994fcea46
Author: Matúš Kukan matus.ku...@collabora.com
Date: Mon Dec 23 10:07:43 2013 +0100
svt: Use constructor feature for GraphicProvider.
Change-Id: I0cb66814c3dcbe38a92ada0dfcc0374313784a2b
diff --git a/svtools/source/graphic/descriptor.hxx
b/svtools/source/graphic/descriptor.hxx
index 906c4aa..5d4e7b9 100644
--- a/svtools/source/graphic/descriptor.hxx
+++ b/svtools/source/graphic/descriptor.hxx
@@ -60,10 +60,6 @@ class Graphic;
namespace unographic {
-// ---
-// - GraphicProvider -
-// ---
-
class GraphicDescriptor : public ::cppu::OWeakAggObject,
public ::com::sun::star::lang::XServiceInfo,
public ::com::sun::star::lang::XTypeProvider,
diff --git a/svtools/source/graphic/graphic.cxx
b/svtools/source/graphic/graphic.cxx
index da0a9de..f81a019 100644
--- a/svtools/source/graphic/graphic.cxx
+++ b/svtools/source/graphic/graphic.cxx
@@ -31,10 +31,6 @@ using namespace com::sun::star;
namespace unographic {
-// ---
-// - GraphicProvider -
-// ---
-
Graphic::Graphic() :
mpGraphic( NULL )
{
diff --git a/svtools/source/graphic/graphic.hxx
b/svtools/source/graphic/graphic.hxx
index 645269c..9ab6fc0 100644
--- a/svtools/source/graphic/graphic.hxx
+++ b/svtools/source/graphic/graphic.hxx
@@ -28,14 +28,8 @@
#include descriptor.hxx
#include transformer.hxx
-class Graphic;
-
namespace unographic {
-// ---
-// - GraphicProvider -
-// ---
-
class Graphic : public ::com::sun::star::graphic::XGraphic,
public ::com::sun::star::awt::XBitmap,
public ::com::sun::star::lang::XUnoTunnel,
diff --git a/svtools/source/graphic/provider.cxx
b/svtools/source/graphic/provider.cxx
index cf5113b..2bc31a6 100644
--- a/svtools/source/graphic/provider.cxx
+++ b/svtools/source/graphic/provider.cxx
@@ -43,19 +43,10 @@
using namespace com::sun::star;
-namespace unographic {
+namespace {
#define UNO_NAME_GRAPHOBJ_URLPREFIX
vnd.sun.star.GraphicObject:
-// ---
-// - GraphicProvider -
-// ---
-
-uno::Reference uno::XInterface SAL_CALL GraphicProvider_CreateInstance(
const uno::Reference lang::XMultiServiceFactory )
-{
-return (static_cast ::cppu::OWeakObject* (new GraphicProvider ));
-}
-
GraphicProvider::GraphicProvider()
{
}
@@ -68,30 +59,10 @@ GraphicProvider::~GraphicProvider()
//
--
-OUString GraphicProvider::getImplementationName_Static()
-throw()
-{
-return OUString( com.sun.star.comp.graphic.GraphicProvider );
-}
-
-//
--
-
-uno::Sequence OUString GraphicProvider::getSupportedServiceNames_Static()
-throw()
-{
-uno::Sequence OUString aSeq( 1 );
-
-aSeq.getArray()[ 0 ] = com.sun.star.graphic.GraphicProvider;
-
-return aSeq;
-}
-
-//
--
-
OUString SAL_CALL GraphicProvider::getImplementationName()
throw( uno::RuntimeException )
{
-return getImplementationName_Static();
+return OUString( com.sun.star.comp.graphic.GraphicProvider );
}
//
--
@@ -114,7 +85,9 @@ sal_Bool SAL_CALL GraphicProvider::supportsService( const
OUString ServiceName
uno::Sequence OUString SAL_CALL GraphicProvider::getSupportedServiceNames()
throw( uno::RuntimeException )
{
-return getSupportedServiceNames_Static();
+uno::Sequence OUString aSeq( 1 );
+aSeq.getArray()[ 0 ] = com.sun.star.graphic.GraphicProvider;
[Libreoffice-commits] core.git: sw/qa
0 files changed New commits: commit 4663b9e494ab691c4932fb0cc7e41aa0f9b3a214 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Dec 23 11:31:12 2013 +0100 sw: chmod -x docx, doc and rtf testcases Change-Id: I6f6726dd99a3f894ae86de279c74270e19b49d0e diff --git a/sw/qa/extras/ooxmlexport/data/1-table-1-page.docx b/sw/qa/extras/ooxmlexport/data/1-table-1-page.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/a4andborders.docx b/sw/qa/extras/ooxmlexport/data/a4andborders.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/grabbag.docx b/sw/qa/extras/ooxmlexport/data/grabbag.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/n789482.docx b/sw/qa/extras/ooxmlexport/data/n789482.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/para-shadow.docx b/sw/qa/extras/ooxmlexport/data/para-shadow.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/table-floating-margins.docx b/sw/qa/extras/ooxmlexport/data/table-floating-margins.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/table-floating.docx b/sw/qa/extras/ooxmlexport/data/table-floating.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/table-style-rPr-sz.docx b/sw/qa/extras/ooxmlexport/data/table-style-rPr-sz.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/textframe-borders.docx b/sw/qa/extras/ooxmlexport/data/textframe-borders.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/textframe-gradient.docx b/sw/qa/extras/ooxmlexport/data/textframe-gradient.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/transparent-shadow.docx b/sw/qa/extras/ooxmlexport/data/transparent-shadow.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlexport/data/watermark.docx b/sw/qa/extras/ooxmlexport/data/watermark.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/default-sect-break-cols.docx b/sw/qa/extras/ooxmlimport/data/default-sect-break-cols.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/fdo65632.docx b/sw/qa/extras/ooxmlimport/data/fdo65632.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/fdo66474.docx b/sw/qa/extras/ooxmlimport/data/fdo66474.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/groupshape-rotation.docx b/sw/qa/extras/ooxmlimport/data/groupshape-rotation.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/groupshape-sdt.docx b/sw/qa/extras/ooxmlimport/data/groupshape-sdt.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/indentation.docx b/sw/qa/extras/ooxmlimport/data/indentation.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/mce-wpg.docx b/sw/qa/extras/ooxmlimport/data/mce-wpg.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/n779630.docx b/sw/qa/extras/ooxmlimport/data/n779630.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/n820509.docx b/sw/qa/extras/ooxmlimport/data/n820509.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/n820788.docx b/sw/qa/extras/ooxmlimport/data/n820788.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/page-border-shadow.docx b/sw/qa/extras/ooxmlimport/data/page-border-shadow.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/table-auto-nested.docx b/sw/qa/extras/ooxmlimport/data/table-auto-nested.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/table-pagebreak.docx b/sw/qa/extras/ooxmlimport/data/table-pagebreak.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/table-style-parprop.docx b/sw/qa/extras/ooxmlimport/data/table-style-parprop.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/textbox-wps-only.docx b/sw/qa/extras/ooxmlimport/data/textbox-wps-only.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/vml-text-vertical-adjust.docx b/sw/qa/extras/ooxmlimport/data/vml-text-vertical-adjust.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/wpg-nested.docx b/sw/qa/extras/ooxmlimport/data/wpg-nested.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/ooxmlimport/data/wpg-only.docx b/sw/qa/extras/ooxmlimport/data/wpg-only.docx old mode 100755 new mode 100644 diff --git a/sw/qa/extras/rtfimport/data/fdo48440.rtf b/sw/qa/extras/rtfimport/data/fdo48440.rtf old mode 100755 new mode 100644 diff --git a/sw/qa/extras/rtfimport/data/fdo67365.rtf b/sw/qa/extras/rtfimport/data/fdo67365.rtf old mode 100755 new mode 100644 diff --git a/sw/qa/extras/rtfimport/data/n825305.rtf
[Libreoffice-commits] core.git: 7 commits - bridges/source ios/experimental ios/MobileLibreOffice ios/README ios/shared
bridges/source/cpp_uno/gcc3_ios_arm/cpp2uno-arm.cxx |
25 +
bridges/source/cpp_uno/gcc3_ios_arm/except.cxx |
129 +++---
bridges/source/cpp_uno/gcc3_ios_arm/generate-snippets.pl |
4
ios/MobileLibreOffice/MobileLibreOffice.xcodeproj/project.pbxproj|
6
ios/README |
30 ++
ios/experimental/LibreOffice/LibreOffice.xcodeproj/project.pbxproj |
8
ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj |
46 +++
ios/shared/ios_sharedlo.xcodeproj/project.pbxproj|
6
8 files changed, 201 insertions(+), 53 deletions(-)
New commits:
commit 0324a62e1977c60961cbf86e454e676d825a4e03
Author: Tor Lillqvist t...@collabora.com
Date: Mon Dec 23 11:29:14 2013 +0200
Add source files from bridges for quicker breakpoint setting
Change-Id: I7842d9d0e5786647d14d0c30be5230c05883ada2
diff --git
a/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
b/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
index f236daf..73dfcf8e 100644
---
a/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
+++
b/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
@@ -81,6 +81,25 @@
BE82BDAB182190E400A447B5 /* TiledView.m */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path
= TiledView.m; sourceTree = group; };
BE82BDAD1821A1D000A447B5 /* View.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
View.h; sourceTree = group; };
BE82BDAE1821A1D000A447B5 /* View.m */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path
= View.m; sourceTree = group; };
+ BE9F45F91868396500B8BE69 /* cpp2uno-arm.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name =
cpp2uno-arm.cxx; path =
../../../bridges/source/cpp_uno/gcc3_ios_arm/cpp2uno-arm.cxx; sourceTree =
group; };
+ BE9F45FA1868396500B8BE69 /* cpp2uno-arm64.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name =
cpp2uno-arm64.cxx; path =
../../../bridges/source/cpp_uno/gcc3_ios_arm/cpp2uno-arm64.cxx; sourceTree =
group; };
+ BE9F45FB1868396500B8BE69 /* cpp2uno-i386.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name =
cpp2uno-i386.cxx; path =
../../../bridges/source/cpp_uno/gcc3_ios_arm/cpp2uno-i386.cxx; sourceTree =
group; };
+ BE9F45FC1868396500B8BE69 /* cpp2uno.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = cpp2uno.cxx;
path = ../../../bridges/source/cpp_uno/gcc3_ios_arm/cpp2uno.cxx; sourceTree =
group; };
+ BE9F45FD1868396500B8BE69 /* except.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = except.cxx;
path = ../../../bridges/source/cpp_uno/gcc3_ios_arm/except.cxx; sourceTree =
group; };
+ BE9F45FE1868396500B8BE69 /* helper.s */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.asm; name = helper.s; path =
../../../bridges/source/cpp_uno/gcc3_ios_arm/helper.s; sourceTree = group;
};
+ BE9F45FF1868396500B8BE69 /* temp.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = temp.cxx; path
= ../../../bridges/source/cpp_uno/gcc3_ios_arm/temp.cxx; sourceTree =
group; };
+ BE9F46001868396500B8BE69 /* uno2cpp-arm.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name =
uno2cpp-arm.cxx; path =
../../../bridges/source/cpp_uno/gcc3_ios_arm/uno2cpp-arm.cxx; sourceTree =
group; };
+ BE9F46011868396500B8BE69 /* uno2cpp-arm64.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name =
uno2cpp-arm64.cxx; path =
../../../bridges/source/cpp_uno/gcc3_ios_arm/uno2cpp-arm64.cxx; sourceTree =
group; };
+ BE9F46021868396500B8BE69 /* uno2cpp-i386.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name =
uno2cpp-i386.cxx; path =
../../../bridges/source/cpp_uno/gcc3_ios_arm/uno2cpp-i386.cxx; sourceTree =
group; };
+ BE9F46031868396500B8BE69 /* uno2cpp.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = uno2cpp.cxx;
path = ../../../bridges/source/cpp_uno/gcc3_ios_arm/uno2cpp.cxx; sourceTree =
group; };
+ BE9F4604186839C100B8BE69 /* bridge.cxx */ = {isa =
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = bridge.cxx;
path = ../../../bridges/source/cpp_uno/shared/bridge.cxx; sourceTree =
group; };
+ BE9F4605186839C100B8BE69 /* component.cxx */ = {isa =
PBXFileReference; lastKnownFileType =
fdo#45904 Java based API tests to C++
Hello everyone! I'm trying to look more closely this easy hack. But with no success. Can someone help me to start it? Or, if possible, give some example, or patch already commited? Thankyou in advance! Best Regards, -- Ricardo Montania ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 49120, which changed state. Bug 49120 Summary: FILESAVE: LibreOffice corrupts XLSX file https://bugs.freedesktop.org/show_bug.cgi?id=49120 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: svl/source
svl/source/notify/broadcast.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 4de5ed0a90666e07c08997353d717553e5181fe1
Author: Eike Rathke er...@redhat.com
Date: Mon Dec 23 13:04:15 2013 +0100
iterators are not pointers
Change-Id: Ic9809beead66cf0d0e6a6a28bb97b220fb667578
diff --git a/svl/source/notify/broadcast.cxx b/svl/source/notify/broadcast.cxx
index 8d3905a..425a1e2 100644
--- a/svl/source/notify/broadcast.cxx
+++ b/svl/source/notify/broadcast.cxx
@@ -79,7 +79,7 @@ SvtBroadcaster::SvtBroadcaster( const SvtBroadcaster rBC ) :
Normalize();
ListenersType::iterator dest(maDestructedListeners.begin());
-for (ListenersType::iterator it(maListeners.begin()); it
maListeners.end(); ++it)
+for (ListenersType::iterator it(maListeners.begin()); it !=
maListeners.end(); ++it)
{
bool bStart = true;
@@ -108,7 +108,7 @@ SvtBroadcaster::~SvtBroadcaster()
// listeners, with the exception of those that already asked to be removed
// during their own destruction
ListenersType::iterator dest(maDestructedListeners.begin());
-for (ListenersType::iterator it(maListeners.begin()); it
maListeners.end(); ++it)
+for (ListenersType::iterator it(maListeners.begin()); it !=
maListeners.end(); ++it)
{
// skip the destructed ones
while (dest != maDestructedListeners.end() (*dest *it))
@@ -124,7 +124,7 @@ void SvtBroadcaster::Broadcast( const SfxHint rHint )
Normalize();
ListenersType::iterator dest(maDestructedListeners.begin());
-for (ListenersType::iterator it(maListeners.begin()); it
maListeners.end(); ++it)
+for (ListenersType::iterator it(maListeners.begin()); it !=
maListeners.end(); ++it)
{
// skip the destructed ones
while (dest != maDestructedListeners.end() (*dest *it))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
My Windows build is much slower than Linux build. Any way to speed up?
Hello, I am new to LibreOffice. Recently, I downloaded the code and started my build. At first, I built under Linux, which simply git, apt-get those library, autogen and make. It worked like a charm. Then I switched to Windows build. I noticed that it builds more things than Linux build does(Like unit test). And it's much SLOWER! Is there any way to speed up windows build? I used precompiled header in my autogen.sh, I also use the correct make(3.82) from libreoffice build tool, and set parallels parameter to 4(make -j 4). Any way to disable the build of unit tests? I've searched through the help to autgen, and found nothing. -- yours sincerely, Jeff ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 49120, which changed state. Bug 49120 Summary: FILESAVE: LibreOffice corrupts XLSX file https://bugs.freedesktop.org/show_bug.cgi?id=49120 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] help.git: helpers/help_hid.lst
helpers/help_hid.lst |1 - 1 file changed, 1 deletion(-) New commits: commit 458e6f18f0a93701748ef8754dc6f4acd7d2aaf0 Author: Caolán McNamara caol...@redhat.com Date: Mon Dec 23 13:03:32 2013 + drop unused help id Change-Id: I232957cb7b8e628f6efae9311ca0c8f90b216d8c diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst index 5d49d97..13382a5 100644 --- a/helpers/help_hid.lst +++ b/helpers/help_hid.lst @@ -1444,7 +1444,6 @@ HID_DLG_FILTER_SELECT,35842, HID_DLG_FLDEDT_ADDRESS,53061, HID_DLG_FLDEDT_NEXT,53059, HID_DLG_FLDEDT_PREV,53060, -HID_DLG_LOGIN,35838, HID_DLG_MAPPING,34842, HID_DLG_NAME,33818, HID_DLG_NEWERVERSIONWARNING,35848, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b7f9d7fb4dcac9e4b06690dca31a204677d68618 Author: Caolán McNamara caol...@redhat.com Date: Mon Dec 23 13:03:32 2013 + Updated core Project: help 458e6f18f0a93701748ef8754dc6f4acd7d2aaf0 diff --git a/helpcontent2 b/helpcontent2 index 5829091..458e6f1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 58290910e1d6ba8ac331281281e9c40cf7b24664 +Subproject commit 458e6f18f0a93701748ef8754dc6f4acd7d2aaf0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: uui/AllLangResTarget_uui.mk uui/source uui/uiconfig uui/UIConfig_uui.mk
uui/AllLangResTarget_uui.mk |1
uui/UIConfig_uui.mk |1
uui/source/iahndl-authentication.cxx |4
uui/source/ids.hrc |8
uui/source/logindlg.cxx | 261 +++
uui/source/logindlg.hrc | 52 -
uui/source/logindlg.hxx | 69 +++
uui/source/logindlg.src | 185 ---
uui/uiconfig/ui/logindialog.ui | 338 +++
9 files changed, 444 insertions(+), 475 deletions(-)
New commits:
commit 190e66534868e6ed553150282d95381f5dd5f51a
Author: Caolán McNamara caol...@redhat.com
Date: Mon Dec 23 12:52:49 2013 +
convert login dialog to .ui
Change-Id: I775c87422f05552b7283f9c6f7103a72262f764e
diff --git a/uui/AllLangResTarget_uui.mk b/uui/AllLangResTarget_uui.mk
index 17e29b2..a0238f1 100644
--- a/uui/AllLangResTarget_uui.mk
+++ b/uui/AllLangResTarget_uui.mk
@@ -26,7 +26,6 @@ $(eval $(call gb_SrsTarget_add_files,uui/res,\
uui/source/fltdlg.src \
uui/source/ids.src \
uui/source/lockfailed.src \
- uui/source/logindlg.src \
uui/source/nameclashdlg.src \
uui/source/newerverwarn.src \
uui/source/openlocked.src \
diff --git a/uui/UIConfig_uui.mk b/uui/UIConfig_uui.mk
index 6c33a2c..df6d3e8 100644
--- a/uui/UIConfig_uui.mk
+++ b/uui/UIConfig_uui.mk
@@ -10,6 +10,7 @@
$(eval $(call gb_UIConfig_UIConfig,uui))
$(eval $(call gb_UIConfig_add_uifiles,uui,\
+ uui/uiconfig/ui/logindialog \
uui/uiconfig/ui/masterpassworddlg \
uui/uiconfig/ui/setmasterpassworddlg \
uui/uiconfig/ui/sslwarndialog \
diff --git a/uui/source/iahndl-authentication.cxx
b/uui/source/iahndl-authentication.cxx
index 0f5f728..e1868c6 100644
--- a/uui/source/iahndl-authentication.cxx
+++ b/uui/source/iahndl-authentication.cxx
@@ -87,9 +87,8 @@ executeLoginDialog(
if (!bCanUseSysCreds)
nFlags |= LF_NO_USESYSCREDS;
-boost::scoped_ptr ResMgr xManager(ResMgr::CreateResMgr(uui));
boost::scoped_ptr LoginDialog xDialog(
-new LoginDialog( pParent, nFlags, rInfo.GetServer(), rRealm,
xManager.get()));
+new LoginDialog(pParent, nFlags, rInfo.GetServer(), rRealm));
if (!rInfo.GetErrorText().isEmpty())
xDialog-SetErrorText(rInfo.GetErrorText());
xDialog-SetName(rInfo.GetUserName());
@@ -101,6 +100,7 @@ executeLoginDialog(
if (bSavePassword)
{
+boost::scoped_ptr ResMgr xManager(ResMgr::CreateResMgr(uui));
xDialog-SetSavePasswordText(
ResId(rInfo.GetIsRememberPersistent()
? RID_SAVE_PASSWORD
diff --git a/uui/source/ids.hrc b/uui/source/ids.hrc
index 9385d5c..c40067b6 100644
--- a/uui/source/ids.hrc
+++ b/uui/source/ids.hrc
@@ -153,19 +153,11 @@
#define ERRCODE_UUI_SSLWARN_INVALID_1 (ERRCODE_AREA_UUI_UNKNOWNAUTH +
SSLWARN_TYPE_INVALID + 1)
#define TITLE_UUI_SSLWARN_INVALID (ERRCODE_AREA_UUI_UNKNOWNAUTH +
SSLWARN_TYPE_INVALID + 3)
-#define HID_DLG_LOGIN
UUI_HID_DLG_LOGIN
#define HID_DLG_FILTER_SELECT
UUI_HID_DLG_FILTER_SELECT
#define HID_DLG_PASSWORD_UUI
UUI_HID_DLG_PASSWORD_UUI
#define HID_XMLSECDLG_MACROWARN
UUI_HID_XMLSECDLG_MACROWARN
#define HID_DLG_NEWERVERSIONWARNING
UUI_HID_DLG_NEWERVERSIONWARNING
-#define HID_LOGIN_DLG_PATH UUI_HID_LOGIN_DLG_PATH
-#define HID_LOGIN_DLG_BROWSEUUI_HID_LOGIN_DLG_BROWSE
-#define HID_LOGIN_DLG_USER_NAME UUI_HID_LOGIN_DLG_USER_NAME
-#define HID_LOGIN_DLG_PASSWORD UUI_HID_LOGIN_DLG_PASSWORD
-#define HID_LOGIN_DLG_ACCOUNT UUI_HID_LOGIN_DLG_ACCOUNT
-#define HID_LOGIN_DLG_REMEMBER_PASSWORD
UUI_HID_LOGIN_DLG_REMEMBER_PASSWORD
-#define HID_LOGIN_DLG_USE_SYSTEM_CREDENTIALS
UUI_HID_LOGIN_DLG_USE_SYSTEM_CREDENTIALS
#define HID_DLG_SIMPLE_NAME_CLASH UUI_HID_DLG_SIMPLE_NAME_CLASH
#endif // UUI_IDS_HRC
diff --git a/uui/source/logindlg.cxx b/uui/source/logindlg.cxx
index 8d9d96a..3775cc4 100644
--- a/uui/source/logindlg.cxx
+++ b/uui/source/logindlg.cxx
@@ -21,7 +21,6 @@
#include vcl/msgbox.hxx
#include logindlg.hxx
-#include logindlg.hrc
#include ids.hrc
#include tools/resid.hxx
#include osl/file.hxx
@@ -37,175 +36,78 @@
using namespace com::sun::star;
-static void lcl_Move( Window rWin, long nOffset )
-{
-Point aTmp( rWin.GetPosPixel() );
-aTmp.Y() -= nOffset;
-rWin.SetPosPixel( aTmp );
-}
-
-
void LoginDialog::HideControls_Impl( sal_uInt16 nFlags )
{
-bool bPathHide = sal_False;
-bool bErrorHide = sal_False;
-bool bAccountHide = sal_False;
-bool bUseSysCredsHide = sal_False;
-
if ( ( nFlags LF_NO_PATH ) == LF_NO_PATH
Re: My Windows build is much slower than Linux build. Any way to speed up?
Hi Jeff, On Mon, 2013-12-23 at 20:10 +0800, Jeff Cai wrote: I am new to LibreOffice. Recently, I downloaded the code and started my build. At first, I built under Linux, which simply git, apt-get those library, autogen and make. It worked like a charm. Good :-) Then I switched to Windows build. I noticed that it builds more things than Linux build does(Like unit test). And it's much SLOWER! Linux builds the same unit test, but they run headless so you just don't see them :-) Also the unit tests on Windows are more valuable since there are many fewer developers there. Is there any way to speed up windows build ? You can disable link time optimisation with a configure option, that probably helps quite a bit, and of course you can turn off debugging symbols - that may also help - though both clearly have costs for debugging / runtime performance. I used precompiled header in my autogen.sh, I also use the correct make(3.82) from libreoffice build tool, and set parallels parameter to 4(make -j 4). Yep - the state of the cygwin build MSVC compiler is really rather appalling there, clearly even working out what is wrong with MSVC is hard. Kohei had some data point around the new templates in the string header taking a long time to compile: I wonder whether we could make those Linux-only, and use a 'const char *' constructor on Windows (which may speed things up). Any way to disable the build of unit tests? I've searched through the help to autgen, and found nothing. There is but it's deliberately hard to find ;-) it's not good for the health of your build. If you are doing an incremental build; it's far better to do eg. 'make sc' to just re-build calc. HTH, Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: fdo#45904 Java based API tests to C++
This commit is an example of converting a Java unit test to a Python unit test: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3c0a9bb59ed19b2f4492defd84d023c5e169d777 Maybe that will help. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: My Windows build is much slower than Linux build. Any way to speed up?
Then I switched to Windows build. I noticed that it builds more things than Linux build does(Like unit test). Actually, unit tests are run on Linux, too. Most of the developers use Linux as their daily platform, so naturally unit tests are written initially for Linux. And it's much SLOWER! Yes. You just need to improve your patience. Any way to disable the build of unit tests? That would be very counter-productive. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/unocoll.hxx |2 -
sw/source/filter/ww8/docxattributeoutput.cxx | 34 +--
sw/source/filter/ww8/docxattributeoutput.hxx |2 +
3 files changed, 35 insertions(+), 3 deletions(-)
New commits:
commit 9e118293188607ac883ed65754aaccc9ef2c6abb
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Dec 23 14:16:01 2013 +0100
sw: drawingml export of textframe gradients
CppunitTest_sw_ooxmlexport's testTextframeGradient is a reproducer for
this problem.
Change-Id: I8a0a1e8728cd82d96bdc7167e57cae72932429c5
diff --git a/sw/inc/unocoll.hxx b/sw/inc/unocoll.hxx
index b3e77dc..29a95bd 100644
--- a/sw/inc/unocoll.hxx
+++ b/sw/inc/unocoll.hxx
@@ -308,7 +308,7 @@ cppu::WeakImplHelper4
::com::sun::star::lang::XServiceInfo
SwXFramesBaseClass;
-class SwXFrames : public SwXFramesBaseClass,
+class SW_DLLPUBLIC SwXFrames : public SwXFramesBaseClass,
public SwUnoCollection
{
const FlyCntTypeeType;
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 29a6cd4..99bba6d 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -31,6 +31,8 @@
#include fmtruby.hxx
#include breakit.hxx
#include redline.hxx
+#include unocoll.hxx
+#include unoframe.hxx
#include comphelper/string.hxx
#include oox/token/tokens.hxx
@@ -5800,12 +5802,15 @@ void DocxAttributeOutput::FormatBackground( const
SvxBrushItem rBrush )
void DocxAttributeOutput::FormatFillStyle( const XFillStyleItem rFillStyle )
{
-m_oFillStyle.reset(rFillStyle.GetValue());
+if (!m_bIgnoreNextFill)
+m_oFillStyle.reset(rFillStyle.GetValue());
+else
+m_bIgnoreNextFill = false;
}
void DocxAttributeOutput::FormatFillGradient( const XFillGradientItem
rFillGradient )
{
-if (*m_oFillStyle == XFILL_GRADIENT)
+if (m_oFillStyle *m_oFillStyle == XFILL_GRADIENT
!m_bDMLTextFrameSyntax)
{
if ( !m_pFlyFillAttrList )
m_pFlyFillAttrList = m_pSerializer-createAttrList();
@@ -5849,11 +5854,35 @@ void DocxAttributeOutput::FormatFillGradient( const
XFillGradientItem rFillGrad
m_pFlyAttrList-add(XML_fillcolor , # + sColor1);
m_pFlyFillAttrList-add(XML_color2, # + sColor2);
}
+else if (m_oFillStyle *m_oFillStyle == XFILL_GRADIENT
m_bDMLTextFrameSyntax)
+{
+uno::Referencebeans::XPropertySet xPropertySet =
SwXFrames::GetObject(const_castSwFrmFmt(m_rExport.mpParentFrame-GetFrmFmt()),
FLYCNTTYPE_FRM);
+m_rDrawingML.SetFS(m_pSerializer);
+m_rDrawingML.WriteGradientFill(xPropertySet);
+}
m_oFillStyle.reset();
}
void DocxAttributeOutput::FormatBox( const SvxBoxItem rBox )
{
+if (m_bDMLTextFrameSyntax)
+{
+// a:gradFill should be before a:ln.
+const SfxPoolItem* pItem = GetExport().HasItem(RES_FILL_STYLE);
+if (pItem)
+{
+const XFillStyleItem* pFillStyle = static_castconst
XFillStyleItem*(pItem);
+FormatFillStyle(*pFillStyle);
+}
+
+pItem = GetExport().HasItem(RES_FILL_GRADIENT);
+if (pItem)
+{
+const XFillGradientItem* pFillGradient = static_castconst
XFillGradientItem*(pItem);
+FormatFillGradient(*pFillGradient);
+}
+m_bIgnoreNextFill = true;
+}
if (m_bTextFrameSyntax || m_bDMLTextFrameSyntax)
{
const SvxBorderLine* pLeft = rBox.GetLeft( );
@@ -6314,6 +6343,7 @@ DocxAttributeOutput::DocxAttributeOutput( DocxExport
rExport, FSHelperPtr pSeri
m_nextFontId( 1 ),
m_tableReference(new TableReference()),
m_oldTableReference(new TableReference()),
+ m_bIgnoreNextFill(false),
m_bBtLr(false),
m_bFrameBtLr(false),
m_pTableStyleExport(new DocxTableStyleExport(rExport.pDoc, pSerializer)),
diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx
b/sw/source/filter/ww8/docxattributeoutput.hxx
index a2a3977..fb75459 100644
--- a/sw/source/filter/ww8/docxattributeoutput.hxx
+++ b/sw/source/filter/ww8/docxattributeoutput.hxx
@@ -801,6 +801,8 @@ private:
std::vectorww8::WW8TableNodeInfoInner::Pointer_t tableFirstCells;
boost::optionalXFillStyle m_oFillStyle;
+/// If FormatBox() already handled fill style / gradient.
+bool m_bIgnoreNextFill;
/// Is fake rotation detected, so rotation with 90 degrees should be
ignored in this cell?
bool m_bBtLr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: My Windows build is much slower than Linux build. Any way to speed up?
Hi *,
On Mon, Dec 23, 2013 at 2:09 PM, Michael Meeks
michael.me...@collabora.com wrote:
On Mon, 2013-12-23 at 20:10 +0800, Jeff Cai wrote:
[Windows build much slower than on linux]
[...]
I used precompiled header in my autogen.sh, I also use the correct
make(3.82) from libreoffice build tool, and set parallels parameter to
4(make -j 4).
You shouldn't need tomanually set -j4 on the commandline, configure
will set it to the number of processors/cores.
Yep - the state of the cygwin build MSVC compiler is really rather
appalling there, clearly even working out what is wrong with MSVC is
hard.
It's not so much about the compiler (at least not all of it). But esp.
when you build with additional languages, then the
build-system-wrapper stuff is what seriously impacts build performance
on windows.
Just compare
mkdir foo ; cd foo
time touch {1..1000}
with
mkdir foo; cd foo
time for i in {1..1000}; do touch $i ; done
While on linux there's no real difference, on windows this is more
than an order of magnitude...(and the build system does the equivalent
of the latter a lot)
Of course windows cannot make (reliable) use of ccache - and
definitely not in combination with precompiled headers, so that's
where the compiler comes into play..
ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: fdo#45904 Java based API tests to C++
Hey, On Mon, Dec 23, 2013 at 12:13 PM, Ricardo Montania rmcam...@libreoffice.org wrote: Hello everyone! I'm trying to look more closely this easy hack. But with no success. Can someone help me to start it? Or, if possible, give some example, or patch already commited? Thankyou in advance! Best Regards, So basically I'm not a big fan of the python tests and prefer to write the failing tests in C++ instead of python. I already provided some code pointers in the bug report so here are just some commits. Please ask more questions if you need them. From some API tests that Laurent wrote after he fixed a bug: http://cgit.freedesktop.org/libreoffice/core/commit/?id=654e275fc673b28ac264f10282a4cd3a9f61a45d http://cgit.freedesktop.org/libreoffice/core/commit/?id=f992400f6fec9c0178bddb83dbc859848221b659 http://cgit.freedesktop.org/libreoffice/core/commit/?id=d75042329e7dd9bcc6d355ca19f556f144e93492 http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7c69a1d87bfa168cf4a41588843dff6704eea2f http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bf016694e8df63e20e530f9880e87de567dc7e1 http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab3f74fbea0337b006230a04f215d95a15ab254a Just look at one of the disabled API tests and ask for more details if you need more information. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - sw/qa sw/source writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport.cxx |7 +++-
sw/source/filter/ww8/docxattributeoutput.cxx | 40 ---
writerfilter/source/ooxml/model.xml |4 +-
3 files changed, 25 insertions(+), 26 deletions(-)
New commits:
commit beb7c8db7b922f7ca76d0093e199282489b7c49b
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Dec 23 15:01:58 2013 +0100
writerfilter: handle moveFromRangeEnd / moveToRangeEnd like bookmark end
For bookmarks, at the start we omit all attributes (name, id), and at
the end we emit only the id. Do the same for moveFromRangeEnd /
moveToRangeEnd, which didn't emit an id at the end before.
This is just the tokenizer part, dmapper should still handle them, which
is missing.
Change-Id: I3f42fdbd86785adb36a8ef1bffe9af14c4d81fa2
diff --git a/writerfilter/source/ooxml/model.xml
b/writerfilter/source/ooxml/model.xml
index 804a9ad..4eec1ed 100644
--- a/writerfilter/source/ooxml/model.xml
+++ b/writerfilter/source/ooxml/model.xml
@@ -14800,13 +14800,13 @@
ref name=CT_MoveBookmark/
/element
element name=moveFromRangeEnd
-ref name=CT_MarkupRange/
+ref name=CT_MarkupRangeBookmark/
/element
element name=moveToRangeStart
ref name=CT_MoveBookmark/
/element
element name=moveToRangeEnd
-ref name=CT_MarkupRange/
+ref name=CT_MarkupRangeBookmark/
/element
element name=commentRangeStart
ref name=CT_MarkupRangeCommentStart/
commit 41927dce4217d60808a889f8dac546f55848eead
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Dec 23 14:25:37 2013 +0100
sw: enable drawingml export of textframes by default
This was only available in experimental mode previously. Also note that
export of shapes (including group shapes) was already enabled
previously, this commit just enables the same for Writer Text Frames.
Change-Id: I53e7f3fac84328cea316a9811ecd5eecec79b23d
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 11d962a..10ab77b 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -1116,7 +1116,7 @@ DECLARE_OOXMLEXPORT_TEST(testTableFloatingMargins,
table-floating-margins.docx
xmlDocPtr pXmlDoc = parseExport();
if (!pXmlDoc)
return;
-assertXPath(pXmlDoc,
/w:document/w:body/w:p/w:r/w:pict/v:rect/v:textbox/w:txbxContent/w:tbl/w:tr[1]/w:tc[1]/w:p/w:pPr/w:spacing,
after, 0);
+assertXPath(pXmlDoc,
/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Fallback/w:pict/v:rect/v:textbox/w:txbxContent/w:tbl/w:tr[1]/w:tc[1]/w:p/w:pPr/w:spacing,
after, 0);
}
DECLARE_OOXMLEXPORT_TEST(testFdo44689_start_page_0,
fdo44689_start_page_0.docx)
@@ -1549,7 +1549,10 @@ DECLARE_OOXMLEXPORT_TEST(testFdo69636, fdo69636.docx)
xmlDocPtr pXmlDoc = parseExport();
if (!pXmlDoc)
return;
-CPPUNIT_ASSERT(getXPath(pXmlDoc,
/w:document/w:body/w:p/w:r/w:pict/v:rect/v:textbox,
style).match(mso-layout-flow-alt:bottom-to-top));
+// VML
+CPPUNIT_ASSERT(getXPath(pXmlDoc,
/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Fallback/w:pict/v:rect/v:textbox,
style).match(mso-layout-flow-alt:bottom-to-top));
+// drawingML
+assertXPath(pXmlDoc,
/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Choice/w:drawing/wp:anchor/a:graphic/a:graphicData/wps:wsp/wps:bodyPr,
vert, vert270);
}
DECLARE_OOXMLEXPORT_TEST(testCharHighlight, char_highlight.docx)
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 99bba6d..20cdf08 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -510,28 +510,24 @@ void DocxAttributeOutput::EndParagraph(
ww8::WW8TableNodeInfoInner::Pointer_t pT
{
sw::Frame* pParentFrame = aParentFrames[i];
m_pSerializer-startElementNS( XML_w, XML_r, FSEND );
-SvtMiscOptions aMiscOptions;
-if (aMiscOptions.IsExperimentalMode())
-{
-m_pSerializer-startElementNS(XML_mc, XML_AlternateContent, FSEND);
-m_pSerializer-startElementNS(XML_mc, XML_Choice,
-XML_Requires, wps,
-FSEND);
-WriteDMLTextFrame(pParentFrame);
-m_pSerializer-endElementNS(XML_mc, XML_Choice);
-
-// Reset table infos, otherwise the depth of the cells will be
incorrect,
-// in case the text frame had table(s) and we try to export the
-// same table second time.
-m_rExport.mpTableInfo = ww8::WW8TableInfo::Pointer_t(new
ww8::WW8TableInfo());
-
-m_pSerializer-startElementNS(XML_mc, XML_Fallback, FSEND);
-WriteVMLTextFrame(pParentFrame);
-m_pSerializer-endElementNS(XML_mc, XML_Fallback);
-
What parameters to supply to autogen.sh
For the build, Linux - rpm (x86), version 4.1.4, English (US), that appears on the Download page what parameters would have been supplied to autogen.sh to build it? Regards Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: What parameters to supply to autogen.sh
On Mon, Dec 23, 2013 at 02:21:13PM +, mcmurchy1917-libreoff...@yahoo.co.uk wrote: For the build, Linux - rpm (x86), version 4.1.4, English (US), that appears on the Download page what parameters would have been supplied to autogen.sh to build it? AFAIK, --with-distro=LibreOfficeLinux.conf which reads the file http://cgit.freedesktop.org/libreoffice/core/tree/distro-configs/LibreOfficeLinux.conf?id=libreoffice-4.1.4.2 and uses the switches there. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/docxattributeoutput.cxx | 273 +++
sw/source/filter/ww8/docxattributeoutput.hxx |3
2 files changed, 119 insertions(+), 157 deletions(-)
New commits:
commit 5d3b3b9fc15bac8bba286e64a6a0e28f2dbb8529
Author: Jacobo Aragunde Pérez jaragu...@igalia.com
Date: Mon Dec 23 11:13:19 2013 +0100
sw: small code refactor
Created method DocxAttributeOutput::AddToAttrList which encapsulates
a piece of code that was widely repeated in that class:
if( some attribute list does not exist )
create the list
add some value to the list
add some other value to the list
Change-Id: Ibef031395927a7cedbf84a372008cb2e2677ae36
Reviewed-on: https://gerrit.libreoffice.org/7187
Reviewed-by: Jacobo Aragunde Pérez jaragu...@igalia.com
Tested-by: Jacobo Aragunde Pérez jaragu...@igalia.com
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Miklos Vajna vmik...@collabora.co.uk
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 20cdf08..3a5c9d4 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -4314,10 +4314,7 @@ void DocxAttributeOutput::CharColor( const SvxColorItem
rColor )
aColorString = msfilter::util::ConvertColor( aColor );
-if( !m_pColorAttrList )
-m_pColorAttrList = m_pSerializer-createAttrList();
-
-m_pColorAttrList-add( FSNS( XML_w, XML_val ), aColorString.getStr() );
+AddToAttrList( m_pColorAttrList, FSNS( XML_w, XML_val ),
aColorString.getStr() );
}
void DocxAttributeOutput::CharContour( const SvxContourItem rContour )
@@ -4386,13 +4383,12 @@ void DocxAttributeOutput::CharEscapement( const
SvxEscapementItem rEscapement )
void DocxAttributeOutput::CharFont( const SvxFontItem rFont)
{
-if (!m_pFontsAttrList)
-m_pFontsAttrList = m_pSerializer-createAttrList();
GetExport().GetId( rFont ); // ensure font info is written to fontTable.xml
OUString sFontName(rFont.GetFamilyName());
OString sFontNameUtf8 = OUStringToOString(sFontName,
RTL_TEXTENCODING_UTF8);
-m_pFontsAttrList-add(FSNS(XML_w, XML_ascii), sFontNameUtf8);
-m_pFontsAttrList-add(FSNS(XML_w, XML_hAnsi), sFontNameUtf8);
+AddToAttrList( m_pFontsAttrList, 2,
+FSNS( XML_w, XML_ascii ), sFontNameUtf8.getStr(),
+FSNS( XML_w, XML_hAnsi ), sFontNameUtf8.getStr() );
}
void DocxAttributeOutput::CharFontSize( const SvxFontHeightItem rFontSize)
@@ -4419,9 +4415,6 @@ void DocxAttributeOutput::CharKerning( const
SvxKerningItem rKerning )
void DocxAttributeOutput::CharLanguage( const SvxLanguageItem rLanguage )
{
-if (!m_pCharLangAttrList)
-m_pCharLangAttrList = m_pSerializer-createAttrList();
-
OString aLanguageCode( OUStringToOString(
LanguageTag( rLanguage.GetLanguage()).getBcp47(),
RTL_TEXTENCODING_UTF8));
@@ -4429,13 +4422,13 @@ void DocxAttributeOutput::CharLanguage( const
SvxLanguageItem rLanguage )
switch ( rLanguage.Which() )
{
case RES_CHRATR_LANGUAGE:
-m_pCharLangAttrList-add(FSNS(XML_w, XML_val), aLanguageCode);
+AddToAttrList( m_pCharLangAttrList, FSNS( XML_w, XML_val ),
aLanguageCode.getStr() );
break;
case RES_CHRATR_CJK_LANGUAGE:
-m_pCharLangAttrList-add(FSNS(XML_w, XML_eastAsia), aLanguageCode);
+AddToAttrList( m_pCharLangAttrList, FSNS( XML_w, XML_eastAsia ),
aLanguageCode.getStr() );
break;
case RES_CHRATR_CTL_LANGUAGE:
-m_pCharLangAttrList-add(FSNS(XML_w, XML_bidi), aLanguageCode);
+AddToAttrList( m_pCharLangAttrList, FSNS( XML_w, XML_bidi ),
aLanguageCode.getStr() );
break;
}
}
@@ -4546,11 +4539,9 @@ void DocxAttributeOutput::CharBackground( const
SvxBrushItem rBrush )
void DocxAttributeOutput::CharFontCJK( const SvxFontItem rFont )
{
-if (!m_pFontsAttrList)
-m_pFontsAttrList = m_pSerializer-createAttrList();
OUString sFontName(rFont.GetFamilyName());
OString sFontNameUtf8 = OUStringToOString(sFontName,
RTL_TEXTENCODING_UTF8);
-m_pFontsAttrList-add(FSNS(XML_w, XML_eastAsia), sFontNameUtf8);
+AddToAttrList( m_pFontsAttrList, FSNS( XML_w, XML_eastAsia ),
sFontNameUtf8.getStr() );
}
void DocxAttributeOutput::CharPostureCJK( const SvxPostureItem rPosture )
@@ -4571,11 +4562,9 @@ void DocxAttributeOutput::CharWeightCJK( const
SvxWeightItem rWeight )
void DocxAttributeOutput::CharFontCTL( const SvxFontItem rFont )
{
-if (!m_pFontsAttrList)
-m_pFontsAttrList = m_pSerializer-createAttrList();
OUString sFontName(rFont.GetFamilyName());
OString sFontNameUtf8 = OUStringToOString(sFontName,
RTL_TEXTENCODING_UTF8);
-m_pFontsAttrList-add(FSNS(XML_w, XML_cs),
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sax/source
sax/source/fastparser/fastparser.cxx | 271 ---
1 file changed, 131 insertions(+), 140 deletions(-)
New commits:
commit 0b4f41eb0ee0fdcb22403f943f8f34911a463cb6
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Dec 20 16:18:48 2013 +
fastparser: fix load regression
Remove erroneous assert: maSavedException is indeed empty for
XML parser reported exceptions. Clean cut/paste code, and comment.
Cleanup conflicts, and squash subsequent fixup patches too.
Change-Id: Ia538bcc87a7efcd079d3021e00ac4d2eb62f3e8d
diff --git a/sax/source/fastparser/fastparser.cxx
b/sax/source/fastparser/fastparser.cxx
index 4f835d5..88bef41 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -56,8 +56,9 @@ using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::xml::sax;
using namespace ::com::sun::star::io;
using namespace com::sun::star;
+using namespace sax_fastparser;
-namespace sax_fastparser {
+namespace {
struct Event;
class FastLocatorImpl;
@@ -75,12 +76,12 @@ enum CallbackType { INVALID, START_ELEMENT, END_ELEMENT,
CHARACTERS, DONE, EXCEP
struct Event
{
-OUString msChars;
+CallbackType maType;
sal_Int32 mnElementToken;
OUString msNamespace;
OUString msElementName;
rtl::Reference FastAttributeList mxAttributes;
-CallbackType maType;
+OUString msChars;
};
struct NameWithToken
@@ -163,9 +164,13 @@ struct Entity : public ParserData
XML_Parser mpParser;
::sax_expatwrap::XMLFile2UTFConverter maConverter;
-// Exceptions cannot be thrown through the C-XmlParser (possible resource
leaks),
-// therefore the exception must be saved somewhere.
-::com::sun::star::uno::Any maSavedException;
+// Exceptions cannot be thrown through the C-XmlParser (possible
+// resource leaks), therefore any exception thrown by a UNO callback
+// must be saved somewhere until the C-XmlParser is stopped.
+::com::sun::star::uno::Any maSavedException;
+void saveException( const Exception e );
+void throwException( const ::rtl::Reference FastLocatorImpl
xDocumentLocator,
+ bool mbDuringParse );
::std::stack NameWithTokenmaNamespaceStack;
/* Context for main thread consuming events.
@@ -186,9 +191,9 @@ struct Entity : public ParserData
Event getEvent( CallbackType aType );
};
-//
-// FastSaxParser implementation
-//
+} // namespace
+
+namespace sax_fastparser {
class FastSaxParserImpl
{
@@ -262,6 +267,10 @@ private:
FastTokenLookup maTokenLookup;
};
+} // namespace sax_fastparser
+
+namespace {
+
class ParserThread: public salhelper::Thread
{
FastSaxParserImpl *mpParser;
@@ -274,16 +283,15 @@ private:
{
mpParser-parse();
}
-catch (const SAXParseException)
+catch (const Exception e)
{
-mpParser-getEntity().getEvent( EXCEPTION );
+Entity rEntity = mpParser-getEntity();
+rEntity.getEvent( EXCEPTION );
mpParser-produce( EXCEPTION );
}
}
};
-}
-
extern C {
static void call_callbackStartElement(void *userData, const XML_Char *name ,
const XML_Char **atts)
@@ -323,8 +331,6 @@ static int call_callbackExternalEntityRef( XML_Parser
parser,
}
-namespace sax_fastparser {
-
//
// FastLocatorImpl
//
@@ -347,18 +353,6 @@ private:
FastSaxParserImpl *mpParser;
};
-//
-// FastSaxParser
-//
-
-//-
-// the implementation part
-//-
-
-
-//
-// FastLocatorImpl implementation
-//
sal_Int32 SAL_CALL FastLocatorImpl::getColumnNumber(void) throw
(RuntimeException)
{
@@ -477,7 +471,7 @@ void Entity::startElement( Event *pEvent )
}
catch (const Exception e)
{
-maSavedException = e;
+saveException( e );
}
}
@@ -490,7 +484,7 @@ void Entity::characters( const OUString sChars )
}
catch (const Exception e)
{
-maSavedException = e;
+saveException( e );
}
}
@@ -508,7 +502,7 @@ void Entity::endElement()
}
catch (const Exception e)
{
-maSavedException = e;
+saveException( e );
}
maContextStack.pop();
}
@@ -546,6 +540,97 @@ Event
Re: My Windows build is much slower than Linux build. Any way to speed up?
Hi,
On Mon, Dec 23, 2013 at 02:30:33PM +0100, Christian Lohmaier wrote:
Just compare
mkdir foo ; cd foo
time touch {1..1000}
with
mkdir foo; cd foo
time for i in {1..1000}; do touch $i ; done
While on linux there's no real difference, on windows this is more
than an order of magnitude...(and the build system does the equivalent
of the latter a lot)
Yes, AFAIK currently there are two main contributions to the build on windows
being slower:
- the MSVC compiler being slower itself
- process creation on windows (or cygwin or shell in cygwin) being slow (see
Clophs example about)
There isnt so much we can do about the first thing in a clean way. We can do
something about the second thing, e.g.:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=66a0713dc9c676182fcd7aa1e21f8dc25c05be5e
improved Windows build time by 10%. Some other things to consider doing for
Windows optimization:
- IIRC MSVC can compile multiple object files with one call.
Obviously all the compile flags etc. must be the same then for all objects to
create, but for cxx files from the same dir and for the same library this is
given. So one could e.g. always batch up 8 of such objects and compile them
with one call. But I fear this is adding a huge load of complexity to the
build, because:
- it IIRC does not generate per object dependency files then
- in incremental builds, you would only need to rebuild _some_ files -- so
you cant do the grouping of objects in some simple or static way (as you
would 'overrebuild' then)
- it also collides with parallelization in the build sytem -- if you put e.g.
always 8 object in one call and only have to rebuild 8 objects (a common
developer change), you would get no parallelization at all
- as noted in the comment above the touching of a file in cygwin took some
~250ms -- interestingly, this is not CPU-bound. A simplistic approach thus
would be, to just allways overcommit the build by some factor and see if it
improves the build time (or the CPU load).
Of course, the real issue is: what is this 250ms idle wait to touch a file from
cygwin about? If we know that we can likely workaround it. Maybe its cygwin
polling some network share for the cygwin-windows path mapping? So any
detective work on that might help:
- Can one make the delay go away by e.g. disabling network shares/virus
scanners/other services?
- Does this delay also appear when doing network-IO instead of file-IO
- If so, could we e.g. start a (native-Windows) Python demon that listens on a
network socket and hand it the commands to execute as be faster?
- Or, does it make sense to make the gbuild in cygwin dump e.g. output for the
ninja (the minimalistic build backend) and then have a (native windows) ninja
process execute this.
Finally, Michael Stahl is considering moving gbuild to work on a native windows
GNU make without the cygwin wrapper. But that likely is quite a bit of work.
So, you see there is a good bit to research (where does the 250 ms delay on
cygwin come from), to evaluate (batch builds, handing over to a native demon,
creating output for ninja, using native GNU make). TBH though, I fear most of
the hacks above -- with the exception of running native GNU make -- make the
build system even more complex and harder to maintain, so I am not convinced
that its an good idea to push for them without very well-funded research
covering all cases.
Best,
Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: oox/source
oox/source/export/shapes.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit c161ceb9056ca5f686e615965ae0bb3efd8acea7
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Dec 23 17:02:09 2013 +0100
oox: fix drawingml export of nested groupshapes
It turns out drawingml requires using different XML elements in case the
groupshape is a toplevel one or a nested one.
Change-Id: I9b76f9d0ae48cd80aaf0d6d41f1eb071cdc8cc07
diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index b2b39a4..4c7af94 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -246,7 +246,10 @@ ShapeExport ShapeExport::WriteOpenBezierShape( Reference
XShape xShape )
ShapeExport ShapeExport::WriteGroupShape(uno::Referencedrawing::XShape
xShape)
{
FSHelperPtr pFS = GetFS();
-pFS-startElementNS(mnXmlNamespace, XML_wgp, FSEND);
+bool bToplevel = !m_xParent.is();
+if (!bToplevel)
+mnXmlNamespace = XML_wpg;
+pFS-startElementNS(mnXmlNamespace, (bToplevel ? XML_wgp : XML_grpSp),
FSEND);
// non visual properties
pFS-singleElementNS(mnXmlNamespace, XML_cNvGrpSpPr, FSEND);
@@ -269,7 +272,7 @@ ShapeExport
ShapeExport::WriteGroupShape(uno::Referencedrawing::XShape xShape
}
m_xParent = xParent;
-pFS-endElementNS(mnXmlNamespace, XML_wgp);
+pFS-endElementNS(mnXmlNamespace, (bToplevel ? XML_wgp : XML_grpSp));
return *this;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: My Windows build is much slower than Linux build. Any way to speed up?
On Mon, Dec 23, 2013 at 9:15 AM, bjoern bjoern.michael...@canonical.com wrote:
There isnt so much we can do about the first thing in a clean way. We can do
something about the second thing, e.g.:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=66a0713dc9c676182fcd7aa1e21f8dc25c05be5e
btw:
+ else
+ {
+ fprintf(stderr, no magic for %s(%s) in %s\n, fn, src_relative, work_dir);
+ }
+ }
+ if(!rc)
+ {
+ puts(created_line); -- create_line is undefined here if we took
the else above
+ }
- as noted in the comment above the touching of a file in cygwin took some
~250ms -- interestingly, this is not CPU-bound. A simplistic approach thus
would be, to just allways overcommit the build by some factor and see if it
improves the build time (or the CPU load).
yep. I typically overcommit by at least 50%. for instance on my 8-core
Windows tinderbox I build with -j14
This is especially important as make 'leak' randomly some job-descriptor...
Of course, the real issue is: what is this 250ms idle wait to touch a file
from
cygwin about? If we know that we can likely workaround it. Maybe its cygwin
polling some network share for the cygwin-windows path mapping? So any
detective work on that might help:
There is a proposed patch series on gnu make to use
spawn() instead of fork() on cygwin... this has received significant
push-back from cygwin maintainers
as they say that spwan() support on cygwin is flaky since not often used...
- Can one make the delay go away by e.g. disabling network shares/virus
scanners/other services?
Yes, it has been reported on this ML, some time ago, that disabling
virus scanner for the lo build/source filenamespace is a big win
Finally, Michael Stahl is considering moving gbuild to work on a native
windows
GNU make without the cygwin wrapper. But that likely is quite a bit of work.
yep, that would be.. the 'easy' case of building plain cxx could be handled
by generating vxproj file based on what is in gbuild's makefile in a
fairly straight forward fashion
The more involved part is to deal with all the other special case.
That would prolly require developing 'custom build rule' in a vstudio
fashion for all the corner cases
from lex/yacc to idlc, xsltproc and all the l10n tooling
A lot of work indeed, on a very despicable platform.. so unless a
Windows fan combined with a skilled dev take that up (and that is a
very rare combo),
it is quite unlikely
Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Changes to 'feature/chart-opengl2'
New branch 'feature/chart-opengl2' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/relorientation.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 12
sw/source/filter/ww8/docxsdrexport.cxx|4
3 files changed, 16 insertions(+)
New commits:
commit 4e49887bee01133a349447a00341c0293f8a5899
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Dec 23 17:58:59 2013 +0100
DOCX export: fix relativeFrom=page, align=right handling
This is the export part of 51a61bd4aca15c860d301b687d582a39193089e2.
Change-Id: I9f7459e99ada8f5f73e9075d249c4e508c941d44
diff --git a/sw/qa/extras/ooxmlexport/data/relorientation.docx
b/sw/qa/extras/ooxmlexport/data/relorientation.docx
new file mode 100644
index 000..d71148b
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/relorientation.docx
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 10ab77b..15ca09e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -2163,6 +2163,18 @@
DECLARE_OOXMLEXPORT_TEST(testFileOpenInputOutputError,floatingtbl_with_formula.
assertXPath(pXmlDoc, /w:document/w:body/w:p[1]/w:pPr/w:pStyle, val,
Normal);
}
+DECLARE_OOXMLEXPORT_TEST(testRelorientation, relorientation.docx)
+{
+uno::Referencedrawing::XShape xShape = getShape(1);
+// This was text::RelOrientation::FRAME, when handling relativeFrom=page,
align=right
+CPPUNIT_ASSERT_EQUAL(text::RelOrientation::PAGE_RIGHT,
getPropertysal_Int16(xShape, HoriOrientRelation));
+
+uno::Referencedrawing::XShapes xGroup(xShape, uno::UNO_QUERY);
+// This resulted in lang::IndexOutOfBoundsException, as nested groupshapes
weren't handled.
+uno::Referencedrawing::XShapeDescriptor
xShapeDescriptor(xGroup-getByIndex(0), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString(com.sun.star.drawing.GroupShape),
xShapeDescriptor-getShapeType());
+}
+
#endif
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/ww8/docxsdrexport.cxx
b/sw/source/filter/ww8/docxsdrexport.cxx
index e030a81..a714e55 100644
--- a/sw/source/filter/ww8/docxsdrexport.cxx
+++ b/sw/source/filter/ww8/docxsdrexport.cxx
@@ -153,6 +153,10 @@ void DocxSdrExport::startDMLAnchorInline(const SwFrmFmt*
pFrmFmt, const Size rS
case text::RelOrientation::CHAR:
relativeFromH = character;
break;
+case text::RelOrientation::PAGE_RIGHT:
+relativeFromH = page;
+alignH = right;
+break;
case text::RelOrientation::FRAME:
default:
relativeFromH = column;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Efficient UNO component linkage GC ...
Hi Stephan, some great work, thanks. On Thu, 2013-12-19 at 10:51 +0100, Stephan Bergmann wrote: thought-dump: really helps :-) * assume all LO-internal C++ implementations are ComponentContext-based (i.e., use cppu::createSingleComponentFactory or cppu::createOneInstanceComponentFactory rather than legacy ServiceManager-based cppu::createSingleFactory or cppu::createOneInstanceFactory); reaching this state is effectively an easy hack Yep, but maybe we don't need special easy hack for this. So far, I was able to just remove the variables as unused. I think it's easy to do as part of creating constructor function for implementation. * implementations of non-single-instance services can be rewritten using the new .component XML implementation constructor=... feature, cf. http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae3a0c8da50b36db395984637f5ad74d3b4887bc Add .component implementation constructor='...' feature; this is effectively an easy hack (note that service manager's createInstanceWithArguments[andContext] no longer uses the css.lang.XInitialization protocol on those implementations) Hm, what does it mean, it no longer uses css.lang.XInitialization protocol? What to do about implementations inheriting from XInitialization? I tried to convert such class in https://gerrit.libreoffice.org/#/c/7186/ Does it look good ? If it's clear when to assert for arguments-nElements and what to do about initialize() we should create an easy hack for this I think. * for implementations of single-instance services/singletons, we can: Sorry, no opinion on this from me. ;-) ** note that there are always situations where UNO services are not called via constructor, though; e.g., the constructor-less css.uri.UriSchemeParser_* services are always created via dynamically computed name Ah, good to know we need to care about such cases. * idea is to set aside for every UNO service/singleton S two macros LO_URE_CTOR_ENV_S' and LO_URE_CTOR_FUN_S', and a macro LO_URE_CURRENT_ENV, and modify cppumaker to generate constructor code as #if defined LO_URE_CURRENT_ENV defined LO_URE_CTOR_ENV_S' \ defined LO_URE_CTOR_FUNS' LO_URE_CURRENT_ENV == LO_URE_CTOR_ENV_S' extern C cppu::ConstructorFunction_type LO_URE_CTOR_FUNS'; Is not LO_URE_CTOR_ENV_S' redundant ? We can just check for defined LO_URE_CTOR_FUNS' ? ** when compiling .cxx files for which it is known that the constructor function for some S will be visible (which could e.g. be ~always the case when compiling for a single big executable on Android/iOS), define the LO_URE_CTOR_ENV_S' and LO_URE_CTOR_FUN_S' macros, either via -D or via some strategically included header Yes, so this needs some thought. If I see correctly, there are already some typos in 15abebbde560e17413f17b16b8b2e9c1f31f01a5 like LO_URE_CTOR_FUN_com_dot_sun_dot_star_dot_xml_dot_sax_dot_FastParser vs. LO_URE_CTOR_FUN_com_dot_sun_dot_star_dot_comp_dot_extensions_dot_xml_dot_sax_dot_FastParser Unfortunately I can't see how to avoid these macros, so I'll try to generate include/osl/detail/component-defines.h early in build process. Do you have another idea ? Overall, this looks really good, Thanks, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/chart-opengl2' - formula/source include/formula sc/source
formula/source/core/api/FormulaCompiler.cxx |4 ++
include/formula/compiler.hrc|5 ++-
include/formula/opcode.hxx |1
sc/source/core/inc/interpre.hxx |1
sc/source/core/tool/compiler.cxx|4 +-
sc/source/core/tool/interpr4.cxx|1
sc/source/core/tool/interpr7.cxx| 40
7 files changed, 51 insertions(+), 5 deletions(-)
New commits:
commit 7d3e6d47b0e1cf8b666cd991575a6ac9da671ff0
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Fri Dec 20 19:57:28 2013 -0500
Add internal cell function __DEBUG_VAR to sniff arbitrary internal state.
Useful for debugging in a more flashy way. But never ever document this
for end users. If you are an end user reading this, use this at your
own risk. You have been warned.
Change-Id: Ibbdb45f576287f707106327704754ffaec27ba3c
diff --git a/formula/source/core/api/FormulaCompiler.cxx
b/formula/source/core/api/FormulaCompiler.cxx
index e8c40aa..1051b73 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -39,7 +39,7 @@ namespace formula
{
using namespace ::com::sun::star;
-static const sal_Char* pInternal[ 1 ] = { TTT };
+static const sal_Char* pInternal[2] = { TTT, __DEBUG_VAR };
namespace {
@@ -794,6 +794,8 @@ bool FormulaCompiler::IsOpCodeVolatile( OpCode eOp )
case ocIndirectXL:
// ocOffset results in indirect references.
case ocOffset:
+// ocDebugVar shows internal value that may change as the internal
state changes.
+case ocDebugVar:
bRet = true;
break;
default:
diff --git a/include/formula/compiler.hrc b/include/formula/compiler.hrc
index 9bda945..e11f825 100644
--- a/include/formula/compiler.hrc
+++ b/include/formula/compiler.hrc
@@ -442,10 +442,11 @@
/*** Internal ***/
#define SC_OPCODE_INTERNAL_BEGIN
#define SC_OPCODE_TTT
-#define SC_OPCODE_INTERNAL_END
+#define SC_OPCODE_DEBUG_VAR 1
+#define SC_OPCODE_INTERNAL_END1
/*** from here on ExtraData contained ***/
-#define SC_OPCODE_DATA_TOKEN_11
+#define SC_OPCODE_DATA_TOKEN_110001
#define SC_OPCODE_NONE 0x
diff --git a/include/formula/opcode.hxx b/include/formula/opcode.hxx
index 58f3d41..c86b3a3 100644
--- a/include/formula/opcode.hxx
+++ b/include/formula/opcode.hxx
@@ -432,6 +432,7 @@ enum OpCodeEnum
// internal stuff
ocInternalBegin = SC_OPCODE_INTERNAL_BEGIN,
ocTTT = SC_OPCODE_TTT,
+ocDebugVar = SC_OPCODE_DEBUG_VAR,
ocInternalEnd = SC_OPCODE_INTERNAL_END,
// from here on ExtraData
ocDataToken1= SC_OPCODE_DATA_TOKEN_1,
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index f8fc0e9..cc67580 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -563,6 +563,7 @@ void ScBitXor();
void ScBitRshift();
void ScBitLshift();
void ScTTT();
+void ScDebugVar();
/** Obtain the date serial number for a given date.
@param bStrict
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 496c151..7b1ef50 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -89,7 +89,7 @@ enum ScanState
ssStop
};
-static const sal_Char* pInternal[ 1 ] = { TTT };
+static const sal_Char* pInternal[2] = { TTT, __DEBUG_VAR };
using namespace ::com::sun::star::i18n;
@@ -3440,7 +3440,7 @@ bool ScCompiler::NextNewToken( bool bInArray )
bool bAsciiNonAlnum;// operators, separators, ...
if ( cSymbol[0] 128 )
{
-bMayBeFuncName = rtl::isAsciiAlpha( cSymbol[0] );
+bMayBeFuncName = rtl::isAsciiAlpha( cSymbol[0] ) || cSymbol[0] == '_';
bAsciiNonAlnum = !bMayBeFuncName !rtl::isAsciiDigit( cSymbol[0] );
}
else
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 6983d3e..c5ebbd3 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -4219,6 +4219,7 @@ StackVar ScInterpreter::Interpret()
case ocBitRshift: ScBitRshift();break;
case ocBitLshift: ScBitLshift();break;
case ocTTT : ScTTT(); break;
+case ocDebugVar : ScDebugVar(); break;
case ocNone : nFuncFmtType = NUMBERFORMAT_UNDEFINED;break;
default : PushError( errUnknownOpCode); break;
}
diff --git a/sc/source/core/tool/interpr7.cxx b/sc/source/core/tool/interpr7.cxx
index bb647c1..0bcf7ae 100644
--- a/sc/source/core/tool/interpr7.cxx
+++ b/sc/source/core/tool/interpr7.cxx
@@ -15,6 +15,8 @@
#include
Beginner
I want to start contributing to the open source community, but I do not where to begin. Your community's cause seems great! So I would love to start but I am absolutely clueless as to where to begin. I have a background in C++ and algorithmic operations. Any help would be appreciated! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/chart-opengl2' - download.lst
download.lst |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 88423db592ed7fb6253167b63e95443b678b3c95 Author: Michael Meeks michael.me...@collabora.com Date: Mon Dec 23 18:07:23 2013 + mend download.lst breakage Change-Id: Ia2295514ce32146f98497d3a4e3fbe634e3f64d4 diff --git a/download.lst b/download.lst index 224f40e..c9b3de3 100644 --- a/download.lst +++ b/download.lst @@ -55,7 +55,8 @@ export FONT_SOURCECODE_TARBALL := 0279a21fab6f245e85a6f85fea54f511-source-code-f export FONT_SOURCESANS_TARBALL := 1e9ddfe25ac9577da709d7b2ea36f939-source-sans-font-1.036.tar.gz export FREETYPE_TARBALL := dbf2caca1d3afd410a29217a9809d397-freetype-2.4.8.tar.bz2 export GRAPHITE_TARBALL := 7042305e4208af4c2d5249d814ccce58-graphite2-1.2.3.tgz -export GLM_TARBALL := bae83fa5dc7f081768daace6e199adc3-glm-0.9.4.6-libreoffice.ziexport HSQLDB_TARBALL := 17410483b5b5f267aa18b7e00b65e6e0-hsqldb_1_8_0.zip +export GLM_TARBALL := bae83fa5dc7f081768daace6e199adc3-glm-0.9.4.6-libreoffice.zip +export HSQLDB_TARBALL := 17410483b5b5f267aa18b7e00b65e6e0-hsqldb_1_8_0.zip export HUNSPELL_TARBALL := 3121aaf3e13e5d88dfff13fb4a5f1ab8-hunspell-1.3.2.tar.gz export HYPHEN_TARBALL := a2f6010987e1c601274ab5d63b72c944-hyphen-2.8.4.tar.gz export ICU_TARBALL := 9e96ed4c1d99c0d14ac03c140f9f346c-icu4c-52_1-src.tgz ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added CC||jumbo4...@yahoo.fr Blocks||72632 --- Comment #43 from Laurent BP jumbo4...@yahoo.fr --- Add bug 72632 : Formula (Math) inserted in Writer have wrong subscript position It makes almost Math formula unusable in Writer -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Beginner
On Mon, Dec 23, 2013 at 11:54 AM, prabhdeep singh prabhdeep3...@gmail.com wrote: I want to start contributing to the open source community, but I do not where to begin. https://wiki.documentfoundation.org/Development browse the links out of this pages.. that should allow you to setup all you need to develop for LibreOffice and find some 'EasyHack' to get started.. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: My Windows build is much slower than Linux build. Any way to speed up?
You can disable link time optimisation with a configure option, But surely any kind of optimisation (link-time or just source-file-compile-time) is mainly done when preparing code to actually deliver to users (including alpha, beta, and release candidate builds). And does it really matter whether building in those presumably rare cases is a bit slower than in a non-optmising build? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/inc sc/source sc/uiconfig sc/UIConfig_scalc.mk
sc/UIConfig_scalc.mk |5
sc/inc/scabstdlg.hxx |4
sc/source/ui/attrdlg/scdlgfact.cxx | 19 ---
sc/source/ui/attrdlg/scdlgfact.hxx |4
sc/source/ui/dbgui/validate.cxx | 35 +++---
sc/source/ui/dbgui/validate.src | 35 --
sc/source/ui/inc/anyrefdg.hxx| 12 ++
sc/source/ui/inc/validate.hrc|3
sc/source/ui/inc/validate.hxx| 33 +++---
sc/source/ui/view/cellsh2.cxx|4
sc/uiconfig/scalc/ui/validationdialog.ui | 161 +++
11 files changed, 218 insertions(+), 97 deletions(-)
New commits:
commit 03552256018e90edfd825b0d4c0a5d855abaef24
Author: Caolán McNamara caol...@redhat.com
Date: Mon Dec 23 17:33:24 2013 +
convert validity tabdialog to .ui
Change-Id: Ib7be4172e2d9b80869dbfa47674b13f1e03877d3
diff --git a/sc/UIConfig_scalc.mk b/sc/UIConfig_scalc.mk
index f55823e..8508fe7 100644
--- a/sc/UIConfig_scalc.mk
+++ b/sc/UIConfig_scalc.mk
@@ -99,6 +99,8 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\
sc/uiconfig/scalc/ui/leftheaderdialog \
sc/uiconfig/scalc/ui/namerangesdialog \
sc/uiconfig/scalc/ui/managenamesdialog \
+ sc/uiconfig/scalc/ui/movecopysheet \
+ sc/uiconfig/scalc/ui/movingaveragedialog \
sc/uiconfig/scalc/ui/nosolutiondialog \
sc/uiconfig/scalc/ui/optcalculatepage \
sc/uiconfig/scalc/ui/optchangespage \
@@ -148,9 +150,8 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\
sc/uiconfig/scalc/ui/tpviewpage \
sc/uiconfig/scalc/ui/ttestdialog \
sc/uiconfig/scalc/ui/ungroupdialog \
+ sc/uiconfig/scalc/ui/validationdialog \
sc/uiconfig/scalc/ui/validationhelptabpage \
- sc/uiconfig/scalc/ui/movecopysheet \
- sc/uiconfig/scalc/ui/movingaveragedialog \
))
# vim: set noet sw=4 ts=4:
diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index eba169d..b5ecda2 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -499,8 +499,8 @@ public:
virtual SfxAbstractTabDialog * CreateScParagraphDlg( Window* pParent,
const SfxItemSet* pAttr ,
int nId ) = 0;
-virtual SfxAbstractTabDialog * CreateScValidationDlg( Window* pParent,
-const SfxItemSet*
pArgSet,int nId, ScTabViewShell *pTabVwSh ) = 0;
+virtual SfxAbstractTabDialog * CreateScValidationDlg(Window* pParent,
+const SfxItemSet* pArgSet, ScTabViewShell *pTabVwSh) = 0;
virtual SfxAbstractTabDialog * CreateScSortDlg(Window* pParent, const
SfxItemSet* pArgSet) = 0;
// for tabpage
diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx
b/sc/source/ui/attrdlg/scdlgfact.cxx
index 003d96b..aa1a9bf 100644
--- a/sc/source/ui/attrdlg/scdlgfact.cxx
+++ b/sc/source/ui/attrdlg/scdlgfact.cxx
@@ -1173,22 +1173,11 @@ SfxAbstractTabDialog *
ScAbstractDialogFactory_Impl::CreateScParagraphDlg( Windo
return 0;
}
-SfxAbstractTabDialog * ScAbstractDialogFactory_Impl::CreateScValidationDlg(
Window* pParent,
-const SfxItemSet*
pArgSet,int nId, ScTabViewShell *pTabVwSh )
+SfxAbstractTabDialog *
ScAbstractDialogFactory_Impl::CreateScValidationDlg(Window* pParent,
+const SfxItemSet* pArgSet, ScTabViewShell *pTabVwSh)
{
-SfxTabDialog* pDlg=NULL;
-switch ( nId )
-{
-case TAB_DLG_VALIDATION :
-pDlg = new ScValidationDlg( pParent, pArgSet, pTabVwSh );
-break;
-default:
-break;
-}
-
-if ( pDlg )
-return new ScAbstractTabDialog_Impl( pDlg );
-return 0;
+SfxTabDialog* pDlg = new ScValidationDlg(pParent, pArgSet, pTabVwSh);
+return new ScAbstractTabDialog_Impl(pDlg);
}
SfxAbstractTabDialog * ScAbstractDialogFactory_Impl::CreateScSortDlg(Window*
pParent, const SfxItemSet* pArgSet)
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx
b/sc/source/ui/attrdlg/scdlgfact.hxx
index e00a5bb..1cdf525 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -566,8 +566,8 @@ public:
virtual SfxAbstractTabDialog * CreateScParagraphDlg( Window* pParent,
const SfxItemSet* pAttr ,
int nId );
-virtual SfxAbstractTabDialog * CreateScValidationDlg( Window* pParent,
-const SfxItemSet*
pArgSet,int nId, ScTabViewShell *pTabVwSh );
+virtual SfxAbstractTabDialog * CreateScValidationDlg(Window* pParent,
+const SfxItemSet* pArgSet, ScTabViewShell *pTabVwSh);
virtual SfxAbstractTabDialog * CreateScSortDlg(Window* pParent, const
SfxItemSet* pArgSet);
diff --git a/sc/source/ui/dbgui/validate.cxx b/sc/source/ui/dbgui/validate.cxx
index f40981c..1d309c3 100644
--- a/sc/source/ui/dbgui/validate.cxx
+++
Re: Efficient UNO component linkage GC ...
Hi Stephan, On Mon, 2013-12-23 at 18:44 +0100, Matúš Kukan wrote: * implementations of non-single-instance services can be rewritten using the new .component XML implementation constructor=... feature, cf. http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae3a0c8da50b36db395984637f5ad74d3b4887bc I'm concerned that we already have way too many, far too verbose XML files, with over-lengthy attributes (some with un-necessary and over-complicated namespacing to boot ;-). Parsing that lot takes a very considerable chunk of startup time, and storing redundant foo in memory seems a bit un-necessary :-) What does this: implementation name=com.sun.star.comp.graphic.GraphicRendererVCL + constructor=com_sun_star_comp_graphic_GraphicRendererVCL_get_implementation service name=com.sun.star.graphic.GraphicRendererVCL/ /implementation win us over: implementation name=com.sun.star.comp.graphic.GraphicRendererVCL direct=1 service name=com.sun.star.graphic.GraphicRendererVCL/ /implementation ? :-) Certainly the latter can be stored as an extra boolean. Given that we can trivially produce the symbol name from the implementation name at run-time ? [ if we even need to produce it at all - since we can link that at compile time ? :-]. I guess - if this would only ever be used for bits of code that are going to be in the main mergelibs domain thus could be directly linked and evaporated away at compile time: and assuming that we subsequently avoid those being registered in services.rdb I guess it's no issue: beyond lots more typing, and scope for typos/errors :-) I suspect though that mergelibs will not encompass all components though, and that thus we'll end up with lists of this duplication around the place still (?). ATB, Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: android/experimental solenv/bin
android/experimental/DocumentLoader/Makefile |2 android/experimental/LibreOffice4Android/Makefile |2 android/experimental/desktop/Makefile |2 solenv/bin/native-code.py | 216 ++ 4 files changed, 189 insertions(+), 33 deletions(-) New commits: commit 3f47635b86ac34a0dc42d93e77bb1a3ca26f6f79 Author: Matúš Kukan matus.ku...@collabora.com Date: Mon Dec 23 17:44:57 2013 +0100 Improve native-code generator for (not only) Android. Group logic from include/osl/detail/component-mapping.h has been duplicated here for now. The plan is to reuse this for iOS too if possible. We don't need component-declarations.h now, which is good because the list of implementation constructors is going to grow a lot over time. Also, something needs to be done to avoid component-defines.h. --constructor parameter was removed because it was not used and also does not make sense. __attribute__ ((visibility(default))) is removed too. Change-Id: I5e3f988800303d31e1d78220cbd25339bcbc482a diff --git a/android/experimental/DocumentLoader/Makefile b/android/experimental/DocumentLoader/Makefile index 5295c80..092292d 100644 --- a/android/experimental/DocumentLoader/Makefile +++ b/android/experimental/DocumentLoader/Makefile @@ -13,7 +13,7 @@ include $(BOOTSTRAPDIR)/Makefile.shared native-code.cxx: $(SRCDIR)/solenv/bin/native-code.py $ \ - -f EXTENDED_CORE -f BASE_CORE -f CALC_CORE -f DRAW_CORE -f MATH -f WRITER \ + -g extended_core -g base_core -g calc_core -g draw_core -g math -g writer \ -s protocolhandler -s sb \ $@ diff --git a/android/experimental/LibreOffice4Android/Makefile b/android/experimental/LibreOffice4Android/Makefile index 92f0668..4eadb65 100644 --- a/android/experimental/LibreOffice4Android/Makefile +++ b/android/experimental/LibreOffice4Android/Makefile @@ -13,7 +13,7 @@ BOOTSTRAPDIR=../../Bootstrap include $(BOOTSTRAPDIR)/Makefile.shared native-code.cxx: $(SRCDIR)/solenv/bin/native-code.py - $ -f EXTENDED_CORE -f BASE_CORE -f CALC_CORE -f DRAW_CORE -f MATH -f WRITER \ + $ -g extended_core -g base_core -g calc_core -g draw_core -g math -g writer \ -s dlgprov -s protocolhandler -s scriptframe -s sb -s stringresource -s vbaswobj -s vbaevents \ $@ diff --git a/android/experimental/desktop/Makefile b/android/experimental/desktop/Makefile index 610bf87..a661825 100644 --- a/android/experimental/desktop/Makefile +++ b/android/experimental/desktop/Makefile @@ -13,7 +13,7 @@ include $(BOOTSTRAPDIR)/Makefile.shared native-code.cxx: $(SRCDIR)/solenv/bin/native-code.py $ -j \ - -f EXTENDED_CORE -f BASE_CORE -f CALC_CORE -f DRAW_CORE -f MATH -f WRITER \ + -g extended_core -g base_core -g calc_core -g draw_core -g math -g writer \ -s basprov -s dlgprov -s cui -s protocolhandler -s scriptframe -s sb -s spl -s stringresource -s uui -s vbaswobj -s vbaevents \ $@ diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py index 99cefb8..ebdd5db 100755 --- a/solenv/bin/native-code.py +++ b/solenv/bin/native-code.py @@ -8,46 +8,205 @@ from __future__ import print_function from optparse import OptionParser +# foo_component_getFactory functions are split into groups, so that you could +# choose e.g. 'extended_core' and 'writer' functionality and through factory_map, +# relevant function sections will be referenced in lo_get_factory_map(). +# That prevents garbage collector to ignore them as unused. + +# We need the same groups for new constructor functions, started in +# ae3a0c8da50b36db395984637f5ad74d3b4887bc +# For now, there are only constructor functions for implementations in 'core' +# group, so no need for other groups, core_constructor_list is enough. +# (These functions are referenced in lo_get_constructor_map().) + +core_factory_list = [ +(libembobj.a, embobj_component_getFactory), +(libemboleobj.a, emboleobj_component_getFactory), +(libintrospectionlo.a, introspection_component_getFactory), +(libreflectionlo.a, reflection_component_getFactory), +(libstocserviceslo.a, stocservices_component_getFactory), +(libcomphelper.a, comphelp_component_getFactory), +(libconfigmgrlo.a, configmgr_component_getFactory), +(libdeployment.a, deployment_component_getFactory), +(libevtattlo.a, evtatt_component_getFactory), +(libfilterconfiglo.a, filterconfig1_component_getFactory), +(libfsstoragelo.a, fsstorage_component_getFactory), +(libfwklo.a, fwk_component_getFactory), +(libfwllo.a, fwl_component_getFactory), +(libhyphenlo.a, hyphen_component_getFactory), +(libi18npoollo.a, i18npool_component_getFactory), +(liblnglo.a, lng_component_getFactory), +(liblnthlo.a, lnth_component_getFactory), +(liblocalebe1lo.a,
Re: Efficient UNO component linkage GC ...
On Mon, 2013-12-23 at 18:44 +0100, Matúš Kukan wrote: ** when compiling .cxx files for which it is known that the constructor function for some S will be visible (which could e.g. be ~always the case when compiling for a single big executable on Android/iOS), define the LO_URE_CTOR_ENV_S' and LO_URE_CTOR_FUN_S' macros, either via -D or via some strategically included header Yes, so this needs some thought. If I see correctly, there are already some typos in 15abebbde560e17413f17b16b8b2e9c1f31f01a5 like LO_URE_CTOR_FUN_com_dot_sun_dot_star_dot_xml_dot_sax_dot_FastParser vs. LO_URE_CTOR_FUN_com_dot_sun_dot_star_dot_comp_dot_extensions_dot_xml_dot_sax_dot_FastParser Oh - it's not a typo. We use service name in codemaker/source/cppumaker/cpputype.cxx - Do we know also implementation names in codemaker for services? -- Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/chart-opengl2' - chart2/source
chart2/source/view/main/AbstractShapeFactory.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 404da58729612a88178b1f71e00a6f0b4e2f884d
Author: Michael Meeks michael.me...@collabora.com
Date: Mon Dec 23 20:36:40 2013 +
re-enable opengl module hooks.
Change-Id: I48275b81e4569ace26f986542ac3190ba8e0a052
diff --git a/chart2/source/view/main/AbstractShapeFactory.cxx
b/chart2/source/view/main/AbstractShapeFactory.cxx
index f93a0a6..d6d6b2e 100644
--- a/chart2/source/view/main/AbstractShapeFactory.cxx
+++ b/chart2/source/view/main/AbstractShapeFactory.cxx
@@ -48,7 +48,6 @@ using ::com::sun::star::uno::Reference;
namespace chart {
-/*
namespace {
typedef opengl::OpenglShapeFactory* (*__getOpenglShapeFactory)(void);
@@ -71,7 +70,6 @@ osl::Module* getOpenGLModule()
}
}
-*/
AbstractShapeFactory*
AbstractShapeFactory::getOrCreateShapeFactory(uno::Reference
lang::XMultiServiceFactory xFactory)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Libreoffice and kde integration
Why does the autogen.sh that is used to compile the build, Linux - rpm (x86), version 4.1.4, English (US) have the flags - --disable-kde4 --enable-kde in the file LibreOfficeLinux.conf. Is it because in the standard build kde integration of LibreOffice is still at KDE3? Or have I lost the plot completely! Regards Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Depends on||72998 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Libreoffice and kde integration
Hi there, On Mon, 2013-12-23 at 21:10 + wrote: Why does the autogen.sh that is used to compile the build, Linux - rpm (x86), version 4.1.4, English (US) have the flags - Sure - this is because the rather old system we compile the generic linux builds on (which needs to be that old so we can run on all newer systems) can't feasibly have KDE4 installed. I tried to make a magic assembler tool to stub the libraries to overcome that without success - it's a bit of a pain. --disable-kde4 --enable-kde in the file LibreOfficeLinux.conf. Sure - and also --enable-gnome-vfs as well as --disable-gio is a similar disaster caused by the same issue. Is it because in the standard build kde integration of LibreOffice is still at KDE3? It's all to do with what we can get to install on a reasonably vanilla CentOS 5 (IIRC). HTH, Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sw/source
sw/source/core/text/EnhancedPDFExportHelper.cxx | 11 +--
sw/source/core/text/txthyph.cxx | 12 ++--
2 files changed, 11 insertions(+), 12 deletions(-)
New commits:
commit a9fa817b6876814b6ebc45c2534a769e1fa84cac
Author: Khaled Hosny khaledho...@eglug.org
Date: Sun Dec 22 01:02:19 2013 +0200
fdo#67370: Hyphens are not visible in tagged PDF
One requirement of tagged PDF is to represent automatically inserted
hyphens using the soft hyphen (U+00AD) character, so we were doing this
by simply passing that character to text layout code when exporting a
tagged PDF (which is the literal suggestion of old PDF specification).
This is wrong, though, since the soft hyphen is a control character and
should not have a visible output by itself (and fonts might not even
have a visible glyph there), but this happened to work because non of
the layout engines we are using treated soft hyphen specially and was
just showing whatever glyph the font had there. This broke with the
switch to HarfBuzz since it will not show any visible glyph for Unicode
control characters (by default), which is the right thing to do.
Latest versions of PDF spec suggest using either ToUnicode mapping or an
ActualText text entry to encode the soft hyphen instead, I found it
easier to use ActualText since we already have code that handles
non-standard hyphenation using it already.
Change-Id: I88deadf3a806f69775b2e0ccff2f9b2f61a0f2e2
Reviewed-on: https://gerrit.libreoffice.org/7170
Tested-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/core/text/EnhancedPDFExportHelper.cxx
b/sw/source/core/text/EnhancedPDFExportHelper.cxx
index fe8b0bd..462576a 100644
--- a/sw/source/core/text/EnhancedPDFExportHelper.cxx
+++ b/sw/source/core/text/EnhancedPDFExportHelper.cxx
@@ -760,7 +760,8 @@ void SwTaggedPDFHelper::SetAttributes(
vcl::PDFWriter::StructElement eType )
case vcl::PDFWriter::Span :
case vcl::PDFWriter::Quote :
case vcl::PDFWriter::Code :
-if( POR_HYPHSTR == pPor-GetWhichPor() || POR_SOFTHYPHSTR ==
pPor-GetWhichPor() )
+if( POR_HYPHSTR == pPor-GetWhichPor() || POR_SOFTHYPHSTR ==
pPor-GetWhichPor() ||
+POR_HYPH == pPor-GetWhichPor() || POR_SOFTHYPH ==
pPor-GetWhichPor() )
bActualText = true;
else
{
@@ -783,7 +784,11 @@ void SwTaggedPDFHelper::SetAttributes(
vcl::PDFWriter::StructElement eType )
if ( bActualText )
{
-const OUString aActualTxt = rInf.GetTxt().copy( rInf.GetIdx(),
pPor-GetLen() );
+OUString aActualTxt;
+if (pPor-GetWhichPor() == POR_SOFTHYPH || pPor-GetWhichPor() ==
POR_HYPH)
+aActualTxt = OUString(0xad); // soft hyphen
+else
+aActualTxt = rInf.GetTxt().copy(rInf.GetIdx(), pPor-GetLen());
mpPDFExtOutDevData-SetActualText( aActualTxt );
}
@@ -1364,6 +1369,8 @@ void SwTaggedPDFHelper::BeginInlineStructureElements()
switch ( pPor-GetWhichPor() )
{
+case POR_HYPH :
+case POR_SOFTHYPH :
// Check for alternative spelling:
case POR_HYPHSTR :
case POR_SOFTHYPHSTR :
diff --git a/sw/source/core/text/txthyph.cxx b/sw/source/core/text/txthyph.cxx
index 909f2ad..0a83abd 100644
--- a/sw/source/core/text/txthyph.cxx
+++ b/sw/source/core/text/txthyph.cxx
@@ -20,7 +20,6 @@
#include hintids.hxx
#include editeng/unolingu.hxx
#include com/sun/star/i18n/WordType.hpp
-#include EnhancedPDFExportHelper.hxx
#include viewopt.hxx
#include viewsh.hxx
#include SwPortionHandler.hxx
@@ -370,16 +369,9 @@ sal_Bool SwTxtPortion::CreateHyphen( SwTxtFormatInfo
rInf, SwTxtGuess rGuess )
* virtual SwHyphPortion::GetExpTxt()
*/
-sal_Bool SwHyphPortion::GetExpTxt( const SwTxtSizeInfo rInf, OUString rTxt )
const
+sal_Bool SwHyphPortion::GetExpTxt( const SwTxtSizeInfo /*rInf*/, OUString
rTxt ) const
{
-// #i16816# tagged pdf support
-const sal_Unicode cChar = rInf.GetVsh()
- rInf.GetVsh()-GetViewOptions()-IsPDFExport()
- SwTaggedPDFHelper::IsExportTaggedPDF(
*rInf.GetOut() ) ?
- 0xad :
- '-';
-
-rTxt = OUString(cChar);
+rTxt = -;
return sal_True;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sw/source
sw/source/core/text/EnhancedPDFExportHelper.cxx | 11 +--
sw/source/core/text/txthyph.cxx | 12 ++--
2 files changed, 11 insertions(+), 12 deletions(-)
New commits:
commit 158027cd7fe1ea2faeb5d2220547b36c9cbfb9d3
Author: Khaled Hosny khaledho...@eglug.org
Date: Sun Dec 22 01:02:19 2013 +0200
fdo#67370: Hyphens are not visible in tagged PDF
One requirement of tagged PDF is to represent automatically inserted
hyphens using the soft hyphen (U+00AD) character, so we were doing this
by simply passing that character to text layout code when exporting a
tagged PDF (which is the literal suggestion of old PDF specification).
This is wrong, though, since the soft hyphen is a control character and
should not have a visible output by itself (and fonts might not even
have a visible glyph there), but this happened to work because non of
the layout engines we are using treated soft hyphen specially and was
just showing whatever glyph the font had there. This broke with the
switch to HarfBuzz since it will not show any visible glyph for Unicode
control characters (by default), which is the right thing to do.
Latest versions of PDF spec suggest using either ToUnicode mapping or an
ActualText text entry to encode the soft hyphen instead, I found it
easier to use ActualText since we already have code that handles
non-standard hyphenation using it already.
Conflicts:
sw/source/core/text/EnhancedPDFExportHelper.cxx
sw/source/core/text/txthyph.cxx
Change-Id: I88deadf3a806f69775b2e0ccff2f9b2f61a0f2e2
Reviewed-on: https://gerrit.libreoffice.org/7177
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/core/text/EnhancedPDFExportHelper.cxx
b/sw/source/core/text/EnhancedPDFExportHelper.cxx
index 3933837..9538de6 100644
--- a/sw/source/core/text/EnhancedPDFExportHelper.cxx
+++ b/sw/source/core/text/EnhancedPDFExportHelper.cxx
@@ -766,7 +766,8 @@ void SwTaggedPDFHelper::SetAttributes(
vcl::PDFWriter::StructElement eType )
case vcl::PDFWriter::Span :
case vcl::PDFWriter::Quote :
case vcl::PDFWriter::Code :
-if( POR_HYPHSTR == pPor-GetWhichPor() || POR_SOFTHYPHSTR ==
pPor-GetWhichPor() )
+if( POR_HYPHSTR == pPor-GetWhichPor() || POR_SOFTHYPHSTR ==
pPor-GetWhichPor() ||
+POR_HYPH == pPor-GetWhichPor() || POR_SOFTHYPH ==
pPor-GetWhichPor() )
bActualText = true;
else
{
@@ -789,7 +790,11 @@ void SwTaggedPDFHelper::SetAttributes(
vcl::PDFWriter::StructElement eType )
if ( bActualText )
{
-const String aActualTxt( rInf.GetTxt(), rInf.GetIdx(),
pPor-GetLen() );
+String aActualTxt;
+if (pPor-GetWhichPor() == POR_SOFTHYPH || pPor-GetWhichPor() ==
POR_HYPH)
+aActualTxt = (sal_Unicode)0xad; // soft hyphen
+else
+aActualTxt = String(rInf.GetTxt(), rInf.GetIdx(),
pPor-GetLen());
mpPDFExtOutDevData-SetActualText( aActualTxt );
}
@@ -1373,6 +1378,8 @@ void SwTaggedPDFHelper::BeginInlineStructureElements()
switch ( pPor-GetWhichPor() )
{
+case POR_HYPH :
+case POR_SOFTHYPH :
// Check for alternative spelling:
case POR_HYPHSTR :
case POR_SOFTHYPHSTR :
diff --git a/sw/source/core/text/txthyph.cxx b/sw/source/core/text/txthyph.cxx
index 62b3ad4..6b32a9f 100644
--- a/sw/source/core/text/txthyph.cxx
+++ b/sw/source/core/text/txthyph.cxx
@@ -20,7 +20,6 @@
#include hintids.hxx
#include editeng/unolingu.hxx
#include com/sun/star/i18n/WordType.hpp
-#include EnhancedPDFExportHelper.hxx
#include viewopt.hxx // SwViewOptions
#include viewsh.hxx
#include SwPortionHandler.hxx
@@ -370,16 +369,9 @@ sal_Bool SwTxtPortion::CreateHyphen( SwTxtFormatInfo
rInf, SwTxtGuess rGuess )
* virtual SwHyphPortion::GetExpTxt()
*/
-sal_Bool SwHyphPortion::GetExpTxt( const SwTxtSizeInfo rInf, OUString rTxt )
const
+sal_Bool SwHyphPortion::GetExpTxt( const SwTxtSizeInfo /*rInf*/, OUString
rTxt ) const
{
-// #i16816# tagged pdf support
-const sal_Unicode cChar = rInf.GetVsh()
- rInf.GetVsh()-GetViewOptions()-IsPDFExport()
- SwTaggedPDFHelper::IsExportTaggedPDF(
*rInf.GetOut() ) ?
- 0xad :
- '-';
-
-rTxt = OUString(cChar);
+rTxt = -;
return sal_True;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/notify/broadcast.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit bf1812806056349fd32785e1fa7ba7595c8c66fa
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Mon Dec 23 23:46:02 2013 +0100
fix crash when erasing entry while iterating through vector
Broadcast might result in calling Remove on the same object which erases
the entry from the listeners vector. If we create a copy we can still
iterate through the vector as all iterators are still valid.
diff --git a/svl/source/notify/broadcast.cxx b/svl/source/notify/broadcast.cxx
index 425a1e2..19abe38 100644
--- a/svl/source/notify/broadcast.cxx
+++ b/svl/source/notify/broadcast.cxx
@@ -124,7 +124,8 @@ void SvtBroadcaster::Broadcast( const SfxHint rHint )
Normalize();
ListenersType::iterator dest(maDestructedListeners.begin());
-for (ListenersType::iterator it(maListeners.begin()); it !=
maListeners.end(); ++it)
+ListenersType aListeners(maListeners); // this copy is important to avoid
erasing entries while iterating
+for (ListenersType::iterator it(aListeners.begin()); it !=
aListeners.end(); ++it)
{
// skip the destructed ones
while (dest != maDestructedListeners.end() (*dest *it))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Error in debug mode svl/source/notify/broadcast.cxx
Hey,
On Sun, Dec 22, 2013 at 8:04 PM, Arnaud Versini arnaud.vers...@gmail.comwrote:
Hi
I got an error in LibreOffce debug build, seems due to your commits :
error: attempt to increment a singular iterator.
Objects involved in the operation:
iterator this @ 0x0x7fff2e90 {
type =
N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPP11SvtListenerNSt9__cxx19986vectorIS4_SaIS4_ENSt7__debug6vectorIS4_S8_
(mutable iterator);
state = singular;
references sequence with type
`NSt7__debug6vectorIP11SvtListenerSaIS2_EEE' @ 0x0x7fff2e90
Sorry I'm unable to understand why,, code seems ok for me, but the
backtraceindicates this location
#4 0x2aaab50a352f in SvtBroadcaster::Broadcast (this=0x1def9e8,
rHint=...) at
/home/arnaud/libreoffice/src/svl/source/notify/broadcast.cxx:127
#5 0x2aaab023fa33 in ScBroadcastAreaSlot::AreaBroadcast
(this=0x1def7f0, rHint=...) at
/home/arnaud/libreoffice/src/sc/source/core/data/bcaslot.cxx:276
#6 0x2aaab02419be in ScBroadcastAreaSlotMachine::AreaBroadcast
(this=0x1d91d20, rHint=...) at
/home/arnaud/libreoffice/src/sc/source/core/data/bcaslot.cxx:677
Reverting c8b624329caed68550fcb1fe197c8fa8107d079b and
df9883411a5423793ad411ac05d7a28c355209aa seems to resolve the bug for now.
Don't hesitate to ask something if you need more information :-)
I was hit by it as well and after some debugging (this code is really,
really nasty) I finally found the problem. Should be fixed now with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=bf1812806056349fd32785e1fa7ba7595c8c66fa
Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 10 commits - sc/qa sc/source
sc/qa/unit/data/xls/opencl/math/iseven.xls |binary
sc/qa/unit/data/xls/opencl/math/isodd.xls |binary
sc/source/core/opencl/op_financial.cxx | 313 +
sc/source/core/opencl/op_math.cxx | 24 +
sc/source/core/opencl/op_math.hxx |3
sc/source/core/opencl/op_statistical.cxx | 190 ++-
sc/source/core/opencl/opinlinefun_finacial.cxx | 49 +++
sc/source/core/opencl/opinlinefun_math.hxx | 29 ++
8 files changed, 347 insertions(+), 261 deletions(-)
New commits:
commit 2bb1a845a25ca9a39c96f37995453844461aed4e
Author: hongyu zhong hon...@multicorewareinc.com
Date: Fri Dec 20 14:41:47 2013 +0800
GPU Calc: Optimized CHISQINV
AMLOEXT-300
Change-Id: I01f16fb5a00e1c96e40bfcf99e417519cb27e765
Signed-off-by: haochen haoc...@multicorewareinc.com
Signed-off-by: Wei Wei wei...@multicorewareinc.com
Signed-off-by: I-Jui (Ray) Sung r...@multicorewareinc.com
diff --git a/sc/source/core/opencl/op_statistical.cxx
b/sc/source/core/opencl/op_statistical.cxx
index 8275aaa..a98a08e 100644
--- a/sc/source/core/opencl/op_statistical.cxx
+++ b/sc/source/core/opencl/op_statistical.cxx
@@ -7125,6 +7125,46 @@ vSubArguments)
{
GenTmpVariables(ss,vSubArguments);
CheckAllSubArgumentIsNan(ss,vSubArguments);
+size_t i = vSubArguments.size();
+ss \n;
+for (i = 0; i vSubArguments.size(); i++)
+{
+FormulaToken *pCur = vSubArguments[i]-GetFormulaToken();
+assert(pCur);
+if (pCur-GetType() == formula::svSingleVectorRef)
+{
+#ifdef ISNAN
+const formula::SingleVectorRefToken* pSVR =
+dynamic_cast const formula::SingleVectorRefToken* (pCur);
+ss if (gid0pSVR-GetArrayLength() ){\n;
+#endif
+}
+else if (pCur-GetType() == formula::svDouble)
+{
+#ifdef ISNAN
+ss {\n;
+#endif
+}
+
+#ifdef ISNAN
+if(ocPush==vSubArguments[i]-GetFormulaToken()-GetOpCode())
+{
+ss if (isNan(;
+ss vSubArguments[i]-GenSlidingWindowDeclRef();
+ss ))\n;
+ss tmpi= 0;\n;
+ss else\n;
+ss tmpi=\n;
+ss vSubArguments[i]-GenSlidingWindowDeclRef();
+ss ;\n}\n;
+}
+else
+{
+ss tmpi=vSubArguments[i]-GenSlidingWindowDeclRef();
+ss ;\n;
+}
+#endif
+}
ss tmp1 = floor(tmp1);\n;
ss bool bConvError;\n;
ss if(tmp1 1.0 || tmp0 0 || tmp0=1.0)\n;
commit 99b93d898f2aff3198146c1e8aa44b9dfae177b9
Author: yangzhang yangzh...@multicorewareinc.com
Date: Fri Dec 20 14:07:56 2013 +0800
GPU Calc: Optimized ACOS
AMLOEXT-270
Change-Id: I460354ede9a9666a7b5dcd7c5d125b605e3b3b2d
Signed-off-by: haochen haoc...@multicorewareinc.com
Signed-off-by: Wei Wei wei...@multicorewareinc.com
Signed-off-by: I-Jui (Ray) Sung r...@multicorewareinc.com
diff --git a/sc/source/core/opencl/op_math.cxx
b/sc/source/core/opencl/op_math.cxx
index f0ed0b1..3f742f8 100644
--- a/sc/source/core/opencl/op_math.cxx
+++ b/sc/source/core/opencl/op_math.cxx
@@ -1032,6 +1032,12 @@ void OpAbs::GenSlidingWindowFunction(std::stringstream
ss,
ss return fabs(tmp);\n;
ss };
}
+void OpArcCos::BinInlineFun(std::setstd::string decls,
+std::setstd::string funs)
+{
+decls.insert(atan2Decl);
+funs.insert(atan2Content);
+}
void OpArcCos::GenSlidingWindowFunction(std::stringstream ss,
const std::string sSymName, SubArguments vSubArguments)
{
@@ -1057,7 +1063,7 @@ void OpArcCos::GenSlidingWindowFunction(std::stringstream
ss,
#endif
ss tmp = ;
ss vSubArguments[0]-GenSlidingWindowDeclRef() ;\n;
-ss return acos(tmp);\n;
+ss return arctan2(sqrt(1.0 - pow(tmp, 2)), tmp);\n;
ss };
}
void OpArcCosHyp::GenSlidingWindowFunction(std::stringstream ss,
diff --git a/sc/source/core/opencl/op_math.hxx
b/sc/source/core/opencl/op_math.hxx
index e10dfa1..5864161 100644
--- a/sc/source/core/opencl/op_math.hxx
+++ b/sc/source/core/opencl/op_math.hxx
@@ -101,6 +101,7 @@ public:
const std::string sSymName, SubArguments vSubArguments);
virtual std::string GetBottom(void) { return 0.0; }
virtual std::string BinFuncName(void) const { return ScACos; }
+virtual void BinInlineFun(std::setstd::string ,std::setstd::string);
};
class OpArcCosHyp:public Normal{
public:
commit 3eb75fa4d7f0c7c87cc0b20a0a246c956ae8816a
Author: yangzhang yangzh...@multicorewareinc.com
Date: Fri Dec 20 14:04:34 2013 +0800
GPU Calc: Optimized ASIN
AMLOEXT-269
Change-Id: I10d33b50f743630ed91daa743017e431754e5659
Signed-off-by: haochen haoc...@multicorewareinc.com
Signed-off-by: Wei Wei wei...@multicorewareinc.com
Signed-off-by: I-Jui (Ray) Sung r...@multicorewareinc.com
diff --git
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 mariosv mari...@miguelangel.mobi changed: What|Removed |Added Depends on||72999 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - include/vcl vcl/inc vcl/source vcl/uiconfig vcl/UIConfig_vcl.mk
include/vcl/prgsbar.hxx|3
vcl/UIConfig_vcl.mk|3
vcl/inc/printdlg.hxx | 15 +---
vcl/inc/svids.hrc |4 -
vcl/source/control/prgsbar.cxx |7 +-
vcl/source/src/print.src | 25 ---
vcl/source/window/printdlg.cxx | 108 +++--
vcl/uiconfig/ui/printprogressdialog.ui | 87 ++
8 files changed, 127 insertions(+), 125 deletions(-)
New commits:
commit 3e978fc21f2d924dab3d714956944a27e70d606f
Author: Caolán McNamara caol...@redhat.com
Date: Mon Dec 23 19:25:30 2013 +
convert print progress dialog to .ui
use an actual ProgressBar rather than direct drawing
into the dialog window
Change-Id: I13a17970055980e0e248f60058cd4d5ef91f1d7d
diff --git a/vcl/UIConfig_vcl.mk b/vcl/UIConfig_vcl.mk
index d3e901e..d37c985 100644
--- a/vcl/UIConfig_vcl.mk
+++ b/vcl/UIConfig_vcl.mk
@@ -10,9 +10,10 @@
$(eval $(call gb_UIConfig_UIConfig,vcl))
$(eval $(call gb_UIConfig_add_uifiles,vcl,\
- vcl/uiconfig/ui/printdialog \
vcl/uiconfig/ui/errornocontentdialog \
vcl/uiconfig/ui/errornoprinterdialog \
+ vcl/uiconfig/ui/printdialog \
+ vcl/uiconfig/ui/printprogressdialog \
))
# vim: set noet sw=4 ts=4:
diff --git a/vcl/inc/printdlg.hxx b/vcl/inc/printdlg.hxx
index 3b07b6b..e142f0a 100644
--- a/vcl/inc/printdlg.hxx
+++ b/vcl/inc/printdlg.hxx
@@ -30,6 +30,7 @@
#include vcl/button.hxx
#include vcl/gdimtf.hxx
#include vcl/lstbox.hxx
+#include vcl/prgsbar.hxx
#include vcl/field.hxx
#include vcl/tabctrl.hxx
#include vcl/tabpage.hxx
@@ -271,29 +272,23 @@ namespace vcl
class PrintProgressDialog : public ModelessDialog
{
OUStringmaStr;
-FixedText maText;
-CancelButtonmaButton;
+FixedText* mpText;
+ProgressBar*mpProgress;
+CancelButton* mpButton;
boolmbCanceled;
sal_Int32 mnCur;
sal_Int32 mnMax;
-longmnProgressHeight;
-Rectangle maProgressRect;
-boolmbNativeProgress;
DECL_LINK( ClickHdl, Button* );
-void implCalcProgressRect();
public:
-PrintProgressDialog( Window* i_pParent, int i_nMax );
-~PrintProgressDialog();
+PrintProgressDialog(Window* i_pParent, int i_nMax);
bool isCanceled() const { return mbCanceled; }
void setProgress( int i_nCurrent, int i_nMax = -1 );
void tick();
void reset();
-
-virtual void Paint( const Rectangle );
};
}
diff --git a/vcl/inc/svids.hrc b/vcl/inc/svids.hrc
index eb16740..f3c3f4d 100644
--- a/vcl/inc/svids.hrc
+++ b/vcl/inc/svids.hrc
@@ -115,10 +115,6 @@
#define SV_PRINT_OPT_TOFILE 2
#define SV_PRINT_OPT_SINGLEJOBS 3
-#define SV_DLG_PRINT_PROGRESS 2049
-#define SV_PRINT_PROGRESS_CANCEL1
-#define SV_PRINT_PROGRESS_TEXT 2
-
#define SV_PRINT_NATIVE_STRINGS 2050
#define SV_HELPTEXT_CLOSE 1
diff --git a/vcl/source/src/print.src b/vcl/source/src/print.src
index 0d2f9c1..4bfa750 100644
--- a/vcl/source/src/print.src
+++ b/vcl/source/src/print.src
@@ -19,31 +19,6 @@
#include svids.hrc
-ModelessDialog SV_DLG_PRINT_PROGRESS
-{
-HelpID = vcl:ModelessDialog:SV_DLG_PRINT_PROGRESS;
-Text [en-US] = Printing;
-Closeable = FALSE;
-Sizeable = FALSE;
-Moveable = TRUE;
-SVLook = TRUE;
-
-Size = MAP_APPFONT( 120, 70 );
-
-CancelButton SV_PRINT_PROGRESS_CANCEL
-{
-Pos = MAP_APPFONT( 35, 50 );
-Size = MAP_APPFONT( 50, 15 );
-};
-FixedText SV_PRINT_PROGRESS_TEXT
-{
-Pos = MAP_APPFONT( 5,10 );
-Size = MAP_APPFONT( 110, 10 );
-Text [ en-US ] = Page %p of %n;
-Center = TRUE;
-};
-};
-
StringArray SV_PRINT_NATIVE_STRINGS
{
ItemList [en-US] =
diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 21941ca..c44dee7 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -1842,63 +1842,46 @@ void PrintDialog::previewBackward()
//
//
-
-PrintProgressDialog::PrintProgressDialog( Window* i_pParent, int i_nMax ) :
-ModelessDialog( i_pParent, VclResId( SV_DLG_PRINT_PROGRESS ) ),
-maText( this, VclResId( SV_PRINT_PROGRESS_TEXT ) ),
-maButton( this, VclResId( SV_PRINT_PROGRESS_CANCEL ) ),
-mbCanceled( false ),
-mnCur( 0 ),
-mnMax( i_nMax ),
-mnProgressHeight( 15 ),
-mbNativeProgress( false )
-{
-FreeResource();
+PrintProgressDialog::PrintProgressDialog(Window* i_pParent, int i_nMax)
+: ModelessDialog(i_pParent, PrintProgressDialog,
+vcl/ui/printprogressdialog.ui)
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/bibliographyentry.ui |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 91915549b6178d361e778cbc31a25ef2e5616020 Author: Alexander Wilms f.alexander.wi...@gmail.com Date: Sun Dec 22 14:56:34 2013 +0100 Made button caption in bib entry dialog clearer Change-Id: Ib917865211407b9aed1cb04eaec9b71c63ead182 Reviewed-on: https://gerrit.libreoffice.org/7179 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sw/uiconfig/swriter/ui/bibliographyentry.ui b/sw/uiconfig/swriter/ui/bibliographyentry.ui index e890b08..917a281 100644 --- a/sw/uiconfig/swriter/ui/bibliographyentry.ui +++ b/sw/uiconfig/swriter/ui/bibliographyentry.ui @@ -1,6 +1,7 @@ ?xml version=1.0 encoding=UTF-8? +!-- Generated with glade 3.16.0 -- interface - !-- interface-requires gtk+ 3.0 -- + requires lib=gtk+ version=3.0/ object class=GtkDialog id=BibliographyEntryDialog property name=can_focusFalse/property property name=border_width6/property @@ -9,11 +10,11 @@ child internal-child=vbox object class=GtkBox id=dialog-vbox1 property name=can_focusFalse/property +property name=orientationvertical/property property name=spacing12/property child internal-child=action_area object class=GtkButtonBox id=dialog-action_area1 property name=can_focusFalse/property -property name=orientationvertical/property property name=layout_stylestart/property child object class=GtkButton id=insert @@ -32,7 +33,7 @@ /child child object class=GtkButton id=modify -property name=label translatable=yesModify/property +property name=label translatable=yesApply/property property name=can_focusTrue/property property name=can_defaultTrue/property property name=has_defaultTrue/property ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/bibliographyentry.ui |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit a517fe8aa7acd7eab167ff7ad0770ac5f5590c76 Author: Caolán McNamara caol...@redhat.com Date: Mon Dec 23 23:48:54 2013 + wanted layout at end here, like everything else Change-Id: I10491e37b62f052b8b45a6b0b94ff43b0dd9a80d diff --git a/sw/uiconfig/swriter/ui/bibliographyentry.ui b/sw/uiconfig/swriter/ui/bibliographyentry.ui index 917a281..1231bdc 100644 --- a/sw/uiconfig/swriter/ui/bibliographyentry.ui +++ b/sw/uiconfig/swriter/ui/bibliographyentry.ui @@ -1,7 +1,6 @@ ?xml version=1.0 encoding=UTF-8? -!-- Generated with glade 3.16.0 -- interface - requires lib=gtk+ version=3.0/ + !-- interface-requires gtk+ 3.0 -- object class=GtkDialog id=BibliographyEntryDialog property name=can_focusFalse/property property name=border_width6/property @@ -15,7 +14,7 @@ child internal-child=action_area object class=GtkButtonBox id=dialog-action_area1 property name=can_focusFalse/property -property name=layout_stylestart/property +property name=layout_styleend/property child object class=GtkButton id=insert property name=label translatable=yesInsert/property ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/uiconfig sw/uiconfig
sc/uiconfig/scalc/ui/inputstringdialog.ui |3 sc/uiconfig/scalc/ui/insertcells.ui | 19 +-- sc/uiconfig/scalc/ui/sortwarning.ui |3 sw/uiconfig/swriter/ui/addentrydialog.ui |3 sw/uiconfig/swriter/ui/assignstylesdialog.ui |9 - sw/uiconfig/swriter/ui/autotext.ui| 10 - sw/uiconfig/swriter/ui/bibliographyentry.ui |6 + sw/uiconfig/swriter/ui/captionoptions.ui |7 - sw/uiconfig/swriter/ui/columndialog.ui|7 - sw/uiconfig/swriter/ui/columnwidth.ui |9 - sw/uiconfig/swriter/ui/converttexttable.ui|9 - sw/uiconfig/swriter/ui/createauthorentry.ui | 145 -- sw/uiconfig/swriter/ui/dropdownfielddialog.ui |7 - sw/uiconfig/swriter/ui/editcategories.ui |9 - sw/uiconfig/swriter/ui/editsectiondialog.ui | 12 -- sw/uiconfig/swriter/ui/exchangedatabases.ui |9 - sw/uiconfig/swriter/ui/inputfielddialog.ui|7 - sw/uiconfig/swriter/ui/insertbookmark.ui |7 - sw/uiconfig/swriter/ui/insertbreak.ui |9 - sw/uiconfig/swriter/ui/insertcaption.ui | 44 +++ 20 files changed, 104 insertions(+), 230 deletions(-) New commits: commit 08880d659e976887eba5db22ece740df3ce89997 Author: Alexander Wilms f.alexander.wi...@gmail.com Date: Mon Dec 23 17:51:07 2013 +0100 Moved buttons columns to the bottom row Change-Id: If178363739231986e0e0e82c9d77f5ca0bc7 Reviewed-on: https://gerrit.libreoffice.org/7192 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sc/uiconfig/scalc/ui/inputstringdialog.ui b/sc/uiconfig/scalc/ui/inputstringdialog.ui index 2d48deb..c624cda 100644 --- a/sc/uiconfig/scalc/ui/inputstringdialog.ui +++ b/sc/uiconfig/scalc/ui/inputstringdialog.ui @@ -1,6 +1,7 @@ ?xml version=1.0 encoding=UTF-8? +!-- Generated with glade 3.16.0 -- interface - !-- interface-requires gtk+ 3.0 -- + requires lib=gtk+ version=3.0/ object class=GtkDialog id=InputStringDialog property name=can_focusFalse/property property name=border_width6/property diff --git a/sc/uiconfig/scalc/ui/insertcells.ui b/sc/uiconfig/scalc/ui/insertcells.ui index 92c4795..1a425b4 100644 --- a/sc/uiconfig/scalc/ui/insertcells.ui +++ b/sc/uiconfig/scalc/ui/insertcells.ui @@ -1,6 +1,7 @@ ?xml version=1.0 encoding=UTF-8? +!-- Generated with glade 3.16.0 -- interface - !-- interface-requires gtk+ 3.0 -- + requires lib=gtk+ version=3.0/ object class=GtkDialog id=InsertCellsDialog property name=can_focusFalse/property property name=border_width6/property @@ -9,21 +10,21 @@ child internal-child=vbox object class=GtkBox id=dialog-vbox1 property name=can_focusFalse/property +property name=orientationvertical/property property name=spacing12/property child internal-child=action_area object class=GtkButtonBox id=dialog-action_area3 property name=can_focusFalse/property -property name=orientationvertical/property property name=layout_stylestart/property child object class=GtkButton id=ok property name=labelgtk-ok/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=can_defaultTrue/property property name=has_defaultTrue/property property name=receives_defaultTrue/property -property name=use_action_appearanceFalse/property property name=use_stockTrue/property /object packing @@ -35,10 +36,10 @@ child object class=GtkButton id=cancel property name=labelgtk-cancel/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property -property name=use_action_appearanceFalse/property property name=use_stockTrue/property /object packing @@ -50,10 +51,10 @@ child object class=GtkButton id=help property name=labelgtk-help/property +property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property -property name=use_action_appearanceFalse/property property name=use_stockTrue/property property name=image_positiontop/property /object @@ -92,10 +93,10 @@ child object class=GtkRadioButton
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/exchangedatabases.ui |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit c5602cfb9d817a2dfbb46c012a4fc5cc0cc444e2 Author: Caolán McNamara caol...@redhat.com Date: Mon Dec 23 23:56:55 2013 + add a border to some widgets in exchange database Change-Id: I48fed93932db28ca1649c7e6c1abf4017757cd45 diff --git a/sw/uiconfig/swriter/ui/exchangedatabases.ui b/sw/uiconfig/swriter/ui/exchangedatabases.ui index bdbcc80..1085589 100644 --- a/sw/uiconfig/swriter/ui/exchangedatabases.ui +++ b/sw/uiconfig/swriter/ui/exchangedatabases.ui @@ -105,7 +105,7 @@ property name=xalign0/property property name=label translatable=yesDatabases in Use/property property name=use_underlineTrue/property -property name=mnemonic_widgetinuselb/property +property name=mnemonic_widgetinuselb:border/property /object packing property name=left_attach0/property @@ -121,7 +121,7 @@ property name=xalign0/property property name=label translatable=yes_Available Databases/property property name=use_underlineTrue/property -property name=mnemonic_widgetavailablelb/property +property name=mnemonic_widgetavailablelb:border/property /object packing property name=left_attach1/property @@ -166,7 +166,7 @@ Use the browse button to select a database file./property /packing /child child - object class=svtlo-SvTreeListBox id=inuselb + object class=svtlo-SvTreeListBox id=inuselb:border property name=visibleTrue/property property name=can_focusFalse/property property name=hexpandTrue/property @@ -180,7 +180,7 @@ Use the browse button to select a database file./property /packing /child child - object class=swlo-SwDBTreeList id=availablelb + object class=swlo-SwDBTreeList id=availablelb:border property name=visibleTrue/property property name=can_focusFalse/property property name=hexpandTrue/property ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - connectivity/source include/connectivity
connectivity/source/commontools/dbconversion.cxx | 16 +---
include/connectivity/dbconversion.hxx|2 +-
2 files changed, 14 insertions(+), 4 deletions(-)
New commits:
commit d2928f81ed1a58eac9f90382dcfe73ea8c482ed6
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Sat Dec 21 10:37:11 2013 +0100
fdo#72916 correct rounding of time part of DateTime
Change-Id: I135478755f9e5a844119129b470fef8de2cd0409
Reviewed-on: https://gerrit.libreoffice.org/7163
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/connectivity/source/commontools/dbconversion.cxx
b/connectivity/source/commontools/dbconversion.cxx
index 5aa5e1a..81b7744 100644
--- a/connectivity/source/commontools/dbconversion.cxx
+++ b/connectivity/source/commontools/dbconversion.cxx
@@ -26,6 +26,7 @@
#include com/sun/star/util/Time.hpp
#include com/sun/star/util/DateTime.hpp
#include rtl/ustrbuf.hxx
+#include rtl/math.hxx
#include unotools/datetime.hxx
#include sstream
#include iomanip
@@ -324,10 +325,15 @@ namespace dbtools
return aRet;
}
//
-
-utl::Time DBTypeConversion::toTime(double dVal)
+utl::Time DBTypeConversion::toTime(double dVal, short nDigits)
{
sal_Int32 nDays = (sal_Int32)dVal;
-sal_Int64 nNS = static_castsal_Int64((dVal - (double)nDays) *
fNanoSecondsPerDay + 0.5);
+sal_Int64 nNS;
+{
+double fSeconds((dVal - (double)nDays) * (fNanoSecondsPerDay /
nanoSecInSec));
+fSeconds = ::rtl::math::round( fSeconds, nDigits );
+nNS = fSeconds * nanoSecInSec;
+}
sal_Int16 nSign;
if ( nNS 0 )
@@ -370,7 +376,11 @@ namespace dbtools
utl::DateTime DBTypeConversion::toDateTime(double dVal, const utl::Date
_rNullDate)
{
utl::Date aDate = toDate(dVal, _rNullDate);
-utl::Time aTime = toTime(dVal);
+// there is not enough precision in a double to have both a date
+// and a time up to nanoseconds - limit to microseconds to have
+// correct rounding, that is e.g. 13:00:00.0 instead of
+// 12:59:59.99790
+utl::Time aTime = toTime(dVal, 6);
utl::DateTime xRet;
diff --git a/include/connectivity/dbconversion.hxx
b/include/connectivity/dbconversion.hxx
index 3fe7c0c0..82345b1 100644
--- a/include/connectivity/dbconversion.hxx
+++ b/include/connectivity/dbconversion.hxx
@@ -105,7 +105,7 @@ namespace dbtools
static ::com::sun::star::util::Date toDate(double dVal, const
::com::sun::star::util::Date _rNullDate = getStandardDate());
static ::com::sun::star::util::Date toDate(const OUString
_sSQLDate);
-static ::com::sun::star::util::Time toTime(double dVal);
+static ::com::sun::star::util::Time toTime(double dVal, short
nDigits = 9);
static ::com::sun::star::util::Time toTime(const OUString
_sSQLDate);
static ::com::sun::star::util::DateTime toDateTime(double dVal, const
::com::sun::star::util::Date _rNullDate = getStandardDate());
static ::com::sun::star::util::DateTime toDateTime(const OUString
_sSQLDate);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/hicontrast icon-themes/sifr svx/source
icon-themes/hicontrast/svx/res/symphony/fill_color.png |binary icon-themes/sifr/svx/res/symphony/fill_color.png |binary svx/source/sidebar/paragraph/ParaPropertyPanel.cxx |2 +- 3 files changed, 1 insertion(+), 1 deletion(-) New commits: commit 1d48659915580abdc4d5e885608c0d61c79a5046 Author: Maxim Monastirsky momonas...@gmail.com Date: Wed Dec 11 15:32:17 2013 +0200 fdo#71748 Fix also for hicontrast and sifr themes A follow-up of commit e239f372c6abcd8371d0a666c828bf1c31195dd4. Didn't notice there is fill_color.png also in these themes. Also fixed the ugly yellow color flash of paragraph color picker while initializing the sidebar (introduced by the above commit). This color picker shows the actual color of a paragraph, so there is no reason to set some default color there. Change-Id: I17eed733d1e35ec71c482e3df906523733383e96 Reviewed-on: https://gerrit.libreoffice.org/7035 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/icon-themes/hicontrast/svx/res/symphony/fill_color.png b/icon-themes/hicontrast/svx/res/symphony/fill_color.png index 7cbafa5..20e5081 100644 Binary files a/icon-themes/hicontrast/svx/res/symphony/fill_color.png and b/icon-themes/hicontrast/svx/res/symphony/fill_color.png differ diff --git a/icon-themes/sifr/svx/res/symphony/fill_color.png b/icon-themes/sifr/svx/res/symphony/fill_color.png index 7cbafa5..a53abdd 100644 Binary files a/icon-themes/sifr/svx/res/symphony/fill_color.png and b/icon-themes/sifr/svx/res/symphony/fill_color.png differ diff --git a/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx b/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx index dbb63b1..361231e 100644 --- a/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx +++ b/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx @@ -346,7 +346,7 @@ void ParaPropertyPanel::InitToolBoxBGColor() const sal_uInt16 nIdBackColor = mpTBxBackColor-GetItemId(UNO_PARABACKCOLOR); mpTBxBackColor-SetItemImage(nIdBackColor, GetDisplayBackground().GetColor().IsDark()? maImgBackColorHigh : maImgBackColor); -mpColorUpdater.reset(new ::svx::ToolboxButtonColorUpdater(SID_BACKGROUND_COLOR, nIdBackColor, mpTBxBackColor)); +mpColorUpdater.reset(new ::svx::ToolboxButtonColorUpdater(0 /* not defined, default is transparent */, nIdBackColor, mpTBxBackColor)); mpTBxBackColor-SetItemBits( nIdBackColor, mpTBxBackColor-GetItemBits( nIdBackColor ) | TIB_DROPDOWNONLY ); Link aLink = LINK(this, ParaPropertyPanel, ToolBoxBackColorDDHandler); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/source
svx/source/sidebar/paragraph/ParaPropertyPanel.src |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit b90d65f5c697806ee9b70a3ea8fb0f154241335f
Author: Maxim Monastirsky momonas...@gmail.com
Date: Wed Dec 11 14:42:18 2013 +0200
Fix typo
Change-Id: Ie2e3cfa3c35f5ccb59420afb13f5142ecdcb659e
Reviewed-on: https://gerrit.libreoffice.org/7033
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/svx/source/sidebar/paragraph/ParaPropertyPanel.src
b/svx/source/sidebar/paragraph/ParaPropertyPanel.src
index 7dc425c..459ea6a 100644
--- a/svx/source/sidebar/paragraph/ParaPropertyPanel.src
+++ b/svx/source/sidebar/paragraph/ParaPropertyPanel.src
@@ -49,11 +49,11 @@
Image IMG_BACK_COLOR
{
-ImageBitmap = Bitmap{File = symphony/sc_backgroundcolor.bmp;};
+ImageBitmap = Bitmap{File = symphony/sc_backgroundcolor.png;};
};
Image IMG_BACK_COLOR_H
{
-ImageBitmap = Bitmap{File = symphony/sch_backgroundcolor.bmp;};
+ImageBitmap = Bitmap{File = symphony/sch_backgroundcolor.png;};
};
Image IMG_SPACE3
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/ui/inc/unomailmerge.hxx |4
sw/source/ui/uno/unomailmerge.cxx | 25 ++---
2 files changed, 10 insertions(+), 19 deletions(-)
New commits:
commit a5504e49dba07f7217ad3c0980d8c0f21f9f646c
Author: Jan-Marek Glogowski glo...@fbihome.de
Date: Sun Dec 22 17:37:28 2013 +0100
Cleanup SwXMailMerge constructor.
Move all fixed initializers into constructor definition.
Change-Id: I7317deae43abf6a9e865c66969cb39a4b69de826
Reviewed-on: https://gerrit.libreoffice.org/7189
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/ui/inc/unomailmerge.hxx
b/sw/source/ui/inc/unomailmerge.hxx
index 9b9a4c1..2be74c6 100644
--- a/sw/source/ui/inc/unomailmerge.hxx
+++ b/sw/source/ui/inc/unomailmerge.hxx
@@ -113,7 +113,6 @@ class SwXMailMerge :
sal_BoolbSinglePrintJobs;
sal_BoolbFileNameFromColumn;
-
OUString sInServerPassword;
OUString sOutServerPassword;
OUString sSubject;
@@ -133,11 +132,8 @@ class SwXMailMerge :
OUString sSaveFilterOptions;
com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyValue
aSaveFilterData;
-
-
sal_BoolbDisposing;
-
voidlaunchEvent( const com::sun::star::beans::PropertyChangeEvent
rEvt ) const;
// disallow use of copy-constructor and assignment-operator for now
diff --git a/sw/source/ui/uno/unomailmerge.cxx
b/sw/source/ui/uno/unomailmerge.cxx
index f9d2b0c..717a095 100644
--- a/sw/source/ui/uno/unomailmerge.cxx
+++ b/sw/source/ui/uno/unomailmerge.cxx
@@ -373,29 +373,24 @@ SwXMailMerge::SwXMailMerge() :
aMergeListeners ( GetMailMergeMutex() ),
aPropListeners ( GetMailMergeMutex() ),
pPropSet( aSwMapProvider.GetPropertySet( PROPERTY_MAP_MAILMERGE ) ),
+nDataCommandType(sdb::CommandType::TABLE),
+nOutputType(MailMergeType::PRINTER),
+bEscapeProcessing(sal_True), //!! allow to process properties like
Filter, Order, ...
+bSinglePrintJobs(sal_False),
+bFileNameFromColumn(sal_False),
bSendAsHTML(sal_False),
bSendAsAttachment(sal_False),
-bSaveAsSingleFile(sal_False)
-
+bSaveAsSingleFile(sal_False),
+bDisposing(sal_False)
{
// create empty document
// like in: SwModule::InsertEnv (appenv.cxx)
-SwDocShell *pDocShell = new SwDocShell( SFX_CREATE_MODE_STANDARD );
-xDocSh = pDocShell;
+xDocSh = new SwDocShell( SFX_CREATE_MODE_STANDARD );
xDocSh-DoInitNew( 0 );
SfxViewFrame *pFrame = SfxViewFrame::LoadHiddenDocument( *xDocSh, 0 );
SwView *pView = (SwView*) pFrame-GetViewShell();
-pView-AttrChangedNotify( pView-GetWrtShell() );//So that SelectShell is
called.
-
-xModel = pDocShell-GetModel();
-
-nDataCommandType= sdb::CommandType::TABLE;
-nOutputType = MailMergeType::PRINTER;
-bEscapeProcessing = sal_True; //!! allow to process properties like
Filter, Order, ...
-bSinglePrintJobs= sal_False;
-bFileNameFromColumn = sal_False;
-
-bDisposing = sal_False;
+pView-AttrChangedNotify( pView-GetWrtShell() ); //So that SelectShell
is called.
+xModel = xDocSh-GetModel();
}
SwXMailMerge::~SwXMailMerge()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Libreoffice and kde integration
Hi Michael, On Mon, Dec 23, 2013 at 09:58:30PM +, Michael Meeks wrote: On Mon, 2013-12-23 at 21:10 + wrote: Why does the autogen.sh that is used to compile the build, Linux - rpm (x86), version 4.1.4, English (US) have the flags - Sure - this is because the rather old system we compile the generic linux builds on (which needs to be that old so we can run on all newer systems) can't feasibly have KDE4 installed. I tried to make a magic assembler tool to stub the libraries to overcome that without success - it's a bit of a pain. --disable-kde4 --enable-kde in the file LibreOfficeLinux.conf. Sure - and also --enable-gnome-vfs as well as --disable-gio is a similar disaster caused by the same issue. It's all to do with what we can get to install on a reasonably vanilla CentOS 5 (IIRC). Ah, I finally get what you were up too with that kde-stub-libs-foo. ;) Just brainstorming, I wonder if it would be easier to do roughly what distros do in these cases, for the 'integration' parts of LibreOffice that connect with other infrastructure on the OS (mostly the above mentioned kde/gtk/gnome-foo), namely: simply using a newer baseline. Now using two baselines, one for 'core' LibreOffice which is truely ancient and one for system integration, which is more recent, and building parts of LibreOffice in each can be assumed to sounds like madness and probably is. Im just not sure if using some symbols stubs lib approach is less painful in the end. Best, Bjoern P.S.: Note that the 'use two baselines' thing is likely easier than it sounds as tools like pbuilder are around and automate most of that away. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: bridges/source include/sal
bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx | 30 +++
include/sal/log-areas.dox|7 +++-
2 files changed, 24 insertions(+), 13 deletions(-)
New commits:
commit 86a372ade0b7d416d4ff97a94ea350f56610da61
Author: Tor Lillqvist t...@collabora.com
Date: Mon Dec 23 21:12:05 2013 +0200
More informative logging in codeSnippet()
Change-Id: I6909ed60b39a65e6a6464427b2f839aa2bff3863
diff --git a/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
b/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
index 4fe5377..52911af 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
@@ -361,6 +361,8 @@ extern C typedef void (*PrivateSnippetExecutor)();
int const codeSnippetSize = 16;
unsigned char * codeSnippet(
+const typelib_InterfaceTypeDescription *type,
+const typelib_TypeDescription *member,
unsigned char * code, sal_Int32 functionIndex, sal_Int32 vtableOffset,
typelib_TypeDescriptionReference * pReturnTypeRef)
{
@@ -427,18 +429,19 @@ unsigned char * codeSnippet(
= ((unsigned char *) exec) - p - sizeof (sal_Int32);
p += sizeof (sal_Int32);
OSL_ASSERT(p - code = codeSnippetSize);
-#if OSL_DEBUG_LEVEL 1
-fprintf(stderr,
-== codeSnippet to %s, functionIndex=%lu%s,
vtableOffset=%SAL_PRIdINT32\n,
-(exec == privateSnippetExecutorGeneral ? General :
- (exec == privateSnippetExecutorVoid ? Void :
- (exec == privateSnippetExecutorHyper ? Hyper :
- (exec == privateSnippetExecutorFloat ? Float :
-(exec == privateSnippetExecutorDouble ? Double :
- (exec == privateSnippetExecutorClass ? Class :
- ???)),
-(functionIndex ~0x8000), (functionIndex 0x8000) ?
|0x8000:, vtableOffset);
-#endif
+
+SAL_INFO( bridges.osx, codeSnippet(
+ OUString(type-aBase.pTypeName) ::
OUString(member-pTypeName) ): [
+ (functionIndex ~0x8000) ((functionIndex
0x8000) ? |0x8000:) , vtableOffset ,
+ (exec == privateSnippetExecutorGeneral ? General :
+ (exec == privateSnippetExecutorVoid ? Void :
+ (exec == privateSnippetExecutorHyper ? Hyper :
+(exec == privateSnippetExecutorFloat ? Float :
+ (exec == privateSnippetExecutorDouble ? Double :
+ (exec == privateSnippetExecutorClass ? Class :
+ ???))
+ ]= (void *)(code + codeSnippetSize) );
+
return code + codeSnippetSize;
}
@@ -484,6 +487,7 @@ unsigned char *
bridges::cpp_uno::shared::VtableFactory::addLocalFunctions(
// Getter:
(s++)-fn = code;
code = codeSnippet(
+type, member,
code, functionOffset++, vtableOffset,
reinterpret_cast typelib_InterfaceAttributeTypeDescription *
(
member)-pAttributeTypeRef);
@@ -494,6 +498,7 @@ unsigned char *
bridges::cpp_uno::shared::VtableFactory::addLocalFunctions(
{
(s++)-fn = code;
code = codeSnippet(
+type, member,
code, functionOffset++, vtableOffset,
0 /* indicates VOID */);
}
@@ -502,6 +507,7 @@ unsigned char *
bridges::cpp_uno::shared::VtableFactory::addLocalFunctions(
case typelib_TypeClass_INTERFACE_METHOD:
(s++)-fn = code;
code = codeSnippet(
+type, member,
code, functionOffset++, vtableOffset,
reinterpret_cast typelib_InterfaceMethodTypeDescription * (
member)-pReturnTypeRef);
diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 5168e81..a53727b 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -40,6 +40,12 @@ certain functionality.
@li @c basic
@li @c basic.sbx
+@section bridges
+
+@li @c bridges
+@li @c bridges.ios
+@li @c bridges.osx
+
@section canvas
@li @c canvas
@@ -426,7 +432,6 @@ certain functionality.
@li @c avmedia
@li @c basebmp
@li @c binaryurp
-@li @c bridges
@li @c configmgr
@li @c cppcanvas
@li @c cppcanvas.emf
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: My Windows build is much slower than Linux build. Any way to speed up?
On Mon, Dec 23, 2013 at 04:15:30PM +0100, Bjoern Michaelsen wrote: Finally, Michael Stahl is considering moving gbuild to work on a native windows GNU make without the cygwin wrapper. But that likely is quite a bit of work. FWIW, to not sabotage that goal it would be wise to try to restrict dependencies of the build system to(*): http://gnuwin32.sourceforge.net/packages/make.htm http://gnuwin32.sourceforge.net/packages/coreutils.htm http://gnuwin32.sourceforge.net/packages/gawk.htm http://gnuwin32.sourceforge.net/packages/sed.htm and plain C (like our concat-deps.c) -- at least for stuff that is used on Windows. Thus maybe consider those options instead, when you want to add some Perl or Python stuff that is used in the core build system(**). Best, Bjoern (*) possibly: using only http://www.busybox.net/ instead of coreutils, gawk, sed. (**) OTOH, we are bringing our own copy of Python on Windows anyway, but using it in the build is somewhat problematic both because its hardly a lightweight dependency for bootstrapping and probably a also a bottleneck increasing buildtime. So: meh. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39749] calc unit test writing
https://bugs.freedesktop.org/show_bug.cgi?id=39749 --- Comment #4 from Ravi ravi.mandl...@gmail.com --- Hi I am a student at clemson university, and I would really really like to contribute on this one.This is my first interaction with any open source project. I have worked on personal C++ projects, and have good grip on language. The following link mentioned in first comment - http://comments.gmane.org/gmane.comp.documentfoundation.libreoffice.qa/42 says No such message. So far: 1. I have downloaded and build libreoffice. 2. I have looked into sc/qa/unit/ folders and tried to understand already built unit tests. 3. I understand that the helper folder contains the handler files which loads csv test data (from data folder) and run thesetests. 4. However, I am still not sure, how exactly these unit tests are run, where is the main function,how to load the data?. A little help or a link to document where this is explained would be of awesome help. My question is How exactly do we run these unit tests?. I really intent to contribute and learn. I am a quick learner, and I really find it interesting. I would really appreciate some pointers. Like where exactly the class files located, for which we are building test cases?, some example test cases for any other module we have. Thanks and Regards Ravi Mandliya -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 3 commits - bridges/source ucbhelper/source
bridges/source/cpp_uno/gcc3_ios_arm/cpp2uno-arm64.cxx | 12 bridges/source/cpp_uno/gcc3_ios_arm/except.cxx|6 ++-- ucbhelper/source/provider/cancelcommandexecution.cxx | 27 +- 3 files changed, 37 insertions(+), 8 deletions(-) New commits: commit 55c6dade042eff373b8b8c9ed383b751c035fc80 Author: Tor Lillqvist t...@collabora.com Date: Tue Dec 24 03:18:45 2013 +0200 Hacky workaround for non-working C++/UNO bridge for arm64 iOS I haven't managed to get the C++/UNO bridge to work for 64-bit iOS code yet. I think I understand the calling convention and the parameter marshalling etc might even be correct now. But something goes wrong in the dynamic creation of type_infos and throwing of exceptions. 64-bit iOS code uses a different unwinding mechanism than 32-bit iOS code, I think, which could be related. Quite possibly there is also an unintended compiler feature (or dare I say bug?) in Apple's Clang for arm64 that affects this: The typeinfos are generated as private_extern symbols in arm64 code (instead of as normal extern in armv7 code), thus the dlsym() thing to look up typeinfos doesn't work. Note that as we don't support any Basic, Java or Python on iOS anyway, the C++/UNO bridge is not used for much. Actually, the only use of the bridge at least in the TiledLibreOffice test app seems to be to throw exceptions. Fun, huh? As the actual types of exceptions thrown seems to be a quite small set, just hack it and throw the appropriate exception directly... The only places where exceptions are thrown through the bridge that is used in the test app seems to be the two cancelCommandExecution() functions in ucbhelper. (It would be nice to change the ucbhelper API to not use exceptions for non-exceptional conditions, but that's another thing...) Change-Id: Ifd1861ccbba23d3b138e82400f2b7d80baf0215a diff --git a/ucbhelper/source/provider/cancelcommandexecution.cxx b/ucbhelper/source/provider/cancelcommandexecution.cxx index 91bcd79..617c96c 100644 --- a/ucbhelper/source/provider/cancelcommandexecution.cxx +++ b/ucbhelper/source/provider/cancelcommandexecution.cxx @@ -25,7 +25,10 @@ */ #include osl/diagnose.h #include cppuhelper/exc_hlp.hxx +#include com/sun/star/lang/IllegalArgumentException.hpp #include com/sun/star/ucb/CommandFailedException.hpp +#include com/sun/star/ucb/InteractiveAugmentedIOException.hpp +#include com/sun/star/ucb/NameClashException.hpp #include com/sun/star/ucb/XCommandEnvironment.hpp #include ucbhelper/interactionrequest.hxx #include ucbhelper/cancelcommandexecution.hxx @@ -71,8 +74,23 @@ void cancelCommandExecution( const uno::Any rException, } } -cppu::throwException( rException ); +#if defined IOS defined __arm64 +// No Java, Basic, or Python on iOS, so try to throw the exception +// directly. Much simpler. Especially as I haven't managed yet to +// get the C++/UNO bridge to work for arm64, and this +// cppu::throwException thing seems to be the only use for it, at +// least in the test apps... + +ucb::NameClashException aNCE; +if ( rException = aNCE ) +throw aNCE; + +lang::IllegalArgumentException aIAE; +if ( rException = aIAE ) +throw aIAE; +#endif +cppu::throwException( rException ); OSL_FAIL( Return from cppu::throwException call!!! ); throw uno::RuntimeException(); } @@ -109,6 +127,13 @@ void cancelCommandExecution( const ucb::IOErrorCode eError, } } +#if defined IOS defined __arm64 +// See comment above. +ucb::InteractiveAugmentedIOException aExc; +if ( xRequest-getRequest() = aExc ) +throw aExc; +#endif + cppu::throwException( xRequest-getRequest() ); OSL_FAIL( Return from cppu::throwException call!!! ); commit 69ea6062d280b93d8372f508864aab60dd810917 Author: Tor Lillqvist t...@collabora.com Date: Tue Dec 24 03:12:29 2013 +0200 Minor logging change Change-Id: I2d25c7c196d0386a1c38fa55746370a84c2a2398 diff --git a/bridges/source/cpp_uno/gcc3_ios_arm/except.cxx b/bridges/source/cpp_uno/gcc3_ios_arm/except.cxx index 01690d3..71171ff 100644 --- a/bridges/source/cpp_uno/gcc3_ios_arm/except.cxx +++ b/bridges/source/cpp_uno/gcc3_ios_arm/except.cxx @@ -169,7 +169,7 @@ RTTI::RTTI() SAL_THROW(()) // Insert commonly needed type_infos to avoid dlsym() calls // Ideally we should insert all needed ones m_rttis.insert( t_rtti_map::value_type( com.sun.star.ucb.InteractiveAugmentedIOException, -typeid( com::sun::star::ucb::InteractiveAugmentedIOException ) ) ); +(std::type_info*) typeid( com::sun::star::ucb::InteractiveAugmentedIOException ) ) ); #endif } @@ -207,7 +207,7 @@ std::type_info *
[Bug 39749] calc unit test writing
https://bugs.freedesktop.org/show_bug.cgi?id=39749 --- Comment #5 from Markus Mohrhard markus.mohrh...@googlemail.com --- (In reply to comment #4) Hi I am a student at clemson university, and I would really really like to contribute on this one.This is my first interaction with any open source project. I have worked on personal C++ projects, and have good grip on language. The following link mentioned in first comment - http://comments.gmane.org/gmane.comp.documentfoundation.libreoffice.qa/42 says No such message. So far: 1. I have downloaded and build libreoffice. 2. I have looked into sc/qa/unit/ folders and tried to understand already built unit tests. 3. I understand that the helper folder contains the handler files which loads csv test data (from data folder) and run thesetests. Great. These are already the most important steps. 4. However, I am still not sure, how exactly these unit tests are run, where is the main function,how to load the data?. A little help or a link to document where this is explained would be of awesome help. My question is How exactly do we run these unit tests?. They are controlled by the makefiles in sc/. sc/Module_sc.mk contains which tests are actually included and the corresponding makefiles in sc/ how to build them. The main function is in sal/ inside the cppunittester applciation but we don't touch that part of the code when we write tests. The cppunittester is included into the test through the CPPUNIT_PLUGIN_IMPLEMENT macro and the remaining cppunit macros register the tests in cppunit. More information abotu cppunit can be found at http://people.freedesktop.org/~mmohrhard/cppunit/index.html So most of the file loading is already abstracted and hidden behind some layers in our testing framework. You need to follow the different class hierarchy that goes into test/ and unotest/. Depending on the test we either use direct calls to the Libreoffice code or use the public UNO API. Taking sc/qa/unit/filters-test.cxx as an example and picking testRangeNameODS which tests the import of range names from ODS. Test method is declared in line 63, added to the test suite in line 84, and definition starts in line 224. The first call in that method loads the file and returns the corresponding ScDocShell (an internal representation of a calc document). Sadly there is not much documentation except for https://wiki.documentfoundation.org/Development/Calc_Import_Unit_Tests which I wrote when i first implemented the csv based document comparison. Most of this page should still be correct. I really intent to contribute and learn. I am a quick learner, and I really find it interesting. I would really appreciate some pointers. Like where exactly the class files located, for which we are building test cases?, some example test cases for any other module we have. So these are not real unit tests and we don't test single classes. You can call it regression testing or integration testing. Basically we normally try to test the correct interaction of larger pieces of the code. Testing single classes is nearly never possible in our code base. There are some exceptions for lower levels where we have real unit tests (also the sc_rangelst_test does something similar). So normally we test parts of sc/source/core or sc/source/filter or both together. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/chart-opengl2' - chart2/Library_chartopengl.mk
chart2/Library_chartopengl.mk | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) New commits: commit ddd174dd1b0cb0b27580bf335ade1ebf76ae7287 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Dec 24 04:37:42 2013 +0100 blind fix for reported Windows build error Change-Id: Ia106f5b1ec5177099c098390ece7fda1a478078c diff --git a/chart2/Library_chartopengl.mk b/chart2/Library_chartopengl.mk index 2532fc3..aa4a77e 100644 --- a/chart2/Library_chartopengl.mk +++ b/chart2/Library_chartopengl.mk @@ -31,11 +31,23 @@ $(eval $(call gb_Library_use_externals,chartopengl,\ )) $(eval $(call gb_Library_use_libraries,chartopengl,\ +basegfx \ chartcore \ +comphelper \ cppu \ cppuhelper \ +drawinglayer \ +editeng \ +fwe \ +i18nlangtag \ sal \ - svxcore \ +sfx \ +svl \ +svt \ +svxcore \ +tl \ +ucbhelper \ +utl \ vcl \ $(gb_UWINAPI) \ )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/chart-opengl2' - chart2/source
chart2/source/view/main/OpenGLRender.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 25158c98a003318ed7d52bf3478a095045f81944
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Tue Dec 24 04:50:42 2013 +0100
fix regression from last warning cleaning
Change-Id: Id4f758a6d27670ff03d4e0c32a45ca66cc74d0c6
diff --git a/chart2/source/view/main/OpenGLRender.cxx
b/chart2/source/view/main/OpenGLRender.cxx
index 92489c3..2ff2017 100644
--- a/chart2/source/view/main/OpenGLRender.cxx
+++ b/chart2/source/view/main/OpenGLRender.cxx
@@ -654,19 +654,19 @@ int OpenGLRender::RenderLine2FBO(int wholeFlag)
BitmapEx aBmp;
aBmp.SetSizePixel(Size(m_iWidth, m_iHeight));
-Bitmap aBitmap( aBmp.GetBitmap() );
-Bitmap aAlpha( aBmp.GetAlpha().GetBitmap() );
+Bitmap aBitmap( Size( m_iWidth, m_iHeight), 24 );
+Bitmap aAlpha( Size( m_iWidth, m_iHeight), 24 );
Bitmap::ScopedWriteAccess pWriteAccess( aBitmap );
Bitmap::ScopedWriteAccess pAlphaWriteAccess( aAlpha );
size_t nCurPos = 0;
-for( int y = 0; y m_iHeight; ++y)
+for( size_t y = 0; y m_iHeight; ++y)
{
Scanline pScan = pWriteAccess-GetScanline(y);
Scanline pAlphaScan = pAlphaWriteAccess-GetScanline(y);
-for( int x = 0; x m_iWidth; ++x )
+for( size_t x = 0; x m_iWidth; ++x )
{
*pScan++ = buf[nCurPos];
*pScan++ = buf[nCurPos+1];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice Gerrit News for core on 2013-12-24
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things ! + fdo#60698: Merge odbcbase into odbc in https://gerrit.libreoffice.org/6929 from Marcos Souza about module build, connectivity, solenv + Export MailMerge cancel functionality via UNO. in https://gerrit.libreoffice.org/7190 from Jan-Marek Glogowski about module offapi, sw + Fix perl errors in installer modules. in https://gerrit.libreoffice.org/7188 from Jan-Marek Glogowski about module solenv + User grants debug Mysql part: first steps in https://gerrit.libreoffice.org/7140 from Julien Nabet about module connectivity, dbaccess + svt: Use constructor feature for ODocumentCloser. in https://gerrit.libreoffice.org/7186 from Matúš Kukan about module svtools + fdo#72219: Fix for corruption of symbols in docx in https://gerrit.libreoffice.org/6955 from Rohit Deshmukh about module i18npool, sw End of freshness * Merged changes on master for project core changed in the last 25 hours: + Cleanup SwXMailMerge constructor. in https://gerrit.libreoffice.org/7189 from Jan-Marek Glogowski + Fix typo in https://gerrit.libreoffice.org/7033 from Maxim Monastirsky + fdo#71748 Fix also for hicontrast and sifr themes in https://gerrit.libreoffice.org/7035 from Maxim Monastirsky + Moved buttons columns to the bottom row in https://gerrit.libreoffice.org/7192 from Alexander Wilms + Made button caption in bib entry dialog clearer in https://gerrit.libreoffice.org/7179 from Alexander Wilms + sw: small code refactor in https://gerrit.libreoffice.org/7187 from Jacobo Aragunde Pérez * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + sdremote: show notes also in landscape orientation in https://gerrit.libreoffice.org/6889 from Christian Lohmaier + fix Bluetooth lifecycle problems and respect UI guidelines in https://gerrit.libreoffice.org/7083 from Christian Lohmaier + get rid of custom all-caps ui widget in https://gerrit.libreoffice.org/6903 from Christian Lohmaier + Double toolbar icon size for HiDPI screens. in https://gerrit.libreoffice.org/6994 from Andrzej Hunt + sw/export docx: add unit test for document with header and section(s) in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer + add a header to provide posix compatible wrapper for platform lacking in https://gerrit.libreoffice.org/6837 from Norbert Thiebaud + Code clean-up/consolidation task. in https://gerrit.libreoffice.org/5926 from Vishv Brahmbhatt + fix for exporting of text watermark to DOCX in https://gerrit.libreoffice.org/5568 from Adam CloudOn + WIP: fdo#33980 Preserve selection across all slide sorters. in https://gerrit.libreoffice.org/6633 from Andrzej Hunt + fdo#71043 - Use STACK lint tool to clean code in https://gerrit.libreoffice.org/6529 from José Guilherme Vanz + new cell-border handling in calc in https://gerrit.libreoffice.org/6093 from Viktor Varga + Increase number of remembered recent documents from 10 to 25 in https://gerrit.libreoffice.org/6101 from Krisztian Pinter + startcenter: Make SC open faster by timeouting thumbnails in https://gerrit.libreoffice.org/6102 from Krisztian Pinter + Simplify oslThreadIdentifier on Linux 32. in https://gerrit.libreoffice.org/5553 from Arnaud Versini + Dynamically align toolbars in LibreOffice in https://gerrit.libreoffice.org/5655 from Prashant Pandey + fdo#36791 : fix for import of greeting card in https://gerrit.libreoffice.org/4240 from Adam CloudOn + more debug logs, extra debug layer, file is not used in p3k in https://gerrit.libreoffice.org/5267 from James Michael Dupont + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn + fdo#64817 : fix for rectangle with image fill in https://gerrit.libreoffice.org/4718 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlimport/data/rprchange_closed.docx |binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx|8
writerfilter/source/ooxml/model.xml |3 +++
3 files changed, 11 insertions(+)
New commits:
commit 75e7d6f12e914b63e66968890533b2a56d0b1a7e
Author: Zolnai Tamás tamas.zol...@collabora.com
Date: Tue Dec 24 08:05:58 2013 +0100
DOCX import: close rPrChange properly.
Call endtrackchanges when rPrChange ends so the
corresponding redline will be removed.
Change-Id: I4091d7b54e0a74f3158cc979f210577a2dc29783
diff --git a/sw/qa/extras/ooxmlimport/data/rprchange_closed.docx
b/sw/qa/extras/ooxmlimport/data/rprchange_closed.docx
new file mode 100644
index 000..ff53871
Binary files /dev/null and
b/sw/qa/extras/ooxmlimport/data/rprchange_closed.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 9198cc6..e91de29 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -1652,6 +1652,14 @@ DECLARE_OOXMLIMPORT_TEST(testFdo72560, fdo72560.docx)
CPPUNIT_ASSERT_EQUAL(text::WritingMode2::LR_TB, getPropertysal_Int16(
xParaRightLTR, WritingMode ));
CPPUNIT_ASSERT_EQUAL( sal_Int32 (style::ParagraphAdjust_RIGHT),
getProperty sal_Int32 ( xParaRightLTR, ParaAdjust ));
}
+
+DECLARE_OOXMLIMPORT_TEST(testRPrChangeClosed, rprchange_closed.docx)
+{
+// Redline defined by rPrChanged wasn't removed.
+// First paragraph has an rPrChange element, make sure it doesn't appear
in the second paragraph.
+CPPUNIT_ASSERT_EQUAL(false, hasProperty(getRun(getParagraph(2), 1),
RedlineType));
+}
+
#endif
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/ooxml/model.xml
b/writerfilter/source/ooxml/model.xml
index 4eec1ed..bf556ae 100644
--- a/writerfilter/source/ooxml/model.xml
+++ b/writerfilter/source/ooxml/model.xml
@@ -22152,6 +22152,9 @@
/resource
resource name=CT_RPrChange resource=Properties tag=character
element name=rPr tokenid=ooxml:CT_RPrChange_rPr/
+ action name=end action=tokenproperty/
+ action name=end action=propagateCharacterPropertiesAsSet
sendtokenid=ooxml:endtrackchange/
+ action name=end action=clearProps/
/resource
resource name=CT_ParaRPrChange resource=Properties tag=character
element name=rPr tokenid=ooxml:CT_ParaRPrChange_rPr/
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] 27 to go before we're under 900!
22 Ara 2013 16:30 tarihinde Robinson Tryon bishop.robin...@gmail.com yazdı: Hi Robinson We're almost there! Congrats :) Just wondering. How many NEEDINFO bugs do we have? Best regards, Zeki ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] 27 to go before we're under 900!
On Mon, Dec 23, 2013 at 1:21 AM, Zeki Bildirici zeki.ozguryazi...@gmail.com wrote: Just wondering. How many NEEDINFO bugs do we have? 869 See table of bug counts by status here: https://bugs.libreoffice.org/report.cgi?y_axis_field=bug_statusquery_format=report-tableproduct=LibreOfficeformat=tableaction=wrap Cheers, --R ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Feedback page up
Hi all, The first draft of the Feedback page is now up on the QA site. Big thanks to cloph for massaging the code into a Silverstripe-friendly format: http://qa.libreoffice.org/feedback/ The page uses the HTML vars passed-in by LibreOffice: https://www.libreoffice.org/get-help/bug/?LOversion=4.2.0.1LOlocale=en-USLOmodule=TextDocument When we update the BSA to accept passed-in variables, this will allow us to automatically fill-in a bunch of information about the bug reporter's system. In the future, we could include additional information such as OS, architecture, and extensions. Sophie - Please let us know if you run into any hurdles testing-out localization of the page. If you have any other notes/info about how to localize a page (esp. based on information passed-in via HTML vars), please document that info on the wiki and link to it from here: https://wiki.documentfoundation.org/Silverstripe Please play around with the page and give us some feedback, folks! Cheers, --R ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Moztrap: relation between version/runs/cases
Hi Sophie / all, It is really amazing the testing was push forward so much :) Thanks a lot for working on this. Merry Christmas and God bless us all! Best wishes, Yifan On Fri, Dec 20, 2013 at 01:18:47PM +0100, Sophie Gautier wrote: Hi Yifan, Le 19/12/2013 10:56, Yifan Jiang a écrit : Hi Sophie, A direct guess of mine is the new test cases not included in a test suite, which is the only way to get test cases in a test run. Your guess is right, I missed this step, I thought once added the P3 tag, it goes in the series. That is to say, when a test run is being created, selecting corresponding test suite wrapping those cases is the only method for us to select wanted test cases. So before the test run is created, the target test cases should be there in a test suite. This is actually a way I don't really like :( ok, I understand. So when creating a brand new test case, there's chance to select which test suite should it be in: http://manual-test.libreoffice.org/manage/case/add/ ok, I see my mistake here Unfortunately the UI seems not there when editing an existed case. In this situation, we need to edit the test suite in: http://manual-test.libreoffice.org/manage/suites/ and edit P3 test suite here: http://manual-test.libreoffice.org/manage/suite/12/ in the page, the p3 tag search in the left hand side panel is usable to get the wizard specific cases. ok, thanks a lot, I see now how I can correct my mistake :) In addition, updating the test suite does not update test run on the fly, we need to recreate a test run after doing proper test suite set up. ah ok, noted. It seems we are having much more fun with Moztrap, my further comments as below. Cheers :) Best wishes, Yifan On Wed, Dec 18, 2013 at 11:51:21AM +0100, Sophie Gautier wrote: Hi Yi Fan, all I need some help to understand the relation between test cases, run, versions. - when I create a new Version (LibreOffice 4.2.0), I indicate that test cases are based on LibreOffice 0 Yes, that's right. - then I've created 4.2.0 beta2 and 4.2.0RC1 runs always based on LibreOffice 0 test cases When you created test runs, the cases in them are based on test suites in the version. So in this scenario, the runs should have been based on Libreoffice 4.2.0 Version+Selected test suites Yes, I see the difference, thanks The problem I encounter currently is that if I modify test cases or create new one on LibreOffice 0, they are not updated to the new run I will create for this version. Before creating 4.0.2 RC1 run, I've added two new test cases to check wizards feature in Writer, but they don't appear in this run. It seems that the test cases appear only if I create a new Version. Or may be there is something wrong that I'm doing? I've tried several time without finding a solution. Ditto :) May be I can delete the actual LibreOffice 4.2.0 version and recreate it, but what would happen to the existing 4.2.0 beta2 run? It doesn't help if test cases are not in a test suite :) Yes, thank you very much for your help. I think I've understand the whole process now. Cheers Sophie -- Yifan Jiang SUSE Desktop, Libreoffice /SUSE Contact: yifan - irc.freenode.net/libreoffice = http://www.libreoffice.org/ http://www.documentfoundation.org/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Feedback page up
Good morning Robinson, *, On Dienstag, 24. Dezember 2013 00:52 Robinson Tryon wrote: The first draft of the Feedback page is now up on the QA site. Big thanks to cloph for massaging the code into a Silverstripe-friendly format: http://qa.libreoffice.org/feedback/ great news :) The page uses the HTML vars passed-in by LibreOffice: https://www.libreoffice.org/get-help/bug/?LOversion=4.2.0.1LOlocale=en-USLOmodule=TextDocument When we update the BSA to accept passed-in variables, this will allow us to automatically fill-in a bunch of information about the bug reporter's system. In the future, we could include additional information such as OS, architecture, and extensions. Would it be possible to add a log-out button/link from Bugzilla there? I find it a little bit disturbing to click on a link of a submitted bug to switch to BZ, just to be able to log out from BZ ... :( And more modules to report bugs to would be really nice ... ;) snip Please play around with the page and give us some feedback, folks! Maybe later this week ... ;) Too much on my desk to handle the next days, sorry ... :( Have a nice day Thomas. -- I may have invented it, but Bill made it famous -- David Bradley, inventor of the Ctrl-Alt-Delete keystroke, during panel discussion with Bill Gates at the 20-year celebration for the IBM PC. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 69938] Incorrect displaying doc document
https://bugs.freedesktop.org/show_bug.cgi?id=69938 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69938] Incorrect displaying doc document
https://bugs.freedesktop.org/show_bug.cgi?id=69938 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #8 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Please, don't set the bugs you reported yourself to NEW. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71485] Font color displays incorrectly
https://bugs.freedesktop.org/show_bug.cgi?id=71485 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=71473 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71473] Writer: colors do not display correctly on monitor
https://bugs.freedesktop.org/show_bug.cgi?id=71473 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added CC||momonas...@gmail.com See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=71485 --- Comment #9 from Maxim Monastirsky momonas...@gmail.com --- Isn't it a clone of Bug 71485? (In reply to comment #3) I see the off-color in the program icons as well. @Qubit: It's the 'high-contrast' icon theme that comes with LO. As for the color bug, I already pointed in Bug 71485 that we actually have a setting which might cause it. Take a look at Tools-Options...-LibreOffice-Accessibility-Options for high contrast appearance. There is 'Use automatic font color for screen display'. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71810] UI: BITAND function arguments have same name.
https://bugs.freedesktop.org/show_bug.cgi?id=71810 Winfried Donkers winfrieddonk...@libreoffice.org changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #3 from Winfried Donkers winfrieddonk...@libreoffice.org --- Calc functions BITAND, BITOR and BITXOR all have 2 arguments, both with the name 'number'. The order of the two is of no consequence for the result of the functions (which is not the case with MMULT in bug 71128), so there is no need to give them separate names. One could even argue that giving the 2 arguments different names suggests that they are not interchangeable. IMHO giving the 2 arguments different names is a matter of user interface policy. I cc the ux-advise list to hear what they think should be changed or maintained. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56197] VIEWING: fonts display
https://bugs.freedesktop.org/show_bug.cgi?id=56197 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72983] New: VIEWING: artifacts
https://bugs.freedesktop.org/show_bug.cgi?id=72983 Priority: medium Bug ID: 72983 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: VIEWING: artifacts Severity: critical Classification: Unclassified OS: Windows (All) Reporter: unexce...@rambler.ru Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.0.6.2 release Component: Writer Product: LibreOffice Created attachment 91146 -- https://bugs.freedesktop.org/attachment.cgi?id=91146action=edit screenshot and document While viewing a document MS Office (.doc) observed artifacts (details in the screenshot attached document)(this bug in all releases). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69649] FILEOPEN: Import DOCX renders page numbers wrong in Table-of-Contents
https://bugs.freedesktop.org/show_bug.cgi?id=69649 Vinaya Mandke vinaya.man...@synerzip.com changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69649] FILEOPEN: Import DOCX renders page numbers wrong in Table-of-Contents
https://bugs.freedesktop.org/show_bug.cgi?id=69649 Vinaya Mandke vinaya.man...@synerzip.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69649] FILEOPEN: Import DOCX renders page numbers wrong in Table-of-Contents
https://bugs.freedesktop.org/show_bug.cgi?id=69649 Vinaya Mandke vinaya.man...@synerzip.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |vinaya.man...@synerzip.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72983] VIEWING: artifacts
https://bugs.freedesktop.org/show_bug.cgi?id=72983 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Attachment #91146|text/plain |application/zip mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40538] FILEOPEN particular .doc (MSO97) shows arrow heads of graphic lines too big
https://bugs.freedesktop.org/show_bug.cgi?id=40538 Cédric Bosdonnat cedric.bosdonnat@free.fr changed: What|Removed |Added CC|cedric.bosdonnat.ooo@free.f | |r | --- Comment #16 from Cédric Bosdonnat cedric.bosdonnat@free.fr --- remove myself from CC: not hacking writer anymore -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66237] Document preview of tables shows overlayed toolbar icons and misplaced column headers
https://bugs.freedesktop.org/show_bug.cgi?id=66237 Cédric Bosdonnat cedric.bosdonnat@free.fr changed: What|Removed |Added CC|cedric.bosdonnat.ooo@free.f | |r | --- Comment #8 from Cédric Bosdonnat cedric.bosdonnat@free.fr --- Removing myself from CC: not hacking writer anymore -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 31609] Support different smart quote settings by language.
https://bugs.freedesktop.org/show_bug.cgi?id=31609 Cédric Bosdonnat cedric.bosdonnat@free.fr changed: What|Removed |Added CC|cedric.bosdonnat.ooo@free.f | |r | --- Comment #11 from Cédric Bosdonnat cedric.bosdonnat@free.fr --- Removing myself from CC: not hacking writer anymore -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63932] EDITING: Very slow Calc
https://bugs.freedesktop.org/show_bug.cgi?id=63932 Cédric Bosdonnat cedric.bosdonnat@free.fr changed: What|Removed |Added CC|cedric.bosdonnat.ooo@free.f | |r | --- Comment #16 from Cédric Bosdonnat cedric.bosdonnat@free.fr --- removed myself from cc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55846] Comboboxes aren’t displayed when the toolbar is vertical
https://bugs.freedesktop.org/show_bug.cgi?id=55846 Tor Lillqvist t...@iki.fi changed: What|Removed |Added Assignee|janit_...@hotmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #12 from Tor Lillqvist t...@iki.fi --- Let's not keep bugs assigned for too long without any indication of progress. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60183] Feature request: Allow regular expressions in cell functions like SUBSTITUTE()
https://bugs.freedesktop.org/show_bug.cgi?id=60183 --- Comment #9 from Javier Alfonso phoneixsego...@gmail.com --- Ohh, so to do this it must be in the standard? It could be a very good addition to the standard if it isn't already part of it. But I don't know how this can be done. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64309] two open buttons on main toolbar
https://bugs.freedesktop.org/show_bug.cgi?id=64309 almos aaalmo...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from almos aaalmo...@gmail.com --- OK. Unconfirmed, then. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55593] particular XLS: lots of problems with Excel (VBA) macros
https://bugs.freedesktop.org/show_bug.cgi?id=55593 Ettore Atalan atalantt...@googlemail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #4 from Ettore Atalan atalantt...@googlemail.com --- (In reply to comment #1) BTW: Why are you not using a calendar made for LibreOffice? Very helpful. You won't get my private Excel macro spreadsheets. I better use Softmaker Planmaker for spreadsheets. LibreOffice Calc is still quite buggy importing Excel files. Atalanttore -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72985] New: EDITING: mismanagement of the Object with no fill and no line Images style
https://bugs.freedesktop.org/show_bug.cgi?id=72985 Priority: medium Bug ID: 72985 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: mismanagement of the Object with no fill and no line Images style Severity: major Classification: Unclassified OS: All Reporter: pierre-yves.sa...@laposte.net Hardware: Other Status: UNCONFIRMED Version: 4.2.0.1 rc Component: Presentation Product: LibreOffice Created attachment 91149 -- https://bugs.freedesktop.org/attachment.cgi?id=91149action=edit ObjectNoFillNoLine.odp (object with french spanish styles) Hello The Object with no fill and no line Images style is not correctly stored when applied on an object. Steps to reproduce: 1. File New Presentation 2. Draw an objet (e.g. rectangle), type some text (e.g. Foo) 3. Format Styles and formatting, select Image styles 4. Double click on Object with no fill and no line 5. Save then close the presentation 6. Unzip to edit styles.xml Expected result: style:style style:name=objectwithnofillandnoline Actual result: style:style style:name=Object_20_with_20_no_20_fill_20_and_20_no_20_line 7. Edit content.xml Expected result: style:style style:name=gr1 style:family=graphic style:parent-style-name=objectwithnofillandnoline Actual result: style:style style:name=gr1 style:family=graphic style:parent-style-name=Object_20_with_20_no_20_fill_20_and_20_no_20_line This bug is very annoying because it does not allow the translation of the style name in a language other than English. A custom style is created for each interface language used 8.Tools Options Language Settings Languages UI select French (for example) 9.Quit, restart, reload the document Actual result: Rectangle with Objet sans remplissage et sans ligne style (translated name) Expected result: Object with no fill and no line (custom style) is created It is *not* a localization problem (string Ok) and it occurs with other languages. See the ObjectNoFillNoLine.dop attached (test with french spanish) Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72985] EDITING: mismanagement of the Object with no fill and no line Images style
https://bugs.freedesktop.org/show_bug.cgi?id=72985 --- Comment #1 from pierre-yves samyn pierre-yves.sa...@laposte.net --- Sorry to step 9 should read (inversion): Expected result: Rectangle with Objet sans remplissage et sans ligne style (translated name) Actual result: Object with no fill and no line (custom style) is created Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72985] EDITING: mismanagement of the Object with no fill and no line Images style
https://bugs.freedesktop.org/show_bug.cgi?id=72985 sophie gautier.sop...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||gautier.sop...@gmail.com Ever confirmed|0 |1 --- Comment #2 from sophie gautier.sop...@gmail.com --- Thank you Pierre-Yves for your detailed report :) Confirmed - Set on New - Sophie -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72986] New: Base fails to render properly
https://bugs.freedesktop.org/show_bug.cgi?id=72986 Priority: medium Bug ID: 72986 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Base fails to render properly Severity: normal Classification: Unclassified OS: Linux (All) Reporter: bugzilla-libreoff...@pokeeffe.net Hardware: x86 (IA32) Status: NEW Version: 4.1.2.3 release Component: Database Product: LibreOffice Main window of Base does not render properly; see attached. Colored rectangles persist while interacting with Base but may change position within window. They persist while dragging window around screen and remain static relative to window while window is moved. Also reappear after closing/relaunching Base in roughly same positions. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72986] Base fails to render properly
https://bugs.freedesktop.org/show_bug.cgi?id=72986 --- Comment #1 from bugzilla-libreoff...@pokeeffe.net --- Created attachment 91150 -- https://bugs.freedesktop.org/attachment.cgi?id=91150action=edit screenshot of incorrect rendering in Base MACHINE!, are you going to attach it this time or not? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49120] FILESAVE: LibreOffice corrupts XLSX file
https://bugs.freedesktop.org/show_bug.cgi?id=49120 Vikram j.vik...@samsung.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Version|3.5.2 release |4.0.1.2 release --- Comment #30 from Vikram j.vik...@samsung.com --- Hello All, I am trying to convert Micorsoft XLSX file to PDF using Libre Office 4.0.1 and latest version of Libre office 4.1.4, but the PDF which is forming is corrupted. (Some portion of xlsx file is not saving in PDF file) Kindly please let me know what is the solution for the above query. Any help ASAP is really appritiated. Regards Vikram -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54157] LibreOffice 4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 49120, which changed state. Bug 49120 Summary: FILESAVE: LibreOffice corrupts XLSX file https://bugs.freedesktop.org/show_bug.cgi?id=49120 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63422] program crashes while opening a database table
https://bugs.freedesktop.org/show_bug.cgi?id=63422 Foss f...@openmailbox.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID --- Comment #7 from Foss f...@openmailbox.org --- Setting to INVALID. Without a testfile there's nothing to be done about this. In any case, should this happen on your new system as well, make sure to -reopen this issue and attach a test file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
