LibreOffice Gerrit News for core on 2014-08-20
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + jurt: Throwable.getCause() instead of Throwable.getTargetException() in https://gerrit.libreoffice.org/11027 from Robert Antoni Buj i Gelonch about module jurt + xmerge: Convert a primitive type into a string in https://gerrit.libreoffice.org/11026 from Robert Antoni Buj i Gelonch about module xmerge + fdo#82290: avoid pipe deadlock by executing write(2) in a new thread in https://gerrit.libreoffice.org/11014 from Hiroto Kagotani about module filter End of freshness + Remove more useless includes of tools/debug.hxx in https://gerrit.libreoffice.org/11020 from Marcos Paulo de Souza about module connectivity, svtools, tools, unotools + create clang plugin to warn about C-style casts in https://gerrit.libreoffice.org/10367 from Noel Grandin about module compilerplugins, include + fdo#81956 : Rendering of vml group shape was wrong. in https://gerrit.libreoffice.org/11013 from sushil_shinde about module sw, writerfilter * Merged changes on master for project core changed in the last 25 hours: + fdo#75757: remove inheritance to std::vector in https://gerrit.libreoffice.org/11017 from Takeshi Abe + fix intermittent crash in make check in https://gerrit.libreoffice.org/10996 from Noel Grandin + Make Draw use paper size when printing - fdo#63905 in https://gerrit.libreoffice.org/9866 from Eilidh McAdam + odk: Clean up comments in https://gerrit.libreoffice.org/11006 from Chris Laplante + svx: Cleanup ASCII art and useless comments in https://gerrit.libreoffice.org/11011 from Chris Laplante * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + fdo#63154: Rearrange some solar.h includes in https://gerrit.libreoffice.org/10892 from Marcos Paulo de Souza + VS2013: Make 64 bit shell extensions optional in https://gerrit.libreoffice.org/10163 from David Ostrovsky + fdo#82290: Perform write(2) and read(2) concurrently to avoid pipe deadlo in https://gerrit.libreoffice.org/10825 from Jan Holesovsky + fdo#80996:Fix for DataLabel not preserved for ColumnChart after RT in https://gerrit.libreoffice.org/10169 from Dushyant Bhalgami + fdo#79018: LO hangs while opening file. in https://gerrit.libreoffice.org/9564 from Yogesh Bharate + Use assert instead of OSL_ASSERT in sal/ in https://gerrit.libreoffice.org/10113 from Arnaud Versini + fdo#77716 : Paragraph spacing is not preserved after RT. in https://gerrit.libreoffice.org/9197 from Tushar Bende + fdo#77121 Header / Footer positions not preserved after RT in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/viewfun6.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit a1a480f91e6f43df23b9ecdf47d5cd230c50ebed
Author: Tor Lillqvist t...@collabora.com
Date: Wed Aug 20 09:01:41 2014 +0300
Wa: C4701: potentially uninitialized local variable 'fVal' used
Change-Id: I579205c4cdc3149ef0c1b01daef32155a13d666b
diff --git a/sc/source/ui/view/viewfun6.cxx b/sc/source/ui/view/viewfun6.cxx
index ba9fbfb..b7a429c 100644
--- a/sc/source/ui/view/viewfun6.cxx
+++ b/sc/source/ui/view/viewfun6.cxx
@@ -263,7 +263,7 @@ void ScViewFunc::InsertCurrentTime(short nCellFmt, const
OUString rUndoStr)
assert(!unhandled current date/time request);
nCellFmt = NUMBERFORMAT_DATETIME;
}
-double fVal;
+double fVal(0);
switch (nCellFmt)
{
case NUMBERFORMAT_DATE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - vcl/source
vcl/source/window/layout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dac4825abef1c9a4d970dab7dbec26673126342a Author: Caolán McNamara caol...@redhat.com Date: Tue Aug 19 16:14:23 2014 +0100 facepalm: nAvailHeight is not derived from allocation Width Change-Id: Ic99c6519b02c546e0d3574cb756e3fb172d1ff52 (cherry picked from commit 36490fff3f4d1b4a7e4b7902a866abb177a0bf54) Reviewed-on: https://gerrit.libreoffice.org/11023 Reviewed-by: Andras Timar andras.ti...@collabora.com Tested-by: Andras Timar andras.ti...@collabora.com diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx index 5ae3412..9e204a8 100644 --- a/vcl/source/window/layout.cxx +++ b/vcl/source/window/layout.cxx @@ -1694,7 +1694,7 @@ void VclScrolledWindow::setAllocation(const Size rAllocation) if (pChild pChild-IsVisible()) aChildReq = getLayoutRequisition(*pChild); -long nAvailHeight = rAllocation.Width(); +long nAvailHeight = rAllocation.Height(); long nAvailWidth = rAllocation.Width(); // vert. ScrollBar if (GetStyle() WB_AUTOVSCROLL) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - vcl/source
vcl/source/window/layout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 14bdff6f667ab28e14618fcb3dfb83bf2c2c765f Author: Caolán McNamara caol...@redhat.com Date: Tue Aug 19 16:14:23 2014 +0100 facepalm: nAvailHeight is not derived from allocation Width Change-Id: Ic99c6519b02c546e0d3574cb756e3fb172d1ff52 (cherry picked from commit 36490fff3f4d1b4a7e4b7902a866abb177a0bf54) Reviewed-on: https://gerrit.libreoffice.org/11024 Reviewed-by: Andras Timar andras.ti...@collabora.com Tested-by: Andras Timar andras.ti...@collabora.com diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx index 8d8ab0d..517fa33 100644 --- a/vcl/source/window/layout.cxx +++ b/vcl/source/window/layout.cxx @@ -1692,7 +1692,7 @@ void VclScrolledWindow::setAllocation(const Size rAllocation) if (pChild pChild-IsVisible()) aChildReq = getLayoutRequisition(*pChild); -long nAvailHeight = rAllocation.Width(); +long nAvailHeight = rAllocation.Height(); long nAvailWidth = rAllocation.Width(); // vert. ScrollBar if (GetStyle() WB_AUTOVSCROLL) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - configure.ac
configure.ac | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) New commits: commit ba754e8ba8897be196de48c48df63b9671115356 Author: Michael Stahl mst...@redhat.com Date: Fri Aug 15 13:25:22 2014 +0200 configure: don't try to use Win32 make on release branch Change-Id: Icd8c1b45659ca323aef25a55803f5b1ce078b9d3 Reviewed-on: https://gerrit.libreoffice.org/10932 Reviewed-by: Thomas Arnhold tho...@arnhold.org Tested-by: Thomas Arnhold tho...@arnhold.org (cherry picked from commit 2087b54aab25ddbab5128af9f777b1686bc0ce5e) Reviewed-on: https://gerrit.libreoffice.org/10990 Reviewed-by: Andras Timar andras.ti...@collabora.com Tested-by: Andras Timar andras.ti...@collabora.com diff --git a/configure.ac b/configure.ac index 312eacd..2560a0d 100644 --- a/configure.ac +++ b/configure.ac @@ -4798,8 +4798,18 @@ for a in $MAKE $GNUMAKE make gmake gnumake; do if test -n $a; then $a --version 2 /dev/null | grep GNU 21 /dev/null if test $? -eq 0; then -GNUMAKE=`which $a` -break +if test $build_os = cygwin; then +if test -n $($a -v | grep 'Built for Windows') ; then +AC_MSG_NOTICE([$a is a native Win32 make, which is not supported on this old branch.]) +unset GNUMAKE +else +GNUMAKE=`which $a` +break +fi +else +GNUMAKE=`which $a` +break +fi fi fi done ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/oox oox/inc
include/oox/drawingml/chart/modelbase.hxx | 12
oox/inc/drawingml/chart/axismodel.hxx |6 --
2 files changed, 18 deletions(-)
New commits:
commit 1558b50e4fd5c26275efd824e731dc46fca781a4
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date: Tue Aug 19 05:01:20 2014 +0200
remove whitespace
Change-Id: I5634bf40e8ccc4ce076409907c13f9c6f52d11a3
diff --git a/include/oox/drawingml/chart/modelbase.hxx
b/include/oox/drawingml/chart/modelbase.hxx
index d46ebbd..68bb9b7 100644
--- a/include/oox/drawingml/chart/modelbase.hxx
+++ b/include/oox/drawingml/chart/modelbase.hxx
@@ -30,8 +30,6 @@ namespace oox {
namespace drawingml {
namespace chart {
-
-
template typename ModelType
class ModelRef : public ::boost::shared_ptr ModelType
{
@@ -51,8 +49,6 @@ public:
ModelType getOrCreate( const Param1Type rParam1 ) { if( !*this )
this-reset( new ModelType( rParam1 ) ); return **this; }
};
-
-
template typename ModelType
class ModelVector : public RefVector ModelType
{
@@ -71,8 +67,6 @@ private:
ModelType append( ModelType* pModel ) { this-push_back( value_type(
pModel ) ); return *pModel; }
};
-
-
template typename KeyType, typename ModelType
class ModelMap : public RefMap KeyType, ModelType
{
@@ -92,8 +86,6 @@ private:
ModelType insert( KeyType eKey, ModelType* pModel ) { (*this)[ eKey
].reset( pModel ); return *pModel; }
};
-
-
struct NumberFormat
{
OUString maFormatCode; /// Number format code.
@@ -104,8 +96,6 @@ struct NumberFormat
voidsetAttributes( const AttributeList rAttribs );
};
-
-
struct LayoutModel
{
double mfX;/// Left position of this object.
@@ -123,8 +113,6 @@ struct LayoutModel
~LayoutModel();
};
-
-
} // namespace chart
} // namespace drawingml
} // namespace oox
diff --git a/oox/inc/drawingml/chart/axismodel.hxx
b/oox/inc/drawingml/chart/axismodel.hxx
index a206185..c4ba8d4 100644
--- a/oox/inc/drawingml/chart/axismodel.hxx
+++ b/oox/inc/drawingml/chart/axismodel.hxx
@@ -27,8 +27,6 @@ namespace oox {
namespace drawingml {
namespace chart {
-
-
struct AxisDispUnitsModel
{
typedef ModelRef ShapeShapeRef;
@@ -47,8 +45,6 @@ struct AxisDispUnitsModel
~AxisDispUnitsModel();
};
-
-
struct AxisModel
{
typedef ModelRef ShapeShapeRef;
@@ -94,8 +90,6 @@ struct AxisModel
~AxisModel();
};
-
-
} // namespace chart
} // namespace drawingml
} // namespace oox
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: xmerge/source
xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/ParaStyle.java
|6 +++---
xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/TextStyle.java
|3 +--
xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/CellStyle.java
|3 +--
3 files changed, 5 insertions(+), 7 deletions(-)
New commits:
commit b9813addf2816e4058069892963e50a97643023d
Author: rbuj robert@gmail.com
Date: Tue Aug 19 19:41:13 2014 +0200
xmerge: Convert a primitive type into a string
Avoid unnecessary temporaries when converting primitive data types into a
String.
Change-Id: If361383be52d8258be7c8c9bddf3ba05d5ca92c1
Reviewed-on: https://gerrit.libreoffice.org/11026
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/ParaStyle.java
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/ParaStyle.java
index 0234a1b..28c964c 100644
---
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/ParaStyle.java
+++
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/ParaStyle.java
@@ -534,7 +534,7 @@ public class ParaStyle extends Style implements Cloneable {
for (int i = 0; i = TEXT_INDENT; i++) {
if (isSet[i]) {
double temp = value[i] / 100.0;
-String stringVal = (new Double(temp)).toString() + mm;
+String stringVal = Double.toString(temp) + mm;
node.setAttribute(attrName[i], stringVal);
}
}
@@ -542,10 +542,10 @@ public class ParaStyle extends Style implements Cloneable
{
if (isSet[LINE_HEIGHT]) {
String stringVal;
if ((value[LINE_HEIGHT] LH_PCT) != 0)
-stringVal = (Integer.valueOf(value[LINE_HEIGHT]
LH_VALUEMASK)).toString() + %;
+stringVal = Integer.toString(value[LINE_HEIGHT]
LH_VALUEMASK) + %;
else {
double temp = (value[LINE_HEIGHT] LH_VALUEMASK) / 100.0;
-stringVal = (new Double(temp)).toString() + mm;
+stringVal = Double.toString(temp) + mm;
}
node.setAttribute(attrName[LINE_HEIGHT], stringVal);
}
diff --git
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/TextStyle.java
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/TextStyle.java
index 83efc31..c752f1e 100644
---
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/TextStyle.java
+++
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/TextStyle.java
@@ -559,8 +559,7 @@ public class TextStyle extends Style implements Cloneable {
node.setAttribute(style:text-position, sub 58%);
if (sizeInPoints != 0) {
-Integer fs = Integer.valueOf(sizeInPoints);
-node.setAttribute(fo:font-size, fs.toString() + pt);
+node.setAttribute(fo:font-size, Integer.toString(sizeInPoints) +
pt);
}
if (fontName != null)
diff --git
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/CellStyle.java
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/CellStyle.java
index e437e18..434912c 100644
---
a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/CellStyle.java
+++
b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/CellStyle.java
@@ -412,8 +412,7 @@ public class CellStyle extends Style implements Cloneable {
node.setAttribute(style:text-position, sub 58%);
if (fmt.getFontSize() != 0) {
-Integer fs = Integer.valueOf(fmt.getFontSize());
-node.setAttribute(fo:font-size, fs.toString() + pt);
+node.setAttribute(fo:font-size,
Integer.toString(fmt.getFontSize()) + pt);
}
if (fmt.getFontName() != null)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: jurt/com
jurt/com/sun/star/comp/loader/FactoryHelper.java |4 ++--
jurt/com/sun/star/comp/loader/JavaLoader.java |2 +-
jurt/com/sun/star/lib/uno/environments/remote/Job.java |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 37c49c305852f4a58e010c63331ba302462754d9
Author: rbuj robert@gmail.com
Date: Tue Aug 19 21:34:58 2014 +0200
jurt: Throwable.getCause() instead of Throwable.getTargetException()
As of the JDK 1.4, Throwable.getCause() is the preferred method for getting
thrown target exception.
Change-Id: I14f3f9ae52869d1149f92b32562e7fb3293109b5
Reviewed-on: https://gerrit.libreoffice.org/11027
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/jurt/com/sun/star/comp/loader/FactoryHelper.java
b/jurt/com/sun/star/comp/loader/FactoryHelper.java
index 2a71201..92b4801 100644
--- a/jurt/com/sun/star/comp/loader/FactoryHelper.java
+++ b/jurt/com/sun/star/comp/loader/FactoryHelper.java
@@ -198,7 +198,7 @@ public class FactoryHelper {
try {
return _constructor.newInstance( args );
} catch (InvocationTargetException invocationTargetException) {
-Throwable targetException =
invocationTargetException.getTargetException();
+Throwable targetException =
invocationTargetException.getCause();
if (targetException instanceof java.lang.RuntimeException)
throw (java.lang.RuntimeException)targetException;
@@ -274,7 +274,7 @@ public class FactoryHelper {
}
return instance;
} catch (InvocationTargetException invocationTargetException) {
-Throwable targetException =
invocationTargetException.getTargetException();
+Throwable targetException =
invocationTargetException.getCause();
if (targetException instanceof java.lang.RuntimeException)
throw (java.lang.RuntimeException)targetException;
diff --git a/jurt/com/sun/star/comp/loader/JavaLoader.java
b/jurt/com/sun/star/comp/loader/JavaLoader.java
index d7f757a..c82f8e9 100644
--- a/jurt/com/sun/star/comp/loader/JavaLoader.java
+++ b/jurt/com/sun/star/comp/loader/JavaLoader.java
@@ -353,7 +353,7 @@ public class JavaLoader implements XImplementationLoader,
+ implementationName + because + e.toString() );
} catch ( InvocationTargetException e ) {
throw new CannotActivateFactoryException(Can not activate the
factory for
-+ implementationName + because +
e.getTargetException().toString() );
++ implementationName + because +
e.getCause().toString() );
}
return returnObject;
diff --git a/jurt/com/sun/star/lib/uno/environments/remote/Job.java
b/jurt/com/sun/star/lib/uno/environments/remote/Job.java
index 47fc033..1d8b366 100644
--- a/jurt/com/sun/star/lib/uno/environments/remote/Job.java
+++ b/jurt/com/sun/star/lib/uno/environments/remote/Job.java
@@ -90,7 +90,7 @@ public class Job {
? dispatch_queryInterface((Type) args[0])
: md.getMethod().invoke(_object, args);
} catch (InvocationTargetException e) {
-exception = e.getTargetException();
+exception = e.getCause();
if (exception == null) {
exception = e;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44580] share autocorrect replacement table for misc. language subgroups
https://bugs.freedesktop.org/show_bug.cgi?id=44580 --- Comment #19 from tommy27 ba...@quipo.it --- Created attachment 104939 -- https://bugs.freedesktop.org/attachment.cgi?id=104939action=edit autocorrect testkit Hi Julien, probably my test in comment 17 was not 100% accurate. try replicating this new experiment. a- download the attached .zip file which contains 3 minimal autocorrect .dat file 1- acor_und.dat it has a single entry: test → test1 it will apply in any document regardless the language since the acor_und.dat file is the global autocorrect list (you can find it at the top of the language dropdown list in the autocorrect replacement table under [All] (don't know how's localized in french) 2- acor_en-GB.dat it has a single entry: test → test2 it will apply only in document where the language is English(UK) 3- acor_en.dat it has a single entry: test → test3 it should apply in any document written in any of the English variants (UK, US, Australia etc.) b- place these 3 dat files in the autocorr subfolder of the user profile c- load a blank new Writer document and set the language as English(UK) d- type test and see how it gets autocorrected e- compare with my results with LibO 4.2.6.2 under Win7x64: - all 3 dat files present → test corrected into test2, so the localized variant acor_en-GB.dat rules over the acor_und.dat and acor_en.dat - remove the und.dat file → again you get test2, so the en-GB.dat wins over the en.dat - remove only the en-GB.dat file → you get test3 so the en.dat wins over the und.dat - remove both en-GB.dat and und.dat → again you get test3 since only en.dat is left - remove both en-GB.dat and en.dat → you get test1 since only und.dat is left so basically in case of autocorrect conflicts the “en-GB” list wins over the “en” list and over the “und” list. I agree this is the correct behavior since the language of the document should tell which is the first autocorrect list to look inside. f- same results if I rename those file to match italian locale (i.e. acor_it.dat and acor_it-IT.dat) and I write an italian(Italy) document. g- different results if you do the same trick with german or french locales. In those cases the renamed acor_de.dat and acor_fr.dat files will have no effect even if you remove the und.dat and the de-DE.dat and the fr-FR.dat files. So it seems that the unlocalized variant .dat files doesn't work in some language subgroups... this is strange and unconsistent with the results with Italian and English where it worked with no issue. Do you have any thoughts about that? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44580] share autocorrect replacement table for misc. language subgroups
https://bugs.freedesktop.org/show_bug.cgi?id=44580 --- Comment #20 from tommy27 ba...@quipo.it --- P.S. when you remove some .dat files as described in the tests above always remember to close LibO first and then restart the program again. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sd/source
sd/source/ui/view/DocumentRenderer.cxx | 33 -
1 file changed, 28 insertions(+), 5 deletions(-)
New commits:
commit a7eed1e17cfb101210db8aa839171f00d0730582
Author: Eilidh McAdam eil...@lanedo.com
Date: Mon Jun 23 20:55:21 2014 +0100
Make Draw use paper size when printing - fdo#63905
Previously, Draw/Impress use the default size from the printer.
Now Draw uses the paper size (specified in page formatting).
Impress still uses the old method - not sure if this is correct
but printing handouts etc probably complicate print/paper size.
Change-Id: If90bae4ac59cd95dd50fcd8deb25fd900756193e
Reviewed-on: https://gerrit.libreoffice.org/9866
Reviewed-by: Matúš Kukan matus.ku...@collabora.com
Tested-by: Matúš Kukan matus.ku...@collabora.com
(cherry picked from commit 7b31e45ec7106d2cfbdbb7915d97667ba710f81c)
diff --git a/sd/source/ui/view/DocumentRenderer.cxx
b/sd/source/ui/view/DocumentRenderer.cxx
index 59106a7..7080e9d 100644
--- a/sd/source/ui/view/DocumentRenderer.cxx
+++ b/sd/source/ui/view/DocumentRenderer.cxx
@@ -1418,7 +1418,19 @@ private:
else if (rInfo.maPageSize.Width() rInfo.maPageSize.Height())
rInfo.meOrientation = ORIENTATION_LANDSCAPE;
-const Size aPaperSize (rInfo.mpPrinter-GetPaperSize());
+// Draw should abide by specified paper size
+Size aPaperSize;
+if (mpOptions-IsDraw())
+{
+aPaperSize.setWidth(rInfo.maPageSize.Width());
+aPaperSize.setHeight(rInfo.maPageSize.Height());
+}
+else
+{
+aPaperSize.setWidth(rInfo.mpPrinter-GetPaperSize().Width());
+aPaperSize.setHeight(rInfo.mpPrinter-GetPaperSize().Height());
+}
+
if( (rInfo.meOrientation == ORIENTATION_LANDSCAPE
(aPaperSize.Width() aPaperSize.Height()))
||
@@ -1483,10 +1495,21 @@ private:
if (mpOptions-IsTime())
aInfo.msTimeDate +=
GetSdrGlobalData().GetLocaleData()-getTime( Time( Time::SYSTEM ), false, false
);
-aInfo.maPrintSize = aInfo.mpPrinter-GetOutputSize();
-maPrintSize = awt::Size(
-aInfo.mpPrinter-GetPaperSize().Width(),
-aInfo.mpPrinter-GetPaperSize().Height());
+
+// Draw should use specified paper size when printing
+if (mpOptions-IsDraw())
+{
+aInfo.maPrintSize = mrBase.GetDocument()-GetSdPage(0,
PK_STANDARD)-GetSize();
+maPrintSize = awt::Size(aInfo.maPrintSize.Width(),
+aInfo.maPrintSize.Height());
+}
+else
+{
+aInfo.maPrintSize = aInfo.mpPrinter-GetOutputSize();
+maPrintSize = awt::Size(
+aInfo.mpPrinter-GetPaperSize().Width(),
+aInfo.mpPrinter-GetPaperSize().Height());
+}
switch (mpOptions-GetOutputQuality())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/qa writerfilter/source
writerfilter/qa/cppunittests/rtftok/data/pass/sf_2063317381c4a46d642c79a4b1817dc0-108116-minimized.rtf
| 62 ++
writerfilter/source/rtftok/rtfdocumentimpl.cxx
| 13 +-
2 files changed, 69 insertions(+), 6 deletions(-)
New commits:
commit e3247719911f4e9b61ec43ea1c9ce04bcddc4ff8
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 08:42:31 2014 +0100
empty m_aStates
valgrind + bff
Change-Id: I3bd526b7ebf0f4fce5d0c7054809e0dc2908e73f
diff --git
a/writerfilter/qa/cppunittests/rtftok/data/pass/sf_2063317381c4a46d642c79a4b1817dc0-108116-minimized.rtf
b/writerfilter/qa/cppunittests/rtftok/data/pass/sf_2063317381c4a46d642c79a4b1817dc0-108116-minimized.rtf
new file mode 100644
index 000..9576906
--- /dev/null
+++
b/writerfilter/qa/cppunittests/rtftok/data/pass/sf_2063317381c4a46d642c79a4b1817dc0-108116-minimized.rtf
@@ -0,0 +1,62 @@
+{\rtf1\ansi\deff0\adeflang1025
+{\fonttbl{\f0\froman\fprq2\fcharset0 Times New
Roman;}{\f1\froman\fprq2\fcharset2 Symbol;}{\f2\fswiss\fprq2\fcharset0
Arial;}{\f3\froman\fprq2\fcharset128 Times New
Roman;}{\f4\froman\fprq2\fcharset128 Arial
Narrow;}{\f5\froman\fprq0\fcharset128 Arial
Narrow;}{\f6\froman\fprq2\fcharset128 Symbol;}{\f7\froman\fprq0\fcharset128
Symbol;}{\f8\froman\fprq2\fcharset128 Wingdings;}{\f9\froman\fprq0\fcharset128
Wingdings;}{\f10\froman\fprq0\fcharset128 Times New
Roman;}{\f11\fnil\fprq2\fcharset0 Microsoft YaHei;}{\f12\fnil\fprq2\fcharset128
SimSun;}{\f13\fnil\fprq2\fcharset128 Times New Roman
(Arabic);}{\f14\fnil\fprq0\fcharset128 Times New Roman
(Arabic);}{\f15\fnil\fprq2\fcharset128 Times New
Roman;}{\f16\fnil\fprq0\fcharset128 Times New Roman;}{\f17\fnil\fprq2\fcharset0
Mangal;}{\f18\fnil\fprq0\fcharset128 Mangal;}{\f19\fnil\fprq2\fcharset128
Mangal;}{\f20\fnil\fprq2\fcharset128 Cambria Math;}{\f21\fnil\fprq0\fcharset128
Cambria Math;}}
+{\colortbl;\red0\green0\blue0;\red0\green0\blue255;\red128\green128\blue128;}
+{\stylesheet{\s0\snext0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040
Predefinito;}
+{\s15\sbasedon0\snext16\sb240\sa120\keepn\hich\af11\dbch\af17\afs28\loch\f2\fs28
Intestazione;}
+{\s16\sbasedon0\snext16\sb0\sa120 Corpo testo;}
+{\s17\sbasedon16\snext17\sb0\sa120\dbch\af18 Elenco;}
+{\s18\sbasedon0\snext18\sb120\sa120\noline\i\dbch\af18\afs24\ai\fs24
Didascalia;}
+{\s19\sbasedon0\snext19\noline\dbch\af18 Indice;}
+}{\info{\creatim\yr2011\mo9\dy28\hr16\min28}{\revtim\yr2011\mo9\dy28\hr16\min29}{\printim\yr0\mo0\dy0\hr0\min0}{\comment
LibreOffice}{\vern3500}}\deftab720
+
+{\*\pgdsctbl
+{\pgdsc0\pgdscuse195\pgwsxn12240\pghsxn15840\marglsxn1134\margrsxn1134\margtsxn1417\margbsxn1134\pgdscnxt0
Predefinito;}}
+\formshade{\*\pgdscno0}\paperh15840\paperw12240\margl1134\margr1134\margt1417\margb1134\sectd\sbknone\sectunlocked1\pgndec\pgwsxn12240\pghsxn15840\marglsxn1134\margrsxn1134\margtsxn1417\margbsxn1134\ftnbj\ftnstart1\ftnrstcont\ftnnar\aenddoc\aftnrstcont\aftnstart1\aftnnrlc
+\trowd\trql\trleft-108\ltrrow\trpaddft3\trpaddt0\trpaddfl3\trpaddl0\trpaddfb3\trpaddb0\trpaddfr3\trpaddr0\clvertalt\cellx9864\pgndec\pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\intbl\qr\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0\keepn{\scaps\b\hich\af14\langfe1040\dbch\af14\afs26\alang1025\ab\rtlch
\ltrch\loch\fs26\lang1040\loch\f5
+SSS SSS curriculum vitae}
+\par \pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\intbl\ql\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0{\rtlch
\ltrch\loch
+}
+\par \pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\intbl\qr\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0{\langfe1040\dbch\af14\afs16\alang1025\rtlch
\ltrch\loch\fs16\lang1040\loch\f5
+}\cell\row\pard\pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\ql\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0{\rtlch
\ltrch\loch
+}
+\par \pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\ql\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0{\rtlch
\ltrch\loch
+}
+\par
\trowd\trql\trleft-108\ltrrow\trpaddft3\trpaddt0\trpaddfl3\trpaddl0\trpaddfb3\trpaddb0\trpaddfr3\trpaddr0\clvertalt\cellx9864\pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\intbl\qr\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0\keepn{\scaps\b\hich\af14\langfe1040\dbch\af14\afs24\alang1025\ab\rtlch
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - filter/source
filter/source/graphicfilter/itiff/itiff.cxx | 31 +++-
1 file changed, 22 insertions(+), 9 deletions(-)
New commits:
commit 6f87560daba857baecb56617ac23b8960c71ad85
Author: Caolán McNamara caol...@redhat.com
Date: Sat Aug 9 17:23:07 2014 +0100
valgrind + bff: Integer divide by zero
Change-Id: I4c47d17a421f1c6d2d6cc29c7b92ec930bdf901f
(cherry picked from commit a1fab361cb3325b2d012942e43660f2c0a2a4b96)
Reviewed-on: https://gerrit.libreoffice.org/11021
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index 061592b..f708435 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -176,6 +176,19 @@ public:
delete pAlphaMask;
}
+sal_uLong GetRowsPerStrip() const
+{
+//Rows Per Strip:
+//
+//(TIFF format only) The number of rows of pixels per strip to use for
+//encoding the TIFF image. A value greater than zero specifies the
+//number of rows per strip. A value of 0 sets the rows per strip equal
+//to the image length, resulting in a single strip. A value of -1 (the
+//default) sets the rows per strip equal to infinity, resulting in a
+//single strip.
+return nRowsPerStrip == 0 ? nImageLength : nRowsPerStrip;
+}
+
bool ReadTIFF( SvStream rTIFF, Graphic rGraphic );
};
@@ -539,10 +552,10 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent,
sal_uLong nMaxPercent )
{
for ( np = 0; np nPlanes; np++ )
{
-nStrip = ny / nRowsPerStrip + np * nStripsPerPlane;
+nStrip = ny / GetRowsPerStrip() + np * nStripsPerPlane;
if ( nStrip = nNumStripOffsets )
return false;
-pTIFF-Seek( pStripOffsets[ nStrip ] + ( ny % nRowsPerStrip )
* nStripBytesPerRow );
+pTIFF-Seek( pStripOffsets[ nStrip ] + ( ny %
GetRowsPerStrip() ) * nStripBytesPerRow );
pTIFF-Read( pMap[ np ], nBytesPerRow );
if ( pTIFF-GetError() )
return false;
@@ -593,9 +606,9 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong
nMaxPercent )
{
for ( np = 0; np nPlanes; np++ )
{
-if ( ny / nRowsPerStrip + np * nStripsPerPlane nStrip )
+if ( ny / GetRowsPerStrip() + np * nStripsPerPlane nStrip )
{
-nStrip=ny/nRowsPerStrip+np*nStripsPerPlane;
+nStrip=ny/GetRowsPerStrip()+np*nStripsPerPlane;
if ( nStrip = nNumStripOffsets )
return false;
pTIFF-Seek( pStripOffsets[ nStrip ] );
@@ -624,9 +637,9 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong
nMaxPercent )
{
for ( np = 0; np nPlanes; np++ )
{
-if ( ny / nRowsPerStrip + np * nStripsPerPlane nStrip )
+if ( ny / GetRowsPerStrip() + np * nStripsPerPlane nStrip )
{
-nStrip = ny / nRowsPerStrip + np * nStripsPerPlane;
+nStrip = ny / GetRowsPerStrip() + np * nStripsPerPlane;
if ( nStrip = nNumStripOffsets )
return false;
pTIFF-Seek(pStripOffsets[nStrip]);
@@ -652,9 +665,9 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong
nMaxPercent )
{
for ( np = 0; np nPlanes; np++ )
{
-if ( ny / nRowsPerStrip + np * nStripsPerPlane nStrip )
+if ( ny / GetRowsPerStrip() + np * nStripsPerPlane nStrip )
{
-nStrip=ny/nRowsPerStrip+np*nStripsPerPlane;
+nStrip=ny/GetRowsPerStrip()+np*nStripsPerPlane;
if ( nStrip = nNumStripOffsets )
return false;
pTIFF-Seek(pStripOffsets[nStrip]);
@@ -1310,7 +1323,7 @@ bool TIFFReader::ReadTIFF(SvStream rTIFF, Graphic
rGraphic )
if ( ( nFillOrder == 2 ) ( nCompression != 5 ) ) //
in the LZW mode bits are already being inverted
bByteSwap = true;
-nStripsPerPlane = ( nImageLength - 1 ) / nRowsPerStrip + 1;
+nStripsPerPlane = ( nImageLength - 1 ) / GetRowsPerStrip()
+ 1;
nBytesPerRow = ( nImageWidth * nSamplesPerPixel / nPlanes
* nBitsPerSample + 7 ) 3;
for ( sal_uLong j = 0; j 4; j++ )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - filter/source
filter/source/graphicfilter/itiff/itiff.cxx | 31 +++-
1 file changed, 22 insertions(+), 9 deletions(-)
New commits:
commit 4bcdb23d76ab02f2ffb081fc89b302ab6a8b6b89
Author: Caolán McNamara caol...@redhat.com
Date: Sat Aug 9 17:23:07 2014 +0100
valgrind + bff: Integer divide by zero
(cherry picked from commit a1fab361cb3325b2d012942e43660f2c0a2a4b96)
Conflicts:
filter/source/graphicfilter/itiff/itiff.cxx
Change-Id: I4c47d17a421f1c6d2d6cc29c7b92ec930bdf901f
Reviewed-on: https://gerrit.libreoffice.org/11022
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index 71bad87..a921b53 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -178,6 +178,19 @@ public:
delete pAlphaMask;
}
+sal_uLong GetRowsPerStrip() const
+{
+//Rows Per Strip:
+//
+//(TIFF format only) The number of rows of pixels per strip to use for
+//encoding the TIFF image. A value greater than zero specifies the
+//number of rows per strip. A value of 0 sets the rows per strip equal
+//to the image length, resulting in a single strip. A value of -1 (the
+//default) sets the rows per strip equal to infinity, resulting in a
+//single strip.
+return nRowsPerStrip == 0 ? nImageLength : nRowsPerStrip;
+}
+
sal_Bool ReadTIFF( SvStream rTIFF, Graphic rGraphic );
};
@@ -547,10 +560,10 @@ sal_Bool TIFFReader::ReadMap( sal_uLong nMinPercent,
sal_uLong nMaxPercent )
{
for ( np = 0; np nPlanes; np++ )
{
-nStrip = ny / nRowsPerStrip + np * nStripsPerPlane;
+nStrip = ny / GetRowsPerStrip() + np * nStripsPerPlane;
if ( nStrip = nNumStripOffsets )
return sal_False;
-pTIFF-Seek( pStripOffsets[ nStrip ] + ( ny % nRowsPerStrip )
* nStripBytesPerRow );
+pTIFF-Seek( pStripOffsets[ nStrip ] + ( ny %
GetRowsPerStrip() ) * nStripBytesPerRow );
pTIFF-Read( pMap[ np ], nBytesPerRow );
if ( pTIFF-GetError() )
return sal_False;
@@ -601,9 +614,9 @@ sal_Bool TIFFReader::ReadMap( sal_uLong nMinPercent,
sal_uLong nMaxPercent )
{
for ( np = 0; np nPlanes; np++ )
{
-if ( ny / nRowsPerStrip + np * nStripsPerPlane nStrip )
+if ( ny / GetRowsPerStrip() + np * nStripsPerPlane nStrip )
{
-nStrip=ny/nRowsPerStrip+np*nStripsPerPlane;
+nStrip=ny/GetRowsPerStrip()+np*nStripsPerPlane;
if ( nStrip = nNumStripOffsets )
return sal_False;
pTIFF-Seek( pStripOffsets[ nStrip ] );
@@ -632,9 +645,9 @@ sal_Bool TIFFReader::ReadMap( sal_uLong nMinPercent,
sal_uLong nMaxPercent )
{
for ( np = 0; np nPlanes; np++ )
{
-if ( ny / nRowsPerStrip + np * nStripsPerPlane nStrip )
+if ( ny / GetRowsPerStrip() + np * nStripsPerPlane nStrip )
{
-nStrip = ny / nRowsPerStrip + np * nStripsPerPlane;
+nStrip = ny / GetRowsPerStrip() + np * nStripsPerPlane;
if ( nStrip = nNumStripOffsets )
return sal_False;
pTIFF-Seek(pStripOffsets[nStrip]);
@@ -660,9 +673,9 @@ sal_Bool TIFFReader::ReadMap( sal_uLong nMinPercent,
sal_uLong nMaxPercent )
{
for ( np = 0; np nPlanes; np++ )
{
-if ( ny / nRowsPerStrip + np * nStripsPerPlane nStrip )
+if ( ny / GetRowsPerStrip() + np * nStripsPerPlane nStrip )
{
-nStrip=ny/nRowsPerStrip+np*nStripsPerPlane;
+nStrip=ny/GetRowsPerStrip()+np*nStripsPerPlane;
if ( nStrip = nNumStripOffsets )
return sal_False;
pTIFF-Seek(pStripOffsets[nStrip]);
@@ -1318,7 +1331,7 @@ sal_Bool TIFFReader::ReadTIFF(SvStream rTIFF, Graphic
rGraphic )
if ( ( nFillOrder == 2 ) ( nCompression != 5 ) ) //
in the LZW mode bits are already being inverted
bByteSwap = sal_True;
-nStripsPerPlane = ( nImageLength - 1 ) / nRowsPerStrip + 1;
+nStripsPerPlane = ( nImageLength - 1 ) / GetRowsPerStrip()
+ 1;
nBytesPerRow = ( nImageWidth * nSamplesPerPixel / nPlanes
* nBitsPerSample + 7 ) 3;
for ( sal_uLong j = 0; j 4; j++ )
___
Libreoffice-commits mailing list
[Bug 44580] share autocorrect replacement table for misc. language subgroups
https://bugs.freedesktop.org/show_bug.cgi?id=44580 --- Comment #21 from Julien Nabet serval2...@yahoo.fr --- First, I don't think you should manually copy files in user for the tests Then, I don't have LO at work so can't check but there can't be any unlocalized files in user\autocorrect. With the brand new profile all autocorrect files (unlocalized and localized) are in share\autocorrect, adding an entry creates a localized autocorrect file in user\autocorrect. This last one is used in priority. Again, perhaps I miss something or am wrong since I'm not at home to check. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sd/source
sd/source/core/sdpage2.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 6c3327a0644364dab5c7f8b0a49808acb87d
Author: Caolán McNamara caol...@redhat.com
Date: Tue Aug 19 20:49:17 2014 +0100
Resolves: fdo#82355 crash on loading ppt
regression probably triggered by...
commit 2e3c45afc6c5ea74f1f8b4a7dce806e537870546
Date: Fri Mar 4 07:38:16 2011 -0800
Remove usage of deprecated List container.
but that just stopped at the first NULL by chance
Change-Id: I767e3bc3130d99cedceb4172857d1741c677b19b
(cherry picked from commit f47baab6d35752b0babba768e299416ea5dd447d)
Reviewed-on: https://gerrit.libreoffice.org/11028
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/sd/source/core/sdpage2.cxx b/sd/source/core/sdpage2.cxx
index 778bc1f..04e9c10 100644
--- a/sd/source/core/sdpage2.cxx
+++ b/sd/source/core/sdpage2.cxx
@@ -209,9 +209,10 @@ void SdPage::SetPresentationLayout(const OUString
rLayoutName,
if (pSheet != pOldSheet)
{
-pObj-EndListening(*pOldSheet);
+if (pOldSheet)
+pObj-EndListening(*pOldSheet);
-if (!pObj-IsListening(*pSheet))
+if (pSheet !pObj-IsListening(*pSheet))
pObj-StartListening(*pSheet);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sd/source
sd/source/core/sdpage2.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 69f2e46f5f5bb201137b7212c2e16d64efc8cb30
Author: Caolán McNamara caol...@redhat.com
Date: Tue Aug 19 20:49:17 2014 +0100
Resolves: fdo#82355 crash on loading ppt
regression probably triggered by...
commit 2e3c45afc6c5ea74f1f8b4a7dce806e537870546
Date: Fri Mar 4 07:38:16 2011 -0800
Remove usage of deprecated List container.
but that just stopped at the first NULL by chance
Change-Id: I767e3bc3130d99cedceb4172857d1741c677b19b
(cherry picked from commit f47baab6d35752b0babba768e299416ea5dd447d)
Reviewed-on: https://gerrit.libreoffice.org/11029
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/sd/source/core/sdpage2.cxx b/sd/source/core/sdpage2.cxx
index 0b9a552..2ab843a 100644
--- a/sd/source/core/sdpage2.cxx
+++ b/sd/source/core/sdpage2.cxx
@@ -208,9 +208,10 @@ void SdPage::SetPresentationLayout(const OUString
rLayoutName,
if (pSheet != pOldSheet)
{
-pObj-EndListening(*pOldSheet);
+if (pOldSheet)
+pObj-EndListening(*pOldSheet);
-if (!pObj-IsListening(*pSheet))
+if (pSheet !pObj-IsListening(*pSheet))
pObj-StartListening(*pSheet);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/qa writerfilter/source
writerfilter/qa/cppunittests/rtftok/data/pass/sf_2063317381c4a46d642c79a4b1817dc0-101375-minimized.rtf
| 62 ++
writerfilter/source/dmapper/DomainMapperTableHandler.cxx
|8 +
2 files changed, 69 insertions(+), 1 deletion(-)
New commits:
commit 0a42632a74596cbc781746931bf8f2650994b80f
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 08:56:54 2014 +0100
empty Reference
valgrind + bff
Change-Id: Id3c039a46dec5d2d4a4642dfb53d23a76972dde2
diff --git
a/writerfilter/qa/cppunittests/rtftok/data/pass/sf_2063317381c4a46d642c79a4b1817dc0-101375-minimized.rtf
b/writerfilter/qa/cppunittests/rtftok/data/pass/sf_2063317381c4a46d642c79a4b1817dc0-101375-minimized.rtf
new file mode 100644
index 000..c3ffebc
--- /dev/null
+++
b/writerfilter/qa/cppunittests/rtftok/data/pass/sf_2063317381c4a46d642c79a4b1817dc0-101375-minimized.rtf
@@ -0,0 +1,62 @@
+{\rtf1\ansi\deff0\adeflang1025
+{\fonttbl{\f0\froman\fprq2\fcharset0 Times New
Roman;}{\f1\froman\fprq2\fcharset2 Symbol;}{\f2\fswiss\fprq2\fcharset0
Arial;}{\f3\froman\fprq2\fcharset128 Times New
Roman;}{\f4\froman\fprq2\fcharset128 Arial
Narrow;}{\f5\froman\fprq0\fcharset128 Arial
Narrow;}{\f6\froman\fprq2\fcharset128 Symbol;}{\f7\froman\fprq0\fcharset128
Symbol;}{\f8\froman\fprq2\fcharset128 Wingdings;}{\f9\froman\fprq0\fcharset128
Wingdings;}{\f10\froman\fprq0\fcharset128 Times New
Roman;}{\f11\fnil\fprq2\fcharset0 Microsoft YaHei;}{\f12\fnil\fprq2\fcharset128
SimSun;}{\f13\fnil\fprq2\fcharset128 Times New Roman
(Arabic);}{\f14\fnil\fprq0\fcharset128 Times New Roman
(Arabic);}{\f15\fnil\fprq2\fcharset128 Times New
Roman;}{\f16\fnil\fprq0\fcharset128 Times New Roman;}{\f17\fnil\fprq2\fcharset0
Mangal;}{\f18\fnil\fprq0\fcharset128 Mangal;}{\f19\fnil\fprq2\fcharset128
Mangal;}{\f20\fnil\fprq2\fcharset128 Cambria Math;}{\f21\fnil\fprq0\fcharset128
Cambria Math;}}
+{\colortbl;\red0\green0\blue0;\red0\green0\blue255;\red128\green128\blue128;}
+{\stylesheet{\s0\snext0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040
Predefinito;}
+{\s15\sbasedon0\snext16\sb240\sa120\keepn\hich\af11\dbch\af17\afs28\loch\f2\fs28
Intestazione;}
+{\s16\sbasedon0\snext16\sb0\sa120 Corpo testo;}
+{\s17\sbasedon16\snext17\sb0\sa120\dbch\af18 Elenco;}
+{\s18\sbasedon0\snext18\sb120\sa120\noline\i\dbch\af18\afs24\ai\fs24
Didascalia;}
+{\s19\sbasedon0\snext19\noline\dbch\af18 Indice;}
+}{\info{\creatim\yr2011\mo9\dy28\hr16\min28}{\revtim\yr2011\mo9\dy28\hr16\min29}{\printim\yr0\mo0\dy0\hr0\min0}{\comment
LibreOffice}{\vern3500}}\deftab720
+
+{\*\pgdsctbl
+{\pgdsc0\pgdscuse195\pgwsxn12240\pghsxn15840\marglsxn1134\margrsxn1134\margtsxn1417\margbsxn1134\pgdscnxt0
Predefinito;}}
+\formshade{\*\pgdscno0}\paperh15840\paperw12240\margl1134\margr1134\margt1417\margb1134\sectd\sbknone\sectunlocked1\pgndec\pgwsxn12240\pghsxn15840\marglsxn1134\margrsxn1134\margtsxn1417\margbsxn1134\ftnbj\ftnstart1\ftnrstcont\ftnnar\aenddoc\aftnrstcont\aftnstart1\aftnnrlc
+\trowd\trql\trleft-108\ltrrow\trpaddft3\trpaddt0\trpaddfl3\trpaddl0\trpaddfb3\trpaddb0\trpaddfr3\trpaddr0\clvertalt\cellx9864\pgndec\pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\intbl\qr\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0\keepn{\scaps\b\hich\af14\langfe1040\dbch\af14\afs26\alang1025\ab\rtlch
\ltrch\loch\fs26\lang1040\loch\f5
+SSS SSS curriculum vitae}
+\par \pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\intbl\ql\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0{\rtlch
\ltrch\loch
+}
+\par \pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\intbl\qr\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0{\langfe1040\dbch\af14\afs16\alang1025\rtlch
\ltrch\loch\fs16\lang1040\loch\f5
+}\cell\row\pard\pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\ql\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0{\rtlch
\ltrch\loch
+}
+\par \pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\ql\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0{\rtlch
\ltrch\loch
+}
+\par
\trowd\trql\trleft-108\ltrrow\trpaddft3\trpaddt0\trpaddfl3\trpaddl0\trpaddfb3\trpaddb0\trpaddfr3\trpaddr0\clvertalt\cellx9864\pard\plain
\s0\nowidctlpar{\*\hyphen2\hyphlead2\hyphtrail2\hyphmax0}\cf0\kerning1\hich\af22\langfe2052\dbch\af17\afs24\alang1081\loch\f0\fs24\lang1040\intbl\qr\nowidctlpar\faauto\li0\ri0\lin0\rin0\fi0\keepn{\scaps\b\hich\af14\langfe1040\dbch\af14\afs24\alang1025\ab\rtlch
[Libreoffice-commits] core.git: 3 commits - connectivity/source
connectivity/source/commontools/DateConversion.cxx | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
New commits:
commit 34d6e7790f17080bea95ad770a819c7b5159b4c4
Author: David Tardon dtar...@redhat.com
Date: Wed Aug 20 10:06:26 2014 +0200
avoid potential null dereference
Change-Id: I2236a18608ffa9481c30088044f34e1a3372dd11
diff --git a/connectivity/source/commontools/DateConversion.cxx
b/connectivity/source/commontools/DateConversion.cxx
index 373d048..cf6fbe1 100644
--- a/connectivity/source/commontools/DateConversion.cxx
+++ b/connectivity/source/commontools/DateConversion.cxx
@@ -255,9 +255,13 @@ void DBTypeConversion::setValue(const
ReferenceXColumnUpdate xVariant,
sal_Int32 nStandardKey(0);
if(xFormatTypes.is())
{
-css::lang::Locale loc;
-if (xFormats-getByKey(nKeyToUse)-getPropertyValue(Locale)
= loc)
-nStandardKey = xFormatTypes-getStandardIndex(loc);
+const Reference XPropertySet
xFormatProps(xFormats-getByKey(nKeyToUse));
+if (xFormatProps.is())
+{
+css::lang::Locale loc;
+if (xFormatProps-getPropertyValue(Locale) = loc)
+nStandardKey = xFormatTypes-getStandardIndex(loc);
+}
}
// Why use nStandardKey rather than nKeyToUse here? Don't know,
but it was always like that.
// Previously had hardcoded 0 instead of nStandardKey, which led
to problems with dates
commit 8c536baf2072295691711927e262d2341d14a3e1
Author: David Tardon dtar...@redhat.com
Date: Wed Aug 20 10:05:31 2014 +0200
do not use obsolete OSL_VERIFY macro
Change-Id: I8efdd4933d3e47c5e086dc4a4685110390d6b6e8
diff --git a/connectivity/source/commontools/DateConversion.cxx
b/connectivity/source/commontools/DateConversion.cxx
index 3780608..373d048 100644
--- a/connectivity/source/commontools/DateConversion.cxx
+++ b/connectivity/source/commontools/DateConversion.cxx
@@ -256,8 +256,8 @@ void DBTypeConversion::setValue(const
ReferenceXColumnUpdate xVariant,
if(xFormatTypes.is())
{
css::lang::Locale loc;
-
OSL_VERIFY(xFormats-getByKey(nKeyToUse)-getPropertyValue(Locale) = loc);
-nStandardKey = xFormatTypes-getStandardIndex(loc);
+if (xFormats-getByKey(nKeyToUse)-getPropertyValue(Locale)
= loc)
+nStandardKey = xFormatTypes-getStandardIndex(loc);
}
// Why use nStandardKey rather than nKeyToUse here? Don't know,
but it was always like that.
// Previously had hardcoded 0 instead of nStandardKey, which led
to problems with dates
commit 238d6ac878fd5ebc7d5534674b5b98cdac15cf17
Author: David Tardon dtar...@redhat.com
Date: Wed Aug 20 10:00:21 2014 +0200
this assert does not make sense
... as the code apparently can work even if xFormatTypes is empty.
Change-Id: I6b733b9b31329d4fafc745bc23d0f555286950e6
diff --git a/connectivity/source/commontools/DateConversion.cxx
b/connectivity/source/commontools/DateConversion.cxx
index 954e987..3780608 100644
--- a/connectivity/source/commontools/DateConversion.cxx
+++ b/connectivity/source/commontools/DateConversion.cxx
@@ -252,7 +252,6 @@ void DBTypeConversion::setValue(const
ReferenceXColumnUpdate xVariant,
double fValue = xFormatter-convertStringToNumber(nKeyToUse,
rString);
Reference XNumberFormats
xFormats(xFormatter-getNumberFormatsSupplier()-getNumberFormats());
Reference XNumberFormatTypes xFormatTypes(xFormats, UNO_QUERY);
-assert(xFormatTypes.is());
sal_Int32 nStandardKey(0);
if(xFormatTypes.is())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Discussion of Bug 37759 - Pixel around Objects like ellipse
Regina Henschel wrote:
I think, the code that adds these points is
if( !bLineGeometryNeededOnly )
1906 {
1907 // hack aNewB2DPolyPolygon to fill logic rect - this is
1908 // needed to produce gradient fills that look like mso
1909 aNewB2DPolygon.clear();
1910 aNewB2DPolygon.append(basegfx::B2DPoint(0,0));
1911 aNewB2DPolygon.setClosed(true);
1912 aNewB2DPolyPolygon.append(aNewB2DPolygon);
1913
1914 aNewB2DPolygon.clear();
1915
aNewB2DPolygon.append(basegfx::B2DPoint(aLogicRect.GetWidth(),
1916 aLogicRect.GetHeight()));
1917 aNewB2DPolygon.setClosed(true);
1918 aNewB2DPolyPolygon.append(aNewB2DPolygon);
1919 }
in core/svx/source/customshapes/EnhancedCustomShape2d.cxx
Yep, and see the comment why this is there. It should _in theory_ be
trivial to filter out those empty polygons during pdf export, just
that (last time I tried), layers above miraculously split things up in
a funny way already.
First port of call for that these days would be the vcl metafile
processor in drawinglayer I guess.
P.S.: please Cc me for prompt answers. Too many lists. ;)
Cheers,
-- Thorsten
signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44580] share autocorrect replacement table for misc. language subgroups
https://bugs.freedesktop.org/show_bug.cgi?id=44580 --- Comment #22 from tommy27 ba...@quipo.it --- (In reply to comment #21) First, I don't think you should manually copy files in user for the tests trust me, it's harmelss. I've done it multiple times. Then, I don't have LO at worsk so can't check but there can't be any unlocalized files in user\autocorrect. With the brand new profile all autocorrect files (unlocalized and localized) are in share\autocorrect, adding an entry creates a localized autocorrect file in user\autocorrect. This last one is used in priority. it can't be there since you cannot create a brand new one. the workaround is to enter an entry in a language you don't use (let's say iceland) and then rename the dat file which is created inside the user profile. this is what I did to create the acor_en.dat file and it worked. what we miss at the moment is the ability to directly create an unlocalized variant of an autocorrect list since in the language dropdown menu of the replacement table you can only select localized versions of languages like English(UK), English(US), English(Australia) etc. etc. and you don't have the chance to select a plain English language item with no indicated variant. What I think that we should tweak that UI and allow support for variantless languages. Again, perhaps I miss something or am wrong since I'm not at home to check. why don't you downlaod the portable LibreOffice version from WinPenPack? link is here: http://sourceforge.net/projects/winpenpack/files/X-LibreOffice/releases/ then you can put in a USB key and bring it with you everywhere. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - connectivity/source
connectivity/source/commontools/DateConversion.cxx | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
New commits:
commit ff4d02e35e5187211da457facbb07b8e89c0d556
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Mon Aug 18 20:38:43 2014 +0200
fdo#82757 call convertStringToNumber and detectNumberFormat with same locale
So that they agree (among others) on date recognition patterns.
Change-Id: I964142702b5bb23bca2c62433e52f76dfa4bdacb
Reviewed-on: https://gerrit.libreoffice.org/11003
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/connectivity/source/commontools/DateConversion.cxx
b/connectivity/source/commontools/DateConversion.cxx
index bb44707..1f63db8 100644
--- a/connectivity/source/commontools/DateConversion.cxx
+++ b/connectivity/source/commontools/DateConversion.cxx
@@ -250,7 +250,24 @@ void DBTypeConversion::setValue(const
ReferenceXColumnUpdate xVariant,
try
{
double fValue = xFormatter-convertStringToNumber(nKeyToUse,
rString);
-sal_Int32 nRealUsedKey = xFormatter-detectNumberFormat(0,
rString);
+Reference XNumberFormats
xFormats(xFormatter-getNumberFormatsSupplier()-getNumberFormats());
+Reference XNumberFormatTypes xFormatTypes(xFormats, UNO_QUERY);
+sal_Int32 nStandardKey(0);
+if(xFormatTypes.is())
+{
+const Reference XPropertySet
xFormatProps(xFormats-getByKey(nKeyToUse));
+if (xFormatProps.is())
+{
+css::lang::Locale loc;
+if (xFormatProps-getPropertyValue(Locale) = loc)
+nStandardKey = xFormatTypes-getStandardIndex(loc);
+}
+}
+// Why use nStandardKey rather than nKeyToUse here? Don't know,
but it was always like that.
+// Previously had hardcoded 0 instead of nStandardKey, which led
to problems with dates
+// because of differences M/D/Y vs D/M/Y. This at least fixes
those problems, but possibly
+// nKeyToUse is an even better choice than nStandardKey.
+sal_Int32 nRealUsedKey =
xFormatter-detectNumberFormat(nStandardKey, rString);
if (nRealUsedKey != nKeyToUse)
nRealUsedTypeClass = getNumberFormatType(xFormatter,
nRealUsedKey) ~NumberFormat::DEFINED;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: formula/source
formula/source/ui/dlg/funcpage.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a240a78cc771a89febfe181abe78d2cf16e1970f Author: Szymon KÅos eszka...@gmail.com Date: Wed Aug 20 09:56:17 2014 +0200 Fixed size of 'formula' dialog in Calc Fixed: 1. Open Calc 2. Open formula dialog 3. Choose AMORDEGRC function or other with = 4 params Edit field is covered by other controls Change-Id: Ie14ff91a17373e11bc8ef6477f4f22c0ea4570c3 Reviewed-on: https://gerrit.libreoffice.org/11035 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/formula/source/ui/dlg/funcpage.cxx b/formula/source/ui/dlg/funcpage.cxx index f8c9e6d..731c4f0 100644 --- a/formula/source/ui/dlg/funcpage.cxx +++ b/formula/source/ui/dlg/funcpage.cxx @@ -78,7 +78,7 @@ FuncPage::FuncPage(Window* pParent,const IFunctionManager* _pFunctionManager): get(m_pLbCategory, category); get(m_pLbFunction, function); m_pLbFunction-SetStyle(m_pLbFunction-GetStyle() | WB_SORT); -Size aSize(LogicToPixel(Size(86 , 133), MAP_APPFONT)); +Size aSize(LogicToPixel(Size(86 , 162), MAP_APPFONT)); m_pLbFunction-set_height_request(aSize.Height()); m_pLbFunction-set_width_request(aSize.Width()); m_aHelpId = m_pLbFunction-GetHelpId(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - vcl/source
vcl/source/window/layout.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit daecdd8ba0f3fed88febb35564e4b5d939cec0b6
Author: Caolán McNamara caol...@redhat.com
Date: Tue Aug 19 17:20:00 2014 +0100
only subtract height of hscroll if visible
otherwise infinite loop in extensions update check
Change-Id: I0dbf4f34208f1bf0854e365006a79470b26571f3
(cherry picked from commit 749f7548b4ee746d69c20a828ea6d3b853eba8d3)
Reviewed-on: https://gerrit.libreoffice.org/11034
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index 517fa33..06f387b 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -1704,8 +1704,11 @@ void VclScrolledWindow::setAllocation(const Size
rAllocation)
// horz. ScrollBar
if (GetStyle() WB_AUTOHSCROLL)
{
-m_aHScroll.Show(nAvailWidth aChildReq.Width());
-nAvailHeight -= getLayoutRequisition(m_aHScroll).Height();
+bool bShowHScroll = nAvailWidth aChildReq.Width();
+m_aHScroll.Show(bShowHScroll);
+
+if (bShowHScroll)
+nAvailHeight -= getLayoutRequisition(m_aHScroll).Height();
if (GetStyle() WB_AUTOVSCROLL)
m_aVScroll.Show(nAvailHeight aChildReq.Height());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - vcl/source
vcl/source/window/layout.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit c0aedce4e6f5393eb31a88a24a5f25cd5cf21142
Author: Caolán McNamara caol...@redhat.com
Date: Tue Aug 19 17:20:00 2014 +0100
only subtract height of hscroll if visible
otherwise infinite loop in extensions update check
Change-Id: I0dbf4f34208f1bf0854e365006a79470b26571f3
(cherry picked from commit 749f7548b4ee746d69c20a828ea6d3b853eba8d3)
Reviewed-on: https://gerrit.libreoffice.org/11033
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index 9e204a8..975df2f 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -1706,8 +1706,11 @@ void VclScrolledWindow::setAllocation(const Size
rAllocation)
// horz. ScrollBar
if (GetStyle() WB_AUTOHSCROLL)
{
-m_aHScroll.Show(nAvailWidth aChildReq.Width());
-nAvailHeight -= getLayoutRequisition(m_aHScroll).Height();
+bool bShowHScroll = nAvailWidth aChildReq.Width();
+m_aHScroll.Show(bShowHScroll);
+
+if (bShowHScroll)
+nAvailHeight -= getLayoutRequisition(m_aHScroll).Height();
if (GetStyle() WB_AUTOVSCROLL)
m_aVScroll.Show(nAvailHeight aChildReq.Height());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - filter/source
filter/source/graphicfilter/itiff/itiff.cxx | 29
1 file changed, 17 insertions(+), 12 deletions(-)
New commits:
commit 3bcdd9fc24a9bec2997768c6aa7a78a0c1f329ee
Author: Caolán McNamara caol...@redhat.com
Date: Tue Aug 19 15:14:04 2014 +0100
guard against division by 0
valgrind + bff
Change-Id: I5fa40f7a9759c98bb70ee6eb854dd9b376401f89
(cherry picked from commit 1ab0e8717bee9fee6c42015647bccfbf1683b8fc)
Reviewed-on: https://gerrit.libreoffice.org/11036
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index f708435..4122ab2 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1324,29 +1324,34 @@ bool TIFFReader::ReadTIFF(SvStream rTIFF, Graphic
rGraphic )
bByteSwap = true;
nStripsPerPlane = ( nImageLength - 1 ) / GetRowsPerStrip()
+ 1;
-nBytesPerRow = ( nImageWidth * nSamplesPerPixel / nPlanes
* nBitsPerSample + 7 ) 3;
+bStatus = nPlanes != 0;
-for ( sal_uLong j = 0; j 4; j++ )
+if (bStatus)
{
-try
-{
-pMap[ j ] = new sal_uInt8[ nBytesPerRow ];
-}
-catch (const std::bad_alloc )
+nBytesPerRow = ( nImageWidth * nSamplesPerPixel /
nPlanes * nBitsPerSample + 7 ) 3;
+
+for ( sal_uLong j = 0; j 4; j++ )
{
-pMap[ j ] = NULL;
-bStatus = false;
-break;
+try
+{
+pMap[ j ] = new sal_uInt8[ nBytesPerRow ];
+}
+catch (const std::bad_alloc )
+{
+pMap[ j ] = NULL;
+bStatus = false;
+break;
+}
}
}
-if (HasAlphaChannel())
+if (bStatus HasAlphaChannel())
{
pAlphaMask = new AlphaMask( aTargetSize );
pMaskAcc = pAlphaMask-AcquireWriteAccess();
}
-if ( bStatus ReadMap( 10, 60 ) )
+if (bStatus ReadMap(10, 60))
{
nMaxPos = std::max( pTIFF-Tell(), nMaxPos );
MakePalCol();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - filter/source
filter/source/graphicfilter/itiff/itiff.cxx | 29
1 file changed, 17 insertions(+), 12 deletions(-)
New commits:
commit 9485833fb89f86b7ac9c4de14b116ca6cf3f8faf
Author: Caolán McNamara caol...@redhat.com
Date: Tue Aug 19 15:14:04 2014 +0100
guard against division by 0
valgrind + bff
(cherry picked from commit 1ab0e8717bee9fee6c42015647bccfbf1683b8fc)
Conflicts:
filter/source/graphicfilter/itiff/itiff.cxx
Change-Id: I5fa40f7a9759c98bb70ee6eb854dd9b376401f89
Reviewed-on: https://gerrit.libreoffice.org/11037
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index a921b53..aa80b09 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1332,29 +1332,34 @@ sal_Bool TIFFReader::ReadTIFF(SvStream rTIFF, Graphic
rGraphic )
bByteSwap = sal_True;
nStripsPerPlane = ( nImageLength - 1 ) / GetRowsPerStrip()
+ 1;
-nBytesPerRow = ( nImageWidth * nSamplesPerPixel / nPlanes
* nBitsPerSample + 7 ) 3;
+bStatus = nPlanes != 0;
-for ( sal_uLong j = 0; j 4; j++ )
+if (bStatus)
{
-try
-{
-pMap[ j ] = new sal_uInt8[ nBytesPerRow ];
-}
-catch (const std::bad_alloc )
+nBytesPerRow = ( nImageWidth * nSamplesPerPixel /
nPlanes * nBitsPerSample + 7 ) 3;
+
+for ( sal_uLong j = 0; j 4; j++ )
{
-pMap[ j ] = NULL;
-bStatus = sal_False;
-break;
+try
+{
+pMap[ j ] = new sal_uInt8[ nBytesPerRow ];
+}
+catch (const std::bad_alloc )
+{
+pMap[ j ] = NULL;
+bStatus = sal_False;
+break;
+}
}
}
-if (HasAlphaChannel())
+if (bStatus HasAlphaChannel())
{
pAlphaMask = new AlphaMask( aTargetSize );
pMaskAcc = pAlphaMask-AcquireWriteAccess();
}
-if ( bStatus ReadMap( 10, 60 ) )
+if (bStatus ReadMap(10, 60))
{
nMaxPos = std::max( pTIFF-Tell(), nMaxPos );
MakePalCol();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - connectivity/source
connectivity/source/parse/sqlbison.y |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 9a0d9d4f404eb49bbe23aa9b70a9ebd7bafdb7c0
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Mon Aug 18 22:22:22 2014 +0200
fdo#82427 disambiguate NOT LIKE 'foo'
Change-Id: Iab383639ea73cc87c03f4f42433bc9ccfcd988ef
Reviewed-on: https://gerrit.libreoffice.org/11008
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/connectivity/source/parse/sqlbison.y
b/connectivity/source/parse/sqlbison.y
index 35819a3..231c9e1 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -1124,8 +1124,8 @@ parenthesized_boolean_value_expression:
}
;
boolean_factor:
- boolean_primary
- | SQL_TOKEN_NOT boolean_primary
+ boolean_primary %dprec 2
+ | SQL_TOKEN_NOT boolean_primary %dprec 1
{ // boolean_factor: rule 1
$$ = SQL_NEW_RULE;
$$-append($1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - connectivity/source
connectivity/source/parse/sqlbison.y |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 967039703c73a9efc225d0d4d9c1f3a168977a46
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Mon Aug 18 22:22:22 2014 +0200
fdo#82427 disambiguate NOT LIKE 'foo'
Change-Id: Iab383639ea73cc87c03f4f42433bc9ccfcd988ef
Reviewed-on: https://gerrit.libreoffice.org/11010
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/connectivity/source/parse/sqlbison.y
b/connectivity/source/parse/sqlbison.y
index 0a3772f..a750541 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -1126,8 +1126,8 @@ parenthesized_boolean_value_expression:
}
;
boolean_factor:
- boolean_primary
- | SQL_TOKEN_NOT boolean_primary
+ boolean_primary %dprec 2
+ | SQL_TOKEN_NOT boolean_primary %dprec 1
{ // boolean_factor: rule 1
$$ = SQL_NEW_RULE;
$$-append($1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44580] share autocorrect replacement table for misc. language subgroups
https://bugs.freedesktop.org/show_bug.cgi?id=44580 --- Comment #23 from Julien Nabet serval2...@yahoo.fr --- There are 2 points to distinguish: 1) In the basic process, there can't be any unlocalized file in user/autocorrect. It seems you may have weird result only if you bypass the process by copying an unlocalized file in it. 2) I understand you'd like to edit unlocalized file and I didn't try to implement it. Being able to edit it would mean indeed mean there could be unlocalized files in user/autocorrect (without manually copying). I don't think I'd be able to do it since it means: - to be able to list unlocalized languages as you said - prevent conflicts you described when there are localized and unlocalized files (again as you said) I'm sorry to tell I can't help more on this last point :-( Andras/Michael: any thoughts? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 8 commits - android/experimental bean/com bean/qa codemaker/test comphelper/qa connectivity/qa dbaccess/qa filter/qa forms/qa framework/qa javaunohelper/com javaunohelp
android/experimental/LibreOffice4Android/src/org/libreoffice/android/DocumentLoader.java |2 android/experimental/LibreOffice4Android/src/org/libreoffice/ui/LibreOfficeUIActivity.java |1 bean/com/sun/star/beans/LocalOfficeConnection.java |3 - bean/com/sun/star/comp/beans/LocalOfficeConnection.java |5 - bean/com/sun/star/comp/beans/OOoBean.java |4 - bean/qa/complex/bean/WriterFrame.java |2 codemaker/test/javamaker/Test.java | 12 ++-- comphelper/qa/complex/comphelper/SequenceOutputStreamUnitTest.java |2 connectivity/qa/complex/connectivity/hsqldb/DatabaseMetaData.java |2 dbaccess/qa/complex/dbaccess/RowSet.java |6 +- filter/qa/complex/filter/detection/typeDetection/Helper.java |6 +- forms/qa/integration/forms/BooleanValidator.java |4 - framework/qa/complex/accelerators/AcceleratorsConfigurationTest.java |8 +- framework/qa/complex/loadAllDocuments/CheckXComponentLoader.java |4 - javaunohelper/com/sun/star/lib/uno/helper/InterfaceContainer.java |6 +- javaunohelper/com/sun/star/lib/uno/helper/PropertySet.java | 12 +--- javaunohelper/test/com/sun/star/comp/helper/Bootstrap_Test.java |2 javaunohelper/test/com/sun/star/comp/helper/SharedLibraryLoader_Test.java |4 - javaunohelper/test/com/sun/star/lib/uno/helper/ComponentBase_Test.java |6 +- javaunohelper/test/com/sun/star/lib/uno/helper/InterfaceContainer_Test.java | 14 ++--- javaunohelper/test/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer_Test.java | 12 ++-- javaunohelper/test/com/sun/star/lib/uno/helper/PropertySet_Test.java | 28 +- javaunohelper/test/com/sun/star/lib/uno/helper/ProxyProvider.java | 12 +--- javaunohelper/test/com/sun/star/lib/uno/helper/WeakBase_Test.java |8 +- jvmfwk/plugins/sunmajor/pluginlib/JREProperties.java |2 odk/examples/DevelopersGuide/Drawing/PresentationDemo.java |2 odk/examples/DevelopersGuide/GUI/UnoDialogSample2.java |4 - odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/Desk.java |4 - odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/DocumentView.java |4 - odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/FunctionHelper.java | 16 ++--- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/Interceptor.java | 16 ++--- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java |2 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/ViewContainer.java | 10 +-- odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java | 10 +-- odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/FilterOptions.java |2 odk/examples/DevelopersGuide/OfficeDev/Linguistic/PropChgHelper_Spell.java |6 +- odk/examples/DevelopersGuide/OfficeDev/TerminationTest/TerminateListener.java |2 odk/examples/DevelopersGuide/OfficeDev/TerminationTest/TerminationTest.java |4 - odk/examples/DevelopersGuide/ScriptingFramework/ScriptSelector/ScriptSelector/ScriptSelector.java |2 odk/examples/java/EmbedDocument/EmbeddedObject/OwnEmbeddedObject.java |1 odk/source/com/sun/star/lib/loader/InstallationFinder.java |2 qadevOOo/runner/convwatch/ConvWatch.java |6 +- qadevOOo/runner/convwatch/ConvWatchStarter.java |2 qadevOOo/runner/convwatch/DirectoryHelper.java |2 qadevOOo/runner/convwatch/DocumentConverter.java |2 qadevOOo/runner/convwatch/FileHelper.java
[Libreoffice-commits] core.git: svl/source
svl/source/numbers/zformat.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit d01ee7e2cc7315728a5a8e04bb1d6847ec185483 Author: Caolán McNamara caol...@redhat.com Date: Wed Aug 20 09:38:34 2014 +0100 fix string out-of-bounds assert on gnome627759-1.ods i.e. on soffice --headless --convert-to pdf gnome627759-1.ods Change-Id: I01289d5afcc79b7180cc12f8ee345ac760b6a637 diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx index 633b803..aa0b8a6 100644 --- a/svl/source/numbers/zformat.cxx +++ b/svl/source/numbers/zformat.cxx @@ -4359,7 +4359,8 @@ bool SvNumberformat::ImpGetNumberOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -/*k = */ InsertBlanks(sStr, k, rInfo.sStrArray[j][1] ); +if (rInfo.sStrArray[j].getLength() = 2) +/*k = */ InsertBlanks(sStr, k, rInfo.sStrArray[j][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -4492,7 +4493,8 @@ bool SvNumberformat::ImpNumberFillWithThousands( OUStringBuffer sBuff, // numb } break; case NF_SYMBOLTYPE_BLANK: -/*k = */ InsertBlanks(sBuff, k, rInfo.sStrArray[j][1] ); +if (rInfo.sStrArray[j].getLength() = 2) +/*k = */ InsertBlanks(sBuff, k, rInfo.sStrArray[j][1] ); break; case NF_SYMBOLTYPE_THSEP: // #i7284# #102685# Insert separator also if number is divided ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sdext/source
sdext/source/pdfimport/wrapper/wrapper.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 30541352a195c57c0b4f65e29b1994be46421ad1 Author: Caolán McNamara caol...@redhat.com Date: Wed Aug 20 09:49:46 2014 +0100 fix string out-of-bounds assert on rhbz496762-1.pdf Change-Id: I224e3c9befd1a9ab3ba0cc2676cd6b4ba51214c8 diff --git a/sdext/source/pdfimport/wrapper/wrapper.cxx b/sdext/source/pdfimport/wrapper/wrapper.cxx index 7cdb775..eedffe4 100644 --- a/sdext/source/pdfimport/wrapper/wrapper.cxx +++ b/sdext/source/pdfimport/wrapper/wrapper.cxx @@ -374,7 +374,10 @@ void Parser::readChar() readDouble(aUnoMatrix.m11); readDouble(fontSize); -OString aChars = lcl_unescapeLineFeeds( m_aLine.copy( m_nCharIndex ) ); +OString aChars; + +if (m_nCharIndex != -1) +aChars = lcl_unescapeLineFeeds( m_aLine.copy( m_nCharIndex ) ); // chars gobble up rest of line m_nCharIndex = -1; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/crsr/annotationmark.cxx |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit 17ccc09ec27bde00e5ed7a9fe6055a991992b0ed
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 10:04:32 2014 +0100
fix crash on loading ooo83574-1.doc
Change-Id: Ia959dde8bac2d663cf1a5bec0358ee89dcaf42ed
diff --git a/sw/source/core/crsr/annotationmark.cxx
b/sw/source/core/crsr/annotationmark.cxx
index 4e2e958..b4e3c1f 100644
--- a/sw/source/core/crsr/annotationmark.cxx
+++ b/sw/source/core/crsr/annotationmark.cxx
@@ -51,9 +51,11 @@ namespace sw { namespace mark
void AnnotationMark::InitDoc(SwDoc* const io_pDoc)
{
-SwTxtFld* pTxtFld =
-GetMarkEnd().nNode.GetNode().GetTxtNode()-GetFldTxtAttrAt(
-GetMarkEnd().nContent.GetIndex()-1, true );
+SwTxtNode *pTxtNode = GetMarkEnd().nNode.GetNode().GetTxtNode();
+
+SwTxtFld* pTxtFld = pTxtNode ?
+pTxtNode-GetFldTxtAttrAt(
+GetMarkEnd().nContent.GetIndex()-1, true ) : NULL;
OSL_ENSURE( pTxtFld != NULL, AnnotationMark::InitDoc(..) - missing
text attribute for annotation field! );
if ( pTxtFld != NULL )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/get-bugzilla-attachments-by-mimetype
bin/get-bugzilla-attachments-by-mimetype | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit 7543a4165be9333054ab14f8a0d99af52fc71530 Author: Caolán McNamara caol...@redhat.com Date: Wed Aug 20 10:18:42 2014 +0100 fix indent to get this working again Change-Id: If48dcf4d04d3888975687aa85557e2cee317f2dd diff --git a/bin/get-bugzilla-attachments-by-mimetype b/bin/get-bugzilla-attachments-by-mimetype index c48bbc8..ef44dbd 100755 --- a/bin/get-bugzilla-attachments-by-mimetype +++ b/bin/get-bugzilla-attachments-by-mimetype @@ -29,20 +29,20 @@ import stat import sys import threading, Queue try: -from urllib.request import urlopen +from urllib.request import urlopen except: -from urllib import urlopen +from urllib import urlopen try: -import xmlrpc.client as xmlrpclib +import xmlrpc.client as xmlrpclib except: -import xmlrpclib +import xmlrpclib from xml.dom import minidom from xml.sax.saxutils import escape def urlopen_retry(url): -maxretries = 3 -for i in range(maxretries + 1): -try: +maxretries = 3 +for i in range(maxretries + 1): +try: return urlopen(url) except IOError as e: print(caught IOError: + str(e)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/bastyp/index.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9cad46b36427aba3082dc096a19f96fc63276ed1
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 10:20:30 2014 +0100
move comment into assert
Change-Id: I230fdf40dc2df552b8cfbdee33e8d3bd25fb81de
diff --git a/sw/source/core/bastyp/index.cxx b/sw/source/core/bastyp/index.cxx
index f180ce0..cdf89e1 100644
--- a/sw/source/core/bastyp/index.cxx
+++ b/sw/source/core/bastyp/index.cxx
@@ -214,7 +214,7 @@ SwIndexReg::SwIndexReg()
SwIndexReg::~SwIndexReg()
{
-assert(!m_pFirst !m_pLast); // There are still indices registered
+assert(!m_pFirst !m_pLast There are still indices registered);
}
void SwIndexReg::Update(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=79641 Bug 79641 depends on bug 79761, which changed state. Bug 79761 Summary: autocorrect slow-down got worse https://bugs.freedesktop.org/show_bug.cgi?id=79761 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/subsequent_export-test.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4fe377ad6dce2f5dcbbf7a989030b27bedf1077f
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date: Wed Aug 20 11:27:14 2014 +0200
disable the test until I understand the problem
Change-Id: I9a24ff49823a9521d412e1e761c4c1b6ece6b601
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 601b0d8..0adfb5e 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -1976,7 +1976,7 @@ void ScExportTest::testSheetProtection()
void ScExportTest::testFunctionsExcel2010ODS()
{
-testFunctionsExcel2010(ODS);
+//testFunctionsExcel2010(ODS);
}
ScExportTest::ScExportTest()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - bean/com comphelper/qa connectivity/qa framework/qa jurt/com jurt/test nlpsolver/src nlpsolver/ThirdParty odk/examples qadevOOo/runner qadevOOo/tests report
bean/com/sun/star/beans/NativeService.java |6 bean/com/sun/star/comp/beans/NativeService.java |6 comphelper/qa/complex/comphelper/Map.java |2 connectivity/qa/complex/connectivity/FlatFileAccess.java |2 connectivity/qa/complex/connectivity/TestCase.java |4 framework/qa/complex/XUserInputInterception/EventTest.java |4 framework/qa/complex/imageManager/_XUIConfiguration.java |8 jurt/com/sun/star/lib/uno/environments/remote/IThreadPool.java | 18 - jurt/test/com/sun/star/lib/uno/environments/remote/TestIWorkAt.java |2 nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/encode/IEncodeEngine.java |2 nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/global/IUpdateCycleEngine.java |2 nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/goodness/IGoodnessCompareEngine.java |8 nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/knowledge/ILibEngine.java |2 nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/space/ILocationEngine.java |2 nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/dialogs/IEvolutionarySolverStatusDialog.java | 28 - odk/examples/DevelopersGuide/Config/ConfigExamples.java |6 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/IOnewayLink.java |2 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/IShutdownListener.java |2 qadevOOo/runner/base/TestBase.java |2 qadevOOo/runner/convwatch/FilenameHelper.java | 10 qadevOOo/runner/convwatch/PropertyName.java | 62 ++-- qadevOOo/runner/graphical/IDocument.java |2 qadevOOo/runner/graphical/IOffice.java |8 qadevOOo/runner/graphical/PropertyName.java | 22 - qadevOOo/runner/helper/AppProvider.java |6 qadevOOo/runner/share/ComplexTest.java |4 qadevOOo/runner/share/CwsDataExchange.java |4 qadevOOo/runner/share/LogWriter.java | 12 qadevOOo/runner/share/Watcher.java |4 qadevOOo/runner/util/PropertyName.java | 62 ++-- qadevOOo/runner/util/compare/DocComparator.java | 16 - qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java |2 qadevOOo/tests/java/ifc/awt/_XUserInputInterception.java |4 qadevOOo/tests/java/ifc/awt/tree/_XMutableTreeNode.java |4 qadevOOo/tests/java/ifc/awt/tree/_XTreeControl.java |4 qadevOOo/tests/java/ifc/awt/tree/_XTreeDataModel.java |4 qadevOOo/tests/java/ifc/document/_XFilter.java |2 qadevOOo/tests/java/ifc/form/_XChangeBroadcaster.java |4 qadevOOo/tests/java/ifc/form/_XDatabaseParameterBroadcaster.java |6 qadevOOo/tests/java/ifc/form/_XUpdateBroadcaster.java |8 qadevOOo/tests/java/ifc/io/_XOutputStream.java
[Libreoffice-commits] core.git: 4 commits - bridges/test connectivity/qa dbaccess/qa desktop/test extensions/qa forms/qa framework/qa javaunohelper/com javaunohelper/test jurt/com nlpsolver/ThirdParty
bridges/test/java_remote/StopMessageDispatcherTest.java |1 connectivity/qa/complex/connectivity/FlatFileAccess.java |5 - dbaccess/qa/complex/dbaccess/ApplicationController.java |6 - dbaccess/qa/complex/dbaccess/Beamer.java |6 - dbaccess/qa/complex/dbaccess/CopyTableWizard.java |7 - desktop/test/deployment/options/handler/com/sun/star/comp/extensionoptions/OptionsEventHandler.java |2 extensions/qa/complex/extensions/OfficeResourceLoader.java |5 - extensions/qa/integration/extensions/ObjectInspector.java |5 - extensions/qa/integration/extensions/TestSkeleton.java |5 - forms/qa/integration/forms/CellBinding.java |5 - forms/qa/integration/forms/ControlValidation.java |5 - forms/qa/integration/forms/ControlValidator.java |5 - forms/qa/integration/forms/DateValidator.java |5 - forms/qa/integration/forms/ListSelectionValidator.java |5 - forms/qa/integration/forms/MasterDetailForms.java |5 - forms/qa/integration/forms/NumericValidator.java |5 - forms/qa/integration/forms/RadioButtons.java |5 - forms/qa/integration/forms/TextValidator.java |5 - forms/qa/integration/forms/TimeValidator.java |5 - forms/qa/integration/forms/XMLFormSettings.java |5 - framework/qa/complex/dispatches/Interceptor.java |9 -- javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java |5 - javaunohelper/com/sun/star/lib/uno/helper/PropertySetMixin.java |4 javaunohelper/test/com/sun/star/lib/uno/helper/PropertySet_Test.java |5 - javaunohelper/test/com/sun/star/lib/uno/helper/ProxyProvider.java |4 javaunohelper/test/com/sun/star/lib/uno/helper/WeakBase_Test.java |5 - jurt/com/sun/star/lib/uno/environments/remote/JavaThreadPoolFactory.java |1 jurt/com/sun/star/lib/uno/protocols/urp/PendingRequests.java |1 nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/encode/EvalElement.java |2 nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/global/OutputMethods.java |5 - odk/examples/DevelopersGuide/Charts/JavaSampleChartAddIn.java |2 odk/examples/DevelopersGuide/Components/JavaComponent/TestComponentA.java |3 odk/examples/DevelopersGuide/Components/SimpleLicense/LicenseTest.java |5 - odk/examples/DevelopersGuide/Components/Thumbs/org/openoffice/comp/test/ImageShrink.java |7 - odk/examples/DevelopersGuide/Database/OpenQuery.java |4 odk/examples/DevelopersGuide/FirstSteps/FirstLoadComponent.java |4 odk/examples/DevelopersGuide/FirstSteps/HelloTextTableShape.java |4 odk/examples/DevelopersGuide/ProfUNO/Lifetime/MyUnoObject.java |1 odk/examples/DevelopersGuide/ScriptingFramework/ScriptSelector/ScriptSelector/ScriptSelector.java |4 odk/examples/DevelopersGuide/Text/TextDocuments.java |4
[Libreoffice-commits] core.git: 2 commits - chart2/source
chart2/source/view/charttypes/GL3DBarChart.cxx | 102 ++---
chart2/source/view/inc/GL3DBarChart.hxx|5 +
2 files changed, 98 insertions(+), 9 deletions(-)
New commits:
commit b7c78772571933b34ff618f07161697c958ba60a
Author: weigao wei...@multicorewareinc.com
Date: Wed Aug 20 13:01:19 2014 +0200
add screen text to auto fly
Change-Id: I6a4549bf47f5126510c3ddb93733b2d56a4159e2
diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx
b/chart2/source/view/charttypes/GL3DBarChart.cxx
index be8a561..fb6e912 100644
--- a/chart2/source/view/charttypes/GL3DBarChart.cxx
+++ b/chart2/source/view/charttypes/GL3DBarChart.cxx
@@ -189,11 +189,11 @@ class RenderBenchMarkThread : public RenderThread
public:
RenderBenchMarkThread(GL3DBarChart * pChart)
: RenderThread(pChart)
+, mbAutoFlyExecuting(0)
, mbExecuting(false)
, mbNeedFlyBack(false)
, mnStep(0)
, mnStepsTotal(0)
-, mbAutoFlyExecuting(0)
{
osl_getSystemTime(maClickFlyBackStartTime);
osl_getSystemTime(maClickFlyBackEndTime);
@@ -536,7 +536,6 @@ void GL3DBarChart::create3DShapes(const
boost::ptr_vectorVDataSeries rDataSer
if (BENCH_MARK_MODE)
{
mnColorRate = 0;
-mnAutoFlyBarID = 0;
}
maShapes.push_back(new opengl3D::Camera(mpRenderer.get()));
mpCamera = static_castopengl3D::Camera*(maShapes.back());
@@ -601,8 +600,8 @@ void GL3DBarChart::create3DShapes(const
boost::ptr_vectorVDataSeries rDataSer
recordBarHistory(nId, nVal);
if (BENCH_MARK_MODE)
{
-std::mapsal_uInt32, sal_uInt32::const_iterator itr =
maBarColorMap.find(nId);
-if (itr == maBarColorMap.end())
+std::mapsal_uInt32, sal_uInt32::const_iterator it =
maBarColorMap.find(nId);
+if (it == maBarColorMap.end())
{
maBarColorMap[nId] = nColor;
}
@@ -1070,9 +1069,10 @@ void GL3DBarChart::recordBarHistory(sal_uInt32 nBarID,
float nVal)
void GL3DBarChart::updateClickEvent()
{
-if (maRenderEvent == EVENT_CLICK)
+if (maRenderEvent == EVENT_CLICK || maRenderEvent == EVENT_AUTO_FLY)
{
-std::listfloat aList = maBarHistory[mSelectBarId];
+sal_uInt32 nBarId = maRenderEvent == EVENT_CLICK ? mSelectBarId :
mnAutoFlyBarID;
+std::listfloat aList = maBarHistory[nBarId];
sal_uInt32 idex = 0;
for (std::listfloat::iterator it = aList.begin();it !=
aList.end();++it)
{
@@ -1083,7 +1083,7 @@ void GL3DBarChart::updateClickEvent()
maScreenTextShapes.push_back(new
opengl3D::ScreenText(mpRenderer.get(), *mpTextCache, aBarValue,
CALC_POS_EVENT_ID));
const opengl3D::TextCacheItem rTextCache =
mpTextCache-getText(aBarValue);
float nRectWidth = (float)rTextCache.maSize.Width() /
(float)rTextCache.maSize.Height() * 0.03;
-std::mapsal_uInt32, const BarInformation::const_iterator itr
= maBarMap.find(mSelectBarId);
+std::mapsal_uInt32, const BarInformation::const_iterator itr
= maBarMap.find(nBarId);
const BarInformation rBarInfo = itr-second;
glm::vec3 aTextPos = glm::vec3(rBarInfo.maPos.x + BAR_SIZE_X /
2.0f,
rBarInfo.maPos.y + BAR_SIZE_Y /
2.0f,
@@ -1240,7 +1240,7 @@ void GL3DBarChart::processAutoFly(sal_uInt32 nId,
sal_uInt32 nColor)
sal_uInt32 nPreColor = maBarColorMap[nId];
maBarColorMap[nId] = nColor;
//if has manul event, just record the color and process manul event first
-if ((maRenderEvent != EVENT_NONE) (maRenderEvent != EVENT_AUTO_FLY))
+if ((maRenderEvent != EVENT_NONE))
{
return;
}
commit 8434a2b6aaff9a1a9ce10d9eb9489ebf2929f724
Author: weigao wei...@multicorewareinc.com
Date: Tue Aug 19 19:24:06 2014 +0800
add auto fly code
Change-Id: Id137892b855b4a70625335ede8015dfe6dce1e7e
diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx
b/chart2/source/view/charttypes/GL3DBarChart.cxx
index 8f9d8ec..be8a561 100644
--- a/chart2/source/view/charttypes/GL3DBarChart.cxx
+++ b/chart2/source/view/charttypes/GL3DBarChart.cxx
@@ -33,6 +33,7 @@
#define HISTORY_NUM 5
#define SHOW_VALUE_COUNT 15
#define SHOW_SCROLL_TEXT_DISTANCE 1000
+#define FLY_THRESHOLD 20
using namespace com::sun::star;
@@ -192,6 +193,7 @@ public:
, mbNeedFlyBack(false)
, mnStep(0)
, mnStepsTotal(0)
+, mbAutoFlyExecuting(0)
{
osl_getSystemTime(maClickFlyBackStartTime);
osl_getSystemTime(maClickFlyBackEndTime);
@@ -207,9 +209,11 @@ private:
void ProcessScroll();
void UpdateScreenText();
void ProcessClickFlyBack();
+void AutoMoveToBar();
private:
glm::vec3 maStartPos;
glm::vec3 maEndPos;
+bool mbAutoFlyExecuting;
bool mbExecuting;
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/ui/view/viewfun6.cxx | 89 ++---
1 file changed, 75 insertions(+), 14 deletions(-)
New commits:
commit fdb7429bf5275469d05ea028a94aa6935399494e
Author: Eike Rathke er...@redhat.com
Date: Wed Aug 20 13:35:33 2014 +0200
update input bar with new value
If setting the number format isn't called we need to explicitly update
the input bar.
Change-Id: I60c4808ce86eb659d3faf92d368c5118ee9673b2
diff --git a/sc/source/ui/view/viewfun6.cxx b/sc/source/ui/view/viewfun6.cxx
index bfe6dfd..3874548 100644
--- a/sc/source/ui/view/viewfun6.cxx
+++ b/sc/source/ui/view/viewfun6.cxx
@@ -377,6 +377,8 @@ void ScViewFunc::InsertCurrentTime(short nReqFmt, const
OUString rUndoStr)
// through.
if (bForceReqFmt || (nReqFmt != nCurNumFormatType nCurNumFormatType !=
NUMBERFORMAT_DATETIME))
SetNumberFormat(nReqFmt);
+else
+rViewData.UpdateInputHandler(); // update input bar with new value
pUndoMgr-LeaveListAction();
}
commit 32e8c47df81292c71ce1d885762358f18559bdb7
Author: Eike Rathke er...@redhat.com
Date: Wed Aug 20 12:27:07 2014 +0200
refine current date/time hotkey handling
Nearing the do what I mean principle..
* key date on time cell = current date + time of cell = date+time
formatted cell
* unless time cell was empty or 00:00 time = current date = date
formatted cell
* key date on date+time cell = current date + 00:00 time = date+time
formatted cell
* unless date was current date = current date = date formatted cell
* key date on other cell = current date = date formatted cell
* key time on date cell = date of cell + current time = date+time
formatted cell
* unless date cell was empty = current time = time formatted cell
* key time on date+time cell = current time = time formatted cell
* unless cell was empty = current date+time = date+time formatted
cell
* key time on other cell = current time = time formatted cell
Change-Id: I5025e0d0ea9ac83d1b9e0b130262df6db4693a56
diff --git a/sc/source/ui/view/viewfun6.cxx b/sc/source/ui/view/viewfun6.cxx
index b7a429c..bfe6dfd 100644
--- a/sc/source/ui/view/viewfun6.cxx
+++ b/sc/source/ui/view/viewfun6.cxx
@@ -236,7 +236,20 @@ void ScViewFunc::DetectiveMarkSucc()
MarkAndJumpToRanges(aDestRanges);
}
-void ScViewFunc::InsertCurrentTime(short nCellFmt, const OUString rUndoStr)
+/** Insert date or time into current cell.
+
+- key date on time cell = current date + time of cell = date+time
formatted cell
+ - unless time cell was empty or 00:00 time = current date = date
formatted cell
+- key date on date+time cell = current date + 00:00 time = date+time
formatted cell
+ - unless date was current date = current date = date formatted cell
+- key date on other cell = current date = date formatted cell
+- key time on date cell = date of cell + current time = date+time
formatted cell
+ - unless date cell was empty = current time = time formatted cell
+- key time on date+time cell = current time = time formatted cell
+ - unless cell was empty = current date+time = date+time formatted
cell
+- key time on other cell = current time = time formatted cell
+ */
+void ScViewFunc::InsertCurrentTime(short nReqFmt, const OUString rUndoStr)
{
ScViewData rViewData = GetViewData();
ScAddress aCurPos = rViewData.GetCurPos();
@@ -248,23 +261,69 @@ void ScViewFunc::InsertCurrentTime(short nCellFmt, const
OUString rUndoStr)
const SvNumberformat* pCurNumFormatEntry =
pFormatter-GetEntry(nCurNumFormat);
const short nCurNumFormatType = (pCurNumFormatEntry ?
(pCurNumFormatEntry-GetType() ~NUMBERFORMAT_DEFINED) :
NUMBERFORMAT_UNDEFINED);
+bool bForceReqFmt = false;
+const double fCell = rDoc.GetValue( aCurPos);
// Combine requested date/time stamp with existing cell time/date, if any.
-switch (nCellFmt)
+switch (nReqFmt)
{
case NUMBERFORMAT_DATE:
-if (nCurNumFormatType == NUMBERFORMAT_TIME)
-nCellFmt = NUMBERFORMAT_DATETIME;
+switch (nCurNumFormatType)
+{
+case NUMBERFORMAT_TIME:
+// An empty cell formatted as time (or 00:00 time) shall
+// not result in the current date with 00:00 time, but only
+// in current date.
+if (fCell != 0.0)
+nReqFmt = NUMBERFORMAT_DATETIME;
+break;
+case NUMBERFORMAT_DATETIME:
+{
+// Force to only date if the existing date+time is the
+// current date. This way inserting current date twice
+// on an existing date+time cell can be used to force
+// date, which
[Libreoffice-commits] core.git: include/comphelper
include/comphelper/sequence.hxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit f340f0454627939f1830826fb5cc53a90e6c62a4
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Aug 20 14:04:43 2014 +0200
Pick a more suitable type for nLength
Change-Id: I6e38b82f08884c4e187e5b3ca2c95a0d4ca8d541
diff --git a/include/comphelper/sequence.hxx b/include/comphelper/sequence.hxx
index 235c4c9..6dd4f9c 100644
--- a/include/comphelper/sequence.hxx
+++ b/include/comphelper/sequence.hxx
@@ -94,11 +94,11 @@ namespace comphelper
templateclass T
void removeElementAt(staruno::SequenceT _rSeq, sal_Int32 _nPos)
{
-sal_uInt32 nLength = _rSeq.getLength();
+sal_Int32 nLength = _rSeq.getLength();
-OSL_ENSURE(0 = _nPos (sal_uInt32)_nPos nLength, invalid index);
+OSL_ENSURE(0 = _nPos _nPos nLength, invalid index);
-for (sal_uInt32 i = (sal_uInt32)_nPos + 1; i nLength; ++i)
+for (sal_Int32 i = _nPos + 1; i nLength; ++i)
{
_rSeq[i-1] = _rSeq[i];
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/charttypes/GL3DBarChart.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1b0baa5799a56432d45cb1ec63d77ab93a3ebf9a Author: Stephan Bergmann sberg...@redhat.com Date: Wed Aug 20 14:16:07 2014 +0200 loplugin:literaltoboolconversion Change-Id: I6fe25eb5619e5e0273e6e2010c948daa547fe46c diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx index fb6e912..01a0ecd 100644 --- a/chart2/source/view/charttypes/GL3DBarChart.cxx +++ b/chart2/source/view/charttypes/GL3DBarChart.cxx @@ -189,7 +189,7 @@ class RenderBenchMarkThread : public RenderThread public: RenderBenchMarkThread(GL3DBarChart * pChart) : RenderThread(pChart) -, mbAutoFlyExecuting(0) +, mbAutoFlyExecuting(false) , mbExecuting(false) , mbNeedFlyBack(false) , mnStep(0) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: config_host.mk.in configure.ac external/apache-commons external/jfreereport RepositoryExternal.mk swext/Extension_wiki-publisher.mk
RepositoryExternal.mk|4 ++-- config_host.mk.in|1 + configure.ac |6 -- external/apache-commons/ExternalPackage_apache_commons_logging.mk|2 +- external/apache-commons/ExternalProject_apache_commons_httpclient.mk |2 +- external/jfreereport/ExternalProject_jfreereport_flow_engine.mk |2 +- external/jfreereport/ExternalProject_jfreereport_liblayout.mk|2 +- swext/Extension_wiki-publisher.mk|2 +- 8 files changed, 12 insertions(+), 9 deletions(-) New commits: commit d8a7f72bab1745cbf122400d81380ed66a6c36fc Author: rbuj robert@gmail.com Date: Mon Aug 18 13:52:32 2014 +0200 Use COMMONS_LOGGING_VERSION vble Change-Id: I0c76ec7e3f9b95166b4005dd1ad5349b3889c3e4 Reviewed-on: https://gerrit.libreoffice.org/10993 Reviewed-by: Thomas Arnhold tho...@arnhold.org Tested-by: Thomas Arnhold tho...@arnhold.org diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 16772512..05e1e05 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -3512,7 +3512,7 @@ else # !SYSTEM_APACHE_COMMONS ifeq ($(ENABLE_JAVA),TRUE) $(eval $(call gb_Helper_register_jars_for_install,OOO,reportbuilder,\ - commons-logging-1.2 \ + commons-logging-$(COMMONS_LOGGING_VERSION) \ )) endif $(eval $(call gb_Helper_register_jars,OXT,\ @@ -3553,7 +3553,7 @@ endef define gb_Jar__use_commons-logging $(call gb_Jar_use_external_project,$(1),apache_commons_logging) -$(call gb_Jar_use_jar,$(1),commons-logging-1.2) +$(call gb_Jar_use_jar,$(1),commons-logging-$(COMMONS_LOGGING_VERSION)) endef define gb_ExternalProject__use_commons-logging $(call gb_ExternalProject_use_external_project,$(1),apache_commons_logging) diff --git a/config_host.mk.in b/config_host.mk.in index f438432..22c8da5 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -64,6 +64,7 @@ export COMMONS_CODEC_JAR=@COMMONS_CODEC_JAR@ export COMMONS_HTTPCLIENT_JAR=@COMMONS_HTTPCLIENT_JAR@ export COMMONS_LANG_JAR=@COMMONS_LANG_JAR@ export COMMONS_LOGGING_JAR=@COMMONS_LOGGING_JAR@ +export COMMONS_LOGGING_VERSION=@COMMONS_LOGGING_VERSION@ export COMPATH=@COMPATH@ export COMPILER_PLUGINS=@COMPILER_PLUGINS@ export COM_GCC_IS_CLANG=@COM_GCC_IS_CLANG@ diff --git a/configure.ac b/configure.ac index f4b7659..bc823c7 100644 --- a/configure.ac +++ b/configure.ac @@ -10865,6 +10865,7 @@ AC_SUBST(LIBSERIALIZER_JAR) # this has to be here because both the Wiki Publisher and the SRB use # commons-logging +COMMONS_LOGGING_VERSION=1.2 if test $ENABLE_MEDIAWIKI = TRUE -o $ENABLE_REPORTBUILDER = TRUE; then AC_MSG_CHECKING([which Apache commons-* libs to use]) if test $with_system_apache_commons = yes; then @@ -10930,8 +10931,8 @@ if test $ENABLE_MEDIAWIKI = TRUE -o $ENABLE_REPORTBUILDER = TRUE; then fi if test $ENABLE_MEDIAWIKI = TRUE -o $ENABLE_REPORTBUILDER = TRUE; then if test -z $COMMONS_LOGGING_JAR; then -AC_CHECK_FILE(/usr/share/java/commons-logging-1.2.jar, - [ COMMONS_LOGGING_JAR=/usr/share/java/commons-logging-1.2.jar ], + AC_CHECK_FILE(/usr/share/java/commons-logging-$(COMMONS_LOGGING_VERSION).jar, + [ COMMONS_LOGGING_JAR=/usr/share/java/commons-logging-$(COMMONS_LOGGING_VERSION).jar ], [ AC_CHECK_FILE(/usr/share/java/commons-logging.jar, [ COMMONS_LOGGING_JAR=/usr/share/java/commons-logging.jar ], @@ -10955,6 +10956,7 @@ AC_SUBST(COMMONS_CODEC_JAR) AC_SUBST(COMMONS_LANG_JAR) AC_SUBST(COMMONS_HTTPCLIENT_JAR) AC_SUBST(COMMONS_LOGGING_JAR) +AC_SUBST(COMMONS_LOGGING_VERSION) # scripting provider for BeanShell? AC_MSG_CHECKING([whether to build support for scripts in BeanShell]) diff --git a/external/apache-commons/ExternalPackage_apache_commons_logging.mk b/external/apache-commons/ExternalPackage_apache_commons_logging.mk index ce72112..2bff13b 100644 --- a/external/apache-commons/ExternalPackage_apache_commons_logging.mk +++ b/external/apache-commons/ExternalPackage_apache_commons_logging.mk @@ -11,6 +11,6 @@ $(eval $(call gb_ExternalPackage_ExternalPackage,apache_commons_logging,apache_c $(eval $(call gb_ExternalPackage_use_external_project,apache_commons_logging,apache_commons_logging)) -$(eval $(call gb_ExternalPackage_add_file,apache_commons_logging,$(LIBO_SHARE_JAVA_FOLDER)/commons-logging-1.2.jar,target/commons-logging-1.2.jar)) +$(eval $(call gb_ExternalPackage_add_file,apache_commons_logging,$(LIBO_SHARE_JAVA_FOLDER)/commons-logging-$(COMMONS_LOGGING_VERSION).jar,target/commons-logging-$(COMMONS_LOGGING_VERSION).jar)) # vim: set noet sw=4 ts=4: diff --git a/external/apache-commons/ExternalProject_apache_commons_httpclient.mk
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 52226, which changed state. Bug 52226 Summary: FILESAVE Images in .docx and .xlsx files show Read-Error, probably corrupted by auto-save[Summary in comment # 31] https://bugs.freedesktop.org/show_bug.cgi?id=52226 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Suggestion for the use of pre-written responses
Hi All, Over the months of doing triaging, i've found that the best means of communicating with bug reporters is to have a set of pre-written responses to suit various common situations like confirming a bug, requesting a sample document, and asking for clear steps. These responses are very handy for the initial comment between me and the bug reporter, but do come in handy at other times as well, like requesting they reset their profile or send in a screencast. These responses have a simple and short format, similar to the below. -- Hello [user's name], Thank you for submitting the bug. I can confirm that the bug is available in 4.2.7, 4.3.2 and master on Linux. -- The primary message that i wanted to get across to the bug reporter is that we are welcoming and appreciate the effort they made in reporting the bug, as reporting a bug on BSA for the first time is a very length procedure. Then a few days ago, I got CCed on the comment from bug 76825 (comment 7) from an unhappy bug reporter whose bug was simply set as a duplicate without a response: -- don't ever bother dropping someone a mail or anything ... (like hi, thanks, we're already on it! - don't ever bother, really) cause we are machines or what ... or cogs in a big machine .) just go the beurocratic way, drop that person some cc :) it took me 15 minutes to report this bug ... i took it seriously, and i meant it ... but i'm sure i'll never do that again -- So i'd like to propose the creation a wiki page of pre-written responses that we can all use. I have created the wiki page at https://wiki.documentfoundation.org/QA/BugTriage/Pre-Written_Responses and will be adding entries to it, though i have very little knowledge of how best to format the page :D. Please add in your own collection of responses if you have. -- Regards, Jay Philips ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44580] share autocorrect replacement table for misc. language subgroups
https://bugs.freedesktop.org/show_bug.cgi?id=44580 --- Comment #24 from tommy27 ba...@quipo.it --- (In reply to comment #23) There are 2 points to distinguish: 1) In the basic process, there can't be any unlocalized file in user/autocorrect. It seems you may have weird result only if you bypass the process by copying an unlocalized file in it. yes, your fix for Bug 79276 had this side effect and allowed me to manually hack the user profile and use and unlocalized autocorrect file inside it. the weird thing is that this work with some languages (Italian, English) and not with others (French, German). I don't understand why... 2) I understand you'd like to edit unlocalized file and I didn't try to implement it. Being able to edit it would mean indeed mean there could be unlocalized files in user/autocorrect (without manually copying). I don't think I'd be able to do it since it means: - to be able to list unlocalized languages as you said, exactly, that would be exactly what I wanted to be implemented when I opened this Bug 44580 - prevent conflicts you described when there are localized and unlocalized files (again as you said) I think it's up to the user to avoid autocorrect conflicts. You can already have conflicts using the acor_UND.dat file but it's your fault if you set discordant autocorrect replacements among different lists. I'm sorry to tell I can't help more on this last point :-( you already did a lot. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: extensions/source extensions/uiconfig extensions/UIConfig_sbibliography.mk
extensions/UIConfig_sbibliography.mk |1
extensions/source/bibliography/bib.hrc| 28 +
extensions/source/bibliography/bibcont.cxx|5
extensions/source/bibliography/bibshortcuthandler.hxx |1
extensions/source/bibliography/bibview.cxx|1
extensions/source/bibliography/general.cxx| 311 +++--
extensions/source/bibliography/general.hxx| 86 +--
extensions/source/bibliography/sections.hrc | 85 ---
extensions/source/bibliography/sections.src | 408 --
extensions/uiconfig/sbibliography/ui/generalpage.ui | 12
10 files changed, 346 insertions(+), 592 deletions(-)
New commits:
commit eba5e5b6b6577cc2d0bbd1ff66eefd0e2024fc4e
Author: Palenik Mihály palenik.mih...@gmail.com
Date: Mon Aug 18 13:03:08 2014 +0200
Convert RID_TP_GENERAL tabpage to .ui
Change-Id: I32300c3d06a8c30d8e75f343cd2af8acef7296ae
Reviewed-on: https://gerrit.libreoffice.org/10989
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/extensions/UIConfig_sbibliography.mk
b/extensions/UIConfig_sbibliography.mk
index 6cd5c4b..58ec842 100644
--- a/extensions/UIConfig_sbibliography.mk
+++ b/extensions/UIConfig_sbibliography.mk
@@ -15,6 +15,7 @@ $(eval $(call
gb_UIConfig_add_menubarfiles,modules/sbibliography,\
$(eval $(call gb_UIConfig_add_uifiles,modules/sbibliography,\
extensions/uiconfig/sbibliography/ui/choosedatasourcedialog \
+ extensions/uiconfig/sbibliography/ui/generalpage \
extensions/uiconfig/sbibliography/ui/mappingdialog \
))
diff --git a/extensions/source/bibliography/bib.hrc
b/extensions/source/bibliography/bib.hrc
index fbcf561..f5370bc 100644
--- a/extensions/source/bibliography/bib.hrc
+++ b/extensions/source/bibliography/bib.hrc
@@ -25,10 +25,6 @@
#define RID_BIB_START RID_EXTENSIONS_START
#endif
-//Dialogs (100)
-#define RID_BIB_DIALOG (RID_BIB_START)
-#define RID_TP_GENERAL (RID_BIB_DIALOG)
-
//Controls(100)
#define RID_BIB_CONTROLS(RID_BIB_START + 100)
#define RID_BIB_TOOLBAR (RID_BIB_CONTROLS+ 1)
@@ -78,6 +74,30 @@
#define ST_CUSTOM3 (RID_BIB_STRING + 34)
#define ST_CUSTOM4 (RID_BIB_STRING + 35)
#define ST_CUSTOM5 (RID_BIB_STRING + 36)
+#define ST_ERROR_PREFIX (RID_BIB_STRING + 37)
+#define ST_TYPE_ARTICLE (RID_BIB_STRING + 38)
+#define ST_TYPE_BOOK(RID_BIB_STRING + 39)
+#define ST_TYPE_BOOKLET (RID_BIB_STRING + 40)
+#define ST_TYPE_CONFERENCE (RID_BIB_STRING + 41)
+#define ST_TYPE_INBOOK (RID_BIB_STRING + 42)
+#define ST_TYPE_INCOLLECTION(RID_BIB_STRING + 43)
+#define ST_TYPE_INPROCEEDINGS (RID_BIB_STRING + 44)
+#define ST_TYPE_JOURNAL (RID_BIB_STRING + 45)
+#define ST_TYPE_MANUAL (RID_BIB_STRING + 46)
+#define ST_TYPE_MASTERSTHESIS (RID_BIB_STRING + 47)
+#define ST_TYPE_MISC(RID_BIB_STRING + 48)
+#define ST_TYPE_PHDTHESIS (RID_BIB_STRING + 49)
+#define ST_TYPE_PROCEEDINGS (RID_BIB_STRING + 50)
+#define ST_TYPE_TECHREPORT (RID_BIB_STRING + 51)
+#define ST_TYPE_UNPUBLISHED (RID_BIB_STRING + 52)
+#define ST_TYPE_EMAIL (RID_BIB_STRING + 53)
+#define ST_TYPE_WWW (RID_BIB_STRING + 54)
+#define ST_TYPE_CUSTOM1 (RID_BIB_STRING + 55)
+#define ST_TYPE_CUSTOM2 (RID_BIB_STRING + 56)
+#define ST_TYPE_CUSTOM3 (RID_BIB_STRING + 57)
+#define ST_TYPE_CUSTOM4 (RID_BIB_STRING + 58)
+#define ST_TYPE_CUSTOM5 (RID_BIB_STRING + 59)
+#define ST_TYPE_TITLE (RID_BIB_STRING + 60)
#endif
diff --git a/extensions/source/bibliography/bibcont.cxx
b/extensions/source/bibliography/bibcont.cxx
index 3dfd6bf..d4460e7 100644
--- a/extensions/source/bibliography/bibcont.cxx
+++ b/extensions/source/bibliography/bibcont.cxx
@@ -65,6 +65,11 @@ BibTabPage::BibTabPage( Window* pParent, const ResId rResId
) : TabPage( pParen
{
}
+BibTabPage::BibTabPage( Window* pParent, const OString rID, const OUString
rUIXMLDescription ) :
+TabPage( pParent, rID, rUIXMLDescription ),
BibShortCutHandler( this )
+{
+}
+
BibTabPage::~BibTabPage()
{
}
diff --git a/extensions/source/bibliography/bibshortcuthandler.hxx
b/extensions/source/bibliography/bibshortcuthandler.hxx
index 8900544..9b862bc 100644
--- a/extensions/source/bibliography/bibshortcuthandler.hxx
+++ b/extensions/source/bibliography/bibshortcuthandler.hxx
@@ -73,6 +73,7 @@ class BibTabPage : public TabPage, public BibShortCutHandler
{
public:
BibTabPage( Window* pParent, const ResId rResId );
+BibTabPage( Window* pParent, const OString
[Libreoffice-commits] core.git: 2 commits - desktop/source desktop/uiconfig extensions/source extensions/uiconfig include/vcl reportdesign/source reportdesign/uiconfig sc/uiconfig sfx2/uiconfig svtool
desktop/source/deployment/gui/dp_gui_updatedialog.hxx |2
desktop/uiconfig/ui/updatedialog.ui |7
extensions/source/bibliography/bib.hrc| 31
extensions/source/bibliography/bibview.cxx|1
extensions/source/bibliography/general.cxx| 496
extensions/source/bibliography/general.hxx| 25
extensions/source/bibliography/sections.src | 126 ---
extensions/uiconfig/sbibliography/ui/generalpage.ui | 697 +-
include/vcl/layout.hxx| 11
reportdesign/source/ui/dlg/CondFormat.cxx |2
reportdesign/uiconfig/dbreport/ui/condformatdialog.ui |5
sc/uiconfig/scalc/ui/retypepassdialog.ui | 19
sc/uiconfig/scalc/ui/sortcriteriapage.ui | 17
sfx2/uiconfig/ui/cmisinfopage.ui | 25
svtools/uiconfig/ui/addresstemplatedialog.ui |5
svx/uiconfig/ui/asianphoneticguidedialog.ui |5
vcl/source/window/builder.cxx |6
vcl/source/window/layout.cxx | 29
18 files changed, 967 insertions(+), 542 deletions(-)
New commits:
commit a6c5f2ba6bca8ad95a3731e2770a1d216c9925a0
Author: Caolán McNamara caol...@redhat.com
Date: Mon Aug 18 14:01:32 2014 +0100
rework RID_TP_GENERAL conversion to make widgets visible, etc.
Change-Id: I93e30198e27631ad4a6865fd202af16094c26a41
diff --git a/extensions/source/bibliography/bib.hrc
b/extensions/source/bibliography/bib.hrc
index f5370bc..96233b1 100644
--- a/extensions/source/bibliography/bib.hrc
+++ b/extensions/source/bibliography/bib.hrc
@@ -43,37 +43,6 @@
#define RID_BIB_STR_FRAME_TITLE (RID_BIB_STRING + 4)
#define RID_MAP_QUESTION(RID_BIB_STRING + 5)
-#define ST_IDENTIFIER (RID_BIB_STRING + 6)
-#define ST_AUTHTYPE (RID_BIB_STRING + 7)
-#define ST_AUTHOR (RID_BIB_STRING + 8)
-#define ST_YEAR (RID_BIB_STRING + 9)
-#define ST_ISBN (RID_BIB_STRING + 10)
-#define ST_MONTH(RID_BIB_STRING + 11)
-#define ST_PUBLISHER(RID_BIB_STRING + 12)
-#define ST_ADDRESS (RID_BIB_STRING + 13)
-#define ST_ANNOTE (RID_BIB_STRING + 14)
-#define ST_BOOKTITLE(RID_BIB_STRING + 15)
-#define ST_CHAPTER (RID_BIB_STRING + 16)
-#define ST_EDITION (RID_BIB_STRING + 17)
-#define ST_EDITOR (RID_BIB_STRING + 18)
-#define ST_HOWPUBLISHED (RID_BIB_STRING + 19)
-#define ST_INSTITUTION (RID_BIB_STRING + 20)
-#define ST_JOURNAL (RID_BIB_STRING + 21)
-#define ST_NOTE (RID_BIB_STRING + 22)
-#define ST_NUMBER (RID_BIB_STRING + 23)
-#define ST_ORGANIZATION (RID_BIB_STRING + 24)
-#define ST_PAGE (RID_BIB_STRING + 25)
-#define ST_SCHOOL (RID_BIB_STRING + 26)
-#define ST_SERIES (RID_BIB_STRING + 27)
-#define ST_TITLE(RID_BIB_STRING + 28)
-#define ST_REPORT (RID_BIB_STRING + 29)
-#define ST_VOLUME (RID_BIB_STRING + 30)
-#define ST_URL (RID_BIB_STRING + 31)
-#define ST_CUSTOM1 (RID_BIB_STRING + 32)
-#define ST_CUSTOM2 (RID_BIB_STRING + 33)
-#define ST_CUSTOM3 (RID_BIB_STRING + 34)
-#define ST_CUSTOM4 (RID_BIB_STRING + 35)
-#define ST_CUSTOM5 (RID_BIB_STRING + 36)
#define ST_ERROR_PREFIX (RID_BIB_STRING + 37)
#define ST_TYPE_ARTICLE (RID_BIB_STRING + 38)
#define ST_TYPE_BOOK(RID_BIB_STRING + 39)
diff --git a/extensions/source/bibliography/bibview.cxx
b/extensions/source/bibliography/bibview.cxx
index 341c3a9..1ecbe3d 100644
--- a/extensions/source/bibliography/bibview.cxx
+++ b/extensions/source/bibliography/bibview.cxx
@@ -113,6 +113,7 @@ namespace bib
}
m_xGeneralPage = m_pGeneralPage = new BibGeneralPage( this, m_pDatMan
);
+m_pGeneralPage-Show();
Resize();
diff --git a/extensions/source/bibliography/general.cxx
b/extensions/source/bibliography/general.cxx
index 3975bcb..d139d61 100644
--- a/extensions/source/bibliography/general.cxx
+++ b/extensions/source/bibliography/general.cxx
@@ -27,6 +27,7 @@
#include com/sun/star/awt/XWindow.hpp
#include toolkit/helper/vclunohelper.hxx
#include cppuhelper/implbase1.hxx
+#include vcl/builder.hxx
#include vcl/settings.hxx
#include general.hxx
#include bibresid.hxx
@@ -52,16 +53,6 @@ using namespace ::com::sun::star::form;
using namespace ::com::sun::star::sdb;
using namespace ::rtl;
-#define DISTANCE_CONTROL_TO_FIXEDTEXT 5
-
-static ::Point lcl_MovePoint(const FixedText rFixedText)
-{
-
[Libreoffice-commits] core.git: uui/AllLangResTarget_uui.mk uui/source uui/uiconfig uui/UIConfig_uui.mk
uui/AllLangResTarget_uui.mk|1
uui/UIConfig_uui.mk|2
uui/source/fltdlg.cxx | 35 -
uui/source/fltdlg.hrc | 32
uui/source/fltdlg.hxx | 10 --
uui/source/fltdlg.src | 75
uui/source/iahndl-filter.cxx |4 -
uui/source/ids.hrc |2
uui/source/nameclashdlg.cxx| 35 -
uui/source/nameclashdlg.hrc| 32
uui/source/nameclashdlg.hxx| 12 +--
uui/source/nameclashdlg.src| 66 -
uui/uiconfig/ui/filterselect.ui| 129 ++
uui/uiconfig/ui/simplenameclash.ui | 138 +
14 files changed, 311 insertions(+), 262 deletions(-)
New commits:
commit 96d7f6171a0b887aa89e32cee279d97c876b1605
Author: Szymon KÅos eszka...@gmail.com
Date: Wed Aug 20 12:29:37 2014 +0200
DLG_FILTER_SELECT and DLG_SIMPLE_NAME_CLASH conversion to .ui
Change-Id: I2a87330d73e2735a764296185f165a29f05b517c
Reviewed-on: https://gerrit.libreoffice.org/11040
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/uui/AllLangResTarget_uui.mk b/uui/AllLangResTarget_uui.mk
index 89cfad0..2cd3657 100644
--- a/uui/AllLangResTarget_uui.mk
+++ b/uui/AllLangResTarget_uui.mk
@@ -23,7 +23,6 @@ $(eval $(call gb_SrsTarget_set_include,uui/res,\
$(eval $(call gb_SrsTarget_add_files,uui/res,\
uui/source/alreadyopen.src \
uui/source/filechanged.src \
- uui/source/fltdlg.src \
uui/source/ids.src \
uui/source/lockfailed.src \
uui/source/nameclashdlg.src \
diff --git a/uui/UIConfig_uui.mk b/uui/UIConfig_uui.mk
index 076969b..41dc9e5 100644
--- a/uui/UIConfig_uui.mk
+++ b/uui/UIConfig_uui.mk
@@ -10,11 +10,13 @@
$(eval $(call gb_UIConfig_UIConfig,uui))
$(eval $(call gb_UIConfig_add_uifiles,uui,\
+ uui/uiconfig/ui/filterselect \
uui/uiconfig/ui/logindialog \
uui/uiconfig/ui/macrowarnmedium \
uui/uiconfig/ui/masterpassworddlg \
uui/uiconfig/ui/password \
uui/uiconfig/ui/setmasterpassworddlg \
+ uui/uiconfig/ui/simplenameclash \
uui/uiconfig/ui/sslwarndialog \
uui/uiconfig/ui/unknownauthdialog \
))
diff --git a/uui/source/fltdlg.cxx b/uui/source/fltdlg.cxx
index 1fae826..1d045fa 100644
--- a/uui/source/fltdlg.cxx
+++ b/uui/source/fltdlg.cxx
@@ -21,8 +21,6 @@
#include ids.hrc
-#include fltdlg.hrc
-
#include com/sun/star/util/XStringWidth.hpp
#include cppuhelper/implbase1.hxx
#include unotools/localfilehelper.hxx
@@ -45,20 +43,19 @@ namespace uui
@seealsomethod SetURL()
@param pParentWindow , parent window for dialog
-@param pResMgr, resource manager
@threadsafe no
*//*-*/
-FilterDialog::FilterDialog( Window* pParentWindow ,
-ResMgr* pResMgr )
-: ModalDialog (pParentWindow, ResId( DLG_FILTER_SELECT, *pResMgr ) )
-, m_ftURL (this, ResId( FT_URL, *pResMgr))
-, m_lbFilters (this, ResId( LB_FILTERS, *pResMgr))
-, m_btnOK (this, ResId( BTN_OK, *pResMgr))
-, m_btnCancel (this, ResId( BTN_CANCEL, *pResMgr))
-, m_btnHelp(this, ResId( BTN_HELP, *pResMgr))
+FilterDialog::FilterDialog( Window* pParentWindow )
+: ModalDialog (pParentWindow, FilterSelectDialog,
uui/ui/filterselect.ui )
, m_pFilterNames(NULL)
{
-FreeResource();
+get(m_pFtURL, url);
+get(m_pLbFilters, filters);
+m_pFtURL-GetOutputSizePixel();
+Size aSize(pParentWindow-LogicToPixel(Size(182, 175), MAP_APPFONT));
+m_pLbFilters-set_height_request(aSize.Height());
+m_pLbFilters-set_width_request(aSize.Width());
+m_pFtURL-SetSizePixel(Size(aSize.Width(),
m_pFtURL-GetOptimalSize().Height()));
}
/*-
@@ -70,7 +67,7 @@ FilterDialog::FilterDialog( Window* pParentWindow ,
void FilterDialog::SetURL( const OUString sURL )
{
// convert it and use given pure string as fallback if conversion failed
-m_ftURL.SetText( impl_buildUIFileName(sURL) );
+m_pFtURL-SetText( impl_buildUIFileName(sURL) );
}
/*-
@@ -93,14 +90,14 @@ void FilterDialog::SetURL( const OUString sURL )
void FilterDialog::ChangeFilters( const FilterNameList* pFilterNames )
{
m_pFilterNames = pFilterNames;
-m_lbFilters.Clear();
+m_pLbFilters-Clear();
if( m_pFilterNames != NULL )
{
for( FilterNameListPtr pItem = m_pFilterNames-begin();
pItem != m_pFilterNames-end() ;
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/source
sw/source/core/crsr/annotationmark.cxx |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit 087c897d3da7a81b63fc79442127eb880d5c3155
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 10:04:32 2014 +0100
fix crash on loading ooo83574-1.doc
Change-Id: Ia959dde8bac2d663cf1a5bec0358ee89dcaf42ed
(cherry picked from commit 17ccc09ec27bde00e5ed7a9fe6055a991992b0ed)
Reviewed-on: https://gerrit.libreoffice.org/11038
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/sw/source/core/crsr/annotationmark.cxx
b/sw/source/core/crsr/annotationmark.cxx
index 95faaa5..bee1ed9 100644
--- a/sw/source/core/crsr/annotationmark.cxx
+++ b/sw/source/core/crsr/annotationmark.cxx
@@ -49,9 +49,11 @@ namespace sw { namespace mark
void AnnotationMark::InitDoc(SwDoc* const io_pDoc)
{
-SwTxtFld* pTxtFld =
-GetMarkEnd().nNode.GetNode().GetTxtNode()-GetFldTxtAttrAt(
-GetMarkEnd().nContent.GetIndex()-1, true );
+SwTxtNode *pTxtNode = GetMarkEnd().nNode.GetNode().GetTxtNode();
+
+SwTxtFld* pTxtFld = pTxtNode ?
+pTxtNode-GetFldTxtAttrAt(
+GetMarkEnd().nContent.GetIndex()-1, true ) : NULL;
OSL_ENSURE( pTxtFld != NULL, AnnotationMark::InitDoc(..) - missing
text attribute for annotation field! );
if ( pTxtFld != NULL )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: helpers/help_hid.lst source/text
helpers/help_hid.lst |2 -- source/text/shared/01/0225.xhp |2 +- 2 files changed, 1 insertion(+), 3 deletions(-) New commits: commit 5ca651f48f04a382b5e915ab9ebb330a28274822 Author: Caolán McNamara caol...@redhat.com Date: Wed Aug 20 14:05:49 2014 +0100 update helpids for bibliography tabpage .ui conversion Change-Id: I27ac3278072b03dccc6419f53e6e27f5434434f3 diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst index f88daf1..c94bb50 100644 --- a/helpers/help_hid.lst +++ b/helpers/help_hid.lst @@ -828,8 +828,6 @@ HID_BIB_BASE,52769, HID_BIB_BOOKTITLE_POS,34780, HID_BIB_CHANGESOURCE,34769, HID_BIB_CHAPTER_POS,34781, -HID_BIB_CONTROL_PAGE,34807, -HID_BIB_CONTROL_PARENT,34808, HID_BIB_CUSTOM1_POS,34800, HID_BIB_CUSTOM2_POS,34801, HID_BIB_CUSTOM3_POS,34802, diff --git a/source/text/shared/01/0225.xhp b/source/text/shared/01/0225.xhp index a0cf696..0425a0d 100644 --- a/source/text/shared/01/0225.xhp +++ b/source/text/shared/01/0225.xhp @@ -29,7 +29,7 @@ body section id=litdat bookmark xml-lang=en-US branch=hid/.uno:BibliographyComponent id=bm_id1785233 localize=false/ -bookmark xml-lang=en-US branch=hid/.uno:BibliographyComponent id=bm_id3150756 localize=false/ +bookmark xml-lang=en-US branch=hid/modules/sbibliography/ui/generalpage/GeneralPage id=bm_id3150756 localize=false/ bookmark xml-lang=en-US branch=hid/EXTENSIONS_HID_BIB_DB_TBX id=bm_id3155354 localize=false/ paragraph xml-lang=en-US id=hd_id3150999 role=heading level=1 l10n=U oldref=1link href=text/shared/01/0225.xhp name=Bibliography DatabaseBibliography Database/link/paragraph /section ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a93ef22ada8762dbcaf90751b69244f93afaad03 Author: Caolán McNamara caol...@redhat.com Date: Wed Aug 20 14:05:49 2014 +0100 Updated core Project: help 5ca651f48f04a382b5e915ab9ebb330a28274822 diff --git a/helpcontent2 b/helpcontent2 index 7c3b223..5ca651f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 7c3b223b9dece4def80895f1fe50b4fc1c11d0b6 +Subproject commit 5ca651f48f04a382b5e915ab9ebb330a28274822 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] Suggestion for the use of pre-written responses
Hi, On Wed, Aug 20, 2014 at 04:35:52PM +0400, Jay Philips wrote: So i'd like to propose the creation a wiki page of pre-written responses that we can all use. I have created the wiki page at https://wiki.documentfoundation.org/QA/BugTriage/Pre-Written_Responses and will be adding entries to it, though i have very little knowledge of how best to format the page :D. Please add in your own collection of responses if you have. that is a great idea! Also we might later consider expending it to having them easily selectable from a pulldown etc. (either with e.g. greasemonkey or own-bugzilla), because as important as this is, I personally guess I will not look for the wikipage everytime for a drive-by confirm. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source
sw/inc/format.hxx |6 +++-
sw/source/core/attr/format.cxx | 40 +---
sw/source/core/docnode/ndtbl1.cxx | 12 -
sw/source/core/frmedt/fetab.cxx |2 -
sw/source/core/layout/atrfrm.cxx| 17 -
sw/source/core/layout/pagedesc.cxx |2 -
sw/source/core/layout/paintfrm.cxx |6 ++--
sw/source/core/layout/tabfrm.cxx|3 +-
sw/source/core/layout/wsfrm.cxx |9 ---
sw/source/core/unocore/unotbl.cxx |2 -
sw/source/filter/html/css1atr.cxx | 10
sw/source/filter/html/htmlcss1.cxx |4 +--
sw/source/filter/html/htmlflywriter.cxx |6 ++--
sw/source/filter/html/htmlgrin.cxx |2 -
sw/source/filter/html/htmltabw.cxx | 14 +--
sw/source/filter/html/swcss1.hxx|2 -
sw/source/filter/ww8/docxexport.cxx | 21
sw/source/filter/ww8/docxexport.hxx |2 -
sw/source/filter/ww8/wrtw8esh.cxx |4 +--
sw/source/ui/dialog/uiregionsw.cxx |5 ++--
sw/source/uibase/docvw/romenu.cxx | 21
sw/source/uibase/docvw/romenu.hxx |6 ++--
22 files changed, 116 insertions(+), 80 deletions(-)
New commits:
commit 9acd707d738b99072cb3d7323e94ef96c1d64be5
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 13:56:35 2014 +0100
fix crashing on exit in static SvxBrushItem dtor
site of second ctor
Change-Id: Ic319bd36f207a0f1939482a7b4c729b519bb5ce1
diff --git a/sw/inc/format.hxx b/sw/inc/format.hxx
index 8c3e69e..9a52566 100644
--- a/sw/inc/format.hxx
+++ b/sw/inc/format.hxx
@@ -98,6 +98,8 @@ public:
//inline
SfxItemState GetItemState( sal_uInt16 nWhich, bool bSrchInParent = true,
const SfxPoolItem **ppItem = 0 ) const;
+SfxItemState GetBackgroundState(SvxBrushItem rItem,
+bool bSrchInParent = true) const;
virtual bool SetFmtAttr( const SfxPoolItem rAttr );
virtual bool SetFmtAttr( const SfxItemSet rSet );
virtual bool ResetFmtAttr( sal_uInt16 nWhich1, sal_uInt16 nWhich2 = 0 );
diff --git a/sw/source/core/attr/format.cxx b/sw/source/core/attr/format.cxx
index 59ea2f3..180b19e 100644
--- a/sw/source/core/attr/format.cxx
+++ b/sw/source/core/attr/format.cxx
@@ -409,13 +409,12 @@ const SfxPoolItem SwFmt::GetFmtAttr( sal_uInt16 nWhich,
bool bInParents ) const
return aSet.Get( nWhich, bInParents );
}
-
SfxItemState SwFmt::GetItemState( sal_uInt16 nWhich, bool bSrchInParent, const
SfxPoolItem **ppItem ) const
{
if(RES_BACKGROUND == nWhich (RES_FLYFRMFMT == Which() || RES_FRMFMT ==
Which()))
{
// FALLBACKBREAKHERE should not be used; instead use
[XATTR_FILL_FIRST .. XATTR_FILL_LAST]
-SAL_INFO(sw.core, Do no longer use SvxBrushItem, instead use
[XATTR_FILL_FIRST .. XATTR_FILL_LAST] FillAttributes (simple fallback is in
place and used));
+SAL_INFO(sw.core, Do no longer use SvxBrushItem, instead use
[XATTR_FILL_FIRST .. XATTR_FILL_LAST] FillAttributes or
SwFmt::GetBackgroundStat (simple fallback is in place and used));
const drawinglayer::attribute::SdrAllFillAttributesHelperPtr aFill =
getSdrAllFillAttributesHelper();
// check if the new fill attributes are used
@@ -424,6 +423,7 @@ SfxItemState SwFmt::GetItemState( sal_uInt16 nWhich, bool
bSrchInParent, const S
// if yes, fill the local SvxBrushItem using the new fill
attributes
// as good as possible to have an instance for the pointer to point
// to and return as state that it is set
+
static SvxBrushItem aSvxBrushItem(RES_BACKGROUND);
aSvxBrushItem = getSvxBrushItemFromSourceSet(aSet, RES_BACKGROUND,
bSrchInParent);
@@ -444,6 +444,33 @@ SfxItemState SwFmt::GetItemState( sal_uInt16 nWhich, bool
bSrchInParent, const S
return aSet.GetItemState( nWhich, bSrchInParent, ppItem );
}
+SfxItemState SwFmt::GetBackgroundState(SvxBrushItem rItem, bool
bSrchInParent) const
+{
+if (RES_FLYFRMFMT == Which() || RES_FRMFMT == Which())
+{
+// FALLBACKBREAKHERE should not be used; instead use
[XATTR_FILL_FIRST .. XATTR_FILL_LAST]
+const drawinglayer::attribute::SdrAllFillAttributesHelperPtr aFill =
getSdrAllFillAttributesHelper();
+
+// check if the new fill attributes are used
+if(aFill.get() aFill-isUsed())
+{
+// if yes, fill the local SvxBrushItem using the new fill
attributes
+// as good as possible to have an instance for the pointer to point
+// to and return as state that it is set
+rItem = getSvxBrushItemFromSourceSet(aSet, RES_BACKGROUND,
bSrchInParent);
+return SFX_ITEM_SET;
+}
+
+// if not return SFX_ITEM_DEFAULT to signal that the item is not set
+return SFX_ITEM_DEFAULT;
+
[Libreoffice-commits] core.git: extensions/inc
extensions/inc/bibliography.hrc |1 - 1 file changed, 1 deletion(-) New commits: commit f78e647a07ca2518d8bf12bd4bffaca40a28836b Author: Caolán McNamara caol...@redhat.com Date: Wed Aug 20 14:06:35 2014 +0100 drop unused helpid Change-Id: Iba89e712dda4795a045c7cc346ed1c100e1cbfbc diff --git a/extensions/inc/bibliography.hrc b/extensions/inc/bibliography.hrc index 480fbdc..ca646c3 100644 --- a/extensions/inc/bibliography.hrc +++ b/extensions/inc/bibliography.hrc @@ -57,7 +57,6 @@ #define HID_BIB_CUSTOM4_POS EXTENSIONS_HID_BIB_CUSTOM4_POS #define HID_BIB_CUSTOM5_POS EXTENSIONS_HID_BIB_CUSTOM5_POS #define HID_BIB_DB_TBX EXTENSIONS_HID_BIB_DB_TBX -#define HID_BIB_CONTROL_PAGE EXTENSIONS_HID_BIB_CONTROL_PAGE #define HID_BIB_CONTROL_PARENT EXTENSIONS_HID_BIB_CONTROL_PARENT #define UID_BIB_FRAME_WINDOW EXTENSIONS_UID_BIB_FRAME_WINDOW #define HID_BIB_DB_GRIDCTRL EXTENSIONS_HID_BIB_DB_GRIDCTRL ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 83046bfcdd1b49da01f6310a05471e816391645e Author: David Tardon dtar...@redhat.com Date: Wed Aug 20 15:12:45 2014 +0200 Updated core Project: help 9a8ca9edc790d35cafbb1b7eb1b0465b806e428f diff --git a/helpcontent2 b/helpcontent2 index 5ca651f..9a8ca9e 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 5ca651f48f04a382b5e915ab9ebb330a28274822 +Subproject commit 9a8ca9edc790d35cafbb1b7eb1b0465b806e428f ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: helpers/help_hid.lst source/text
helpers/help_hid.lst |2 -- source/text/shared/01/01020103.xhp |2 +- 2 files changed, 1 insertion(+), 3 deletions(-) New commits: commit 9a8ca9edc790d35cafbb1b7eb1b0465b806e428f Author: David Tardon dtar...@redhat.com Date: Wed Aug 20 15:12:45 2014 +0200 update help ids for Filter Selection dlg Change-Id: I898c8844c7d5309d4d41c09214a6b98108762e9d diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst index c94bb50..0542f80 100644 --- a/helpers/help_hid.lst +++ b/helpers/help_hid.lst @@ -1271,7 +1271,6 @@ HID_DLG_ADABAS_TRANSACTIONLOG,37282, HID_DLG_ADABAS_TRANSACTIONLOG_SIZE,37287, HID_DLG_ADABAS_USR,37276, HID_DLG_DATABASE_WIZARD,39148, -HID_DLG_FILTER_SELECT,35842, HID_DLG_FLDEDT_ADDRESS,53061, HID_DLG_FLDEDT_NEXT,53059, HID_DLG_FLDEDT_PREV,53060, @@ -5669,7 +5668,6 @@ uui_Edit_DLG_UUI_LOGIN_ED_LOGIN_PASSWORD,1311344669, uui_Edit_DLG_UUI_LOGIN_ED_LOGIN_PATH,1311344662, uui_Edit_DLG_UUI_LOGIN_ED_LOGIN_USERNAME,1311344666, uui_Edit_DLG_UUI_MASTERPASSWORD_ED_MASTERPASSWORD,1311508501, -uui_ListBox_DLG_FILTER_SELECT_LB_FILTERS,1311477279, uui_PushButton_DLG_COOKIES_BTN_COOKIES_CANCEL,1311363614, uui_PushButton_DLG_COOKIES_BTN_COOKIES_OK,1311363615, uui_PushButton_DLG_UUI_LOGIN_BTN_LOGIN_PATH,1311347224, diff --git a/source/text/shared/01/01020103.xhp b/source/text/shared/01/01020103.xhp index b0f340a..bd2afef 100644 --- a/source/text/shared/01/01020103.xhp +++ b/source/text/shared/01/01020103.xhp @@ -37,7 +37,7 @@ embed href=text/shared/00/0404.xhp#filterauswahl/ /section !-- removed HID SFX2:LISTBOX:DLG_FILTER_SELECT:LB_DLG_LISTBOX -- -bookmark xml-lang=en-US branch=hid/uui:ListBox:DLG_FILTER_SELECT:LB_FILTERS id=bm_id1646778 localize=false/ +bookmark xml-lang=en-US branch=hid/uui/ui/filterselect/filters id=bm_id1646778 localize=false/ paragraph role=heading id=hd_id3151100 xml-lang=en-US level=2 l10n=U oldref=4Filter list/paragraph paragraph role=paragraph id=par_id3159201 xml-lang=en-US l10n=U oldref=5ahelp hid=SFX2:LISTBOX:DLG_FILTER_SELECT:LB_DLG_LISTBOXSelect the import filter for the file that you want to open./ahelp/paragraph paragraph role=paragraph id=par_id3152918 xml-lang=en-US l10n=U oldref=6If $[officename] does not recognize the file type of the document that your want to open, try any of the following:/paragraph ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/reffact.cxx | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
New commits:
commit 893d5f9973e75a61f7d21ac146ca329627a9c440
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Aug 20 15:44:59 2014 +0200
Clean up line splicing and indentation
Change-Id: I2b9725052aeaeebef84ec9aedba639f6dda537ff
diff --git a/sc/source/ui/view/reffact.cxx b/sc/source/ui/view/reffact.cxx
index 6d2bca2..ff4b878 100644
--- a/sc/source/ui/view/reffact.cxx
+++ b/sc/source/ui/view/reffact.cxx
@@ -278,24 +278,24 @@ namespace
}
}
-ScValidityRefChildWin::ScValidityRefChildWin( Window* pParentP,
\
- sal_uInt16 nId,
\
- SfxBindings* p,
\
- SfxChildWinInfo* /*pInfo*/ )
\
+ScValidityRefChildWin::ScValidityRefChildWin( Window* pParentP,
+ sal_uInt16 nId,
+ SfxBindings* p,
+ SfxChildWinInfo* /*pInfo*/ )
: SfxChildWindow(pParentP, nId),
m_bVisibleLock( false ),
m_bFreeWindowLock( false ),
m_pSavedWndParent( NULL )
{
-SetWantsFocus( false );\
-ScTabViewShell* pViewShell =\
-NULL != ( pWindow = ScValidationDlg::Find1AliveObject( pParentP )
) ? static_castScValidationDlg*(pWindow)-GetTabViewShell() :
-lcl_GetTabViewShell( p );
-if (!pViewShell)
-pViewShell = PTR_CAST( ScTabViewShell, SfxViewShell::Current() );
-OSL_ENSURE( pViewShell, missing view shell :-( ); \
-if (pViewShell !pWindow)
\
-pViewShell-GetViewFrame()-SetChildWindow( nId, false );
\
+SetWantsFocus( false );
+ScTabViewShell* pViewShell =
+NULL != ( pWindow = ScValidationDlg::Find1AliveObject( pParentP ) ) ?
static_castScValidationDlg*(pWindow)-GetTabViewShell() :
+lcl_GetTabViewShell( p );
+if (!pViewShell)
+pViewShell = PTR_CAST( ScTabViewShell, SfxViewShell::Current() );
+OSL_ENSURE( pViewShell, missing view shell :-( );
+if (pViewShell !pWindow)
+pViewShell-GetViewFrame()-SetChildWindow( nId, false );
if( pWindow ) m_pSavedWndParent = pWindow-GetParent();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 --- Comment #210 from David genericinet+libreoffice@gmail.com --- Adding bug 67379. Cursor positioning in a document where frames are used has been broken for a very long time and is very annoying. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: extensions/source
extensions/source/bibliography/toolbar.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit 71804294c79136ef43a8f91b5c961e266d32187a Author: Caolán McNamara caol...@redhat.com Date: Wed Aug 20 14:55:08 2014 +0100 Resolves: fdo#79227 labels are truncated Change-Id: I9d5cd9491325aab6c844c889bf4db6baab2e75c8 diff --git a/extensions/source/bibliography/toolbar.cxx b/extensions/source/bibliography/toolbar.cxx index d08505b..965700a 100644 --- a/extensions/source/bibliography/toolbar.cxx +++ b/extensions/source/bibliography/toolbar.cxx @@ -216,15 +216,13 @@ BibToolBar::BibToolBar(Window* pParent, Link aLink, WinBits nStyle): aEdQuery.Show(); OUString aStr=GetItemText(TBC_FT_SOURCE); -Rectangle aRect=GetItemRect(TBC_FT_SOURCE); aFtSource.SetText(aStr); -aFtSource.SetSizePixel(aRect.GetSize()); +aFtSource.SetSizePixel(aFtSource.get_preferred_size()); aFtSource.SetBackground(Wallpaper( COL_TRANSPARENT )); aStr=GetItemText(TBC_FT_QUERY); -aRect=GetItemRect(TBC_FT_QUERY); aFtQuery.SetText(aStr); -aFtQuery.SetSizePixel(aRect.GetSize()); +aFtQuery.SetSizePixel(aFtQuery.get_preferred_size()); aFtQuery.SetBackground(Wallpaper( COL_TRANSPARENT )); SetItemWindow(TBC_FT_SOURCE,aFtSource); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: canvas/source cppcanvas/source drawinglayer/source editeng/source include/vcl sc/source starmath/source svx/source sw/source vcl/source
canvas/source/cairo/cairo_canvashelper_text.cxx |5 --
canvas/source/cairo/cairo_textlayout.cxx| 10 +---
canvas/source/vcl/canvashelper.cxx |5 --
canvas/source/vcl/textlayout.cxx| 10 +---
cppcanvas/source/mtfrenderer/implrenderer.cxx | 22 ++--
drawinglayer/source/primitive2d/metafileprimitive2d.cxx |8 +--
drawinglayer/source/processor2d/vclprocessor2d.cxx |4 -
editeng/source/editeng/impedit3.cxx |2
editeng/source/outliner/outliner.cxx|2
include/vcl/metaact.hxx |7 +-
include/vcl/outdev.hxx | 17 +-
include/vcl/outdevstate.hxx | 40 +++-
include/vcl/pdfwriter.hxx |3 -
sc/source/ui/docshell/docsh4.cxx|2
starmath/source/ElementsDockingWindow.cxx |2
starmath/source/document.cxx|8 +--
svx/source/sdr/contact/objectcontactofpageview.cxx |2
sw/source/core/inc/txtfrm.hxx |2
sw/source/core/text/itradj.cxx |2
sw/source/core/text/txtfrm.cxx |2
sw/source/core/txtnode/fntcache.cxx |2
sw/source/core/txtnode/fntcap.cxx |2
vcl/source/app/help.cxx |2
vcl/source/control/ctrl.cxx |2
vcl/source/control/edit.cxx |2
vcl/source/edit/texteng.cxx |2
vcl/source/filter/wmf/emfwr.cxx |8 +--
vcl/source/filter/wmf/enhwmf.cxx|2
vcl/source/filter/wmf/winmtf.cxx|2
vcl/source/filter/wmf/winmtf.hxx|9 ++-
vcl/source/filter/wmf/winwmf.cxx|2
vcl/source/filter/wmf/wmfwr.cxx |8 +--
vcl/source/gdi/gdimtf.cxx |4 -
vcl/source/gdi/metaact.cxx |8 ++-
vcl/source/gdi/pdfwriter.cxx|4 -
vcl/source/gdi/pdfwriter_impl.cxx |4 -
vcl/source/gdi/pdfwriter_impl.hxx |6 +-
vcl/source/gdi/textlayout.cxx |2
vcl/source/outdev/outdevstate.cxx |2
vcl/source/outdev/text.cxx | 12 ++--
vcl/source/outdev/textline.cxx |2
41 files changed, 130 insertions(+), 112 deletions(-)
New commits:
commit 794d5ac4ac0b1dcaac289772ce096a4295d4e15d
Author: Noel Grandin n...@peralex.com
Date: Fri Aug 1 12:34:33 2014 +0200
vcl: use enum for complex text layout constants
Since these constants are bitfield flags, we define some methods to make
working with them reasonably type safe.
Move the definitions to outdevstate.hxx, since we need the values there,
and that appears to be the root most header file.
Also dump TEXT_LAYOUT_BIDI_LTR constant, since it means the same thing
as TEXT_LAYOUT_DEFAULT (ie. 0), and leaving it in causes people to write
weird code thinking that it's a real flag.
Change-Id: Iddab86cd6c78181ceb8caa48e77e1f5a8e526343
Reviewed-on: https://gerrit.libreoffice.org/10676
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/canvas/source/cairo/cairo_canvashelper_text.cxx
b/canvas/source/cairo/cairo_canvashelper_text.cxx
index d65f2de..f95d71a 100644
--- a/canvas/source/cairo/cairo_canvashelper_text.cxx
+++ b/canvas/source/cairo/cairo_canvashelper_text.cxx
@@ -307,14 +307,13 @@ namespace cairocanvas
return uno::Reference rendering::XCachedPrimitive (NULL); //
no output necessary
// change text direction and layout mode
-sal_uLong nLayoutMode(0);
+ComplexTextLayoutMode nLayoutMode(TEXT_LAYOUT_DEFAULT);
switch( textDirection )
{
case rendering::TextDirection::WEAK_LEFT_TO_RIGHT:
-nLayoutMode |= TEXT_LAYOUT_BIDI_LTR;
// FALLTHROUGH intended
case rendering::TextDirection::STRONG_LEFT_TO_RIGHT:
-nLayoutMode |= TEXT_LAYOUT_BIDI_LTR |
TEXT_LAYOUT_BIDI_STRONG;
+nLayoutMode |= TEXT_LAYOUT_BIDI_STRONG;
nLayoutMode |= TEXT_LAYOUT_TEXTORIGIN_LEFT;
break;
diff --git a/canvas/source/cairo/cairo_textlayout.cxx
b/canvas/source/cairo/cairo_textlayout.cxx
index db9a21c..f01e75a 100644
--- a/canvas/source/cairo/cairo_textlayout.cxx
+++ b/canvas/source/cairo/cairo_textlayout.cxx
@@ -72,17
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/appdde.cxx |2 --
sfx2/source/inc/appdata.hxx |4 +++-
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 5e531e121fae61675fb358e814d49b70cfab14cf
Author: Takeshi Abe t...@fixedpoint.jp
Date: Wed Aug 20 21:59:48 2014 +0900
fdo#75757: remove inheritance to std::vector
Change-Id: I621286f0b64ff464bc29310ba79e416abc5791d8
Reviewed-on: https://gerrit.libreoffice.org/11042
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/sfx2/source/appl/appdde.cxx b/sfx2/source/appl/appdde.cxx
index 9d3d634..9de5f08 100644
--- a/sfx2/source/appl/appdde.cxx
+++ b/sfx2/source/appl/appdde.cxx
@@ -229,8 +229,6 @@ public:
};
-class SfxDdeDocTopics_Impl : public std::vectorSfxDdeDocTopic_Impl* {};
-
#if defined( WNT )
namespace {
diff --git a/sfx2/source/inc/appdata.hxx b/sfx2/source/inc/appdata.hxx
index 19fd3ed..ead6ea5 100644
--- a/sfx2/source/inc/appdata.hxx
+++ b/sfx2/source/inc/appdata.hxx
@@ -33,7 +33,7 @@
class SfxApplication;
class SfxProgress;
-class SfxDdeDocTopics_Impl;
+class SfxDdeDocTopic_Impl;
class DdeService;
class SfxItemPool;
class SfxFilterMatcher;
@@ -63,6 +63,8 @@ namespace sfx2 {
typedef Link* LinkPtr;
+typedef std::vectorSfxDdeDocTopic_Impl* SfxDdeDocTopics_Impl;
+
class SfxAppData_Impl
{
public:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - extensions/source
extensions/source/bibliography/toolbar.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit 3b6748a4002f4b61ae477da7a84b4a0feccdef12 Author: Caolán McNamara caol...@redhat.com Date: Wed Aug 20 14:55:08 2014 +0100 Resolves: fdo#79227 labels are truncated Change-Id: I9d5cd9491325aab6c844c889bf4db6baab2e75c8 (cherry picked from commit 71804294c79136ef43a8f91b5c961e266d32187a) Reviewed-on: https://gerrit.libreoffice.org/11043 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/extensions/source/bibliography/toolbar.cxx b/extensions/source/bibliography/toolbar.cxx index 3db37df..e9d2e7b 100644 --- a/extensions/source/bibliography/toolbar.cxx +++ b/extensions/source/bibliography/toolbar.cxx @@ -220,15 +220,13 @@ BibToolBar::BibToolBar(Window* pParent, Link aLink, WinBits nStyle): aEdQuery.Show(); OUString aStr=GetItemText(TBC_FT_SOURCE); -Rectangle aRect=GetItemRect(TBC_FT_SOURCE); aFtSource.SetText(aStr); -aFtSource.SetSizePixel(aRect.GetSize()); +aFtSource.SetSizePixel(aFtSource.get_preferred_size()); aFtSource.SetBackground(Wallpaper( COL_TRANSPARENT )); aStr=GetItemText(TBC_FT_QUERY); -aRect=GetItemRect(TBC_FT_QUERY); aFtQuery.SetText(aStr); -aFtQuery.SetSizePixel(aRect.GetSize()); +aFtQuery.SetSizePixel(aFtQuery.get_preferred_size()); aFtQuery.SetBackground(Wallpaper( COL_TRANSPARENT )); SetItemWindow(TBC_FT_SOURCE,aFtSource); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: wizards/com
wizards/com/sun/star/wizards/common/NumericalHelper.java |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit e5070e0cc2bc7c19668846d3faaa1b97e3440f06
Author: rbuj robert@gmail.com
Date: Wed Aug 20 12:34:07 2014 +0200
wizards: Number parsing
Change-Id: If81db8cf10556dbb79458258a70760e3f12a5524
Reviewed-on: https://gerrit.libreoffice.org/11041
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/wizards/com/sun/star/wizards/common/NumericalHelper.java
b/wizards/com/sun/star/wizards/common/NumericalHelper.java
index dd1c731..f2c6e76 100644
--- a/wizards/com/sun/star/wizards/common/NumericalHelper.java
+++ b/wizards/com/sun/star/wizards/common/NumericalHelper.java
@@ -97,8 +97,7 @@ public class NumericalHelper
case STRING_TYPE:
try
{
-Integer i = Integer.valueOf((String) aTypeObject.aValue);
-retValue = i.intValue();
+retValue = Integer.parseInt((String) aTypeObject.aValue);
}
catch (java.lang.NumberFormatException e)
{
@@ -152,8 +151,7 @@ public class NumericalHelper
case STRING_TYPE:
try
{
-Float f = new Float((String) aTypeObject.aValue);
-retValue = f.floatValue();
+retValue = Float.parseFloat((String) aTypeObject.aValue);
}
catch (java.lang.NumberFormatException e)
{
@@ -207,8 +205,7 @@ public class NumericalHelper
case STRING_TYPE:
try
{
-Boolean b = Boolean.valueOf((String) aTypeObject.aValue);
-retValue = b.booleanValue();
+retValue = Boolean.parseBoolean((String)
aTypeObject.aValue);
}
catch (java.lang.NumberFormatException e)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 75757] remove inheritance to std::map and std::vector
https://bugs.freedesktop.org/show_bug.cgi?id=75757 --- Comment #25 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e531e121fae61675fb358e814d49b70cfab14cf fdo#75757: remove inheritance to std::vector The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: connectivity/source svtools/source tools/source unotools/source
connectivity/source/commontools/parameters.cxx |4
connectivity/source/drivers/dbase/DConnection.cxx |1 -
connectivity/source/drivers/file/FDatabaseMetaData.cxx |1 -
connectivity/source/drivers/file/FPreparedStatement.cxx |1 -
connectivity/source/drivers/file/FResultSet.cxx |1 -
connectivity/source/drivers/file/FStatement.cxx |1 -
connectivity/source/drivers/file/FTable.cxx |1 -
connectivity/source/drivers/file/fcode.cxx |1 -
svtools/source/config/itemholder2.cxx |3 ---
svtools/source/contnr/contentenumeration.cxx|1 -
svtools/source/contnr/viewdataentry.cxx |3 ---
svtools/source/control/accessibleruler.cxx |1 -
tools/source/generic/config.cxx |1 -
tools/source/generic/line.cxx |1 -
tools/source/stream/strmunx.cxx |1 -
unotools/source/config/configvaluecontainer.cxx |2 --
unotools/source/i18n/calendarwrapper.cxx|1 -
unotools/source/i18n/charclass.cxx |1 -
unotools/source/i18n/collatorwrapper.cxx|1 -
unotools/source/i18n/nativenumberwrapper.cxx|1 -
unotools/source/i18n/numberformatcodewrapper.cxx|1 -
unotools/source/i18n/transliterationwrapper.cxx |1 -
unotools/source/streaming/streamwrap.cxx|1 -
23 files changed, 31 deletions(-)
New commits:
commit b3d985230968fe8987023db6353d09d4567be74c
Author: Marcos Paulo de Souza marcos.souza@gmail.com
Date: Tue Aug 19 08:08:55 2014 -0300
Remove more useless includes of tools/debug.hxx
Change-Id: If289dcbff125ac0088f01b5c9752f9f3173585dc
Reviewed-on: https://gerrit.libreoffice.org/11020
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/connectivity/source/commontools/parameters.cxx
b/connectivity/source/commontools/parameters.cxx
index d7809d5..72757fb 100644
--- a/connectivity/source/commontools/parameters.cxx
+++ b/connectivity/source/commontools/parameters.cxx
@@ -32,7 +32,6 @@
#include connectivity/filtermanager.hxx
#include TConnection.hxx
-#include tools/debug.hxx
#include tools/diagnose_ex.h
#include comphelper/uno3.hxx
@@ -41,11 +40,8 @@
#include connectivity/ParameterCont.hxx
#include rtl/ustrbuf.hxx
-
namespace dbtools
{
-
-
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::sdb;
using namespace ::com::sun::star::sdbc;
diff --git a/connectivity/source/drivers/dbase/DConnection.cxx
b/connectivity/source/drivers/dbase/DConnection.cxx
index a86c316..f4881b0 100644
--- a/connectivity/source/drivers/dbase/DConnection.cxx
+++ b/connectivity/source/drivers/dbase/DConnection.cxx
@@ -25,7 +25,6 @@
#include com/sun/star/lang/DisposedException.hpp
#include dbase/DPreparedStatement.hxx
#include dbase/DStatement.hxx
-#include tools/debug.hxx
#include connectivity/dbexception.hxx
using namespace connectivity::dbase;
diff --git a/connectivity/source/drivers/file/FDatabaseMetaData.cxx
b/connectivity/source/drivers/file/FDatabaseMetaData.cxx
index c36c302..5a766df 100644
--- a/connectivity/source/drivers/file/FDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/file/FDatabaseMetaData.cxx
@@ -31,7 +31,6 @@
#include file/FDriver.hxx
#include file/FTable.hxx
#include comphelper/processfactory.hxx
-#include tools/debug.hxx
#include ucbhelper/content.hxx
using namespace com::sun::star::ucb;
diff --git a/connectivity/source/drivers/file/FPreparedStatement.cxx
b/connectivity/source/drivers/file/FPreparedStatement.cxx
index 7d5e1c5..66dff0a 100644
--- a/connectivity/source/drivers/file/FPreparedStatement.cxx
+++ b/connectivity/source/drivers/file/FPreparedStatement.cxx
@@ -34,7 +34,6 @@
#include diagnose_ex.h
#include comphelper/types.hxx
#include com/sun/star/sdbc/ColumnValue.hpp
-#include tools/debug.hxx
#include resource/file_res.hrc
using namespace connectivity;
diff --git a/connectivity/source/drivers/file/FResultSet.cxx
b/connectivity/source/drivers/file/FResultSet.cxx
index ee98373..08210b5 100644
--- a/connectivity/source/drivers/file/FResultSet.cxx
+++ b/connectivity/source/drivers/file/FResultSet.cxx
@@ -36,7 +36,6 @@
#include connectivity/dbtools.hxx
#include cppuhelper/propshlp.hxx
#include iterator
-#include tools/debug.hxx
#include com/sun/star/sdbc/ResultSetType.hpp
#include com/sun/star/sdbc/FetchDirection.hpp
#include com/sun/star/sdbc/ResultSetConcurrency.hpp
diff --git a/connectivity/source/drivers/file/FStatement.cxx
b/connectivity/source/drivers/file/FStatement.cxx
index c83fadf..229cc8e 100644
--- a/connectivity/source/drivers/file/FStatement.cxx
+++ b/connectivity/source/drivers/file/FStatement.cxx
@@ -35,7 +35,6 @@
#include connectivity/dbexception.hxx
#include
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 52226, which changed state. Bug 52226 Summary: FILESAVE Images in .docx and .xlsx files show Read-Error, probably corrupted by auto-save[Summary in comment # 31] https://bugs.freedesktop.org/show_bug.cgi?id=52226 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||67379 --- Comment #211 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to comment #210) Adding bug 67379. Cursor positioning in a document where frames are used has been broken for a very long time and is very annoying. would concur with nomination -- adding issue to MAB -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Deena P. F. : license statement
Hi All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. My affiliation is : Libre Data Consultancy Services (P) Ltd Thanks, Deena P. F. On Fri, Aug 15, 2014 at 6:53 PM, Deena Francis deena.fran...@gmail.com wrote: Hi All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Thanks, Deena P. F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Suggestion for the use of pre-written responses
Hey there, Jay, *, Not sure that codifying a bunch of approved QA exchanges is in the best interest of moving the QA process along--especially if we have to dig them out of a WiKi. It would not do much to improve the QA flow, nor improve the readability of issues over their life span. Otherwise, during triage we should all strive to be courteous. By itself, the automated message delivered *** This bug has been marked as a duplicate of bug x *** is a bit too terse in closing a NEW issue as duplicate. But believe including a simple thank you for posting would suffice. If too many bugs like fdo#82701 are making it through, then the Bugzilla and BSA duplicate issue filters may need to be improved. I don't think he was trying to codify - maybe more just saying I'm posting these to the wiki - feel free to use (or not use) them at your pleasure :) I've thought of doing similar things with my auto responses but of course everyone can use their own methodology :) Best, Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 38 commits - sc/source solenv/gdb sw/inc sw/README sw/source xmloff/source xmlscript/source
sc/source/filter/excel/xiescher.cxx|3
solenv/gdb/libreoffice/sw.py |8 -
sw/README | 43 ++-
sw/inc/doc.hxx |4
sw/inc/expfld.hxx |4
sw/inc/fmtfld.hxx |7 -
sw/inc/fmtftn.hxx | 24 +++
sw/inc/fmtrfmrk.hxx| 24 +++
sw/inc/hintids.hxx |4
sw/inc/unocoll.hxx |4
sw/inc/unoframe.hxx| 32 -
sw/inc/unoparagraph.hxx|6
sw/inc/unotbl.hxx |5
sw/source/core/attr/calbck.cxx |7 -
sw/source/core/crsr/bookmrk.cxx|2
sw/source/core/doc/docftn.cxx |3
sw/source/core/doc/docnew.cxx |2
sw/source/core/doc/textboxhelper.cxx | 12 +
sw/source/core/docnode/nodes.cxx | 20 +--
sw/source/core/fields/expfld.cxx |6
sw/source/core/inc/unobookmark.hxx | 18 +-
sw/source/core/inc/unofield.hxx| 14 +-
sw/source/core/inc/unofootnote.hxx | 13 --
sw/source/core/inc/unoidx.hxx | 13 +-
sw/source/core/inc/unometa.hxx | 12 +
sw/source/core/inc/unorefmark.hxx | 11 -
sw/source/core/layout/atrfrm.cxx |4
sw/source/core/tox/tox.cxx |4
sw/source/core/txtnode/atrfld.cxx | 38 +-
sw/source/core/txtnode/atrftn.cxx | 28 +++-
sw/source/core/txtnode/atrref.cxx | 34 -
sw/source/core/txtnode/ndtxt.cxx |2
sw/source/core/txtnode/thints.cxx | 14 --
sw/source/core/unocore/unobkm.cxx | 75 +++-
sw/source/core/unocore/unocoll.cxx | 122
sw/source/core/unocore/unocrsrhelper.cxx | 21 +--
sw/source/core/unocore/unodraw.cxx | 18 +-
sw/source/core/unocore/unofield.cxx| 128 +
sw/source/core/unocore/unoframe.cxx| 64 +-
sw/source/core/unocore/unoftn.cxx | 75 +---
sw/source/core/unocore/unoidx.cxx | 84 +
sw/source/core/unocore/unoobj2.cxx | 36 +++--
sw/source/core/unocore/unoparagraph.cxx| 37 +++---
sw/source/core/unocore/unoportenum.cxx | 43 ---
sw/source/core/unocore/unorefmk.cxx| 106 +
sw/source/core/unocore/unosect.cxx | 18 ++
sw/source/core/unocore/unotbl.cxx | 31 -
sw/source/core/unocore/unotext.cxx | 19 +--
sw/source/filter/ww8/docxattributeoutput.cxx |6
sw/source/filter/ww8/ww8par.cxx|3
sw/source/filter/ww8/ww8par6.cxx |6
sw/source/filter/xml/xmltexti.cxx | 45 ---
sw/source/uibase/uno/unotxvw.cxx | 46 +++
sw/source/uibase/wrtsh/wrtsh2.cxx | 37 --
xmloff/source/forms/elementexport.cxx |4
xmloff/source/forms/layerimport.cxx|6
xmlscript/source/xmldlg_imexp/xmldlg_expmodels.cxx |1
xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx |8 -
58 files changed, 943 insertions(+), 521 deletions(-)
New commits:
commit 9f01ba1b78edf6a08d36be39658327451120d613
Author: Michael Stahl mst...@redhat.com
Date: Wed Aug 20 14:19:31 2014 +0200
i#107771: sw: burn, UnoCallBack, burn!
Change-Id: Ifdb6d4b2e404bd160e6fcec3229691e750bdf698
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 1fbb206..2ff506b 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -346,7 +346,6 @@ class SW_DLLPUBLIC SwDoc :
SwLayoutCache *mpLayoutCache; /** Layout cache to read and save with
the
document for a faster formatting */
-SwModify *mpUnoCallBack;
IGrammarContact *mpGrammarContact; // for grammar checking in
paragraphs during editing
// table of forbidden characters of this document
@@ -1562,9 +1561,6 @@ public:
*/
bool ContainsHiddenChars() const;
-// call back for API wrapper
-SwModify* GetUnoCallBack() const { return mpUnoCallBack; }
-
IGrammarContact* getGrammarContact() const { return mpGrammarContact; }
/** Marks/Unmarks a list level of a certain list
diff --git a/sw/source/core/doc/docnew.cxx b/sw/source/core/doc/docnew.cxx
index c5ec7fe..c18fe20 100644
--- a/sw/source/core/doc/docnew.cxx
+++ b/sw/source/core/doc/docnew.cxx
@@
[Libreoffice-commits] core.git: sc/source
sc/source/ui/dbgui/validate.cxx | 17 -
sc/source/ui/inc/validate.hxx | 19 +--
2 files changed, 17 insertions(+), 19 deletions(-)
New commits:
commit 9a42c5939485732c031f6e6d30394b5414f6ad61
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Aug 20 17:02:33 2014 +0200
Bad hack to enforce weakly emitted RTTI for ScValidationDlg
...(by inlining all its virtual functions), as otherwise
-fsanitize=undefined
makes sc require ScValidationDlg RTTI (to verify the cast to
ScValidationDlg in
the ScValidityRefChildWin ctor in sc/source/ui/view/reffact.cxx) but which
would
only be emitted in scui (against which sc cannot link).
Change-Id: Id9e2bf0719ba3bba35e5ae1f0e58190d9fdb6dd4
diff --git a/sc/source/ui/dbgui/validate.cxx b/sc/source/ui/dbgui/validate.cxx
index 6cfaafa..c4b9514 100644
--- a/sc/source/ui/dbgui/validate.cxx
+++ b/sc/source/ui/dbgui/validate.cxx
@@ -156,23 +156,6 @@ void ScTPValidationValue::RefInputDonePostHdl()
}
-bool ScValidationDlg::Close()
-{
-if( m_bOwnRefHdlr )
-{
-if (SfxTabPage* pPage = GetTabPage(m_nValuePageId))
-static_castScTPValidationValue*(pPage)-RemoveRefDlg();
-}
-
-return ScValidationDlgBase::Close();
-}
-
-ScValidationDlg::~ScValidationDlg()
-{
-if( m_bOwnRefHdlr )
-RemoveRefDlg( false );
-}
-
namespace {
/** Converts the passed ScValidationMode to the position in the list box. */
diff --git a/sc/source/ui/inc/validate.hxx b/sc/source/ui/inc/validate.hxx
index edda7dc..12db0e7 100644
--- a/sc/source/ui/inc/validate.hxx
+++ b/sc/source/ui/inc/validate.hxx
@@ -97,7 +97,11 @@ class ScValidationDlg
public:
explicit ScValidationDlg( Window* pParent, const SfxItemSet* pArgSet,
ScTabViewShell * pTabViewSh, SfxBindings *pB = NULL );
-virtual ~ScValidationDlg();
+virtual ~ScValidationDlg()
+{
+if( m_bOwnRefHdlr )
+RemoveRefDlg( false );
+}
static ScValidationDlg * Find1AliveObject( Window *pAncestor )
{
return static_castScValidationDlg *( SC_MOD()-Find1RefWindow(
SLOTID, pAncestor ) );
@@ -169,7 +173,7 @@ public:
enum { SLOTID = SID_VALIDITY_REFERENCE };
-bool Close() SAL_OVERRIDE;
+inline bool Close() SAL_OVERRIDE;
};
/** The tab page Criteria from the Validation dialog. */
@@ -257,6 +261,17 @@ public:
voidRemoveRefDlg();
};
+bool ScValidationDlg::Close()
+{
+if( m_bOwnRefHdlr )
+{
+if (SfxTabPage* pPage = GetTabPage(m_nValuePageId))
+static_castScTPValidationValue*(pPage)-RemoveRefDlg();
+}
+
+return ScValidationDlgBase::Close();
+}
+
class ScTPValidationHelp : public SfxTabPage
{
private:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unoframe.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit c310523a5f33372e76b69545dbbee0809644bd0c
Author: Michael Stahl mst...@redhat.com
Date: Wed Aug 20 17:11:12 2014 +0200
C++ name lookup is hard, especially for clang tinderbox
Change-Id: I50a25e5cfa219bbdcf0a23c03b8e6a2cff72c3d6
diff --git a/sw/source/core/unocore/unoframe.cxx
b/sw/source/core/unocore/unoframe.cxx
index 58be8ab..6eab659 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1232,7 +1232,7 @@ SwXFrame::~SwXFrame()
delete pProps;
}
-templateclass Interface, class Impl
+templateclass Interface, class NameLookupIsHard
uno::ReferenceInterface
SwXFrame::CreateXFrame(SwDoc rDoc, SwFrmFmt *const pFrmFmt)
{
@@ -1244,7 +1244,9 @@ SwXFrame::CreateXFrame(SwDoc rDoc, SwFrmFmt *const
pFrmFmt)
}
if (!xFrame.is())
{
-Impl *const pNew((pFrmFmt) ? new Impl(*pFrmFmt) : new Impl(rDoc));
+NameLookupIsHard *const pNew((pFrmFmt)
+? new NameLookupIsHard(*pFrmFmt)
+: new NameLookupIsHard(rDoc));
xFrame.set(pNew);
if (pFrmFmt)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/source
sw/source/filter/ww8/ww8par6.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit b2d54aa61607e477cb4b81f1a70e555ee3adb0af
Author: Michael Stahl mst...@redhat.com
Date: Tue Aug 19 18:11:42 2014 +0200
sw: ww8: fix another ~SwIndexReg() assertion
If the position is the same as the body text anchor position, don't
delete the node. Probably something should have inserted more nodes
between StartApo() and StopApo().
Change-Id: I41110a47d840e764f6d2a24e43bf6938b1282972
(cherry picked from commit 404f16e97f1c2fcd8f9a1297bdfa46cba970467e)
Reviewed-on: https://gerrit.libreoffice.org/11046
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index 5e7ce09..cb22c8f 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -2379,7 +2379,7 @@ bool SwWW8ImplReader::StartApo(const ApoTestResults rApo,
pAnchorStck-AddAnchor(*pPaM-GetPoint(),pSFlyPara-pFlyFmt);
}
-// merke Pos im Haupttext
+// remember Pos in body text
pSFlyPara-pMainTextPos = new SwPosition( *pPaM-GetPoint() );
//remove fltanchors, otherwise they will be closed inside the
@@ -2475,7 +2475,9 @@ void SwWW8ImplReader::StopApo()
Color aBg(0xFE, 0xFF, 0xFF, 0xFF); //Transparent by default
-if (SwTxtNode* pNd = aPref.GetNode().GetTxtNode())
+SwTxtNode* pNd = aPref.GetNode().GetTxtNode();
+if (pNd pPaM-GetPoint()-nNode.GetNode()
+!= pSFlyPara-pMainTextPos-nNode.GetNode())
{
/*
#i582#
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-1' - connectivity/source
connectivity/source/parse/sqlbison.y |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit c4e400e4ef8523b3bd587f5d7a6160af8d44df94
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Mon Aug 18 22:22:22 2014 +0200
fdo#82427 disambiguate NOT LIKE 'foo'
Change-Id: Iab383639ea73cc87c03f4f42433bc9ccfcd988ef
Reviewed-on: https://gerrit.libreoffice.org/11009
Reviewed-by: David Tardon dtar...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/connectivity/source/parse/sqlbison.y
b/connectivity/source/parse/sqlbison.y
index 35819a3..231c9e1 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -1124,8 +1124,8 @@ parenthesized_boolean_value_expression:
}
;
boolean_factor:
- boolean_primary
- | SQL_TOKEN_NOT boolean_primary
+ boolean_primary %dprec 2
+ | SQL_TOKEN_NOT boolean_primary %dprec 1
{ // boolean_factor: rule 1
$$ = SQL_NEW_RULE;
$$-append($1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sw/source
sw/source/filter/ww8/ww8par6.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 953a77abf6466165d5fbcc88cd87ce062ad901e8
Author: Michael Stahl mst...@redhat.com
Date: Tue Aug 19 18:11:42 2014 +0200
sw: ww8: fix another ~SwIndexReg() assertion
If the position is the same as the body text anchor position, don't
delete the node. Probably something should have inserted more nodes
between StartApo() and StopApo().
Change-Id: I41110a47d840e764f6d2a24e43bf6938b1282972
(cherry picked from commit 404f16e97f1c2fcd8f9a1297bdfa46cba970467e)
Reviewed-on: https://gerrit.libreoffice.org/11048
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index 14cb5b3..392fdac 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -2374,7 +2374,7 @@ bool SwWW8ImplReader::StartApo(const ApoTestResults rApo,
pAnchorStck-AddAnchor(*pPaM-GetPoint(),pSFlyPara-pFlyFmt);
}
-// merke Pos im Haupttext
+// remember Pos in body text
pSFlyPara-pMainTextPos = new SwPosition( *pPaM-GetPoint() );
//remove fltanchors, otherwise they will be closed inside the
@@ -2470,7 +2470,9 @@ void SwWW8ImplReader::StopApo()
Color aBg(0xFE, 0xFF, 0xFF, 0xFF); //Transparent by default
-if (SwTxtNode* pNd = aPref.GetNode().GetTxtNode())
+SwTxtNode* pNd = aPref.GetNode().GetTxtNode();
+if (pNd pPaM-GetPoint()-nNode.GetNode()
+!= pSFlyPara-pMainTextPos-nNode.GetNode())
{
/*
#i582#
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - extensions/source include/svtools include/tools include/vcl rsc/source svtools/source tools/source uui/source vcl/source
extensions/source/bibliography/bibcont.cxx|5 -
extensions/source/bibliography/bibshortcuthandler.hxx |8 ++--
include/svtools/wizardmachine.hxx |1 -
include/tools/rcid.h |2 --
include/vcl/tabpage.hxx |2 --
rsc/source/parser/rscinit.cxx |9 -
svtools/source/dialogs/wizardmachine.cxx | 18 --
tools/source/rc/resmgr.cxx|2 --
uui/source/ids.hrc|4
vcl/source/window/tabpage.cxx | 12
10 files changed, 2 insertions(+), 61 deletions(-)
New commits:
commit afa5d63e2adccefd5cabfe2e0f6f78ce217a294d
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 14:15:19 2014 +0100
TabPages are no longer loaded from resource files
Change-Id: I009e0f388cfe1861cef89d2148a02380dd47c1ff
diff --git a/extensions/source/bibliography/bibcont.cxx
b/extensions/source/bibliography/bibcont.cxx
index d4460e7..346478b 100644
--- a/extensions/source/bibliography/bibcont.cxx
+++ b/extensions/source/bibliography/bibcont.cxx
@@ -60,11 +60,6 @@ BibSplitWindow::~BibSplitWindow()
{
}
-
-BibTabPage::BibTabPage( Window* pParent, const ResId rResId ) : TabPage(
pParent, rResId ), BibShortCutHandler( this )
-{
-}
-
BibTabPage::BibTabPage( Window* pParent, const OString rID, const OUString
rUIXMLDescription ) :
TabPage( pParent, rID, rUIXMLDescription ),
BibShortCutHandler( this )
{
diff --git a/extensions/source/bibliography/bibshortcuthandler.hxx
b/extensions/source/bibliography/bibshortcuthandler.hxx
index 9b862bc..6eb4231 100644
--- a/extensions/source/bibliography/bibshortcuthandler.hxx
+++ b/extensions/source/bibliography/bibshortcuthandler.hxx
@@ -52,7 +52,6 @@ inline Window* BibShortCutHandler::GetWindow( void )
return pBaseClass;
}
-
class BibWindow : public Window, public BibShortCutHandler
{
public:
@@ -60,7 +59,6 @@ public:
virtual ~BibWindow();
};
-
class BibSplitWindow : public SplitWindow, public BibShortCutHandler
{
public:
@@ -68,13 +66,11 @@ public:
virtual ~BibSplitWindow();
};
-
class BibTabPage : public TabPage, public BibShortCutHandler
{
public:
-BibTabPage( Window* pParent, const ResId rResId );
-BibTabPage( Window* pParent, const OString rID,
const OUString rUIXMLDescription );
-virtual ~BibTabPage();
+BibTabPage( Window* pParent, const OString rID, const OUString
rUIXMLDescription );
+virtual ~BibTabPage();
};
#endif
diff --git a/include/svtools/wizardmachine.hxx
b/include/svtools/wizardmachine.hxx
index 5d780a8..9618af1 100644
--- a/include/svtools/wizardmachine.hxx
+++ b/include/svtools/wizardmachine.hxx
@@ -98,7 +98,6 @@ namespace svt
if the OWizardPage is used in an OWizardMachine, this parameter
must be the OWizardMachine (which is derived from Window)
*/
-OWizardPage(Window* _pParent, const ResId _rResId);
OWizardPage(Window *pParent, const OString rID, const OUString
rUIXMLDescription);
virtual ~OWizardPage();
diff --git a/include/tools/rcid.h b/include/tools/rcid.h
index 47244ea..f1edf65 100644
--- a/include/tools/rcid.h
+++ b/include/tools/rcid.h
@@ -98,8 +98,6 @@
#define RSC_TOOLBOX (RSC_NOTYPE + 0x71)
#define RSC_DOCKINGWINDOW (RSC_NOTYPE + 0x72)
-#define RSC_TABPAGE (RSC_NOTYPE + 0x74)
-
#define RSC_STRINGARRAY (RSC_NOTYPE + 0x79)
// (RSC_NOTYPE + 0x200) - (RSC_NOTYPE + 0x300) reserved for Sfx
diff --git a/include/vcl/tabpage.hxx b/include/vcl/tabpage.hxx
index 88a1ead..86f9946 100644
--- a/include/vcl/tabpage.hxx
+++ b/include/vcl/tabpage.hxx
@@ -42,8 +42,6 @@ public:
explicitTabPage( Window* pParent, WinBits nStyle = 0 );
explicitTabPage( Window *pParent, const OString rID, const
OUString rUIXMLDescription );
-explicitTabPage( Window* pParent, const ResId rResId );
-
virtual voidPaint( const Rectangle rRect ) SAL_OVERRIDE;
virtual voidDraw( OutputDevice* pDev, const Point rPos, const Size
rSize, sal_uLong nFlags ) SAL_OVERRIDE;
diff --git a/rsc/source/parser/rscinit.cxx b/rsc/source/parser/rscinit.cxx
index 70415bc..5859588 100644
--- a/rsc/source/parser/rscinit.cxx
+++ b/rsc/source/parser/rscinit.cxx
@@ -112,7 +112,6 @@ void RscTypCont::Init()
RscTop * pClassToolBoxItem;
RscTop * pClassToolBox;
RscTop * pClassFloatingWindow;
-RscTop * pClassTabPage;
RscTop * pClassFixedLine;
RscTop *pClassSfxStyleFamilyItem;
RscTop *pClassSfxTemplateDialog;
@@ -588,14 +587,6 @@ void RscTypCont::Init()
pRoot-Insert( pClassFloatingWindow );
// Klasse anlegen
-
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/forms/elementexport.cxx | 30 --
1 file changed, 30 deletions(-)
New commits:
commit 29e1b2f1ca6e2dcbf9a04c63a3ac1d554cfdcb52
Author: Michael Stahl mst...@redhat.com
Date: Wed Aug 20 17:37:30 2014 +0200
xmloff: dead code gives MSVC fits
Change-Id: I1ae4a38fb828e6801e444b6345fd8b60f5c1
diff --git a/xmloff/source/forms/elementexport.cxx
b/xmloff/source/forms/elementexport.cxx
index 2a25317..4ce6534 100644
--- a/xmloff/source/forms/elementexport.cxx
+++ b/xmloff/source/forms/elementexport.cxx
@@ -1155,36 +1155,6 @@ namespace xmloff
}
}
-// the string properties
-{
-static const sal_Int32 nStringPropertyAttributeIds[] =
-{ // attribute flags
-};
-static const OUString pStringPropertyNames[] =
-{ // property names
-};
-
-static const sal_Int32 nIdCount = sizeof(
nStringPropertyAttributeIds ) / sizeof( nStringPropertyAttributeIds[0] );
-#if OSL_DEBUG_LEVEL 0
-static const sal_Int32 nNameCount = sizeof( pStringPropertyNames )
/ sizeof( pStringPropertyNames[0] );
-OSL_ENSURE( ( nIdCount == nNameCount ),
-OControlExport::exportSpecialAttributes: somebody tampered
with the maps (2)! );
-#endif
-for ( i = 0; i nIdCount; ++i )
-if ( nStringPropertyAttributeIds[i] m_nIncludeSpecial )
-{
-exportStringPropertyAttribute(
-OAttributeMetaData::getSpecialAttributeNamespace(
nStringPropertyAttributeIds[i] ),
-OAttributeMetaData::getSpecialAttributeName(
nStringPropertyAttributeIds[i] ),
-pStringPropertyNames[i]
-);
-#if OSL_DEBUG_LEVEL 0
-// reset the bit for later checking
-m_nIncludeSpecial = m_nIncludeSpecial
~nStringPropertyAttributeIds[i];
-#endif
-}
-}
-
if ((SCA_MIN_VALUE | SCA_MAX_VALUE) m_nIncludeSpecial)
{
// need to export the min value and the max value as attributes
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/funcdesc.cxx | 16
1 file changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 135df4753db7e03817a2a0dbb6e68ead457385e2
Author: Eike Rathke er...@redhat.com
Date: Wed Aug 20 18:13:11 2014 +0200
convert some OSL_TRACE to SAL_WARN
Change-Id: Ifb687de25a6da4696e659e27cb34668a9762445f
diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx
index df48b13..7ab1b47 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -837,8 +837,8 @@ ScFuncRes::ScFuncRes( ResId aRes, ScFuncDesc* pDesc, bool
rbSuppressed )
{
if (nSuppressed nArgs)
{
-OSL_TRACE( ScFuncRes: suppressed parameters count mismatch on
OpCode %u: suppressed %d params %d,
-aRes.GetId(), (int)nSuppressed, (int)nArgs);
+SAL_WARN(sc.core, ScFuncRes: suppressed parameters count
mismatch on OpCode
+aRes.GetId() : suppressed nSuppressed
params nArgs);
nSuppressed = nArgs;// sanitize
}
for (sal_uInt16 i = 0; i nSuppressed; ++i)
@@ -848,13 +848,13 @@ ScFuncRes::ScFuncRes( ResId aRes, ScFuncDesc* pDesc,
bool rbSuppressed )
{
if (pDesc-nArgCount = PAIRED_VAR_ARGS nParam = nArgs-2)
{
-OSL_TRACE( ScFuncRes: PAIRED_VAR_ARGS parameters can't be
suppressed, on OpCode %u: param %d = arg %d-2,
-aRes.GetId(), (int)nParam, (int)nArgs);
+SAL_WARN(sc.core, ScFuncRes: PAIRED_VAR_ARGS parameters
can't be suppressed, on OpCode
+aRes.GetId() : param nParam = arg
nArgs -2);
}
else if (pDesc-nArgCount = VAR_ARGS nParam == nArgs-1)
{
-OSL_TRACE( ScFuncRes: VAR_ARGS parameters can't be
suppressed, on OpCode %u: param %d == arg %d-1,
-aRes.GetId(), (int)nParam, (int)nArgs);
+SAL_WARN(sc.core, ScFuncRes: VAR_ARGS parameters can't
be suppressed, on OpCode
+aRes.GetId() : param nParam == arg
nArgs -1);
}
else
{
@@ -864,8 +864,8 @@ ScFuncRes::ScFuncRes( ResId aRes, ScFuncDesc* pDesc, bool
rbSuppressed )
}
else
{
-OSL_TRACE( ScFuncRes: suppressed parameter exceeds count on
OpCode %u: param %d = args %d,
-aRes.GetId(), (int)nParam, (int)nArgs);
+SAL_WARN(sc.core, ScFuncRes: suppressed parameter exceeds
count on OpCode
+aRes.GetId() : param nParam = args
nArgs);
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/validate.hxx | 186 +-
1 file changed, 93 insertions(+), 93 deletions(-)
New commits:
commit da401ac07b4e41b43723722aaff135b3a1376b31
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Aug 20 18:23:48 2014 +0200
Work around unhelpful MSVC error C2216: override cannot be used with inline
Change-Id: I2944b9911b2458bf1c0f1645fd983b635be67bd2
diff --git a/sc/source/ui/inc/validate.hxx b/sc/source/ui/inc/validate.hxx
index 12db0e7..9876d4c 100644
--- a/sc/source/ui/inc/validate.hxx
+++ b/sc/source/ui/inc/validate.hxx
@@ -77,6 +77,93 @@ public:
ScRefHandlerHelper():m_pHandler(NULL), m_pSetReferenceHdl( NULL ),
m_pSetActiveHdl(NULL), m_pRefInputStartPreHdl( NULL ),
m_pRefInputStartPostHdl( NULL ), m_pRefInputDonePreHdl( NULL ),
m_pRefInputDonePostHdl( NULL ){}
};
+class ScValidationDlg;
+
+/** The tab page Criteria from the Validation dialog. */
+class ScTPValidationValue : public ScRefHandlerCaller, public SfxTabPage
+{
+public:
+explicitScTPValidationValue( Window* pParent, const
SfxItemSet rArgSet );
+
+static SfxTabPage* Create( Window* pParent, const SfxItemSet*
rArgSet );
+static const sal_uInt16* GetRanges();
+
+virtual boolFillItemSet( SfxItemSet* rArgSet )
SAL_OVERRIDE;
+virtual voidReset( const SfxItemSet* rArgSet )
SAL_OVERRIDE;
+
+private:
+voidInit();
+
+OUString GetFirstFormula() const;
+OUString GetSecondFormula() const;
+
+voidSetFirstFormula( const OUString rFmlaStr );
+voidSetSecondFormula( const OUString rFmlaStr );
+
+DECL_LINK(SelectHdl, void *);
+DECL_LINK(CheckHdl, void *);
+
+ListBox*m_pLbAllow;
+CheckBox* m_pCbAllow; /// Allow blank cells.
+CheckBox* m_pCbShow; /// Show selection list in
cell.
+CheckBox* m_pCbSort; /// Sort selection list in
cell.
+FixedText* m_pFtValue;
+ListBox*m_pLbValue;
+FixedText* m_pFtMin;
+VclContainer* m_pMinGrid;
+formula::RefEdit* m_pEdMin;
+VclMultiLineEdit* m_pEdList; /// Entries for explicit list
+FixedText* m_pFtMax;
+formula::RefEdit* m_pEdMax;
+FixedText* m_pFtHint; /// Hint text for cell range
validity.
+
+OUStringmaStrMin;
+OUStringmaStrMax;
+OUStringmaStrValue;
+OUStringmaStrRange;
+OUStringmaStrList;
+sal_Unicode mcFmlaSep; /// List separator in formulas.
+
+DECL_LINK(EditSetFocusHdl, void *);
+DECL_LINK( KillFocusHdl, Window *);
+voidOnClick( Button *pBtn );
+formula::RefEdit* m_pRefEdit;
+public:
+class ScRefButtonEx : public ::formula::RefButton
+{
+ScTPValidationValue* m_pPage;
+virtual void Click() SAL_OVERRIDE;
+public:
+ScRefButtonEx(Window* pParent, WinBits nStyle)
+: ::formula::RefButton(pParent, nStyle)
+, m_pPage(NULL)
+{
+}
+void SetParentPage(ScTPValidationValue *pPage)
+{
+m_pPage = pPage;
+}
+ScTPValidationValue* GetParentPage()
+{
+return m_pPage;
+}
+};
+private:
+ScRefButtonEx* m_pBtnRef;
+VclContainer* m_pRefGrid;
+friend class ScRefButtonEx;
+voidSetReferenceHdl( const ScRange , ScDocument* );
+voidSetActiveHdl();
+voidRefInputStartPreHdl( formula::RefEdit* pEdit,
formula::RefButton* pButton );
+voidRefInputDonePostHdl();
+ScValidationDlg * GetValidationDlg();
+public:
+sal_uInt16 GetAllowEntryPos();
+OUStringGetMinText();
+voidSetupRefDlg();
+voidRemoveRefDlg();
+};
+
/** The Validity tab dialog. */
class ScValidationDlg
: public ScRefHdlrImplScValidationDlg, SfxTabDialog, false
@@ -173,104 +260,17 @@ public:
enum { SLOTID = SID_VALIDITY_REFERENCE };
-inline bool Close() SAL_OVERRIDE;
-};
-
-/** The tab page Criteria from the Validation dialog. */
-class ScTPValidationValue : public ScRefHandlerCaller, public SfxTabPage
-{
-public:
-explicitScTPValidationValue( Window* pParent, const
SfxItemSet rArgSet );
-
-static SfxTabPage* Create( Window* pParent, const SfxItemSet*
rArgSet );
-static const sal_uInt16* GetRanges();
-
-virtual boolFillItemSet( SfxItemSet* rArgSet )
SAL_OVERRIDE;
-
[Libreoffice-commits] core.git: 2 commits - connectivity/source
connectivity/source/commontools/DateConversion.cxx | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
New commits:
commit 3ddfcd70dccd1d8312d6172014f01862cd5be1ab
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Wed Aug 20 18:33:04 2014 +0200
make debug builds fail hard on unexpected conditions
Change-Id: I0732ce65757ee29e5ad12cb576c5b64ed0edeaee
diff --git a/connectivity/source/commontools/DateConversion.cxx
b/connectivity/source/commontools/DateConversion.cxx
index 9798845..0e31e4f 100644
--- a/connectivity/source/commontools/DateConversion.cxx
+++ b/connectivity/source/commontools/DateConversion.cxx
@@ -261,7 +261,19 @@ void DBTypeConversion::setValue(const
ReferenceXColumnUpdate xVariant,
css::lang::Locale loc;
if (xFormatProps-getPropertyValue(Locale) = loc)
nStandardKey = xFormatTypes-getStandardIndex(loc);
+else
+{
+assert(false);
+}
}
+else
+{
+SAL_WARN(connectivity.commontools, no format by key
nKeyToUse);
+}
+}
+else
+{
+assert(false);
}
// Why use nStandardKey rather than nKeyToUse here? I'm not sure,
but it was always like that.
// Previously had hardcoded 0 instead of nStandardKey, which led
to problems with dates
commit 73ff8a29c1d546bbe2864d714ddb9c35c1d875f4
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Wed Aug 20 18:35:20 2014 +0200
update comments with my new findings
Change-Id: I58e07994e627ce980573812cbe56a068f66b1862
diff --git a/connectivity/source/commontools/DateConversion.cxx
b/connectivity/source/commontools/DateConversion.cxx
index cf6fbe1..9798845 100644
--- a/connectivity/source/commontools/DateConversion.cxx
+++ b/connectivity/source/commontools/DateConversion.cxx
@@ -263,10 +263,12 @@ void DBTypeConversion::setValue(const
ReferenceXColumnUpdate xVariant,
nStandardKey = xFormatTypes-getStandardIndex(loc);
}
}
-// Why use nStandardKey rather than nKeyToUse here? Don't know,
but it was always like that.
+// Why use nStandardKey rather than nKeyToUse here? I'm not sure,
but it was always like that.
// Previously had hardcoded 0 instead of nStandardKey, which led
to problems with dates
// because of differences M/D/Y vs D/M/Y. This at least fixes
those problems, but possibly
// nKeyToUse is an even better choice than nStandardKey.
+// OTOH, using nKeyToUse nullifies the special treatment for
percent formats,
+// leading to 5 (in a percent format) to be understood as
500% instead of 5%.
sal_Int32 nRealUsedKey =
xFormatter-detectNumberFormat(nStandardKey, rString);
if (nRealUsedKey != nKeyToUse)
nRealUsedTypeClass = getNumberFormatType(xFormatter,
nRealUsedKey) ~NumberFormat::DEFINED;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Suggestion for the use of pre-written responses
jphilipz wrote .. So i'd like to propose the creation a wiki page of pre-written responses that we can all use. I have created the wiki page at https://wiki.documentfoundation.org/QA/BugTriage/Pre-Written_Responses and will be adding entries to it, though i have very little knowledge of how best to format the page :D. Please add in your own collection of responses if you have. Bright idea! I'm just thinking about the number of times when I advise to try to reproduce with a brand new LO profile! :-) I'd just change the name by template responses because we could adapt the answer (eg: in case of LO profile if you want to give the direct link, it depends on your env) and because indeed we don't want to be considered as machines :-p Julien -- View this message in context: http://nabble.documentfoundation.org/Suggestion-for-the-use-of-pre-written-responses-tp4119622p4119659.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ANN] libpagemaker 0.0.1 has been released
List of changes: - Fix build on MS Windows. - Parse HLS colors. - Parse bitmaps. - Parse WMF metafiles. - Fix output of multi-page documents. - Fix parsing of polygons. - Handle rotation of various shapes correctly. - Fix handling of text that contains ASCII control characters. - Fix parsing of big data blocks, where the data are saved in indirect records (sub-records). - And many other small fixes and improvements. Home page: https://wiki.documentfoundation.org/DLP/Libraries/libpagemaker Download from: http://dev-www.libreoffice.org/src/libpagemaker/ D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Suggestion for the use of pre-written responses
Hi All, Yes similar to what joel stated, i'm just posting the ones i use on the wiki for others to use if they'd like and for those who have their own and would like to share them, that they'd have a centralized resource to post them to. I believe the wiki will also be a useful resource for new QA members to see what type of responses they are likely to have to respond with. I personally use my browser's (opera) inbuilt feature to save these responses and whiteboard keywords so i dont have to copy and paste them from a wiki page or text file. Hopefully something similar can be added into the new bugzilla for QA/dev team members can easily have access to as Bjoern suggested or until then, grabbing a browser extension which has a similar feature like JBF suggested. For all those chrome/chromium users, search the extension for clip or clipboard and there are quite a few of them listed there. Regards, Jay Philips On 08/20/2014 06:38 PM, Joel Madero wrote: Hey there, Jay, *, Not sure that codifying a bunch of approved QA exchanges is in the best interest of moving the QA process along--especially if we have to dig them out of a WiKi. It would not do much to improve the QA flow, nor improve the readability of issues over their life span. Otherwise, during triage we should all strive to be courteous. By itself, the automated message delivered *** This bug has been marked as a duplicate of bug x *** is a bit too terse in closing a NEW issue as duplicate. But believe including a simple thank you for posting would suffice. If too many bugs like fdo#82701 are making it through, then the Bugzilla and BSA duplicate issue filters may need to be improved. I don't think he was trying to codify - maybe more just saying I'm posting these to the wiki - feel free to use (or not use) them at your pleasure :) I've thought of doing similar things with my auto responses but of course everyone can use their own methodology :) Best, Joel ___ List Name: Libreoffice-qa mailing list Mail address: libreoffice...@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - include/tools include/vcl rsc/source vcl/source
include/tools/rcid.h |4 ++--
include/vcl/msgbox.hxx|2 --
rsc/source/parser/rscinit.cxx | 16
vcl/source/window/msgbox.cxx | 12
4 files changed, 2 insertions(+), 32 deletions(-)
New commits:
commit 50fffcaa05eef36fe03b1654bd57fdd3ae741106
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 16:57:42 2014 +0100
Infoboxen are no longer loaded from resource files
Change-Id: If387291e9e145ee36338b1e560f18889c3b62674
diff --git a/include/tools/rcid.h b/include/tools/rcid.h
index e0d12f6..70199fc 100644
--- a/include/tools/rcid.h
+++ b/include/tools/rcid.h
@@ -48,7 +48,7 @@
#define RSC_IMAGELIST (RSC_NOTYPE + 0x24)
#define RSC_MESSBOX (RSC_NOTYPE + 0x30)
-#define RSC_INFOBOX (RSC_NOTYPE + 0x31)
+
#define RSC_WARNINGBOX (RSC_NOTYPE + 0x32)
#define RSC_QUERYBOX(RSC_NOTYPE + 0x34)
diff --git a/include/vcl/msgbox.hxx b/include/vcl/msgbox.hxx
index b97edb0..2684a25 100644
--- a/include/vcl/msgbox.hxx
+++ b/include/vcl/msgbox.hxx
@@ -77,7 +77,6 @@ private:
public:
InfoBox( Window* pParent, const OUString rMessage );
-InfoBox( Window* pParent, const ResId rResId );
InfoBox( Window* pParent, WinBits nStyle,
const OUString rMessage );
diff --git a/rsc/source/parser/rscinit.cxx b/rsc/source/parser/rscinit.cxx
index 1b5702f..2016d11 100644
--- a/rsc/source/parser/rscinit.cxx
+++ b/rsc/source/parser/rscinit.cxx
@@ -94,7 +94,6 @@ void RscTypCont::Init()
RscTop * pClassMenuItem;
RscTop * pClassMenu;
RscTop * pClassMessBox;
-RscTop * pClassInfoBox;
RscTop * pClassWarningBox;
RscTop * pClassQueryBox;
RscTop * pClassSplitter;
@@ -472,13 +471,6 @@ void RscTypCont::Init()
pRoot-Insert( pClassMessBox );
// Klasse anlegen
-nId = pHS-getID( InfoBox );
-pClassInfoBox = new RscClass( nId, RSC_INFOBOX, pClassMessBox );
-pClassInfoBox-SetCallPar( *pWinPar1, *pWinPar2, *pWinParType );
-aNmTb.Put( nId, CLASSNAME, pClassInfoBox );
-pRoot-Insert( pClassInfoBox );
-
-// Klasse anlegen
nId = pHS-getID( WarningBox );
pClassWarningBox = new RscClass( nId, RSC_WARNINGBOX, pClassMessBox );
pClassWarningBox-SetCallPar( *pWinPar1, *pWinPar2, *pWinParType );
diff --git a/vcl/source/window/msgbox.cxx b/vcl/source/window/msgbox.cxx
index ff2880d..666411c 100644
--- a/vcl/source/window/msgbox.cxx
+++ b/vcl/source/window/msgbox.cxx
@@ -420,12 +420,6 @@ InfoBox::InfoBox( Window* pParent, const OUString
rMessage ) :
ImplInitInfoBoxData();
}
-InfoBox::InfoBox( Window* pParent, const ResId rResId ) :
-MessBox( pParent, rResId.SetRT( RSC_INFOBOX ) )
-{
-ImplInitInfoBoxData();
-}
-
InfoBox::InfoBox( Window* pParent, WinBits nStyle, const OUString rMessage ) :
MessBox( pParent, nStyle, OUString(), rMessage )
{
commit d4a615bf62d81485d8e20e94824af511c9fef0bb
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 20 14:33:51 2014 +0100
ErrorBoxen are no longer loaded from resource files
Change-Id: I099258e449d0155154d60a839f9495236cb48cbb
diff --git a/include/tools/rcid.h b/include/tools/rcid.h
index f1edf65..e0d12f6 100644
--- a/include/tools/rcid.h
+++ b/include/tools/rcid.h
@@ -50,7 +50,7 @@
#define RSC_MESSBOX (RSC_NOTYPE + 0x30)
#define RSC_INFOBOX (RSC_NOTYPE + 0x31)
#define RSC_WARNINGBOX (RSC_NOTYPE + 0x32)
-#define RSC_ERRORBOX(RSC_NOTYPE + 0x33)
+
#define RSC_QUERYBOX(RSC_NOTYPE + 0x34)
#define RSC_WINDOW (RSC_NOTYPE + 0x35)
#define RSC_SYSWINDOW (RSC_NOTYPE + 0x36)
diff --git a/include/vcl/msgbox.hxx b/include/vcl/msgbox.hxx
index bc5f7b2..b97edb0 100644
--- a/include/vcl/msgbox.hxx
+++ b/include/vcl/msgbox.hxx
@@ -107,7 +107,6 @@ private:
public:
ErrorBox( Window* pParent, WinBits nStyle,
const OUString rMessage );
-ErrorBox( Window* pParent, const ResId rResId );
static ImageGetStandardImage();
};
diff --git a/rsc/source/parser/rscinit.cxx b/rsc/source/parser/rscinit.cxx
index 5859588..1b5702f 100644
--- a/rsc/source/parser/rscinit.cxx
+++ b/rsc/source/parser/rscinit.cxx
@@ -96,7 +96,6 @@ void RscTypCont::Init()
RscTop * pClassMessBox;
RscTop * pClassInfoBox;
RscTop * pClassWarningBox;
-RscTop * pClassErrorBox;
RscTop * pClassQueryBox;
RscTop * pClassSplitter;
RscTop * pClassSplitWindow;
@@ -487,13 +486,6 @@ void RscTypCont::Init()
pRoot-Insert( pClassWarningBox );
// Klasse anlegen
-nId = pHS-getID( ErrorBox );
-pClassErrorBox = new RscClass( nId, RSC_ERRORBOX, pClassMessBox );
-pClassErrorBox-SetCallPar( *pWinPar1, *pWinPar2, *pWinParType );
-aNmTb.Put( nId, CLASSNAME,
[Libreoffice-commits] core.git: extensions/source
extensions/source/update/ui/updatecheckui.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit dba2bae5aa77492a47243590fe125e97e505814d
Author: Thomas Arnhold tho...@arnhold.org
Date: Wed Aug 20 21:53:01 2014 +0200
stray ErrorBox from ResId
forgotten in c584f344b7f810c297da616befdc354b86fbf8b8
Change-Id: I2847b1853602c3a0ac1f9e55b496a34a408c790c
diff --git a/extensions/source/update/ui/updatecheckui.cxx
b/extensions/source/update/ui/updatecheckui.cxx
index 1f2b1c7..1c1120f 100644
--- a/extensions/source/update/ui/updatecheckui.cxx
+++ b/extensions/source/update/ui/updatecheckui.cxx
@@ -42,6 +42,7 @@
#include vcl/timer.hxx
#include vcl/menu.hxx
#include vcl/outdev.hxx
+#include vcl/layout.hxx
#include vcl/msgbox.hxx
#include vcl/lineinfo.hxx
#include vcl/button.hxx
@@ -594,7 +595,7 @@ IMPL_LINK_NOARG(UpdateCheckUI, ClickHdl)
mrJob-execute( aEmpty );
}
catch(const uno::Exception) {
-ErrorBox( NULL, ResId( MSG_ERR_NO_WEBBROWSER_FOUND, *mpSfxResMgr
)).Execute();
+MessageDialog( NULL, ResId( STR_NO_WEBBROWSER_FOUND, *mpSfxResMgr
)).Execute();
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: extensions/source
extensions/source/update/ui/updatecheckui.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e6369973702286d92bfc34ab8305d4a9bcf5c27e Author: Thomas Arnhold tho...@arnhold.org Date: Wed Aug 20 22:02:18 2014 +0200 rename define too Change-Id: I33c9c867f058d69739d1389c76f76f89f1150b93 diff --git a/extensions/source/update/ui/updatecheckui.cxx b/extensions/source/update/ui/updatecheckui.cxx index 1c1120f..5f15da3 100644 --- a/extensions/source/update/ui/updatecheckui.cxx +++ b/extensions/source/update/ui/updatecheckui.cxx @@ -53,7 +53,7 @@ #include updatecheckui.hrc -#define MSG_ERR_NO_WEBBROWSER_FOUND (RID_SFX_APP_START + 7) +#define STR_NO_WEBBROWSER_FOUND (RID_SFX_APP_START + 7) #define PROPERTY_TITLE BubbleHeading #define PROPERTY_TEXT BubbleText ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basic/source
basic/source/runtime/methods1.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit d718c1f65f850f7897b942c2e4415110132e51a5
Author: Michael Meeks michael.me...@collabora.com
Date: Thu Aug 21 00:38:23 2014 +0100
coverity#1202729 - ensure we have exactly a one dimensional array.
Change-Id: I6db8a2fb48ed7ce134a5c45c590c2ada0e19fc85
diff --git a/basic/source/runtime/methods1.cxx
b/basic/source/runtime/methods1.cxx
index a4e1622..255ffd1 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -1714,6 +1714,7 @@ RTLFUNC(Join)
if( pArr-GetDims() != 1 )
{
StarBASIC::Error( SbERR_WRONG_DIMS ); // Syntax Error?!
+return;
}
OUString aDelim;
if( nParCount == 3 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source unotools/source
cui/source/dialogs/SpellDialog.cxx |2 +-
unotools/source/misc/fontdefs.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit ac57362b23859591c088e36b7218f4a606dcf3bb
Author: Julien Nabet serval2...@yahoo.fr
Date: Thu Aug 21 07:33:38 2014 +0200
Typo: and-end
Change-Id: I8c3707dbf537261d7ed9a69807fc1bdeae851526
diff --git a/cui/source/dialogs/SpellDialog.cxx
b/cui/source/dialogs/SpellDialog.cxx
index c38b033..a62e702 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -1544,7 +1544,7 @@ bool SentenceEditWindow_Impl::MarkNextError( bool
bIgnoreCurrentError, com::sun:
sal_uInt16 nTextLen = pTextEngine-GetTextLen(0);
if(m_nErrorEnd = nTextLen - 1)
return false;
-//if it's not already modified the modified flag has to be reset at the
and of the marking
+//if it's not already modified the modified flag has to be reset at the
end of the marking
bool bModified = IsModified();
bool bRet = false;
const sal_uInt16 nOldErrorStart = m_nErrorStart;
diff --git a/unotools/source/misc/fontdefs.cxx
b/unotools/source/misc/fontdefs.cxx
index 61f6a07..4a45fce 100644
--- a/unotools/source/misc/fontdefs.cxx
+++ b/unotools/source/misc/fontdefs.cxx
@@ -335,7 +335,7 @@ void GetEnglishSearchFontName( OUString rName )
// Remove Script at the end
// Scriptname must be the last part of the fontname and
// looks like fontname (scriptname). So there can only be a
-// script name at the and of the fontname, when the last char is ')'
+// script name at the end of the fontname, when the last char is ')'
if ( (nLen = 3) rName[ nLen-1 ] == ')' )
{
int nOpen = 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-qa] Suggestion for the use of pre-written responses
Hi All, Over the months of doing triaging, i've found that the best means of communicating with bug reporters is to have a set of pre-written responses to suit various common situations like confirming a bug, requesting a sample document, and asking for clear steps. These responses are very handy for the initial comment between me and the bug reporter, but do come in handy at other times as well, like requesting they reset their profile or send in a screencast. These responses have a simple and short format, similar to the below. -- Hello [user's name], Thank you for submitting the bug. I can confirm that the bug is available in 4.2.7, 4.3.2 and master on Linux. -- The primary message that i wanted to get across to the bug reporter is that we are welcoming and appreciate the effort they made in reporting the bug, as reporting a bug on BSA for the first time is a very length procedure. Then a few days ago, I got CCed on the comment from bug 76825 (comment 7) from an unhappy bug reporter whose bug was simply set as a duplicate without a response: -- don't ever bother dropping someone a mail or anything ... (like hi, thanks, we're already on it! - don't ever bother, really) cause we are machines or what ... or cogs in a big machine .) just go the beurocratic way, drop that person some cc :) it took me 15 minutes to report this bug ... i took it seriously, and i meant it ... but i'm sure i'll never do that again -- So i'd like to propose the creation a wiki page of pre-written responses that we can all use. I have created the wiki page at https://wiki.documentfoundation.org/QA/BugTriage/Pre-Written_Responses and will be adding entries to it, though i have very little knowledge of how best to format the page :D. Please add in your own collection of responses if you have. -- Regards, Jay Philips ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Suggestion for the use of pre-written responses
Hi, On Wed, Aug 20, 2014 at 04:35:52PM +0400, Jay Philips wrote: So i'd like to propose the creation a wiki page of pre-written responses that we can all use. I have created the wiki page at https://wiki.documentfoundation.org/QA/BugTriage/Pre-Written_Responses and will be adding entries to it, though i have very little knowledge of how best to format the page :D. Please add in your own collection of responses if you have. that is a great idea! Also we might later consider expending it to having them easily selectable from a pulldown etc. (either with e.g. greasemonkey or own-bugzilla), because as important as this is, I personally guess I will not look for the wikipage everytime for a drive-by confirm. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Suggestion for the use of pre-written responses
Hey there, Jay, *, Not sure that codifying a bunch of approved QA exchanges is in the best interest of moving the QA process along--especially if we have to dig them out of a WiKi. It would not do much to improve the QA flow, nor improve the readability of issues over their life span. Otherwise, during triage we should all strive to be courteous. By itself, the automated message delivered *** This bug has been marked as a duplicate of bug x *** is a bit too terse in closing a NEW issue as duplicate. But believe including a simple thank you for posting would suffice. If too many bugs like fdo#82701 are making it through, then the Bugzilla and BSA duplicate issue filters may need to be improved. I don't think he was trying to codify - maybe more just saying I'm posting these to the wiki - feel free to use (or not use) them at your pleasure :) I've thought of doing similar things with my auto responses but of course everyone can use their own methodology :) Best, Joel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Suggestion for the use of pre-written responses
Hi All, Yes similar to what joel stated, i'm just posting the ones i use on the wiki for others to use if they'd like and for those who have their own and would like to share them, that they'd have a centralized resource to post them to. I believe the wiki will also be a useful resource for new QA members to see what type of responses they are likely to have to respond with. I personally use my browser's (opera) inbuilt feature to save these responses and whiteboard keywords so i dont have to copy and paste them from a wiki page or text file. Hopefully something similar can be added into the new bugzilla for QA/dev team members can easily have access to as Bjoern suggested or until then, grabbing a browser extension which has a similar feature like JBF suggested. For all those chrome/chromium users, search the extension for clip or clipboard and there are quite a few of them listed there. Regards, Jay Philips On 08/20/2014 06:38 PM, Joel Madero wrote: Hey there, Jay, *, Not sure that codifying a bunch of approved QA exchanges is in the best interest of moving the QA process along--especially if we have to dig them out of a WiKi. It would not do much to improve the QA flow, nor improve the readability of issues over their life span. Otherwise, during triage we should all strive to be courteous. By itself, the automated message delivered *** This bug has been marked as a duplicate of bug x *** is a bit too terse in closing a NEW issue as duplicate. But believe including a simple thank you for posting would suffice. If too many bugs like fdo#82701 are making it through, then the Bugzilla and BSA duplicate issue filters may need to be improved. I don't think he was trying to codify - maybe more just saying I'm posting these to the wiki - feel free to use (or not use) them at your pleasure :) I've thought of doing similar things with my auto responses but of course everyone can use their own methodology :) Best, Joel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 80739] FILESAVE: Color filling of symbol changed
https://bugs.freedesktop.org/show_bug.cgi?id=80739 --- Comment #9 from raal r...@post.cz --- Created attachment 104937 -- https://bugs.freedesktop.org/attachment.cgi?id=104937action=edit printscreen from 4.4 I can reproduce with Version: 4.4.0.0.alpha0+ Build ID: e379401618268ed7f7f5885a36b90e1f4f6cd4af TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-08-18_05:51:03 After save - background color of symbols is changed. Symbols are grouped drawing objects. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80739] FILESAVE: Color filling of symbol changed
https://bugs.freedesktop.org/show_bug.cgi?id=80739 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71447] File menu takes long time to open
https://bugs.freedesktop.org/show_bug.cgi?id=71447 tommy27 ba...@quipo.it changed: What|Removed |Added OS|Windows (All) |All Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #17 from tommy27 ba...@quipo.it --- status NEW because of confirmation in the post above -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44580] share autocorrect replacement table for misc. language subgroups
https://bugs.freedesktop.org/show_bug.cgi?id=44580 --- Comment #19 from tommy27 ba...@quipo.it --- Created attachment 104939 -- https://bugs.freedesktop.org/attachment.cgi?id=104939action=edit autocorrect testkit Hi Julien, probably my test in comment 17 was not 100% accurate. try replicating this new experiment. a- download the attached .zip file which contains 3 minimal autocorrect .dat file 1- acor_und.dat it has a single entry: test → test1 it will apply in any document regardless the language since the acor_und.dat file is the global autocorrect list (you can find it at the top of the language dropdown list in the autocorrect replacement table under [All] (don't know how's localized in french) 2- acor_en-GB.dat it has a single entry: test → test2 it will apply only in document where the language is English(UK) 3- acor_en.dat it has a single entry: test → test3 it should apply in any document written in any of the English variants (UK, US, Australia etc.) b- place these 3 dat files in the autocorr subfolder of the user profile c- load a blank new Writer document and set the language as English(UK) d- type test and see how it gets autocorrected e- compare with my results with LibO 4.2.6.2 under Win7x64: - all 3 dat files present → test corrected into test2, so the localized variant acor_en-GB.dat rules over the acor_und.dat and acor_en.dat - remove the und.dat file → again you get test2, so the en-GB.dat wins over the en.dat - remove only the en-GB.dat file → you get test3 so the en.dat wins over the und.dat - remove both en-GB.dat and und.dat → again you get test3 since only en.dat is left - remove both en-GB.dat and en.dat → you get test1 since only und.dat is left so basically in case of autocorrect conflicts the “en-GB” list wins over the “en” list and over the “und” list. I agree this is the correct behavior since the language of the document should tell which is the first autocorrect list to look inside. f- same results if I rename those file to match italian locale (i.e. acor_it.dat and acor_it-IT.dat) and I write an italian(Italy) document. g- different results if you do the same trick with german or french locales. In those cases the renamed acor_de.dat and acor_fr.dat files will have no effect even if you remove the und.dat and the de-DE.dat and the fr-FR.dat files. So it seems that the unlocalized variant .dat files doesn't work in some language subgroups... this is strange and unconsistent with the results with Italian and English where it worked with no issue. Do you have any thoughts about that? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44580] share autocorrect replacement table for misc. language subgroups
https://bugs.freedesktop.org/show_bug.cgi?id=44580 --- Comment #20 from tommy27 ba...@quipo.it --- P.S. when you remove some .dat files as described in the tests above always remember to close LibO first and then restart the program again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
