[Libreoffice-bugs] [Bug 108279] export to xlsx shows only 65k rows when imported into SPSS
https://bugs.documentfoundation.org/show_bug.cgi?id=108279 Eike Rathkechanged: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Version|5.3.1.2 release |Inherited From OOo Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Ever confirmed|0 |1 OS|Windows (All) |All --- Comment #3 from Eike Rathke --- It's probably (can't check as I don't have SPSS) the element (here in ./xl/worksheets/sheet1.xml) that is instead of Apparently SPSS ignores any data beyond but sane applications don't. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107932] Export slide outline rather than slide titles in PDF index/ outline
https://bugs.documentfoundation.org/show_bug.cgi?id=107932 Yousuf Philips (jay)changed: What|Removed |Added CC|libreoffice-ux-advise@lists | |.freedesktop.org| Summary|Add option to export slide |Export slide outline rather |titles as PDF bookmarks |than slide titles in PDF |from Impress (in addition |index/outline |to current slide names) | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 107932] Export slide outline rather than slide titles in PDF index/ outline
https://bugs.documentfoundation.org/show_bug.cgi?id=107932 Yousuf Philips (jay)changed: What|Removed |Added CC|libreoffice-ux-advise@lists | |.freedesktop.org| Summary|Add option to export slide |Export slide outline rather |titles as PDF bookmarks |than slide titles in PDF |from Impress (in addition |index/outline |to current slide names) | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 68153] EDITING: Query input in foreignkey-field impossible, when two tables in the query.
https://bugs.documentfoundation.org/show_bug.cgi?id=68153 --- Comment #17 from Howard Johnson--- > > What were talking about here is the ability to edit many-to-one relations in > > queries, and in forms based on those queries. > > Not quite. I use several related data forms/subforms (within the same > document window) to edit stuff based on JOIN. Don't perform the JOIN in the > query itself, but through the "link master fields" and "link slave fields" > of data forms & subforms. As I pointed out before, forms/subforms deal with "has" relationships (main table has children; where FKs are in the children and point to the main table), not "is" relationships (where FKs are in the parents and points to enumerations). Also to be complete, you can use list-boxes in forms to edit "is" relationships, but because the underlying data is not what's getting edited that is another issue. > ... If the database engine that you use (such as > embedded HSQLDB 1.8, MySQL, PostgreSQL, ...) cannot do something, Base will > not do it for you. As I said before: MySQL can do this, and I can prove it because Access, when connected to MySQL, to the very same database and tables, can do this. Again to be clear I'm testing the exact same database and tables in Access as in LO Base. Access edits the FK, Base does not. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68153] EDITING: Query input in foreignkey-field impossible, when two tables in the query.
https://bugs.documentfoundation.org/show_bug.cgi?id=68153 --- Comment #16 from Howard Johnson--- (In reply to Lionel Elie Mamane from comment #10) Lionel, I'm sorry. It's true, there's a lot that I don't know about this code development process. I appreciate you taking a look at this and kicking this around with me. I don't personally have the skills to fix this, at least not yet. This is not the only bug I have noticed in this area, so if I can ever get into this stuff I hope to fix a number of things. I've got another related bug to soon submit when I get the chance which will help deal with many-to-many relationships. I suppose before anything like that can be done code-wise by me or anyone, it's my understanding that first the bugs need to be clearly fleshed out here in bugzilla, because what is changed is not up to me or any one person I don't think. So that's my goal today: further document this issue and ask for any other feedback. I do hope to move up to fixing code, and am working on getting there, but I'm not there yet. For now I can only notice, investigate, and report it as I am capable. Perhaps someday I can come back and fix this issue. I sure hope to. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-5.3.4.1'
Tag 'libreoffice-5.3.4.1' created by Christian Lohmaierat 2017-06-01 18:14 + Tag libreoffice-5.3.4.1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAABAgAGBQJZMFlsAAoJEPQ0oe+v7q6jfG8QAKx5/qJh+2VI/xQgFWe0z9kq buHR/31E4R77MNeOLNMcIuTCR4z2p0PH7VqomP5uPI/SNLonkkQAxVrUUyFtrNTe QimaB2vmD829DY80aF4BgVcv6E6pjmp/xgqpmH6PM+Xa2TcMDPF2FEF5FDAC8Wxp v6bOgcT6t1boYnqeJ/Wx68NNLYsuTXIwPWJ4dTJOsuYrW70Lhr7uNqlgmlRiii3z kLIWaZKDzOh+aE+ClCICe3lDGhkccvjC1Tfq4iTopBwKkczGjMxU2INYWRVeBvoX CzfeKjUhSs8jvrTDrYf7gSVS/KRrxMQN4C8qtHSp8Xz4cYfHIONP+7zaDj/TVB8K ZsujZUBmQA+Wu3eS/yHYP9aweNM/Pdvd7tEOzAhIl3T0pS30c/dVS2T+X350Pn2x SmNbjW977H0xUiMZOX6Zuygof02GZwgMtg3x9tKVpTeMiKflvlJ91KFptCBs8IhK uFXLYUJNNnLYe5KZ+Z+LUcRpWOoRP9/1VVxxruT6BiS/0ltbP7fNKrThwD/cqTdv RA/43wEh0wPpvr5x4dhnrcMvtbzRLQ1HXpAl2Jo80l1l6JK5Oztg968nwmEFMob1 L14bR/TOjtY2P4tvd5zI/6iBXoVOGpBXXnnY/1u11hyqNMJMINNFq35JvawFgnrL VxTSA2DF0iD+Xp8XkyNm =5rAM -END PGP SIGNATURE- Changes since cp-5.3-15-2: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-5.3.4.1'
Tag 'libreoffice-5.3.4.1' created by Christian Lohmaierat 2017-06-01 18:14 + Tag libreoffice-5.3.4.1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAABAgAGBQJZMFlpAAoJEPQ0oe+v7q6jnkUQAJesVAyUvuP9TP/zRfz7vDjW G4keWM+6ceWb15lb7wD1jcHZenasMHMtCz6W9UTD50OsFWqlrFxPElV5sStWzD5P TxCbggYE7uUDFEOhbFbXhH08ep7WIdW80OIdFBXM9SlFt1hdRoMHqZrWF/RsNL17 UHbLxzfgMRp+M9evZH3q9iaL8Go7JiR1Ym8I21IvqHRTmk0Grfc1hFT+chhgPjqB hZC1TsumUkUw1fhVEi+O1LKpiwsEd0ror8DxQxnlQpxiWNXuj28nBkgv89+YXxGn 3xBFUA1I8MnQsNBXQxL+INKFeroV3do8Cdv17FHqWGfRs712DFY7+cH3VLwpI3KU 8NCIeVRTTtR0zfhRAdYfJtuO2wheD3a1jD/yylTfijR+DSmaE3cEASQ9kUDlmOBh WHySNScX4f8S0tkGh9sOghPvQZhT4FRffEMGkieB0ATlw4TRd0eMV8oQ8rmVrIRz eoYigQfxsjouoDqNRuEZY0REkHpjQBDdn31/lTTZTdbkqcPeVJPipwXVoJ3KrXBC Aa2C0mtVeCvRts9WcjxCHx4vl8lVelNU7/plnHFu49ZILDiXmhbiAqzW/Bs7cH4H lMwhNO1CapGorubgWzl89M97SxV2SJJNI4GUO3oQFGz/JtEuj9H6hBmIh5qMqLWC zM+HaBo5BzHZ26bNkgsc =KGkR -END PGP SIGNATURE- Changes since cp-5.3-15-1: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-5.3.4.1'
Tag 'libreoffice-5.3.4.1' created by Christian Lohmaierat 2017-06-01 18:13 + Tag libreoffice-5.3.4.1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAABAgAGBQJZMFllAAoJEPQ0oe+v7q6jGzIP/0A5Vv258dPckUuwMiuLSBlS qwnowRCt5fQJBRK/maHDgnUtfrjjXrSciTIHOLWl2C5dnV8/n2vFwP56ZmW+S4Nd bzhHi1RDjF6z9z9PlkSD+xHCWB75WjfDklb3JEk1ueATSA+fnPnnhkLZC+0iRsGK cUSv4V97HjY+cU9Pkm5CBtWWzYNhobKRoNRs8KLDq1RzvQxfScAKaVY+voVdqTaM mgM6HJ8+/0RAn0C1pBRjkngCHzmKRBvhx1qYhfGzqseNK0pjcYwos0P7kb5Gxuhg YMleQ7nxmJ8PLb4L262iPFGEvnyDXd+Ss3PnI+jAPPt1yx9ZmducSsPygH0GUeLh 7Wzzaj1LRKBrcGHWH5E76gf8sZrPynj0Swr979Mc2McKeb4B6u14uoneomrXUt/S S6kiUT23urPJ69RivDA50JvtXssJW+f/Gi52QyR9UpJQrAp5mVhx+Iz+9uogXX8Z td9PErTyEUULvyJT7wQnJIhuAJIjOEfnv4bMd2aaRovXhLkX8JMKcfMoAD7DpxZn 5206SUjwQlwVYbeDLa1ICCxGgG7c8wxvTZxJmMLnsujr9zR/gM5+mgSIA7+5dT3P n6MZrhvNXXLd4jILj7xZ9mkQy+dt6KbYQ7JHXJng84V+tT32phakpGvCF5/+ZgOU 6q4pHOh+MHTs9knMh5dI =Uo4w -END PGP SIGNATURE- Changes since cp-5.3-15-1: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-5.3.4.1'
Tag 'libreoffice-5.3.4.1' created by Christian Lohmaierat 2017-06-01 18:14 + Tag libreoffice-5.3.4.1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAABAgAGBQJZMFlvAAoJEPQ0oe+v7q6j9YgP/2P5L7UgsiKnB14U+p84ovxg QpF7blGhTmKqCj7pLaxwUDCIEmTCAqeIi5FX5vGgY6gbe+uSqyElgKkYo8V4IzSb iKOCpnblUNZuXiA0vPVsF3rqw48WvKpx+M7F/YyuOUbaN8sOKB7+z1ByTmZjYa85 1UnjFwCF+Ko0L38iH+zgCU+xWHkKNWotFTT0myEYNUUUqL3W+6E/y2Z1dJNbc077 K2gtV7wAe+wwb8SZxk3CGNwR7g4WyQIQjX8Wtcsk/42lPs1sTnMgNRl/KbK9+/58 v1KiMZvFUKCJSGmqnteieJRc4Qh8vl4/I68OTuplPIUZ/Kb1G4cM6acZNZn5n4YN WH+/8HBK35ZgGGNMP0hoJpoOQlSTfixgimSWfR24ZeK4GS364yxy8kwt2aT9Hnoq o4ZADsKtVmtGjKoOKnKV3YK507Wa5P+r9+3YIyqe5db0dCRZlEKvyrS0bP7LgoQ4 ux+dQl9taWHKg8bE54eNKt8gbDFQ6u9R4WTlWnfn88TZqZTIPnM36oRGeUQ5udgO AEk/480xq08XcwxPx/gZaIcy96hZ0yXY1MhaMBrhaRrH2ycpsp+XhxAlaKIR6wLg Wi7v+8C6ALHNz9u08gRsRngti9z8ibsYAry0gVgxDwtNcOD0gtZSD2HIxB4uYXaG EL9zpCWLSbOn9AS54Rmn =Effl -END PGP SIGNATURE- Changes since cp-5.3-branch-point-346: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3-4' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c844353678581b4b6c9358a94541dbb3e4b7127b Author: Christian LohmaierDate: Thu Jun 1 20:14:42 2017 +0200 bump product version to 5.3.4.1.0+ Change-Id: Ib1e4717cf67604fd09c20ba74fdaa6b1683cee7b diff --git a/configure.ac b/configure.ac index 81334913e282..cdd7ebf7793f 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[5.3.4.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[5.3.4.1.0+],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'libreoffice-5-3-4'
New branch 'libreoffice-5-3-4' available with the following commits: commit 75a156c9c12c537e2dfa0c6fbb4c64d089a236b2 Author: Christian LohmaierDate: Thu Jun 1 20:10:38 2017 +0200 Branch libreoffice-5-3-4 This is 'libreoffice-5-3-4' - the stable branch for the 5.3.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.3.x release, please use the 'libreoffice-5-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I630fd949dbe84d3cfb7af67a1f348be984fda11e ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3831605e0ec55a3dab4090449d495b142a33c2c7 Author: Christian LohmaierDate: Thu Jun 1 20:12:01 2017 +0200 bump product version to 5.3.5.0.0+ Change-Id: Ifb8a0d553437b8da598d9841de96859b009d8962 diff --git a/configure.ac b/configure.ac index 81334913e282..6032e56d29e9 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[5.3.4.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[5.3.5.0.0+],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'libreoffice-5-3-4'
New branch 'libreoffice-5-3-4' available with the following commits: commit daae0818b78b46241186681876a39758b6e1b345 Author: Christian LohmaierDate: Thu Jun 1 20:10:05 2017 +0200 Branch libreoffice-5-3-4 This is 'libreoffice-5-3-4' - the stable branch for the 5.3.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.3.x release, please use the 'libreoffice-5-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I24f16b8c93656079b3edca4671324381426935be ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'libreoffice-5-3-4'
New branch 'libreoffice-5-3-4' available with the following commits: commit 29fec7b242217450fd63caf539e917beff73d530 Author: Christian LohmaierDate: Thu Jun 1 20:10:05 2017 +0200 Branch libreoffice-5-3-4 This is 'libreoffice-5-3-4' - the stable branch for the 5.3.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.3.x release, please use the 'libreoffice-5-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I608259e8e7d79f08d4ef7ead1059c1683c8d09db ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-5-3-4'
New branch 'libreoffice-5-3-4' available with the following commits: commit 6224f202ffeb70e1459a6e0c5bae34d86b832f34 Author: Christian LohmaierDate: Thu Jun 1 20:10:05 2017 +0200 Branch libreoffice-5-3-4 This is 'libreoffice-5-3-4' - the stable branch for the 5.3.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.3.x release, please use the 'libreoffice-5-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Ia4e4ecd52534d2e0a1b89bd6593f50fff1e08ec0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 68153] EDITING: Query input in foreignkey-field impossible, when two tables in the query.
https://bugs.documentfoundation.org/show_bug.cgi?id=68153 --- Comment #15 from Howard Johnson--- (In reply to Lionel Elie Mamane from comment #10) > I'm curious what meaning you will ascribe to editing the foreign key. I uploaded a new very simple demonstration of this issue. Open the query. Try to edit the FK field and change 0 to 1, or 1 to 0 and you see an error message. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45589] Show bookmarks: make them visible in a document
https://bugs.documentfoundation.org/show_bug.cgi?id=45589 Yousuf Philips (jay)changed: What|Removed |Added Blocks||108288 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108288 [Bug 108288] [META] Bookmark bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87610] UNO: Duplication of .uno:InsertBookmark as .uno:InsertAnchor
https://bugs.documentfoundation.org/show_bug.cgi?id=87610 Yousuf Philips (jay)changed: What|Removed |Added Blocks||108288 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108288 [Bug 108288] [META] Bookmark bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89568] Ability to view bookmark/anchor locations in a document
https://bugs.documentfoundation.org/show_bug.cgi?id=89568 Yousuf Philips (jay)changed: What|Removed |Added Blocks||108288 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108288 [Bug 108288] [META] Bookmark bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108288] [META] Bookmark bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108288 Yousuf Philips (jay)changed: What|Removed |Added Depends on||87610, 89568, 90855, 45589 Alias||Bookmarks Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=45589 [Bug 45589] Show bookmarks: make them visible in a document https://bugs.documentfoundation.org/show_bug.cgi?id=87610 [Bug 87610] UNO: Duplication of .uno:InsertBookmark as .uno:InsertAnchor https://bugs.documentfoundation.org/show_bug.cgi?id=89568 [Bug 89568] Ability to view bookmark/anchor locations in a document https://bugs.documentfoundation.org/show_bug.cgi?id=90855 [Bug 90855] DIALOG: Improve the 'Insert Bookmark' dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Yousuf Philips (jay)changed: What|Removed |Added Depends on||86395 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86395 [Bug 86395] Allow sorting of bookmarks in the navigator in two ways: alphabetically and by order in document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86395] Allow sorting of bookmarks in the navigator in two ways: alphabetically and by order in document
https://bugs.documentfoundation.org/show_bug.cgi?id=86395 Yousuf Philips (jay)changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Blocks||103030 OS|Linux (All) |All Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103030 [Bug 103030] [META] Navigator sidebar deck and floating window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86395] Allow sorting of bookmarks in the navigator in two ways: alphabetically and by order in document
https://bugs.documentfoundation.org/show_bug.cgi?id=86395 Yousuf Philips (jay)changed: What|Removed |Added Blocks||108288 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108288 [Bug 108288] [META] Bookmark bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108288] [META] Bookmark bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108288 Yousuf Philips (jay)changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||c...@nouenoff.nl, ||vstuart.fo...@utsa.edu Version|Master old -3.6|Inherited From OOo Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78779] PDF: Bookmarks not exported as described
https://bugs.documentfoundation.org/show_bug.cgi?id=78779 Yousuf Philips (jay)changed: What|Removed |Added Blocks||108288 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108288 [Bug 108288] [META] Bookmark bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108288] New: [META] Bookmark bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108288 Bug ID: 108288 Summary: [META] Bookmark bugs and enhancements Product: LibreOffice Version: Master old -3.6 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Depends on: 78779, 86395 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=78779 [Bug 78779] PDF: Bookmarks not exported as described https://bugs.documentfoundation.org/show_bug.cgi?id=86395 [Bug 86395] Allow sorting of bookmarks in the navigator in two ways: alphabetically and by order in document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108279] export to xlsx shows only 65k rows when imported into SPSS
https://bugs.documentfoundation.org/show_bug.cgi?id=108279 Eike Rathkechanged: What|Removed |Added Attachment #133782|application/zip |application/vnd.openxmlform mime type||ats-officedocument.spreadsh ||eetml.sheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108279] export to xlsx shows only 65k rows when imported into SPSS
https://bugs.documentfoundation.org/show_bug.cgi?id=108279 Eike Rathkechanged: What|Removed |Added Attachment #133781|application/zip |application/vnd.openxmlform mime type||ats-officedocument.spreadsh ||eetml.sheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108287] New: EDITING: Changing the background color in calc is slower than in previous versions
https://bugs.documentfoundation.org/show_bug.cgi?id=108287 Bug ID: 108287 Summary: EDITING: Changing the background color in calc is slower than in previous versions Product: LibreOffice Version: 5.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Changing the background color in calc is slower than in previous versions Steps to Reproduce: 1. Open attachment 133790 2. Press CTRL+A and wait until toolbar is responsive 3. The color picker for the background in the toolbar, choose some color and apply.. take notice of time required Actual Results: It takes around 13 seconds to change to background color Expected Results: With LibO5.2.5.0.0+ just 3 seconds is needed Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 5.5.0.0.alpha0+ Build ID: ec79f3453471ee9b6ae32e71ff16ea99d9b7751c CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-05-28_23:21:44 Locale: nl-NL (nl_NL); Calc: CL and in Versie: 5.4.0.0.beta1 Build ID: 8672113ead4e403c55e31b1d9a3d1e0f3b299577 CPU-threads: 4; Besturingssysteem:Windows 6.2; UI-render: standaard; Locale: nl-NL (nl_NL); Calc: CL but not in Version: 5.2.5.0.0+ Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8 CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time: 2016-12-24_14:43:55 Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 107932] Add option to export slide titles as PDF bookmarks from Impress ( in addition to current slide names)
https://bugs.documentfoundation.org/show_bug.cgi?id=107932 --- Comment #8 from Yousuf Philips (jay)--- (In reply to Heiko Tietze from comment #7) > And the label should reflect the function and get changed to > "Export outlines" (also in other modules). In writer this doesnt change as writer always exports the outline with the checkbox enabled or not, but presently it doesnt even export bookmarks when it is checked (bug 78779). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 107932] Add option to export slide titles as PDF bookmarks from Impress ( in addition to current slide names)
https://bugs.documentfoundation.org/show_bug.cgi?id=107932 --- Comment #8 from Yousuf Philips (jay)--- (In reply to Heiko Tietze from comment #7) > And the label should reflect the function and get changed to > "Export outlines" (also in other modules). In writer this doesnt change as writer always exports the outline with the checkbox enabled or not, but presently it doesnt even export bookmarks when it is checked (bug 78779). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - icon-themes/sifr
0 files changed New commits: commit 373c5775735858138a461548272175b3141a3e37 Author: Matthias FreundDate: Thu Jun 1 18:46:08 2017 +0200 tdf#75256 sifr icon theme - trackchangesbar Fix for wrong filename for trackchangesbar Change-Id: I3a286c87b6ca9e01a8e256acde00715a84f7b4d9 Reviewed-on: https://gerrit.libreoffice.org/38323 Reviewed-by: Yousuf Philips Tested-by: Yousuf Philips diff --git a/icon-themes/sifr/cmd/lc_showtrackchanges.png b/icon-themes/sifr/cmd/lc_trackchangesbar.png similarity index 100% rename from icon-themes/sifr/cmd/lc_showtrackchanges.png rename to icon-themes/sifr/cmd/lc_trackchangesbar.png diff --git a/icon-themes/sifr/cmd/sc_showtrackchanges.png b/icon-themes/sifr/cmd/sc_trackchangesbar.png similarity index 100% rename from icon-themes/sifr/cmd/sc_showtrackchanges.png rename to icon-themes/sifr/cmd/sc_trackchangesbar.png ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - icon-themes/sifr
0 files changed New commits: commit d965c7164e3de2a2bc3255dae25836d68b25dd3e Author: Matthias FreundDate: Thu Jun 1 18:46:08 2017 +0200 tdf#75256 sifr icon theme - trackchangesbar Fix for wrong filename for trackchangesbar Change-Id: I3a286c87b6ca9e01a8e256acde00715a84f7b4d9 Reviewed-on: https://gerrit.libreoffice.org/38322 Reviewed-by: Yousuf Philips Tested-by: Yousuf Philips diff --git a/icon-themes/sifr/cmd/lc_showtrackchanges.png b/icon-themes/sifr/cmd/lc_trackchangesbar.png similarity index 100% rename from icon-themes/sifr/cmd/lc_showtrackchanges.png rename to icon-themes/sifr/cmd/lc_trackchangesbar.png diff --git a/icon-themes/sifr/cmd/sc_showtrackchanges.png b/icon-themes/sifr/cmd/sc_trackchangesbar.png similarity index 100% rename from icon-themes/sifr/cmd/sc_showtrackchanges.png rename to icon-themes/sifr/cmd/sc_trackchangesbar.png ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/sifr
0 files changed New commits: commit 6d4a283083e4d53d913a713d81824d61d90c1279 Author: Matthias FreundDate: Thu Jun 1 18:46:08 2017 +0200 tdf#75256 sifr icon theme - trackchangesbar Fix for wrong filename for trackchangesbar Change-Id: I3a286c87b6ca9e01a8e256acde00715a84f7b4d9 Reviewed-on: https://gerrit.libreoffice.org/38321 Tested-by: Jenkins Reviewed-by: Yousuf Philips diff --git a/icon-themes/sifr/cmd/lc_showtrackchanges.png b/icon-themes/sifr/cmd/lc_trackchangesbar.png similarity index 100% rename from icon-themes/sifr/cmd/lc_showtrackchanges.png rename to icon-themes/sifr/cmd/lc_trackchangesbar.png diff --git a/icon-themes/sifr/cmd/sc_showtrackchanges.png b/icon-themes/sifr/cmd/sc_trackchangesbar.png similarity index 100% rename from icon-themes/sifr/cmd/sc_showtrackchanges.png rename to icon-themes/sifr/cmd/sc_trackchangesbar.png ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/inc/interpre.hxx |2 +- sc/source/core/tool/interpr1.cxx | 18 ++ 2 files changed, 15 insertions(+), 5 deletions(-) New commits: commit 41ba5f649f361bfa6965a7c8f2e2ffa084317c45 Author: Eike RathkeDate: Thu Jun 1 19:46:27 2017 +0200 Perf: do not calculate a null-operation with the result matrix, tdf#58874 Change-Id: I6fe115ff7ec7960900863ddaf1cd1dc48975fd74 diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx index 53190038bd9b..9b36afec2e05 100644 --- a/sc/source/core/inc/interpre.hxx +++ b/sc/source/core/inc/interpre.hxx @@ -575,7 +575,7 @@ size_t GetRefListArrayMaxSize( short nParamCount ); /** Switch to array reference list if current TOS is one and create/init or update matrix and return true. Else return false. */ bool SwitchToArrayRefList( ScMatrixRef& xResMat, SCSIZE nMatRows, double fCurrent, -const std::function & MatOpFunc ); +const std::function & MatOpFunc, bool bDoMatOp ); void IterateParameters( ScIterFunc, bool bTextAsZero = false ); void ScSumSQ(); void ScSum(); diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index 845be4b5e523..0d75c3f79834 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -3457,7 +3457,7 @@ void ScInterpreter::ScUnichar() } bool ScInterpreter::SwitchToArrayRefList( ScMatrixRef& xResMat, SCSIZE nMatRows, double fCurrent, -const std::function & MatOpFunc ) +const std::function & MatOpFunc, bool bDoMatOp ) { const ScRefListToken* p = dynamic_cast(pStack[sp-1]); if (!p || !p->IsArrayResult()) @@ -3470,7 +3470,7 @@ bool ScInterpreter::SwitchToArrayRefList( ScMatrixRef& xResMat, SCSIZE nMatRows, xResMat = GetNewMat( 1, nMatRows, true); xResMat->FillDouble( fCurrent, 0,0, 0,nMatRows-1); } -else +else if (bDoMatOp) { // Current value and values from vector are operands // for each vector position. @@ -3533,8 +3533,13 @@ void ScInterpreter::ScMin( bool bTextAsZero ) break; case svRefList : { -if (SwitchToArrayRefList( xResMat, nMatRows, nMin, MatOpFunc)) +// bDoMatOp only for non-array value when switching to +// ArrayRefList. +if (SwitchToArrayRefList( xResMat, nMatRows, nMin, MatOpFunc, +nRefArrayPos == std::numeric_limits::max())) +{ nRefArrayPos = nRefInList; +} } SAL_FALLTHROUGH; case svDoubleRef : @@ -3683,8 +3688,13 @@ void ScInterpreter::ScMax( bool bTextAsZero ) break; case svRefList : { -if (SwitchToArrayRefList( xResMat, nMatRows, nMax, MatOpFunc)) +// bDoMatOp only for non-array value when switching to +// ArrayRefList. +if (SwitchToArrayRefList( xResMat, nMatRows, nMax, MatOpFunc, +nRefArrayPos == std::numeric_limits::max())) +{ nRefArrayPos = nRefInList; +} } SAL_FALLTHROUGH; case svDoubleRef : ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108286] New: Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=108286 Bug ID: 108286 Summary: Crash in: mergedlo.dll Product: LibreOffice Version: 5.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: critical Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Created attachment 133790 --> https://bugs.documentfoundation.org/attachment.cgi?id=133790=edit Example file This bug was filed from the crash reporting server and is br-a0350f40-6694-4d22-9965-1c050b71dd48. = 1. Open the attached file 2. Choose File -> Reload 3. Close Calc while loading the file (using red cross or gray cross) 4. Calc will crash; with the gray cross it will take a little longer) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94464] Text Body default line spacing too big ( proportional 120% instead of Single )
https://bugs.documentfoundation.org/show_bug.cgi?id=94464 --- Comment #24 from V Stuart Foote--- (In reply to Yousuf Philips (jay) from comment #22) > > though i would minus 1 from it so we could go for 1.15 like other apps. > ... > > Took Cor's doc and modified it to include the range between 1.00 and 1.20 so > we can compare the sizes. I think 1.10 and 1.15 have the good amount of > space to not feel to camped or to large. If we like the 115 for Text Body, rather than User/Proportional with a default of 115--it would make more sense to just use the "1.15" and cleanup the DocumentStylePoolManager template, assigning the LINESPACE_115 var and allowing the listbox to populate with the LLINESPACE_115 definition and its enum to use the "1.15 Lines" label. But, I would still prefer cutting back to Single space, i.e. 100--for the general use case for Text Body--it is what users are used to from the Default style which has always used that as a starting point. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108284] FILEOPEN ODS: Opening is slower as it used to be in earlier releases
https://bugs.documentfoundation.org/show_bug.cgi?id=108284 Xisco Faulíchanged: What|Removed |Added Keywords||bibisectRequest, perf, ||regression Version|5.2.5.1 release |5.2.0.0.alpha1 --- Comment #3 from Xisco Faulí --- Reproduced in - Version: 5.2.0.0.alpha1+ Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; Locale: ca-ES (ca_ES.UTF-8) real1m13.821s user0m57.120s sys 0m0.360s but not in - Version: 5.0.0.0.alpha1+ Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86 Locale: ca-ES (ca_ES.UTF-8) real0m20.029s user0m19.648s sys 0m0.184s -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] translations.git: Branch 'libreoffice-5-3' - source/af source/am source/ar source/as source/ast source/be source/bg source/bn source/bn-IN source/bo source/br source/brx source/b
source/af/cui/uiconfig/ui.po | 150 source/am/cui/uiconfig/ui.po | 150 source/ar/cui/uiconfig/ui.po | 151 source/as/cui/uiconfig/ui.po | 165 source/ast/cui/uiconfig/ui.po | 165 source/be/cui/uiconfig/ui.po | 165 source/bg/cui/uiconfig/ui.po | 156 source/bg/helpcontent2/source/text/shared/01.po |8 source/bg/sc/uiconfig/scalc/ui.po |6 source/bg/sw/source/uibase/utlui.po |8 source/bn-IN/cui/uiconfig/ui.po | 160 source/bn/cui/uiconfig/ui.po | 150 source/bo/cui/uiconfig/ui.po | 150 source/br/cui/uiconfig/ui.po | 152 source/br/extensions/source/propctrlr.po | 110 source/br/officecfg/registry/data/org/openoffice/Office.po| 10 source/br/officecfg/registry/data/org/openoffice/Office/UI.po | 88 source/brx/cui/uiconfig/ui.po | 150 source/bs/cui/uiconfig/ui.po | 165 source/ca-valencia/cui/uiconfig/ui.po | 160 source/ca/cui/uiconfig/ui.po | 150 source/ca/helpcontent2/source/text/smath.po | 10 source/ca/officecfg/registry/data/org/openoffice/Office/UI.po |6 source/ca/sc/uiconfig/scalc/ui.po |6 source/ca/sfx2/source/view.po |7 source/ca/svx/uiconfig/ui.po |8 source/ca/sw/uiconfig/swriter/ui.po |6 source/cs/cui/uiconfig/ui.po | 148 source/cs/svx/source/items.po | 10 source/cy/cui/uiconfig/ui.po | 150 source/da/cui/uiconfig/ui.po | 150 source/da/helpcontent2/source/text/shared/optionen.po | 10 source/de/cui/uiconfig/ui.po | 162 source/de/dbaccess/source/ui/dlg.po |8 source/de/filter/source/pdf.po| 12 source/de/helpcontent2/source/auxiliary.po|8 source/de/helpcontent2/source/text/sbasic/shared.po | 20 source/de/helpcontent2/source/text/sbasic/shared/01.po| 10 source/de/helpcontent2/source/text/scalc/01.po| 80 source/de/helpcontent2/source/text/scalc/guide.po | 60 source/de/helpcontent2/source/text/schart/01.po | 12 source/de/helpcontent2/source/text/schart/04.po | 10 source/de/helpcontent2/source/text/sdraw/guide.po | 14 source/de/helpcontent2/source/text/shared/00.po | 42 source/de/helpcontent2/source/text/shared/01.po | 100 source/de/helpcontent2/source/text/shared/02.po | 84 source/de/helpcontent2/source/text/shared/04.po | 32 source/de/helpcontent2/source/text/shared/05.po |6 source/de/helpcontent2/source/text/shared/autopi.po | 14 source/de/helpcontent2/source/text/shared/explorer/database.po| 54 source/de/helpcontent2/source/text/shared/guide.po| 112 source/de/helpcontent2/source/text/shared/optionen.po | 64 source/de/helpcontent2/source/text/simpress/01.po | 10 source/de/helpcontent2/source/text/simpress/guide.po |8 source/de/helpcontent2/source/text/smath/01.po| 42 source/de/helpcontent2/source/text/swriter.po |8 source/de/helpcontent2/source/text/swriter/01.po | 20 source/de/helpcontent2/source/text/swriter/04.po |8 source/de/helpcontent2/source/text/swriter/guide.po | 22 source/de/helpcontent2/source/text/swriter/librelogo.po |6 source/de/instsetoo_native/inc_openoffice/windows/msi_languages.po|6 source/de/officecfg/registry/data/org/openoffice/Office/UI.po | 10 source/de/readlicense_oo/docs.po | 12
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dd4c9b3ff347507e47006c0612942796bf297d2b Author: Christian LohmaierDate: Thu Jun 1 19:11:16 2017 +0200 Updated core Project: translations bdbcd4decf1ae9699ebffa6aa8c6e3f1c6cb41a0 update translations for 5.3.4 rc1 and force-fix errors using pocheck Change-Id: I0b1e1ccf9d04d9bad6bcab4c1800f8fe223af73f diff --git a/translations b/translations index 7439773399c3..bdbcd4decf1a 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 7439773399c3b11904cf66e4b24afc7c3c070376 +Subproject commit bdbcd4decf1ae9699ebffa6aa8c6e3f1c6cb41a0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108284] FILEOPEN ODS: Opening is slower as it used to be in earlier releases
https://bugs.documentfoundation.org/show_bug.cgi?id=108284 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- Confirmed in Version: 5.5.0.0.alpha0+ Build ID: 9956849c2ea6049582e2ccf04c355542c1ef00a1 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group time real1m6.849s user1m10.896s sys 0m1.140s Version: 4.3.0.0.alpha1+ Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e time real0m20.337s user0m19.740s sys 0m0.176s -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/create-ids |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9c32973e0ea91fbc1d9eb7daa55967c4a18f3f72 Author: Eike RathkeDate: Thu Jun 1 19:18:23 2017 +0200 For --with-outpath include workdir generated files without UnpackedTar* Change-Id: I07605c132432cb9454614368200e9c85695bea26 diff --git a/solenv/bin/create-ids b/solenv/bin/create-ids index a6a2c1f57f80..67f35d17c942 100755 --- a/solenv/bin/create-ids +++ b/solenv/bin/create-ids @@ -9,9 +9,9 @@ # create ID file for the whole LibO tree. run it in toplevel dir -# TODO: should this include workdir headers? if [ "$1" = "--with-outpath" ]; then -dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(workdir\|instdir\)\//d')" +# Include workdir generated files but without workdir/UnpackedTarball workdir/UnpackedTarget +dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(workdir\/UnpackedTar\|\(instdir\/\)\)/d')" else dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(workdir\|instdir\)\//d')" fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 68153] EDITING: Query input in foreignkey-field impossible, when two tables in the query.
https://bugs.documentfoundation.org/show_bug.cgi?id=68153 --- Comment #14 from Howard Johnson--- Created attachment 133789 --> https://bugs.documentfoundation.org/attachment.cgi?id=133789=edit HSQLDB example demonstrating this issue: 2 tables & query w/ uneditable FK Open the query. Try to change the *FK field in an existing record from 0 to 1 or 1 to 0. What should happen is that it should be changed. What happens is you get an error message: "Error updating the current record". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/create-ids |4 ++-- solenv/bin/create-tags |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 6e79d226f49494d425d946f542ef834ad62da9f7 Author: Eike RathkeDate: Thu Jun 1 19:00:11 2017 +0200 'clone' directory is gone and might even be a legit module name in future Change-Id: Iba0cf3345655a8ca61a4d55b9f045c713683f97b diff --git a/solenv/bin/create-ids b/solenv/bin/create-ids index 702c951eb413..a6a2c1f57f80 100755 --- a/solenv/bin/create-ids +++ b/solenv/bin/create-ids @@ -11,8 +11,8 @@ # TODO: should this include workdir headers? if [ "$1" = "--with-outpath" ]; then -dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(clone\|workdir\|instdir\)\//d')" +dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(workdir\|instdir\)\//d')" else -dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(clone\|workdir\|instdir\)\//d')" +dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(workdir\|instdir\)\//d')" fi mkid --lang-map="$(dirname "$0")"/id-lang.map --include='C C++ asm perl java make' --statistics $dirs diff --git a/solenv/bin/create-tags b/solenv/bin/create-tags index 47400f55c68d..994aa1686c02 100755 --- a/solenv/bin/create-tags +++ b/solenv/bin/create-tags @@ -18,7 +18,7 @@ omnicppoptions="--c++-kinds=+p --fields=+iaS --extra=+q" $ctags -h "+.hdl.hrc" --langmap=c:+.hrc.src,c++:+.hdl $saloptions $omnicppoptions \ --languages=-HTML,Java,JavaScript \ -R --exclude=instdir --exclude=instdir_for_build --exclude=workdir --exclude=workdir_for_build \ - --exclude=clone --exclude=external --totals=yes ${SRCDIR:-*} + --exclude=external --totals=yes ${SRCDIR:-*} if test -d workdir_for_build; then w=workdir_for_build ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108285] New: FILEOPEN ODS: The source ODS file opens far slower than the exported XLSX
https://bugs.documentfoundation.org/show_bug.cgi?id=108285 Bug ID: 108285 Summary: FILEOPEN ODS: The source ODS file opens far slower than the exported XLSX Product: LibreOffice Version: 4.4.6.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: The source ODS file opens far slower than the exported XLSX Steps to Reproduce: 1. Open attachment 133788 (bug 108284) 2. Save it as a xlsx file 3. Open both documents and compare the opening speed Actual Results: The opening of the ODS file takes around 16 seconds in Lib0 4.4.6.3 Opening the xlsx is a lot faster (8 seconds) Expected Results: Should be similar in my opinion Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 5.5.0.0.alpha0+ Build ID: ec79f3453471ee9b6ae32e71ff16ea99d9b7751c CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-05-28_23:21:44 Locale: nl-NL (nl_NL); Calc: CL and in Versie: 4.4.6.3 Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d Locale: nl_NL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108283] Start animation by clicking a drawn shape in ubuntu 17
https://bugs.documentfoundation.org/show_bug.cgi?id=108283 --- Comment #2 from pao--- The animation starts in presentation mode only if I left mouse click on the slide and set up "use mouse as pen" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/create-ids |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 090e33dfece35b9f2ff7248b9ef947317392bab9 Author: Eike RathkeDate: Thu Jun 1 18:44:17 2017 +0200 Fix 'make id' further to not include workdir and instdir again as ls output is now prefixed with ./ since commit 027d661ef7e2490f1182d3e5003ae4da4135e0ca Date: Fri May 19 18:03:04 2017 +0300 Change-Id: Ifd2b6405cb4670a7ae4e21228d29fae5b7408112 diff --git a/solenv/bin/create-ids b/solenv/bin/create-ids index de1e79155c87..702c951eb413 100755 --- a/solenv/bin/create-ids +++ b/solenv/bin/create-ids @@ -11,8 +11,8 @@ # TODO: should this include workdir headers? if [ "$1" = "--with-outpath" ]; then -dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\(clone\|workdir\|instdir\)\//d')" +dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(clone\|workdir\|instdir\)\//d')" else -dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\(clone\|workdir\|instdir\)\//d')" +dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\.\/\(clone\|workdir\|instdir\)\//d')" fi mkid --lang-map="$(dirname "$0")"/id-lang.map --include='C C++ asm perl java make' --statistics $dirs ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94632] Light sifr and breeze icon themes for dark OS themes
https://bugs.documentfoundation.org/show_bug.cgi?id=94632 --- Comment #28 from Yousuf Philips (jay)--- (In reply to steve -_- from comment #27) > Not sure. Attaching screenshot of what breeze dark icon set looks like. > Maybe expected? Do users have to manually switch the background? If so, I > would not consider this solved. But maybe can also be dealt with in > additional bugs. Yes its for breeze for dark themes, so that is what is expected, as regular breeze is for light themes. > 1. dark OS theme: macOS has an option to use a dark menubar and dock (in > system preferences > general) but that's it. I am not sure if that can be > considered a dark OS mode. Guess it could. So should LO pick up on that? Or > what is the idea? Reading this bugs title it sounds like it should. Guess it wont be useful on mac if it doesnt allow users to use a dark theme. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src wsd/DocumentBroker.cpp
loleaflet/src/core/Socket.js |3 +++ wsd/DocumentBroker.cpp |8 +++- 2 files changed, 6 insertions(+), 5 deletions(-) New commits: commit a0710c9613309cb7be2934e8eedc75507185b87f Author: Pranav KantDate: Thu Jun 1 22:02:08 2017 +0530 Inform the current session about document change too Change-Id: I9947eb8b23e5a698cc2cbf39bfde4e1941aae0f0 diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js index e1cfde78..c0b53dca 100644 --- a/loleaflet/src/core/Socket.js +++ b/loleaflet/src/core/Socket.js @@ -282,6 +282,9 @@ L.Socket = L.Class.extend({ var username = textMsg.substring('documentconflict '.length); msg = _('%user asked to refresh the document. Document will now refresh automatically.').replace('%user', username); + if (this._map._docLayer) { + this._map._docLayer.removeAllViews(); + } // Detach all the handlers from current socket, otherwise _onSocketClose tries to reconnect again // However, we want to reconnect manually here. this.close(); diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp index dfad745e..d92df509 100644 --- a/wsd/DocumentBroker.cpp +++ b/wsd/DocumentBroker.cpp @@ -497,11 +497,9 @@ bool DocumentBroker::load(const std::shared_ptr& session, const s { LOG_WRN("Document [" << _docKey << "] has been modified behind our back. Informing all clients."); _documentChangedInStorage = true; -// Inform all clients -for (const auto& sessionIt : _sessions) -{ -sessionIt.second->sendTextFrame("error: cmd=storage kind=documentconflict"); -} +const std::string errorMsg = "error: cmd=storage kind=documentconflict"; +session->sendTextFrame(errorMsg); +broadcastMessage(errorMsg); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108284] FILEOPEN ODS: Opening is slower as it used to be in earlier releases
https://bugs.documentfoundation.org/show_bug.cgi?id=108284 --- Comment #1 from Telesto--- Created attachment 133788 --> https://bugs.documentfoundation.org/attachment.cgi?id=133788=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108283] Start animation by clicking a drawn shape in ubuntu 17
https://bugs.documentfoundation.org/show_bug.cgi?id=108283 paochanged: What|Removed |Added Summary|Start animation by clicking |Start animation by clicking |a drown shape in ubuntu 17 |a drawn shape in ubuntu 17 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108284] FILEOPEN ODS: Opening is slower as it used to be in earlier releases
https://bugs.documentfoundation.org/show_bug.cgi?id=108284 Telestochanged: What|Removed |Added Version|5.5.0.0.alpha0+ Master |5.2.5.1 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108284] New: FILEOPEN ODS: Opening is slower as it used to be in earlier releases
https://bugs.documentfoundation.org/show_bug.cgi?id=108284 Bug ID: 108284 Summary: FILEOPEN ODS: Opening is slower as it used to be in earlier releases Product: LibreOffice Version: 5.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: File-opening is slower as it used to be in LibO4.4.6.3 Steps to Reproduce: 1. Open attached file and take notice of the time needed until opened Actual Results: File opening takes around 30 seconds Expected Results: Should be around 16 seconds Reproducible: Always User Profile Reset: No Additional Info: Found in (33 seconds) Version: 5.5.0.0.alpha0+ Build ID: ec79f3453471ee9b6ae32e71ff16ea99d9b7751c CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-05-28_23:21:44 Locale: nl-NL (nl_NL); Calc: CL and in Version: 5.2.5.0.0+ (40 seconds) Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8 CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time: 2016-12-24_14:43:55 Locale: nl-NL (nl_NL); Calc: CL but not in (16 seconds) Versie: 4.4.6.3 Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d Locale: nl_NL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108283] Start animation by clicking a drown shape in ubuntu 17
https://bugs.documentfoundation.org/show_bug.cgi?id=108283 paochanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94464] Text Body default line spacing too big ( proportional 120% instead of Single )
https://bugs.documentfoundation.org/show_bug.cgi?id=94464 Yousuf Philips (jay)changed: What|Removed |Added CC||khaledho...@eglug.org, ||momonas...@gmail.com --- Comment #23 from Yousuf Philips (jay) --- @Khaled, @Maxim, @Heiko: Do you guys have a take on this? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94464] Text Body default line spacing too big ( proportional 120% instead of Single )
https://bugs.documentfoundation.org/show_bug.cgi?id=94464 --- Comment #22 from Yousuf Philips (jay)--- Created attachment 133787 --> https://bugs.documentfoundation.org/attachment.cgi?id=133787=edit 1.00 to 1.20 comparison (In reply to V Stuart Foote from comment #21) > Correct. And as "peculiar" for MS's implementation, our target range for the > 120%-145% line spacing would be the same 1.03-1.29 that Butterick > suggests--just in our implementation a 103-129 value. Using our current > Text Body style default of 120 puts our spacing closer to 138%--too large. The recommendation states that anything within the 120% to 145% range is fine, so why would it be too large to use 138%? I'm fine with taking the middle value of the range, 132.5%, which is would be equivalent to 1.16, though i would minus 1 from it so we could go for 1.15 like other apps. > We should be on the lower end, so 108 as Cor suggested was reasonable, and > as MS Moved Office to at 2013, effectively 125% of the Point size > ("effective" depending on the hhea or Typo height described in the font). > The Gentium Plus, Gentium Plus Compact are a good example of how the font > itself controls the line spacing by increasing or decreasing the > ascent/descent for the same glyphs on a common em square. If you look at the line spacing page[1], it says "The text in this paragraph has line spacing of 135%. It looks fine.", which is using 1.35, so wouldnt be in favour of going to the lower end. [1] http://practicaltypography.com/line-spacing.html Took Cor's doc and modified it to include the range between 1.00 and 1.20 so we can compare the sizes. I think 1.10 and 1.15 have the good amount of space to not feel to camped or to large. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108283] Start animation by clicking a drown shape in ubuntu 17
https://bugs.documentfoundation.org/show_bug.cgi?id=108283 paochanged: What|Removed |Added CC||paolo.eustacc...@gmail.com --- Comment #1 from pao --- Created attachment 133786 --> https://bugs.documentfoundation.org/attachment.cgi?id=133786=edit I add a simple file with the animation that works on Windows but fails on Ubuntu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108283] New: Start animation by clicking a drown shape in ubuntu 17
https://bugs.documentfoundation.org/show_bug.cgi?id=108283 Bug ID: 108283 Summary: Start animation by clicking a drown shape in ubuntu 17 Product: LibreOffice Version: 5.3.3.2 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: paolo.eustacc...@gmail.com Description: Using Ubuntu 17.04 I've tried to start image enter animation by clicking on a LO drawn circle but in the the presentation when i click the circle the slide change without play animation. The same animation works fine under Windows. I apologize for my poor English. Steps to Reproduce: 1.Add image and Create circle 2.add enter animation for the image 3.right click on animation choose the second tab of effect option 4.set up activate animation by clicking circle Actual Results: in the the presentation when i click the circle the slide change without play animation. Expected Results: in the the presentation when i click the circle the added image enter with an animation effect Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 Dieter Praaschanged: What|Removed |Added Depends on||108256 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108256 [Bug 108256] EDITING: find/replace regular expressions: \n has 2 meanings, it shouldn't -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108256] EDITING: find/replace regular expressions: \n has 2 meanings, it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=108256 Dieter Praaschanged: What|Removed |Added Status|UNCONFIRMED |NEW Blocks||102847 Ever confirmed|0 |1 --- Comment #3 from Dieter Praas --- Thank you for the explanations and examples. I agree, that there are some situations, where it might be useful. Set to NEW. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90868] EDITING: Interactive image crop tool can' t apply proportional crop
https://bugs.documentfoundation.org/show_bug.cgi?id=90868 --- Comment #3 from tmacalp--- This still affects 5.3.3.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src wsd/ClientSession.cpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/protocol.txt
loleaflet/src/core/Socket.js | 12 wsd/ClientSession.cpp|5 - wsd/DocumentBroker.cpp | 18 +- wsd/DocumentBroker.hpp |3 +++ wsd/protocol.txt | 14 +- 5 files changed, 41 insertions(+), 11 deletions(-) New commits: commit f4b22bbb3c82c1e841934f98280f5deb2256f326 Author: Pranav KantDate: Thu Jun 1 21:41:11 2017 +0530 Broadcast command result back to clients This is required to tell the clients if the command they issued was successfull or not. In this case 'savetostorage' is the command that we are interested in knowing the success status of. With this, now if the user commands to overwrite the document, dialog boxes of all other users are automatically closed. Can easily more commands in future for this kind of thing. Its similar to unocommandresult, except its not a uno command, but our internal command. Change-Id: I2e7e1fd5edbd55c13ee4bf9bce24284483d6507f diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js index b3b99f48..e1cfde78 100644 --- a/loleaflet/src/core/Socket.js +++ b/loleaflet/src/core/Socket.js @@ -221,6 +221,18 @@ L.Socket = L.Class.extend({ this._map.fire('wopiprops', wopiInfo); return; } + else if (textMsg.startsWith('commandresult: ')) { + var commandresult = JSON.parse(textMsg.substring(textMsg.indexOf('{'))); + if (commandresult['command'] === 'savetostorage' && commandresult['success']) { + // Close any open confirmation dialogs + if (vex.dialogID > 0) { + var id = vex.dialogID; + vex.dialogID = -1; + vex.close(id); + } + } + return; + } else if (textMsg.startsWith('close: ')) { textMsg = textMsg.substring('close: '.length); msg = ''; diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp index 7af580bb..20b50b22 100644 --- a/wsd/ClientSession.cpp +++ b/wsd/ClientSession.cpp @@ -226,7 +226,10 @@ bool ClientSession::_handleInput(const char *buffer, int length) { int force = 0; getTokenInteger(tokens[1], "force", force); -docBroker->saveToStorage(getId(), true, "" /* This is irrelevant when success is true*/, true); +if (docBroker->saveToStorage(getId(), true, "" /* This is irrelevant when success is true*/, true)) +{ +docBroker->broadcastMessage("commandresult: { \"command\": \"savetostorage\", \"success\": true }"); +} } else { diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp index 2aa10d21..dfad745e 100644 --- a/wsd/DocumentBroker.cpp +++ b/wsd/DocumentBroker.cpp @@ -627,6 +627,7 @@ bool DocumentBroker::saveToStorageInternal(const std::string& sessionId, // So set _documentLastModifiedTime then _documentLastModifiedTime = _storage->getFileInfo()._modifiedTime; + // After a successful save, we are sure that document in the storage is same as ours _documentChangedInStorage = false; @@ -662,11 +663,7 @@ bool DocumentBroker::saveToStorageInternal(const std::string& sessionId, { LOG_ERR("PutFile says that Document changed in storage"); _documentChangedInStorage = true; -// Inform all clients -for (const auto& sessionIt : _sessions) -{ -sessionIt.second->sendTextFrame("error: cmd=storage kind=documentconflict"); -} +broadcastMessage("error: cmd=storage kind=documentconflict"); } return false; @@ -1418,6 +1415,17 @@ void DocumentBroker::closeDocument(const std::string& reason) terminateChild(reason, false); } +void DocumentBroker::broadcastMessage(const std::string& message) +{ +assertCorrectThread(); + +LOG_DBG("Broadcasting message [" << message << "] to all sessions."); +for (const auto& sessionIt : _sessions) +{ +sessionIt.second->sendTextFrame(message); +} +} + void DocumentBroker::updateLastActivityTime() { _lastActivityTime = std::chrono::steady_clock::now(); diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp index 7f563647..1329fcb1 100644 --- a/wsd/DocumentBroker.hpp +++ b/wsd/DocumentBroker.hpp @@ -339,6 +339,9 @@ public: /// Sends the .uno:Save command to LoKit. bool sendUnoSave(const std::string& sessionId, bool dontTerminateEdit = true, bool dontSaveIfUnmodified = true); +/// Sends a message to all sessions +void broadcastMessage(const std::string& message); + private: /// Shutdown all client connections with the given
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr6.cxx | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) New commits: commit e4f2aab11721cc6842c2c821ff9dacebc6095a56 Author: Eike RathkeDate: Thu Jun 1 17:58:58 2017 +0200 Perf: do not calculate a null-operation with the result matrix, tdf#58874 i.e. with an empty set within an svRefList when advancing to the next reference. Change-Id: Iae81c3a0cd3c30ab113ad74881a0f28b78b0973d diff --git a/sc/source/core/tool/interpr6.cxx b/sc/source/core/tool/interpr6.cxx index 0db0bd226373..cff34f262ad8 100644 --- a/sc/source/core/tool/interpr6.cxx +++ b/sc/source/core/tool/interpr6.cxx @@ -506,7 +506,11 @@ void ScInterpreter::IterateParameters( ScIterFunc eFunc, bool bTextAsZero ) short nParamCount = GetByte(); const SCSIZE nMatRows = GetRefListArrayMaxSize( nParamCount); ScMatrixRef xResMat, xResCount; -double fRes = ( eFunc == ifPRODUCT ) ? 1.0 : 0.0; +auto ResInitVal = [eFunc]() +{ +return (eFunc == ifPRODUCT) ? 1.0 : 0.0; +}; +double fRes = ResInitVal(); double fVal = 0.0; double fMem = 0.0; // first numeric value != 0.0 sal_uLong nCount = 0; @@ -753,19 +757,27 @@ void ScInterpreter::IterateParameters( ScIterFunc eFunc, bool bTextAsZero ) { // Current value and values from vector are operands // for each vector position. -for (SCSIZE i=0; i < nMatRows; ++i) +if (nCount && xResCount) { -if (xResCount) +for (SCSIZE i=0; i < nMatRows; ++i) +{ xResCount->PutDouble( xResCount->GetDouble(0,i) + nCount, 0,i); -double fVecRes = xResMat->GetDouble(0,i); -if (eFunc == ifPRODUCT) -fVecRes *= fRes; -else -fVecRes += fRes; -xResMat->PutDouble( fVecRes, 0,i); +} +} +if (fRes != ResInitVal()) +{ +for (SCSIZE i=0; i < nMatRows; ++i) +{ +double fVecRes = xResMat->GetDouble(0,i); +if (eFunc == ifPRODUCT) +fVecRes *= fRes; +else +fVecRes += fRes; +xResMat->PutDouble( fVecRes, 0,i); +} } } -fRes = ((eFunc == ifPRODUCT) ? 1.0 : 0.0); +fRes = ResInitVal(); nCount = 0; } } @@ -943,7 +955,7 @@ void ScInterpreter::IterateParameters( ScIterFunc eFunc, bool bTextAsZero ) fVecRes += fRes; xResMat->PutDouble( fVecRes, 0,nRefArrayPos); // Reset. -fRes = ((eFunc == ifPRODUCT) ? 1.0 : 0.0); +fRes = ResInitVal(); nCount = 0; nRefArrayPos = std::numeric_limits::max(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108256] EDITING: find/replace regular expressions: \n has 2 meanings, it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=108256 --- Comment #2 from akerb...@flopcat.org --- 2 have occurred just in my household: 1- my daughter wanted to cut and paste song lyrics into a story she was writing, but in paragraph form. So she needed to at the end of every line hand delete the paragraph break and replace it with a space. It was a very long song. 2- I have hundreds/thousands of old emails from back when they were sent only in plain text format. When you would reply, the paragraphs would be word-wrapped at 76 characters (or so) and on each new line a "> " would be prepended. We'd format new paragraphs by having 2 carriage returns. Preserving old emails into a document requires replacing all those single carriage returns with spaces and the double carriage returns with single carriage returns. A lot of reformatting. Basically - this is something you run into with reformatting text obtained from elsewhere. Also, it would be helpful for bringing text from or to a spreadsheet format. Clearly it is not a theoretical problem. In fact, a quick google search finds complaints about this going back 5-6 years, with some painful workarounds. But really this should just be in the already available find/replace feature. Noone should have to cut and paste thier LibreWriter doc into MSWord to be able to replace on . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108282] Crash in: SwWriteTable::SwWriteTable(SwTable const *, SwHTMLTableLayout const *)
https://bugs.documentfoundation.org/show_bug.cgi?id=108282 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |DUPLICATE --- Comment #1 from Xisco Faulí --- *** This bug has been marked as a duplicate of bug 105769 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105769] Crash when saving a pasted HTML table as DOCX or HTML, repro in comment 14 (Win, 64-bit build only)
https://bugs.documentfoundation.org/show_bug.cgi?id=105769 Xisco Faulíchanged: What|Removed |Added CC||clive.tom...@btinternet.com --- Comment #23 from Xisco Faulí --- *** Bug 108282 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108123] Crash in: writerfilter::dmapper::DomainMapper_Impl:: getTableManager()
https://bugs.documentfoundation.org/show_bug.cgi?id=108123 Xisco Faulíchanged: What|Removed |Added Keywords||bibisected, regression --- Comment #7 from Xisco Faulí --- Regression introduced in range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=a1ac2538e9b287444500618ab4d2f0f06c25cf34..19f4ebd8a54da0ae03b9cc8481613e5cd20ee1e7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 2 commits - loleaflet/src wsd/DocumentBroker.cpp
loleaflet/src/core/Socket.js | 13 + loleaflet/src/map/Map.js |2 +- wsd/DocumentBroker.cpp |2 ++ 3 files changed, 16 insertions(+), 1 deletion(-) New commits: commit dce714efb8b23e8ef59d3663f87cd0a557c70c9f Author: Pranav KantDate: Thu Jun 1 21:07:52 2017 +0530 Toggle this flag after a successfull save Change-Id: Id1bf5bc5e32e24f68094f3020f4a7c4c4117f18a diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp index 981834fa..2aa10d21 100644 --- a/wsd/DocumentBroker.cpp +++ b/wsd/DocumentBroker.cpp @@ -627,6 +627,8 @@ bool DocumentBroker::saveToStorageInternal(const std::string& sessionId, // So set _documentLastModifiedTime then _documentLastModifiedTime = _storage->getFileInfo()._modifiedTime; +// After a successful save, we are sure that document in the storage is same as ours +_documentChangedInStorage = false; LOG_DBG("Saved docKey [" << _docKey << "] to URI [" << uri << "] and updated tile cache. Document modified timestamp: " << Poco::DateTimeFormatter::format(Poco::DateTime(_documentLastModifiedTime), commit 9f535580a6590bcb6f77d4227ff685f8185cdf2d Author: Pranav Kant Date: Thu Jun 1 21:07:21 2017 +0530 Close the dialog before showing a confirmation dialog Change-Id: If7220c37f8456627181500d7428caf3657816a16 diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js index 1d6b884f..b3b99f48 100644 --- a/loleaflet/src/core/Socket.js +++ b/loleaflet/src/core/Socket.js @@ -270,6 +270,10 @@ L.Socket = L.Class.extend({ var username = textMsg.substring('documentconflict '.length); msg = _('%user asked to refresh the document. Document will now refresh automatically.').replace('%user', username); + // Detach all the handlers from current socket, otherwise _onSocketClose tries to reconnect again + // However, we want to reconnect manually here. + this.close(); + // Reload the document this._map._active = false; map = this._map; @@ -349,6 +353,15 @@ L.Socket = L.Class.extend({ else if (command.errorKind === 'documentconflict') { storageError = errorMessages.storage.documentconflict; + + // TODO: We really really need to factor this out duplicate dialog code logic everywhere + // Close any open dialogs first. + if (vex.dialogID > 0) { + var id = vex.dialogID; + vex.dialogID = -1; + vex.close(id); + } + vex.dialog.confirm({ message: _('Document has been changed in storage. Do you want to refresh the page to load the new document ? Cancelling will continue editing and overwrite.'), callback: L.bind(function(value) { diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js index 1e06bae5..32b07f73 100644 --- a/loleaflet/src/map/Map.js +++ b/loleaflet/src/map/Map.js @@ -842,7 +842,7 @@ L.Map = L.Evented.extend({ var options = $.extend({}, vex.defaultOptions, { contentCSS: {'background':'rgba(0, 0, 0, 0)', -'font-size': 'xx-large', +'font-size': 'xx-large', 'color': '#fff', 'text-align': 'center'}, content: _('Inactive document - please click to resume editing') ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108282] New: Crash in: SwWriteTable::SwWriteTable(SwTable const *, SwHTMLTableLayout const *)
https://bugs.documentfoundation.org/show_bug.cgi?id=108282 Bug ID: 108282 Summary: Crash in: SwWriteTable::SwWriteTable(SwTable const *,SwHTMLTableLayout const *) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: clive.tom...@btinternet.com This bug was filed from the crash reporting server and is br-0ba40859-2c6a-4233-a3f5-7a884cef849a. = -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Makefile.in Repository.mk vcl/Executable_ww8fuzzer.mk vcl/Module_vcl.mk vcl/workben
Makefile.in |2 - Repository.mk |1 vcl/Executable_ww8fuzzer.mk | 47 vcl/Module_vcl.mk |1 vcl/workben/ww8fuzzer.cxx | 33 ++ 5 files changed, 83 insertions(+), 1 deletion(-) New commits: commit 5cd1da66013015c091b7f0a86a04f7c465fd6b8d Author: Caolán McNamaraDate: Tue May 2 12:56:34 2017 +0100 add ww8 fuzzer Change-Id: Icb8b385e3c59b6476ac58da5e76bbe73eaa82d88 diff --git a/Makefile.in b/Makefile.in index 53cb88141121..8a4f9710c24a 100644 --- a/Makefile.in +++ b/Makefile.in @@ -474,7 +474,7 @@ $(foreach ide,\ eclipsecdt,\ $(eval $(call gb_Top_GbuildToIdeIntegrationNS,$(ide -fuzzers: Library_sal Library_salhelper Library_reg Library_store Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper Library_comphelper StaticLibrary_ulingu StaticLibrary_findsofficepath Library_tl Library_basegfx Library_canvastools Library_cppcanvas Library_dbtools Library_deploymentmisc Library_deploymentmisc Library_editeng Library_fwe Library_fwi Library_i18nutil Library_localebe1 Library_sax Library_sofficeapp Library_ucbhelper Library_opencl Rdb_services udkapi offapi Library_clew Library_gie Library_icg Library_reflection Library_invocadapt Library_bootstrap Library_introspection Library_stocservices Library_xmlreader Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer Executable_psdfuzzer Executable_epsfuzzer Executable_pctfuzzer Executable_pcxfuzzer Executable_rasfuzzer Executable_tgafuzzer Executable_tiffuzzer Executable_hwpfuzzer Executable_602fuzzer Executable_lwpfuzzer Executable_olefuzzer AllLangResTarget_sd Executable_pptfuzzer Executable_rtffuzzer Executable_cgmfuzzer Executable_ww2fuzzer Executable_ww6fuzzer +fuzzers: Library_sal Library_salhelper Library_reg Library_store Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper Library_comphelper StaticLibrary_ulingu StaticLibrary_findsofficepath Library_tl Library_basegfx Library_canvastools Library_cppcanvas Library_dbtools Library_deploymentmisc Library_deploymentmisc Library_editeng Library_fwe Library_fwi Library_i18nutil Library_localebe1 Library_sax Library_sofficeapp Library_ucbhelper Library_opencl Rdb_services udkapi offapi Library_clew Library_gie Library_icg Library_reflection Library_invocadapt Library_bootstrap Library_introspection Library_stocservices Library_xmlreader Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer Executable_psdfuzzer Executable_epsfuzzer Executable_pctfuzzer Executable_pcxfuzzer Executable_rasfuzzer Executable_tgafuzzer Executable_tiffuzzer Executable_hwpfuzzer Executable_602fuzzer Executable_lwpfuzzer Executable_olefuzzer AllLangResTarget_sd Executable_pptfuzzer Executable_rtffuzzer Executable_cgmfuzzer Executable_ww2fuzzer Executable_ww6fuzzer Executable_ww8fuzzer endif # MAKE_RESTARTS diff --git a/Repository.mk b/Repository.mk index bf38a3b3504a..de4cded208c5 100644 --- a/Repository.mk +++ b/Repository.mk @@ -127,6 +127,7 @@ $(eval $(call gb_Helper_register_executables_for_install,OOO,brand, \ $(call gb_Helper_optional,FUZZERS,cgmfuzzer) \ $(call gb_Helper_optional,FUZZERS,ww2fuzzer) \ $(call gb_Helper_optional,FUZZERS,ww6fuzzer) \ + $(call gb_Helper_optional,FUZZERS,ww8fuzzer) \ $(if $(filter-out ANDROID IOS MACOSX WNT,$(OS)),oosplash) \ soffice_bin \ $(if $(filter DESKTOP,$(BUILD_TYPE)),unopkg_bin) \ diff --git a/vcl/Executable_ww8fuzzer.mk b/vcl/Executable_ww8fuzzer.mk new file mode 100644 index ..41ce144e6c52 --- /dev/null +++ b/vcl/Executable_ww8fuzzer.mk @@ -0,0 +1,47 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +include $(SRCDIR)/vcl/commonfuzzer.mk + +$(eval $(call gb_Executable_Executable,ww8fuzzer)) + +$(eval $(call gb_Executable_use_api,ww8fuzzer,\ +offapi \ +udkapi \ +)) + +$(eval $(call gb_Executable_use_externals,ww8fuzzer,\ + $(fuzzer_externals) \ +)) + +$(eval $(call gb_Executable_set_include,ww8fuzzer,\ +$$(INCLUDE) \ +-I$(SRCDIR)/vcl/inc \
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/docary.hxx |8 +--- sw/source/core/doc/DocumentRedlineManager.cxx |9 ++--- sw/source/core/doc/docredln.cxx |6 +++--- 3 files changed, 14 insertions(+), 9 deletions(-) New commits: commit 58d57d666a7ea2044599d9ec47a29ff3c6b588a2 Author: Caolán McNamaraDate: Thu May 18 13:52:04 2017 +0100 ofz: InsertWithValidRanges didn't report that it deleted its argument anymore since... commit ddd84d08c9bb6e00fbd9a73bd52a28688a8c1ba7 Date: Fri Jul 20 17:16:03 2012 +0200 Convert SV_DECL_PTRARR_SORT_DEL(_SwRedlineTbl) to o3tl::sorted_vector Change-Id: Ie7edc6b32b373619d4c0ac154da93650743049cf otherwise that p = nullptr line at the end doesn't make sense Change-Id: Ibd5230beb87240cba4b3896dfa2217e25a4db697 Reviewed-on: https://gerrit.libreoffice.org/37760 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/inc/docary.hxx b/sw/inc/docary.hxx index de663f105075..424680b329c6 100644 --- a/sw/inc/docary.hxx +++ b/sw/inc/docary.hxx @@ -318,6 +318,8 @@ struct CompareSwRedlineTable // Notification type for notifying about redlines to LOK clients enum class RedlineNotification { Add, Remove, Modify }; +typedef SwRangeRedline* SwRangeRedlinePtr; + class SwRedlineTable { public: @@ -333,9 +335,9 @@ public: bool Contains(const SwRangeRedline* p) const { return maVector.find(const_cast (p)) != maVector.end(); } size_type GetPos(const SwRangeRedline* p) const; -bool Insert( SwRangeRedline* p ); -bool Insert( SwRangeRedline* p, size_type& rInsPos ); -bool InsertWithValidRanges( SwRangeRedline* p, size_type* pInsPos = nullptr ); +bool Insert(SwRangeRedlinePtr& p); +bool Insert(SwRangeRedlinePtr& p, size_type& rInsPos); +bool InsertWithValidRanges(SwRangeRedlinePtr& p, size_type* pInsPos = nullptr); void Remove( size_type nPos ); bool Remove( const SwRangeRedline* p ); diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx b/sw/source/core/doc/DocumentRedlineManager.cxx index 093bdc719228..90cc40202ab8 100644 --- a/sw/source/core/doc/DocumentRedlineManager.cxx +++ b/sw/source/core/doc/DocumentRedlineManager.cxx @@ -1228,9 +1228,10 @@ bool DocumentRedlineManager::AppendRedline( SwRangeRedline* pNewRedl, bool bCall if( bCallDelete ) { ::comphelper::FlagGuard g(m_isForbidCompressRedlines); +//Insert may delete pNewRedl, in which case it sets pNewRedl to nullptr mpRedlineTable->Insert( pNewRedl ); m_rDoc.getIDocumentContentOperations().DeleteAndJoin( *pRedl ); -if( !mpRedlineTable->Remove( pNewRedl ) ) +if (pNewRedl && !mpRedlineTable->Remove(pNewRedl)) { assert(false); // can't happen pNewRedl = nullptr; @@ -1260,9 +1261,10 @@ bool DocumentRedlineManager::AppendRedline( SwRangeRedline* pNewRedl, bool bCall // We insert temporarily so that pNew is // also dealt with when moving the indices. ::comphelper::FlagGuard g(m_isForbidCompressRedlines); +//Insert may delete pNewRedl, in which case it sets pNewRedl to nullptr mpRedlineTable->Insert( pNewRedl ); m_rDoc.getIDocumentContentOperations().DeleteAndJoin( aPam ); -if( !mpRedlineTable->Remove( pNewRedl ) ) +if (pNewRedl && !mpRedlineTable->Remove(pNewRedl)) { assert(false); // can't happen pNewRedl = nullptr; @@ -1291,9 +1293,10 @@ bool DocumentRedlineManager::AppendRedline( SwRangeRedline* pNewRedl, bool bCall // We insert temporarily so that pNew is // also dealt with when moving the indices. ::comphelper::FlagGuard g(m_isForbidCompressRedlines); +//Insert may delete pNewRedl, in which case it sets pNewRedl to nullptr mpRedlineTable->Insert( pNewRedl ); m_rDoc.getIDocumentContentOperations().DeleteAndJoin( aPam ); -if( !mpRedlineTable->Remove( pNewRedl ) ) +if
[Libreoffice-commits] core.git: 2 commits - hwpfilter/source sw/source
hwpfilter/source/hbox.cxx|2 -- hwpfilter/source/hbox.h |2 -- hwpfilter/source/hwpfile.cxx | 10 -- hwpfilter/source/hwpread.cxx |1 + sw/source/filter/ww8/ww8graf.cxx |2 +- 5 files changed, 2 insertions(+), 15 deletions(-) New commits: commit dfe317b490025550d82cbd6bb46685171a864d7a Author: Caolán McNamaraDate: Mon Apr 24 15:06:10 2017 +0100 ofz#1220 sanitize nTyp to legal values Change-Id: Iad71c4f79dbe03e2e325453eb0506a2d92d67c2d Reviewed-on: https://gerrit.libreoffice.org/36891 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/source/filter/ww8/ww8graf.cxx b/sw/source/filter/ww8/ww8graf.cxx index 121f605f34dd..d404d6c9c29c 100644 --- a/sw/source/filter/ww8/ww8graf.cxx +++ b/sw/source/filter/ww8/ww8graf.cxx @@ -1295,7 +1295,7 @@ SdrObject* SwWW8ImplReader::ReadCaptionBox(WW8_DPHEAD* pHd, SfxAllItemSet ) else// no -> take lines SetStdAttr( rSet, aCallB.dpPolyLine.aLnt, aCallB.dptxbx.aShd ); SetFill( rSet, aCallB.dptxbx.aFill ); -rSet.Put( SdrCaptionTypeItem( aCaptA[nTyp] ) ); +rSet.Put(SdrCaptionTypeItem(aCaptA[nTyp % SAL_N_ELEMENTS(aCaptA)])); return pObj; } commit 630ae53e3657423cb7eeda6f8e8160b75d497f8d Author: Caolán McNamara Date: Fri Apr 21 10:51:19 2017 +0100 ofz#1193 we only set these values, never read them Change-Id: Ia2f54b536a4262e19abe260e8e19c9b15cc2d0ec Reviewed-on: https://gerrit.libreoffice.org/36779 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx index 3bfe57662656..ef6348817f48 100644 --- a/hwpfilter/source/hbox.cxx +++ b/hwpfilter/source/hbox.cxx @@ -328,8 +328,6 @@ FBox::FBox(hchar hch) , pgy(0) , pgno(0) , showpg(0) -, prev(nullptr) -, next(nullptr) { } diff --git a/hwpfilter/source/hbox.h b/hwpfilter/source/hbox.h index a110d70d0f32..8824a0911ded 100644 --- a/hwpfilter/source/hbox.h +++ b/hwpfilter/source/hbox.h @@ -316,8 +316,6 @@ struct FBox: public HBox short pgx, pgy; // physical xpos, ypos short pgno, showpg; // pageno where code is -FBox *prev, *next; - explicit FBox( hchar hch ); virtual ~FBox() override; }; diff --git a/hwpfilter/source/hwpfile.cxx b/hwpfilter/source/hwpfile.cxx index 729f31a9e317..00c45475fdf1 100644 --- a/hwpfilter/source/hwpfile.cxx +++ b/hwpfilter/source/hwpfile.cxx @@ -466,18 +466,8 @@ EmPicture *HWPFile::GetEmPictureByName(char * name) return nullptr; } - void HWPFile::AddBox(FBox * box) { -// LATER if we don't use box->next(), -// AddBox() and GetBoxHead() are useless; -if (!blist.empty()) -{ -box->prev = blist.back(); -box->prev->next = box; -} -else -box->prev = nullptr; blist.push_back(box); } diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx index 92f484b1d10d..90564df487b9 100644 --- a/hwpfilter/source/hwpread.cxx +++ b/hwpfilter/source/hwpread.cxx @@ -219,6 +219,7 @@ bool TxtBox::Read(HWPFile & hwpf) hwpf.AddBox(this); hwpf.Read2b(_len, 1); hwpf.Read2b(, 1); +unsigned short next; hwpf.Read2b(, 1); hwpf.Read2b(, 1); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/DocumentRedlineManager.cxx | 21 + sw/source/core/inc/DocumentRedlineManager.hxx |1 + 2 files changed, 22 insertions(+) New commits: commit 1c0ea92c5722b19f515f3b2cd0bf2ddce94b58e7 Author: Michael StahlDate: Tue Apr 25 21:38:28 2017 +0200 ofz#1262 sw: DeleteAndJoin could delete proposed new redline ... because that calls CompressRedlines, which may combine the new redline with a previous one. In that case, the part of the new redline that follows the currently handled overlap cannot be checked for overlaps with subsequent existing redlines. So prevent this with a new flag m_isForbidCompressRedlines and instead call CompressRedlines() at the end of AppendRedline(). Change-Id: I7567962c31366ded9a433a13232d3db985745e43 Reviewed-on: https://gerrit.libreoffice.org/36901 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx b/sw/source/core/doc/DocumentRedlineManager.cxx index fd8e3c21488f..093bdc719228 100644 --- a/sw/source/core/doc/DocumentRedlineManager.cxx +++ b/sw/source/core/doc/DocumentRedlineManager.cxx @@ -30,6 +30,7 @@ #include #include #include +#include using namespace com::sun::star; @@ -1226,10 +1227,15 @@ bool DocumentRedlineManager::AppendRedline( SwRangeRedline* pNewRedl, bool bCall // also dealt with when moving the indices. if( bCallDelete ) { +::comphelper::FlagGuard g(m_isForbidCompressRedlines); mpRedlineTable->Insert( pNewRedl ); m_rDoc.getIDocumentContentOperations().DeleteAndJoin( *pRedl ); if( !mpRedlineTable->Remove( pNewRedl ) ) +{ +assert(false); // can't happen pNewRedl = nullptr; +} +bCompress = true; // delayed compress } delete pRedl; } @@ -1253,10 +1259,15 @@ bool DocumentRedlineManager::AppendRedline( SwRangeRedline* pNewRedl, bool bCall { // We insert temporarily so that pNew is // also dealt with when moving the indices. +::comphelper::FlagGuard g(m_isForbidCompressRedlines); mpRedlineTable->Insert( pNewRedl ); m_rDoc.getIDocumentContentOperations().DeleteAndJoin( aPam ); if( !mpRedlineTable->Remove( pNewRedl ) ) +{ +assert(false); // can't happen pNewRedl = nullptr; +} +bCompress = true; // delayed compress n = 0; // re-initialize } bDec = true; @@ -1279,10 +1290,15 @@ bool DocumentRedlineManager::AppendRedline( SwRangeRedline* pNewRedl, bool bCall { // We insert temporarily so that pNew is // also dealt with when moving the indices. +::comphelper::FlagGuard g(m_isForbidCompressRedlines); mpRedlineTable->Insert( pNewRedl ); m_rDoc.getIDocumentContentOperations().DeleteAndJoin( aPam ); if( !mpRedlineTable->Remove( pNewRedl ) ) +{ +assert(false); // can't happen pNewRedl = nullptr; +} +bCompress = true; // delayed compress n = 0; // re-initialize bDec = true; } @@ -1777,6 +1793,11 @@ bool DocumentRedlineManager::AppendTableCellRedline( SwTableCellRedline* pNewRed void DocumentRedlineManager::CompressRedlines() { +if (m_isForbidCompressRedlines) +{ +return; +} + CHECK_REDLINE( *this ) void (SwRangeRedline::*pFnc)(sal_uInt16, size_t) = nullptr; diff --git a/sw/source/core/inc/DocumentRedlineManager.hxx
[Libreoffice-commits] core.git: filter/source
filter/source/graphicfilter/icgm/class2.cxx | 15 +++ 1 file changed, 15 insertions(+) New commits: commit e436f7139e246fa742a9dc62b18740ab99418400 Author: Caolán McNamaraDate: Thu Apr 27 21:45:31 2017 +0100 ofz#1284 InsertBundle may delete the bundle that pMarkerBundle is pointing to Change-Id: Ic8bd538e80469b672ddd9c5fcceb2f5aac81d2a1 Reviewed-on: https://gerrit.libreoffice.org/37051 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/filter/source/graphicfilter/icgm/class2.cxx b/filter/source/graphicfilter/icgm/class2.cxx index 842acfb86a31..34d89f93bf45 100644 --- a/filter/source/graphicfilter/icgm/class2.cxx +++ b/filter/source/graphicfilter/icgm/class2.cxx @@ -147,7 +147,10 @@ void CGM::ImplDoClass2() aTempLineBundle.eLineType = (LineType)ImplGetI( pElement->nIndexPrecision ); aTempLineBundle.nLineWidth = ImplGetFloat( pElement->eRealPrecision, pElement->nRealSize ); aTempLineBundle.SetColor( ImplGetBitmapColor() ); +const bool bUpdateLineBundle = aTempLineBundle.GetIndex() == pElement->pLineBundle->GetIndex(); CGMElements::InsertBundle( pElement->aLineList, aTempLineBundle ); +if (bUpdateLineBundle) +pElement->pLineBundle = static_cast (CGMElements::GetBundleIndex(aTempLineBundle.GetIndex(), pElement->aLineList, pElement->aLineBundle)); } break; case 0x0c : /*Marker Representation*/ @@ -157,7 +160,10 @@ void CGM::ImplDoClass2() aTempMarkerBundle.eMarkerType = (MarkerType)ImplGetI( pElement->nIndexPrecision ); aTempMarkerBundle.nMarkerSize = ImplGetFloat( pElement->eRealPrecision, pElement->nRealSize ); aTempMarkerBundle.SetColor( ImplGetBitmapColor() ); +const bool bUpdateMarkerBundle = aTempMarkerBundle.GetIndex() == pElement->pMarkerBundle->GetIndex(); CGMElements::InsertBundle( pElement->aMarkerList, aTempMarkerBundle ); +if (bUpdateMarkerBundle) +pElement->pMarkerBundle = static_cast (CGMElements::GetBundleIndex(aTempMarkerBundle.GetIndex(), pElement->aMarkerList, pElement->aMarkerBundle)); } break; case 0x0d : /*Text Representation*/ @@ -169,7 +175,10 @@ void CGM::ImplDoClass2() aTempTextBundle.nCharacterSpacing = ImplGetFloat( pElement->eRealPrecision, pElement->nRealSize ); aTempTextBundle.nCharacterExpansion = ImplGetFloat( pElement->eRealPrecision, pElement->nRealSize ); aTempTextBundle.SetColor( ImplGetBitmapColor() ); +const bool bUpdateTextBundle = aTempTextBundle.GetIndex() == pElement->pTextBundle->GetIndex(); CGMElements::InsertBundle( pElement->aTextList, aTempTextBundle ); +if (bUpdateTextBundle) +pElement->pTextBundle = static_cast (CGMElements::GetBundleIndex(aTempTextBundle.GetIndex(), pElement->aTextList, pElement->aTextBundle)); } break; case 0x0e : /*Fill Representation*/ @@ -180,7 +189,10 @@ void CGM::ImplDoClass2() aTempFillBundle.SetColor( ImplGetBitmapColor() ); aTempFillBundle.nFillPatternIndex = ImplGetI( pElement->nIndexPrecision ); aTempFillBundle.nFillHatchIndex = ImplGetI( pElement->nIndexPrecision ); +const bool bUpdateFillBundle = aTempFillBundle.GetIndex() == pElement->pFillBundle->GetIndex(); CGMElements::InsertBundle( pElement->aFillList, aTempFillBundle ); +if (bUpdateFillBundle) +pElement->pFillBundle = static_cast (CGMElements::GetBundleIndex(aTempFillBundle.GetIndex(), pElement->aFillList, pElement->aFillBundle)); } break; case 0x0f : /*Edge Representation*/ @@ -190,7 +202,10 @@ void CGM::ImplDoClass2() aTempEdgeBundle.eEdgeType = (EdgeType)ImplGetI( pElement->nIndexPrecision ); aTempEdgeBundle.nEdgeWidth = ImplGetFloat( pElement->eRealPrecision, pElement->nRealSize ); aTempEdgeBundle.SetColor( ImplGetBitmapColor() ); +const bool bUpdateEdgeBundle = aTempEdgeBundle.GetIndex() == pElement->pEdgeBundle->GetIndex(); CGMElements::InsertBundle( pElement->aEdgeList, aTempEdgeBundle ); +if (bUpdateEdgeBundle) +pElement->pEdgeBundle = static_cast (CGMElements::GetBundleIndex(aTempEdgeBundle.GetIndex(), pElement->aEdgeList, pElement->aEdgeBundle)); } break; case 0x10 : /*Interior Style Specification Mode */break;// NS ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sw/source
sw/source/uibase/fldui/fldmgr.cxx |2 +- sw/source/uibase/misc/numberingtypelistbox.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit e63729710b58f34827aebc55b79ceaf2044b763a Author: Caolán McNamaraDate: Thu Jun 1 15:56:43 2017 +0100 wrong resource manager for RID_SVXSTRARY_NUMBERINGTYPE Change-Id: I4c348ee56ae3e90513c8ebd19e0f506bbf0d70f0 (cherry picked from commit 088ef5dd64dfa653d6a0f6e5f73f1b6078910bca) diff --git a/sw/source/uibase/fldui/fldmgr.cxx b/sw/source/uibase/fldui/fldmgr.cxx index 98657f7b69d6..49ed1f7a7395 100644 --- a/sw/source/uibase/fldui/fldmgr.cxx +++ b/sw/source/uibase/fldui/fldmgr.cxx @@ -594,7 +594,7 @@ OUString SwFieldMgr::GetFormatStr(sal_uInt16 nTypeId, sal_uLong nFormatId) const { if(xNumberingInfo.is()) { -ResStringArray aNames(ResId(RID_SVXSTRARY_NUMBERINGTYPE, *pSwResMgr)); +ResStringArray aNames(ResId(RID_SVXSTRARY_NUMBERINGTYPE, DIALOG_MGR())); Sequence aTypes = xNumberingInfo->getSupportedNumberingTypes(); const sal_Int16* pTypes = aTypes.getConstArray(); diff --git a/sw/source/uibase/misc/numberingtypelistbox.cxx b/sw/source/uibase/misc/numberingtypelistbox.cxx index 6f87678ab0a9..7d5c066cbf73 100644 --- a/sw/source/uibase/misc/numberingtypelistbox.cxx +++ b/sw/source/uibase/misc/numberingtypelistbox.cxx @@ -90,7 +90,7 @@ void SwNumberingTypeListBox::Reload(SwInsertNumTypes nTypeFlags) pTypes = aTypes.getConstArray(); } } -ResStringArray aNames(ResId(RID_SVXSTRARY_NUMBERINGTYPE, *pSwResMgr)); +ResStringArray aNames(ResId(RID_SVXSTRARY_NUMBERINGTYPE, DIALOG_MGR())); for(size_t i = 0; i < aNames.Count(); i++) { sal_IntPtr nValue = aNames.GetValue(i); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/fldui/fldmgr.cxx |2 +- sw/source/uibase/misc/numberingtypelistbox.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 088ef5dd64dfa653d6a0f6e5f73f1b6078910bca Author: Caolán McNamaraDate: Thu Jun 1 15:56:43 2017 +0100 wrong resource manager for RID_SVXSTRARY_NUMBERINGTYPE Change-Id: I4c348ee56ae3e90513c8ebd19e0f506bbf0d70f0 diff --git a/sw/source/uibase/fldui/fldmgr.cxx b/sw/source/uibase/fldui/fldmgr.cxx index 98657f7b69d6..49ed1f7a7395 100644 --- a/sw/source/uibase/fldui/fldmgr.cxx +++ b/sw/source/uibase/fldui/fldmgr.cxx @@ -594,7 +594,7 @@ OUString SwFieldMgr::GetFormatStr(sal_uInt16 nTypeId, sal_uLong nFormatId) const { if(xNumberingInfo.is()) { -ResStringArray aNames(ResId(RID_SVXSTRARY_NUMBERINGTYPE, *pSwResMgr)); +ResStringArray aNames(ResId(RID_SVXSTRARY_NUMBERINGTYPE, DIALOG_MGR())); Sequence aTypes = xNumberingInfo->getSupportedNumberingTypes(); const sal_Int16* pTypes = aTypes.getConstArray(); diff --git a/sw/source/uibase/misc/numberingtypelistbox.cxx b/sw/source/uibase/misc/numberingtypelistbox.cxx index 6f87678ab0a9..7d5c066cbf73 100644 --- a/sw/source/uibase/misc/numberingtypelistbox.cxx +++ b/sw/source/uibase/misc/numberingtypelistbox.cxx @@ -90,7 +90,7 @@ void SwNumberingTypeListBox::Reload(SwInsertNumTypes nTypeFlags) pTypes = aTypes.getConstArray(); } } -ResStringArray aNames(ResId(RID_SVXSTRARY_NUMBERINGTYPE, *pSwResMgr)); +ResStringArray aNames(ResId(RID_SVXSTRARY_NUMBERINGTYPE, DIALOG_MGR())); for(size_t i = 0; i < aNames.Count(); i++) { sal_IntPtr nValue = aNames.GetValue(i); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108208] LO will not open in windows 10 creators update
https://bugs.documentfoundation.org/show_bug.cgi?id=108208 fdheal...@yahoo.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #11 from fdheal...@yahoo.com --- (In reply to V Stuart Foote from comment #10) > (In reply to fdhealy54 from comment #9) > > Sorry but that is beyond my pay grade so to say. Do you have the ability to > > remotely connect to my computer? > > > > Would prefer not to go down that route. Perhaps seek competent assistance in > your neighborhood. Both to correct the MS Installer service, and completely > clear residual installs and profiles. Then start again with a clean > installation. > > For now, lacking any actionable details, resolving this install issue as > WORKSFORME as it is known functional. > > If following cleanup and a new command line install attempt with logging, if > still having issues zip and post the install log--we'll REOPEN. Do you have a list of files and registry items to remove for a manual uninstall? Dale -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/basic
include/basic/sberrors.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 52fc13a6f701b1e94ffc012e1cfe07a25747ccc6 Author: Caolán McNamaraDate: Thu Jun 1 14:31:01 2017 +0100 SbError is a ErrCode Change-Id: I2b4f0680f4adedc5661c6a9d2556ac3ecf2c4659 Reviewed-on: https://gerrit.libreoffice.org/38311 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/include/basic/sberrors.hxx b/include/basic/sberrors.hxx index 6ec016fd1ce5..f1e44a977754 100644 --- a/include/basic/sberrors.hxx +++ b/include/basic/sberrors.hxx @@ -23,7 +23,7 @@ #include #ifndef __RSC -typedef sal_uIntPtr SbError; +typedef ErrCode SbError; #endif // Mapping to SbxError ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108208] LO will not open in windows 10 creators update
https://bugs.documentfoundation.org/show_bug.cgi?id=108208 V Stuart Footechanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #10 from V Stuart Foote --- (In reply to fdhealy54 from comment #9) > Sorry but that is beyond my pay grade so to say. Do you have the ability to > remotely connect to my computer? > Would prefer not to go down that route. Perhaps seek competent assistance in your neighborhood. Both to correct the MS Installer service, and completely clear residual installs and profiles. Then start again with a clean installation. For now, lacking any actionable details, resolving this install issue as WORKSFORME as it is known functional. If following cleanup and a new command line install attempt with logging, if still having issues zip and post the install log--we'll REOPEN. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] [libreoffice-projects] Minutes of the Design Hangout: 2017-Jun-01
On 01.06.2017 15:59, K-J LibreOffice wrote: > The best would be a Whiteboard [1] as we made it the last times (except LibO > 5). The pad is still at https://pad.documentfoundation.org/p/UX-branding-6.0 and the last request for input has been done on the mailing list http://nabble.documentfoundation.org/Branding-6-0-td4215458.html (x-post with marketing). One reply to marketing with +1 for keeping the original motif (forever) and another one directly to me. 100% agreement for the transparency. signature.asc Description: OpenPGP digital signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [libreoffice-projects] Minutes of the Design Hangout: 2017-Jun-01
On 01.06.2017 15:59, K-J LibreOffice wrote: > The best would be a Whiteboard [1] as we made it the last times (except LibO > 5). The pad is still at https://pad.documentfoundation.org/p/UX-branding-6.0 and the last request for input has been done on the mailing list http://nabble.documentfoundation.org/Branding-6-0-td4215458.html (x-post with marketing). One reply to marketing with +1 for keeping the original motif (forever) and another one directly to me. 100% agreement for the transparency. signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] minutes of ESC call ...
* Present: + Caolan, Heiko, Kendy, Miklos, Olivier, Michael M, Stephan, Sebastian, Sophie, Christian, Eike, Michael S, Xisco * Completed Action Items: + get 5.4 deprecated section proposals here (Eike, thanks to buovjaga) + state in the release notes that 5.4 will be the very last release supporting Windows XP and Vista (Eike, thanks to Stuart) + cf. https://bugs.documentfoundation.org/show_bug.cgi?id=108043 + Windows builds use internal ICU 58 again + cherry-pick commit bringing Mac base-line up to 10.9 (Miklos) + quantify potential size saving from live help screenshot (Olivier) [ ~35M per language (Olivier) + in current downloads ? < 3.5Gb. + help content is 7Mb or so, if add all screenshots will be 35M will save 29Mb each + idea in the past – run screenshots on installing help package. + takes time to make screenshots & things flicker ] AI: + come up with a concrete, deliverable plan for discussion (Olivier) * Pending Action Items: + Developer Certification – next round (Stephan/Bjoern/Kendy/Thorsten) [ still pending ] * Release Engineering update (Christian) + 5.4.0 Beta 2 – June 6th + hard break / tag on Tuesday; not shifting it back. + no additional reviews necessary on the branch, you can push yourself until June 20th + late features + Windows support for gpg sign/encrypt (?) (Thorsten) + 5.3.4 RC1 – May 30th + due this week, not tagged yet + but all patches waiting with out -1 were integrated + minor UI freeze break in options page – approved by Sophie/Olivier + Android & iOS Remote + no release, but poked at it in the hack-fest; new release pending. + online – Beta2 coming up. + git / problems with replication to freedesktop + appeared to fix itself. + perf. issues fixed by a ‘git gc’ on repos. + marketing decided to use 6.0 for next release (Heiko) + versions / bug notifications etc. talk of 5.5 AI: + check with Italo, and change the version info in configure.ac (Christian) * Documentation (Olivier) + online help rewritten – to static html (Olivier) + flattening all the XML. + discussing it with Kendy. + enthusiasm for the new solution here. + preserves all the help / translation editing tools etc. + a couple of scripts to flatten the XML – browser portable. + New help pages fixed and added (G. Kelemen) + Fix of Helpauthoring to support tags (Jean Spiteri / Liongold) + superscript / subscript. + New doc for download (quick reference card) (Valdir Barbosa) + Docs team calls ? (Michael) + new guy from Italy, learning help authoring tools. + next week – will have another meeting. * UX Update (Heiko) + Bugzilla (topicUI) statistics 257(257) (topicUI) bugs open, 472(472) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week 1 month 3 months 12 months added 6(3) 17(1) 36(3) 457(-9) commented 52(5)212(2)577(37)3500(-19) removed 0(0) 0(-1) 5(-1) 42(0) resolved 3(0) 10(2) 47(-1) 232(2) + top 10 contributors: Philips, Yousuf made 192 changes in 1 month, and 1445 changes in 1 year Tietze, Heiko made 60 changes in 1 month, and 1975 changes in 1 year Thomas Lendo made 47 changes in 1 month, and 161 changes in 1 year Buovjaga made 45 changes in 1 month, and 391 changes in 1 year Cor Nouws made 19 changes in 1 month, and 391 changes in 1 year Henschel, Regina made 16 changes in 1 month, and 141 changes in 1 year Foote, V Stuart made 15 changes in 1 month, and 621 changes in 1 year Timur made 14 changes in 1 month, and 45 changes in 1 year Telesto made 12 changes in 1 month, and 58 changes in 1 year Iversen, Jan made 11 changes in 1 month, and 318 changes in 1 year + working on refinement for GsoC + final adjustments to layout + projects are running (well) + students coming to the design meeting. * Crash Reporting (Caolan) + 4(+3) import failure, 1(+0) export failures + new assert from Miklos; rest seem to be transient + 33 coverity issues, down + have a patch to reduce them + 28 fuzzers + silent for a week, so adding ww8 filters now. + schedule decision; 90 day count-down from discovery + when fixed – 30 day count-down. + schedule gap from 5.2 being unavailble and 5.4 appearing + push this month, bits to master. + will remove 5.2 from download page temporarily (Christian) => closes the gap. + 30 days from today ok ? + yes => pushing things today. * Perugia Hackfest retrospective (Cloph, Eike,
minutes of ESC call ...
* Present: + Caolan, Heiko, Kendy, Miklos, Olivier, Michael M, Stephan, Sebastian, Sophie, Christian, Eike, Michael S, Xisco * Completed Action Items: + get 5.4 deprecated section proposals here (Eike, thanks to buovjaga) + state in the release notes that 5.4 will be the very last release supporting Windows XP and Vista (Eike, thanks to Stuart) + cf. https://bugs.documentfoundation.org/show_bug.cgi?id=108043 + Windows builds use internal ICU 58 again + cherry-pick commit bringing Mac base-line up to 10.9 (Miklos) + quantify potential size saving from live help screenshot (Olivier) [ ~35M per language (Olivier) + in current downloads ? < 3.5Gb. + help content is 7Mb or so, if add all screenshots will be 35M will save 29Mb each + idea in the past – run screenshots on installing help package. + takes time to make screenshots & things flicker ] AI: + come up with a concrete, deliverable plan for discussion (Olivier) * Pending Action Items: + Developer Certification – next round (Stephan/Bjoern/Kendy/Thorsten) [ still pending ] * Release Engineering update (Christian) + 5.4.0 Beta 2 – June 6th + hard break / tag on Tuesday; not shifting it back. + no additional reviews necessary on the branch, you can push yourself until June 20th + late features + Windows support for gpg sign/encrypt (?) (Thorsten) + 5.3.4 RC1 – May 30th + due this week, not tagged yet + but all patches waiting with out -1 were integrated + minor UI freeze break in options page – approved by Sophie/Olivier + Android & iOS Remote + no release, but poked at it in the hack-fest; new release pending. + online – Beta2 coming up. + git / problems with replication to freedesktop + appeared to fix itself. + perf. issues fixed by a ‘git gc’ on repos. + marketing decided to use 6.0 for next release (Heiko) + versions / bug notifications etc. talk of 5.5 AI: + check with Italo, and change the version info in configure.ac (Christian) * Documentation (Olivier) + online help rewritten – to static html (Olivier) + flattening all the XML. + discussing it with Kendy. + enthusiasm for the new solution here. + preserves all the help / translation editing tools etc. + a couple of scripts to flatten the XML – browser portable. + New help pages fixed and added (G. Kelemen) + Fix of Helpauthoring to support tags (Jean Spiteri / Liongold) + superscript / subscript. + New doc for download (quick reference card) (Valdir Barbosa) + Docs team calls ? (Michael) + new guy from Italy, learning help authoring tools. + next week – will have another meeting. * UX Update (Heiko) + Bugzilla (topicUI) statistics 257(257) (topicUI) bugs open, 472(472) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week 1 month 3 months 12 months added 6(3) 17(1) 36(3) 457(-9) commented 52(5)212(2)577(37)3500(-19) removed 0(0) 0(-1) 5(-1) 42(0) resolved 3(0) 10(2) 47(-1) 232(2) + top 10 contributors: Philips, Yousuf made 192 changes in 1 month, and 1445 changes in 1 year Tietze, Heiko made 60 changes in 1 month, and 1975 changes in 1 year Thomas Lendo made 47 changes in 1 month, and 161 changes in 1 year Buovjaga made 45 changes in 1 month, and 391 changes in 1 year Cor Nouws made 19 changes in 1 month, and 391 changes in 1 year Henschel, Regina made 16 changes in 1 month, and 141 changes in 1 year Foote, V Stuart made 15 changes in 1 month, and 621 changes in 1 year Timur made 14 changes in 1 month, and 45 changes in 1 year Telesto made 12 changes in 1 month, and 58 changes in 1 year Iversen, Jan made 11 changes in 1 month, and 318 changes in 1 year + working on refinement for GsoC + final adjustments to layout + projects are running (well) + students coming to the design meeting. * Crash Reporting (Caolan) + 4(+3) import failure, 1(+0) export failures + new assert from Miklos; rest seem to be transient + 33 coverity issues, down + have a patch to reduce them + 28 fuzzers + silent for a week, so adding ww8 filters now. + schedule decision; 90 day count-down from discovery + when fixed – 30 day count-down. + schedule gap from 5.2 being unavailble and 5.4 appearing + push this month, bits to master. + will remove 5.2 from download page temporarily (Christian) => closes the gap. + 30 days from today ok ? + yes => pushing things today. * Perugia Hackfest retrospective (Cloph, Eike,
[Libreoffice-bugs] [Bug 108281] Writer 5.2.x and 5.3.x vertical text alignment diference
https://bugs.documentfoundation.org/show_bug.cgi?id=108281 V Stuart Footechanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 --- Comment #2 from V Stuart Foote --- Can not confirm on Windows 10 with Version: 5.3.3.2 (x64) Build ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448 CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; Locale: en-US (en_US); Calc: group where layout of a new document using the template is the same as on Version: 5.2.7.2 Build ID: 2b7f1e640c46ceb28adf43ee075a6e8b8439ed10 CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; Locale: en-US (en_US); Calc: group Turn on the "Formatting marks" View -> Formatting marks, or +F10 to see the empty paragraphs. For me in both 5.3.3.2 and 5.2.7.2 the third cell of the table used for the Heading shows an empty paragraph entered in the template. Remove that extra line, and the document's header matches your 5.2.7 clip. Did the .odt template simply become corrupt gaining an extra line in that table cell? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55204] FILEOPEN PPTX Mangled plots
https://bugs.documentfoundation.org/show_bug.cgi?id=55204 Buovjagachanged: What|Removed |Added Keywords||filter:pptx Summary|VIEWING: Mangled plots |FILEOPEN PPTX Mangled plots -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95555] FILEOPEN RTF Frames overlap in document created by Oracle Reports
https://bugs.documentfoundation.org/show_bug.cgi?id=9 Buovjagachanged: What|Removed |Added Keywords||filter:rtf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107634] [META] Fontwork / WordArt bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107634 Buovjagachanged: What|Removed |Added Depends on||51672 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=51672 [Bug 51672] FILEOPEN XLS Issues with wordart gradients and shadow -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51672] FILEOPEN XLS Issues with wordart gradients and shadow
https://bugs.documentfoundation.org/show_bug.cgi?id=51672 Buovjagachanged: What|Removed |Added Keywords||filter:xls Blocks||107634 Summary|[XLS] issues with wordart |FILEOPEN XLS Issues with |gradients and shadow|wordart gradients and ||shadow Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107634 [Bug 107634] [META] Fontwork / WordArt bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107627] Calc crashes when closing a document
https://bugs.documentfoundation.org/show_bug.cgi?id=107627 --- Comment #17 from Buovjaga--- (In reply to superurbi from comment #16) > Could it be a hardware problem? Related to memory? > > Regards, https://www.raymond.cc/blog/memory-test-for-macos-x/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108208] LO will not open in windows 10 creators update
https://bugs.documentfoundation.org/show_bug.cgi?id=108208 --- Comment #9 from fdheal...@yahoo.com --- (In reply to V Stuart Foote from comment #8) > (In reply to fdhealy54 from comment #7) > > Where are the log files so I can zip them up and post them for you. > > If you were able to change directory while in the command prompt into the > folder holding the .msi installer package, the "/L*v ,somefilename> verbose > log will be created with in that folder. Sorry but that is beyond my pay grade so to say. Do you have the ability to remotely connect to my computer? Dale -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/sdi sc/source
sc/sdi/formatsh.sdi|2 +- sc/source/ui/view/formatsh.cxx | 11 ++- sc/source/ui/view/tabview3.cxx |1 + 3 files changed, 12 insertions(+), 2 deletions(-) New commits: commit 9c7e9cbdaf06b0bbd1f8a476e77b9a3172c99ef6 Author: Gulsah KoseDate: Tue May 30 15:45:24 2017 +0300 tdf#86119 Fix toggle behaviour of SID_NUMBER_STANDARD. Change-Id: I718869c92a3a03c05b8db3fe665f5502202f434b Signed-off-by: Gulsah Kose Reviewed-on: https://gerrit.libreoffice.org/38217 Tested-by: Jenkins (cherry picked from commit 82beda528fb74ae1c6b5e12a98dbf5d4e9e4c0db) Reviewed-on: https://gerrit.libreoffice.org/38233 diff --git a/sc/sdi/formatsh.sdi b/sc/sdi/formatsh.sdi index 3663955aadfa..54771a8dbb80 100644 --- a/sc/sdi/formatsh.sdi +++ b/sc/sdi/formatsh.sdi @@ -110,7 +110,7 @@ interface FormatForSelection SID_NUMBER_CURRENCY [ ExecMethod = ExecuteNumFormat; StateMethod = GetNumFormatState; ] SID_NUMBER_PERCENT [ ExecMethod = ExecuteNumFormat; StateMethod = GetNumFormatState; ] SID_NUMBER_TIME [ ExecMethod = ExecuteNumFormat; StateMethod = GetNumFormatState; ] -SID_NUMBER_STANDARD [ ExecMethod = ExecuteNumFormat;] +SID_NUMBER_STANDARD [ ExecMethod = ExecuteNumFormat; StateMethod = GetNumFormatState; ] SID_NUMBER_INCDEC [ ExecMethod = ExecuteNumFormat;] SID_NUMBER_DECDEC [ ExecMethod = ExecuteNumFormat;] diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx index 259338a37ab4..cef3eab48bc3 100644 --- a/sc/source/ui/view/formatsh.cxx +++ b/sc/source/ui/view/formatsh.cxx @@ -1127,7 +1127,9 @@ void ScFormatShell::ExecuteNumFormat( SfxRequest& rReq ) rReq.Done(); break; case SID_NUMBER_STANDARD: -pTabViewShell->SetNumberFormat( css::util::NumberFormat::NUMBER ); +if (!(nType & css::util::NumberFormat::NUMBER)) +pTabViewShell->SetNumberFormat( css::util::NumberFormat::NUMBER ); +rBindings.Invalidate( nSlot ); rReq.Done(); break; case SID_NUMBER_INCDEC: @@ -2637,6 +2639,13 @@ void ScFormatShell::GetNumFormatState( SfxItemSet& rSet ) rSet.Put( SfxBoolItem(nWhich, (nType & css::util::NumberFormat::NUMBER) && nNumberFormat == 4 ) ); } break; +case SID_NUMBER_STANDARD: +{ +const SfxItemSet& rAttrSet = pTabViewShell->GetSelectionPattern()->GetItemSet(); +sal_uInt32 nNumberFormat = static_cast(rAttrSet.Get(ATTR_VALUE_FORMAT)).GetValue(); +rSet.Put( SfxBoolItem(nWhich, (nType & css::util::NumberFormat::NUMBER) && nNumberFormat == 0 ) ); +} +break; } nWhich = aIter.NextWhich(); } diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx index 25421ad60c52..390e8ef37a53 100644 --- a/sc/source/ui/view/tabview3.cxx +++ b/sc/source/ui/view/tabview3.cxx @@ -322,6 +322,7 @@ void ScTabView::InvalidateAttribs() rBindings.Invalidate( SID_NUMBER_PERCENT ); rBindings.Invalidate( SID_NUMBER_TWODEC ); rBindings.Invalidate( SID_NUMBER_TIME ); +rBindings.Invalidate( SID_NUMBER_STANDARD ); } // SetCursor - Cursor, set, draw, update InputWin ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sw/source sw/uiconfig
sw/source/ui/frmdlg/frmpage.cxx | 14 +++ sw/source/uibase/inc/frmpage.hxx |2 sw/source/uibase/shells/frmsh.cxx|6 + sw/source/uibase/shells/grfsh.cxx|6 + sw/uiconfig/swriter/ui/frmaddpage.ui | 160 +-- 5 files changed, 107 insertions(+), 81 deletions(-) New commits: commit 509029dd9583a4b3328ad72b91054ff8b54d5535 Author: Gulsah KoseDate: Fri May 26 15:14:45 2017 +0300 tdf#107589 Make description editable from Options tab. That commit makes possible to edit descriptions of images frames and objects from "Options" tab of Object/Properties dialogs Change-Id: I62d06b32da6919df62ff77b50c4c77d6a265bd64 Signed-off-by: Gulsah Kose Reviewed-on: https://gerrit.libreoffice.org/38176 Tested-by: Jenkins (cherry picked from commit 61ff1d919e317947c769e61eeda7f1bb8132f273) Reviewed-on: https://gerrit.libreoffice.org/38234 diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx index b26dd9916e82..3a85effb9647 100644 --- a/sw/source/ui/frmdlg/frmpage.cxx +++ b/sw/source/ui/frmdlg/frmpage.cxx @@ -382,6 +382,7 @@ const sal_uInt16 SwFrameAddPage::aAddPgRg[] = { RES_PRINT, RES_PRINT, FN_SET_FRM_NAME,FN_SET_FRM_NAME, FN_SET_FRM_ALT_NAME,FN_SET_FRM_ALT_NAME, +FN_UNO_DESCRIPTION, FN_UNO_DESCRIPTION, 0 }; @@ -2875,6 +2876,8 @@ SwFrameAddPage::SwFrameAddPage(vcl::Window *pParent, const SfxItemSet ) get(m_pPrevLB,"prev"); get(m_pNextFT,"next_label"); get(m_pNextLB,"next"); +get(m_pDescriptionFT, "description_label"); +get(m_pDescriptionED, "description"); get(m_pProtectFrame,"protect"); get(m_pProtectContentCB,"protectcontent"); @@ -2890,6 +2893,7 @@ SwFrameAddPage::SwFrameAddPage(vcl::Window *pParent, const SfxItemSet ) get(m_pTextFlowFT,"textflow_label"); get(m_pTextFlowLB,"textflow"); + m_pDescriptionED->set_height_request(m_pDescriptionED->get_preferred_size().Height()); } SwFrameAddPage::~SwFrameAddPage() @@ -2919,6 +2923,8 @@ void SwFrameAddPage::dispose() m_pPrintFrameCB.clear(); m_pTextFlowFT.clear(); m_pTextFlowLB.clear(); +m_pDescriptionFT.clear(); +m_pDescriptionED.clear(); SfxTabPage::dispose(); } @@ -2955,6 +2961,12 @@ void SwFrameAddPage::Reset(const SfxItemSet *rSet ) m_pAltNameED->SaveValue(); } +if(SfxItemState::SET == rSet->GetItemState(FN_UNO_DESCRIPTION, false, )) +{ +m_pDescriptionED->SetText(static_cast(pItem)->GetValue()); +m_pDescriptionED->SaveValue(); +} + if(!m_bFormat) { // insert graphic - properties @@ -3120,6 +3132,8 @@ bool SwFrameAddPage::FillItemSet(SfxItemSet *rSet) bRet |= nullptr != rSet->Put(SfxStringItem(FN_SET_FRM_NAME, m_pNameED->GetText())); if (m_pAltNameED->IsValueChangedFromSaved()) bRet |= nullptr != rSet->Put(SfxStringItem(FN_SET_FRM_ALT_NAME, m_pAltNameED->GetText())); +if (m_pDescriptionED->IsValueChangedFromSaved()) +bRet |= nullptr != rSet->Put(SfxStringItem(FN_UNO_DESCRIPTION, m_pDescriptionED->GetText())); const SfxPoolItem* pOldItem; SvxProtectItem aProt ( static_cast(GetItemSet().Get(RES_PROTECT)) ); diff --git a/sw/source/uibase/inc/frmpage.hxx b/sw/source/uibase/inc/frmpage.hxx index 63fb4db07eb6..9aa04255aab4 100644 --- a/sw/source/uibase/inc/frmpage.hxx +++ b/sw/source/uibase/inc/frmpage.hxx @@ -278,6 +278,8 @@ class SwFrameAddPage : public SfxTabPage VclPtr m_pNameED; VclPtrm_pAltNameFT; VclPtr m_pAltNameED; +VclPtrm_pDescriptionFT; +VclPtr m_pDescriptionED; VclPtrm_pPrevFT; VclPtr m_pPrevLB; VclPtrm_pNextFT; diff --git a/sw/source/uibase/shells/frmsh.cxx b/sw/source/uibase/shells/frmsh.cxx index b617d3fa9970..a008774512a8 100644 --- a/sw/source/uibase/shells/frmsh.cxx +++ b/sw/source/uibase/shells/frmsh.cxx @@ -408,9 +408,9 @@ void SwFrameShell::Execute(SfxRequest ) FN_SURROUND,FN_HORI_ORIENT, // [21303 FN_SET_FRM_NAME,FN_KEEP_ASPECT_RATIO, // [21306 FN_SET_FRM_ALT_NAME,FN_SET_FRM_ALT_NAME, // [21318 +FN_UNO_DESCRIPTION, FN_UNO_DESCRIPTION, // [21320 FN_OLE_IS_MATH, FN_MATH_BASELINE_ALIGNMENT, // [22314 FN_PARAM_CHAIN_PREVIOUS, FN_PARAM_CHAIN_NEXT, // [22420 - 0); // create needed items for XPropertyList entries from the DrawModel so that @@ -423,6 +423,7 @@ void SwFrameShell::Execute(SfxRequest ) aSet.Put( SfxBoolItem(FN_KEEP_ASPECT_RATIO, pVOpt->IsKeepRatio()) );
[Libreoffice-bugs] [Bug 108208] LO will not open in windows 10 creators update
https://bugs.documentfoundation.org/show_bug.cgi?id=108208 --- Comment #8 from V Stuart Foote--- (In reply to fdhealy54 from comment #7) > Where are the log files so I can zip them up and post them for you. If you were able to change directory while in the command prompt into the folder holding the .msi installer package, the "/L*v ,somefilename> verbose log will be created with in that folder. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105863] Flicker when hovering over main menu with default rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=105863 --- Comment #15 from DoMi.--- For me, the menu flickers with version above 5.3.1.2. It's ok with version 5.3.1.2 with a NVIDIA Quadro 2000M and drivers 21.21.13.7586. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 3 commits - loleaflet/src wsd/ClientSession.cpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/protocol.txt wsd/Storage.cpp wsd/Storage.hpp
loleaflet/src/control/Toolbar.js |4 +++- loleaflet/src/core/Socket.js | 30 ++ wsd/ClientSession.cpp| 14 ++ wsd/DocumentBroker.cpp | 17 - wsd/DocumentBroker.hpp |8 +++- wsd/Storage.cpp | 15 --- wsd/Storage.hpp |8 +++- wsd/protocol.txt | 12 8 files changed, 97 insertions(+), 11 deletions(-) New commits: commit 41234773e3b57e1695951bddaedb4f61ad44026d Author: Pranav KantDate: Thu Jun 1 19:46:03 2017 +0530 If user permits, save to storage force-fully in case of doc conflict There is one known problem still - after any user decides to overwrite the file to storage, other users are not informed, so their dialog keeps hanging on the screen until they press the cancel or reload button. Change-Id: I6dad1585e4c53eeed79cd38316892a7f239d44ef diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js index 681a8ecc..b5f68749 100644 --- a/loleaflet/src/control/Toolbar.js +++ b/loleaflet/src/control/Toolbar.js @@ -131,7 +131,9 @@ L.Map.include({ }, save: function(dontTerminateEdit, dontSaveIfUnmodified) { - this._socket.sendMessage('save dontTerminateEdit=' + (dontTerminateEdit ? 1 : 0) + ' dontSaveIfUnmodified=' + (dontSaveIfUnmodified ? 1 : 0)); + this._socket.sendMessage('save' + +' dontTerminateEdit=' + (dontTerminateEdit ? 1 : 0) + +' dontSaveIfUnmodified=' + (dontSaveIfUnmodified ? 1 : 0)); }, sendUnoCommand: function (command, json) { diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js index a65a330a..1d6b884f 100644 --- a/loleaflet/src/core/Socket.js +++ b/loleaflet/src/core/Socket.js @@ -357,7 +357,7 @@ L.Socket = L.Class.extend({ this.sendMessage('closedocument'); } else { // They want to overwrite - this.sendMessage('documentconflict.overwrite'); + this.sendMessage('savetostorage force=1'); } }, this) }); diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp index 4ba8988f..7af580bb 100644 --- a/wsd/ClientSession.cpp +++ b/wsd/ClientSession.cpp @@ -136,6 +136,7 @@ bool ClientSession::_handleInput(const char *buffer, int length) tokens[0] != "resetselection" && tokens[0] != "save" && tokens[0] != "saveas" && + tokens[0] != "savetostorage" && tokens[0] != "selectgraphic" && tokens[0] != "selecttext" && tokens[0] != "setclientpart" && @@ -221,6 +222,12 @@ bool ClientSession::_handleInput(const char *buffer, int length) getTokenInteger(tokens[2], "dontSaveIfUnmodified", dontSaveIfUnmodified); docBroker->sendUnoSave(getId(), dontTerminateEdit != 0, dontSaveIfUnmodified != 0); } +else if (tokens[0] == "savetostorage") +{ +int force = 0; +getTokenInteger(tokens[1], "force", force); +docBroker->saveToStorage(getId(), true, "" /* This is irrelevant when success is true*/, true); +} else { if (!filterMessage(firstLine)) diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp index 9b282165..981834fa 100644 --- a/wsd/DocumentBroker.cpp +++ b/wsd/DocumentBroker.cpp @@ -544,10 +544,15 @@ bool DocumentBroker::load(const std::shared_ptr& session, const s } bool DocumentBroker::saveToStorage(const std::string& sessionId, - bool success, const std::string& result) + bool success, const std::string& result, bool force) { assertCorrectThread(); +if (force) +{ +LOG_TRC("Document will be saved forcefully to storage."); +_storage->forceSave(); +} const bool res = saveToStorageInternal(sessionId, success, result); // If marked to destroy, or session is disconnected, remove. diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp index 588df3fd..7f563647 100644 --- a/wsd/DocumentBroker.hpp +++ b/wsd/DocumentBroker.hpp @@ -240,7 +240,7 @@ public: bool isDocumentChangedInStorage() { return _documentChangedInStorage; } /// Save the document to Storage if it needs persisting. -bool saveToStorage(const std::string& sesionId, bool success, const std::string& result = ""); +bool saveToStorage(const std::string& sesionId, bool success, const std::string& result = "", bool
[Libreoffice-bugs] [Bug 108050] 5.3.3-Writer hangs on Windows 7 machine
https://bugs.documentfoundation.org/show_bug.cgi?id=108050 niall.cavan...@ymail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #2 from niall.cavan...@ymail.com --- It appears that the test file was in some way corrupt, so it was not a valid test. The same issues occur in the 5.3.2_x86 version which I had rolled back to. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108208] LO will not open in windows 10 creators update
https://bugs.documentfoundation.org/show_bug.cgi?id=108208 --- Comment #7 from fdheal...@yahoo.com --- Where are the log files so I can zip them up and post them for you. Dale -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108245] Change column format to "Date" adds ' to the beginning of field
https://bugs.documentfoundation.org/show_bug.cgi?id=108245 Jacques Guilleronchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108245] Change column format to "Date" adds ' to the beginning of field
https://bugs.documentfoundation.org/show_bug.cgi?id=108245 --- Comment #10 from Jacques Guilleron--- Created attachment 133785 --> https://bugs.documentfoundation.org/attachment.cgi?id=133785=edit a way to reproduce. This is the usual behaviour. Most of the time, those apostrophes (simple quote marks) are added when we import table from web or a database. They are texts and, with or without apostrophe, they are aligned to left. This behaviour can be reproduce. I joined a document to show how it works. Column A was first text formated and filled next with numbers. Column B is a copie of column A, but an apostrophe was automaticly added at the copie time. Column D is get from column C by a formula, and give also a quoted column E by copie. Column B as column E can be transform to values by selecting them and Data > Text to columns… Another way to do that is to multiply by 1 or use a formula like =VALUE() Ok for the beer the next time we meet. Jacques -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Changes to 'refs/tags/2.1.2-rc1'
Tag '2.1.2-rc1' created by Andras Timarat 2017-06-01 14:08 + 2.1.2-rc1 Changes since 2.1.2-beta2-12: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits