[Libreoffice-bugs] [Bug 109189] Statusbar sum and average calculation with decimal values equivalent to zero sometimes shows incorrect negative exponential value
https://bugs.documentfoundation.org/show_bug.cgi?id=109189 b. changed: What|Removed |Added Keywords||needsDevEval CC||newbie...@gmx.de --- Comment #8 from b. --- @all: careful, long, but has info with solution potential! @jay: nice job in narrowing down, you had the fish hooked, but i think it was too diverse an interaction to understand right away? imho there are five effects mixed here: 1. calc doe's some 'rough' rounding, especially near zero results, but not or less strict for the statusbar, 2. bin representations of most fractional decimal values are not exact but contain small deviations, 3. these deviations may add up in calculations, 4. especially when subtracting values of similar magnitude deviations are boosted (powered) in their relative! effect on the result, and thus sometimes become visible, 5. above may give different results for computing the same operands in different order, 6. calc uses different calculation engines for the sheet and for the status bar resulting in different calculation orders, and thus - sometimes - different results, ... why? ... i don't know ... - that for the sheet starts bottom right and calculates rightmost column bottom up, then continues with nextleft column, - that for the statusbar starts leftmost column top -> down, then continues with nextright column, - ex$el deviates and starts top row left to right, continues with rows top down, (i just filed a bug for that as it undermines calc - ex$el compatibility, tdf#140691) - ex$el statusbar / autosum - to be honest - i haven' yet deciphered, it's sometimes by row left right top down, sometimes by column top down left right, and looks depending on the field marked, only the cells to be calculated or empty cells around included and whatever more ... might be also where you started marking, might be depending if marked by mousedrag or keyboard ... not yet understood, above: info for this bug - below: further reflections (important?) didn't check how google or similar work, but already within theese three it's deviations enough as fp-math is not in all cases associative (in fact it's only for very few cases), and thus different results come up, if you then try to achieve ex$el compatibility by rounding you may quickly come to a status as calc is now, rounding here and there, and nobody knows why it doesn't work ... the idiosyncrasy of calc dates back to 3.5.1.2 and may be former ver., i - assume - 'inherited', imho an important decision, what do we want? achieve full ex$el compatibility, or keep calc backward compatible? and the longer i think about i get the feeling - 'assume' (sorry@erAck) - that such might be one of the root causes for multiple calc problems, users complain about deviating from ex$el, devs don't understand why ... 'let's try some more rounding', not good!, step one: check if i'm right with that analysis, step two: spread that info, step three: let the big brains think about and find a solution, (my proposal: an option switch and two modi, 'calc - correct math' or 'ex$el - as compatible as possible', then you would have clear targets and can work straightforward ...) besides: repro with: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 62dff2844b0bf1d1bcb8eb4d6db529ef4a31bee4 CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140960] LibreOffice is not crashing but the system kept on informing me that LibreOffice had crashed
https://bugs.documentfoundation.org/show_bug.cgi?id=140960 mac-w...@sjtu.edu.cn changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from mac-w...@sjtu.edu.cn --- Dear Mz. Nabet: I have applied the contents in https://wiki.documentfoundation.org/QA/FirstSteps. I had my user profile restored, but sadly this bug happened again. Also, I can be sure that this bug is not concerning OpenGL or OpenCL, since I was not using Calc and I am also observing this bug with OpenGL off. I have not tried the second method (export SAL_USE_VCLPLUGIN=gen). However, this time, a new and "useful" backtrace log had been generated. From the bug report, I can guess that this bug is somewhat related to Qt5 and/or Kf5 (I'm not a programmer myself so forgive my mistake). The newly-generated bug report is attached below. [Backtrace log] Application: soffice (soffice), signal: Segmentation fault [KCrash Handler] #4 0x7f7090c215be in SdTransferable::ObjectReleased() () from /usr/lib64/libreoffice/program/../program/libsdlo.so #5 0x7f7090c2d555 in SdTransferable::~SdTransferable() () from /usr/lib64/libreoffice/program/../program/libsdlo.so #6 0x7f7090c2dbe9 in SdTransferable::~SdTransferable() () from /usr/lib64/libreoffice/program/../program/libsdlo.so #7 0x7f70d8792737 in Qt5MimeData::~Qt5MimeData() () from /usr/lib64/libreoffice/program/libvclplug_qt5lo.so #8 0x7f70d175a45c in QXcbClipboard::~QXcbClipboard (this=0x7f70c8005dd0, __in_chrg=) at qxcbclipboard.cpp:274 #9 0x7f70d175a609 in QXcbClipboard::~QXcbClipboard (this=0x7f70c8005dd0, __in_chrg=) at qxcbclipboard.cpp:276 #10 0x7f70d176103b in QXcbConnection::~QXcbConnection (this=0x55562ad6a920, __in_chrg=) at qxcbconnection.cpp:141 #11 0x7f70d1761639 in QXcbConnection::~QXcbConnection (this=0x55562ad6a920, __in_chrg=) at qxcbconnection.cpp:159 #12 0x7f70d1762846 in qDeleteAll::const_iterator> (end=..., begin=...) at ../../../../include/QtCore/../../src/corelib/tools/qalgorithms.h:320 #13 qDeleteAll > (c=...) at ../../../../include/QtCore/../../src/corelib/tools/qalgorithms.h:328 #14 QXcbIntegration::~QXcbIntegration (this=0x55562ad60590, __in_chrg=) at qxcbintegration.cpp:229 #15 0x7f70d1762949 in QXcbIntegration::~QXcbIntegration (this=0x55562ad60590, __in_chrg=) at qxcbintegration.cpp:231 #16 0x7f70d975815d in QGuiApplicationPrivate::~QGuiApplicationPrivate (this=0x55562ad5b170, __in_chrg=) at kernel/qguiapplication.cpp:1645 #17 0x7f70d8f0a819 in QApplicationPrivate::~QApplicationPrivate (this=0x55562ad5b170, __in_chrg=) at kernel/qapplication.cpp:181 #18 0x7f70da126633 in QScopedPointerDeleter::cleanup (pointer=) at ../../include/QtCore/../../src/corelib/tools/qscopedpointer.h:60 #19 QScopedPointer >::~QScopedPointer (this=0x55562ad59528, __in_chrg=) at ../../include/QtCore/../../src/corelib/tools/qscopedpointer.h:107 #20 QObject::~QObject (this=, __in_chrg=) at kernel/qobject.cpp:892 #21 0x7f70da0f18f6 in QCoreApplication::~QCoreApplication (this=0x55562ad59520, __in_chrg=) at kernel/qcoreapplication.cpp:892 #22 0x7f70d975bb60 in QGuiApplication::~QGuiApplication (this=0x55562ad59520, __in_chrg=) at kernel/qguiapplication.cpp:649 #23 0x7f70d8f0c989 in QApplication::~QApplication (this=0x55562ad59520, __in_chrg=) at kernel/qapplication.cpp:773 #24 0x7f70d8f0cb89 in QApplication::~QApplication (this=0x55562ad59520, __in_chrg=) at kernel/qapplication.cpp:843 #25 0x7f70d8775a37 in Qt5Instance::~Qt5Instance() () from /usr/lib64/libreoffice/program/libvclplug_qt5lo.so #26 0x7f70ef89b9cb in non-virtual thunk to KF5SalInstance::~KF5SalInstance() () from /usr/lib64/libreoffice/program/libvclplug_kf5lo.so #27 0x7f70ee03fa43 in DeInitVCL() () from /usr/lib64/libreoffice/program/libmergedlo.so #28 0x7f70ee03fe3a in ImplSVMain() () from /usr/lib64/libreoffice/program/libmergedlo.so #29 0x7f70ed617665 in soffice_main () from /usr/lib64/libreoffice/program/libmergedlo.so #30 0x5556291cf77b in main () [Inferior 1 (process 8248) detached] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/inc
cui/inc/tipoftheday.hrc |1 -
1 file changed, 1 deletion(-)
New commits:
commit 6cae56fe25a51c9c0ec05253be8508940a013eee
Author: Xisco Fauli
AuthorDate: Fri Mar 12 12:11:10 2021 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Mar 12 19:59:16 2021 +0100
TipOfTheDay: remove odd tip regarding GSOC
Change-Id: I4d7111de1fb734c51e6449913caa52adaf43b594
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112381
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/cui/inc/tipoftheday.hrc b/cui/inc/tipoftheday.hrc
index d809446acf6d..6483d0335f61 100644
--- a/cui/inc/tipoftheday.hrc
+++ b/cui/inc/tipoftheday.hrc
@@ -107,7 +107,6 @@ const std::tuple
TIPOFTHEDAY_STRINGARRAY[] =
{ NC_("RID_CUI_TIPOFTHEDAY", "To enable macro recording, check Tools ▸
Options ▸ %PRODUCTNAME ▸ Advanced ▸ Enable macro recording."), "", ""},
{ NC_("RID_CUI_TIPOFTHEDAY", "Want to insert a placeholder for an image
in a Writer template? Use Insert ▸ Fields ▸ More fields, click Functions tab,
choose PlaceHolder for Type and Image for Format."), "", "tipoftheday_w.png"},
{ NC_("RID_CUI_TIPOFTHEDAY", "%PRODUCTNAME supports four macro security
levels (from low to very high) and trusted sources."),
"cui/ui/optsecuritypage/OptSecurityPage", ""}, //
https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/shared/optionen/01030300.html
- { NC_("RID_CUI_TIPOFTHEDAY", "%PRODUCTNAME intends to apply as an
organization for Google Summer of Code (GSoC) see:"),
"https://wiki.documentfoundation.org/Development/GSoC;, ""},
{ NC_("RID_CUI_TIPOFTHEDAY", "Did you know that you can attach comments
to portions of text? Just use the shortcut %MOD1+%MOD2+C."), "", ""},
{ NC_("RID_CUI_TIPOFTHEDAY", "Need to move one or more paragraphs? No
need to cut and paste: Use the keyboard shortcut %MOD1+%MOD2+Arrow (Up/Down)"),
"", "tipoftheday_w.png"},
{ NC_("RID_CUI_TIPOFTHEDAY", "Change the basic fonts for the predefined
template or current document per Tools ▸ Options ▸ %PRODUCTNAME Writer ▸ Basic
Fonts."), "modules/swriter/ui/optfonttabpage/OptFontTabPage",
"tipoftheday_w.png"},
//https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/shared/optionen/01040300.html
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sal/osl sfx2/source
sal/osl/w32/file.cxx|2 +-
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 5e404d6289f433e72218e13ed5a083b59dbc307b
Author: Andrea Gelmini
AuthorDate: Fri Mar 12 17:19:32 2021 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Mar 12 19:54:29 2021 +0100
Fix typos
Change-Id: I7366c5e7d6c9fb4dd7aa17a5d0405f28179a92af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112399
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sal/osl/w32/file.cxx b/sal/osl/w32/file.cxx
index 44b8ac97ba09..1c13b6211779 100644
--- a/sal/osl/w32/file.cxx
+++ b/sal/osl/w32/file.cxx
@@ -657,7 +657,7 @@ oslFileError SAL_CALL osl_openFile(
if (result != osl_File_E_None)
return result;
-// tdf126742 use FILE_SHARE_WRITE to get closer to non-Windows plattform
behavoiur,
+// tdf126742 use FILE_SHARE_WRITE to get closer to non-Windows platform
behaviour,
// for details and discussion see task please
DWORD dwAccess = GENERIC_READ, dwShare = FILE_SHARE_READ |
FILE_SHARE_WRITE, dwCreation = 0;
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index 6b6a1bdfcc1d..58f14e16274a 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -442,7 +442,7 @@ public:
bool shouldShowExpander() override
{
-// Show expnder only if the sequence has elements
+// Show expander only if the sequence has elements
int nLength = mxIdlArray->getLen(maAny);
return nLength > 0;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sw/source
sw/source/uibase/shells/tabsh.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit f71efcdc4c8525bdf93becfc66b57bccd47f88c4
Author: Caolán McNamara
AuthorDate: Fri Mar 12 12:57:57 2021 +
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Mar 12 19:53:27 2021 +0100
tdf#140977 drop possible table-cursor before setting the new one
Change-Id: I3d278af77886af3413b4a15464c8a52caa9a8e02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112310
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/uibase/shells/tabsh.cxx
b/sw/source/uibase/shells/tabsh.cxx
index 34d98f61edd9..036274546d04 100644
--- a/sw/source/uibase/shells/tabsh.cxx
+++ b/sw/source/uibase/shells/tabsh.cxx
@@ -600,6 +600,9 @@ void SwTableShell::Execute(SfxRequest )
pDlg->StartExecuteAsync([pDlg, pRequest, pTableRep,
, , vCursors](sal_Int32 nResult){
if (RET_OK == nResult)
{
+if (rSh.IsTableMode()) // tdf#140977 drop possible
table-cursor before setting the new one
+rSh.TableCursorToCursor();
+
rSh.SetSelection(*vCursors->front()); // tdf#135636
set the table selected at dialog launch as current selection
const SfxItemSet* pOutSet = pDlg->GetOutputItemSet();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa
sw/qa/core/objectpositioning/data/inside-outside-vert-align.docx |binary sw/qa/core/objectpositioning/objectpositioning.cxx |4 ++-- sw/qa/extras/layout/data/tdf116486.docx |binary sw/qa/extras/ooxmlexport/data/effectextent-margin.docx |binary sw/qa/extras/ooxmlexport/data/tdf133045_TestShapeAlignmentRelativeFromTopMargin.docx |binary sw/qa/extras/ooxmlexport/data/textframe-gradient.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport6.cxx |6 +++--- 7 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 0fc76a646233bebebbca3f86144f30eb32a5d60c Author: Miklos Vajna AuthorDate: Fri Mar 12 18:12:11 2021 +0100 Commit: Miklos Vajna CommitDate: Fri Mar 12 19:40:15 2021 +0100 CppunitTest_sw_ooxmlexport: clean up testEffectExtentMargin The shape had line information, but the intent was to test what happens when the shape has some non-zero effect extent, line information is not needed for that. And do the same for a bunch of other tests: a test document should ideally have line information only if it's relevant for a test. Change-Id: I9ea1f38841a30e7e61088d347443e37948b1a9d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112401 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sw/qa/core/objectpositioning/data/inside-outside-vert-align.docx b/sw/qa/core/objectpositioning/data/inside-outside-vert-align.docx index 15d2dca0775e..1308e1f6a8a5 100644 Binary files a/sw/qa/core/objectpositioning/data/inside-outside-vert-align.docx and b/sw/qa/core/objectpositioning/data/inside-outside-vert-align.docx differ diff --git a/sw/qa/core/objectpositioning/objectpositioning.cxx b/sw/qa/core/objectpositioning/objectpositioning.cxx index 7b9a3eca2831..9817b9b05233 100644 --- a/sw/qa/core/objectpositioning/objectpositioning.cxx +++ b/sw/qa/core/objectpositioning/objectpositioning.cxx @@ -227,9 +227,9 @@ CPPUNIT_TEST_FIXTURE(SwCoreObjectpositioningTest, testInsideOutsideVertAlignBott = getXPath(pXmlDoc, "//SwAnchoredDrawObject[2]/bounds", "top").toInt32(); //15694 // Verify that the distance between the bottom of page and bottom of first shape is around 0cm. (align=outside) -CPPUNIT_ASSERT_EQUAL(static_cast(23), nPageBottom - nFirstShapeOutside); +CPPUNIT_ASSERT_EQUAL(static_cast(3), nPageBottom - nFirstShapeOutside); // Verify that the distance between the bottom of body and top of second shape is around 0cm. (align=inside) -CPPUNIT_ASSERT_EQUAL(static_cast(10), nBodyBottom - nSecondShapeInside); +CPPUNIT_ASSERT_EQUAL(static_cast(0), nBodyBottom - nSecondShapeInside); } CPPUNIT_TEST_FIXTURE(SwCoreObjectpositioningTest, testVMLVertAlignBottomMargin) diff --git a/sw/qa/extras/layout/data/tdf116486.docx b/sw/qa/extras/layout/data/tdf116486.docx index c6a4891b0cf4..825b0ef33a55 100644 Binary files a/sw/qa/extras/layout/data/tdf116486.docx and b/sw/qa/extras/layout/data/tdf116486.docx differ diff --git a/sw/qa/extras/ooxmlexport/data/effectextent-margin.docx b/sw/qa/extras/ooxmlexport/data/effectextent-margin.docx index 22db162a78b0..5dccf967fe7a 100644 Binary files a/sw/qa/extras/ooxmlexport/data/effectextent-margin.docx and b/sw/qa/extras/ooxmlexport/data/effectextent-margin.docx differ diff --git a/sw/qa/extras/ooxmlexport/data/tdf133045_TestShapeAlignmentRelativeFromTopMargin.docx b/sw/qa/extras/ooxmlexport/data/tdf133045_TestShapeAlignmentRelativeFromTopMargin.docx index 2cd299ff211a..aa976e7cc925 100644 Binary files a/sw/qa/extras/ooxmlexport/data/tdf133045_TestShapeAlignmentRelativeFromTopMargin.docx and b/sw/qa/extras/ooxmlexport/data/tdf133045_TestShapeAlignmentRelativeFromTopMargin.docx differ diff --git a/sw/qa/extras/ooxmlexport/data/textframe-gradient.docx b/sw/qa/extras/ooxmlexport/data/textframe-gradient.docx index e5ed0689d251..edbfe53b1627 100644 Binary files a/sw/qa/extras/ooxmlexport/data/textframe-gradient.docx and b/sw/qa/extras/ooxmlexport/data/textframe-gradient.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx index 72dc978a4c8e..935c047dad21 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx @@ -1008,9 +1008,9 @@ DECLARE_OOXMLEXPORT_TEST(testRelativeAlignmentFromTopMargin, return; xmlDocUniquePtr pXmlDoc = parseLayoutDump(); -assertXPath(pXmlDoc, "//SwAnchoredDrawObject[1]/bounds", "top", "1487"); // center -assertXPath(pXmlDoc, "//SwAnchoredDrawObject[2]/bounds", "top", "2668"); // bottom -assertXPath(pXmlDoc, "//SwAnchoredDrawObject[3]/bounds", "top", "298"); // top +assertXPath(pXmlDoc, "//SwAnchoredDrawObject[1]/bounds", "top", "1502"); // center +assertXPath(pXmlDoc,
[Libreoffice-bugs] [Bug 140415] Table properties (some) are not saved when saved as .pptx (might be related to bug 89806)
https://bugs.documentfoundation.org/show_bug.cgi?id=140415 --- Comment #2 from lal --- The point is that this bug is if you save the file as .pptx, not .odp - so your note is correct and it is still a bug as described. thank you for your kind consideration. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/authfld.hxx |2 +
sw/qa/core/tox/tox.cxx | 46 +
sw/source/core/fields/authfld.cxx |9 +--
sw/source/core/fields/fldbas.cxx |9 +++
sw/source/uibase/docvw/edtwin.cxx |2 -
sw/source/uibase/docvw/edtwin2.cxx |7 +
sw/source/uibase/inc/wrtsh.hxx |2 -
sw/source/uibase/shells/basesh.cxx |2 -
sw/source/uibase/wrtsh/wrtsh2.cxx | 21
9 files changed, 94 insertions(+), 6 deletions(-)
New commits:
commit 64ffabbdb2725e93de997171708bb31c33c93a55
Author: Miklos Vajna
AuthorDate: Fri Mar 12 17:51:07 2021 +0100
Commit: Miklos Vajna
CommitDate: Fri Mar 12 19:32:19 2021 +0100
sw bibliography, refer to a page: make the biblio field clickable
- add support for this in SwWrtShell::ClickToField()
- restrict this to ctrl-click by default (similar to hyperlinks)
- ignore empty URLs
- extend the tooltip to hint the URL
- change pointer to hint that the field is clickable
- downgrade the assert to SAL_WARN in
SwAuthorityFieldType::RemoveField(), that currently fires every time a
biblio field is de-selected
Change-Id: I3b4a12d8a7661f7d8d41804f104505c7594debd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112400
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/inc/authfld.hxx b/sw/inc/authfld.hxx
index cdfcf7f9f55a..c9c7fd880b7b 100644
--- a/sw/inc/authfld.hxx
+++ b/sw/inc/authfld.hxx
@@ -185,6 +185,8 @@ public:
/// Returns the line matching the source's default row in the ToX.
OUString GetAuthority(const SwTextAttr* pTextAttr, const SwRootFrame*
pLayout) const;
+bool HasURL() const;
+
void dumpAsXml(xmlTextWriterPtr pWriter) const override;
};
diff --git a/sw/qa/core/tox/tox.cxx b/sw/qa/core/tox/tox.cxx
index 127cb4b06e7f..0862b6403638 100644
--- a/sw/qa/core/tox/tox.cxx
+++ b/sw/qa/core/tox/tox.cxx
@@ -16,6 +16,9 @@
#include
+#include
+#include
+
namespace
{
/// Covers sw/source/core/tox/ fixes.
@@ -108,6 +111,49 @@ CPPUNIT_TEST_FIXTURE(Test, testAuthorityTableEntryURL)
CPPUNIT_ASSERT_EQUAL(OUString("http://www.example.com/test.pdf;), aActual);
}
+CPPUNIT_TEST_FIXTURE(Test, testAuthorityTableEntryClick)
+{
+// Given an empty document:
+SwDoc* pDoc = createSwDoc();
+
+// When inserting a biblio entry field with an URL:
+uno::Reference xFactory(mxComponent,
uno::UNO_QUERY);
+uno::Reference xField(
+xFactory->createInstance("com.sun.star.text.TextField.Bibliography"),
uno::UNO_QUERY);
+uno::Sequence aFields = {
+comphelper::makePropertyValue("BibiliographicType",
text::BibliographyDataType::WWW),
+comphelper::makePropertyValue("Identifier", OUString("AT")),
+comphelper::makePropertyValue("Author", OUString("Author")),
+comphelper::makePropertyValue("Title", OUString("Title")),
+comphelper::makePropertyValue("URL",
OUString("http://www.example.com/test.pdf#page=1;)),
+};
+xField->setPropertyValue("Fields", uno::makeAny(aFields));
+uno::Reference xTextDocument(mxComponent,
uno::UNO_QUERY);
+uno::Reference xText = xTextDocument->getText();
+uno::Reference xCursor = xText->createTextCursor();
+uno::Reference xContent(xField, uno::UNO_QUERY);
+xText->insertTextContent(xCursor, xContent, /*bAbsorb=*/false);
+
+// Then make sure that the field is clickable, since the page part will
not be part of the
+// bibliography table:
+const SwFieldTypes* pTypes =
pDoc->getIDocumentFieldsAccess().GetFieldTypes();
+auto it = std::find_if(pTypes->begin(), pTypes->end(),
+ [](const std::unique_ptr& pType) {
+ return pType->Which() ==
SwFieldIds::TableOfAuthorities;
+ });
+CPPUNIT_ASSERT(it != pTypes->end());
+const SwFieldType* pType = it->get();
+std::vector aFormatFields;
+pType->GatherFields(aFormatFields);
+CPPUNIT_ASSERT_EQUAL(static_cast(1), aFormatFields.size());
+SwField* pField = aFormatFields[0]->GetField();
+// Without the accompanying fix in place, this test would have failed, as
the field was not
+// clickable.
+CPPUNIT_ASSERT(pField->IsClickable());
+// This is needed, so the mouse has the correct RefHand pointer style.
+CPPUNIT_ASSERT(pField->HasClickHdl());
+}
+
CPPUNIT_TEST_FIXTURE(Test, testAuthorityTableURLDeduplication)
{
// Given a document with 3 bibliography references (of type WWW) in it:
diff --git a/sw/source/core/fields/authfld.cxx
b/sw/source/core/fields/authfld.cxx
index ad60d02db173..8812d70d2db6 100644
--- a/sw/source/core/fields/authfld.cxx
+++ b/sw/source/core/fields/authfld.cxx
@@ -99,8 +99,7 @@ void SwAuthorityFieldType::RemoveField(const SwAuthEntry*
pEntry)
return;
}
}
-assert(false);
-OSL_FAIL("Field unknown" );
+
[Libreoffice-bugs] [Bug 140987] Conversion to pdf using LibreOffice 7.0.4 fail in Oracle Linux Server 8.3
https://bugs.documentfoundation.org/show_bug.cgi?id=140987 --- Comment #2 from Arnab Mallik --- Created attachment 170445 --> https://bugs.documentfoundation.org/attachment.cgi?id=170445=edit log file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140988] In fact it is version LibreOffice_7.0.5.2_Win_x64
https://bugs.documentfoundation.org/show_bug.cgi?id=140988 norger...@web.de changed: What|Removed |Added Alias||Norbert -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140987] Conversion to pdf using LibreOffice 7.0.4 fail in Oracle Linux Server 8.3
https://bugs.documentfoundation.org/show_bug.cgi?id=140987 Arnab Mallik changed: What|Removed |Added CC||arnabdmal...@gmail.com --- Comment #1 from Arnab Mallik --- Created attachment 170444 --> https://bugs.documentfoundation.org/attachment.cgi?id=170444=edit source file to convert to pdf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140988] New: In fact it is version LibreOffice_7.0.5.2_Win_x64
https://bugs.documentfoundation.org/show_bug.cgi?id=140988 Bug ID: 140988 Summary: In fact it is version LibreOffice_7.0.5.2_Win_x64 Product: LibreOffice Version: 7.0.4.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: norger...@web.de Created attachment 170443 --> https://bugs.documentfoundation.org/attachment.cgi?id=170443=edit dump-file At starting libreoffice either Writer or Calc it shows a message that a crash occured. Crash reporter shows up with blank instead of link to submit, even though crash dump is created. (see attachment) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140987] New: Conversion to pdf using LibreOffice 7.0.4 fail in Oracle Linux Server 8.3
https://bugs.documentfoundation.org/show_bug.cgi?id=140987 Bug ID: 140987 Summary: Conversion to pdf using LibreOffice 7.0.4 fail in Oracle Linux Server 8.3 Product: LibreOffice Version: 7.0.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: arnabdmal...@gmail.com Description: Using Oracle Linux Server 8.3 and trying to convert rtf to pdf using LibreOffice 7.0.4 and the conversion fails. Running the following command as root ./soffice --headless --convert-to pdf --outdir /tmp /tmp/abc.rtf The output seen is convert /tmp/abc.rtf -> /tmp/abc.pdf using filter : writer_pdf_Export Error: Please verify input parameters... (SfxBaseModel::impl_store failed: 0xc10(Error Area:Io Class:Write Code:16) /home/buildslave/source/libo-core/sfx2/source/doc/sfxbasemodel.cxx:3153 /home/buildslave/source/libo-core/sfx2/source/doc/sfxbasemodel.cxx:1735) Strangely, all other conversion works as expected (rtf to html, rtf to doc, rtf to odt). Also, I tried to convert rtf to pdf using LibreOffice 5.1.2.2 on the same Oracle Linux Server 8.3 and the conversion worked. Content of abc.rtf is simply – Hello World. Steps to Reproduce: 1. Create a simple rtf file 2. ./soffice --headless --convert-to pdf --outdir abc.rtf 3. Conversion fail Actual Results: Error: Please verify input parameters... (SfxBaseModel::impl_store failed: 0xc10(Error Area:Io Class:Write Code:16) /home/buildslave/source/libo-core/sfx2/source/doc/sfxbasemodel.cxx:3153 /home/buildslave/source/libo-core/sfx2/source/doc/sfxbasemodel.cxx:1735) Expected Results: rtf to pdf conversion successful Reproducible: Always User Profile Reset: Yes Additional Info: conversion successful using LibreOffice 5.1.2.2 on the same Oracle Linux Server 8.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140544] FORMATTING: Writer paragraph styles "Letter" may be more efficiently grouped in a new hierarchy.
https://bugs.documentfoundation.org/show_bug.cgi?id=140544 cpmonger changed: What|Removed |Added Summary|Writer paragraph styles |FORMATTING: Writer |"Letter" may be more|paragraph styles "Letter" |efficiently grouped in a|may be more efficiently |new hierarchy. |grouped in a new hierarchy. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140971] Can't maximaze the window with opened "Find and Replace" dialog box after minimizing it
https://bugs.documentfoundation.org/show_bug.cgi?id=140971 --- Comment #1 from tv1700 --- Additional Info: Version: 7.1.1.2 / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: ru-RU (ru_RU.UTF-8); UI: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140544] Writer paragraph styles "Letter" may be more efficiently grouped in a new hierarchy.
https://bugs.documentfoundation.org/show_bug.cgi?id=140544 cpmonger changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135948] cut and special past link between two calc files
https://bugs.documentfoundation.org/show_bug.cgi?id=135948 Timur changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA --- Comment #4 from Timur --- No response. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140544] Writer paragraph styles "Letter" may be more efficiently grouped in a new hierarchy.
https://bugs.documentfoundation.org/show_bug.cgi?id=140544 --- Comment #2 from cpmonger --- Hi Dieter: In answer to the two questions in your comment: [1.] Q: "I can't see a paragraph style "letter" in . Are you sure, that it isn't a custom style?" A: Yes sir, I am certain it is not a custom style; see proposed _enhancement_ meta-description in the "Additional Info" section. Additional Info: Proposed enhancement meta-description: 1. Create paragraph style level-02 "Letter" hierarchy under level-01 "Default Paragraph Style". [2.] Q: "And if you don't agree with hierarchy, you can easily customise it and add as many additional styles as you want." A: I am seeking to contribute to a hierarchy organization improvement issue, i. e., fix once -- help many. I offered my logical reasoning at the beginning: "Description: LibraOffice Writer paragraph styles type "Letter" may be more efficiently grouped in a new hierarchy. Global low-level and high-level styles are currently intermixed. Letter styles may only be used by a few users, and are a distraction. Most other style types are grouped." [3.] Further, in accordance with directions and conventions, I carefully edited a hopefully clear title and summary: "Writer paragraph styles "Letter" may be more efficiently grouped in a new hierarchy." [4.] May I respectfully observe that this is only one of several related style hierarchy issues. Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107348] Pasting transpose of filtered data pastes unfiltered data
https://bugs.documentfoundation.org/show_bug.cgi?id=107348 Timur changed: What|Removed |Added CC||burnus...@gmail.com --- Comment #6 from Timur --- *** Bug 140979 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140979] Paste Special with Transpose does not respect visibility of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=140979 Timur changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Timur --- Looks duplicate. Please search before submitting. *** This bug has been marked as a duplicate of bug 107348 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53676] Link bugs from different bug trackers
https://bugs.documentfoundation.org/show_bug.cgi?id=53676 --- Comment #10 from Harshita Nag --- Ok sure:) I have emailed you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129629] Find and Replace dialog: "Other options" won't stay closed, if certain options are ticked
https://bugs.documentfoundation.org/show_bug.cgi?id=129629 Timur changed: What|Removed |Added CC||tv1...@yandex.ua --- Comment #10 from Timur --- *** Bug 140972 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140972] The "Find & Replace..." dialog box opens by default in the expanded version
https://bugs.documentfoundation.org/show_bug.cgi?id=140972 Timur changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Timur --- Looks duplicate. Please always search before submitting. *** This bug has been marked as a duplicate of bug 129629 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140818] Default Character Style should be renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=140818 --- Comment #10 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #9) > "No Character Style" https://gerrit.libreoffice.org/c/core/+/112311 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140464] Image moving to different position after changing anchor (likely Center/Top)
https://bugs.documentfoundation.org/show_bug.cgi?id=140464 mulla.tasa...@gmail.com changed: What|Removed |Added Whiteboard| QA:needsComment| CC||mulla.tasa...@gmail.com --- Comment #1 from mulla.tasa...@gmail.com --- Thank you for reporting the bug. I can not reproduce the bug in Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nb-NO (en_US); UI: en-US Calc: CL Version: 7.2.0.0.alpha0+ (x64) Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138902] Impress Presenter Console Help Screen Text Doesn't Wrap Properly (Simplified Chinese Translation Only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=138902 --- Comment #13 from tianswo...@fedoraproject.org --- (In reply to Ming Hua from comment #12) > (In reply to tiansworld from comment #11) > > (In reply to Ming Hua from comment #10) > > > (In reply to tiansworld from comment #8) > > > > The issue is not completely resolved in LibreOffice 7.1.1.2. > > > > > > > > Please see the detail in the screenshot. The first string in the red > > > > rectangle. > > > This is really strange, as the second line for "previous slide or previous > > > effect" wraps (if not at the ideal position), but the first line for "next > > > slide or next effect" doesn't. > > > > BTW, could you tell me which file in the L10n LibreOffice installation > > directory contains this string? And which one is the corresponding one on > > Weblate? So I can download that file and test it directly once you fix it. > > > > Last time it took me much time on looking for the files, but I couldn't find > > them. Thanks for your tips about xcd files. Previously I spent my time on the mo files. The file holds the string is /LibreOffice.app/Contents/Resources/registry/res/registry_zh-CN.xcd . The xcd is a xml type file, and can be edited directly in text editing tools. I solved the problem by adding a space before the word "Page" within that string. After several tests, it seems that any spaces before "Page" and after the first Chinese character "鼠" would solve the problem. I counted the half-width characters in the first line in English Impress remote control help, the length is 32 before wrapped automatically. "Left click, right or down arrow,*32nd is here* spacebar, page down, enter, return, 'N'". The tests showed that if the string is very long, then it will be automatically wrapped if there is any space before the 32nd character. The English string has many spaces, so there is no displaying problem. However, there is no space before the 32nd character in the translation string: "鼠标左键，右/下箭头、空格、Page Down、回车 (换行)、或 N 键", which is before the in word "Down". So the problem exists. I guess the central cause is probably the xml style or other backends configurations in LibreOffice. > > What about breaking the line into two lines? > I'm not willing to try this without being able to test locally first. And I > have neither a local build environment nor dual-display setup to test it. > OK. I'd like to know if a single space added before "Page" in the po file will work. If you don't believe my test, then please find someone you trust and let him/her do the test. I don't think lacking of testing environment would stop you from doing such a simple update to the translation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140468] Cursor position changes after insertion of image
https://bugs.documentfoundation.org/show_bug.cgi?id=140468 mulla.tasa...@gmail.com changed: What|Removed |Added CC||mulla.tasa...@gmail.com Status|UNCONFIRMED |NEW Whiteboard| QA:needsComment| Ever confirmed|0 |1 --- Comment #7 from mulla.tasa...@gmail.com --- Thank you for reporting the bug. I can confirm the bug present in, Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nb-NO (en_US); UI: en-US Calc: CL Version: 7.2.0.0.alpha0+ (x64) Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140415] Table properties (some) are not saved when saved as .pptx (might be related to bug 89806)
https://bugs.documentfoundation.org/show_bug.cgi?id=140415 mulla.tasa...@gmail.com changed: What|Removed |Added CC||mulla.tasa...@gmail.com Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Whiteboard| QA:needsComment| --- Comment #1 from mulla.tasa...@gmail.com --- Thank you for reporting the bug. If I'm saving the file as .pptx then only I can reproduce the bug in Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nb-NO (en_US); UI: en-US Calc: CL Version: 7.2.0.0.alpha0+ (x64) Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL FILE SAVED AS .ODP FILE, DOESN'T REPRODUCE THE BUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98255] Excel keyboard shortcut bindings for Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=98255 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=65 ||911 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 V Stuart Foote changed: What|Removed |Added Depends on||65911 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=65911 [Bug 65911] Keyboard accelerator & shortcut assignments -- review divergence from MS Word for reasonable common use cases [accessibility] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65911] Keyboard accelerator & shortcut assignments -- review divergence from MS Word for reasonable common use cases [accessibility]
https://bugs.documentfoundation.org/show_bug.cgi?id=65911 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=98 ||255 Blocks||98259 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98259 [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 65911] Keyboard accelerator & shortcut assignments -- review divergence from MS Word for reasonable common use cases [accessibility]
https://bugs.documentfoundation.org/show_bug.cgi?id=65911 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=98 ||255 Blocks||98259 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98259 [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140986] New: drop-down menu
https://bugs.documentfoundation.org/show_bug.cgi?id=140986 Bug ID: 140986 Summary: drop-down menu Product: LibreOffice Version: 7.0.3.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pingal...@gmail.com LibreOffice Version: 7.0.3.1 and Ubuntu 20.10. Reference file: http://bergheat.ingalsuo.fi/Bergheat46.ods Try changing the value of cell $BERGHEAT.H22 from its drop-down menu. No dice. Has been successful in the past. $BERGHEAT.H22 cell selection affects many Bergheat46 cells. The same problem has occurred in the $BERGHEAT.G35 cell. This cell also has an effect on many other cells. For other menu cells that affect only a few cells, there is no problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65606] Paste special sometimes not available (like for web content) -
https://bugs.documentfoundation.org/show_bug.cgi?id=65606 steve changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99818] EDITING: unformatted paste incorrectly grayed (no steps)
https://bugs.documentfoundation.org/show_bug.cgi?id=99818 steve changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/shells/tabsh.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 6db71f70a3b200d4074f6cda8ce445e9861d3296
Author: Caolán McNamara
AuthorDate: Fri Mar 12 12:57:57 2021 +
Commit: Caolán McNamara
CommitDate: Fri Mar 12 17:17:35 2021 +0100
tdf#140977 drop possible table-cursor before setting the new one
Change-Id: I3d278af77886af3413b4a15464c8a52caa9a8e02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112391
Tested-by: Jenkins
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sw/source/uibase/shells/tabsh.cxx
b/sw/source/uibase/shells/tabsh.cxx
index 34d98f61edd9..036274546d04 100644
--- a/sw/source/uibase/shells/tabsh.cxx
+++ b/sw/source/uibase/shells/tabsh.cxx
@@ -600,6 +600,9 @@ void SwTableShell::Execute(SfxRequest )
pDlg->StartExecuteAsync([pDlg, pRequest, pTableRep,
, , vCursors](sal_Int32 nResult){
if (RET_OK == nResult)
{
+if (rSh.IsTableMode()) // tdf#140977 drop possible
table-cursor before setting the new one
+rSh.TableCursorToCursor();
+
rSh.SetSelection(*vCursors->front()); // tdf#135636
set the table selected at dialog launch as current selection
const SfxItemSet* pOutSet = pDlg->GetOutputItemSet();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #202 from Commit Notification --- ViswaasLP committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ce69ab8d61975d5d49142469115798b5b3688a63 tdf#124176 Use pragma once in sw/source/uibase/inc It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/abstract.hxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit ce69ab8d61975d5d49142469115798b5b3688a63 Author: ViswaasLP AuthorDate: Thu Mar 11 22:12:51 2021 -0800 Commit: Ilmari Lauhakangas CommitDate: Fri Mar 12 17:05:26 2021 +0100 tdf#124176 Use pragma once in sw/source/uibase/inc Change-Id: I74c85b0327005ba7b2d07169f052a903381eb1f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112373 Reviewed-by: Ilmari Lauhakangas Tested-by: Ilmari Lauhakangas diff --git a/sw/source/uibase/inc/abstract.hxx b/sw/source/uibase/inc/abstract.hxx index 2bba7126debe..3a9e16f9888e 100644 --- a/sw/source/uibase/inc/abstract.hxx +++ b/sw/source/uibase/inc/abstract.hxx @@ -16,8 +16,7 @@ * except in compliance with the License. You may obtain a copy of * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_SW_SOURCE_UIBASE_INC_ABSTRACT_HXX -#define INCLUDED_SW_SOURCE_UIBASE_INC_ABSTRACT_HXX +#pragma once #include @@ -34,6 +33,4 @@ public: sal_uInt8 GetPara() const; }; -#endif - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/ui/inc/UITools.hxx |2 +-
reportdesign/source/ui/misc/UITools.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 2f8e96ccdc062c76a596e626d2b605f3cc9b539e
Author: Caolán McNamara
AuthorDate: Fri Mar 12 12:07:46 2021 +
Commit: Caolán McNamara
CommitDate: Fri Mar 12 17:01:16 2021 +0100
we just use the OutputDevice api for setZoomFactor
Change-Id: Ia72d9a82b266b2172581c757c30bfb80529849c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112389
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/reportdesign/source/ui/inc/UITools.hxx
b/reportdesign/source/ui/inc/UITools.hxx
index 13aafb14fc90..5fe175440e61 100644
--- a/reportdesign/source/ui/inc/UITools.hxx
+++ b/reportdesign/source/ui/inc/UITools.hxx
@@ -174,7 +174,7 @@ namespace rptui
@param _aZoom the zoom scale
@param _rWindowwhere to set the map mode
*/
-void setZoomFactor(const Fraction& _aZoom, vcl::Window& _rWindow);
+void setZoomFactor(const Fraction& _aZoom, OutputDevice& _rWindow);
}
#endif // INCLUDED_REPORTDESIGN_SOURCE_UI_INC_UITOOLS_HXX
diff --git a/reportdesign/source/ui/misc/UITools.cxx
b/reportdesign/source/ui/misc/UITools.cxx
index 3a96710a2a5b..92785547d4d3 100644
--- a/reportdesign/source/ui/misc/UITools.cxx
+++ b/reportdesign/source/ui/misc/UITools.cxx
@@ -1020,7 +1020,7 @@ void correctOverlapping(SdrObject*
_pControl,OReportSection const & _aReportSect
rSectionView.InsertObjectAtView(_pControl,*rSectionView.GetSdrPageView(),
SdrInsertFlags::ADDMARK);
}
-void setZoomFactor(const Fraction& _aZoom, vcl::Window& _rWindow)
+void setZoomFactor(const Fraction& _aZoom, OutputDevice& _rWindow)
{
MapMode aMapMode( _rWindow.GetMapMode() );
aMapMode.SetScaleX(_aZoom);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 65911] Keyboard accelerator & shortcut assignments -- review divergence from MS Word for reasonable common use cases [accessibility]
https://bugs.documentfoundation.org/show_bug.cgi?id=65911 --- Comment #7 from Michael Warner --- There is the ability to manually assign shortcuts and load/save them into files using the Keyboard tab in Tools->Customize. It would be a lot more convenient for users though if LO included pre-made profiles with keybindings that correspond to other popular office software and could be easily selected. This is a common feature in IDEs, for example. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 65911] Keyboard accelerator & shortcut assignments -- review divergence from MS Word for reasonable common use cases [accessibility]
https://bugs.documentfoundation.org/show_bug.cgi?id=65911 --- Comment #7 from Michael Warner --- There is the ability to manually assign shortcuts and load/save them into files using the Keyboard tab in Tools->Customize. It would be a lot more convenient for users though if LO included pre-made profiles with keybindings that correspond to other popular office software and could be easily selected. This is a common feature in IDEs, for example. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/viewopt.hxx |3 +--
sw/source/uibase/config/viewopt.cxx |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
New commits:
commit df0c80eef320ceeedacfab27f4da4c4ddbebb4bf
Author: Caolán McNamara
AuthorDate: Fri Mar 12 12:03:35 2021 +
Commit: Caolán McNamara
CommitDate: Fri Mar 12 16:47:29 2021 +0100
we just use the OutputDevice api for SwViewOption::Init
Change-Id: I36a52d0e02d6a2fa900abc579d7d1018fc5381f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112388
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/inc/viewopt.hxx b/sw/inc/viewopt.hxx
index 006a3f9b3dd3..c1ae8daa452f 100644
--- a/sw/inc/viewopt.hxx
+++ b/sw/inc/viewopt.hxx
@@ -30,7 +30,6 @@
#include "swdllapi.h"
class SwRect;
-namespace vcl { class Window; }
class OutputDevice;
class SwDocShell;
namespace svtools{ class ColorConfig;}
@@ -201,7 +200,7 @@ public:
SwViewOption(const SwViewOption&);
~SwViewOption();
-static void Init( vcl::Window const *pWin );// Initializing of
static data.
+static void Init(const OutputDevice* pWin);// Initializing of
static data.
ViewOptFlags1 GetCoreOptions() const {return m_nCoreOptions;}
inline void SetUIOptions( const SwViewOption& );
diff --git a/sw/source/uibase/config/viewopt.cxx
b/sw/source/uibase/config/viewopt.cxx
index c58e734f83ab..99ad4caf97a1 100644
--- a/sw/source/uibase/config/viewopt.cxx
+++ b/sw/source/uibase/config/viewopt.cxx
@@ -323,7 +323,7 @@ SwViewOption::~SwViewOption()
{
}
-void SwViewOption::Init( vcl::Window const *pWin )
+void SwViewOption::Init(const OutputDevice* pWin)
{
if( !s_nPixelTwips && pWin )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/qa
sd/qa/unit/misc-tests.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 9d1eea8f21907a86f23736fd739d1b032e410711 Author: Caolán McNamara AuthorDate: Fri Mar 12 12:01:06 2021 + Commit: Caolán McNamara CommitDate: Fri Mar 12 16:47:08 2021 +0100 can call XWindow::setVisible instead of extracting its vcl::Window Change-Id: Ia3b4c95b37f5da7ae1c8e04ae1181d00d7567cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112387 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/sd/qa/unit/misc-tests.cxx b/sd/qa/unit/misc-tests.cxx index f23ee5b5cea5..0ae169ce4431 100644 --- a/sd/qa/unit/misc-tests.cxx +++ b/sd/qa/unit/misc-tests.cxx @@ -50,7 +50,6 @@ #include #include #include -#include #include #include #include @@ -148,9 +147,7 @@ sd::DrawDocShellRef SdMiscTest::Load(const OUString& rURL, sal_Int32 nFormat) uno::Reference xContainerWindow = xTargetFrame->getContainerWindow(); CPPUNIT_ASSERT(xContainerWindow.is()); xContainerWindow->setPosSize(0, 0, 1024, 768, awt::PosSize::SIZE); -VclPtr pContainerWindow = VCLUnoHelper::GetWindow(xContainerWindow); -CPPUNIT_ASSERT(pContainerWindow); -pContainerWindow->Show(true); +xContainerWindow->setVisible(true); // 1. Open the document sd::DrawDocShellRef xDocSh = loadURL(rURL, nFormat); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/drawfunc/drtxtob.cxx |2 +-
sc/source/ui/inc/viewutil.hxx |4 ++--
sc/source/ui/view/editsh.cxx |2 +-
sc/source/ui/view/viewutil.cxx|9 +
4 files changed, 9 insertions(+), 8 deletions(-)
New commits:
commit b9190aca7ddd1fa7daa30eed0c8770196ca7c08e
Author: Caolán McNamara
AuthorDate: Fri Mar 12 11:49:04 2021 +
Commit: Caolán McNamara
CommitDate: Fri Mar 12 16:46:28 2021 +0100
use ScTabViewShell to get toplevel dialog parent
Change-Id: I87d8f41e60bd8dfb620861d6c6ec716ce72f7641
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112386
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/drawfunc/drtxtob.cxx
b/sc/source/ui/drawfunc/drtxtob.cxx
index 117e47a5bd02..d0fb849b31e6 100644
--- a/sc/source/ui/drawfunc/drtxtob.cxx
+++ b/sc/source/ui/drawfunc/drtxtob.cxx
@@ -233,7 +233,7 @@ void ScDrawTextObjectBar::Execute( SfxRequest )
}
}
else
-ScViewUtil::ExecuteCharMap( rItem,
*mrViewData.GetViewShell()->GetViewFrame() );
+ScViewUtil::ExecuteCharMap(rItem,
*mrViewData.GetViewShell());
if ( !aString.isEmpty() )
{
diff --git a/sc/source/ui/inc/viewutil.hxx b/sc/source/ui/inc/viewutil.hxx
index 6dd0a49a2b28..834802f06d0c 100644
--- a/sc/source/ui/inc/viewutil.hxx
+++ b/sc/source/ui/inc/viewutil.hxx
@@ -32,6 +32,7 @@ class ScChangeAction;
class ScChangeViewSettings;
class ScDocument;
class ScMarkData;
+class ScTabViewShell;
enum class SvtScriptType;
enum class TransliterationFlags;
@@ -41,8 +42,7 @@ enum class ScUpdateMode { All, Marks };
class SC_DLLPUBLIC ScViewUtil
{
public:
-static void ExecuteCharMap( const SvxFontItem& rOldFont,
-SfxViewFrame& rFrame );
+static void ExecuteCharMap(const SvxFontItem& rOldFont, ScTabViewShell&
rShell);
static bool IsActionShown( const ScChangeAction& rAction,
const ScChangeViewSettings& rSettings,
diff --git a/sc/source/ui/view/editsh.cxx b/sc/source/ui/view/editsh.cxx
index 4a7ed8e09415..68a186f1dd5d 100644
--- a/sc/source/ui/view/editsh.cxx
+++ b/sc/source/ui/view/editsh.cxx
@@ -420,7 +420,7 @@ void ScEditShell::Execute( SfxRequest& rReq )
}
else
{
-ScViewUtil::ExecuteCharMap( rItem,
*rViewData.GetViewShell()->GetViewFrame() );
+ScViewUtil::ExecuteCharMap(rItem,
*rViewData.GetViewShell());
// while the dialog was open, edit mode may have been
stopped
if (!SC_MOD()->IsInputMode())
diff --git a/sc/source/ui/view/viewutil.cxx b/sc/source/ui/view/viewutil.cxx
index 7d87902175b2..f94d24ab1210 100644
--- a/sc/source/ui/view/viewutil.cxx
+++ b/sc/source/ui/view/viewutil.cxx
@@ -30,7 +30,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -41,6 +40,7 @@
#include
#include
#include
+#include
#include
#include
@@ -317,15 +317,16 @@ void ScViewUtil::HideDisabledSlot( SfxItemSet& rSet,
SfxBindings& rBindings, sal
rSet.DisableItem( nSlotId );
}
-void ScViewUtil::ExecuteCharMap( const SvxFontItem& rOldFont,
- SfxViewFrame& rFrame )
+void ScViewUtil::ExecuteCharMap(const SvxFontItem& rOldFont,
+ScTabViewShell& rShell)
{
SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create();
+SfxViewFrame& rFrame = *rShell.GetViewFrame();
SfxAllItemSet aSet( rFrame.GetObjectShell()->GetPool() );
aSet.Put( SfxBoolItem( FN_PARAM_1, false ) );
aSet.Put( SvxFontItem( rOldFont.GetFamily(), rOldFont.GetFamilyName(),
rOldFont.GetStyleName(), rOldFont.GetPitch(), rOldFont.GetCharSet(),
aSet.GetPool()->GetWhich( SID_ATTR_CHAR_FONT ) ) );
auto xFrame = rFrame.GetFrame().GetFrameInterface();
-ScopedVclPtr
pDlg(pFact->CreateCharMapDialog(rFrame.GetWindow().GetFrameWeld(), aSet,
xFrame));
+ScopedVclPtr
pDlg(pFact->CreateCharMapDialog(rShell.GetFrameWeld(), aSet, xFrame));
pDlg->Execute();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140983] Offline (i.e. installed) Help takes 22 seconds to fully load the page on Chrome and Edge
https://bugs.documentfoundation.org/show_bug.cgi?id=140983 V Stuart Foote changed: What|Removed |Added Ever confirmed|0 |1 CC||sdc.bla...@youmail.dk, ||vstuart.fo...@utsa.edu Severity|normal |minor Summary|Help takes 22 seconds to|Offline (i.e. installed) |fully load the page on |Help takes 22 seconds to |Chrome and Edge |fully load the page on ||Chrome and Edge Status|UNCONFIRMED |NEEDINFO --- Comment #1 from V Stuart Foote --- Confirmed, Firefox seems to load some prebuilt index. And on initial launch has the index in place. While Chrome/Edge both seem to not to cache the index and rebuild it on each launch with the delay noted. Once built, both seem equally robust. To me the online Help seems performant in any browser (assuming network connection). =-testing-= Version: 7.1.1.1 (x64) / LibreOffice Community Build ID: 575c5867c4cc13d7ae78f9ce39a54a52ed38c769 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sw/qa sw/source
sw/qa/extras/ooxmlexport/data/fly_fieldmark.fodt | 60 +++
sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx| 12
sw/source/filter/ww8/wrtw8nds.cxx| 23 +++-
sw/source/filter/ww8/wrtww8.hxx |1
4 files changed, 92 insertions(+), 4 deletions(-)
New commits:
commit e79c637f291d552bfe8f32ccfc23300c67f51fcc
Author: Michael Stahl
AuthorDate: Wed Mar 10 11:26:07 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Mar 12 16:14:09 2021 +0100
sw: DOCX export: put fly before fieldmark start into its own run
If a fly starts at the same position as a CH_TXT_ATR_FIELDSTART, it is
anchored before the field, and written in OutFlys() before the field is
written in EndRun(), but the DOCX export reorders things in confusing
ways.
StartField_Impl() and CmdField_Impl() will actually end the current run
(after putting the field char in it) and start a new one.
So do something similar in this situation and create a new run if flys
have been processed.
Restrict this extra run to when there is actually a fly, because
otherwise a dozen tests break; this requires a new FLY_NONE result for
OutFlys() because FLY_PROCESSED is returned even if there are no flys.
Change-Id: Id469c53d07eacad3992c7c0e451ab3756e02c8fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112267
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 3eced2d52415abeac266804ab682bee022322a19)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112230
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/extras/ooxmlexport/data/fly_fieldmark.fodt
b/sw/qa/extras/ooxmlexport/data/fly_fieldmark.fodt
new file mode 100644
index ..af1ae9a86243
--- /dev/null
+++ b/sw/qa/extras/ooxmlexport/data/fly_fieldmark.fodt
@@ -0,0 +1,60 @@
+
+
+http://openoffice.org/2009/office;
xmlns:css3t="http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0"
xmlns:dc="http://purl.org/dc/elements/1.1/;
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:config="urn:oasis:names:tc:opendocument:xmlns
:config:1.0" xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="ur
n:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:xforms="http://www.w3.org/2002/xforms; office:version="1.3"
office:mimetype="application/vnd.oasis.opendocument.text">
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+foobar
+
+
+
diff --git a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
index 240678318f9a..40f93ab67664 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
@@ -484,6 +484,18 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testEditTime,
"fdo81341.docx")
assertXPath(pXmlDoc, "/w:document/w:body/w:p/w:r[5]/w:fldChar",
"fldCharType", "end");
}
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testFlyFieldmark, "fly_fieldmark.fodt")
+{
+// the problem was that the flys were written after the field start
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+
[Libreoffice-commits] core.git: sfx2/source sfx2/uiconfig
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx |5 ++
sfx2/uiconfig/ui/developmenttool.ui | 40 +---
2 files changed, 40 insertions(+), 5 deletions(-)
New commits:
commit cd2e32cae86f31e7dff8b350e3c5e551c79f4bc1
Author: Tomaž Vajngerl
AuthorDate: Thu Mar 11 12:26:38 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Mar 12 16:04:26 2021 +0100
devtools: make all columns sorted in all tree views
Change-Id: I0a20948fcad6919c5ee1a0f18d649ed9f7808114
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112371
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index e0f2b4ae9d5d..6b6a1bdfcc1d 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -736,6 +736,11 @@ ObjectInspectorTreeHandler::ObjectInspectorTreeHandler(
mpPropertiesTreeView->connect_changed(LINK(this,
ObjectInspectorTreeHandler, SelectionChanged));
mpMethodsTreeView->connect_changed(LINK(this, ObjectInspectorTreeHandler,
SelectionChanged));
+mpInterfacesTreeView->make_sorted();
+mpServicesTreeView->make_sorted();
+mpPropertiesTreeView->make_sorted();
+mpMethodsTreeView->make_sorted();
+
mpObjectInspectorToolbar->connect_clicked(
LINK(this, ObjectInspectorTreeHandler, ToolbarButtonClicked));
mpObjectInspectorToolbar->set_item_sensitive("inspect", false);
diff --git a/sfx2/uiconfig/ui/developmenttool.ui
b/sfx2/uiconfig/ui/developmenttool.ui
index 22c1f5f315f1..9f23752d7f26 100644
--- a/sfx2/uiconfig/ui/developmenttool.ui
+++ b/sfx2/uiconfig/ui/developmenttool.ui
@@ -174,9 +174,12 @@
-
+
True
Name
+True
+True
+0
@@ -223,6 +226,9 @@
True
Name
+True
+True
+0
@@ -273,6 +279,9 @@
True
Object
+True
+True
+0
@@ -285,6 +294,9 @@
True
Value
+True
+True
+1
@@ -297,6 +309,9 @@
True
Type
+True
+True
+2
@@ -309,6 +324,9 @@
True
Info
+True
+True
+3
@@ -356,9 +374,12 @@
-
+
True
Method
+True
+True
+0
@@ -368,9 +389,12 @@
-
+
True
Return Type
+True
+True
+1
@@ -380,9 +404,12 @@
-
+
True
Parameters
+True
+True
+2
[Libreoffice-commits] core.git: sfx2/source sfx2/uiconfig
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx | 125
sfx2/uiconfig/ui/developmenttool.ui | 22 ++-
2 files changed, 118 insertions(+), 29 deletions(-)
New commits:
commit 8d1888fca3147520c6f049ba4335932f69caf358
Author: Tomaž Vajngerl
AuthorDate: Fri Mar 5 22:28:40 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Mar 12 16:03:58 2021 +0100
devtools: new column "Info" for properties in object inspector
Adds additional column "info" for properties, where additional
property attributes are written. Currently these are mostly
constants from beans::PropertyAttribute, but they can be others
too (anything that is useful to the users for the current property,
struct, sequence).
Change-Id: I12d21ebdfb9352bca79def98d5aa65aa48cfe2aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112117
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index 0466f252166e..e0f2b4ae9d5d 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
@@ -349,15 +350,18 @@ class BasicValueNode : public SimpleStringNode
{
protected:
uno::Any maAny;
+OUString mrInfo;
uno::Reference mxContext;
-ObjectInspectorNodeInterface* createNodeObjectForAny(OUString const&
rName, uno::Any& rAny);
+ObjectInspectorNodeInterface* createNodeObjectForAny(OUString const&
rName, uno::Any& rAny,
+ OUString const&
mrInfo);
public:
-BasicValueNode(OUString const& rName, uno::Any const& rAny,
+BasicValueNode(OUString const& rName, uno::Any const& rAny, OUString
const& rInfo,
uno::Reference const& xContext)
: SimpleStringNode(rName)
, maAny(rAny)
+, mrInfo(rInfo)
, mxContext(xContext)
{
}
@@ -389,19 +393,16 @@ public:
OUString aValue = AnyToString(maAny, mxContext);
OUString aType = getAnyType(maAny);
-return {
-{ 1, aValue },
-{ 2, aType },
-};
+return { { 1, aValue }, { 2, aType }, { 3, mrInfo } };
}
};
class GenericPropertiesNode : public BasicValueNode
{
public:
-GenericPropertiesNode(OUString const& rName, uno::Any const& rAny,
+GenericPropertiesNode(OUString const& rName, uno::Any const& rAny,
OUString const& rInfo,
uno::Reference const&
xContext)
-: BasicValueNode(rName, rAny, xContext)
+: BasicValueNode(rName, rAny, rInfo, xContext)
{
}
@@ -412,9 +413,9 @@ public:
class StructNode : public BasicValueNode
{
public:
-StructNode(OUString const& rName, uno::Any const& rAny,
+StructNode(OUString const& rName, uno::Any const& rAny, OUString const&
rInfo,
uno::Reference const& xContext)
-: BasicValueNode(rName, rAny, xContext)
+: BasicValueNode(rName, rAny, rInfo, xContext)
{
}
@@ -429,9 +430,9 @@ class SequenceNode : public BasicValueNode
uno::Reference mxIdlArray;
public:
-SequenceNode(OUString const& rName, uno::Any const& rAny,
+SequenceNode(OUString const& rName, uno::Any const& rAny, OUString const&
rInfo,
uno::Reference const& xContext)
-: BasicValueNode(rName, rAny, xContext)
+: BasicValueNode(rName, rAny, rInfo, xContext)
{
auto xReflection = reflection::theCoreReflection::get(mxContext);
OUString aTypeName = maAny.getValueType().getTypeName();
@@ -456,7 +457,8 @@ public:
uno::Any aArrayValue = mxIdlArray->get(maAny, i);
uno::Reference xCurrent;
-auto* pObjectInspectorNode =
createNodeObjectForAny(OUString::number(i), aArrayValue);
+auto* pObjectInspectorNode
+= createNodeObjectForAny(OUString::number(i), aArrayValue, "");
if (pObjectInspectorNode)
lclAppendNodeToParent(pTree, pParent, pObjectInspectorNode);
}
@@ -490,7 +492,8 @@ void
GenericPropertiesNode::fillChildren(std::unique_ptr& pTree,
for (OUString const& rName : aNames)
{
uno::Any aAny = xNameAccess->getByName(rName);
-auto* pObjectInspectorNode = createNodeObjectForAny("@" + rName,
aAny);
+auto* pObjectInspectorNode
+= createNodeObjectForAny(u"@" + rName, aAny, u"name
container");
lclAppendNodeToParent(pTree, pParent, pObjectInspectorNode);
}
}
@@ -502,7 +505,7 @@ void
GenericPropertiesNode::fillChildren(std::unique_ptr& pTree,
{
uno::Any aAny = xIndexAccess->getByIndex(nIndex);
auto* pObjectInspectorNode
-=
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx | 46 +---
1 file changed, 21 insertions(+), 25 deletions(-)
New commits:
commit 9f72f662d7ac2fbd5131ecf65be93aa001b720c9
Author: Tomaž Vajngerl
AuthorDate: Fri Mar 5 19:53:28 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Mar 12 16:03:12 2021 +0100
devtools: use XInvocation2 to get the available properties
XIntrospection is not needed as XInvocation can provide a list of
available properties by itself and we need XInvocation to get the
property value. So this change removes XIntrospection and
simplifies the code a bit.
Change-Id: Ic274c87c9c274a05537715b5f19662a7ceaeb2b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112116
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index 5dbbb00a0844..0466f252166e 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -34,8 +34,9 @@
#include
#include
-#include
#include
+#include
+#include
#include
#include
@@ -522,40 +523,35 @@ void
GenericPropertiesNode::fillChildren(std::unique_ptr& pTree,
}
}
-uno::Reference xIntrospection =
beans::theIntrospection::get(mxContext);
-if (!xIntrospection.is())
-return;
-
-auto xIntrospectionAccess = xIntrospection->inspect(maAny);
-if (!xIntrospectionAccess.is())
-return;
-
auto xInvocationFactory = css::script::Invocation::create(mxContext);
uno::Sequence aParameters = { maAny };
auto xInvocationInterface =
xInvocationFactory->createInstanceWithArguments(aParameters);
-uno::Reference xInvocation(xInvocationInterface,
uno::UNO_QUERY);
+if (!xInvocationInterface.is())
+return;
-const auto xProperties = xIntrospectionAccess->getProperties(
-beans::PropertyConcept::ALL - beans::PropertyConcept::DANGEROUS);
+uno::Reference xInvocation(xInvocationInterface,
uno::UNO_QUERY);
+if (!xInvocation.is())
+return;
-for (auto const& xProperty : xProperties)
+const auto aInvocationInfoSequence = xInvocation->getInfo();
+for (auto const& aInvocationInfo : aInvocationInfoSequence)
{
-uno::Any aCurrentAny;
-
-try
+if (aInvocationInfo.eMemberType == script::MemberType_PROPERTY)
{
-if (xInvocation->hasProperty(xProperty.Name))
+uno::Any aCurrentAny;
+auto const& aPropertyName = aInvocationInfo.aName;
+try
+{
+aCurrentAny = xInvocation->getValue(aPropertyName);
+}
+catch (...)
{
-aCurrentAny = xInvocation->getValue(xProperty.Name);
}
-}
-catch (...)
-{
-}
-auto* pObjectInspectorNode = createNodeObjectForAny(xProperty.Name,
aCurrentAny);
-if (pObjectInspectorNode)
-lclAppendNodeToParent(pTree, pParent, pObjectInspectorNode);
+auto* pObjectInspectorNode = createNodeObjectForAny(aPropertyName,
aCurrentAny);
+if (pObjectInspectorNode)
+lclAppendNodeToParent(pTree, pParent, pObjectInspectorNode);
+}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx | 29 ++--
1 file changed, 15 insertions(+), 14 deletions(-)
New commits:
commit 7aec678ff4f34bfe76ac64c8be8bae944ea508a8
Author: Tomaž Vajngerl
AuthorDate: Thu Mar 4 22:36:55 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Mar 12 16:02:29 2021 +0100
devtools: show expander for the sequence only if it has elements
Change-Id: Ic94881df48da63b8662484faaddc004d83756529
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112115
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index f6a863b24aaf..5dbbb00a0844 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -425,28 +425,34 @@ public:
class SequenceNode : public BasicValueNode
{
+uno::Reference mxIdlArray;
+
public:
SequenceNode(OUString const& rName, uno::Any const& rAny,
uno::Reference const& xContext)
: BasicValueNode(rName, rAny, xContext)
{
+auto xReflection = reflection::theCoreReflection::get(mxContext);
+OUString aTypeName = maAny.getValueType().getTypeName();
+auto xClass = xReflection->forName(aTypeName);
+mxIdlArray = xClass->getArray();
}
-bool shouldShowExpander() override { return true; }
+bool shouldShowExpander() override
+{
+// Show expnder only if the sequence has elements
+int nLength = mxIdlArray->getLen(maAny);
+return nLength > 0;
+}
void fillChildren(std::unique_ptr& pTree,
const weld::TreeIter* pParent) override
{
-auto xReflection = reflection::theCoreReflection::get(mxContext);
-uno::Reference xClass
-= xReflection->forName(maAny.getValueType().getTypeName());
-uno::Reference xIdlArray = xClass->getArray();
-
-int nLength = xIdlArray->getLen(maAny);
+int nLength = mxIdlArray->getLen(maAny);
for (int i = 0; i < nLength; i++)
{
-uno::Any aArrayValue = xIdlArray->get(maAny, i);
+uno::Any aArrayValue = mxIdlArray->get(maAny, i);
uno::Reference xCurrent;
auto* pObjectInspectorNode =
createNodeObjectForAny(OUString::number(i), aArrayValue);
@@ -457,12 +463,7 @@ public:
std::vector> getColumnValues() override
{
-auto xReflection = reflection::theCoreReflection::get(mxContext);
-uno::Reference xClass
-= xReflection->forName(maAny.getValueType().getTypeName());
-uno::Reference xIdlArray = xClass->getArray();
-
-int nLength = xIdlArray->getLen(maAny);
+int nLength = mxIdlArray->getLen(maAny);
OUString aValue = "";
OUString aType = getAnyType(maAny).replaceAll(u"[]", u"");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
New commits:
commit d1d7390596400aaeb401e98f6ba7242742b0921a
Author: Tomaž Vajngerl
AuthorDate: Thu Mar 4 22:19:11 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Mar 12 16:01:49 2021 +0100
devtools: shorter type names, improve sequence type name
This change modifies the type names to a shorter form by replacing
"com.sun.star" with "css". Sequence type names are also changed
so that it shows the number of elements in the type name.
Change-Id: I4b3b3d0917478d1e5ce0e7443e9b5118672cb12b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112114
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index 42d5f163e75b..f6a863b24aaf 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -182,7 +182,11 @@ OUString AnyToString(const uno::Any& aValue, const
uno::ReferencegetLen(maAny);
-OUString aValue = "0 to " + OUString::number(nLength - 1);
-OUString aType = getAnyType(maAny);
+OUString aValue = "";
+OUString aType = getAnyType(maAny).replaceAll(u"[]", u"");
+aType += u"[" + OUString::number(nLength) + u"]";
return {
{ 1, aValue },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit ee88afa23e86c20a355ccf00e5d7321d44ad56db
Author: Tomaž Vajngerl
AuthorDate: Thu Mar 4 22:11:56 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Mar 12 16:00:58 2021 +0100
devtools: don't show the expander if the object has no value
Change-Id: I2aa742c70ed3eab8b56d16e9d846d5bc21223c4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112113
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index ea864bb7a8f1..42d5f163e75b 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -366,6 +366,10 @@ public:
switch (maAny.getValueType().getTypeClass())
{
case uno::TypeClass_INTERFACE:
+{
+uno::Reference xInterface(maAny,
uno::UNO_QUERY);
+return xInterface.is();
+}
case uno::TypeClass_SEQUENCE:
return true;
default:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx | 27 ++--
1 file changed, 3 insertions(+), 24 deletions(-)
New commits:
commit 4acad9bad5f17991c2e426348704fc5cdaabd8ec
Author: Tomaž Vajngerl
AuthorDate: Thu Mar 4 22:08:32 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Mar 12 16:00:32 2021 +0100
devtools: simplify getting the type name for Any object
We actually don't need the XIdlClass to get the name for the type.
Change-Id: Ie2a39ede1dcd7163120a40e64cca39a559796eeb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112112
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index 1977a30ce473..ea864bb7a8f1 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -50,22 +50,6 @@ namespace
constexpr OUStringLiteral constTypeDescriptionManagerSingletonName
= u"/singletons/com.sun.star.reflection.theTypeDescriptionManager";
-uno::Reference
-TypeToIdlClass(const uno::Type& rType, const
uno::Reference& xContext)
-{
-auto xReflection = reflection::theCoreReflection::get(xContext);
-
-uno::Reference xRetClass;
-typelib_TypeDescription* pTD = nullptr;
-rType.getDescription();
-if (pTD)
-{
-OUString sOWName(pTD->pTypeName);
-xRetClass = xReflection->forName(sOWName);
-}
-return xRetClass;
-}
-
OUString AnyToString(const uno::Any& aValue, const
uno::Reference& xContext)
{
OUString aRetStr;
@@ -198,12 +182,7 @@ OUString AnyToString(const uno::Any& aValue, const
uno::Reference& xContext)
-{
-uno::Type aValType = aValue.getValueType();
-auto xIdlClass = TypeToIdlClass(aValType, xContext);
-return xIdlClass->getName();
-}
+OUString getAnyType(const uno::Any& aValue) { return
aValue.getValueType().getTypeName(); }
// Object inspector nodes
@@ -399,7 +378,7 @@ public:
std::vector> getColumnValues() override
{
OUString aValue = AnyToString(maAny, mxContext);
-OUString aType = getAnyType(maAny, mxContext);
+OUString aType = getAnyType(maAny);
return {
{ 1, aValue },
@@ -478,7 +457,7 @@ public:
int nLength = xIdlArray->getLen(maAny);
OUString aValue = "0 to " + OUString::number(nLength - 1);
-OUString aType = getAnyType(maAny, mxContext);
+OUString aType = getAnyType(maAny);
return {
{ 1, aValue },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx | 28
1 file changed, 12 insertions(+), 16 deletions(-)
New commits:
commit 46035be60691ba799910565456a5425dd1af3e14
Author: Tomaž Vajngerl
AuthorDate: Thu Mar 4 22:02:33 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Mar 12 16:00:15 2021 +0100
devtools: allow an Any without value in object inspector
If an Any doesn't have a value, still create the object so it will
be added to the object inspector, but with "NULL" string as the
value. This is needed to show that the property is available in
this object, but it hasn't been set to a value.
Change-Id: I986ceac436434af34709bdfc0588e4d15748c20e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112111
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index a9687635c380..1977a30ce473 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -72,7 +72,7 @@ OUString AnyToString(const uno::Any& aValue, const
uno::Reference xInterface(aValue, uno::UNO_QUERY);
+if (!xInterface.is())
+aRetStr = "NULL";
+else
+aRetStr = "";
break;
}
case uno::TypeClass_STRUCT:
@@ -394,18 +398,13 @@ public:
std::vector> getColumnValues() override
{
-if (maAny.hasValue())
-{
-OUString aValue = AnyToString(maAny, mxContext);
-OUString aType = getAnyType(maAny, mxContext);
-
-return {
-{ 1, aValue },
-{ 2, aType },
-};
-}
+OUString aValue = AnyToString(maAny, mxContext);
+OUString aType = getAnyType(maAny, mxContext);
-return ObjectInspectorNodeInterface::getColumnValues();
+return {
+{ 1, aValue },
+{ 2, aType },
+};
}
};
@@ -595,9 +594,6 @@ void
StructNode::fillChildren(std::unique_ptr& pTree, const weld
ObjectInspectorNodeInterface* BasicValueNode::createNodeObjectForAny(OUString
const& rName,
uno::Any&
rAny)
{
-if (!rAny.hasValue())
-return nullptr;
-
switch (rAny.getValueType().getTypeClass())
{
case uno::TypeClass_INTERFACE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cppuhelper/source
cppuhelper/source/servicemanager.hxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit bd0dd2589c435078d8d974e3b37da5edb5f74f9f Author: Luboš Luňák AuthorDate: Wed Mar 10 19:19:26 2021 +0100 Commit: Luboš Luňák CommitDate: Fri Mar 12 15:44:13 2021 +0100 use std::unordered_map in cppuhelper ServiceManager It's faster and I do not see any reason for the map to be sorted. cppuhelper::ServiceManager::findServiceImplementation() may be called quite often e.g. during text layout by i18npool::BreakIterator. Change-Id: If8c77c506b88a0a3eac29e0d20d43d2110eed4ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112280 Tested-by: Jenkins Reviewed-by: Luboš Luňák diff --git a/cppuhelper/source/servicemanager.hxx b/cppuhelper/source/servicemanager.hxx index f6a505492be8..d086a8d65ead 100644 --- a/cppuhelper/source/servicemanager.hxx +++ b/cppuhelper/source/servicemanager.hxx @@ -12,7 +12,7 @@ #include #include -#include +#include #include #include #include @@ -164,17 +164,17 @@ public: css::uno::Reference const & instance); }; -typedef std::map< OUString, std::shared_ptr< Implementation > > +typedef std::unordered_map< OUString, std::shared_ptr< Implementation > > NamedImplementations; typedef -std::map< +std::unordered_map< css::uno::Reference< css::lang::XServiceInfo >, std::shared_ptr< Implementation > > DynamicImplementations; typedef -std::map< +std::unordered_map< OUString, std::vector< std::shared_ptr< Implementation > > > ImplementationMap; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108800] [META] Print related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108800 Bug 108800 depends on bug 129085, which changed state. Bug 129085 Summary: From version 6.1.x, some images in Writer not printed with "Tight" or "Through" or "Parallel" wrap https://bugs.documentfoundation.org/show_bug.cgi?id=129085 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129085] From version 6.1.x, some images in Writer not printed with "Tight" or "Through" or "Parallel" wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=129085 Xisco Faulí changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #36 from Xisco Faulí --- The commit causing this issue has been reverted in https://cgit.freedesktop.org/libreoffice/core/commit/?id=2e334998f4a821ea05ce25dc6346b556bcb1347b Please, test it with a daily build. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140590] Crash in: mergedlo.dll: Using Save-As dialog in Tools>Chapter Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=140590 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115121] [META] Chapter numbering dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=115121 Bug 115121 depends on bug 140590, which changed state. Bug 140590 Summary: Crash in: mergedlo.dll: Using Save-As dialog in Tools>Chapter Numbering https://bugs.documentfoundation.org/show_bug.cgi?id=140590 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/tabcont.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2502b80e57eb2116fd7043603833ff38f9da1320
Author: Caolán McNamara
AuthorDate: Fri Mar 12 11:31:20 2021 +
Commit: Caolán McNamara
CommitDate: Fri Mar 12 15:39:37 2021 +0100
query the DocShell if we have entered modal mode
rather than using Application::IsInModalMode()
Change-Id: Ib630aeef06928c2bbc5fb9697e6864874f2f2a71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112384
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/view/tabcont.cxx b/sc/source/ui/view/tabcont.cxx
index c96f3424a511..31628bc9c342 100644
--- a/sc/source/ui/view/tabcont.cxx
+++ b/sc/source/ui/view/tabcont.cxx
@@ -621,7 +621,7 @@ TabBarAllowRenamingReturnCode ScTabControl::AllowRenaming()
OSL_FAIL("ScTabControl::AllowRenaming: nested calls");
nRet = TABBAR_RENAMING_NO;
}
-else if ( Application::IsInModalMode() )
+else if (pViewData->GetDocShell()->IsInModalMode())
{
// don't show error message above any modal dialog
// instead cancel renaming without error message
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/fpicker/SalGtkPicker.cxx | 18 ++
1 file changed, 18 insertions(+)
New commits:
commit ba123c6b03545f9c111c997d21b7dddf50399bf2
Author: Caolán McNamara
AuthorDate: Fri Mar 12 11:21:12 2021 +
Commit: Caolán McNamara
CommitDate: Fri Mar 12 15:39:17 2021 +0100
[Inc/Dec]ModalCount on parent frame so it knows it is in modal mode
which is something we do on welded dialog already, but the prior
native file dialog integration lacked this to date
Change-Id: Ia1c3b81d5a2d567731215f367fcf37b750c51ee7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112383
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/fpicker/SalGtkPicker.cxx
b/vcl/unx/gtk3/fpicker/SalGtkPicker.cxx
index f1bcbfc4d265..7502d5af290b 100644
--- a/vcl/unx/gtk3/fpicker/SalGtkPicker.cxx
+++ b/vcl/unx/gtk3/fpicker/SalGtkPicker.cxx
@@ -187,7 +187,25 @@ gint RunDialog::run()
mxToolkit->addTopWindowListener(this);
mxDesktop->addTerminateListener(this);
+
+// [Inc/Dec]ModalCount on parent frame so it knows it is in modal mode
+GtkWindow* pParent = gtk_window_get_transient_for(GTK_WINDOW(mpDialog));
+GtkSalFrame* pFrame = pParent ?
GtkSalFrame::getFromWindow(GTK_WIDGET(pParent)) : nullptr;
+VclPtr xFrameWindow = pFrame ? pFrame->GetWindow() : nullptr;
+if (xFrameWindow)
+{
+xFrameWindow->IncModalCount();
+xFrameWindow->ImplGetFrame()->NotifyModalHierarchy(true);
+}
+
gint nStatus = gtk_dialog_run(GTK_DIALOG(mpDialog));
+
+if (xFrameWindow)
+{
+xFrameWindow->DecModalCount();
+xFrameWindow->ImplGetFrame()->NotifyModalHierarchy(false);
+}
+
mxDesktop->removeTerminateListener(this);
if (mxToolkit.is())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/tabcont.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit e1dbdfc133a81eb065fb1426a2bd0f36244f5346
Author: Caolán McNamara
AuthorDate: Fri Mar 12 11:01:12 2021 +
Commit: Caolán McNamara
CommitDate: Fri Mar 12 15:38:50 2021 +0100
document how this ScTabControl::AllowRenaming condition can be reached
Change-Id: I127329794852c90edb3eceddf4974b2be7924362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112382
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/view/tabcont.cxx b/sc/source/ui/view/tabcont.cxx
index 2bb97d065cf8..c96f3424a511 100644
--- a/sc/source/ui/view/tabcont.cxx
+++ b/sc/source/ui/view/tabcont.cxx
@@ -625,6 +625,9 @@ TabBarAllowRenamingReturnCode ScTabControl::AllowRenaming()
{
// don't show error message above any modal dialog
// instead cancel renaming without error message
+// e.g. start with default Sheet1, add another sheet
+// alt+left click on Sheet2 tab, edit to say Sheet1
+// ctrl+S to trigger modal file save dialog
nRet = TABBAR_RENAMING_CANCEL;
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/png/PngImageReader.cxx |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
New commits:
commit 16638bb53b93d9b3ad356c2774532fca4699f041
Author: Luboš Luňák
AuthorDate: Tue Mar 9 16:54:38 2021 +0100
Commit: Luboš Luňák
CommitDate: Fri Mar 12 15:37:48 2021 +0100
make vcl::PngImageReader ignore crc if fuzzing
Similarly to the way vcl::PNGReader did.
Change-Id: I985d40fb117bfcdd5cf8b867d0fe55227bd7cff4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112210
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/vcl/source/filter/png/PngImageReader.cxx
b/vcl/source/filter/png/PngImageReader.cxx
index 1f1b632bbd0d..b385ba90a508 100644
--- a/vcl/source/filter/png/PngImageReader.cxx
+++ b/vcl/source/filter/png/PngImageReader.cxx
@@ -15,6 +15,7 @@
#include
#include
#include
+#include
#include
#include
@@ -101,7 +102,10 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
png_set_read_fn(pPng, , lclReadStream);
-png_set_crc_action(pPng, PNG_CRC_ERROR_QUIT, PNG_CRC_WARN_DISCARD);
+if (!utl::ConfigManager::IsFuzzing())
+png_set_crc_action(pPng, PNG_CRC_ERROR_QUIT, PNG_CRC_WARN_DISCARD);
+else
+png_set_crc_action(pPng, PNG_CRC_QUIET_USE, PNG_CRC_QUIET_USE);
png_set_sig_bytes(pPng, PNG_SIGNATURE_SIZE);
@@ -360,6 +364,7 @@ std::unique_ptr getMsGifChunk(SvStream&
rStream, sal_Int32* chunkSi
// try to get it using libpng.
// https://en.wikipedia.org/wiki/Portable_Network_Graphics#File_format
// Each chunk is: 4 bytes length, 4 bytes type, bytes, 4 bytes crc
+bool ignoreCrc = utl::ConfigManager::IsFuzzing();
for (;;)
{
sal_uInt32 length, type, crc;
@@ -392,7 +397,7 @@ std::unique_ptr getMsGifChunk(SvStream&
rStream, sal_Int32* chunkSi
return nullptr;
computedCrc = rtl_crc32(computedCrc, chunk.get(), length);
rStream.ReadUInt32(crc);
-if (crc != computedCrc)
+if (!ignoreCrc && crc != computedCrc)
continue; // invalid chunk, ignore
if (chunkSize)
*chunkSize = length;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source include/vcl sd/qa sd/source sfx2/source sw/qa vcl/Library_vcl.mk vcl/qa vcl/source vcl/workben
framework/source/uiconfiguration/imagemanagerimpl.cxx |6
include/vcl/filter/PngImageReader.hxx |4
include/vcl/pngread.hxx| 59
sd/qa/unit/export-tests-ooxml1.cxx |6
sd/qa/unit/import-tests.cxx| 16
sd/source/ui/slidesorter/cache/SlsBitmapCompressor.cxx |6
sfx2/source/control/recentdocsview.cxx |6
sfx2/source/control/thumbnailview.cxx |6
sw/qa/extras/ooxmlexport/ooxmlexport10.cxx |6
vcl/Library_vcl.mk |1
vcl/source/app/brand.cxx |7
vcl/source/filter/graphicfilter.cxx| 70
vcl/source/filter/png/PngImageReader.cxx |7
vcl/source/filter/png/pngread.cxx | 1708 -
vcl/source/treelist/transfer.cxx |7
vcl/workben/fftester.cxx |6
vcl/workben/pngfuzzer.cxx |6
vcl/workben/vcldemo.cxx|1
18 files changed, 63 insertions(+), 1865 deletions(-)
New commits:
commit e1d0846e060d2b3faedfe1a5877303037d8cf4d6
Author: Luboš Luňák
AuthorDate: Fri Mar 5 19:55:43 2021 +0100
Commit: Luboš Luňák
CommitDate: Fri Mar 12 15:37:21 2021 +0100
drop PNGReader and use only PngImageReader
PNGReader is a home-made PNG reader that does not use libpng,
so it's more code, presumably less optimized and it apparently also
doesn't always map colors properly.
The only two features it has that PngImageReader doesn't are explicit
chunk reading (used only for reading Microsoft's GIF in PNG, I
implemented that for PngImageReader in a previous commit), and it
loads paletted images as BitmapEx with a palette instead of
converting to direct-color 24/32bpp or 8bpp-gray. The latter is even
questional if nowadays that's feature or a misfeature, as it saves
memory at the expense of speed. I can implement that if somebody
misses it.
I had to adjust some tests:
- CVE-2016-0952-1.png - invalid CRC of the PNG header, neither Gimp
nor Gwenview can display that, it should fail
- afl-sample-Z_NEED_DICT.png - failure while decompressing data,
but the loader considers that only a partially broken image since
the header is correct, so it "passes" (like in Gimp or Gwenview)
- SdImportTest::testTdf134210() and
testPictureWithSchemeColor::Load_Verify_Reload_Verify()
need the colors tested changed, because apparently gamma correction
or something is now applied correctly, and it wasn't before (again
checked the loaded images with Gimp)
Change-Id: Id46f8d8a01256daf48ca64264b47c4e609183837
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112042
Tested-by: Jenkins
Reviewed-by: Noel Grandin
Reviewed-by: Luboš Luňák
diff --git a/framework/source/uiconfiguration/imagemanagerimpl.cxx
b/framework/source/uiconfiguration/imagemanagerimpl.cxx
index 64cf3a53342c..8b7733aac91e 100644
--- a/framework/source/uiconfiguration/imagemanagerimpl.cxx
+++ b/framework/source/uiconfiguration/imagemanagerimpl.cxx
@@ -42,7 +42,7 @@
#include
#include
#include
-#include
+#include
#include
#include
#include
@@ -333,8 +333,8 @@ void ImageManagerImpl::implts_loadUserImages(
BitmapEx aUserBitmap;
{
std::unique_ptr
pSvStream(utl::UcbStreamHelper::CreateStream( xBitmapStream ));
-vcl::PNGReader aPngReader( *pSvStream );
-aUserBitmap = aPngReader.Read();
+vcl::PngImageReader aPngReader( *pSvStream );
+aUserBitmap = aPngReader.read();
}
// Delete old image list and create a new one from the
read bitmap
diff --git a/include/vcl/filter/PngImageReader.hxx
b/include/vcl/filter/PngImageReader.hxx
index 2cd57549cf49..2615fd961bd4 100644
--- a/include/vcl/filter/PngImageReader.hxx
+++ b/include/vcl/filter/PngImageReader.hxx
@@ -33,7 +33,11 @@ class VCL_DLLPUBLIC PngImageReader
public:
PngImageReader(SvStream& rStream);
+// Returns true if image was successfully read without errors.
+// A usable bitmap may be returned even if there were errors (e.g.
incomplete image).
bool read(BitmapEx& rBitmap);
+// Returns a bitmap without indicating if there were errors.
+BitmapEx read();
// Returns the contents of the msOG chunk (containing a Gif image), if it
exists.
// Does not change position in the stream.
diff --git a/include/vcl/pngread.hxx b/include/vcl/pngread.hxx
deleted file mode 100644
index d3fa1942ee57..
--- a/include/vcl/pngread.hxx
+++ /dev/null
@@ -1,59 +0,0 @@
-/* -*- Mode: C++; tab-width: 4;
[Libreoffice-bugs] [Bug 140590] Crash in: mergedlo.dll: Using Save-As dialog in Tools>Chapter Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=140590 --- Comment #14 from Timur --- Crash still reproducible, test in Windows per comment 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/PngImageReader.hxx|5 +
vcl/source/filter/png/PngImageReader.cxx | 87 ---
2 files changed, 85 insertions(+), 7 deletions(-)
New commits:
commit e286bd791bfaa00746ea143303761f76e0af1f0d
Author: Luboš Luňák
AuthorDate: Fri Mar 5 19:42:41 2021 +0100
Commit: Luboš Luňák
CommitDate: Fri Mar 12 15:36:32 2021 +0100
add support for Microsoft Gif chunk to PngImageReader
Change-Id: I7d7f47041c48eb1a19e2aaee0c6da8c675ada4b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112039
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/include/vcl/filter/PngImageReader.hxx
b/include/vcl/filter/PngImageReader.hxx
index 97b2616883b2..2cd57549cf49 100644
--- a/include/vcl/filter/PngImageReader.hxx
+++ b/include/vcl/filter/PngImageReader.hxx
@@ -34,6 +34,11 @@ public:
PngImageReader(SvStream& rStream);
bool read(BitmapEx& rBitmap);
+
+// Returns the contents of the msOG chunk (containing a Gif image), if it
exists.
+// Does not change position in the stream.
+static std::unique_ptr getMicrosoftGifChunk(SvStream& rStream,
+ sal_Int32*
chunkSize = nullptr);
};
} // namespace vcl
diff --git a/vcl/source/filter/png/PngImageReader.cxx
b/vcl/source/filter/png/PngImageReader.cxx
index 3351e314b3fe..829f3dd45bca 100644
--- a/vcl/source/filter/png/PngImageReader.cxx
+++ b/vcl/source/filter/png/PngImageReader.cxx
@@ -10,6 +10,7 @@
#include
#include
+#include
#include
#include
#include
@@ -40,18 +41,20 @@ void lclReadStream(png_structp pPng, png_bytep pOutBytes,
png_size_t nBytesToRea
}
}
-bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool bUseBitmap32)
-{
-enum
-{
-PNG_SIGNATURE_SIZE = 8
-};
+constexpr int PNG_SIGNATURE_SIZE = 8;
+bool isPng(SvStream& rStream)
+{
// Check signature bytes
sal_uInt8 aHeader[PNG_SIGNATURE_SIZE];
rStream.ReadBytes(aHeader, PNG_SIGNATURE_SIZE);
-if (png_sig_cmp(aHeader, 0, PNG_SIGNATURE_SIZE))
+return png_sig_cmp(aHeader, 0, PNG_SIGNATURE_SIZE) == 0;
+}
+
+bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool bUseBitmap32)
+{
+if (!isPng(rStream))
return false;
png_structp pPng = png_create_read_struct(PNG_LIBPNG_VER_STRING, nullptr,
nullptr, nullptr);
@@ -347,6 +350,64 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
return true;
}
+std::unique_ptr getMsGifChunk(SvStream& rStream, sal_Int32*
chunkSize)
+{
+if (chunkSize)
+*chunkSize = 0;
+if (!isPng(rStream))
+return nullptr;
+// It's easier to read manually the contents and find the chunk than
+// try to get it using libpng.
+// https://en.wikipedia.org/wiki/Portable_Network_Graphics#File_format
+// Each chunk is: 4 bytes length, 4 bytes type, bytes, 4 bytes crc
+for (;;)
+{
+sal_uInt32 length, type, crc;
+rStream.ReadUInt32(length);
+rStream.ReadUInt32(type);
+if (!rStream.good())
+return nullptr;
+constexpr sal_uInt32 PNGCHUNK_msOG = 0x6d734f47; // Microsoft Office
Animated GIF
+constexpr sal_uInt64 MSGifHeaderSize = 11; // "MSOFFICE9.0"
+if (type == PNGCHUNK_msOG && length > MSGifHeaderSize)
+{
+// calculate chunktype CRC (swap it back to original byte order)
+sal_uInt32 typeForCrc = type;
+#if defined(__LITTLEENDIAN) || defined(OSL_LITENDIAN)
+typeForCrc = OSL_SWAPDWORD(typeForCrc);
+#endif
+sal_uInt32 computedCrc = rtl_crc32(0, , 4);
+const sal_uInt64 pos = rStream.Tell();
+if (pos + length >= rStream.TellEnd())
+return nullptr; // broken PNG
+
+char msHeader[MSGifHeaderSize];
+if (rStream.ReadBytes(msHeader, MSGifHeaderSize) !=
MSGifHeaderSize)
+return nullptr;
+computedCrc = rtl_crc32(computedCrc, msHeader, MSGifHeaderSize);
+length -= MSGifHeaderSize;
+
+std::unique_ptr chunk(new sal_uInt8[length]);
+if (rStream.ReadBytes(chunk.get(), length) != length)
+return nullptr;
+computedCrc = rtl_crc32(computedCrc, chunk.get(), length);
+rStream.ReadUInt32(crc);
+if (crc != computedCrc)
+continue; // invalid chunk, ignore
+if (chunkSize)
+*chunkSize = length;
+return chunk;
+}
+if (rStream.remainingSize() < length)
+return nullptr;
+rStream.SeekRel(length);
+rStream.ReadUInt32(crc);
+constexpr sal_uInt32 PNGCHUNK_IEND = 0x49454e44;
+if (type == PNGCHUNK_IEND)
+return nullptr;
+}
+}
+
} // anonymous namespace
namespace vcl
@@ -364,6 +425,18 @@ bool PngImageReader::read(BitmapEx& rBitmapEx)
return reader(mrStream, rBitmapEx, bSupportsBitmap32);
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/png/PngImageReader.cxx | 37 +--
1 file changed, 35 insertions(+), 2 deletions(-)
New commits:
commit 12eac05c8088cefadace2629efce5473212662eb
Author: Luboš Luňák
AuthorDate: Fri Mar 5 21:45:11 2021 +0100
Commit: Luboš Luňák
CommitDate: Fri Mar 12 15:36:05 2021 +0100
make PngImageReader read grayscale images as 8bpp, not 24bpp
Grayscale is still a direct-color format, so it can save memory
while not being slow (well, at least with Skia I made sure it's
fast). PNGReader also reads grayscale images this way.
Change-Id: I896f9901aca4defc8263fdcea6d2bebd574d1e8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112040
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
Reviewed-by: Luboš Luňák
diff --git a/vcl/source/filter/png/PngImageReader.cxx
b/vcl/source/filter/png/PngImageReader.cxx
index a510c6704686..3351e314b3fe 100644
--- a/vcl/source/filter/png/PngImageReader.cxx
+++ b/vcl/source/filter/png/PngImageReader.cxx
@@ -134,7 +134,9 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
if (bitDepth < 8)
png_set_packing(pPng);
-if (colorType == PNG_COLOR_TYPE_GRAY || colorType ==
PNG_COLOR_TYPE_GRAY_ALPHA)
+// Convert gray+alpha to RGBA, keep gray as gray.
+if (colorType == PNG_COLOR_TYPE_GRAY_ALPHA
+|| (colorType == PNG_COLOR_TYPE_GRAY && png_get_valid(pPng, pInfo,
PNG_INFO_tRNS)))
{
png_set_gray_to_rgb(pPng);
}
@@ -154,7 +156,9 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
return false;
}
-if (bitDepth != 8 || (colorType != PNG_COLOR_TYPE_RGB && colorType !=
PNG_COLOR_TYPE_RGB_ALPHA))
+if (bitDepth != 8
+|| (colorType != PNG_COLOR_TYPE_RGB && colorType !=
PNG_COLOR_TYPE_RGB_ALPHA
+&& colorType != PNG_COLOR_TYPE_GRAY))
{
png_destroy_read_struct(, , nullptr);
return false;
@@ -299,6 +303,35 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
rBitmapEx = BitmapEx(aBitmap, aBitmapAlpha);
}
}
+else if (colorType == PNG_COLOR_TYPE_GRAY)
+{
+size_t aRowSizeBytes = png_get_rowbytes(pPng, pInfo);
+
+aBitmap = Bitmap(Size(width, height), 8,
::GetGreyPalette(256));
+aBitmap.Erase(COL_WHITE);
+{
+pWriteAccess = BitmapScopedWriteAccess(aBitmap);
+
+aRows = std::vector>(height);
+for (auto& rRow : aRows)
+rRow.resize(aRowSizeBytes, 0);
+
+for (int pass = 0; pass < nNumberOfPasses; pass++)
+{
+for (png_uint_32 y = 0; y < height; y++)
+{
+Scanline pScanline = pWriteAccess->GetScanline(y);
+png_bytep pRow = aRows[y].data();
+png_read_row(pPng, pRow, nullptr);
+size_t iColor = 0;
+for (size_t i = 0; i < aRowSizeBytes; ++i)
+pScanline[iColor++] = pRow[i];
+}
+}
+pWriteAccess.reset();
+}
+rBitmapEx = BitmapEx(aBitmap);
+}
}
png_read_end(pPng, pInfo);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/png/PngImageReader.cxx |4
1 file changed, 4 deletions(-)
New commits:
commit 750f9f2ac4f713115b07c6ab8db014ff6e3270a9
Author: Luboš Luňák
AuthorDate: Thu Mar 11 11:28:27 2021 +0100
Commit: Luboš Luňák
CommitDate: Fri Mar 12 15:35:33 2021 +0100
do not clear bitmaps in png loader just for broken images
As Tomaž pointed out, this is optimizing for a rare scenario.
The clearing is actually a memset(), so it's not that expensive,
but fair enough, a broken image is a broken image.
Change-Id: I42e3672be8c493d22599a856534b3cb9eaec4ae2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112325
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/vcl/source/filter/png/PngImageReader.cxx
b/vcl/source/filter/png/PngImageReader.cxx
index ad778bce6aba..a510c6704686 100644
--- a/vcl/source/filter/png/PngImageReader.cxx
+++ b/vcl/source/filter/png/PngImageReader.cxx
@@ -177,7 +177,6 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
size_t aRowSizeBytes = png_get_rowbytes(pPng, pInfo);
aBitmap = Bitmap(Size(width, height), 24);
-aBitmap.Erase(COL_WHITE);
{
pWriteAccess = BitmapScopedWriteAccess(aBitmap);
ScanlineFormat eFormat = pWriteAccess->GetScanlineFormat();
@@ -215,7 +214,6 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
if (bUseBitmap32)
{
aBitmap = Bitmap(Size(width, height), 32);
-aBitmap.Erase(COL_WHITE);
{
pWriteAccess = BitmapScopedWriteAccess(aBitmap);
ScanlineFormat eFormat = pWriteAccess->GetScanlineFormat();
@@ -264,8 +262,6 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
{
aBitmap = Bitmap(Size(width, height), 24);
aBitmapAlpha = AlphaMask(Size(width, height), nullptr);
-aBitmap.Erase(COL_WHITE);
-aBitmapAlpha.Erase(0xff); // transparent
{
pWriteAccess = BitmapScopedWriteAccess(aBitmap);
ScanlineFormat eFormat = pWriteAccess->GetScanlineFormat();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/png/PngImageReader.cxx | 60 ---
1 file changed, 47 insertions(+), 13 deletions(-)
New commits:
commit da4de084d20116f0ae49b43cd454188fde2ddac9
Author: Luboš Luňák
AuthorDate: Fri Mar 5 19:38:07 2021 +0100
Commit: Luboš Luňák
CommitDate: Fri Mar 12 15:35:16 2021 +0100
make PngImageReader return partially broken images
This makes it consistent with PNGReader, which is capable of reading
in e.g. the invalid-chunk.png test file.
Change-Id: Ia3b5553e588ac5778fad6de5bc284d5822febbda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112038
Reviewed-by: Tomaž Vajngerl
Reviewed-by: Luboš Luňák
Tested-by: Jenkins
diff --git a/vcl/source/filter/png/PngImageReader.cxx
b/vcl/source/filter/png/PngImageReader.cxx
index be94f99b04d2..ad778bce6aba 100644
--- a/vcl/source/filter/png/PngImageReader.cxx
+++ b/vcl/source/filter/png/PngImageReader.cxx
@@ -33,7 +33,11 @@ void lclReadStream(png_structp pPng, png_bytep pOutBytes,
png_size_t nBytesToRea
sal_Size nBytesRead = pStream->ReadBytes(pOutBytes, nBytesToRead);
if (nBytesRead != nBytesToRead)
-png_error(pPng, "Error reading");
+{
+// Make sure to not reuse old data (could cause infinite loop).
+memset(pOutBytes + nBytesRead, 0, nBytesToRead - nBytesRead);
+png_warning(pPng, "Error reading");
+}
}
bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool bUseBitmap32)
@@ -61,9 +65,32 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
return false;
}
+// All variables holding resources need to be declared here in order to be
+// properly cleaned up in case of an error, otherwise libpng's longjmp()
+// jumps over the destructor calls.
+Bitmap aBitmap;
+AlphaMask aBitmapAlpha;
+Size prefSize;
+BitmapScopedWriteAccess pWriteAccess;
+AlphaScopedWriteAccess pWriteAccessAlpha;
+std::vector> aRows;
+
if (setjmp(png_jmpbuf(pPng)))
{
png_destroy_read_struct(, , nullptr);
+// Set the bitmap if it contains something, even on failure. This
allows
+// reading images that are only partially broken.
+pWriteAccess.reset();
+pWriteAccessAlpha.reset();
+if (!aBitmap.IsEmpty() && !aBitmapAlpha.IsEmpty())
+rBitmapEx = BitmapEx(aBitmap, aBitmapAlpha);
+else if (!aBitmap.IsEmpty())
+rBitmapEx = BitmapEx(aBitmap);
+if (!rBitmapEx.IsEmpty() && !prefSize.IsEmpty())
+{
+rBitmapEx.SetPrefMapMode(MapMode(MapUnit::Map100thMM));
+rBitmapEx.SetPrefSize(prefSize);
+}
return false;
}
@@ -133,7 +160,6 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
return false;
}
-Size prefSize;
png_uint_32 res_x = 0;
png_uint_32 res_y = 0;
int unit_type = 0;
@@ -150,14 +176,15 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
{
size_t aRowSizeBytes = png_get_rowbytes(pPng, pInfo);
-Bitmap aBitmap(Size(width, height), 24);
+aBitmap = Bitmap(Size(width, height), 24);
+aBitmap.Erase(COL_WHITE);
{
-BitmapScopedWriteAccess pWriteAccess(aBitmap);
+pWriteAccess = BitmapScopedWriteAccess(aBitmap);
ScanlineFormat eFormat = pWriteAccess->GetScanlineFormat();
if (eFormat == ScanlineFormat::N24BitTcBgr)
png_set_bgr(pPng);
-std::vector> aRows(height);
+aRows = std::vector>(height);
for (auto& rRow : aRows)
rRow.resize(aRowSizeBytes, 0);
@@ -177,6 +204,7 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
}
}
}
+pWriteAccess.reset();
}
rBitmapEx = BitmapEx(aBitmap);
}
@@ -186,9 +214,10 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
if (bUseBitmap32)
{
-Bitmap aBitmap(Size(width, height), 32);
+aBitmap = Bitmap(Size(width, height), 32);
+aBitmap.Erase(COL_WHITE);
{
-BitmapScopedWriteAccess pWriteAccess(aBitmap);
+pWriteAccess = BitmapScopedWriteAccess(aBitmap);
ScanlineFormat eFormat = pWriteAccess->GetScanlineFormat();
if (eFormat == ScanlineFormat::N32BitTcAbgr
|| eFormat == ScanlineFormat::N32BitTcBgra)
@@ -196,7 +225,7 @@ bool reader(SvStream& rStream, BitmapEx& rBitmapEx, bool
bUseBitmap32)
png_set_bgr(pPng);
}
-std::vector> aRows(height);
+aRows = std::vector>(height);
[Libreoffice-bugs] [Bug 129085] From version 6.1.x, some images in Writer not printed with "Tight" or "Through" or "Parallel" wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=129085 --- Comment #35 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f4f6ec04544059910ab5ec47817fad2287dd3f5a tdf#129085: vcl_pdfexport: Add unittest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129085] From version 6.1.x, some images in Writer not printed with "Tight" or "Through" or "Parallel" wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=129085 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/pdfexport/data/tdf129085.docx |binary
vcl/qa/cppunit/pdfexport/pdfexport.cxx | 43 +++
2 files changed, 43 insertions(+)
New commits:
commit f4f6ec04544059910ab5ec47817fad2287dd3f5a
Author: Xisco Fauli
AuthorDate: Thu Mar 11 14:00:26 2021 +0100
Commit: Xisco Fauli
CommitDate: Fri Mar 12 15:33:41 2021 +0100
tdf#129085: vcl_pdfexport: Add unittest
Change-Id: Id0d46d258c960e31896bdf5b288135364f0ecd2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112342
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/vcl/qa/cppunit/pdfexport/data/tdf129085.docx
b/vcl/qa/cppunit/pdfexport/data/tdf129085.docx
new file mode 100644
index ..6ac21d8f28b8
Binary files /dev/null and b/vcl/qa/cppunit/pdfexport/data/tdf129085.docx differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index a15832aeabff..514ea6ef73bc 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -1780,6 +1780,49 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf121615)
CPPUNIT_ASSERT_EQUAL(COL_BLACK, aBitmap.GetPixelColor(199, 299));
}
+CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf129085)
+{
+vcl::filter::PDFDocument aDocument;
+load(u"tdf129085.docx", aDocument);
+
+// The document has one page.
+std::vector aPages = aDocument.GetPages();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), aPages.size());
+
+// Get access to the only image on the only page.
+vcl::filter::PDFObjectElement* pResources =
aPages[0]->LookupObject("Resources");
+CPPUNIT_ASSERT(pResources);
+auto pXObjects
+=
dynamic_cast(pResources->Lookup("XObject"));
+
+// Without the fix in place, this test would have failed here
+CPPUNIT_ASSERT(pXObjects);
+CPPUNIT_ASSERT_EQUAL(static_cast(1), pXObjects->GetItems().size());
+vcl::filter::PDFObjectElement* pXObject
+= pXObjects->LookupObject(pXObjects->GetItems().begin()->first);
+CPPUNIT_ASSERT(pXObject);
+vcl::filter::PDFStreamElement* pStream = pXObject->GetStream();
+CPPUNIT_ASSERT(pStream);
+SvMemoryStream& rObjectStream = pStream->GetMemory();
+
+// Load the embedded image.
+rObjectStream.Seek(0);
+GraphicFilter& rFilter = GraphicFilter::GetGraphicFilter();
+Graphic aGraphic;
+sal_uInt16 format;
+ErrCode bResult = rFilter.ImportGraphic(aGraphic, OUString("import"),
rObjectStream,
+GRFILTER_FORMAT_DONTKNOW, );
+CPPUNIT_ASSERT_EQUAL(ERRCODE_NONE, bResult);
+
+sal_uInt16 jpegFormat =
rFilter.GetImportFormatNumberForShortName(JPG_SHORTNAME);
+CPPUNIT_ASSERT(jpegFormat != GRFILTER_FORMAT_NOTFOUND);
+CPPUNIT_ASSERT_EQUAL(jpegFormat, format);
+BitmapEx aBitmap = aGraphic.GetBitmapEx();
+CPPUNIT_ASSERT_EQUAL(tools::Long(884), aBitmap.GetSizePixel().Width());
+CPPUNIT_ASSERT_EQUAL(tools::Long(925), aBitmap.GetSizePixel().Height());
+CPPUNIT_ASSERT_EQUAL(24, int(aBitmap.GetBitCount()));
+}
+
CPPUNIT_TEST_FIXTURE(PdfExportTest, testTocLink)
{
// Load the Writer document.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/pdfexport/data/tdf124272.odt |binary
vcl/qa/cppunit/pdfexport/pdfexport.cxx | 44
2 files changed, 44 insertions(+)
New commits:
commit 2f1e74c77eb13b53a7d4b5d31a7f2ac9ff8f
Author: Xisco Fauli
AuthorDate: Thu Mar 11 13:21:49 2021 +0100
Commit: Xisco Fauli
CommitDate: Fri Mar 12 15:33:03 2021 +0100
tdf#124272: vcl_pdfexport: Add unittest
Change-Id: I5d5aa7a2b9cc9c7cb522a84e00d48a348912ad95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112341
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/vcl/qa/cppunit/pdfexport/data/tdf124272.odt
b/vcl/qa/cppunit/pdfexport/data/tdf124272.odt
new file mode 100644
index ..54d4dcb2a1a4
Binary files /dev/null and b/vcl/qa/cppunit/pdfexport/data/tdf124272.odt differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 365a9a0955c1..a15832aeabff 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -1688,6 +1688,50 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf115967)
CPPUNIT_ASSERT_EQUAL(OUString("m=750abc"), sText);
}
+CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf124272)
+{
+// Import the bugdoc and export as PDF.
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) +
"tdf124272.odt";
+mxComponent = loadFromDesktop(aURL);
+
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+utl::MediaDescriptor aMediaDescriptor;
+aMediaDescriptor["FilterName"] <<= OUString("writer_pdf_Export");
+xStorable->storeToURL(maTempFile.GetURL(),
aMediaDescriptor.getAsConstPropertyValueList());
+
+// Parse the export result.
+vcl::filter::PDFDocument aDocument;
+SvFileStream aStream(maTempFile.GetURL(), StreamMode::READ);
+CPPUNIT_ASSERT(aDocument.Read(aStream));
+
+// The document has one page.
+std::vector aPages = aDocument.GetPages();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), aPages.size());
+
+// The page has a stream.
+vcl::filter::PDFObjectElement* pContents =
aPages[0]->LookupObject("Contents");
+CPPUNIT_ASSERT(pContents);
+vcl::filter::PDFStreamElement* pStream = pContents->GetStream();
+CPPUNIT_ASSERT(pStream);
+SvMemoryStream& rObjectStream = pStream->GetMemory();
+// Uncompress it.
+SvMemoryStream aUncompressed;
+ZCodec aZCodec;
+aZCodec.BeginCompression();
+rObjectStream.Seek(0);
+aZCodec.Decompress(rObjectStream, aUncompressed);
+CPPUNIT_ASSERT(aZCodec.EndCompression());
+
+OString aBitmap("Q q 299.899 782.189 m\n"
+"55.2 435.889 l 299.899 435.889 l 299.899 782.189 l\n"
+"h");
+
+auto pStart = static_cast(aUncompressed.GetData());
+const char* pEnd = pStart + aUncompressed.GetSize();
+auto it = std::search(pStart, pEnd, aBitmap.getStr(), aBitmap.getStr() +
aBitmap.getLength());
+CPPUNIT_ASSERT(it != pEnd);
+}
+
CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf121615)
{
vcl::filter::PDFDocument aDocument;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/helper/xmlsignaturehelper.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit c0ec7d342bd715d9910cf28afe10a6bfa3ba28cb
Author: Caolán McNamara
AuthorDate: Thu Mar 11 20:23:31 2021 +
Commit: Miklos Vajna
CommitDate: Fri Mar 12 15:29:47 2021 +0100
do same set error state as ReadAndVerifySignature does
this function is nearly exactly the same as ReadAndVerifySignature
except it doesn't set error-state on exception during parse
Change-Id: Ife881f639a11d3185920ca62cc2cd22812fae36d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112366
Tested-by: Jenkins
Reviewed-by: Michael Stahl
Reviewed-by: Miklos Vajna
diff --git a/xmlsecurity/source/helper/xmlsignaturehelper.cxx
b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
index d91a02ad8124..18ed40ce6ac5 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper.cxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
@@ -406,6 +406,7 @@ bool
XMLSignatureHelper::ReadAndVerifySignatureStorageStream(const css::uno::Ref
catch(const uno::Exception&)
{
DBG_UNHANDLED_EXCEPTION("xmlsecurity.helper");
+mbError = true;
}
// release the signature reader
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/calc_tests2/tdf105268.py | 35 --
sc/qa/unit/ucalc.cxx | 14 +
2 files changed, 14 insertions(+), 35 deletions(-)
New commits:
commit 1af1458fa44c6ed9f73a68696f494657ef8e2bc5
Author: Xisco Fauli
AuthorDate: Fri Mar 12 12:09:42 2021 +0100
Commit: Xisco Fauli
CommitDate: Fri Mar 12 15:24:25 2021 +0100
tdf#105268: sc: move UItest to CppUnittest
Change-Id: I90d896b14b7e75d1586aa4ea329b0d80a32d45fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112380
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/uitest/calc_tests2/tdf105268.py
b/sc/qa/uitest/calc_tests2/tdf105268.py
deleted file mode 100644
index f501e3511048..
--- a/sc/qa/uitest/calc_tests2/tdf105268.py
+++ /dev/null
@@ -1,35 +0,0 @@
-# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-from uitest.framework import UITestCase
-from uitest.uihelper.common import get_state_as_dict
-from uitest.uihelper.common import select_pos
-from uitest.uihelper.calc import enter_text_to_cell
-from libreoffice.calc.document import get_cell_by_position
-from libreoffice.uno.propertyvalue import mkPropertyValues
-#Bug 105268 - Auto Fill: The Next Value for "001-001-001" is "001-001-002"
Rather than "001-001000"
-
-class tdf105268(UITestCase):
-def test_tdf105268(self):
-calc_doc = self.ui_test.create_doc_in_start_center("calc")
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-document = self.ui_test.get_component()
-enter_text_to_cell(gridwin, "A1", "001-001-001")
-gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": "A1:A3"}))
-self.ui_test.execute_dialog_through_command(".uno:FillSeries")
-xDialog = self.xUITest.getTopFocusWindow()
-xautofill = xDialog.getChild("autofill")
-xautofill.executeAction("CLICK", tuple())
-xOK = xDialog.getChild("ok")
-self.ui_test.close_dialog_through_button(xOK)
-self.assertEqual(get_cell_by_position(document, 0, 0, 0).getString(),
"001-001-001")
-self.assertEqual(get_cell_by_position(document, 0, 0, 1).getString(),
"001-001-002")
-self.assertEqual(get_cell_by_position(document, 0, 0, 2).getString(),
"001-001-003")
-
-self.ui_test.close_doc()
-
-# vim: set shiftwidth=4 softtabstop=4 expandtab:
\ No newline at end of file
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 57525bea2c3a..5fab68bcf3f1 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -4989,6 +4989,20 @@ void Test::testAutoFill()
CPPUNIT_ASSERT_EQUAL( OUString("4.5"), m_pDoc->GetString( 0, 65, 0 ) );
CPPUNIT_ASSERT_EQUAL( OUString("4.6"), m_pDoc->GetString( 0, 66, 0 ) );
+// Clear column A for a new test.
+clearRange(m_pDoc, ScRange(0,0,0,0,MAXROW,0));
+m_pDoc->SetRowHidden(0, MAXROW, 0, false); // Show all rows.
+
+m_pDoc->SetString( 0, 70, 0, "001-001-001" );
+m_pDoc->Fill( 0, 70, 0, 70, nullptr, aMarkData, 3, FILL_TO_BOTTOM,
FILL_AUTO );
+
+// tdf#105268: Without the fix in place, this test would have failed with
+// - Expected: 001-001-002
+// - Actual : 001-001000
+CPPUNIT_ASSERT_EQUAL( OUString("001-001-002"), m_pDoc->GetString( 0, 71, 0
) );
+CPPUNIT_ASSERT_EQUAL( OUString("001-001-003"), m_pDoc->GetString( 0, 72, 0
) );
+CPPUNIT_ASSERT_EQUAL( OUString("001-001-004"), m_pDoc->GetString( 0, 73, 0
) );
+
m_pDoc->DeleteTab(0);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140985] New: make hyperlink able to start apps/external .exe
https://bugs.documentfoundation.org/show_bug.cgi?id=140985 Bug ID: 140985 Summary: make hyperlink able to start apps/external .exe Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mh...@gmx.net Make the function HYPERLINK in writer able to open local links to apps/.exe aswell. Martin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50128] Formula "=HYPERLINK()" makes not executable links
https://bugs.documentfoundation.org/show_bug.cgi?id=50128 mhonline changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|REOPENED --- Comment #7 from mhonline --- that function is not working No .exe can be started only docs/files by using the system-settings to interpret the file-extension (like *.doc etc) martin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140952] windows10 update 10/3/21
https://bugs.documentfoundation.org/show_bug.cgi?id=140952 --- Comment #9 from Mike Kaganski --- (In reply to mejames1974 from comment #8) > I did not attempt to print anything after switching the computer on the day > after the update. LibreOffice might still communicate with driver of the printer configured in the document when loading it, e.g. to get a list of supported paper types, or margins, or something like that. See e.g. tdf#42673, or tdf#116679, where printer was communicated at opening Format -> Character. > (The printer I use is a Kyocera FS C5100DN colour laser) Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=129062 Bug 129062 depends on bug 140930, which changed state. Bug 140930 Summary: Crash on saving with Skia and custom shape with stretched bitmap https://bugs.documentfoundation.org/show_bug.cgi?id=140930 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140930] Crash on saving with Skia and custom shape with stretched bitmap
https://bugs.documentfoundation.org/show_bug.cgi?id=140930 Regina Henschel changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140930] Crash on saving with Skia and custom shape with stretched bitmap
https://bugs.documentfoundation.org/show_bug.cgi?id=140930 --- Comment #4 from Regina Henschel --- Created attachment 170442 --> https://bugs.documentfoundation.org/attachment.cgi?id=170442=edit File with extruded custom shape No, it is not duplicate, but might be a problem with a debug build. I do not see it with the daily build, but with both of my debug builds. Open attached file. Select the object and rotate it a little bit. 3D-Rotating is in toolbar "3D Settings". Then save the document _while the object is still selected_. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140984] EDITING Autofill with user list does not change small/large caps
https://bugs.documentfoundation.org/show_bug.cgi?id=140984 --- Comment #2 from NISZ LibreOffice Team --- Created attachment 170441 --> https://bugs.documentfoundation.org/attachment.cgi?id=170441=edit Screenshot of the original document after autofilling side by side in Excel and Calc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140984] EDITING Autofill with user list does not change small/large caps
https://bugs.documentfoundation.org/show_bug.cgi?id=140984 --- Comment #1 from NISZ LibreOffice Team --- Created attachment 170440 --> https://bugs.documentfoundation.org/attachment.cgi?id=170440=edit Screenshot of the original document side by side in Excel and Calc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140984] New: EDITING Autofill with user list does not change small/large caps
https://bugs.documentfoundation.org/show_bug.cgi?id=140984 Bug ID: 140984 Summary: EDITING Autofill with user list does not change small/large caps Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@nisz.hu CC: nem...@numbertext.org, szucs.atti...@nisz.hu Blocks: 113499 Created attachment 170439 --> https://bugs.documentfoundation.org/attachment.cgi?id=170439=edit Example file from Excel Attached Excel-made file contains day names which are also defined as user lists in both Excel and Calc. When there is a series of these in Excel, autofilling considers the starting small/large capitals and fills cells according to the first cells capitals. Calc always autofills with small caps. Steps to reproduce: 1. Open attached file in Excel and Calc 2. Select B2:C2 and autofill to H2 3. Select B4:C4 and autofill to H4 Actual results: In Excel D2:H2 becomes filled with large capitals day names. In Calc D2:H2 is also filled with small capitals day names. D4:H4 becomes filled with small capitals day names in both programs, this is good. Expected results: In Calc D2:H2 should be filled with large capitals day names. LibreOffice details: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 9d8accf03984a64a4105826e55b221962628eb93 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-GB Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113499 [Bug 113499] [META] AutoFill bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113499] [META] AutoFill bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113499 NISZ LibreOffice Team changed: What|Removed |Added Depends on||140984 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140984 [Bug 140984] EDITING Autofill with user list does not change small/large caps -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140952] windows10 update 10/3/21
https://bugs.documentfoundation.org/show_bug.cgi?id=140952 --- Comment #8 from mejames1...@outlook.com --- I did not attempt to print anything after switching the computer on the day after the update. (The printer I use is a Kyocera FS C5100DN colour laser) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - 4 commits - external/cairo
external/cairo/ExternalProject_cairo.mk |1
external/cairo/UnpackedTarball_cairo.mk |3
external/cairo/cairo/cairo.oldfreetype.patch| 112 ++--
external/cairo/cairo/cairo.oldfreetypecentos6.patch | 78 +
4 files changed, 119 insertions(+), 75 deletions(-)
New commits:
commit 3fb1632217a1d7aa05d28482c1291123daee0da1
Author: Miklos Vajna
AuthorDate: Thu Sep 24 10:39:01 2020 +0200
Commit: Andras Timar
CommitDate: Fri Mar 12 14:54:08 2021 +0100
cairo: avoid linking to freetype-2.8-only FT_Get_Var_Design_Coordinates
This is meant to help producing binaries which run on Ubuntu 16.04.
Change-Id: I7fc965c265d2ac97a6836df0829d3d4cd0cc9333
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103295
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/external/cairo/cairo/cairo.oldfreetype.patch
b/external/cairo/cairo/cairo.oldfreetype.patch
index 2ccc1908fa22..a25c8bbdd030 100644
--- a/external/cairo/cairo/cairo.oldfreetype.patch
+++ b/external/cairo/cairo/cairo.oldfreetype.patch
@@ -9,3 +9,34 @@
/* If FT_Get_Var_Blend_Coordinates() is available, we can check if the
* current design coordinates are the default coordinates. In this case
* the current outlines match the font tables.
+--- a/cairo/src/cairo-ft-font.c2020-09-24 10:35:25.391941702 +0200
b/cairo/src/cairo-ft-font.c2020-09-24 10:35:39.900126419 +0200
+@@ -451,7 +451,7 @@
+ unscaled->have_color = FT_HAS_COLOR (face) != 0;
+ unscaled->have_color_set = TRUE;
+
+-#ifdef HAVE_FT_GET_VAR_DESIGN_COORDINATES
++#if 0
+ {
+ FT_MM_Var *ft_mm_var;
+ if (0 == FT_Get_MM_Var (face, _mm_var))
+@@ -2377,7 +2377,7 @@
+ }
+
+ current_coords = malloc (sizeof (FT_Fixed) * ft_mm_var->num_axis);
+-#ifdef HAVE_FT_GET_VAR_DESIGN_COORDINATES
++#if 0
+ ret = FT_Get_Var_Design_Coordinates (face, ft_mm_var->num_axis,
current_coords);
+ if (ret == 0) {
+ for (i = 0; i < ft_mm_var->num_axis; i++) {
+--- a/cairo/test/font-variations.c 2020-09-24 10:36:01.592402635 +0200
b/cairo/test/font-variations.c 2020-09-24 10:36:08.728493510 +0200
+@@ -117,7 +117,7 @@
+ return CAIRO_TEST_FAILURE;
+ }
+
+-#ifdef HAVE_FT_GET_VAR_DESIGN_COORDINATES
++#if 0
+ ret = FT_Get_Var_Design_Coordinates (ft_face, 20, coords);
+ if (ret != 0) {
+ cairo_test_log (ctx, "Failed to get coords");
commit 6a25c5a13b510d78ed96b6d14a251a9de335a2e1
Author: Miklos Vajna
AuthorDate: Wed Sep 23 13:48:11 2020 +0200
Commit: Andras Timar
CommitDate: Fri Mar 12 14:53:43 2021 +0100
cairo: avoid linking to freetype-2.8 symbols
This is meant to help producing binaries which run on Ubuntu 16.04.
Change-Id: Ie4cd3fe707225a951ec8a5fb49a755064701dcfa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103248
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/external/cairo/UnpackedTarball_cairo.mk
b/external/cairo/UnpackedTarball_cairo.mk
index 186971410840..b31c61bac5f5 100644
--- a/external/cairo/UnpackedTarball_cairo.mk
+++ b/external/cairo/UnpackedTarball_cairo.mk
@@ -15,6 +15,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,cairo,\
external/cairo/cairo/cairo-1.10.2.patch \
external/cairo/cairo/cairo.oldfreetypecentos6.patch \
external/cairo/cairo/cairo-libtool-rpath.patch.1 \
+ external/cairo/cairo/cairo.oldfreetype.patch \
))
ifeq ($(OS),iOS)
diff --git a/external/cairo/cairo/cairo.oldfreetype.patch
b/external/cairo/cairo/cairo.oldfreetype.patch
new file mode 100644
index ..2ccc1908fa22
--- /dev/null
+++ b/external/cairo/cairo/cairo.oldfreetype.patch
@@ -0,0 +1,11 @@
+--- a/cairo/src/cairo-ft-font.c2020-09-23 15:27:09.114619562 +0200
b/cairo/src/cairo-ft-font.c2020-09-23 15:27:22.602808705 +0200
+@@ -2838,7 +2838,7 @@
+ goto cleanup;
+ }
+
+-#if FREETYPE_MAJOR > 2 || ( FREETYPE_MAJOR == 2 && FREETYPE_MINOR >= 8)
++#if 0
+ /* If FT_Get_Var_Blend_Coordinates() is available, we can check if the
+* current design coordinates are the default coordinates. In this case
+* the current outlines match the font tables.
commit eda42b714c0e5db7bbb8565e0a25ad5e31e5b546
Author: Andras Timar
AuthorDate: Fri Mar 12 14:53:23 2021 +0100
Commit: Andras Timar
CommitDate: Fri Mar 12 14:53:23 2021 +0100
rename a cairo patch to make room for the next patch
Change-Id: If1964ebfec41074e8d1ef83428e6e51a4b68df52
diff --git a/external/cairo/UnpackedTarball_cairo.mk
b/external/cairo/UnpackedTarball_cairo.mk
index 7d3537bbc4fb..186971410840 100644
--- a/external/cairo/UnpackedTarball_cairo.mk
+++ b/external/cairo/UnpackedTarball_cairo.mk
@@ -13,7 +13,7 @@ $(eval $(call
gb_UnpackedTarball_set_tarball,cairo,$(CAIRO_TARBALL),,cairo))
[Libreoffice-bugs] [Bug 140983] New: Help takes 22 seconds to fully load the page on Chrome and Edge
https://bugs.documentfoundation.org/show_bug.cgi?id=140983 Bug ID: 140983 Summary: Help takes 22 seconds to fully load the page on Chrome and Edge Product: LibreOffice Version: 7.0.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bill.spar...@uwclub.net CC: olivier.hal...@libreoffice.org Description: While working on a spreadsheet, for example, I press F1 or select Help / LibreOffice Help. My default browser opens (Chrome in my case) and the right half of the help page loads instantly. There is then a delay of 22 seconds, with the progress indicator on the tab going round and round, before the topic list on the left of the help page opens. With the help page open, I can often recreate this delay by switching to another module using the Module drop-down menu. This is step does not consistently recreate the delay, however. Some modules never exhibit this delay, while others (predominantly Calc, Writer and Chart) re-create the delay maybe half of the occasions. I can get this problem in the Chrome and Edge browsers but not in the Firefox browser. So the bug is probably in the browser but only LibreOffice help seems to trigger it. Chrome Version 88.0.4324.190 (Official Build) (64-bit) Edge Version 89.0.774.50 (Official build) (64-bit) Firefox 85.0 (64-bit) I am using the downloaded help. Steps to Reproduce: 1. Open a document 2. Select Help | LibreOffice Help (With Chrome or Edge as the default browser) 3. Actual Results: There is then a delay of 22 seconds, with the progress indicator on the tab going round and round, before the topic list on the left of the help page opens. Expected Results: Help should open instantly, as it does with Firefox. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.4.2 (x64) Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 16; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140982] EDITING Comment range lost in deletions-in-margin mode
https://bugs.documentfoundation.org/show_bug.cgi?id=140982 László Németh changed: What|Removed |Added Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | Status|UNCONFIRMED |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140972] The "Find & Replace..." dialog box opens by default in the expanded version
https://bugs.documentfoundation.org/show_bug.cgi?id=140972 --- Comment #1 from Uwe Auer --- (In reply to tv1700 from comment #0) > In previous versions, this dialog box appeared minimized "Other options" by > default. This was the expected behavior. Last previous version found this to be the case was v6.0.7.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115815] Comment position on deleted track change not preserved
https://bugs.documentfoundation.org/show_bug.cgi?id=115815 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0982 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137770] [META] Tracked changes in margin
https://bugs.documentfoundation.org/show_bug.cgi?id=137770 NISZ LibreOffice Team changed: What|Removed |Added Depends on||140982 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140982 [Bug 140982] EDITING Comment range lost in deletions-in-margin mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140980] EDITING Comment looks deleted when changes in margin mode is activated
https://bugs.documentfoundation.org/show_bug.cgi?id=140980 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0982 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140982] New: EDITING Comment range lost in deletions-in-margin mode
https://bugs.documentfoundation.org/show_bug.cgi?id=140982 Bug ID: 140982 Summary: EDITING Comment range lost in deletions-in-margin mode Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@nisz.hu CC: nem...@numbertext.org Blocks: 137770 Created attachment 170438 --> https://bugs.documentfoundation.org/attachment.cgi?id=170438=edit attachment #139963 after disabling deletions-in-margin mode This is a followup to bug #115815 When a comment is added to a range of deleted text and deletions-in-margin mode is activated and deactivated then the range of the comment is lost and it’s reduced to a point of text. Steps to reproduce: 1. Open attachment #139963 2. Select the deleted word “Bilal” and add a comment on it. 3. In the Track Changes toolbar turn on and off the Deletion on Margins mode Actual results: The comment is not on the deleted word “Bilal” but at the end of it. Expected results: The comment range is retained. LibreOffice details: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2fb274950e5207ca55f4f52325fb522bd44024e1 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=137770 [Bug 137770] [META] Tracked changes in margin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140952] windows10 update 10/3/21
https://bugs.documentfoundation.org/show_bug.cgi?id=140952 --- Comment #7 from Mike Kaganski --- It looks like not related to video (and thus it is unlikely to be solved by forcing Skia software mode), but to some printer. Could you please tell which printer and printer driver you are using? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140950] Blue screen shows as soon as I try to open LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=140950 --- Comment #8 from Mike Kaganski --- See bug 140952 comment 6. In the end, it looks like not related to video (and thus it is unlikely to be solved by forcing Skia software mode), but to some printer. Could you please tell which printer and printer driver you are using? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140981] New: Tools - Automatic Correction doesn't honor removed substitutions
https://bugs.documentfoundation.org/show_bug.cgi?id=140981 Bug ID: 140981 Summary: Tools - Automatic Correction doesn't honor removed substitutions Product: LibreOffice Version: 7.0.4.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nachodelosr...@gmail.com Description: My documents are set to language Spanish (from Spain). When I type "nº " (which means "number", like # in English) it is automatically corrected to "n.º ", which is incorrect (and meaningless). However if I write "nº1" (without the trailing space), it is respected. But it is customary to insert the space, like in addresses "Calle Gran Vía nº 123". If I go to options for automatic corrections I see there is a default entry that changes "nº" for "n.º". Well, that is wrong. But the real issue is: If I remove the entry for the substitution, the behavior doesn't change. I have removed other substitutions, like "exumar" to "exhumar" (which is correct), and the substitution still takes place. I have found that if I *ADD* an entry that substitutes "nº" with "nº", then it works OK. So there's two issues: #1 User-added substitutions are applied, and user-modified substitutions are applied too, but user-removed substitutions are ignored, and the default table is applied. #2 The substitution "nº" for "n.º" in Spanish is wrong (and will drive crazy anybody who doesn't jump through all the hoops I went thru to fix it). Steps to Reproduce: 1. Set document language to Spanish (from Spain) 2. Type "nº 123" 3. You get "n.º 123" 4. Type "nº123" 5. You get "nº123" 6. Select Tools -> Automatic Correction -> Options for Automatic Correction 7. Make sure it is showing substitutions for Spanish (from Spain) 8. Type "nº" in "Replace" box 9. "nº" to "n.º" entry is highlighted 10. Click "remove". The entry disappears. Click "Accept" 11. Type "nº 123". You still get "n.º 123" 12. Select Tools -> Automatic Correction -> Options for Automatic Correction 13. Make sure it is showing substitutions for Spanish (from Spain) 14. Type "nº" in "Replace" box. Type "nº" in "with" box. Click on New. 15. The new entry is highlighted. Click Accept. 16. Type "nº 123". You get "nº 123" If you dont have an "º" key, you can probably see the same behavior in English. 1. Pick any substitution from the autocorrect menu 2. Check that it is applied 3. Remove it from the table 4. See how it is still applied 5. Add it again and change the substitution value 6. See how the new substitution is applied. Actual Results: Removed substitutions are still applied. Expected Results: Removed substitutions are not applied any longer. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: es Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140977] Assert is failed closing Table Properties dialog with table selected
https://bugs.documentfoundation.org/show_bug.cgi?id=140977 Caolán McNamara changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140952] windows10 update 10/3/21
https://bugs.documentfoundation.org/show_bug.cgi?id=140952 --- Comment #6 from Mike Kaganski --- Likely that's https://support.microsoft.com/en-us/topic/march-9-2021-kb5000802-os-builds-19041-867-and-19042-867-63552d64-fe44-4132-8813-ef56d3626e14 which has this entry in "Known issues in this update": > After installing this update, you might receive an APC_INDEX_MISMATCH error > with a blue screen when attempting to print to certain printers in some apps. and this "Workaround": > We are presently investigating and will provide an update when more > information is available. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140952] windows10 update 10/3/21
https://bugs.documentfoundation.org/show_bug.cgi?id=140952 --- Comment #5 from mejames1...@outlook.com --- oops 10th March! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
