Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
Hi August, On 17/11/11 16:52, August Sodora wrote: a minor fix ) So, what I suggest is to mail the patch to me/list and I will test/integrate it ( already I fear some manual merging will be necessary as Everything is pushed to the branch feature/line-numbers-in-basicIDE. I have added a 'Goto Line' menu to the IDE yesterday and it will certainly conflict with your patch. I see Norbert has already integrated that, just some points to remember, for new files don't forget to add a license header ( I added that for linenumberwindow.[ch]xx ) Also, only items that raise dialogs should end with '...' I corrected the string for that.. You can see the changes here - http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd48c0eead825326ce1ee31d043185a79e7fa87f I was looking at this and was wondering if it made sense to factor out the dialog into its own hxx/cxx. I'd very much like to see the whole group of baside*.cxx get turned into something more meaningful where it is easier to find a specific piece of functionality. I'm not a major fan of slavishly imposing a rule of individual [ch]xx files per class, this is especially true for minor ( tiny ) classes used only internally ( as is the case here ) in fact I think probably there was no need for this new dialog to appear in header file, thinking about it, the class could/should have been internalised in the source file where it is used. In general though. hth, thanks again Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On 11/11/11 20:42, Michael Meeks wrote: SvtMiscOptions aMiscOptions; const bool bExperimentalMode = aMiscOptions.IsExperimentalMode(); Should get that for you to switch on; Noel - do you think that's enough ?:-) or do you really want the setting for this so it can be turned off ? My preference is to have a setting so this can be toggled on/off, I think that such a switch should relax the potential requirement of using the 'Experimental' mode. The same switching logic/code needs to be done regardless. Of course if dynamically switching to/from displaying line numbers was causing issues we could additionally show/hide the 'setting' via the 'Experimental' mode ( should only be a handful of lines more to do that ) As mentioned previously I think the simplest way to achieve this is to put a new menu item under 'View' e.g. Display Source Line Numbers ( one of those checkbox entries ) I did also suggest using some sort of button in one of the basic IDE specific toolbars but a menu entry is far simpler. Hope that makes sense. Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On 11/11/11 19:56, Noel Power wrote: On 11/11/11 19:25, August Sodora wrote: [...] Also, is there a consensus on how the option to hide/display line numbers should be added? Currently I'm trying to add a page to the options dialog in cui but I suppose it will really only have one option for now, is that ok? hmm, I'd keep it simple, imo either of the options I mentioned previously On 11/11/11 16:50, Noel Power wrote: Of course I was looking at the stuff in cui for adding an option somewhere, is that the correct place to be looking? Also I'm not sure if the basic ide deserves its own entire category for options yet as I think this is the first configurable thing about the basic ide. I wasn't thinking about anything so grand, mostly I was thinking about maybe either adding a new checkbox under view or perhaps adding a 'toggle linenumbers' button to macro toolbar ( see view|toolbars|macros ) For a first cut/release I wouldn't even worry about persisting that option ok, since let me try and help with this, I am trying to add the menu and some supporting code to tie that in, when I have it done I hope you can take the patch and look at dynamically displaying/undisplaying the linenumbers. Perhaps as a start you could assume the ComplexEditor will be constructed with no line numbers displayed ( e.g. the linenumberwindow should not be shown ) You could add a method void ComplexEditor::SetLineNumberDisplay( bool ) which would show/hide the linenumber windows and do/call whatever resizing magic that needs to happen. How does that sound? Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On 14/11/11 17:17, Noel Power wrote:
ok, since let me try and help with this, I am trying to add the menu
and some supporting code to tie that in, when I have it done I hope
you can take the patch and look at dynamically displaying/undisplaying
the linenumbers. Perhaps as a start you could assume the ComplexEditor
will be constructed with no line numbers displayed ( e.g. the
linenumberwindow should not be shown ) You could add a method void
ComplexEditor::SetLineNumberDisplay( bool ) which would show/hide the
linenumber windows and do/call whatever resizing magic that needs to
happen. How does that sound?
Noel
The attached patch adds the menu item, there is a new method
BasicIDEShell::SourceLinesDisplayed() that you could use in the
ComplexEditor constructor to decide if linenumbers are shown are not (
no need now to assume they are not shown ). There is also some handling
code 'commented out' when the 'View | Display Source Line Numbers ' menu
option is selected. That commented out code will call
ModuleWindow::SetLineNumberDisplay( bool ) You need of course to create
that method and tunnel the call to the
ComplexEditor::SetLineNumberDisplay() method or something similar.
hth,
Noel
p.s. if you manage to get line number to toggle nicely probably there is
no need to put this in the feature branch be we could just commit it.
diff --git basctl/sdi/baside.sdi basctl/sdi/baside.sdi
index f40e239..d297663 100644
--- basctl/sdi/baside.sdi
+++ basctl/sdi/baside.sdi
@@ -39,6 +39,11 @@ shell BasicIDEShell
//
// Current, je nach aktuellem Fenster:
//
+SID_SHOWLINES
+[
+StateMethod = GetState;
+ExecMethod = ExecuteCurrent;
+]
SID_BASICIDE_HIDECURPAGE
[
ExecMethod = ExecuteCurrent;
index 6a5cd13..b8fe0f2 100644
--- basctl/source/basicide/basides1.cxx
+++ basctl/source/basicide/basides1.cxx
@@ -34,6 +34,7 @@
#include basic/sbx.hxx
#define _SVSTDARR_STRINGS
#include svl/svstdarr.hxx
+#include svl/visitem.hxx
#include ide_pch.hxx
#define _SOLAR__PRIVATE 1
@@ -83,6 +84,19 @@ using namespace ::com::sun::star::frame;
class SvxSearchItem;
+// until we have some configuration lets just keep
+// persist this value for the process lifetime
+bool lcl_GetSourceLinesEnabledValue()
+{
+static bool bSourceLinesEnabled(false);
+return bSourceLinesEnabled;
+}
+
+bool BasicIDEShell::SourceLinesDisplayed()
+{
+return lcl_GetSourceLinesEnabledValue();
+}
+
void BasicIDEShell::ExecuteCurrent( SfxRequest rReq )
{
if ( !pCurWin )
@@ -90,6 +104,20 @@ void BasicIDEShell::ExecuteCurrent( SfxRequest rReq )
switch ( rReq.GetSlot() )
{
+case SID_SHOWLINES:
+{
+SFX_REQUEST_ARG(rReq, pItem, SfxBoolItem, rReq.GetSlot(), sal_False);
+bool bValue = false;
+if ( pItem )
+bValue = pItem-GetValue();
+lcl_GetSourceLinesEnabledValue() = bValue;
+if ( pCurWin pCurWin-IsA( TYPE( ModulWindow ) ) )
+{
+//(ModuleWindow*)(pCurWin)-SetLineNumberDisplay( bValue );
+}
+}
+break;
+
case SID_BASICIDE_HIDECURPAGE:
{
pCurWin-StoreData();
@@ -779,6 +807,20 @@ void BasicIDEShell::GetState(SfxItemSet rSet)
{
switch ( nWh )
{
+case SID_SHOWLINES:
+{
+// if this is not a module window hide the
+// setting, doesn't make sense for example if the
+// dialog editor is open
+if( pCurWin !pCurWin-IsA( TYPE( ModulWindow ) ) )
+{
+rSet.DisableItem( nWh );
+rSet.Put(SfxVisibilityItem(nWh, sal_False));
+}
+else
+rSet.Put( SfxBoolItem( nWh, lcl_GetSourceLinesEnabledValue() ) );
+break;
+}
case SID_DOCINFO:
{
rSet.DisableItem( nWh );
diff --git basctl/source/inc/basidesh.hxx basctl/source/inc/basidesh.hxx
index 15fd8f27..9d66a6d 100644
--- basctl/source/inc/basidesh.hxx
+++ basctl/source/inc/basidesh.hxx
@@ -227,6 +227,7 @@ public:
virtual ::com::sun::star::uno::Reference ::com::sun::star::frame::XModel
GetCurrentDocument() const;
+bool SourceLinesDisplayed();
};
diff --git basctl/uiconfig/basicide/menubar/menubar.xml basctl/uiconfig/basicide/menubar/menubar.xml
index 4583ca2..fa99e98 100644
--- basctl/uiconfig/basicide/menubar/menubar.xml
+++ basctl/uiconfig/basicide/menubar/menubar.xml
@@ -48,6 +48,7 @@
menu:menuitem menu:id=.uno:AvailableToolbars/
menu:menuitem menu:id=.uno:StatusBarVisible/
menu:menuitem menu:id=.uno:ShowImeStatusWindow/
+menu:menuitem menu:id=.uno:ShowLines/
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On 10/11/11 03:02, August Sodora wrote: Hello, I've attached a patch that attempts to add line numbers to the basic ide. I believe it is mostly correct, although I am seeing a couple of rendering issues that I haven't been able to track down yet. First, the scrollbar seems to jump around and flicker a lot more than it does without this patch. Second, typing so that the window has to scroll horizontally causes the vertical scrollbar to move to a nonsensical position. If anybody has a moment to take a look at this I would really appreciate it! This has been bugging me for a while. There are a couple problems as you mention with this patch, however I do think that this is *really* useful and certainly something that I would have liked to see at times. However sometimes I think the line numbers can just be annoying ;-) so I think definitely this should be configurable :-) The erratic behaviour of the vertical scrollbar ( note it doesn't respond to clicks ) is I believe due to the fact that you probably don't take into account the reduced size of the editor window ( because now there is the extra width from the window with the line numbers ) and in fact the width of that line-number window is dynamic ( e.g. can change as you are typing when the number of lines increases ). What I suspect is happening is the editor window area extends over where the scrollbar is painted and the 'flicker' and erratic 'positioning' is as a result of the the editor window and scroll bar painting over one another. given the current state would you consider moving this to a feature branch where perhaps others might be able to check it out and collaborate/help ? Although I am not very familiar with vcl and/or ui stuff, I'd be happy to try and help. Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
There are a couple problems as you mention with this patch, however I do think that this is *really* useful land certainly something that I would have liked to see at times. However sometimes I think the line numbers can just be annoying ;-) so I think definitely this should be configurable :-) Of course :-) I was looking at the stuff in cui for adding an option somewhere, is that the correct place to be looking? Also I'm not sure if the basic ide deserves its own entire category for options yet as I think this is the first configurable thing about the basic ide. The erratic behaviour of the vertical scrollbar ( note it doesn't respond to clicks ) is I believe due to the fact that you probably don't take into account the reduced size of the editor window ( because now there is the extra width from the window with the line numbers ) and in fact the width of that line-number window is dynamic ( e.g. can change as you are typing when the number of lines increases ). What I suspect is happening is the editor window area extends over where the scrollbar is painted and the 'flicker' and erratic 'positioning' is as a result of the the editor window and scroll bar painting over one another. This was my first reaction but I couldn't find anything on my first pass through; I'll definitely take a deeper look. given the current state would you consider moving this to a feature branch where perhaps others might be able to check it out and collaborate/help ? Although I am not very familiar with vcl and/or ui stuff, I'd be happy to try and help. I'd love to but I'm not exactly sure how. Currently I have it as a local branch. August Sodora aug...@gmail.com (201) 280-8138 On Fri, Nov 11, 2011 at 11:09 AM, Noel Power nopo...@suse.com wrote: On 10/11/11 03:02, August Sodora wrote: Hello, I've attached a patch that attempts to add line numbers to the basic ide. I believe it is mostly correct, although I am seeing a couple of rendering issues that I haven't been able to track down yet. First, the scrollbar seems to jump around and flicker a lot more than it does without this patch. Second, typing so that the window has to scroll horizontally causes the vertical scrollbar to move to a nonsensical position. If anybody has a moment to take a look at this I would really appreciate it! This has been bugging me for a while. There are a couple problems as you mention with this patch, however I do think that this is *really* useful and certainly something that I would have liked to see at times. However sometimes I think the line numbers can just be annoying ;-) so I think definitely this should be configurable :-) The erratic behaviour of the vertical scrollbar ( note it doesn't respond to clicks ) is I believe due to the fact that you probably don't take into account the reduced size of the editor window ( because now there is the extra width from the window with the line numbers ) and in fact the width of that line-number window is dynamic ( e.g. can change as you are typing when the number of lines increases ). What I suspect is happening is the editor window area extends over where the scrollbar is painted and the 'flicker' and erratic 'positioning' is as a result of the the editor window and scroll bar painting over one another. given the current state would you consider moving this to a feature branch where perhaps others might be able to check it out and collaborate/help ? Although I am not very familiar with vcl and/or ui stuff, I'd be happy to try and help. Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On 11/11/11 16:09, Noel Power wrote: On 10/11/11 03:02, August Sodora wrote: Hello, I've attached a patch that attempts to add line numbers to the basic ide. I believe it is mostly correct, although I am seeing a couple of rendering issues that I haven't been able to track down yet. First, the scrollbar seems to jump around and flicker a lot more than it does without this patch. Second, typing so that the window has to scroll horizontally causes the vertical scrollbar to move to a nonsensical position. If anybody has a moment to take a look at this I would really appreciate it! This has been bugging me for a while. There are a couple problems as you mention with this patch, however I do think that this is *really* useful and certainly something that I would have liked to see at times. However sometimes I think the line numbers can just be annoying ;-) so I think definitely this should be configurable :-) The erratic behaviour of the vertical scrollbar ( note it doesn't respond to clicks ) is I believe due to the fact that you probably don't take into account the reduced size of the editor window ( because now there is the extra width from the window with the line numbers ) and in fact the width of that line-number window is dynamic ( e.g. can change as you are typing when the number of lines increases ). What I suspect is happening is the editor window area extends over where the scrollbar is painted and the 'flicker' and erratic 'positioning' is as a result of the the editor window and scroll bar painting over one another. given the current state would you consider moving this to a feature branch where perhaps others might be able to check it out and collaborate/help ? Although I am not very familiar with vcl and/or ui stuff, I'd be happy to try and help. Noel @@ -1643,11 +1653,14 @@ void ComplexEditorWindow::Resize() long nBrkWidth = 20; long nSBWidth = aEWVScrollBar.GetSizePixel().Width(); -Size aBrkSz( Size( nBrkWidth, aSz.Height() ) ); +Size aBrkSz(nBrkWidth, aSz.Height()); aBrkWindow.SetPosSizePixel( Point( DWBORDER, DWBORDER ), aBrkSz ); -Size aEWSz( Size( aSz.Width() - nBrkWidth - nSBWidth + 2, aSz.Height() ) ); -aEdtWindow.SetPosSizePixel( Point( DWBORDER+aBrkSz.Width()-1, DWBORDER ), aEWSz ); +Size aLnSz(aLineNumberWindow.GetWidth(), aSz.Height()); +aLineNumberWindow.SetPosSizePixel(Point(DWBORDER+aBrkSz.Width() - 1, DWBORDER), aLnSz); + +Size aEWSz(aSz.Width() - nBrkWidth - nSBWidth + 2, aSz.Height()); +aEdtWindow.SetPosSizePixel( Point( DWBORDER+aBrkSz.Width()+aLnSz.Width()-1, DWBORDER ), aEWSz ); aEWVScrollBar.SetPosSizePixel( Point( aOutSz.Width()-DWBORDER-nSBWidth, DWBORDER ), Size( nSBWidth, aSz.Height() ) ); } I think in the hunk above +Size aEWSz(aSz.Width() - nBrkWidth - nSBWidth + 2, aSz.Height()); should be + Size aEWSz(aSz.Width() - nBrkWidth - aLineNumberWindow.GetWidth() - nSBWidth + 2, aSz.Height()); or at least scroll bar seems to work as expected with that :-) thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On 11/11/11 16:30, August Sodora wrote: There are a couple problems as you mention with this patch, however I do think that this is *really* useful land certainly something that I would have liked to see at times. However sometimes I think the line numbers can just be annoying ;-) so I think definitely this should be configurable :-) Of course :-) I was looking at the stuff in cui for adding an option somewhere, is that the correct place to be looking? Also I'm not sure if the basic ide deserves its own entire category for options yet as I think this is the first configurable thing about the basic ide. I wasn't thinking about anything so grand, mostly I was thinking about maybe either adding a new checkbox under view or perhaps adding a 'toggle linenumbers' button to macro toolbar ( see view|toolbars|macros ) For a first cut/release I wouldn't even worry about persisting that option The erratic behaviour of the vertical scrollbar [...] This was my first reaction but I couldn't find anything on my first pass through; I'll definitely take a deeper look. see my previous response, there is a fix there for that given the current state would you consider moving this to a feature branch where perhaps others might be able to check it out and collaborate/help ? Although I am not very familiar with vcl and/or ui stuff, I'd be happy to try and help. I'd love to but I'm not exactly sure how. Currently I have it as a local branch. haha, yes, well not being much of a git guru myself I can't recall offhand what the command are for that, let me try and find out what they are and get back to you. Anyway, no problem with it being a local branch for the moment thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On 11/11/11 16:50, Noel Power wrote: On 11/11/11 16:30, August Sodora wrote: I'd love to but I'm not exactly sure how. Currently I have it as a local branch. haha, yes, well not being much of a git guru myself I can't recall offhand what the command are for that, let me try and find out what they are and get back to you. Anyway, no problem with it being a local branch for the moment thanks, Noel see below for some steps that kendy sent to the list at some stage, note the instructions are based on the old multi-repo setup so I guess one just needs to substitute 'git' for 'g' in the instructions below So the example workflow might look like the following: # create the branch locally g checkout -b mybranch # develop something ... g commit -a ... g commit # find out that it might be useful as a feature branch g -f push origin mybranch:feature/some-comprehensible-name # continue development and pushing ... g commit -a g push # hmm, a conflict, somebody pushed to our # feature/some-comprehensible-name branch, we want to get newest stuff # from there. In this case, we want the 'rebasing' pull. g pull -r g push # at some stage you might find out that you actually want to merge newer # stuff from some other branch, eg. master g merge master # finally you want to get it all back to master g checkout master g merge mybranch g push # if it failed, we need to get the newest stuff from the remote repo # BUT WITHOUT REBASING g pull --no-rebase g push # everything finished, kill the remote branch g -f push origin :feature/some-comphrehensible-name thanks again Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
Ok, I've adjusted the patch to include the fix you provided
(thanks!!). I only have two more stumbling blocks at this point.
First, I don't have a account to commit with; would you mind creating
a branch for this in the meantime? Also, is there a consensus on how
the option to hide/display line numbers should be added? Currently I'm
trying to add a page to the options dialog in cui but I suppose it
will really only have one option for now, is that ok?
August Sodora
aug...@gmail.com
(201) 280-8138
On Fri, Nov 11, 2011 at 12:01 PM, Noel Power nopo...@suse.com wrote:
On 11/11/11 16:50, Noel Power wrote:
On 11/11/11 16:30, August Sodora wrote:
I'd love to but I'm not exactly sure how. Currently I have it as a local
branch.
haha, yes, well not being much of a git guru myself I can't recall offhand
what the command are for that, let me try and find out what they are and get
back to you. Anyway, no problem with it being a local branch for the moment
thanks,
Noel
see below for some steps that kendy sent to the list at some stage, note the
instructions are based on the old multi-repo setup so I guess one just needs
to substitute 'git' for 'g' in the instructions below
So the example workflow might look like the following:
# create the branch locally
g checkout -b mybranch
# develop something
...
g commit -a
...
g commit
# find out that it might be useful as a feature branch
g -f push origin mybranch:feature/some-comprehensible-name
# continue development and pushing
...
g commit -a
g push
# hmm, a conflict, somebody pushed to our
# feature/some-comprehensible-name branch, we want to get newest stuff
# from there. In this case, we want the 'rebasing' pull.
g pull -r
g push
# at some stage you might find out that you actually want to merge newer
# stuff from some other branch, eg. master
g merge master
# finally you want to get it all back to master
g checkout master
g merge mybranch
g push
# if it failed, we need to get the newest stuff from the remote repo
# BUT WITHOUT REBASING
g pull --no-rebase
g push
# everything finished, kill the remote branch
g -f push origin :feature/some-comphrehensible-name
thanks again
Noel
From 2a08f10d45446176e0d8b4b29863650b594f2bd2 Mon Sep 17 00:00:00 2001
From: August Sodora aug...@gmail.com
Date: Fri, 11 Nov 2011 14:22:11 -0500
Subject: [PATCH] Add line numbers to basic ide
---
basctl/Library_basctl.mk|1 +
basctl/source/basicide/baside2.hxx |6 ++
basctl/source/basicide/baside2b.cxx | 29 +
3 files changed, 28 insertions(+), 8 deletions(-)
diff --git a/basctl/Library_basctl.mk b/basctl/Library_basctl.mk
index c806980..b1badf4 100644
--- a/basctl/Library_basctl.mk
+++ b/basctl/Library_basctl.mk
@@ -94,6 +94,7 @@ $(eval $(call gb_Library_add_exception_objects,basctl,\
basctl/source/basicide/docsignature \
basctl/source/basicide/documentenumeration \
basctl/source/basicide/iderdll \
+ basctl/source/basicide/linenumberwindow \
basctl/source/basicide/localizationmgr \
basctl/source/basicide/macrodlg \
basctl/source/basicide/moduldl2 \
diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx
index 6af6c06..1de34d7 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -42,6 +42,7 @@ class SvxSearchItem;
#include svtools/headbar.hxx
#include vcl/button.hxx
+#include basic/sbstar.hxx
#include basic/sbmod.hxx
#include vcl/split.hxx
#include svl/lstner.hxx
@@ -50,6 +51,8 @@ class SvxSearchItem;
#include sfx2/progress.hxx
#include svtools/syntaxhighlight.hxx
+#include linenumberwindow.hxx
+
DBG_NAMEEX( ModulWindow )
#define MARKER_NOMARKER 0x
@@ -284,6 +287,7 @@ class ComplexEditorWindow : public Window
{
private:
BreakPointWindowaBrkWindow;
+LineNumberWindowaLineNumberWindow;
EditorWindowaEdtWindow;
ScrollBar aEWVScrollBar;
@@ -297,6 +301,7 @@ public:
ComplexEditorWindow( ModulWindow* pParent );
BreakPointWindow GetBrkWindow() { return aBrkWindow; }
+LineNumberWindow GetLineNumberWindow() { return aLineNumberWindow; }
EditorWindow GetEdtWindow() { return aEdtWindow; }
ScrollBar GetEWVScrollBar() { return aEWVScrollBar; }
};
@@ -402,6 +407,7 @@ public:
EditorWindow GetEditorWindow() { return aXEditorWindow.GetEdtWindow(); }
BreakPointWindow GetBreakPointWindow() { return aXEditorWindow.GetBrkWindow(); }
+LineNumberWindow GetLineNumberWindow() { return aXEditorWindow.GetLineNumberWindow(); }
ScrollBar GetEditVScrollBar() { return aXEditorWindow.GetEWVScrollBar(); }
ExtTextEngine* GetEditEngine() { return GetEditorWindow().GetEditEngine(); }
ExtTextView*GetEditView() { return GetEditorWindow().GetEditView(); }
diff --git a/basctl/source/basicide/baside2b.cxx
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On 11/11/11 19:25, August Sodora wrote: First, I don't have a account to commit with; you should think about asking for commit access, in the meantime I can add the feature branch for you ( but please remind me next week 'cause probably I will forget between now and then ) Also, is there a consensus on how the option to hide/display line numbers should be added? Currently I'm trying to add a page to the options dialog in cui but I suppose it will really only have one option for now, is that ok? hmm, I'd keep it simple, imo either of the options I mentioned previously On 11/11/11 16:50, Noel Power wrote: Of course I was looking at the stuff in cui for adding an option somewhere, is that the correct place to be looking? Also I'm not sure if the basic ide deserves its own entire category for options yet as I think this is the first configurable thing about the basic ide. I wasn't thinking about anything so grand, mostly I was thinking about maybe either adding a new checkbox under view or perhaps adding a 'toggle linenumbers' button to macro toolbar ( see view|toolbars|macros ) For a first cut/release I wouldn't even worry about persisting that option would probably be simpler, seems like alot of trouble otherwise ( e.g. going down the tools|options|... route ) for just one simple option. In anycase making the behaviour switchable needs to be done regardless, how that option is presented can be solved in a number of ways, I would take the easiest option first, if needs be, how the option is presented can easily be changed later. Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
On Fri, 2011-11-11 at 11:30 -0500, August Sodora wrote: Of course :-) I was looking at the stuff in cui for adding an option somewhere, is that the correct place to be looking? Also I'm not sure if the basic ide deserves its own entire category for options yet as I think this is the first configurable thing about the basic ide. Heh :-) there is a good point here. If the feature is not perfect, but we want it in before the feature freeze, that is fairly easy to do. We just make it available when the 'Experimental' mode is on. SvtMiscOptions aMiscOptions; const bool bExperimentalMode = aMiscOptions.IsExperimentalMode(); Should get that for you to switch on; Noel - do you think that's enough ? :-) or do you really want the setting for this so it can be turned off ? Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
Hey, to make it easier for everyone I pushed it to a feature branch. The new feature branch for this is: feature/line-numbers-in-basicIDE. As soon as you get your commit access by Michael, you can work on this branch without to worry about the master branch too much. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Added line numbers to the basic ide
August Sodora wrote (11-11-11 17:30) Of course :-) I was looking at the stuff in cui for adding an option somewhere, is that the correct place to be looking? Also I'm not sure if the basic ide deserves its own entire category for options yet as I think this is the first configurable thing about the basic ide. In Tools OPtions LibreOffice Fonts there is the possibility to set, of course, the font -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
