[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4807 Wrong glissando slopes with accidental in target chord

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:



--- old
+++ new
@@ -1,3 +1,5 @@
+http://codereview.appspot.com/342100043
+
 As Harm reported, glissando slopes may be wrongly calculated, if there is an 
accidental on the target chord. This worked fine in v2.16.2.
 
 



- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 20th



---

** [issues:#4807] Wrong glissando slopes with accidental in target chord**

**Status:** Started
**Labels:** Regression 
**Created:** Mon Mar 21, 2016 10:59 AM UTC by Simon Albrecht
**Last Updated:** Sat May 12, 2018 02:56 PM UTC
**Owner:** Malte Meyn
**Attachments:**

- 
[4807-2.16-no-bug.png](https://sourceforge.net/p/testlilyissues/issues/4807/attachment/4807-2.16-no-bug.png)
 (4.9 kB; image/png)
- 
[4807-2.18-bug.png](https://sourceforge.net/p/testlilyissues/issues/4807/attachment/4807-2.18-bug.png)
 (5.4 kB; image/png)
- 
[Reg_test_2018-05-12_15-47-11.png](https://sourceforge.net/p/testlilyissues/issues/4807/attachment/Reg_test_2018-05-12_15-47-11.png)
 (37.1 kB; image/png)


http://codereview.appspot.com/342100043

As Harm reported, glissando slopes may be wrongly calculated, if there is an 
accidental on the target chord. This worked fine in v2.16.2.


:::TeX
\version "2.18.2"
%% up to 2.19.39

{ 1\glissando 1 }

%% this one is ok:
{ 1\glissando 1 }



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5318 Context regression tests

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 20th



---

** [issues:#5318] Context regression tests**

**Status:** Started
**Created:** Thu May 03, 2018 02:37 AM UTC by Dan Eble
**Last Updated:** Sun May 13, 2018 12:27 PM UTC
**Owner:** Dan Eble


Context regression tests
Note that context-find-parent.ly currently fails.

http://codereview.appspot.com/348760043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5320 beam.cc: avoid calculating an invalid reference

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Type**: Enhancement --> Crash
- **Comment**:

Pushed to staging as
commit d63756608d265d7a99444af1123b7be8a06f3cc2
Author: David Kastrup 
Date:   Wed May 9 13:48:35 2018 +0200

Issue 5320: beam.cc: avoid calculating an invalid reference

In calc_beam_segments, an invalid reference to a neighboring segment
was calculated (and not used) at the extreme ends of the beam.  This
caused segfaults on Fedora.  Since the reference is used at most twice
anyway and in the same expression, it seems easier to just use the
expression directly (the invalid cases are then skipped due to
short-circuit evaluation).




---

** [issues:#5320] beam.cc: avoid calculating an invalid reference**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Wed May 09, 2018 11:49 AM UTC by David Kastrup
**Last Updated:** Thu May 17, 2018 08:09 AM UTC
**Owner:** David Kastrup


beam.cc: avoid calculating an invalid reference

In calc_beam_segments, an invalid reference to a neighboring segment
was calculated (and not used) at the extreme ends of the beam.  This
caused segfaults on Fedora.  Since the reference is used at most twice
anyway and in the same expression, it seems easier to just use the
expression directly (the invalid cases are then skipped due to
short-circuit evaluation).

http://codereview.appspot.com/343160043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5321 Parser: E_BACKSLASH should be two backslashes

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Type**: Enhancement --> Defect
- **Comment**:

Pushed to staging as
commit aa37e5ad9ab0d5a90c3d2ef0f250683089846f96
Author: David Kastrup 
Date:   Wed May 9 15:36:41 2018 +0200

Issue 5321: Parser: E_BACKSLASH should be two backslashes

Makes for better parser error messages.




---

** [issues:#5321] Parser: E_BACKSLASH should be two backslashes**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Wed May 09, 2018 01:37 PM UTC by David Kastrup
**Last Updated:** Thu May 17, 2018 08:08 AM UTC
**Owner:** David Kastrup


Parser: E_BACKSLASH should be two backslashes

Makes for better parser error messages.

http://codereview.appspot.com/341250043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **summary**: Issue : Generalize the special case of creating a Timing 
context --> Generalize the special case of creating a Timing context
- Description has changed:

Diff:



--- old
+++ new
@@ -1,5 +1,3 @@
-Issue : Generalize the special case of creating a Timing context
-into the general case of creating a context for which there is no
-definition but which is mentioned as an alias.
+Generalize the special case of creating a Timing context into the general case 
of creating a context for which there is no definition but which is mentioned 
as an alias.
 
 http://codereview.appspot.com/344910043



- **Needs**:  -->  



---

** [issues:#5326] Generalize the special case of creating a Timing context**

**Status:** Started
**Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble
**Last Updated:** Mon May 21, 2018 12:39 PM UTC
**Owner:** Dan Eble


Generalize the special case of creating a Timing context into the general case 
of creating a context for which there is no definition but which is mentioned 
as an alias.

http://codereview.appspot.com/344910043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Issue XXXX: Generalize the special case of creating a Timing context

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5326] Issue : Generalize the special case of creating a Timing 
context**

**Status:** Started
**Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble
**Last Updated:** Mon May 21, 2018 12:39 PM UTC
**Owner:** nobody


Issue : Generalize the special case of creating a Timing context
into the general case of creating a context for which there is no
definition but which is mentioned as an alias.

http://codereview.appspot.com/344910043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5326] Generalize the special case of creating a Timing context**

**Status:** Started
**Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble
**Last Updated:** Mon May 21, 2018 12:42 PM UTC
**Owner:** Dan Eble


Generalize the special case of creating a Timing context into the general case 
of creating a context for which there is no definition but which is mentioned 
as an alias.

http://codereview.appspot.com/344910043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5327 Allow Scheme/identifiers for duration multipliers

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

No good dead goes unpunished.  Documentation and harmonization.

http://codereview.appspot.com/346810043


---

** [issues:#5327] Allow Scheme/identifiers for duration multipliers**

**Status:** Started
**Created:** Tue May 22, 2018 08:46 PM UTC by David Kastrup
**Last Updated:** Wed May 23, 2018 09:59 PM UTC
**Owner:** David Kastrup


Allow Scheme/identifiers for duration multipliers


Also contains commit:

Regtest for computed duration multipliers

http://codereview.appspot.com/346810043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5326] Generalize the special case of creating a Timing context**

**Status:** Started
**Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble
**Last Updated:** Tue May 22, 2018 12:15 PM UTC
**Owner:** Dan Eble


Generalize the special case of creating a Timing context into the general case 
of creating a context for which there is no definition but which is mentioned 
as an alias.

http://codereview.appspot.com/344910043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

The questions on this still have not been resolved so am leaving this on 
review. @Bernhard can you look at the Rietveld comments please?


---

** [issues:#5323] sort input files**

**Status:** Started
**Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann
**Last Updated:** Sun May 20, 2018 09:40 PM UTC
**Owner:** Bernhard M. Wiedemann


sort input files

to have reproducible link order
so that the lilypond binary always contains its functions in the same order.

When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would differ.

See https://reproducible-builds.org/ for why this matters.

http://codereview.appspot.com/347770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

That was fast.  I am somewhat sqeamish about the approach but don't see an 
obvious problem with it.  Not requiring a special case for the Timing/Score 
pairing is good, of course.  So my choice would have been to go with it and see 
whether or not that buys us problems.  I just failed to timely state this, but 
no harm done.


---

** [issues:#5326] Generalize the special case of creating a Timing context**

**Status:** Started
**Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble
**Last Updated:** Wed May 23, 2018 11:19 AM UTC
**Owner:** Dan Eble


Generalize the special case of creating a Timing context into the general case 
of creating a context for which there is no definition but which is mentioned 
as an alias.

http://codereview.appspot.com/344910043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

sorting .o files instead of .cc

http://codereview.appspot.com/347770043


---

** [issues:#5323] sort input files**

**Status:** Started
**Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann
**Last Updated:** Wed May 23, 2018 12:28 PM UTC
**Owner:** Bernhard M. Wiedemann


sort input files

to have reproducible link order
so that the lilypond binary always contains its functions in the same order.

When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would differ.

See https://reproducible-builds.org/ for why this matters.

http://codereview.appspot.com/347770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5328 mf2pt1 uses random uniqueID

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5328] mf2pt1 uses random uniqueID**

**Status:** New
**Labels:** reproducible 
**Created:** Wed May 23, 2018 02:13 PM UTC by Bernhard M. Wiedemann
**Last Updated:** Wed May 23, 2018 02:13 PM UTC
**Owner:** nobody
**Attachments:**

- 
[reproducible.patch](https://sourceforge.net/p/testlilyissues/issues/5328/attachment/reproducible.patch)
 (1.4 kB; text/x-patch)


`scripts/build/mf2pt1.pl` calls `int(rand(100)) + 400`
so with every (clean) build, a new uniqueID value gets generated, which 
prevents lilypond packages from building reproducibly.
See also https://reproducible-builds.org/ for why this matters.

One pretty clean solution would be to calculate a hash of all relevant inputs 
and use that for uniqueID.

Since I dont know what the inputs are there, for now I only did a dummy patch 
that hashed the filename...


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5326 Generalize the special case of creating a Timing context

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

Pushed to staging:

commit 648ac00067d409792605113c46639326aed27547 (HEAD -> 
pushed/issue-5326-context-create-timing, origin/staging)
Author: Dan Eble 
Date:   Mon May 21 07:39:18 2018 -0400

Issue 5326: Generalize the special case of creating a Timing context
into the general case of creating a context for which there is no
definition but which is mentioned as an alias.




---

** [issues:#5326] Generalize the special case of creating a Timing context**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Mon May 21, 2018 12:39 PM UTC by Dan Eble
**Last Updated:** Wed May 23, 2018 11:26 AM UTC
**Owner:** Dan Eble


Generalize the special case of creating a Timing context into the general case 
of creating a context for which there is no definition but which is mentioned 
as an alias.

http://codereview.appspot.com/344910043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5327 Allow Scheme/identifiers for duration multipliers

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  --> Enhancement
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5327] Allow Scheme/identifiers for duration multipliers**

**Status:** Started
**Created:** Tue May 22, 2018 08:46 PM UTC by David Kastrup
**Last Updated:** Wed May 23, 2018 09:59 PM UTC
**Owner:** David Kastrup


Allow Scheme/identifiers for duration multipliers


Also contains commit:

Regtest for computed duration multipliers

http://codereview.appspot.com/346810043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5327 Allow Scheme/identifiers for duration multipliers

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5327] Allow Scheme/identifiers for duration multipliers**

**Status:** Started
**Created:** Tue May 22, 2018 08:46 PM UTC by David Kastrup
**Last Updated:** Tue May 22, 2018 08:46 PM UTC
**Owner:** nobody


Allow Scheme/identifiers for duration multipliers


Also contains commit:

Regtest for computed duration multipliers

http://codereview.appspot.com/346810043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5329 Improve make-bracket-bar-line

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

No, the problem arised only, if ]-bar was forced to have a thick span-bar, thus 
the test-case above.
We don't have a regtest for this combination. And I think it would be too much 
to cover every possible combination of bar-lines/span-bars.
But that's only me ...


---

** [issues:#5329] Improve make-bracket-bar-line**

**Status:** Started
**Created:** Thu May 24, 2018 09:08 PM UTC by Thomas Morley
**Last Updated:** Fri May 25, 2018 04:06 PM UTC
**Owner:** Thomas Morley


Improve make-bracket-bar-line

The previously used ly:stencil-scale -1 1 resulted in wrongly positioned
SpanBars in certain cases.
Replaces ly:stencil-scale by flip-stencil.

http://codereview.appspot.com/339670043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5329 Improve make-bracket-bar-line

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 29th.



---

** [issues:#5329] Improve make-bracket-bar-line**

**Status:** Started
**Created:** Thu May 24, 2018 09:08 PM UTC by Thomas Morley
**Last Updated:** Fri May 25, 2018 04:54 PM UTC
**Owner:** Thomas Morley


Improve make-bracket-bar-line

The previously used ly:stencil-scale -1 1 resulted in wrongly positioned
SpanBars in certain cases.
Replaces ly:stencil-scale by flip-stencil.

http://codereview.appspot.com/339670043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 29th.



---

** [issues:#5323] sort input files**

**Status:** Started
**Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann
**Last Updated:** Thu May 24, 2018 12:07 PM UTC
**Owner:** Bernhard M. Wiedemann


sort input files

to have reproducible link order
so that the lilypond binary always contains its functions in the same order.

When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would differ.

See https://reproducible-builds.org/ for why this matters.

http://codereview.appspot.com/347770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5330 Allow use of Identity-H CMap and CID versions of Emmentaler

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5330] Allow use of Identity-H CMap and CID versions of Emmentaler**

**Status:** New
**Created:** Sat May 26, 2018 12:54 PM UTC by Knut Petersen
**Last Updated:** Sat May 26, 2018 12:54 PM UTC
**Owner:** Knut Petersen
**Attachments:**

- 
[0001-Allow-use-of-Identity-H-CMap-and-CID-versions-of-Emm.patch](https://sourceforge.net/p/testlilyissues/issues/5330/attachment/0001-Allow-use-of-Identity-H-CMap-and-CID-versions-of-Emm.patch)
 (121.8 kB; text/x-patch)


I think we should remove the use of three encodings/subsets of emmentaler fonts 
from our postscript code and use CID versions of the emmentaler fonts combined 
with the Identity-H CMap instead.

Attached is a patch that implements (and uses) this enhancement:

* When -O TeX or -O TeX-GS is given, lilypond generates postscript code that 
instructs ghostscript to use the Identity-H CMap and CID versions of the 
emmentaler fonts. 
* Without '-O TeX' or '-O TeX-GS' we still use the traditional postscript code.
* Documentation is still missing.

Only a proof of concept, not ready for release, definitely not for lilypond 
2.20.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5330 Allow use of Identity-H CMap and CID versions of Emmentaler

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Allow use of Identity-H CMap and CID versions of Emmentaler

When -O TeX or -O TeX-GS is given, lilypond generates
postscript code that instructs ghostscript to use the
Identity-H CMap and CID versions of the emmentaler
fonts. Used e.g. by 'make doc'.

Without '-O TeX' or '-O TeX-GS' we still use the
traditional postscript code.

Documentation is missing.

Only a proof of concept, definitely not ready for
release.

Tested only with current lilypond and ghostscript master.

Signed-off-by: Knut Petersen 

http://codereview.appspot.com/343970043


---

** [issues:#5330] Allow use of Identity-H CMap and CID versions of Emmentaler**

**Status:** Started
**Created:** Sat May 26, 2018 12:54 PM UTC by Knut Petersen
**Last Updated:** Sat May 26, 2018 01:18 PM UTC
**Owner:** Knut Petersen
**Attachments:**

- 
[0001-Allow-use-of-Identity-H-CMap-and-CID-versions-of-Emm.patch](https://sourceforge.net/p/testlilyissues/issues/5330/attachment/0001-Allow-use-of-Identity-H-CMap-and-CID-versions-of-Emm.patch)
 (121.8 kB; text/x-patch)


I think we should remove the use of three encodings/subsets of emmentaler fonts 
from our postscript code and use CID versions of the emmentaler fonts combined 
with the Identity-H CMap instead.

Attached is a patch that implements (and uses) this enhancement:

* When -O TeX or -O TeX-GS is given, lilypond generates postscript code that 
instructs ghostscript to use the Identity-H CMap and CID versions of the 
emmentaler fonts. 
* Without '-O TeX' or '-O TeX-GS' we still use the traditional postscript code.
* Documentation is still missing.

Only a proof of concept, not ready for release, definitely not for lilypond 
2.20.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5330 Allow use of Identity-H CMap and CID versions of Emmentaler

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Any notion of what problems this might alleviate?  Is there a conceivable 
rationale for "Without '-O TeX' or '-O TeX-GS' we still use the traditional 
postscript code." apart from being cautious by default?  Without a tangible 
reason, it might make stuff more predictable by not differentiating in minor 
details.  It might also be possible  to provide a separate option that can then 
be used independent of the -O setting for special needs.

But in general, without a good reason otherwise it would seem to cause less 
trouble by making such changes completely.  Can you think of a good reason 
otherwise?


---

** [issues:#5330] Allow use of Identity-H CMap and CID versions of Emmentaler**

**Status:** Started
**Created:** Sat May 26, 2018 12:54 PM UTC by Knut Petersen
**Last Updated:** Sat May 26, 2018 01:18 PM UTC
**Owner:** Knut Petersen
**Attachments:**

- 
[0001-Allow-use-of-Identity-H-CMap-and-CID-versions-of-Emm.patch](https://sourceforge.net/p/testlilyissues/issues/5330/attachment/0001-Allow-use-of-Identity-H-CMap-and-CID-versions-of-Emm.patch)
 (121.8 kB; text/x-patch)


I think we should remove the use of three encodings/subsets of emmentaler fonts 
from our postscript code and use CID versions of the emmentaler fonts combined 
with the Identity-H CMap instead.

Attached is a patch that implements (and uses) this enhancement:

* When -O TeX or -O TeX-GS is given, lilypond generates postscript code that 
instructs ghostscript to use the Identity-H CMap and CID versions of the 
emmentaler fonts. 
* Without '-O TeX' or '-O TeX-GS' we still use the traditional postscript code.
* Documentation is still missing.

Only a proof of concept, not ready for release, definitely not for lilypond 
2.20.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  --> Enhancement
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5323] sort input files**

**Status:** Started
**Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann
**Last Updated:** Wed May 23, 2018 12:28 PM UTC
**Owner:** Bernhard M. Wiedemann


sort input files

to have reproducible link order
so that the lilypond binary always contains its functions in the same order.

When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would differ.

See https://reproducible-builds.org/ for why this matters.

http://codereview.appspot.com/347770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5329 Improve make-bracket-bar-line

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5329] Improve make-bracket-bar-line**

**Status:** Started
**Created:** Thu May 24, 2018 09:08 PM UTC by Thomas Morley
**Last Updated:** Thu May 24, 2018 09:08 PM UTC
**Owner:** nobody


Improve make-bracket-bar-line

The previously used ly:stencil-scale -1 1 resulted in wrongly positioned
SpanBars in certain cases.
Replaces ly:stencil-scale by flip-stencil.

http://codereview.appspot.com/339670043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5329 Improve make-bracket-bar-line

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

A test-case:

~~~
\version "2.19.81"

\defineBarLine "]" #'("]" "" ".")

\new StaffGroup <<
  \new Staff { R1 \bar "]" }
  \new Staff { R1 }
  >>
~~~

current 2.19.81-output attached


Attachments:

- 
[wrong-span-bar.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/aefe9323/009e/attachment/wrong-span-bar.png)
 (5.5 kB; image/png)


---

** [issues:#5329] Improve make-bracket-bar-line**

**Status:** Started
**Created:** Thu May 24, 2018 09:08 PM UTC by Thomas Morley
**Last Updated:** Thu May 24, 2018 09:08 PM UTC
**Owner:** Thomas Morley


Improve make-bracket-bar-line

The previously used ly:stencil-scale -1 1 resulted in wrongly positioned
SpanBars in certain cases.
Replaces ly:stencil-scale by flip-stencil.

http://codereview.appspot.com/339670043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5323] sort input files**

**Status:** Started
**Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann
**Last Updated:** Fri May 18, 2018 01:03 PM UTC
**Owner:** nobody


sort input files

to have reproducible link order
so that the lilypond binary always contains its functions in the same order.

When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would differ.

See https://reproducible-builds.org/ for why this matters.

http://codereview.appspot.com/347770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4807 Wrong glissando slopes with accidental in target chord

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**: Regression --> Regression, Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

commit 4d958aa0ac05f7bc4c1b294e8697274a015d38fb
Author: Malte Meyn 
Date:   Sat May 12 10:53:45 2018 +0200

Issue 4807/2: add chord glissandi to regtest

commit 13e34233a0bb42a481da1471f4e4acbb62ab5cff
Author: Malte Meyn 
Date:   Wed May 9 15:49:09 2018 +0200

Issue 4807/1: fix glissando in case of accidentals

This reverts b47350d1 as both issue 40 and 4807 are solved then.



---

** [issues:#4807] Wrong glissando slopes with accidental in target chord**

**Status:** Fixed
**Labels:** Regression Fixed_2_21_0 
**Created:** Mon Mar 21, 2016 10:59 AM UTC by Simon Albrecht
**Last Updated:** Sun May 20, 2018 09:39 PM UTC
**Owner:** Malte Meyn
**Attachments:**

- 
[4807-2.16-no-bug.png](https://sourceforge.net/p/testlilyissues/issues/4807/attachment/4807-2.16-no-bug.png)
 (4.9 kB; image/png)
- 
[4807-2.18-bug.png](https://sourceforge.net/p/testlilyissues/issues/4807/attachment/4807-2.18-bug.png)
 (5.4 kB; image/png)
- 
[Reg_test_2018-05-12_15-47-11.png](https://sourceforge.net/p/testlilyissues/issues/4807/attachment/Reg_test_2018-05-12_15-47-11.png)
 (37.1 kB; image/png)


http://codereview.appspot.com/342100043

As Harm reported, glissando slopes may be wrongly calculated, if there is an 
accidental on the target chord. This worked fine in v2.16.2.


:::TeX
\version "2.18.2"
%% up to 2.19.39

{ 1\glissando 1 }

%% this one is ok:
{ 1\glissando 1 }



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5340] Simplify Spacing_spanner::get_columns**

**Status:** Started
**Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble
**Last Updated:** Mon Jun 11, 2018 11:02 AM UTC
**Owner:** nobody


Simplify Spacing_spanner::get_columns

The old algorithm filtered the system's list of columns into a list of
used columns, then searched the filtered list for the endpoints of the
range to return.

The search key was the "rank" of a column, which is its index in the
unfiltered list of columns (see System::add_column).  There is
therefore no need to search.

The new algorithm selects the desired range in the unfiltered list and
then filters that.

This commit also removes the unused function Paper_column::compare.

http://codereview.appspot.com/348940044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5341 Urgent corrections to stencil-integral.cc (skylines)

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5341] Urgent corrections to stencil-integral.cc (skylines)**

**Status:** Started
**Created:** Mon Jun 11, 2018 04:19 PM UTC by Torsten Hämmerle
**Last Updated:** Mon Jun 11, 2018 04:19 PM UTC
**Owner:** Torsten Hämmerle


Garbage collection issue spotted by DAK:
http://lilypond.1069038.n5.nabble.com/Re-issue-5319-Make-skylines-reflect-grob-rotation-issue-342060043-by-torsten-haemmerle-web-de-tt213726.html#none

Two other (minor) changes regarding unnecessary lines being drawn and replacing 
a 
i < n + 1 
by
i <= n


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5336 Expose hidden dynamic_casts in Grob_array and Grob_info

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push.



---

** [issues:#5336] Expose hidden dynamic_casts in Grob_array and Grob_info**

**Status:** Started
**Created:** Tue Jun 05, 2018 03:03 AM UTC by Dan Eble
**Last Updated:** Thu Jun 07, 2018 03:47 PM UTC
**Owner:** Dan Eble


There are methods of `Grob_array` and `Grob_info` which are basically dynamic 
casts with the added cost of a function call.

~~~
Item *
Grob_array::item (vsize i)
{
  return dynamic_cast (grobs_.at (i));
}
~~~

Making this operation more convenient to type is a rather perverse incentive.  
These methods should probably be abolished.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push. Alex if you do not have commit access can you 
attach a git-formatted patch (based against current master) and I can push it 
for you.



---

** [issues:#5333] musicxml2ly: hidden timesigs and tempo marks with text.**

**Status:** Started
**Created:** Fri Jun 01, 2018 11:49 AM UTC by Alex Myltsev
**Last Updated:** Thu Jun 07, 2018 03:47 PM UTC
**Owner:** Alex Myltsev


musicxml2ly: hidden timesigs and tempo marks with text.

http://codereview.appspot.com/34443


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

The patch is ok. It eliminates an obvious and easily exploitable security 
problem.



---

** [issues:#5334] Use system* instead of system when invoking browser**

**Status:** Started
**Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h
**Last Updated:** Sun Jun 10, 2018 03:24 PM UTC
**Owner:** pkx166h
**Attachments:**

- 
[0001-use-system-instead-of-system.patch](https://sourceforge.net/p/testlilyissues/issues/5334/attachment/0001-use-system-instead-of-system.patch)
 (1.3 kB; text/x-patch)


 Don Armstrong - 2018-05-11

I have just uploaded a fix to Debian which switches to using system* instead of 
system:
https://salsa.debian.org/debian/lilypond/commit/788b56e4b7f62637481af65b4b2929649c30fe78

Not sure if this is cross-platform enough, but it solves the issue for systems 
with a working system* call.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5335 Use covariant return types on virtual Grob::clone()

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

commit 23534338bce94508ddbfbbbd4a746619eb403fd5 (HEAD -> 
pushed/issue-5335-grob-clone-covariance, origin/staging)
Author: Dan Eble 
Date:   Sun Jun 3 19:23:14 2018 -0400

Issue 5335/2: Remove other unnecessary dynamic_casts
unrelated to the previous commit

commit 2164bfe5d73b9a660627f43c001ea69453680d68
Author: Dan Eble 
Date:   Sun Jun 3 18:30:17 2018 -0400

Issue 5335/1: Use covariant return types on virtual Grob::clone()
and remove unnecessary dynamic_casts.




---

** [issues:#5335] Use covariant return types on virtual Grob::clone()**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Mon Jun 04, 2018 12:35 AM UTC by Dan Eble
**Last Updated:** Sun Jun 10, 2018 03:14 PM UTC
**Owner:** Dan Eble


Use covariant return types on virtual Grob::clone()

... and remove unnecessary dynamic_casts.

The casts in the parser were not Grob-related, but since they turned
up during my search, I removed them too.

http://codereview.appspot.com/341320043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5336 Expose hidden dynamic_casts in Grob_array and Grob_info

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

commit aec018d7d4ed58e6d67e4621019a6cf2936b212f (HEAD -> 
pushed/issue-5336-grob-array-downcasting, origin/staging)
Author: Dan Eble 
Date:   Mon Jun 4 17:51:24 2018 -0400

Issue 5336: Remove downcasting methods from Grob_array and Grob_info

Presenting dynamic casts as simple getters was hiding something that
is better left in the open.




---

** [issues:#5336] Expose hidden dynamic_casts in Grob_array and Grob_info**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Tue Jun 05, 2018 03:03 AM UTC by Dan Eble
**Last Updated:** Sun Jun 10, 2018 03:16 PM UTC
**Owner:** Dan Eble


There are methods of `Grob_array` and `Grob_info` which are basically dynamic 
casts with the added cost of a function call.

~~~
Item *
Grob_array::item (vsize i)
{
  return dynamic_cast (grobs_.at (i));
}
~~~

Making this operation more convenient to type is a rather perverse incentive.  
These methods should probably be abolished.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: new --> review



---

** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs**

**Status:** Started
**Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen
**Last Updated:** Sun Jun 10, 2018 01:02 PM UTC
**Owner:** Knut Petersen


Fix out-of-sync LilyScriptEncoding / ps script defs

Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
encodingdefs.ps.

This patch will pass 'make test-baseline/check', but visually the reg 
testdifferences that do occur are wrong.

I did not care about the 80-characters per line limit,
it is easier to maintain this format.

The glyphs are now included in the order in which they
are included in the emmentaler fonts. The order of the
glyphs does not matter as long as the encoding vector
and the corresponding commands match.

The change occured because I decided to use otfinfo
and sed to generate the new code, it seemed easier,
safer and faster than correcting the old code by hand.

Signed-off-by: Knut Petersen 

http://codereview.appspot.com/347870043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Passes make, make check and a full make doc.

Reg test diff attached


Attachments:

- 
[5338_regtestdiff.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/39a197cb/73ff/attachment/5338_regtestdiff.png)
 (49.4 kB; image/png)


---

** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs**

**Status:** Started
**Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen
**Last Updated:** Sun Jun 10, 2018 12:26 PM UTC
**Owner:** Knut Petersen


Fix out-of-sync LilyScriptEncoding / ps script defs

Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
encodingdefs.ps.

This patch will pass 'make test-baseline/check', but visually the reg 
testdifferences that do occur are wrong.

I did not care about the 80-characters per line limit,
it is easier to maintain this format.

The glyphs are now included in the order in which they
are included in the emmentaler fonts. The order of the
glyphs does not matter as long as the encoding vector
and the corresponding commands match.

The change occured because I decided to use otfinfo
and sed to generate the new code, it seemed easier,
safer and faster than correcting the old code by hand.

Signed-off-by: Knut Petersen 

http://codereview.appspot.com/347870043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5335 Use covariant return types on virtual Grob::clone()

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push.



---

** [issues:#5335] Use covariant return types on virtual Grob::clone()**

**Status:** Started
**Created:** Mon Jun 04, 2018 12:35 AM UTC by Dan Eble
**Last Updated:** Thu Jun 07, 2018 03:47 PM UTC
**Owner:** Dan Eble


Use covariant return types on virtual Grob::clone()

... and remove unnecessary dynamic_casts.

The casts in the parser were not Grob-related, but since they turned
up during my search, I removed them too.

http://codereview.appspot.com/341320043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for June 13th.



---

** [issues:#5337] Create Bottom contexts in a more general way**

**Status:** Started
**Created:** Tue Jun 05, 2018 04:59 PM UTC by Dan Eble
**Last Updated:** Thu Jun 07, 2018 04:36 PM UTC
**Owner:** Dan Eble


Create Bottom contexts in a more general way

Moving special treatment of "Bottom" into path_to_acceptable_context
() makes it effective during calls to create_unique_context (), which
is the basis of \new and (now) get_default_interpreter ().

http://codereview.appspot.com/339710043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5340] Simplify Spacing_spanner::get_columns**

**Status:** Started
**Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble
**Last Updated:** Mon Jun 11, 2018 11:02 AM UTC
**Owner:** Dan Eble


Simplify Spacing_spanner::get_columns

The old algorithm filtered the system's list of columns into a list of
used columns, then searched the filtered list for the endpoints of the
range to return.

The search key was the "rank" of a column, which is its index in the
unfiltered list of columns (see System::add_column).  There is
therefore no need to search.

The new algorithm selects the desired range in the unfiltered list and
then filters that.

This commit also removes the unused function Paper_column::compare.

http://codereview.appspot.com/348940044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:



--- old
+++ new
@@ -3,8 +3,7 @@
 Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
 encodingdefs.ps.
 
-This patch will not pass 'make check', but this is ok
-as the current state is wrong.
+This patch will pass 'make test-baseline/check', but visually the reg 
testdifferences that do occur are wrong.
 
 I did not care about the 80-characters per line limit,
 it is easier to maintain this format.



- **Needs**:  -->  



---

** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs**

**Status:** Started
**Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen
**Last Updated:** Fri Jun 08, 2018 09:49 AM UTC
**Owner:** Knut Petersen


Fix out-of-sync LilyScriptEncoding / ps script defs

Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
encodingdefs.ps.

This patch will pass 'make test-baseline/check', but visually the reg 
testdifferences that do occur are wrong.

I did not care about the 80-characters per line limit,
it is easier to maintain this format.

The glyphs are now included in the order in which they
are included in the emmentaler fonts. The order of the
glyphs does not matter as long as the encoding vector
and the corresponding commands match.

The change occured because I decided to use otfinfo
and sed to generate the new code, it seemed easier,
safer and faster than correcting the old code by hand.

Signed-off-by: Knut Petersen 

http://codereview.appspot.com/347870043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: needs_work --> new



---

** [issues:#5334] Use system* instead of system when invoking browser**

**Status:** Started
**Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h
**Last Updated:** Sun Jun 10, 2018 03:20 PM UTC
**Owner:** pkx166h
**Attachments:**

- 
[0001-use-system-instead-of-system.patch](https://sourceforge.net/p/testlilyissues/issues/5334/attachment/0001-use-system-instead-of-system.patch)
 (1.3 kB; text/x-patch)


 Don Armstrong - 2018-05-11

I have just uploaded a fix to Debian which switches to using system* instead of 
system:
https://salsa.debian.org/debian/lilypond/commit/788b56e4b7f62637481af65b4b2929649c30fe78

Not sure if this is cross-platform enough, but it solves the issue for systems 
with a working system* call.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs**

**Status:** Started
**Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen
**Last Updated:** Fri Jun 08, 2018 09:49 AM UTC
**Owner:** nobody


Fix out-of-sync LilyScriptEncoding / ps script defs

Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
encodingdefs.ps.

This patch will not pass 'make check', but this is ok
as the current state is wrong.

I did not care about the 80-characters per line limit,
it is easier to maintain this format.

The glyphs are now included in the order in which they
are included in the emmentaler fonts. The order of the
glyphs does not matter as long as the encoding vector
and the corresponding commands match.

The change occured because I decided to use otfinfo
and sed to generate the new code, it seemed easier,
safer and faster than correcting the old code by hand.

Signed-off-by: Knut Petersen 

http://codereview.appspot.com/347870043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for June 10th



---

** [issues:#5333] musicxml2ly: hidden timesigs and tempo marks with text.**

**Status:** Started
**Created:** Fri Jun 01, 2018 11:49 AM UTC by Alex Myltsev
**Last Updated:** Tue Jun 05, 2018 05:11 AM UTC
**Owner:** Alex Myltsev


musicxml2ly: hidden timesigs and tempo marks with text.

http://codereview.appspot.com/34443


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5335 Use covariant return types on virtual Grob::clone()

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for June 10th



---

** [issues:#5335] Use covariant return types on virtual Grob::clone()**

**Status:** Started
**Created:** Mon Jun 04, 2018 12:35 AM UTC by Dan Eble
**Last Updated:** Tue Jun 05, 2018 05:45 AM UTC
**Owner:** Dan Eble


Use covariant return types on virtual Grob::clone()

... and remove unnecessary dynamic_casts.

The casts in the parser were not Grob-related, but since they turned
up during my search, I removed them too.

http://codereview.appspot.com/341320043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and and a full make doc.



---

** [issues:#5337] Create Bottom contexts in a more general way**

**Status:** Started
**Created:** Tue Jun 05, 2018 04:59 PM UTC by Dan Eble
**Last Updated:** Tue Jun 05, 2018 04:59 PM UTC
**Owner:** Dan Eble


Create Bottom contexts in a more general way

Moving special treatment of "Bottom" into path_to_acceptable_context
() makes it effective during calls to create_unique_context (), which
is the basis of \new and (now) get_default_interpreter ().

http://codereview.appspot.com/339710043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5336 Expose hidden dynamic_casts in Grob_array and Grob_info

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for June 10th



---

** [issues:#5336] Expose hidden dynamic_casts in Grob_array and Grob_info**

**Status:** Started
**Created:** Tue Jun 05, 2018 03:03 AM UTC by Dan Eble
**Last Updated:** Tue Jun 05, 2018 06:33 AM UTC
**Owner:** Dan Eble


There are methods of `Grob_array` and `Grob_info` which are basically dynamic 
casts with the added cost of a function call.

~~~
Item *
Grob_array::item (vsize i)
{
  return dynamic_cast (grobs_.at (i));
}
~~~

Making this operation more convenient to type is a rather perverse incentive.  
These methods should probably be abolished.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5323 sort input files

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: countdown --> review
- **Comment**:

Setting down to review - no update about the Rietveld comment - I have posted a 
note there too. If tihs still has no decision by next countdown I will set this 
patch to needs_work.



---

** [issues:#5323] sort input files**

**Status:** Started
**Created:** Fri May 18, 2018 01:03 PM UTC by Bernhard M. Wiedemann
**Last Updated:** Tue Jun 05, 2018 06:45 AM UTC
**Owner:** Bernhard M. Wiedemann


sort input files

to have reproducible link order
so that the lilypond binary always contains its functions in the same order.

When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would differ.

See https://reproducible-builds.org/ for why this matters.

http://codereview.appspot.com/347770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5347 Add and use a Transform data type

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5347] Add and use a Transform data type**

**Status:** Started
**Created:** Sat Jun 16, 2018 09:03 AM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 09:03 AM UTC
**Owner:** David Kastrup


Add and use a Transform data type

As of now, this is just used in stencil-integral.  However, a Scheme
level interface would likely make sense for compacting geometric
transformations.  The abstraction currently relies on PangoTransform
matrices but could easily be moved to other implementations such as
cairo_matrix_t.


Contains commits:

Add Transform data type


stencil-integral.cc: use Transform


stencil-integral: pass SCM as transform values

http://codereview.appspot.com/344970043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Sorry for reporting so late, but there's a problem with the rotation centre, 
see attached image:


Attachments:

- 
[issue-5346-skyline-rot.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/6083b388/f57c/attachment/issue-5346-skyline-rot.png)
 (65.1 kB; image/png)


---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 08:53 AM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5341 Urgent corrections to stencil-integral.cc (skylines)

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for June 19th.



---

** [issues:#5341] Urgent corrections to stencil-integral.cc (skylines)**

**Status:** Started
**Created:** Mon Jun 11, 2018 04:19 PM UTC by Torsten Hämmerle
**Last Updated:** Wed Jun 13, 2018 08:52 AM UTC
**Owner:** Torsten Hämmerle
**Attachments:**

- [Reg_test_2018-06-13 
09-41-41.png](https://sourceforge.net/p/testlilyissues/issues/5341/attachment/Reg_test_2018-06-13%2009-41-41.png)
 (20.8 kB; image/png)


Garbage collection issue spotted by DAK:
http://lilypond.1069038.n5.nabble.com/Re-issue-5319-Make-skylines-reflect-grob-rotation-issue-342060043-by-torsten-haemmerle-web-de-tt213726.html#none

Two other (minor) changes regarding unnecessary lines being drawn and replacing 
a 
i < n + 1 
by
i <= n


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5342 lilypond-invoke-editor only should only handle textedit URIs

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **status**: Started --> Invalid
- **assigned_to**: Knut Petersen --> pkx166h
- **Comment**:

It b was a mistake (by me) to have created this - see 
https://sourceforge.net/p/testlilyissues/issues/5334/

Setting invalid.



---

** [issues:#5342] lilypond-invoke-editor only should only handle textedit URIs**

**Status:** Invalid
**Created:** Mon Jun 11, 2018 05:26 PM UTC by pkx166h
**Last Updated:** Mon Jun 11, 2018 05:32 PM UTC
**Owner:** pkx166h


This came out of both 

https://sourceforge.net/p/testlilyissues/issues/5243/

and

https://sourceforge.net/p/testlilyissues/issues/5334/

>From Knut Petersen - 2018-06-03

I think that lilypond-invoke-editor only should only handle textedit URIs. It 
might be a good idea to have a 2nd look at the patch I suggested in 2017.

https://codereview.appspot.com/336240043
https://sourceforge.net/p/testlilyissues/issues/5243/

On top of current master
git revert aee02594be68a968bb843f87d3264777099e46b4
git revert 39f800a7e5acb7cc5da6424c99fd2690e389495a
git revert 807f5eb8cd631133da3be6897e3e8fa7202e089d
wget https://codereview.appspot.com/download/issue336240043_60001.diff
would be needed to for a test build.

In 2017 one objection was that my patch does not change the code in lily.scm 
... do you we really need to change that code? I don't see a problem as the 
code is executed by lilypond, we give the arguments. But maybe I don't have the 
imagination to see a security hole ... 


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: countdown --> push
- **Comment**:

Patch counted down - I'll push.



---

** [issues:#5334] Use system* instead of system when invoking browser**

**Status:** Started
**Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h
**Last Updated:** Wed Jun 13, 2018 02:41 PM UTC
**Owner:** pkx166h
**Attachments:**

- 
[0001-use-system-instead-of-system.patch](https://sourceforge.net/p/testlilyissues/issues/5334/attachment/0001-use-system-instead-of-system.patch)
 (1.3 kB; text/x-patch)


 Don Armstrong - 2018-05-11

I have just uploaded a fix to Debian which switches to using system* instead of 
system:
https://salsa.debian.org/debian/lilypond/commit/788b56e4b7f62637481af65b4b2929649c30fe78

Not sure if this is cross-platform enough, but it solves the issue for systems 
with a working system* call.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5343 Remove Moment::as_scheme

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for June 19th.



---

** [issues:#5343] Remove Moment::as_scheme**

**Status:** Started
**Created:** Wed Jun 13, 2018 02:12 PM UTC by David Kastrup
**Last Updated:** Wed Jun 13, 2018 04:54 PM UTC
**Owner:** David Kastrup


Remove Moment::as_scheme

It's a remnant of some design long abandoned.

http://codereview.appspot.com/346070043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for June 19th.



---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Fri Jun 15, 2018 04:32 PM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Could you please keep tests like that not private but add them to the regtests? 
 Particularly when you are working on that area?  This could have been caught 
by either me or James then.  I doubt I'll be able to fix this before tomorrow 
as I have to leave for a family celebration soonish.


---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 12:27 PM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5347 Add and use a Transform data type

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5347] Add and use a Transform data type**

**Status:** Started
**Created:** Sat Jun 16, 2018 09:03 AM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 09:03 AM UTC
**Owner:** nobody


Add and use a Transform data type

As of now, this is just used in stencil-integral.  However, a Scheme
level interface would likely make sense for compacting geometric
transformations.  The abstraction currently relies on PangoTransform
matrices but could easily be moved to other implementations such as
cairo_matrix_t.


Contains commits:

Add Transform data type


stencil-integral.cc: use Transform


stencil-integral: pass SCM as transform values

http://codereview.appspot.com/344970043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
author  Don Armstrong
Sat, 2 Jun 2018 18:56:52 +0100 (18:56 +0100)
committer   James Lowe  
Sat, 16 Jun 2018 11:05:02 +0100 (11:05 +0100)
commit  d493d5f4bc8c87afdf44f42e5cc5f421f8d0545d
~~~

Thank you Don.



---

** [issues:#5334] Use system* instead of system when invoking browser**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h
**Last Updated:** Sat Jun 16, 2018 08:51 AM UTC
**Owner:** pkx166h
**Attachments:**

- 
[0001-use-system-instead-of-system.patch](https://sourceforge.net/p/testlilyissues/issues/5334/attachment/0001-use-system-instead-of-system.patch)
 (1.3 kB; text/x-patch)


 Don Armstrong - 2018-05-11

I have just uploaded a fix to Debian which switches to using system* instead of 
system:
https://salsa.debian.org/debian/lilypond/commit/788b56e4b7f62637481af65b4b2929649c30fe78

Not sure if this is cross-platform enough, but it solves the issue for systems 
with a working system* call.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

This wasn't private at all since I actually had added this very example to the 
regtests:
input/regression/skyline-grob-rotation.ly
It should have shown up in the standard regtest procedures, I'll check this.

By the way: grob rotation (the printed stencil) uses rotate_degrees, i.e. the 
offset co-ordinates are "measured in terms of the extent of the stencil, so -1 
= LEFT/DOWN edge, 1 = RIGHT/UP edge." (cited from a comment in the coding).

This was the reason that drove me into rotating a copy of the stencil using 
rotate_degrees as an easy way to get the exact same behaviour for skylines and 
the printed stencil later on. Unfortunately, I was totally ignorant of garbage 
collection.


---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 12:27 PM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push.



---

** [issues:#5340] Simplify Spacing_spanner::get_columns**

**Status:** Started
**Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble
**Last Updated:** Wed Jun 13, 2018 02:42 PM UTC
**Owner:** Dan Eble


Simplify Spacing_spanner::get_columns

The old algorithm filtered the system's list of columns into a list of
used columns, then searched the filtered list for the endpoints of the
range to return.

The search key was the "rank" of a column, which is its index in the
unfiltered list of columns (see System::add_column).  There is
therefore no need to search.

The new algorithm selects the desired range in the unfiltered list and
then filters that.

This commit also removes the unused function Paper_column::compare.

http://codereview.appspot.com/348940044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: countdown --> push



---

** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs**

**Status:** Started
**Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen
**Last Updated:** Sat Jun 16, 2018 08:49 AM UTC
**Owner:** Knut Petersen


Fix out-of-sync LilyScriptEncoding / ps script defs

Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
encodingdefs.ps.

This patch will pass 'make test-baseline/check', but visually the reg 
testdifferences that do occur are wrong.

I did not care about the 80-characters per line limit,
it is easier to maintain this format.

The glyphs are now included in the order in which they
are included in the emmentaler fonts. The order of the
glyphs does not matter as long as the encoding vector
and the corresponding commands match.

The change occured because I decided to use otfinfo
and sed to generate the new code, it seemed easier,
safer and faster than correcting the old code by hand.

Signed-off-by: Knut Petersen 

http://codereview.appspot.com/347870043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
author  Alexander Myltsev  
Wed, 27 Apr 2016 16:04:43 +0100 (18:04 +0300)
committer   James Lowe  
Sat, 16 Jun 2018 10:58:59 +0100 (10:58 +0100)
commit  d751f5fd70d1c4de9878dceb81bda42e9a500fb7
~~~

~~~
author  Alexander Myltsev  
Thu, 2 Jun 2016 09:19:07 +0100 (11:19 +0300)
committer   James Lowe  
Sat, 16 Jun 2018 10:59:08 +0100 (10:59 +0100)
commit  7b07440da921d979ab492fd284b6198152a8020c
~~~

Many thanks Alexander.



---

** [issues:#5333] musicxml2ly: hidden timesigs and tempo marks with text.**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Fri Jun 01, 2018 11:49 AM UTC by Alex Myltsev
**Last Updated:** Fri Jun 15, 2018 12:19 PM UTC
**Owner:** Alex Myltsev


musicxml2ly: hidden timesigs and tempo marks with text.

http://codereview.appspot.com/34443


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5345 Crash with specific combination of pitch and omitted note head

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:



--- old
+++ new
@@ -1,3 +1,17 @@
+Issue 5345: Stop crash while merging ledger lines
+
+The old code (part of issue 4979) used quite broken code for merging
+intervals that could crash eating all memory under certain conditions
+and failed to account for merging certain interval combinations.
+
+The incremental broken merge code has been thrown out and replaced by
+using the non-incremental Interval_set::union which has been designed
+for that purpose.
+
+http://codereview.appspot.com/343270043
+
+
+
 Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:
 
 WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.



- **assigned_to**: David Kastrup
- **Needs**:  -->  
- **Type**:  --> Enhancement



---

** [issues:#5345] Crash with specific combination of pitch and omitted note 
head**

**Status:** Started
**Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht
**Last Updated:** Mon Jun 18, 2018 12:24 AM UTC
**Owner:** David Kastrup


Issue 5345: Stop crash while merging ledger lines

The old code (part of issue 4979) used quite broken code for merging
intervals that could crash eating all memory under certain conditions
and failed to account for merging certain interval combinations.

The incremental broken merge code has been thrown out and replaced by
using the non-incremental Interval_set::union which has been designed
for that purpose.

http://codereview.appspot.com/343270043



Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:

WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.


:::TeX
\version "2.19.80"

\new Staff <<
  {
\clef bass
e,4
  }
  {
\omit NoteHead
e,4
  }
>>


Lukas says:

> Everything here (except the \version) seems to be necessary. I can reproduce 
> the crash with some other configurations as well (another pitch in tenor 
> clef, for instance), but removing any single command seems to resolve the 
> problem. Also, putting each "voice" into a regular \new Voice (as in Harm's 
> proposal) makes the problem disappear. Just as  taking f, instead of e, for 
> the pitch does (which could point to ledger lines).

David K. says the problem appears to be in the page builder.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5348 Fix bad rotation center from issue 5346

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5348] Fix bad rotation center from issue 5346**

**Status:** Started
**Created:** Sat Jun 16, 2018 08:39 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 08:39 PM UTC
**Owner:** nobody


Fix bad rotation center from issue 5346

http://codereview.appspot.com/341380043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

commit bb34e5bbfdcf8d10877b5b85a339416f0a03c39b (HEAD -> 
pushed/issue-5340-used-columns-in-range, origin/staging)
Author: Dan Eble 
Date:   Mon Jun 11 06:47:48 2018 -0400

Issue 5340: Simplify Spacing_spanner::get_columns

The old algorithm filtered the system's list of columns into a list of
used columns, then searched the filtered list for the endpoints of the
range to return.

The search key was the "rank" of a column, which is its index in the
unfiltered list of columns (see System::add_column).  There is
therefore no need to search.

The new algorithm selects the desired range in the unfiltered list and
then filters that.

This commit also removes the unused function Paper_column::compare.




---

** [issues:#5340] Simplify Spacing_spanner::get_columns**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble
**Last Updated:** Sat Jun 16, 2018 08:48 AM UTC
**Owner:** Dan Eble


Simplify Spacing_spanner::get_columns

The old algorithm filtered the system's list of columns into a list of
used columns, then searched the filtered list for the endpoints of the
range to return.

The search key was the "rank" of a column, which is its index in the
unfiltered list of columns (see System::add_column).  There is
therefore no need to search.

The new algorithm selects the desired range in the unfiltered list and
then filters that.

This commit also removes the unused function Paper_column::compare.

http://codereview.appspot.com/348940044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5348 Fix bad rotation center from issue 5346

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

`out/bin/lilypond -ddebug-skylines input/regression/skyline-grob-rotation.ly`

looks fixed with this patch.  I'll give it an expedited push if there is some 
corroboration.


---

** [issues:#5348] Fix bad rotation center from issue 5346**

**Status:** Started
**Created:** Sat Jun 16, 2018 08:39 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 08:39 PM UTC
**Owner:** David Kastrup


Fix bad rotation center from issue 5346

http://codereview.appspot.com/341380043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

No problem with "fuming off", but what bothers me a bit is that these 
positioning differences actually do not show up in the standard regtests. I 
didn't expect that at all.

But when using the png comparison regtests (make-regtest-png.sh), the 
differences will become visible - even the slight shift in the much older 
stencil-color-rotation.
Please find a PNG file containing all six (old, new, diff) as an attachment.




---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 12:27 PM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5348 Fix bad rotation center from issue 5346

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- Description has changed:

Diff:







- **status**: Started --> Fixed
- **Needs**:  -->  
- **Patch**: new -->  
- **Type**: Enhancement --> Critical
- **Comment**:

Pushed to staging as
commit 92e15f3cbc30036c823961812f06134ab9e2893b
Author: David Kastrup 
Date:   Sat Jun 16 22:38:02 2018 +0200

Issue 5348: Fix bad rotation center from issue 5346

Sorry for the rush but my train arrives in 4 minutes.  Let's hope I don't get 
arrested while changing into my biking clothes.  Again no working toilet on the 
train.



---

** [issues:#5348] Fix bad rotation center from issue 5346**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Sat Jun 16, 2018 08:39 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 08:51 PM UTC
**Owner:** David Kastrup


Fix bad rotation center from issue 5346

http://codereview.appspot.com/341380043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

>  It should have shown up in the standard regtest procedures, I'll check this.

Sorry for fuming off here: I searched for the file name of your regtest image 
and you named it different from the test so I thought it wasn't there and I had 
no time looking for it.  I think the problem is that our regtests prefilter on 
differences in bounding boxes of grobs and those are entirely unimpressed by 
skylines.  Maybe it would help to stack several systems into one markup so that 
the system skyline distance has some effect on some grob.

I just uploaded a new patch: I'll check it with this regtest.


---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 12:27 PM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

> but what bothers me a bit is that these positioning differences actually do 
> not show up in the standard regtests. I didn't expect that at all.

Well, me neither.  Hence the fume.  I needed hitting in the face with it to 
even start looking for an explanation.  It's likely a potential problem with 
all skyline regtests, not just rotation.


---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 12:27 PM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Dan, test results here:

https://cloud.indie.host/s/iMYNwKodaWDxCjY


---

** [issues:#5344] Avoid repeated calculation of accepted contexts**

**Status:** Started
**Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble
**Last Updated:** Sun Jun 17, 2018 08:31 PM UTC
**Owner:** Dan Eble


Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context is instantiated.

http://codereview.appspot.com/346080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5345 Crash with specific combination of pitch and omitted note head

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5345] Crash with specific combination of pitch and omitted note 
head**

**Status:** Started
**Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht
**Last Updated:** Mon Jun 18, 2018 12:06 PM UTC
**Owner:** David Kastrup


Issue 5345: Stop crash while merging ledger lines

The old code (part of issue 4979) used quite broken code for merging
intervals that could crash eating all memory under certain conditions
and failed to account for merging certain interval combinations.

The incremental broken merge code has been thrown out and replaced by
using the non-incremental Interval_set::union which has been designed
for that purpose.

http://codereview.appspot.com/343270043



Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:

WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.


:::TeX
\version "2.19.80"

\new Staff <<
  {
\clef bass
e,4
  }
  {
\omit NoteHead
e,4
  }
>>


Lukas says:

> Everything here (except the \version) seems to be necessary. I can reproduce 
> the crash with some other configurations as well (another pitch in tenor 
> clef, for instance), but removing any single command seems to resolve the 
> problem. Also, putting each "voice" into a regular \new Voice (as in Harm's 
> proposal) makes the problem disappear. Just as  taking f, instead of e, for 
> the pitch does (which could point to ledger lines).

David K. says the problem appears to be in the page builder.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5344 Avoid repeated calculation of accepted contexts

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Dan,

Sorry I didn't spot this until later. I'll re-run the test and let you know.


---

** [issues:#5344] Avoid repeated calculation of accepted contexts**

**Status:** Started
**Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble
**Last Updated:** Sun Jun 17, 2018 08:31 PM UTC
**Owner:** Dan Eble


Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context is instantiated.

http://codereview.appspot.com/346080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5349 Use more const Grobs in the Paper_column interface

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5349] Use more const Grobs in the Paper_column interface**

**Status:** Started
**Created:** Mon Jun 18, 2018 11:56 PM UTC by Dan Eble
**Last Updated:** Mon Jun 18, 2018 11:56 PM UTC
**Owner:** nobody


Use more const Grobs in the Paper_column interface

http://codereview.appspot.com/346100043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5350 Avoid unnecessary copying of Paper_score vectors

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5350] Avoid unnecessary copying of Paper_score vectors**

**Status:** Started
**Created:** Tue Jun 19, 2018 03:22 AM UTC by Dan Eble
**Last Updated:** Tue Jun 19, 2018 03:22 AM UTC
**Owner:** nobody


Avoid unnecessary copying of Paper_score vectors

http://codereview.appspot.com/342170043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5341 Urgent corrections to stencil-integral.cc (skylines)

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Attachments has changed:

Diff:



--- old
+++ new
@@ -0,0 +1 @@
+Reg_test_2018-06-13 09-41-41.png (20.8 kB; image/png)



- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  --> Enhancement
- **Comment**:

Passes make, make check and a full make doc - reg test diff attached



---

** [issues:#5341] Urgent corrections to stencil-integral.cc (skylines)**

**Status:** Started
**Created:** Mon Jun 11, 2018 04:19 PM UTC by Torsten Hämmerle
**Last Updated:** Tue Jun 12, 2018 02:30 PM UTC
**Owner:** Torsten Hämmerle
**Attachments:**

- [Reg_test_2018-06-13 
09-41-41.png](https://sourceforge.net/p/testlilyissues/issues/5341/attachment/Reg_test_2018-06-13%2009-41-41.png)
 (20.8 kB; image/png)


Garbage collection issue spotted by DAK:
http://lilypond.1069038.n5.nabble.com/Re-issue-5319-Make-skylines-reflect-grob-rotation-issue-342060043-by-torsten-haemmerle-web-de-tt213726.html#none

Two other (minor) changes regarding unnecessary lines being drawn and replacing 
a 
i < n + 1 
by
i <= n


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for Jun 13.



---

** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs**

**Status:** Started
**Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen
**Last Updated:** Sun Jun 10, 2018 01:02 PM UTC
**Owner:** Knut Petersen


Fix out-of-sync LilyScriptEncoding / ps script defs

Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke
encodingdefs.ps.

This patch will pass 'make test-baseline/check', but visually the reg 
testdifferences that do occur are wrong.

I did not care about the 80-characters per line limit,
it is easier to maintain this format.

The glyphs are now included in the order in which they
are included in the emmentaler fonts. The order of the
glyphs does not matter as long as the encoding vector
and the corresponding commands match.

The change occured because I decided to use otfinfo
and sed to generate the new code, it seemed easier,
safer and faster than correcting the old code by hand.

Signed-off-by: Knut Petersen 

http://codereview.appspot.com/347870043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Knut, thanks. Do we still need 
https://sourceforge.net/p/testlilyissues/issues/5342/ ?

(Don's) Patch on countdown for June 13.



---

** [issues:#5334] Use system* instead of system when invoking browser**

**Status:** Started
**Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h
**Last Updated:** Mon Jun 11, 2018 10:00 PM UTC
**Owner:** pkx166h
**Attachments:**

- 
[0001-use-system-instead-of-system.patch](https://sourceforge.net/p/testlilyissues/issues/5334/attachment/0001-use-system-instead-of-system.patch)
 (1.3 kB; text/x-patch)


 Don Armstrong - 2018-05-11

I have just uploaded a fix to Debian which switches to using system* instead of 
system:
https://salsa.debian.org/debian/lilypond/commit/788b56e4b7f62637481af65b4b2929649c30fe78

Not sure if this is cross-platform enough, but it solves the issue for systems 
with a working system* call.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5334 Use system* instead of system when invoking browser

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

> Do we still need https://sourceforge.net/p/testlilyissues/issues/5342/ ?

No


---

** [issues:#5334] Use system* instead of system when invoking browser**

**Status:** Started
**Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h
**Last Updated:** Wed Jun 13, 2018 02:41 PM UTC
**Owner:** pkx166h
**Attachments:**

- 
[0001-use-system-instead-of-system.patch](https://sourceforge.net/p/testlilyissues/issues/5334/attachment/0001-use-system-instead-of-system.patch)
 (1.3 kB; text/x-patch)


 Don Armstrong - 2018-05-11

I have just uploaded a fix to Debian which switches to using system* instead of 
system:
https://salsa.debian.org/debian/lilypond/commit/788b56e4b7f62637481af65b4b2929649c30fe78

Not sure if this is cross-platform enough, but it solves the issue for systems 
with a working system* call.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5340 Simplify Spacing_spanner::get_columns

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for Jun 13.



---

** [issues:#5340] Simplify Spacing_spanner::get_columns**

**Status:** Started
**Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble
**Last Updated:** Tue Jun 12, 2018 11:35 AM UTC
**Owner:** Dan Eble


Simplify Spacing_spanner::get_columns

The old algorithm filtered the system's list of columns into a list of
used columns, then searched the filtered list for the endpoints of the
range to return.

The search key was the "rank" of a column, which is its index in the
unfiltered list of columns (see System::add_column).  There is
therefore no need to search.

The new algorithm selects the desired range in the unfiltered list and
then filters that.

This commit also removes the unused function Paper_column::compare.

http://codereview.appspot.com/348940044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push.



---

** [issues:#5337] Create Bottom contexts in a more general way**

**Status:** Started
**Created:** Tue Jun 05, 2018 04:59 PM UTC by Dan Eble
**Last Updated:** Sun Jun 10, 2018 03:18 PM UTC
**Owner:** Dan Eble


Create Bottom contexts in a more general way

Moving special treatment of "Bottom" into path_to_acceptable_context
() makes it effective during calls to create_unique_context (), which
is the basis of \new and (now) get_default_interpreter ().

http://codereview.appspot.com/339710043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5343 Remove Moment::as_scheme

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc



---

** [issues:#5343] Remove Moment::as_scheme**

**Status:** Started
**Created:** Wed Jun 13, 2018 02:12 PM UTC by David Kastrup
**Last Updated:** Wed Jun 13, 2018 02:12 PM UTC
**Owner:** David Kastrup


Remove Moment::as_scheme

It's a remnant of some design long abandoned.

http://codereview.appspot.com/346070043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5341 Urgent corrections to stencil-integral.cc (skylines)

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Rotation coding temporarily deactivated as discussed

http://codereview.appspot.com/341350043


---

** [issues:#5341] Urgent corrections to stencil-integral.cc (skylines)**

**Status:** Started
**Created:** Mon Jun 11, 2018 04:19 PM UTC by Torsten Hämmerle
**Last Updated:** Tue Jun 12, 2018 02:30 PM UTC
**Owner:** Torsten Hämmerle


Garbage collection issue spotted by DAK:
http://lilypond.1069038.n5.nabble.com/Re-issue-5319-Make-skylines-reflect-grob-rotation-issue-342060043-by-torsten-haemmerle-web-de-tt213726.html#none

Two other (minor) changes regarding unnecessary lines being drawn and replacing 
a 
i < n + 1 
by
i <= n


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5345 Crash with specific combination of pitch and omitted note head

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Oh wow.  I did not think of bijecting, and "don't merge non-overkapping ledger 
lines" is a theme that might be related to omitted note heads.  The pitch would 
require a ledger line as noted by Lukas, and its double occurence would warrant 
some sort of merging.

This helps a lot.


---

** [issues:#5345] Crash with specific combination of pitch and omitted note 
head**

**Status:** Accepted
**Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht
**Last Updated:** Fri Jun 15, 2018 09:33 AM UTC
**Owner:** nobody


Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:

WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.


:::TeX
\version "2.19.80"

\new Staff <<
  {
\clef bass
e,4
  }
  {
\omit NoteHead
e,4
  }
>>


Lukas says:

> Everything here (except the \version) seems to be necessary. I can reproduce 
> the crash with some other configurations as well (another pitch in tenor 
> clef, for instance), but removing any single command seems to resolve the 
> problem. Also, putting each "voice" into a regular \new Voice (as in Harm's 
> proposal) makes the problem disappear. Just as  taking f, instead of e, for 
> the pitch does (which could point to ledger lines).

David K. says the problem appears to be in the page builder.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5345 Crash with specific combination of pitch and omitted note head

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Well, the patch contains this part:

+  +  // When the extents of two 
ledgers at the same
+  // vertical position overlap horizontally, we merge
+  // them together to produce a single stencil.  In rare
+  // cases they do not overlap and we do not merge them.
+
   if (lr.ledger_extents_.find (lpos) == lr.ledger_extents_.end 
())
-lr.ledger_extents_[lpos] = x_extent;
+// Found nothing for this lpos.
+lr.ledger_extents_[lpos].push_back(x_extent);
   else
-lr.ledger_extents_[lpos].unite (x_extent);

I suspect that "do not merge" here translates to "eat all memory and crash".  
But I'll have to do more of an analysis to be sure.


---

** [issues:#5345] Crash with specific combination of pitch and omitted note 
head**

**Status:** Accepted
**Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht
**Last Updated:** Fri Jun 15, 2018 09:33 AM UTC
**Owner:** nobody


Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:

WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.


:::TeX
\version "2.19.80"

\new Staff <<
  {
\clef bass
e,4
  }
  {
\omit NoteHead
e,4
  }
>>


Lukas says:

> Everything here (except the \version) seems to be necessary. I can reproduce 
> the crash with some other configurations as well (another pitch in tenor 
> clef, for instance), but removing any single command seems to resolve the 
> problem. Also, putting each "voice" into a regular \new Voice (as in Harm's 
> proposal) makes the problem disappear. Just as  taking f, instead of e, for 
> the pitch does (which could point to ledger lines).

David K. says the problem appears to be in the page builder.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Here are the two commits reviewed above.


Attachments:

- 
[0001-musicxml2ly-support-text-bpm-tempo-marks.patch](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/15e541b4/8cc6/attachment/0001-musicxml2ly-support-text-bpm-tempo-marks.patch)
 (3.9 kB; application/octet-stream)
- 
[0002-musicxml2ly-handle-hidden-time-signatures.patch](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/15e541b4/8cc6/attachment/0002-musicxml2ly-handle-hidden-time-signatures.patch)
 (2.6 kB; application/octet-stream)


---

** [issues:#5333] musicxml2ly: hidden timesigs and tempo marks with text.**

**Status:** Started
**Created:** Fri Jun 01, 2018 11:49 AM UTC by Alex Myltsev
**Last Updated:** Wed Jun 13, 2018 02:38 PM UTC
**Owner:** Alex Myltsev


musicxml2ly: hidden timesigs and tempo marks with text.

http://codereview.appspot.com/34443


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5345 Crash with specific combination of pitch and omitted note head

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Well, I haven't started serious analysis yet, but my hunch is that an array 
basically containing {a, b} is iteratively changed into {a, b, a}, {a, b, a, 
a}, {a, b, a, a, a} or similar.  Basically it is extended all the while and the 
iteration never finishes.


---

** [issues:#5345] Crash with specific combination of pitch and omitted note 
head**

**Status:** Accepted
**Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht
**Last Updated:** Fri Jun 15, 2018 09:33 AM UTC
**Owner:** nobody


Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:

WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.


:::TeX
\version "2.19.80"

\new Staff <<
  {
\clef bass
e,4
  }
  {
\omit NoteHead
e,4
  }
>>


Lukas says:

> Everything here (except the \version) seems to be necessary. I can reproduce 
> the crash with some other configurations as well (another pitch in tenor 
> clef, for instance), but removing any single command seems to resolve the 
> problem. Also, putting each "voice" into a regular \new Voice (as in Harm's 
> proposal) makes the problem disappear. Just as  taking f, instead of e, for 
> the pitch does (which could point to ledger lines).

David K. says the problem appears to be in the page builder.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5345 Crash with specific combination of pitch and omitted note head

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Type**: Crash --> Critical



---

** [issues:#5345] Crash with specific combination of pitch and omitted note 
head**

**Status:** Accepted
**Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht
**Last Updated:** Fri Jun 15, 2018 09:33 AM UTC
**Owner:** nobody


Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:

WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.


:::TeX
\version "2.19.80"

\new Staff <<
  {
\clef bass
e,4
  }
  {
\omit NoteHead
e,4
  }
>>


Lukas says:

> Everything here (except the \version) seems to be necessary. I can reproduce 
> the crash with some other configurations as well (another pitch in tenor 
> clef, for instance), but removing any single command seems to resolve the 
> problem. Also, putting each "voice" into a regular \new Voice (as in Harm's 
> proposal) makes the problem disappear. Just as  taking f, instead of e, for 
> the pitch does (which could point to ledger lines).

David K. says the problem appears to be in the page builder.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5345 Crash with specific combination of pitch and omitted note head

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Looks to me like a problem with a missing pure-impure-container -- checking the 
extent has a side effect, so you create a new layout, and off you go.  But I 
haven't checked out the exact code.



---

** [issues:#5345] Crash with specific combination of pitch and omitted note 
head**

**Status:** Accepted
**Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht
**Last Updated:** Fri Jun 15, 2018 09:33 AM UTC
**Owner:** nobody


Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:

WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.


:::TeX
\version "2.19.80"

\new Staff <<
  {
\clef bass
e,4
  }
  {
\omit NoteHead
e,4
  }
>>


Lukas says:

> Everything here (except the \version) seems to be necessary. I can reproduce 
> the crash with some other configurations as well (another pitch in tenor 
> clef, for instance), but removing any single command seems to resolve the 
> problem. Also, putting each "voice" into a regular \new Voice (as in Harm's 
> proposal) makes the problem disappear. Just as  taking f, instead of e, for 
> the pitch does (which could point to ledger lines).

David K. says the problem appears to be in the page builder.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

commit 1c751c5c50c56b85253bba402e24dc16a725a33d (HEAD -> 
pushed/issue-5337-context-bottom, origin/staging)
Author: Dan Eble 
Date:   Sat May 26 07:08:09 2018 -0400

Issue 5337: Create Bottom contexts in a more general way

Moving special treatment of "Bottom" into path_to_acceptable_context
() makes it effective during calls to create_unique_context (), which
is the basis of \new and (now) get_default_interpreter ().




---

** [issues:#5337] Create Bottom contexts in a more general way**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Tue Jun 05, 2018 04:59 PM UTC by Dan Eble
**Last Updated:** Wed Jun 13, 2018 02:38 PM UTC
**Owner:** Dan Eble


Create Bottom contexts in a more general way

Moving special treatment of "Bottom" into path_to_acceptable_context
() makes it effective during calls to create_unique_context (), which
is the basis of \new and (now) get_default_interpreter ().

http://codereview.appspot.com/339710043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:



--- old
+++ new
@@ -3,6 +3,6 @@
 Encapsulate the list of accepted contexts into Acceptance_set, which
 is owned by both Context_def and Context.  The merging of context mods
 that used to occur anew for every path_to_acceptable_context () call
-now occurs once when a context instantiated.
+now occurs once when a context is instantiated.
 
 http://codereview.appspot.com/346080043



- **Needs**:  -->  



---

** [issues:#5344] Avoid repeated calculation of accepted contexts**

**Status:** Started
**Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble
**Last Updated:** Thu Jun 14, 2018 10:05 PM UTC
**Owner:** Dan Eble


Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context is instantiated.

http://codereview.appspot.com/346080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Patch**: new --> needs_work



---

** [issues:#5344] Avoid repeated calculation of accepted contexts**

**Status:** Started
**Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble
**Last Updated:** Fri Jun 15, 2018 12:39 AM UTC
**Owner:** Dan Eble


Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context is instantiated.

http://codereview.appspot.com/346080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5344] Avoid repeated calculation of accepted contexts**

**Status:** Started
**Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble
**Last Updated:** Thu Jun 14, 2018 10:05 PM UTC
**Owner:** nobody


Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context instantiated.

http://codereview.appspot.com/346080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5345 Crash with specific combination of pitch and omitted note head

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5345] Crash with specific combination of pitch and omitted note 
head**

**Status:** Accepted
**Created:** Fri Jun 15, 2018 12:11 AM UTC by Simon Albrecht
**Last Updated:** Fri Jun 15, 2018 12:11 AM UTC
**Owner:** nobody


Reported by Lukas-Fabian Moser [in this 
thread](http://lists.gnu.org/archive/html/lilypond-user/2018-06/msg00222.html) 
with the following minimal example:

WARNING: Only test with appropriate configuration of ulimit, see the e-mail 
exchange.


:::TeX
\version "2.19.80"

\new Staff <<
  {
\clef bass
e,4
  }
  {
\omit NoteHead
e,4
  }
>>


Lukas says:

> Everything here (except the \version) seems to be necessary. I can reproduce 
> the crash with some other configurations as well (another pitch in tenor 
> clef, for instance), but removing any single command seems to resolve the 
> problem. Also, putting each "voice" into a regular \new Voice (as in Harm's 
> proposal) makes the problem disappear. Just as  taking f, instead of e, for 
> the pitch does (which could point to ledger lines).

David K. says the problem appears to be in the page builder.


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Fri Jun 15, 2018 03:32 PM UTC
**Owner:** David Kastrup


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5346 Fix GC issue in skyline rotations

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5346] Fix GC issue in skyline rotations**

**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Fri Jun 15, 2018 03:32 PM UTC
**Owner:** nobody


Fix GC issue in skyline rotations

This was issue 5341 initially and is a fix for a problem introduced
during issue 5319.  The problem basically is that a rotated Stencil is
created and its stencil expression is getting stored on the heap
without retaining any pointer to it in areas scanned during garbage
collections.

This fix is a minimal one that merely avoids creating a stencil and
instead simulates the effect on the transform matrix to be expected
from using a rotated stencil.

http://codereview.appspot.com/344960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

test that \with \denies ... has local effect

http://codereview.appspot.com/346080043


---

** [issues:#5344] Avoid repeated calculation of accepted contexts**

**Status:** Started
**Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble
**Last Updated:** Sun Jun 17, 2018 05:51 PM UTC
**Owner:** Dan Eble


Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context is instantiated.

http://codereview.appspot.com/346080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5344 Avoid repeated calculation of accepted contexts

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Stop uniquifying \accepts; clarify copying

http://codereview.appspot.com/346080043


---

** [issues:#5344] Avoid repeated calculation of accepted contexts**

**Status:** Started
**Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble
**Last Updated:** Sun Jun 17, 2018 01:06 PM UTC
**Owner:** Dan Eble


Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context is instantiated.

http://codereview.appspot.com/346080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5344 Avoid repeated calculation of accepted contexts

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

James, when you run `make check`, it would be interesting to know whether there 
are any differences in the profiling results.  When I ran `make check` myself, 
the results showed 3 cases with a reduction in cell count above the threshold 
distance.  I don't remake my test baseline very frequently, though.


---

** [issues:#5344] Avoid repeated calculation of accepted contexts**

**Status:** Started
**Created:** Thu Jun 14, 2018 10:05 PM UTC by Dan Eble
**Last Updated:** Sun Jun 17, 2018 01:06 PM UTC
**Owner:** Dan Eble


Avoid repeated calculation of accepted contexts

Encapsulate the list of accepted contexts into Acceptance_set, which
is owned by both Context_def and Context.  The merging of context mods
that used to occur anew for every path_to_acceptable_context () call
now occurs once when a context is instantiated.

http://codereview.appspot.com/346080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5347 Add and use a Transform data type

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Needs**:  -->  
- **Patch**: new --> needs_work
- **Type**:  -->  
- **Comment**:

Oh for  sake.  This patch has the original GC problem back.  I'll need 
another iteration.



---

** [issues:#5347] Add and use a Transform data type**

**Status:** Started
**Created:** Sat Jun 16, 2018 09:03 AM UTC by David Kastrup
**Last Updated:** Sun Jun 17, 2018 12:26 PM UTC
**Owner:** David Kastrup


Add and use a Transform data type

As of now, this is just used in stencil-integral.  However, a Scheme
level interface would likely make sense for compacting geometric
transformations.  The abstraction currently relies on PangoTransform
matrices but could easily be moved to other implementations such as
cairo_matrix_t.


Contains commits:

Add Transform data type


stencil-integral.cc: use Transform


stencil-integral: pass SCM as transform values

http://codereview.appspot.com/344970043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5347 Add and use a Transform data type

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Refix GC issue

http://codereview.appspot.com/344970043


---

** [issues:#5347] Add and use a Transform data type**

**Status:** Started
**Created:** Sat Jun 16, 2018 09:03 AM UTC by David Kastrup
**Last Updated:** Sun Jun 17, 2018 12:41 PM UTC
**Owner:** David Kastrup


Add and use a Transform data type

As of now, this is just used in stencil-integral.  However, a Scheme
level interface would likely make sense for compacting geometric
transformations.  The abstraction currently relies on PangoTransform
matrices but could easily be moved to other implementations such as
cairo_matrix_t.


Contains commits:

Add Transform data type


stencil-integral.cc: use Transform


stencil-integral: pass SCM as transform values

http://codereview.appspot.com/344970043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto