Re: Add Editing page/node (issue 60530047)
Am 07.02.2014 23:32, schrieb Urs Liska: Am 07.02.2014 22:24, schrieb Janek Warchoł: Hi, 2014-02-07 Urs Liska u...@openlilylib.org: At http://www.openlilylib.org/lilyweb/editing.html you can see the actual page _with_ the new image (in order to compile locally you'd have to pull from lilypond-extra). My comments: I'd change generic editor to text editor. generic is a needlessly complicated word, it will just scare people. Any other opinions on that? I wouldn't object to Janek's reasoning, but am slightly reluctant to go through the process if nobody else thinks the same. I support Janek's proposal, text editor sounds better. and maybe errors through typographic means - i had to read it 3 times to understand what you mean. OK, I'll review that. You are referring to structure of the input file in that sentence – misspelled commands should not be part of it, so IMHO error highlightning – while being very convenient – does not belong to the structure and its representation within an editor window. Marc best, j ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES: Countdown for Feb 11 - 06:00 GMT
Hello, 3836 http://code.google.com/p/lilypond/issues/detail?id=3836q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement James Lowe push Patch: NR: Add verbatim to @lilypond example 3835 http://code.google.com/p/lilypond/issues/detail?id=3835q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement David Kastrup push Patch: Chord change detection in repeat alternatives 3833 http://code.google.com/p/lilypond/issues/detail?id=3833q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation James Lowe push Document Double G clef, tenor G clef, varpercussion clef and varC clef 3829 http://code.google.com/p/lilypond/issues/detail?id=3829q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation James Lowe push website: suggest latest stable and remove the version from Linux distribution-specific links 3823 http://code.google.com/p/lilypond/issues/detail?id=3823q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation James Lowe push Add @KNOWNISSUE for midiInstrument appear twice in MIDI output 3844 http://code.google.com/p/lilypond/issues/detail?id=3844q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement paconet.org countdown Patch: Doc: misplaced comment produces wrong HTML output. 3843 http://code.google.com/p/lilypond/issues/detail?id=3843q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation paconet.org countdown Patch: Doc: make real destructive code innocuous. 3842 http://code.google.com/p/lilypond/issues/detail?id=3842q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation paconet.org countdown Doc: clarify because a «command» is not always a lilypond command. 3831 http://code.google.com/p/lilypond/issues/detail?id=3831q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement David Nalesnik countdown Patch: Improve positioning of tuplet numbers for kneed beams. 3845 http://code.google.com/p/lilypond/issues/detail?id=3845q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement Urs Liska review Patch: Add Editing page/node 3803 http://code.google.com/p/lilypond/issues/detail?id=3803q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation James Lowe review Add Stockhausen piece to examples 3239 http://code.google.com/p/lilypond/issues/detail?id=3239q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement Janek Warchol waiting Patch: rewrite Self_alignment_interface May 2013 3186
Changes.tely updated - 2.19.x before Feb 4th 2014 (issue 60490050)
https://codereview.appspot.com/60490050/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/60490050/diff/1/Documentation/changes.tely#newcode108 Documentation/changes.tely:108: Chord change detection in @code{\repeat} alternatives now happens in This is a special case of several properties at the start of a repeat alternative are reset to the value at the start of the first alternative. This currently also affects the current meter, and the current measure position. We probably should also add the current key and active accidentals here, but at the current point of time it's the above. https://codereview.appspot.com/60490050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Changes.tely updated - 2.19.x before Feb 4th 2014 (issue 60490050)
Reviewers: dak, Message: On 2014/02/08 12:45:33, dak wrote: https://codereview.appspot.com/60490050/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/60490050/diff/1/Documentation/changes.tely#newcode108 Documentation/changes.tely:108: Chord change detection in @code{\repeat} alternatives now happens in This is a special case of several properties at the start of a repeat alternative are reset to the value at the start of the first alternative. This currently also affects the current meter, and the current measure position. We probably should also add the current key and active accidentals here, but at the current point of time it's the above. Thanks, I've reworded the paragraph. Would it be possible (useful?) to have some simple @code{} examples to better illustrate some of the Scheme entries (rather than complete @lilypond or @example examples)? Description: Changes.tely updated - 2.19.x before Feb 4th 2014 Documented all new enhancements and features since 2.19.0 was released up until current master (Feb 4 2014). Contains Information for the following fixed Tracker Issues 3753, 3761, 3772, 3780, 3793, 3810, 3814, 3815, 3817, 3818, 3821 and 3835 Please review this at https://codereview.appspot.com/60490050/ Affected files (+61, -0 lines): M Documentation/changes.tely Index: Documentation/changes.tely diff --git a/Documentation/changes.tely b/Documentation/changes.tely index 19f2da0da8509151116c6848edc83f36682715c9..e6f0bcdbdaa36829d4635892352c8962b4cdd9d5 100644 --- a/Documentation/changes.tely +++ b/Documentation/changes.tely @@ -60,6 +60,67 @@ which scares away people. * only show user-visible changes. @end ignore +@item +@code{Partcombiner}'s handing of repeated note durations has been +improved. + +@item +@code{\lyricsto} and @code{\addLyrics} have been @q{harmonized}. Both +now accept the same kind of delimited argument list that @code{\lyrics} +and @code{\chords} accept. Backward compatibility has been added so +music identifiers (i.e. @code{\mus}) are permitted as arguments. A +@code{convert-ly} rule has been added that removes redundant uses of +@code{\lyricmode} and rearranges combinations with context starters such +that @code{\lyricsto} in general is applied last (i.e. like +@code{\lyricmode} would be). + +@item +Scheme functions and identifiers can now be used as output definitions. + +@item +Scheme expressions can now be used as chord constituents. + +@item +Improved visual spacing of small and regular @q{MI} Funk and Walker +noteheads so they are now the same width as other shaped notes in +their respective sets. @code{SOL} noteheads are also now visually +improved when used with both the normal Aiken and Sacred Harp heads, as +well as with the thin variants. + +@item +@code{LeftEdge} now has a definable @code{Y-extent} (i.e.vertical). See +@rinternals{LeftEdge}. + +@item +Added a new @code{make-path-stencil} function that supports all +@code{path} commands both relative and absolute: + +@code{lineto}, @code{rlineto}, @code{curveto}, @code{rcurveto}, +@code{moveto}, @code{rmoveto}, @code{closepath}. The function also +supports @q{single-letter} syntax used in standard SVG path commands: + +@code{L}, @code{l}, @code{C}, @code{c}, @code{M}, @code{m}, @code{Z} and +@code{z}. The new command is also backward-compatible with the original +@code{make-connected-path-stencil} function. Also see +@file{scm/stencil.scm}. + +@item +Chord change detection in @code{\repeat} alternatives now happens in +relation to the chord active at the @emph{beginning} of the @emph{first} +alternative. + +@item +Improved MIDI output for breathe marks. After tied notes, breaths take +time @emph{only} from the last note of the tie; e.g. +@code{@{ c4~ c8 \breathe @}} performs as @code{@{ c4~ c16 r @}} instead +of @code{@{ c4 r8 @}}. This is more consistent with articulations and +how humans interpret breaths after ties. It now also makes it easier to +align simultaneous breathe marks over multiple parts, all with different +note lengths. + +@item +A new note head style for Tabulature has been added; +@code{TabNoteHead.style = #'slash}. @item Four new Clefs have been added. @emph{Double G}, @emph{Tenor G}, ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Changes.tely updated - 2.19.x before Feb 4th 2014 (issue 60490050)
https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely#newcode64 Documentation/changes.tely:64: @code{Partcombiner}'s handing of repeated note durations has been It has not been improved but rather made to work at all. Bug fix - we don't mention it at all in the changes. https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely#newcode108 Documentation/changes.tely:108: Several @q{propeties} including chord, key and accidental changes are properties. But this is a bit hand-wavy and confusing. Let's see: Context properties named in the @samp{alternativeRestores} property are restored to their value at the start of the first alternative in subsequent alternatives. The default set restores measure position, current chord (for the sake of showing chord changes) and current meter. End of proposal... key and accidentals are not yet in the current set of restored properties. It might make sense to put them there as well. What is somewhat tricky here is that the property restoration works via iterators in whatever context may get to see the \repeat/\volta stuff. So the key stuff might behave trickily. We probably still want to try it out and see whether people complain. The safest bet is having \repeat/\volta everywhere where you want it, and it's also safer when using \unfoldRepeats. https://codereview.appspot.com/60490050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add Editing page/node (issue 60530047)
Some proposed changes that help to make it easier to read, I hope. https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (right): https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1190 Documentation/web/introduction.itexi:1190: and how you actually @emph{work} with these text files you may Think it's simpler and better to say: But if you don't have a clear idea yet how you actually @emph{work} with these text files https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1202 Documentation/web/introduction.itexi:1202: LilyPond isn't one monolithic program as you may be used one - a single https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1203 Documentation/web/introduction.itexi:1203: from graphical notation tools. Instead it is a system with graphical music notation tools. https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1204 Documentation/web/introduction.itexi:1204: several independent parts. This may seem irritating at first, This may seem irritating at first, - This may not be what you're used to, https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1213 Documentation/web/introduction.itexi:1213: of other options, including MIDI. there is a variety of other options is grammatically correct, but sounds odd to a native. there are a variety of other options sounds better. Alternatively a variety of other options are available, including MIDI avoids the issue. https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1219 Documentation/web/introduction.itexi:1219: support you in working with LilyPond files. This would read better as: It can be unnecessarily difficult editing LilyPond input with a plain text editor, but fortunately there are a number of tools that actively support working with LilyPond files. https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1236 Documentation/web/introduction.itexi:1236: automatic command completion that helps you remembering remembering - remember https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1237 Documentation/web/introduction.itexi:1237: the available commands and reduces misspelling errors at the misspelling - spelling https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1240 Documentation/web/introduction.itexi:1240: While these are quite basic tools some programs offer you a While these are quite basic tools some programs offer - Some other programs offer https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1241 Documentation/web/introduction.itexi:1241: complete editing environment for working with LilyPond score. score - scores https://codereview.appspot.com/60530047/diff/40001/Documentation/web/introduction.itexi#newcode1242 Documentation/web/introduction.itexi:1242: They may include templates and entry palettes, may support may support - support https://codereview.appspot.com/60530047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Updating Ubuntu
Still using Ubuntu 10.04 and the update manager is proposing updates to libcurl. I think last time something of this sort happened I lost the ability to connect to lilypond.org via my SSH login: the versions locally and remotely were incompatible. Is this likely to happen again if I accept the updates, and if I did and it did, is there a way of backing them out again? Thanks for any help. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Updating Ubuntu
Phil Holmes m...@philholmes.net writes: Still using Ubuntu 10.04 and the update manager is proposing updates to libcurl. I think last time something of this sort happened I lost the ability to connect to lilypond.org via my SSH login: the versions locally and remotely were incompatible. Is this likely to happen again if I accept the updates, and if I did and it did, is there a way of backing them out again? Thanks for any help. Huh. I'm running a current version of Ubuntu (with Cinnamon as desktop) and I have not encountered any problems. But I can't remember ever having encountered the problems you mention, so my experience might not be authoritive for your setup. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCHES: Countdown for Feb 11 - 06:00 GMT
Am 08.02.2014 11:10, schrieb James: Hello, 3833 http://code.google.com/p/lilypond/issues/detail?id=3833q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation James Lowe pushDocument Double G clef, tenor G clef, varpercussion clef and varC clef I was off the devel list for quite some time, and since I re-signed in, I do not get any messages concerning new issues. Is this something that *I* can change somewhere somehow? On rietveld, I don't see any settings that may have some impact ... Marc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCHES: Countdown for Feb 11 - 06:00 GMT
On 08/02/14 15:03, Marc Hohl wrote: Am 08.02.2014 11:10, schrieb James: Hello, 3833 http://code.google.com/p/lilypond/issues/detail?id=3833q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation James Lowe push Document Double G clef, tenor G clef, varpercussion clef and varC clef I was off the devel list for quite some time, and since I re-signed in, I do not get any messages concerning new issues. Is this something that *I* can change somewhere somehow? On rietveld, I don't see any settings that may have some impact ... Marc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel Marc, Tracker updates are on auto not dev http://lists.gnu.org/archive/html/lilypond-auto/ So unless you are an email contact on the tracker itself you won't get anything in dev. Only Rietveld discussions are in dev. Hope that helps. james ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCHES: Countdown for Feb 11 - 06:00 GMT
Am 08.02.2014 16:50, schrieb James: On 08/02/14 15:03, Marc Hohl wrote: Am 08.02.2014 11:10, schrieb James: Hello, 3833 http://code.google.com/p/lilypond/issues/detail?id=3833q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Documentation James Lowe push Document Double G clef, tenor G clef, varpercussion clef and varC clef I was off the devel list for quite some time, and since I re-signed in, I do not get any messages concerning new issues. Is this something that *I* can change somewhere somehow? On rietveld, I don't see any settings that may have some impact ... Marc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel Marc, Tracker updates are on auto not dev Ah, I forgot that – thanks for the reminder! Marc http://lists.gnu.org/archive/html/lilypond-auto/ So unless you are an email contact on the tracker itself you won't get anything in dev. Only Rietveld discussions are in dev. Hope that helps. james ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Changes.tely updated - 2.19.x before Feb 4th 2014 (issue 60490050)
https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely#newcode64 Documentation/changes.tely:64: @code{Partcombiner}'s handing of repeated note durations has been On 2014/02/08 13:41:04, dak wrote: It has not been improved but rather made to work at all. Bug fix - we don't mention it at all in the changes. removed https://codereview.appspot.com/60490050/diff/20001/Documentation/changes.tely#newcode108 Documentation/changes.tely:108: Several @q{propeties} including chord, key and accidental changes are On 2014/02/08 13:41:04, dak wrote: properties. But this is a bit hand-wavy and confusing. Let's see: Context properties named in the @samp{alternativeRestores} property are restored to their value at the start of the first alternative in subsequent alternatives. The default set restores measure position, current chord (for the sake of showing chord changes) and current meter. Thanks. I'll make a new patch with some @lilypond examples as I think I get what is being said here and have created some simple examples. Although if you think I have missed the point, feel free to edit them. So this sounds like (and from my cursory experiments with lilypond-book compiling snippets) that bits of the NR http://lilypond.org/doc/v2.19/Documentation/notation/long-repeats are no longer needed now. --snip-- @lilypond[fragment,quote,relative=2] \partial 4 \repeat volta 2 { e4 | c2 e | } \alternative { { f2 d | \set Timing.measureLength = #(ly:make-moment 3/4) g4 g g % optional bar check is allowed here } { \set Timing.measureLength = #(ly:make-moment 4/4) a2 a | } } g1 | @end lilypond --snip-- When I compile this with and without the \set Timing command, it makes no difference at all. So is this what is now 'changed'? If so I'll make some edits in the NR too, while it is fresh in my head - but in a new patch for a new tracker. End of proposal... key and accidentals are not yet in the current set of restored properties. It might make sense to put them there as well. What is somewhat tricky here is that the property restoration works via iterators in whatever context may get to see the \repeat/\volta stuff. So the key stuff might behave trickily. We probably still want to try it out and see whether people complain. The safest bet is having \repeat/\volta everywhere where you want it, and it's also safer when using \unfoldRepeats. https://codereview.appspot.com/60490050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Updating Ubuntu
On 08/02/14 14:48, Phil Holmes wrote: Still using Ubuntu 10.04 and the update manager is proposing updates to libcurl. I think last time something of this sort happened I lost the ability to connect to lilypond.org via my SSH login: the versions locally and remotely were incompatible. Is this likely to happen again if I accept the updates, and if I did and it did, is there a way of backing them out again? Thanks for any help. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel Phil, If it helps, I just plough all the updates on usually. I haven't had any problems so far with this. I cannot remember a libcurl SSH connection issue, but as I say, it works for me. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Changes.tely updated - 2.19.x before Feb 4th 2014 (issue 60490050)
On 2014/02/08 19:38:38, J_lowe wrote: So this sounds like (and from my cursory experiments with lilypond-book compiling snippets) that bits of the NR http://lilypond.org/doc/v2.19/Documentation/notation/long-repeats are no longer needed now. --snip-- @lilypond[fragment,quote,relative=2] \partial 4 \repeat volta 2 { e4 | c2 e | } \alternative { { f2 d | \set Timing.measureLength = #(ly:make-moment 3/4) g4 g g % optional bar check is allowed here } { \set Timing.measureLength = #(ly:make-moment 4/4) a2 a | } } g1 | @end lilypond --snip-- When I compile this with and without the \set Timing command, it makes no difference at all. So is this what is now 'changed'? Yes. Though after removing the \set commands, the comment is wrong. If so I'll make some edits in the NR too, while it is fresh in my head - but in a new patch for a new tracker. Sounds good. https://codereview.appspot.com/60490050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Improve positioning of tuplet numbers for kneed beams. (issue 58610044)
Reviewers: janek, Message: On 2014/02/06 21:44:26, janek wrote: Why are there so few test cases in the regtests? I saw that you have loads of *excellent* examples, and i think that at least half of them is worth being added - don't be shy about it! Here's five more :) Description: Improve positioning of tuplet numbers for kneed beams. In the past LilyPond always placed tuplet numbers according to the position of a bracket, though this bracket may or may not have actually been drawn. This system led at times to tuplet numbers which appeared stranded when there was a kneed beam and no visible bracket. This patch positions the tuplet number independently of brackets and close to the beam when the the bracket is not drawn, the beam is kneed, and there is an appropriate beam segment to place the number against. The side of the beam on which the number is placed is chosen by principles derived from Gould. The number is centered horizontally on the beam. Collision detection is also introduced. The number will be offset horizontally if it is too close to an adjoining note column. All shifts preserve the number's vertical distance from the beam. If the number is too large to fit in the available horizontal space (between note columns to either side), we use the old bracket-based positioning system. In the event of a collision with an accidental, the tuplet number is moved vertically, away from the beam. The older behavior is always available through an override of the property `knee-to-beam' which is introduced by this patch, and set by default to true. This patch also adds a header file, `tuplet-number.hh', and provides a regression test, `tuplet-numbers-kneed-beams.ly'. Please review this at https://codereview.appspot.com/58610044/ Affected files (+690, -14 lines): A input/regression/tuplet-number-french-kneed-beams.ly A input/regression/tuplet-number-kneed-beam-even-stem-count.ly A input/regression/tuplet-number-kneed-beam-horizontal-fit.ly A input/regression/tuplet-number-kneed-beam-ledger-lines.ly A input/regression/tuplet-number-shift-along-kneed-beam.ly A input/regression/tuplet-numbers-kneed-beams-accidentals.ly A input/regression/tuplet-numbers-kneed-beams.ly A lily/include/tuplet-number.hh M lily/tuplet-number.cc M scm/define-grob-properties.scm M scm/define-grobs.scm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
NR: 1.4.1 Replaced deprecated snippet w\ @lilypond (issue 60840048)
https://codereview.appspot.com/60840048/diff/1/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (left): https://codereview.appspot.com/60840048/diff/1/Documentation/notation/repeats.itely#oldcode526 Documentation/notation/repeats.itely:526: {printing-a-repeat-sign-at-the-beginning-of-a-piece.ly} Is there any way in which one can actually delete this snippet file without getting it carried back in via LSR? https://codereview.appspot.com/60840048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: NR: 1.4.1 Replaced deprecated snippet w\ @lilypond (issue 60840048)
Reviewers: dak, Message: On 2014/02/08 21:55:15, dak wrote: https://codereview.appspot.com/60840048/diff/1/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (left): https://codereview.appspot.com/60840048/diff/1/Documentation/notation/repeats.itely#oldcode526 Documentation/notation/repeats.itely:526: {printing-a-repeat-sign-at-the-beginning-of-a-piece.ly} Is there any way in which one can actually delete this snippet file without getting it carried back in via LSR? I did wonder. Can we just remove it from ../snippets/new/.. as it resides in snippets/.. anyway, I assumed that anything in snippets/new/.. gets re-introduced to the doc (not sure about LSR) with makelsr.py? James Description: NR: 1.4.1 Replaced deprecated snippet w\ @lilypond Issue 3801 Removed reference to snippet and added a suitable @lilypond example. Please review this at https://codereview.appspot.com/60840048/ Affected files (+10, -6 lines): M Documentation/notation/repeats.itely Index: Documentation/notation/repeats.itely diff --git a/Documentation/notation/repeats.itely b/Documentation/notation/repeats.itely index ba57fe22b02d856a08b4e794472287b661ba982b..77defacb7879ad6885d605883da6beedde68574c 100644 --- a/Documentation/notation/repeats.itely +++ b/Documentation/notation/repeats.itely @@ -94,6 +94,16 @@ c2 d \repeat volta 2 { d4 e f g } @end lilypond +An @q{opening} repeat mark is not, by default, printed in the first full +measure. However it is possible to add one by using @code{\bar .|:} +before the first note. + +@lilypond[verbatim,fragment,quote,relative=2] +\repeat volta 2 { \bar .|: c4 d e f } +c2 d +\repeat volta 2 { d4 e f g } +@end lilypond + Alternative endings can be produced using @code{\alternative}. Each group of alternatives must be themselves, enclosed in a set of braces. @@ -519,12 +529,6 @@ voltaAdLib = \markup { 1. 2. 3... \text \italic { ad lib. } } } @end lilypond - -@snippets - -@lilypondfile[verbatim,quote,texidoc,doctitle] -{printing-a-repeat-sign-at-the-beginning-of-a-piece.ly} - @seealso Notation Reference: @ref{Bar lines}, ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel