Re: Edit Kievan documentation (issue 193890043 by aleksandr.andr...@gmail.com)
On 2015/01/04 13:26:19, J_lowe wrote: On 2015/01/04 13:17:15, aleksandr.andreev wrote: > On 2015/01/04 12:13:31, J_lowe wrote: > > 1. I cannot find a tracker for this issue (is that important for > translations?). > > > > The tracker is here: > https://code.google.com/p/lilypond/issues/detail?id=4241 > Could someone please push this for me, as I do not have push access? Thank you. https://codereview.appspot.com/193890043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Edit Kievan documentation (issue 193890043 by aleksandr.andr...@gmail.com)
On 2015/01/04 12:13:31, J_lowe wrote: 1. I cannot find a tracker for this issue (is that important for translations?). The tracker is here: https://code.google.com/p/lilypond/issues/detail?id=4241 2 I cannot find an equivalent set of entries in the English documentation. It looks like these translations are now out of sync with the English one. Can someone please check? It's in the English documentation here: http://lilypond.org/doc/v2.18/Documentation/notation/typesetting-kievan-square-notation There is some old code in the French and German documentation, which is what is being fixed with this patch. The German documentation is missing the subsection Kievan melismata, but I did not work on this. Best if whoever is supporting the German doc looks at that. Is there any way to update the doc on the website now, or do we have to wait for the release cycle? https://codereview.appspot.com/193890043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Edit Kievan documentation (issue 193890043 by aleksandr.andr...@gmail.com)
Reviewers: ,
Message:
Fixing some issues with the French and German documentation of Kievan
notation.
Description:
Edit Kievan documentation
Fixing some problems in French and German documentation of Kievan
notation.
Please review this at https://codereview.appspot.com/193890043/
Affected files (+8, -8 lines):
M Documentation/de/notation/ancient.itely
M Documentation/fr/notation/ancient.itely
Index: Documentation/de/notation/ancient.itely
diff --git a/Documentation/de/notation/ancient.itely
b/Documentation/de/notation/ancient.itely
index
813dcf4d5cbb421521efb7275a771dfd96feaa11..e96c96c2349cf92fa7ab23f7dceb17cfc4962a0e
100644
--- a/Documentation/de/notation/ancient.itely
+++ b/Documentation/de/notation/ancient.itely
@@ -2574,7 +2574,7 @@ Er bezeichnet die Position von @code{c}:
@lilypond[quote,relative=1,notime,verbatim]
\clef "kievan-do"
- \override NoteHead.style = #'kievan
+ \kievanOn
c
@end lilypond
@@ -2606,8 +2606,10 @@ Notenköpfe:
@lilypond[quote,fragment,ragged-right,verbatim]
\autoBeamOff
\cadenzaOn
-\override NoteHead.style = #'kievan
+\kievanOn
b'1 b'2 b'4 b'8 b'\breve b'\longa
+\kievanOff
+b'2
@end lilypond
@seealso
@@ -2641,7 +2643,6 @@ vor allem der Vollständigkeit halber eingesetzt.
@lilypond[quote,relative=1,notime,verbatim]
\clef "kievan-do"
-\override NoteHead.style = #'kievan
\override Accidental.glyph-name-alist =
#alteration-kievan-glyph-name-alist
bes' dis,
@@ -2663,19 +2664,18 @@ Notationsreferenz:
Eine dekorative Figur wird üblicherweise am Ende von eines
Musikstückes der Kiever Notation gesetzt, was man als Kiever
-Schlussstrich bezeichnen kann. Es wird gesetzt mit @code{\bar "kievan"}.
+Schlussstrich bezeichnen kann. Es wird gesetzt mit @code{\bar "k"}.
@lilypond[quote,relative=1,notime,verbatim]
\clef "kievan-do"
- \override NoteHead.style = #'kievan
- c \bar "kievan"
+ \clef "kievan-do"
+ c \bar "k"
@end lilypond
@seealso
@ref{Takte},
@ref{Die Feta-Schriftart}
-
@c Working with ancient music: scenarios and solutions:: {{{1
@node Musiksatz Alter Musik in der Praxis -- Szenarien und Lösungen
@subsection Musiksatz Alter Musik in der Praxis -- Szenarien und Lösungen
Index: Documentation/fr/notation/ancient.itely
diff --git a/Documentation/fr/notation/ancient.itely
b/Documentation/fr/notation/ancient.itely
index
ed7afd63cfc6377def1eb017f817c5c180e3cbed..e936981f3d938a79eca0c565531334123cd713ca
100644
--- a/Documentation/fr/notation/ancient.itely
+++ b/Documentation/fr/notation/ancient.itely
@@ -2479,7 +2479,7 @@ lancer dans la saisie de votre chant, comme
ci-dessous :
<<
\new KievanVoice = "melody" \relative c' {
\cadenzaOn
- c4 c c c c2 b,\longa
+ c4 c c c c2 b\longa
\bar "k"
}
\new Lyrics \lyricsto "melody" {
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fwd: OpenType support in Windows
I am offering a bounty of $100 for issue 1388, in particularly for an interface that allows one to access stylistic sets in OpenType fonts. http://code.google.com/p/lilypond/issues/detail?id=1388 Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Bounty offer on some outstanding Kievan issues
Hello list members, My current teaching schedule unfortunately means that I am not going to have time to work on LilyPond development in the near future. However, I am still interested in seeing outstanding issues with Kievan notation resolved, as I plan to use LilyPond in some upcoming projects. If anyone is interested in working on these issues, I am offering a bounty. Please take a look here: http://code.google.com/p/lilypond/issues/list?can=2&q=kievan Feel free to contact me off list should there be questions! Aleksandr ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Change \transpose to \relative in ancient.itely (issue 7538043)
On 2013/03/16 09:09:29, dak wrote: So many pitches are wrong in this patch that I think we should revert it and have it redone carefully. I do not have push access, so I cannot do much at this point. Can you revert it then? Possibly using some automatism (like Frescobaldi's absolute/relative conversions, making sure that one gets the starting pitch right). I've never used Frescobaldi, so I don't know much about this. As it stands, this just changes too much. Sorry, I should have checked the output more carefully. (Then again, Pál said above that the changes "didn't matter"). Anyway, if you want to revert this, that is OK with me. https://codereview.appspot.com/7538043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Change \transpose to \relative in ancient.itely (issue 7538043)
https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/7538043/diff/5001/Documentation/notation/ancient.itely#newcode952 Documentation/notation/ancient.itely:952: @c @end example On 2013/03/07 19:04:52, benko.pal wrote: please make the two examples above and below match Sorry, I am confused which examples you are referring to. The above example is commented out. Should we eliminate it completely? https://codereview.appspot.com/7538043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Change \transpose to \relative in ancient.itely (issue 7538043)
Reviewers: , Message: Please review Description: Change \transpose to \relative in ancient.itely Change \transpose c c' syntax to \relative c' syntax in examples in the ancient notation chapter of notation manual. Please review this at https://codereview.appspot.com/7538043/ Affected files: M Documentation/notation/ancient.itely ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Document Kievan ligature engraver (issue 7382060)
On 2013/02/27 09:24:07, Trevor Daniels wrote: On 2013/02/27 03:26:11, aleksandr.andreev wrote: > Looking at the sections on Mensural and Gregorian notations, it looks like the > \transpose c c' syntax is used quite often there. On the other hand, the > \relative syntax is used in the "scenarios and solutions" section. I don't mind > changing this example (as well as the example at the beginning of the Kievan > section), but perhaps we should then make all of the examples in the Ancient > notation chapter consistent? I think changing all the examples to \relative would be good, but I'm happy to leave this to a separate patch if you prefer. The Ancient section was not included in the push for consistency some years ago due to lack of interest/effort. But better late than never. Trevor I think it makes sense to push this patch first and then I will upload another patch that changes the syntax across the manual. That way it is cleaner in the commit history. There is also Issue 1287. I could try to work on improving the ancient notation chapter, though I am no expert in Gregorian chant. https://codereview.appspot.com/7382060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Document Kievan ligature engraver (issue 7382060)
On 2013/02/26 16:07:33, Trevor Daniels wrote:
One suggested change; otherwise LGTM.
Trevor
https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (right):
https://codereview.appspot.com/7382060/diff/1/Documentation/notation/ancient.itely#newcode2607
Documentation/notation/ancient.itely:2607: \new KievanVoice = "melody"
\transpose c c' {
I'd rather this be \relative c' rather than \transpose c c'
to be in keeping with the style in the rest of the manual.
Looking at the sections on Mensural and Gregorian notations, it looks
like the \transpose c c' syntax is used quite often there. On the other
hand, the \relative syntax is used in the "scenarios and solutions"
section. I don't mind changing this example (as well as the example at
the beginning of the Kievan section), but perhaps we should then make
all of the examples in the Ancient notation chapter consistent?
https://codereview.appspot.com/7382060/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Document Kievan ligature engraver (issue 7382060)
Reviewers: ,
Message:
Please review.
Description:
Document Kievan ligature engraver
Adds subsection about Kievan ligatures to ancient notation section of
notation manual.
Please review this at https://codereview.appspot.com/7382060/
Affected files:
M Documentation/notation/ancient.itely
Index: Documentation/notation/ancient.itely
diff --git a/Documentation/notation/ancient.itely
b/Documentation/notation/ancient.itely
index
6d122875f89150dab9d5c01540fa84b51b092ebd..0f3c9a7f70e7d4ea254b7cb3907aab785ca12c6d
100644
--- a/Documentation/notation/ancient.itely
+++ b/Documentation/notation/ancient.itely
@@ -2416,6 +2416,7 @@ with head prefixes in arbitrary order.
* Kievan notes::
* Kievan accidentals::
* Kievan bar line::
+* Kievan melismata::
@end menu
@node Kievan contexts
@@ -2569,6 +2570,63 @@ It can be invoked as @code{\bar "k"}.
@ref{Bars},
@ref{The Feta font}
+@node Kievan melismata
+@unnumberedsubsubsec Kievan melismata
+
+@cindex Ligatures
+
+Notes within a Kievan melisma are usually placed close to each other
+and the melismata separated by whitespace. This is done to allow
+the chanter to quickly identify the melodic structures of Znamenny
+chant. In LilyPond, melismata are treated as ligatures and the
+spacing is implemented by the @code{Kievan_ligature_engraver}.
+
+When the @code{KievanVoice} and @code{KievanStaff} contexts are used,
+the @code{Kievan_ligature_engraver} is enabled by default. In other
+contexts, it can be invoked by replacing the
@code{Ligature_bracket_engraver}
+with the @code{Kievan_ligature_engraver} in the layout block:
+
+@example
+\layout @{
+ \context @{
+\Voice
+\remove "Ligature_bracket_engraver"
+\consists "Kievan_ligature_engraver"
+ @}
+@}
+@end example
+
+The spacing between the notes within a Kievan ligature can be controlled
+by setting the @code{padding} property of the @code{KievanLigature}.
+
+The following example demonstrates the use of Kievan ligatures:
+
+@lilypond[quote,ragged-right,verbatim]
+\score {
+ <<
+\new KievanVoice = "melody" \transpose c c' {
+ \cadenzaOn
+ e2 \[ e4( d4 ) \] \[ c4( d e d ) \] e1 \bar "k"
+}
+\new Lyrics \lyricsto "melody" {
+ Га -- врі -- и -- лу
+}
+ >>
+}
+@end lilypond
+
+@seealso
+Music Glossary:
+@rglos{ligature}.
+
+Notation Reference:
+@ref{White mensural ligatures},
+@ref{Gregorian square neume ligatures},
+@ref{Ligatures}.
+
+@knownissues
+Horizontal spacing of ligatures is poor.
+
@node Working with ancient music---scenarios and solutions
@subsection Working with ancient music---scenarios and solutions
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Add Kievan ligature engraver (issue 7301097)
Reviewers: ,
Message:
Please review.
Description:
Add Kievan ligature engraver
Creates support for melismas ("ligatures") in Kievan notation via the
use of a ligature engraver.
Please review this at https://codereview.appspot.com/7301097/
Affected files:
M lily/coherent-ligature-engraver.cc
A + lily/include/kievan-ligature.hh
A lily/kievan-ligature-engraver.cc
A + lily/kievan-ligature.cc
M lily/ligature-engraver.cc
M ly/engraver-init.ly
M scm/define-grobs.scm
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: For those who need new features and bug fixes...
On Fri, Dec 21, 2012 at 7:01 AM, Kieren MacMillan wrote: > The big ones for me are: > > 1. The completion of Janek's GSoC work on Lyrics. +1!! Aleksandr ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py fromgoogle
I went into my git-cl directory and did a git pull -r Works fine for me now. Aleksandr On Sun, Dec 2, 2012 at 6:08 PM, Thomas Morley wrote: > 2012/12/2 Phil Holmes : >> - Original Message - From: "Graham Percival" >> >> To: "Phil Holmes" >> Cc: ; "David Kastrup" >> Sent: Sunday, December 02, 2012 8:55 PM >> >> Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py >> fromgoogle >> >> >>> On Sun, Dec 02, 2012 at 02:47:27PM -, Phil Holmes wrote: Graham - could you either give me access to git-cl or push this patch, please? >>> >>> >>> I've given Phil push access to git-cl. David, if you have a >>> github account I'll add you too. >>> >>> - Graham >> >> >> >> Thanks. I've now pushed the updates to the git-cl repo, so a pull should >> now provide a working git-cl. >> >> -- >> Phil Holmes > > Hi Phil, > > sorry, I still not have a working git-cl on LilyDev. > > harm@harm-laptop ~/lilypond-git (dev/local_working)$ git pull -r > > seems to be wrong, but whatelse should I do? > > > -Harm > > ___ > lilypond-devel mailing list > lilypond-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Changes to Kievan documentation (issue 6865049)
Please review. https://codereview.appspot.com/6865049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
git-cl error message
Hello list,
I am getting the following message when I try to run git cl upload
origin/master:
Traceback (most recent call last):
File "/usr/bin/git-cl", line 888, in
sys.exit(main(sys.argv))
File "/usr/bin/git-cl", line 882, in main
return func(argv[2:])
File "/usr/bin/git-cl", line 607, in CmdUpload
issue, patchset = upload.RealMain(['upload'] + upload_args + args)
File "/home/sasha/git-cl/upload.py", line 1467, in RealMain
response_body = rpc_server.Send("/upload", body, content_type=ctype)
File "/home/sasha/git-cl/upload.py", line 342, in Send
f = self.opener.open(req)
File "/usr/lib/python2.7/urllib2.py", line 407, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 520, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 445, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 379, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 528, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 301: Moved Permanently
Is there something wrong with my setup or is this a network issue?
Aleksandr
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various clean-ups in stems and beams. (issue 6584045)
On 2012/11/07 07:52:33, mike7 wrote:
On 7 nov. 2012, at 09:50, mailto:d...@gnu.org wrote:
> On 2012/11/07 05:32:40, mike7 wrote:
>> On 7 nov. 2012, at 00:50, mailto:d...@gnu.org wrote:
>
>> >
>> >
>
>
http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108
>> >> > input/regression/note-head-style.ly:108: \override
> Staff.Dots.style
>> > =
>> >> > #'kievan
>> >> > Why can't we use the new function here, e.g.,
>> >> >
>> >> > \kievanOn
>> >> >
>> >
>> >> \kievenOn only works on the voice level and the overrides happen
on
>> > the staff
>> >> level.
>> >
>> > How about making \pattern a music function taking a context
>> > modification as argument? Then you could write
>> >
>> > \pattern \with { \override NoteHead.style = #'slash }
>> > \pattern \with { \kievanOn }
>> > \pattern \with { ... }
>> >
>> > and just pass the context mod on to the \new Voice within
\pattern.
>> >
>> > It seems awkward to use Staff-wide overrides here.
>> >
>> > By the way: it's frightening how fast one gets used to the new
>> > override syntax. I had to think really hard about whether this
was
>> > supposed to be different previously or not. And then it seems
> strange
>> > that there would have been no dot.
>> >
>
>> I'm not exactly sure how this'd be done - if it's OK w/ you, I'll
push
> the patch
>> after a countdown and then you can propose a followup patch. Sorry
-
> I have
>> been out of the loop for a bit and am not up-to-date on the most
> recent syntax
>> modifications.
>
> There are no really new syntax modifications required. The problem
with
> the "OK w/ you" part is that it is simply wrong _not_ to use the
> \kievanOn function in this regtest and instead copy and modify its
> contents. That way, the regtests ceases to test \kievanOn and
depends
> on its internals not changing.
>
> I'll put up a git-format patch on the Google issue tracker as
Rietveld
> does not appear to take attachments.
>
Excellent - I'll copy and paste whatever you come up with into my
patch. Thanks
for taking the time to do this.
Cheers,
MS
LGTM.
http://codereview.appspot.com/6584045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various clean-ups in stems and beams. (issue 6584045)
http://codereview.appspot.com/6584045/diff/13015/input/regression/kievan-notation.ly File input/regression/kievan-notation.ly (right): http://codereview.appspot.com/6584045/diff/13015/input/regression/kievan-notation.ly#newcode13 input/regression/kievan-notation.ly:13: \bar "kievan" This needs to be: \bar "k" given the changes made by issue 2790. http://codereview.appspot.com/6584045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various clean-ups in stems and beams. (issue 6584045)
http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly File input/regression/kievan-notation.ly (right): http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly#newcode13 input/regression/kievan-notation.ly:13: \bar "kievan" Sorry, I missed one more thing. Evidently, after 2790, this line should now be: \bar "k" http://codereview.appspot.com/6584045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various clean-ups in stems and beams. (issue 6584045)
On 2012/11/03 18:21:09, mike7 wrote: On 3 nov. 2012, at 12:26, mailto:d...@gnu.org wrote: > http://codereview.appspot.com/6584045/diff/1/scm/output-lib.scm#newcode85 > scm/output-lib.scm:85: (left-height (if (= direction DOWN) > Is direction sure to be non-null? > Thanks again for the review. Aleksandr can respond to this better than I can. Cheers, MS Sorry for the delay in responding -- weekends are always very busy for me. The default direction is set to DOWN in Beam::calc_direction, starting on line 291. http://codereview.appspot.com/6584045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various clean-ups in stems and beams. (issue 6584045)
http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly File input/regression/kievan-notation.ly (right): http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly#newcode12 input/regression/kievan-notation.ly:12: c4 c4 c8 [ d8 ] c4 c2 b,\longa We should add an unbeamed eighth note to the regtest, since its correct appearance is now controlled by note-head::calc-kievan-duration-log Maybe something like c4 c8 c8[ d8] c4 c2 b,\longa http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly File input/regression/note-head-style.ly (right): http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108 input/regression/note-head-style.ly:108: \override Staff.Dots.style = #'kievan Why can't we use the new function here, e.g., \kievanOn http://codereview.appspot.com/6584045/diff/13014/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/6584045/diff/13014/ly/engraver-init.ly#newcode1150 ly/engraver-init.ly:1150: \override Stem.length = #0.0 It seems like we also need something like: \override Flag.stencil = ##f Otherwise "flags" appear on Kievan eighth notes. http://codereview.appspot.com/6584045/diff/13014/ly/property-init.ly File ly/property-init.ly (right): http://codereview.appspot.com/6584045/diff/13014/ly/property-init.ly#newcode310 ly/property-init.ly:310: \override Stem.length = #0.0 Also need here: \override Flag.stencil = ##f http://codereview.appspot.com/6584045/diff/13014/ly/property-init.ly#newcode323 ly/property-init.ly:323: \revert Stem.length And here: \revert Flag.stencil http://codereview.appspot.com/6584045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix extra spacing in Kievan notation (issue 6684051)
On 2012/10/16 08:14:17, benko.pal wrote: > The presence of a long syllable in the lyrics makes the left_col->extent > larger than spring.min_distance(). Manipulating the SpacingSpanner > properties has no effect -- the extraneous space is still there. long syllables are a general problem, see Janek's GSoC list, it shouldn't be solved this way. p The GSoC issues do not deal with packed spacing, so this is somewhat different, though related. Do you have any ideas for how this issue could be addressed differently? Has there been any work on the various GSoC issues? http://codereview.appspot.com/6684051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix extra spacing in Kievan notation (issue 6684051)
On 2012/10/15 20:00:28, benko.pal wrote: I don't like that: the patch manipulates a staff based on note head. it also increments a hack. have you tried something like \override SpacingSpanner #'shortest-duration-space = #0 \override SpacingSpanner #'spacing-increment = #0 ? The presence of a long syllable in the lyrics makes the left_col->extent larger than spring.min_distance(). Manipulating the SpacingSpanner properties has no effect -- the extraneous space is still there. http://codereview.appspot.com/6684051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix extra spacing in Kievan notation (issue 6684051)
Reviewers: ,
Message:
Please review.
Description:
Fix extra spacing in Kievan notation
In Kievan notation, notes should be spaced as tightly as possible within
melismas.
This patch fixes extra spacing caused by long syllables.
Issue 2631.
Please review this at http://codereview.appspot.com/6684051/
Affected files:
M lily/include/paper-column.hh
M lily/paper-column.cc
M lily/spacing-spanner.cc
Index: lily/include/paper-column.hh
diff --git a/lily/include/paper-column.hh b/lily/include/paper-column.hh
index
01a84d50dfd9a7085dfb7bbb1d13059e208ba507..f4bccf391f3ec2e6d32135ef20ee08a3224a7914
100644
--- a/lily/include/paper-column.hh
+++ b/lily/include/paper-column.hh
@@ -57,6 +57,7 @@ public:
static bool is_used (Grob *);
static bool is_breakable (Grob *);
static bool is_extraneous_column_from_ligature (Grob *);
+ static bool is_kievan (Grob *);
static Real minimum_distance (Grob *l, Grob *r);
static Interval break_align_width (Grob *me, SCM align_sym);
};
Index: lily/paper-column.cc
diff --git a/lily/paper-column.cc b/lily/paper-column.cc
index
78f2786ef89b34f41cefcb63cc8d8e4c352a9bbf..ff6c0292204586770534e1a0f8d542bd1ea77f37
100644
--- a/lily/paper-column.cc
+++ b/lily/paper-column.cc
@@ -381,6 +381,21 @@ Paper_column::is_extraneous_column_from_ligature (Grob
*me)
return has_notehead;
}
+bool
+Paper_column::is_kievan (Grob *me)
+{
+ if (!is_musical (me))
+return false;
+
+ extract_grob_set (me, "elements", elts);
+ for (vsize i = 0; i < elts.size (); i++)
+{
+ if (elts[i]->get_property ("style") == ly_symbol2scm ("kievan"))
+return true;
+}
+ return false;
+}
+
ADD_INTERFACE (Paper_column,
"@code{Paper_column} objects form the top-most
X@tie{}parents"
" for items. There are two types of columns: musical and"
Index: lily/spacing-spanner.cc
diff --git a/lily/spacing-spanner.cc b/lily/spacing-spanner.cc
index
022c6a121949543fa05c7fd4b4fba680aa8b1fea..d77a90a4ac449d0678e085d022c336f2d9c4ee41
100644
--- a/lily/spacing-spanner.cc
+++ b/lily/spacing-spanner.cc
@@ -425,7 +425,8 @@ Spacing_spanner::musical_column_spacing (Grob *me,
the left-hand column is "genuine". This is a dirty hack and it
should be fixed in the ligature-engravers. --jneem
*/
- if (Paper_column::is_extraneous_column_from_ligature (left_col))
+ if (Paper_column::is_extraneous_column_from_ligature (left_col) ||
+ Paper_column::is_kievan (left_col))
spring.set_distance (spring.min_distance ());
else
spring.set_distance (max (left_col->extent (left_col,
X_AXIS)[RIGHT],
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various clean-ups in stems and beams. (issue 6584045)
On 2012/10/02 14:56:28, mike7 wrote:
On 2 oct. 2012, at 16:42, mailto:aleksandr.andr...@gmail.com wrote:
> What I mean is that if something like
>
> {
> \override NoteHead #'style = #'kievan
> c'8
> }
>
> produces a quarter note in the output, the user is likely to be
> thoroughly confused.
Is this because of the duration-log override?
Yes.
NoteHead #'duration-log for
Kievan notation should be a separate function that is not based on
style (this
is what I propose in my patch).
Then it has to be set with an override whenever the style is set to
kievan.
Why can't we have commands \startKievan and \stopKievan that do all
the
overrides simultaneously?
I think that would work.
For example, the command \hideNotes groups together several overrides.
I think
it would be a mistake to make \override NoteHead #'transparent also
control Dots
and Stems by default.
Sure. The trouble is that Stems don't make much sense when NoteHead
style is set to kievan and warnings are produced with beams. Of course,
we could rewrite the way that is handled in stem::is_normal_stem, but
that would take some thought.
It's better to have a global command that groups together
all these overrides.
Definitely.
I think it's important to keep properties as separate as possible.
For example,
take the command arpeggioParenthesisDashed. In theory, we could make
it such
that arpeggio has a style property that'd set all these things, but
it's better
to keep them as separate overrides to various parameters. Same for
easyHeadsOn,
improvisationOn, and tabFullNotation. A command like \startKievan or
\kievanOn
or whatever should work like this.
I agree, but see the above comment about Stems not being normal.
http://codereview.appspot.com/6584045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various clean-ups in stems and beams. (issue 6584045)
On 2012/10/02 07:28:10, J_lowe wrote:
If you are talking about the Documentation in the Notation Reference,
the
Ancient Notation doesn't follow (mostly) the standard Policies at all
- indeed
there is a while tracker to tidy this section up, I started but I
don't have any
knowlegde of Ancient Notation to make distinctions between the
different types.
So I wouldn't worry about that. If examples need a specific context
include in
the @lilypond examples then so be it. I don't think that that is a
huge deal.
What I mean is that if something like
{
\override NoteHead #'style = #'kievan
c'8
}
produces a quarter note in the output, the user is likely to be
thoroughly confused.
If NoteHead and Stem properties are set up in engraver-init.ly, then if
the user wants a Kievan NoteHead somewhere other than in a KievanVoice
context, he will need to set up other overrides in addition to NoteHead
style.
This is different from other ancient notations in the sense that if I
do, e.g.,
{
\override NoteHead #'style = #'mensural
}
things work as expected. Of course, Mensural notation is simpler in the
sense that it lacks beams and specialized eighth heads.
I think it would be best if setting NoteHead style to Kievan would set
the necessary duration-log and Stem properties, but I am not sure how
that would be implemented given the clean-ups that Mike is proposing
with this patch.
https://codereview.appspot.com/6584045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various clean-ups in stems and beams. (issue 6584045)
On 2012/10/01 23:34:39, MikeSol wrote:
I think a user should be able to use Kievan notation and normal
stems/flags/beams if she so chooses. I'll define something like
[snip]
and then use it in the documentation.
I still see some issues with this. As written now in stem.cc, when the
style property of NoteHead is set to kievan, the stems are not "normal".
In this case, it is not clear what Kievan notation with "normal
stems/flags/beams" would look like. At best, there would be no stems and
beams flat across the center of the staff. Or, something like
\relative c' {
\override NoteHead #'style = #'kievan
a'8[ bes]
}
gives the warning "weird stem size, check for narrow beams".
Also, because the calculation of the duration log moves to
note-head::calc-kievan-duration-log, something like
\relative c' {
\override NoteHead #'style = #'kievan
a'8
}
produces the wrong NoteHead stencil (a quarter note instead of an eighth
note).
If we implement the patch as written, Kievan note heads outside of the
KievanVoice context wouldn't make sense. I'm not altogether opposed to
that (I see no real reason to not use KievanVoice), but it seems like a
"policy" issue, as it would make Kievan notation different from how
other ancient notations are handled.
https://codereview.appspot.com/6584045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Various clean-ups in stems and beams. (issue 6584045)
http://codereview.appspot.com/6584045/diff/2001/ly/engraver-init.ly
File ly/engraver-init.ly (right):
http://codereview.appspot.com/6584045/diff/2001/ly/engraver-init.ly#newcode1150
ly/engraver-init.ly:1150: \override Beam #'positions =
#beam::get-kievan-positions
The only issue with putting this here is that if the user enters Kievan
notes without using the default KievanVoice context, the properties
don't get initialized. For example, this no longer works:
\relative c' {
\override NoteHead #'style = #'kievan
e8 [ g]
a[ bes]
}
Either we have to initialize these properties when the style property of
the NoteHead is set to kievan or we have to change the documentation to
indicate that Kievan notation can only be used with the default
contexts. The latter option would require changing the snippets in the
documentation, among other things.
http://codereview.appspot.com/6584045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix vertical position of Kievan dots (issue 6570047)
Reviewers: ,
Message:
Please review.
Description:
Fix vertical position of Kievan dots
Dots in Kievan notation should be placed at the same Y_AXIS position as
the note, even if they occur on a line.
Issue 2857.
Please review this at http://codereview.appspot.com/6570047/
Affected files:
M lily/dot-column.cc
Index: lily/dot-column.cc
diff --git a/lily/dot-column.cc b/lily/dot-column.cc
index
1aa0b728c0657618f6839be6818691cee898848a..6cba432639deb7f8fd899a53a577987253787762
100644
--- a/lily/dot-column.cc
+++ b/lily/dot-column.cc
@@ -187,7 +187,8 @@ Dot_column::calc_positioning_done (SCM smob)
cfg.remove_collision (p);
cfg[p] = dp;
- if (Staff_symbol_referencer::on_line (dp.dot_, p))
+ if (Staff_symbol_referencer::on_line (dp.dot_, p) &&
+ dp.dot_->get_property ("style") != ly_symbol2scm ("kievan"))
cfg.remove_collision (p);
}
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix for beaming in Kievan notation (issue 6305080)
Please review. http://codereview.appspot.com/6305080/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add support for Cyrillic in texinfo. (issue 6459081)
On 2012/08/13 19:17:28, lemzwerg wrote: It would be nice if a Russian speaking person could fix the Cyrillic index entries. However, since we don't have Cyrillic characters in the index, this is not an urgent issue (and maybe we never need this). Could you explain what you mean by "fix the Cyrillic index"? Perhaps I can help with this. http://codereview.appspot.com/6459081/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix for beaming in Kievan notation (issue 6305080)
On 2012/08/07 18:19:14, dak wrote: http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc#newcode636 lily/beam.cc:636: extract_grob_set (stems[0], "note-heads", heads); This looks like the wrong place to do this calculation. You overwrite what has been put into quantized-positions here. It looks like you should rather move the calculation to the place where quantized-positions is initialized, Agreed. However, I cannot figure out where the appropriate place for these calculations should be. http://codereview.appspot.com/6305080/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix for beaming in Kievan notation (issue 6305080)
This is definitely not an elegant approach to the problem at all (and it does not solve the issue of the warning being given out at stem.cc line 128), but it's the best I can figure out after hacking at the code for a while. Perhaps reviewers more familiar with LilyPond internals can provide some comments for improvement. http://codereview.appspot.com/6305080/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: building master / fixed all Critical?
On Sun, Jul 1, 2012 at 6:29 PM, Graham Percival wrote: > I'm not certain where we stand. Over the weekend, some patches > were pushed (by accident?) to master. One (or more?) of those > commits broke compiling, and were reverted. This fix was (or will I was just able to make doc from scratch without any problems. Aleksandr ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Add blurb about Kievan notation to changes (issue 6326056)
Reviewers: ,
Message:
Please review.
Description:
Add blurb about Kievan notation to changes
Adds a blurb and minimal example to changes.tely indicating support of
Kievan notation.
Please review this at http://codereview.appspot.com/6326056/
Affected files:
M Documentation/changes.tely
Index: Documentation/changes.tely
diff --git a/Documentation/changes.tely b/Documentation/changes.tely
index
e1c05e52c8befbc4c9cf4c9068c71af828995596..6545c1dd69c8de8ce1ce80753cfb22b054a1449b
100644
--- a/Documentation/changes.tely
+++ b/Documentation/changes.tely
@@ -60,6 +60,15 @@ which scares away people.
* only show user-visible changes.
@end ignore
+@item
+Support for Kievan square notation:
+@lilypond[quote,relative=1,verbatim]
+\new KievanVoice {
+ \cadenzaOn
+ c d e f g a bes
+ \bar "kievan"
+}
+@end lilypond
@item
Augmentation dots now avoid the other voice in two-voice polyphony
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Removing 'fragment' from ancient.itely (issue 6335049)
Reviewers: ,
Message:
Please review.
Description:
Removing 'fragment' from ancient.itely
Issue 2619.
Please review this at http://codereview.appspot.com/6335049/
Affected files:
M Documentation/notation/ancient.itely
Index: Documentation/notation/ancient.itely
diff --git a/Documentation/notation/ancient.itely
b/Documentation/notation/ancient.itely
index
0f42583de8b6ba33af3c55b6be5b5a892330b569..1348e2761a750dffe4063bc073b95379859b16fb
100644
--- a/Documentation/notation/ancient.itely
+++ b/Documentation/notation/ancient.itely
@@ -445,7 +445,7 @@ mensural C clef
@code{mensural-c1}, @code{mensural-c2},@*
@code{mensural-c3}, @code{mensural-c4}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\clef "mensural-c2"
\override NoteHead #'style = #'mensural
c
@@ -456,7 +456,7 @@ mensural F clef
@tab
@code{mensural-f}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\clef "mensural-f"
\override NoteHead #'style = #'mensural
c
@@ -467,7 +467,7 @@ mensural G clef
@tab
@code{mensural-g}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\clef "mensural-g"
\override NoteHead #'style = #'mensural
c
@@ -479,7 +479,7 @@ neomensural C clef
@code{neomensural-c1}, @code{neomensural-c2},@*
@code{neomensural-c3}, @code{neomensural-c4}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\clef "neomensural-c2" c
@end lilypond
@@ -491,7 +491,7 @@ petrucci style C clefs, for use on different staff lines
@code{petrucci-c3}, @code{petrucci-c4},@*
@code{petrucci-c5}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\clef "petrucci-c2"
\override NoteHead #'style = #'mensural
c
@@ -504,7 +504,7 @@ petrucci style F clefs, for use on different staff lines
@code{petrucci-f3}, @code{petrucci-f4},@*
@code{petrucci-f5}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\clef "petrucci-f3"
\override NoteHead #'style = #'mensural
c
@@ -515,7 +515,7 @@ petrucci style G clef
@tab
@code{petrucci-g}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\clef "petrucci-g"
\override NoteHead #'style = #'mensural
c
@@ -596,7 +596,7 @@ to select ancient time signatures. Supported styles are
@code{neomensural} style. The following examples show the
differences in style:
-@lilypond[ragged-right,fragment,relative=1,quote]
+@lilypond[ragged-right,relative=1,quote]
{
\textLengthOn
@@ -871,7 +871,7 @@ switched on by setting @code{suggestAccidentals} to
true.
@funindex suggestAccidentals
-@lilypond[verbatim,fragment,relative=1]
+@lilypond[verbatim,relative=1]
fis gis
\set suggestAccidentals = ##t
ais bis
@@ -1107,7 +1107,7 @@ Editio Vaticana style do clef
@code{vaticana-do1}, @code{vaticana-do2},@*
@code{vaticana-do3}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\override Staff.StaffSymbol #'line-count = #4
\override Staff.StaffSymbol #'color = #red
\override Staff.LedgerLineSpanner #'color = #red
@@ -1123,7 +1123,7 @@ Editio Vaticana style fa clef
@tab
@code{vaticana-fa1}, @code{vaticana-fa2}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\override Staff.StaffSymbol #'line-count = #4
\override Staff.StaffSymbol #'color = #red
\override Staff.LedgerLineSpanner #'color = #red
@@ -1140,7 +1140,7 @@ Editio Medicaea style do clef
@code{medicaea-do1}, @code{medicaea-do2},@*
@code{medicaea-do3}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\override Staff.StaffSymbol #'line-count = #4
\override Staff.StaffSymbol #'color = #red
\override Staff.LedgerLineSpanner #'color = #red
@@ -1156,7 +1156,7 @@ Editio Medicaea style fa clef
@tab
@code{medicaea-fa1}, @code{medicaea-fa2}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\override Staff.StaffSymbol #'line-count = #4
\override Staff.StaffSymbol #'color = #red
\override Staff.LedgerLineSpanner #'color = #red
@@ -1173,7 +1173,7 @@ hufnagel style do clef
@code{hufnagel-do1}, @code{hufnagel-do2},@*
@code{hufnagel-do3}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\override Staff.StaffSymbol #'line-count = #4
\override Staff.StaffSymbol #'color = #red
\override Staff.LedgerLineSpanner #'color = #red
@@ -1189,7 +1189,7 @@ hufnagel style fa clef
@tab
@code{hufnagel-fa1}, @code{hufnagel-fa2}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\override Staff.StaffSymbol #'line-count = #4
\override Staff.StaffSymbol #'color = #red
\override Staff.LedgerLineSpanner #'color = #red
@@ -1205,7 +1205,7 @@ hufnagel style combined do/fa clef
@tab
@code{hufnagel-do-fa}
@tab
-@lilypond[fragment,relative=1,notime]
+@lilypond[relative=1,notime]
\override Staff.StaffSymbol #'color = #red
\override Staff.LedgerLineSpanner #'col
Re: Documentation of Kievan notation (issue 6303095)
On 2012/06/23 05:37:05, janek wrote: pushed as a10311ff02578de9f979dc6ad83ba9535f8e4e4c. Aleksandr, please close this Rietveld issue. thanks! Janek, I was going to have the removal of 'fragment' reviewed in this issue, per Trevor's recommendation. Or shall I open a separate issue for that? http://codereview.appspot.com/6303095/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Documentation of Kievan notation (issue 6303095)
Per comments by Graham and Trevor, I have removed 'fragment' throughout ancient.itely where 'relative' is also used. http://codereview.appspot.com/6303095/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Documentation of Kievan notation (issue 6303095)
http://codereview.appspot.com/6303095/diff/4/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): http://codereview.appspot.com/6303095/diff/4/Documentation/notation/ancient.itely#newcode2530 Documentation/notation/ancient.itely:2530: @lilypond[quote,fragment,relative=1,notime,verbatim] On 2012/06/20 02:35:23, Graham Percival wrote: IIRC [fragment] has no meaning if there's also a [relative=1] in there. It seems to be used that way throughout the ancient.itely file. However, if someone can confirm that it's not necessary, I'd be happy to fix it throughout the file as part of this patch. http://codereview.appspot.com/6303095/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Documentation of Kievan notation (issue 6303095)
Updated patch based on comments by Janek and Trevor.
http://codereview.appspot.com/6303095/diff/1/Documentation/music-glossary.tely
File Documentation/music-glossary.tely (right):
http://codereview.appspot.com/6303095/diff/1/Documentation/music-glossary.tely#newcode4539
Documentation/music-glossary.tely:4539: jurisdictions of Orthodoxy and
Byzantine-rite Catholicism. It is
On 2012/06/18 07:41:55, janek wrote:
There should be two spaces after period that closes sentence (here and
in some
places in the second file).
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (right):
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode41
Documentation/notation/ancient.itely:41: Gregorian notation.
On 2012/06/18 08:06:15, Trevor Daniels wrote:
"... contexts for these styles." maybe.
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2431
Documentation/notation/ancient.itely:2431: as the following excerpt
demonstrates:
On 2012/06/18 08:06:15, Trevor Daniels wrote:
Stop after the comma, and change that to a colon.
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2464
Documentation/notation/ancient.itely:2464: There is only one clef used
in Kievan notation (the Tse-fa-ut Clef). It is used to indicate the
position of @code{c}, as in the following example:
On 2012/06/18 08:06:15, Trevor Daniels wrote:
Stop after the comma, and change that to a colon.
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2537
Documentation/notation/ancient.itely:2537: @end lilypond
On 2012/06/18 08:06:15, Trevor Daniels wrote:
Rather than displaying the glyphs (which already appear in Appendix 8
and should
be referenced there) it would be better to move the following para
about
accidental style before this one and then show the use of accidentals
in context
in a bar of music.
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2566
Documentation/notation/ancient.itely:2566: @end lilypond
On 2012/06/18 08:06:15, Trevor Daniels wrote:
Could this example include a bar of music to show how the two fit
together?
Maybe the last two examples should be merged? I'm not sure the Kievan
bar line deserves a subsection all to itself. What do you think?
http://codereview.appspot.com/6303095/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Documentation of Kievan notation (issue 6303095)
Reviewers: , Message: Please review. Description: Documentation of Kievan notation Adds a subsection to the Ancient notation section of the Notation reference documenting support of Kievan square notation. Issue 2317. Please review this at http://codereview.appspot.com/6303095/ Affected files: M Documentation/music-glossary.tely M Documentation/notation/ancient.itely ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix for beaming in Kievan notation (issue 6305080)
On 2012/06/11 00:49:42, Keith wrote: looks good to me. The question I have now is how to affect the position of the beam. It needs to attach toward the bottom of the "stem" and not at center of the staff. http://codereview.appspot.com/6305080/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix for beaming in Kievan notation (issue 6305080)
Reviewers: ,
Message:
A first attempt at fixing issue 2492.
This fixes the note heads for beamed kievan notes, also getting rid of
the warning messages.
Description:
Fix for beaming in Kievan notation
Implementing correct beaming functionality in Kievan notation
Fix for Issue 2492
Please review this at http://codereview.appspot.com/6305080/
Affected files:
M lily/note-head.cc
M ly/engraver-init.ly
Index: lily/note-head.cc
diff --git a/lily/note-head.cc b/lily/note-head.cc
index
fb93e40eeb82f02574c2fa670183d19054214fd6..287b10dc043a42ce8ebe613422a8c51fe916874b
100644
--- a/lily/note-head.cc
+++ b/lily/note-head.cc
@@ -80,6 +80,15 @@ internal_print (Grob *me, string *font_char)
}
}
+ if (style == "kievan"
+ && 3 == robust_scm2int (me->get_property ("duration-log"), 2))
+{
+ Grob *stem = unsmob_grob (me->get_object ("stem"));
+ Grob *beam = unsmob_grob (stem->get_object ("beam"));
+ if (beam)
+out = fm->find_by_name (idx_either + "2kievan");
+}
+
idx_either += suffix;
if (out.is_empty ())
{
Index: ly/engraver-init.ly
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index
9bb731883cba5d9754fdc7c2030508b49bde06f4..b4a7008b8d4c1f7338557f4f0b0448285bb0b417
100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -1146,8 +1146,6 @@ accommodated for typesetting a piece in Kievan style."
%% There are beams in Kievan notation, but they are invoked manually
autoBeaming = ##f
- \override Beam #'beam-thickness = #0.32
- \override Beam #'length-fraction = #0.62
}
\context {
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Different notehead if beaming used
Hello list, After a hiatus related to the end of the semester here, I figured I'd take a stab at solving this issue: http://code.google.com/p/lilypond/issues/detail?id=2492 The problem is that a different note head needs to appear for the Kievan eighth note if the note is beamed. (In Kievan notation, only two notes would be beamed. You would never have more than two notes beamed together). Related to this is the fact that since stems are not used, the beam engraver evidently cannot figure out the correct placement of the beam. A set of warnings is also returned. Perhaps this could be solved by making stems invisible instead of turning them off completely? With regard to the note head, the approach I am thinking of taking is to add two additional glyphs, which would be used for an eighth note that is beamed (an "up" glyph and a "down" glyph.) These glyphs would be identical to the glyphs for the quarter note. My question is this: is it possible to determine, from note-head.cc, whether the note head will be beamed? Then the selection could be done much in the same way as the selection based on staff position. Any guidance is always appreciated! Aleksandr ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix MIDI output for Kievan (issue 6193043)
On 2012/05/05 16:58:22, benko.pal wrote: thank you very much! please add Beam_performer too to ensure consistency with Voice (may be needed when doing ancient and modern edition from a common source). Added Beam_performer for Vaticana and Mensural based on this comment. http://codereview.appspot.com/6193043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix MIDI output for Kievan (issue 6193043)
On 2012/05/04 19:33:06, benko.pal wrote: would you fix Vaticana and Mensural too? I've uploaded a patch that gets at Vaticana and Mensural as well. It seems that "Beam_performer" would not be necessary for the two, but I don't know about "Tie_performer" and "Slur_performer". It would probably be good for someone who knows more than me about Gregorian chant to double check that it works right. In addition to 2512, I think this addresses 2004. http://codereview.appspot.com/6193043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix MIDI output for Kievan (issue 6193043)
On 2012/05/04 15:34:17, dak wrote: Aliases are only relevant for properties, I think. The initial values get inherited, and any use of context property setting commands in the music or context mods will accept changes for Voice into this context. But translators are independent. Sorry, I'm a little green. Does this mean I need to change something in this patch? http://codereview.appspot.com/6193043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix MIDI output for Kievan (issue 6193043)
For whatever reason, \alias Staff and \alias Voice do not bring in the
performers. If I comment out the line \consists "Note_performer", I get
no notes in the MIDI file, only the appropriate number of rests.
I think this is also why Vaticana does not appear to work properly with
MIDI. Try this example:
\include "gregorian.ly"
\score {
<<
\new VaticanaVoice = "cantus" {
c' d' e'
}
\new Lyrics \lyricsto "cantus" {
ut re mi
}
>>
\midi { }
}
On 2012/05/04 02:59:06, Carl wrote:
Looks like it works, but I think it can (and should) be simplified.
If it
can't, then LGTM.
http://codereview.appspot.com/6193043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix MIDI output for Kievan (issue 6193043)
Reviewers: ,
Message:
Here is a patch that attempts to fix issues with MIDI playback of Kievan
notation.
Description:
Fix MIDI output for Kievan
Adding KievanStaff and KievanVoice for MIDI output of Kievan notation.
Please review this at http://codereview.appspot.com/6193043/
Affected files:
M ly/performer-init.ly
Index: ly/performer-init.ly
diff --git a/ly/performer-init.ly b/ly/performer-init.ly
index
0ad1e2964ee9cab5e4b7b7f030b00f1fed8ffd71..1b60a6393dfba16cfa847f1007f6c496e2523b9d
100644
--- a/ly/performer-init.ly
+++ b/ly/performer-init.ly
@@ -31,6 +31,7 @@
\consists "Staff_performer"
\consists "Key_performer"
}
+
\context {
\name Global
\accepts Score
@@ -39,6 +40,17 @@
}
\context {
+ \type "Performer_group"
+ \name KievanStaff
+ \denies Voice
+ \accepts KievanVoice
+ \defaultchild KievanVoice
+ \alias Staff
+ \consists "Staff_performer"
+ \consists "Key_performer"
+}
+
+\context {
\Staff
\name DrumStaff
midiInstrument = #"drums"
@@ -70,6 +82,17 @@
}
\context {
+ \type "Performer_group"
+ \name KievanVoice
+ \alias Voice
+ \consists "Dynamic_performer"
+ \consists "Tie_performer"
+ \consists "Note_performer"
+ \consists "Beam_performer"
+ \consists "Slur_performer"
+}
+
+\context {
\Voice
\remove "Note_performer"
\consists "Drum_note_performer"
@@ -157,6 +180,7 @@
\accepts FretBoards
\accepts Lyrics
\accepts VaticanaStaff
+ \accepts KievanStaff
\consists "Time_signature_performer"
\consists "Control_track_performer"
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: MIDI with ancient notation
Upon further investigation, I believe this is related to this issue:
http://code.google.com/p/lilypond/issues/detail?id=2004
Aleksandr
On Wed, May 2, 2012 at 1:39 PM, Aleksandr Andreev
wrote:
> Hello folks,
>
> I've been experimenting with what is supported so far for Kievan
> notation, and I've run in to some problems generating MIDI output. I
> get the following messages at compile time if I add a \midi block:
>
> warning: cannot find or create new `KievanStaff'
> warning: cannot find or create new `KievanVoice'
> warning: cannot find or create `Timing' called `'
>
> Looking at performer-init.ly, I see that VaticanaStaff and
> VaticanaVoice have their own Context blocks so that makes me think
> that KievanStaff and KievanVoice should be implemented similarly.
>
> However, if I typeset some Gregorian chant, as in:
>
> \include "gregorian.ly"
> \score {
> \new VaticanaStaff
> <<
> \new VaticanaVoice {
> \[ c'\melisma a \]
> }
> >>
> \midi { }
> \layout { }
> }
>
> I get no MIDI output -- the resulting MIDI file appears to consist of
> a few seconds of rests.
>
> There's probably something I'm not doing right.
>
> Also, I couldn't find anything about MIDI output with ancient music in
> the documentation.
>
> Help much appreciated as always!
>
> Aleksandr
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Recap of my meeting w/ Janek
> He plans to tackle 2451, 2452, and 2453 first via a parsing of pango strings > to find word prefixes and suffixes and do alignment from where these lie. Quick question: will languages that do not use Latin characters be considered? For example, 2452 is also a problem when working with Slavic languages written in Cyrillic. Aleksandr ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
MIDI with ancient notation
Hello folks,
I've been experimenting with what is supported so far for Kievan
notation, and I've run in to some problems generating MIDI output. I
get the following messages at compile time if I add a \midi block:
warning: cannot find or create new `KievanStaff'
warning: cannot find or create new `KievanVoice'
warning: cannot find or create `Timing' called `'
Looking at performer-init.ly, I see that VaticanaStaff and
VaticanaVoice have their own Context blocks so that makes me think
that KievanStaff and KievanVoice should be implemented similarly.
However, if I typeset some Gregorian chant, as in:
\include "gregorian.ly"
\score {
\new VaticanaStaff
<<
\new VaticanaVoice {
\[ c'\melisma a \]
}
>>
\midi { }
\layout { }
}
I get no MIDI output -- the resulting MIDI file appears to consist of
a few seconds of rests.
There's probably something I'm not doing right.
Also, I couldn't find anything about MIDI output with ancient music in
the documentation.
Help much appreciated as always!
Aleksandr
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fixing height of Kievan bar line (issue 5727051)
Resolved issue with the gray line appearing. I also added layer support, thanks to a comment by Trevor Daniels. Looks like the Kievan bar line is properly supported now. http://codereview.appspot.com/5727051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fixing height of Kievan bar line
> Thanks. That seems to be a good approach. I've uploaded
> a new patch. The results are here:
> http://code.google.com/p/lilypond/issues/detail?id=2344#c12
>
Looks like the trick with stencil-whiteout does not work in all cases.
Here are two examples.
1.
\new KievanStaff {
\new KievanVoice
{
c' \bar "kievan"
}
}
2.
\new KievanStaff {
\new KievanVoice
{
c' b \bar "kievan"
}
}
In the second example, the bar line is whited out. But in the first
example, it isn't. Anyone have any pointers as to how to debug this?
Aleksandr
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Work on Issue 1320
On Thu, Apr 5, 2012 at 2:51 PM, Marc Hohl wrote: > I don't know whether the > kievan bar line makes sense with span bars It doesn't make sense with span bars. > but I managed to get this better IMHO I've attempted to modify your code to use stencil-whiteout to remove the staff lines behind the kievan bar line. Please see attached. Aleksandr barlinetest.ly Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fixing height of Kievan bar line
> Have a look at lily/grob.cc where the whiteout handling is defined. Thanks. That seems to be a good approach. I've uploaded a new patch. The results are here: http://code.google.com/p/lilypond/issues/detail?id=2344#c12 There still appears to be a gray line at the bottom. Is that just a feature of how stencil-whiteout works or do I need to extend the char_box downward? Code is here: http://codereview.appspot.com/5727051/ Aleksandr ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fixing height of Kievan bar line
> Wouldn't it be easier to draw a white box underneath the kievan glyph? Can that be done with the same Stencil object? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fixing height of Kievan bar line
Hello list, I'm back to trying to work on this issue after a bit of a hiatus. The problem is how to get the staff lines to stop printing before the Kievan bar line appears: http://code.google.com/p/lilypond/issues/detail?id=2344 I've been hacking around the code a bit and here's my question. Is it possible to pass an event to the staff object? Right now, on line 290 of bar-line.cc, where the Kievan bar line is being added as a Stencil, I can access the staff as: Grob *staff = Staff_symbol_referencer::get_staff_symbol (me); I'd like to be able to pass a stop event to this staff, which AFAICT happens via Staff_symbol_engraver::stop_spanner () But I'm not sure how to do that. Thanks, Aleksandr ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fixing height of Kievan bar line (issue 5727051)
Reviewers: ,
Message:
Changing the char_box of the Kievan bar line to eliminate the problem
with the bar line being cut off.
However, this brings back the problem of staff lines appearing under the
bar line.
Description:
Fixing height of Kievan bar line
Kievan bar line is cut off when running lilypond with -dpreview,
or using Kievan score as a snippet in lilypond-book
See issue: http://code.google.com/p/lilypond/issues/detail?id=2344
Please review this at http://codereview.appspot.com/5727051/
Affected files:
M mf/parmesan-scripts.mf
Index: mf/parmesan-scripts.mf
diff --git a/mf/parmesan-scripts.mf b/mf/parmesan-scripts.mf
index
284aa45f5c163b7bebcf22ee621c2adebbf7142c..0689c22613f9a9a2fd4eef53c2533ea43ebc1659
100644
--- a/mf/parmesan-scripts.mf
+++ b/mf/parmesan-scripts.mf
@@ -254,16 +254,16 @@ fet_beginchar ("Kievan end of piece
(slash)", "barline.kievan");
save hair_thickness, thick_thickness, width, depth, height, padding;
hair# = 1.9 linethickness#;
thick# = 6.0 linethickness#;
- width = .8 staff_space;
+ width# = 1.0 staff_space#;
height# + depth# = 4 staff_space#;
depth# = height# + hair# / 2;
- padding = .2 staff_space;
+ padding# = .2 staff_space#;
- set_char_box (0, 0, depth#, height#);
- define_pixels (hair, thick);
+ set_char_box (0, width# + 3 padding#, depth#, height# + staff_space#);
+ define_pixels (hair, thick, width, padding, depth, height);
- x1r - x2l = width;
- y1 - y3r = d + h + linethickness / 2;
+ x7r - x2l = width;
+ y1 - y3r = depth + height + linethickness / 2;
z3 = z2;
z4 = .5 [z1, z2]
= (width / 2 + padding, hair / 8);
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove Time-signature from Kievan Staff (issue 5672063)
> Oops, i see now that the tracker issue > (http://code.google.com/p/lilypond/issues/detail?id=2318) doesn't have a > "Patch" label, and therefore isn't included in our regular patch > maintenance (i suppose it's because you didn't use our dedicated git-cl, > see section "reviews" here > http://lilypond.org/doc/v2.15/Documentation/contributor-big-page#summary-for-experienced-developers). I did use git-cl, but maybe I didn't do something right? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove Time-signature from Kievan Staff (issue 5672063)
On 2012/02/16 11:32:18, janek wrote: Looks Good To Me I think this can be pushed. http://codereview.appspot.com/5672063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Remove Time-signature from Kievan Staff (issue 5672063)
Reviewers: ,
Message:
Addressing the issue here:
http://code.google.com/p/lilypond/issues/detail?id=2318
Description:
Remove Time-signature from Kievan Staff
Time_signature_engraver is removed from Kievan Staff as per Google Code
issue 2318
http://code.google.com/p/lilypond/issues/detail?id=2318
Please review this at http://codereview.appspot.com/5672063/
Affected files:
M ly/engraver-init.ly
Index: ly/engraver-init.ly
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index
6335ab65b1fcd0fb168e0098cfa8efa57ecabe0f..83fd095d6131a28c0a8d3a5a0878495d5647ed6e
100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -1121,8 +1121,6 @@ accommodated for typesetting a piece in Petrucci
style."
\description "Same as @code{Voice} context, except that it is
accommodated for typesetting a piece in Kievan style."
-% \override Stem #'stencil = ##f
-
%% Set glyph styles.
\override NoteHead #'style = #'kievan
\override Rest #'style = #'mensural
@@ -1146,6 +1144,8 @@ accommodated for typesetting a piece in Kievan style."
\description "Same as @code{Staff} context, except that it is
accommodated for typesetting a piece in Kievan style."
+ \remove "Time_signature_engraver"
+
%% Choose Kievan tsefaut clef
clefGlyph = #"clefs.kievan.do"
middleCClefPosition = #0
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
There is a difference, compare the position of "kievan" markups in pdfs Ah, OK, I see it now. You've forgotten about one char_box, see below. I fixed this one as well as the char_box for the clef. I've run make and regtests from scratch on a freshly-updated source. I'm getting the error described above by Julien when running make test. I guess I have to wait for that patch to be pushed. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
When I go to make the regression tests, I get the following error message: texi2html --I=/home/sasha/lilypond-git/input/regression/lilypond-book --I=./out-test -I /home/sasha/lilypond-git/Documentation --I=/home/sasha/lilypond-git/build/./out-test/xref-maps --init-file=/home/sasha/lilypond-git/Documentation/lilypond-texi2html.init --output=out-test/collated-files.html out-test/collated-files.texi *** Duplicate node found: Top (in out-test/papersize-docs.texi l. 8) make[2]: Leaving directory `/home/sasha/lilypond-git/build/input/regression/lilypond-book' rsync -L -a --exclude 'out-*' --exclude 'out' --exclude mf --exclude source --exclude mf /home/sasha/lilypond-git/build/out/share ./out-test make[1]: Leaving directory `/home/sasha/lilypond-git/build/input/regression/lilypond-book' Looks like it's complaining about a "Top" node in collated-files.texi and another "Top" node in papersize-docs.texi. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Regarding comments by Jan: I guess it should be 2.5 staff_space or something I changed the depth and height parameters as you suggested. However, I do not see any difference, in the reg tests or in my test files. Are we sure that the entire glyph has to fit within the char_box, including the "stem"? Regarding comments by Neil and Bertrand: I rewrote Stem::is_normal_stem the way Neil suggested. Looking at the code in Stem.cc, it appears that both ways are being used to check the style property. I don't know which is the more correct. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
On 2012/01/12 16:24:13, Neil Puttock wrote: You're trying to access style from the Stem instead of the NoteHead. Got it. Thanks, Neil. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
On 2012/01/11 21:37:36, Neil Puttock wrote: Add a check for kievan style in Stem::is_normal_stem (). Unfortunately, that doesn't seem to do anything. Unless I'm not accessing the property correctly ... see the latest patch. Aleks http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
something like stems, which should be hidden, stick from notes. The problem here is that we're not using KievanVoice in note-head-style.ly. I've posted a potential solution to get rid of the "stems", but it's not very elegant because it breaks the pattern. Perhaps someone else has a better idea. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Merged Kievan patch with existing source code and fixed an issue in output-lib.scm http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Regression tests don't run
Aha. Some Googling reveals that: Exit code 137: The job was killed because it exceeded the time limit. Any ideas how to up the time limit? On Thu, Dec 29, 2011 at 10:54 AM, Phil Holmes wrote: > - Original Message - From: "Aleksandr Andreev" > > To: "Phil Holmes" > Cc: "Carl Sorensen" ; > Sent: Thursday, December 29, 2011 5:41 PM > > Subject: Re: Regression tests don't run > > >> Phil, >> >> I ran it again this morning on the latest source from git pull, and I >> get the same message. There is no notice in the relevant log file of >> any failed files, so it doesn't appear to be a syntax error. >> >> In fact, it looks like the relevant command runs, but for some reason >> make test still crashes. >> >> Does "Child returned 137" mean anything to anyone? >> >> Aleksandr >> > > It's the error number from LilyPond. Don't know the significance of the > 137, though. > > -- > Phil Holmes > > ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Regression tests don't run
Phil, I ran it again this morning on the latest source from git pull, and I get the same message. There is no notice in the relevant log file of any failed files, so it doesn't appear to be a syntax error. In fact, it looks like the relevant command runs, but for some reason make test still crashes. Does "Child returned 137" mean anything to anyone? Aleksandr ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Regression tests don't run
Here's the contents of the relevant log file: GNU LilyPond 2.15.24 Killed ing ./snippet-map--1615808177 Processing 94/lily-32d78681 Processing 8d/lily-d2e2b327 Processing 29/lily-e0ac5d9b Processing 89/lily-1efebec4 Processing 56/lily-44b4b5eb Processing de/lily-7583ff9a Processing a1/lily-2532f52b Processing e9/lily-cc1cc235 Processing eb/lily-b9b3e4da Processing c4/lily-5ec3314c Processing b6/lily-ed22f196 Processing 15/lily-7dccbf09 Processing 14/lily-f30583e8 Processing fb/lily-225d5a65 Processing d5/lily-430551bd Processing 8f/lily-6ab7ba14 Processing 2b/lily-67a53cb6 Processing b9/lily-87587e29 Processing 14/lily-ec228008 Processing 53/lily-986709b2 Processing b7/lily-139426fd Processing 86/lily-19d35db6 Processing 82/lily-c4fec699 Processing ad/lily-e2043b05 Processing d2/lily-235b4f54 Processing 77/lily-8d63c64e Processing a3/lily-35b258bb Processing 0b/lily-4a373899 Processing 21/lily-61a92dad Processing b3/lily-aa32cc8b Processing a7/lily-49addee4 Processing ce/lily-e862b98f Processing ac/lily-607721f0 Processing c6/lily-f054e88e Processing 79/lily-720c9c29 Processing 2b/lily-9d8ed098 Processing 22/lily-1718ce3f Processing fa/lily-c94b8509 Processing 32/lily-223f4956 Processing 5f/lily-5b10c699 Processing 4e/lily-5a511e5e Processing cc/lily-95d0d592 Processing 9f/lily-4aff3b6d Processing ab/lily-eb1df898 Processing 83/lily-4b937056 Processing ce/lily-dbdc055c Processing 28/lily-5dd413f5 Processing 23/lily-1ef97ebb Processing e8/lily-537bc5aa Processing 65/lily-75309660 Processing e2/lily-62607bbd Processing f5/lily-d942e982 Processing aa/lily-4099c8bb Processing a6/lily-496abe90 Processing 06/lily-82d85ecc Processing ba/lily-b01b78ac Processing 4f/lily-55bea4f5 Processing 5a/lily-6a849106 Processing ed/lily-6e585fc8 Processing 58/lily-266fe9bc Processing 67/lily-133725e9 Processing 10/lily-bd86e368 Processing 91/lily-8e889cab Processing ad/lily-0851732d Processing e7/lily-3f441e4e Processing 91/lily-6383f8ee Processing 55/lily-8d0f229b Processing 05/lily-ea938668 Processing 2d/lily-3cf5aeba Processing 5f/lily-6a87f0ee Processing 66/lily-f56ccaae Processing ab/lily-4214384a Processing c8/lily-def31f4b Processing 1a/lily-b90d23c4 Processing fe/lily-16d8c40d Processing 5f/lily-824fd7df Processing ee/lily-82ee4955 Processing bf/lily-87f1c433 Processing e9/lily-697dfab3 Processing 60/lily-6c5ab550 Processing fd/lily-2f531b63 Processing b5/lily-a1e251f8 Processing 5e/lily-538dfa61 Processing 29/lily-905dff02 Processing 08/lily-163a34d7 Processing 10/lily-eeb266cd Processing 15/lily-f6bf1744 Processing 52/lily-f1c532f3 Processing e8/lily-39b668da Processing b3/lily-96491fef Processing 65/lily-12d11fe6 Processing ad/lily-4a65a9a9 Processing a6/lily-d85b2254 Processing 6a/lily-67029b14 Processing 3f/lily-dc74be5e Processing cc/lily-c86299ef Processing fd/lily-5c314c83 Processing 80/lily-1efcebab Processing 5c/lily-33bf9ef2 Processing 08/lily-1e228cd2 Processing d0/lily-74b8777a Processing 54/lily-bd72b7b6 Processing 7c/lily-8723b55c Processing dd/lily-9f75a27c Processing 91/lily-af7c96bf Processing 4c/lily-cc405751 Processing e4/lily-d9de67dd Processing e5/lily-33240bbc Processing 0b/lily-b64e2787 Processing 0a/lily-3c39c489 Processing c7/lily-4bc72a99 Processing dd/lily-acce9bcc Processing e3/lily-cf149140 Processing 94/lily-0def3433 Processing 90/lily-1098a953 Processing 0a/lily-3c5e91eb Processing 1b/lily-aeadd10a Processing e7/lily-17aec669 Processing 9b/lily-cc62da83 Processing f7/lily-ea9b5f76 Processing dd/lily-4497eb29 Processing f8/lily-62272f3c Processing b1/lily-e3db0b2b Processing 09/lily-ada16d72 Processing ac/lily-129a96e6 Processing f1/lily-c4f730c3 Processing a0/lily-52083928 Processing 37/lily-3e40c16c Processing a4/lily-b59df3db Processing 09/lily-1f5cc835 Processing 4e/lily-13e26396 Processing 22/lily-b5e766bb Processing 7e/lily-a887c164 Processing a4/lily-94320b95 Processing ba/lily-de8a468a Processing 56/lily-68611a0f Processing 29/lily-a9ff2d11 Processing 78/lily-fa60fe17 Processing dd/lily-9325fcdd Processing 8d/lily-b308bddb Processing 1e/lily-e83a90bd Processing 1a/lily-6f475f86 Processing 03/lily-68481a2f Processing 94/lily-c6d701c7 Processing 4f/lily-bb045b97 Processing c4/lily-a38f1a04 Processing e0/lily-386d9cdf Processing 19/lily-ece14a02 Processing a8/lily-1c89eb9d Processing cf/lily-c27adf63 Processing ff/lily-42692278 Processing 72/lily-bfd4d468 Processing f8/lily-854040e0 Processing 53/lily-0b6cd35e Processing 0a/lily-e018ab08 Processing 7a/lily-00408d77 Processing 53/lily-f91afdf8 Processing e2/lily-7f07ecf0 Processing 3b/lily-8f72236e Processing 38/lily-4ca5881d Processing 26/lily-b10705d7 Processing 50/lily-0bc3e5ca Processing de/lily-40a05bca Processing c6/lily-73a13001 Processing 38/lily-8bf11382 Processing 42/lily-551e1b0f Processing db/lily-3d77e7c4 Processing 37/lily-661f1a21 Processing 4b/lily-7352cabe Processing f5/lily-bb35059a Processing 0d/lily-349857a3 Processing 2d/lily-29933104 Processing 42/lily-9fcb7364 Processing c9/lily-f35bd5a4 Processing c4/lily-9c1
Regression tests don't run
Hello folks, I've downloaded the latest Lilypond source from git onto a different computer than I was using before. This computer is running Ubuntu 11.04. I was trying to test out some things for the Kievan notation project, and to do that I wanted to build everything (including the documentation) from scratch. Now I'm trying to compile the source (just the source that came from git pull, without any modifications). Configure and make work fine, but make doc fails. Running make test reveals that the regression tests fail. Here's the results of make test: Processing /home/sasha/lilypond-git/build/out/lybook-testdb/snippet-names--1722816927.ly command failed: /home/sasha/lilypond-git/build/out/bin/lilypond -I /home/sasha/lilypond-git/input/regression/ -I ./out-test -I /home/sasha/lilypond-git/input -I /home/sasha/lilypond-git/Documentation -I /home/sasha/lilypond-git/Documentation/snippets -I /home/sasha/lilypond-git/input/regression/ -I /home/sasha/lilypond-git/Documentation/included/ -I /home/sasha/lilypond-git/build/mf/out/ -I /home/sasha/lilypond-git/build/mf/out/ -I /home/sasha/lilypond-git/Documentation/pictures -I /home/sasha/lilypond-git/build/Documentation/pictures/./out-test -dbackend=eps --formats=ps -dseparate-log-files -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I /home/sasha/lilypond-git/Documentation/included/ -ddump-profile -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I "/home/sasha/lilypond-git/build/out/lybook-testdb" -I "/home/sasha/lilypond-git/build/input/regression" -I "/home/sasha/lilypond-git/input/regression" -I "/home/sasha/lilypond-git/build/input/regression/out-test" -I "/home/sasha/lilypond-git/input" -I "/home/sasha/lilypond-git/Documentation" -I "/home/sasha/lilypond-git/Documentation/snippets" -I "/home/sasha/lilypond-git/input/regression" -I "/home/sasha/lilypond-git/Documentation/included" -I "/home/sasha/lilypond-git/build/mf/out" -I "/home/sasha/lilypond-git/build/mf/out" -I "/home/sasha/lilypond-git/Documentation/pictures" -I "/home/sasha/lilypond-git/build/Documentation/pictures/out-test" --formats=eps -deps-box-padding=3.00 -dread-file-list -dno-strip-output-dir "/home/sasha/lilypond-git/build/out/lybook-testdb/snippet-names--1722816927.ly" Child returned 137 Error ignored by lilylib Error trapped by lilypond-book Please see /home/sasha/lilypond-git/build/out/lybook-testdb/snippet-names--1722816927.log make[2]: *** [out-test/collated-files.texi] Error 1 make[2]: Leaving directory `/home/sasha/lilypond-git/build/input/regression' make[1]: *** [local-test] Error 2 make[1]: Leaving directory `/home/sasha/lilypond-git/build/input/regression' make: *** [test] Error 2 Does this mean anything to anyone? The dependencies appear to be fine. I'm running Ubuntu 11.04, Kernel version 2.6.38-13-generic (32-bit). I tried nuking the entire lilypond-git directory and re-pulling the source, but that did not solve the problem. Thanks, Alex ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
That is done, but before updating I wanted to resolve a few other issues. However, I cannot figure out how to control the amount of spacing between notes (I need the notes in a phrasing slur to be closer together). Also, I can't get the beams to show properly. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Fixed the issues addressed by Bertrand. What still remains: 1. Implementing beams 2. Changing the spacing so that notes in a phrasing slur are closer together. 3. Remove extra space after final note. Comments much appreciated. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
I'm trying to implement beams, but I get this message:
"must have Item for spanner bound of Beam"
What does this refer to?
A
On Fri, Oct 7, 2011 at 6:29 AM, wrote:
> Here's the second part of my review. I saw that kievan notation has
> beams, contrary to what I thought. If you're intrepid, you can also try
> to implement the kievan beaming parameters in you KievanVoice.
>
> Hold on, it's the end!
> Bertrand
>
>
> http://codereview.appspot.com/4951062/diff/64002/mf/parmesan-clefs.mf
> File mf/parmesan-clefs.mf (right):
>
> http://codereview.appspot.com/4951062/diff/64002/mf/parmesan-clefs.mf#newcode1738
> mf/parmesan-clefs.mf:1738: % TODO: merge this code with the above
> Obviously, this must be done. This is easy, you just have to define the
> glyph and create two characters with it:
>
>
> def draw_kievan_do_clef =
> z1 = [...]
> [...]
> enddef;
>
> fet_beginchar ([...]);
> draw_kievan_do_clef;
> fet_endchar;
>
> fet beginchar ([...]_change");
> % TODO: make a different glyph for changes, but
> % dunno what a kievan clef looks like in changes...
> draw[...];
> endchar;
>
> http://codereview.appspot.com/4951062/diff/64002/mf/parmesan-noteheads.mf
> File mf/parmesan-noteheads.mf (right):
>
> http://codereview.appspot.com/4951062/diff/64002/mf/parmesan-noteheads.mf#newcode1861
> mf/parmesan-noteheads.mf:1861: fet_beginchar ("kievan half note (space
> position)", "s1rkievan");
> Still "sr1kievan".
>
> http://codereview.appspot.com/4951062/diff/64002/scm/output-lib.scm
> File scm/output-lib.scm (right):
>
> http://codereview.appspot.com/4951062/diff/64002/scm/output-lib.scm#newcode101
> scm/output-lib.scm:101: (min 2
> Maybe you could try to change "min 2" for "min 3" and remove what you
> added before. I'm totally unsure of that, we must check what's going on
> downstream to be sure.
>
> http://codereview.appspot.com/4951062/diff/64002/scm/output-lib.scm#newcode595
> scm/output-lib.scm:595: (0 . "accidentals.vaticana0")
> I guess there's no natural glyph in kievan notation since there is no
> time signature and no accidental 'remembering'. Can you confirm this?
> Maybe we need to remove this line, then. This will produce a warning
> (but no crash) if one tries to use a natural in kievan style.
>
> http://codereview.appspot.com/4951062/
>
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
I've taken care of the issues Bertrand points out in #46. There are still some issues outstanding. The code in output-lib.scm is probably not the best way of doing this. Also, the Kievan bar line does not appear correctly. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
I've uploaded changes to output-lib.scm. The problem I have is that output-lib does not allow access to noteheads of log-duration greater than 2. I've temporarily changed a few lines of the file. However, I'm not sure this is the best way of doing this. Please let me know what the right approach should be. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Per comments by Bertrand, I have moved the Kievan glyphs to Parmesan. I have also changed the names of the glyphs as he suggested. I've begun working on improving the MetaFont code. Please take a look at the code for the final note, the recitative, and the whole note and let me know if I'm on the right track. I've been trying to understand the way the other glyphs in Parmesan are drawn, but there's a lot of subpaths of circles and other stuff that quite honestly is beyond me at this point. :( http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
> This is a great work, but it doesn't fit correctly into LilyPond: OK, I will merge with Parmesan and work on the Scheme stuff. > I also agree with Werner, there's also a lot of cleanup to do inside > your MetaFont stuff. I'm new to MetaFont, so right now I'm using it like a GUI-less outline font editor. I know that's probably the wrong approach. A ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
> What did you do to get make doc going? I nuked my entire lilypond-git directory, reinstalled the source and ran make and make doc. Then, I ran the Kievan patch and recompiled. A ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
make doc problem solved on my system. I can confirm that make and make doc run successfully with this patch. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
FWIW, I updated my kernel by installing the latest Ubuntu updates. I also did a git rebase. I still get the same problem. A 2011/9/22 Janek Warchoł : > 2011/9/22 Peekay Ex : >> Janek >> >> 2011/9/22 Janek Warchoł : >>> >>> I use Lilydev - probably not the newest version, how can i check it? >> >> System -> Administration -> System Monitor click on the first tab : ) > > It says > janek-lilydev5 (that's my username and virtual machine name i guess), > Ubuntu release 10.04 (lucid), Kernel Linux 2.6.32-26-generic, GNOME > 2.30.2 > > cheers, > Janek > ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Hi Phil, > Janek, Aleksandr - could you confirm what system you're getting make doc > failing on? Yes, I'm running Ubuntu Natty (not Lilydev). More specifically, Linux sasha-desktop 2.6.38-11-generic #48-Ubuntu x86_64 GNU/Linux Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Yet another rm -fdr build/ and re-run of make, etc., eliminated my original problem with snippets. Now, my make doc command crashes with the same error message that Janek is getting. Looks like there's a missing file web.texi. Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Updated Documentation/notation/notation-appendices.itely to show new glyphs, reflecting comments by Neil. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
>> What's in the above file? It'll probably contain 5-10 other filename Yes. All the different snippets seem to have something to do with percussion. Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Unfortunately, I cannot get my documentation to build. As was suggested earlier, I nuked my build folder and redid everything from the beginning (configure.sh, make all, touch, make doc). However, make doc errors out with the following message: Calculating line breaks... Segmentation fault command failed: /home/sasha/lilypond-git/build/out/bin/lilypond -dbackend=eps --formats=ps,png,pdf -dinclude-eps-fonts -dgs-load-fonts --header=doctitle --header=doctitlecs --header=doctitlede --header=doctitlees --header=doctitlefr --header=doctitlehu --header=doctitleit --header=doctitleja --header=doctitlenl --header=doctitlezh --header=texidoc --header=texidoccs --header=texidocde --header=texidoces --header=texidocfr --header=texidochu --header=texidocit --header=texidocja --header=texidocnl --header=texidoczh -dcheck-internal-types -ddump-signatures -danti-alias-factor=2 -I "/home/sasha/lilypond-git/build/out/lybook-db" -I "/home/sasha/lilypond-git/build/Documentation" -I "/home/sasha/lilypond-git/Documentation" -I "/home/sasha/lilypond-git/build/Documentation/out-www" -I "/home/sasha/lilypond-git/input" -I "/home/sasha/lilypond-git/Documentation" -I "/home/sasha/lilypond-git/Documentation/snippets" -I "/home/sasha/lilypond-git/input/regression" -I "/home/sasha/lilypond-git/Documentation/included" -I "/home/sasha/lilypond-git/build/mf/out" -I "/home/sasha/lilypond-git/build/mf/out" -I "/home/sasha/lilypond-git/Documentation/pictures" -I "/home/sasha/lilypond-git/build/Documentation/pictures/out-www" --formats=eps --verbose -deps-box-padding=3.00 -dread-file-list -dno-strip-output-dir "/home/sasha/lilypond-git/build/out/lybook-db/snippet-names-5304161007275961614.ly" Child returned 139 make[2]: *** [out-www/notation.texi] Error 1 make[2]: Leaving directory `/home/sasha/lilypond-git/build/Documentation' make[1]: *** [WWW-1] Error 2 make[1]: Leaving directory `/home/sasha/lilypond-git/build' make: *** [doc-stage-1] Error 2 Does anyone have any idea what could be going on? > The only thing that's missing is an entry in > Documentation/notation/notation-appendices.itely to show the glyphs. OK. I'll work on notation-appendices.itely. Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Fixed alignment issue based on comments by lemzwerg. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
As per comments by Neil, I removed the reg test file. Also made the necessary changes to Documentation/included/font-table.ly Also merged with Parmesan patch by Bertrand and resolved conflict. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
On 2011/09/10 10:20:45, lemzwerg wrote: Simply have a look how other note heads are implemented, and watch how the shape changes for different design sizes. OK. What is noteheight# equal to and how is that determined? http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
On 2011/09/10 12:47:18, J_lowe wrote: I created https://code.google.com/p/lilypond/issues/detail?id=1873 and called it 'Added glyphs for Kievan Notation' so when this issue is changed can we use the same title? I changed the name of the issue. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cleaned up style (issue 4951062)
Changed code style and glyph names based on the comments of Carl and lemzwerg. Carl, is it OK that the group name is kievan, so now we have glyphs like kievan.s1kievan? Is this how it should be? Re: "you can see that all coordinates rely on meta-parameters which control the appearance" I'm new to MetaFont, so I'm not sure I know what a meta-parameter is. lemzwerg, could you or someone else more knowledgeable about MF than me code up one of these glyphs the LilyPond way as an example? I think if I see it done once correctly, I'll be able to figure it out. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Kievan square notation in LilyPond
> I think it should be done similarly to ancient music support: add a > new kind of context, for example KievanVoice. > See how mensural notation works now - an example: OK, so IIUC, I have to add code to engraver-init.ly, and I can use the MensuralVoice context as an example. That seems to be fairly straightforward. Could you point me to which C++ files would need to be modified? Thanks, Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Kievan square notation in LilyPond
Hi folks, So now that we've got the Metafont code for the Kievan glyphs, what shall I do next? Basically, I would like to have an interface for Kievan Notation that achieves the following: 1. Automatically uses the Kievan tsefaut clef. 2. Suppresses Time Signature and Key Signature. 3. Uses the Kievan notes when the standard note commands (e.g., d1, e4) are issued. 4. Implements default placement of up vs. down variants 5. Ties implement proper spacing. 6. End of piece character placed at the end of the staff. How do I go about implementing these features? Thanks, Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cleaned up style (issue 4951062)
Cleaned up code style based on comments from janek. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Kievan square notation in LilyPond
Hi Janek, > > Please report is these worked for you. If so, i will update Just a thought: if you're editing the documentation, it would be useful to indicate that git-cl pulls up an interface of vim and that to get out of it, you use the standard vim commands. It's not obvious when you're doing for the first time. To the uninitiated, it looks like the script just crashes. I'm running Ubuntu Natty, if that's important. Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Added glyphs for Kievan Notation (issue 4951062)
Reviewers: , Message: Publishing for review Metafont code for support of Kievan square notes plus a very basic regression file to test the implementation. Description: Added glyphs for Kievan Notation Added Kievan glyphs and a basic test file add basic infrastructure for kievan font First step in supporting kievan square notation. Add generic metafont file, driver files and file containing code (one glyph currently). Modified scripts used in font generation to include kievan glyphs. Signed-off-by: Aleksandr Andreev Please review this at http://codereview.appspot.com/4951062/ Affected files: A input/regression/kievan-notes.ly M mf/GNUmakefile A mf/feta-kievan-generic.mf A mf/feta-kievan.mf A mf/feta-kievan11.mf A mf/feta-kievan13.mf A mf/feta-kievan14.mf A mf/feta-kievan16.mf A mf/feta-kievan18.mf A mf/feta-kievan20.mf A mf/feta-kievan23.mf A mf/feta-kievan26.mf M scripts/build/gen-emmentaler-scripts.py M scripts/build/mf-to-table.py ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Kievan square notation in LilyPond
Hi folks, I've finished writing up the Metafont code for the new glyphs and wanted to submit a patch for review, as per the instructions here: http://lilypond.org/doc/v2.15/Documentation/contributor/commits-and-patches#uploading-a-patch-for-review However, it looks like git-cl is not available: sasha@sasha-desktop:~$ git clone git://neugierig.org/git-cl.git Cloning into git-cl... neugierig.org[0: 208.94.116.153]: errno=Connection timed out neugierig.org[0: 208.94.117.38]: errno=Connection timed out neugierig.org[0: 208.94.116.102]: errno=Connection timed out fatal: unable to connect a socket (Connection timed out) What should I do? Aleks - Aleksandr Andreev :: Founder / Sole Proprietor Ponomar Technologies, Inc. "Putting Modern Technology to Work for the Ancient Church" http://www.ponomar.net/ * sa...@ponomar.net ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Kievan square notation in LilyPond
Hi Jan, Thanks for your comments. > In case of noteheads, i suppose that everything would be best defined in > staff_space. For stems (as i understand there are special characters for > stems) stafflinethickness will be more appropriate. Right now, I've got the notehead and stem being drawn as one character. Is this a bad idea? > However, i may be mistaken since i don't see the code. Here's the file I'm working with right now: http://www.ponomar.net/files/metasuprasl.mf And here's a proof sheet to make your life easier: http://www.ponomar.net/files/metasuprasl.pdf Thanks for your help, Aleks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
