Re: PATCH: 48-HOur countdown to 22:00 20110918
Am Saturday, 17. September 2011, 05:35:30 schrieb Colin Campbell: For 22: MDT Sunday Sept 18: [...] Issue 1888: Introduce a maximum depth for markup evaluation - R 5032041 and the closely related Issue 380: Try to auto-detect cyclic references in header fields (was 'cycling markup reference segfaults') - R 5027042: Fix 380: Auto-detect all cyclic references in markups There's another patch for this issue: http://codereview.appspot.com/4951073/ As the general solution (R 5027042) is not able to print out nice error messages (i.e. tell the user where exactly the problem lies), this patch handles only the cyclic \fromproperty case and prints a warning that tells the user exactly which header property has a recursive definition. I'd like both patches to go in, the first, because it fixes the problem in general, and the second because it's a more user-friendly special case. What I'm still missing, though, is how I can nicely print out the contents of the recursive markup. So far, I'm only able to print the name of the markup function, but not its contents (i.e. I can only print somehting like recursive line-markup encountered, but the user won't know which of his hundreds of markups in a score causes it). Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-HOur countdown to 22:00 20110918
On Sep 17, 2011, at 5:21 PM, Reinhold Kainhofer wrote: Am Saturday, 17. September 2011, 05:35:30 schrieb Colin Campbell: For 22: MDT Sunday Sept 18: [...] Issue 1888: Introduce a maximum depth for markup evaluation - R 5032041 and the closely related Issue 380: Try to auto-detect cyclic references in header fields (was 'cycling markup reference segfaults') - R 5027042: Fix 380: Auto-detect all cyclic references in markups There's another patch for this issue: http://codereview.appspot.com/4951073/ As the general solution (R 5027042) is not able to print out nice error messages (i.e. tell the user where exactly the problem lies), this patch handles only the cyclic \fromproperty case and prints a warning that tells the user exactly which header property has a recursive definition. I'd like both patches to go in, the first, because it fixes the problem in general, and the second because it's a more user-friendly special case. What I'm still missing, though, is how I can nicely print out the contents of the recursive markup. So far, I'm only able to print the name of the markup function, but not its contents (i.e. I can only print somehting like recursive line-markup encountered, but the user won't know which of his hundreds of markups in a score causes it). I've been toying with the idea for some time now of making markups at all levels behave more like grobs. It would require a massive code rewrite, but it'd allow a much more uniform approach to exactly this sort of thing (markups could, for example, issue errors like grobs, which gives the user the place in the code where the bad markup is). It'd also allow for some code-duping in the footnote code to go away and would allow for object-oriented references between markups (which would help with spacing, advanced inter-markup communication for layout stuff, etc.). Would anyone be interested in co-taking this on? Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-HOur countdown to 22:00 20110918
For 22: MDT Sunday Sept 18: Issue 935 http://code.google.com/p/lilypond/issues/detail?id=935: Enhancement: optional arguments in music functions - R 5023044 http://codereview.appspot.com/5023044/ Issue 1822 http://code.google.com/p/lilypond/issues/detail?id=1822: New short and long lyric ties - R4912041 http://codereview.appspot.com/4912041/ Issue 1854 http://code.google.com/p/lilypond/issues/detail?id=1854: Add some polyphonically directed grobs - R 4387046 http://codereview.appspot.com/4387046/ Issue 1868 http://code.google.com/p/lilypond/issues/detail?id=1868: Loglevels in our python scripts (lilypond-book, musicxml2ly, convert-ly) - R 4908041 http://codereview.appspot.com/4908041/ Issue 1888 http://code.google.com/p/lilypond/issues/detail?id=1888: Introduce a maximum depth for markup evaluation - R 5032041 http://codereview.appspot.com/5032041/ and the closely related Issue 380 http://code.google.com/p/lilypond/issues/detail?id=380: Try to auto-detect cyclic references in header fields (was 'cycling markup reference segfaults') - R 5027042 http://codereview.appspot.com/5027042/: Fix 380: Auto-detect all cyclic references in markups Cheers, Colin -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- ) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
2011/9/13 Peekay Ex pkx1...@gmail.com: 2011/9/13 Janek Warchoł janek.lilyp...@gmail.com: 2011/9/13 Peekay Ex pkx1...@gmail.com: On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: countdown for 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review after some comments today. you mean needs_work? I do. I still don't get it... I don't see any new comments either in tracker http://code.google.com/p/lilypond/issues/detail?id=1873 or on Rietveld http://codereview.appspot.com/4951062/ All comments there are at least 3 days old. Also, the patch status of the tracker issue is patch-review. ?? cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
Janek, 2011/9/14 Janek Warchoł janek.lilyp...@gmail.com: 2011/9/13 Peekay Ex pkx1...@gmail.com: 2011/9/13 Janek Warchoł janek.lilyp...@gmail.com: 2011/9/13 Peekay Ex pkx1...@gmail.com: On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: countdown for 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review after some comments today. you mean needs_work? I do. I still don't get it... I don't see any new comments either in tracker http://code.google.com/p/lilypond/issues/detail?id=1873 or on Rietveld http://codereview.appspot.com/4951062/ All comments there are at least 3 days old. Also, the patch status of the tracker issue is patch-review. ?? I have gone back over again. I think somewhere I confused two tracker issues (this and the change to parmesan noteheads issue). You are right sorry. But I have gone back over the the correct tracker and the correct Reitveld and it is fine. :) Patch-review and I did my reg tests ok. Sorry but thanks for catching this. James -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
Hello, On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: For 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review after some comments today. Regards -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
2011/9/13 Peekay Ex pkx1...@gmail.com: Hello, On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: For 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review you mean needs_work? after some comments today. I don't see any, are you perhaps referring to another patch? cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
Hello, 2011/9/13 Janek Warchoł janek.lilyp...@gmail.com: 2011/9/13 Peekay Ex pkx1...@gmail.com: Hello, On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: For 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review you mean needs_work? I do. Sorry. -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown to 20110914
For 22:00 MDT Wednesday, September 14 Issue 456 http://code.google.com/p/lilypond/issues/detail?id=456: \laissezVibrer in chords - R 4969069 http://codereview.appspot.com/4969069/ Issue 1876 http://code.google.com/p/lilypond/issues/detail?id=1876: MusicXML: fix case when some elements have a staff number, while others don't - R 4991044 http://codereview.appspot.com/4991044/ Issue 1193 http://code.google.com/p/lilypond/issues/detail?id=1193: Enhancement: internal ledger lines, and Issue 1292 http://code.google.com/p/lilypond/issues/detail?id=1292: Enhancement: twelve-notation support, and Issue 1878 http://code.google.com/p/lilypond/issues/detail?id=1878: Add support for custom ledger positions All 3 above connected to R 4974075 http://codereview.appspot.com/4974075/ Issue 380 http://code.google.com/p/lilypond/issues/detail?id=380: cycling markup reference segfaults - R 4951073 http://codereview.appspot.com/4951073/ Issue 1852 http://code.google.com/p/lilypond/issues/detail?id=1852: manuals needs more explicit dependencies - R 4996044 http://codereview.appspot.com/4996044/ Issue 1873 http://code.google.com/p/lilypond/issues/detail?id=1873: Added glyphs for Kievan Notation - R 4951062 http://codereview.appspot.com/4951062/ Issue 1776 http://code.google.com/p/lilypond/issues/detail?id=1776: Doc: NR - Polymetric Notation \compoundMeter isn't documented - R 4837050 http://codereview.appspot.com/4837050/ A goodly batch today, devels. Nice work! Cheers Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown to 20110909
For 22:00 MDT Friday September 9 Just one for today: Issue 1248 http://code.google.com/p/lilypond/issues/detail?id=1248: GUB produces a random unbound open-file in regtests - R 4956062 http://codereview.appspot.com/4956062/: Flush all ports after each file, The other 4 outstanding issues are actively being discussed, or their status is unclear. Great work, developers! Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown to 20110907
For 22:00 MDT Wednesday Sept. 7 Issue 509 http://code.google.com/p/lilypond/issues/detail?id=509: collision nested tuplet numbers - R 4808082 http://codereview.appspot.com/4808082/ Issue 1805 http://code.google.com/p/lilypond/issues/detail?id=1805: Ambitus engraver produces false warnings - R Issue 4904049 http://codereview.appspot.com/4904049/ Issue 1846 http://code.google.com/p/lilypond/issues/detail?id=1846: Improves horizontal spacing of axis groups that SpanBar grobs traverse - R 4917046 http://codereview.appspot.com/4917046/ Issue 1855 http://code.google.com/p/lilypond/issues/detail?id=1855: Prevents nested tuplets from colliding - R 4808082 http://codereview.appspot.com/4808082/ Issue 1866 http://code.google.com/p/lilypond/issues/detail?id=1866: Uses langdefs.py to create language list - R 4951047 http://codereview.appspot.com/4951047/ Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110903
On 11-09-01 02:38 PM, Graham Percival wrote: On Thu, Sep 01, 2011 at 07:10:19AM -0600, Colin Campbell wrote: Sweet! I'll do some housekeeping as I get a chance today. Tomorrow's batch will go out early, as I'm taking Mrs Patchmeister on an impulse session of highway therapy: driving for 4 days around Alberta and BC, back in time for the regular Monday batch. Mrs Patchmeister is a lucky woman. Driving around Alberta and BC means the Rocky Mountains, the best place on earth. :) Cheers, - Graham The tour went South to Lethbridge, then West through the Crowsnest to the Okanagan, North along the lakes, vineyards and orchards, eventually to Prince George, then home through the Yellowhead, with Mount Robson *almost* completely visible, although he still had a wisp of cloud at the summit. WRT the lucky part: we blew a tire about an hour or so south of PG, and were faced with the challenge of nursing the miniature spare at 60KM along the shoulder of the highway. We made it into a wee town about 15 minutes later, and found someone who knew a chap who could fix flats at home, on Sunday! Better than that, on the outskirts of PG, I noticed a sign saying the drive-in cinema was open, so Mrs Patchmeister and I saw Captain America at what is surelt the most Northerly and still operating drive-in cinema anywhere! Cheers. Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110903
On 11-08-31 11:32 PM, Graham Percival wrote: Colin: I've just added a Patch-push label as a temporary measure. Please change the labels on issues that should be pushed, so that we can (easily) get an accurate view of the situation. (this isn't urgent, though) Sweet! I'll do some housekeeping as I get a chance today. Tomorrow's batch will go out early, as I'm taking Mrs Patchmeister on an impulse session of highway therapy: driving for 4 days around Alberta and BC, back in time for the regular Monday batch. Cheers Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110903
On Thu, Sep 01, 2011 at 07:10:19AM -0600, Colin Campbell wrote: Sweet! I'll do some housekeeping as I get a chance today. Tomorrow's batch will go out early, as I'm taking Mrs Patchmeister on an impulse session of highway therapy: driving for 4 days around Alberta and BC, back in time for the regular Monday batch. Mrs Patchmeister is a lucky woman. Driving around Alberta and BC means the Rocky Mountains, the best place on earth. :) Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown to 20110903
For 22:00 MDT Friday Sept 3 T 1844 http://code.google.com/p/lilypond/issues/detail?id=1844: Changes variable names in include/beam-scoring-problem.hh and beam-quanting.cc - R 4961041 http://codereview.appspot.com/4961041/ T 1825 http://code.google.com/p/lilypond/issues/detail?id=1825: convert-ly produces no output having run on up-to-date source - R 4961059 http://codereview.appspot.com/4961059/ T 1854 http://code.google.com/p/lilypond/issues/detail?id=1854: Add some polyphonically directed grobs - R 4387046 http://codereview.appspot.com/4387046/ The remaining 13(!) patches with review status, have all had coundtowns, and are waiting to be pushed, closed and marked fixed. Folks, please make my life easier, and get Graham off my back: when you get a PatchBatch, why not set a follow up reminder in your email or calendar? Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110903
On Wed, Aug 31, 2011 at 09:34:26PM -0600, Colin Campbell wrote: The remaining 13(!) patches with review status, have all had coundtowns, and are waiting to be pushed, closed and marked fixed. woah, seriously ?! Folks, please make my life easier, and get Graham off my back: when you get a PatchBatch, why not set a follow up reminder in your email or calendar? Yes, definitely. Guys: I certainly have been sending nasty private messages to Colin to prod him along, thinking that we had a huge backlog of 10-20 patches waiting to get onto the countdown. This changes everything! Colin: I've just added a Patch-push label as a temporary measure. Please change the labels on issues that should be pushed, so that we can (easily) get an accurate view of the situation. (this isn't urgent, though) Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown to 20110831
For 23:00 MDT Wednesday, August 31 Issue 1849 http://code.google.com/p/lilypond/issues/detail?id=1849: Fix memleak: temporary skyline objects for systems were never deleted - R Issue 4923048 http://codereview.appspot.com/4923048/ Issue 1847 http://code.google.com/p/lilypond/issues/detail?id=1847: Lilypond-book: Get rid of lilyquote option - R Issue 4921050 http://codereview.appspot.com/4921050/ (S/B pushed already per GP) Issue 1846 http://code.google.com/p/lilypond/issues/detail?id=1846: Improves horizontal spacing of axis groups that SpanBar grobs traverse - R Issue 4917046 http://codereview.appspot.com/4917046/ Issue 1845 http://code.google.com/p/lilypond/issues/detail?id=1845: Creates pure closures - R Issue 4894052 http://codereview.appspot.com/4894052/ Issue 1840 http://code.google.com/p/lilypond/issues/detail?id=1840: Fixes figuredBassCenterContinuations - R Issue 4868046 http://codereview.appspot.com/4868046/ Issue 1838 http://code.google.com/p/lilypond/issues/detail?id=1838: Make accidental styles available as context mods - R Issue 4819064 http://codereview.appspot.com/4819064/ Issue 1835 http://code.google.com/p/lilypond/issues/detail?id=1835: no learing manual pdf in dutch - (No Rietveld, patch attached to tracker) Issue 1814 http://code.google.com/p/lilypond/issues/detail?id=1814: Breve with double-line ears can collide with accidentals and barlines - R Issue 4931043 http://codereview.appspot.com/4931043/ Issue 1529 http://code.google.com/p/lilypond/issues/detail?id=1529: filename changing should not trigger a regtests comparison - R Issue 4893044 http://codereview.appspot.com/4893044/: Hashed snippet filename changes Issue 723 http://code.google.com/p/lilypond/issues/detail?id=723: wrong horizontal alignment of pedal brackets with a second inside a chord - R Issue 4966042 http://codereview.appspot.com/4966042/ As always, thanks for all the hard work, and don't forget to close your Rietveld items when you push: I can mark the bug tracker issues fixed, but you're on your own with Rietveld! Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110828
On Aug 27, 2011, at 4:40 AM, Colin Campbell wrote: Issue 1235: Accidental overlays stem - R 4898044: Fixes heights and pure heights of stems. Issue 1114: A later note's stem can be to the left of an earlier note's stem - R Issue 4898044: Fixes heights and pure heights of stems. Hey all, Just a note to say that this issue had already gone through a countdown with no comments, so I'm gonna push it (I just ran the regtests on it and they are clean) so that I can push the stem-tremolo patch on Monday. Cheers, MS___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown to 20110828
For 21:00 MDT Sunday August 28 Issue 1833 http://code.google.com/p/lilypond/issues/detail?id=1833: Deprecate \fermataMarkup for full-bar rests - R Issue 4672059 http://codereview.appspot.com/4672059/ Issue 1235 http://code.google.com/p/lilypond/issues/detail?id=1235: Accidental overlays stem - R 4898044 http://codereview.appspot.com/4898044/: Fixes heights and pure heights of stems. Issue 1114 http://code.google.com/p/lilypond/issues/detail?id=1114: A later note's stem can be to the left of an earlier note's stem - R Issue 4898044 http://codereview.appspot.com/4898044/: Fixes heights and pure heights of stems. Issue 905 http://code.google.com/p/lilypond/issues/detail?id=905: LilyPond should accept UTF-8 BOM signatures - R Issue 4908043 http://codereview.appspot.com/4908043/: Issue 905: Gracefully ignore UTF-8 BOM in the middle of a file Rietveld only: Issue 4867043 http://codereview.appspot.com/4867043/: Uses Y-offset for stem tremolos instead of translated stencil. Issue 4837047 http://codereview.appspot.com/4837047/: Lets auto numbering of footnotes kick in from commands alone. Don't forget to push/close/mark fixed! Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20:00 MDT 20110826
On Aug 25, 2011, at 3:56 AM, Colin Campbell wrote: For Friday, August 26 (and where did the Summer go?) Issue 509: collision nested tuplet numbers - R Issue 4808082: Prevents nested tuplets from colliding. Issue 1328: Slurs collides with fermata - R Issue 4860042: Does better polynomial calculations for avoid objects. Hey Lilynauts, 1328 was on Monday's countdown and got reviews from Joe Han-Wen, so I'm gonna push it this morning. If no one has any objections, I'd like to replace this with the older: Issue 1235: Accidental overlays stem - R 4898044: Fixes heights and pure heights of stems. Which I had pulled off of the countdown on Monday so that the flags could be reviewed first. Sorry for the post-countdown e-mails, and thanks very much for your help Colin! Cheers, MS___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20:00 MDT 20110826
On Wed, Aug 24, 2011 at 07:56:10PM -0600, Colin Campbell wrote: Of the 14 patches for review, 6 are less than 48 hours old and too young to be on this list, What? There's no point waiting. If something is marked patch-review, then (space permitting) it should go on the next countdown. Obviously is something is still languishing in patch-new, then don't put it on the countdown... and if there's any patch-review with known objections, it shouldn't go on the countdown (and should instead be marked patch-needs_work). I'm aware of approximately 15 patches which haven't gotten into the system as patch-new, so I don't think there's cause for celebration yet. I haven't made a bigger fuss about those because there's plenty of stuff already in patch-review, but once those are under control, we should either recruit a new volunteer to find those lost patches, or I'll do it myself. Let's not let up the pressure yet. (I also don't like having 21 patches languishing as patch-needs_work; I think that once the backlog is gone and we can force reviews within 48 hours, developers will have more motivation to make the required changes and get another set of reviews) Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown to 20:00 MDT 20110826
For Friday, August 26 (and where did the Summer go?) Issue 509 http://code.google.com/p/lilypond/issues/detail?id=509: collision nested tuplet numbers - R Issue 4808082 http://codereview.appspot.com/4808082/: Prevents nested tuplets from colliding. Issue 1328 http://code.google.com/p/lilypond/issues/detail?id=1328: Slurs collides with fermata - R Issue 4860042 http://codereview.appspot.com/4860042/: Does better polynomial calculations for avoid objects. Issue 1816 http://code.google.com/p/lilypond/issues/detail?id=1816: Lilypond-book music runs off right side of the page - R Issue 4888046 http://codereview.appspot.com/4888046/: Fix 1816: Lilypond-Book: Issue 1735 http://code.google.com/p/lilypond/issues/detail?id=1735: modifying default behaviour of tremolo slashes - R Issue 4636081 http://codereview.appspot.com/4636081/: modifying default behaviour of tremolo slashes Issue 1787 http://code.google.com/p/lilypond/issues/detail?id=1787: Hide ends of barlines inside staff lines. - R Issue 4809057 http://codereview.appspot.com/4809057/: Ends of barlines are hidden in staff lines Issue 1742 http://code.google.com/p/lilypond/issues/detail?id=1742: print transposed guitar chords on piano sheets - R Issue 4800051 http://codereview.appspot.com/4800051/ Issue 1688 http://code.google.com/p/lilypond/issues/detail?id=1688: New half-closed hihat symbol for drum mode - R Issue 4714043 http://codereview.appspot.com/4714043/ Of the 14 patches for review, 6 are less than 48 hours old and too young to be on this list, and the oldest of those above is Aug. 9, the rest being within the last 4 days. Great work, developers! Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown 22:00 MDT 20110824
On Aug 23, 2011, at 5:31 AM, Colin Campbell wrote: For Wednesday August 25th, 22:00 Issue 1735: modifying default behaviour of tremolo slashes - R 4636081 Issue 1628: Fingerings collide with slurs when used in - R 4876051: Fixes issue 1628. Issue 1328: Slurs collides with fermata - R 4860042 Issue 1235: Accidental overlays stem - R 4898044: Fixes heights and pure heights of stems. Cheers, Colin Hey all, If it's OK with everyone, I'd like to replace: Issue 1235: Accidental overlays stem - R 4898044: Fixes heights and pure heights of stems. with Creates a Flag grob (http://codereview.appspot.com/4922042/) as Han-Wen had requested that this be implemented first before 4898044 was pushed. Sorry for not alerting you about that, Colin, and thanks to all for your reviews on both 4922042 and 4898044 so far. Cheers, MS___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown 22:00 MDT 20110824
For Wednesday August 25th, 22:00 Issue 1735 http://code.google.com/p/lilypond/issues/detail?id=1735: modifying default behaviour of tremolo slashes - R 4636081 http://codereview.appspot.com/4636081/ Issue 1628 http://code.google.com/p/lilypond/issues/detail?id=1628: Fingerings collide with slurs when used in - R 4876051 http://codereview.appspot.com/4876051/: Fixes issue 1628. Issue 1328 http://code.google.com/p/lilypond/issues/detail?id=1328: Slurs collides with fermata - R 4860042 http://codereview.appspot.com/4860042/ Issue 1235 http://code.google.com/p/lilypond/issues/detail?id=1235: Accidental overlays stem - R 4898044 http://codereview.appspot.com/4898044/: Fixes heights and pure heights of stems. Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown 21:00 MDT 2011-08-19
For 21:00 MDT Friday August 19 Issue 1349 http://code.google.com/p/lilypond/issues/detail?id=1349: Guile 2.0 compat: Scheme macros (repeated due to revisions since the Monday list) Issue 1779 http://code.google.com/p/lilypond/issues/detail?id=1779: accidentaled notes too far from the barline - R Issue 4188051 http://codereview.appspot.com/4188051/: Remove special case in staff-spacing Issue 804 http://code.google.com/p/lilypond/issues/detail?id=804: Code cleaning: checking types-conversion issues and other build warnings R Issue 472 http://code.google.com/p/lilypond/issues/detail?id=472: collision rest + (accidental/notehead) with beaming - R Issue 4860043 http://codereview.appspot.com/4860043/: Better pure height approximations for beamed rests. Issue 1785 http://code.google.com/p/lilypond/issues/detail?id=1785: Compressible space before the first note of a line - R Issue 4188051 http://codereview.appspot.com/4188051/: Remove special case in staff-spacing Issue 509 http://code.google.com/p/lilypond/issues/detail?id=509: collision nested tuplet numbers - R Issue 4808082 http://codereview.appspot.com/4808082/ (repeated after revisions) Issue 1776 http://code.google.com/p/lilypond/issues/detail?id=1776: Doc: NR - Polymetric Notation \compoundMeter isn't documented - R Issue 4837050 http://codereview.appspot.com/4837050/ Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-Hour countdown 21:00 MDT 2011-08-17
For 21:00 Wednesday August 17 T Issue 1811 http://code.google.com/p/lilypond/issues/detail?id=1811: Revise warning re cueDuring font size Rhttp://codereview.appspot.com/4850051 T Issue 1349 http://code.google.com/p/lilypond/issues/detail?id=1349: Guile 2.0 compat: Scheme macros must be defined/autocompiled before they are used. R http://codereview/appspot.com/4849054 T Issue 1808 http://code.google.com/p/lilypond/issues/detail?id=1808: [PATCH] Implement MusicXML files in lilypond-book R http://codereview.appspot.com/1659041/ T Issue 1752 http://code.google.com/p/lilypond/issues/detail?id=1752: redesigning G clef in our Feta font R http://codereview.appspot.com/4664070/ T Issue 1779 http://code.google.com/p/lilypond/issues/detail?id=1779: accidentaled notes too far from the barline R http://codereview.appspot.com/4188051/ Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-Hour countdown
22:00 MDT Saturday, Aug 13 Issue T 1790 http://code.google.com/p/lilypond/issues/detail?id=1790: Proper loglevels: cmd-line option --loglevel=NONE/ERROR/WARN/PROGRESS/INFO/DEBUG - R Issue 4822055 http://codereview.appspot.com/4822055/ Issue T 40 http://code.google.com/p/lilypond/issues/detail?id=40: collision glissando accidental (includes workaround) - R Issue 4801083 http://codereview.appspot.com/4801083/ Issue T 1807 http://code.google.com/p/lilypond/issues/detail?id=1807: Adds a lyric tie glyph to feta font - R Issue 4808074 http://codereview.appspot.com/4808074/ Issue T 1787 http://code.google.com/p/lilypond/issues/detail?id=1787: Hide ends of barlines inside staff lines - R Issue 4809057 http://codereview.appspot.com/4809057/ I'm seizing the chance for a 4-day weekend, after a *remarkably* unpleasant end to Folk Fest, so the next Patch Batch will resume the regular schedule on Monday. Cheers, Colin Campbell Bug Squad -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown
22:00 MDT Thursday Aug 11. Issue 1800 http://code.google.com/p/lilypond/issues/detail?id=1800: Segfault compiling LSR 346 - Rietveld Issue 4830064 http://codereview.appspot.com/4830064/ Issue 1604 http://code.google.com/p/lilypond/issues/detail?id=1604: MultiMeasureRest staff position 0 is taken as staff position 2 - Rietveld Issue 4822046 http://codereview.appspot.com/4822046/ Issue 1735 http://code.google.com/p/lilypond/issues/detail?id=1735: modifying default behaviour of tremolo slashes - Rietveld Issue 4636081 http://codereview.appspot.com/4636081/ Issue 1214 http://code.google.com/p/lilypond/issues/detail?id=1214: Cue notes to music that creates a sub-voice does not work - Rietveld Issue 4816044 http://codereview.appspot.com/4816044/ Issue 509 http://code.google.com/p/lilypond/issues/detail?id=509: collision nested tuplet numbers - Rietveld Issue 4808082 http://codereview.appspot.com/4808082/ Issue 163 http://code.google.com/p/lilypond/issues/detail?id=163: huge (ugly) slur (both phrasing and normal) - Rietveld Issue 4810072 http://codereview.appspot.com/4810072/ Owners/developers, please push, close and mark ASAP after Thursday evening. Thanks, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
Colin Campbell cpkc at shaw.ca writes: New today, for Friday: Issue 621: Dynamics should avoid cross-staff BarLines (e.g. GrandStaff, PianoStaff etc) - Rietveld I should advertise that the patch on this issue includes a Docs change. After the patch we no longer need to teach how to un-overlap DynamicText, so I replaced it with teaching on how to un-overlap MetronomeMarks http://codereview.appspot.com/4805054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
On Do., 28. Jul. 2011 04:04:21 CEST, Colin Campbell c...@shaw.ca wrote: Countdown done, but still open/not marked fixed: From Wednesday July 27 Issue 732: Alignment problems when vertically stacking horizontally centered stencils. Issue : Allow manual directions on dynamics to break alignment spanner automatically Issue 1433: \breakDynamicSpan breaks with \break (bounds of spanner are invalid) Issue 1259: DynamicTextSpanner #'style = #'none doesn't work over \break The list of patches still not dealt with is rather alarming: is it because devels are on holiday, Those four patches quoted above are mine, and I'm currently at vacation at home with my parents, so I simply don't find enough time to deal with them right now. I'll fix and close them in the next few days. Cheers, Reinhold ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
RE: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
Hello, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of Reinhold Kainhofer )Sent: 28 July 2011 08:16 )To: Colin Campbell; Devel )Subject: Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29 ) )On Do., 28. Jul. 2011 04:04:21 CEST, Colin Campbell c...@shaw.ca )wrote: ) Countdown done, but still open/not marked fixed: ) From Wednesday July 27 ) Issue 732: Alignment problems when vertically stacking horizontally )centered stencils. ) Issue : Allow manual directions on dynamics to break alignment )spanner automatically ) Issue 1433: \breakDynamicSpan breaks with \break (bounds of spanner )are invalid) ) Issue 1259: DynamicTextSpanner #'style = #'none doesn't work over )\break ) ) The list of patches still not dealt with is rather alarming: is it ) because devels are on holiday, ) )Those four patches quoted above are mine, and I'm currently at vacation )at home with my parents, so I simply don't find enough time to deal with )them right now. I'll fix and close them in the next few days. )Cheers, )Reinhold ) --- I also keep half an eye on Rietveld issues being updated in the emails and Trackers not - as the patches are on Rietveld it is more than likely a dev will do one but forget the other. So I often step in and cut/paste the relevant comment on the Rietveld and update the Tracker. Until we get a single place to put issues and Patches I can't see this really changing and as has been said before, it is more important to keep the Devs slaving^H^H^H^H^H^H^H working away fixing and improving LP than worrying *too* much about the admin. James PA to Mike Solomon ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
On Jul 28, 2011, at 10:07 AM, James Lowe wrote: PA to Mike Solomon :) Even with my new virtual box, I am sometimes forgetting to take certain steps to get a clean baseline (i.e. forgetting to commit changes before deleting a branch, which leaves a set of files in my new branch, which then gets compiled with a patch, etc.). That has gotten better in the past few days, but I still make mistakes (like the slur stuff). Your regtest and admin help is very appreciated! Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
RE: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
Hello, )-Original Message- )From: m...@apollinemike.com [mailto:m...@apollinemike.com] )Sent: 28 July 2011 09:16 )To: James Lowe )Cc: Reinhold Kainhofer; Colin Campbell; Devel )Subject: Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29 )Importance: Low ) )On Jul 28, 2011, at 10:07 AM, James Lowe wrote: ) ) PA to Mike Solomon ) ):) )Even with my new virtual box, I am sometimes forgetting to take certain )steps to get a clean baseline (i.e. forgetting to commit changes before )deleting a branch, which leaves a set of files in my new branch, which )then gets compiled with a patch, etc.). That has gotten better in the past )few days, but I still make mistakes (like the slur stuff). Your regtest and )admin help is very appreciated! ) )Cheers, )MS Mike, depending on your Host machine you can use snapshot of VBOX quite effectively, to snapshot a point where you KNOW you have a clean build and even create snaps of different stages of your dev. I use it a lot because I get confused with git stashing and popping, but also to save me having to keep making a clean make test-baseline (only because it is much more sure to go back to a snap than run the 'clean' make commands). James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
On 11-07-28 01:16 AM, Reinhold Kainhofer wrote: On Do., 28. Jul. 2011 04:04:21 CEST, Colin Campbellc...@shaw.ca wrote: Countdown done, but still open/not marked fixed: From Wednesday July 27 Issue 732: Alignment problems when vertically stacking horizontally centered stencils. Issue : Allow manual directions on dynamics to break alignment spanner automatically Issue 1433: \breakDynamicSpan breaks with \break (bounds of spanner are invalid) Issue 1259: DynamicTextSpanner #'style = #'none doesn't work over \break The list of patches still not dealt with is rather alarming: is it because devels are on holiday, Those four patches quoted above are mine, and I'm currently at vacation at home with my parents, so I simply don't find enough time to deal with them right now. I'll fix and close them in the next few days. Cheers, Reinhold No worries, Reinhold. Thanks for your hard work, and I see you've already pushed them. Great to get that group around the dynamic spanner off this list! Enjoy the rest of the vacation, and sorry for the nagging. Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
On 11-07-28 12:48 AM, m...@apollinemike.com wrote: On Jul 28, 2011, at 4:04 AM, Colin Campbell wrote: New today, for Friday: Issue 621 http://code.google.com/p/lilypond/issues/detail?id=621: Dynamics should avoid cross-staff BarLines (e.g. GrandStaff, PianoStaff etc) - Rietveld Countdown done, but still open/not marked fixed: From Wednesday July 27 Issue 732 http://code.google.com/p/lilypond/issues/detail?id=732: Alignment problems when vertically stacking horizontally centered stencils. - Rietveld Issue 4798050 http://codereview.appspot.com/4798050/: Fix 732: center-column ignored left half of stencil extent - collision with previous stencil Issue http://code.google.com/p/lilypond/issues/detail?id=: Allow manual directions on dynamics to break alignment spanner automatically - Rietveld Issue 4810048 http://codereview.appspot.com/4810048/: Fix : Break dynamic line spanner if different direction is explicitly given Issue 1730 http://code.google.com/p/lilypond/issues/detail?id=1730: Documentation for lilypond-windows.exe and -dgui option - Rietveld Issue 4806050 http://codereview.appspot.com/4806050/: Doc: Usage - new option for lilypond-book And a couple of Rietveld-only patches: Issue 4668045 http://codereview.appspot.com/4668045/: Fixes error for tuplet bracket direction calculation when tuplets contain rests. Issue 4639075 http://codereview.appspot.com/4639075/: Moves tuplet numbers outside staff with their brackets. Issue 4580041 http://codereview.appspot.com/4580041/: Current state of automatic footnotes. Issue 1433 http://code.google.com/p/lilypond/issues/detail?id=1433: \breakDynamicSpan breaks with \break (bounds of spanner are invalid) - Rietveld Issue 4630070 http://codereview.appspot.com/4630070/: Fix issues 1259 and 1433 (\breakDynamicSpan and a spanner's style=#'none over a line break) Issue 1259 http://code.google.com/p/lilypond/issues/detail?id=1259: DynamicTextSpanner #'style = #'none doesn't work over \break The list of patches still not dealt with is rather alarming: is it because devels are on holiday, am I missing the closed or fixed tags in Rietveld and Google Code? How can I help you folk keep this moving? Hey Colin, Sorry for the delay! I'll take care of a large portion of my backlog today (I run an extra regtest before pushing, which slows me down a bit). Cheers, MS No problem, Mike: extra testing is always in order. Many's the time I wished I'd checked the order first: ready, fire, aim or . . . Thanks for the effort! Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
On 11-07-27 10:59 PM, Graham Percival wrote: On Wed, Jul 27, 2011 at 08:04:21PM -0600, Colin Campbell wrote: The list of patches still not dealt with is rather alarming: is it because devels are on holiday, am I missing the closed or fixed tags in Rietveld and Google Code? How can I help you folk keep this moving? You could check the git changelog (either in gitk, or on the web) to make sure that nobody pushed something without marking it fixed. Then send private emails to people reminding them to push, or to send final patches to me if they don't have push ability. Private emails always get more attention. Yes, it adds another 30 minutes to your job, but with the looming Aug 1 deadline before existing C++ patches get awkward, I think it's worth the effort. Cheers, - Graham Good points, Graham, and I'll try to do that. Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
New today, for Friday: Issue 621 http://code.google.com/p/lilypond/issues/detail?id=621: Dynamics should avoid cross-staff BarLines (e.g. GrandStaff, PianoStaff etc) - Rietveld Countdown done, but still open/not marked fixed: From Wednesday July 27 Issue 732 http://code.google.com/p/lilypond/issues/detail?id=732: Alignment problems when vertically stacking horizontally centered stencils. - Rietveld Issue 4798050 http://codereview.appspot.com/4798050/: Fix 732: center-column ignored left half of stencil extent - collision with previous stencil Issue http://code.google.com/p/lilypond/issues/detail?id=: Allow manual directions on dynamics to break alignment spanner automatically - Rietveld Issue 4810048 http://codereview.appspot.com/4810048/: Fix : Break dynamic line spanner if different direction is explicitly given Issue 1730 http://code.google.com/p/lilypond/issues/detail?id=1730: Documentation for lilypond-windows.exe and -dgui option - Rietveld Issue 4806050 http://codereview.appspot.com/4806050/: Doc: Usage - new option for lilypond-book And a couple of Rietveld-only patches: Issue 4668045 http://codereview.appspot.com/4668045/: Fixes error for tuplet bracket direction calculation when tuplets contain rests. Issue 4639075 http://codereview.appspot.com/4639075/: Moves tuplet numbers outside staff with their brackets. Issue 4580041 http://codereview.appspot.com/4580041/: Current state of automatic footnotes. Issue 1433 http://code.google.com/p/lilypond/issues/detail?id=1433: \breakDynamicSpan breaks with \break (bounds of spanner are invalid) - Rietveld Issue 4630070 http://codereview.appspot.com/4630070/: Fix issues 1259 and 1433 (\breakDynamicSpan and a spanner's style=#'none over a line break) Issue 1259 http://code.google.com/p/lilypond/issues/detail?id=1259: DynamicTextSpanner #'style = #'none doesn't work over \break The list of patches still not dealt with is rather alarming: is it because devels are on holiday, am I missing the closed or fixed tags in Rietveld and Google Code? How can I help you folk keep this moving? I still owe Graham a proposal on patch management, but this seems to call for more immediate attention. cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29
On Wed, Jul 27, 2011 at 08:04:21PM -0600, Colin Campbell wrote: The list of patches still not dealt with is rather alarming: is it because devels are on holiday, am I missing the closed or fixed tags in Rietveld and Google Code? How can I help you folk keep this moving? You could check the git changelog (either in gitk, or on the web) to make sure that nobody pushed something without marking it fixed. Then send private emails to people reminding them to push, or to send final patches to me if they don't have push ability. Private emails always get more attention. Yes, it adds another 30 minutes to your job, but with the looming Aug 1 deadline before existing C++ patches get awkward, I think it's worth the effort. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
2011/7/22 Xavier Scheuer x.sche...@gmail.com: On 21 July 2011 04:24, Colin Campbell c...@shaw.ca wrote: Issue 1735: modifying default behaviour of tremolo slashes - Rietveld Issue 4636081: modifying default behaviour of tremolo slashes [Not sure how it works, but] Please wait for issue 1735. Joe reviewed it yesterday and made some changes, about which Janek has not replied back yet. http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42 And I asked to keep current settings as default (and suggested not to blindly follow Elaine Gould, but instead see real practices and/or make a little user survey about what should be default tremolo slashes settings). http://code.google.com/p/lilypond/issues/detail?id=1735#c5 2011/7/22 Colin Campbell c...@shaw.ca: I've taken it off the list and set it to patch needs work. The problems are addressed (i think). Thanks for watching over this! Janek PS Reinhold, have a nice vacation! ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On 21 July 2011 04:24, Colin Campbell c...@shaw.ca wrote: Issue 1735: modifying default behaviour of tremolo slashes - Rietveld Issue 4636081: modifying default behaviour of tremolo slashes [Not sure how it works, but] Please wait for issue 1735. Joe reviewed it yesterday and made some changes, about which Janek has not replied back yet. http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42 And I asked to keep current settings as default (and suggested not to blindly follow Elaine Gould, but instead see real practices and/or make a little user survey about what should be default tremolo slashes settings). http://code.google.com/p/lilypond/issues/detail?id=1735#c5 Thanks in advance. Cheers, Xavier -- Xavier Scheuer x.sche...@gmail.com ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On 11-07-22 04:00 AM, Xavier Scheuer wrote: On 21 July 2011 04:24, Colin Campbellc...@shaw.ca wrote: Issue 1735: modifying default behaviour of tremolo slashes - Rietveld Issue 4636081: modifying default behaviour of tremolo slashes [Not sure how it works, but] Please wait for issue 1735. Joe reviewed it yesterday and made some changes, about which Janek has not replied back yet. http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42 And I asked to keep current settings as default (and suggested not to blindly follow Elaine Gould, but instead see real practices and/or make a little user survey about what should be default tremolo slashes settings). http://code.google.com/p/lilypond/issues/detail?id=1735#c5 Thanks in advance. Cheers, Xavier Thanks, Xavier! I've taken it off the list and set it to patch needs work. Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
Am Donnerstag, 21. Juli 2011, 04:24:07 schrieb Colin Campbell: Issue 1770: \displayLilyMusic causes error with \oneVoice - Rietveld Issue 4805043: Fix 1770: revert caused a crash in displayLilyMusic. I have already pushed this after fixing Neil's concerns, because I'm going on vacation tomorrow morning for a week and I don't know if I'll be able to do any LilyPond work during that time. Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On 11-07-22 06:50 AM, Reinhold Kainhofer wrote: Am Donnerstag, 21. Juli 2011, 04:24:07 schrieb Colin Campbell: Issue 1770: \displayLilyMusic causes error with \oneVoice - Rietveld Issue 4805043: Fix 1770: revert caused a crash in displayLilyMusic. I have already pushed this after fixing Neil's concerns, because I'm going on vacation tomorrow morning for a week and I don't know if I'll be able to do any LilyPond work during that time. Cheers, Reinhold Works for me, Reinhold. Have a great time away! Cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown
New today, for 21:00 MST Friday July 22 Issue 1567 http://code.google.com/p/lilypond/issues/detail?id=1567: Add documentation for footnotes - Rietveld Issue 4751045 http://codereview.appspot.com/4751045/: Doc: NR Added new Node for Footnotes Issue 1735 http://code.google.com/p/lilypond/issues/detail?id=1735: modifying default behaviour of tremolo slashes - Rietveld Issue 4636081 http://codereview.appspot.com/4636081/: modifying default behaviour of tremolo slashes Issue 1770 http://code.google.com/p/lilypond/issues/detail?id=1770: \displayLilyMusic causes error with \oneVoice - Rietveld Issue 4805043 http://codereview.appspot.com/4805043/: Fix 1770: revert caused a crash in displayLilyMusic. Countdown done, but still open/not fixed: 21:00 MST Wednesday July 13 Reitveld Issue 4664060 http://codereview.appspot.com/4664060/: Adds redirect-lilypond-output option to lilypond-book cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
RE: PATCH: 48-hour countdown
Hello, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of Colin Campbell )Sent: 21 July 2011 03:24 )To: lilypond-devel@gnu.org )Subject: PATCH: 48-hour countdown ) )New today, for 21:00 MST Friday July 22 ) )Issue 1567 http://code.google.com/p/lilypond/issues/detail?id=1567 : )Add documentation for footnotes - Rietveld Issue 4751045 )http://codereview.appspot.com/4751045/ : Doc: NR Added new Node )for Footnotes This still has some (minor) work to do by me - I've changed the Tracker Status back to 'needs work'. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On Wed, Jul 20, 2011 at 08:24:07PM -0600, Colin Campbell wrote: Countdown done, but still open/not fixed: 21:00 MST Wednesday July 13 Reitveld Issue 4664060: Adds redirect-lilypond-output option to lilypond-book sorry, that one was pushed but I forgot to update the google tracker. Phil, could you mark it fixed and add the git commit hash? Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown
New today, for 21:00 MST Wednesday July 20 (Where were you 42 years ago that day?) Issue 1678 http://code.google.com/p/lilypond/issues/detail?id=1678: Midi gives false warnings - Rietveld issue4757043 http://codereview.appspot.com/4757043/: MIDI: reset channel counters when done Issue 1752 http://code.google.com/p/lilypond/issues/detail?id=1752: redesigning G clef in our Feta font - Rietveld issue4664070 http://codereview.appspot.com/4664070/: changing shape of the G clef Countdown done, but still open/not fixed: 21:00 MST Monday July 18 Issue 1563 http://code.google.com/p/lilypond/issues/detail?id=1563: strange vertical line at staff begin using StaffSymbol #'staff-space - Rietveld - 4693043 http://codereview.appspot.com/4693043/: Fix 1563: System start bars interpreted collapse-height as absolute length. Issue 1507 http://code.google.com/p/lilypond/issues/detail?id=1507: weird linebreaks in song output - Rietveld - 4693046 http://codereview.appspot.com/4693046/: Fix #1507: Inconsistent \festival output in regression testing. (no discussion of patch yet, is it acceptable?) Issue 1695 http://code.google.com/p/lilypond/issues/detail?id=1695: Clef change placed outside score - Rietveld - 4683043 http://codereview.appspot.com/4683043/: Fix #1695: Clef change placed outside score. Issue 1728 Implements multi-line non-cross staff glissandi has been pushed and should be marked as fixed. 22:00 MST Friday July 15 Issue 1390 http://code.google.com/p/lilypond/issues/detail?id=1390: Tied acciaccaturas should not be printed with a slur - Reitveld issue 4670056 http://codereview.appspot.com/4670056/ 21:00 MST Wednesday July 13 Reitveld Issue 4664060 http://codereview.appspot.com/4664060/: Adds redirect-lilypond-output option to lilypond-book cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On 7/18/11 8:44 PM, Colin Campbell c...@shaw.ca wrote: New today, for 21:00 MST Wednesday July 20 (Where were you 42 years ago that day?) I was watching Neil Armstrong step on the moon in my living room, IIRC. Issue 1752 http://code.google.com/p/lilypond/issues/detail?id=1752 : redesigning G clef in our Feta font - Rietveld issue 4664070 http://codereview.appspot.com/4664070/ : changing shape of the G clef I believe the current state of this patch is not approved. I believe the consensus is that we should not keep the old clef around; the patch set 3 that does this has been identified as of concern to Trevor, Neil, and Han-Wen. Also, the comments on the glyph are not being kept on Rietveld, but are rather on -user, IIRC. James Lowe does not want to change the clef; many others are supportive of changing the clef. But there were some small details on the clef that were still being discussed, I think. So I think it's premature to push this patch before coming to consensus on the final disposition. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On 7/18/11 8:44 PM, Colin Campbell c...@shaw.ca wrote: Countdown done, but still open/not fixed: 21:00 MST Monday July 18 Issue 1695 http://code.google.com/p/lilypond/issues/detail?id=1695 : Clef change placed outside score - Rietveld - 4683043 http://codereview.appspot.com/4683043/ : Fix #1695: Clef change placed outside score. I'd sure like to see the fix for 1695 pushed. When that fix is pushed and backported, we can release 2.14.2. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On Mon, Jul 18, 2011 at 08:44:13PM -0600, Colin Campbell wrote: Countdown done, but still open/not fixed: All those should be marked patch-needs_work. When a new version of the patch is available, James will check that it passes the regtests, and then they are simply patch-review items. They should be placed on a future countdown, like any other patch-review item. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On 7/18/11 9:48 PM, Graham Percival gra...@percival-music.ca wrote: On Mon, Jul 18, 2011 at 08:44:13PM -0600, Colin Campbell wrote: Countdown done, but still open/not fixed: All those should be marked patch-needs_work. When a new version of the patch is available, James will check that it passes the regtests, and then they are simply patch-review items. They should be placed on a future countdown, like any other patch-review item. I think the patch for 1695 is approved. Current status, patch-review. No negative comments. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown
22:00 MST Friday July 15
Issue 1390 http://code.google.com/p/lilypond/issues/detail?id=1390:
Tied acciaccaturas should not be printed with a slur - Reitveld issue
4670056 http://codereview.appspot.com/4670056/
Issue 1760 http://code.google.com/p/lilypond/issues/detail?id=1760:
\RemoveEmptyStaves only works inside a \layout block - Reitveld issue
4664076 http://codereview.appspot.com/4664076/
Issue 1734 http://code.google.com/p/lilypond/issues/detail?id=1734:
Lilypond crashes on fingeringOrientations = #'right if set in \layout
{ \ context { \Score ... } } - Reitveld issue 4654090
http://codereview.appspot.com/4654090/: Does type checking for all
context property sets.
Cheers,
Colin
--
The human race has one really effective weapon, and that is laughter.
-- Mark Twain
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
2011/7/12 Colin Campbell c...@shaw.ca: 21:00 MST Wednesday July 13 Reitveld Issue 4664060: Adds redirect-lilypond-output option to lilypond-book Issue 1736: clarify description of minimal examples - Reitveld Issue 4636082 Issue 1739: doc: correcting note about rerunning regtests - Reitveld Issue 4675048 ? This already was on the previous countdown, i've send patch to Mike for pushing. cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
2011/7/10 Carl Sorensen c_soren...@byu.edu: On 7/9/11 8:43 PM, Colin Campbell c...@shaw.ca wrote: 21:00 MST Monday A paltry pile of patches presented, presumably prior patches (of which there are a metric shedload marked for review) preoccupying people. Issue 1735 http://code.google.com/p/lilypond/issues/detail?id=1735 : modifying default behaviour of tremolo slashes, Reitveld Issue 4636081 http://codereview.appspot.com/4636081/ : It seems to me that this patch is not yet approved. There is a major objection; it could be resolved by making an easily adjusted setting part of the patch. But it is premature to push this patch before revising it, IMO. Yes, it's not ready - sory for forgetting to update label. I'll work on it, but i need to close other issues first. cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On 11-07-09 09:08 PM, Carl Sorensen wrote: On 7/9/11 8:43 PM, Colin Campbellc...@shaw.ca wrote: 21:00 MST Monday A paltry pile of patches presented, presumably prior patches (of which there are a metric shedload marked for review) preoccupying people. Issue 1735http://code.google.com/p/lilypond/issues/detail?id=1735 : modifying default behaviour of tremolo slashes, Reitveld Issue 4636081 http://codereview.appspot.com/4636081/ : It seems to me that this patch is not yet approved. There is a major objection; it could be resolved by making an easily adjusted setting part of the patch. But it is premature to push this patch before revising it, IMO. Thanks, Carl Thanks, Carl! I obviously looked only at the tracker issue, and not at the discussion on Reitveld. Colin Chastened Campbell -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown
21:00 MST Monday A paltry pile of patches presented, presumably prior patches (of which there are a metric shedload marked for review) preoccupying people. Issue 1735 http://code.google.com/p/lilypond/issues/detail?id=1735: modifying default behaviour of tremolo slashes, Reitveld Issue 4636081 http://codereview.appspot.com/4636081/: Issue 1739 http://code.google.com/p/lilypond/issues/detail?id=1739: doc: correcting note about rerunning regtests, Reitveld Issue 4675048 http://codereview.appspot.com/4675048/ Thanks to those who have been helping by closing issues on Reitveld and marking them fixed on the bug tracker! Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown
On 7/9/11 8:43 PM, Colin Campbell c...@shaw.ca wrote: 21:00 MST Monday A paltry pile of patches presented, presumably prior patches (of which there are a metric shedload marked for review) preoccupying people. Issue 1735 http://code.google.com/p/lilypond/issues/detail?id=1735 : modifying default behaviour of tremolo slashes, Reitveld Issue 4636081 http://codereview.appspot.com/4636081/ : It seems to me that this patch is not yet approved. There is a major objection; it could be resolved by making an easily adjusted setting part of the patch. But it is premature to push this patch before revising it, IMO. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
