RE: [PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
Hi, Fabio
Anson Huang
Best Regards!
> -Original Message-
> From: Fabio Estevam [mailto:feste...@gmail.com]
> Sent: Saturday, May 5, 2018 11:18 PM
> To: Anson Huang
> Cc: Shawn Guo ; Sascha Hauer
> ; Fabio Estevam ; Rob
> Herring ; Mark Rutland ;
> Haibo Chen ; Andy Duan
> ; A.s. Dong ; Robin Gong
> ; dl-linux-imx ; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> ; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS ; linux-kernel
>
> Subject: Re: [PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch
> screen support
>
> On Sat, May 5, 2018 at 5:29 AM, Anson Huang
> wrote:
>
> > &iomuxc {
> > + pinctrl_egalax_int: egalax-intgrp {
> > + fsl,pins = <
> > + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22
> 0x8000
>
> Please avoid using 0x8000 and use the real IOMUX value instead.
Will use the expected pad settings in next version. Thanks.
Anson.
RE: [PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
Hi, Fabio
Anson Huang
Best Regards!
> -Original Message-
> From: Fabio Estevam [mailto:feste...@gmail.com]
> Sent: Saturday, May 5, 2018 7:56 PM
> To: Anson Huang
> Cc: Shawn Guo ; Sascha Hauer
> ; Fabio Estevam ; Rob
> Herring ; Mark Rutland ;
> Haibo Chen ; Andy Duan
> ; A.s. Dong ; Robin Gong
> ; dl-linux-imx ; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> ; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS ; linux-kernel
>
> Subject: Re: [PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch
> screen support
>
> Hi Anson,
>
> On Sat, May 5, 2018 at 5:29 AM, Anson Huang
> wrote:
> > Add egalax touch screen support on i2c2 bus.
> >
> > Signed-off-by: Haibo Chen
>
> Is Haibo the author of this patch? If so, his name should appear in the From
> field.
I made this patch based on NXP kernel tree, Haibo is the original author of this
feature, but the original patch can NOT be applied directly, I have to refine
the patch
to meet the upstream requirement, so I added him as another signed-off tag,
to avoid confuse, I can remove this sign-off in next patch version. Same story
for other patches in this series.
>
> > Signed-off-by: Anson Huang
> > ---
> > changes since V5:
> > improve pinctrl node name and touchscreen node name.
> > arch/arm/boot/dts/imx6sx-sabreauto.dts | 16
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > index 1dc5b58..3fe41d3 100644
> > --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > @@ -122,6 +122,12 @@
> > };
> >
> > &iomuxc {
> > + pinctrl_egalax_int: egalax-intgrp {
> > + fsl,pins = <
> > + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22
> 0x8000
> > + >;
> > + };
> > +
> > pinctrl_enet1: enet1grp {
> > fsl,pins = <
> > MX6SX_PAD_ENET1_MDIO__ENET1_MDIO
> 0xa0b1
> > @@ -264,6 +270,16 @@
> > pinctrl-0 = <&pinctrl_i2c2>;
> > status = "okay";
> >
> > + egalax_touchscreen@4 {
>
> Should be touchscreen@4.
Will improve it in next patch version.
Anson.
Re: [PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
On Sat, May 5, 2018 at 5:29 AM, Anson Huang wrote:
> &iomuxc {
> + pinctrl_egalax_int: egalax-intgrp {
> + fsl,pins = <
> + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x8000
Please avoid using 0x8000 and use the real IOMUX value instead.
Re: [PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
Hi Anson,
On Sat, May 5, 2018 at 5:29 AM, Anson Huang wrote:
> Add egalax touch screen support on i2c2 bus.
>
> Signed-off-by: Haibo Chen
Is Haibo the author of this patch? If so, his name should appear in
the From field.
> Signed-off-by: Anson Huang
> ---
> changes since V5:
> improve pinctrl node name and touchscreen node name.
> arch/arm/boot/dts/imx6sx-sabreauto.dts | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 1dc5b58..3fe41d3 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -122,6 +122,12 @@
> };
>
> &iomuxc {
> + pinctrl_egalax_int: egalax-intgrp {
> + fsl,pins = <
> + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x8000
> + >;
> + };
> +
> pinctrl_enet1: enet1grp {
> fsl,pins = <
> MX6SX_PAD_ENET1_MDIO__ENET1_MDIO0xa0b1
> @@ -264,6 +270,16 @@
> pinctrl-0 = <&pinctrl_i2c2>;
> status = "okay";
>
> + egalax_touchscreen@4 {
Should be touchscreen@4.
[PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
Add egalax touch screen support on i2c2 bus.
Signed-off-by: Haibo Chen
Signed-off-by: Anson Huang
---
changes since V5:
improve pinctrl node name and touchscreen node name.
arch/arm/boot/dts/imx6sx-sabreauto.dts | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts
b/arch/arm/boot/dts/imx6sx-sabreauto.dts
index 1dc5b58..3fe41d3 100644
--- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
+++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
@@ -122,6 +122,12 @@
};
&iomuxc {
+ pinctrl_egalax_int: egalax-intgrp {
+ fsl,pins = <
+ MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x8000
+ >;
+ };
+
pinctrl_enet1: enet1grp {
fsl,pins = <
MX6SX_PAD_ENET1_MDIO__ENET1_MDIO0xa0b1
@@ -264,6 +270,16 @@
pinctrl-0 = <&pinctrl_i2c2>;
status = "okay";
+ egalax_touchscreen@4 {
+ compatible = "eeti,egalax_ts";
+ reg = <0x04>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_egalax_int>;
+ interrupt-parent = <&gpio6>;
+ interrupts = <22 IRQ_TYPE_EDGE_FALLING>;
+ wakeup-gpios = <&gpio6 22 GPIO_ACTIVE_HIGH>;
+ };
+
pfuze100: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
--
2.7.4
