RE: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
Hi Michal, > -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Michal Simek > Sent: Thursday, August 02, 2018 11:14 PM > To: Stephen Boyd ; ard.biesheu...@linaro.org; > dmitry.torok...@gmail.com; gre...@linuxfoundation.org; > hkallwe...@gmail.com; keesc...@chromium.org; linux-...@vger.kernel.org; > mark.rutl...@arm.com; m...@codeblueprint.co.uk; mi...@kernel.org; > mturque...@baylibre.com; robh...@kernel.org; sb...@codeaurora.org; > sudeep.ho...@arm.com; Jolly Shah ; Michal Simek > > Cc: devicet...@vger.kernel.org; Rajan Vaja ; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for > ZynqMP core > > On 2.8.2018 22:59, Stephen Boyd wrote: > > Quoting Michal Simek (2018-07-30 05:50:42) > >> On 26.7.2018 18:36, Stephen Boyd wrote: > >>> Quoting Michal Simek (2018-07-25 02:51:14) > >>>> On 24.7.2018 20:14, Jolly Shah wrote: > >>>>>>> create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h > >>>>>>> create mode 100644 drivers/firmware/xilinx/zynqmp.c create > >>>>>>> mode > >>>>>>> 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h > >>>>>>> create mode 100644 include/linux/firmware/xlnx-zynqmp.h > >>>>>>> > >>>>>> > >>>>>> It looks pretty calm over the last several series that's why when > >>>>>> I get an answer from Stephen or Mike I will take this series via my > >>>>>> tree > and arm-soc tree. > >>>>>> > >>>>>> I have applied 01-08 here > >>>>>> https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc > >>>>>> > >>>>>> Thanks, > >>>>>> Michal > >>>>> > >>>>> > >>>>> Thanks for merging the patches. > >>>>> By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for > firmware bindings (Patch01). Stephen had reviewed clock bindings only. > Please > suggest if I should send a new version with that fix. > >>>> > >>>> I have fixed that in my branch and I have asked Shephen to look at > >>>> clk over chat. > >>>> > >>> > >>> I have some unresolved review comments on v9. I'll give reviewed-by > >>> when that discussion is resolved. > >> > >> ok. Do you want to take them via clk tree or via arm-soc tree? > >> > > > > I'm fine for the clk patch to go via arm-soc if that makes it easier. > > > > ok. Great. > Jolly: Please address all Stephen's comments that we can move. > > Thanks, > Michal Posted V11 patch set with all his comments addressed. Thanks, Jolly Shah
RE: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
Hi Michal, > -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Michal Simek > Sent: Thursday, August 02, 2018 11:14 PM > To: Stephen Boyd ; ard.biesheu...@linaro.org; > dmitry.torok...@gmail.com; gre...@linuxfoundation.org; > hkallwe...@gmail.com; keesc...@chromium.org; linux-...@vger.kernel.org; > mark.rutl...@arm.com; m...@codeblueprint.co.uk; mi...@kernel.org; > mturque...@baylibre.com; robh...@kernel.org; sb...@codeaurora.org; > sudeep.ho...@arm.com; Jolly Shah ; Michal Simek > > Cc: devicet...@vger.kernel.org; Rajan Vaja ; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for > ZynqMP core > > On 2.8.2018 22:59, Stephen Boyd wrote: > > Quoting Michal Simek (2018-07-30 05:50:42) > >> On 26.7.2018 18:36, Stephen Boyd wrote: > >>> Quoting Michal Simek (2018-07-25 02:51:14) > >>>> On 24.7.2018 20:14, Jolly Shah wrote: > >>>>>>> create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h > >>>>>>> create mode 100644 drivers/firmware/xilinx/zynqmp.c create > >>>>>>> mode > >>>>>>> 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h > >>>>>>> create mode 100644 include/linux/firmware/xlnx-zynqmp.h > >>>>>>> > >>>>>> > >>>>>> It looks pretty calm over the last several series that's why when > >>>>>> I get an answer from Stephen or Mike I will take this series via my > >>>>>> tree > and arm-soc tree. > >>>>>> > >>>>>> I have applied 01-08 here > >>>>>> https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc > >>>>>> > >>>>>> Thanks, > >>>>>> Michal > >>>>> > >>>>> > >>>>> Thanks for merging the patches. > >>>>> By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for > firmware bindings (Patch01). Stephen had reviewed clock bindings only. > Please > suggest if I should send a new version with that fix. > >>>> > >>>> I have fixed that in my branch and I have asked Shephen to look at > >>>> clk over chat. > >>>> > >>> > >>> I have some unresolved review comments on v9. I'll give reviewed-by > >>> when that discussion is resolved. > >> > >> ok. Do you want to take them via clk tree or via arm-soc tree? > >> > > > > I'm fine for the clk patch to go via arm-soc if that makes it easier. > > > > ok. Great. > Jolly: Please address all Stephen's comments that we can move. > > Thanks, > Michal Posted V11 patch set with all his comments addressed. Thanks, Jolly Shah
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
On 2.8.2018 22:59, Stephen Boyd wrote: > Quoting Michal Simek (2018-07-30 05:50:42) >> On 26.7.2018 18:36, Stephen Boyd wrote: >>> Quoting Michal Simek (2018-07-25 02:51:14) On 24.7.2018 20:14, Jolly Shah wrote: >>> create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h >>> create mode 100644 drivers/firmware/xilinx/zynqmp.c create mode >>> 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h >>> create mode 100644 include/linux/firmware/xlnx-zynqmp.h >>> >> >> It looks pretty calm over the last several series that's why when I get >> an answer >> from Stephen or Mike I will take this series via my tree and arm-soc >> tree. >> >> I have applied 01-08 here >> https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc >> >> Thanks, >> Michal > > > Thanks for merging the patches. > By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for > firmware bindings (Patch01). Stephen had reviewed clock bindings only. > Please suggest if I should send a new version with that fix. I have fixed that in my branch and I have asked Shephen to look at clk over chat. >>> >>> I have some unresolved review comments on v9. I'll give reviewed-by when >>> that discussion is resolved. >> >> ok. Do you want to take them via clk tree or via arm-soc tree? >> > > I'm fine for the clk patch to go via arm-soc if that makes it easier. > ok. Great. Jolly: Please address all Stephen's comments that we can move. Thanks, Michal
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
On 2.8.2018 22:59, Stephen Boyd wrote: > Quoting Michal Simek (2018-07-30 05:50:42) >> On 26.7.2018 18:36, Stephen Boyd wrote: >>> Quoting Michal Simek (2018-07-25 02:51:14) On 24.7.2018 20:14, Jolly Shah wrote: >>> create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h >>> create mode 100644 drivers/firmware/xilinx/zynqmp.c create mode >>> 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h >>> create mode 100644 include/linux/firmware/xlnx-zynqmp.h >>> >> >> It looks pretty calm over the last several series that's why when I get >> an answer >> from Stephen or Mike I will take this series via my tree and arm-soc >> tree. >> >> I have applied 01-08 here >> https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc >> >> Thanks, >> Michal > > > Thanks for merging the patches. > By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for > firmware bindings (Patch01). Stephen had reviewed clock bindings only. > Please suggest if I should send a new version with that fix. I have fixed that in my branch and I have asked Shephen to look at clk over chat. >>> >>> I have some unresolved review comments on v9. I'll give reviewed-by when >>> that discussion is resolved. >> >> ok. Do you want to take them via clk tree or via arm-soc tree? >> > > I'm fine for the clk patch to go via arm-soc if that makes it easier. > ok. Great. Jolly: Please address all Stephen's comments that we can move. Thanks, Michal
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
Quoting Michal Simek (2018-07-30 05:50:42) > On 26.7.2018 18:36, Stephen Boyd wrote: > > Quoting Michal Simek (2018-07-25 02:51:14) > >> On 24.7.2018 20:14, Jolly Shah wrote: > > create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h > > create mode 100644 drivers/firmware/xilinx/zynqmp.c create mode > > 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h > > create mode 100644 include/linux/firmware/xlnx-zynqmp.h > > > > It looks pretty calm over the last several series that's why when I get > an answer > from Stephen or Mike I will take this series via my tree and arm-soc > tree. > > I have applied 01-08 here > https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc > > Thanks, > Michal > >>> > >>> > >>> Thanks for merging the patches. > >>> By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for > >>> firmware bindings (Patch01). Stephen had reviewed clock bindings only. > >>> Please suggest if I should send a new version with that fix. > >> > >> I have fixed that in my branch and I have asked Shephen to look at clk > >> over chat. > >> > > > > I have some unresolved review comments on v9. I'll give reviewed-by when > > that discussion is resolved. > > ok. Do you want to take them via clk tree or via arm-soc tree? > I'm fine for the clk patch to go via arm-soc if that makes it easier.
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
Quoting Michal Simek (2018-07-30 05:50:42) > On 26.7.2018 18:36, Stephen Boyd wrote: > > Quoting Michal Simek (2018-07-25 02:51:14) > >> On 24.7.2018 20:14, Jolly Shah wrote: > > create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h > > create mode 100644 drivers/firmware/xilinx/zynqmp.c create mode > > 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h > > create mode 100644 include/linux/firmware/xlnx-zynqmp.h > > > > It looks pretty calm over the last several series that's why when I get > an answer > from Stephen or Mike I will take this series via my tree and arm-soc > tree. > > I have applied 01-08 here > https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc > > Thanks, > Michal > >>> > >>> > >>> Thanks for merging the patches. > >>> By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for > >>> firmware bindings (Patch01). Stephen had reviewed clock bindings only. > >>> Please suggest if I should send a new version with that fix. > >> > >> I have fixed that in my branch and I have asked Shephen to look at clk > >> over chat. > >> > > > > I have some unresolved review comments on v9. I'll give reviewed-by when > > that discussion is resolved. > > ok. Do you want to take them via clk tree or via arm-soc tree? > I'm fine for the clk patch to go via arm-soc if that makes it easier.
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
On 26.7.2018 18:36, Stephen Boyd wrote: > Quoting Michal Simek (2018-07-25 02:51:14) >> On 24.7.2018 20:14, Jolly Shah wrote: > create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h > create mode 100644 drivers/firmware/xilinx/zynqmp.c create mode > 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h > create mode 100644 include/linux/firmware/xlnx-zynqmp.h > It looks pretty calm over the last several series that's why when I get an answer from Stephen or Mike I will take this series via my tree and arm-soc tree. I have applied 01-08 here https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc Thanks, Michal >>> >>> >>> Thanks for merging the patches. >>> By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for >>> firmware bindings (Patch01). Stephen had reviewed clock bindings only. >>> Please suggest if I should send a new version with that fix. >> >> I have fixed that in my branch and I have asked Shephen to look at clk >> over chat. >> > > I have some unresolved review comments on v9. I'll give reviewed-by when > that discussion is resolved. ok. Do you want to take them via clk tree or via arm-soc tree? Thanks, Michal
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
On 26.7.2018 18:36, Stephen Boyd wrote: > Quoting Michal Simek (2018-07-25 02:51:14) >> On 24.7.2018 20:14, Jolly Shah wrote: > create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h > create mode 100644 drivers/firmware/xilinx/zynqmp.c create mode > 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h > create mode 100644 include/linux/firmware/xlnx-zynqmp.h > It looks pretty calm over the last several series that's why when I get an answer from Stephen or Mike I will take this series via my tree and arm-soc tree. I have applied 01-08 here https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc Thanks, Michal >>> >>> >>> Thanks for merging the patches. >>> By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for >>> firmware bindings (Patch01). Stephen had reviewed clock bindings only. >>> Please suggest if I should send a new version with that fix. >> >> I have fixed that in my branch and I have asked Shephen to look at clk >> over chat. >> > > I have some unresolved review comments on v9. I'll give reviewed-by when > that discussion is resolved. ok. Do you want to take them via clk tree or via arm-soc tree? Thanks, Michal
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
Quoting Michal Simek (2018-07-25 02:51:14) > On 24.7.2018 20:14, Jolly Shah wrote: > >>> create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h > >>> create mode 100644 drivers/firmware/xilinx/zynqmp.c create mode > >>> 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h > >>> create mode 100644 include/linux/firmware/xlnx-zynqmp.h > >>> > >> > >> It looks pretty calm over the last several series that's why when I get an > >> answer > >> from Stephen or Mike I will take this series via my tree and arm-soc tree. > >> > >> I have applied 01-08 here > >> https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc > >> > >> Thanks, > >> Michal > > > > > > Thanks for merging the patches. > > By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for > > firmware bindings (Patch01). Stephen had reviewed clock bindings only. > > Please suggest if I should send a new version with that fix. > > I have fixed that in my branch and I have asked Shephen to look at clk > over chat. > I have some unresolved review comments on v9. I'll give reviewed-by when that discussion is resolved.
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
Quoting Michal Simek (2018-07-25 02:51:14) > On 24.7.2018 20:14, Jolly Shah wrote: > >>> create mode 100644 drivers/firmware/xilinx/zynqmp-debug.h > >>> create mode 100644 drivers/firmware/xilinx/zynqmp.c create mode > >>> 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h > >>> create mode 100644 include/linux/firmware/xlnx-zynqmp.h > >>> > >> > >> It looks pretty calm over the last several series that's why when I get an > >> answer > >> from Stephen or Mike I will take this series via my tree and arm-soc tree. > >> > >> I have applied 01-08 here > >> https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc > >> > >> Thanks, > >> Michal > > > > > > Thanks for merging the patches. > > By mistake I added “Reviewed-by: Stephen Boyd sb...@kernel.org” for > > firmware bindings (Patch01). Stephen had reviewed clock bindings only. > > Please suggest if I should send a new version with that fix. > > I have fixed that in my branch and I have asked Shephen to look at clk > over chat. > I have some unresolved review comments on v9. I'll give reviewed-by when that discussion is resolved.
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
On 24.7.2018 20:14, Jolly Shah wrote: > Hi Michal, > >> -Original Message- >> From: Michal Simek [mailto:michal.si...@xilinx.com] >> Sent: Thursday, July 19, 2018 3:33 AM >> To: Jolly Shah ; ard.biesheu...@linaro.org; >> mi...@kernel.org; gre...@linuxfoundation.org; m...@codeblueprint.co.uk; >> sudeep.ho...@arm.com; hkallwe...@gmail.com; keesc...@chromium.org; >> dmitry.torok...@gmail.com; mturque...@baylibre.com; >> sb...@codeaurora.org; Michal Simek ; >> robh...@kernel.org; mark.rutl...@arm.com; linux-...@vger.kernel.org >> Cc: Rajan Vaja ; linux-arm-ker...@lists.infradead.org; >> linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; Jolly Shah >> >> Subject: Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river >> for >> ZynqMP core >> >> On 17.7.2018 21:58, Jolly Shah wrote: >>> This patchset is adding communication layer with firmware and clock >>> driver who uses those APIs to communicate with PMU. >>> Firmware driver provides an interface to firmware APIs.Interface APIs >>> can be used by any driver to communicate to PMUFW(Platform Management >> Unit). All requests go through ATF. >>> This patchset adds CCF compliant clock driver for ZynqMP.Clock driver >>> queries supported clock information from firmware and regiters pll and >>> output >> clocks with CCF. >>> v10: >>> - Incorporated code review comments from v9 patch series. Discussed below: >>> https://patchwork.kernel.org/patch/10478575/ >>> https://patchwork.kernel.org/patch/10478457/ >>> https://patchwork.kernel.org/patch/10478461/ >>> https://patchwork.kernel.org/patch/10478463/ >>> >>> v9: >>> - Fixed minor typo comments >>> >>> v8: >>> - Corrected typo in clk Kconfig >>> >>> v7: >>> - Removed xilinx specific clock debugfs API support >>> - Added reviewed-by tags for FW and clock bindings >>> - Updated clock node name to clock-controller >>> >>> v6: >>> - Broke patch series to have base FW driver and Clock driver user >>> - Incorporated code review comments from last FW and Clock driver patch >> series. Discussed below: >>> https://patchwork.kernel.org/patch/10230759/ >>> https://patchwork.kernel.org/patch/10250047/ >>> >>> v5: >>> - Added ATF version check support >>> - Updated some functions to be static >>> - Minor function name corrections >>> >>> v4: >>> - Changed clock setrate/getrate API prototype to support 64 bit rate >>> - Defined macros for get_node_status return values >>> - Moved DT node as a child of firmware >>> - Changed debugfs APIs to return data to debugfs buffer instead of >>> dumping to kernel log >>> - Minor changes to incorporate other review comments from v3 patch >>> series >>> >>> v3: >>> - added some fixes to firmware-ggs.c >>> - updated pinmux get/set function argument names to specify function >>> id instead of node id >>> - added new pinctrl query macros >>> - incorporated review comments from v2 patch series >>> >>> v2: >>> - change SPDX-License-Identifier license text style >>> - split patch into multiple patches >>> - Updated copyrights >>> - Added ABI documentation >>> - incorporated logical review comments from previuos patch. Discussed >> below: >>> https://patchwork.kernel.org/patch/10150665/ >>> >>> Jolly Shah (1): >>> drivers: clk: Add ZynqMP clock driver >>> >>> Rajan Vaja (9): >>> dt-bindings: firmware: Add bindings for ZynqMP firmware >>> firmware: xilinx: Add Zynqmp firmware driver >>> firmware: xilinx: Add zynqmp IOCTL API for device control >>> firmware: xilinx: Add query data API >>> firmware: xilinx: Add clock APIs >>> firmware: xilinx: Add debugfs interface >>> firmware: xilinx: Add debugfs for IOCTL API >>> firmware: xilinx: Add debugfs for query data API >>> dt-bindings: clock: Add bindings for ZynqMP clock driver >>> >>> .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 82 +++ >>> arch/arm64/Kconfig.platforms | 1 + >>> drivers/clk/Kconfig| 1 + >>> drivers/clk/Makefile | 1 + >>> drivers/clk/zynqmp/Kconfig | 10 + >>> drivers/
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
On 24.7.2018 20:14, Jolly Shah wrote: > Hi Michal, > >> -Original Message- >> From: Michal Simek [mailto:michal.si...@xilinx.com] >> Sent: Thursday, July 19, 2018 3:33 AM >> To: Jolly Shah ; ard.biesheu...@linaro.org; >> mi...@kernel.org; gre...@linuxfoundation.org; m...@codeblueprint.co.uk; >> sudeep.ho...@arm.com; hkallwe...@gmail.com; keesc...@chromium.org; >> dmitry.torok...@gmail.com; mturque...@baylibre.com; >> sb...@codeaurora.org; Michal Simek ; >> robh...@kernel.org; mark.rutl...@arm.com; linux-...@vger.kernel.org >> Cc: Rajan Vaja ; linux-arm-ker...@lists.infradead.org; >> linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; Jolly Shah >> >> Subject: Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river >> for >> ZynqMP core >> >> On 17.7.2018 21:58, Jolly Shah wrote: >>> This patchset is adding communication layer with firmware and clock >>> driver who uses those APIs to communicate with PMU. >>> Firmware driver provides an interface to firmware APIs.Interface APIs >>> can be used by any driver to communicate to PMUFW(Platform Management >> Unit). All requests go through ATF. >>> This patchset adds CCF compliant clock driver for ZynqMP.Clock driver >>> queries supported clock information from firmware and regiters pll and >>> output >> clocks with CCF. >>> v10: >>> - Incorporated code review comments from v9 patch series. Discussed below: >>> https://patchwork.kernel.org/patch/10478575/ >>> https://patchwork.kernel.org/patch/10478457/ >>> https://patchwork.kernel.org/patch/10478461/ >>> https://patchwork.kernel.org/patch/10478463/ >>> >>> v9: >>> - Fixed minor typo comments >>> >>> v8: >>> - Corrected typo in clk Kconfig >>> >>> v7: >>> - Removed xilinx specific clock debugfs API support >>> - Added reviewed-by tags for FW and clock bindings >>> - Updated clock node name to clock-controller >>> >>> v6: >>> - Broke patch series to have base FW driver and Clock driver user >>> - Incorporated code review comments from last FW and Clock driver patch >> series. Discussed below: >>> https://patchwork.kernel.org/patch/10230759/ >>> https://patchwork.kernel.org/patch/10250047/ >>> >>> v5: >>> - Added ATF version check support >>> - Updated some functions to be static >>> - Minor function name corrections >>> >>> v4: >>> - Changed clock setrate/getrate API prototype to support 64 bit rate >>> - Defined macros for get_node_status return values >>> - Moved DT node as a child of firmware >>> - Changed debugfs APIs to return data to debugfs buffer instead of >>> dumping to kernel log >>> - Minor changes to incorporate other review comments from v3 patch >>> series >>> >>> v3: >>> - added some fixes to firmware-ggs.c >>> - updated pinmux get/set function argument names to specify function >>> id instead of node id >>> - added new pinctrl query macros >>> - incorporated review comments from v2 patch series >>> >>> v2: >>> - change SPDX-License-Identifier license text style >>> - split patch into multiple patches >>> - Updated copyrights >>> - Added ABI documentation >>> - incorporated logical review comments from previuos patch. Discussed >> below: >>> https://patchwork.kernel.org/patch/10150665/ >>> >>> Jolly Shah (1): >>> drivers: clk: Add ZynqMP clock driver >>> >>> Rajan Vaja (9): >>> dt-bindings: firmware: Add bindings for ZynqMP firmware >>> firmware: xilinx: Add Zynqmp firmware driver >>> firmware: xilinx: Add zynqmp IOCTL API for device control >>> firmware: xilinx: Add query data API >>> firmware: xilinx: Add clock APIs >>> firmware: xilinx: Add debugfs interface >>> firmware: xilinx: Add debugfs for IOCTL API >>> firmware: xilinx: Add debugfs for query data API >>> dt-bindings: clock: Add bindings for ZynqMP clock driver >>> >>> .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 82 +++ >>> arch/arm64/Kconfig.platforms | 1 + >>> drivers/clk/Kconfig| 1 + >>> drivers/clk/Makefile | 1 + >>> drivers/clk/zynqmp/Kconfig | 10 + >>> drivers/
RE: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
Hi Michal, > -Original Message- > From: Michal Simek [mailto:michal.si...@xilinx.com] > Sent: Thursday, July 19, 2018 3:33 AM > To: Jolly Shah ; ard.biesheu...@linaro.org; > mi...@kernel.org; gre...@linuxfoundation.org; m...@codeblueprint.co.uk; > sudeep.ho...@arm.com; hkallwe...@gmail.com; keesc...@chromium.org; > dmitry.torok...@gmail.com; mturque...@baylibre.com; > sb...@codeaurora.org; Michal Simek ; > robh...@kernel.org; mark.rutl...@arm.com; linux-...@vger.kernel.org > Cc: Rajan Vaja ; linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; Jolly Shah > > Subject: Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for > ZynqMP core > > On 17.7.2018 21:58, Jolly Shah wrote: > > This patchset is adding communication layer with firmware and clock > > driver who uses those APIs to communicate with PMU. > > Firmware driver provides an interface to firmware APIs.Interface APIs > > can be used by any driver to communicate to PMUFW(Platform Management > Unit). All requests go through ATF. > > This patchset adds CCF compliant clock driver for ZynqMP.Clock driver > > queries supported clock information from firmware and regiters pll and > > output > clocks with CCF. > > v10: > > - Incorporated code review comments from v9 patch series. Discussed below: > > https://patchwork.kernel.org/patch/10478575/ > > https://patchwork.kernel.org/patch/10478457/ > > https://patchwork.kernel.org/patch/10478461/ > > https://patchwork.kernel.org/patch/10478463/ > > > > v9: > > - Fixed minor typo comments > > > > v8: > > - Corrected typo in clk Kconfig > > > > v7: > > - Removed xilinx specific clock debugfs API support > > - Added reviewed-by tags for FW and clock bindings > > - Updated clock node name to clock-controller > > > > v6: > > - Broke patch series to have base FW driver and Clock driver user > > - Incorporated code review comments from last FW and Clock driver patch > series. Discussed below: > > https://patchwork.kernel.org/patch/10230759/ > > https://patchwork.kernel.org/patch/10250047/ > > > > v5: > > - Added ATF version check support > > - Updated some functions to be static > > - Minor function name corrections > > > > v4: > > - Changed clock setrate/getrate API prototype to support 64 bit rate > > - Defined macros for get_node_status return values > > - Moved DT node as a child of firmware > > - Changed debugfs APIs to return data to debugfs buffer instead of > > dumping to kernel log > > - Minor changes to incorporate other review comments from v3 patch > > series > > > > v3: > > - added some fixes to firmware-ggs.c > > - updated pinmux get/set function argument names to specify function > > id instead of node id > > - added new pinctrl query macros > > - incorporated review comments from v2 patch series > > > > v2: > > - change SPDX-License-Identifier license text style > > - split patch into multiple patches > > - Updated copyrights > > - Added ABI documentation > > - incorporated logical review comments from previuos patch. Discussed > below: > > https://patchwork.kernel.org/patch/10150665/ > > > > Jolly Shah (1): > > drivers: clk: Add ZynqMP clock driver > > > > Rajan Vaja (9): > > dt-bindings: firmware: Add bindings for ZynqMP firmware > > firmware: xilinx: Add Zynqmp firmware driver > > firmware: xilinx: Add zynqmp IOCTL API for device control > > firmware: xilinx: Add query data API > > firmware: xilinx: Add clock APIs > > firmware: xilinx: Add debugfs interface > > firmware: xilinx: Add debugfs for IOCTL API > > firmware: xilinx: Add debugfs for query data API > > dt-bindings: clock: Add bindings for ZynqMP clock driver > > > > .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 82 +++ > > arch/arm64/Kconfig.platforms | 1 + > > drivers/clk/Kconfig| 1 + > > drivers/clk/Makefile | 1 + > > drivers/clk/zynqmp/Kconfig | 10 + > > drivers/clk/zynqmp/Makefile| 4 + > > drivers/clk/zynqmp/clk-gate-zynqmp.c | 144 + > > drivers/clk/zynqmp/clk-mux-zynqmp.c| 141 > > drivers/clk/zynqmp/clk-zynqmp.h| 68 ++ > > drivers/clk/zynqmp/clkc.c | 719 > > +
RE: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
Hi Michal, > -Original Message- > From: Michal Simek [mailto:michal.si...@xilinx.com] > Sent: Thursday, July 19, 2018 3:33 AM > To: Jolly Shah ; ard.biesheu...@linaro.org; > mi...@kernel.org; gre...@linuxfoundation.org; m...@codeblueprint.co.uk; > sudeep.ho...@arm.com; hkallwe...@gmail.com; keesc...@chromium.org; > dmitry.torok...@gmail.com; mturque...@baylibre.com; > sb...@codeaurora.org; Michal Simek ; > robh...@kernel.org; mark.rutl...@arm.com; linux-...@vger.kernel.org > Cc: Rajan Vaja ; linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; Jolly Shah > > Subject: Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for > ZynqMP core > > On 17.7.2018 21:58, Jolly Shah wrote: > > This patchset is adding communication layer with firmware and clock > > driver who uses those APIs to communicate with PMU. > > Firmware driver provides an interface to firmware APIs.Interface APIs > > can be used by any driver to communicate to PMUFW(Platform Management > Unit). All requests go through ATF. > > This patchset adds CCF compliant clock driver for ZynqMP.Clock driver > > queries supported clock information from firmware and regiters pll and > > output > clocks with CCF. > > v10: > > - Incorporated code review comments from v9 patch series. Discussed below: > > https://patchwork.kernel.org/patch/10478575/ > > https://patchwork.kernel.org/patch/10478457/ > > https://patchwork.kernel.org/patch/10478461/ > > https://patchwork.kernel.org/patch/10478463/ > > > > v9: > > - Fixed minor typo comments > > > > v8: > > - Corrected typo in clk Kconfig > > > > v7: > > - Removed xilinx specific clock debugfs API support > > - Added reviewed-by tags for FW and clock bindings > > - Updated clock node name to clock-controller > > > > v6: > > - Broke patch series to have base FW driver and Clock driver user > > - Incorporated code review comments from last FW and Clock driver patch > series. Discussed below: > > https://patchwork.kernel.org/patch/10230759/ > > https://patchwork.kernel.org/patch/10250047/ > > > > v5: > > - Added ATF version check support > > - Updated some functions to be static > > - Minor function name corrections > > > > v4: > > - Changed clock setrate/getrate API prototype to support 64 bit rate > > - Defined macros for get_node_status return values > > - Moved DT node as a child of firmware > > - Changed debugfs APIs to return data to debugfs buffer instead of > > dumping to kernel log > > - Minor changes to incorporate other review comments from v3 patch > > series > > > > v3: > > - added some fixes to firmware-ggs.c > > - updated pinmux get/set function argument names to specify function > > id instead of node id > > - added new pinctrl query macros > > - incorporated review comments from v2 patch series > > > > v2: > > - change SPDX-License-Identifier license text style > > - split patch into multiple patches > > - Updated copyrights > > - Added ABI documentation > > - incorporated logical review comments from previuos patch. Discussed > below: > > https://patchwork.kernel.org/patch/10150665/ > > > > Jolly Shah (1): > > drivers: clk: Add ZynqMP clock driver > > > > Rajan Vaja (9): > > dt-bindings: firmware: Add bindings for ZynqMP firmware > > firmware: xilinx: Add Zynqmp firmware driver > > firmware: xilinx: Add zynqmp IOCTL API for device control > > firmware: xilinx: Add query data API > > firmware: xilinx: Add clock APIs > > firmware: xilinx: Add debugfs interface > > firmware: xilinx: Add debugfs for IOCTL API > > firmware: xilinx: Add debugfs for query data API > > dt-bindings: clock: Add bindings for ZynqMP clock driver > > > > .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 82 +++ > > arch/arm64/Kconfig.platforms | 1 + > > drivers/clk/Kconfig| 1 + > > drivers/clk/Makefile | 1 + > > drivers/clk/zynqmp/Kconfig | 10 + > > drivers/clk/zynqmp/Makefile| 4 + > > drivers/clk/zynqmp/clk-gate-zynqmp.c | 144 + > > drivers/clk/zynqmp/clk-mux-zynqmp.c| 141 > > drivers/clk/zynqmp/clk-zynqmp.h| 68 ++ > > drivers/clk/zynqmp/clkc.c | 719 > > +
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
On 17.7.2018 21:58, Jolly Shah wrote: > This patchset is adding communication layer with firmware and clock driver > who uses > those APIs to communicate with PMU. > Firmware driver provides an interface to firmware APIs.Interface APIs can be > used by any driver to communicate to > PMUFW(Platform Management Unit). All requests go through ATF. > This patchset adds CCF compliant clock driver for ZynqMP.Clock driver queries > supported clock information from > firmware and regiters pll and output clocks with CCF. > v10: > - Incorporated code review comments from v9 patch series. Discussed below: > https://patchwork.kernel.org/patch/10478575/ > https://patchwork.kernel.org/patch/10478457/ > https://patchwork.kernel.org/patch/10478461/ > https://patchwork.kernel.org/patch/10478463/ > > v9: > - Fixed minor typo comments > > v8: > - Corrected typo in clk Kconfig > > v7: > - Removed xilinx specific clock debugfs API support > - Added reviewed-by tags for FW and clock bindings > - Updated clock node name to clock-controller > > v6: > - Broke patch series to have base FW driver and Clock driver user > - Incorporated code review comments from last FW and Clock driver patch > series. Discussed below: > https://patchwork.kernel.org/patch/10230759/ > https://patchwork.kernel.org/patch/10250047/ > > v5: > - Added ATF version check support > - Updated some functions to be static > - Minor function name corrections > > v4: > - Changed clock setrate/getrate API prototype to support 64 bit rate > - Defined macros for get_node_status return values > - Moved DT node as a child of firmware > - Changed debugfs APIs to return data to debugfs buffer instead of dumping > to kernel log > - Minor changes to incorporate other review comments from v3 patch series > > v3: > - added some fixes to firmware-ggs.c > - updated pinmux get/set function argument names to specify function id > instead of node id > - added new pinctrl query macros > - incorporated review comments from v2 patch series > > v2: > - change SPDX-License-Identifier license text style > - split patch into multiple patches > - Updated copyrights > - Added ABI documentation > - incorporated logical review comments from previuos patch. Discussed below: > https://patchwork.kernel.org/patch/10150665/ > > Jolly Shah (1): > drivers: clk: Add ZynqMP clock driver > > Rajan Vaja (9): > dt-bindings: firmware: Add bindings for ZynqMP firmware > firmware: xilinx: Add Zynqmp firmware driver > firmware: xilinx: Add zynqmp IOCTL API for device control > firmware: xilinx: Add query data API > firmware: xilinx: Add clock APIs > firmware: xilinx: Add debugfs interface > firmware: xilinx: Add debugfs for IOCTL API > firmware: xilinx: Add debugfs for query data API > dt-bindings: clock: Add bindings for ZynqMP clock driver > > .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 82 +++ > arch/arm64/Kconfig.platforms | 1 + > drivers/clk/Kconfig| 1 + > drivers/clk/Makefile | 1 + > drivers/clk/zynqmp/Kconfig | 10 + > drivers/clk/zynqmp/Makefile| 4 + > drivers/clk/zynqmp/clk-gate-zynqmp.c | 144 + > drivers/clk/zynqmp/clk-mux-zynqmp.c| 141 > drivers/clk/zynqmp/clk-zynqmp.h| 68 ++ > drivers/clk/zynqmp/clkc.c | 719 > + > drivers/clk/zynqmp/divider.c | 217 +++ > drivers/clk/zynqmp/pll.c | 335 ++ > drivers/firmware/Kconfig | 1 + > drivers/firmware/Makefile | 1 + > drivers/firmware/xilinx/Kconfig| 23 + > drivers/firmware/xilinx/Makefile | 5 + > drivers/firmware/xilinx/zynqmp-debug.c | 249 +++ > drivers/firmware/xilinx/zynqmp-debug.h | 22 + > drivers/firmware/xilinx/zynqmp.c | 562 > include/dt-bindings/clock/xlnx,zynqmp-clk.h| 116 > include/linux/firmware/xlnx-zynqmp.h | 116 > 21 files changed, 2818 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > create mode 100644 drivers/clk/zynqmp/Kconfig > create mode 100644 drivers/clk/zynqmp/Makefile > create mode 100644 drivers/clk/zynqmp/clk-gate-zynqmp.c > create mode 100644 drivers/clk/zynqmp/clk-mux-zynqmp.c > create mode 100644 drivers/clk/zynqmp/clk-zynqmp.h > create mode 100644 drivers/clk/zynqmp/clkc.c > create mode 100644 drivers/clk/zynqmp/divider.c > create mode 100644 drivers/clk/zynqmp/pll.c > create mode 100644 drivers/firmware/xilinx/Kconfig > create mode 100644 drivers/firmware/xilinx/Makefile > create mode 100644
Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core
On 17.7.2018 21:58, Jolly Shah wrote: > This patchset is adding communication layer with firmware and clock driver > who uses > those APIs to communicate with PMU. > Firmware driver provides an interface to firmware APIs.Interface APIs can be > used by any driver to communicate to > PMUFW(Platform Management Unit). All requests go through ATF. > This patchset adds CCF compliant clock driver for ZynqMP.Clock driver queries > supported clock information from > firmware and regiters pll and output clocks with CCF. > v10: > - Incorporated code review comments from v9 patch series. Discussed below: > https://patchwork.kernel.org/patch/10478575/ > https://patchwork.kernel.org/patch/10478457/ > https://patchwork.kernel.org/patch/10478461/ > https://patchwork.kernel.org/patch/10478463/ > > v9: > - Fixed minor typo comments > > v8: > - Corrected typo in clk Kconfig > > v7: > - Removed xilinx specific clock debugfs API support > - Added reviewed-by tags for FW and clock bindings > - Updated clock node name to clock-controller > > v6: > - Broke patch series to have base FW driver and Clock driver user > - Incorporated code review comments from last FW and Clock driver patch > series. Discussed below: > https://patchwork.kernel.org/patch/10230759/ > https://patchwork.kernel.org/patch/10250047/ > > v5: > - Added ATF version check support > - Updated some functions to be static > - Minor function name corrections > > v4: > - Changed clock setrate/getrate API prototype to support 64 bit rate > - Defined macros for get_node_status return values > - Moved DT node as a child of firmware > - Changed debugfs APIs to return data to debugfs buffer instead of dumping > to kernel log > - Minor changes to incorporate other review comments from v3 patch series > > v3: > - added some fixes to firmware-ggs.c > - updated pinmux get/set function argument names to specify function id > instead of node id > - added new pinctrl query macros > - incorporated review comments from v2 patch series > > v2: > - change SPDX-License-Identifier license text style > - split patch into multiple patches > - Updated copyrights > - Added ABI documentation > - incorporated logical review comments from previuos patch. Discussed below: > https://patchwork.kernel.org/patch/10150665/ > > Jolly Shah (1): > drivers: clk: Add ZynqMP clock driver > > Rajan Vaja (9): > dt-bindings: firmware: Add bindings for ZynqMP firmware > firmware: xilinx: Add Zynqmp firmware driver > firmware: xilinx: Add zynqmp IOCTL API for device control > firmware: xilinx: Add query data API > firmware: xilinx: Add clock APIs > firmware: xilinx: Add debugfs interface > firmware: xilinx: Add debugfs for IOCTL API > firmware: xilinx: Add debugfs for query data API > dt-bindings: clock: Add bindings for ZynqMP clock driver > > .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 82 +++ > arch/arm64/Kconfig.platforms | 1 + > drivers/clk/Kconfig| 1 + > drivers/clk/Makefile | 1 + > drivers/clk/zynqmp/Kconfig | 10 + > drivers/clk/zynqmp/Makefile| 4 + > drivers/clk/zynqmp/clk-gate-zynqmp.c | 144 + > drivers/clk/zynqmp/clk-mux-zynqmp.c| 141 > drivers/clk/zynqmp/clk-zynqmp.h| 68 ++ > drivers/clk/zynqmp/clkc.c | 719 > + > drivers/clk/zynqmp/divider.c | 217 +++ > drivers/clk/zynqmp/pll.c | 335 ++ > drivers/firmware/Kconfig | 1 + > drivers/firmware/Makefile | 1 + > drivers/firmware/xilinx/Kconfig| 23 + > drivers/firmware/xilinx/Makefile | 5 + > drivers/firmware/xilinx/zynqmp-debug.c | 249 +++ > drivers/firmware/xilinx/zynqmp-debug.h | 22 + > drivers/firmware/xilinx/zynqmp.c | 562 > include/dt-bindings/clock/xlnx,zynqmp-clk.h| 116 > include/linux/firmware/xlnx-zynqmp.h | 116 > 21 files changed, 2818 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > create mode 100644 drivers/clk/zynqmp/Kconfig > create mode 100644 drivers/clk/zynqmp/Makefile > create mode 100644 drivers/clk/zynqmp/clk-gate-zynqmp.c > create mode 100644 drivers/clk/zynqmp/clk-mux-zynqmp.c > create mode 100644 drivers/clk/zynqmp/clk-zynqmp.h > create mode 100644 drivers/clk/zynqmp/clkc.c > create mode 100644 drivers/clk/zynqmp/divider.c > create mode 100644 drivers/clk/zynqmp/pll.c > create mode 100644 drivers/firmware/xilinx/Kconfig > create mode 100644 drivers/firmware/xilinx/Makefile > create mode 100644
