RE: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts
> > The change log is near the end of the patch: > > /** > > -- > > Changelog v2 > > *mdio interrupt mode or polling mode will depends on mdio interrupt > > enable bit *Disable the mdio interrupt enable bit in stmmac_release > > *Remove the condition for initialize wait queues *Applied reverse > > Christmas tree > > 1.9.1 > > At the end, nobody sees it, because everybody else does it at the > beginning. > > https://www.kernel.org/doc/html/latest/process/submitting- > patches.html?highlight=submitting#the-canonical-patch-format > > This talks about the ---. David prefers to see the change log before the > ---. Other maintainers want it after the ---. > > > > > > > > > The formatting of this patch also looks a bit odd. Did you use git > > > format-patch ; git send-email? > > > > Yes, I do git format-patch, then ./scripts/checkpatch.pl. > > Lastly git send-email > > What looked odd is the missing --- marker. git format-patch should of > create that as part of the patch. > >Andrew I found out why as I did a git format-patch with -p which is without the Stat. I will resent v3 to using correct format. Weifeng
Re: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts
> > The change log is near the end of the patch: > /** > -- > Changelog v2 > *mdio interrupt mode or polling mode will depends on mdio interrupt enable bit > *Disable the mdio interrupt enable bit in stmmac_release > *Remove the condition for initialize wait queues > *Applied reverse Christmas tree > 1.9.1 At the end, nobody sees it, because everybody else does it at the beginning. https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=submitting#the-canonical-patch-format This talks about the ---. David prefers to see the change log before the ---. Other maintainers want it after the ---. > > > > > The formatting of this patch also looks a bit odd. Did you use git > > format-patch ; git send-email? > > Yes, I do git format-patch, then ./scripts/checkpatch.pl. > Lastly git send-email What looked odd is the missing --- marker. git format-patch should of create that as part of the patch. Andrew
RE: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts
> On Wed, Sep 04, 2019 at 10:02:54PM +0800, Voon Weifeng wrote: > > From: "Chuah, Kim Tatt" > > > > DW EQoS v5.xx controllers added capability for interrupt generation > > when MDIO interface is done (GMII Busy bit is cleared). > > This patch adds support for this interrupt on supported HW to avoid > > polling on GMII Busy bit. > > > > stmmac_mdio_read() & stmmac_mdio_write() will sleep until wake_up() is > > called by the interrupt handler. > > > > Reviewed-by: Voon Weifeng > > Reviewed-by: Kweh, Hock Leong > > Reviewed-by: Ong Boon Leong > > Signed-off-by: Chuah, Kim Tatt > > Signed-off-by: Ong Boon Leong > > Signed-off-by: Voon Weifeng > > Hi Voon > > It is normal to include a short description of what you changed between > the previous version and this version. The change log is near the end of the patch: /** -- Changelog v2 *mdio interrupt mode or polling mode will depends on mdio interrupt enable bit *Disable the mdio interrupt enable bit in stmmac_release *Remove the condition for initialize wait queues *Applied reverse Christmas tree 1.9.1 > > The formatting of this patch also looks a bit odd. Did you use git > format-patch ; git send-email? Yes, I do git format-patch, then ./scripts/checkpatch.pl. Lastly git send-email > > Thanks > Andrew
Re: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts
On Wed, Sep 04, 2019 at 10:02:54PM +0800, Voon Weifeng wrote: > From: "Chuah, Kim Tatt" > > DW EQoS v5.xx controllers added capability for interrupt generation > when MDIO interface is done (GMII Busy bit is cleared). > This patch adds support for this interrupt on supported HW to avoid > polling on GMII Busy bit. > > stmmac_mdio_read() & stmmac_mdio_write() will sleep until wake_up() is > called by the interrupt handler. > > Reviewed-by: Voon Weifeng > Reviewed-by: Kweh, Hock Leong > Reviewed-by: Ong Boon Leong > Signed-off-by: Chuah, Kim Tatt > Signed-off-by: Ong Boon Leong > Signed-off-by: Voon Weifeng Hi Voon It is normal to include a short description of what you changed between the previous version and this version. The formatting of this patch also looks a bit odd. Did you use git format-patch ; git send-email? Thanks Andrew
