date:20130322

[PATCH 0/2] davinci: vpss: clock cleanup

2013-03-22 Thread Prabhakar lad

From: Lad, Prabhakar 

This patch series cleanup's the VPSS clock enabling.
The first patch removes vpss clock enabling from the capture
drivers and moves it to the VPSS driver itself.
The second patch moves the venc_enable_vpss_clock() to the driver
which was being done in platform code.

Lad, Prabhakar (2):
  media: davinci: vpss: enable vpss clocks
  media: davinci: vpbe: venc: move the enabling of vpss clocks to
driver

 arch/arm/mach-davinci/dm355.c|3 -
 arch/arm/mach-davinci/dm365.c|9 +++-
 arch/arm/mach-davinci/dm644x.c   |5 --
 drivers/media/platform/davinci/dm355_ccdc.c  |   39 +
 drivers/media/platform/davinci/dm644x_ccdc.c |   44 ---
 drivers/media/platform/davinci/isif.c|   28 ++--
 drivers/media/platform/davinci/vpbe_venc.c   |   26 +++
 drivers/media/platform/davinci/vpss.c|   60 ++
 8 files changed, 98 insertions(+), 116 deletions(-)

-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] media: davinci: vpss: enable vpss clocks

2013-03-22 Thread Prabhakar lad

From: Lad, Prabhakar 

By default the VPSS clocks are only enabled in capture driver
for davinci family which creates duplicates. This
patch adds support to enable the VPSS clocks in VPSS driver.
This avoids duplication of code and also adding clock aliases.
This patch cleanups the VPSS clock enabling in the capture driver,
and also removes the clock alias in machine file. Along side adds
a vpss slave clock for DM365 as mentioned by Sekhar
(https://patchwork.kernel.org/patch/1221261/).

Signed-off-by: Lad, Prabhakar 
---
 arch/arm/mach-davinci/dm355.c|3 -
 arch/arm/mach-davinci/dm365.c|9 +++-
 arch/arm/mach-davinci/dm644x.c   |5 --
 drivers/media/platform/davinci/dm355_ccdc.c  |   39 +
 drivers/media/platform/davinci/dm644x_ccdc.c |   44 ---
 drivers/media/platform/davinci/isif.c|   28 ++--
 drivers/media/platform/davinci/vpss.c|   60 ++
 7 files changed, 72 insertions(+), 116 deletions(-)

diff --git a/arch/arm/mach-davinci/dm355.c b/arch/arm/mach-davinci/dm355.c
index b49c3b7..a917983 100644
--- a/arch/arm/mach-davinci/dm355.c
+++ b/arch/arm/mach-davinci/dm355.c
@@ -873,9 +873,6 @@ static int __init dm355_init_devices(void)
if (!cpu_is_davinci_dm355())
return 0;
 
-   /* Add ccdc clock aliases */
-   clk_add_alias("master", dm355_ccdc_dev.name, "vpss_master", NULL);
-   clk_add_alias("slave", dm355_ccdc_dev.name, "vpss_master", NULL);
davinci_cfg_reg(DM355_INT_EDMA_CC);
platform_device_register(&dm355_edma_device);
platform_device_register(&dm355_vpss_device);
diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c
index 6c39805..f4c19f7 100644
--- a/arch/arm/mach-davinci/dm365.c
+++ b/arch/arm/mach-davinci/dm365.c
@@ -257,6 +257,12 @@ static struct clk vpss_master_clk = {
.flags  = CLK_PSC,
 };
 
+static struct clk vpss_slave_clk = {
+   .name   = "vpss_slave",
+   .parent = &pll1_sysclk5,
+   .lpsc   = DAVINCI_LPSC_VPSSSLV,
+};
+
 static struct clk arm_clk = {
.name   = "arm_clk",
.parent = &pll2_sysclk2,
@@ -450,6 +456,7 @@ static struct clk_lookup dm365_clks[] = {
CLK(NULL, "pll2_sysclk9", &pll2_sysclk9),
CLK(NULL, "vpss_dac", &vpss_dac_clk),
CLK(NULL, "vpss_master", &vpss_master_clk),
+   CLK(NULL, "vpss_slave", &vpss_slave_clk),
CLK(NULL, "arm", &arm_clk),
CLK(NULL, "uart0", &uart0_clk),
CLK(NULL, "uart1", &uart1_clk),
@@ -1239,8 +1246,6 @@ static int __init dm365_init_devices(void)
clk_add_alias(NULL, dev_name(&dm365_mdio_device.dev),
  NULL, &dm365_emac_device.dev);
 
-   /* Add isif clock alias */
-   clk_add_alias("master", dm365_isif_dev.name, "vpss_master", NULL);
platform_device_register(&dm365_vpss_device);
platform_device_register(&dm365_isif_dev);
platform_device_register(&vpfe_capture_dev);
diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c
index ee0e994..026e7e3 100644
--- a/arch/arm/mach-davinci/dm644x.c
+++ b/arch/arm/mach-davinci/dm644x.c
@@ -901,11 +901,6 @@ int __init dm644x_init_video(struct vpfe_config *vpfe_cfg,
dm644x_vpfe_dev.dev.platform_data = vpfe_cfg;
platform_device_register(&dm644x_ccdc_dev);
platform_device_register(&dm644x_vpfe_dev);
-   /* Add ccdc clock aliases */
-   clk_add_alias("master", dm644x_ccdc_dev.name,
- "vpss_master", NULL);
-   clk_add_alias("slave", dm644x_ccdc_dev.name,
- "vpss_slave", NULL);
}
 
if (vpbe_cfg) {
diff --git a/drivers/media/platform/davinci/dm355_ccdc.c 
b/drivers/media/platform/davinci/dm355_ccdc.c
index 2364dba..05f8fb7 100644
--- a/drivers/media/platform/davinci/dm355_ccdc.c
+++ b/drivers/media/platform/davinci/dm355_ccdc.c
@@ -37,7 +37,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
@@ -59,10 +58,6 @@ static struct ccdc_oper_config {
struct ccdc_params_raw bayer;
/* YCbCr configuration */
struct ccdc_params_ycbcr ycbcr;
-   /* Master clock */
-   struct clk *mclk;
-   /* slave clock */
-   struct clk *sclk;
/* ccdc base address */
void __iomem *base_addr;
 } ccdc_cfg = {
@@ -997,32 +992,10 @@ static int dm355_ccdc_probe(struct platform_device *pdev)
goto fail_nomem;
}
 
-   /* Get and enable Master clock */
-   ccdc_cfg.mclk = clk_get(&pdev->dev, "master");
-   if (IS_ERR(ccdc_cfg.mclk)) {
-   status = PTR_ERR(ccdc_cfg.mclk);
-   goto fail_nomap;
-   }
-   if (clk_prepare_enable(ccdc_cfg.mclk)) {
-   status = -ENODEV;
-   goto fail_mclk;
-   }
-
-   /* Get and enable Slave c

[PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-03-22 Thread Prabhakar lad

From: Lad, Prabhakar 

The vpss clocks were enabled by calling a exported function from a driver
in a machine code. calling driver code from platform code is incorrect way.

This patch fixes this issue and calls the function from driver code itself.

Signed-off-by: Lad, Prabhakar 
---
 Note: This patch is based on the comment from Sekhar
  (https://patchwork-mail1.kernel.org/patch/2278441/).
  Shekar I haven't completely removed the callback, I just added
  the function calls after the callback. As you mentioned just to
  pass the VPSS_CLK_CTRL as a resource to venc but the VPSS_CLK_CTRL
  is already being used by VPSS driver. I'll take this cleanup task later
  point of time.

 drivers/media/platform/davinci/vpbe_venc.c |   26 ++
 1 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/drivers/media/platform/davinci/vpbe_venc.c 
b/drivers/media/platform/davinci/vpbe_venc.c
index f15f211..26bdf9b 100644
--- a/drivers/media/platform/davinci/vpbe_venc.c
+++ b/drivers/media/platform/davinci/vpbe_venc.c
@@ -202,6 +202,26 @@ static void venc_enabledigitaloutput(struct v4l2_subdev 
*sd, int benable)
}
 }
 
+static void
+venc_enable_vpss_clock(int venc_type,
+  enum vpbe_enc_timings_type type,
+  unsigned int pclock)
+{
+   if (venc_type == VPBE_VERSION_1)
+   return;
+
+   if (venc_type == VPBE_VERSION_2 && (type == VPBE_ENC_STD ||
+   (type == VPBE_ENC_DV_TIMINGS && pclock <= 2700))) {
+   vpss_enable_clock(VPSS_VENC_CLOCK_SEL, 1);
+   vpss_enable_clock(VPSS_VPBE_CLOCK, 1);
+   return;
+   }
+
+   if (venc_type == VPBE_VERSION_3 && type == VPBE_ENC_STD)
+   vpss_enable_clock(VPSS_VENC_CLOCK_SEL, 0);
+
+}
+
 #define VDAC_CONFIG_SD_V3  0x0E21A6B6
 #define VDAC_CONFIG_SD_V2  0x081141CF
 /*
@@ -220,6 +240,7 @@ static int venc_set_ntsc(struct v4l2_subdev *sd)
if (pdata->setup_clock(VPBE_ENC_STD, V4L2_STD_525_60) < 0)
return -EINVAL;
 
+   venc_enable_vpss_clock(venc->venc_type, VPBE_ENC_STD, V4L2_STD_525_60);
venc_enabledigitaloutput(sd, 0);
 
if (venc->venc_type == VPBE_VERSION_3) {
@@ -265,6 +286,7 @@ static int venc_set_pal(struct v4l2_subdev *sd)
if (venc->pdata->setup_clock(VPBE_ENC_STD, V4L2_STD_625_50) < 0)
return -EINVAL;
 
+   venc_enable_vpss_clock(venc->venc_type, VPBE_ENC_STD, V4L2_STD_625_50);
venc_enabledigitaloutput(sd, 0);
 
if (venc->venc_type == VPBE_VERSION_3) {
@@ -319,6 +341,7 @@ static int venc_set_480p59_94(struct v4l2_subdev *sd)
if (pdata->setup_clock(VPBE_ENC_DV_TIMINGS, 2700) < 0)
return -EINVAL;
 
+   venc_enable_vpss_clock(venc->venc_type, VPBE_ENC_DV_TIMINGS, 2700);
venc_enabledigitaloutput(sd, 0);
 
if (venc->venc_type == VPBE_VERSION_2)
@@ -366,6 +389,7 @@ static int venc_set_576p50(struct v4l2_subdev *sd)
if (pdata->setup_clock(VPBE_ENC_DV_TIMINGS, 2700) < 0)
return -EINVAL;
 
+   venc_enable_vpss_clock(venc->venc_type, VPBE_ENC_DV_TIMINGS, 2700);
venc_enabledigitaloutput(sd, 0);
 
if (venc->venc_type == VPBE_VERSION_2)
@@ -406,6 +430,7 @@ static int venc_set_720p60_internal(struct v4l2_subdev *sd)
if (pdata->setup_clock(VPBE_ENC_DV_TIMINGS, 7425) < 0)
return -EINVAL;
 
+   venc_enable_vpss_clock(venc->venc_type, VPBE_ENC_DV_TIMINGS, 7425);
venc_enabledigitaloutput(sd, 0);
 
venc_write(sd, VENC_OSDCLK0, 0);
@@ -434,6 +459,7 @@ static int venc_set_1080i30_internal(struct v4l2_subdev *sd)
if (pdata->setup_clock(VPBE_ENC_DV_TIMINGS, 7425) < 0)
return -EINVAL;
 
+   venc_enable_vpss_clock(venc->venc_type, VPBE_ENC_DV_TIMINGS, 7425);
venc_enabledigitaloutput(sd, 0);
 
venc_write(sd, VENC_OSDCLK0, 0);
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: media-tree build is broken

2013-03-22 Thread Mauro Carvalho Chehab

Em Thu, 21 Mar 2013 19:16:55 +0100
Frank Schäfer  escreveu:

> ...
> Kernel: arch/x86/boot/bzImage is ready  (#2)
> ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined!
> make[1]: *** [__modpost] Fehler 1
> make: *** [modules] Fehler 2
> 
> 
> Mauro, I assume this is caused by one of the recent Siano patches ?

I tried to debug this one, but I couldn't reproduce it here. Not sure why,
but I'm not capable of producing those errors here for a long time.

Maybe the gcc compiler version currently provided with Fedora 18 doesn't
require any library for 64-bit divisions, even when compiling for a
32 bits Kernel.

Anyway, I'm almost sure that the following patch fixes the issue.
Please test.

Regards,
Mauro.

-

PATCH] [media] siano: use do_div() for 64-bits division

As reported by Frank Schäfer :
ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined!

Reported-by: Frank Schäfer 
Signed-off-by: Mauro Carvalho Chehab 

diff --git a/drivers/media/common/siano/smsdvb-main.c 
b/drivers/media/common/siano/smsdvb-main.c
index d965a7a..297f1b2 100644
--- a/drivers/media/common/siano/smsdvb-main.c
+++ b/drivers/media/common/siano/smsdvb-main.c
@@ -22,6 +22,7 @@ along with this program.  If not, see 
.
 #include 
 #include 
 #include 
+#include 
 
 #include "dmxdev.h"
 #include "dvbdev.h"
@@ -244,6 +245,7 @@ static void smsdvb_update_per_slices(struct smsdvb_client_t 
*client,
 {
struct dvb_frontend *fe = &client->frontend;
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
+   u64 tmp;
 
client->fe_status = sms_to_status(p->is_demod_locked, p->is_rf_locked);
c->modulation = sms_to_modulation(p->constellation);
@@ -272,8 +274,9 @@ static void smsdvb_update_per_slices(struct smsdvb_client_t 
*client,
c->post_bit_count.stat[0].uvalue += p->ber_bit_count;
 
/* Legacy PER/BER */
-   client->legacy_per = (p->ets_packets * 65535) /
-(p->ts_packets + p->ets_packets);
+   tmp = p->ets_packets * 65535;
+   do_div(tmp, p->ts_packets + p->ets_packets);
+   client->legacy_per = tmp;
 }
 
 static void smsdvb_update_dvb_stats(struct smsdvb_client_t *client,
@@ -803,7 +806,7 @@ static int smsdvb_read_snr(struct dvb_frontend *fe, u16 
*snr)
rc = smsdvb_send_statistics_request(client);
 
/* Preferred scale for SNR with legacy API: 0.1 dB */
-   *snr = c->cnr.stat[0].svalue / 100;
+   *snr = ((u32)c->cnr.stat[0].svalue) / 100;
 
led_feedback(client);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-22 Thread Hans Verkuil

Hi Mauro,

I've attached the dumps:

ok.txt is tested with commit aab3125c43d8fecc7134e5f1e729fabf4dd196da^ (i.e.
the commit right before the failing commit).

fail.txt is tested with commit aab3125c43d8fecc7134e5f1e729fabf4dd196da and
fail-with-patch.txt is tested with the same commit + your i2c speed patch.

Test sequence: start the sniffer, insert the stick, run v4l2-ctl -f 61.25 to
change the frequency. All on the same PC. Note that this PC is different from
the one I used yesterday, so it is not specific to one unlucky hardware
combination.

Regards,

Hans

On Thu March 21 2013 17:23:44 Mauro Carvalho Chehab wrote:
> Em Thu, 21 Mar 2013 16:34:13 +0100
> Hans Verkuil  escreveu:
> 
> > On Thu March 21 2013 11:03:27 Mauro Carvalho Chehab wrote:
> > > Em Thu, 21 Mar 2013 09:33:41 +0100
> > > Hans Verkuil  escreveu:
> > > 
> > > > I tried to use my HVR 900 stick today and discovered that it no longer 
> > > > worked.
> > > > I traced it to commit aab3125c43d8fecc7134e5f1e729fabf4dd196da: 
> > > > "em28xx: add
> > > > support for registering multiple i2c buses".
> > > > 
> > > > The kernel messages for when it fails are:
> > > ...
> > > > Mar 21 09:26:57 telek kernel: [ 1396.542517] xc2028 12-0061: attaching 
> > > > existing instance
> > > > Mar 21 09:26:57 telek kernel: [ 1396.542521] xc2028 12-0061: type set 
> > > > to XCeive xc2028/xc3028 tuner
> > > > Mar 21 09:26:57 telek kernel: [ 1396.542523] em2882/3 #0: em2882/3 
> > > > #0/2: xc3028 attached
> > > ...
> > > > Mar 21 09:26:57 telek kernel: [ 1396.547833] xc2028 12-0061: Error on 
> > > > line 1293: -19
> > > 
> > > Probably, the I2C speed is wrong. I noticed a small bug on this patch.
> > > The following patch should fix it. Could you please test?
> > 
> > No luck, it didn't help.
> 
> On a first glance, I've no idea what else is different for devices with
> just one I2C bus, like HVR-900.
> 
> Could you send me an USB sniff dump with the kernel that works and with
> the broken kernel, with this patch applied?
> 
> The parsing tools are under v4l-utils contrib/ dir.
> 
> The first step is to check the usbmon interface for capture, with:
> 
>   $ ./parse_tcpdump_log.pl --list-devices
>   usbmon4 ==> 020f (level 2)
>   usbmon2 ==> USB2.0 Hub (level 1)
>   usbmon1 ==> WinTV HVR-930C (level 7)
> 
> Then, you can run the parser to capture the data:
> 
>   # ./parse_tcpdump_log.pl --device usbmon1 | ./em28xx/parse_em28xx.pl 
> 
> Please load the em28xx driver only after starting the parser, as we want
> to see what the driver is doing during the initialization.
> 
> Thanks!
> Mauro
> 


usbdump.tar.bz2
Description: application/bzip-compressed-tar

Re: [REVIEW PATCH 11/41] af9035: basic support for IT9135 v2 chips

2013-03-22 Thread Mauro Carvalho Chehab

Em Fri, 22 Mar 2013 01:45:30 +0200
Antti Palosaari  escreveu:

> On 03/21/2013 11:54 PM, Mauro Carvalho Chehab wrote:
> > Em Sun, 10 Mar 2013 04:03:03 +0200
> > Antti Palosaari  escreveu:
> >>   static struct ite_config af9035_it913x_config = {
> >> -  .chip_ver = 0x01,
> >> +  .chip_ver = 0x02,
> 
> >> @@ -1153,6 +1161,7 @@ static int af9035_tuner_attach(struct 
> >> dvb_usb_adapter *adap)
> >>case AF9033_TUNER_IT9135_38:
> >>case AF9033_TUNER_IT9135_51:
> >>case AF9033_TUNER_IT9135_52:
> >> +  af9035_it913x_config.chip_ver = 0x01;
> >
> > Hmmm... aren't you missing a break here? If not, please add a comment, as
> > otherwise reviewers think that this is a bug.
> 
> It is correct as it was set 0x02 by init. And variable was removed 
> totally few patches later.

Ok, so please send a patch latter adding a notice about that, like:
case AF9033_TUNER_IT9135_52:
af9035_it913x_config.chip_ver = 0x01;
/* fall trough */
case ...

This is a very common practice at the Kernel, as it helps to better
document it.

Also I'm pretty sure some janitor would otherwise send us sooner or later a
patch adding a break there.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[GIT PULL FOR v3.10] v4l2: make arg of write-only ioctls const

2013-03-22 Thread Hans Verkuil

Hi Mauro,

This is the second and last phase of ensuring that the arguments of write-only
ioctls in V4L2 are const. The first phase was 4-5 months ago and added const
to s_crop, s_modulator, s_audio, s_audout, (un)subscribe_event, s_freq_hw_seek,
s_jpegcomp and s_fbuf.

This second phase adds const to s_frequency, s_tuner, s_std and s_register.
Actually, for s_std it doesn't add const but changes it to pass the std by
value which is more consistent in that particular case.

As a result drivers will be aware when they are implementing write-only ioctls
(and I saw a few drivers attempting to return data back to the user), and the
v4l2 core will know that drivers won't change the argument of a write-only
ioctls which simplifies the core debug code.

The changes have been compile-tested with the linux-media daily build but
I may have missed some more exotic architectures.

Ideally I would like to have this merged fairly early on so we have enough
time to shake out any remaining compile problems.

This pull request is identical to:

http://www.mail-archive.com/linux-media@vger.kernel.org/msg59774.html and
http://www.mail-archive.com/linux-media@vger.kernel.org/msg59886.html with
this final change for radio-keene.c:

http://www.spinics.net/lists/linux-media/msg61339.html

Note that I will be making more pull requests based on top of this pull
request since you will get merge conflicts otherwise.

Regards,

Hans

The following changes since commit d7104bffcfb7a1a7f1dbb1274443e339588c2cb3:

  [media] MAINTAINERS: add drivers/media/tuners/it913x* (2013-03-21 19:06:43 
-0300)

are available in the git repository at:

  git://linuxtv.org/hverkuil/media_tree.git const2

for you to fetch changes up to 0b03adbbaef3e6ec164ba7647dd1f53f48ef76c5:

  v4l2-ioctl: add precision when printing names. (2013-03-22 09:31:28 +0100)


Hans Verkuil (6):
  v4l2: add const to argument of write-only s_frequency ioctl.
  v4l2: add const to argument of write-only s_tuner ioctl.
  v4l2: pass std by value to the write-only s_std ioctl.
  v4l2: add const to argument of write-only s_register ioctl.
  v4l2-ioctl: simplify debug code.
  v4l2-ioctl: add precision when printing names.

 drivers/media/common/saa7146/saa7146_video.c |4 +--
 drivers/media/dvb-frontends/au8522_decoder.c |2 +-
 drivers/media/i2c/ad9389b.c  |2 +-
 drivers/media/i2c/adv7183.c  |2 +-
 drivers/media/i2c/adv7604.c  |2 +-
 drivers/media/i2c/ak881x.c   |2 +-
 drivers/media/i2c/cs5345.c   |2 +-
 drivers/media/i2c/cx25840/cx25840-core.c |6 ++--
 drivers/media/i2c/m52790.c   |2 +-
 drivers/media/i2c/msp3400-driver.c   |4 +--
 drivers/media/i2c/mt9m032.c  |2 +-
 drivers/media/i2c/mt9v011.c  |2 +-
 drivers/media/i2c/ov7670.c   |2 +-
 drivers/media/i2c/saa6588.c  |2 +-
 drivers/media/i2c/saa7115.c  |2 +-
 drivers/media/i2c/saa7127.c  |2 +-
 drivers/media/i2c/saa717x.c  |4 +--
 drivers/media/i2c/soc_camera/mt9m001.c   |2 +-
 drivers/media/i2c/soc_camera/mt9m111.c   |2 +-
 drivers/media/i2c/soc_camera/mt9t031.c   |2 +-
 drivers/media/i2c/soc_camera/mt9t112.c   |2 +-
 drivers/media/i2c/soc_camera/mt9v022.c   |2 +-
 drivers/media/i2c/soc_camera/ov2640.c|2 +-
 drivers/media/i2c/soc_camera/ov5642.c|2 +-
 drivers/media/i2c/soc_camera/ov6650.c|2 +-
 drivers/media/i2c/soc_camera/ov772x.c|2 +-
 drivers/media/i2c/soc_camera/ov9640.c|2 +-
 drivers/media/i2c/soc_camera/ov9740.c|2 +-
 drivers/media/i2c/soc_camera/rj54n1cb0c.c|2 +-
 drivers/media/i2c/soc_camera/tw9910.c|2 +-
 drivers/media/i2c/tda9840.c  |2 +-
 drivers/media/i2c/tvaudio.c  |4 +--
 drivers/media/i2c/tvp5150.c  |2 +-
 drivers/media/i2c/tvp7002.c  |2 +-
 drivers/media/i2c/upd64031a.c|4 +--
 drivers/media/i2c/upd64083.c |2 +-
 drivers/media/i2c/vp27smpx.c |2 +-
 drivers/media/i2c/vs6624.c   |2 +-
 drivers/media/i2c/wm8775.c   |2 +-
 drivers/media/parport/pms.c  |4 +--
 drivers/media/pci/bt8xx/bttv-driver.c|   36 
+---
 drivers/media/pci/cx18/cx18-av-core.c|6 ++--
 drivers/media/pci/cx18/cx18-driver.c |2 +-
 drivers/media/pci/cx18/cx18-ioctl.c  |   50 
++---
 drivers/media

Re: [PATCH -next] [media] dvb_usb_v2: make local function dvb_usb_v2_generic_io() static

2013-03-22 Thread Antti Palosaari


On 03/22/2013 05:17 AM, Wei Yongjun wrote:

From: Wei Yongjun 

dvb_usb_v2_generic_io() was not declared. It should be static.

Signed-off-by: Wei Yongjun 


Acked-by: Antti Palosaari 



---
  drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c 
b/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c
index 74c911f..aa0c35e 100644
--- a/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c
+++ b/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c
@@ -21,7 +21,7 @@

  #include "dvb_usb_common.h"

-int dvb_usb_v2_generic_io(struct dvb_usb_device *d,
+static int dvb_usb_v2_generic_io(struct dvb_usb_device *d,
u8 *wbuf, u16 wlen, u8 *rbuf, u16 rlen)
  {
int ret, actual_length;




--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [REVIEW PATCH 11/41] af9035: basic support for IT9135 v2 chips

2013-03-22 Thread Antti Palosaari


On 03/22/2013 11:30 AM, Mauro Carvalho Chehab wrote:

Em Fri, 22 Mar 2013 01:45:30 +0200
Antti Palosaari  escreveu:


On 03/21/2013 11:54 PM, Mauro Carvalho Chehab wrote:

Em Sun, 10 Mar 2013 04:03:03 +0200
Antti Palosaari  escreveu:

   static struct ite_config af9035_it913x_config = {
-   .chip_ver = 0x01,
+   .chip_ver = 0x02,



@@ -1153,6 +1161,7 @@ static int af9035_tuner_attach(struct dvb_usb_adapter 
*adap)
case AF9033_TUNER_IT9135_38:
case AF9033_TUNER_IT9135_51:
case AF9033_TUNER_IT9135_52:
+   af9035_it913x_config.chip_ver = 0x01;


Hmmm... aren't you missing a break here? If not, please add a comment, as
otherwise reviewers think that this is a bug.


It is correct as it was set 0x02 by init. And variable was removed
totally few patches later.


Ok, so please send a patch latter adding a notice about that, like:
case AF9033_TUNER_IT9135_52:
af9035_it913x_config.chip_ver = 0x01;
/* fall trough */
case ...

This is a very common practice at the Kernel, as it helps to better
document it.

Also I'm pretty sure some janitor would otherwise send us sooner or later a
patch adding a break there.


I totally agree the issue, but it is totally irrelevant currently as the 
whole piece of code does not exists anymore.


regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] [media] hdpvr: vidioc_g_fmt_vid_cap should not fail

2013-03-22 Thread Leonid Kegulskiy

Fixed get_video_info() function that used to return NULL
if video source is not present, subsequently causing
vidioc_g_fmt_vid_cap to fail. Originally issue reported here:
http://www.spinics.net/lists/linux-media/msg54246.html

Signed-off-by: Leonid Kegulskiy 
---
 drivers/media/usb/hdpvr/hdpvr-control.c |   29 +
 drivers/media/usb/hdpvr/hdpvr-video.c   |5 -
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/drivers/media/usb/hdpvr/hdpvr-control.c 
b/drivers/media/usb/hdpvr/hdpvr-control.c
index ae8f229..ed12159 100644
--- a/drivers/media/usb/hdpvr/hdpvr-control.c
+++ b/drivers/media/usb/hdpvr/hdpvr-control.c
@@ -53,12 +53,6 @@ struct hdpvr_video_info *get_video_info(struct hdpvr_device 
*dev)
 #endif
int ret;
 
-   vidinf = kzalloc(sizeof(struct hdpvr_video_info), GFP_KERNEL);
-   if (!vidinf) {
-   v4l2_err(&dev->v4l2_dev, "out of memory\n");
-   goto err;
-   }
-
mutex_lock(&dev->usbc_mutex);
ret = usb_control_msg(dev->udev,
  usb_rcvctrlpipe(dev->udev, 0),
@@ -66,12 +60,6 @@ struct hdpvr_video_info *get_video_info(struct hdpvr_device 
*dev)
  0x1400, 0x0003,
  dev->usbc_buf, 5,
  1000);
-   if (ret == 5) {
-   vidinf->width   = dev->usbc_buf[1] << 8 | dev->usbc_buf[0];
-   vidinf->height  = dev->usbc_buf[3] << 8 | dev->usbc_buf[2];
-   vidinf->fps = dev->usbc_buf[4];
-   }
-
 #ifdef HDPVR_DEBUG
if (hdpvr_debug & MSG_INFO) {
hex_dump_to_buffer(dev->usbc_buf, 5, 16, 1, print_buf,
@@ -82,11 +70,20 @@ struct hdpvr_video_info *get_video_info(struct hdpvr_device 
*dev)
 #endif
mutex_unlock(&dev->usbc_mutex);
 
-   if (!vidinf->width || !vidinf->height || !vidinf->fps) {
-   kfree(vidinf);
-   vidinf = NULL;
+   if (ret == 5)
+   {
+   vidinf = kzalloc(sizeof(struct hdpvr_video_info), GFP_KERNEL);
+   if (vidinf)
+   {
+   vidinf->width   = dev->usbc_buf[1] << 8 | 
dev->usbc_buf[0];
+   vidinf->height  = dev->usbc_buf[3] << 8 | 
dev->usbc_buf[2];
+   vidinf->fps = dev->usbc_buf[4];
+   }
+   else
+   {
+   v4l2_err(&dev->v4l2_dev, "out of memory\n");
+   }
}
-err:
return vidinf;
 }
 
diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c 
b/drivers/media/usb/hdpvr/hdpvr-video.c
index da6b779..fb14012 100644
--- a/drivers/media/usb/hdpvr/hdpvr-video.c
+++ b/drivers/media/usb/hdpvr/hdpvr-video.c
@@ -268,7 +268,7 @@ static int hdpvr_start_streaming(struct hdpvr_device *dev)
 
vidinf = get_video_info(dev);
 
-   if (vidinf) {
+   if (vidinf && vidinf->width && vidinf->height && vidinf->fps) {
v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
 "video signal: %dx%d@%dhz\n", vidinf->width,
 vidinf->height, vidinf->fps);
@@ -293,6 +293,9 @@ static int hdpvr_start_streaming(struct hdpvr_device *dev)
 
return 0;
}
+   
+   if (vidinf)
+   kfree(vidinf);
msleep(250);
v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
 "no video signal at input %d\n", dev->options.video_input);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL FOR v3.10] v4l2: make arg of write-only ioctls const

2013-03-22 Thread Hans Verkuil

On Fri March 22 2013 11:35:17 Hans Verkuil wrote:
> Hi Mauro,
> 
> This is the second and last phase of ensuring that the arguments of write-only
> ioctls in V4L2 are const. The first phase was 4-5 months ago and added const
> to s_crop, s_modulator, s_audio, s_audout, (un)subscribe_event, 
> s_freq_hw_seek,
> s_jpegcomp and s_fbuf.
> 
> This second phase adds const to s_frequency, s_tuner, s_std and s_register.
> Actually, for s_std it doesn't add const but changes it to pass the std by
> value which is more consistent in that particular case.
> 
> As a result drivers will be aware when they are implementing write-only ioctls
> (and I saw a few drivers attempting to return data back to the user), and the
> v4l2 core will know that drivers won't change the argument of a write-only
> ioctls which simplifies the core debug code.
> 
> The changes have been compile-tested with the linux-media daily build but
> I may have missed some more exotic architectures.
> 
> Ideally I would like to have this merged fairly early on so we have enough
> time to shake out any remaining compile problems.
> 
> This pull request is identical to:
> 
> http://www.mail-archive.com/linux-media@vger.kernel.org/msg59774.html and
> http://www.mail-archive.com/linux-media@vger.kernel.org/msg59886.html with
> this final change for radio-keene.c:
> 
> http://www.spinics.net/lists/linux-media/msg61339.html
> 
> Note that I will be making more pull requests based on top of this pull
> request since you will get merge conflicts otherwise.

Nacked-by: Hans Verkuil 

I just discovered that after the recent merged the s_register patch causes
a compile warning in ths7303. Nacking this and posting a new one.

Regards,

Hans

> 
> Regards,
> 
> Hans
> 
> The following changes since commit d7104bffcfb7a1a7f1dbb1274443e339588c2cb3:
> 
>   [media] MAINTAINERS: add drivers/media/tuners/it913x* (2013-03-21 19:06:43 
> -0300)
> 
> are available in the git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git const2
> 
> for you to fetch changes up to 0b03adbbaef3e6ec164ba7647dd1f53f48ef76c5:
> 
>   v4l2-ioctl: add precision when printing names. (2013-03-22 09:31:28 +0100)
> 
> 
> Hans Verkuil (6):
>   v4l2: add const to argument of write-only s_frequency ioctl.
>   v4l2: add const to argument of write-only s_tuner ioctl.
>   v4l2: pass std by value to the write-only s_std ioctl.
>   v4l2: add const to argument of write-only s_register ioctl.
>   v4l2-ioctl: simplify debug code.
>   v4l2-ioctl: add precision when printing names.
> 
>  drivers/media/common/saa7146/saa7146_video.c |4 +--
>  drivers/media/dvb-frontends/au8522_decoder.c |2 +-
>  drivers/media/i2c/ad9389b.c  |2 +-
>  drivers/media/i2c/adv7183.c  |2 +-
>  drivers/media/i2c/adv7604.c  |2 +-
>  drivers/media/i2c/ak881x.c   |2 +-
>  drivers/media/i2c/cs5345.c   |2 +-
>  drivers/media/i2c/cx25840/cx25840-core.c |6 ++--
>  drivers/media/i2c/m52790.c   |2 +-
>  drivers/media/i2c/msp3400-driver.c   |4 +--
>  drivers/media/i2c/mt9m032.c  |2 +-
>  drivers/media/i2c/mt9v011.c  |2 +-
>  drivers/media/i2c/ov7670.c   |2 +-
>  drivers/media/i2c/saa6588.c  |2 +-
>  drivers/media/i2c/saa7115.c  |2 +-
>  drivers/media/i2c/saa7127.c  |2 +-
>  drivers/media/i2c/saa717x.c  |4 +--
>  drivers/media/i2c/soc_camera/mt9m001.c   |2 +-
>  drivers/media/i2c/soc_camera/mt9m111.c   |2 +-
>  drivers/media/i2c/soc_camera/mt9t031.c   |2 +-
>  drivers/media/i2c/soc_camera/mt9t112.c   |2 +-
>  drivers/media/i2c/soc_camera/mt9v022.c   |2 +-
>  drivers/media/i2c/soc_camera/ov2640.c|2 +-
>  drivers/media/i2c/soc_camera/ov5642.c|2 +-
>  drivers/media/i2c/soc_camera/ov6650.c|2 +-
>  drivers/media/i2c/soc_camera/ov772x.c|2 +-
>  drivers/media/i2c/soc_camera/ov9640.c|2 +-
>  drivers/media/i2c/soc_camera/ov9740.c|2 +-
>  drivers/media/i2c/soc_camera/rj54n1cb0c.c|2 +-
>  drivers/media/i2c/soc_camera/tw9910.c|2 +-
>  drivers/media/i2c/tda9840.c  |2 +-
>  drivers/media/i2c/tvaudio.c  |4 +--
>  drivers/media/i2c/tvp5150.c  |2 +-
>  drivers/media/i2c/tvp7002.c  |2 +-
>  drivers/media/i2c/upd64031a.c|4 +--
>  drivers/media/i2c/upd64083.c |2 +-
>  drivers/media/i2c/vp27smpx.c |2 +-
>  drivers/media/i2c/vs6624.c   |

[GIT PULL FOR v3.10] v4l2: make arg of write-only ioctls const

2013-03-22 Thread Hans Verkuil

Hi Mauro,

This is the second and last phase of ensuring that the arguments of write-only
ioctls in V4L2 are const. The first phase was 4-5 months ago and added const
to s_crop, s_modulator, s_audio, s_audout, (un)subscribe_event, s_freq_hw_seek,
s_jpegcomp and s_fbuf.

This second phase adds const to s_frequency, s_tuner, s_std and s_register.
Actually, for s_std it doesn't add const but changes it to pass the std by
value which is more consistent in that particular case.

As a result drivers will be aware when they are implementing write-only ioctls
(and I saw a few drivers attempting to return data back to the user), and the
v4l2 core will know that drivers won't change the argument of a write-only
ioctls which simplifies the core debug code.

The changes have been compile-tested with the linux-media daily build but
I may have missed some more exotic architectures.

Ideally I would like to have this merged fairly early on so we have enough
time to shake out any remaining compile problems.

This pull request is identical to:

http://www.mail-archive.com/linux-media@vger.kernel.org/msg59774.html and
http://www.mail-archive.com/linux-media@vger.kernel.org/msg59886.html with
this final change for radio-keene.c:

http://www.spinics.net/lists/linux-media/msg61339.html

and an extra s_register change for the ths7303 due to the recently merged
ths7303 change.

Note that I will be making more pull requests based on top of this pull
request since you will get merge conflicts otherwise.

Regards,

Hans


The following changes since commit d7104bffcfb7a1a7f1dbb1274443e339588c2cb3:

  [media] MAINTAINERS: add drivers/media/tuners/it913x* (2013-03-21 19:06:43 
-0300)

are available in the git repository at:

  git://linuxtv.org/hverkuil/media_tree.git const

for you to fetch changes up to 8bf1a5a826d06a9b6f65b3e8dffb9be59d8937c3:

  v4l2-ioctl: add precision when printing names. (2013-03-22 11:59:21 +0100)


Hans Verkuil (6):
  v4l2: add const to argument of write-only s_frequency ioctl.
  v4l2: add const to argument of write-only s_tuner ioctl.
  v4l2: pass std by value to the write-only s_std ioctl.
  v4l2: add const to argument of write-only s_register ioctl.
  v4l2-ioctl: simplify debug code.
  v4l2-ioctl: add precision when printing names.

 drivers/media/common/saa7146/saa7146_video.c |4 +--
 drivers/media/dvb-frontends/au8522_decoder.c |2 +-
 drivers/media/i2c/ad9389b.c  |2 +-
 drivers/media/i2c/adv7183.c  |2 +-
 drivers/media/i2c/adv7604.c  |2 +-
 drivers/media/i2c/ak881x.c   |2 +-
 drivers/media/i2c/cs5345.c   |2 +-
 drivers/media/i2c/cx25840/cx25840-core.c |6 ++--
 drivers/media/i2c/m52790.c   |2 +-
 drivers/media/i2c/msp3400-driver.c   |4 +--
 drivers/media/i2c/mt9m032.c  |2 +-
 drivers/media/i2c/mt9v011.c  |2 +-
 drivers/media/i2c/ov7670.c   |2 +-
 drivers/media/i2c/saa6588.c  |2 +-
 drivers/media/i2c/saa7115.c  |2 +-
 drivers/media/i2c/saa7127.c  |2 +-
 drivers/media/i2c/saa717x.c  |4 +--
 drivers/media/i2c/soc_camera/mt9m001.c   |2 +-
 drivers/media/i2c/soc_camera/mt9m111.c   |2 +-
 drivers/media/i2c/soc_camera/mt9t031.c   |2 +-
 drivers/media/i2c/soc_camera/mt9t112.c   |2 +-
 drivers/media/i2c/soc_camera/mt9v022.c   |2 +-
 drivers/media/i2c/soc_camera/ov2640.c|2 +-
 drivers/media/i2c/soc_camera/ov5642.c|2 +-
 drivers/media/i2c/soc_camera/ov6650.c|2 +-
 drivers/media/i2c/soc_camera/ov772x.c|2 +-
 drivers/media/i2c/soc_camera/ov9640.c|2 +-
 drivers/media/i2c/soc_camera/ov9740.c|2 +-
 drivers/media/i2c/soc_camera/rj54n1cb0c.c|2 +-
 drivers/media/i2c/soc_camera/tw9910.c|2 +-
 drivers/media/i2c/tda9840.c  |2 +-
 drivers/media/i2c/ths7303.c  |2 +-
 drivers/media/i2c/tvaudio.c  |4 +--
 drivers/media/i2c/tvp5150.c  |2 +-
 drivers/media/i2c/tvp7002.c  |2 +-
 drivers/media/i2c/upd64031a.c|4 +--
 drivers/media/i2c/upd64083.c |2 +-
 drivers/media/i2c/vp27smpx.c |2 +-
 drivers/media/i2c/vs6624.c   |2 +-
 drivers/media/i2c/wm8775.c   |2 +-
 drivers/media/parport/pms.c  |4 +--
 drivers/media/pci/bt8xx/bttv-driver.c|   36 
+---
 drivers/media/pci/cx18/cx18-av-core.c|6 ++--
 drivers/media/

Re: [PATCH] [media] hdpvr: vidioc_g_fmt_vid_cap should not fail

2013-03-22 Thread Hans Verkuil

On Fri March 22 2013 11:59:05 Leonid Kegulskiy wrote:
> Fixed get_video_info() function that used to return NULL
> if video source is not present, subsequently causing
> vidioc_g_fmt_vid_cap to fail. Originally issue reported here:
> http://www.spinics.net/lists/linux-media/msg54246.html

Nacked-by: Hans Verkuil 

A change like this should be done on top of my hdpvr patch series:

http://www.mail-archive.com/linux-media@vger.kernel.org/msg60040.html

I worked around it by keeping track if one of the new DV_TIMINGS ioctls
for HDTV is used: if so, then the proper v4l2 behavior is used, otherwise
I keep the existing behavior.

Janne, it is really strange that EFAULT is returned if there is no signal.
Does mythtv or another application rely on that? If so, then we need to
keep it like that for now.

gstreamer can try to use the DV_TIMINGS API instead, which has proper
behavior.

Regards,

Hans

> 
> Signed-off-by: Leonid Kegulskiy 
> ---
>  drivers/media/usb/hdpvr/hdpvr-control.c |   29 +
>  drivers/media/usb/hdpvr/hdpvr-video.c   |5 -
>  2 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/media/usb/hdpvr/hdpvr-control.c 
> b/drivers/media/usb/hdpvr/hdpvr-control.c
> index ae8f229..ed12159 100644
> --- a/drivers/media/usb/hdpvr/hdpvr-control.c
> +++ b/drivers/media/usb/hdpvr/hdpvr-control.c
> @@ -53,12 +53,6 @@ struct hdpvr_video_info *get_video_info(struct 
> hdpvr_device *dev)
>  #endif
>   int ret;
>  
> - vidinf = kzalloc(sizeof(struct hdpvr_video_info), GFP_KERNEL);
> - if (!vidinf) {
> - v4l2_err(&dev->v4l2_dev, "out of memory\n");
> - goto err;
> - }
> -
>   mutex_lock(&dev->usbc_mutex);
>   ret = usb_control_msg(dev->udev,
> usb_rcvctrlpipe(dev->udev, 0),
> @@ -66,12 +60,6 @@ struct hdpvr_video_info *get_video_info(struct 
> hdpvr_device *dev)
> 0x1400, 0x0003,
> dev->usbc_buf, 5,
> 1000);
> - if (ret == 5) {
> - vidinf->width   = dev->usbc_buf[1] << 8 | dev->usbc_buf[0];
> - vidinf->height  = dev->usbc_buf[3] << 8 | dev->usbc_buf[2];
> - vidinf->fps = dev->usbc_buf[4];
> - }
> -
>  #ifdef HDPVR_DEBUG
>   if (hdpvr_debug & MSG_INFO) {
>   hex_dump_to_buffer(dev->usbc_buf, 5, 16, 1, print_buf,
> @@ -82,11 +70,20 @@ struct hdpvr_video_info *get_video_info(struct 
> hdpvr_device *dev)
>  #endif
>   mutex_unlock(&dev->usbc_mutex);
>  
> - if (!vidinf->width || !vidinf->height || !vidinf->fps) {
> - kfree(vidinf);
> - vidinf = NULL;
> + if (ret == 5)
> + {
> + vidinf = kzalloc(sizeof(struct hdpvr_video_info), GFP_KERNEL);
> + if (vidinf)
> + {
> + vidinf->width   = dev->usbc_buf[1] << 8 | 
> dev->usbc_buf[0];
> + vidinf->height  = dev->usbc_buf[3] << 8 | 
> dev->usbc_buf[2];
> + vidinf->fps = dev->usbc_buf[4];
> + }
> + else
> + {
> + v4l2_err(&dev->v4l2_dev, "out of memory\n");
> + }
>   }
> -err:
>   return vidinf;
>  }
>  
> diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c 
> b/drivers/media/usb/hdpvr/hdpvr-video.c
> index da6b779..fb14012 100644
> --- a/drivers/media/usb/hdpvr/hdpvr-video.c
> +++ b/drivers/media/usb/hdpvr/hdpvr-video.c
> @@ -268,7 +268,7 @@ static int hdpvr_start_streaming(struct hdpvr_device *dev)
>  
>   vidinf = get_video_info(dev);
>  
> - if (vidinf) {
> + if (vidinf && vidinf->width && vidinf->height && vidinf->fps) {
>   v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
>"video signal: %dx%d@%dhz\n", vidinf->width,
>vidinf->height, vidinf->fps);
> @@ -293,6 +293,9 @@ static int hdpvr_start_streaming(struct hdpvr_device *dev)
>  
>   return 0;
>   }
> + 
> + if (vidinf)
> + kfree(vidinf);
>   msleep(250);
>   v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
>"no video signal at input %d\n", dev->options.video_input);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: media-tree build is broken

2013-03-22 Thread Gianluca Gennari

Il 22/03/2013 10:25, Mauro Carvalho Chehab ha scritto:
> Em Thu, 21 Mar 2013 19:16:55 +0100
> Frank Schäfer  escreveu:
> 
>> ...
>> Kernel: arch/x86/boot/bzImage is ready  (#2)
>> ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined!
>> make[1]: *** [__modpost] Fehler 1
>> make: *** [modules] Fehler 2
>>
>>
>> Mauro, I assume this is caused by one of the recent Siano patches ?
> 
> I tried to debug this one, but I couldn't reproduce it here. Not sure why,
> but I'm not capable of producing those errors here for a long time.
> 
> Maybe the gcc compiler version currently provided with Fedora 18 doesn't
> require any library for 64-bit divisions, even when compiling for a
> 32 bits Kernel.
> 
> Anyway, I'm almost sure that the following patch fixes the issue.
> Please test.

Hi Mauro, Frank,
I can confirm the patch fixes the compilation problem.
Tested on a 32 bit Ubuntu 10.04, compiling the latest media_build tree.

Regards,
Gianluca


> 
> Regards,
> Mauro.
> 
> -
> 
> PATCH] [media] siano: use do_div() for 64-bits division
> 
> As reported by Frank Schäfer :
>   ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined!
> 
> Reported-by: Frank Schäfer 
> Signed-off-by: Mauro Carvalho Chehab 
> 
> diff --git a/drivers/media/common/siano/smsdvb-main.c 
> b/drivers/media/common/siano/smsdvb-main.c
> index d965a7a..297f1b2 100644
> --- a/drivers/media/common/siano/smsdvb-main.c
> +++ b/drivers/media/common/siano/smsdvb-main.c
> @@ -22,6 +22,7 @@ along with this program.  If not, see 
> .
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  #include "dmxdev.h"
>  #include "dvbdev.h"
> @@ -244,6 +245,7 @@ static void smsdvb_update_per_slices(struct 
> smsdvb_client_t *client,
>  {
>   struct dvb_frontend *fe = &client->frontend;
>   struct dtv_frontend_properties *c = &fe->dtv_property_cache;
> + u64 tmp;
>  
>   client->fe_status = sms_to_status(p->is_demod_locked, p->is_rf_locked);
>   c->modulation = sms_to_modulation(p->constellation);
> @@ -272,8 +274,9 @@ static void smsdvb_update_per_slices(struct 
> smsdvb_client_t *client,
>   c->post_bit_count.stat[0].uvalue += p->ber_bit_count;
>  
>   /* Legacy PER/BER */
> - client->legacy_per = (p->ets_packets * 65535) /
> -  (p->ts_packets + p->ets_packets);
> + tmp = p->ets_packets * 65535;
> + do_div(tmp, p->ts_packets + p->ets_packets);
> + client->legacy_per = tmp;
>  }
>  
>  static void smsdvb_update_dvb_stats(struct smsdvb_client_t *client,
> @@ -803,7 +806,7 @@ static int smsdvb_read_snr(struct dvb_frontend *fe, u16 
> *snr)
>   rc = smsdvb_send_statistics_request(client);
>  
>   /* Preferred scale for SNR with legacy API: 0.1 dB */
> - *snr = c->cnr.stat[0].svalue / 100;
> + *snr = ((u32)c->cnr.stat[0].svalue) / 100;
>  
>   led_feedback(client);
>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[GIT PULL FOR v3.10] solo6x10 driver overhaul

2013-03-22 Thread Hans Verkuil

Hi Mauro,

This is my solo6x10 driver overhaul. It is identical to:

http://www.mail-archive.com/linux-media@vger.kernel.org/msg59864.html

but rebased on top of my const changes 
(http://patchwork.linuxtv.org/patch/17568/)
and with the source/header rename patches.

This patch series syncs the driver to the latest code from Bluecherry and then
fixes many v4l issues.

Remaining open issues:

1) Most importantly, the video from video0 is broken: it is supposed to be
   either one of the four inputs or a 2x2 image of all four inputs, instead I
   always get the first video line of the input repeated for the whole image.

   I have no idea why and it would be very nice if someone from Bluecherry
   can look at this. I do not see anything wrong in the DMA code, so it is
   a mystery to me.

2) I couldn't get it to work on a big-endian system. Perhaps it is because
   the PCI card is sitting in a PCIe slot using a PCIe-to-PCI adapter.

3) The 'extended streams' have been disabled. Basically you can get two
   encoded streams out of the box: each with different encoder settings
   (e.g. high and low bitrates). This should probably be implemented as
   an extra video node.

4) There is a custom extension for motion detection. Besides adding two
   private ioctls to support regional motion thresholds I left that part
   otherwise unchanged as it doesn't look too bad, but I am unable to test
   it properly. I've ordered a suitable CCTV camera from dealextreme, but that
   will take a few weeks before I have it (dx.com is cheap, but delivery is
   quite slow). I'd like to experiment a bit with this.

5) The tw28* 'drivers' should really be split off as subdevice drivers.

6) Capture of video0 is now using dma-contig. It used to be dma-sg, but due
   to locking issues Bluecherry changed it to dma-contig. So I've kept it
   that way, but it can probably be converted back to dma-sg. But issue 1 should
   be fixed first before we mess with this.

So there is still work to be done, but at least the driver is in a much better
state.

The idea is that Bluecherry will develop from this code base and keep the
kernel driver in sync.

Regards,

Hans

The following changes since commit 8bf1a5a826d06a9b6f65b3e8dffb9be59d8937c3:

  v4l2-ioctl: add precision when printing names. (2013-03-22 11:59:21 +0100)

are available in the git repository at:

  git://linuxtv.org/hverkuil/media_tree.git solo3

for you to fetch changes up to 13c810d87b0e332ecefb3a889246f2d2b3d4e749:

  solo6x10: prefix sources with 'solo6x10-' (2013-03-22 12:40:36 +0100)


Hans Verkuil (21):
  solo6x10: sync to latest code from Bluecherry's git repo.
  solo6x10: fix querycap and update driver version.
  solo6x10: add v4l2_device.
  solo6x10: add control framework.
  solo6x10: fix various format-related compliancy issues.
  solo6x10: add support for prio and control event handling.
  solo6x10: move global fields in solo_dev_fh to solo_dev.
  solo6x10: move global fields in solo_enc_fh to solo_enc_dev.
  solo6x10: convert encoder nodes to vb2.
  solo6x10: convert the display node to vb2.
  solo6x10: fix 'BUG: key 88081a2a9b58 not in .data!'
  solo6x10: add call to pci_dma_mapping_error.
  solo6x10: drop video_type and add proper s_std support.
  solo6x10: also stop DMA if the SOLO_PCI_ERR_P2M_DESC is raised.
  solo6x10: small big-endian fix.
  solo6x10: use V4L2_PIX_FMT_MPEG4, not _FMT_MPEG
  solo6x10: fix sequence handling.
  solo6x10: disable the 'priv' abuse.
  solo6x10: clean up motion detection handling.
  solo6x10: rename headers.
  solo6x10: prefix sources with 'solo6x10-'

 drivers/staging/media/solo6x10/Kconfig  |3 +-
 drivers/staging/media/solo6x10/Makefile |4 +-
 drivers/staging/media/solo6x10/TODO |   33 +-
 drivers/staging/media/solo6x10/core.c   |  321 
 drivers/staging/media/solo6x10/offsets.h|   74 --
 drivers/staging/media/solo6x10/osd-font.h   |  154 
 drivers/staging/media/solo6x10/p2m.c|  306 ---
 drivers/staging/media/solo6x10/solo6x10-core.c  |  708 

 drivers/staging/media/solo6x10/{disp.c => solo6x10-disp.c}  |  128 ++-
 drivers/staging/media/solo6x10/solo6x10-eeprom.c|  154 
 drivers/staging/media/solo6x10/{enc.c => solo6x10-enc.c}|  240 --
 drivers/staging/media/solo6x10/{g723.c => solo6x10-g723.c}  |   93 ++-
 drivers/staging/media/solo6x10/{gpio.c => solo6x10-gpio.c}  |   13 +-
 drivers/staging/media/solo6x10/{i2c.c => solo6x10-i2c.c}|   26 +-
 drivers/staging/media/solo6x10/solo6x10-jpeg.h  |   94 ++-
 drivers/staging/media/solo6x10/solo6x10-offsets.h   |   85 ++
 drivers/sta

Re: media-tree build is broken

2013-03-22 Thread Mauro Carvalho Chehab

Em Fri, 22 Mar 2013 12:35:19 +0100
Gianluca Gennari  escreveu:

> Il 22/03/2013 10:25, Mauro Carvalho Chehab ha scritto:
> > Em Thu, 21 Mar 2013 19:16:55 +0100
> > Frank Schäfer  escreveu:
> > 
> >> ...
> >> Kernel: arch/x86/boot/bzImage is ready  (#2)
> >> ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined!
> >> make[1]: *** [__modpost] Fehler 1
> >> make: *** [modules] Fehler 2
> >>
> >>
> >> Mauro, I assume this is caused by one of the recent Siano patches ?
> > 
> > I tried to debug this one, but I couldn't reproduce it here. Not sure why,
> > but I'm not capable of producing those errors here for a long time.
> > 
> > Maybe the gcc compiler version currently provided with Fedora 18 doesn't
> > require any library for 64-bit divisions, even when compiling for a
> > 32 bits Kernel.
> > 
> > Anyway, I'm almost sure that the following patch fixes the issue.
> > Please test.
> 
> Hi Mauro, Frank,
> I can confirm the patch fixes the compilation problem.
> Tested on a 32 bit Ubuntu 10.04, compiling the latest media_build tree.

Thanks! I'll add a tested-by on the patch.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: add ETH_P_802_3_MIN

2013-03-22 Thread Simon Horman

On Thu, Mar 21, 2013 at 11:56:08AM -0400, David Miller wrote:
> From: Simon Horman 
> Date: Thu, 21 Mar 2013 17:29:28 +0900
> 
> > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for
> > an 802.3 frame. Frames with a lower value in the ethernet type field
> > are Ethernet II.
> > 
> > Also update all the users of this value that I could find to use the
> > new constant.
> > 
> > I anticipate adding some more users of this constant when
> > adding MPLS support to Open vSwtich.
> > 
> > As suggested by Jesse Gross.
> > 
> > Compile tested only.
> > 
> > Signed-off-by: Simon Horman 
> 
> You missed a few cases:
> 
> drivers/media/dvb-core/dvb_net.c:   } while (p->ule_sndu_type < 1536);
> drivers/media/dvb-core/dvb_net.c:   if 
> (priv->ule_sndu_type < 1536) {
> net/atm/lec.h: *is less than 1536(0x0600) MUST be encoded by placing that 
> length
> drivers/net/wireless/ray_cs.c:  if (ntohs(proto) >= 1536) { /* DIX II 
> ethernet frame */
> net/bridge/netfilter/ebtables.c:if (FWINV2(ntohs(ethproto) >= 
> 1536, EBT_IPROTO))
> include/linux/if_vlan.h:if (ntohs(proto) >= 1536) {
> net/bluetooth/bnep/netdev.c:if (proto >= 1536)
> net/openvswitch/flow.c: if (ntohs(proto) >= 1536)
> net/mac80211/tx.c:  } else if (ethertype >= 0x600) {
> net/wireless/util.c:} else if (ethertype > 0x600) {
> 
> In fact, the last line looks like a bug, it should be >= not >.

Thanks for finding those.

> Could you take care of these bits and respin your patch?

Sure.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] em28xx: tuner setup is broken after algo_data change.

2013-03-22 Thread Hans Verkuil

Commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke em28xx. I traced
this eventually to the change in what algo_data points to. This pointer
is also passed to em28xx_tuner_callback() through several hidden tuner
layers (yuck!) and that callback was not updated.

Signed-off-by: Hans Verkuil 
---
 drivers/media/usb/em28xx/em28xx-cards.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/usb/em28xx/em28xx-cards.c 
b/drivers/media/usb/em28xx/em28xx-cards.c
index 46fff5c..cb7cdd3 100644
--- a/drivers/media/usb/em28xx/em28xx-cards.c
+++ b/drivers/media/usb/em28xx/em28xx-cards.c
@@ -2229,8 +2229,9 @@ static unsigned short msp3400_addrs[] = {
 
 int em28xx_tuner_callback(void *ptr, int component, int command, int arg)
 {
+   struct em28xx_i2c_bus *i2c_bus = ptr;
+   struct em28xx *dev = i2c_bus->dev;
int rc = 0;
-   struct em28xx *dev = ptr;
 
if (dev->tuner_type != TUNER_XC2028 && dev->tuner_type != TUNER_XC5000)
return 0;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-22 Thread Hans Verkuil

On Thu March 21 2013 19:46:03 edubez...@gmail.com wrote:
> Hans,
> 
> 
> 
> 
> >> > Are you still able to test the si4713 driver? Because I have patches
> >>
> >>
> >>
> >> I see. In fact that is my next step on my todo list for si4713. I
> >> still have an n900 that I can fetch from my drobe, so just a matter of
> >> booting it with newer kernel.
> >>
> >> > outstanding that I would love for someone to test for me:
> >> >
> >> > http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/si4713
> 
> So, I got my hands on my old n900 and thanks to Aaro and lo community
> I could still boot it with 3.9-rc3 kernel! amazing!
> 
> I didn't have the time to look at your patches, but I could do a blind
> run of v4l2-compliance -r 0 on n900. It follows the results:

... 

> 
> 
> # on your branch on the other hand I get a NULL pointer:

I've fixed that (v4l2_dev was never initialized), and I've also rebased my tree
to the latest code. Can you try again?

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[GIT PULL FOR v3.10] go7007 driver overhaul

2013-03-22 Thread Hans Verkuil

Hi all,

This pull request updates the staging go7007 driver to the latest
V4L2 frameworks and actually makes it work reliably.

This pull request assumes that pull request
http://patchwork.linuxtv.org/patch/17568/ was merged first.

Some highlights:

- moved the custom i2c drivers to media/i2c.
- replaced the s2250-loader by a common loader for all the supported
  devices.
- replaced all MPEG-related custom ioctls by standard ioctls and FMT
  support.
- added the saa7134-go7007 combination (similar to the saa7134-empress).
- added support for ADS Tech DVD Xpress DX2.

In addition I've made some V4L2 core and saa7115 changes (the first 7
patches):

- eliminate false lockdep warnings when dealing with nested control
  handlers. This patch is a slightly modified version from the one Andy
  posted a long time ago.
- add support to easily test if any subdevices support a particular operation.
- fix a few bugs in the code that tests if an ioctl is available: it didn't
  take 'disabling of ioctls' into account.
- added additional configuration flags to saa7115, needed by the go7007.
- improved querystd support in saa7115.

This driver now passes all v4l2-compliance tests.

It has been tested with:

- Plextor PX-TV402U (PAL model)
- Sensoray S2250S (generously provided by Sensoray, all audio inputs
  now work!)
- Sensoray Model 614 (saa7134+go7007 PCI board, generously provided by
  Sensoray)
- WIS X-Men II sensor board (generously provided by Sensoray)
- Adlink PCI-MPG24 surveillance board
- ADS Tech DVD Xpress DX2

Everything seems to work OK, but for two things:

- the WIS X-Men and tthe S2250 do not honor requested frameperiod changes
  using S_PARM. The others work fine, and I have no idea why these work
  differently.
- the bttv part of the Adlink card doesn't work for me: I just get black
  with fuzzy lines. This doesn't work in 3.8 either, so I don't know
  what's going on here. It's not related to my patch series, that's for
  sure.

What needs to be done to get this driver out of staging? The main thing
is the motion detection support. Volokh has some additional code for that,
and I want to experiment with motion detection for this card and the
solo6x10 card and see if I can come up with a nice API for that.

It would also be nice to get the s2250-board.c code make use of the already
existing i2c devices, but it is hooked up somewhat strangely, so I need to
look at that some day.

Regarding the firmware: they are available here:

http://git.linuxtv.org/hverkuil/linux-firmware.git/shortlog/refs/heads/go7007

All firmwares relating to this driver have been collected in the go7007
directory with correct licensing. Note that this means that the s2250 firmwares
have been renamed. Should this be an issue I can change this back and leave
those files where they are today, but since the go7007 firmware files were
never included in linux-firmware (and therefor the driver never worked with
just linux-firmware) and because it is still a staging driver I thought it
cleaner to have all firmware files in one place.

Mauro, when should I make a pull request for the linux-firmware changes?
After you have merged this pull request?

In the meantime, the firmware files are also available here:

http://hverkuil.home.xs4all.nl/go7007-fw.tar.bz2

Just unpack in /lib/firmware.

Regards,

Hans

The following changes since commit 8bf1a5a826d06a9b6f65b3e8dffb9be59d8937c3:

  v4l2-ioctl: add precision when printing names. (2013-03-22 11:59:21 +0100)

are available in the git repository at:

  git://linuxtv.org/hverkuil/media_tree.git go7007

for you to fetch changes up to 651f19e2186eb92393296717afaa7fc0873d6c2f:

  go7007: add support for ADS Tech DVD Xpress DX2 (2013-03-22 15:20:46 +0100)


Andy Walls (1):
  v4l2-ctrls: eliminate lockdep false alarms for struct 
v4l2_ctrl_handler.lock

Hans Verkuil (47):
  v4l2-core: add code to check for specific ops.
  v4l2-ioctl: check if an ioctl is valid.
  v4l2-ctrls: add V4L2_CID_MPEG_VIDEO_REPEAT_SEQ_HEADER control
  saa7115: add config flag to change the IDQ polarity.
  saa7115: improve querystd handling for the saa7115.
  saa7115: add support for double-rate ASCLK
  go7007: fix i2c_xfer return codes.
  tuner: add Sony BTF tuners
  sony-btf-mpx: the MPX driver for the sony BTF PAL/SECAM tuner
  ov7640: add new ov7640 driver
  uda1342: add new uda1342 audio codec driver
  tw9903: add new tw9903 video decoder.
  tw2804: add support for the Techwell tw2804.
  go7007: switch to standard tuner/i2c subdevs.
  go7007: remove all wis* drivers.
  go7007: add audio input ioctls.
  s2250-loader: use usbv2_cypress_load_firmware
  go7007: go7007: add device_caps and bus_info support to querycap.
  go7007: remove current_norm.
  go7007: fix DMA related errors.
  go7007: remember boot firmware.
  go7007: fix unregister/disconnect handling.

[PATCH 3/3] [media] m5602_ov7660: return error at ov7660_init()

2013-03-22 Thread Mauro Carvalho Chehab

It used to be a code that returns arror at ov7660_init.
However, this was removed by changeset c84e412f:

@@ -231,33 +116,40 @@ int ov7660_init(struct sd *sd)
if (dump_sensor)
ov7660_dump_registers(sd);

-   err = ov7660_set_gain(&sd->gspca_dev, sensor_settings[GAIN_IDX]);
-   if (err < 0)
-   return err;
+ return 0;
+}

-   err = ov7660_set_auto_white_balance(&sd->gspca_dev,
-   sensor_settings[AUTO_WHITE_BALANCE_IDX]);
-   if (err < 0)
-   return err;

As complained by gcc:
drivers/media/usb/gspca/m5602/m5602_ov7660.c: In function 'ov7660_init':
drivers/media/usb/gspca/m5602/m5602_ov7660.c:99:9: warning: variable 
'err' set but not used [-Wunused-but-set-variable]

It should be noticed that the original error code was crappy, as it wasn't
returning any error if sensor init fails.

Fix it by returning an error if the sensor can't be initialized.

Cc: Hans de Goede 
Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/usb/gspca/m5602/m5602_ov7660.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/usb/gspca/m5602/m5602_ov7660.c 
b/drivers/media/usb/gspca/m5602/m5602_ov7660.c
index 4ac7889..64b3b03 100644
--- a/drivers/media/usb/gspca/m5602/m5602_ov7660.c
+++ b/drivers/media/usb/gspca/m5602/m5602_ov7660.c
@@ -96,7 +96,7 @@ sensor_found:
 
 int ov7660_init(struct sd *sd)
 {
-   int i, err = 0;
+   int i, err;
 
/* Init the sensor */
for (i = 0; i < ARRAY_SIZE(init_ov7660); i++) {
@@ -111,6 +111,8 @@ int ov7660_init(struct sd *sd)
err = m5602_write_sensor(sd,
init_ov7660[i][1], data, 1);
}
+   if (err < 0)
+   return err;
}
 
if (dump_sensor)
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] [media] drxk: fix CNR calculus

2013-03-22 Thread Mauro Carvalho Chehab

Changeset 8f3741e accidentally broke the CNR estimation. It should
be calculated as "a + b - c". However, previously, the subtraction
by c only occurred if SNR would be positive, due to a bad binding
to DVBv3 API.

This also fixes the following warning:
drivers/media/dvb-frontends/drxk_hard.c:2556:6: warning: variable 'c' 
set but not used [-Wunused-but-set-variable]

Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/dvb-frontends/drxk_hard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/drxk_hard.c 
b/drivers/media/dvb-frontends/drxk_hard.c
index fc93bd3..55a4c22 100644
--- a/drivers/media/dvb-frontends/drxk_hard.c
+++ b/drivers/media/dvb-frontends/drxk_hard.c
@@ -2628,7 +2628,7 @@ static int GetDVBTSignalToNoise(struct drxk_state *state,
/* log(x) x = (16bits + 16bits) << 15 ->32 bits  */
c = Log10Times100(SqrErrIQ);
 
-   iMER = a + b;
+   iMER = a + b - c;
}
*pSignalToNoise = iMER;
 
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] [media] siano: remove the ir protocol field

2013-03-22 Thread Mauro Carvalho Chehab

This field is unused. Remove it.

Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/common/siano/smsir.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/common/siano/smsir.h 
b/drivers/media/common/siano/smsir.h
index 69b59b9..fc8b792 100644
--- a/drivers/media/common/siano/smsir.h
+++ b/drivers/media/common/siano/smsir.h
@@ -40,7 +40,6 @@ struct ir_t {
char phys[32];
 
char *rc_codes;
-   u64 protocol;
 
u32 timeout;
u32 controller;
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] [media] em28xx: Only change I2C bus inside em28xx-i2c

2013-03-22 Thread Mauro Carvalho Chehab

There's currently a bug on em28xx-i2c that makes it write the
wrong values to register 06, that controlls the I2C bus speed
and bus.

Fix it to change only the I2C bus flag.

Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/usb/em28xx/em28xx-i2c.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c 
b/drivers/media/usb/em28xx/em28xx-i2c.c
index de9b208..9e2fa41 100644
--- a/drivers/media/usb/em28xx/em28xx-i2c.c
+++ b/drivers/media/usb/em28xx/em28xx-i2c.c
@@ -284,6 +284,7 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap,
struct em28xx *dev = i2c_bus->dev;
unsigned bus = i2c_bus->bus;
int addr, rc, i, byte;
+   u8 reg;
 
rc = rt_mutex_trylock(&dev->i2c_bus_lock);
if (rc < 0)
@@ -292,10 +293,11 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap,
/* Switch I2C bus if needed */
if (bus != dev->cur_i2c_bus) {
if (bus == 1)
-   dev->cur_i2c_bus |= EM2874_I2C_SECONDARY_BUS_SELECT;
+   reg = EM2874_I2C_SECONDARY_BUS_SELECT;
else
-   dev->cur_i2c_bus &= ~EM2874_I2C_SECONDARY_BUS_SELECT;
-   em28xx_write_reg(dev, EM28XX_R06_I2C_CLK, dev->cur_i2c_bus);
+   reg = 0;
+   em28xx_write_reg_bits(dev, EM28XX_R06_I2C_CLK, reg,
+ EM2874_I2C_SECONDARY_BUS_SELECT);
dev->cur_i2c_bus = bus;
}
 
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[GIT PULL FOR v3.10] au0828 driver overhaul

2013-03-22 Thread Hans Verkuil

Hi all,

This pull request converts the au0828/au8522 drivers to the latest frameworks,
except for vb2 as usual.

Tested with a WinTV aero generously donated by Hauppauge some time ago.

I also did a lot of fixes in the disconnect handling and setting up the
right routing/std information at the right time.

It works fine with qv4l2, but there is still a bug causing tvtime to fail.
That's caused by commit e58071f024aa337b7ce41682578b33895b024f8b, applied
August last year, that broke g_tuner: after that 'signal' would always be 0
and tvtime expects signal to be non-zero for a valid frequency. The signal
field is set by the au8522, but g_tuner is only called for the tuner (well,
also for au8522 but since the i2c gate is set for the tuner that won't do
anything).

I have a patch for that but I want to convert that to using an i2c mux instead.

For the time being I'd like to get this merged since at least it is in a
lot better shape.

Note: this pull request sits on top of this 'const' pull request:

http://patchwork.linuxtv.org/patch/17568/

Regards,

Hans

The following changes since commit 8bf1a5a826d06a9b6f65b3e8dffb9be59d8937c3:

  v4l2-ioctl: add precision when printing names. (2013-03-22 11:59:21 +0100)

are available in the git repository at:

  git://linuxtv.org/hverkuil/media_tree.git au0828b

for you to fetch changes up to 9b216a590115ea8aac389b9bb9248b7adce25f7f:

  au0828: improve firmware loading & locking. (2013-03-22 17:13:57 +0100)


Hans Verkuil (15):
  au8522_decoder: convert to the control framework.
  au0828: fix querycap.
  au0828: frequency handling fixes.
  au0828: fix intendation coding style issue.
  au0828: fix audio input handling.
  au0828: convert to the control framework.
  au0828: add prio, control event and log_status support
  au0828: add try_fmt_vbi support, zero vbi.reserved, pix.priv.
  au0828: replace deprecated current_norm by g_std.
  au8522_decoder: remove obsolete control ops.
  au0828: fix disconnect sequence.
  au0828: simplify i2c_gate_ctrl.
  au0828: don't change global state information on open().
  au0828: fix initial video routing.
  au0828: improve firmware loading & locking.

 drivers/media/dvb-frontends/au8522_decoder.c |  123 --
 drivers/media/dvb-frontends/au8522_priv.h|6 +-
 drivers/media/usb/au0828/au0828-core.c   |   61 +
 drivers/media/usb/au0828/au0828-video.c  |  286 

 drivers/media/usb/au0828/au0828.h|7 ++
 5 files changed, 260 insertions(+), 223 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-22 Thread edubez...@gmail.com

Hello Hans,

On Fri, Mar 22, 2013 at 10:04 AM, Hans Verkuil  wrote:

>>
>> # on your branch on the other hand I get a NULL pointer:
>
> I've fixed that (v4l2_dev was never initialized), and I've also rebased my 
> tree
> to the latest code. Can you try again?
>

This time I get a kernel crash at _power. Unfortunately I cannot fetch
the crash log as I am not having access to a serial line (using vga
console) and in my setup mtdoops is not working somehow.

Sequence is 
v4l2_ioctl->video_usercopy->__video_do_ioctl->v4l_s_ctrl->v4l2_s_ctrl->set_ctrl_lock->try_or_set_cluster->si4713_s_ctrl->si4713_set_power_state->mutex_lock_nested->lock_acquire.

I 'd need to spend some time on it to understand better your patches
and help you to get this working. And for that I'd prob need to spend
some time to either hack a serial line or get mtdoops to work :-)

> Regards,
>
> Hans

-- 
Eduardo Bezerra Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL FOR v3.10] au0828 driver overhaul

2013-03-22 Thread Hans Verkuil

On Fri March 22 2013 17:22:24 Hans Verkuil wrote:
> Hi all,
> 
> This pull request converts the au0828/au8522 drivers to the latest frameworks,
> except for vb2 as usual.
> 
> Tested with a WinTV aero generously donated by Hauppauge some time ago.
> 
> I also did a lot of fixes in the disconnect handling and setting up the
> right routing/std information at the right time.
> 
> It works fine with qv4l2, but there is still a bug causing tvtime to fail.
> That's caused by commit e58071f024aa337b7ce41682578b33895b024f8b, applied
> August last year, that broke g_tuner: after that 'signal' would always be 0
> and tvtime expects signal to be non-zero for a valid frequency. The signal
> field is set by the au8522, but g_tuner is only called for the tuner (well,
> also for au8522 but since the i2c gate is set for the tuner that won't do
> anything).
> 
> I have a patch for that but I want to convert that to using an i2c mux 
> instead.
> 
> For the time being I'd like to get this merged since at least it is in a
> lot better shape.
> 
> Note: this pull request sits on top of this 'const' pull request:
> 
> http://patchwork.linuxtv.org/patch/17568/
> 
> Regards,
> 
> Hans

Oops, missed a compiler warning relating to the const changes.

Nacked-by: Hans Verkuil 

I'll post a new, fixed, version.

Regards,

Hans

> 
> The following changes since commit 8bf1a5a826d06a9b6f65b3e8dffb9be59d8937c3:
> 
>   v4l2-ioctl: add precision when printing names. (2013-03-22 11:59:21 +0100)
> 
> are available in the git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git au0828b
> 
> for you to fetch changes up to 9b216a590115ea8aac389b9bb9248b7adce25f7f:
> 
>   au0828: improve firmware loading & locking. (2013-03-22 17:13:57 +0100)
> 
> 
> Hans Verkuil (15):
>   au8522_decoder: convert to the control framework.
>   au0828: fix querycap.
>   au0828: frequency handling fixes.
>   au0828: fix intendation coding style issue.
>   au0828: fix audio input handling.
>   au0828: convert to the control framework.
>   au0828: add prio, control event and log_status support
>   au0828: add try_fmt_vbi support, zero vbi.reserved, pix.priv.
>   au0828: replace deprecated current_norm by g_std.
>   au8522_decoder: remove obsolete control ops.
>   au0828: fix disconnect sequence.
>   au0828: simplify i2c_gate_ctrl.
>   au0828: don't change global state information on open().
>   au0828: fix initial video routing.
>   au0828: improve firmware loading & locking.
> 
>  drivers/media/dvb-frontends/au8522_decoder.c |  123 
> --
>  drivers/media/dvb-frontends/au8522_priv.h|6 +-
>  drivers/media/usb/au0828/au0828-core.c   |   61 +
>  drivers/media/usb/au0828/au0828-video.c  |  286 
> 
>  drivers/media/usb/au0828/au0828.h|7 ++
>  5 files changed, 260 insertions(+), 223 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[GIT PULL FOR v3.10] au0828 driver overhaul

2013-03-22 Thread Hans Verkuil

Hi all,

This pull request converts the au0828/au8522 drivers to the latest frameworks,
except for vb2 as usual.

Tested with a WinTV aero generously donated by Hauppauge some time ago.

I also did a lot of fixes in the disconnect handling and setting up the
right routing/std information at the right time.

It works fine with qv4l2, but there is still a bug causing tvtime to fail.
That's caused by commit e58071f024aa337b7ce41682578b33895b024f8b, applied
August last year, that broke g_tuner: after that 'signal' would always be 0
and tvtime expects signal to be non-zero for a valid frequency. The signal
field is set by the au8522, but g_tuner is only called for the tuner (well,
also for au8522 but since the i2c gate is set for the tuner that won't do
anything).

I have a patch for that but I want to convert that to using an i2c mux instead.

For the time being I'd like to get this merged since at least it is in a
lot better shape.

Note: this pull request sits on top of this 'const' pull request:

http://patchwork.linuxtv.org/patch/17568/

Regards,

Hans

The following changes since commit 8bf1a5a826d06a9b6f65b3e8dffb9be59d8937c3:

  v4l2-ioctl: add precision when printing names. (2013-03-22 11:59:21 +0100)

are available in the git repository at:

  git://linuxtv.org/hverkuil/media_tree.git au0828c

for you to fetch changes up to fbb5b69d62a7eb9b1dc4783a52ebe45c850c510a:

  au0828: improve firmware loading & locking. (2013-03-22 17:34:15 +0100)


Hans Verkuil (15):
  au8522_decoder: convert to the control framework.
  au0828: fix querycap.
  au0828: frequency handling fixes.
  au0828: fix intendation coding style issue.
  au0828: fix audio input handling.
  au0828: convert to the control framework.
  au0828: add prio, control event and log_status support
  au0828: add try_fmt_vbi support, zero vbi.reserved, pix.priv.
  au0828: replace deprecated current_norm by g_std.
  au8522_decoder: remove obsolete control ops.
  au0828: fix disconnect sequence.
  au0828: simplify i2c_gate_ctrl.
  au0828: don't change global state information on open().
  au0828: fix initial video routing.
  au0828: improve firmware loading & locking.

 drivers/media/dvb-frontends/au8522_decoder.c |  123 --
 drivers/media/dvb-frontends/au8522_priv.h|6 +-
 drivers/media/usb/au0828/au0828-core.c   |   61 +
 drivers/media/usb/au0828/au0828-video.c  |  287 

 drivers/media/usb/au0828/au0828.h|7 ++
 5 files changed, 261 insertions(+), 223 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-22 Thread Hans Verkuil

On Fri March 22 2013 17:26:57 edubez...@gmail.com wrote:
> Hello Hans,
> 
> On Fri, Mar 22, 2013 at 10:04 AM, Hans Verkuil  wrote:
> 
> 
> >>
> >> # on your branch on the other hand I get a NULL pointer:
> >
> > I've fixed that (v4l2_dev was never initialized), and I've also rebased my 
> > tree
> > to the latest code. Can you try again?
> >
> 
> This time I get a kernel crash at _power. Unfortunately I cannot fetch
> the crash log as I am not having access to a serial line (using vga
> console) and in my setup mtdoops is not working somehow.
> 
> 
> Sequence is 
> v4l2_ioctl->video_usercopy->__video_do_ioctl->v4l_s_ctrl->v4l2_s_ctrl->set_ctrl_lock->try_or_set_cluster->si4713_s_ctrl->si4713_set_power_state->mutex_lock_nested->lock_acquire.
> 
> 
> I 'd need to spend some time on it to understand better your patches
> and help you to get this working. And for that I'd prob need to spend
> some time to either hack a serial line or get mtdoops to work :-)

You're doing fine: that was all the info I needed. Can you do a git pull and
try again?

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-22 Thread edubez...@gmail.com

Hans,


On Fri, Mar 22, 2013 at 12:45 PM, Hans Verkuil  wrote:
> On Fri March 22 2013 17:26:57 edubez...@gmail.com wrote:
>> Hello Hans,
>>
>> On Fri, Mar 22, 2013 at 10:04 AM, Hans Verkuil  wrote:
>> 
>>
>> >>
>> >> # on your branch on the other hand I get a NULL pointer:
>> >
>> > I've fixed that (v4l2_dev was never initialized), and I've also rebased my 
>> > tree
>> > to the latest code. Can you try again?
>> >
>>
>> This time I get a kernel crash at _power. Unfortunately I cannot fetch
>> the crash log as I am not having access to a serial line (using vga
>> console) and in my setup mtdoops is not working somehow.
>>
>>
>> Sequence is 
>> v4l2_ioctl->video_usercopy->__video_do_ioctl->v4l_s_ctrl->v4l2_s_ctrl->set_ctrl_lock->try_or_set_cluster->si4713_s_ctrl->si4713_set_power_state->mutex_lock_nested->lock_acquire.
>>
>>
>> I 'd need to spend some time on it to understand better your patches
>> and help you to get this working. And for that I'd prob need to spend
>> some time to either hack a serial line or get mtdoops to work :-)
>
> You're doing fine: that was all the info I needed. Can you do a git pull and
> try again?
>

Sure. Your patch removes the locks but I believe the set_power is used in other
places as well. And has a misspell: s/clocks/locks.

But now I still get the nested lock issue. But this time around
si4713_setup, that is called from _s_ctrl and which in turns calls
v4l2_ctrl_handler_setup, which call s_ctrl again.

> Regards,
>
> Hans



-- 
Eduardo Bezerra Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] media: si4713: minor updates

2013-03-22 Thread Hans Verkuil

On Fri March 22 2013 17:59:00 edubez...@gmail.com wrote:
> Hans,
> 
> 
> On Fri, Mar 22, 2013 at 12:45 PM, Hans Verkuil  wrote:
> > On Fri March 22 2013 17:26:57 edubez...@gmail.com wrote:
> >> Hello Hans,
> >>
> >> On Fri, Mar 22, 2013 at 10:04 AM, Hans Verkuil  wrote:
> >> 
> >>
> >> >>
> >> >> # on your branch on the other hand I get a NULL pointer:
> >> >
> >> > I've fixed that (v4l2_dev was never initialized), and I've also rebased 
> >> > my tree
> >> > to the latest code. Can you try again?
> >> >
> >>
> >> This time I get a kernel crash at _power. Unfortunately I cannot fetch
> >> the crash log as I am not having access to a serial line (using vga
> >> console) and in my setup mtdoops is not working somehow.
> >>
> >>
> >> Sequence is 
> >> v4l2_ioctl->video_usercopy->__video_do_ioctl->v4l_s_ctrl->v4l2_s_ctrl->set_ctrl_lock->try_or_set_cluster->si4713_s_ctrl->si4713_set_power_state->mutex_lock_nested->lock_acquire.
> >>
> >>
> >> I 'd need to spend some time on it to understand better your patches
> >> and help you to get this working. And for that I'd prob need to spend
> >> some time to either hack a serial line or get mtdoops to work :-)
> >
> > You're doing fine: that was all the info I needed. Can you do a git pull and
> > try again?
> >
> 
> Sure. Your patch removes the locks but I believe the set_power is used in 
> other
> places as well. And has a misspell: s/clocks/locks.
> 
> But now I still get the nested lock issue. But this time around
> si4713_setup, that is called from _s_ctrl and which in turns calls
> v4l2_ctrl_handler_setup, which call s_ctrl again.

One last try: again do a git pull and see what happens.

I'm on irc at the moment, that's a bit more interactive.

It's clear by the way that I need to study the locking scheme in this
driver, but I'd really like to see the v4l2-compliance output :-)

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Fwd: [SE-2011-01] PoC code for digital SAT TV research released

2013-03-22 Thread Antti Palosaari

Could be interesting reading for DTV hackers!

regards
Antti

 Original Message 
Subject: [SE-2011-01] PoC code for digital SAT TV research released
Date: Thu, 21 Mar 2013 14:30:41 +0100
From: Security Explorations 
To: full-disclos...@lists.grok.org.uk, bugt...@securityfocus.com

Hello All,

Last year, we disclosed information pertaining to security issues
discovered as a result of our digital satellite TV research [1].

It's been over a year and we haven't received [2] information with
respect to the status and impact of the vulnerabilities found in:
- digital satellite TV set-top-boxes produced by Advanced Digital
  Broadcast [3],
- DVB / MPEG chipsets manufactured by STMicroelectronics [4].

We haven't received important information from Conax AS [5] either.

This in particular concerns a final security level assigned by the
company to set-top boxes and secure DVB chipsets evaluated as part
of Conax security / evaluation process. Conax "rigorous evaluation
and testing regime" [6] missed serious security vulnerabilities
potentially affecting 540 millions [7] of DVB / MPEG chipsets.

Today, a new digital satellite TV platform starts in Poland. It is
called NC+ [8] and it is apparently based on equipment / technology
coming from several vendors, which were affected by security issues
found as part of SE-2011-01 project.

We take the above as a perfect opportunity to verify whether these
vendors had learned anything from the results of our 1.5 years long
research. We assume that they have and that in particular:
- all of security issues discovered as part of our SE-2011-01 project
  have been properly resolved,
- new equipment is considerably harder to hack or use for any SAT TV
  piracy purposes.

We decided to release our Proof of Concept code developed as part of
SE-2011-01 project [9]. Its source code is is available for download
from the following location:

http://www.security-explorations.com/en/SE-2011-01-details.html

We believe that the security community and professionals involved in
a development of digital satellite TV ecosystems should benefit the
most from the release of our Proof of Concept code.

Thank you.

Best Regards,
Adam Gowdiak

-
Security Explorations
http://www.security-explorations.com
"We bring security research to the new level"
-

References:
[1] SE-2011-01 Security weaknesses in a digital satellite TV platform
http://www.security-explorations.com/en/SE-2011-01.html
[2] SE-2011-01 Vendors status
http://www.security-explorations.com/en/SE-2011-01-status.html
[3] Advanced Digital Broadcast
http://www.adbglobal.com
[4] STMicroelectronics
http://www.st.com
[5] Conax AS
http://www.conax.com
[6] Conax Security Evaluation Scheme

http://www.conax.com/products-solutions/advanced-security-features/security-evaluation-scheme/
[7] Multimedia Convergence & ACCI Sector Overview, Philippe Lambinet,
STMicroelectronics

http://www.st.com/internet/com/CORPORATE_RESOURCES/COMPANY/COMPANY_PRESENTATION/5_mult_conv_acci_lambinet.pdf
[8] NC+ Digital Satellite TV Plaform
http://ncplus.pl/
[9] SE-2011-01 Proof of Concept Code (technical information)
http://www.security-explorations.com/en/SE-2011-01-poc.html

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL FOR v3.10] au0828 driver overhaul

2013-03-22 Thread Devin Heitmueller

On Fri, Mar 22, 2013 at 12:38 PM, Hans Verkuil  wrote:
> It works fine with qv4l2, but there is still a bug causing tvtime to fail.
> That's caused by commit e58071f024aa337b7ce41682578b33895b024f8b, applied
> August last year, that broke g_tuner: after that 'signal' would always be 0
> and tvtime expects signal to be non-zero for a valid frequency. The signal
> field is set by the au8522, but g_tuner is only called for the tuner (well,
> also for au8522 but since the i2c gate is set for the tuner that won't do
> anything).

During your testing, did you bisect the entire media tree or just the
au0828/au8522 driver.  This discovery is pretty damn surprising since
I actively test with tvtime whenever I do any work on that driver.
Are you sure something else in the framework didn't change which
caused breakage for this driver?

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL FOR v3.10] au0828 driver overhaul

2013-03-22 Thread Devin Heitmueller

On Fri, Mar 22, 2013 at 12:38 PM, Hans Verkuil  wrote:
> It works fine with qv4l2, but there is still a bug causing tvtime to fail.
> That's caused by commit e58071f024aa337b7ce41682578b33895b024f8b, applied
> August last year, that broke g_tuner: after that 'signal' would always be 0
> and tvtime expects signal to be non-zero for a valid frequency. The signal
> field is set by the au8522, but g_tuner is only called for the tuner (well,
> also for au8522 but since the i2c gate is set for the tuner that won't do
> anything).

Wait, are you saying that the G_TUNER call is no longer being routed
to the au8522 driver?  The signal level has always been set to a
nonzero value by au8522 if a signal is present, and thus the state of
the i2c gate isn't relevant.  This is because the xc5000 driver didn't
actually have implemented a call to return the signal level.

If what you're saying is true, then the behavior of the framework
itself changed, and who knows what else is broken.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

cron job: media_tree daily build: ERRORS

2013-03-22 Thread Hans Verkuil

This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.

Results of the daily build of media_tree:

date:   Fri Mar 22 19:00:27 CET 2013
git branch: test
git hash:   bc3d292803409ce44febffb8e6839faae6e768fb
gcc version:i686-linux-gcc (GCC) 4.7.2
host hardware:  x86_64
host os:3.8-3.slh.2-amd64

linux-git-arm-davinci: OK
linux-git-arm-exynos: ERRORS
linux-git-arm-omap: WARNINGS
linux-git-blackfin: WARNINGS
linux-git-i686: OK
linux-git-m32r: OK
linux-git-mips: ERRORS
linux-git-powerpc64: OK
linux-git-sh: OK
linux-git-x86_64: OK
linux-2.6.31.14-i686: WARNINGS
linux-2.6.32.27-i686: WARNINGS
linux-2.6.33.7-i686: WARNINGS
linux-2.6.34.7-i686: WARNINGS
linux-2.6.35.9-i686: WARNINGS
linux-2.6.36.4-i686: WARNINGS
linux-2.6.37.6-i686: WARNINGS
linux-2.6.38.8-i686: WARNINGS
linux-2.6.39.4-i686: WARNINGS
linux-3.0.60-i686: WARNINGS
linux-3.1.10-i686: WARNINGS
linux-3.2.37-i686: WARNINGS
linux-3.3.8-i686: WARNINGS
linux-3.4.27-i686: WARNINGS
linux-3.5.7-i686: WARNINGS
linux-3.6.11-i686: ERRORS
linux-3.7.4-i686: ERRORS
linux-3.8-i686: ERRORS
linux-3.9-rc1-i686: WARNINGS
linux-2.6.31.14-x86_64: WARNINGS
linux-2.6.32.27-x86_64: WARNINGS
linux-2.6.33.7-x86_64: WARNINGS
linux-2.6.34.7-x86_64: WARNINGS
linux-2.6.35.9-x86_64: WARNINGS
linux-2.6.36.4-x86_64: WARNINGS
linux-2.6.37.6-x86_64: WARNINGS
linux-2.6.38.8-x86_64: WARNINGS
linux-2.6.39.4-x86_64: WARNINGS
linux-3.0.60-x86_64: WARNINGS
linux-3.1.10-x86_64: WARNINGS
linux-3.2.37-x86_64: WARNINGS
linux-3.3.8-x86_64: WARNINGS
linux-3.4.27-x86_64: WARNINGS
linux-3.5.7-x86_64: WARNINGS
linux-3.6.11-x86_64: ERRORS
linux-3.7.4-x86_64: ERRORS
linux-3.8-x86_64: ERRORS
linux-3.9-rc1-x86_64: WARNINGS
apps: WARNINGS
spec-git: OK
sparse: ERRORS

Detailed results are available here:

http://www.xs4all.nl/~hverkuil/logs/Friday.log

Full logs are available here:

http://www.xs4all.nl/~hverkuil/logs/Friday.tar.bz2

The Media Infrastructure API from this daily build is here:

http://www.xs4all.nl/~hverkuil/spec/media.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] davinci: vpss: clock cleanup

[PATCH 1/2] media: davinci: vpss: enable vpss clocks

[PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

Re: media-tree build is broken

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

Re: [REVIEW PATCH 11/41] af9035: basic support for IT9135 v2 chips

[GIT PULL FOR v3.10] v4l2: make arg of write-only ioctls const

Re: [PATCH -next] [media] dvb_usb_v2: make local function dvb_usb_v2_generic_io() static

Re: [REVIEW PATCH 11/41] af9035: basic support for IT9135 v2 chips

[PATCH] [media] hdpvr: vidioc_g_fmt_vid_cap should not fail

Re: [GIT PULL FOR v3.10] v4l2: make arg of write-only ioctls const

[GIT PULL FOR v3.10] v4l2: make arg of write-only ioctls const

Re: [PATCH] [media] hdpvr: vidioc_g_fmt_vid_cap should not fail

Re: media-tree build is broken

[GIT PULL FOR v3.10] solo6x10 driver overhaul

Re: media-tree build is broken

Re: [PATCH] net: add ETH_P_802_3_MIN

[PATCH] em28xx: tuner setup is broken after algo_data change.

Re: [PATCH 0/4] media: si4713: minor updates

[GIT PULL FOR v3.10] go7007 driver overhaul

[PATCH 3/3] [media] m5602_ov7660: return error at ov7660_init()

[PATCH 1/3] [media] drxk: fix CNR calculus

[PATCH 2/3] [media] siano: remove the ir protocol field

[PATCH] [media] em28xx: Only change I2C bus inside em28xx-i2c

[GIT PULL FOR v3.10] au0828 driver overhaul

Re: [PATCH 0/4] media: si4713: minor updates

Re: [GIT PULL FOR v3.10] au0828 driver overhaul

[GIT PULL FOR v3.10] au0828 driver overhaul

Re: [PATCH 0/4] media: si4713: minor updates

Re: [PATCH 0/4] media: si4713: minor updates

Re: [PATCH 0/4] media: si4713: minor updates

Fwd: [SE-2011-01] PoC code for digital SAT TV research released

Re: [GIT PULL FOR v3.10] au0828 driver overhaul

Re: [GIT PULL FOR v3.10] au0828 driver overhaul

cron job: media_tree daily build: ERRORS

35 matches

Site Navigation

Mail list logo

Footer information