Re: [RFC/PATCH] arm: omap: hwmod: add debugfs interface
On Tue, 20 Jan 2015, Paul Walmsley wrote: On Fri, 5 Dec 2014, Felipe Balbi wrote: By exposing the details of hwmod structures to debugfs we can much more easily verify that changes to hwmod data is correct and won't cause regressions. The idea is that this can be used to check the state of one hwmod, verify hwmod sysc fields, etc. For example, this will be used to move some of the sysc fields to DT and later verify that they are correct pre- and post-patch. Signed-off-by: Felipe Balbi ba...@ti.com This one had a bunch of unnecessary includes and checkpatch issues (below). I cleaned those up here and have queued the result (also below) for v3.20. ... and, the patch doesn't even boot. Dropped. If you really want something like this to be merged, resend a version that boots, and has checkpatch warnings fixed and unnecessary includes dropped. Otherwise you're just wasting my time. - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH] arm: omap: hwmod: add debugfs interface
Hi, On Tue, Jan 20, 2015 at 08:13:57AM +, Paul Walmsley wrote: On Tue, 20 Jan 2015, Paul Walmsley wrote: On Fri, 5 Dec 2014, Felipe Balbi wrote: By exposing the details of hwmod structures to debugfs we can much more easily verify that changes to hwmod data is correct and won't cause regressions. The idea is that this can be used to check the state of one hwmod, verify hwmod sysc fields, etc. For example, this will be used to move some of the sysc fields to DT and later verify that they are correct pre- and post-patch. Signed-off-by: Felipe Balbi ba...@ti.com This one had a bunch of unnecessary includes and checkpatch issues (below). I cleaned those up here and have queued the result (also below) for v3.20. ... and, the patch doesn't even boot. Dropped. If you really want something like this to be merged, resend a version that boots, and has checkpatch warnings fixed and unnecessary includes dropped. Otherwise you're just wasting my time. you're using a really old version, though. There have been other versions which are still under discussion. -- balbi signature.asc Description: Digital signature
Re: [RFC/PATCH] arm: omap: hwmod: add debugfs interface
On Tue, Jan 20, 2015 at 08:36:03AM -0600, Felipe Balbi wrote: Hi, On Tue, Jan 20, 2015 at 08:13:57AM +, Paul Walmsley wrote: On Tue, 20 Jan 2015, Paul Walmsley wrote: On Fri, 5 Dec 2014, Felipe Balbi wrote: By exposing the details of hwmod structures to debugfs we can much more easily verify that changes to hwmod data is correct and won't cause regressions. The idea is that this can be used to check the state of one hwmod, verify hwmod sysc fields, etc. For example, this will be used to move some of the sysc fields to DT and later verify that they are correct pre- and post-patch. Signed-off-by: Felipe Balbi ba...@ti.com This one had a bunch of unnecessary includes and checkpatch issues (below). I cleaned those up here and have queued the result (also below) for v3.20. ... and, the patch doesn't even boot. Dropped. If you really want something like this to be merged, resend a version that boots, and has checkpatch warnings fixed and unnecessary includes dropped. Otherwise you're just wasting my time. you're using a really old version, though. There have been other versions which are still under discussion. not to mention that this was an RFC, not meant for merging at the time it was sent. -- balbi signature.asc Description: Digital signature
Re: [RFC/PATCH] arm: omap: hwmod: add debugfs interface
On Fri, 5 Dec 2014, Felipe Balbi wrote: By exposing the details of hwmod structures to debugfs we can much more easily verify that changes to hwmod data is correct and won't cause regressions. The idea is that this can be used to check the state of one hwmod, verify hwmod sysc fields, etc. For example, this will be used to move some of the sysc fields to DT and later verify that they are correct pre- and post-patch. Signed-off-by: Felipe Balbi ba...@ti.com This one had a bunch of unnecessary includes and checkpatch issues (below). I cleaned those up here and have queued the result (also below) for v3.20. - Paul CHECK: extern prototypes should be avoided in .h files #61: FILE: arch/arm/mach-omap2/omap_hwmod.h:772: +extern int __init omap_hwmod_debug_init(void); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 CHECK: Alignment should match open parenthesis #116: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:44: +static int __init omap_hwmod_create_files(struct omap_hwmod *oh, + struct dentry *dir) CHECK: Alignment should match open parenthesis #129: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:57: + file = debugfs_create_u8(response_lat, S_IRUGO, dir, + oh-response_lat); CHECK: Alignment should match open parenthesis #134: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:62: + file = debugfs_create_u8(rst_lines_cnt, S_IRUGO, dir, + oh-rst_lines_cnt); CHECK: Alignment should match open parenthesis #139: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:67: + file = debugfs_create_u8(opt_clks_cnt, S_IRUGO, dir, + oh-opt_clks_cnt); CHECK: Alignment should match open parenthesis #164: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:92: + file = debugfs_create_u8(_postsetup_state, S_IRUGO, dir, + oh-_postsetup_state); ERROR: need consistent spacing around '*' (ctx:WxV) #173: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:101: + dentry *dir) ^ CHECK: Alignment should match open parenthesis #186: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:114: + file = debugfs_create_x32(rev_offs, S_IRUGO, subdir, + sysc-rev_offs); CHECK: Alignment should match open parenthesis #191: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:119: + file = debugfs_create_x32(sysc_offs, S_IRUGO, subdir, + sysc-sysc_offs); CHECK: Alignment should match open parenthesis #196: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:124: + file = debugfs_create_x32(syss_offs, S_IRUGO, subdir, + sysc-syss_offs); CHECK: Alignment should match open parenthesis #201: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:129: + file = debugfs_create_x16(sysc_flags, S_IRUGO, subdir, + sysc-sysc_flags); CHECK: Alignment should match open parenthesis #206: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:134: + file = debugfs_create_u8(srst_udelay, S_IRUGO, subdir, + sysc-srst_udelay); WARNING: line over 80 characters #210: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:138: + file = debugfs_create_x8(idlemodes, S_IRUGO, subdir, sysc-idlemodes); CHECK: Alignment should match open parenthesis #222: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:150: +static int __init omap_hwmod_create_class_files(struct omap_hwmod_class *class, + struct dentry *dir) CHECK: Alignment should match open parenthesis #247: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:175: +static int __init omap_hwmod_create_irq_files(struct omap_hwmod_irq_info *irqs, + struct dentry *dir) CHECK: Alignment should match open parenthesis #263: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:191: + file = debugfs_create_u16(irqs[i].name, S_IRUGO, subdir, + irqs[i].irq); CHECK: Alignment should match open parenthesis #273: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:201: +static int __init omap_hwmod_create_dma_files(struct omap_hwmod_dma_info *dmas, + struct dentry *dir) CHECK: Alignment should match open parenthesis #289: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:217: + file = debugfs_create_u16(dmas[i].name, S_IRUGO, subdir, + dmas[i].dma_req); CHECK: Alignment should match open parenthesis #299: FILE: arch/arm/mach-omap2/omap_hwmod_debugfs.c:227: +static int __init omap_hwmod_debugfs_create_subdir(struct omap_hwmod *oh, + void *data) total: 1 errors, 2 warnings, 17 checks, 305 lines checked Your patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [PATCH] arm: omap: hwmod: add debugfs interface By exposing the details of hwmod structures to debugfs
[RFC/PATCH] arm: omap: hwmod: add debugfs interface
By exposing the details of hwmod structures
to debugfs we can much more easily verify
that changes to hwmod data is correct and won't
cause regressions.
The idea is that this can be used to check the
state of one hwmod, verify hwmod sysc fields, etc.
For example, this will be used to move some of
the sysc fields to DT and later verify that they
are correct pre- and post-patch.
Signed-off-by: Felipe Balbi ba...@ti.com
---
The idea behind this is that I'll be moving some more of hwmod
data to DT and this will help diff pre- and post-patch boots
to see if data remained the same.
Tested with AM437x SK, logs here:
http://hastebin.com/ukahuvipiz
arch/arm/mach-omap2/Makefile | 2 +-
arch/arm/mach-omap2/omap_hwmod.c | 1 +
arch/arm/mach-omap2/omap_hwmod.h | 6 +
arch/arm/mach-omap2/omap_hwmod_debugfs.c | 280 +++
4 files changed, 288 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/mach-omap2/omap_hwmod_debugfs.c
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index 5d27dfd..68c9ae5 100644
--- a/arch/arm/mach-omap2/Makefile
+++ b/arch/arm/mach-omap2/Makefile
@@ -11,7 +11,7 @@ obj-y := id.o io.o control.o mux.o devices.o fb.o serial.o
timer.o pm.o \
omap_device.o sram.o drm.o
hwmod-common = omap_hwmod.o omap_hwmod_reset.o \
- omap_hwmod_common_data.o
+ omap_hwmod_common_data.o
omap_hwmod_debugfs.o
clock-common = clock.o clock_common_data.o \
clkt_dpll.o clkt_clksel.o
secure-common = omap-smc.o omap-secure.o
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index cbb908d..a01caa4 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -3314,6 +3314,7 @@ static int __init omap_hwmod_setup_all(void)
omap_hwmod_for_each(_init, NULL);
omap_hwmod_for_each(_setup, NULL);
+ omap_hwmod_debug_init();
return 0;
}
diff --git a/arch/arm/mach-omap2/omap_hwmod.h b/arch/arm/mach-omap2/omap_hwmod.h
index 35ca6ef..49f1d82 100644
--- a/arch/arm/mach-omap2/omap_hwmod.h
+++ b/arch/arm/mach-omap2/omap_hwmod.h
@@ -768,4 +768,10 @@ int am43xx_hwmod_init(void);
extern int __init omap_hwmod_register_links(struct omap_hwmod_ocp_if **ois);
+#if IS_ENABLED(CONFIG_DEBUG_FS)
+extern int __init omap_hwmod_debug_init(void);
+#else
+static inline int __int omap_hwmod_debug_init(void) { return 0; }
+#endif
+
#endif
diff --git a/arch/arm/mach-omap2/omap_hwmod_debugfs.c
b/arch/arm/mach-omap2/omap_hwmod_debugfs.c
new file mode 100644
index 000..eb120a4
--- /dev/null
+++ b/arch/arm/mach-omap2/omap_hwmod_debugfs.c
@@ -0,0 +1,280 @@
+/*
+ * omap_hwmod debugfs view
+ *
+ * Copyright (C) 2014 Texas Instruments, Incorporated - http://www.ti.com
+ * Author: Felipe Balbi ba...@ti.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+#undef DEBUG
+
+#include linux/kernel.h
+#include linux/errno.h
+#include linux/io.h
+#include linux/err.h
+#include linux/fs.h
+#include linux/list.h
+#include linux/mutex.h
+#include linux/spinlock.h
+#include linux/debugfs.h
+#include linux/seq_file.h
+
+#include clock.h
+#include omap_hwmod.h
+
+#include soc.h
+#include common.h
+#include clockdomain.h
+#include powerdomain.h
+#include cm2xxx.h
+#include cm3xxx.h
+#include cm33xx.h
+#include prm.h
+#include prm3xxx.h
+#include prm44xx.h
+#include prm33xx.h
+#include prminst44xx.h
+#include mux.h
+#include pm.h
+
+#if IS_ENABLED(CONFIG_DEBUG_FS)
+static int __init omap_hwmod_create_files(struct omap_hwmod *oh,
+ struct dentry *dir)
+{
+ struct dentry *file;
+
+ file = debugfs_create_u16(flags, S_IRUGO, dir, oh-flags);
+ if (!file)
+ return -ENOMEM;
+
+ file = debugfs_create_u8(mpu_rt_idx, S_IRUGO, dir, oh-mpu_rt_idx);
+ if (!file)
+ return -ENOMEM;
+
+ file = debugfs_create_u8(response_lat, S_IRUGO, dir,
+ oh-response_lat);
+ if (!file)
+ return -ENOMEM;
+
+ file = debugfs_create_u8(rst_lines_cnt, S_IRUGO, dir,
+ oh-rst_lines_cnt);
+ if (!file)
+ return -ENOMEM;
+
+ file = debugfs_create_u8(opt_clks_cnt, S_IRUGO, dir,
+ oh-opt_clks_cnt);
+ if (!file)
+ return -ENOMEM;
+
+ file = debugfs_create_u8(masters_cnt, S_IRUGO, dir, oh-masters_cnt);
+ if (!file)
+ return -ENOMEM;
+
+ file = debugfs_create_u8(slaves_cnt, S_IRUGO, dir, oh-slaves_cnt);
+ if (!file)
+ return -ENOMEM;
+
+ file = debugfs_create_u8(hwmods_cnt, S_IRUGO, dir, oh-hwmods_cnt);
+
