Re: [Linuxwacom-devel] Feature request: inverting parameters
On 2011-03-01 18:36, Jason Gerecke wrote: On Mon, Feb 28, 2011 at 3:45 AM, Pander pan...@users.sourceforge.net wrote: Hi all, I would like to make the following feature request for inverting/toggling parameters. Please extend values for the following parameters with invert: touch: on, off, invert (toggle) gesture:on, off, invert (toggle) tabletpcbutton: on, off, invert (toggle) rawfilter: on, off, invert (toggle) mode: absolute, relative, invert (toggle) rotate: none, cw, ccw, half, invert (+180 degrees) Implementing this will make it easier for application, scripts, and command line usage to toggle parameters without having to remember the status or first requesting the current status in order to toggle a value. Thanks, Pander PS This would only apply to xsetwacom and control via GNOME. It is not advisable to use this in xorg config files. I can see how a way to toggle/invert the existing option would make things easier, but it doesn't seem like something that was particularly hard to begin with. Getting the current status from xsetwacom is almost trivial, and inverting it only slightly less so. That said, I'm not really opposed to a patch for this functionality -- its just not something I seem much of a use for. The use case would be to use button 4 of my tablet or someting in GNOME for enabling/disabling touchgesture, and button 3 or CTRL+button4 or something else in GNOME for switching between absolute and relative mode via xsetwacom. Of course, this could be done inside the driver. In that implementation I'm interested too. Actually more then via xsetwacom. Attached you will find some scripts that (at the moment) do not do anything, except showcase the notification and document the use case. Regards, Pander Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. wacom-config-notify.tar.gz Description: GNU Zip compressed data -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL
On Sun, Feb 27, 2011 at 12:16 PM, Pander pan...@users.sourceforge.netwrote: Hi all, Here are some patches for supporting Wacom Bamboo Fun CTH-661SE-NL. These are created on a system with Ubuntu 10.10 Maverick. The USB ID has been added to the USB ID Repository at https://usb-ids.gowdy.us/read/UD/056a/00db Before this trickles down, the following patches need to be applied: --- /var/lib/usbutils/.usb.ids 2011-02-27 20:58:10.58605 +0100 +++ /var/lib/usbutils/usb.ids 2011-02-27 21:01:34.706049996 +0100 @@ -4892,6 +4892,7 @@ 00c6 Cintiq 12WX 00c7 DTU-1931 00d3 Bamboo Fun (CTH-661) + 00db Bamboo Fun (CTH-661SE-NL) 0400 PenPartner 4x5 4850 PenPartner 6x8 056b Decicon, Inc. --- /usr/share/hwdata/.usb.ids 2011-02-27 21:07:29.386049996 +0100 +++ /usr/share/hwdata/usb.ids 2011-02-27 21:08:04.076049994 +0100 @@ -4629,6 +4629,7 @@ 0044 Intuos2 12x12 0045 Intuos2 12x18 00b5 Intuos3 6x11 (PTZ-631W) + 00db Bamboo Fun (CTH-661SE-NL) 0400 PenPartner 4x5 4850 PenPartner 6x8 056b Decicon, Inc. --- /lib/modules/2.6.35-25-generic/.modules.alias 2011-02-27 16:18:03.554113003 +0100 +++ /lib/modules/2.6.35-25-generic/modules.alias2011-02-27 16:18:46.304113004 +0100 @@ -7842,6 +7842,7 @@ alias usb:v056Ap0012d*dc*dsc*dp*ic*isc*i alias usb:v056Ap0011d*dc*dsc*dp*ic*isc*ip* wacom alias usb:v056Ap0010d*dc*dsc*dp*ic*isc*ip* wacom alias usb:v056Apd*dc*dsc*dp*ic*isc*ip* wacom +alias usb:v056Ap00DBd*dc*dsc*dp*ic*isc*ip* wacom alias platform:88pm860x-touch 88pm860x_ts alias spi:ad7877 ad7877 alias spi:ad7879 ad7879 --- /lib/modules/2.6.35-25-generic/.modules.usbmap 2011-02-27 16:15:12.214112988 +0100 +++ /lib/modules/2.6.35-25-generic/modules.usbmap 2011-02-27 16:17:21.934112993 +0100 @@ -3533,6 +3533,7 @@ wacom0x0003 0x056a wacom0x0003 0x056a 0x00e20x 0x 0x00 0x000x000x000x00 0x00 0x0 wacom0x0003 0x056a 0x00e30x 0x 0x00 0x000x000x000x00 0x00 0x0 wacom0x0003 0x056a 0x00470x 0x 0x00 0x000x000x000x00 0x00 0x0 +wacom0x0003 0x056a 0x00db0x 0x 0x00 0x000x000x000x00 0x00 0x0 usbtouchscreen 0x0283 0x0eef 0x00010x 0x 0x00 0x000x000x030x00 0x02 0x0 usbtouchscreen 0x0283 0x0eef 0x00020x 0x 0x00 0x000x000x030x00 0x02 0x0 usbtouchscreen 0x0003 0x3823 0x00010x 0x 0x00 0x000x000x000x00 0x00 0x0 Those files do not blong to wacom driver. Please also report them upstream. There is nothing we can do about those files. Please let me know what to add to /lib/udev/rules.d/69-xserver-xorg-input-wacom.rules for this Wacom Bamboo Fun (pen and touch) This could be something we care. But I am not sure where we need to include it: xf86-input-wacom, the X server driver for version 1.7 and later does not include the .rules file any more. Let's ask the list to see what they want. Do we still need the .rules for static defined devices in xorg.conf? Ping -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting
On Tue, Mar 01, 2011 at 12:19:42PM -0600, Favux ... wrote: Xorg.conf.d is finished. Please review it when you get a chance. Done, I think. Please let me know if I culled too much. IMO, one example is enough and we should rely on our users being smart enough to interpolate from the examples. Cheers, Peter On Sun, Feb 27, 2011 at 8:59 PM, Peter Hutterer peter.hutte...@who-t.net wrote: thanks. As you can see from the history, I'd like to make this new page the main [[xorg.conf.d]] page and link to it from Configuring_X. there's plenty of information we should provide that it warrants a separate page. especially since we have different configurations for 1.8, 1.9 and 1.10. I haven't really finished with it yet though, I'll try to edit it over the next few days. The main plan is: - use MatchDriver instead of duplicating the matches (for server 1.9+) - don't tell users to search for the right snippets (they stack anyway), just explain how they can write one that applies to their device Cheers, Peter -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Small patch to improve comment
On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote:
Hi all,
Small patch to improve comment in src/wcmUSB.c
line 200 CTH-661 - Bamboo Fun CTH-661SE-NL
See attachment. Can someone take this patch under consideration?
I also have a question related to this model. Is it correct that the new
series Bamboo Fun (the one above with Touch and Pen and Gesture) are
usbBamboo and the older Bamboo Fun are usbBambooFun?
Thanks,
Pander
--- src/.wcmUSB.c 2011-03-01 09:44:04.274570995 +0100
+++ src/wcmUSB.c 2011-03-01 09:45:58.944570994 +0100
@@ -200,7 +200,7 @@ static struct
{ WACOM_VENDOR_ID, 0xD7, 10, 10, usbBamboo }, /* CTH-461/S
*/
{ WACOM_VENDOR_ID, 0xD8, 10, 10, usbBamboo }, /*
CTH-661/S1 */
{ WACOM_VENDOR_ID, 0xDA, 10, 10, usbBamboo }, /* CTH-461/L
*/
- { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* CTH-661 */
+ { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* Bamboo
Fun CTH-661SE-NL */
{ WACOM_VENDOR_ID, 0x20, 10, 10, usbIntuos }, /* Intuos
4x5 */
{ WACOM_VENDOR_ID, 0x21, 10, 10, usbIntuos }, /* Intuos
6x8 */
Chris or Ping, can I have your ACK on this, you know the bamboos better.
Pander - please submit as a signed-off, git-formatted patch as outlined in
https://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Submitting_Patches
Cheers,
Peter
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Feature request: inverting parameters
On Tue, Mar 01, 2011 at 09:52:27AM +0100, Pander wrote:
On 2011-02-28 12:45, Pander wrote:
Hi all,
I would like to make the following feature request for
inverting/toggling parameters.
Please extend values for the following parameters with invert:
touch: on, off, invert (toggle)
gesture:on, off, invert (toggle)
tabletpcbutton: on, off, invert (toggle)
rawfilter: on, off, invert (toggle)
mode: absolute, relative, invert (toggle)
rotate: none, cw, ccw, half, invert (+180 degrees)
Implementing this will make it easier for application, scripts, and
command line usage to toggle parameters without having to remember the
status or first requesting the current status in order to toggle a value.
I have made an attempt myself but it will only work once. :( Could
someone help me out with this one since I'm new to this project.
--- xf86-input-wacom/tools/.xsetwacom.c 2011-02-28 23:45:44.886995005
+0100
+++ xf86-input-wacom/tools/xsetwacom.c2011-03-01 00:06:43.296995005
+0100
@@ -1351,6 +1351,11 @@ static void set_mode(Display *dpy, XDevi
mode = Relative;
else if (strcasecmp(argv[0], Absolute) == 0)
mode = Absolute;
+ else if (strcasecmp(argv[0], invert) == 0)
+ if (mode == Absolute)
+ mode = Relative;
+ else if (mode == Relative)
+ mode = Absolute;
you need to get the current mode from the server before toggling.
currently this will always set the mode to relative.
else
{
printf(Invalid device mode. Use 'Relative' or 'Absolute'.\n);
@@ -1389,6 +1394,15 @@ static void set_rotate(Display *dpy, XDe
if (rotation 0 || rotation 3)
goto error;
}
+ else if (strcasecmp(argv[0], invert) == 0)
+ if (rotation == 0)
+ rotation = 3;
+ else if (rotation == 1)
+ rotataion = 2;
+ else if (rotation == 2)
+ rotation = 1;
+ else if (rotation == 3)
+ rotation = 0;
same here.
Cheers,
Peter
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [PATCH] Move VCOPY storage out of the function.
Not 100% sure why this is needed but it looks like the returned address is
invalid, causing memory corruption. Simply moving the variable into a global
scope fixes this issue.
Fixes crash with server 1.7.
Reported-by: Vu Ngoc San san.vu-n...@laposte.net
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/wcmCommon.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index e469e15..64e10cc 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -36,9 +36,9 @@
* data beforehand.
*/
#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) 11
+static int v[MAX_VALUATORS];
static int *VCOPY(const int *valuators, int nvals)
{
- static int v[MAX_VALUATORS];
memcpy(v, valuators, nvals * sizeof(int));
return v;
}
--
1.7.4
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [PATCH 1/3] test: add ifdefs to allow running tests against 1.7
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
test/fake-symbols.c | 10 --
test/fake-symbols.h |9 -
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/test/fake-symbols.c b/test/fake-symbols.c
index b0af219..9d00d2d 100644
--- a/test/fake-symbols.c
+++ b/test/fake-symbols.c
@@ -132,12 +132,13 @@ DeleteInputDeviceRequest(DeviceIntPtr pDev)
}
+#if GET_ABI_MAJOR(ABI_XINPUT_VERSION = 11)
_X_EXPORT void
FreeInputAttributes(InputAttributes *attrs)
{
return;
}
-
+#endif
_X_EXPORT void
xf86PostButtonEvent(DeviceIntPtr device,
@@ -249,7 +250,10 @@ GetTimeInMillis (void)
_X_EXPORT int
-NewInputDeviceRequest (InputOption *options, InputAttributes *attrs,
+NewInputDeviceRequest (InputOption *options,
+#if GET_ABI_MAJOR(ABI_XINPUT_VERSION = 11)
+ InputAttributes *attrs,
+#endif
DeviceIntPtr *pdev)
{
return 0;
@@ -269,11 +273,13 @@ miPointerGetScreen(DeviceIntPtr pDev)
return NULL;
}
+#if GET_ABI_MAJOR(ABI_XINPUT_VERSION = 11)
_X_EXPORT InputAttributes*
DuplicateInputAttributes(InputAttributes *attrs)
{
return NULL;
}
+#endif
_X_EXPORT int
ValidAtom(Atom atom)
diff --git a/test/fake-symbols.h b/test/fake-symbols.h
index c713b5e..5593879 100644
--- a/test/fake-symbols.h
+++ b/test/fake-symbols.h
@@ -36,7 +36,9 @@ xf86ScaleAxis(int Cx,
int from_min );
extern void DeleteInputDeviceRequest(DeviceIntPtr pDev);
+#if GET_ABI_MAJOR(ABI_XINPUT_VERSION = 11)
extern void FreeInputAttributes(InputAttributes *attrs);
+#endif
extern void
xf86PostButtonEvent(DeviceIntPtr device,
intis_absolute,
@@ -85,14 +87,19 @@ XIChangeDeviceProperty (DeviceIntPtr dev, Atom property,
Atom type,
extern CARD32 GetTimeInMillis (void);
extern int
-NewInputDeviceRequest (InputOption *options, InputAttributes *attrs,
+NewInputDeviceRequest (InputOption *options,
+#if GET_ABI_MAJOR(ABI_XINPUT_VERSION = 11)
+ InputAttributes *attrs,
+#endif
DeviceIntPtr *pdev);
extern Bool
InitLedFeedbackClassDeviceStruct (DeviceIntPtr dev, LedCtrlProcPtr
controlProc);
extern ScreenPtr miPointerGetScreen(DeviceIntPtr pDev);
+#if GET_ABI_MAJOR(ABI_XINPUT_VERSION = 11)
extern InputAttributes* DuplicateInputAttributes(InputAttributes *attrs);
+#endif
extern int ValidAtom(Atom atom);
extern Bool
InitKeyboardDeviceStruct(DeviceIntPtr dev, XkbRMLVOSet *rmlvo,
--
1.7.4
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting
Alright, looks good. I think I like the new tip appearance. Intriguing anyway. If we do a separate Bamboo page do we pull the examples along and put new examples in the Xorg.conf.d? Favux On Tue, Mar 1, 2011 at 5:36 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at 12:19:42PM -0600, Favux ... wrote: Xorg.conf.d is finished. Please review it when you get a chance. Done, I think. Please let me know if I culled too much. IMO, one example is enough and we should rely on our users being smart enough to interpolate from the examples. Cheers, Peter On Sun, Feb 27, 2011 at 8:59 PM, Peter Hutterer peter.hutte...@who-t.net wrote: thanks. As you can see from the history, I'd like to make this new page the main [[xorg.conf.d]] page and link to it from Configuring_X. there's plenty of information we should provide that it warrants a separate page. especially since we have different configurations for 1.8, 1.9 and 1.10. I haven't really finished with it yet though, I'll try to edit it over the next few days. The main plan is: - use MatchDriver instead of duplicating the matches (for server 1.9+) - don't tell users to search for the right snippets (they stack anyway), just explain how they can write one that applies to their device Cheers, Peter -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Feature request: inverting parameters
On Mon, Feb 28, 2011 at 12:45:35PM +0100, Pander wrote: I would like to make the following feature request for inverting/toggling parameters. Please extend values for the following parameters with invert: touch: on, off, invert (toggle) gesture:on, off, invert (toggle) tabletpcbutton: on, off, invert (toggle) rawfilter: on, off, invert (toggle) mode: absolute, relative, invert (toggle) rotate: none, cw, ccw, half, invert (+180 degrees) Implementing this will make it easier for application, scripts, and command line usage to toggle parameters without having to remember the status or first requesting the current status in order to toggle a value. tbh, I'm not a big fan of this. it's a few lines to implement toggle in whatever script/config tool you need. and one of the things we've found with toggle in the past is that it is quite hard to get right because you don't always know where you're toggling too. e.g. in GNOME + xkb we had the issue that our toggle touchpad key would get out of sync and enable in hardware but disable in software (and vice versa), leading to a dead touchpad. besides, there's the naming. toggle works for touch as toggling an option is an understood concept. inverting touch isn't quite as clear, imo. inverting or toggling a mode is confusing, a better name may be switching or so. rotating - cycle? and once you start cycling through the options, do you have next and previous as well? I think the current xsetwacom interface is simple enough that this can be easily implemented on top where a toggle command is needed. Cheers, Peter -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [PATCH] xsetwacom.c: Fix a typo preventing Rotate ccw from working
Introduced in ac821ba29a828fb9bb531243d0a226a7fe494504 Signed-off-by: Timo Aaltonen timo.aalto...@canonical.com --- tools/xsetwacom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 6713a97..fa98e3e 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -1377,7 +1377,7 @@ static void set_rotate(Display *dpy, XDevice *dev, param_t* param, int argc, cha if (strcasecmp(argv[0], cw) == 0) rotation = 1; - else if (strcasecmp(argv[0], cww) == 0) + else if (strcasecmp(argv[0], ccw) == 0) rotation = 2; else if (strcasecmp(argv[0], half) == 0) rotation = 3; -- 1.7.4.1 -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting
On Tue, Mar 1, 2011 at 7:42 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at 07:35:02PM -0600, Favux ... wrote: Alright, looks good. I think I like the new tip appearance. Intriguing anyway. If we do a separate Bamboo page do we pull the examples along and put new examples in the Xorg.conf.d? yeah I think so. the example in the xorg.conf.d page should be the standard example without special cases. btw, Chris: wasn't there a Bamboo change in the kernel that the devices are now on a single device? Or am I confusing something here? Its still two devices in all versions. We talked about merging them but tabled it for now. I'm sure It will come up again at some point in Xinput 2.1 and pointer emulation discussions. Chris -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Small patch to improve comment
Hi,
I'm not sure that follows our little naming convention for wcmUSB.c.
I believe that model was first reported by Tobias Verbeke (12-4-10) as
the Bamboo PT Special Edition medium CTH-661/L. Tobias is also the
tested-by on at least the linux-input patch. If we change it we
should change it to:
/* CTH-661/L */
To bring it into conformity with the /* CTH-461/L */.
We call it the Wacom Bamboo 2FG 6x8 SE in wacom_wac.c.
Favux
On Tue, Mar 1, 2011 at 4:32 PM, Peter Hutterer peter.hutte...@who-t.net wrote:
On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote:
Hi all,
Small patch to improve comment in src/wcmUSB.c
line 200 CTH-661 - Bamboo Fun CTH-661SE-NL
See attachment. Can someone take this patch under consideration?
I also have a question related to this model. Is it correct that the new
series Bamboo Fun (the one above with Touch and Pen and Gesture) are
usbBamboo and the older Bamboo Fun are usbBambooFun?
Thanks,
Pander
--- src/.wcmUSB.c 2011-03-01 09:44:04.274570995 +0100
+++ src/wcmUSB.c 2011-03-01 09:45:58.944570994 +0100
@@ -200,7 +200,7 @@ static struct
{ WACOM_VENDOR_ID, 0xD7, 10, 10, usbBamboo }, /*
CTH-461/S */
{ WACOM_VENDOR_ID, 0xD8, 10, 10, usbBamboo }, /*
CTH-661/S1 */
{ WACOM_VENDOR_ID, 0xDA, 10, 10, usbBamboo }, /*
CTH-461/L */
- { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* CTH-661
*/
+ { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* Bamboo
Fun CTH-661SE-NL */
{ WACOM_VENDOR_ID, 0x20, 10, 10, usbIntuos }, /* Intuos
4x5 */
{ WACOM_VENDOR_ID, 0x21, 10, 10, usbIntuos }, /* Intuos
6x8 */
Chris or Ping, can I have your ACK on this, you know the bamboos better.
Pander - please submit as a signed-off, git-formatted patch as outlined in
https://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Submitting_Patches
Cheers,
Peter
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Small patch to improve comment
Dave, can you comment on this? I tend to rely on the information
you've collected in Ubuntu forum (probably its in wiki now?). See
below.
On Tue, Mar 1, 2011 at 4:32 PM, Peter Hutterer peter.hutte...@who-t.net wrote:
On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote:
Hi all,
Small patch to improve comment in src/wcmUSB.c
line 200 CTH-661 - Bamboo Fun CTH-661SE-NL
See attachment. Can someone take this patch under consideration?
I also have a question related to this model. Is it correct that the new
series Bamboo Fun (the one above with Touch and Pen and Gesture) are
usbBamboo and the older Bamboo Fun are usbBambooFun?
Thanks,
Pander
--- src/.wcmUSB.c 2011-03-01 09:44:04.274570995 +0100
+++ src/wcmUSB.c 2011-03-01 09:45:58.944570994 +0100
@@ -200,7 +200,7 @@ static struct
{ WACOM_VENDOR_ID, 0xD7, 10, 10, usbBamboo }, /*
CTH-461/S */
{ WACOM_VENDOR_ID, 0xD8, 10, 10, usbBamboo }, /*
CTH-661/S1 */
{ WACOM_VENDOR_ID, 0xDA, 10, 10, usbBamboo }, /*
CTH-461/L */
- { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* CTH-661
*/
+ { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* Bamboo
Fun CTH-661SE-NL */
{ WACOM_VENDOR_ID, 0x20, 10, 10, usbIntuos }, /* Intuos
4x5 */
{ WACOM_VENDOR_ID, 0x21, 10, 10, usbIntuos }, /* Intuos
6x8 */
Chris or Ping, can I have your ACK on this, you know the bamboos better.
The following is from info Dave collected:
Bamboo P T Special Edition Small (CTH461/L; Product ID = 0xdA)
Bamboo P T Special Edition Medium (CTH661/L; Product ID = 0xdB)
I'm not sure where the pre-existing convention of /L, /S1, etc
comes from since my Bamboo is simply CTH-460. Is it from output of
lsusb (iProduct) or is it from back of tablet?
Following the convention of Small Special Edition tablet, it should
read CTH-661/L.
Chris
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Small patch to improve comment
On Tue, Mar 1, 2011 at 2:32 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote:
Hi all,
Small patch to improve comment in src/wcmUSB.c
line 200 CTH-661 - Bamboo Fun CTH-661SE-NL
See attachment. Can someone take this patch under consideration?
I also have a question related to this model. Is it correct that the new
series Bamboo Fun (the one above with Touch and Pen and Gesture) are
usbBamboo and the older Bamboo Fun are usbBambooFun?
Thanks,
Pander
--- src/.wcmUSB.c 2011-03-01 09:44:04.274570995 +0100
+++ src/wcmUSB.c 2011-03-01 09:45:58.944570994 +0100
@@ -200,7 +200,7 @@ static struct
{ WACOM_VENDOR_ID, 0xD7, 10, 10, usbBamboo }, /*
CTH-461/S */
{ WACOM_VENDOR_ID, 0xD8, 10, 10, usbBamboo }, /*
CTH-661/S1 */
{ WACOM_VENDOR_ID, 0xDA, 10, 10, usbBamboo }, /*
CTH-461/L */
- { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /*
CTH-661 */
+ { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /*
Bamboo Fun CTH-661SE-NL */
{ WACOM_VENDOR_ID, 0x20, 10, 10, usbIntuos }, /*
Intuos 4x5 */
{ WACOM_VENDOR_ID, 0x21, 10, 10, usbIntuos }, /*
Intuos 6x8 */
Chris or Ping, can I have your ACK on this, you know the bamboos better.
I have no clue. I'll ack the patch if we get one more confirmation from the
list.
Ping
Pander - please submit as a signed-off, git-formatted patch as outlined in
https://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Submitting_Patches
Cheers,
Peter
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT
data
generated by your applications, servers and devices whether physical,
virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev ___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting
On Tue, Mar 1, 2011 at 5:42 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Mar 01, 2011 at 07:35:02PM -0600, Favux ... wrote: Alright, looks good. I think I like the new tip appearance. Intriguing anyway. If we do a separate Bamboo page do we pull the examples along and put new examples in the Xorg.conf.d? yeah I think so. the example in the xorg.conf.d page should be the standard example without special cases. btw, Chris: wasn't there a Bamboo change in the kernel that the devices are now on a single device? Or am I confusing something here? No, pen and touch are not on the same logical port (if that is what you are asking for). This is true for all pen and touch enabled devices, not just Bamboo or Wacom devices. If we want to unify them, we would have to redesign it in the HID-layer for all pen and touch enabled devices. It can not be done within Wacom kernel driver. Ping -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Small patch to improve comment
On 2011-03-02 16:17, Chris Bagwell wrote:
Dave, can you comment on this? I tend to rely on the information
you've collected in Ubuntu forum (probably its in wiki now?). See
below.
On Tue, Mar 1, 2011 at 4:32 PM, Peter Hutterer peter.hutte...@who-t.net
wrote:
On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote:
Hi all,
Small patch to improve comment in src/wcmUSB.c
line 200 CTH-661 - Bamboo Fun CTH-661SE-NL
See attachment. Can someone take this patch under consideration?
I also have a question related to this model. Is it correct that the new
series Bamboo Fun (the one above with Touch and Pen and Gesture) are
usbBamboo and the older Bamboo Fun are usbBambooFun?
Thanks,
Pander
--- src/.wcmUSB.c 2011-03-01 09:44:04.274570995 +0100
+++ src/wcmUSB.c 2011-03-01 09:45:58.944570994 +0100
@@ -200,7 +200,7 @@ static struct
{ WACOM_VENDOR_ID, 0xD7, 10, 10, usbBamboo }, /*
CTH-461/S */
{ WACOM_VENDOR_ID, 0xD8, 10, 10, usbBamboo }, /*
CTH-661/S1 */
{ WACOM_VENDOR_ID, 0xDA, 10, 10, usbBamboo }, /*
CTH-461/L */
- { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* CTH-661
*/
+ { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* Bamboo
Fun CTH-661SE-NL */
{ WACOM_VENDOR_ID, 0x20, 10, 10, usbIntuos }, /* Intuos
4x5 */
{ WACOM_VENDOR_ID, 0x21, 10, 10, usbIntuos }, /* Intuos
6x8 */
Chris or Ping, can I have your ACK on this, you know the bamboos better.
The following is from info Dave collected:
Bamboo P T Special Edition Small (CTH461/L; Product ID = 0xdA)
Bamboo P T Special Edition Medium (CTH661/L; Product ID = 0xdB)
I'm not sure where the pre-existing convention of /L, /S1, etc
comes from since my Bamboo is simply CTH-460. Is it from output of
lsusb (iProduct) or is it from back of tablet?
Following the convention of Small Special Edition tablet, it should
read CTH-661/L.
Hi all, It is fine by me if it is the project's naming convention.
The USB ID list here:
https://usb-ids.gowdy.us/read/UD/056a
has been created without any conventions by many different users. If it
is necessary, perhaps supply the maintainer of https://usb-ids.gowdy.us
with a bulk update per email. I understand that technically this might
not be necessary but documentation wise it could be good to do anyway to
avoid misunderstandings.
Does anyone have advise on how to troubleshoot stylus and eraser
pressure levels? In GIMP and Inkscape I ony get nothing or 100% even
though I followed the instructions from
https://help.ubuntu.com/community/Wacom
Regards,
Pander
Chris
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] [PATCH] Move VCOPY storage out of the function.
On Tue, Mar 1, 2011 at 4:33 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
Not 100% sure why this is needed but it looks like the returned address is
invalid, causing memory corruption. Simply moving the variable into a
global
scope fixes this issue.
Fixes crash with server 1.7.
Reported-by: Vu Ngoc San san.vu-n...@laposte.net
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/wcmCommon.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index e469e15..64e10cc 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -36,9 +36,9 @@
* data beforehand.
*/
#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) 11
+static int v[MAX_VALUATORS];
static int *VCOPY(const int *valuators, int nvals)
{
- static int v[MAX_VALUATORS];
memcpy(v, valuators, nvals * sizeof(int));
return v;
Once the routine is returned, the pointer is out of the scope.
To return a valid pointer, the array has to be declared outside of VCOPY.
You could declare it in the calling routine if you don't like it as a global
variable.
With that said,
Reviewed-by: Ping Cheng pingli...@gmail.com
Ping
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev ___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Heading towards regular releases
On Tue, Mar 1, 2011 at 5:55 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Following up on this, I just bumped the version in git to 0.10.99. New release versioning scheme until we settle on a stable 1.0: - 0.x.99 is the version number in-between releases - 0.x.99.901 is the first RC - 0.x.99.902 is the second RC - 0.x+1.0 is next the release Any version bump other than to .99 is coupled with a tag and a tarball so users and distros can get the newest goodness easily. Note that this is the same versioning scheme we use in X.Org, so I'm less likely to get it confused ;) I'm planning for 901 on April 1st (yes, it'll be a hoot!) and then the release soon after that, depending on the issues we see with the RCs. Either way, we'll have a 0.11 release early-April. That's about as precise as I can plan at this point :) For the time between 0.10.99.901 and 0.11 I won't merge any intrusive patches, only stuff that fixes actual issues. Any comments or extra requests? Thank you for sharing the plan ahead of the release. I am fine with the plan as long as we have a plan. I have a question about the definition of stuff that fixes actual issues. You know I am still holding the workaround I made for fixing the hotplugging device enable/disable issue. Before we get a barrier from X server that tells us we are getting the last configured input device (are you plan to do that?), we can only work on one device at a time. I know if hotplugging is provided through udev, all tools could be added insider xf86-input-wacom, if all tools are configured with the same options. What about hotplugging based on HAL? Do we care about that case? So, basically, I need to know if you would consider that patch as fixing actual issues or not. It is not a perfect solution. But, there is not way to make it perfect without getting help from outside of the driver. It does narrow the race condition. Ping -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Small patch to improve comment
Hi Chris,
We got it from the label on the back of the tablet to start
distinguishing them from the previous 5 models. Because some of the
Bamboo models were overlapping.
Pander, the Ubuntu community wikis are maintained by Ubuntu users, not
the linux wacom project. Loic2 is no longer maintaining the Wacom
wiki pages. His thread associated with the wiki is here:
http://ubuntuforums.org/showthread.php?t=967147 At least one other
person has done an update. You could start updating them if you
wanted to.
I'll submit a patch for /* CTH-661/L */ if wanted.
Favux
On Wed, Mar 2, 2011 at 9:56 AM, Pander pan...@users.sourceforge.net wrote:
On 2011-03-02 16:17, Chris Bagwell wrote:
Dave, can you comment on this? I tend to rely on the information
you've collected in Ubuntu forum (probably its in wiki now?). See
below.
On Tue, Mar 1, 2011 at 4:32 PM, Peter Hutterer peter.hutte...@who-t.net
wrote:
On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote:
Hi all,
Small patch to improve comment in src/wcmUSB.c
line 200 CTH-661 - Bamboo Fun CTH-661SE-NL
See attachment. Can someone take this patch under consideration?
I also have a question related to this model. Is it correct that the new
series Bamboo Fun (the one above with Touch and Pen and Gesture) are
usbBamboo and the older Bamboo Fun are usbBambooFun?
Thanks,
Pander
--- src/.wcmUSB.c 2011-03-01 09:44:04.274570995 +0100
+++ src/wcmUSB.c 2011-03-01 09:45:58.944570994 +0100
@@ -200,7 +200,7 @@ static struct
{ WACOM_VENDOR_ID, 0xD7, 10, 10, usbBamboo }, /*
CTH-461/S */
{ WACOM_VENDOR_ID, 0xD8, 10, 10, usbBamboo }, /*
CTH-661/S1 */
{ WACOM_VENDOR_ID, 0xDA, 10, 10, usbBamboo }, /*
CTH-461/L */
- { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /*
CTH-661 */
+ { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /* Bamboo
Fun CTH-661SE-NL */
{ WACOM_VENDOR_ID, 0x20, 10, 10, usbIntuos }, /* Intuos
4x5 */
{ WACOM_VENDOR_ID, 0x21, 10, 10, usbIntuos }, /* Intuos
6x8 */
Chris or Ping, can I have your ACK on this, you know the bamboos better.
The following is from info Dave collected:
Bamboo P T Special Edition Small (CTH461/L; Product ID = 0xdA)
Bamboo P T Special Edition Medium (CTH661/L; Product ID = 0xdB)
I'm not sure where the pre-existing convention of /L, /S1, etc
comes from since my Bamboo is simply CTH-460. Is it from output of
lsusb (iProduct) or is it from back of tablet?
Following the convention of Small Special Edition tablet, it should
read CTH-661/L.
Hi all, It is fine by me if it is the project's naming convention.
The USB ID list here:
https://usb-ids.gowdy.us/read/UD/056a
has been created without any conventions by many different users. If it
is necessary, perhaps supply the maintainer of https://usb-ids.gowdy.us
with a bulk update per email. I understand that technically this might
not be necessary but documentation wise it could be good to do anyway to
avoid misunderstandings.
Does anyone have advise on how to troubleshoot stylus and eraser
pressure levels? In GIMP and Inkscape I ony get nothing or 100% even
though I followed the instructions from
https://help.ubuntu.com/community/Wacom
Regards,
Pander
Chris
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Small patch to improve comment
On 2011-03-02 22:24, Favux ... wrote:
Hi Chris,
We got it from the label on the back of the tablet to start
distinguishing them from the previous 5 models. Because some of the
Bamboo models were overlapping.
See below for extra data on my tablet.
Pander, the Ubuntu community wikis are maintained by Ubuntu users, not
the linux wacom project. Loic2 is no longer maintaining the Wacom
wiki pages. His thread associated with the wiki is here:
http://ubuntuforums.org/showthread.php?t=967147 At least one other
person has done an update. You could start updating them if you
wanted to.
I have already updated to screenshots for GIMP. However, troubleshooting
pressure levels should also be easily possible via the driver/tools I
think. Anyway, good news is that meanwhile pressure levels work for me :D.
I'll submit a patch for /* CTH-661/L */ if wanted.
See below for all data. Best is that you guys decide.
Favux
On Wed, Mar 2, 2011 at 9:56 AM, Pander pan...@users.sourceforge.net wrote:
On 2011-03-02 16:17, Chris Bagwell wrote:
Dave, can you comment on this? I tend to rely on the information
you've collected in Ubuntu forum (probably its in wiki now?). See
below.
On Tue, Mar 1, 2011 at 4:32 PM, Peter Hutterer peter.hutte...@who-t.net
wrote:
On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote:
Hi all,
Small patch to improve comment in src/wcmUSB.c
line 200 CTH-661 - Bamboo Fun CTH-661SE-NL
See attachment. Can someone take this patch under consideration?
I also have a question related to this model. Is it correct that the new
series Bamboo Fun (the one above with Touch and Pen and Gesture) are
usbBamboo and the older Bamboo Fun are usbBambooFun?
Thanks,
Pander
--- src/.wcmUSB.c 2011-03-01 09:44:04.274570995 +0100
+++ src/wcmUSB.c 2011-03-01 09:45:58.944570994 +0100
@@ -200,7 +200,7 @@ static struct
{ WACOM_VENDOR_ID, 0xD7, 10, 10, usbBamboo }, /*
CTH-461/S */
{ WACOM_VENDOR_ID, 0xD8, 10, 10, usbBamboo }, /*
CTH-661/S1 */
{ WACOM_VENDOR_ID, 0xDA, 10, 10, usbBamboo }, /*
CTH-461/L */
- { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /*
CTH-661 */
+ { WACOM_VENDOR_ID, 0xDB, 10, 10, usbBamboo }, /*
Bamboo Fun CTH-661SE-NL */
{ WACOM_VENDOR_ID, 0x20, 10, 10, usbIntuos }, /*
Intuos 4x5 */
{ WACOM_VENDOR_ID, 0x21, 10, 10, usbIntuos }, /*
Intuos 6x8 */
Chris or Ping, can I have your ACK on this, you know the bamboos better.
The following is from info Dave collected:
Bamboo P T Special Edition Small (CTH461/L; Product ID = 0xdA)
Bamboo P T Special Edition Medium (CTH661/L; Product ID = 0xdB)
I'm not sure where the pre-existing convention of /L, /S1, etc
comes from since my Bamboo is simply CTH-460. Is it from output of
lsusb (iProduct) or is it from back of tablet?
Following the convention of Small Special Edition tablet, it should
read CTH-661/L.
The barcode on the back of tablet 056a:00db reads indeed:
CTH-661/L
The package says also:
Bamboo Pen Touch Special Edition Medium
The barcode on the package says:
CTH-661SE-NL (Special Edition Netherlands)
That is what I added to https://usb-ids.gowdy.us/read/UD/056a
Hi all, It is fine by me if it is the project's naming convention.
The USB ID list here:
https://usb-ids.gowdy.us/read/UD/056a
has been created without any conventions by many different users. If it
is necessary, perhaps supply the maintainer of https://usb-ids.gowdy.us
with a bulk update per email. I understand that technically this might
not be necessary but documentation wise it could be good to do anyway to
avoid misunderstandings.
Does anyone have advise on how to troubleshoot stylus and eraser
pressure levels? In GIMP and Inkscape I ony get nothing or 100% even
though I followed the instructions from
https://help.ubuntu.com/community/Wacom
Regards,
Pander
Chris
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights.
Re: [Linuxwacom-devel] [PATCH] Move VCOPY storage out of the function.
On Wed, Mar 02, 2011 at 10:43:34AM -0800, Ping Cheng wrote:
On Tue, Mar 1, 2011 at 4:33 PM, Peter Hutterer
peter.hutte...@who-t.netwrote:
Not 100% sure why this is needed but it looks like the returned address is
invalid, causing memory corruption. Simply moving the variable into a
global
scope fixes this issue.
Fixes crash with server 1.7.
Reported-by: Vu Ngoc San san.vu-n...@laposte.net
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/wcmCommon.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index e469e15..64e10cc 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -36,9 +36,9 @@
* data beforehand.
*/
#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) 11
+static int v[MAX_VALUATORS];
static int *VCOPY(const int *valuators, int nvals)
{
- static int v[MAX_VALUATORS];
memcpy(v, valuators, nvals * sizeof(int));
return v;
Once the routine is returned, the pointer is out of the scope.
To return a valid pointer, the array has to be declared outside of VCOPY.
You could declare it in the calling routine if you don't like it as a global
variable.
well, that's the bit that is confusing me. since the storage is static, why
would the address to it be invalid (or even temporary)?
With that said,
Reviewed-by: Ping Cheng pingli...@gmail.com
thanks!
Cheers,
Peter
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] [PATCH] xsetwacom.c: Fix a typo preventing Rotate ccw from working
On Wed, Mar 02, 2011 at 07:09:27PM +0200, Timo Aaltonen wrote: Introduced in ac821ba29a828fb9bb531243d0a226a7fe494504 Signed-off-by: Timo Aaltonen timo.aalto...@canonical.com --- tools/xsetwacom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 6713a97..fa98e3e 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -1377,7 +1377,7 @@ static void set_rotate(Display *dpy, XDevice *dev, param_t* param, int argc, cha if (strcasecmp(argv[0], cw) == 0) rotation = 1; - else if (strcasecmp(argv[0], cww) == 0) + else if (strcasecmp(argv[0], ccw) == 0) rotation = 2; else if (strcasecmp(argv[0], half) == 0) rotation = 3; -- 1.7.4.1 merged, thanks. Cheers, Peter -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL
On Wed, Mar 2, 2011 at 4:22 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at 01:41:54PM -0800, Ping Cheng wrote: On Sun, Feb 27, 2011 at 12:16 PM, Pander pan...@users.sourceforge.netwrote: Please let me know what to add to /lib/udev/rules.d/69-xserver-xorg-input-wacom.rules for this Wacom Bamboo Fun (pen and touch) This could be something we care. But I am not sure where we need to include it: xf86-input-wacom, the X server driver for version 1.7 and later does not include the .rules file any more. Let's ask the list to see what they want. Do we still need the .rules for static defined devices in xorg.conf? I'm rather against them. it's much easier these days configuring devices through hotplugging (and I think the majority of ppl does just that). maintaining a huge list of udev rules seems unnecessary in this regard - those who really need them can quickly set them up based on their local configurations. Cheers, Peter Oops. Pander, just updated the wacom.rules for your model BambooPT. See the mediawiki Fixed device files with udev: http://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Fixed_device_files_with_udev But as Peter points out they are not needed any more unless you are using the xorg.conf to configure for some reason and want wacom symlinks. Favux -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [PATCH 1/2] Don't discard the first 2 USB events
It was an issue with older kernels. This driver only supports
kernels 2.6.26 and later. No need to do that any more.
There is a special case that this code may have helped though.
If tool is on the tablet while driver started, waiting for more
events before processing them would fill some otherwise filtered
events from the kernel. Even for this case, the solution should
be added inside wcmUSB.c, instead of here.
We'll work on that in wcmUSB.c later. Just for the record. The
perfect solution would be to retrieve all events from the kernel
if important events, such as tool type, serial number, etc, are
missing. This would require quite some changes in wcmUSB.c. And,
the challenge is that linux-input doesn't provide the means for
us to retrieve all of the events that posted from the kernel. At
least, we can not retrieve serial number and MT events yet.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmCommon.c | 11 ---
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 09435d4..911e9a9 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -870,17 +870,6 @@ void wcmEvent(WacomCommonPtr common, unsigned int channel,
}
}
- /* Discard the first 2 USB packages due to events delay */
- if ( (pChannel-nSamples 2) IsUSBDevice(common)
- ds.device_type != PAD_ID (ds.device_type != TOUCH_ID) )
- {
- DBG(11, common,
- discarded %dth USB data.\n,
- pChannel-nSamples);
- ++pChannel-nSamples;
- return; /* discard */
- }
-
if (TabletHasFeature(common, WCM_ROTATION)
TabletHasFeature(common, WCM_RING)) /* I4 */
{
--
1.7.4
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [PATCH 2/2] Set ISDV4 to PROTOCOL_GENERIC in isdv4ProbeKeys
isdv4ProbeKeys is the place we set all tool types and other keys.
Reset the ProtocolLevel to PROTOCOL_GENERIC here as well.
Otherwise, it would be overwrote by the default.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmISDV4.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c
index cc77a11..bfa0d0f 100644
--- a/src/wcmISDV4.c
+++ b/src/wcmISDV4.c
@@ -315,8 +315,6 @@ static int isdv4Query(InputInfoPtr pInfo, const char*
query, char* data)
static void isdv4InitISDV4(WacomCommonPtr common, const char* id, float
version)
{
- /* Change to generic protocol to match USB MT format */
- common-wcmProtocolLevel = WCM_PROTOCOL_GENERIC;
/* length of a packet */
common-wcmPktLength = ISDV4_PKGLEN_TPCPEN;
@@ -952,6 +950,9 @@ static int isdv4ProbeKeys(InputInfoPtr pInfo)
if (model-set_bits)
tablet_id = model-set_bits(id, common-wcmKeys);
+ /* Change to generic protocol to match USB MT format */
+ common-wcmProtocolLevel = WCM_PROTOCOL_GENERIC;
+
return tablet_id;
}
--
1.7.4
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL
On Wed, Mar 02, 2011 at 05:07:37PM -0600, Favux ... wrote: On Wed, Mar 2, 2011 at 4:22 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 01, 2011 at 01:41:54PM -0800, Ping Cheng wrote: On Sun, Feb 27, 2011 at 12:16 PM, Pander pan...@users.sourceforge.netwrote: Please let me know what to add to /lib/udev/rules.d/69-xserver-xorg-input-wacom.rules for this Wacom Bamboo Fun (pen and touch) This could be something we care. But I am not sure where we need to include it: xf86-input-wacom, the X server driver for version 1.7 and later does not include the .rules file any more. Let's ask the list to see what they want. Do we still need the .rules for static defined devices in xorg.conf? I'm rather against them. it's much easier these days configuring devices through hotplugging (and I think the majority of ppl does just that). maintaining a huge list of udev rules seems unnecessary in this regard - those who really need them can quickly set them up based on their local configurations. Cheers, Peter Oops. Pander, just updated the wacom.rules for your model BambooPT. See the mediawiki Fixed device files with udev: http://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Fixed_device_files_with_udev But as Peter points out they are not needed any more unless you are using the xorg.conf to configure for some reason and want wacom symlinks. hehe, more clarification on that: having them on the wiki is a good thing. that's what the wiki is for, finding documentation for special setups. I don't think we need to maintain and ship them as part of the driver thoguh. having said that, i think that the scripts we have on this page should explain a bit better _what_ they are actually doing instead of just providing the full list (I added a fixme to the page for now). And of course there's the argument that one or two examples should be enough and we don't need to worry about updating the list for every single ID as it comes out but rather teach the users how to add it to their setup if they need it. Cheers, Peter -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Heading towards regular releases
On Wed, Mar 02, 2011 at 11:44:09AM -0800, Ping Cheng wrote: On Tue, Mar 1, 2011 at 5:55 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Following up on this, I just bumped the version in git to 0.10.99. New release versioning scheme until we settle on a stable 1.0: - 0.x.99 is the version number in-between releases - 0.x.99.901 is the first RC - 0.x.99.902 is the second RC - 0.x+1.0 is next the release Any version bump other than to .99 is coupled with a tag and a tarball so users and distros can get the newest goodness easily. Note that this is the same versioning scheme we use in X.Org, so I'm less likely to get it confused ;) I'm planning for 901 on April 1st (yes, it'll be a hoot!) and then the release soon after that, depending on the issues we see with the RCs. Either way, we'll have a 0.11 release early-April. That's about as precise as I can plan at this point :) For the time between 0.10.99.901 and 0.11 I won't merge any intrusive patches, only stuff that fixes actual issues. Any comments or extra requests? Thank you for sharing the plan ahead of the release. I am fine with the plan as long as we have a plan. I have a question about the definition of stuff that fixes actual issues. There's a blurry line as usual, but in general patches that are acceptable are: - documentation updates - typo fixes and other fixes that don't change functionality - patches that fix regressions - patches that fix crashes and build errors Not acceptable: - adding new features - intrusive patches fixing old bugs - UI changes You know I am still holding the workaround I made for fixing the hotplugging device enable/disable issue. Before we get a barrier from X server that tells us we are getting the last configured input device (are you plan to do that?), we can only work on one device at a time. The X server doesn't really know about it either, at least not in the case of hotplugging. For xorg.conf devices, that information is available (and I think currently even accessible to the driver, though more by accident than intention). Not sure what we can do in the server here, I'll have a look though. I know if hotplugging is provided through udev, all tools could be added insider xf86-input-wacom, if all tools are configured with the same options. What about hotplugging based on HAL? Do we care about that case? HAL-based hotplugging is identical to udev-based hotplugging. the only exception is a HAL-trick we used in linuxwacom to let HAL fake up the devices. we're not using that anymore though, at least not in xf86-input-wacom. for our purposes, HAL and udev are the same (with the exception of a few strcmps) So, basically, I need to know if you would consider that patch as fixing actual issues or not. It is not a perfect solution. But, there is not way to make it perfect without getting help from outside of the driver. It does narrow the race condition. the problem with that patch was IIRC that it was based on some mistaken assumptions. e.g. the refcounting was working completely different to what you tried to do. so it was more a problem with the patch itself than anything related to the release problem. Cheers, Peter -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Heading towards regular releases
On Wed, Mar 2, 2011 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the problem with that patch was IIRC that it was based on some mistaken assumptions. e.g. the refcounting was working completely different to what you tried to do. so it was more a problem with the patch itself than anything related to the release problem. No, it was not a question immediately related to the release. I was wondering if the patch meets the acceptable criterion or not. If yes, I would make a patch so it could get in the next release. So, I will make a patch only considering the dynamically allocated devices insider the driver. At least that is the case we can handle properly, right? Ping -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] [PATCH 1/2] Don't discard the first 2 USB events
On Wed, Mar 2, 2011 at 5:16 PM, Ping Cheng pingli...@gmail.com wrote:
It was an issue with older kernels. This driver only supports
kernels 2.6.26 and later. No need to do that any more.
There is a special case that this code may have helped though.
If tool is on the tablet while driver started, waiting for more
events before processing them would fill some otherwise filtered
events from the kernel. Even for this case, the solution should
be added inside wcmUSB.c, instead of here.
We'll work on that in wcmUSB.c later. Just for the record. The
perfect solution would be to retrieve all events from the kernel
if important events, such as tool type, serial number, etc, are
missing. This would require quite some changes in wcmUSB.c. And,
the challenge is that linux-input doesn't provide the means for
us to retrieve all of the events that posted from the kernel. At
least, we can not retrieve serial number and MT events yet.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmCommon.c | 11 ---
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 09435d4..911e9a9 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -870,17 +870,6 @@ void wcmEvent(WacomCommonPtr common, unsigned int
channel,
}
}
- /* Discard the first 2 USB packages due to events delay */
- if ( (pChannel-nSamples 2) IsUSBDevice(common)
- ds.device_type != PAD_ID (ds.device_type != TOUCH_ID) )
- {
- DBG(11, common,
- discarded %dth USB data.\n,
- pChannel-nSamples);
- ++pChannel-nSamples;
- return; /* discard */
- }
-
if (TabletHasFeature(common, WCM_ROTATION)
TabletHasFeature(common, WCM_RING)) /* I4 */
{
I am all for removing this code. I didn't like it for reasons you
stated (should be in wcmUSB.c based on if() statement).
I recall running across multiple issues though that this statement
seemed to help. I can't recall now what issue was so obviously I
should have added a comment when I noticed it.
I think one issue was what you mention. kernel filtering+memset() in
xf86-input-wacom resulted in high chance of X or Y being zero and so
return as work around. We are no longer memset()'ing for generic and
protocol 4 so issue is limited to protocol 5 devices.
Whats a little strange is above if() ignored TOUCH case but it has
exact same issue (but also now resolved).
I think the other issue I saw was probably just an observation I
had. If we can fix the memset() issue then its a good idea to add
first 3 packets to filter window and return instead of just returning.
This would be similar to what xf86-input-synatpics does so that we
never use an un-averaged value from HW. Today, the first 3 are
un-averaged and so have sample errors.
So at least I agree with your plan of action since it keeps moving us forward.
Reviewed-by: Chris Bagwell ch...@cnpbagwell.com
Chris
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Heading towards regular releases
On Wed, Mar 2, 2011 at 5:31 PM, Ping Cheng pingli...@gmail.com wrote: On Wed, Mar 2, 2011 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the problem with that patch was IIRC that it was based on some mistaken assumptions. e.g. the refcounting was working completely different to what you tried to do. so it was more a problem with the patch itself than anything related to the release problem. No, it was not a question immediately related to the release. I was wondering if the patch meets the acceptable criterion or not. If yes, I would make a patch so it could get in the next release. So, I will make a patch only considering the dynamically allocated devices insider the driver. At least that is the case we can handle properly, right? One more question before I leave you alone ;) How do we allow different configuration options for hotplugged tools? I am a bit lost track on that feature. Ping -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] [PATCH 2/2] Set ISDV4 to PROTOCOL_GENERIC in isdv4ProbeKeys
Setting it in probeKeys() is consistent with wcmUSB... Can't think of
any issues offhand.
Acked-by: Chris Bagwell ch...@cnpbagwell.com
Chris
On Wed, Mar 2, 2011 at 5:16 PM, Ping Cheng pingli...@gmail.com wrote:
isdv4ProbeKeys is the place we set all tool types and other keys.
Reset the ProtocolLevel to PROTOCOL_GENERIC here as well.
Otherwise, it would be overwrote by the default.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmISDV4.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c
index cc77a11..bfa0d0f 100644
--- a/src/wcmISDV4.c
+++ b/src/wcmISDV4.c
@@ -315,8 +315,6 @@ static int isdv4Query(InputInfoPtr pInfo, const char*
query, char* data)
static void isdv4InitISDV4(WacomCommonPtr common, const char* id, float
version)
{
- /* Change to generic protocol to match USB MT format */
- common-wcmProtocolLevel = WCM_PROTOCOL_GENERIC;
/* length of a packet */
common-wcmPktLength = ISDV4_PKGLEN_TPCPEN;
@@ -952,6 +950,9 @@ static int isdv4ProbeKeys(InputInfoPtr pInfo)
if (model-set_bits)
tablet_id = model-set_bits(id, common-wcmKeys);
+ /* Change to generic protocol to match USB MT format */
+ common-wcmProtocolLevel = WCM_PROTOCOL_GENERIC;
+
return tablet_id;
}
--
1.7.4
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Heading towards regular releases
On Wed, Mar 02, 2011 at 05:58:37PM -0800, Ping Cheng wrote: On Wed, Mar 2, 2011 at 5:31 PM, Ping Cheng pingli...@gmail.com wrote: On Wed, Mar 2, 2011 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the problem with that patch was IIRC that it was based on some mistaken assumptions. e.g. the refcounting was working completely different to what you tried to do. so it was more a problem with the patch itself than anything related to the release problem. No, it was not a question immediately related to the release. I was wondering if the patch meets the acceptable criterion or not. If yes, I would make a patch so it could get in the next release. So, I will make a patch only considering the dynamically allocated devices insider the driver. At least that is the case we can handle properly, right? One more question before I leave you alone ;) How do we allow different configuration options for hotplugged tools? I am a bit lost track on that feature. that's fixed in input ABI 12 (server 1.10). can't easily do it for any other servers. Cheers, Peter -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] Making sense of suppress
On Thu, Mar 03, 2011 at 01:35:20PM +1000, Peter Hutterer wrote: I'm trying to make sense of the suppress handling in the code and it's confusing me. In wcmEvent() we call wcmCheckSuppress() which compares old and new state against the suppress value and then returns: 0 if the event is to be discarded 1 if there was some state change 2 if there was only motion state change above the suppress limit but nothing else changed In the case of 0, we just return from wcmEvent. Otherwise, we pass this into commonDispatchDevice(): - if suppress is 1, we reset x/y to oldx/oldy and continue processing (but obviously skipping motion). - if suppress is 2, we ignore the data and don't send an event which suggests that for high values of suppress, we either won't get any relative motion events or we simply won't get any events. The commit history isn't really telling and doesn't give a reason why this is there. so, what again are we actually trying to do? nevermind, of course 30 sec after sending this it suddenly made sense. the code in commonDispatchDevice is in if (delta 1) condition and thus if we have movement of less than one device coordinate and no other data, we can just exit early and ignore the rest of the event processing. Cheers, Peter -- Free Software Download: Index, Search Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] [PATCH 1/2] Don't discard the first 2 USB events
On Wed, Mar 02, 2011 at 03:16:15PM -0800, Ping Cheng wrote:
It was an issue with older kernels. This driver only supports
kernels 2.6.26 and later. No need to do that any more.
There is a special case that this code may have helped though.
If tool is on the tablet while driver started, waiting for more
events before processing them would fill some otherwise filtered
events from the kernel. Even for this case, the solution should
be added inside wcmUSB.c, instead of here.
We'll work on that in wcmUSB.c later. Just for the record. The
perfect solution would be to retrieve all events from the kernel
if important events, such as tool type, serial number, etc, are
missing. This would require quite some changes in wcmUSB.c. And,
the challenge is that linux-input doesn't provide the means for
us to retrieve all of the events that posted from the kernel. At
least, we can not retrieve serial number and MT events yet.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmCommon.c | 11 ---
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 09435d4..911e9a9 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -870,17 +870,6 @@ void wcmEvent(WacomCommonPtr common, unsigned int
channel,
}
}
- /* Discard the first 2 USB packages due to events delay */
- if ( (pChannel-nSamples 2) IsUSBDevice(common)
- ds.device_type != PAD_ID (ds.device_type != TOUCH_ID) )
- {
- DBG(11, common,
- discarded %dth USB data.\n,
- pChannel-nSamples);
- ++pChannel-nSamples;
- return; /* discard */
- }
-
if (TabletHasFeature(common, WCM_ROTATION)
TabletHasFeature(common, WCM_RING)) /* I4 */
{
--
1.7.4
merged, thanks.
Cheers,
Peter
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [PATCH 4/4] Add a fixme about tool handling.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/wcmConfig.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/wcmConfig.c b/src/wcmConfig.c
index 7863167..bd37659 100644
--- a/src/wcmConfig.c
+++ b/src/wcmConfig.c
@@ -340,6 +340,11 @@ static Bool wcmMatchDevice(InputInfoPtr pLocal,
WacomCommonPtr *common_return)
{
DBG(2, priv, port share between %s and %s\n,
pLocal-name, pMatch-name);
+ /* FIXME: we loose the common-wcmTool here but it
+* gets re-added during wcmParseOptions. This is
+* currently required by the code, adding the tool
+* again here means we trigger the duplicate tool
+* detection */
wcmFreeCommon(priv-common);
priv-common = wcmRefCommon(privMatch-common);
priv-next = priv-common-wcmDevices;
--
1.7.4
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
[Linuxwacom-devel] [PATCH 3/4] Keep an enabled flag in the tool to avoid racy startup.
There is a small time window where a device may try to send an event even
though it is not fully setup to send events yet, causing a server crash.
This window opens when the tool is added to the list of devices in
wcmParseOptions() and closes with the server calling xf86ActivateDevice().
If an event for a dependent device is processed during that time, the tool
will be available but the device pointer is still invalid.
Crash can be reproduced by putting a breakpoint after wcmParseOptions() for
the eraser, then generating events with the eraser. These will cause the
tool to dereference tool-device-dev, which is uninitialized.
Work around this with a simple enabled flag that is set whenever the tool
is actually enabled.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/wcmCommon.c |9 -
src/xf86Wacom.c | 19 +++
src/xf86WacomDefs.h |1 +
3 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 591a20e..2491e4b 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -1163,17 +1163,16 @@ static void commonDispatchDevice(WacomCommonPtr common,
unsigned int channel,
return;
}
- pInfo = tool-device;
- DBG(11, common, tool id=%d for %s\n, ds-device_type, pInfo-name);
-
/* Tool on the tablet when driver starts. This sometime causes
* access errors to the device */
- if (!pInfo || !pInfo-dev || !pInfo-dev-enabled)
- {
+ if (!tool-enabled) {
xf86Msg(X_ERROR, wcmEvent: tool not initialized yet. Skipping
event. \n);
return;
}
+ pInfo = tool-device;
+ DBG(11, common, tool id=%d for %s\n, ds-device_type, pInfo-name);
+
filtered = pChannel-valid.state;
/* Device transformations come first */
diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c
index 0962e1d..43d64a4 100644
--- a/src/xf86Wacom.c
+++ b/src/xf86Wacom.c
@@ -755,6 +755,23 @@ static void wcmDevClose(InputInfoPtr pInfo)
}
}
+static void wcmEnableDisableTool(DeviceIntPtr dev, Bool enable)
+{
+ InputInfoPtrpInfo = dev-public.devicePrivate;
+ WacomDevicePtr priv= pInfo-private;
+ WacomToolPtrtool= priv-tool;
+
+ tool-enabled = enable;
+}
+
+static void wcmEnableTool(DeviceIntPtr dev)
+{
+ wcmEnableDisableTool(dev, TRUE);
+}
+static void wcmDisableTool(DeviceIntPtr dev)
+{
+ wcmEnableDisableTool(dev, FALSE);
+}
/*
* wcmDevProc --
* Handle the initialization, etc. of a wacom tablet. Called by the server
@@ -791,12 +808,14 @@ static int wcmDevProc(DeviceIntPtr pWcm, int what)
case DEVICE_ON:
if (!wcmDevOpen(pWcm))
goto out;
+ wcmEnableTool(pWcm);
xf86AddEnabledDevice(pInfo);
pWcm-public.on = TRUE;
break;
case DEVICE_OFF:
case DEVICE_CLOSE:
+ wcmDisableTool(pWcm);
if (pInfo-fd = 0)
{
xf86RemoveEnabledDevice(pInfo);
diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h
index db83ddb..2a6e4ff 100644
--- a/src/xf86WacomDefs.h
+++ b/src/xf86WacomDefs.h
@@ -492,6 +492,7 @@ struct _WacomTool
int typeid; /* Tool type */
int serial; /* Serial id, 0 == no serial id */
+ Bool enabled;
InputInfoPtr device; /* The InputDevice connected to this tool */
};
--
1.7.4
--
Free Software Download: Index, Search Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
