Re: Build LyX with MSVC 2017

2018-10-22 Thread Kornel Benko
Am Dienstag, 23. Oktober 2018 08:11:25 CEST schrieb Daniel :
> On 23/10/2018 07:03, Daniel wrote:
> > On 2018-10-22 19:11, Kornel Benko wrote:
> >> Am Montag, 22. Oktober 2018 17:22:37 CEST schrieb Daniel 
> >> :
> >>> On 22/10/2018 17:19, Daniel wrote:
>  On 22/10/2018 16:39, Daniel wrote:
> 
> [...]
> 
>  I that the build process can be set so that those .gmo files are not
>  compiled each time. But I don't remember how. Can someone enlighten me?
> >>>
> >>> Should be "I remember that ...". Sorry for my lousy writing...
> >>>
> >>
> >> You are using cmake I suppose. The gmo-files are remade if the sources 
> >> change
> >> AND
> >> if you have all the needed executables (xgettext ... )
> >> AND
> >> you started the cmake configuration with '-DLYX_NLS=ON'.
> > 
> > Thanks, I'll try the cmake flag then.
> 
> I am using CMake GUI. I disabled LYX_NLS. But still all the gmo files 
> are generated. Is there anything else I need to disable?
> 

You are probably using -DLYX_INSTALL=ON, this implies also LYX_NLS=ON

Kornel



signature.asc
Description: This is a digitally signed message part.


Re: Build LyX with MSVC 2017

2018-10-22 Thread Daniel

On 23/10/2018 07:03, Daniel wrote:

On 2018-10-22 19:11, Kornel Benko wrote:
Am Montag, 22. Oktober 2018 17:22:37 CEST schrieb Daniel 
:

On 22/10/2018 17:19, Daniel wrote:

On 22/10/2018 16:39, Daniel wrote:


[...]


I that the build process can be set so that those .gmo files are not
compiled each time. But I don't remember how. Can someone enlighten me?


Should be "I remember that ...". Sorry for my lousy writing...



You are using cmake I suppose. The gmo-files are remade if the sources 
change

AND
if you have all the needed executables (xgettext ... )
AND
you started the cmake configuration with '-DLYX_NLS=ON'.


Thanks, I'll try the cmake flag then.


I am using CMake GUI. I disabled LYX_NLS. But still all the gmo files 
are generated. Is there anything else I need to disable?





Re: Build LyX with MSVC 2017

2018-10-22 Thread Daniel

On 2018-10-22 19:11, Kornel Benko wrote:

Am Montag, 22. Oktober 2018 17:22:37 CEST schrieb Daniel :

On 22/10/2018 17:19, Daniel wrote:

On 22/10/2018 16:39, Daniel wrote:

On 22/10/2018 16:15, Daniel wrote:

On 22/10/2018 14:17, Jean-Marc Lasgouttes wrote:

Le 22/10/2018 à 13:43, Daniel a écrit :

Hi,

I did not manage to download MS Visual Studio Community 2015 from
the official website - it only gives me 2017. [1]



ErrorC2065'cmatch': undeclared identifierLyX
(applications\LyX\LyX)
C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp 1352


What branch/commit did you try to compile. The code using cmatch is
gone in current master.


Thanks, it work now.


Didn't want to write this in my last mail. But indeed it does work now.


I that the build process can be set so that those .gmo files are not
compiled each time. But I don't remember how. Can someone enlighten me?


Should be "I remember that ...". Sorry for my lousy writing...



You are using cmake I suppose. The gmo-files are remade if the sources change
AND
if you have all the needed executables (xgettext ... )
AND
you started the cmake configuration with '-DLYX_NLS=ON'.


Thanks, I'll try the cmake flag then.

Daniel



Re: Confusing layout list filter

2018-10-22 Thread Scott Kostyshak
On Fri, Oct 19, 2018 at 12:36:51PM -0400, Scott Kostyshak wrote:

> > I'm happy with whatever we settle upon. But Daniel had suggested that
> > the underline is hard to see, and I agreed with him. I can barely see it
> > at all. The bold at least makes it obvious what's happening, and it's
> > helpful, so long as we're matching substrings and not just at the
> > beginning.
> 
> That makes sense. To be clear, I wasn't proposing to stay with only
> underlining. I was proposing adding underlining in addition to bold.

Pushed at 73b1c658 since I didn't see any disagreement.

Scott


signature.asc
Description: PGP signature


Re: [LyX/master] Allow multiple calls to processUpdateFlags before redraw

2018-10-22 Thread Scott Kostyshak
On Mon, Oct 22, 2018 at 03:45:03PM +0200, Jean-Marc Lasgouttes wrote:

> This should be fixed in master at 9e7832915f9. Unfortunately, it turns out
> that it was premature to remove one of the updateMacros calls in 8d8988de.

Tested and works well. Thanks for the quick fix.

Scott


signature.asc
Description: PGP signature


Re: Build LyX with MSVC 2017

2018-10-22 Thread Kornel Benko
Am Montag, 22. Oktober 2018 17:22:37 CEST schrieb Daniel :
> On 22/10/2018 17:19, Daniel wrote:
> > On 22/10/2018 16:39, Daniel wrote:
> >> On 22/10/2018 16:15, Daniel wrote:
> >>> On 22/10/2018 14:17, Jean-Marc Lasgouttes wrote:
>  Le 22/10/2018 à 13:43, Daniel a écrit :
> > Hi,
> >
> > I did not manage to download MS Visual Studio Community 2015 from 
> > the official website - it only gives me 2017. [1]
>  
> > ErrorC2065'cmatch': undeclared identifierLyX 
> > (applications\LyX\LyX) 
> > C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp 1352
> 
>  What branch/commit did you try to compile. The code using cmatch is 
>  gone in current master.
> >>>
> >>> Thanks, it work now.
> >>
> >> Didn't want to write this in my last mail. But indeed it does work now.
> > 
> > I that the build process can be set so that those .gmo files are not 
> > compiled each time. But I don't remember how. Can someone enlighten me?
> 
> Should be "I remember that ...". Sorry for my lousy writing...
> 

You are using cmake I suppose. The gmo-files are remade if the sources change
AND
if you have all the needed executables (xgettext ... )
AND
you started the cmake configuration with '-DLYX_NLS=ON'.

Kornel


signature.asc
Description: This is a digitally signed message part.


Re: Build LyX with MSVC 2017

2018-10-22 Thread Daniel

On 22/10/2018 17:19, Daniel wrote:

On 22/10/2018 16:39, Daniel wrote:

On 22/10/2018 16:15, Daniel wrote:

On 22/10/2018 14:17, Jean-Marc Lasgouttes wrote:

Le 22/10/2018 à 13:43, Daniel a écrit :

Hi,

I did not manage to download MS Visual Studio Community 2015 from 
the official website - it only gives me 2017. [1]


Error    C2065    'cmatch': undeclared identifier    LyX 
(applications\LyX\LyX) 
C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp 1352


What branch/commit did you try to compile. The code using cmatch is 
gone in current master.


Thanks, it work now.


Didn't want to write this in my last mail. But indeed it does work now.


I that the build process can be set so that those .gmo files are not 
compiled each time. But I don't remember how. Can someone enlighten me?


Should be "I remember that ...". Sorry for my lousy writing...




Re: Build LyX with MSVC 2017

2018-10-22 Thread Daniel

On 22/10/2018 16:39, Daniel wrote:

On 22/10/2018 16:15, Daniel wrote:

On 22/10/2018 14:17, Jean-Marc Lasgouttes wrote:

Le 22/10/2018 à 13:43, Daniel a écrit :

Hi,

I did not manage to download MS Visual Studio Community 2015 from 
the official website - it only gives me 2017. [1]


Error    C2065    'cmatch': undeclared identifier    LyX 
(applications\LyX\LyX) C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp 
1352


What branch/commit did you try to compile. The code using cmatch is 
gone in current master.


Thanks, it work now.


Didn't want to write this in my last mail. But indeed it does work now.


I that the build process can be set so that those .gmo files are not 
compiled each time. But I don't remember how. Can someone enlighten me?


Daniel




Re: Build LyX with MSVC 2017

2018-10-22 Thread Richard Kimberly Heck
On 10/22/18 10:39 AM, Daniel wrote:
> On 22/10/2018 16:15, Daniel wrote:
>> On 22/10/2018 14:17, Jean-Marc Lasgouttes wrote:
>>> Le 22/10/2018 à 13:43, Daniel a écrit :
 Hi,

 I did not manage to download MS Visual Studio Community 2015 from
 the official website - it only gives me 2017. [1]
>>> 
 Error    C2065    'cmatch': undeclared identifier    LyX
 (applications\LyX\LyX)
 C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp 1352
>>>
>>> What branch/commit did you try to compile. The code using cmatch is
>>> gone in current master.
>>
>> Thanks, it work now.
>
> Didn't want to write this in my last mail. But indeed it does work now.


It'd be worth my also knowing how to do this. Did you just follow the
instructions in some README file? Or did you do something else?

Riki




Re: [LyX/master] Allow multiple calls to processUpdateFlags before redraw

2018-10-22 Thread Richard Kimberly Heck
On 10/22/18 9:45 AM, Jean-Marc Lasgouttes wrote:
> Le 20/10/2018 à 06:46, Scott Kostyshak a écrit :
>> On Tue, Oct 24, 2017 at 10:26:08PM +0200, Jean-Marc Lasgouttes wrote:
>>> commit 8d8988de475bf2055f253823e53fd5627be5de78
>>> Author: Jean-Marc Lasgouttes 
>>> Date:   Wed Oct 11 18:00:48 2017 +0200
>>>
>>>  Allow multiple calls to processUpdateFlags before redraw
>>
>> With this commit I get an assertion with the following recipe:
>>
>> 1. Download both of the attached .lyx files and put in the same folder.
>> 2. Open master.lyx.
>> 3. Put the cursor at the beginning of the buffer.
>> 4. Insert "a".
>> 5. Compile to PDF (e.g., click the eyes icon).
>
> This should be fixed in master at 9e7832915f9. Unfortunately, it turns
> out that it was premature to remove one of the updateMacros calls in
> 8d8988de.
>
> Riki, If this fixes what Scott sees (it does for me), then it needs to
> go to 2.3.2 too.


OK.

Riki




Re: Build LyX with MSVC 2017

2018-10-22 Thread Daniel

On 22/10/2018 16:15, Daniel wrote:

On 22/10/2018 14:17, Jean-Marc Lasgouttes wrote:

Le 22/10/2018 à 13:43, Daniel a écrit :

Hi,

I did not manage to download MS Visual Studio Community 2015 from the 
official website - it only gives me 2017. [1]


Error    C2065    'cmatch': undeclared identifier    LyX 
(applications\LyX\LyX) C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp 
1352


What branch/commit did you try to compile. The code using cmatch is 
gone in current master.


Thanks, it work now.


Didn't want to write this in my last mail. But indeed it does work now.

Daniel



Re: Build LyX with MSVC 2017

2018-10-22 Thread Daniel

On 22/10/2018 14:17, Jean-Marc Lasgouttes wrote:

Le 22/10/2018 à 13:43, Daniel a écrit :

Hi,

I did not manage to download MS Visual Studio Community 2015 from the 
official website - it only gives me 2017. [1]


Error    C2065    'cmatch': undeclared identifier    LyX 
(applications\LyX\LyX) C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp 1352


What branch/commit did you try to compile. The code using cmatch is gone 
in current master.


Thanks, it work now.

First, I just did

git clone git://git.lyx.org/lyx

So, I guess I was building current master. Now, I did another pull and 
it gave me another error (something with "regex"... I haven't saved it). 
Next try:


git checkout 2.3.x

I'll report back whether it works.

Daniel



Re: [LyX/master] Allow multiple calls to processUpdateFlags before redraw

2018-10-22 Thread Jean-Marc Lasgouttes

Le 20/10/2018 à 06:46, Scott Kostyshak a écrit :

On Tue, Oct 24, 2017 at 10:26:08PM +0200, Jean-Marc Lasgouttes wrote:

commit 8d8988de475bf2055f253823e53fd5627be5de78
Author: Jean-Marc Lasgouttes 
Date:   Wed Oct 11 18:00:48 2017 +0200

 Allow multiple calls to processUpdateFlags before redraw


With this commit I get an assertion with the following recipe:

1. Download both of the attached .lyx files and put in the same folder.
2. Open master.lyx.
3. Put the cursor at the beginning of the buffer.
4. Insert "a".
5. Compile to PDF (e.g., click the eyes icon).


This should be fixed in master at 9e7832915f9. Unfortunately, it turns 
out that it was premature to remove one of the updateMacros calls in 
8d8988de.


Riki, If this fixes what Scott sees (it does for me), then it needs to 
go to 2.3.2 too.



JMarc


Re: Build LyX with MSVC 2017

2018-10-22 Thread Jean-Marc Lasgouttes

Le 22/10/2018 à 13:43, Daniel a écrit :

Hi,

I did not manage to download MS Visual Studio Community 2015 from the 
official website - it only gives me 2017. [1]

...
Error    C2065    'cmatch': undeclared identifier    LyX 
(applications\LyX\LyX) C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp
1352


What branch/commit did you try to compile. The code using cmatch is gone 
in current master.


JMarc


Build LyX with MSVC 2017

2018-10-22 Thread Daniel

Hi,

I did not manage to download MS Visual Studio Community 2015 from the 
official website - it only gives me 2017. [1]


Is it possible to build LyX to built LyX with MSVC 2017? I tried it but 
get errors (below for MSVC).


Daniel

[1] I tried also from 
https://visualstudio.microsoft.com/vs/older-downloads/ but it gives me only:


"Sorry, we couldn't find any downloads for you.
To continue, please join Visual Studio Dev Essentials or purchase a 
Visual Studio Subscription."


== MSVC =

SeverityCodeDescription Project FileLineSuppression 
State
Error	C2065	'cmatch': undeclared identifier	LyX (applications\LyX\LyX) 
C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp	1352	
Error	C2146	syntax error: missing ';' before identifier 'cm'	LyX 
(applications\LyX\LyX)	C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp	1352	
Error	C2065	'cm': undeclared identifier	LyX (applications\LyX\LyX) 
C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp	1352	
Error	C2065	'cm': undeclared identifier	LyX (applications\LyX\LyX) 
C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp	1354	
Error	C2065	'cm': undeclared identifier	LyX (applications\LyX\LyX) 
C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp	1355	
Error	C2065	'cm': undeclared identifier	LyX (applications\LyX\LyX) 
C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp	1357	
Error	C2065	'cm': undeclared identifier	LyX (applications\LyX\LyX) 
C:\Users\Daniel\LyXSource\lyx\src\lyxfind.cpp	1360	

Error   MSB3073 The command "setlocal
"C:\Program Files\CMake\bin\cmake.exe" -DBUILD_TYPE=Debug -P 
cmake_install.cmake

if %errorlevel% neq 0 goto :cmEnd
:cmEnd
endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone
:cmErrorLevel
exit /b %1
:cmDone
if %errorlevel% neq 0 goto :VCEnd
:VCEnd" exited with code 1.	INSTALL	C:\Program Files (x86)\Microsoft 
Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets 
138	


== CMAKE =

TOP_SRC_DIR = C:/Users/Daniel/LyXSource/lyx

Building out-of-source

CXX11_FLAG_DETECTED = "noflagneeded"
Compiler supports std_regex
Found GNUWIN32: C:/Users/Daniel/LyXSource/lyx-dep
Found Qt-Version 5.11.2
Function magic_file not found
Function magic_open not found
Function magic_load not found
Function magic_close not found
Function magic_error not found
Could NOT find Magic (missing: Magic_INCLUDE_DIR Magic_LIBRARY 
HAS_MAGIC_FUNCTIONS)

  * Hunspell:
 - include: C:/Users/Daniel/LyXSource/lyx/3rdparty/hunspell/1.6.2/src
 - library: hunspell
Could NOT find ASPELL (missing: ASPELL_LIBRARY ASPELL_INCLUDE_DIR)
ASPELL not found, building without ASPELL support
Could NOT find ENCHANT (missing: ENCHANT_LIBRARY ENCHANT_INCLUDE_DIR)
ENCHANT not found, building without Enchant support
Building with USE_HUNSPELL
Could NOT find LYX_PY_polib (missing: LYX_PY_POLIB)
You will be unable to update layouttranslations file

- PACKAGE : LyX2.4
- PACKAGE_VERSION : 2.4.0dev
- PROGRAM_SUFFIX  :
- LYX_DIR_VER : LYX_DIR_24x
- LYX_USERDIR_VER : LYX_USERDIR_24x
- LYX_ABS_TOP_SRCDIR  : C:/Users/Daniel/LyXSource/lyx
- LYX_ABS_INSTALLED_DATADIR   : LYX_INSTALLED
- LYX_ABS_INSTALLED_LOCALEDIR : LYX_INSTALLED/Resources/locale
- LYX_INSTALL_SUFFIX  : 2.4

- Warning level  : 3
- Warnings as errors : /we4101 /we4189
- Warnings disabled  : /wd4288 /wd4355 /wd4800 /wd4996 /wd4267 
/wd4180 /wd4231


HAVE_HUNSPELL_CXXABI = FALSE
Using icon defined in resource file: 
C:/Users/Daniel/LyXSource/lyx/development/cmake/lyx.rc
Using icon defined in resource file: 
C:/Users/Daniel/LyXSource/lyx/development/cmake/lyx.rc
comparepdf (= "COMPAREPDF_EXECUTABLE-NOTFOUND") not found ==> no pdf 
comparision in test AMS-import

doxygen not found, ==> no doxygen creation

Build params, switch LYX_* options by -DLYX_*=ON or OFF, LYX_* combos by 
-DLYX_*=value:


LYX_CPACK= OFF: Use the CPack management (Implies 
LYX_INSTALL option)
LYX_LOCALVERSIONING  = OFF: Add version info to created package 
name (only used if LYX_CPACK option set)
LYX_INSTALL  = ON : Build install projects/rules 
(implies a bunch of other options)

LYX_NLS  = ON : Enable Native Language Support (NLS)
LYX_REQUIRE_SPELLCHECK   = OFF: Abort if no spellchecker available
LYX_ASPELL   = OFF: Require aspell
LYX_ENCHANT  = OFF: Require Enchant
LYX_HUNSPELL = ON : Require Hunspell
LYX_RELEASE  = ON : Build release version, build debug 
when disabled

LYX_DEBUG= OFF: Enforce debug build
LYX_NO_OPTIMIZE  = OFF: Don't use any optimization/debug flags
LYX_PACKAGE_SUFFIX   = ON : Use version suffix for packaging
LYX_SUFFIX_VALUE =: Use this string as suffix
LYX_PCH  = OFF: Use pre

Re: Parentheses keys are reversed in Hebrew

2018-10-22 Thread Guy Rutenberg
Hi,


On Mon, 22 Oct 2018 at 11:21, Jean-Marc Lasgouttes 
wrote:

>
> So is the conclusion that the LyX' hebrew keymap needs fixing?
>

Probably yes (because the handling of () and [] differ). However, my guess
is that there is some code that reversed Hebrew brackets upon insertion.
After that code is fixed to be consistent we would be able to know in if
and what the fix for the hebrew keymap is needed.

Regards,
Guy


Re: Parentheses keys are reversed in Hebrew

2018-10-22 Thread Jean-Marc Lasgouttes

Le 22/10/2018 à 09:33, Guy Rutenberg a écrit :

Hi,

I've made some more experiments (this time on the git version) and it 
seems the behavior changes based on how hebrew is typed:
* If you are using the system's keyboard layout then () get reversed, 
and [] {} <> are correct.
* If you are using lyx's hebrew keymap (and system's keyboard layout as 
english) then () are correct and [],{} and <> are reversed.


In both cases, the display in lyx matches xelatex output (which is good).


So is the conclusion that the LyX' hebrew keymap needs fixing?

Also, are the parenthesis in natural order in the .lyx file? I would not 
know what the natural order is :)


Finally (this might be a question for Jürgen), is the handling of Hebrew 
still different from the handling of other RtL languages in this 
respect? It should not IMO.


JMarc


Re: Parentheses keys are reversed in Hebrew

2018-10-22 Thread Guy Rutenberg
Hi,

I've made some more experiments (this time on the git version) and it seems
the behavior changes based on how hebrew is typed:
* If you are using the system's keyboard layout then () get reversed, and
[] {} <> are correct.
* If you are using lyx's hebrew keymap (and system's keyboard layout as
english) then () are correct and [],{} and <> are reversed.

In both cases, the display in lyx matches xelatex output (which is good).

Thanks,
Guy

On Mon, 22 Oct 2018 at 09:52, Guy Rutenberg  wrote:

> Hi,
> I'm re-sending my last message as it appears I accidentally didn't send it
> to the list. I've also added the lyx-devel, as it seems to be more
> appropriate.
>
> On Fri, 19 Oct 2018 at 17:22, Guy Rutenberg 
> wrote:
>
>> On Fri, 19 Oct 2018 at 11:05, Daniel  wrote:
>>
>>>
>>> However, this is with an English, German, etc. keyboard layout. This
>>> changes if I switch to the Hebrew keyboard layout. But then the Hebrew
>>> keyboard layout seems to have parenthesis switched relative to the
>>> English:
>>>
>>
>> I'm referring to the case of using Hebrew keyboard layout.
>>
>>>
>>>
>>> https://en.wikipedia.org/wiki/Hebrew_keyboard#/media/File:Hebrew_keyboard_layout.png
>>>
>>>
>> I don't know how made that diagram, but I'm pretty sure that he didn't
>> use an actual Hebrew keyboard. I have around seven different keyboards
>> around me right now from different manufacturers, non have this weird
>> things with reversed parenthesis. Even the actual keyboard photo in the
>> Wiki article shows the parenthesis to be normal and not reversed as in the
>> diagram.
>>
>>
>>> So, if you are using a Hebrew keyboard layout, then LyX seems to behave
>>> correctly. But in that case I am wondering why other applications don't
>>> behave that way for you.
>>
>>
>> Because LyX behavior is unexpected to the normal user.
>>
>> On Fri, 19 Oct 2018 at 13:11, Jürgen Spitzmüller  wrote:
>>
>>>
>>>
>>> Please comment here:
>>> https://www.lyx.org/trac/ticket/11191
>>>
>>> We generally need to audit LyX's behavior with bracket/parens input in
>>> RTL, but we urgently need input from experienced users.
>>>
>>>
>> I've added a new comment there as well. I'll gladly help to fix this
>> issue if someone can point me in the right direction.
>>
>
>
> I've looked again at the bug and the patch linked there. It seems that the
> code handling parenthesis had been moved to somewhere else. Where does it
> resides now? I want to try and patch it so it won't reverse parenthesis in
> hebrew.
>
> Thanks,
> Guy
>