Re: [LyX/master] Fix crash when selecting text with changes
On Fri, Dec 28, 2018 at 11:05:45AM -0500, Scott Kostyshak wrote: > Done in master at c5301a64. Riki, can this go to 2.3.x? Riki gave the OK (I accidentally sent an email without CC'ing devel). Pushed to 2.3.x at 4ea6d814. Scott signature.asc Description: PGP signature
Re: AICPA Support Case Created: Case #00005668
On 12/27/18 9:44 AM, Jürgen Spitzmüller wrote: > Am Freitag, den 05.10.2018, 11:49 -0400 schrieb Richard Kimberly Heck: >> I think it may have to do with lyx-cvs, rather than lyx-devel. I just >> tested this by pushing a commit, and I got the email. (That explains >> who >> gets them and who doesn't.) >> >> I have emailed Maté to ask him to look for relevant addresses in the >> subscriber's list. > I'm still getting these. Riki, did Maté actually investigate? I never heard anything back. I guess we should try again. Riki
Re: Windows build documentation
On 12/26/18 10:56 AM, Jürgen Womser-Schütz wrote: > Hi altogether :-) > > I am a newbi and I am trying to setup the LyX-build for my Win10/VS2017 > machine using "https://wiki.lyx.org/Windows/Compilation;. > It seems to me that the referred batch-file > "http://ftp.lyx.de/Images/MSVC2015-LyX22.bat; in chapter "Compilation" > is missing. Hi, Jürgen, that's not an official LyX site, I'm afraid, but one controlled by Uwe Stohr. So you could try writing him (uwest...@lyx.org). That said, I'm not sure that batch file is actually needed. If you can open a console yourself, you might try just running the build5-2015 batch file, as directed. Riki
Re: Can't cancel suggestion context menu
On Thu, Nov 29, 2018 at 01:33:17PM +0100, Pavel Sanda wrote: > On Wed, Nov 28, 2018 at 04:01:24PM +0100, Kornel Benko wrote: > > Am Montag, 26. November 2018 17:45:41 CET schrieb Pavel Sanda > > : > > > Hi, > > > > > > have english dictionary on, write "traces", leave cursor at the end of > > > the work, > > > hit tab. Context menu with suggestions appears. When I pres Esc, the > > > context menu > > > won't disappear. Is this expected? > > > > > > Pavel > > > > > > > Sorry, cannot reproduce on master. Neither with master nor with stable. > > I probably have not understood the procedure ... > > Because the recipy was not full, other suggestions needs to be in the buffer > first, type: > > tracesi tracesu traces > > and hit tab after last "s". You should see contex menu with first two words > as suggestions > appearing and it won't disappear after Esc. Patch fixing the issue is attached; we simply did not have handler for Esc. Will commit soon unless anyone objects. Pavel diff --git a/src/frontends/qt4/GuiCompleter.cpp b/src/frontends/qt4/GuiCompleter.cpp index f2e4eda81f..767bb6bac7 100644 --- a/src/frontends/qt4/GuiCompleter.cpp +++ b/src/frontends/qt4/GuiCompleter.cpp @@ -216,6 +216,11 @@ bool GuiCompleter::eventFilter(QObject * watched, QEvent * e) tab(); ke->accept(); return true; + case Qt::Key_Escape: + hidePopup(); + hideInline(); + updateVisibility(false, false); + return true; default: break; } }
Layout/auto-nesting help
Hi, I'm working on a custom module, and I've bumped into unexpected difficulties getting autonesting to work. I've also run into a failure with Edit > Undo that baffles me. The attached MWE (give or take the "minimal" part) contains an explanation of what I'm trying to do and what is going wrong, an example that is correct in the document, and a second copy of the example minus a few key bits (to be used as a "sandbox" if you would care to try things out). The module is in the local layout section of the document settings, and requires the algorithmicx.sty LaTeX package. Thanks for any help or advice. Paul mwe.lyx Description: application/lyx
Re: lyx2lyx regression on master?
On Fri, Dec 28, 2018 at 06:41:36PM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 12:12 -0500 schrieb Scott Kostyshak: > > > I seem to remember we agreed that lyx2lyx would be too hard to do > > > for > > > the cprotect thing. And indeed it would be very hard to track all > > > cases. > > > > Makes sense for not adding ERT. But would it be easy to at least > > provide > > a warning from lyx2lyx? > > For this, you'd need to track all cases as well. Ah, then I guess indeed there is nothing to be done. Scott signature.asc Description: PGP signature
Re: lyx2lyx regression on master?
Am Freitag, den 28.12.2018, 12:12 -0500 schrieb Scott Kostyshak: > > I seem to remember we agreed that lyx2lyx would be too hard to do > > for > > the cprotect thing. And indeed it would be very hard to track all > > cases. > > Makes sense for not adding ERT. But would it be easy to at least > provide > a warning from lyx2lyx? For this, you'd need to track all cases as well. Jürgen > > Scott signature.asc Description: This is a digitally signed message part
Re: lyx2lyx regression on master?
On Fri, Dec 28, 2018 at 05:55:09PM +0100, Jürgen Spitzmüller wrote:
> Am Freitag, den 28.12.2018, 11:22 -0500 schrieb Scott Kostyshak:
> > Indeed, the first problem seems to be a missing \cprotect here:
> >
> > \footnote{ASCII means \href{
> > https://en.wikipedia.org/wiki/ASCII\#Character_set}{this set}
> >
> > I guess it is too complicated to output the \cprotect in ERT? Would
> > it
> > be easy for lyx2lyx to at least give a warning that compilation with
> > 2.3.x is not expected to succeed because of missing \cprotect?
>
> I seem to remember we agreed that lyx2lyx would be too hard to do for
> the cprotect thing. And indeed it would be very hard to track all
> cases.
Makes sense for not adding ERT. But would it be easy to at least provide
a warning from lyx2lyx?
Scott
signature.asc
Description: PGP signature
Re: lyx2lyx regression on master?
Am Freitag, den 28.12.2018, 11:22 -0500 schrieb Scott Kostyshak:
> Indeed, the first problem seems to be a missing \cprotect here:
>
> \footnote{ASCII means \href{
> https://en.wikipedia.org/wiki/ASCII\#Character_set}{this set}
>
> I guess it is too complicated to output the \cprotect in ERT? Would
> it
> be easy for lyx2lyx to at least give a warning that compilation with
> 2.3.x is not expected to succeed because of missing \cprotect?
I seem to remember we agreed that lyx2lyx would be too hard to do for
the cprotect thing. And indeed it would be very hard to track all
cases.
Jürgen
>
> Scott
signature.asc
Description: This is a digitally signed message part
Re: Strings to toggle table lines
Le 28/12/2018 à 16:16, Kornel Benko a écrit : Am Freitag, 28. Dezember 2018 15:49:27 CET schrieb Jürgen Spitzmüller : Am Freitag, den 28.12.2018, 15:41 +0100 schrieb Kornel Benko: The menu strings in stdtoolbars.inc "Set bottom/top/left/right line" do not reflect the respective function. Better seems to be for instance "Toggle bottom line" +1 Jürgen OK, done with 32b59a42 + 98abb620. We could even have "Top line", since the toggle is indicted with a menu mark. JMarc
Re: lyx2lyx regression on master?
On Fri, Dec 28, 2018 at 09:55:08AM +0100, Jürgen Spitzmüller wrote:
> Am Freitag, den 28.12.2018, 09:35 +0100 schrieb Jürgen Spitzmüller:
> > Am Freitag, den 28.12.2018, 02:46 -0500 schrieb Scott Kostyshak:
> > > Thanks, I no longer get those messages. However, there is a
> > > compilation
> > > error when compiling with pdflatex (with 2.3.x) the .lyx file that
> > > master exports to 2.3.x format:
> > >
> > > ! Illegal parameter number in definition of \Hy@tempa.
>
> Hm, this error message makes me wonder whether you really exported the
> 2.3.x version of the UG (and not master's). Because this comes up if
> invalid characters are used in URLs (things we can handle now thanks to
> \cprotect).
>
> I have used stable's version of the UG for my testing.
To reproduce, I do the following:
1. Export master's UG to a 2.3.x .lyx file. This creates
UserGuide.23.lyx.
2. Open UserGuide.23.lyx in 2.3.x.
3. Go to File > Export > PDF (pdflatex)
The diff of the .tex files is here:
https://www.dropbox.com/s/pbe4l8n71wa5oel/diff.txt?dl=0
Indeed, the first problem seems to be a missing \cprotect here:
\footnote{ASCII means
\href{https://en.wikipedia.org/wiki/ASCII\#Character_set}{this set}
I guess it is too complicated to output the \cprotect in ERT? Would it
be easy for lyx2lyx to at least give a warning that compilation with
2.3.x is not expected to succeed because of missing \cprotect?
Scott
signature.asc
Description: PGP signature
Re: [LyX/master] Fix crash when selecting text with changes
On Fri, Dec 28, 2018 at 03:48:37PM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 09:44 -0500 schrieb Scott Kostyshak: > > Tested and works well. Do we also have to test that the inset's texts > > are the same? Just thinking about what you said above, it seems > > possible > > that the pit and the cell could be the same, but be in different > > inset's > > texts? > > Don't think that can happen. You cannot select an inset only partially > and select contents outside the inset at the same time. > > I'd go with the idx() fix. Done in master at c5301a64. Riki, can this go to 2.3.x? Thanks, Scott signature.asc Description: PGP signature
Re: Strings to toggle table lines
Am Freitag, 28. Dezember 2018 15:49:27 CET schrieb Jürgen Spitzmüller : > Am Freitag, den 28.12.2018, 15:41 +0100 schrieb Kornel Benko: > > The menu strings in stdtoolbars.inc > > "Set bottom/top/left/right line" > > do not reflect the respective function. > > > > Better seems to be for instance > > "Toggle bottom line" > > +1 > > Jürgen > OK, done with 32b59a42 + 98abb620. Kornel signature.asc Description: This is a digitally signed message part.
Re: Strings to toggle table lines
Am Freitag, den 28.12.2018, 15:41 +0100 schrieb Kornel Benko: > The menu strings in stdtoolbars.inc > "Set bottom/top/left/right line" > do not reflect the respective function. > > Better seems to be for instance > "Toggle bottom line" +1 Jürgen signature.asc Description: This is a digitally signed message part
Re: [LyX/master] Fix crash when selecting text with changes
Am Freitag, den 28.12.2018, 09:44 -0500 schrieb Scott Kostyshak: > Tested and works well. Do we also have to test that the inset's texts > are the same? Just thinking about what you said above, it seems > possible > that the pit and the cell could be the same, but be in different > inset's > texts? Don't think that can happen. You cannot select an inset only partially and select contents outside the inset at the same time. I'd go with the idx() fix. Jürgen signature.asc Description: This is a digitally signed message part
Re: [LyX/master] Fix crash when selecting text with changes
On Fri, Dec 28, 2018 at 09:31:21AM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 02:29 -0500 schrieb Scott Kostyshak: > > Attached is a patch. It seems that the problem is: > > > > bool const in_last_par = (it.pit() == cur.selectionEnd().pit()); > > > > Apparently this doesn't always do what I thought it did. Replacing it > > with > > > > bool const in_last_par = (() == > > ().paragraph()); > > > > seems to avoid the assertion (because then "end" is set correctly), > > but > > I don't feel comfortable not knowing why the original in_last_par > > definition doesn't work. Is it possible that different paragraphs can > > have the same pit? > > In different cells, yes (probably also in different inset's texts). OK good to know. > > I have a fundamental misunderstanding somewhere, but not sure where. > > How about a more explicit > > bool const in_last_par = (it.pit() == cur.selectionEnd().pit() > && it.idx() == cur.selectionEnd().idx()); Tested and works well. Do we also have to test that the inset's texts are the same? Just thinking about what you said above, it seems possible that the pit and the cell could be the same, but be in different inset's texts? Thanks, Scott signature.asc Description: PGP signature
Strings to toggle table lines
The menu strings in stdtoolbars.inc "Set bottom/top/left/right line" do not reflect the respective function. Better seems to be for instance "Toggle bottom line" Kornel signature.asc Description: This is a digitally signed message part.
Re: lyx2lyx regression on master?
Am Freitag, den 28.12.2018, 09:35 +0100 schrieb Jürgen Spitzmüller: > Am Freitag, den 28.12.2018, 02:46 -0500 schrieb Scott Kostyshak: > > Thanks, I no longer get those messages. However, there is a > > compilation > > error when compiling with pdflatex (with 2.3.x) the .lyx file that > > master exports to 2.3.x format: > > > > ! Illegal parameter number in definition of \Hy@tempa. Hm, this error message makes me wonder whether you really exported the 2.3.x version of the UG (and not master's). Because this comes up if invalid characters are used in URLs (things we can handle now thanks to \cprotect). I have used stable's version of the UG for my testing. Jürgen signature.asc Description: This is a digitally signed message part
Re: lyx2lyx regression on master?
Am Freitag, den 28.12.2018, 02:46 -0500 schrieb Scott Kostyshak: > Thanks, I no longer get those messages. However, there is a > compilation > error when compiling with pdflatex (with 2.3.x) the .lyx file that > master exports to 2.3.x format: > > ! Illegal parameter number in definition of \Hy@tempa. I don't see this here. Can you make a diff of the original version's tex and the one of the file exported from master? Jürgen signature.asc Description: This is a digitally signed message part
Re: [LyX/master] Fix crash when selecting text with changes
Am Freitag, den 28.12.2018, 02:29 -0500 schrieb Scott Kostyshak: > Attached is a patch. It seems that the problem is: > > bool const in_last_par = (it.pit() == cur.selectionEnd().pit()); > > Apparently this doesn't always do what I thought it did. Replacing it > with > > bool const in_last_par = (() == > ().paragraph()); > > seems to avoid the assertion (because then "end" is set correctly), > but > I don't feel comfortable not knowing why the original in_last_par > definition doesn't work. Is it possible that different paragraphs can > have the same pit? In different cells, yes (probably also in different inset's texts). > I have a fundamental misunderstanding somewhere, but not sure where. How about a more explicit bool const in_last_par = (it.pit() == cur.selectionEnd().pit() && it.idx() == cur.selectionEnd().idx()); Jürgen > > Scott signature.asc Description: This is a digitally signed message part
