Re: QProcess::startCommand deprecation
On 5/18/21 9:49 AM, Jean-Marc Lasgouttes wrote: > Le 18/05/2021 à 15:25, Jürgen Spitzmüller a écrit : >> Am Dienstag, dem 18.05.2021 um 14:27 +0200 schrieb Jean-Marc >> Lasgouttes: >>> In this case, having a single code path is a good thing IMO. Do we >>> want >>> to keep both versions until Qt5 support is deleted? >> >> What do you mean by "both versions"? > > Before I forget: whatever the decision, this will need to be > backported to branch. Fine with me. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Dynamic insets
Am Dienstag, dem 18.05.2021 um 17:33 +0200 schrieb Jean-Pierre Chrétien: > > Probably all should use info insets. > > Is it correct to state that all the recognised strings are given in > the LFUNS > mùanual, under 'dialog-show' ? I'd say so. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: German Translation of LyX User Guide
Am Dienstag, dem 18.05.2021 um 17:43 +0200 schrieb Kornel Benko: > OK, so adding "Shift", "Ctrl", "Alt" somewhere in *.cpp should cure > it? Only if the translation differs from the input. That's the drawback currently. We don't know whether a string really has been translated, only if it differs from the input string. So for German, it will work with Ctrl (since this is "Strg" in German) and Shift ("Umschalt"), but not for Alt (since this is "Alt" in German as well). Not sure how to improve this. I found no obvious way. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: German Translation of LyX User Guide
Am Tue, 18 May 2021 17:04:26 +0200 schrieb Jürgen Spitzmüller : > Am Dienstag, dem 18.05.2021 um 16:46 +0200 schrieb Kornel Benko: > > I have problem to identify where the relevant translatable strings > > are to be found. > > (For instance I am unable to see "Umschalt+F3" in the de.po-file) > > This translation comes from Qt (via KeySequence::ForGui). Note though > that it's only the Shift key, not the whole sequence, that is > translated. > > Jürgen > OK, so adding "Shift", "Ctrl", "Alt" somewhere in *.cpp should cure it? I remember, we had some strings not covered by Qt added in source, but don't remember where. Kornel pgpu5mXiMiI3y.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Dynamic insets
Le 18/05/2021 à 07:52, Jürgen Spitzmüller a écrit : Am Montag, dem 17.05.2021 um 16:07 +0200 schrieb Jean-Pierre Chrétien: Finally, it seems that not all menu entries appear in dynamic insets. What are exactly those which are liable to do so (the list in the inset parameters is not very explicit)? And is it done everywhere where it can be in the English docs? If not, is this a target to achieve? Probably all should use info insets. Is it correct to state that all the recognised strings are given in the LFUNS mùanual, under 'dialog-show' ? As a conclusion, where is the dynamic inset feature documented? I do not remember to have translated it. User Guide A.4.4 Thanks, indeed, it needs to be translated in French. -- Jean-Pierre -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: German Translation of LyX User Guide
Am Dienstag, dem 18.05.2021 um 16:46 +0200 schrieb Kornel Benko: > I have problem to identify where the relevant translatable strings > are to be found. > (For instance I am unable to see "Umschalt+F3" in the de.po-file) This translation comes from Qt (via KeySequence::ForGui). Note though that it's only the Shift key, not the whole sequence, that is translated. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: German Translation of LyX User Guide
Am Dienstag, dem 18.05.2021 um 16:46 +0200 schrieb Kornel Benko: > What would be the difference if the string would not be marked as > 'English'? It would be in another language, and the hyphenation could be wrong. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: German Translation of LyX User Guide
Am Tue, 18 May 2021 13:59:29 +0200 schrieb Jürgen Spitzmüller : > Am Dienstag, dem 18.05.2021 um 13:51 +0200 schrieb Jürgen Spitzmüller: > > Yes, I've seen that. Only for some though. "Umschalt+F3" for instance > > is in German. > > > > There could be some rationale behind it. Need to investigate that, no > > time ATM though. > > Here's the answer (InsetInfo::info): > > docstring const res = translateIfPossible(err, lang->code()); > bool const translated = res != err; > // If the string is not translated, we use default lang (English) > Font const f = translated ? Font(inherit_font, lang) : > Font(inherit_font); I have problem to identify where the relevant translatable strings are to be found. (For instance I am unable to see "Umschalt+F3" in the de.po-file) > We could be a bit more precise here, but the decision itself makes > sense (think of different scripts). What would be the difference if the string would not be marked as 'English'? > Jürgen Kornel pgpm_88_oRk66.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: QProcess::startCommand deprecation
Le 18/05/2021 à 15:25, Jürgen Spitzmüller a écrit : Am Dienstag, dem 18.05.2021 um 14:27 +0200 schrieb Jean-Marc Lasgouttes: In this case, having a single code path is a good thing IMO. Do we want to keep both versions until Qt5 support is deleted? What do you mean by "both versions"? Before I forget: whatever the decision, this will need to be backported to branch. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: QProcess::startCommand deprecation
Am Dienstag, dem 18.05.2021 um 14:27 +0200 schrieb Jean-Marc Lasgouttes: > In this case, having a single code path is a good thing IMO. Do we > want > to keep both versions until Qt5 support is deleted? What do you mean by "both versions"? Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: QProcess::startCommand deprecation
Le 18/05/2021 à 13:52, Jürgen Spitzmüller a écrit : I think that having the correct bounds will help us in the long term. I think my rationale was to play safe and keep the deprecated function until it was marked deprecated. In this case, having a single code path is a good thing IMO. Do we want to keep both versions until Qt5 support is deleted? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: German Translation of LyX User Guide
Am Dienstag, dem 18.05.2021 um 13:51 +0200 schrieb Jürgen Spitzmüller: > Yes, I've seen that. Only for some though. "Umschalt+F3" for instance > is in German. > > There could be some rationale behind it. Need to investigate that, no > time ATM though. Here's the answer (InsetInfo::info): docstring const res = translateIfPossible(err, lang->code()); bool const translated = res != err; // If the string is not translated, we use default lang (English) Font const f = translated ? Font(inherit_font, lang) : Font(inherit_font); We could be a bit more precise here, but the decision itself makes sense (think of different scripts). Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: QProcess::startCommand deprecation
Am Dienstag, dem 18.05.2021 um 11:02 +0200 schrieb Jean-Marc Lasgouttes: > I have been looking at backporting the following commit to stble (the > last warning I see): > > commit 9f92fc92bdd41c367b0975454a01c15403d51a60 > Author: Juergen Spitzmueller > Date: Fri Mar 12 12:14:42 2021 +0100 > > Yet another deprecation fix (this is the last one I am aware of) > > > This uses QProcess::startDetached(cmd, args) instead of > QProcess::startDetached(cmd + args) for Qt >= 5.15. > > I have a question though. I see that this new form already exists in > Qt4 > https://doc.qt.io/archives/qt-4.8/qprocess.html > > So, why use the conditionning on Qt 5.15 at all? > > More generally, I am not sure that we are always conditionning on the > right version. Example: in GuiAbout, Qt:endl is used for Qt>= 5.15, > whereas it has been introduced in 5.14 according to the docs. > > I think that having the correct bounds will help us in the long term. I think my rationale was to play safe and keep the deprecated function until it was marked deprecated. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: German Translation of LyX User Guide
Am Dienstag, dem 18.05.2021 um 10:33 +0200 schrieb Kornel Benko: > Explicit search for English text shows also > > 'Letzte Einstellungen anwenden' > and > 'displaymath mathlines' (here only the space is > English) Thanks, corrected. > Interestingly the info-inserts for shortcuts are also marked English > even with non-English UI. > For instance > 'Die Verwendung von [Alt+M N]' Yes, I've seen that. Only for some though. "Umschalt+F3" for instance is in German. There could be some rationale behind it. Need to investigate that, no time ATM though. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
QProcess::startCommand deprecation
Hi, I have been looking at backporting the following commit to stble (the last warning I see): commit 9f92fc92bdd41c367b0975454a01c15403d51a60 Author: Juergen Spitzmueller Date: Fri Mar 12 12:14:42 2021 +0100 Yet another deprecation fix (this is the last one I am aware of) This uses QProcess::startDetached(cmd, args) instead of QProcess::startDetached(cmd + args) for Qt >= 5.15. I have a question though. I see that this new form already exists in Qt4 https://doc.qt.io/archives/qt-4.8/qprocess.html So, why use the conditionning on Qt 5.15 at all? More generally, I am not sure that we are always conditionning on the right version. Example: in GuiAbout, Qt:endl is used for Qt>= 5.15, whereas it has been introduced in 5.14 according to the docs. I think that having the correct bounds will help us in the long term. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: German Translation of LyX User Guide
Am Tue, 18 May 2021 08:52:03 +0200 schrieb Jürgen Spitzmüller : > Am Freitag, dem 14.05.2021 um 19:00 +0200 schrieb Christoph Schmitz: > > Attached is an updated German translation of the LyX User Guide. > > Thanks. Looks good in general. I have corrected some things and > committed: > > * Paths to images need to be relative, not absolute > * Some German text was still marked English > * Very few wording changes Explicit search for English text shows also 'Letzte Einstellungen anwenden' and 'displaymath mathlines' (here only the space is English) Interestingly the info-inserts for shortcuts are also marked English even with non-English UI. For instance 'Die Verwendung von [Alt+M N]' > > I have not yet understood how to make my update public for review. > > Can somebody tell me what to do or where I find more information. The > > LyX translation website does not answer this question. > > I think positing it here is the best way. > > Best > Jürgen > Kornel pgpHjuJ18V6zU.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel