Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 18/09/2017 à 15:15, Pavel Sanda a écrit :

Jean-Marc Lasgouttes wrote:

Le 12/09/2017 ?? 16:44, Pavel Sanda a écrit :

I tried, but... :)
Are you still able to compile on the ubuntu 12.04 oldie?
Even if I try beta tarball to avoid our autotools version requirements
it chokes on signal.h and its C++11 constructs. Are we completely
done with 12.04 or is there still some relatively painless way how
to get binary for it?


I do not have access to a 12.04 box right now, but I will try to find one.
Can you show the error message in the mean time?


   CXXFileMonitor.o
   FileMonitor.cpp: In member function 'void 
lyx::support::FileMonitor::changed(bool)':
   FileMonitor.cpp:201:21: error: no match for call to '(lyx::support::FileMonitor::sig 
{aka boost::signals2::signal}) (const bool&)'


I see. I'll try to setup a 12.04 virtual machine, but don't hold you 
breath yet.


JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Le 12/09/2017 ?? 16:44, Pavel Sanda a écrit :
>> I tried, but... :)
>> Are you still able to compile on the ubuntu 12.04 oldie?
>> Even if I try beta tarball to avoid our autotools version requirements
>> it chokes on signal.h and its C++11 constructs. Are we completely
>> done with 12.04 or is there still some relatively painless way how
>> to get binary for it?
>
> I do not have access to a 12.04 box right now, but I will try to find one. 
> Can you show the error message in the mean time?

  CXXFileMonitor.o
  FileMonitor.cpp: In member function 'void 
lyx::support::FileMonitor::changed(bool)':
  FileMonitor.cpp:201:21: error: no match for call to 
'(lyx::support::FileMonitor::sig {aka boost::signals2::signal}) (const 
bool&)'
  ../../3rdparty/boost/boost/signals2/detail/signal_template.hpp:599:11: note: 
candidates are:
  ../../3rdparty/boost/boost/signals2/detail/signal_template.hpp:721:19: note: 
boost::signals2::signal::result_type 
boost::signals2::signal, Mutex = boost::signals2::mutex, R = void, Args 
= {}, boost::signals2::signal::result_tyxtendedSlotFunction = 
boost::function, Mutex = 
boost::signals2::mutex, R = void, Args = {}, boost::signals2::signal::result_type = void]
  ../../3rdparty/boost/boost/signals2/detail/signal_template.hpp:721:19: note:  
 candidate expects 0 arguments, 1 provided
  ../../3rdparty/boost/boost/signals2/detail/signal_template.hpp:725:19: note: 
boost::signals2::signal::result_type 
boost::signals2::signal, Mutex = boost::signals2::mutex, R = void, Args 
= {}, boost::signals2::signal::result_type = void]tFunction = 
boost::function, Mutex = 
boost::signals2::mutex, R = void, Args = {}, boost::signals2::signal::result_type = void]
  ../../3rdparty/boost/boost/signals2/detail/signal_template.hpp:725:19: note:  
 candidate expects 0 arguments, 1 provided
  make[5]: *** [FileMonitor.o] Error 1

>
> JMarc

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 12/09/2017 à 16:44, Pavel Sanda a écrit :

I tried, but... :)
Are you still able to compile on the ubuntu 12.04 oldie?
Even if I try beta tarball to avoid our autotools version requirements
it chokes on signal.h and its C++11 constructs. Are we completely
done with 12.04 or is there still some relatively painless way how
to get binary for it?


I do not have access to a 12.04 box right now, but I will try to find 
one. Can you show the error message in the mean time?


JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Le 8 septembre 2017 20:02:39 GMT+02:00, Pavel Sanda  a écrit :
> >Jean-Marc Lasgouttes wrote:
> >> Feedback welcome. Everything is supposed to work at this point. The
> >only 
> >> strange point is that my tests with remote executions give poor 
> >> performance. I hoped for the opposite, but this is not a scientific 
> >> comparison.
> >
> >By remote execution you mean running through forwarded ssh tunnel?
> >Pavel
> 
> Yes. But I did not compare with 2.2 in this situation.

I tried, but... :)
Are you still able to compile on the ubuntu 12.04 oldie?
Even if I try beta tarball to avoid our autotools version requirements
it chokes on signal.h and its C++11 constructs. Are we completely
done with 12.04 or is there still some relatively painless way how
to get binary for it?

Pavel

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 11/09/2017 à 17:19, Pavel Sanda a écrit :


JMarc, I see the following problem:
Put your caret in the middle of paragraph (line-wise) and at the very end
of line, just behind the last character of the word and hit spacebar.
The space character is (invisbly) inserted, but caret does not move
as it used to.


Hi Pavel,

Actually, this is a regression in 2.2.x, described in ticket
http://www.lyx.org/trac/ticket/10117

The discussion there has slowed down, waiting for Guillaume's patch. Or 
for some great idea.


JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Pavel Sanda wrote:
> Jean-Marc Lasgouttes wrote:
> >>> Do you want me to rebase on a regular basis? Or you can ping me whenever
> >>> you want a rebase.
> >> I just need that fileformat number is equal to lyx 2.3, otherwise do as 
> >> you prefer...
> >
> > Hi Pavel, did you have time to look at this branch ?
> 
> I am actually editing my current work with it.
> Up to now no problem.

JMarc, I see the following problem:
Put your caret in the middle of paragraph (line-wise) and at the very end
of line, just behind the last character of the word and hit spacebar.
The space character is (invisbly) inserted, but caret does not move
as it used to.
Can you reproduce?

> Pavel

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 8 septembre 2017 20:02:39 GMT+02:00, Pavel Sanda  a écrit :
>Jean-Marc Lasgouttes wrote:
>> Feedback welcome. Everything is supposed to work at this point. The
>only 
>> strange point is that my tests with remote executions give poor 
>> performance. I hoped for the opposite, but this is not a scientific 
>> comparison.
>
>By remote execution you mean running through forwarded ssh tunnel?
>Pavel

Yes. But I did not compare with 2.2 in this situation.

JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Feedback welcome. Everything is supposed to work at this point. The only 
> strange point is that my tests with remote executions give poor 
> performance. I hoped for the opposite, but this is not a scientific 
> comparison.

By remote execution you mean running through forwarded ssh tunnel?
Pavel

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 08/09/2017 à 10:04, Pavel Sanda a écrit :

Jean-Marc Lasgouttes wrote:

Do you want me to rebase on a regular basis? Or you can ping me whenever
you want a rebase.

I just need that fileformat number is equal to lyx 2.3, otherwise do as
you prefer...


Hi Pavel, did you have time to look at this branch ?


I am actually editing my current work with it.
Up to now no problem.


I added a new LyXRC format (because of the removal of \use_qimage) and 
rewrote history to put all LyXRC changes in one commit (which will be 
skipped if we ever backport to 2.3.x).


I merged the branch in master. I will keep it alive to cherry-pick all 
related changes for an hypothetic backport.


Feedback welcome. Everything is supposed to work at this point. The only 
strange point is that my tests with remote executions give poor 
performance. I hoped for the opposite, but this is not a scientific 
comparison.


JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
>>> Do you want me to rebase on a regular basis? Or you can ping me whenever
>>> you want a rebase.
>> I just need that fileformat number is equal to lyx 2.3, otherwise do as 
>> you prefer...
>
> Hi Pavel, did you have time to look at this branch ?

I am actually editing my current work with it.
Up to now no problem.

Pavel

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 30/08/2017 à 16:51, Pavel Sanda a écrit :

Jean-Marc Lasgouttes wrote:


I just did that. It is good that I rebase it from time to time to avoid
bitrot, anyway.

Do you want me to rebase on a regular basis? Or you can ping me whenever
you want a rebase.


I just need that fileformat number is equal to lyx 2.3, otherwise do as you 
prefer...


Hi Pavel, did you have time to look at this branch ?

JMarc

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 30/08/2017 à 16:51, Pavel Sanda a écrit :

Jean-Marc Lasgouttes wrote:


I just did that. It is good that I rebase it from time to time to avoid
bitrot, anyway.

Do you want me to rebase on a regular basis? Or you can ping me whenever
you want a rebase.


I just need that fileformat number is equal to lyx 2.3, otherwise do as you 
prefer...


I will at least update every time the pref/layout/fileformat changes...

JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
>
> I just did that. It is good that I rebase it from time to time to avoid 
> bitrot, anyway.
>
> Do you want me to rebase on a regular basis? Or you can ping me whenever 
> you want a rebase.

I just need that fileformat number is equal to lyx 2.3, otherwise do as you 
prefer...

Pavel

Re: [LyX features/properpaint] Fix caret painting

[Kornel Benko]

Am Dienstag, 29. August 2017 um 17:11:03, schrieb Pavel Sanda 
> Jean-Marc Lasgouttes wrote:
> > Would it help you if I rebased frequently wrt master?
> 
> Yes, I would work on top of that instead of master. Pavel

+1

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 27/08/2017 à 03:15, Pavel Sanda a écrit :

Jean-Marc Lasgouttes wrote:

I am not working on it anymore unless I get bug reports. I will merge it in 
2.4.0 asap.


What about merging it into master now, I would start testing it. P


I just did that. It is good that I rebase it from time to time to avoid 
bitrot, anyway.


Do you want me to rebase on a regular basis? Or you can ping me whenever 
you want a rebase.


JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Would it help you if I rebased frequently wrt master?

Yes, I would work on top of that instead of master. Pavel

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 27/08/2017 à 03:15, Pavel Sanda a écrit :

Jean-Marc Lasgouttes wrote:

I am not working on it anymore unless I get bug reports. I will merge it in 
2.4.0 asap.


What about merging it into master now, I would start testing it. P


There are still things that I want to check (direct calls to 
redoParagraph) and, if we want one day to backport to 2.3.x, it would be 
better to have a nearly working branch to merge IMO.


Would it help you if I rebased frequently wrt master?

JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> I am not working on it anymore unless I get bug reports. I will merge it in 
> 2.4.0 asap.

What about merging it into master now, I would start testing it. P

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

I am not working on it anymore unless I get bug reports. I will merge it in 
2.4.0 asap.

JMarc

Le 1 août 2017 01:35:49 GMT+02:00, Pavel Sanda  a écrit :
>What is your strategy with features/properpaint? To continue piling up
>new patches on top of if or leave it for testing?
>
>Pavel

Re: [LyX features/properpaint] Fix caret painting

[Richard Heck]

On 07/31/2017 02:02 PM, Jean-Marc Lasgouttes wrote:
> I do not think so. Maybe after 2.3.0, it will be up to Richard, since the 
> amount of code is small.

I guess we will need to see, as usual, if there's a need for fast
release of 2.3.1. But, if not, then we can think about merging early so
it gets lots of testing.

Richard

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> I do not think so. Maybe after 2.3.0

:(

> But I suspect that there are dark corners that we have not visited yet.

What is your strategy with features/properpaint? To continue piling up new 
patches on top of if or leave it for testing?

Pavel

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

I do not think so. Maybe after 2.3.0, it will be up to Richard, since the 
amount of code is small.

Thanks for testing. I am happy that it works. But I suspect that there are dark 
corners that we have not visited yet.

JMarc

Le 31 juillet 2017 19:45:09 GMT+02:00, Pavel Sanda  a écrit :
>
>Whoaa! I tried and I am back on almost 2.0 speed!
>Any chance this branch gets into 2.3?

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Le 25/07/2017 ?? 11:37, Pavel Sanda a écrit :
>>> Preliminary testing shows that the performance of pressing cursor down
>>> repeatedly is the same, but the performance of Page Down is much better.
>> Is this supposed to change only perf of going down or it also affects just
>> going through the text (left/right arrow) without painting new lines?
>
> I don't know, try it :) The slowness you are experiencing is a bit 
> mysterious to me.

Whoaa! I tried and I am back on almost 2.0 speed!
Any chance this branch gets into 2.3?

Pavel

Re: [LyX features/properpaint] Fix caret painting

[Jean-Marc Lasgouttes]

Le 25/07/2017 à 11:37, Pavel Sanda a écrit :

Preliminary testing shows that the performance of pressing cursor down
repeatedly is the same, but the performance of Page Down is much better.


Is this supposed to change only perf of going down or it also affects just
going through the text (left/right arrow) without painting new lines?


I don't know, try it :) The slowness you are experiencing is a bit 
mysterious to me.


JMarc

Re: [LyX features/properpaint] Fix caret painting

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Le 21/07/2017 ?? 23:31, Jean-Marc Lasgouttes a écrit :
>> The branch, properpaint, has been updated.
>> - Log -
>> commit de11aeb73b97ea6fd3c76d71aa027d5d7dc90f7d
>> Author: Jean-Marc Lasgouttes 
>> Date:   Thu Jul 20 23:31:05 2017 +0200
>>  Fix caret painting
>
> With this commit, the new painting scheme (without intermediate Pixmap) 
> seems to work. This has only been tested with Qt4 and input methods are 
> broken right now.
>
> Preliminary testing shows that the performance of pressing cursor down 
> repeatedly is the same, but the performance of Page Down is much better.

Is this supposed to change only perf of going down or it also affects just
going through the text (left/right arrow) without painting new lines?

Pavel