OK button in xforms dalog

2004-04-07 Thread Andre Poenitz

Is there a possibility to invoke the OK button in dialogs like
Insert-Tabular with the Return key?

The picture -' on the button seems to indicate that somebody was
thinking of this possibility at some point of time, but it does not
work for me neither in 1.4.0cvs nor 1.3.5cvs.

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
Andre Poenitz wrote:
 Is there a possibility to invoke the OK button in dialogs like
 Insert-Tabular with the Return key?

Yes.

 The picture -' on the button seems to indicate that somebody was
 thinking of this possibility at some point of time, but it does not
 work for me neither in 1.4.0cvs nor 1.3.5cvs.

Works for me for the tabular create dialog in both lyx 13x and 14x.

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread Andre Poenitz
On Wed, Apr 07, 2004 at 02:35:30PM +0100, Angus Leeming wrote:
 Andre Poenitz wrote:
  Is there a possibility to invoke the OK button in dialogs like
  Insert-Tabular with the Return key?
 
 Yes.
 
  The picture -' on the button seems to indicate that somebody was
  thinking of this possibility at some point of time, but it does not
  work for me neither in 1.4.0cvs nor 1.3.5cvs.
 
 Works for me for the tabular create dialog in both lyx 13x and 14x.

Well, not here. This is fvwm2 but I doubt this is the reason.

Could this be somehow connected to the problem I had with Return in
the minibuffer lately?

What should I do to debug this?

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
Andre Poenitz wrote:
  Is there a possibility to invoke the OK button in dialogs like
  Insert-Tabular with the Return key?
 
 Yes.
 
  The picture -' on the button seems to indicate that somebody was
  thinking of this possibility at some point of time, but it does
  not work for me neither in 1.4.0cvs nor 1.3.5cvs.
 
 Works for me for the tabular create dialog in both lyx 13x and
 14x.
 
 Well, not here. This is fvwm2 but I doubt this is the reason.
 
 Could this be somehow connected to the problem I had with Return
 in the minibuffer lately?
 
 What should I do to debug this?

Ok, you asked for this...

This stuff is handled by xforms. Grab the xforms source

http://savannah.nongnu.org/cvs/?group=xforms

The shortcuts are handled in lib/forms.c, here:

static void
fl_keyboard(FL_FORM * form, int key, FL_Coord x, FL_Coord y, void 
*xev)
{
FL_OBJECT *obj, *obj1, *special;

/* always check  shortcut first */
if (fl_do_shortcut(form, key, x, y, xev))
return;

I guess that a few print statements in do_shortcut will reveal more...

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread John Levon
On Wed, Apr 07, 2004 at 04:57:55PM +0100, Angus Leeming wrote:

  Works for me for the tabular create dialog in both lyx 13x and
  14x.
  
  Well, not here. This is fvwm2 but I doubt this is the reason.

Sounds to me like Andre is talking about the Tabular edit dialog not
Create, which disallows Return-OK for good reason

regards
john


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
John Levon wrote:
  Works for me for the tabular create dialog in both lyx 13x and
  14x.

  Well, not here. This is fvwm2 but I doubt this is the reason.

 Sounds to me like Andre is talking about the Tabular edit dialog not
 Create, which disallows Return-OK for good reason

Granted. But that doesn't have an Ok button, just a Close.

Incidentally, How is life with you? Did you find your Challenging 
position in systems software development? Can we tempt you back to 
writing code for LyX?

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread John Levon
On Wed, Apr 07, 2004 at 06:00:08PM +0100, Angus Leeming wrote:

 Granted. But that doesn't have an Ok button, just a Close.

True.

 Incidentally, How is life with you? Did you find your Challenging 
 position in systems software development?

Sure did. I'm busy hacking Solaris for Sun.

 Can we tempt you back to writing code for LyX?

I'm waiting for lyx to get close to how it used to be in terms of
stability before even going near it...

regards
john


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
John Levon wrote:
 Incidentally, How is life with you? Did you find your Challenging
 position in systems software development?
 
 Sure did. I'm busy hacking Solaris for Sun.

Interesting. Based here or in the US?

 Can we tempt you back to writing code for LyX?
 
 I'm waiting for lyx to get close to how it used to be in terms of
 stability before even going near it...

Fair enough. It's been a frustrating time, but things *are* getting 
better.

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread John Levon
On Wed, Apr 07, 2004 at 06:09:50PM +0100, Angus Leeming wrote:

 Interesting. Based here or in the US?

Both really :) I'm still in Manchester but practically everybody I work
with lives in California.

 Fair enough. It's been a frustrating time, but things *are* getting 
 better.

That's good to hear. I look forward to trying to work out how lyx works
all over again :)

Change tracking is unfortunately badly broken for quite some time, it
would be a shame if this wasn't brought back into a working state by
release time

regards
john


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
John Levon wrote:
 Fair enough. It's been a frustrating time, but things *are* getting
 better.
 
 That's good to hear. I look forward to trying to work out how lyx
 works all over again :)
 
 Change tracking is unfortunately badly broken for quite some time,
 it would be a shame if this wasn't brought back into a working state
 by release time

Agreed.

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread Andre Poenitz
On Wed, Apr 07, 2004 at 06:00:08PM +0100, Angus Leeming wrote:
 Incidentally, How is life with you? Did you find your Challenging 
 position in systems software development? Can we tempt you back to 
 writing code for LyX?

Or just check that everything is in order with change tracking, for
starters...

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread Andre Poenitz
On Wed, Apr 07, 2004 at 05:39:01PM +0100, John Levon wrote:
 On Wed, Apr 07, 2004 at 04:57:55PM +0100, Angus Leeming wrote:
 
   Works for me for the tabular create dialog in both lyx 13x and
   14x.
   
   Well, not here. This is fvwm2 but I doubt this is the reason.
 
 Sounds to me like Andre is talking about the Tabular edit dialog not
 Create, which disallows Return-OK for good reason

No, I am talking about 'Create' with that initial 5x5 choice.

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread Andre Poenitz
On Wed, Apr 07, 2004 at 06:07:24PM +0100, John Levon wrote:
 Change tracking is unfortunately badly broken for quite some time, it
 would be a shame if this wasn't brought back into a working state by
 release time

That'd be indeed a shame. But as all the change tracking code sits
around in a corner somewhere it 'only' takes someone who knows how it
used to work to cobble it together...

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread John Levon
On Wed, Apr 07, 2004 at 10:16:48PM +0200, Andre Poenitz wrote:

 That'd be indeed a shame. But as all the change tracking code sits
 around in a corner somewhere it 'only' takes someone who knows how it
 used to work to cobble it together...

Last I looked, fixing it would require some non-trivial core changes I'm
afraid. I forget what it was we needed.

The original code had some pretty ugly hooks already...

regards
john


Re: OK button in xforms dalog

2004-04-07 Thread Alfredo Braunstein
John Levon wrote:

 On Wed, Apr 07, 2004 at 10:16:48PM +0200, Andre Poenitz wrote:
 
 That'd be indeed a shame. But as all the change tracking code sits
 around in a corner somewhere it 'only' takes someone who knows how it
 used to work to cobble it together...
 
 Last I looked, fixing it would require some non-trivial core changes I'm
 afraid. I forget what it was we needed.

IIRC, there were several problems with DEPM and with tracking of
breaking/merging of paragraphs (but you fixed some of these by just not
tracking the breaking/merging)

 The original code had some pretty ugly hooks already...

But it is a good feature nevertheless.

Btw, last time I've looked at it (when I've made the changes to lyx::find),
it wasn't unusable.

Alfredo




OK button in xforms dalog

2004-04-07 Thread Andre Poenitz

Is there a possibility to invoke the OK button in dialogs like
Insert->Tabular with the  key?

The picture <-' on the button seems to indicate that somebody was
thinking of this possibility at some point of time, but it does not
work for me neither in 1.4.0cvs nor 1.3.5cvs.

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
Andre Poenitz wrote:
> Is there a possibility to invoke the OK button in dialogs like
> Insert->Tabular with the  key?

Yes.

> The picture <-' on the button seems to indicate that somebody was
> thinking of this possibility at some point of time, but it does not
> work for me neither in 1.4.0cvs nor 1.3.5cvs.

Works for me for the "tabular create" dialog in both lyx 13x and 14x.

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread Andre Poenitz
On Wed, Apr 07, 2004 at 02:35:30PM +0100, Angus Leeming wrote:
> Andre Poenitz wrote:
> > Is there a possibility to invoke the OK button in dialogs like
> > Insert->Tabular with the  key?
> 
> Yes.
> 
> > The picture <-' on the button seems to indicate that somebody was
> > thinking of this possibility at some point of time, but it does not
> > work for me neither in 1.4.0cvs nor 1.3.5cvs.
> 
> Works for me for the "tabular create" dialog in both lyx 13x and 14x.

Well, not here. This is fvwm2 but I doubt this is the reason.

Could this be somehow connected to the problem I had with  in
the minibuffer lately?

What should I do to debug this?

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
Andre Poenitz wrote:
>> > Is there a possibility to invoke the OK button in dialogs like
>> > Insert->Tabular with the  key?
>> 
>> Yes.
>> 
>> > The picture <-' on the button seems to indicate that somebody was
>> > thinking of this possibility at some point of time, but it does
>> > not work for me neither in 1.4.0cvs nor 1.3.5cvs.
>> 
>> Works for me for the "tabular create" dialog in both lyx 13x and
>> 14x.
> 
> Well, not here. This is fvwm2 but I doubt this is the reason.
> 
> Could this be somehow connected to the problem I had with 
> in the minibuffer lately?
> 
> What should I do to debug this?

Ok, you asked for this...

This stuff is handled by xforms. Grab the xforms source

http://savannah.nongnu.org/cvs/?group=xforms

The shortcuts are handled in lib/forms.c, here:

static void
fl_keyboard(FL_FORM * form, int key, FL_Coord x, FL_Coord y, void 
*xev)
{
FL_OBJECT *obj, *obj1, *special;

/* always check  shortcut first */
if (fl_do_shortcut(form, key, x, y, xev))
return;

I guess that a few print statements in do_shortcut will reveal more...

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread John Levon
On Wed, Apr 07, 2004 at 04:57:55PM +0100, Angus Leeming wrote:

> >> Works for me for the "tabular create" dialog in both lyx 13x and
> >> 14x.
> > 
> > Well, not here. This is fvwm2 but I doubt this is the reason.

Sounds to me like Andre is talking about the Tabular edit dialog not
Create, which disallows Return->OK for good reason

regards
john


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
John Levon wrote:
>> >> Works for me for the "tabular create" dialog in both lyx 13x and
>> >> 14x.

>> > Well, not here. This is fvwm2 but I doubt this is the reason.

> Sounds to me like Andre is talking about the Tabular edit dialog not
> Create, which disallows Return->OK for good reason

Granted. But that doesn't have an "Ok" button, just a "Close".

Incidentally, How is life with you? Did you find your "Challenging 
position in systems software development"? Can we tempt you back to 
writing code for LyX?

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread John Levon
On Wed, Apr 07, 2004 at 06:00:08PM +0100, Angus Leeming wrote:

> Granted. But that doesn't have an "Ok" button, just a "Close".

True.

> Incidentally, How is life with you? Did you find your "Challenging 
> position in systems software development"?

Sure did. I'm busy hacking Solaris for Sun.

> Can we tempt you back to writing code for LyX?

I'm waiting for lyx to get close to how it used to be in terms of
stability before even going near it...

regards
john


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
John Levon wrote:
>> Incidentally, How is life with you? Did you find your "Challenging
>> position in systems software development"?
> 
> Sure did. I'm busy hacking Solaris for Sun.

Interesting. Based here or in the US?

>> Can we tempt you back to writing code for LyX?
> 
> I'm waiting for lyx to get close to how it used to be in terms of
> stability before even going near it...

Fair enough. It's been a frustrating time, but things *are* getting 
better.

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread John Levon
On Wed, Apr 07, 2004 at 06:09:50PM +0100, Angus Leeming wrote:

> Interesting. Based here or in the US?

Both really :) I'm still in Manchester but practically everybody I work
with lives in California.

> Fair enough. It's been a frustrating time, but things *are* getting 
> better.

That's good to hear. I look forward to trying to work out how lyx works
all over again :)

Change tracking is unfortunately badly broken for quite some time, it
would be a shame if this wasn't brought back into a working state by
release time

regards
john


Re: OK button in xforms dalog

2004-04-07 Thread Angus Leeming
John Levon wrote:
>> Fair enough. It's been a frustrating time, but things *are* getting
>> better.
> 
> That's good to hear. I look forward to trying to work out how lyx
> works all over again :)
> 
> Change tracking is unfortunately badly broken for quite some time,
> it would be a shame if this wasn't brought back into a working state
> by release time

Agreed.

-- 
Angus



Re: OK button in xforms dalog

2004-04-07 Thread Andre Poenitz
On Wed, Apr 07, 2004 at 06:00:08PM +0100, Angus Leeming wrote:
> Incidentally, How is life with you? Did you find your "Challenging 
> position in systems software development"? Can we tempt you back to 
> writing code for LyX?

Or just check that everything is in order with change tracking, for
starters...

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread Andre Poenitz
On Wed, Apr 07, 2004 at 05:39:01PM +0100, John Levon wrote:
> On Wed, Apr 07, 2004 at 04:57:55PM +0100, Angus Leeming wrote:
> 
> > >> Works for me for the "tabular create" dialog in both lyx 13x and
> > >> 14x.
> > > 
> > > Well, not here. This is fvwm2 but I doubt this is the reason.
> 
> Sounds to me like Andre is talking about the Tabular edit dialog not
> Create, which disallows Return->OK for good reason

No, I am talking about 'Create' with that initial 5x5 choice.

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread Andre Poenitz
On Wed, Apr 07, 2004 at 06:07:24PM +0100, John Levon wrote:
> Change tracking is unfortunately badly broken for quite some time, it
> would be a shame if this wasn't brought back into a working state by
> release time

That'd be indeed a shame. But as all the change tracking code sits
around in a corner somewhere it 'only' takes someone who knows how it
used to work to cobble it together...

Andre'


Re: OK button in xforms dalog

2004-04-07 Thread John Levon
On Wed, Apr 07, 2004 at 10:16:48PM +0200, Andre Poenitz wrote:

> That'd be indeed a shame. But as all the change tracking code sits
> around in a corner somewhere it 'only' takes someone who knows how it
> used to work to cobble it together...

Last I looked, fixing it would require some non-trivial core changes I'm
afraid. I forget what it was we needed.

The original code had some pretty ugly hooks already...

regards
john


Re: OK button in xforms dalog

2004-04-07 Thread Alfredo Braunstein
John Levon wrote:

> On Wed, Apr 07, 2004 at 10:16:48PM +0200, Andre Poenitz wrote:
> 
>> That'd be indeed a shame. But as all the change tracking code sits
>> around in a corner somewhere it 'only' takes someone who knows how it
>> used to work to cobble it together...
> 
> Last I looked, fixing it would require some non-trivial core changes I'm
> afraid. I forget what it was we needed.

IIRC, there were several problems with DEPM and with tracking of
breaking/merging of paragraphs (but you fixed some of these by just "not
tracking" the breaking/merging)

> The original code had some pretty ugly hooks already...

But it is a good feature nevertheless.

Btw, last time I've looked at it (when I've made the changes to lyx::find),
it wasn't unusable.

Alfredo